#hangar-dev | PaperMC | Page 14

pallid yoke Mar 28, 2021, 4:03 PM

#

its moved back to that others can take a look?

random badger Mar 28, 2021, 4:03 PM

#

but that's not what it sounds like, it would be "put back into queue" then

#

not remove from queue

pallid yoke Mar 28, 2021, 4:03 PM

#

idk, I would still save to nuke it

random badger Mar 28, 2021, 4:03 PM

#

remove from queue sounds like "its unreviewed, and no one has to review it, so hide it from the reviewers"

#

BACKLOG isn't the right name for that tho

pallid yoke Mar 28, 2021, 4:05 PM

#

so like a, we cant review this?

#

or we dont ever want to review this?

random badger Mar 28, 2021, 4:05 PM

#

I think the second one

#

maybe not "not ever", but its the lowest possible priority

pallid yoke Mar 28, 2021, 4:06 PM

#

idk how thats different to approve partial, its also a "hey, this is prolly fine, but use at your own risk cause smth is meh"

#

I dont think we ever should postpone a review like that

random badger Mar 28, 2021, 4:06 PM

#

ok, then we can get rid of it

pallid yoke Mar 28, 2021, 5:53 PM

#

user action log has a modal to view page content, however, its not rendered, we wanna render that, right?

random badger Mar 28, 2021, 6:17 PM

#

yeah, why not

pallid yoke Mar 28, 2021, 6:18 PM

#

https://i.imgur.com/XgcjmtO.png

Imgur

#

perfect

#

😄

#

https://i.imgur.com/afn9VTF.png

Imgur

#

rendering was ez

sly mason Mar 28, 2021, 6:18 PM

#

so was ur mum

random badger Mar 28, 2021, 6:21 PM

#

yeah, the Markdown component is nice

pallid yoke Mar 28, 2021, 6:21 PM

#

coool

#

the colors are hardcoded

random badger Mar 28, 2021, 6:21 PM

#

Hey mini, you are in the vuetify discord right? You wanna take a look at this issue? #340215499398840331 message

#

vuetify's text-end class isn't working

pallid yoke Mar 28, 2021, 6:22 PM

#

sure, lemme finish this

random badger Mar 28, 2021, 6:22 PM

#

cool cool

#

on a kinda related note, do we need to worry about RTL languages ever?

#

cause the solution to the problem is to add dir="ltr" to the root html element

pallid yoke Mar 28, 2021, 6:36 PM

#

nah

#

lets just not 😄

random badger Mar 28, 2021, 6:36 PM

#

we have something that changes

#

text-align: end

to

[dir="ltr"] .blah {
  text-align: right;
}
[dir="rtl"] .blah {
  text-align: left;
}

#

so the text-end class wasn't working, cause [dir="ltr"] doesnt match anything

random badger Mar 28, 2021, 6:52 PM

#

there is a flag for pinning when you install right?

#

I need to remember to use that

#

--exact

pallid yoke Mar 28, 2021, 6:53 PM

#

dw, ill never rememver that

random badger Mar 28, 2021, 6:53 PM

#

is there a yarn configuration where we can set that per-directory?

pallid yoke Mar 28, 2021, 6:53 PM

#

thats why we have bots 😄

random badger Mar 28, 2021, 6:55 PM

#

looks like there might be

pallid yoke Mar 28, 2021, 6:56 PM

#

user action log still uses old stuff in backend, because I wrote it before you merged the branch, and its missing UI stuff for filtering

#

I dont know how to best do the filtering, do we wanna do the same like ore?

#

the color stuff here, you can click to filter

#

https://i.imgur.com/39sJsjd.png

Imgur

random badger Mar 28, 2021, 6:56 PM

#

yeah, the log page is pretty complicated

#

I guess we can start there and see

pallid yoke Mar 28, 2021, 6:58 PM

#

the marker look so ugley, I really wanna find a better way

#

thats npmrc, does yarn respect that?

random badger Mar 28, 2021, 7:00 PM

#

yep

#

tested it

pallid yoke Mar 28, 2021, 7:00 PM

#

nice

random badger Mar 28, 2021, 7:02 PM

#

speaking of markdown... we need to include the admonition css/js on pages I think

pallid yoke Mar 28, 2021, 7:02 PM

#

oh

#

maybe we can do a better way than we did in hold frontend....

random badger Mar 28, 2021, 7:03 PM

#

yeah, I mean cant we just create a css file, and import in the Markdown component

#

idk about js

pallid yoke Mar 28, 2021, 7:03 PM

#

same

#

not sure about executing time for the events tho and if it likes running on server

random badger Mar 28, 2021, 7:03 PM

#

maybe can just throw it in created() or smth

pallid yoke Mar 28, 2021, 7:04 PM

#

but yeah, I agree, we should just copy it this time

random badger Mar 28, 2021, 7:04 PM

#

the markdown rendering isn't done on the server anyways

pallid yoke Mar 28, 2021, 7:04 PM

#

not do the weird serving via the backend

random badger Mar 28, 2021, 7:04 PM

#

actually is it? on first page load, is the markdown rendering done on the server?

pallid yoke Mar 28, 2021, 7:04 PM

#

I hope it is

random badger Mar 28, 2021, 7:04 PM

#

yeah, it is ok. its in the fetch hook

#

which is blocking on first page load

#

isn't blocking on route changing

pallid yoke Mar 28, 2021, 7:05 PM

#

https://i.imgur.com/Ve3SiOF.png

Imgur

#

imma go scroll back in this channel to where we spoke about swagger for accepted filters and stuff and look at that stuff

random badger Mar 28, 2021, 7:06 PM

#

oh yeah, to get those things documented

pallid yoke Mar 28, 2021, 7:22 PM

#

that was easier than I thought

random badger Mar 28, 2021, 7:23 PM

#

oh sweet

pallid yoke Mar 28, 2021, 7:24 PM

#

I mean

#

idk if its proper

#

but it works?

#

https://i.imgur.com/p5LJhFM.png

Imgur

#

https://i.imgur.com/rArP6zb.png

Imgur

random badger Mar 28, 2021, 7:24 PM

#

I guess that doesn't say what the sort query key is

#

sortBy or whatever

pallid yoke Mar 28, 2021, 7:25 PM

#

lemme try adding it as a param

random badger Mar 28, 2021, 7:25 PM

#

I was thinking... we could make the sorters an enum that implement an interface

#

could then grab more info from the enums that way, idk

#

but like a Description annotation for the filters would be nice, since those are a tad more complicated than the sorters

pallid yoke Mar 28, 2021, 7:35 PM

#

params are harder https://i.imgur.com/sUdTuL7.png

Imgur

#

idk how this example stuff works, lol

pallid yoke Mar 28, 2021, 8:02 PM

#

yeah I can't get the example stuff to work

random badger Mar 28, 2021, 8:12 PM

#

so what exactly is happening w/your domain?

#

you can't get it back right away?

pallid yoke Mar 28, 2021, 8:12 PM

#

need to wait a week

#

before its deleted

#

else they charge me 150 euro or smth

random badger Mar 28, 2021, 8:13 PM

#

ya, not worth that for sure

pallid yoke Mar 28, 2021, 8:14 PM

#

120 euro actually, plus the price of the domain obviously

#

should be on the 30th

ivory ingot Mar 28, 2021, 8:20 PM

#

Oh that's the reason for the nexus as well. 😄

pallid yoke Mar 28, 2021, 8:26 PM

#

HA!

#

got a dropdown

#

https://i.imgur.com/78MlASs.png

Imgur

#

.query(q -> q.style(ParameterStyle.SIMPLE).model(m -> m.scalarModel(ScalarType.STRING)).enumerationFacet(e -> e.allowedValues(Arrays.asList(sorters.get().value())))).build());

#

isnt that obvious?

#

time to never look at any that shit again

random badger Mar 28, 2021, 8:31 PM

#

Looks 👍

pallid yoke Mar 28, 2021, 8:44 PM

#

layout wise, only admin approvals projects and admin activities user is missing

#

oh and discuss

#

103 todos to solve overall, that doesnt sound too bad anymore 😄

#

@deft drift you now happy with the footer?! https://i.imgur.com/iS0hArP.png

Imgur

sly mason Mar 28, 2021, 9:03 PM

#

no

pallid yoke Mar 28, 2021, 9:06 PM

#

heh, remembered this was a thing and ran the thingy again

#

https://github.com/PaperMC/Hangar/issues/335

GitHub

ToDo List · Issue #335 · PaperMC/Hangar

Open ToDos 'test' in build.yml#9 'once nuxt is merged, change this back' in build.yml#13 'fix tests' in build.yml#42 's can be found in the R...

random badger Mar 28, 2021, 9:07 PM

#

what was wrong with the footer (besides it being WAY to big imo)

pallid yoke Mar 28, 2021, 9:08 PM

#

simple complained about the alignment the other day

random badger Mar 28, 2021, 9:08 PM

#

oh yeah, the labels above the buttons

pallid yoke Mar 28, 2021, 9:08 PM

#

and it doesnt really matter if its big or not since its hidden most of the time anyways

random badger Mar 28, 2021, 9:09 PM

#

I think I had it sticky before which was worse

pallid yoke Mar 28, 2021, 9:09 PM

#

oh yeah thats horrible, lol

#

https://i.imgur.com/Y0dF9XX.png

Imgur

#

this is my companies footer 😄

random badger Mar 28, 2021, 9:10 PM

#

Sitemap is Sitemap in german?

pallid yoke Mar 28, 2021, 9:10 PM

#

we just dont have a word for it

sly mason Mar 28, 2021, 9:11 PM

#

u did a bad job

modest bisonBOT Mar 28, 2021, 9:11 PM

#

Many Internet words don't have a german counterpart which is why english words are used

random badger Mar 28, 2021, 9:11 PM

#

does the LoggedActionViewModel need to be redone?

#

I think it accomplishes its job well

#

(except that a bunch of userId needs to be changed to the nullable long)

pallid yoke Mar 28, 2021, 9:12 PM

#

not sure it does, I just copied the old one and wasn't sure if it still meets our standards

#

also, the footer gets really bad on mobile https://i.imgur.com/43N1YGd.png

Imgur

random badger Mar 28, 2021, 9:21 PM

#

you got any other log actions to add other than these?
https://github.com/PaperMC/Hangar/issues/383

GitHub

Additional log actions · Issue #383 · PaperMC/Hangar

Channels creation editing deletion Versions visibility changes

pallid yoke Mar 28, 2021, 9:22 PM

#

lemme see what exists

#

theres PROJECT_MEMBER_REMOVED but not addition?

#

oooh you added that already

random badger Mar 28, 2021, 9:24 PM

#

yeah, I just noticed that

#

its because addition was covered by settings change before

#

but now its not

pallid yoke Mar 28, 2021, 9:24 PM

#

only thing I could think of is invites

#

like we have member added and removed, is that called when an invite is created?

random badger Mar 28, 2021, 9:25 PM

#

well right now, they aren't

#

even the org member actions are being logged atm

#

it looks like the org members are logged on invite

#

that could probably be split up, invite, accept, decline

#

dont need one for marking notifications as read right?

pallid yoke Mar 28, 2021, 9:27 PM

#

nah thats overkill

#

https://github.com/PaperMC/Hangar/issues/124

GitHub

Version Reviews - add link back to version · Issue #124 · PaperMC/H...

On the version reviews page, there isn't a link back to the version or project page. There probably should be for ease of use.

#

why did you reopen this?

random badger Mar 28, 2021, 9:29 PM

#

cause its missing again

pallid yoke Mar 28, 2021, 9:29 PM

#

I think we have links to go to wherever

#

https://i.imgur.com/8uQNcUh.png

Imgur

random badger Mar 28, 2021, 9:30 PM

#

does clicking on the Paper tab go back to the main version screen?

pallid yoke Mar 28, 2021, 9:30 PM

#

clicking paper gets you back to the version page

random badger Mar 28, 2021, 9:30 PM

#

oh it does, ok

#

then should be all good I guess

#

https://github.com/PaperMC/Hangar/issues/383
k, I updated it with member actions

GitHub

Additional log actions · Issue #383 · PaperMC/Hangar

Channels creation editing deletion Versions visibility changes

gusty birch Mar 29, 2021, 2:47 AM

#

coommits

random badger Mar 29, 2021, 7:12 AM

#

that was a thiccc commit

leaden lily Mar 29, 2021, 7:20 AM

#

Oml

pallid yoke Mar 29, 2021, 7:20 AM

#

Looks good

#

Only thing I saw was that since you moved the descriptions to i18n, we shouldn't need them in the backend anymore, right?

random badger Mar 29, 2021, 7:21 AM

#

I got rid of them?

#

Except for the ones still being used by old stuff

leaden lily Mar 29, 2021, 7:21 AM

#

Why does actions always fail now?

random badger Mar 29, 2021, 7:21 AM

#

Mini’s domain

pallid yoke Mar 29, 2021, 7:21 AM

#

Oh then I looked wrong

#

Am still in bed ^^

leaden lily Mar 29, 2021, 7:21 AM

#

Ahh

pallid yoke Mar 29, 2021, 7:21 AM

#

The action fails because it can't deploy

random badger Mar 29, 2021, 7:22 AM

#

I have like 30 emails about failed to deploy

#

Also, updated https://github.com/PaperMC/Hangar/issues/383

pallid yoke Mar 29, 2021, 7:25 AM

#

I have long disabled actions emails

#

Since you get a github notifications anyways

#

One thing I thought about in bed yesterday: since we have this fantastic audit log, is it worth exposing that to org owners?

#

So that they can see the changes to org stuff and org projects by org members?

sly mason Mar 29, 2021, 7:27 AM

#

I'd imagine so

#

Like, leaders of the org may wanna know wtf people are doing

#

who flipped some thing

#

Seems beter than us having to run around and look if something happens

pallid yoke Mar 29, 2021, 7:30 AM

#

Just need to look that we don't expose stuff they shouldn't know

#

Like review stuff

random badger Mar 29, 2021, 7:31 AM

#

Oh also, should be able to follow orgs

#

And users

#

Like you can in projects

pallid yoke Mar 29, 2021, 7:33 AM

#

Yeah

#

Heh, apperently I missed the start of a vuex training/qualification

#

A apprentice of mine called me half an hour ago but my phone was still in sleep 😂

#

Ah apparently it's about the composition api, so not as boring

pallid yoke Mar 29, 2021, 8:48 AM

#

Thanks for the issues

leaden lily Mar 29, 2021, 3:12 PM

#

So for nuxt rewrite to be merged, the nuxt issue just needs to have everything checked off? It looks to be getting closer.

random badger Mar 29, 2021, 3:17 PM

#

I don’t think I’ve updated the nuxt issue ever. So idk

#

We could just merge it now tbh, and move master to something else, idk what’s preferable

#

It’s almost a feature complete rewrite

pallid yoke Mar 29, 2021, 3:23 PM

#

I mean, considering staging is broken anyways 😂

#

I keep the nuxt issue updated i guess

leaden lily Mar 29, 2021, 3:24 PM

#

Aha. I got a local instance setup finally.

random badger Mar 29, 2021, 3:24 PM

#

K, I updated the issue a bunch

leaden lily Mar 29, 2021, 3:25 PM

#

Awesome!

#

Whelp, now I can at least stay up-to-date locally and try to pitch in where I can.

#

Has any work been done on https://github.com/PaperMC/Hangar/issues/382? Are we planning to use what is built in with nuxt, use a nuxt addon, etc?

pallid yoke Mar 29, 2021, 3:39 PM

#

Nuxt uses vue meta, right?

#

If so that's fine

#

We already set the title for some things I think

#

But yeah, bunch of seo stuff that should be straight forward to do

#

Also like structured data for a bunch of stuff

#

Like breadcrumbs

leaden lily Mar 29, 2021, 3:44 PM

#

breadcrumbs?

#

Hmm. HangarAuth is failing to install with docker. https://paste.gg/p/anonymous/b58e049fb7964cd99d1f0cadc496a8e3

random badger Mar 29, 2021, 3:47 PM

#

Do you have HangarAuth on your machine?

leaden lily Mar 29, 2021, 3:48 PM

#

What, docker?

pallid yoke Mar 29, 2021, 3:49 PM

#

Or just don't use hangar auth locally 😂

leaden lily Mar 29, 2021, 3:49 PM

#

I have Hangar and HangarAuth as siblings and then I went into Hangar/docker and did docker-compose up -d

random badger Mar 29, 2021, 3:49 PM

#

Hmm

leaden lily Mar 29, 2021, 3:49 PM

#

How do I do a fake user then?

pallid yoke Mar 29, 2021, 3:49 PM

#

Breadcrumbs structured data are a way to format links in google nicely

leaden lily Mar 29, 2021, 3:49 PM

#

I wanted to test creating a project in my local instance.

random badger Mar 29, 2021, 3:53 PM

#

hmmm when I startup my local instance, it def installs from that requirements file

#

but I dont get that error

leaden lily Mar 29, 2021, 3:54 PM

#

Oh wait weird. I just restarted the docker container for regular Hangar and it says I'm signed in now.

random badger Mar 29, 2021, 3:55 PM

#

I mean, is auth running? check :8000

leaden lily Mar 29, 2021, 3:55 PM

#

Nope

random badger Mar 29, 2021, 3:55 PM

#

I'm guessing you are signed in as the fake user then

#

which if you started it via docker, shouldnt be possible

leaden lily Mar 29, 2021, 3:57 PM

#

I'm so confused then.

#

This jar scanning stuff on upload is so cool!

pallid yoke Mar 29, 2021, 4:02 PM

#

Wait till it becomes actually cool and scans for force OP and stuff ^^

leaden lily Mar 29, 2021, 4:03 PM

#

What is preventing me from clicking the create button when I'm trying to upload the jar?

random badger Mar 29, 2021, 4:03 PM

#

need a description?

#

I'd have to see an image of the screen

leaden lily Mar 29, 2021, 4:04 PM

#

Oh nvm it works when I use a valid plugin. I tried a Jobs jar and Hangar didn't like that 😛

random badger Mar 29, 2021, 4:06 PM

#

so I get that error if I docker-compose build --no-cache

#

I dont recall ever changing any requirements file tho

#

so idk when that started

pallid yoke Mar 29, 2021, 4:06 PM

#

Well, if python packages aren't locked or smth

#

Still wanna just throw all of that shit away

leaden lily Mar 29, 2021, 4:08 PM

#

What's the diff between delete and hard delete?

random badger Mar 29, 2021, 4:09 PM

#

delete is available to the author

#

but doesn't actually delete it

#

just sorta hides it

leaden lily Mar 29, 2021, 4:09 PM

#

Ahh. I guess that functionality isn't implemented yet.

random badger Mar 29, 2021, 4:09 PM

#

no, none of the delete's are in

#

just delete the db row

pallid yoke Mar 29, 2021, 4:12 PM

#

(soft)delete is just a visibility

#

Hard delete is removing properly, but that's mod only

leaden lily Mar 29, 2021, 4:14 PM

#

Lol, I logged into the postgresql system via command line and the hangar database doesn't even exist. Let me keep digging.

pallid yoke Mar 29, 2021, 4:14 PM

#

Schema hangar

#

Or wait

#

Idk

leaden lily Mar 29, 2021, 4:15 PM

#

Referring to the docker information, it's just localhost on 5432 with user and pass as hangar, right?

random badger Mar 29, 2021, 4:16 PM

#

ok, fixed that conflicting dependency

leaden lily Mar 29, 2021, 4:17 PM

#

Aha. Found the database.

pallid yoke Mar 29, 2021, 4:17 PM

#

I can recommend IJs database tools

leaden lily Mar 29, 2021, 4:17 PM

#

I forgot those existed. Let me read more on those.

#

Is there an efficient way to test meta tags locally? I've always heard that's a bitch because it's easier to test that in a debug prod.

random badger Mar 29, 2021, 4:18 PM

#

view page source?

pallid yoke Mar 29, 2021, 4:19 PM

#

Yeah

#

There's also the structured data testing tool

leaden lily Mar 29, 2021, 4:19 PM

#

Ooo, what's that?

pallid yoke Mar 29, 2021, 4:19 PM

#

A tool to test structured data? :P

little flintBOT Mar 29, 2021, 4:20 PM

#

Structured Data Testing Tool - Google

https://search.google.com/structured-data/testing-tool
Main menu. Google apps. Structured Data Testing Tool. Structured Data Testing Tool. Sign in. public. NEW TEST. settings. View Search Gallery; Help; Send

random badger Mar 29, 2021, 4:21 PM

#

HangarAuth can't really be all that complicated right?

pallid yoke Mar 29, 2021, 4:21 PM

#

https://developers.google.com/search/docs/guides/search-gallery

Google Developers

Explore the Search Gallery & Rich Results | Search Central

Explore the Search Gallery to learn about specific information you can provide to help your site display in rich results on Google Search.

#

That's the kinda stuff we wanna do with strcutred data

#

No i don't think so jake

#

I wasn't even sure if that's worth to do in nuxt, but prolly is so that styles match

random badger Mar 29, 2021, 4:22 PM

#

yeah, I think it'd be good for the UI to match

#

well, maybe could use some "material" framework

#

ik materialize.css exists

leaden lily Mar 29, 2021, 4:23 PM

#

Damn. Looking at the page source, 24K lines is just the styling.

random badger Mar 29, 2021, 4:23 PM

#

that's the entirety of the vuetify css styling

pallid yoke Mar 29, 2021, 4:23 PM

#

That's debug mode tho

random badger Mar 29, 2021, 4:24 PM

#

cause it puts that in a style tag

#

and ya

leaden lily Mar 29, 2021, 4:24 PM

#

Ahh

pallid yoke Mar 29, 2021, 4:24 PM

#

Staging will come back tomorrow or Wednesday or smth

#

Then you can see the real page size and speed

#

It's sooooooo fast

random badger Mar 29, 2021, 4:24 PM

#

ok Glare, you could be able to build the whole thing w/docker now

#

pull that latest commit from HangarAuth

#

then do docker-compose up -d

leaden lily Mar 29, 2021, 4:27 PM

#

Trying now.

#

Got further at least.

#

The docker_auth container won't start because it's saying no such file or directory on something.

random badger Mar 29, 2021, 4:31 PM

#

does it say where its looking for a file or directory?

#

should be

Projects/
  Hangar/
    docker/docker-compose.yml
  HangarAuth/
    Dockerfile

leaden lily Mar 29, 2021, 4:32 PM

#

Interesting. So when you add in hangar auth, it changes the port that the database is running on it seems because it's not on 5432 anymore but it's on 2345

random badger Mar 29, 2021, 4:32 PM

#

yes

leaden lily Mar 29, 2021, 4:33 PM

#

Gotta update that locally then so that it starts up.

random badger Mar 29, 2021, 4:33 PM

#

wdym?

leaden lily Mar 29, 2021, 4:34 PM

#

Well I couldn't start my local instance anymore because it was looking for a postgresql server on 5432 but it got changed to 2345

random badger Mar 29, 2021, 4:34 PM

#

oh wait, when you are using hangar auth, everything is supposed to be in docker

#

not just auth and database

#

the main app as well

leaden lily Mar 29, 2021, 4:35 PM

#

#

Ahh the literal app

#

That makes sense.

random badger Mar 29, 2021, 4:35 PM

#

yes, that last one is Hangar

#

and it knows the port is 2345

leaden lily Mar 29, 2021, 4:35 PM

#

Makes sense

random badger Mar 29, 2021, 4:35 PM

#

when running Hangar via docker, it uses a different configuration file located at Hangar/docker/hangar/application.yml

#

and the db url is jdbc:postgresql://db:5432/hangar in that one

leaden lily Mar 29, 2021, 4:36 PM

#

That makes sense.

#

Yeah I have it up and running again.

#

Sick.

pallid yoke Mar 29, 2021, 5:51 PM

#

"Validate failed: Migrations have failed validation"

#

rreeee

random badger Mar 29, 2021, 6:14 PM

#

Yeah... sorry

pallid yoke Mar 29, 2021, 6:14 PM

#

its fine I saw it already this morning

random badger Mar 29, 2021, 6:14 PM

#

You can’t really edit types with migrations

#

Like, I wanted to redo that logged_action_type, but you can’t delete existing ones

#

And you can’t drop the type w/o dropping all the tables that use it

pallid yoke Mar 29, 2021, 6:24 PM

#

https://i.imgur.com/GHncVOy.png

Imgur

#

reeeeee

#

urg, I see what you mean

#

ERROR: invalid input value for enum logged_action_type: "version_platform_dependency_changed"

ivory ingot Mar 29, 2021, 6:27 PM

#

#cyclic-dependency

pallid yoke Mar 29, 2021, 6:52 PM

#

uff

#

now I need to try to understand all the securty stuff jake did 😄

#

https://i.imgur.com/RiDdmOI.png

Imgur

#

ayyy

#

works

pallid yoke Mar 29, 2021, 7:13 PM

#

https://i.imgur.com/lCNI9ds.png

Imgur

#

ayy

pallid yoke Mar 29, 2021, 7:47 PM

#

https://i.imgur.com/AgV0p6m.png

Imgur

#

heh

#

down too 100 todos!

#

and like, many of them are "delete this"

#

mmmh, not sure storing the icon in the log was a good idea tbh, apperently its 200kb

#

meh we can worry about it later, and its a really nice feature

random badger Mar 29, 2021, 8:04 PM

#

Are we saving older icons?

#

also, didnt we just do a breaking changes update to husky?

#

smh

pallid yoke Mar 29, 2021, 8:12 PM

#

I just saved older icons, yes

#

Into the user action log

#

As seen by the image above (it's properly scaled now)

random badger Mar 29, 2021, 8:13 PM

#

isn't that gonna make those logs HUGE?

pallid yoke Mar 29, 2021, 8:13 PM

#

As I said, that one image is 200kb ^^

#

Maybe we should give them some uuid and store them on disk instead

#

Yeah I like that, some folder where we have a bunch of images, subdivided into folders with the first two chars, so that file systems don't get angry, and then in the log we just save the random uuid

random badger Mar 30, 2021, 5:25 AM

#

does this log action make sense? version_platform_dependency_changed?

#

you only really ever add, or remove one

#

I guess if you were thinking there should just be one "changed" log type

#

where it lists before, and after

pallid yoke Mar 30, 2021, 5:50 AM

#

Version?

#

But yeah maybe i was too lazy to properly calculate that, not sure

leaden lily Mar 31, 2021, 2:15 PM

#

Okay so after this commit https://github.com/PaperMC/Hangar/commit/c127c55ce87e94533cde575a34b3f369695f2fb2

I tried recreating a new project and uploading a project icon and it's throwing 404s on it not.

http://localhost:3000/api/internal/projects/project/paper/PlaceholderAPI/icon

pallid yoke Mar 31, 2021, 2:31 PM

#

You did restart the backend, right?

#

That url looks fine

#

Can check when am at my pc later

leaden lily Mar 31, 2021, 2:34 PM

#

Yeah I'm fairly sure I did another yarn install

pallid yoke Mar 31, 2021, 2:54 PM

#

Backend, the spring thing, restart that so the new api is there after you pull

leaden lily Mar 31, 2021, 3:54 PM

#

Yeah I think I pulled everything?

#

I can try again.

random badger Mar 31, 2021, 3:57 PM

#

Have to rebuild the backend

#

Ctrl F9 in IntelliJ

wise temple Mar 31, 2021, 5:02 PM

#

how do i get this thing to start properly for development

#

cant get the auth thingy going

random badger Mar 31, 2021, 5:04 PM

#

so I use the auth when I dev, but @pallid yoke doesn't

#

Mini, you start the database w/docker, and then start the spring backend with intellij?

wise temple Mar 31, 2021, 5:09 PM

#

i've got that far

#

trying to sign up is just redirecting me to :8000 still

pallid yoke Mar 31, 2021, 5:09 PM

#

Yep

wise temple Mar 31, 2021, 5:12 PM

#

ok i must be doing something really stupid

#

how do i not use the auth

#

oh nvm i did something

random badger Apr 1, 2021, 2:48 AM

#

ok @wise temple so what isn't working, or doesn't make sense about https://github.com/PaperMC/Hangar#setting-up

wise temple Apr 1, 2021, 6:02 AM

#

I think its just some weirdness when using the builtin user

#

mainly the sign-up button still redirects

random badger Apr 1, 2021, 6:03 AM

#

oh ya dont think that was ever changed

small bobcat Apr 2, 2021, 1:29 AM

#

Hi is chance to add max health for mobs ?

woven ridge Apr 2, 2021, 1:38 AM

#

you already asked this in #paper-help , this channel is not for support

small bobcat Apr 2, 2021, 1:42 AM

#

maybee dev have a method

woven ridge Apr 2, 2021, 1:43 AM

#

as stated, this could easily be done with a plugin. However #hangar-dev isn't about paper development.

narrow verge Apr 2, 2021, 6:39 PM

#

rip hangar?

ivory ingot Apr 2, 2021, 6:41 PM

#

rip domain.

narrow verge Apr 2, 2021, 6:41 PM

#

oh that is indeed a rip

woven ridge Apr 2, 2021, 6:42 PM

#

Domain Status: pendingDelete https://icann.org/epp#pendingDelete
Domain Status: serverHold https://icann.org/epp#serverHold
Domain Status: redemptionPeriod https://icann.org/epp#redemptionPeriod

EPP Status Codes | What Do They Mean, and Why Should I Know? - ICANN

narrow verge Apr 2, 2021, 6:42 PM

#

pain

ivory ingot Apr 2, 2021, 6:45 PM

#

Yeah he wants to get that domain for a small amount of money.

modest bisonBOT Apr 2, 2021, 6:46 PM

#

"small"

narrow verge Apr 2, 2021, 6:50 PM

#

usually it's cheaper to renew it cus there's a fee if you wait

stiff token Apr 2, 2021, 8:08 PM

#

narrow verge usually it's cheaper to renew it cus there's a fee if you wait

Yes, and mini got cited like 150$ for the expired domain and decided to let it go back into the pool and buy it again.

narrow verge Apr 2, 2021, 8:11 PM

#

lol

random badger Apr 3, 2021, 3:38 AM

#

ok, so what is the purpose of the user locking/unlocking?

#

way back when, I thought it was something admins could do to a user, but that doesn't seem to be the way it was setup

random badger Apr 3, 2021, 6:09 AM

#

Also, https://www.baeldung.com/spring-boot-jdbi#using_daos suggests there is a way of using a BeanFactory for tons of DAOs. Might be better than the system we have.

pallid yoke Apr 3, 2021, 7:26 AM

#

Oh yeah hardcoded beans like that will get rid of all the errors and we don't need the generic I guess

#

Isn't user locking like banning?

#

https://github.com/PaperMC/Hangar/commit/4491b5a31fa26ea298731d44c861cb41f6f7e3c0#diff-18da4fba335adad6a06308cbb44285f2fcccc3958618268614d166bea888087bR390

GitHub

notification types · PaperMC/Hangar@4491b5a

closes #405

#

This should use refs, not document get element by id

random badger Apr 3, 2021, 7:34 AM

#

The way locking was setup, is that only the user can lock themselves.

#

So idk what that is

pallid yoke Apr 3, 2021, 7:34 AM

#

Closing your account?

#

Idk

#

Fun fact that button doesn't work on ore

#

Like, sponge ore prod

cursive kraken Apr 3, 2021, 7:44 AM

#

Pssssst

pallid yoke Apr 3, 2021, 7:45 AM

#

Since you here, do you know what the usecase for that button is?

#

Is it like a, I wanna archive my account?

cursive kraken Apr 3, 2021, 7:46 AM

#

Ähm the thing is i don't know either 😄 that button is there since the first version I was not even a part of

#

Let me check something

#

I think you basically lock out yourself from uploading and creating stuff (don't ask me why you would do this)

random badger Apr 3, 2021, 7:53 AM

#

Do we wanna turn it into a thing mods can do?

#

The way I’ve been using the @Unlocked annotation, is on requests that change something

#

So the user can only view stuff, no changing?

pallid yoke Apr 3, 2021, 8:13 AM

#

Yeah so like, "your account has been (temporary) locked by staff, in response to recent actions. You can not modify your account or any projects while your account is locked" or smth

random badger Apr 3, 2021, 6:23 PM

#

Yes, I like that

ocean pagoda Apr 3, 2021, 8:14 PM

#

If the locking is for a longer duration, might make sense to include a link to whatever the appeal process is or at least the rules

random badger Apr 3, 2021, 8:40 PM

#

ok, so what is the purpose of a sitemap? and do we need to have one?

sly mason Apr 3, 2021, 8:42 PM

#

indexing, basically

random badger Apr 3, 2021, 8:42 PM

#

for search engines?

sly mason Apr 3, 2021, 8:42 PM

#

it's mostly there for search engines but can be human readable

pallid yoke Apr 3, 2021, 8:46 PM

#

Site map is very very important

random badger Apr 3, 2021, 8:46 PM

#

ok, can just proxy it from frontend to the existing routes in spring?

pallid yoke Apr 3, 2021, 8:46 PM

#

It's how you tell google what pages you have

#

Doesn't backend have code to generate the sitemap already?

random badger Apr 3, 2021, 8:46 PM

#

yes, that's what I was saying

pallid yoke Apr 3, 2021, 8:47 PM

#

Same with stuff like the robots.txt

random badger Apr 3, 2021, 8:47 PM

#

add a rule to the proxy in nuxt.config.js

#

just like we do with all /api routes

pallid yoke Apr 3, 2021, 8:47 PM

#

Robots.txt is for telling google where the sitemap is and what not to index

random badger Apr 4, 2021, 4:45 AM

#

what about this statusz thing that ore had?

random badger Apr 4, 2021, 5:18 AM

#

also... what are we gonna do about someone with the username login? would match multiple routes

#

or api, or various other places where there could be conflicts

pallid yoke Apr 4, 2021, 8:18 AM

#

We should prolly reserve those?

#

And statusz was some kind of play framework thingy, right?

#

Oh I see it's git infos and stuff

#

No need for that, we can just use the spring boot actuator instead, it has a way to disable git infos

random badger Apr 4, 2021, 8:11 PM

#

mini, it looks like chartjs has a vue library?

#

worth using or nah?

pallid yoke Apr 4, 2021, 8:12 PM

#

I used chartist for the stats page

random badger Apr 4, 2021, 8:13 PM

#

that's what I meant to say https://www.npmjs.com/package/vue-chartist

pallid yoke Apr 4, 2021, 8:13 PM

#

does it do anything different to my chart.vue?

random badger Apr 4, 2021, 8:13 PM

#

well I had to add smth to watch the data prop to update the chart when that data changed

pallid yoke Apr 4, 2021, 8:13 PM

#

lemme look at the code

random badger Apr 4, 2021, 8:13 PM

#

so maybe vue-chartist does that since the data is a prop itself

pallid yoke Apr 4, 2021, 8:14 PM

#

its 150 lines, lol

#

it also looks abandoned, lets just stick with our own impl

random badger Apr 4, 2021, 8:14 PM

#

mmkay

pallid yoke Apr 4, 2021, 8:15 PM

#

the guy is MIA since last summer and not very active generally

#

so lets just take from his code what we need 😄

#

he just adds a watch on the data and calls this.chart.update(this.data, this.options)

random badger Apr 4, 2021, 8:16 PM

#

yeah, that's what I did

pallid yoke Apr 4, 2021, 8:17 PM

#

wat

#

https://i.imgur.com/QW2elAu.png

Imgur

#

I think docker hub is broken

#

Get registry-1.docker.io/v2/: net/http: request canceled (Client.Timeout exceeded while awaiting headers)

#

ah yes

#

https://i.imgur.com/mzXAEZY.png

Imgur

#

they have no clue whats wrong

#

great

#

but in theory deploy should work again now

random badger Apr 4, 2021, 8:52 PM

#

hmm, for some reason one of the numbers doesn't have the white color

#

k, fixed that by just applying a color. weird

#

so I threw the stats sql query in its own file. idk if you had looked at doing that before, but it might make some of the DAOs a little cleaner? but then you have to navigate to the sql file if you want to view the query at the same time... idk what's best

pallid yoke Apr 4, 2021, 9:28 PM

#

IJ is able to understand the line breaks in the annotations nicely for me and syntax highlighting works good

#

Sadly it breaks with string templates

random badger Apr 4, 2021, 9:28 PM

#

the line breaks don't seem to work for me in IJ, like the next line's quotations start before the top line's

#

this is what happens

pallid yoke Apr 4, 2021, 9:30 PM

#

Ah, never noticed that

#

You can also control enter edit language fragment or smth and IJ gives you a nice editor

random badger Apr 4, 2021, 9:30 PM

#

yeah, I always forget that exists, and then remember, and then use it once and forget again

pallid yoke Apr 4, 2021, 9:31 PM

#

Generally I don't care too much where the queries are, the cool thing about having them in code is that you can quickly find them

#

But if we move a few complex queries out to files to make our life easier that's fine too

#

I don't expect us to touch most of the query anyways

main lava Apr 5, 2021, 1:52 AM

#

what is hangar? Im new lol

sly mason Apr 5, 2021, 1:52 AM

#

main lava Apr 5, 2021, 1:53 AM

#

sly mason

So is it like Sponge's Ore? What is the relationship between Sponge and Hangar btw.

sly mason Apr 5, 2021, 1:53 AM

#

Hangar was originally gonna be a fork of Ore, but, was basically rewritten with java

main lava Apr 5, 2021, 1:54 AM

#

oh ok

#

ty

random badger Apr 5, 2021, 2:01 AM

#

well, was rewritten twice essentially

#

once was literally just trying to copy it in java exactly, but now its pretty much being re-written all over again

main lava Apr 5, 2021, 2:04 AM

#

Is Hangar out?

random badger Apr 5, 2021, 2:05 AM

#

nah, still in dev

main lava Apr 5, 2021, 2:05 AM

#

oh ok

pallid yoke Apr 5, 2021, 6:51 AM

#

The health no platform thing most likely just lists all projects without a platform, which would be a bad error

#

Can that even happen on hangar?

random badger Apr 5, 2021, 6:53 AM

#

it shouldn't

#

have to select at least one when uploading a version

#

and you can't remove all from it after

pallid yoke Apr 5, 2021, 6:56 AM

#

We might not need that report then

#

But I think that kinda stuff we will expand on when people actually use and break hangar

random badger Apr 5, 2021, 6:56 AM

#

oh yes, waiting for the big annoying breaks to happen

random badger Apr 5, 2021, 8:20 AM

#

hrm... getting an issue where HangarAuth doesn't seem to save the uploaded organization avatar

#

😡 really wish a better project would just poof into existence for that.

pallid yoke Apr 5, 2021, 8:27 AM

#

Should I work on that today?

#

Or on discourse like i thought about

pallid yoke Apr 5, 2021, 9:20 AM

#

setting up discourse is a pita, lol

#

ahy

#

https://i.imgur.com/9tKqLpE.png

Imgur

#

ok mail doesnt work of course, urg

pallid yoke Apr 5, 2021, 10:07 AM

#

https://i.imgur.com/LilX25F.png

Imgur

pallid yoke Apr 5, 2021, 11:18 AM

#

https://i.imgur.com/FzGjpTO.png

Imgur

#

not too bad

pallid yoke Apr 5, 2021, 3:05 PM

#

Updating service hangar_new_mail (id: fn3fgrcmwpm8ocdrbh1509kzp)
Updating service hangar_new_auth (id: yyva13y3wcgidhhwgwqxa9fhe)
Updating service hangar_new_redis (id: ed6449og9jt89ub5k5wzgxmna)
Updating service hangar_new_frontend (id: na4bfurxw9uudpqsh0hmvys1m)
Updating service hangar_new_backend (id: qa6re6tw2r5zmf9x05fdm35hx)
Updating service hangar_new_db (id: fibnjz43p5k4urly8fh53moof)

#

figured out why deployment wasn't going thru

pallid yoke Apr 5, 2021, 5:03 PM

#

https://i.imgur.com/B3hKlRP.png

Imgur

#

kkeeeek

#

nuxt csp handling is hella sketch

pallid yoke Apr 5, 2021, 6:32 PM

#

https://hangar.benndorf.dev/ works properly now

Hangar | PaperMC

Plugin repository for Paper plugins and more!

mellow pebble Apr 5, 2021, 6:33 PM

#

properly

wary ether Apr 5, 2021, 6:33 PM

#

Whoa

#

This looks pretty good

pallid yoke Apr 5, 2021, 6:34 PM

#

care to send me a browser console log screenshot?

#

cause it does look right for me 😄

#

https://i.imgur.com/juCAbRZ.png

mellow pebble Apr 5, 2021, 6:35 PM

#

No, but activating Javascript does help xD

pallid yoke Apr 5, 2021, 6:35 PM

#

oh really? 😄

#

without JS it still displays fine for me

wary ether Apr 5, 2021, 6:36 PM

#

#

The text looks weird on mobile

pallid yoke Apr 5, 2021, 6:36 PM

#

yeah we havent done any design work, so its obviously not optimized for mobile

ocean pagoda Apr 5, 2021, 6:37 PM

#

honestly it looks pretty good on desktop. its basic, but I like it, it looks clean

pallid yoke Apr 5, 2021, 6:37 PM

#

still looking for desginers btw, lol

#

its literally just the default dark theme of vuetify

woven ridge Apr 5, 2021, 6:38 PM

#

I get the same thing with no scripts

pallid yoke Apr 5, 2021, 6:38 PM

#

yeah you should, its all server rendered

woven ridge Apr 5, 2021, 6:38 PM

#

no I mean this https://shx.gg/cmZQPZ

cmZQPZ.png

ocean pagoda Apr 5, 2021, 6:38 PM

#

Thats how it looks without scripts for me

pallid yoke Apr 5, 2021, 6:38 PM

#

well you block more than just scripts

#

but like, JS is a hard requirement anyways

ocean pagoda Apr 5, 2021, 6:39 PM

#

huh, its just uBlock Origins JS blocking feature

pallid yoke Apr 5, 2021, 6:39 PM

#

sulu also blocks fonts

mellow pebble Apr 5, 2021, 6:40 PM

#

NoScript probably blocks everything script 😄

pallid yoke Apr 5, 2021, 6:40 PM

#

and yes, it will not be perfect, part of the css is loaded with the JS

ocean pagoda Apr 5, 2021, 6:40 PM

#

only blocking fonts at least gives me the images back
But idk, I doubt too many people have JS blocked anyways

pallid yoke Apr 5, 2021, 6:41 PM

#

ore front page without JS 😛

#

https://i.imgur.com/FjGpBgs.png

Imgur

ocean pagoda Apr 5, 2021, 6:42 PM

#

ocean pagoda Thats how it looks without scripts for me

btw, is it that narrow on purpose?

#

its not even using 50% of the screen

pallid yoke Apr 5, 2021, 6:43 PM

#

thats part of design and thus not done 😛

teal smelt Apr 5, 2021, 6:46 PM

#

pallid yoke its literally just the default dark theme of vuetify

Tbh there is nothing wrong with that default theme, looks great. Especially because it is dark xD
I know you'll want customizations, but you don't need to be that completely far from that default, a clean simplistic look that is easy to understand is definitely fitting for this from my opinion (I'm just a user ultimately)

ocean pagoda Apr 5, 2021, 6:46 PM

#

yeah, its not like the vuetify default is bad or anything

pallid yoke Apr 5, 2021, 6:46 PM

#

it looks horrible, the contrast is all over the place, stuff isn't consistent, etc

barren shale Apr 5, 2021, 6:47 PM

#

yeah idk what kind of design lessons you two took pepela

pallid yoke Apr 5, 2021, 6:47 PM

#

making dark themes is especially hard

#

I really like the design sketches bastian did for bstats, I want smth like that 😄

#

https://cdn.discordapp.com/attachments/260708924481601539/823964586683924580/unknown.png

barren shale Apr 5, 2021, 6:48 PM

#

I somehow managed to get hangar (nuxt-frontend) running in 10 minutes btw, compared to the last 5 times it took me at least an hour each BoneZone

ocean pagoda Apr 5, 2021, 6:48 PM

#

barren shale yeah idk what kind of design lessons you two took <:pepela:798950800894066708>

programmers kekw
but idk, looks better than spigot, even tho thats not hard

pallid yoke Apr 5, 2021, 6:48 PM

#

spigot just looks dated, but their theme isn't bad

ocean pagoda Apr 5, 2021, 6:49 PM

#

that orange is just ehh

#

mah eyes

pallid yoke Apr 5, 2021, 6:49 PM

#

the round gradient headers just scream 2010

#

the orange is the CI of spigot tho

modest bisonBOT Apr 5, 2021, 6:49 PM

#

Don't they have paid dark mode?

wary ether Apr 5, 2021, 6:49 PM

#

Yep

pallid yoke Apr 5, 2021, 6:49 PM

#

for paper its the blue for some reason

ocean pagoda Apr 5, 2021, 6:49 PM

#

it is, but it makes the entire website look like a warning cone

pallid yoke Apr 5, 2021, 6:51 PM

#

but we will stick to the plan of first making the software usable, let others use it (and promise not to nuke DB every day), gather feedback on the functionality, while we work on design and policies

teal smelt Apr 5, 2021, 7:09 PM

#

pallid yoke it looks horrible, the contrast is all over the place, stuff isn't consistent, e...

I meant more like the general "clean" look, but yeah, I get it

teal smelt Apr 5, 2021, 7:09 PM

#

barren shale yeah idk what kind of design lessons you two took <:pepela:798950800894066708>

None, and I did not say I did XD

#

Just tryna give some user perspective 😭

barren shale Apr 5, 2021, 7:17 PM

#

that was more of a dev perspective, as it looks ""fine""

#

but definitely not "nice" for the "normal" user

#

that's my contribution for the week, time for CS now
... didn't see the readme branch btw, sorreh; just merge that over if you pull the branch it, tho plz add info on the actual fake-user setting/location (setting up hangar as well was something also throwing over some people afaik, also given it's not necessarily needed) and that the detach -d parameter for the docker-compose command(s) isn't necessary

random badger Apr 5, 2021, 10:05 PM

#

am I going crazy or was the profile image not always square?

#

OH, you changed it from using a v-avatar

#

ok, so the problem with changing organization's avatars... is that its not stored in a docker volume so each restart... it goes away

#

that's great

ivory ingot Apr 5, 2021, 10:25 PM

#

Then extend the path volume mapping to include organization avatars.

random badger Apr 5, 2021, 10:25 PM

#

yeah, I just did, I just didn't realize what was happening before

#

I thought it wasn't saving at all, not realizing it was saving, but then getting "deleted" when I rebuilt

random badger Apr 5, 2021, 10:58 PM

#

@pallid yoke maybe we wanna throw https://vuetifyjs.com/en/components/breadcrumbs/ this for the project header?

#

can be on pages as well

random badger Apr 6, 2021, 3:07 AM

#

so, I'm curious why you went the route of wrapping all the handlermethodargumentresolvers with the pagination resolver instead of writing your own resolver for it?

pallid yoke Apr 6, 2021, 5:42 AM

#

random badger <@!134340832093405184> maybe we wanna throw <https://vuetifyjs.com/en/components...

Sounds good, maybe that already generates the necessary google structured data

pallid yoke Apr 6, 2021, 5:43 AM

#

random badger so, I'm curious why you went the route of wrapping all the handlermethodargument...

I think stuff was a bit weird, at first I only wrapped one

pallid yoke Apr 6, 2021, 5:44 AM

#

random badger OH, you changed it from using a v-avatar

Yeah to fix the absolutely broken error handling that I did on there, and to have the error handling all in one place

#

And well, it's an user avatar essentially, it just doesn't have a link

random badger Apr 6, 2021, 6:30 AM

#

so I changed the way the Pagination object is resolved a bit, so far, everything still works as expected

#

just w/o needing the initializingbean to change the adapters after-the-fact

pallid yoke Apr 6, 2021, 6:33 AM

#

I see

random badger Apr 6, 2021, 6:35 AM

#

just hijacked where the adapter is created, and added our own resolvers up top in it's own afterPropertiesSet https://github.com/PaperMC/Hangar/blob/nuxt-frontend/src/main/java/io/papermc/hangar/config/WebConfig.java#L157

random badger Apr 6, 2021, 8:42 AM

#

we are getting so close... I can feel it

#

big thing-wise, we have all the download stuff, the user activity page, the user admin backend functionality, and api authentication

pallid yoke Apr 6, 2021, 9:22 AM

#

And a bunch of small random stuff everywhere ^^

#

But yeah, everything is coming together nicely

random badger Apr 6, 2021, 8:32 PM

#

Ah yes, got api key authentication working. Soooo nice to have 1 auth system instead of having two completely separate ones.

#

Oh, and one other big thing we need to figure out, is the api for creating versions.

#

Creating versions is probably the most complex thing users can do.

pallid yoke Apr 6, 2021, 8:56 PM

#

Yeeeaah

#

Did ore handle that nicely?

#

Maybe I can look at stuff tomorrow

#

First day of the week is always a mess for me (yesterday was holiday)

random badger Apr 6, 2021, 9:02 PM

#

well ore had a solution... but we added a TON more stuff

#

all the dependency/platform version stuff

#

like, I had earlier thrown around the idea of having people put this stuff in their respective .yml/.json files so it could be read on a file upload

#

cause with api, you need someway to convey all that information so you create the file with one request

random badger Apr 7, 2021, 4:34 AM

#

there been a couple times now... where I swear one of the perm voters isn't working correctly, I add some debugging statements, and then it works suddenly.. as if just having it reload the file was enough to fix it.

#

that's happened many times with the custom HangarAnnotationIntrospector to perm-lock jackson serializing certain fields

#

🤞 I'm either imagining this... or it is only smth that happens in the dev environment

sly mason Apr 7, 2021, 4:37 AM

#

itt: Machine is a crazy person

pallid yoke Apr 7, 2021, 7:06 AM

#

random badger like, I had earlier thrown around the idea of having people put this stuff in th...

Oh yeah, I remember that, that might be the best solution really

#

Can also use that data to expand the current scanning then

pallid yoke Apr 7, 2021, 4:09 PM

#

mmmmh, why are the settings in two cards?

#

I mean, it makes sense splitting up stuff a bit

#

lemme see if I can make it use tabs

random badger Apr 7, 2021, 5:25 PM

#

You talking about project settings?

pallid yoke Apr 7, 2021, 5:27 PM

#

yeah, I used vertical tabs now, really liking that

#

categorization obviously up for debate

#

https://streamable.com/si9ymr

Streamable

MGgggGP74Q.mp4

▶ Play video

rare pike Apr 7, 2021, 5:48 PM

#

I can see the page changing size each time you choose a different tab being pretty annoying... maybe a fixed height would be nice?

random badger Apr 7, 2021, 6:38 PM

#

hmm, what would be the way to accomplish that?

pallid yoke Apr 7, 2021, 6:50 PM

#

setting a min high or smth

#

ufff

#

I think am done with the settings refactor and donation stuff now

#

that was more work than expected

#

but hey, two todos removed

random badger Apr 7, 2021, 8:05 PM

#

mini, what about tying the settings tabs to a #id ?

#

so you can link directly to a tab, and refreshing the page keeps you on the same tab?

pallid yoke Apr 7, 2021, 8:12 PM

#

Oh yeah I thought about that and then got distracted

#

I mean, could go all out can do it per setting and highlight it, for hot linking

#

But that might be overkill

random badger Apr 7, 2021, 8:14 PM

#

I think the tabs would be enough tbh

pallid yoke Apr 7, 2021, 8:14 PM

#

Yeah

random badger Apr 7, 2021, 8:15 PM

#

Getting really annoyed again with this hot reloading making the page error...

#

Is there a way to force it to do a full page refresh every time?

#

That might just be better

pallid yoke Apr 7, 2021, 8:16 PM

#

The role stuff?

#

I mean, could catch the role error and nuxt refresh?

random badger Apr 7, 2021, 8:17 PM

#

Well not just on that page.

#

I think the issue arises from the fact that the field is undefined on hot reloads before asyncData is run.

#

But that would never happen otherwise because asyncData would always run before the field is referenced in the template

#

Another error check thingy we should do, is on all the Promise.all, check if the result is undefined and return so the error page actually gets shown instead of a data.whatever is undefined error

pallid yoke Apr 7, 2021, 8:25 PM

#

Yeah

#

We do that in some places

#

I also had a really fun issue where translations weren't resolving, and it got worse with refreshing, only restarting nuxt helped, that was strange

random badger Apr 7, 2021, 8:44 PM

#

ive had a couple crashes while reloading translations where it runs out of memory 🤷‍♂️

pallid yoke Apr 7, 2021, 8:45 PM

#

Nah wasn't a crash, idk

#

Stuff is funky

random badger Apr 7, 2021, 8:45 PM

#

in all likelihood, its just due to the environment, and nuxt build && nuxt start will work just fine

pallid yoke Apr 7, 2021, 8:46 PM

#

Oh yeah, totally

#

Staging runs smooth

random badger Apr 7, 2021, 8:55 PM

#

so.. if we just give them default values no error happens

#

I thought that I tried that before...

#

I was pretty sure I got errors saying the return value of asyncData couldn't be applied to the component because they already existed

#

🤷‍♂️

pallid yoke Apr 7, 2021, 8:57 PM

#

I made bad experience with default values because they didn't were applied when I thought they would be

#

But that was for props I think

#

I was overriding my props with that

random badger Apr 7, 2021, 8:58 PM

#

oh, that might be what I was thinking of as well...

#

well it seems to work, refreshing, hot reloading, navigating to the page.

#

so I guess we do that now where we see it

pallid yoke Apr 7, 2021, 8:58 PM

#

I'll keep it in mind for when I encounter obscure issues ^^

#

But yeah seems fine for now

random badger Apr 7, 2021, 9:28 PM

#

ok, another issue with the dev is that asyncData is run after the created/mounted hooks. which might throw off the logic there

#

that cant be right, right?

leaden lily Apr 7, 2021, 9:57 PM

#

Does the staging branch contain any working API so that I can do some testing on a 3rd party project?

random badger Apr 7, 2021, 9:58 PM

#

as a matter of fact, it does. Now, nothing is finalized ofc.

leaden lily Apr 7, 2021, 9:58 PM

#

What's the new staging URL? It's not updated on the README.

random badger Apr 7, 2021, 9:58 PM

#

https://hangar.benndorf.dev/api

#

those are the api docs

leaden lily Apr 7, 2021, 9:58 PM

#

Oh that's a lovely view

#

Lol

random badger Apr 7, 2021, 9:59 PM

#

the authentication stuff is totally wrong

#

ignore that first bunch of text

leaden lily Apr 7, 2021, 9:59 PM

#

I don't need to do any auth. I am simply going for read-only stuff.

random badger Apr 7, 2021, 9:59 PM

#

yeah, most stuff is public

#

so no auth needed there

leaden lily Apr 7, 2021, 10:00 PM

#

Doesn't look like there's any projects on this staging.

random badger Apr 7, 2021, 10:04 PM

#

hmm, idk what database mini is using, the one I have for it shows a bunch

leaden lily Apr 7, 2021, 10:04 PM

#

random badger Apr 7, 2021, 10:04 PM

#

yeah, last commit should fix that

leaden lily Apr 7, 2021, 10:05 PM

#

Ahh okay, looks like it's in the process of deploying.

#

Is it pretty much the same as Ore's?

random badger Apr 7, 2021, 10:06 PM

#

eh... kinda

#

the models have changed a bit

#

but most of the urls are the same

leaden lily Apr 7, 2021, 10:07 PM

#

Okay awesome, I see a project now.

random badger Apr 7, 2021, 10:07 PM

#

yeah, so the db I have is clearly not the right one 😆

#

you can see all the models at the bottom of the api docs page

leaden lily Apr 7, 2021, 10:10 PM

#

Yeah, okay, awesome. I think I can work with most of this.

#

Getting ready to start on the Hangar addition branch for MCBanners.

random badger Apr 7, 2021, 10:10 PM

#

cool! let us know if you think it's missing something

#

cause im sure it is

#

like, nothing on organizations atm

leaden lily Apr 7, 2021, 10:11 PM

#

Oooo, I didn't even think about that.

#

Is there going to be a reliable way in the API to get the icon of an author / organization / resource?

random badger Apr 7, 2021, 10:13 PM

#

yeah, it was in the public api, then I think I added a todo to move it back... but then I forget why I did in the first place.
currently the route is like /api/internal/projects/project/:author/:slug/icon or smth

#

which is technically public even though internal is in the route

#

but yes, long story short, there will be

leaden lily Apr 7, 2021, 10:13 PM

#

Okay, awesome, because that will be essential for these banners.

#

Looks like ore's is the same way but with Hangar, when you go to the URL, it's actually redirecting to another URL, or at least it is with Mini's.

random badger Apr 7, 2021, 10:14 PM

#

yes, that's how it works

#

url will be standardized for projects/users

leaden lily Apr 7, 2021, 10:16 PM

#

Okay let me do some testing.

random badger Apr 7, 2021, 10:17 PM

#

the users avatar is technically on another host tho. like https://hangar-auth.benndorf.dev/avatar/MiniDigger?size=120x120

#

which itself redirects to papermc.io forums

#

to take advantage of its generating letter avatars for those who dont have them

#

otherwise it wont redirect away from hangar-auth

leaden lily Apr 7, 2021, 10:18 PM

#

So what should I do on my end to make sure that I can always obtain an icon for a project whether it's the default generated or uploaded?

#

Just wait for something to be officially in the API?

random badger Apr 7, 2021, 10:18 PM

#

itll be the same url for both, just one will redirect more than the other

leaden lily Apr 7, 2021, 10:18 PM

#

Ahh

random badger Apr 7, 2021, 10:19 PM

#

like, there could be 2 redirects: a project with no icon uses the author icon and if the author has no icon, itll redirect again to the default generated one

#

or it could be 0 redirects if the project has an icon

leaden lily Apr 7, 2021, 10:34 PM

#

Ahh so Ore's old system used to use IDs. So it looks like I'm going to have to have them put in their user and their project name to turn it into the author / slug.

leaden lily Apr 7, 2021, 10:51 PM

#

Aha. Awesome.

#

#

WIP. I still need to figure out how I can log all the likes / downloads.

random badger Apr 7, 2021, 11:23 PM

#

well, hangar has stars which is kinda similar to likes

white pier Apr 7, 2021, 11:24 PM

#

petition to change stars to tacos

#

🌮

random badger Apr 7, 2021, 11:24 PM

#

so if you are talking about all the likes that user has received on their projects, then you can just query the projects they own

#

I just had tacos like 2 minutes ago actually 😆

white pier Apr 7, 2021, 11:24 PM

#

machine living the good life

random badger Apr 7, 2021, 11:26 PM

#

so good

random badger Apr 8, 2021, 12:01 AM

#

do you think its fine if the donation settings are included in the public api model for a project? It's not private info... I mean you see the email if you try to donate, you see the preset amounts, etc.

random badger Apr 8, 2021, 1:27 AM

#

pallid yoke I'll keep it in mind for when I encounter obscure issues ^^

well it's not really a solution either as I've just discovered. Instead of throwing an error, it just doesn't update the fields from their default state on a hot reload.

#

I cannot seem to replicate in another project the asyncData hook being called after created/mounted

#

so idk what's up

leaden lily Apr 8, 2021, 1:53 AM

#

I can probably make it say stars if it's hangar.

random badger Apr 8, 2021, 1:54 AM

#

btw, saw your question in the nuxt discord... I think i've gotten like 1 answer there for the 30 questions asked 😅

leaden lily Apr 8, 2021, 1:54 AM

#

Tbh, I didn't realize Ore removed V1 so those are just totally broken right now. I think the way to make it work for resources is to have them enter their username and then the resource name because it's not valid by ID anymore.

#

Yeah...

#

It's unfortunate.

#

The main page for mcbanners takes way too long to load and it's the webpack client but idk how to improve that.

random badger Apr 8, 2021, 1:55 AM

#

I haven't tried stack overflow recently, maybe more luck there?

leaden lily Apr 8, 2021, 1:55 AM

#

Oh I think the webpack was from running it as dev.

#

I did make some changes that I was able to push to prod to take it down from 1.7 seconds to like 588 after the first load cause of the cache.

#

But initial load without cache is like 2.21 seconds. Network just says the type is document so Idek what that is.

#

Oh actually it's whatever workbox-core.prod is

#

Ohh it's the PWA I think.

random badger Apr 8, 2021, 2:19 AM

#

ok... the plot thickens. the lifecycle looks like this when a user is logged in.

#

but you don't get that error saying testArr is undefined if you aren't logged in, and asyncData finishes before created is called

#

so something that only happens when the user is logged in is causing this issue

leaden lily Apr 8, 2021, 2:21 AM

#

Hmm

random badger Apr 8, 2021, 2:25 AM

#

ok, narrowed it down to $auth.updateUser(token)

leaden lily Apr 8, 2021, 2:28 AM

#

I think bootstrap-vue in general is hard to load. I've seen Vuetify have a much better load time.

random badger Apr 8, 2021, 2:28 AM

#

I mean, I dont know anything about seo stuff like Mini does, but he seems to think hangar loads crazy fast

leaden lily Apr 8, 2021, 2:30 AM

#

5.52 seconds to load the current staging branch (https://hangar.benndorf.dev/)

random badger Apr 8, 2021, 2:31 AM

#

like I said, idk, might be the host or smth, #hangar-dev message

leaden lily Apr 8, 2021, 2:32 AM

#

The concern will be that you guys get this done and the load time is still what it is, it's going to be hard to navigate this thing

#

If it's a full 4 - 5 seconds for each page change, that will get a tad annoying.

random badger Apr 8, 2021, 2:32 AM

#

is it 4-5 seconds for you?

leaden lily Apr 8, 2021, 2:32 AM

#

Yeah

random badger Apr 8, 2021, 2:33 AM

#

... that is certainly not what I'm seeing

leaden lily Apr 8, 2021, 2:33 AM

#

I can get you a recording.

#

Looks to be better after the content has already loaded on that visit.

random badger Apr 8, 2021, 2:35 AM

#

that doesnt look like 4-5 seconds?

leaden lily Apr 8, 2021, 2:35 AM

#

I'm going off of whatever the network tab says finish is

random badger Apr 8, 2021, 2:36 AM

#

its maybe > 1 second sometimes for me going off that tab

leaden lily Apr 8, 2021, 2:36 AM

#

I wonder if it's a location thing?

random badger Apr 8, 2021, 2:38 AM

#

ya idk

random badger Apr 8, 2021, 3:06 AM

#

huh, so if I don't make an axios request there, it's all fine

#

can't make any http request there?

#

ok, new theory, cause some http requests work

#

its only ones over the nuxt proxy

#

or not, well, was excited for a second

#

ok, actually found it now... its committing the user (during the user refresh on each route change) to the vuex store

random badger Apr 8, 2021, 3:38 AM

#

so...

#

if I delay updating the user by some time for client processes, the issue is resolved, but I don't think that's really a solution

random badger Apr 8, 2021, 3:55 AM

#

and it's only that commit, not just any commit

#

so I'm guessing it has to do with the number of things watching that for changes since there are a bunch

#

finally able to reproduce it in a separate project

random badger Apr 8, 2021, 4:37 AM

#

reproducible here now https://codesandbox.io/s/nuxt-dev-reload-issue-mk16j

random badger Apr 8, 2021, 4:46 AM

#

random badger there been a couple times now... where I swear one of the perm voters isn't work...

ahha. well I wasn't dreaming about the voter issue. I made a stupid mistake re-using MethodBasedEvaluationContext objects for every voter call which is stupid because they are called for a ton of different methods

pallid yoke Apr 8, 2021, 6:00 AM

#

random badger do you think its fine if the donation settings are included in the public api mo...

It feels weird

#

Prolly should have a way to define which settings are public and which are not

#

We might be adding even more stuff in the future where this is more clear cut

pallid yoke Apr 8, 2021, 6:03 AM

#

leaden lily Looks to be better after the content has already loaded on that visit.

Only thing that is really slow right now is avatars, but those will be heavily edge side cached by CloudFlare anyways. The website itself will get faster when we start caching DB stuff too, but considering there is zero caching right now, and the giant queries a single page visit triggers, it's hella fast, lol

leaden lily Apr 8, 2021, 6:04 AM

#

Ahh

random badger Apr 8, 2021, 6:10 AM

#

Mini, here's the wack solution to what I think, is the whole reloading problem https://github.com/PaperMC/Hangar/blob/nuxt-frontend/frontend/plugins/auth.ts#L44

leaden lily Apr 8, 2021, 6:11 AM

#

Why the heck does plex come up as an option for that link

random badger Apr 8, 2021, 6:11 AM

#

??

leaden lily Apr 8, 2021, 6:12 AM

#

#

Idk maybe a typescript thing

pallid yoke Apr 8, 2021, 6:18 AM

#

Yeah I saw that MM

modest forge Apr 8, 2021, 6:18 AM

#

.ts is the extension used for some audio/video streams

pallid yoke Apr 8, 2021, 6:19 AM

#

Tried using nextTick instead of the 1 second delay?

#

That seems excessive

random badger Apr 8, 2021, 6:20 AM

#

yeah, it can't be too small

#

or the error still happens

#

which is what makes it extra stupid

leaden lily Apr 8, 2021, 5:06 PM

#

So, Mini, how do you begin to debug and see what parts are taking the longest? Is there some kind of profiler for nuxt?

pallid yoke Apr 8, 2021, 5:29 PM

#

Idk

#

In spa mode you can see the requests in the browser dev tools I guess?

#

We haven't done any performance optimizations yet

#

Most can be done by throwing @cachable annoations on stuff

leaden lily Apr 8, 2021, 5:32 PM

#

So it's the backend that's causing the problems and not the component loading of the front-end?

pallid yoke Apr 8, 2021, 5:34 PM

#

I would doubt that

#

But generally I haven't seen any slow downs anyways, so I never looked

#

In dev mode stuff is slow, but that's just webpack being webpack

leaden lily Apr 8, 2021, 9:21 PM

#

Yeah I noticed dev was a lot slower to load than actually deployed.

pallid yoke Apr 9, 2021, 7:20 AM

#

Heh I was wanting to say that am not sure I would tell the user he only soft deleted, but you changed wording in the next commit ^^

#

I am also not sure if we should move all settings into the project creation screen, it doesn't really make much sense to flood the user like that I think?

#

Especially since we might have settings we lock behind roles, so only "validated" users can use them or smth

ivory ingot Apr 9, 2021, 7:35 AM

#

Just write the soft deletion into the AGB or how it is called. Only few will read them.

If you request an account deletion it will be a deactivation only.

pallid yoke Apr 9, 2021, 7:37 AM

#

Was talking about project

ivory ingot Apr 9, 2021, 7:38 AM

#

Ah ok, would do the same for projects.

random badger Apr 9, 2021, 9:17 AM

#

Yeah ok, don’t have to put them there. I did have to add the donation field to the form object to fix an error there tho.

pallid yoke Apr 9, 2021, 9:19 AM

#

Ah ok

pallid yoke Apr 9, 2021, 4:01 PM

#

https://i.imgur.com/zGiaVls.png

Imgur

#

this is wild, didn't even notice it in the commits

leaden lily Apr 9, 2021, 4:57 PM

#

Hmm?

pallid yoke Apr 9, 2021, 5:00 PM

#

the hint to change the avatar

random badger Apr 9, 2021, 5:15 PM

#

Ore had it. I think it’d be kinda nice to have a few of them.

#

Like when you create a project for the first time, it points out where important buttons are

#

Like editing channels, settings, dependencies, pages, idk

pallid yoke Apr 9, 2021, 5:22 PM

#

yeah

#

I like it

pallid yoke Apr 9, 2021, 6:27 PM

#

Platform[keys[0] as keyof typeof Platform]

#

just typescript things

pallid yoke Apr 9, 2021, 6:51 PM

#

the hash navigation for the settings is more manual than I would like

#

but we kinda fighting vue router here, so its fine

random badger Apr 9, 2021, 9:14 PM

#

@pallid yoke I would do the redirect to the general hash in something that fires on the server instead of mounted

#

so like if there isnt a hash, add one to general

#

can maybe do it in asyncData before the api requests, then return after so it doesnt do the api requests twice

pallid yoke Apr 9, 2021, 9:28 PM

#

Hash isn't there on the server iirc

random badger Apr 9, 2021, 9:28 PM

#

oh, ok, totally didnt know that

pallid yoke Apr 9, 2021, 9:28 PM

#

It never gets send to the server

random badger Apr 9, 2021, 9:28 PM

#

I guess that makes sense

pallid yoke Apr 9, 2021, 9:28 PM

#

Only query gets send to the server

random badger Apr 9, 2021, 9:29 PM

#

well... what if we just made the settings tab url point to # general

pallid yoke Apr 9, 2021, 9:29 PM

#

Which is why early SPAs used the # for navigation, before the web history api was a thing

#

I did that, that was kinda funky because it was a router navigation

random badger Apr 9, 2021, 9:29 PM

#

so we didnt have to do any re-routing. can still keep mounted() as backup

pallid yoke Apr 9, 2021, 9:29 PM

#

So it did reload the page

#

I also considered to just make it proper and use the router again

#

Would also split up the file a bit

random badger Apr 9, 2021, 10:55 PM

#

did you know about the ::v-deep sass thing?

#

totally didn't know about it until just now. can style child components (aka vuetify components) inside scoped css that way

prime acorn Apr 10, 2021, 2:03 AM

#

anyone a good dev

random badger Apr 10, 2021, 2:03 AM

#

literally 0 good devs here

random badger Apr 10, 2021, 5:53 AM

#

apparently we spell licenses wrong like all over the place

#

we have it as licences which is apparently wrong

white pier Apr 10, 2021, 6:28 AM

#

en_US vs en_UK

#

pick your poison

random badger Apr 10, 2021, 7:08 AM

#

Oh is it really spelled differently in the UK?

white pier Apr 10, 2021, 7:26 AM

#

the noun is yes

#

the verb is spelled the same iirc

pallid yoke Apr 10, 2021, 7:37 AM

#

Oh man, I see how bad I am with jdbi

#

I knew the list<pair> was dum, but I couldn't find on how to let jdbi do the mapping to map

#

Idk if we need to enforce channel color, I mean, it would be confusing to the user I guess? But like, it doesn't hurt anything so maybe just display a warning? Hey, you use that color for release already, you sure?

#

But just banning for now, since we have the code for that is fine too and if somebody complains we can adjust

pallid yoke Apr 10, 2021, 7:40 AM

#

random badger did you know about the ::v-deep sass thing?

Tbh, I hate scoped css, it's rather confusing if you wanna style vuetify stuff and once we actually write css to make stuff look nice, I think i just wanna use css classes properly

pallid yoke Apr 10, 2021, 8:40 AM

#

the way you to the settings page switch is still a full reload of the route now, its slow :/

#

it does 3 requests to the server even

pallid yoke Apr 10, 2021, 2:20 PM

#

can you make sure login still works for you MM? https://github.com/PaperMC/Hangar/commit/5b6116e2c9c7db03842a402b835f9e3943c2cc5c

#

my brain is mushy but that logic should be fine

random badger Apr 10, 2021, 3:07 PM

#

pallid yoke the way you to the settings page switch is still a full reload of the route now,...

Oh you know... it probably messes with the saving too. Since it’s one save button for all the settings, you can’t change settings on one page, and go to another page.

#

So yeah... your way was probably better. I’m not sure it’s needed to add an entry to the history tho.

pallid yoke Apr 10, 2021, 3:08 PM

#

replace shouldn't add one

random badger Apr 10, 2021, 3:08 PM

#

Oh was yours replace? I forget, I just know there was something history api related

pallid yoke Apr 10, 2021, 3:08 PM

#

I think, yeah

#

ill look into reverting after this game then

pliant grotto Apr 10, 2021, 4:15 PM

#

white pier en_US vs en_UK

90% sure it’s en_gb but ok

white pier Apr 10, 2021, 9:28 PM

#

The ISO code is GB yes, UK is a common mistake. I saw some software with it just recently even, apparently it has infected me too 😕

random badger Apr 11, 2021, 4:18 AM

#

hanger

#

hangar... is described in the description of the channel

narrow verge Apr 11, 2021, 5:29 AM

#

thats hanger

#

hangar is

#

lemme grab the pic

#

https://cdn.discordapp.com/attachments/746194024721023128/821442889753034752/image0.jpg

#

now thats a hangar

#

just toss your plugins in there

pallid yoke Apr 11, 2021, 8:21 AM

#

pallid yoke ill look into reverting after this game then

I totally did that

#

Not

#

Thanks MM

random badger Apr 11, 2021, 8:38 AM

#

🙂

hot jackal Apr 11, 2021, 11:23 AM

#

random badger hanger

lol

sly mason Apr 12, 2021, 8:08 AM

#

guess what day it is

pallid yoke Apr 12, 2021, 8:12 AM

#

Renovate isn't on a schedule I don't think so

barren shale Apr 12, 2021, 8:19 AM

#

renovate made me instantly unsub from the repo pepela

pallid yoke Apr 12, 2021, 8:28 AM

#

Just ignore the bot on gh

barren shale Apr 12, 2021, 9:14 AM

#

how? I only see block, and I dont want to block renovate 😂

limber flare Apr 12, 2021, 9:48 PM

#

can I ask question for plugin development here ?

cobalt oyster Apr 12, 2021, 9:52 PM

#

no

#

wrong channel

random badger Apr 13, 2021, 1:02 AM

#

so I'm not sure it's really needed to be able to download either the whole file uploaded, or just the jar

#

(like if a project author wants to upload a whole zip with some extra readmes or whatever)

#

it should just download the whole thing every time I think

leaden lily Apr 13, 2021, 2:16 AM

#

Yooo new API stuff. Nice.

random badger Apr 13, 2021, 2:22 AM

#

Idrk how to do downloads for the api...

leaden lily Apr 13, 2021, 2:24 AM

#

Wdym?

random badger Apr 13, 2021, 2:25 AM

#

Well like there’s this whole “confirmation” thing. So you’d need to make 2 requests for some versions that aren’t reviewed

#

Idk if we should keep that whole thing or not.

leaden lily Apr 13, 2021, 2:25 AM

#

Why not just not expose unreviewed versions?

#

Keep them essentially private?

random badger Apr 13, 2021, 2:38 AM

#

Well, that could be an option. This bit is really modeled off of ore.

leaden lily Apr 13, 2021, 2:42 AM

#

Ahh

silver zephyr Apr 13, 2021, 2:43 AM

#

hi

leaden lily Apr 13, 2021, 2:43 AM

#

Whelp, those are my 2 cents. Do what you think is best MM.

silver zephyr Apr 13, 2021, 2:43 AM

#

someone could explain what is the goal of hangar ?

#

is it like top.gg but for minecraft plugins ?

random badger Apr 13, 2021, 2:45 AM

#

it’s a plugin repository as stated by the pinned messages/channel description

sly mason Apr 13, 2021, 4:12 AM

#

Still the wrong channel, you're asking for help, with paper

#

logs.

pallid yoke Apr 13, 2021, 5:13 AM

#

Mmh

pallid yoke Apr 13, 2021, 5:13 AM

#

random badger it should just download the whole thing every time I think

This I would say yes, download exactly what was uploaded

#

Not sure if we need confirmations for api, but I can see that being nice

#

A hangar plugin updater thingy would interactively ask for confirmation

sly mason Apr 13, 2021, 5:31 AM

#

i don't see why there'd be need for api confirmations

#

stuff like that can just be done UI side, otherwise auto publishing just becomes weird as people will dismiss it anyways, or it would just impede auto publishing?

pallid yoke Apr 13, 2021, 5:43 AM

#

Not publishing, downloading

#

And only reason I see for having it there for downloading is stats I guess?

#

(download api)

sly mason Apr 13, 2021, 5:44 AM

#

yea, I clicked on there, but, I don't see what that solves

#

all you do is require a few extra lines in the bot

#

most sites just count unique downloads per IP

#

Whiiich does get weird as CGNAT deployments grow

pallid yoke Apr 13, 2021, 5:45 AM

#

Ore tracks unsafe downloads separately

pallid yoke Apr 13, 2021, 6:14 PM

#

why am I doing this to myself?

#

https://github.com/SpongePowered/Ore/blob/staging/jobs/src/main/scala/ore/discourse/OreDiscourseApiEnabled.scala

GitHub

SpongePowered/Ore

Repository software for Sponge plugins and Forge mods - SpongePowered/Ore

#

the discourse api is strange

#

to create a post

#

you POST /posts.json

#

why the extension?

leaden lily Apr 13, 2021, 6:24 PM

#

O.o

pallid yoke Apr 13, 2021, 6:43 PM

#

I am questioning the need for this whole job system

#

why can't we just push shit out to the forums directly?

#

https://i.imgur.com/3Rjg5D4.png

Imgur

#

well, at least that works

untold idol Apr 13, 2021, 6:53 PM

#

lmfao

pallid yoke Apr 13, 2021, 6:57 PM

#

oh I think the jobs stuff is because of rate limits

#

I can see 429 status codes in the code

pallid yoke Apr 13, 2021, 7:22 PM

#

fuck you discourse, lmao

#

422 Unprocessable Entity: [{"action":"create_post","errors":["Title seems unclear, most of the words contain the same letters over and over?"]}]

#

directus api poc

#

not discourse

#

man, work is getting to me

#

I have been working on directus all day 😂

#

anyways, not as much progress as I would like, but that at least works

#

maybe I can port the template stuff tomorrow: https://github.com/SpongePowered/Ore/blob/staging/jobs/src/main/scala/ore/discourse/OreDiscourseApiEnabled.scala

GitHub

SpongePowered/Ore

Repository software for Sponge plugins and Forge mods - SpongePowered/Ore

#

and figure out the jobs shit

#

oh btw, I have off work the whole next week

#

so looking to do a hangar sprint then

cursive kraken Apr 13, 2021, 10:49 PM

#

pallid yoke I can see 429 status codes in the code

You are getting to the fun parts of discourse

cyan totem Apr 14, 2021, 4:01 AM

#

saw #315 and figured i could contribute, just a quick sketch of an idea for a hangar logo

#

another idea

random badger Apr 14, 2021, 4:09 AM

#

Out of those, I prefer the first one. Idk if we want it to kinda follow the color scheme of the paper logo, or it to be completely separate

cyan totem Apr 14, 2021, 4:09 AM

#

ideally the logo should work in two tone first before figuring out colors

sly mason Apr 14, 2021, 4:10 AM

#

part of the hope was for some level of consistency on the site rather than you go to everywhere else bar one section of the site and it's 10 miles different

narrow verge Apr 14, 2021, 4:19 AM

#

then the 2nd one on top of the normal paper stack may work?

#

not sure whats up with the chimney though, although it kinda gives off the "h"

cyan totem Apr 14, 2021, 4:43 AM

#

🤔

pallid yoke Apr 14, 2021, 5:19 AM

#

@Astrash#063 can you post them into the github thread please? So that they don't get lost

#

@cyan totem ^

cyan totem Apr 14, 2021, 5:19 AM

#

sure

pallid yoke Apr 14, 2021, 5:20 AM

#

Thanks!

#

I like the idea

#

In theory you could say that that logo is made out of two sheets of paper?

cyan totem Apr 14, 2021, 5:21 AM

#

thats the idea

pallid yoke Apr 14, 2021, 5:21 AM

#

Woo, I got it, even tho I just woke up 😂

pallid yoke Apr 14, 2021, 5:22 AM

#

cursive kraken You are getting to the fun parts of discourse

I think I saw 12 hour waits, I don't even wanna know right now

cursive kraken Apr 14, 2021, 8:30 AM

#

pallid yoke I think I saw 12 hour waits, I don't even wanna know right now

Even worse is that you can't bypass all the rules set by discourse (like topic title length etc)

pallid yoke Apr 14, 2021, 8:31 AM

#

Yeah I noticed that while playing around

#

That's so fun

#

At least I now know why it's handled via jobs

mellow pebble Apr 14, 2021, 10:51 AM

#

Those designs look awesome

zealous charm Apr 14, 2021, 11:17 AM

#

1 is very hot

lilac geyser Apr 14, 2021, 7:37 PM

#

Really nice!

random badger Apr 14, 2021, 10:00 PM

#

Change from Java to PHP? thinksmart

narrow verge Apr 14, 2021, 10:06 PM

#

no god please no

#

though laravel aint that bad

devout nacelle Apr 15, 2021, 1:02 PM

#

random badger Change from Java to PHP? <:thinksmart:497966651623604225>

yea please

devout nacelle Apr 15, 2021, 1:02 PM

#

narrow verge though laravel aint that bad

❤️

pallid yoke Apr 15, 2021, 1:43 PM

#

@sour condor You get permission to rewrite hangar auth in laravel (it's django/python rn) 😂

untold idol Apr 15, 2021, 1:44 PM

#

lol

#

im sure whoever that is will get right on it

pallid yoke Apr 15, 2021, 1:45 PM

#

Friend of mine

untold idol Apr 15, 2021, 1:45 PM

#

ah okay

#

i thought you just pinged a random while trying to ping jake 😄

pallid yoke Apr 15, 2021, 1:45 PM

#

Wait I did ping a random, lmao

untold idol Apr 15, 2021, 1:45 PM

#

OMEGALUL

pallid yoke Apr 15, 2021, 1:45 PM

#

Ment to ping @devout nacelle

#

Discord doesn't prioritize last active users 🤷‍♂️

devout nacelle Apr 15, 2021, 1:46 PM

#

🤔

sly mason Apr 15, 2021, 1:51 PM

#

typical mini

#

.mini

modest bisonBOT Apr 15, 2021, 1:51 PM

#

https://xkcd.com/323/

xkcd: Ballmer Peak

#

(Korobi) xkcd: Ballmer Peak (1 October 2007)

sour condor Apr 15, 2021, 2:03 PM

#

pallid yoke Wait I did ping a random, lmao

i didnt see this message, i was confused for quite a bit

pallid yoke Apr 15, 2021, 2:37 PM

#

Am sorry ^^

devout nacelle Apr 16, 2021, 7:30 AM

#

So i heard rewrite in php?

random badger Apr 16, 2021, 7:35 AM

#

Yeah, mini is gonna do all that this weekend

#

No food, no sleep, only php

pallid yoke Apr 16, 2021, 7:50 AM

#

Hey, beer is food too!

#

I actually do wanna look at hangar auth next week

#

And get discourse to work

sly mason Apr 16, 2021, 7:51 AM

#

Idk why but my brain went to the whole, "that's german engineers for you, machines which convert beer into code"

#

then it reminded me of the soviet machine joke from Chernobyl

#

What’s as big as a house, burns 20 liters of fuel every hour, puts out a shit-load of smoke and noise, and cuts an apple into three pieces?
||A Soviet machine made to cut apples into four pieces!||

random badger Apr 16, 2021, 7:54 AM

#

ah yes, love that joke (and show)

hoary wraith Apr 16, 2021, 11:52 PM

#

Will hangar allow freemium plugins? (Software that is open source but can be purchased to avoid the process of compiling)

untold idol Apr 16, 2021, 11:53 PM

#

almost certainly not

hoary wraith Apr 16, 2021, 11:53 PM

#

Huh, I heard that somewhere. Must have been incorrect. Apologies!

pallid yoke Apr 17, 2021, 5:05 AM

#

Nothing is decided, but ppl have ideas and preferences

#

All we know for certain is that money invites cancer and we don't wanna end like spigotmc pty ltd

pallid yoke Apr 17, 2021, 7:19 AM

#

@random badger objections to merging nuxt into master?

#

these outdated dependabot thingies are getting annoying

#

and it basically is master

sly mason Apr 17, 2021, 7:20 AM

#

I mean, are you working on master?

pallid yoke Apr 17, 2021, 7:20 AM

#

no we working on nuxt-frontend

sly mason Apr 17, 2021, 7:20 AM

#

Like, i never saw the point to a seperate branch if it's taking up like 100% of the work time

pallid yoke Apr 17, 2021, 7:20 AM

#

well, at first it was a poc

#

and master is currently still deployed for reference

sly mason Apr 17, 2021, 7:21 AM

#

Like, maybe you wanna consider having like a dev/prod branches down the line, but, master == dev, rn imho

pallid yoke Apr 17, 2021, 7:21 AM

#

yeah

#

ill just do it