hangar-dev

[pallid yoke]

not even to different channels?

[sly thunder]

lemme try

[ocean pagoda]

"Found a duplicate file in project. Plugin files may only be uploaded once."
When uploading the file, before even being able to select the channel

[pallid yoke]

I see

[sly thunder]

also, this needs a "back" button somewhere. I should probably make a list of issues somewhere lol

(dont ask why i have an emu war tab open)

[pallid yoke]

so we wanna make sure the duplicate check doesn't consider deleted stuff

[ocean pagoda]

Yep, that would make sense. Its not really a duplicate anyways when the other version was deleted

[pallid yoke]

@ocean pagoda why do you have ICODE and not CODE?

oooh, inline code

that was easy

[random badger]

Ok, so for deleting versions, I see no reason why versions with new visibility can’t be hard deleted by the project owner

Is there a reason why any version can’t be hard deleted? Cause if it’s not hard deleted, you can’t use that version name or the same file again.

[barren shale]

for modz to view potentially reported stuff or something?

[pallid yoke]

well, user uploads malicious stuff, other user downloads, reports, owner deletes before staff can take a look and gets away with it

[random badger]

Yeah, that’s right. Well I guess we have to make everything about a version editable then.

Release channel, dependencies, name, etc.

So there’s never a need to delete/re upload.

[ocean pagoda]

That would be more userfriendly anyways

[barren shale]

I wouldn't let people edit the used channel, since that's the one thing that isn't visual only

[pallid yoke]

lets just exclude the version if its marked as deleted from the uniqueness check

[random badger]

I think the uniqueness check is done on the db table right?

A unique key with project id and version string?

[pallid yoke]

uuh

lemme see

[random badger]

Could then add a check when restoring a version to make sure another non-deleted version with the same name doesn’t already exist

[pallid yoke]

(project_id, version_string) is unique

we could add the visibility to that

[midnight anchor]

is the email confirmation setup yet?

[sly thunder]

mini gets the emails

[midnight anchor]

ah

[pallid yoke]

@midnight anchor http://hangar-auth.minidigger.me/accounts/verify/Mw/5l6-23525a42d0d9642a57d9/

[midnight anchor]

:D

[pallid yoke]

I have no clue where the fuck uploaded stuff is stored on staging

but its saved somewhere apperently

since its persisted

but there is no volume?!

[cursive kraken]

your compose file creates a upload volume or not

[pallid yoke]

now it does

https://github.com/PaperMC/Hangar/commit/b86ccf0edf7626ae2f5ffef507e7a8e943e194b4

[cursive kraken]

ah there was one before but it was not bound

[pallid yoke]

yeah it was weird

but for some reason downloads worked

idk

now its looks like I expect it do to and icons seem to work

soooo 🤷

[random badger]

Perhaps the default project icon shouldn’t be owners pfp?

Might confuse some people? Idk.

[narrow verge]

Default should be that one icon where it's just the first letter of the project name

[random badger]

no idea how that works, that's all done via hangarauth for users pfps

[narrow verge]

Oh so project icons are persistent now?

[random badger]

yeah, apparently staging wasn't setup to save them or something

I'm guessing that means the jar's probably didn't persist either?

if any were uploaded, idk

im thinking this maybe

[barren shale]

sounds good

I'd also have some info text saying "Upload your first version by clicking the upload button on the right!" (or any sort of marker) so that you don't just have << 1 >> without anything else in the middle

[narrow verge]

Yeah I guess jars went poof too

https://hangar.minidigger.me/Chew/SpigotDrama/versions/1.1/download

[barren shale]

when did you upload that? mini changed something to storage

[random badger]

yeah, that stuff didn't persist cause a docker volume wasn't setup correctly. I think mini only changed it a few hours ago

[narrow verge]

#hangar-dev message

i uploaded it yesterday

[random badger]

right, mini fixed it a few hours ago, so everything before that was lost

project icons, jars, etc.

[narrow verge]

rip

[mortal idol]

F

[random badger]

works fine on local dev cause it uses a different docker-compose file, so this would only have been caught in staging

[mortal idol]

imagine this happens on production

[narrow verge]

whats the diff between staging and production?

please try to stay on topic

[random badger]

well rn, there is no production, staging is the "production" for now

[narrow verge]

Glad to see the forward progress 😄

[pallid yoke]

I am not sure how the fuck downloads persisted before

[modest forge]

Magic

[pallid yoke]

https://i.imgur.com/KzvqmJ1.png

nice

[random badger]

we could add the visibility to that
@pallid yoke
don't think that would work right? cause then you could have a new version, and a public version with the same name

[pallid yoke]

Yeah that's what I thought later too

[narrow verge]

500 commits, great work guys!

[pallid yoke]

Most of the props are for MM, I just layed the ground work and vanished, lol

[narrow verge]

I wish I could help but it got to a state where the point of entry got too high for the free-time I had

[pallid yoke]

I disagree, now that everything is "done", the barrier of entry to do a small change or fix is lower since everything is in place

[narrow verge]

Ah, cool

[sly thunder]

I just stick to reporting issues so someone else can fix them

[sly mason]

report ur existence

[sly thunder]

Wtf rude. Plz no bully in #hangar-dev

[narrow verge]

😳

[pallid yoke]

I just stick to reporting issues so someone else can fix them :WolfKek1:
Thats prolly the most helpful thing to do

Cause God nows am too blind to see issues

After looking at this for months

Also, if we got proper web designers in here that can help with making stuff look nice and stuff, that would be cool

Dont even need to be contributing code, just "hey, this looks bad, how about smth like this?" Helps

Also general UX stuff

We want this to be actually nice to use

We don't just want to have some dum replacement for spigot, we want to build an actual platform that you actually want to use

[sly mason]

can you upload to ore, or, just sticking to 3rd party?

[pallid yoke]

Hangar can either host your crappy plugins or you can host then on like github releases and link it in hangar

Whatever you want

Sane with dependencies, you can either link a hangar project as dependency or link to some other url

[narrow verge]

download links MUST be jars though right?

otherwise api would bork

[sly mason]

maven/gradle plugin wen

[pallid yoke]

That's something I want to enforce, yes

A think sponge actually has a plugin cat, would be easy to fork

But ye, there's an upload api so that's easily possible

[narrow verge]

poG

[sly mason]

Yea, I know, it's just more fun to make your life hell

[pallid yoke]

I also saw that there is no download api in the documented api yet, I need to move that tomorrow

Left some Todo on that today

Oh and chew, since you played with the api already, did you use authentication?

Since I wasn't sure if that works and I saw a Todo that didn't make too much sense

[narrow verge]

https://github.com/Chewbotcca/Discord/blob/main/src/main/java/pw/chew/chewbotcca/commands/minecraft/HangarCommand.java is what I do

Call authenticate and get a key, then call projects

Which works, thankfully

Though if there's an API key somewhere that would be a lot better

[pallid yoke]

Your code is fine, you basically anonymous

You can generate a key for your user I think

Am go sleep now, I'll look at stuff tomorrow

[narrow verge]

nighty

[sly mason]

be gone

[carmine steeple]

@narrow verge The bot is really cool! Where can I add suggestions? (Sorry for the ping)

[radiant zephyr]

This seems wrong to me

IN_WATER uses getMonsterSpawnLimit()

[sly mason]

1. Wrong channel

2. Not paper

[radiant zephyr]

Aight - had absolutely no idea where to post

[random badger]

So yeah, atm @narrow verge you can put whatever link you want when posting a version. Doesn’t have to be direct link to jar.

But I’m not sure we should enforce that is has to be a jar.

Because one of the points of allowing external links, was so someone could link to a gh release that has multiple jars for different versions or smth

[mortal idol]

what about plugins like essx

[random badger]

You can upload zips

I actually have no clue what happens currently if you upload the Essx zip. I’ll mess with that today.

Also @pallid yoke I was thinking about how the upload api was gonna work with all the dependency stuff we added.

Should part of the upload request require all that info be sent with the file/link? OR should we basically have documentation on like a hangar.yml that’s in the file that has that info.

[pallid yoke]

I really like the idea of adding a hangar section to the plugin.yml

but we should also allow to make that work via the request I guess

[random badger]

Well can’t be plugin.yml

[pallid yoke]

why not?

[random badger]

Cause that doesn’t exist for all plugins

Like velocity plugins

Or bungee that uses bungee.yml

[pallid yoke]

well, could do it per platform I then

having it in the proper file is nicer than having a new file I would argue

especially since like, we dont wanna force yaml on velocity ppl ^^

[random badger]

Yeah ok. I guess each platform does have different dependencies too.

So if we did have a separate file, it’d have to have different sections for each platform

[pallid yoke]

yeah that too

[random badger]

Then what should be part of that section?
Supported versions, probably a list of strings

Mapping dependencies to either a project or a link.

Don’t need to worry about if the dependency is required or not, that’s already taken care of. How should it be linked to a hangar project? Just “Author/Project”?

[pallid yoke]

yeah

maybe a version range?

but we don't require semver so thats messy

[random badger]

Can probably use this section in manual uploads as well to fill out more info on dependencies. But it’s not required for manual uploads.

[pallid yoke]

yeah

[random badger]

k, I think we probably need to go through the project and make sure all links are url encoded, specifically ones that use a project slug, or owner name or something like that. cause those can probably include characters that would throw off the link right?

[pallid yoke]

arent project name and author name already validated?

[random badger]

does that validation include removing those chars?

I dont see where it is. its checked against the max length, and has consecutive spaces removed

but I think you can have a project name be ?&/\_

[pallid yoke]

yeah I never check the content of the check

[random badger]

I assume that would mess something up somewhere

[pallid yoke]

https://i.imgur.com/QXJ6K3G.png

lets just require a-zA-Z0-9-_ for project names?

[stray wharf]

but muh

{{-50% HALLOWEEN SALE]]

[random badger]

brackets should be fine to allow

[pallid yoke]

use the description for bullshit like that

[stray wharf]

have you looked at spigot in the past few days

[random badger]

but we'd need to check that for project names and version names as well

[pallid yoke]

name = plugin.yml name

[sly mason]

treat the slug and project title seperatly?

[random badger]

oh right, the slug is the only thing that needs to be url encoded

[stray wharf]

literally every premium plugin has a bunch of special characters and shit in the title

[sly mason]

you want mcMMO to match up to mcMMO, etc

[random badger]

and thats a separate column in the db

but there is no slug column for version name

[pallid yoke]

https://i.imgur.com/5mr5j7K.png

we have no title. we have a project name, which is a slug and also the plugin.yml name

if you wanna do emoji and shit, use that description field

[random badger]

aren't they separate, we have a name and a slug column

in the projects table

[stray wharf]

bigger text better text

[pallid yoke]

https://i.imgur.com/jnoKcr5.png

[stray wharf]

can i make the font size of the description 40

[random badger]

on your personal machine, yes 🙂

just make some custom styles for it

should give you the high you need from seeing obnoxious names 😛

[stray wharf]

how am I supposed to attract customers if I can't spam size 20 emojis in the plugin title

[pallid yoke]

kek we have an xss

https://i.imgur.com/cOh6zUX.png

lemme repro on ore 😂

ore is safe, so thats good

why does it work for us tho

I thought freemarker would prevent that

fixed

but now more stuff broke

[pallid yoke]

thats a big boi commit

pls test

most of that was done with a structural replace, so it might have gotten stuff wrong

basically function > macro

[narrow verge]

The bot is really cool! Where can I add suggestions? (Sorry for the ping)
@Simon.#4921 issue section or on the server, link is in the readme

[pallid yoke]

and

-                                <#assign support>${p.project.support}</#assign>
+                                <#assign support=p.project.support />

[narrow verge]

Oh they left

[pallid yoke]

@carmine steeple ^

no they didnt

[midnight anchor]

i created a project name with a . in it and... https://i.imgur.com/D4z8XIG.png

[pallid yoke]

can you open an issue for "sanitize project, org and user names" pls?

am on the run now

[narrow verge]

Oh yeah I had that issue

It's probably looking for Cool- as a text file

[midnight anchor]

its looking for the file Cool-.txt-file lol

[pallid yoke]

no its just the regex breaking

[midnight anchor]

ah

[pallid yoke]

but point is, we dont want to allow such names in the first place

[midnight anchor]

can you open an issue for "sanitize project, org and user names" pls?
me? or someone else?

[pallid yoke]

yes pls

[sly mason]

you, or someone else

[midnight anchor]

ok

lol

[carmine steeple]

@carmine steeple issue section or on the server, link is in the readme
Thanks!

[midnight anchor]

done

[pallid yoke]

Ty

[midnight anchor]

np

[modest forge]

org creation no worky 👀

[pallid yoke]

Open issue pls so I can take a look tmr

[modest forge]

Alright, will do

Might need to ping me to remind me lol

[narrow verge]

i can do it rq if you need

[modest forge]

Also staff and authors page seem to error and the bbcode convert endpoint is giving me a 500

@narrow verge do you mean ping me or submit an issue 👀

https://i.imgur.com/4clHMnq.gif

[narrow verge]

make the issue

but got notifications to go through real quick

[random badger]

ok, so what characters should be allowed in a project name? a-zA-Z0-9-_ and...

[modest forge]

Probably just those tbh

[pallid yoke]

That sounds fine for now

[random badger]

no {}?

[barren shale]

no

[modest forge]

No

[random badger]

or periods? for Epic Plugin 3.0

[pallid yoke]

Can prolly just check what bukkit allows

I feel like that's a good baseline

[modest forge]

Bukkit allows ()[]

Not sure about {}

Although Bukkit also has separate project titles to slugs

[sly mason]

private static final Pattern VALID_NAME = Pattern.compile("^[A-Za-z0-9 _.-]+$");

[narrow verge]

what does github allow?

dash and dot apparently

[sly mason]

I'd argue for the nature of dependency matching,etc, it should stick to being bukkit formatted

[narrow verge]

oop and underscore

[sly mason]

if plugins want pretty names, they can do that in the desc, or, should be treat sepereatly from the actual name, akin to a display name

[modest forge]

Oh you mean bukkit

For some reason I read "bukkit" as DBO rip

[random badger]

that's what I thought as well

[pallid yoke]

Nah I mean bukkit

I agree with cat, let's do bukkit for now and tell ppl to use the desc, if they complain we can add a seperate display name later

[modest forge]

^

[random badger]

ok, what's bukkit accept?

[pallid yoke]

private static final Pattern VALID_NAME = Pattern.compile("^[A-Za-z0-9 _.-]+$");

[random badger]

oh missed that msg

it does take . tho

and that will mess up urls

[pallid yoke]

Yeah remove that

[random badger]

unless we url encode the slug

[sly mason]

I'd just remove the .

I don't think I've ever seen anybody use a .

[random badger]

so no underscore then

[pallid yoke]

Chew, go back is a browser back

It has no href

It's just JS

[narrow verge]

either way it doesnt work

[pallid yoke]

Maybe that doesn't work with new tab

[narrow verge]

yeah so should it just close the tab then?

[sly mason]

Won't work on a new tab as there's nothing to go back to, so, yea, closing would be the only real option there

I mean, I'd argue though, does it need a new tab by default?

[narrow verge]

Yeah so choices really are no new tab (if you want one just right click > new tab) or close tab on go back

if latter, maybe say "Cancel" instead

[modest forge]

I've done the former in #222, up to you guys which one you want to go for

||totally bc I feel bad about not contributing in forever and not because hacktoberfest ends today||

[pallid yoke]

Not sure if that even has the label

I think we added it

[narrow verge]

ive done like one pr, i missed my chance 😂

[modest forge]

never too late to PR to the drama generator

[narrow verge]

I did!

like 3 months ago 😂

4 actually!

[modest forge]

oof

[narrow verge]

was just a link to my api

as seen in the plugin

[modest forge]

Oh I forgot about that

[random badger]

huh, the staff/author pages don't error for me on local

but this does https://hangar.minidigger.me/staff

[narrow verge]

https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3AChew+archived%3Afalse
I've got some PRs cooking

[modest forge]

TIL you can use that PR page to see other people's PRs

[pallid yoke]

I need to look into giving you log access jake

[narrow verge]

works for issues too 😄

[random badger]

that would be pretty nice

[pallid yoke]

I think portainer supports role based access control

[narrow verge]

fancy

[placid river]

How do I get the tps in a variable?

[mossy topaz]

#paper-dev

[placid river]

oops

[random badger]

@pallid yoke is that what was causing the error on staging?

[pallid yoke]

yes...

[random badger]

Why wasn’t it erroring on local then?

[pallid yoke]

if you mix casing it freaks out

it did for me

maybe you didn't pull my giant output format change commit?

[random badger]

Oh you know, I bet that’s it

[pallid yoke]

or it didn't properly update templates

[random badger]

Yeah, I was working on the review vue templates and hasn’t rebased yet

[pallid yoke]

yeah that commit introduced it because I added <#outputformat> to a file that had startsWith

and not starts_with

[random badger]

What’s the purpose of outputformat “JavaScript”? Free marker docs says that doesnt escape anything

[main lava]

hey guys, what is hangar?

[misty mountain]

https://girlsare.life/5Kt5MZh.png

[main lava]

Oooo, cool

[pallid yoke]

I could have entered plain text too

But it's more concrete that was and we could use that to do stuff in the future if needed

@main lava it uses spring boot, freemarker and Vue.js

[main lava]

neat

[pallid yoke]

Oh and Jake, I had to add it because it was escaping stuff in some places which broke stuff

But thanks to the forced output format everywhere now, we are safe against xss

At least I am unable to xss now in the places I tried

[random badger]

Oh yeah, ok I get that now.

[random badger]

@modest forge do you happen to know where in hangarauth the username is validated?

cause we need to prevent bad characters in that as well

same as projects probably a-zA-Z0-9-_

[pallid yoke]

I took a look before and didn't see it

[random badger]

there's something preventing you from creating orgs with more than numbers, letters, and underscores

and that's on the hangarauth side

ahha, yeah, there is validation on the User db model

spongeauth/accounts/models.py line 20

[^\w.-] one of the checks is if a match is found, throw error

that would allow . in usernames right?

[cursive kraken]

Yes that's stupid and there is a pr for removing that

But I've never merged it lol

Btw the docker stuff you have for auth is not production ready, it's using the dev sever. I hope you know that

[random badger]

not sure I follow.

if you are talking about the docker stuff in the HangarAuth repo, I don't think that's actually used anywhere

[cursive kraken]

Ah k

[random badger]

well the Dockerfile is, the docker-compose.yml is not

[cursive kraken]

K but than it's not production ready

Cause it starts the dev server in the entry point on the repo

[pallid yoke]

Yeah yeah I know that that's all wonky

It's good enough right now and we will figure it out later (potentially ~ annoying ~ asking you guys)

Idk how strike thru works

[barren shale]

double ~

[sly mason]

two ~

[pallid yoke]

I had that and edited it out

[barren shale]

any content between opening and closing ~~ should work... unlike markdown, which won't render ~~hello ~~ striked through with that trailing space

so I had to watch out for that in the converter as well, cause the stupid editor loves its [b]hello [/b] tags and similar :>

[somber flicker]

so https://github.com/PaperMC/Hangar/issues/214 are we sure thats fixed because Prism Icon reset again and even better for some reason its now on the TestProject

https://user-images.githubusercontent.com/2214955/97820768-6c0b9700-1cfb-11eb-8602-e04409da5352.png

[narrow verge]

That might've been as a test

My icon is still there

[somber flicker]

lol

Ill update it again

[random badger]

did you set the icon after mini fixed the issue?

any jar/image files from before that, were not saved

[somber flicker]

I just did it - I didnt realize fixes had been applied because the issues are not being linked to commits..

ie Gitlab > github

[random badger]

well gh only links them if you mention in the commit message that this commit fixes #214 or something similar

[somber flicker]

yep I know - I just assumed the fix wasnt code based from the issue

all good seems fixed 🙂

is there a gradle plugin for api based uploading yet?

[random badger]

ore has something like that iirc. afaik, none of us have touched that yet

I have no clue how that works right now

[somber flicker]

but the hangar api is pretty similar to Ore so that might be a good starting point

[random badger]

there is an api endpoint for deploying a version. but its the last api endpoint that has yet to be actually written

[somber flicker]

thats ok I was just going to see If I could develop a maven deploy plugin that mimics the gradle one

[random badger]

it gets a little more complex because of how hangar has expanded the dependencies. We talked about adding a section to the plugin.yml/bungee.yml/velocity.json files to configure dependencies inside the jar.

cause now, when you upload a version manually, you can set the supported versions and whatnot, but when doing that from the api, somehow that info needs to get to the server. Either additional params on the POST request, or additions to the various config files

[somber flicker]

yep and it could work nicely with Demonwavs intellij plugin that adds that automagically

I thought i looked at the api and it could take version details etc with the upload

obviously not dependency stuff yet - becuase thats new

[random badger]

yeah, there is basic stuff with the upload

like description and stuff, but for dependencies, it gets more complicated

they are per-platform and are either linked to a hangar project or an external link

[somber flicker]

of course particularly when we want to link existing hangar plugions

[random badger]

ok, shouldn't run into any more bad project/page/version/user/organization names

still need to figure out what to do with deleted versions...

[somber flicker]

yeah the naming conflict

is there a definite requirement that the version name must be unique? like it is currently?

[random badger]

yeah, I mean the version name is used in the url

so you couldn't really have two with the same name

[somber flicker]

Do you think that might be limiting long term.

[random badger]

I hadn't really thought about it at all. This was just taken directly from ore

[somber flicker]

I mean even from the point of view of a plugin name - DBO moved it an Id system pretty bloody quickly as has Bstats for that same problem

not that I think you want multiple plugins with the same name

but even if you think about some annoying person creating multiple projects with various names ...that never get approved...but by thier existence prevent a legitimate project with that name every existing -

[random badger]

multiple projects can have the same name

just two projects from the same author cant have the same name

[somber flicker]

oh right

AUTHOR>PROJECT>VERSION for uniqueness

[random badger]

which is totally fine, I dont see any problem with that, but maybe we do have to switch to using the db id for versions

[somber flicker]

I dont think hangar should be the place I would ever deploy snapshots but lets say we get a plugin that can autodeploy on build - and its autodeploying snapshots - I can imagine the technicality of it searching for an existing version with the same name then uploading a new file - v uploading a new version with the same version snaphot name - I mean again probably something that just gets decided at the outset what the hangar team wants

[mortal idol]

dependabot monday woo

[barren shale]

(At least a few of us already said) we don’t want people to use hangar to permanently spam (dev) builds, so there will likely be a sane max versions to release a day

but files with the same name should be made possible, since we still want people to be able to upload dev builds and such in general. A search could either return a list or just a single entry, being the last to be released (both regarding api and separate url calls aside from the version id?)

[random badger]

Yeah, so if we want versions with the same name, we need a new identifier

For some reason I feel like “Machine/EpicProject/versions/347” doesn’t look as nice as “Machine/EpicProject/versions/1.6.1”

Maybe the url should be a combination of the version string and the ID?

[barren shale]

I would actually allow both of these

tho maybe as different parameters, so you can set either one (instead of us figuring out which one it is from versions/...)

but eh, not 100% sure what's the best way of dealing with it

[pallid yoke]

Xenforo does displayname.id

Displayname is completely discarded for routing

[barren shale]

yeah I suppose 3.0-SNAPSHOT.347 or similar would look good as well

[random badger]

yeah, I think that'll be good. Will completely fix the deleted version issue

[zealous charm]

Could not resolve placeholder 'hangar.projects.name-regex' in value "#{T(java.util.regex.Pattern).compile(${hangar.projects.name-regex})}"

@random badger mini say broke and not epic

[pallid yoke]

That's on staging, gotta define the pattern in a yml or add a default value

[somber flicker]

if your going to go with 3.0-SNAPSHOT.347 why not 3.0-SNAPSHOT-347 which is consistent with Maven versioning

[narrow verge]

I always do major.minor.patch_build

[somber flicker]

can maven read that>

I based what I do off the oracle article ..

[white pier]

pretty sure maven itself does not care at all what you put in there

now whether you can get that published in the global repo ehhhh I doubt it

[sly mason]

generally don't want build numbers in there if that's what you're doing

[somber flicker]

last I checked global repo only allows releases.

kenny was referring to SemVer I think

but as I understand it SemVer does not actually validate SNAPSHOT at all

[narrow verge]

Oh yeah, for published things I just drop the _build

builds are just that: dev builds

[narrow verge]

Bad gateway atm, server down?

[pallid yoke]

That's on staging, gotta define the pattern in a yml or add a default value
@pallid yoke if this wasn't fixed then yes

[random badger]

oh yeah, I totally forgot about that

[random badger]

yeah, should be fixed now @narrow verge

[narrow verge]

Sweet

[modest forge]

Not build numbers, adding an ID to the URL for versions

IMO it shouldn't be made to look like a Maven version because the ID isn't actually part of the version name

So I'd say version_name.version_id is fine

[pallid yoke]

Yeah sorry didn't had time to fix stuff either yesterday

Looking back at that message it sounded like I was blaming jake for breaking it and for not fixing it

I mean, he is to blame, buuuut you get what I mean 😂

[main lava]

a really stupid question, what exactly is this?

a plugin repository, yes, but what can i do with it?

[zealous charm]

upload... plugins?

https://github.com/PaperMC/Hangar#hangar---papers-upcoming-plugin-repository

[main lava]

so it's a website?

lol, never saw a web application written in Java

[zealous charm]

java in web is pretty huge lol

[main lava]

a really stupid question, what exactly is this?
@main lava its like spigotmc, but way better.

that sounds really good

Did you guys add spoilers already?

[pallid yoke]

Did you open an issue?

Then you could see if it's closed

^^

[main lava]

No i asked if i should do that, but noone answered...

To that question

I can do that if you want

@pallid yoke

[pallid yoke]

Yes pls do, as you can see stuff gets lost

Rather open an issue too much than having something lost

(I do that wrong too as you see by scrolling a few messages up......)

[main lava]

Yeah im fine. This is a huge project and all of you got a lot to do. I will open an issue once im back at my pc.

[pallid yoke]

Thanks :)

[tight mulch]

poggers, this sounds interesting.

[random badger]

Does markdown have spoilers?

Or are we adding that custom?

[barren shale]

it doesn't

[pallid yoke]

Gh flavored markdown has

[main lava]

Or are we adding that custom?
@random badger github had to implement them custom

^

[pallid yoke]

And I am somewhat sure our markdown parser supports that

Behind some options or whatever

[main lava]

how would it look like?

[pallid yoke]

Like on GitHub hopefully ^^

[main lava]

hm is the parser as on ore?

or is it different?

[pallid yoke]

I don't remember

[main lava]

because on ore it didn't work or hm

i gotta check that

[pallid yoke]

https://github.com/vsch/flexmark-java is what we use

[main lava]

gotta read into it

[pallid yoke]

It seems to support bunch of stuff

https://github.com/vsch/flexmark-java/wiki/Extensions

This is our code

https://github.com/PaperMC/Hangar/blob/master/src/main/java/io/papermc/hangar/service/MarkdownService.java

[main lava]

doesn't look like it exists

¯_(ツ)_/¯

[pallid yoke]

It supports https://squidfunk.github.io/mkdocs-material/reference/admonitions/

That has something that looks like a spoiler

Details extension

That will most likely require a bit of style work but that looks like

[main lava]

hm this are spoilers

kinda

[pallid yoke]

Ah nice the extension ships the js/css

https://github.com/vsch/flexmark-java/wiki/Extensions#admonition

I like

If you create a ticket, and add that link so it's not getting lost, I can hopefully look at in in a few hours

[main lava]

ok

@pallid yoke https://github.com/PaperMC/Hangar/issues/229

[pallid yoke]

Oh and like, if you see anything else on the pages above that you like, add it there too

[main lava]

ok should i edit my message or comment under it?

[pallid yoke]

This all seems fairly plug and play

Comment is better than I see that smth changed

[main lava]

🆗

huh i think hangar doesn't have emojis right?

[pallid yoke]

It supports unicode pretty sure

[main lava]

theres all this emojis that can be used: https://www.webfx.com/tools/emoji-cheat-sheet/

through a addon

so its like github does it

[pallid yoke]

So you mean the : notation?

[main lava]

yes

[pallid yoke]

Seems fair to add

[main lava]

k

and i feel like that emoji base is bigger

[barren shale]

all of those would have to be integrated into the forums as well

since threads are created on there

[pallid yoke]

Ah yes

[random badger]

hmm ok so the gfm-users extension would be great

except... it doesn't like _ in the user...

[pallid yoke]

its not to late to change our regex

runs

ill be unable to look at stuff today, my brain is mush

[random badger]

just watch U.S. election news. really a big stress reliever 😛

so maybe we can write our own extensions

I don't think you can currently have spaces in a username

yeah, its just \w and -

do people want underscores in their name?

[pallid yoke]

dont think so

[random badger]

Ok. So we can get rid of underscores. Then we can add an autocomplete thing when typing after a @. Should be nice.

There’s not a ton of reasons to link users, but I guess it’ll be good to have.

The mentioning will mainly take place on the forum thread.

[stiff token]

But my name underscores 😢

[pallid yoke]

is it common that ppl limit underscores?

[stiff token]

How is it on Paper forum?

I only know that on GH I have - sign, instead of underscore.

Usually . or _ works.

[pallid yoke]

we can prolly just fork the extension

or copy it into our code

[stiff token]

I was joking btw 😛

I don't like the fact that I have to use - on GH (might need to change nick because of that), but I don't think this is in any way a deal breaker.

I preffer underscore as replacement for space in usernames.

[pallid yoke]

well, we dont need to restrict stuff for no reason

[random badger]

if the pattern wasn't declared final....

I guess if we do implement it ourselves, we can have it only resolve if there is indeed a user with that name

so we don't get links to 404s

[pallid yoke]

Yeah

[main lava]

hmm ok so the gfm-users extension would be great
When is that even useful?

just wondering...

Its a nice thing, but i don't see any useful usecase.

Except in user descriptions or something...

[random badger]

linking to users pages on your project page

contributors or something

[ocean pagoda]

Usernames with underscores a pretty common. It's the least noticeable character that most sites allow. So e.g. if Malfrador was taken, Malfrador_ would be the first name I would try because it looks less bad than the other usually allowed symbols

"pretty common" is tbh based on observations of playernames on my server, but as many people use their Minecraft name elsewhere, this should be an acceptable metric

[stray wharf]

xXxMalfrador123xXx

[ocean pagoda]

Yeah, that looks horrible :D

[random badger]

hey @pallid yoke I think after your output format changes, the rendered markdown no longer is read as HTML, but as plain text

so before vue takes over and replaces it, you see a bunch of ugly html

[pallid yoke]

I thought I fixed that

[random badger]

well maybe its something I did then?

[pallid yoke]

I remember looking at that

[random badger]

hmm yeah, on live it works fine.

no clue what I could've done to cause that tho

didnt think I touched anything anywhere near that

all I was doing was transitioning to the versionname.id thing

which I dont see how that affects this

[pallid yoke]

I can look at it once you pushed your stuff tomorrow or so

if I see smth

[pallid yoke]

https://drama.essentialsx.net/eyJzZW50ZW5jZSI6MzQsInBlb3BsZSI6WzhdLCJzaXRlcyI6WzhdLCJkcmFtYSI6WzVdfQ==

[modest forge]

stolen drama 👀

[pallid yoke]

It's now mine

[modest bison]

🌮

[narrow verge]

🌮

[jagged ore]

🌮

[carmine steeple]

🌮

[modest forge]

🌯

[barren shale]

🍍

[wispy sonnet]

\🌮

[pallid yoke]

We can stop spamming now

It was only to test the bridge

[stray wharf]

👨🏻‍🎨

[modest forge]

:(

[jagged ore]

[misty mountain]

happy dependabot-monday

[modest phoenix]

The sass

[misty mountain]

The scss

[modest bison]

👀

oof, this channel is in window 20 and the irssi quick switcher can only do 19 directly

[pallid yoke]

And I thought irssi was for power users, smh

[modest bison]

I mean I can still do /<windownumber> or /go<tab>start typing channel name

[main lava]

I wanna make it so when player runs the cmd a time counter will start, which counts time (HOUR, MINUTE, SECONDS, MILLISECOND)

[pallid yoke]

#paper-dev

[main lava]

sorry

my bad

[random badger]

lol, we are running into the same thing in this channel that sponge deals with in their ore channel. like all the messages in their ore channel that aren't from me are people looking for dev help with sponge

[narrow verge]

Pretty much lol

[modest forge]

Could have a message like #paper-test-builds which tells people "this is for Hangar only"

[sly mason]

implying people read

plz

[modest forge]

Hey I'm not expecting people to read it, it just gives us an excuse to yell at people misusing the channel 👀

[pallid yoke]

I yell at ppl whenever I want!

[sly mason]

listen here fuckbreath

I have nothing to say to you

I just wanted to call you that

[random badger]

Not sure I’ve seen that one before...

[stray wharf]

is that a reference

[upper flower]

Not exactly a dev question but will Hangar work with forums accounts when it launches or will it have a dedicated system?

[modest forge]

We're currently building it to use a custom auth system (originally developed by Sponge) that's designed to integrate directly into Discourse

Chances are, when we get closer to launch, forum accounts will probably get migrated over to hangarauth, but I can't confirm that for sure as I don't believe that's really been discussed/decided on yet

[pallid yoke]

Pretty sure that will be the case

We don't want you to have multiple accounts

[sharp crypt]

So HangarAuth will be a SSO for Forums and Hangar?

[pallid yoke]

Yes, hopefully

[narrow verge]

rev up those fryers

[pallid yoke]

Did spring discover sem ver? :0

Also, it's Monday my dudes!

[random badger]

yep, always glad to get my monday reminder courtesy of dependabot

[pallid yoke]

Notice how the spring boot PR doesn't have the release suffix

[ivory ingot]

Yeah, but the release suffix is specified in semver as well.

https://semver.org/
<valid semver> ::= <version core> | <version core> "-" <pre-release> | <version core> "+" <build> | <version core> "-" <pre-release> "+" <build>

[pallid yoke]

Whatever it's stupid and am glad it's gone

[sly mason]

[ivory ingot]

😄

[modest forge]

It's Dependabot Day again

[zealous charm]

🥳

[modest forge]

Was anything discussed about discussion pages? I only just remembered I had a PR open to use Discourse

[pallid yoke]

Not really, don't remember anything

[cursive kraken]

trust me, if there is a way around it don't touch the discourse api

[modest forge]

The Ore template that uses Discourse's built-in embed seemed to function in Hangar with a few changes, but I didn't really test it further

[wicked heath]

is a Premium or payed Ressource categorie planned?

[random badger]

no

no paid resources. We will encourage paid support via whatever platform tho

[wicked heath]

okay thx

[safe harbor]

Btc

[pallid yoke]

This is not a marketplace :)

[safe harbor]

Oss > premium

I wouldn't be very opposed to crypto currencies haha

[silver panther]

no premium section

very excited for hangar tbh

[cinder silo]

yep same here

i think it will naturally cultivate a far better community than spigotmc's

[silver panther]

definitely

[cinder silo]

i hope it will slowly steer the minecraft (server) community to less toxicity

[silver panther]

yeah same, honestly the server community is pretty terrible rn

hopefully hangar will be a step in the right direction

i really like the decision not to do premium, i think spigot's premium section contributes a lot to the toxicity on the platform

since its no longer a place where everyones just making cool shit for the game they love, its basically become a hypercompetitive marketplace in many ways

[cinder silo]

yep

i wouldn't say the server community as a whole is terrible

there are many bastions of hope, i.e. paper, sponge, syscraft, etc

[silver panther]

yea

[cinder silo]

all places with very cool people who are pushing the game forward

[wicked heath]

Official Minecraft in opensource would be really great

[safe harbor]

[pallid yoke]

Minecraft is open source enough nowadays

[cinder silo]

yeah fr lol

honestly i never thought about it but yeah for the best selling game of all time minecraft is surprisingly open for modders n shit

[pallid yoke]

We literally have the full mappings with a rather permissive licence now

[cinder silo]

yeah exactly

they've been getting a lot better

[narrow verge]

shouldve said check the pins

[cinder silo]

to what?

[random badger]

check the pins

[soft hornet]

Mandatory source link on plugin pages? 😄

[untold idol]

https://google.com

that is my plugin repo

[safe harbor]

Thx for your contribution.

[untold idol]

any time

[safe harbor]

😂

[barren shale]

requiring would be a bit much, sadly, but things like obfuscated resources (and maybe resources with no source provided as well?) will be marked with some tag saying it's obfuscated (or closed-sourced) :p

[pallid yoke]

Am thinking to do what mojang just did with outdated versions in the launcher

"this reosurce is obfuscated and thus may be unsafe to use, proceed at your own risk"

And tweaking search algos and shit like that

[safe harbor]

Meh, not necessarily all closed source stuff is obfuscated. Some people just couldn't be bothered (yet) to publish the source.

[barren shale]

obviously, those are two different things

[white pier]

no source, obf'd etc, should have that sort of "gentle push" away

[pallid yoke]

Well yes, this would only be applied to obfuscated stuff

[white pier]

shows up last in results

gets a slightly ugly badge

etc

[pallid yoke]

Also we would require authors to fill this out and rely on reports to check

And do harsh punishments or smth

[safe harbor]

GH integration?

[pallid yoke]

Idk, this is all ideas

Yeah, via webhooks

[barren shale]

at least that's the plan™️

[pallid yoke]

Gh release into hangar release is a plan

Once am done with MiniMessage and paperweight is on track hangar will get more love again

I have the next few Fridays off of work

[safe harbor]

Sounds handy

[pallid yoke]

I also got 40 hours on my flexible time account

[modest bison]

"whatever platform"? any plans for that lol

oof, I was scrolled up

how tf did that happen

[random badger]

prob cause discord > irc 😝

[narrow verge]

😡

[soft hornet]

My question was basically a sneakier "How honest do you plan to be about GPL obligations?" 😛

(acknowledging that the platform could have non-bukkit-based stuff, which obviously doesn't have that issue)

[pallid yoke]

Do you pay the lawyer for us? :P

Cause I ain't trying to understand this shit

[soft hornet]

sulks in the corner

[white pier]

forcing everyone on the platform to be GPL compliant is a giant and unrealistic hassle that isnt going to happen

[soft hornet]

I'll start demanding royalty checks from md_5 and we'll see how it goes. 😛

[white pier]

enforcing some sanity and pushing people towards open source is certainly a noble goal however

[pallid yoke]

Keep us updated ^^

[white pier]

we were kind of memeing a bit about what could happen there but I think we're a bit off from that anyway

stuff like ugly warnings, deprioritizing search results if there are multiple, etc

[random badger]

covering non open source plugin pages with ads for open source alternatives.... 😈

[soft hornet]

Motivate by requiring non-open source projects to submit gpg signatures for all uploads

[white pier]

"you must sit through this 45 minute video where mbaxter tells you what youre doing is wrong and makes him sad"

[soft hornet]

Signatures nearly killed Ore off with community backlash

Only 45? 😦

[random badger]

did ore require them initially?

[white pier]

its your video, we'll make it work

yes

[soft hornet]

"There will be a quiz at the end"

Signatures were our solution to the legitimate problem on BukkitDev of accounts of major projects getting hacked and malicious software being uploaded. It's a thing that happened, so we thought requiring signatures (which seriously takes like 10 minutes to set up, once, and then never needs touching again) wouldn't be that bad. We were very wrong.

[sly mason]

They required them at some point

mbax

you made a mistake

[soft hornet]

Expecting users to do anything beyond the bare minimum? 😄

[sly mason]

You expected people to lift their fingers to prevent an issue they complain/worry about having you solve

[pallid yoke]

Do you wanna guess the percentage of plugins on spigot that don't even use a build tool?

[soft hornet]

Yeah... it's not a happy percentage.

[white pier]

do you want to guess the percentage that have classes full of those eclipse compiler errors

[pallid yoke]

But: could always add github style verified checkmarks

[soft hornet]

Same thing with review queues. We made it so that you could still download unreviewed files, which is better than BukkitDev was, but the warning message? People do not like. 😛

I'd 100% set up my signing stuff for plugins if it got me a cute little checkmark.

[random badger]

could also do a user flair if all your projects have source links

[soft hornet]

At this point for me its as easy as adding a single plugin entry to my pom to start signing.

[white pier]

it would be a nice optional feature, if nothing else

quick, throw more features onto the request pile before mini finishes typing!

[pallid yoke]

Yeah we could add a ton of badges you could wear

"open source enthusiast" -> has more than 5 open source projects

Stupid shit like this

[soft hornet]

Collect all badges for a badge collector badge

[random badger]

could do total project downloads as a badge too

[pallid yoke]

No we also gonna add bad badges

[random badger]

combined projects have > 100k downloads

[pallid yoke]

"freedom hater" for somebody who has all reosurces obfuscated

[random badger]

is there a reliable way to auto check for obfuscation?

[pallid yoke]

Kek theses could actually be fun

No

[random badger]

it'd be neat to have an obfuscated badge for projects

[sly mason]

ez

[pallid yoke]

But that's solve able by the crowd

[sly mason]

Just look for dictionarable terms

[random badger]

ah yes, let the crowd vote if a plugin should get a shame badge

[sly mason]

if you have a class without any words in a dictionary, mark it

[random badger]

that'll turn out well

[sly mason]

:>)

[pallid yoke]

I would 100% rely on ppls reports for if a plugin is labeled wrong

[white pier]

use a dictionary and a prefix

[pallid yoke]

There are ppl on spigot that check every resource upload

[white pier]

catIsBad = 0
int catIsStupid(int catIsAwful)

[pallid yoke]

Playing cat and mouse game for automated detection isn't worth anybodies time

[white pier]

might need to setup a demo project for that

[pallid yoke]

https://staging-ore-vue.spongeproject.net/

Ore staged the Vue branch, in case anybody needs inspiration

[jade ginkgo]

What is the PROD url for hangar

[modest bison]

there is none

[jade ginkgo]

oh okay

Wait a minute, if there is no hangar prod, how to publish paper plugins

[modest bison]

there is a section on the forum

[jade ginkgo]

Oki

[mellow pebble]

Hangar is not finished yet, that's why there's is no prod url

[barren shale]

at some point™️

[sly mason]

is mondai boiz

[narrow verge]

monday funday

[sly mason]

https://www.youtube.com/watch?v=SsmVgoXDq2w

[random badger]

why do I have a notification in here?

[narrow verge]

unread?

someone asked help in wrong channel

[random badger]

ugh. wish discord would have a way to remove notifications for removed messages

[narrow verge]

right click > mark as read?

or automatically

[random badger]

would make deleting pings actually meaningful in those channels that have bots that auto delete pings of staff

automatically

[dense aurora]

nice song

[cinder rain]

Question about the API change, is there an endpoint to simply get the latest build for a given version?

without having to enumerate the builds

[narrow verge]

#general and no, not anymore

[cinder rain]

🙄

[random badger]

hmm ya know, maybe doing what the sponge discord just did wouldn't be a bad idea. having people manually assign a role to see certain channels

with a #roles channel or something

[stark verge]

yea that would be neat

[narrow verge]

ironically would add another channel

[random badger]

right, but the other channels would be hidden until you clicked a reacon to add a role

so it would really reduce channel count for most people I think

[stark verge]

@random badger do it.

[random badger]

lol, I can't do it.

[midnight anchor]

:P

[mortal idol]

.services

[main lava]

.services

[sly mason]

?kick @main lava This is not the place for solicitation

[azure bolt]

ManiaPrison#1718 was kicked | This is not the place for solicitation

[random badger]

damn, some action in #hangar-dev 🙂

[frozen bough]

lawl

[mortal idol]

who moved #760946492483043342 above #hangar-dev

[random badger]

Hmmm, yeah. Just noticed that.

Tbh, should be a bannable offense. Moving channels around... 😛

[modest forge]

👀

kaaaaaaaash pls fix

[random badger]

Wonder what day it is...

[sly mason]

#760946492483043342 is my only sense of weeks passing

[main lava]

lol

[modest forge]

Hmm must be a Wednesday

[pallid yoke]

Guess we need to pick up more activity again to confuse cat ^^

MiniMessage is mostly done and paperweight also doesn't need my attention so I should be able to do stuff this week

Not today tho, am a wreck

[pallid yoke]

Thanks Jake I forgot

Was busy at work today

[random badger]

did you not do the webpack-cli one cause it looks kinda big?

been sitting there for 22 days now

[pallid yoke]

Yeah I looked into it, I think it breaks smth

It's a breaking major version and we need to make sure all plugins support it

Iirc Vue cli didn't even support it yet

[narrow verge]

On hold ⏸️

[random badger]

wtf dependabot... its NOT monday

you are throwing off my whole week

[modest forge]

Dependabot got drunk again

[narrow verge]

((could be a vulnerability fix, those work round the clock))

[midnight anchor]

it is

[narrow verge]

oops 2 days late

[midnight anchor]

haha lol

[random badger]

ahh, the start of a new week

[vocal pebble]

who can help with the plugin. I want to differentiate pve pvp. in the center mklenkom will turn off the fire of TNT and pvp. in the second round, pvp without fire and tnt. all behind 2 circles. anarchy. are there plugins that do this? can anyone help develop such a plugin?

[stiff token]

Not the channel for it. And no recruiting allowed here - check spigot recruitment forum.

[vocal pebble]

@stiff token I thought the developer team for this. I'm sorry I understood.

[stiff token]

This channel is for hangar project. If you want to write plugin on your own - #paper-dev. You should be fine asking if such plugin exists in #general, but I'd recommend asking Google first.

[random badger]

BlackHangar when?

[narrow verge]

No premium remember? Black market for what 😄

[random badger]

doesnt matter.

[modest forge]

👀

[midnight anchor]

we will put free plugins

and inject bitcoin miners into them

ez money

[pallid yoke]

I'll make sure to redirect the pool to my wallet

[safe harbor]

Crypto integration wen

[midnight anchor]

i came up with the idea i should get at least 75%.. duh

[soft hornet]

Open source with a publicly listed CI doesn't stop that site from hosting 'leaked' versions of plugins. I'm sure hangar stuff would show up on such a site.

[stiff token]

@main lava this is not the place for it.

[midnight anchor]

wat

[modest forge]

#general

[obsidian halo]

@slender birch ?

[mellow pebble]

?ban @rotund yarrow Ads

[pallid yoke]

ok guys and girls

I plan to wrap up hangar over xmas

but:

I don't have any clue what needs to be done 😂

so what could go wrong, lol

[barren shale]

well there's no shortage of big tasks 😂

pick something of your liking from the to do column (or move stuff around if you think something else should also be done before a release) :p

[pallid yoke]

heh staging is broken big time

vue doesnt build

ah yes, locally maven throw an NPE

lmao

https://i.imgur.com/Bz4Z0GM.png

[random badger]

Hey mini, the reason I kept stuff inside the vue html element is so the page wouldn’t be blank when it was being loaded. I see you got rid of that for the settings page?

[random badger]

I think it’s pretty much just the issues we have marked to be done, and then we need people to use the site to find bugs.

[pallid yoke]

I got hella confused before I realized that that was duplicated in Vue

[random badger]

Yeah, there are several situations exactly like that. Where it’s duplicates in vue

[pallid yoke]

We only really need that duplication for SEO, which doesn't matter here, so I don't think it makes sense to duplicate it

[random badger]

Ok

[pallid yoke]

Normally you would use something ppl call skeleton

Like how facebook looks when you has low internet for example

Might be worth to try out

[random badger]

Right, I think I know what that is, bunch of low res boxes or smth

Outlines of where stuff will be

[pallid yoke]

Yeah pretty much

[mellow pebble]

just put a sad cat picture there when the page is not loading

[pallid yoke]

We already have the loader I stole from company

[random badger]

Oh, and we need a logo still 🙂

Unless we want to use chew’s amazing depiction of a hangar.

[mellow pebble]

chew also made one? 😮

[random badger]

Oh was that yours? My b

For some reason I thought it was chew’s 😅

[midnight anchor]

something feels... off
https://i.imgur.com/ooApZVD.png

[barren shale]

clear your biscuits

the british version of cookies I mean, of course

[midnight anchor]

lol

still does it :P

[mellow pebble]

nope, same for me

[barren shale]

#blamemini

[midnight anchor]

i even cleared my... wafers
https://i.imgur.com/qxKhQ70.png

[pallid yoke]

^ known

I'll look into it later

I blame dependabot

[midnight anchor]

ah didn't see that lol

[random badger]

Was it my change? Was working for me locally

[pallid yoke]

idk

what did you change

lol

ah the css thing

the error is maximal helpful https://i.imgur.com/eE2HOmD.png

yeah the error is there since that commit

god knows why tho

so for some reason, it looks like the css plugin thingy broke sourcemaps

downgrading to 1.2.0 fixes it

1.3.0 fails

1.2.1 is fine too

[pallid yoke]

so yeah, staging is fixed

[upper flower]

🥳

[random badger]

Huh. I didn’t test building locally, just serving.

[pallid yoke]

yeah and CI just goes thru without failing

thats the real issue

[random badger]

mini, when you get a chance, you wanna look over that latest pr? It should be the solution to allowing multiple versions in the same project to have the same name

[modest bison]

ill tomorrow

[midnight anchor]

he turned into a bot! 😱

[modest forge]

beep boop

[random badger]

Mini, do you have your tab size set to 2 spaces somewhere? or is everything supposed to be 2 spaces? or what happened here https://github.com/PaperMC/Hangar/commit/68dc91a8420a246a78ebd00f093ae5aad17a980f#diff-717e6733c9fe4544add002e40aa2c0176108ddcc0c3fa9b99a91c4689f771c98R78

[pallid yoke]

oh

I copied that from elsewhere

[cinder silo]

not sure if this is a super hangar-related thing, but i thought it would be best for this to go here

someone should make a "Designed for Paper" badge or something to put on plugin pages

or README.mds, etc

[mossy topaz]

a shields.io badge

[cinder silo]

oh, that's how they're made?

i thought they were custom. nvm, thanks

[cinder silo]

hey real quick

where's the register page template

[random badger]

for making an account?

[cinder silo]

yea

[random badger]

umm. somewhere in HangarAuth, lemme find it

[cinder silo]

oh

that would be why i can't find it lol

[random badger]

https://github.com/PaperMC/HangarAuth/blob/master/spongeauth/templates/accounts/register.html

I think that's is

yeah, Auth is totally separate from hangar. eventually that auth will take over the forums as the central auth for all things paper

[cinder silo]

wtf is crispy form

i wanna see that form

[random badger]

I think its probably something that generates a form based on some inputs?

like I said, this was taken straight from sponge so idk how it works

[cinder silo]

yeah fair

[random badger]

https://github.com/PaperMC/HangarAuth/blob/master/spongeauth/accounts/views.py#L251

[cinder silo]

ok wait one last question, do you know where the translation key is?

[random badger]

that's where the view is used

[cinder silo]

keys*

oh

[random badger]

oh also, I should be able to approve your account. cause the email thing doesn't work

so let me know when you've created your acct

[cinder silo]

yeah email is brokey

created

name is bluely

[random badger]

k, dm'd you the link

[cinder silo]

ty, other question - where do these little descriptions come from https://i.imgur.com/9G2mtPF.png\

i wanna fix the discord one, there's no space after the ?

[random badger]

oh huh.

idk where those are

you'd have to dig around in HangarAuth

right here: 😛 https://github.com/PaperMC/HangarAuth/blob/master/spongeauth/accounts/forms.py#L65

[cinder silo]

https://i.imgur.com/7bAANWf.png good job nerds, owned

anyways, thanks

i was super lost

[random badger]

where'd you get that page?

when you created the project?

[cinder silo]

creating a rpoject

yeah

[random badger]

prob cause you don't have https at the start of the url?

[cinder silo]

i mean, it redirected me there - i've been using https

ill retry

yeah

https://i.imgur.com/ZtWjfyW.png

[random badger]

huh

[cinder silo]

here's a video, for the content

looks like any time i submit anything (deleting the two test projects) i get redirected to the http version

[random badger]

yeah, im too tired too look into that. can you make an issue on gh?

[cinder silo]

yep on it rn actually lol

[stark verge]

ooh I wanna help.. if I can lol

[cinder silo]

i have a few grammar tweaks

just need to fix the commits so i can pr it

eh

ill pr it

[stark verge]

I'll honestly be willing to help with anything

[cinder silo]

check the open issues

[stark verge]

ooh ok

oof this is so above my skill level

[mortal idol]

monday again woo

[stiff token]

If you have time - try anyway. I sometimes spent a few days doing "simple" stuff above my level - that's how you learn a lot :)

[stark verge]

I don't even understand what to do tho

.-.

[modest forge]

Did we ever decide on discourse integration vs building our own comments system?

[mortal idol]

md keeps getting more hats

[barren shale]

this isn't a chit chat channel
noone really said anything we should do, so probably what's easier™️ now (integrating)

[modest forge]

The reactions plugin might work but last I saw it seemed like it was dead, sooo

We'll probably have to live without that for now, then if we want to replace it with our own comments, we can do later

https://github.com/discourse/discourse-reactions
Seems like they started working on an official one but haven't touched it for a while

https://github.com/discourse/discourse-reactions/commit/d520c5601514aa636cd7c712da93028a8ca6c3ae

Hmm maybe Retort is still maintained after all

https://github.com/gdpelican/retort

[stark verge]

wuts this

[modest forge]

Although, uh, https://github.com/gdpelican/retort/issues/76

[barren shale]

but like, a check shouldn't be that hard right? oO

[modest forge]

I mean, feel free to dive into the Ruby code if you feel like it

I haven't looked tbh

It doesn't look overly complicated, would probably want to add a before action or something

[barren shale]

oh ruby, well

[modest forge]

https://github.com/gdpelican/retort/blob/master/plugin.rb#L30 Should be able to add something here?

[stark verge]

wth is discourseeeee

[mellow pebble]

https://papermc.io/forums/