#hangar-dev | PaperMC | Page 3

narrow verge · 2020-08-30T18:28:59.082Z

Yeah, all we can do is: (for both issues and prs) * Close or re-open * Manage labels, milestones, and assignees that's it

narrow verge Aug 30, 2020, 6:28 PM

#

Yeah, all we can do is: (for both issues and prs)

Close or re-open
Manage labels, milestones, and assignees
that's it

#

can't even edit/remove comments

barren shale Aug 30, 2020, 6:30 PM

#

the teams are team private

#

👀

narrow verge Aug 30, 2020, 6:30 PM

#

hmm

#

ah then that link probably doesnt work

barren shale Aug 30, 2020, 6:31 PM

#

... else you could just list name-description-hex color for us to copy paste then 😂

narrow verge Aug 30, 2020, 6:31 PM

#

weird how you can't see teams

#

thought they could be public

barren shale Aug 30, 2020, 6:31 PM

#

~~I think they can, but are private by default (?) and noone set them to public~~

narrow verge Aug 30, 2020, 6:32 PM

#

Ah, teams are only visible to members

barren shale Aug 30, 2020, 6:32 PM

#

everytime someone makes a pr we just have that GH head at the top lol https://i.imgur.com/WAXwRvn.png

Imgur

narrow verge Aug 30, 2020, 6:32 PM

#

there's visible to every org member, or only visible to team members

barren shale Aug 30, 2020, 6:35 PM

#

one of Via's members has a transparent avatar, so things like this just look awesome lmao https://i.imgur.com/rGY51Vd.png

Imgur

modest forge Aug 30, 2020, 6:38 PM

#

the system

#

@narrow verge go to sleep

narrow verge Aug 30, 2020, 6:39 PM

#

IT"S 1:30 AM

#

PM*

#

oops

modest forge Aug 30, 2020, 6:39 PM

#

go to sleep

narrow verge Aug 30, 2020, 6:39 PM

#

in 8 hours sure

barren shale Aug 30, 2020, 6:39 PM

#

slep

modest forge Aug 30, 2020, 6:44 PM

#

sleeeeep

barren shale Aug 30, 2020, 6:56 PM

#

@spiral current thanks for the push to do GH projects, now we actually have a better plan on what we're doing 😂

spiral current Aug 30, 2020, 6:56 PM

#

:p

barren shale Aug 30, 2020, 6:57 PM

#

and a nice list of future todos

spiral current Aug 30, 2020, 6:59 PM

#

that's nice

#

but now I forgot what I was looking at before I checked the ping :(

random badger Aug 30, 2020, 6:59 PM

#

yeah, im creating issues for api paths, frontend paths rn. will be good

spiral current Aug 30, 2020, 7:01 PM

#

machine, what's your opinion on tables?

random badger Aug 30, 2020, 7:02 PM

#

gonna have to be more specific... database, dinner, markdown... plenty of tables

#

100% pro dinner tables

spiral current Aug 30, 2020, 7:05 PM

#

smh

random badger Aug 30, 2020, 7:05 PM

#

no but really, what do you mean

pallid yoke Aug 30, 2020, 7:18 PM

#

Organization?

#

Pffffff

#

One weekend where I don't use my PC and get drunk and stuff and suddenly we are organized?

#

😂 😂

barren shale Aug 30, 2020, 7:19 PM

#

kekwhyper

modest forge Aug 30, 2020, 7:23 PM

#

times tables best tables

fluid stratus Aug 30, 2020, 7:40 PM

#

But we took your table, so no time table for you

random badger Aug 30, 2020, 7:42 PM

#

wow, I think I just understood what he was asking...

#

🤦‍♂️

random badger Aug 30, 2020, 8:20 PM

#

🚫 table

spiral current Aug 30, 2020, 8:22 PM

#

well it's too late buddy

#

you expressed interest in tables which is not tolerated :^)

#

/s

dire jasper Aug 31, 2020, 9:48 AM

#

Hopefully Hangar will be a better experience than Polymart too (their ToS has typos 🤦‍♀️)

sly mason Aug 31, 2020, 9:55 AM

#

Polymart also basically harassed me to try to get mcMMO on his site

#

Told him that it's nothing to do with me and to sod off as nicely as possible, but, like, damn

pallid yoke Aug 31, 2020, 9:57 AM

#

ill make sure to harras md to put essentials on hangar 😄

#

but yeah, idk, generally thats not a good idea, lol

#

you want ppl to come to you cause you are a nice platform and you got users/traffic etc

solemn whale Aug 31, 2020, 10:01 AM

#

When javascript transforms "2020-8-31" to 1981

#

PepeHands

solemn whale Aug 31, 2020, 10:55 AM

#

If nobody is already doing the admin/stats I would like to claim it

pallid yoke Aug 31, 2020, 11:23 AM

#

Go Ahead

limpid stump Aug 31, 2020, 12:10 PM

#

@sly mason Polymart is selling yooniks' crap, that's how low their standards are... they're worse than MC-Market

#

I thought MC-Market was scraping the bottom of the barrel, but nope

#

So yeah, Hangar will be a much better experience, especially if no paid mods are allowed

modest forge Aug 31, 2020, 12:12 PM

#

I'll make sure to harass Mini to let me put EssX on Hangar

limpid stump Aug 31, 2020, 12:14 PM

#

I have semi-ancedotal evidence that Aegis is hot garbage

#

And I already proved that Flamecord has no reason to exist because of the mitigation I managed to upstream into BungeeCord after much difficulty.

reef stone Aug 31, 2020, 12:59 PM

#

I heard of polymart, I don't trust anything other than Spigot. Usually something dodgy going on.

narrow verge Aug 31, 2020, 2:12 PM

#

i thought polymart was that one youtube channel

modest forge Aug 31, 2020, 2:13 PM

#

👀

📎 unknown.png

worthy basalt Aug 31, 2020, 2:16 PM

#

@solemn whale transforms how" ?

#

Number("2020-8-31")
NaN
parseInt("2020-8-31")
2020

narrow verge Aug 31, 2020, 2:16 PM

#

maybe it thinks month day year idk, i had a fun time trying to convert a time format like that in Java to a Date

#

had to use Calendar and just split the date string

worthy basalt Aug 31, 2020, 2:17 PM

#

"2020" -8-31
1981
2020 -8-31
1981

#

seems about as correct as one could hope for

solemn whale Aug 31, 2020, 2:23 PM

#

I was sending a List<String> to javascript which contained
just those dates, I had to add qoutes to the strings before it would see them as strings

fluid stratus Aug 31, 2020, 2:26 PM

#

JavaScript does stupid things with dates. It doesn't represent dates as a year starting from 0 in the Gregorian calendar, but as some offset from a year in the Gregorian calendar.

modest forge Aug 31, 2020, 2:26 PM

#

sending a List<String> to javascript
how? json? embedding in freemarker?

fluid stratus Aug 31, 2020, 2:26 PM

#

Pretty much Javascript's entire date/time functionality is a giant joke.

solemn whale Aug 31, 2020, 2:27 PM

#

i added them to the modelandview so i guess embedding in freemarker?

modest forge Aug 31, 2020, 2:29 PM

#

In which case you'd be inserting the string 2020-8-31 into the template without quotes

#

Freemarker isn't magic, it doesn't know you're trying to put a string into a script vs any other part of the page

solemn whale Aug 31, 2020, 2:34 PM

#

Yea, figured it was something like that

random badger Aug 31, 2020, 3:13 PM

#

Dates didn’t start with year 0 tho. There was no year 0. Or am I misunderstanding what you said.

#

That’s why 2020 is NOT the start of a new decade, but Dec 31 2020 will be the last day of a decade

pallid yoke Aug 31, 2020, 3:14 PM

#

Ever day is the end of a decade

#

Just depends which you mean ^^

narrow verge Aug 31, 2020, 3:15 PM

#

who was talking about decades

modest forge Aug 31, 2020, 3:29 PM

#

I have no idea

random badger Aug 31, 2020, 3:41 PM

#

Just thought I’d bring up that lovely debate...

narrow verge Aug 31, 2020, 3:58 PM

#

decads use lua??

fluid stratus Aug 31, 2020, 4:43 PM

#

Year 0 didn't exist, but we start counting from it.

#

I mean, dates are super gross and nothing ever works properly with them anyway, so whatever

#

Seems like there are also different ways to count decades within a calendar, so... idk

barren shale Aug 31, 2020, 4:53 PM

#

people who say 2001 was the start of the new century/2021=new decade are absolute lunatics

#

and that's a fact

random badger Aug 31, 2020, 5:09 PM

#

But years arent zero indexed... there was no year 0 in the Gregorian calendar.

barren shale Aug 31, 2020, 5:10 PM

#

so? doesn't mean we should drop all that is sane smolTHEMAN

fluid stratus Aug 31, 2020, 5:11 PM

#

Don't even know what JS uses, could be that they use ISO 8601:2004 in which there is a year 0.

#

If a decade is ten years, though, and you use a 0-9 system for decades in the Gregorian calendar, would the "first" decade then run from 1 BC to 9 AD?

#

Cause that's eh interesting.

pallid yoke Aug 31, 2020, 5:12 PM

#

A decade is just defined as a timeframe of 10 years

#

You can start wherever

#

It's just that society likes to define special decades

fluid stratus Aug 31, 2020, 5:13 PM

#

Yeah, that's kinda the point. If you define a decade on the calendar as a 0-9 system, such that 2010-2019 would be a decade, then with that reasoning you'd also get 1 BC to 9 AD as a decade.

#

Subsequently 12 BC to 2 BC would be a decade, which is interesting.

#

Or you just skip a year somewhere or something, but that's even more blegh

#

I feel like a 1-0 system makes more sense on a longer timescale, since then 1 AD to 10 AD would be a decade and 10 BC to 1 BC would be one, which aligns nicely.

#

Or just don't design a garbage calendar that skips zero, but whatever,

#

0 to 9 and 10 to 19 is nice because a decade is the period where all digits except the last one of the year are the same. I.e. all values for 198x form a single decade. Problem is what I mentioned above, since year 0 doesn't exist in gregorian calendar, you get a decade that is 1 BC to 9 AD and the decade before that would be 12 BC to 2 BC, which is stupid, because you offset the last digit by two.
With 1-0 you don't have the convenice of 198x forming a single decade, because 1980 is of the previous decade while 1990 is of the decade that also contains 1981-1989, which isn't as great, but at least around year zero, you don't run into the issue that you offset the decade when going into BC: 10 BC to 1 BC is a decade and 1 AD to 10 AD is a decade.

#

0 to 9 is nice for everything in AD, but the moment you go into BC I personally would go for 1 to 0, so you don't have to deal with offset decades.

fluid stratus Aug 31, 2020, 5:50 PM

#

confused screaming

modest forge Aug 31, 2020, 5:50 PM

#

hangar-dev intensifies
https://cdn.discordapp.com/attachments/746367733699969104/749995170099101776/unknown.png

solemn whale Aug 31, 2020, 8:05 PM

#

https://imgur.com/6Nf6bEB.png 'uploads' are those plugins upload on a day?

Imgur

Screenshot

random badger Aug 31, 2020, 8:08 PM

#

I assume so yes. I’d have to look at ore to be sure.

#

im not sure what other uploads it might be referring to

solemn whale Aug 31, 2020, 8:12 PM

#

Yea, neither do I, but sometimes there is some hidden stuff I dont know of

random badger Aug 31, 2020, 8:17 PM

#

wdym hidden stuff...
the only other uploading that happens, are organizations/projects changing their avatars

solemn whale Aug 31, 2020, 8:23 PM

#

oh, not really about this project (yet). But somtimes you assume something and then it happens to be something else

narrow verge Aug 31, 2020, 9:22 PM

#

ok but actually, what is MVP?

random badger Aug 31, 2020, 9:25 PM

#

minimum viable product

#

if you are talking about the project... To-Do is what is needed for mvp

#

and backlog comes after, so not stuff needed for mvp

barren shale Aug 31, 2020, 9:31 PM

#

smh chew assuming my answer was a meme like everyone else’s

narrow verge Aug 31, 2020, 9:32 PM

#

Oh you actually answered

random badger Aug 31, 2020, 9:34 PM

#

yeah, I had to ask again too cause I had no clue what the actual answer was

cursive kraken Aug 31, 2020, 9:42 PM

#

https://imgur.com/6Nf6bEB.png 'uploads' are those plugins upload on a day?
@solemn whale it's version uploads a day

Imgur

Screenshot

solemn whale Aug 31, 2020, 10:09 PM

#

Thanks

velvet gyro Sep 1, 2020, 12:57 AM

#

is hangar live?

#

dam its written in java 😦

narrow verge Sep 1, 2020, 12:58 AM

#

WHATS WRONG WITH JAVA

velvet gyro Sep 1, 2020, 12:58 AM

#

ReactJS / ExpressJS gang

#

for web dev

#

I made a plugin store in 3 days

#

I just feel like

narrow verge Sep 1, 2020, 12:58 AM

#

excuse u, js is sucks... js

velvet gyro Sep 1, 2020, 12:58 AM

#

the development velocity is a lot better

#

I use typescript

vivid cypress Sep 1, 2020, 3:28 AM

#

could always go work with the scala version :p

narrow verge Sep 1, 2020, 3:30 AM

#

fuck it, ChewPlugins, Hangar rewritten in Rails

velvet gyro Sep 1, 2020, 3:54 AM

#

would be fun to make a plugin repo in reactjs

#

id be down

untold idol Sep 1, 2020, 3:58 AM

#

nodejs is bad

#

i prefer 42000 assembler

narrow verge Sep 1, 2020, 4:14 AM

#

isn't react node though

velvet gyro Sep 1, 2020, 4:29 AM

#

yes it is @narrow verge

#

but once built its sending javascript to run on v8

#

in chrome

#

or whatever browser

#

but on a dev environment its node

narrow verge Sep 1, 2020, 4:30 AM

#

aaacckkk

#

node

velvet gyro Sep 1, 2020, 4:30 AM

#

whats wrong with node

narrow verge Sep 1, 2020, 4:30 AM

#

terrible bloated nonsense

velvet gyro Sep 1, 2020, 4:31 AM

#

is jvm not "bloated" then

#

idk the sizes but if we talking in docker containers

#

the docker container needs a nodejs environment or a jvm to run on

#

I generally only do mc development on jvm

#

and use kotlin

#

but for all the other stuff I use node

random badger Sep 1, 2020, 4:35 AM

#

Well we aren’t about to change hangar now...

#

Part of the reason it’s in Java (spring framework) is thats what mini uses professionally, part of it is so people in the Mc community can be more likely to contribute (cause plugins are in java), and partly because ore was in scala.

untold idol Sep 1, 2020, 4:43 AM

#

nodejs advocate also suggests kotlin PepeLaugh

#

but the jvm is 100x better than v8

velvet gyro Sep 1, 2020, 4:43 AM

#

how so

untold idol Sep 1, 2020, 4:43 AM

#

kotlin is syntax soup

velvet gyro Sep 1, 2020, 4:44 AM

#

I think the jvm would scale better if the project is written correctly

#

but you arent building twitter

#

yeah @random badger I mean the frontend for reactjs

#

not the backend to nodejs

random badger Sep 1, 2020, 4:44 AM

#

There really isn’t a lot of front end...

velvet gyro Sep 1, 2020, 4:45 AM

#

exactly

random badger Sep 1, 2020, 4:45 AM

#

Right now, it’s just a few vue templates

velvet gyro Sep 1, 2020, 4:45 AM

#

https://nextjs.org/

Next.js by Vercel - The React Framework

Production grade React applications that scale. The world’s leading companies use Next.js by Vercel to build static and dynamic websites and web applications.

#

I really like this

#

I use it since it has server side rendering on react

random badger Sep 1, 2020, 4:45 AM

#

And we def aren’t gonna change away from that because thats actually the one thing that ore and hangar can share.

velvet gyro Sep 1, 2020, 4:46 AM

#

ah ok

random badger Sep 1, 2020, 4:46 AM

#

More stuff is being moved to the front end to eventually remove the query webjar dependency. But it’s not there yet

vivid cypress Sep 1, 2020, 4:49 AM

#

honestly complaining about the language used is probably the least useful thing you could be doing in this channel

#

it's in java because people know java

velvet gyro Sep 1, 2020, 4:50 AM

#

📎 unknown.png

vivid cypress Sep 1, 2020, 4:50 AM

#

unless you want to port and maintain ore yourself, your opinion is worth approximately nothing.

velvet gyro Sep 1, 2020, 4:50 AM

#

I just expressed sadness

#

that it was written in java

#

I know its not feasible to just

#

hop on over

untold idol Sep 1, 2020, 4:50 AM

#

theres no reason to use node

#

paper is a community built on java

vivid cypress Sep 1, 2020, 4:50 AM

#

plus every single developer in this community already knows java

untold idol Sep 1, 2020, 4:50 AM

#

^

#

why switch to node for worse perf and syntax

#

4HEad

leaden lily Sep 1, 2020, 4:51 AM

#

Skript developers punching the air right now.

velvet gyro Sep 1, 2020, 4:51 AM

#

Im pretty sure last time I checked

#

nodejs is faster

untold idol Sep 1, 2020, 4:51 AM

#

lol no

#

not remotely

#

for web dev specifically, Java's inter-thread memory sharing is faster than js's inter-process sharing

#

which matters

velvet gyro Sep 1, 2020, 4:54 AM

#

I mean I figured jvm should be faster

#

but I be googling

#

I googled more now

#

and there are articles going towards one side or another

untold idol Sep 1, 2020, 4:55 AM

#

it's largely task based

#

but generally, nodejs does nothing special and is very rarely, if ever, faster than java at a specific task

sharp quest Sep 1, 2020, 4:57 AM

#

pfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffft js and speed

untold idol Sep 1, 2020, 4:57 AM

#

saying that one language is faster over another is odd in the first place but eh

sharp quest Sep 1, 2020, 4:58 AM

#

js is the exception

velvet gyro Sep 1, 2020, 4:58 AM

#

I've built a server is Go

untold idol Sep 1, 2020, 4:58 AM

#

go is decent

velvet gyro Sep 1, 2020, 4:58 AM

#

which is quite liked

sharp quest Sep 1, 2020, 4:58 AM

#

go is pepega

velvet gyro Sep 1, 2020, 4:58 AM

#

I looked at Rust but it doesnt seem like it is fast to write code in

#

like Im tryna get stuff done, and it seems to have a steeper learning curve

untold idol Sep 1, 2020, 4:58 AM

#

go is great once you learn it

velvet gyro Sep 1, 2020, 4:58 AM

#

yeah

#

I am still kinda new to that, but I use javascript for backends right now because of next.js

#

it has serverless functions built in

#

so I kinda just use that

#

no deployment worries, but the latency is a bit higher

#

https://ktor.io/

#

this is a cool framework too, I tried it

#

but you guys dont like kotlin Hehe

vivid cypress Sep 1, 2020, 5:01 AM

#

kotlin is decent, but bukkit's library situation is too fucked to be able to produce kotlin apis

velvet gyro Sep 1, 2020, 5:01 AM

#

Ive been building stuff in Kotlin a lot recently

#

but I agree the APIs are kinda weird champ

#

but I can figure it out generally because of autocomplete when using java

#

You just gotta know to hit Companion objects

untold idol Sep 1, 2020, 5:02 AM

#

kotlin is decent, but bukkit's library situation is too fucked to be able to produce kotlin apis
kotlin-java interop in it of itself is fucked

velvet gyro Sep 1, 2020, 5:02 AM

#

can we define fucked

#

it works

vivid cypress Sep 1, 2020, 5:02 AM

#

there are some annoying issues

velvet gyro Sep 1, 2020, 5:02 AM

#

I wrote a large plugin recently and have "plugins" for my plugin, and some are in java

vivid cypress Sep 1, 2020, 5:02 AM

#

some overloads that java accepts aren't accepted by kotlin because they're ambiguous, so you have to explicitly cast to the variant you want

untold idol Sep 1, 2020, 5:02 AM

#

it is very slow, and has had some major ish bugs for a long time

velvet gyro Sep 1, 2020, 5:03 AM

#

yeah some of my code was lookin weird, but I didnt know it was slow

#

I guess i never considered it

untold idol Sep 1, 2020, 5:03 AM

#

no no

vivid cypress Sep 1, 2020, 5:03 AM

#

slow compile times or sth?

untold idol Sep 1, 2020, 5:03 AM

#

i meant the time it takes to resolve

#

in ide+slower compile times

velvet gyro Sep 1, 2020, 5:03 AM

#

ah

vivid cypress Sep 1, 2020, 5:03 AM

#

half and half kotlin-java projects are the worst

velvet gyro Sep 1, 2020, 5:03 AM

#

I dont actually do that

#

I havemodules

vivid cypress Sep 1, 2020, 5:03 AM

#

(that's where PEX is right now lol)

velvet gyro Sep 1, 2020, 5:03 AM

#

which are pure java

#

or pure kotlin

#

I did pure java modules to test if other devs can use my api

untold idol Sep 1, 2020, 5:04 AM

#

i think of kotlin like i think of lombok

velvet gyro Sep 1, 2020, 5:04 AM

#

oof

#

I dont like lombok

untold idol Sep 1, 2020, 5:04 AM

#

don't use it in public

velvet gyro Sep 1, 2020, 5:05 AM

#

📎 unknown.png

#

this is like 200 kotlin files

#

the compiler is really slow

#

but if you dont clean everytime

#

its quick enough

#

📎 unknown.png

untold idol Sep 1, 2020, 5:06 AM

#

you're using

#

maven

#

with kotlin??

velvet gyro Sep 1, 2020, 5:06 AM

#

ok I dont anymore

#

but

#

this project I had other developers working with me

#

and they didnt know gradle

#

I use gradle for everything I need

#

gradle's compiler for kotlin is a lot faster or whatever magic it does

#

I think its the same compiler but

untold idol Sep 1, 2020, 5:07 AM

#

ok we should stop crowding up hangar channel 😄

velvet gyro Sep 1, 2020, 5:07 AM

#

tru

#

I go to sleep

#

nice talking to u jroy

untold idol Sep 1, 2020, 5:08 AM

#

:p

main lava Sep 1, 2020, 5:54 AM

#

how do you delete someone else's message

vivid cypress Sep 1, 2020, 6:08 AM

#

ban them

pallid yoke Sep 1, 2020, 6:34 AM

#

I feel like we need to moderate this channel better, lol

vivid cypress Sep 1, 2020, 6:35 AM

#

no moderation

#

let's talk about sandwiches

untold idol Sep 1, 2020, 6:35 AM

#

xqcM

#

free channel

pallid yoke Sep 1, 2020, 6:35 AM

#

If you got nothing better to contribute to this project, other than ewww java, I'll ask you to kindly troll elsewhere

distant jasper Sep 1, 2020, 6:36 AM

#

Let's rewrite it on brainfuck

barren shale Sep 1, 2020, 1:21 PM

#

@solemn whale no need for custom mappers there https://github.com/PaperMC/Hangar/pull/106/commits/b429a349c59b73eca4c7c581c69d45a1b7155a8c

solemn whale Sep 1, 2020, 1:26 PM

#

Ah okay, good to know! Thank you

random badger Sep 1, 2020, 2:08 PM

#

@solemn whale just did a few small fixes on the stats.ftlh file https://github.com/PaperMC/Hangar/commit/962b1aa568e223d3c7ad09bd9a9a98073a50e2ad

solemn whale Sep 1, 2020, 2:13 PM

#

Yea I can see why 😅

random badger Sep 1, 2020, 2:13 PM

#

https://github.com/PaperMC/Hangar/commit/962b1aa568e223d3c7ad09bd9a9a98073a50e2ad#diff-c42cf1d459de670b48b9c4633f44a310L117 I miss the shit like this all the time

#

cause it doesn't pop out as an error

solemn whale Sep 1, 2020, 2:33 PM

#

Yea, guess it was the same for me

solemn whale Sep 1, 2020, 3:32 PM

#

I was looking at the admin/health and the missingFiles, do we want to check all files everytime someone opens admin/health? Or all unhealthyProjects in that list? I cant really figure it out from ore's code, not sure where the projects is from https://github.com/SpongePowered/Ore/blob/staging/ore/app/controllers/Application.scala#L147

random badger Sep 1, 2020, 3:39 PM

#

yeah, I don't think there should be any caching on any of the admin pages

#

since they aren't gonna be used by everyone (only those with perms) and its important for them to have the latest information

cursive kraken Sep 1, 2020, 7:43 PM

#

I was looking at the admin/health and the missingFiles, do we want to check all files everytime someone opens admin/health? Or all unhealthyProjects in that list? I cant really figure it out from ore's code, not sure where the projects is from https://github.com/SpongePowered/Ore/blob/staging/ore/app/controllers/Application.scala#L147
@solemn whale https://github.com/SpongePowered/Ore/blob/9445350c31c59be7d96164943873bec764372fbc/orePlayCommon/app/db/impl/access/ProjectBase.scala#L119

GitHub

SpongePowered/Ore

Repository software for Sponge plugins and Forge mods - SpongePowered/Ore

GitHub

SpongePowered/Ore

Repository software for Sponge plugins and Forge mods - SpongePowered/Ore

#

It's an implicit from OreControllerComponents

solemn whale Sep 1, 2020, 7:45 PM

#

oooh, there it is! Thank you

cursive kraken Sep 1, 2020, 7:46 PM

#

No problem

narrow verge Sep 1, 2020, 8:46 PM

#

Do yall have an email service in mind? I just use sendgrid

pallid yoke Sep 1, 2020, 8:52 PM

#

No clue what the forums use

#

We would most likely just use that

sweet heron Sep 1, 2020, 8:54 PM

#

how will we be able to design our plugin threads? with markdown? bbcode?

worthy basalt Sep 1, 2020, 8:54 PM

#

ill prob just handle the mail

barren shale Sep 1, 2020, 8:55 PM

#

markdown

sweet heron Sep 1, 2020, 8:56 PM

#

great👍

narrow verge Sep 1, 2020, 8:59 PM

#

bbcode is torture

#

markdown and html too maybe? Just no styles or script?

#

oh and import from github readme, very useful there too

barren shale Sep 1, 2020, 9:00 PM

#

markdown. 😛

#

yeah that’s also planned with the whole GH integration

pallid yoke Sep 1, 2020, 9:04 PM

#

Doesn't markdown support html anyways? I don't remember which engine I implemented

narrow verge Sep 1, 2020, 9:05 PM

#

Oh, I suppose it does

modest forge Sep 1, 2020, 9:16 PM

#

Pretty sure it's just plain SMTP (at least, that's what auth uses so I assume Ore is the same)

pallid yoke Sep 1, 2020, 9:17 PM

#

Oh yeah for mail we can just use javas mail api

narrow verge Sep 1, 2020, 9:17 PM

#

ah, i was referring to sendgrid being the actual SMTP server

pallid yoke Sep 1, 2020, 9:18 PM

#

Do they offer smtp? I assumed it's a fancy api

narrow verge Sep 1, 2020, 9:18 PM

#

Yes, I use it

pallid yoke Sep 1, 2020, 9:18 PM

#

But then it's even easier and we don't need to do anything fancy

#

Just smtp via javas api and config

narrow verge Sep 1, 2020, 9:18 PM

#

Yep, it's as simple as setting up the dns records, I don't know the pricing or plans though

#

ah, 100/day on free

pallid yoke Sep 1, 2020, 9:20 PM

#

Yeah, that's not gonna cut it

#

Am assuming there is already a mail server setup for the forum that we would just configure

#

Like, actual mailboxes and shit

narrow verge Sep 1, 2020, 9:22 PM

#

fancy, hope that works out

random badger Sep 1, 2020, 9:24 PM

#

markdown can support html, but it can be made to not support it (see github's markdown)

pallid yoke Sep 1, 2020, 9:25 PM

#

GitHub supports some html

#

I think we should do too, as long as it's save and ppl don't go crazy

random badger Sep 1, 2020, 9:30 PM

#

yeah

#

no iframes or something tho 😆

#

and... no script tags 🙂

fluid stratus Sep 1, 2020, 9:44 PM

#

Aww, why not? I can't imagine any issues would come up when allowing people to put their own custom scripts on hangar.

random badger Sep 1, 2020, 9:58 PM

#

open a feature request....

and get banned subsequently from opening issues

#

pretty sure there have been pure css games that have been created. if we allow style tags, you probably can make one of those

solemn whale Sep 1, 2020, 10:44 PM

#

Yea, have seen a few people claiming that css is turing compleet, havent seen any evidence about it yet

vivid cypress Sep 1, 2020, 11:44 PM

#

yeah, let's get customizable pages myspace-style

random badger Sep 1, 2020, 11:47 PM

#

I think I remember someone in my 4th grade class having a myspace page... but other than that...

random badger Sep 2, 2020, 3:36 AM

#

k, finally figured out how to get docker to run everything (Hangar & HangarAuth) together and STILL have hot-reloading via spring devtools. if anyone has any better ideas, ping me https://github.com/PaperMC/Hangar/pull/108

GitHub

Sync sso endpoint by Machine-Maker · Pull Request #108 · PaperMC/Ha...

Doing a PR in case anyone has any better suggestions regarding the docker changes.
Read the README changes to get a better idea of how it works.
This should continue to allow hot-reloading of the f...

somber flicker Sep 2, 2020, 4:01 AM

#

@pallid yoke are yy seriously using sendgrid as an SMTP server?

narrow verge Sep 2, 2020, 4:01 AM

#

no, not enough for what we need apparently

somber flicker Sep 2, 2020, 4:01 AM

#

At last check the entire infrastructure is blacklisted by hotmail/outlook anyway

#

unless you stump up for a private IP

worthy basalt Sep 2, 2020, 4:32 AM

#

ill be handling the mail. I run my own mail servers 😛

#

but i did use mailgun for my super important emails, but "you gots mail" just goes out smtp

grave gazelle Sep 2, 2020, 4:58 AM

#

ill be handling the mail. I run my own mail servers 😛
Any recommendations for the mail server app

pallid yoke Sep 2, 2020, 7:32 AM

#

@pallid yoke are yy seriously using sendgrid as an SMTP server?
@somber flicker no, I never used sendgrid before, and hangar doesn't use anything right now

somber flicker Sep 2, 2020, 7:44 AM

#

Ok cool - the free service they provide is shocking

#

its deliverability is bad

hearty lynx Sep 2, 2020, 4:09 PM

#

(if you have the GitHub student pack their pro plan is free for 2 years)

narrow verge Sep 2, 2020, 4:12 PM

#

Yes but only for educational purposes

#

As with anything in the pack

#

Not supposed to be used for stuff like this or anything professional

worthy basalt Sep 2, 2020, 4:28 PM

#

@somber flicker because us ESP's tend to keep high risk clients separate from low risk clients, free = abuse, dont want to risk impacting paying customers deliverability

#

we have separate sending pools for our customers at work, and if people pay, they can get a dedicated pool/ip

somber flicker Sep 2, 2020, 10:09 PM

#

No I understand why @worthy basalt but I didnt want Hangar to go with that infrastucture

#

you would be better off using a VP

gleaming pagoda Sep 3, 2020, 5:28 AM

#

What is hangar

mortal idol Sep 3, 2020, 5:29 AM

#

if you are serious, read pins
if you are not, well its your death

gleaming pagoda Sep 3, 2020, 5:29 AM

#

Oh ok thank you

random badger Sep 3, 2020, 5:38 AM

#

Hangar is life

#

Anyone know anything about caching maven dependencies in a docker container?

stiff token Sep 3, 2020, 7:02 AM

#

What you mean exactly?

#

If you want to cache them on build-time, I don't think it's viable tbh.

#

Unless you only mean caching them as long as pom.xml doesn't change - then you could add pom.xml to image, run some maven command to fetch dependencies (not sure what it'd be), add rest of code, build.

#

And the cache will invalidate on pom.xml change, but if only code does change, it'll have the deps cached.

#

If you are running on Linux, you might try to abuse Buildkit build-time mounts, not sure if they are rw though. And it doesn't work on Windows, so...

random badger Sep 3, 2020, 7:31 AM

#

Yeah, caching as long as the POM doesn’t change

#

Or wait

pallid yoke Sep 3, 2020, 7:31 AM

#

Yeah, layers will work then

#

I think I tried to do that?

#

I remember smth

stiff token Sep 3, 2020, 8:42 AM

#

Hmm, it looks like maven can't do that. At least I can't find it.

#

Oh, nvm. There seems to be dependency goal.

barren shale Sep 3, 2020, 9:23 AM

#

no, a better replacement ;)

#

have fun

pallid yoke Sep 3, 2020, 9:49 AM

#

What just happened

main lava Sep 3, 2020, 10:01 AM

#

~~spiot is better than paper happened~~

barren shale Sep 3, 2020, 10:01 AM

#

spiot*

modest forge Sep 3, 2020, 10:03 AM

#

spiot

distant jasper Sep 3, 2020, 10:39 AM

#

spagit

main lava Sep 3, 2020, 11:06 AM

#

spaget

solemn whale Sep 3, 2020, 11:13 AM

#

Yea, lets call it spaghet

sly mason Sep 3, 2020, 12:26 PM

#

Anyone know anything about caching maven dependencies in a docker container
What you'd do is store the containers .m2 folder somewhere on the disk

stiff token Sep 3, 2020, 1:12 PM

#

But you can't do that on build time Cat.

#

You can do that with making sure there's a step that downloads the deps, but no steps before it can invalidate the cache.

sly mason Sep 3, 2020, 1:21 PM

#

changing source files such as the pom would bust that one though?

stiff token Sep 3, 2020, 1:24 PM

#

You can copy POM - download dep - copy rest of sources - build.
At least if onyl source and not deps change, it'll reuse it.

#

I wonder if the Buildkit builder mounts are RW and can be used for directiories - maybe they could be abused.

#

I'll see what I can come up with when I'll get off of work in like an hour or so.

sly mason Sep 3, 2020, 1:30 PM

#

See, the normal "fix" is often to just use a volume for the .m2 folder so you can shove it on disk, docker really wasn't designed for stuff like this too well

stiff token Sep 3, 2020, 1:51 PM

#

I mean, you can use volume, but you can't do it on build time.

#

And dockers caching works quite well, especially with Buildkit enabled. But it won't provide incremental caching like maven has.

random badger Sep 3, 2020, 6:13 PM

#

yeah, its not that big an issue. it only has to download deps once per dev session. just when I initially build the containers, it downloads them, but then I can rebuild with intellij, and no need to download them again

#

hmm... it seems that on a users page, you can't see any projects they are a member of, only projects they own

#

I feel like you should be able to see projects they are a part of as well right?

barren shale Sep 3, 2020, 6:18 PM

#

doesn't fit the userpage's purpose, if anything in an extra section (or even page) only visible to yourself

#

imo that is

#

similar to how GH does it, just not as hidden away as there (you have to go to settings->repositories, which is rather annoying)

random badger Sep 3, 2020, 6:21 PM

#

so you don't think other people should be able to see a list of repos you are a member of?

#

only if they come across a project that has you as a member, they'll know

barren shale Sep 3, 2020, 6:21 PM

#

yeah, since it's not your project then (and otherwise of the org)

sly mason Sep 3, 2020, 6:22 PM

#

There are some orgs you might not wanna be associated with

random badger Sep 3, 2020, 6:22 PM

#

well they do see a list of orgs you are in

barren shale Sep 3, 2020, 6:22 PM

#

he's specifically talking about project membership I think

random badger Sep 3, 2020, 6:22 PM

#

that's already part of ore

sly mason Sep 3, 2020, 6:22 PM

#

e.g. that rando joke project you have from 6th grade

random badger Sep 3, 2020, 6:22 PM

#

yeah, im talking just about project membership

barren shale Sep 3, 2020, 6:25 PM

#

so you don't think other people should be able to see a list of repos you are a member of?
yea

random badger Sep 3, 2020, 6:26 PM

#

ok

barren shale Sep 3, 2020, 6:31 PM

#

but https://github.com/PaperMC/Hangar/issues/113

narrow verge Sep 3, 2020, 6:35 PM

#

Like GitHub?

#

I mean on GitHub everyone can be private

barren shale Sep 3, 2020, 6:36 PM

#

yeah like github. being able so set membership private in projects and orgs (just except your own non-org project)

narrow verge Sep 3, 2020, 6:37 PM

#

Yeah

random badger Sep 3, 2020, 6:40 PM

#

k, so we're gonna def need to add a db migration system

#

cause there's no way were are gonna think of everything before release

barren shale Sep 3, 2020, 6:42 PM

#

all shame jake!!!! https://github.com/PaperMC/Hangar/commit/e6ffe6c1c2f1510cb37bd3fad06fdda2554e937e#diff-ac6b28499a7ca6129bf6eafc7e5f1a32R70

#

runs

random badger Sep 3, 2020, 6:42 PM

#

wow...

#

see there is where I would amend the latest commit and then force push

#

but idk if I should, mini said something about force pushing messing up gitlab or something

barren shale Sep 3, 2020, 6:43 PM

#

tinfoilhat

#

I'll get rid of them with another one-line fix lol

random badger Sep 3, 2020, 6:45 PM

#

I think you missed your daily commit yesterday

barren shale Sep 3, 2020, 6:45 PM

#

yea :(

random badger Sep 3, 2020, 6:47 PM

#

k, onto org invites

narrow verge Sep 3, 2020, 6:48 PM

#

I just modify the database in production

solemn whale Sep 3, 2020, 7:11 PM

#

You're a monster!

narrow verge Sep 3, 2020, 7:16 PM

#

dont worry, I enabled heroku maitanence mode if it goes wrong

#

and when i remember to, take a backup

#

it's a miracle everything is still intact lmao

#

prod database USED to be dev database too, thats a whole other can of worms though

narrow verge Sep 3, 2020, 7:45 PM

#

what java is hangar going to be ran on?

#

i.e what sdk do i use?

stiff token Sep 3, 2020, 7:46 PM

#

I saw java-14 being used in docker.

random badger Sep 3, 2020, 7:46 PM

#

yeah, the docker is 14, but pom has 11

#

idk why

narrow verge Sep 3, 2020, 7:47 PM

#

we need siwtch exporesson!

random badger Sep 3, 2020, 7:48 PM

#

is that 14?

stiff token Sep 3, 2020, 7:48 PM

#

We need to select all the java files in IJ and run Ctrl+Alt+Shift+K !

random badger Sep 3, 2020, 7:48 PM

#

what's that do?

stiff token Sep 3, 2020, 7:48 PM

#

AKA convert all Java files to Kotlin 😛

random badger Sep 3, 2020, 7:48 PM

#

nokotlin

narrow verge Sep 3, 2020, 7:49 PM

#

ru serious? NO

#

lol

#

imma make a pr that does all the java 14 fancy changes since we're running on 14

random badger Sep 3, 2020, 7:50 PM

#

go ahead

narrow verge Sep 3, 2020, 7:51 PM

#

yallve been busy dangh

📎 unknown.png

random badger Sep 3, 2020, 7:51 PM

#

idk what im looking at?

narrow verge Sep 3, 2020, 7:51 PM

#

thats the map of all files

#

middle is root

random badger Sep 3, 2020, 7:52 PM

#

huh, ive never seen something like that before. neat

barren shale Sep 3, 2020, 7:52 PM

#

we didn't have any reason to use 14 (since there's not too many features helpful to us in code), so we stuck to 11 to also have more people able to run it on their own setup (cc mini)

#

not sure why the docker part uses 14

random badger Sep 3, 2020, 7:53 PM

#

but I mean, if someone is going to contribute, it can't be that much of a hassle for them to install 14 right?

narrow verge Sep 3, 2020, 7:53 PM

#

all i have is 8 and 14

#

holy hell all the deps lol

random badger Sep 3, 2020, 7:55 PM

#

yes, there are a bunch

barren shale Sep 3, 2020, 7:55 PM

#

for the discussion page I'd personally vote against signatures, since they mostly interrupt read flow

narrow verge Sep 3, 2020, 7:56 PM

#

BEANS? :O

📎 unknown.png

barren shale Sep 3, 2020, 7:56 PM

#

if you want to say something, put it in your profile sig imo

random badger Sep 3, 2020, 7:56 PM

#

but HOW CAN I advertise my plugins 🙂

barren shale Sep 3, 2020, 7:56 PM

#

or what do you think

narrow verge Sep 3, 2020, 7:56 PM

#

eh, signatures are useless, ive never seen one that im like "now that's a signature"

#

it feels like those blimps with ads flying behind them

barren shale Sep 3, 2020, 7:57 PM

#

even just 3 lines of signature text can put off if the reply itself is just 1-2 lines smolEyes

narrow verge Sep 3, 2020, 7:57 PM

#

hope yall ready

📎 unknown.png

barren shale Sep 3, 2020, 7:57 PM

#

so yeah, if noone has a strong case for signatures, I'll remove them from the discussion issue again 👀

narrow verge Sep 3, 2020, 7:57 PM

#

it's an against from me

random badger Sep 3, 2020, 8:05 PM

#

the way the bukkit forums handle sigs, is they only have it on the first reply in the thread

#

so its not taking up a ton of space through out the entire thread

barren shale Sep 3, 2020, 8:20 PM

#

sounds like an alternative. or even having an option to hide them kneneny

random badger Sep 3, 2020, 8:21 PM

#

and well just use markdown for formatting for posts right?

#

ore doesn't have a review/rating system, do we want to add one of those too?

narrow verge Sep 3, 2020, 8:26 PM

#

bad news for the hangar crew

#

75 spring errors and counting

random badger Sep 3, 2020, 8:28 PM

#

what errors are you talking about?

narrow verge Sep 3, 2020, 8:28 PM

#

it's finishing up

#

every single one is autowiring for BEANS

📎 unknown.png

random badger Sep 3, 2020, 8:28 PM

#

nope, ignore them

narrow verge Sep 3, 2020, 8:29 PM

#

smh the beans are erroring and youre ignoring?

random badger Sep 3, 2020, 8:29 PM

#

they are all either for HangarDao<?> or HttpServletRequest

#

the beans exist

#

the IDE just doesn't know it

narrow verge Sep 3, 2020, 8:29 PM

#

smh

#

IDE is

#

whatever the word is

#

oblivious?

random badger Sep 3, 2020, 8:30 PM

#

well its just so we don't have to manually create a bean for every DAO since there are like 20

#

    @Bean
    @Scope(ConfigurableBeanFactory.SCOPE_PROTOTYPE)
    public <T> HangarDao<T> hangarDao(Jdbi jdbi, InjectionPoint injectionPoint) {
        if (injectionPoint instanceof DependencyDescriptor) {
            DependencyDescriptor descriptor = (DependencyDescriptor) injectionPoint;
            //noinspection unchecked
            return new HangarDao<>((T) jdbi.onDemand(descriptor.getResolvableType().getGeneric(0).getRawClass()));
        }
        return null;
    }

barren shale Sep 3, 2020, 8:31 PM

#

a lot of people here dislike rating systems, so I think that’s a no (tho I feel indifferent about it)

narrow verge Sep 3, 2020, 8:32 PM

#

📎 unknown.png

#

pretty much it

barren shale Sep 3, 2020, 8:33 PM

#

lol going over ide warnings won’t get you anywhere

#

since 9/10 of them are probably just eh, wrong

random badger Sep 3, 2020, 8:33 PM

#

fix all typos first

stiff token Sep 3, 2020, 8:34 PM

#

chew go over warnings and put @SuppressWarnings() on all of them 😛

random badger Sep 3, 2020, 8:34 PM

#

what's the freemarker error?

narrow verge Sep 3, 2020, 8:34 PM

#

the img alt for the paper logomark is "spongie" still, intentional?

#

AH HA

#

TYPO SPOTTED

#

literally unusable

#

misspelled class name... uh oh

random badger Sep 3, 2020, 8:39 PM

#

what is misspelled?

narrow verge Sep 3, 2020, 8:39 PM

#

"PagesSerivce"

#

📎 unknown.png

modest phoenix Sep 3, 2020, 8:39 PM

#

It’s intenden

#

It’s a serivce not a service

narrow verge Sep 3, 2020, 8:39 PM

#

intended typo??

modest phoenix Sep 3, 2020, 8:39 PM

#

Yes

#

Nono service

narrow verge Sep 3, 2020, 8:39 PM

#

why

modest phoenix Sep 3, 2020, 8:40 PM

#

Yesyes serivce

random badger Sep 3, 2020, 8:40 PM

#

its a serivce

#

not a service

narrow verge Sep 3, 2020, 8:40 PM

#

java
ChannelService.InvalidChannelCreationReason validateChanneUpdate(long projectId, String oldChannelName, @Define String channelName, @Define long colorValue);```
I assume that's intentional too?

modest phoenix Sep 3, 2020, 8:40 PM

#

Yes

#

Channe no l cause we no loosers

narrow verge Sep 3, 2020, 8:41 PM

#

but above it's java ChannelService.InvalidChannelCreationReason validateChannelCreation

#

hm

modest phoenix Sep 3, 2020, 8:41 PM

#

Don’t worry about it drink some alcohol

random badger Sep 3, 2020, 8:41 PM

#

#BlameKenny

#

pretty sure he was doing channel creation

narrow verge Sep 3, 2020, 8:42 PM

#

what about java String header = request.getHeader("X-Frowarded-For");

barren shale Sep 3, 2020, 8:42 PM

#

it’s just... frorwarding

modest phoenix Sep 3, 2020, 8:42 PM

#

It’s new https6 standard chew

narrow verge Sep 3, 2020, 8:43 PM

#

alright well other than those I found 1 legit typo

modest phoenix Sep 3, 2020, 8:44 PM

#

Lies

narrow verge Sep 3, 2020, 8:46 PM

#

Unless resolved is spelled... resovled

modest phoenix Sep 3, 2020, 8:47 PM

#

Give context

narrow verge Sep 3, 2020, 8:48 PM

#

I forgot the file

#

But it was something like "Flag resovled by" instead of "Flag resolved by"

random badger Sep 3, 2020, 8:49 PM

#

ok, so how tf are org members supposed to edit a project owned by an org

#

where is the logic for that?

thorny bane Sep 3, 2020, 8:51 PM

#

They can't :D

#

That's why paper explicitly requests that PRs are submitted through non org accounts

#

Oh org members

random badger Sep 3, 2020, 8:51 PM

#

huh?

#

im talking about hangar

#

hence #hangar-dev

thorny bane Sep 3, 2020, 8:52 PM

#

Yes and? I thought you were talking about people editing PRs submitted by orgs

#

I misread

random badger Sep 3, 2020, 8:52 PM

#

no, talking about plugins that people post to hangar that are owned by an organization they created on hangar

random badger Sep 3, 2020, 9:17 PM

#

k, I figured it out

random badger Sep 3, 2020, 10:34 PM

#

@modest forge ok, got an issue here with hangarauth

#

for some reason, the calls to /sync_sso aren't synchronous or something when they are called post_save on the user model

#

any ideas? the create user endpoint needs to wait until it makes the /sync_sso request and gets a response before its sending its own response

#

shit needs to happen like this

📎 unknown.png

#

from top to bottom, except the create_user response is being sent before the /sync_sso request is sent

#

which is big no-no

#

k, so for the time being, the user will still be manually created in the org create method. its not a big deal because the /sync_sso will still give it the global organization role

random badger Sep 4, 2020, 12:19 AM

#

k, org invites are done

narrow verge Sep 4, 2020, 12:22 AM

#

Hell yes

random badger Sep 4, 2020, 12:25 AM

#

there really isn't a whole lot of big things left

narrow verge Sep 4, 2020, 12:26 AM

#

Well done, I assume just some polishing up, then beta, then bug fixes, then release

#

@lilac plinth #announcements

random badger Sep 4, 2020, 12:26 AM

#

yeah, the issues are a bunch of small things that need to be checked and done

narrow verge Sep 4, 2020, 12:27 AM

#

Indeed but please be on topic or move to #paper-help

#

#paper-help

#

Yes, ask there

random badger Sep 4, 2020, 2:59 AM

#

in ore, where do you go to edit your channels?

#

the release channels

random badger Sep 4, 2020, 5:25 AM

#

holy hell, the user admin page is a mess. but finally got it error/free and functional

barren shale Sep 4, 2020, 7:18 AM

#

yeah I don’t think you actually have any button or something to go to channel editing, I always manually opened author/slug/channels

random badger Sep 4, 2020, 7:35 AM

#

Yeah, there supposed to be one, but no one had the perm to see it.

#

So I gave that perm to project dev/owner

modest forge Sep 4, 2020, 7:45 AM

#

@random badger There's two modes that the scheduler library works in, one synchronous and one asynchronous, and I don't know how they're running SpongeAuth in production

#

We can make it always synchronous, but that means if auth can't reach Discourse or Hangar then any request that triggers sync_sso will fail

#

ie user creation, profile edits etc will just error out

random badger Sep 4, 2020, 1:05 PM

#

Well the only place I can think of where it has to be sync is org creation. But we can get around that by manually creating the org user instead of relying on /sync_sso to create it.

#

K, so what’s up with these actor routes? What are they supposed to do?

#

GET /pantopticon/actor-tree

#

GET /pantopticon/actor-count

barren shale Sep 4, 2020, 1:14 PM

#

looks like some local debugging thing?

#

not sure if useful, but certainly not required

#

https://github.com/ScalaConsultants/panopticon-tui

#

yeah you can throw it out lol

main lava Sep 4, 2020, 1:24 PM

#

What is hangar?

dire jasper Sep 4, 2020, 1:25 PM

#

Upcoming Spigot/MC-Market/Polymart alternative

main lava Sep 4, 2020, 1:25 PM

#

Ah

thorny bane Sep 4, 2020, 1:25 PM

#

checkthepins

main lava Sep 4, 2020, 1:25 PM

#

Mobile

#

Sorry

#

They are like hidden in the side panel

#

So I never check unless on desktop

#

¯\_(ツ)_/¯

untold idol Sep 4, 2020, 1:26 PM

#

pretty sure nobody reads pins :p

main lava Sep 4, 2020, 1:26 PM

#

Heh

thorny bane Sep 4, 2020, 1:26 PM

#

Sounds like a them problem lul

modest forge Sep 4, 2020, 1:37 PM

#

Well the only place I can think of where it has to be sync is org creation. But we can get around that by manually creating the org user instead of relying on /sync_sso to create it.
@random badger that leaves the possibility for a race condition if a user gets created on auth at the same time as an org gets created on hangar

#

does the create user endpoint accept an ID?

random badger Sep 4, 2020, 1:38 PM

#

Hmm, we might have to change it so it creates the user in hangar before auth.

#

If it doesn’t, then we can make it accept one

modest forge Sep 4, 2020, 1:39 PM

#

Yeah

#

Did you modify hangarauth at all? I don't know which one is the right one to work with right now

random badger Sep 4, 2020, 1:46 PM

#

I made some changes.

#

Mainly to get it to work with docker better

#

There is a pr for all your changes + my small one on minis repo rn

modest forge Sep 4, 2020, 1:49 PM

#

Do we want Hangar roles to be included in the migrations?

#

Also the Organization role was missing from my list in migrations because I didn't know whether we were planning on using it

#

Hnnng so it looks like org creation in Ore assumes SpongeAuth never does sso sync calls asynchronously at all

random badger Sep 4, 2020, 2:33 PM

#

yeah, I guess include them

#

I didn't realize they weren't included in there already

random badger Sep 6, 2020, 12:58 AM

#

anyone know how to, with spring, take a bean created in a request scope and use it in a thread that doesn't know about that request?

#

I could probably deep copy the object, but im not sure thats the best solution

ivory ingot Sep 6, 2020, 5:30 AM

#

So you have the problem that this bean is destroyed and cannot be used in the thread?

random badger Sep 6, 2020, 5:32 AM

#

well idk what exactly is causing the problem. all I know, is I get an error when I try to pass that bean into a jdbi update method

#

the error is a bean creation error and it cant created it because its trying to create a request-scoped bean outside of the request scope

#

but idk why it would have to create it again. cause if I log the object right before, its there

ivory ingot Sep 6, 2020, 5:43 AM

#

Why you passing the bean to that update method? Do you want to get some data from that bean in that method?

random badger Sep 6, 2020, 5:45 AM

#

so I made some request-scoped beans so that if the route contains parameters for a project, you could get the project in a bean rather than in every project route getting the project and doing a null check there

#

and sometimes, I need to update info on that project

#

I got around it kinda, by just making a copy constructor

#

pass the copy in, and it works fine

ivory ingot Sep 6, 2020, 5:50 AM

#

Sounds like an interesting approach. Is it a private project or Hangar?

random badger Sep 6, 2020, 5:50 AM

#

hangar

#

if you want to see an example...
bean definition https://github.com/PaperMC/Hangar/blob/request-scoped-beans/src/main/java/io/papermc/hangar/controller/VersionsController.java#L134
line giving me trouble: https://github.com/PaperMC/Hangar/blob/request-scoped-beans/src/main/java/io/papermc/hangar/controller/VersionsController.java#L388

GitHub

PaperMC/Hangar

A plugin repository used for paper plugins. Contribute to PaperMC/Hangar development by creating an account on GitHub.

narrow verge Sep 6, 2020, 5:52 AM

#

it's always the beans isnt it

random badger Sep 6, 2020, 5:53 AM

#

im just confused as to why it tries to construct it again... cause the object exists. right up until I pass it to jdbi for it to do its thing

ivory ingot Sep 6, 2020, 5:59 AM

#

Ah ok.
Now I see another approach.

Most the time the bean is something providing data not being the data itself.

Another approach would be to return a Supplier<Project table>

#

So that the table isn't the bean itself.

random badger Sep 6, 2020, 6:00 AM

#

oh wait, I think I saw an example of a Provider<Something>

#

hmm

#

that is a good idea... are those final classes tho?

#

I was trying to use Optional<Something> for a bean and it didn't like it

#

cause Optional is a final class

ivory ingot Sep 6, 2020, 6:01 AM

#

And with a projectSupplier#get you get your table.

#

It's a functional interface so non final

random badger Sep 6, 2020, 6:02 AM

#

ok, that might be the solution. lemme check it out

ivory ingot Sep 6, 2020, 6:03 AM

#

Yes, spring Boot sometimes want to proxy instances and for that it needs to inherit and wrap it

random badger Sep 6, 2020, 6:03 AM

#

yeah, that is what I found out when I was trying to figure out why optional wasn't working

#

was trying to set one up for the current user, which of course can be no user

ivory ingot Sep 6, 2020, 6:04 AM

#

Would do it similar.
Supplier<Optional<User>>

random badger Sep 6, 2020, 6:05 AM

#

yeah

ivory ingot Sep 6, 2020, 6:07 AM

#

That's why I love open source projects. I can see the actual use case instead of asking for hundreds of years until the guy/girl provides actual information.

random badger Sep 6, 2020, 6:08 AM

#

you think I can have it autowire a supplier, and then have a private final of whatever its supplying? instead of calling get() everytime?

ivory ingot Sep 6, 2020, 6:09 AM

#

You do it in the ctor of the service, so yes.

random badger Sep 6, 2020, 6:09 AM

#

yes

ivory ingot Sep 6, 2020, 6:11 AM

#

Or not because it returns null without that request. Not that sure.

random badger Sep 6, 2020, 6:11 AM

#

thing is, it wont be constructed unless its needed

#

and itll never be needed when its null

#

either it exists or throws not found

#

if its null, it wont be accessed

ivory ingot Sep 6, 2020, 6:13 AM

#

Let's see

random badger Sep 6, 2020, 6:13 AM

#

hmm it didnt like suppplier by default

#

I changed it to ObjectFactory which is essentially the same

#

huh... I got the same error. I guess lemme try calling .get everytime

#

nope, still got the error... lemme try one more thing

#

ok, got it to work

#

so spring won't autowrap it in a supplier, the bean actually has to return the supplier type

#

and I can't use get() in the ctor

#

because sometimes that ctor is gonna be called not in the request scope, like at the very start of the program

#

calling get() shouldn't be a big problem tho, its still a big simplification

sly mason Sep 6, 2020, 6:28 AM

#

the bean actually has to return the supplier type
You mean the object mapping stuff for a response?

#

If so, people generally just have some "response" type object to be able to wrap their responses into

random badger Sep 6, 2020, 6:29 AM

#

    @Bean
    @RequestScope
    Supplier<ProjectVersionsTable> projectVersionsTable() {
        Map<String, String> pathParams = (Map<String, String>) request.getAttribute(HandlerMapping.URI_TEMPLATE_VARIABLES_ATTRIBUTE);
        if (!pathParams.keySet().containsAll(Set.of("author", "slug", "version"))) {
            return () -> null;
        } else {
            ProjectVersionsTable pvt = versionService.getVersion(pathParams.get("author"), pathParams.get("slug"), pathParams.get("version"));
            if (pvt == null) {
                throw new ResponseStatusException(HttpStatus.NOT_FOUND);
            }
            return () -> pvt;
        }
    }

re: the return type

#

if the return type was just ProjectVersionsTable, spring could autowire that to Supplier<ProjectVersionsTable> or ObjectFactory<ProjectVersionsTable> or Provider<ProjectVersionsTable>. but apparently not the way its setup currently

sly mason Sep 6, 2020, 6:32 AM

#

What would be wrong with returning the type itself?

random badger Sep 6, 2020, 6:33 AM

#

because then I can't use outside the request scope, which apparently using that object via jdbi to update some row in a database is

#

that's what was causing the initial issue. it needs to be wrapped in something

#

and if I rely on spring to auto wrap it, it still can't use the object outside the request scope, it has to start out wrapped

#

any difference performance wise, between making multiple calls to get() on the supplier or storing it as a local var in a method

sly mason Sep 6, 2020, 6:37 AM

#

each get will run that code

#

wait, nvm

#

Your supplier is literally just a "return X", so, no real difference

random badger Sep 6, 2020, 6:38 AM

#

yeah, I figured

ivory ingot Sep 6, 2020, 9:58 AM

#

👍

solemn whale Sep 6, 2020, 12:33 PM

#

https://github.com/PaperMC/Hangar/pull/111 My pull request has conflicts with master. Leaving aside or it would be merged with them being fixed. What would be a good way to resolve this? Merging master into my branch would mess up the commit history, right? And I cant rebase because of the conflicts (or maybe im just doing something wrong)?

Or would it be better to make create a new branch of master and redo my work on there and than create a new pull request?

misty mountain Sep 6, 2020, 12:34 PM

#

just rebase onto master

#

and fix conflicts as you're rebasing

solemn whale Sep 6, 2020, 12:50 PM

#

Okay thanks!

misty mountain Sep 6, 2020, 1:20 PM

#

often, the hangar folks can also just resolve em ^^

#

its rarely a lot of work lol

solemn whale Sep 6, 2020, 1:22 PM

#

Yea it isnt much work, but its also nice to know the solution yourself

random badger Sep 6, 2020, 11:29 PM

#

k, so im a little confused as to what exactly locking a user means? I mean the lock button only shows up for yourself.

random badger Sep 7, 2020, 12:33 AM

#

MAN, the more I use spring, the more I love it. just getting into parsing spel in custom annotations

narrow verge Sep 7, 2020, 12:57 AM

#

spring when

vivid cypress Sep 7, 2020, 5:34 AM

#

sproing now

random badger Sep 7, 2020, 5:55 AM

#

be super useful for hangar to have a contrib/github channel here btw

narrow verge Sep 7, 2020, 6:00 AM

#

I agree

#

Where's the Hangar Team role

random badger Sep 7, 2020, 6:12 AM

#

lol, I'd love a role 😆

#

currently we go back and forth between a couple channels in Mini's discord

narrow verge Sep 7, 2020, 6:12 AM

#

lol

random badger Sep 7, 2020, 6:12 AM

#

and finally putting everything here, would be nice

narrow verge Sep 7, 2020, 6:13 AM

#

Yeah you could join the big bois

random badger Sep 7, 2020, 6:15 AM

#

man, its so close to being done

#

well done initially, like not bug free for sure lol

narrow verge Sep 7, 2020, 6:15 AM

#

I'm too far behind on development

#

I can't help idk what's going on lol

cold ridge Sep 7, 2020, 5:43 PM

#

wen is hangar? I have to upload my plugins which are using paper api on spigot, so ppl complaining about NoDefMethodError etc, although i noted that this plugin works only with paper

misty mountain Sep 7, 2020, 5:45 PM

#

you can use paperlib to check if paper & disable in the meantime

#

hangar is here when hangar is ready

cold ridge Sep 7, 2020, 5:49 PM

#

so it doesn't solve main issue: ppl are stupid

#

they don't read that plugin works only with paper

tacit roost Sep 7, 2020, 5:51 PM

#

you dont even need paper lib just do a try catch around java Class.forName("com.destroystokyo.paper.PaperConfig");

#

and if it throws put a big error in console saying to download paper, and dont load the plugin

cold ridge Sep 7, 2020, 5:53 PM

#

Ok

#

mb that will work

misty mountain Sep 7, 2020, 5:56 PM

#

or just use paperlib, its very small and does the job even after we change the package of the config

#

if youre gonna depend on paper code in your plugin, please depend on API

random badger Sep 7, 2020, 9:00 PM

#

ugh. running out of stuff I want to do...

barren shale Sep 7, 2020, 9:12 PM

#

you could fix the view counter to also insert into that single_view table / not actually insert everytime you refresh

#

one of the few little things :p

random badger Sep 7, 2020, 9:12 PM

#

its supposed to be every refresh as far as I can tell...

#

its not what I thought it was

barren shale Sep 7, 2020, 9:13 PM

#

preetty sure it doesn’t on SpongeOre

random badger Sep 7, 2020, 9:13 PM

#

right, but that number displayed, doesn't equate to unique rows in that table

#

its from the home_projects view

#

which does a bunch of complicated stuff

barren shale Sep 7, 2020, 9:14 PM

#

do that then smolMonkey 😂

random badger Sep 7, 2020, 9:14 PM

#

like, look in the ore code, unless I missed something, its every time

barren shale Sep 7, 2020, 9:14 PM

#

would make sense for why they’re storing so much data in the single views table

modest forge Sep 7, 2020, 10:38 PM

#

machine: do you feel like rewriting SpongeAuth? :p

random badger Sep 7, 2020, 10:59 PM

#

@modest forge like you mean Runway?

#

I figured that what we've currently got is sufficient for now

#

I mean, its functionality all works

modest forge Sep 7, 2020, 11:02 PM

#

aside from org creation (unless you modified hangarauth?)

random badger Sep 7, 2020, 11:02 PM

#

I did

#

my branch does the sync sso call on org creation

modest forge Sep 7, 2020, 11:02 PM

#

That's the main reason I haven't bothered with runway tbh

random badger Sep 7, 2020, 11:03 PM

#

was a tiny change, just called the method to update it in the endpoint method handler. works like a charm

somber flicker Sep 8, 2020, 3:37 AM

#

maybe Hangar should be moved to its own category?

narrow verge Sep 8, 2020, 4:29 AM

#

nah, it's just one thing atm

#

not quite done

somber flicker Sep 8, 2020, 6:04 AM

#

so close....so close

sly mason Sep 8, 2020, 6:28 AM

#

The only real business of this channel is going to be when dev is going crazy, I can't see it being active enough that we can't just shove it into #paper-dev at some point, we have plenty of channels as is, and I don't really see how well a section for hanger will fit

pallid yoke Sep 8, 2020, 6:30 AM

#

We use a channel on my discord most of the time anyways 🤷

dire jasper Sep 8, 2020, 6:32 AM

#

Is said discord restricted or available to the public?

pallid yoke Sep 8, 2020, 6:35 AM

#

Do you plan on contributing?

sly mason Sep 8, 2020, 6:37 AM

#

I meant, #paper-github for notification; help requests will probs just go in general/paper-halp, any other channels are basically gonna be staff only type deals

barren shale Sep 8, 2020, 6:42 AM

#

still waiting on that one

solemn whale Sep 8, 2020, 8:02 AM

#

We use a channel on my discord most of the time anyways 🤷
~~Can i get an invite to that discord?~~ Got one, thanks mini

cinder rain Sep 8, 2020, 11:50 AM

#

sup,

#

I am watching with interest

#

I'd love to replace SpiGet

#

If you had a SpiGet compatible API that'd be huge in its own right

#

a robust API to allow integration is a must though

barren shale Sep 8, 2020, 11:55 AM

#

see pinned

cinder rain Sep 8, 2020, 11:56 AM

#

👍

#

I don't see an endpoint for a list of categories, searching by category, etc

pallid yoke Sep 8, 2020, 11:58 AM

#

We can easily add more apis later

#

But for now it's obviously not a focus

cinder rain Sep 8, 2020, 11:58 AM

#

is there any route for me to sponsor having specific features added?

#

or to outright offer some sponsorship to the hangar project?

pallid yoke Sep 8, 2020, 12:00 PM

#

Uuhm

#

I would need to talk to the team and stuff, but I don't see why that wouldn't work

#

I mean, the software itself has a feature to display sponors already, we inherited that from the sponge guys

#

But again, let's focus on shipping an MVP first and then talk about stuff like that later

#

But be sure to open an issue for search by api and stuff so that it isn't lost

#

Or just a more general API expansion issue with a giant wish list

#

You were representing a panel, right?

modest forge Sep 8, 2020, 2:17 PM

#

well, BukkitDev never went away

narrow verge Sep 8, 2020, 2:19 PM

#

spiget is a 3rd party services to get stuff from spigot :p

#

well, not really

#

assuming they actually will implement it lol

mortal idol Sep 8, 2020, 2:22 PM

#

soon, spigot will be abandoned, and Paper will be the leader

narrow verge Sep 8, 2020, 2:22 PM

#

nah, crappy premium plugins will stay behind

#

it'll just be mc-market 2

#

lol, all the api si already documented

#

you could legit be ready day one

#

well thats not api we have so of course it wont be documented

#

i mean good enough

#

do you search for "multipurpose plugin" or do you search for "essentials"

#

well the site will have it

#

but this is the api we're talkingabout

#

if you want to find a plugin, you go to the site, if you want to download it, you use the API

#

otherwise you just have mini hangars everywhere (what a coincidence)

worthy basalt Sep 8, 2020, 2:27 PM

#

well since spigot doesnt even allow people to make new premium plugins of certain categories now, that compromises it as being a premium host too

narrow verge Sep 8, 2020, 2:27 PM

#

yee it has to be in the "Premium" section

worthy basalt Sep 8, 2020, 2:28 PM

#

no i mean that no one is allowed to make new anti cheats now on spigot

narrow verge Sep 8, 2020, 2:28 PM

#

it is

worthy basalt Sep 8, 2020, 2:28 PM

#

hey nothing wrong with 2008 forums 😛

#

mines older than spigots lol ._.

narrow verge Sep 8, 2020, 2:28 PM

#

im gonna fork hangar and use it to release my ti-84 programs

mortal idol Sep 8, 2020, 2:28 PM

#

no i mean that no one is allowed to make new anti cheats now on spigot
so THAT's why there are no good public anticheats

worthy basalt Sep 8, 2020, 2:28 PM

#

dont need bland, need the job to get done clean

#

i was talking about premium little

narrow verge Sep 8, 2020, 2:29 PM

#

premium can still be good and public, given it follows the LICENSE theyre supposed to follow :P

worthy basalt Sep 8, 2020, 2:29 PM

#

they only allow free new anti cheats

mortal idol Sep 8, 2020, 2:30 PM

#

i didnt mean "good and public" as "free" i meant "public" as like not custom-coded ones that are only used on 1-2 servers

worthy basalt Sep 8, 2020, 2:30 PM

#

oh

narrow verge Sep 8, 2020, 2:30 PM

#

spigot's main problem is they dont care if you violate license

cinder rain Sep 8, 2020, 2:32 PM

#

@narrow verge if there's no way to find plugins without using the site then it's not worth integrating into anything, I might as well just scrape the frontend.

narrow verge Sep 8, 2020, 2:32 PM

#

um hello? search?

cinder rain Sep 8, 2020, 2:33 PM

#

categories, new, popular, etc

mortal idol Sep 8, 2020, 2:33 PM

#

i dont understand

narrow verge Sep 8, 2020, 2:33 PM

#

like i said, whats the point of just integrating hangar into your panel

#

people arent there to discover theyre there to install

cinder rain Sep 8, 2020, 2:33 PM

#

the fact that they don't have to leave it, and I can tell you they absolutely are there to discover

mossy topaz Sep 8, 2020, 2:34 PM

#

a ton of people use those panel plugin installers

#

it's kind of disappointing

narrow verge Sep 8, 2020, 2:34 PM

#

i mean sure, but at that point what's thepoint of hangar having a front end if every panel is just gonna implement their own version of it lol

cinder rain Sep 8, 2020, 2:35 PM

#

arguably there isn't much of one - just have it be a way for developers to upload their plugin and let the panels implement it how they please

mortal idol Sep 8, 2020, 2:35 PM

#

I have been using panels and I would rather search/explore inside the panel than go to the website externally
imo not a big deal

barren shale Sep 8, 2020, 2:35 PM

#

there already is api to get a list of projects in categories etc..

#

again, see pinned, it's all based off SpongeOre

cinder rain Sep 8, 2020, 2:36 PM

#

I took a look and couldn't see that endpoint, but I'll check again

#

couldn't see a category list either

narrow verge Sep 8, 2020, 2:36 PM

#

📎 unknown.png

barren shale Sep 8, 2020, 2:36 PM

#

like the very first entry in the projects dropdown

cinder rain Sep 8, 2020, 2:36 PM

#

no I mean an API endpoint to get the categories list

narrow verge Sep 8, 2020, 2:37 PM

#

Available values : admin_tools, chat, dev_tools, economy, gameplay, games, protection, role_playing, world_management, misc

#

are you saying an api to get those?
because i highly doubt those will change

barren shale Sep 8, 2020, 2:37 PM

#

and as mini said, adding a basic query to get something like a list of categories is an absolute no-brainer, but we will worry about that kinda stuff after the MVP

narrow verge Sep 8, 2020, 2:38 PM

#

yes

barren shale Sep 8, 2020, 2:38 PM

#

developing hangar

narrow verge Sep 8, 2020, 2:38 PM

#

📎 unknown.png

#

smh

#

slashes are specific

cinder rain Sep 8, 2020, 2:38 PM

#

📎 unknown.png

#

this is what I have right now with SpiGet, but Spiget is really unreliable

narrow verge Sep 8, 2020, 2:39 PM

#

"ChatControl???" lmao

cinder rain Sep 8, 2020, 2:39 PM

#

it also knows if updates are available, etc

modest forge Sep 8, 2020, 2:39 PM

#

???????????!

narrow verge Sep 8, 2020, 2:40 PM

#

Nani???

cinder rain Sep 8, 2020, 2:40 PM

#

This being why I want to replace SpiGet

📎 unknown.png

#

this kinda thing is common

mortal idol Sep 8, 2020, 2:40 PM

#

bro i thought that "spiget" just meant "spigot" in a bad way

cinder rain Sep 8, 2020, 2:41 PM

#

https://spiget.org/

Spiget | API for Spigot Resources, Plugins and Authors

Spiget is an API to quickly and easily get information about Spigot plugins, resources and authors

#

the site scrapes the spigot plugins frontend, puts it in a database, exposes as an API

#

works fine here?

#

but the backend has some issues and frequently has bad downloads

#

or sometimes it'll return a file that's actually the HTML for a cloudflare challenge page WraithEyeroll

narrow verge Sep 8, 2020, 2:42 PM

#

i remember seeing some api that worked through cloudflare walls, idk how reliably

cinder rain Sep 8, 2020, 2:42 PM

#

AMP has some logic to fetch through cloudflare walls, but it depends on what mode is in effect

#

it can do the "hey is this a real browser that has javascript" challenge but of course not anything with a captcha in it

#

but yeah, my interest in Hangar is focused squarely on its API - using its frontend would require extra integration (embed in an iframe, hooks to tell the frontend when the user wants to install something, how to check if a plugin is already installed, etc)

narrow verge Sep 8, 2020, 2:45 PM

#

ok nvm just tried the "some api" i talked about, got an error about "This website was blocked due to forums content" lmao

cinder rain Sep 8, 2020, 2:46 PM

#

xD

#

https://github.com/RyuzakiH/CloudflareSolverRe works really well for me

GitHub

RyuzakiH/CloudflareSolverRe

Cloudflare Javascript & reCaptcha challenge (I'm Under Attack Mode or IUAM) solving / bypass .NET Standard library. - RyuzakiH/CloudflareSolverRe

narrow verge Sep 8, 2020, 2:46 PM

#

reCaptcha
outdated

cinder rain Sep 8, 2020, 2:47 PM

#

The solver never worked well on the captcha ones, just the "I am under attack" ones

#

which took you past 90% of the things I encountered

#

these days it can integrate with 2Captcha and AntiCaptcha as paid services

#

which is nutty

#

there was one plugin API that was ass-backwards stupid, when you did a search it just returned a list of plugin IDs, if you wanted the names you had to make an API call for each result to get the name...

narrow verge Sep 8, 2020, 2:50 PM

#

i do the opposite with my api, it returns every single detail for every single object lol

cinder rain Sep 8, 2020, 2:50 PM

#

aye I'd rather too much data than too little

narrow verge Sep 8, 2020, 2:50 PM

#

getting memes? memes have authors, so each meme call always has the author objects lol

barren shale Sep 8, 2020, 2:54 PM

#

links to https://hangar-new.minidigger.me/api for a third time

cinder rain Sep 8, 2020, 2:54 PM

#

just ignore luka

#

hes been banned from my discord more times than I can count

barren shale Sep 8, 2020, 2:54 PM

#

lol

narrow verge Sep 8, 2020, 2:55 PM

#

check :pins:

#

i worked very hard onthat faq

cinder rain Sep 8, 2020, 2:57 PM

#

API question - is CORS enabled?

#

if not could it be so?

misty mountain Sep 8, 2020, 2:58 PM

#

CORS will probably be decided on later on in development

cinder rain Sep 8, 2020, 2:58 PM

#

it'd be handy, it mean I won't have to proxy the requests, and you'd get better metrics about the actual users

narrow verge Sep 8, 2020, 2:59 PM

#

proxi 🥺 the requests

cinder rain Sep 8, 2020, 2:59 PM

#

aye via AMPs backend

misty mountain Sep 8, 2020, 2:59 PM

#

we'll see akkoShrug

#

if it isn't on release, you're always free to PR it

cinder rain Sep 8, 2020, 3:00 PM

#

👍

#

https://tenor.com/view/senator-palpatine-anakin-skywalker-phantom-menace-gif-10607636

Tenor

pallid yoke Sep 8, 2020, 3:03 PM

#

Oh yeah, api should obviously have cors so you can use it in a browser

cinder rain Sep 8, 2020, 3:03 PM

#

yup, being able to touch it directly from the browser would save a few steps

pallid yoke Sep 8, 2020, 3:03 PM

#

Not sure if it does right now

#

But that's thankfully easy

#

Generally, stuff like this is part of the reason we rewrote ore from scratch. We have full control and ownership over the codebase and can implement basically anything

cinder rain Sep 8, 2020, 3:04 PM

#

there's a bug in the API browser, it's trying to load requests over HTTP rather than HTTPS

pallid yoke Sep 8, 2020, 3:04 PM

#

And since it's really popular tech, everybody can contribute

cinder rain Sep 8, 2020, 3:04 PM

#

Mixed Content: The page at 'https://hangar-new.minidigger.me/api#/Projects/listProjects' was loaded over HTTPS, but requested an insecure resource 'http://hangar-new.minidigger.me/login?returnUrl=/api/v2/projects'. This request has been blocked; the content must be served over HTTPS.

pallid yoke Sep 8, 2020, 3:04 PM

#

Urg, that's just swagger-ui not sure wtf they do

#

Oh wait, no, it's because it's asking you to auth

#

Theres a dum bug currently that if you have a open session, and we restart, that session is invalid on the server but not on the client

narrow verge Sep 8, 2020, 3:06 PM

#

How does that work

#

Isn't a valid session based off of what client and server have

#

not independent?

pallid yoke Sep 8, 2020, 3:06 PM

#

If the client would ask the servwr if the session is valid it would say no

#

But client doesn't do that for whatever reason, we haven't really touched client yet

narrow verge Sep 8, 2020, 3:08 PM

#

Ah

worthy basalt Sep 8, 2020, 3:37 PM

#

replace all http:// with https://

#

looks like a base url is set to http:// for login

pallid yoke Sep 8, 2020, 3:42 PM

#

No clue where, I'll check when I actually have the project open

cinder rain Sep 8, 2020, 4:35 PM

#

📎 usxezajznxl51.png

worn swallow Sep 8, 2020, 6:29 PM

#

😳

narrow verge Sep 8, 2020, 6:32 PM

#

#memes but it checks out lol

cold ridge Sep 8, 2020, 7:19 PM

#

When you click on paper droplist you just getting redirected to main page

random badger Sep 8, 2020, 7:20 PM

#

yeah. you hover to show the dropdown

#

or if you are on mobile, try clicking on the drop down arrow. someone did report something similar I think on mobile

cold ridge Sep 8, 2020, 7:21 PM

#

i do so

barren shale Sep 8, 2020, 7:21 PM

#

on mobile it was an actual bug tho, drago fixed it already

random badger Sep 8, 2020, 7:22 PM

#

well apparently not? the new builds have been deploying right?

cold ridge Sep 8, 2020, 7:22 PM

#

and i am still getting redirected

barren shale Sep 8, 2020, 7:23 PM

#

you can click anywhere on the dropdown icon on mobile and it will open the dropdown and only redirect on the second click

cold ridge Sep 8, 2020, 7:23 PM

#

no

#

i click in it once

#

and getting redirected

barren shale Sep 8, 2020, 7:24 PM

#

what's your phone

cold ridge Sep 8, 2020, 7:24 PM

#

zte blade a6

barren shale Sep 8, 2020, 7:24 PM

#

and what exact url did you open?

cold ridge Sep 8, 2020, 7:25 PM

#

https://hangar.minidigger.me/

Hangar

A Paper Plugin Repository

barren shale Sep 8, 2020, 7:25 PM

#

that's the wrong url

pallid yoke Sep 8, 2020, 7:25 PM

#

That's old

cold ridge Sep 8, 2020, 7:25 PM

#

and new too

barren shale Sep 8, 2020, 7:25 PM

#

you should take that down mini lol

pallid yoke Sep 8, 2020, 7:25 PM

#

Hangar-new

#

I still use it for comparison ^^

cold ridge Sep 8, 2020, 7:26 PM

#

i got redirected from new hangar to old

barren shale Sep 8, 2020, 7:27 PM

#

kinda doubt that 👀

cold ridge Sep 8, 2020, 7:27 PM

#

now im just getting redirected to main page

safe harbor Sep 8, 2020, 7:27 PM

#

Please use our production server at https://hangar.minidigger.me for uploading your plugins!
👀

Hangar

A Paper Plugin Repository

random badger Sep 8, 2020, 7:28 PM

#

its working just fine for me. on mobile taping once brings up the dropdown list, and then taping again goes to the home page

cold ridge Sep 8, 2020, 7:28 PM

#

omg it's working

#

im stupid

random badger Sep 8, 2020, 7:29 PM

#

inb4 mini did a fix in the last minute

pallid yoke Sep 8, 2020, 7:58 PM

#

Am innocent

cold ridge Sep 8, 2020, 8:00 PM

#

no one is blaming you

random badger Sep 8, 2020, 8:00 PM

#

and you are sure you tried hangar-new.minidigger.me?

#

that's the only one the fix is on

cold ridge Sep 8, 2020, 8:06 PM

#

ive tried new hangar

#

its working fine

#

just thought i was on new hangar

random badger Sep 8, 2020, 8:07 PM

#

ahh

cold ridge Sep 8, 2020, 8:07 PM

#

and i remember that i put "new" to address

#

but i got redirected to old version

#

i think

narrow verge Sep 8, 2020, 8:08 PM

#

whwt are we talking about?

#

the one bug on android?

cold ridge Sep 8, 2020, 8:09 PM

#

damn, feel dumb

narrow verge Sep 8, 2020, 8:09 PM

#

hangar mobile app when think_smart

odd grove Sep 8, 2020, 8:10 PM

#

https://hangar.minidigger.me/Spongie/test_waterfall/versions
https://pays.host/zJUIkyiW_
For the versions I think you should be able to see the updates without having to click each version, maybe a pop up when you hover of it or something

Hangar

Spongie / test_waterfall

test_waterfall

random badger Sep 8, 2020, 8:11 PM

#

im not sure what you mean?

narrow verge Sep 8, 2020, 8:12 PM

#

like

#

click to view previosu versions?

random badger Sep 8, 2020, 8:12 PM

#

the versions aren't loading for me on that url

narrow verge Sep 8, 2020, 8:12 PM

#

idk

#

unless thats an example idk

random badger Sep 8, 2020, 8:12 PM

#

if mini would deploy my branch of hangarauth, we could actually have a pretty much fully functional system

narrow verge Sep 8, 2020, 8:13 PM

#

dang gg

#

my vps is LXC so cant run docker

barren shale Sep 8, 2020, 8:14 PM

#

(it's also the wrong url)

random badger Sep 8, 2020, 8:14 PM

#

yeah, although if anything was changed there, so his same suggestion might still apply IF I understood what his suggestion was

cinder silo Sep 8, 2020, 8:29 PM

#

inquiry: hangar wen

narrow verge Sep 8, 2020, 8:31 PM

#

enquiry: check pins

random badger Sep 8, 2020, 11:46 PM

#

hmm, whats the recommended way of dealing with circular dependency issues?

mossy topaz Sep 8, 2020, 11:50 PM

#

refactor

random badger Sep 8, 2020, 11:56 PM

#

yeah, I did to avoid having to use @ Lazy

random badger Sep 9, 2020, 12:24 AM

#

the inline if?

narrow verge Sep 9, 2020, 12:24 AM

#

oop was gonna move that to #general but yes

random badger Sep 9, 2020, 12:24 AM

#

isnt it the ternary operator?

narrow verge Sep 9, 2020, 12:25 AM

#

yes that

#

thx

random badger Sep 9, 2020, 12:25 AM

#

but that was a bad example

#

cause you couldve just returned x > 10

#

rather than x > 10 ? true : false

narrow verge Sep 9, 2020, 12:26 AM

#

yee, someone was telling me about it, apparently cs has their own term for it

ivory ingot Sep 9, 2020, 7:45 AM

#

Yeah ternary operator or to keep is simpler shorthand if

obtuse orchid Sep 9, 2020, 11:05 AM

#

i have never heard anyone call it anything else other than ternary

#

that's what it's called so if you want people to understand you you call it that lol

fluid stratus Sep 9, 2020, 11:36 AM

#

In Java it is actually formally referred to as either "ternary conditional operator" or "conditional operator", yet not as "ternary operator".

modest forge Sep 9, 2020, 11:46 AM

#

screw formality! all hail colloquialisms!

solemn whale Sep 9, 2020, 11:46 AM

#

https://docs.oracle.com/javase/tutorial/java/nutsandbolts/operators.html They're calling it here ternary ?

Operators (The Java™ Tutorials > Learning the J...

This beginner Java tutorial describes fundamentals of programming in the Java programming language

barren shale Sep 9, 2020, 11:47 AM

#

almost all of the big guides I could find also call it ternary operator (as the short of ternary conditional)

fluid stratus Sep 9, 2020, 11:58 AM

#

The Java Language Specification calls it "conditional operator": https://docs.oracle.com/javase/specs/jls/se7/html/jls-15.html#jls-15.25.

barren shale Sep 9, 2020, 11:59 AM

#

I guess if even Java can't agree on that, we can agree on both ternary and conditional operator being good.. but not "shorthand if" lol

solemn whale Sep 9, 2020, 12:03 PM

#

Yea funny thing https://docs.oracle.com/javase/tutorial/java/nutsandbolts/opsummary.html they call it there Ternary (shorthand for if-then-else statement) under Conditional Operators

sly mason Sep 9, 2020, 12:05 PM

#

oracle

#

java

#

expecting consistency

#

plz

ivory ingot Sep 9, 2020, 12:23 PM

#

I guess if even Java can't agree on that, we can agree on both ternary and conditional operator being good.. but not "shorthand if" lol
@barren shale
https://www.w3schools.com/cpp/cpp_conditions_shorthand.asp

It's not the official name for that but everyone will know what you mean with it.
Saying to some noob: "Just use a ternary operator for that", doesn't mean the noob knows what he need to use. From the simplicity point of view with the term short-hand if-else everyone has a clue what could be meant with it.

sly mason Sep 9, 2020, 12:33 PM

#

everyone has a clue

#

thonk

modest forge Sep 9, 2020, 12:42 PM

#

#hangar-dev intensifies

pallid yoke Sep 9, 2020, 12:48 PM

#

W3schools, reeee

narrow verge Sep 9, 2020, 3:04 PM

#

Someone i worked with called it an integer based Boolean or whatever

fluid stratus Sep 9, 2020, 3:22 PM

#

Integer-based boolean?

mossy topaz Sep 9, 2020, 3:27 PM

#

I think they mean using 1 or 0 to represent a boolean

#

but truly it's confusing to say that

narrow verge Sep 9, 2020, 3:27 PM

#

maybe thats what they call it in C# idk

untold idol Sep 9, 2020, 3:28 PM

#

typically if you are referring to the number representation of bools people say bits

#

i think that's what sql calls them too

fluid stratus Sep 9, 2020, 3:28 PM

#

Yeah

mossy topaz Sep 9, 2020, 3:28 PM

#

the bit type in SQL is different from a boolean

#

i thought

untold idol Sep 9, 2020, 3:29 PM

#

sql doesn't have bools

#

it has bit-type

mossy topaz Sep 9, 2020, 3:29 PM

#

it does

untold idol Sep 9, 2020, 3:30 PM

#

which are often converted to bools by the sql driver

mossy topaz Sep 9, 2020, 3:30 PM

#

well, not all vendors have the boolean type

#

mysql also has the boolean literal/alias but not the data type

#

it's in the standard but is an optional feature

barren shale Sep 9, 2020, 6:58 PM

#

@modest forge hangar wen

random badger Sep 9, 2020, 6:59 PM

#

@modest forge runway* wen 🙂

modest forge Sep 9, 2020, 7:18 PM

#

@barren shale hangar wen

narrow verge Sep 9, 2020, 7:18 PM

#

@modest forge hangar whn

#

also check pins!!!! ! ! !snmh

barren shale Sep 9, 2020, 7:18 PM

#

only we are allowed to do that chew, sorry

narrow verge Sep 9, 2020, 7:19 PM

#

smhh

misty mountain Sep 9, 2020, 7:19 PM

#

@barren shale hangar wen?

narrow verge Sep 9, 2020, 7:19 PM

#

hangar wen (including this message) counter: 28

narrow verge Sep 9, 2020, 7:19 PM

#

narrow verge hangar wen (including this message) counter: 28

#

there

random badger Sep 9, 2020, 10:11 PM

#

there are reason why the Login / User account info button is hidden on error pages?

#

like on a 404 for example, I think the login button should be there. Because sometimes the page 404s because you don't have access to that page (an unpublic version for example)

narrow verge Sep 9, 2020, 10:31 PM

#

shouldnt that be a 401/403

random badger Sep 9, 2020, 10:35 PM

#

well see, I wasn't sure it should

#

because then it proves it exists

#

rather than 404 means well... it could exist, but it might not

#

ore does 404s if the user doesn't have perms to see that project/version