#dev-contrib | Python | Page 172

vale ibex Mar 15, 2022, 4:58 PM

#

hopefully not

surreal veldt Mar 15, 2022, 4:59 PM

#

PS C:\Users\tenuk>```

#

when I run python install-poetry.py --uninstall

vale ibex Mar 15, 2022, 4:59 PM

#

uhh that's weird

#

What about if you just go to https://install.python-poetry.org and save it as a python file from there

surreal veldt Mar 15, 2022, 5:01 PM

#

any specific dir to save it in?

#

directory*

vale ibex Mar 15, 2022, 5:01 PM

#

Where ever you like

surreal veldt Mar 15, 2022, 5:16 PM

#

vale ibex Where ever you like

went to eat dinner; but yes i saved it, what's next?

molten perch Mar 15, 2022, 7:27 PM

#

Hey! I'd love to have some review on sir-robin#20 , it's a fairly straightforward migration 😉

dusky shoreBOT Mar 15, 2022, 7:27 PM

#

GitHub

PROpen Migrate back to Discord.py V2

austere hornet Mar 15, 2022, 11:29 PM

#

!ot Wrong channel, you could ask in off-topic

stable mountainBOT Mar 15, 2022, 11:29 PM

#

Off-topic channel: #ot2-never-nester’s-nightmare

Please read our off-topic etiquette before participating in conversations.

eternal hull Mar 15, 2022, 11:55 PM

#

https://github.com/python-discord/bot/issues/2116
Any thoughts for this one?

GitHub

Autoformat messages that contain code but aren't using MD · Issue #...

When a user sends a message which contains python code but isn't marked down, instead of simply letting them know about it, will also format the message, and send it as an embed, deleting t...

thorny obsidian Mar 16, 2022, 12:20 AM

#

eternal hull https://github.com/python-discord/bot/issues/2116 Any thoughts for this one?

I personally don't like the auto-formatting of code like that. Even if it takes a bit more work, I'd rather the person learn going forward to format things rather than relying on the bot to do it.

short snow Mar 16, 2022, 12:21 AM

#

You could use context menues for that, or whatever they are called

#

arl implemented it for their bot

#

and it works pretty great

#

#

(didn't have immediate access to it, so copied hsp's screenshot)

eternal hull Mar 16, 2022, 12:58 AM

#

thorny obsidian I personally don't like the auto-formatting of code like that. Even if it takes ...

Fair enough

signal forge Mar 16, 2022, 2:45 PM

#

Howdy, everyone. Made some progress on this issue:

https://github.com/python-discord/bot/issues/2079#issuecomment-1068626315

GitHub

Command request: Add topic parameter to `!resources` · Issue #2079 ...

I'd like for the resources command to have a single, optional parameter for specifying the topic. For example, !resources data science should return the URL for the resources page, pre-filt...

molten perch Mar 16, 2022, 4:15 PM

#

Hey! It looks pretty good. If you wish to showcase your features I could suggest you to open a draft pull request. This way we know that you haven't finished it yet, but you have made progress. (Maybe you could upload this gif/video as the description for the draft)

signal forge Mar 16, 2022, 4:49 PM

#

molten perch Hey! It looks pretty good. If you wish to showcase your features I could suggest...

Oh... that's a good idea. Never opened a draft PR before so will be a learning experience.

dim pelican Mar 16, 2022, 4:51 PM

#

~~I think the only difference is marking it as a draft after creation~~

gritty wind Mar 16, 2022, 4:52 PM

#

You can actually open a PR as draft right away, which has the added benefit of not auto-requesting reviewers until you're actually ready

#

It's in a dropdown under the normal open PR button

signal forge Mar 17, 2022, 12:41 AM

#

Is anyone available to help me get Poetry up and running?

#

I've installed it, but am running into an issue that I can't quite figure out... none of the commands are working as they should.

ericfletcher@Erics-MBP  ~  poetry run python                                                                                                                                                                                                                                                       ✔  1391  20:38:06

  RuntimeError

  Poetry could not find a pyproject.toml file in /Users/ericfletcher or its parents

  at .poetry/lib/poetry/_vendor/py3.9/poetry/core/factory.py:369 in locate
      365│             if poetry_file.exists():
      366│                 return poetry_file
      367│
      368│         else:
    → 369│             raise RuntimeError(
      370│                 "Poetry could not find a pyproject.toml file in {} or its parents".format(
      371│                     cwd
      372│                 )
      373│             )

#

Then from within the project in PyCharm with poetry run task precommit

 ericfletcher@Erics-MBP  ~/Documents/open-source-repos/bot   2079  poetry run task precommit                                                                                                                 1 ↵  1393  20:38:34

  FileNotFoundError

  [Errno 2] No such file or directory: b'/Library/Frameworks/Mono.framework/Versions/Current/Commands/task'

  at /opt/homebrew/Cellar/python@3.9/3.9.10/Frameworks/Python.framework/Versions/3.9/lib/python3.9/os.py:607 in _execvpe
       603│         path_list = map(fsencode, path_list)
       604│     for dir in path_list:
       605│         fullname = path.join(dir, file)
       606│         try:
    →  607│             exec_func(fullname, *argrest)
       608│         except (FileNotFoundError, NotADirectoryError) as e:
       609│             last_exc = e
       610│         except OSError as e:
       611│             last_exc = e

#

I think this is tripping me up / not properly executed:

To get started you need Poetry's bin directory ($HOME/.poetry/bin) in your `PATH`
environment variable. Next time you log in this will be done
automatically.

vocal prairie Mar 17, 2022, 12:44 AM

#

signal forge Then from within the project in `PyCharm` with `poetry run task precommit` ``` ...

Have you run poetry install?

#

I think I've gotten this error because I haven't before

signal forge Mar 17, 2022, 12:45 AM

#

I have this in my .zshrc

 export PATH="$HOME/.poetry/bin:$PATH"

signal forge Mar 17, 2022, 12:45 AM

#

vocal prairie Have you run `poetry install`?

I just did in my terminal on my Mac laptop:

ericfletcher@Erics-MBP  ~  poetry install                                                                                                                                                                                                                                                          ✔  1396  20:45:22

  RuntimeError

  Poetry could not find a pyproject.toml file in /Users/ericfletcher or its parents

  at .poetry/lib/poetry/_vendor/py3.9/poetry/core/factory.py:369 in locate
      365│             if poetry_file.exists():
      366│                 return poetry_file
      367│
      368│         else:
    → 369│             raise RuntimeError(
      370│                 "Poetry could not find a pyproject.toml file in {} or its parents".format(
      371│                     cwd
      372│                 )
      373│             )

#

Oh should I run that command from within the project in PyCharm?

vocal prairie Mar 17, 2022, 12:46 AM

#

from within the project, yeah

#

It'll install the dependencies from the pyproject.toml into a venv

signal forge Mar 17, 2022, 12:46 AM

#

oh my

#

it's installing so many things

#

lol I'm such a noob 😦

#

Oh my the lint is so cool!

#

Everything passed except Flake8 for 4 errors i need to fix

signal forge Mar 17, 2022, 1:02 AM

#

vocal prairie from within the project, yeah

Now when ready to commit and push, after running lint and precommit, I get this commit failed with error message:

21:01:48.934: [bot] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false add --ignore-errors -A -f -- bot/exts/info/resources.py
21:01:48.939: [bot] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false commit -F /private/var/folders/nn/7bxtpjwx1sbbfnynm05zdtjc0000gn/T/git-commit-msg-.txt --
Check for merge conflicts................................................Passed
Check Toml...........................................(no files to check)Skipped
Check Yaml...........................................(no files to check)Skipped
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
check blanket noqa.......................................................Passed
isort (python)...........................................................Passed
Flake8...................................................................Failed
- hook id: flake8
- exit code: 1
Executable `poetry` not found

vocal prairie Mar 17, 2022, 1:03 AM

#

pithink

signal forge Mar 17, 2022, 1:03 AM

#

running this from within PyCharm

vocal prairie Mar 17, 2022, 1:03 AM

#

I'm not sure what could cause that

signal forge Mar 17, 2022, 1:06 AM

#

vocal prairie I'm not sure what could cause that

Eh... I restarted PyCharm and it worked

#

lol

vocal prairie Mar 17, 2022, 1:06 AM

#

ah, maybe it didn't load into the PyCharm session

#

glad you figured it out!

signal forge Mar 17, 2022, 1:07 AM

#

Yea! going to enter a draft pull request now

#

Don't worry the issue was assigned to me 🙂

#

And approved

signal forge Mar 17, 2022, 1:26 AM

#

Hi, everyone. I just submitted my first ever draft pull request to the Bot repo. My PR has failed 1 of the lint checks and am not entirely sure how I can fix what it has identified.

Can anyone help me with this?

https://github.com/python-discord/bot/pull/2117

GitHub

Add Resources Command by iamericfletcher · Pull Request #2117 · pyt...

Hi, everyone.
This pull request is in reference to approved issue #2079.
Please note, I successfully ran poetry run task precommit and poetry run task lint prior to submitting this pull request.
De...

tawdry vapor Mar 17, 2022, 1:27 AM

#

Do you know how to view the logs for CI?

signal forge Mar 17, 2022, 1:27 AM

#

I clicked details, and it says bot/exts/info/resources.py:5: ModuleNotFoundError

#

But it's properly working on my local version in PyCharm.... the disnake module

tawdry vapor Mar 17, 2022, 1:28 AM

#

There were recently commits merged into main which switched from disnake back to discord.py

signal forge Mar 17, 2022, 1:28 AM

#

oh no

#

I guess I could just replace disnake with discord./py and replace what I can with discord.py

tawdry vapor Mar 17, 2022, 1:29 AM

#

Your branch is just out of date. If you merge the changes from main and update your import then it should work

signal forge Mar 17, 2022, 1:30 AM

#

oh

#

ok i can do that

#

but then I have to re commit and then recommit to my pull request

tawdry vapor Mar 17, 2022, 1:30 AM

#

Though it is strange that the CI used the latest changes (regarding dependencies) despite your branch being on an older revision...

signal forge Mar 17, 2022, 1:31 AM

#

Do iw ant to merge incoming changes into the current branch?

#

Or rebase the current branch op of incoming changes

tawdry vapor Mar 17, 2022, 1:32 AM

#

Since your PR is still a draft, no one has reviewed it yet. So you're more flexible with the git history. Doing a rebase would require you to force push, but it will result in cleaner history; the merge would create an extra "merge commit"

signal forge Mar 17, 2022, 1:33 AM

#

It says I have no tracked branch

#

Can't perform the update

#

Can I share my screen with you?

tawdry vapor Mar 17, 2022, 1:34 AM

#

Sure

#

Can you join the dev voice channel here or is it locked for you

#

<@&831776746206265384> please grant stream perms to @signal forge

vocal wolf Mar 17, 2022, 1:35 AM

#

!stream 750693589532672100

stable mountainBOT Mar 17, 2022, 1:35 AM

#

✅ @signal forge can now stream until <t:1647481245:f>.

vocal wolf Mar 17, 2022, 1:35 AM

#

wait that only gives 5 minutes

tawdry vapor Mar 17, 2022, 1:36 AM

#

Thanks

#

No it's fine I think

#

It's just the window of time they have to start the stream

vocal wolf Mar 17, 2022, 1:36 AM

#

ah

short snow Mar 17, 2022, 1:36 AM

#

tawdry vapor Can you join the dev voice channel here or is it locked for you

yep, dev voice is blocked for us

signal forge Mar 17, 2022, 2:19 AM

#

vocal wolf wait that only gives 5 minutes

Could you point me to the section of the server / site where I can learn how to become able to stream video without having to ask permission?

hoary haven Mar 17, 2022, 2:22 AM

#

signal forge Could you point me to the section of the server / site where I can learn how to ...

currently we don't have such a system, a mod has to be present in vc already and it's at their discretion

#

what time zone are you in, out of curiosity?

#

there is a chunk of the day where we tend to have mods on vc, but it's usually not around this time.

surreal veldt Mar 17, 2022, 7:30 AM

#

Sorry for ping but @vale ibex do you mind following up on what you were saying about getting the pre hooks installed?

gritty wind Mar 17, 2022, 8:38 AM

#

surreal veldt Sorry for ping but <@!126811506632294400> do you mind following up on what you w...

I’ve got some free time right now if you’d like help

surreal veldt Mar 17, 2022, 8:43 AM

#

gritty wind I’ve got some free time right now if you’d like help

Well... you'd need to read a lot for context

gritty wind Mar 17, 2022, 8:43 AM

#

I was watching yesterday, you should just need to run the script with the correct environment 😜

#

But yeah you can wait for Chris, that’s fine

surreal veldt Mar 17, 2022, 8:44 AM

#

When i run some code i now get this

#

task: <Task pending name='disnake: app_command_preparation' coro=<InteractionBotBase._prepare_application_commands() running at C:\Users\tenuk\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\disnake\ext\commands\interaction_bot_base.py:849> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0x0000022E7F8BDF70>()]>>```

#

It maybe because of the files i added or changed yesterday I'm not sure what to do

gritty wind Mar 17, 2022, 8:48 AM

#

This is good, it means the application is running

#

Did you stop it while it was running?

surreal veldt Mar 17, 2022, 8:50 AM

#

gritty wind This is good, it means the application is running

No it came when i ran the code

#

It's a script for a discord bot

gritty wind Mar 17, 2022, 8:54 AM

#

Python discord bots?

#

As in one of the server’s projects

surreal veldt Mar 17, 2022, 8:56 AM

#

But it doesn't normally come

surreal veldt Mar 17, 2022, 8:57 AM

#

gritty wind Python discord bots?

No just a personal project

#

But it doesn't run the code with that error

gritty wind Mar 17, 2022, 8:57 AM

#

Could you post a full traceback

surreal veldt Mar 17, 2022, 8:58 AM

#

I have a print on on_ready which isn't printed

#

I'm not currently on my pc but iirc that's the full tb

hoary haven Mar 17, 2022, 2:07 PM

#

hm getting a 500 when trying to submit a PR

#

:(

vale ibex Mar 17, 2022, 2:10 PM

#

https://www.githubstatus.com/

GitHub Status

Welcome to GitHub's home for real-time and historical data on system performance.

#

D:

placid ermine Mar 17, 2022, 2:12 PM

#

oof

vale ibex Mar 17, 2022, 2:12 PM

#

webscale software sometimes has hickups

#

maybe they deleted /etc/ on one of their hosts

#

@patent pivot @last patio thoughts

last patio Mar 17, 2022, 2:17 PM

#

lol

hoary haven Mar 17, 2022, 2:18 PM

#

all yellow now

#

PRs was green for a long time lemon_angrysad

clever wraith Mar 17, 2022, 2:23 PM

#

vale ibex maybe they deleted /etc/ on one of their hosts

From now on I'm gonna call doing that pulling a joe

summer garden Mar 17, 2022, 2:33 PM

#

last patio lol

haha okay, good. I thought I broke my git

short snow Mar 17, 2022, 3:59 PM

#

#dev-log message Uhhhhh

#

how did they close the issue

brisk brook Mar 17, 2022, 3:59 PM

#

They're a helper

short snow Mar 17, 2022, 4:00 PM

#

ah, didn't find a member tag on them, so got suprised

#

whats their discord tag, out of curiosity?

sturdy jungle Mar 17, 2022, 4:02 PM

#

short snow whats their discord tag, out of curiosity?

😅 its me... i didn't realize i could close it myself so it happened by mistake

short snow Mar 17, 2022, 4:09 PM

#

Ah 👍

full fractal Mar 17, 2022, 5:12 PM

#

short snow ah, didn't find a member tag on them, so got suprised

You can hide organisation membership on GitHub, it's fairly common. For example, the PyPA has 45 public members (me included) but I can promise you there's almost double that in actual members.

#

In that case usually the tag is "contributor" or even nothing IIRC?

gritty wind Mar 17, 2022, 5:14 PM

#

Contributor is unrelated to membership

#

It’s about making commits to any branch on the repo

#

But yeah a ton of hidden members

full fractal Mar 17, 2022, 5:14 PM

#

well that's fair, I was just talking about the visible tags for hidden membership -- it's fairly common since members do typically make commits

#

but yes they are separate things, they only overlap when GH decides which tag to present

short snow Mar 17, 2022, 5:17 PM

#

full fractal You can hide organisation membership on GitHub, it's fairly common. For example,...

you see the member tag even if you have hidden your membership IIRC

full fractal Mar 17, 2022, 5:17 PM

#

No...? you'll only see it if you're also a member

#

short snow Mar 17, 2022, 5:19 PM

#

ok yeah, got them confused with the contributor tag 😅

torpid grotto Mar 17, 2022, 8:31 PM

#

Got an error about the server #discord-bots message

cold island Mar 17, 2022, 8:32 PM

#

Seems like a Discord hiccup

torpid grotto Mar 17, 2022, 8:32 PM

#

👍

placid ermine Mar 18, 2022, 4:57 AM

#

@tawdry vapor

try:
    is_future = target > arrow.utcnow())
except TypeError:
    is_future = True
if not is_future:
    await ctx.send("!!!!")
    return
func(...)

is a bit cleaner, i think?

tawdry vapor Mar 18, 2022, 4:58 AM

#

Sure that works.

#

Or maybe instead of return early just do if-else.

#

Up to you I'm not super concerned about minor readability details at this point

#

I used up my quota for the docstring :D

placid ermine Mar 18, 2022, 5:00 AM

#

lol

#

hmm also, how do i do the "resolved in <commit_hash>" thing on github

#

nvm googled it

tawdry vapor Mar 18, 2022, 5:16 AM

#

Oh... I just realised we have almost 30 PRs open

#

That is not good

#

Possibly the most we've ever had

#

Even more if we consider other repos

placid ermine Mar 18, 2022, 5:17 AM

#

all the more reason to merge mine quickly /s

tawdry vapor Mar 18, 2022, 5:18 AM

#

Yeah I was gonna be lazy and review it tomorrow cause it's late but I'm gonna test it now while I'm still in the mindset of contrib stuff

#

Ah yes I am reminded of how painfully slow discord API responds on my machine

#

um? ```
Installing dependencies from lock file

RuntimeError

[BUG] bot-core (1.2.0) is not satisfied.

at /usr/lib/python3.10/site-packages/poetry/mixology/partial_solution.py:200 in satisfier

hoary haven Mar 18, 2022, 5:27 AM

#

is this your first time setting up bot since bot-core stuff was added?

tawdry vapor Mar 18, 2022, 5:28 AM

#

Yes I think

hoary haven Mar 18, 2022, 5:28 AM

#

i've on & off had to destroy my venv and poetry install fresh

tawdry vapor Mar 18, 2022, 5:28 AM

#

I tried that already though

hoary haven Mar 18, 2022, 5:28 AM

#

kosa had a completely different issue

tawdry vapor Mar 18, 2022, 5:29 AM

#

let's see if it gets fixed if I re-lock

hoary haven Mar 18, 2022, 5:29 AM

#

but i think kosa's was smth abt python being set to 3.9.0a somewhere, which i'm sure is not your scenario

tawdry vapor Mar 18, 2022, 5:30 AM

#

I don't think this lock is gonna work... 90 seconds and still going

#

Wait it finished

#

Nope still broken. No idea why. I'm using 3.9.9

#

The error says "bug" which implies it's some Poetry bug. Also weird that the lock took so long

odd hill Mar 18, 2022, 7:05 AM

#

could I be assigned an issue from one of the python bots?

rapid swallow Mar 18, 2022, 7:07 AM

#

odd hill could I be assigned an issue from one of the python bots?

link? \🥺

odd hill Mar 18, 2022, 7:17 AM

#

rapid swallow link? \🥺

https://github.com/python-discord/bot/issues/2116

GitHub

Autoformat messages that contain code but aren't using MD · Issue #...

When a user sends a message which contains python code but isn't marked down, instead of simply letting them know about it, will also format the message, and send it as an embed, deleting t...

#

i don’t really mind

#

any would suffice

surreal veldt Mar 18, 2022, 12:58 PM

#

when I use poetry commands in terminal it raises errors like the system cannot find the path specified. I'm not able to find them in the file explorer as well, so they might've been deleted.
Can anyone tell me how to re-install poetry?

fervent sage Mar 18, 2022, 1:02 PM

#

you could use pip install --force-reinstall poetry

surreal veldt Mar 18, 2022, 1:04 PM

#

fervent sage you could use `pip install --force-reinstall poetry`

oh that seemed to work I think

#

after running that, in my command prompt i did pip show poetry and it gave something though

#

is that normal?

#

oh also it raises ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. httpx 0.13.3 requires idna==2.*, but you have idna 3.3 which is incompatible.

hoary haven Mar 18, 2022, 7:13 PM

#

was helping raven, and for whatever reason poetry install only worked after pip installing poetry into the project venv

#

big ¯_(ツ)_/¯

brisk brook Mar 18, 2022, 9:47 PM

#

I am not sure how often you check your mail or GitHub notifications so I'll ping you here. I reviewed your pull request @signal forge!

surreal veldt Mar 19, 2022, 4:25 AM

#

What does this mean?

vocal wolf Mar 19, 2022, 5:54 AM

#

surreal veldt What does this mean?

That human has notified others he will be working on the issue and/or pull request they've assigned themselves to.

surreal veldt Mar 19, 2022, 6:00 AM

#

vocal wolf That human has notified others he will be working on the issue and/or pull reque...

So he's going to be doing the changes?

vocal wolf Mar 19, 2022, 6:00 AM

#

where was this notification found?

surreal veldt Mar 19, 2022, 6:01 AM

#

vocal wolf where was this notification found?

https://github.com/python-discord/site/pull/698#pullrequestreview-914793798

GitHub

Add custom help command by Diabolical5777 · Pull Request #698 · pyt...

Add custom help command page for Discord bot migration project (#695)
This PR adds a page to the website with the content from this pin from #discord-bots.

vocal wolf Mar 19, 2022, 6:02 AM

#

are you the author of this PR?

surreal veldt Mar 19, 2022, 6:02 AM

#

yes

vocal wolf Mar 19, 2022, 6:03 AM

#

ah, then this was most likely a mistake I believe

#

if you hadn't discussed this beforehand

vocal wolf Mar 19, 2022, 6:03 AM

#

surreal veldt What does this mean?

@last patio y u assign

surreal veldt Mar 19, 2022, 6:05 AM

#

i was looking forward to working on it lol it's my first time doing markdown and the YAML formatter

vocal wolf Mar 19, 2022, 6:06 AM

#

surreal veldt i was looking forward to working on it lol it's my first time doing markdown and...

usually a person would assign themselves if it was discussed before, so this is still your PR

surreal veldt Mar 19, 2022, 6:18 AM

#

okay, thank you

surreal veldt Mar 19, 2022, 7:07 AM

#

Does preview not support this? Actually first of all, is this how I should be using YAML formatter in a .md file?

wild prism Mar 19, 2022, 7:10 AM

#

surreal veldt Does preview not support this? Actually first of all, is this how I should be us...

if you have the site up and running you can actually just live load the changes in your browser

surreal veldt Mar 19, 2022, 7:11 AM

#

wild prism if you have the site up and running you can actually just live load the changes ...

i haven't done that step I believe

wild prism Mar 19, 2022, 7:13 AM

#

if you're interested, here's the full walkthrough to get it working
https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/site/

Python Discord - Contributing to Site

A guide to setting up and configuring Site.

surreal veldt Mar 19, 2022, 7:14 AM

#

Yeah I considered that but then thought I'd skip that step

patent pivot Mar 19, 2022, 7:14 AM

#

vocal wolf <@!196989358165852160> y u assign

@surreal veldt if you assign yourself or someone else to a PR it also means you may review

#

We generally do review requests for that but that's the other meaning

vocal wolf Mar 19, 2022, 7:15 AM

#

patent pivot <@!751814647346102303> if you assign yourself or someone else to a PR it also me...

I was not aware of this, ty

surreal veldt Mar 19, 2022, 7:15 AM

#

I'm sorry I didn't understand what you mean, you're talking for Volcyy he wanted to review it?

patent pivot Mar 19, 2022, 7:16 AM

#

if he assigned himself to your PR it probably means he's going to review it

surreal veldt Mar 19, 2022, 7:16 AM

#

so I can still change it and update it? Or he will do that

patent pivot Mar 19, 2022, 7:17 AM

#

No all is still entirely up to you

#

It's just a reminder to him to review it

surreal veldt Mar 19, 2022, 7:18 AM

#

surreal veldt Does preview not support this? Actually first of all, is this how I should be us...

if I want to view this and what it looks like, I have to follow the steps to get it running?

patent pivot Mar 19, 2022, 7:18 AM

#

@last patio maybe use review requests in future for things like this unless you have another meaning review reqs don't cover

surreal veldt Mar 19, 2022, 7:18 AM

#

I hope I can avoid those steps because it's kind of a long task at least for me to get a small thing done

#

Oh wait I just realised he asked to use YAML frontmatter which I read as YAML formatter

#

Anyways, the member who self assigned it said he doesn't think markdown headers shouldn't be used for text, can I ask for feedback here? Right now it looks like this

last patio Mar 19, 2022, 7:56 AM

#

vocal wolf <@!196989358165852160> y u assign

for me it means that I’m making myself responsible to getting it into master, e.g. requesting review as well

vocal wolf Mar 19, 2022, 7:57 AM

#

ty for letting me know

vocal wolf Mar 19, 2022, 8:41 AM

#

surreal veldt I hope I can avoid those steps because it's kind of a long task at least for me ...

avoid what steps?

surreal veldt Mar 19, 2022, 8:44 AM

#

vocal wolf avoid what steps?

Host the site

#

But it's fine i misread a phrase

surreal veldt Mar 19, 2022, 8:44 AM

#

surreal veldt Anyways, the member who self assigned it said he doesn't think markdown headers ...

This is my only question now

vocal wolf Mar 19, 2022, 8:45 AM

#

surreal veldt Anyways, the member who self assigned it said he doesn't think markdown headers ...

I don't think this many headers should be necessary, should be formatted to look similar to this: https://github.com/python-discord/site/blob/831f56f71d76741276d13e20954f46088e754d18/pydis_site/apps/content/resources/guides/python-guides/creating-python-environment-windows.md?plain=1

surreal veldt Mar 19, 2022, 8:47 AM

#

vocal wolf I don't think this many headers should be necessary, should be formatted to look...

So remove the title of Custom Help Command?

vocal wolf Mar 19, 2022, 8:48 AM

#

By headers I mean the many ###s

#

the top title stays

surreal veldt Mar 19, 2022, 8:52 AM

#

oh got it updated

#

at first I thought it looked more readable but in retrospect the body was too big

signal forge Mar 19, 2022, 11:36 AM

#

brisk brook I am not sure how often you check your mail or GitHub notifications so I'll ping...

Hey! Thank you so much @brisk brook .... a lot to learn 🙂 This is my first time dealing with a code review and I don't want to mess up the git history on the repo or locally on my machine. Is there a learning resource you can suggest for me to implement code review changes via git properly?

brisk brook Mar 19, 2022, 11:57 AM

#

signal forge Hey! Thank you so much <@!344404945359077377> .... a lot to learn 🙂 This is my ...

I am not aware of one personally, sorry.

It's relatively simple though. Go through the comments and apply the feedback you agree with by making those changes locally, if there's something you don't agree with then make a reply on the comment discussing it. Once you've applied all comments you can commit the changes and push, lastly click "Mark as resolved" on the comments that you fixed. It's fine if you leave some open, as they may also be asking others' opinions as well. I recommend not force-pushing on larger PRs (it's fine on for example one-line changes) because all comments get marked as Outdated (even when they may not be) and if I mark files as viewed that gets reset.

Don't be too worried about messing up the Git history, your PR can simply be squashed in the end if things get messy.

surreal veldt Mar 19, 2022, 12:14 PM

#

If i make a PR and update the code, how do i update it in the pr? Do i need to make a new PR?

brazen charm Mar 19, 2022, 12:28 PM

#

the pr will be updated if you push to its branch

clever wraith Mar 19, 2022, 12:38 PM

#

lol

surreal veldt Mar 19, 2022, 12:49 PM

#

brazen charm the pr will be updated if you push to its branch

before I had a button here to do that I think which isn't there now can you tell me what to do please?

brisk brook Mar 19, 2022, 12:57 PM

#

surreal veldt before I had a button here to do that I think which isn't there now can you tell...

That looks correct, if you were on the incorrect branch then it wouldn't say M for Modified - the file would've been created if I am not mistaken.

surreal veldt Mar 19, 2022, 12:58 PM

#

brisk brook That looks correct, if you were on the incorrect branch then it wouldn't say `M`...

but it hasn't been updated on github

brisk brook Mar 19, 2022, 12:59 PM

#

Have you pushed the changes?

surreal veldt Mar 19, 2022, 12:59 PM

#

I use the commit command right?

brisk brook Mar 19, 2022, 1:00 PM

#

Yes, first you commit and then you push the commit to GitHub

surreal veldt Mar 19, 2022, 1:02 PM

#

how do I stage files?

placid ermine Mar 19, 2022, 1:03 PM

#

git add .

surreal veldt Mar 19, 2022, 1:05 PM

#

cool thank you it was updated

surreal veldt Mar 19, 2022, 1:07 PM

#

surreal veldt cool thank you it was updated

CC @last patio (sorry for the ping I'm just letting you know)

mellow hawk Mar 19, 2022, 3:01 PM

#

@patent pivot hey can you accept my friend request just wanna ask you something

#

then you can remove me

patent pivot Mar 19, 2022, 3:02 PM

#

mellow hawk <@!165023948638126080> hey can you accept my friend request just wanna ask you s...

my DMs are open

mellow hawk Mar 19, 2022, 3:02 PM

#

oh

#

didnt know that

jovial kite Mar 19, 2022, 7:56 PM

#

lol

harsh pasture Mar 20, 2022, 3:25 AM

#

hi

fallen patrol Mar 20, 2022, 3:46 AM

#

Pre-fetching them with an asyncio.gather will speed this up dramatically, thanks to the power of non-blocking networking.
was it tested to see if this actually does speed it up?

hoary haven Mar 20, 2022, 3:49 AM

#

when testing yeah it was loads faster

#

in the bot's current state it takes 25~50s to give us the bb watched message

#

testing that PR on the test server it took less than a second. granted that's with a much smaller set of users

#

bot#2115

dusky shoreBOT Mar 20, 2022, 3:58 AM

#

GitHub

PROpen Pre-fetch watched users to avoid sequential API calls

hoary haven Mar 20, 2022, 4:00 AM

#

not sure how we can replicate a larger number of users for testing

fallen patrol Mar 20, 2022, 4:06 AM

#

hoary haven testing that PR on the test server it took less than a second. granted that's wi...

right, but you would also need to test with a ton of watched users

fallen patrol Mar 20, 2022, 4:06 AM

#

hoary haven not sure how we can replicate a larger number of users for testing

run some int e to add everyone in the test server to the watched list mmwhereismynose

#

additionally, disable the member cache while testing

#

it's definitely going to be faster in the test server because all users will be cached automatically as the guild has less than 250 members, so it will be using the cache and making no requests, which means that the gather won't be doing anything in testing

#

and in prod it also won't do anything due to dpys sequential ratelimit handling

#

dpy makes one request to a route and waits for it to return before letting the next request through

#

it's slow, it's clunky, and it means that you get no api benefit from gathering requests together

#

and even if you did gather them together, there's not a great way for the library to handle the 50 requests/sec global baseline, but that can't be assumed either because bots can be given a different global ratelimit, and the only way to get those update ratelimits is to be cloudflare banned a couple of times and then reach out (seriously, this is what the docs say)

#

so if the library did make concurrent requests, which dpy does not, you would want to chunk asyncio.gather to make around 35 requests to leave overhead for the rest of the bot's functions, and then wait a second before making the next batch, and then repeat.

#

I'm working on refactoring the ratelimit handling for disnake to allow users to use the benefit of asyncio.gather if they desire, as right no there is virtually no benefit

hoary haven Mar 20, 2022, 4:19 AM

#

and the only way to get those update ratelimits is to be cloudflare banned a couple of times and then reach out (seriously, this is what the docs say)
lol wat

fallen patrol Mar 20, 2022, 4:19 AM

#

yes

hoary haven Mar 20, 2022, 4:19 AM

#

but yeah if dpy itself is the bottleneck anyway i suppose this won't help

fallen patrol Mar 20, 2022, 4:20 AM

#

disnake should soon have this handled better

#

as an example right now making 40 channels with dpy takes around 8 seconds, new ratelimit handling brings that down to 0.7 seconds

#

which is a huge speed increase, it allows bots to actually take advantage of ratelimits while also making sure you dont get 429s

fallen patrol Mar 20, 2022, 4:24 AM

#

hoary haven but yeah if dpy itself is the bottleneck anyway i suppose this won't help

to note, moving when it happens (from on command to prefetch) will help but now that's a lot of requests every time the bot starts, so some middle ground could be reached

#

but there is also a gateway command which could help with this which I've detailed on the pull

#

wait

#

@hoary haven how many watched users are there

#

just curious if the websocket idea is any good

#

it might not, depending how many users there are to be fetched within 40 seconds, although I have to keep in mind that I have no idea how many are cached

hoary haven Mar 20, 2022, 4:31 AM

#

this topic is whooshing over me so i'll let others comment tmrw BlushFluent

surreal veldt Mar 20, 2022, 10:29 AM

#

Why does this line show this path for invoke_help_command when it's not there? https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/utilities/colour.py#L16

stable mountainBOT Mar 20, 2022, 10:29 AM

#

bot/exts/utilities/colour.py line 16

from bot.exts.core.extensions import invoke_help_command```

cold island Mar 20, 2022, 10:30 AM

#

It is there.. imported from another file. That's not great of course

#

the correct import is bot/utils/extensions.py like hsp mentioned

surreal veldt Mar 20, 2022, 10:33 AM

#

oh so it's not imported from the file the function is created in

cold island Mar 20, 2022, 10:33 AM

#

yeah

signal forge Mar 20, 2022, 7:46 PM

#

@brisk brook - are you around for a quick screen share? I'm working on your code review and have a couple questions about how I should go about creating commits.

brisk brook Mar 20, 2022, 7:46 PM

#

Sorry no, but if you have questions I can answer them in here!

signal forge Mar 20, 2022, 7:48 PM

#

Ok cool. Does each comment get its own commit with comment, or should I just make all the changes then commit?

brisk brook Mar 20, 2022, 7:51 PM

#

If there's for example multiple typos you fix I would put those in the same commit.

#

If the changes are completely unrelated then I sometimes put them in different yes.

signal forge Mar 20, 2022, 7:52 PM

#

Ok cool

brisk brook Mar 20, 2022, 7:52 PM

#

For example, you can have one for fixing the docstrings (I left multiple comments for this), one having to do with extracting the tag from other content and one for embed improvements

#

I see some people just say "Fix after review comments" sometimes, but that can make it unclear what changed when you don't know exactly which comments were made and which were addressed.

signal forge Mar 20, 2022, 7:54 PM

#

Ok cool thanks for the info! And so since httpx is not used, I can pass over your suggestion regarding request blocking?

brisk brook Mar 20, 2022, 8:04 PM

#

signal forge Ok cool thanks for the info! And so since `httpx` is not used, I can pass over y...

Ah, no, like Mark pointed out you should use aiohttp though.

#

Let me see where the session is stored, hold on.

sleek steppe Mar 20, 2022, 8:05 PM

#

bot.http_session

signal forge Mar 20, 2022, 8:12 PM

#

Hmmm... I'm not sure I really understand what aiohttp is doing. Is it making the request to the site?

#

So I would be accessing the site and pulling the html using aiohttp.

brisk brook Mar 20, 2022, 8:14 PM

#

signal forge Hmmm... I'm not sure I really understand what `aiohttp` is doing. Is it making t...

Yes, the same as requests. It's doing the same job, but asynchronously so that the bot can do other things meanwhile!

signal forge Mar 20, 2022, 8:14 PM

#

Agh sweet.... I'd still use BeautifulSoup to get the data from the HTML, right?

brazen charm Mar 20, 2022, 8:17 PM

#

yes

wild prism Mar 20, 2022, 8:17 PM

#

does site not expose this in the API?

tawdry vapor Mar 20, 2022, 8:19 PM

#

No. The categories are kind of hard-coded

#

I say kind of cause the icons are hard coded, but IIRC it actually uses whatever categories it finds in the loose files. Didn't see any validation for that.

signal forge Mar 20, 2022, 8:48 PM

#

wild prism does site not expose this in the API?

In regards to the site, what do you mean when you say API?

#

There is a particular API we can use to access data from the site? Like particular methods that allow for the gathering of data from the site?

molten perch Mar 20, 2022, 8:52 PM

#

Yes, but that API is not accessible to the outer world, just inside the cluster, so the bots can access it.
You can find it here: https://github.com/python-discord/site/tree/main/pydis_site/apps/api
I advise you to read the README it explains you how it works and how the app is structured.

GitHub

site/pydis_site/apps/api at main · python-discord/site

pythondiscord.com - A Django and Bulma web application. - site/pydis_site/apps/api at main · python-discord/site

signal forge Mar 20, 2022, 8:55 PM

#

@brisk brook - What do you suggest I do with the code that's removed from my PR ahead of the API update.... copy paste it somewhere and when the issue is open see if any of it is useful?

wild prism Mar 20, 2022, 8:55 PM

#

the API also handles things not related to the site frontend, like moderation infraction history, but it's still tied into the site project

brisk brook Mar 20, 2022, 8:58 PM

#

signal forge <@!344404945359077377> - What do you suggest I do with the code that's removed f...

That's the beauty with Git. It will always be there in the history: https://github.com/python-discord/bot/blob/e268c7b9e5fcf829c7f2ddbaee0d584b07808aa3/bot/exts/info/resources.py#L14-L36

GitHub

bot/resources.py at e268c7b9e5fcf829c7f2ddbaee0d584b07808aa3 · pyth...

The community bot for the Python Discord community - bot/resources.py at e268c7b9e5fcf829c7f2ddbaee0d584b07808aa3 · python-discord/bot

#

Even if you push more changes, it'll be right there in this commit. As long as you don't force push and delete it permanently

signal forge Mar 20, 2022, 8:58 PM

#

oh wow

brisk brook Mar 20, 2022, 8:58 PM

#

Simply comitting changes that remove it, will still keep it in the history

#

That's the point of Git and why it's used!

wild prism Mar 20, 2022, 8:59 PM

#

if there's an issue open for the API changes, you could link to that commit in a comment

#

and if there isn't you could open one

signal forge Mar 20, 2022, 9:07 PM

#

wild prism and if there isn't you could open one

I'd love to, but really need to finish making changes to my current PR. It's a little overwhelming being my first PR of any real significance lol.

wild prism Mar 20, 2022, 9:09 PM

#

you dont have to of course, but also opening an issue doesnt mean you have to be assigned to it

signal forge Mar 20, 2022, 9:09 PM

#

I'd want to be assigned to it... it seems really interesting plus a terrific learning opportunity.,

#

I'm going to completely remove the scraping portion from my current PR and move it to the future API request issue.

brisk brook Mar 20, 2022, 9:11 PM

#

I think you should just do some basic work to separate obvious resource from the user's message (like splitting by ., newline, | and similar) then just try to set that as a resource

#

Get this working and merged, meanwhile you can look at the site API and open another PR using this new API once it's been merged.

signal forge Mar 20, 2022, 9:12 PM

#

Yea that's what I'm going to do.

#

Would you suggest not SCREAMING_SNAKE_CASE the url since it is being mutated via the appending on to the URL?

#

Actually, I don't need the resources url in my current PR since it's included in the string and fstring

#

I'm going to hope to have my PR updated later tonight.. I have to jet for a bit, but will be back

#

Thank you so much for all the help.

fallen patrol Mar 20, 2022, 11:03 PM

#

cold island It is there.. imported from another file. That's not great of course

why is this even a thing lol

#

it should just be on the context object

#

and use a custom context class

#

type hints would not need to be changed, as the methods do already exist

#

Context.send_help IIRC

#

That could be overridden to send the correct help and wouldn't require this weird method

cold island Mar 20, 2022, 11:05 PM

#

idk, didn't delve deeply into that code 😄

#

It's likely to be replaced eventually with botcore

fallen patrol Mar 20, 2022, 11:06 PM

#

should use a custom context IMO

trail pilot Mar 20, 2022, 11:23 PM

#

i'm trying to set up the site repository, and docker runs and it gives me the link (http://0.0.0.0:8000/), but the link doesn't work and just says "site can't be reached"

vale ibex Mar 20, 2022, 11:27 PM

#

that's the IP within the docker container

#

on your machine it will be 127.0.0.1:8000

cold island Mar 20, 2022, 11:27 PM

#

or just localhost:8000

trail pilot Mar 20, 2022, 11:37 PM

#

ohh

#

thank you

fallen patrol Mar 21, 2022, 12:30 AM

#

@vale ibex bot#2115, are you fetching users that aren't in the guild

dusky shoreBOT Mar 21, 2022, 12:30 AM

#

GitHub

PROpen Pre-fetch watched users to avoid sequential API calls

fallen patrol Mar 21, 2022, 12:31 AM

#

i think you are

#

that means you have around 30 to 60 members who aren't in the cache, and are being fetched as a user

#

huh

#

no, every member is in the guild

vale ibex Mar 21, 2022, 12:36 AM

#

There are many users that aren't in the guild yes

#

but they won't be fetched since we're using get member, so get_or_fetch member will just return None

#

my comment in the conversation isn't accurate, since I made it on my phone and didn't actually read the code properly

#

So we just need to get all the member objects for the people in the guild, but can't solely use member cache since offline user's won't be in there

fallen patrol Mar 21, 2022, 12:43 AM

#

vale ibex There are many users that aren't in the guild yes

so this is a ratelimit issue

#

although why will offline users not be in the cache?

#

hm

#

seems like chunking should be done to fix the cache issues, although i wonder

#

what exactly is the data used for?

#

https://github.com/python-discord/bot/blob/89f7388395ca2c3b7def78d563664b743727aa31/bot/exts/moderation/watchchannels/_watchchannel.py#L368

stable mountainBOT Mar 21, 2022, 12:48 AM

#

bot/exts/moderation/watchchannels/_watchchannel.py line 368

line += f" ({member.name}#{member.discriminator})"```

fallen patrol Mar 21, 2022, 12:48 AM

#

just this

#

and this

#

https://github.com/python-discord/bot/blob/89f7388395ca2c3b7def78d563664b743727aa31/bot/exts/moderation/watchchannels/_watchchannel.py#L371-L372

stable mountainBOT Mar 21, 2022, 12:48 AM

#

bot/exts/moderation/watchchannels/_watchchannel.py lines 371 to 372

if not member:  # Cross off users who left the server.
    line = f"~~{line}~~"```

vocal prairie Mar 21, 2022, 3:03 AM

#

!d r

stable mountainBOT Mar 21, 2022, 3:03 AM

#

Inventories refreshed

vale ibex Mar 21, 2022, 9:52 AM

#

fallen patrol although why will offline users not be in the cache?

I have a vivid memory of offline users not being in the member cache

#

which was causing us issues with modmail

gritty wind Mar 21, 2022, 9:53 AM

#

Start up cache?

#

Shit, not even online members are in it most of the time, as the reminders command constantly reminds me

vale ibex Mar 21, 2022, 9:55 AM

#

nah, even after start up

#

we were having issues where offline users couldn't open modmail threads since they weren't cached

#

We had to change a get to a get or fetch iirc

#

but checking guild.members now, it looks like it's full

green oriole Mar 21, 2022, 10:03 AM

#

that was a discord bug

#

they just didn't send every member for some reason

vale ibex Mar 21, 2022, 10:03 AM

#

sounds believable lol

#

probably not worth forcing the command to take ~1 minute just to cover the case where discord might decide to do that

green oriole Mar 21, 2022, 10:04 AM

#

it was painful to add fetches everywhere

vale ibex Mar 21, 2022, 10:04 AM

#

might just change it to a get only

green oriole Mar 21, 2022, 10:04 AM

#

you could try to get and fetch if it isn't in the cache

#

isn't there a utility for this already?

vale ibex Mar 21, 2022, 10:05 AM

#

it's using get or fetch already

#

there's just so many not in the cache that it's causing a bunch of fetches

#

(this is for the bb watch list)

green oriole Mar 21, 2022, 10:05 AM

#

lol

#

is there an option to lazily load pages

vale ibex Mar 21, 2022, 10:06 AM

#

I was thinking about that lol

#

currently not, but it's already server-side pagination so why not add it 😛

#

probably just pass a coro instead of a line to the paginator and have it inspect for coros

green oriole Mar 21, 2022, 10:07 AM

#

yeah

vale ibex Mar 21, 2022, 10:43 AM

#

I've never had to do this before, so what's the most pythonic way to lay this out?

#

Ideally the paginator would take either a coro or a normal func

#

and then either call the func, or await the coro

#

is there a good way to tell if a given callable is a coro and await it, or just call it if not?

#

my first thought was something like ```py
result = a()
if isinstance(result, typing.Coroutine):
result = await result

placid ermine Mar 21, 2022, 10:47 AM

#

there's inspect.iscoroutinefunction

vale ibex Mar 21, 2022, 10:47 AM

#

ah, would I use that over the isinstance?

placid ermine Mar 21, 2022, 10:48 AM

#

if inspect.iscoroutinefunction(f):
    await f()
else:
    f()

vale ibex Mar 21, 2022, 10:48 AM

#

alright cool, thanks 😄

green oriole Mar 21, 2022, 11:32 AM

#

!docs inspect.isawaitable

stable mountainBOT Mar 21, 2022, 11:32 AM

#

inspect.isawaitable


inspect.isawaitable(object)```
Return `True` if the object can be used in [`await`](https://docs.python.org/3/reference/expressions.html#await) expression.

Can also be used to distinguish generator-based coroutines from regular generators...

green oriole Mar 21, 2022, 11:32 AM

#

Even better @vale ibex @placid ermine

vale ibex Mar 21, 2022, 11:33 AM

#

Wouldn't that require us to actually call the coro?

#

IE inspect.isawaitable(f()) vs inspect.iscoroutinefunction(f)

green oriole Mar 21, 2022, 11:42 AM

#

Not really?

#

I mean

#

Wait

#

You want an awaitable object

#

You want to pass f()

#

then await it when needed

#

So you are free to pass whatever arguments you want to f beforehand, basically getting a more powerful API for free

vale ibex Mar 21, 2022, 11:43 AM

#

Yea, so its py result = a() if inspect.isawaitable(result): result = await result vs ```py
if inspect.iscoroutinefunction(f):
await f()
else:
f()

green oriole Mar 21, 2022, 11:43 AM

#

Yeah

#

Well

vale ibex Mar 21, 2022, 11:43 AM

#

*args **kwargs to the coros ofc

green oriole Mar 21, 2022, 11:44 AM

#

You probably want a check for callable, awaitable then just copy the variable

#

You do not need args and kwargs if you use an awaitable object

vale ibex Mar 21, 2022, 11:45 AM

#

I was thinking of allowing the paginator to accept an awaitable, or a normal func

#

So IG it could accept a partial or an awaitable

green oriole Mar 21, 2022, 11:46 AM

#

I think that's the best option if you want to pass a list of callbacks

vale ibex Mar 21, 2022, 11:46 AM

#

Yea

#

so lines is list[Union[str, Awaitable, functools.Partial]]

green oriole Mar 21, 2022, 11:48 AM

#

Yep

#

well you may as well put Callable[[], str] instead of your partial

#

I wonder if you can set the return value of your awaitable too

vale ibex Mar 21, 2022, 11:49 AM

#

Yea, it would need to return a str

placid ermine Mar 21, 2022, 12:03 PM

#

kind of a weird api tbh lol

green oriole Mar 21, 2022, 12:10 PM

#

it makes sense whne you think about it

#

is the new paginator anywhere?

#

dead bot-core but it is imported as botcore

#

I see no paginator

vale ibex Mar 21, 2022, 12:12 PM

#

paginator hasn't been ported yet

#

and this new thing I'm talking about I havne't written anny code for it

#

just thinking about how I'd implement it

green oriole Mar 21, 2022, 12:13 PM

#

oh yeah, I was just looking for some code to steal

vale ibex Mar 21, 2022, 12:13 PM

#

LinePaginator in bot then

#

can't remember the path off the top of my head

green oriole Mar 21, 2022, 12:13 PM

#

the current paginator is a bit too much of a mess though :P

#

is it not using views

vale ibex Mar 21, 2022, 12:14 PM

#

nope, haven't updated it

green oriole Mar 21, 2022, 12:14 PM

#

no pydis bot has interaction based pagination?

#

I am probably misremebering then

vale ibex Mar 21, 2022, 12:14 PM

#

Correct

#

The help command has interactions

#

!help bb

stable mountainBOT Mar 21, 2022, 12:15 PM

#

Command Help

!bigbrother
Can also use: bb

Monitors users by relaying their messages to the Big Brother watch channel.

Subcommands:

!bigbrother oldest [update_cache=True]
Shows Big Brother monitored users ordered by oldest watched.
!bigbrother unwatch <user> <reason>
Stop relaying messages by the given user.
!bigbrother watch <user> <reason>
Relay messages sent by the given user to the #big-brother channel.
!bigbrother watched [oldest_first=False] [update_cache=True]
Shows the users that are currently being monitored by Big Brother.

green oriole Mar 21, 2022, 12:15 PM

#

aah

vale ibex Mar 21, 2022, 12:15 PM

#

not quite pagination

#

iirc you can control the interaction too

#

we didn't restrict to author

green oriole Mar 21, 2022, 12:15 PM

#

looks like I'm asking the octocat for help

vale ibex Mar 21, 2022, 12:16 PM

#

I think this solution wasn't too bad

#

Can't remember specifics though

green oriole Mar 21, 2022, 12:17 PM

#

I see, I see

vale ibex Mar 21, 2022, 12:17 PM

#

!src help

stable mountainBOT Mar 21, 2022, 12:17 PM

#

Help Command

An interactive instance for the bot help command.

Source Code

Go to GitHub

green oriole Mar 21, 2022, 12:18 PM

#

so much boilerplate

#

thank you

#

any resource to get started with views? :c

vale ibex Mar 21, 2022, 12:20 PM

#

There's some examples in the repo https://github.com/Rapptz/discord.py/tree/master/examples/views

GitHub

discord.py/examples/views at master · Rapptz/discord.py

An API wrapper for Discord written in Python. Contribute to Rapptz/discord.py development by creating an account on GitHub.

#

with fairly decent comments

#

not sure about written guides

#

I bashed my head against the API ref and it was pain

green oriole Mar 21, 2022, 12:27 PM

#

I feel like that's where I'm currently going lmao

#

Represents a UI view.

This object must be inherited to create a UI within Discord.

#

I could have made those docs

vale ibex Mar 21, 2022, 12:34 PM

#

lol searching discord py guides brings up our guide on site

#

#

gotta love that SEO

cold island Mar 21, 2022, 1:11 PM

#

vale ibex

Google adjusts results to you. Try searching from incognito

#

Unless that's what you meant by SEO 🤔

vale ibex Mar 21, 2022, 1:23 PM

#

looks like this for me in incognito 😛

#

So yea, slightly changed

signal forge Mar 21, 2022, 1:44 PM

#

Hi, everyone. I think I'm almost done with my current PR here: https://github.com/python-discord/bot/pull/2117

I am going to adapt a portion of my code from the above PR that was removed to create a new addition to the site API (open the issue and hopefully get assigned to the issue). I've never worked with an API before, so was wondering if there are any more experienced members who could help briefly explain the API and how it interacts with Discord / how the methods are called / utilized across the project? Perhaps a screen share voice chat session would be most beneficial for me. I live in the EDT time zone and can be available anytime after say 8:00 PM.

cold island Mar 21, 2022, 1:47 PM

#

green oriole so much boilerplate

Views and buttons generally don't need this much boilerplate, the use case here is just a bit on the edge since the components are created dynamically

green oriole Mar 21, 2022, 1:47 PM

#

Hmmmmm

brisk brook Mar 21, 2022, 1:57 PM

#

signal forge Hi, everyone. I think I'm almost done with my current PR here: https://github.co...

@last patio ^^

gritty gate Mar 21, 2022, 2:36 PM

#

does @stable mountain use a database for anything?

brisk brook Mar 21, 2022, 2:37 PM

#

Yes

gritty gate Mar 21, 2022, 2:37 PM

#

what database does it use?

brisk brook Mar 21, 2022, 2:37 PM

#

PostgreSQL, it's accessed using the site API.

gritty gate Mar 21, 2022, 2:37 PM

#

oh ok

surreal veldt Mar 21, 2022, 4:12 PM

#

Suggestion: not really major nor significant but on the discord.py articles for the website, make one about subclassing bot and/or Context?

green oriole Mar 21, 2022, 7:37 PM

#

@vale ibex i've made a lazy view based paginator that I'm quite happy about, if that can be useful here

https://github.com/Akarys42/StarBot/blob/main/starbot/utils/paginator.py

GitHub

StarBot/paginator.py at main · Akarys42/StarBot

StarBot is an open-source general-purpose Discord bot aiming to provide essential functionalities needed to run your community - StarBot/paginator.py at main · Akarys42/StarBot

#

It will arrange items given by the list/(async) iterator to form a page until a certain character limit is reached

#

I basically needed that to format my infraction list, and I didn't know how many I could fit in a single page

#

You could use that for BB, with each item being a line about a user

#

Or alternatively scrap that item logic and just take pages straight from the source

austere hornet Mar 21, 2022, 7:42 PM

#

green oriole <@126811506632294400> i've made a lazy view based paginator that I'm quite happy...

.bm

dusky shoreBOT Mar 21, 2022, 7:42 PM

#

In the future, don't do that.

@austere hornet, please enable your DMs to receive the bookmark.

austere hornet Mar 21, 2022, 7:42 PM

#

green oriole <@126811506632294400> i've made a lazy view based paginator that I'm quite happy...

.bm

#

Shoot, sorry for the ping

green oriole Mar 21, 2022, 7:43 PM

#

gurkmoji_sleep_deprived

#

/j

#

Don't forget the rule, if you steal code you star! (yes I just made the rule up)

austere hornet Mar 21, 2022, 7:44 PM

#

Ok, I'll star it 😄

#

But I get the joke 😄

trail pilot Mar 21, 2022, 8:37 PM

#

surreal veldt Suggestion: not really major nor significant but on the discord.py articles for ...

.bm

dim tangle Mar 22, 2022, 2:35 AM

#

.ttt

vocal prairie Mar 22, 2022, 2:36 AM

#

^ that command is causing this error #sir-lancebot-playground message

#

hmm interesting, it works in #bot-commands

#

maybe it was just the channel occupation thing

#

by that, I mean https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/fun/tic_tac_toe.py#L256-L257

stable mountainBOT Mar 22, 2022, 2:37 AM

#

bot/exts/fun/tic_tac_toe.py lines 256 to 257

@is_channel_free()
@is_requester_free()```

slim widget Mar 22, 2022, 2:48 AM

#

Do you mind if I reload it, or do you want me to leave it so you can investigate what went wrong?

surreal veldt Mar 22, 2022, 10:25 AM

#

trail pilot .bm

what's this mean?

#

oh wait it is the bookmark command, my bad

surreal veldt Mar 22, 2022, 4:10 PM

#

I was going to make a PR about subclassing commands.Context and commands.Bot as an article on the pydis site. But as this requires some knowledge of OOP, I haven't found any articles on the site about basic subclassing so could this be made? I wouldn't mind writing it down

cold island Mar 22, 2022, 4:20 PM

#

I'm wondering if that's the right place for such a guide. Wouldn't it be more beneficial on the discordpy docs?

surreal veldt Mar 22, 2022, 4:26 PM

#

You mean for the dpy github? Or for the dpy docs on the pydis github

sharp crag Mar 22, 2022, 5:39 PM

#

surreal veldt Suggestion: not really major nor significant but on the discord.py articles for ...

Hi, thanks for the suggestion. I'd like to have this included within the site as I believe subclassing bot is very beneficial and provides you more control over your bot. If you want to take this up and make a PR, I wouldn't mind helping. If you don't want to though, I would be fine making one as well. Just let me know what you plan to do :)

surreal veldt Mar 22, 2022, 5:40 PM

#

I wouldn't helping?

sharp crag Mar 22, 2022, 5:40 PM

#

Sorry

#

But about the custom context, don't we already have an example?

surreal veldt Mar 22, 2022, 5:41 PM

#

Oh you do?

sharp crag Mar 22, 2022, 5:41 PM

#

https://github.com/Rapptz/discord.py/blob/master/examples/custom_context.py

GitHub

discord.py/custom_context.py at master · Rapptz/discord.py

An API wrapper for Discord written in Python. Contribute to Rapptz/discord.py development by creating an account on GitHub.

#

Well not us

surreal veldt Mar 22, 2022, 5:41 PM

#

May have missed it

surreal veldt Mar 22, 2022, 5:41 PM

#

sharp crag https://github.com/Rapptz/discord.py/blob/master/examples/custom_context.py

No plans to make a detailed explanation of it?

sharp crag Mar 22, 2022, 5:42 PM

#

Well they only have examples, I feel like it would be useful if we had both the example, explanations, and advantages/disadvantages of it

#

Just bare code examples aren't really helpful if you get what I'm saying

surreal veldt Mar 22, 2022, 5:42 PM

#

Yeah

sharp crag Mar 22, 2022, 5:42 PM

#

For example, this has a subclassed client: https://github.com/Rapptz/discord.py/blob/master/examples/edits.py but again it's just a barebones example that could be confusing to newer users

#

I feel that advanced topics within discord bots that require both examples and detailed explanations which discord.py doesn't do all that well

surreal veldt Mar 22, 2022, 5:43 PM

#

So you think both are worth making pr's?

sharp crag Mar 22, 2022, 5:43 PM

#

I do, yes, and make it much more detailed

surreal veldt Mar 22, 2022, 5:44 PM

#

Can i make it?

sharp crag Mar 22, 2022, 5:44 PM

#

Both?

#

I'm fine with whatever just make sure you can handle it

#

I wouldn't want you to have to do too much work :p

surreal veldt Mar 22, 2022, 5:46 PM

#

I'll let you know and i enjoy making these now so it's fine haha

sharp crag Mar 22, 2022, 5:46 PM

#

Great, think about it and let me know which ones you want to do :)

surreal veldt Mar 22, 2022, 5:48 PM

#

Oh wait maybe they can be in the samd fil

#

File*

#

Because in order to subclass context you need to subclass bot

sharp crag Mar 22, 2022, 6:09 PM

#

surreal veldt Oh wait maybe they can be in the samd fil

Hmmm

#

I think it’s best to seperate them but have custom context build upon subclassed bot

surreal veldt Mar 22, 2022, 6:10 PM

#

What do you mean?

#

Oh i got it

sharp crag Mar 22, 2022, 6:12 PM

#

Something like “in order to have a custom context, you need a custom bot, so it’s recommended to read the subclassing bot guide before reading this guide, if you haven’t already”

cold island Mar 22, 2022, 6:57 PM

#

surreal veldt You mean for the dpy github? Or for the dpy docs on the pydis github

The latter

#

No

#

The former

#

lol

surreal veldt Mar 22, 2022, 7:01 PM

#

cold island The latter

So you think it's not worh makinga PR?

cold island Mar 22, 2022, 7:51 PM

#

surreal veldt So you think it's not worh makinga PR?

I don't mind, just wondering where it will be the most useful

#

@patent pivot out of curiosity, what's the traffic for our dpy guide? 🤔

#

Probably deserves an update after 2.0 comes out, it doesn't even mention intents

patent pivot Mar 22, 2022, 7:57 PM

#

cold island <@!165023948638126080> out of curiosity, what's the traffic for our dpy guide? �...

last 7 days it's the 4th most viewed page on pythondiscord.com

#

based on a 10% sample of requests

#

that's after the homepage, /resources/ and the code of conduct

#

again my usual disclaimer of these analytics are dodgy and should not be trusted

#

for last 12 months, Google Search puts it as our 5th most clicked page from search results after homepage, homepage with www, setting up test server and setting up test server with www

cold island Mar 22, 2022, 8:19 PM

#

tnx

signal forge Mar 23, 2022, 12:37 AM

#

Hey, everyone. Do any of you accept suggested changes from within GH Pull Requests? Is this advisable?

#

I'd have to update my local project so to have the latest changes locally, right?

#

That is if I accept the suggested changes in the PR.

vocal prairie Mar 23, 2022, 12:39 AM

#

signal forge Hey, everyone. Do any of you accept suggested changes from within GH Pull Reques...

I find suggested changes helpful, personally. I usually don't click the "commit" button since that creates a whole commit; rather, I just copy/make the suggested changes locally. Although that's a personal preference.

brisk brook Mar 23, 2022, 12:42 AM

#

@vocal wolf I thought the future of that PR was somewhat unknown because of changes happening to the infrastructure?

signal forge Mar 23, 2022, 12:42 AM

#

Hey @brisk brook! Thanks for the review.... I'm working on it now 🙂

vocal wolf Mar 23, 2022, 12:42 AM

#

which PR are you talking about? the global leaderboard?

brisk brook Mar 23, 2022, 12:42 AM

#

Yeah

vocal wolf Mar 23, 2022, 12:43 AM

#

I am unsure myself

#

since no one had commented on the issue about this, I have absolutely no idea, actually

vocal prairie Mar 23, 2022, 12:44 AM

#

I'm pretty sure that DevOps is going to enforce that Redis (or KeyDB, not sure) not be relied on for persistence at all, so there shall be no persistent storage for Sir Lance.

#

cc @patent pivot because he knows

patent pivot Mar 23, 2022, 12:47 AM

#

vocal prairie I'm pretty sure that DevOps is going to enforce that Redis (or KeyDB, not sure) ...

not no persistent storage, just no persistence relying on redis, anything persistent needs to use site @vocal wolf

vocal wolf Mar 23, 2022, 12:48 AM

#

very well

vocal prairie Mar 23, 2022, 12:48 AM

#

Lance will never use site though, will it (in the foreseeable future)?

#

To keep a low barrier of contribution and all

#

So doesn't that mean that Lance will have no persistent storage?

sleek steppe Mar 23, 2022, 12:49 AM

#

vocal prairie Lance will never use site though, will it (in the foreseeable future)?

It won't, so lancebot won't have any persistent storage

vocal prairie Mar 23, 2022, 12:50 AM

#

that's what I meant, sorry if it wasn't clear

patent pivot Mar 23, 2022, 12:51 AM

#

uhhh

#

I think with bot core we can make it not so bad

#

I don't recall us making the decision that Lance will have no persistent storage

signal forge Mar 23, 2022, 12:53 AM

#

@brisk brook Would you happen to have time to briefly explain why from urllib.parse import quote is needed? Wouldn't it accomplish the same thing as the code currently is configured?

vocal prairie Mar 23, 2022, 12:53 AM

#

patent pivot I don't recall us making the decision that Lance will have no persistent storage

Apologies if I am mistaken. My understanding was that all persistence should go through site, and that Lance should never need site so that users don't have to spin it up to run it, since having to do so is a barrier to contribution (although less so with Docker and all).

sleek steppe Mar 23, 2022, 12:54 AM

#

patent pivot I don't recall us making the decision that Lance will have no persistent storage

wasn't that one of the reasons we went with the event bot, or am I missing something?

brisk brook Mar 23, 2022, 12:56 AM

#

signal forge <@!344404945359077377> Would you happen to have time to briefly explain why `fro...

It'll replace characters that are invalid with their %-escapes. It's a way of sanitizing the user-input you format into the URL.

patent pivot Mar 23, 2022, 12:56 AM

#

vocal prairie Apologies if I am mistaken. My understanding was that all persistence should go ...

I think the solution there is to make site easier rather than to completely rule out persistence -- site isn't too bad to spin up nowadays, we removed the need to move /etc/hosts, we're working on documenting the project more -- site should not be a complex project

signal forge Mar 23, 2022, 12:56 AM

#

brisk brook It'll replace characters that are invalid with their `%`-escapes. It's a way of ...

Oh wow.

#

Awesome. Thanks 🙂

patent pivot Mar 23, 2022, 12:56 AM

#

sleek steppe wasn't that one of the reasons we went with the event bot, or am I missing somet...

not the sole reason -- maybe a contributing factor -- I really don't want to see persistence ruled out on Lance

signal forge Mar 23, 2022, 12:58 AM

#

What a cool module!

#

Damn.

vocal prairie Mar 23, 2022, 12:58 AM

#

patent pivot I think the solution there is to make site easier rather than to completely rule...

understood, thanks~

brisk brook Mar 23, 2022, 12:58 AM

#

signal forge Oh wow.

It's not like it posses a huge security risk right now, don't get me wrong. I believe there was a PR that changed all URL formatting to it though so I think it's best to keep that, good practice as well!

Emojis come to mind immediately, they'll be changed because they're invalid in URLs

signal forge Mar 23, 2022, 12:58 AM

#

urlparse so neat.... would love to see the source code for that.

brisk brook Mar 23, 2022, 12:59 AM

#

Trust me, you probably don't 😅. I've looked into it once, and the code wasn't very clear. Very oddly designed.. but hey!.. it works!

signal forge Mar 23, 2022, 12:59 AM

#

lol

brisk brook Mar 23, 2022, 1:01 AM

#

Here it is if you're curious:
https://github.com/python/cpython/blob/main/Lib/urllib/parse.py

GitHub

cpython/parse.py at main · python/cpython

The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

signal forge Mar 23, 2022, 1:03 AM

#

lol I recognize some of the names in the comments from my job.

#

I work as an Executive Assistant at MIT.

#

T. Berners-Lee

brisk brook Mar 23, 2022, 1:03 AM

#

Cool haha

#

Well, yeah those classes are so odd to me...

signal forge Mar 23, 2022, 1:09 AM

#

I got a weird error using quote

#

Unexpected type(s):(set[str])Possible type(s):(bytes)(str)

#

Sorry, an unexpected error occurred. Please let us know!

TypeError: quote_from_bytes() expected bytes

#

Bot is throwing an error as well.

brisk brook Mar 23, 2022, 1:10 AM

#

signal forge `Unexpected type(s):(set[str])Possible type(s):(bytes)(str)`

That looks odd, is that just your editor?

signal forge Mar 23, 2022, 1:10 AM

#

It is, but the bot is erroring after comman dis provided.

brisk brook Mar 23, 2022, 1:10 AM

#

set[str].. huh? Where does that come from?

signal forge Mar 23, 2022, 1:11 AM

#

async def resources_command(self, ctx: commands.Context, *, resource_topic: Optional[str]) -> None:

brisk brook Mar 23, 2022, 1:11 AM

#

Can you show a screenshot where you hover over it maybe?

signal forge Mar 23, 2022, 1:11 AM

#

brisk brook Mar 23, 2022, 1:18 AM

#

Yeah look, you have an odd pair of { around respurce_topic

#

Also.. I was thinking you do the formatting inside of response_url = "...". Not sure if it's better that way though, but just to be clear 👌

signal forge Mar 23, 2022, 1:45 AM

#

brisk brook Also.. I was thinking you do the formatting inside of `response_url = "..."`. No...

Got it! Just pushed to the repo!

brisk brook Mar 23, 2022, 1:48 AM

#

Awesome! I will have to take a look tomorrow

signal forge Mar 23, 2022, 1:51 AM

#

Thanks for all your help...

#

Once this one is finished, perhaps I can work on opening the issue for the site API feature for scraping.

thorny obsidian Mar 23, 2022, 1:58 AM

#

patent pivot I don't recall us making the decision that Lance will have no persistent storage

I don't think making site a dependency to Sir Lancebot is the way to go. I even opted for Sir Robin to prevent site being required for Lance.

#

If you don't use docker site is still very =/ to set up (as someone who doesn't work with pg on the daily outside of specific work projects)

surreal veldt Mar 23, 2022, 3:22 AM

#

There is no command that shows the python guides on the pydis site?

wild prism Mar 23, 2022, 3:36 AM

#

surreal veldt There is no command that shows the python guides on the pydis site?

wdym?

surreal veldt Mar 23, 2022, 3:42 AM

#

wild prism wdym?

https://github.com/python-discord/site/tree/main/pydis_site/apps/content/resources/guides/python-guides

GitHub

site/pydis_site/apps/content/resources/guides/python-guides at main...

pythondiscord.com - A Django and Bulma web application. - site/pydis_site/apps/content/resources/guides/python-guides at main · python-discord/site

wild prism Mar 23, 2022, 3:44 AM

#

just a command to link that?

surreal veldt Mar 23, 2022, 3:46 AM

#

wild prism just a command to link that?

Yeah maybe something like (with the command name beng x)
!x (optional guide)

surreal veldt Mar 23, 2022, 4:03 AM

#

@sharp crag do you know any article which is good that explains basic subclassing in python?

sharp crag Mar 23, 2022, 4:09 AM

#

Unfortunately no, it's just OOP that I learned from CS classes in school

#

I think if you know how inheritance works conceptually you can get subclassing within python relatively easily

surreal veldt Mar 23, 2022, 4:09 AM

#

how do I make two seperate PR's?

sharp crag Mar 23, 2022, 4:10 AM

#

Fork it, make 2 different branches, and PR each of those branches

surreal veldt Mar 23, 2022, 4:11 AM

#

oh no i know subclassing but for the subclassing bot pr i'm gonig to make

sharp crag Mar 23, 2022, 4:11 AM

#

What about the PR?

surreal veldt Mar 23, 2022, 4:15 AM

#

sharp crag What about the PR?

basic subclassing

#

What I mean is I asked for any good article on basic subclassing in python to put in the PR about subclassing bot, because basic understanding of subclassing is a better start to doing it

sharp crag Mar 23, 2022, 4:16 AM

#

Ohh I see

#

Just like "Subclassing bot requires you to know how subclassing works, to learn more about that look at this article: " or something like that?

surreal veldt Mar 23, 2022, 4:17 AM

#

sharp crag Fork it, make 2 different branches, and PR each of those branches

ah so fork it twice

sharp crag Mar 23, 2022, 4:17 AM

#

surreal veldt ah so fork it twice

No no, just fork it once

surreal veldt Mar 23, 2022, 4:17 AM

#

is a fork a branch?

sharp crag Mar 23, 2022, 4:17 AM

#

You fork an entire repository and all the branches inside it

#

You can then add more branches to the fork

#

So you could fork python-discord/site then add 2 branches like: subclassing-bot and custom-context

surreal veldt Mar 23, 2022, 4:17 AM

#

uhhhh

#

oh yeah

#

how do I add the branch again?

#

git branch [name]?

sharp crag Mar 23, 2022, 4:18 AM

#

Hmm let me double check

surreal veldt Mar 23, 2022, 4:19 AM

#

got it

sharp crag Mar 23, 2022, 4:19 AM

#

Use git branch -b <branch-name> to make a new branch

surreal veldt Mar 23, 2022, 4:19 AM

#

sharp crag Just like "Subclassing bot requires you to know how subclassing works, to learn ...

and yes

sharp crag Mar 23, 2022, 4:19 AM

#

Then to switch to that branch, use git checkout <branch-name>

#

From there you can git commit and git push

#

I'd recommend using vscode's native git integration as you don't have to worry about commands but worry about making the actual content

surreal veldt Mar 23, 2022, 4:20 AM

#

ah welp on my local machine I meant to delete one new file I just made on the site but deleted a whole bunch...

#

sharp crag Mar 23, 2022, 4:21 AM

#

Luckily you can always just delete the folder and clone it again if worst comes to worst

surreal veldt Mar 23, 2022, 4:21 AM

#

yeah i'll just fork it again

vocal wolf Mar 23, 2022, 4:22 AM

#

@surreal veldt in this case you can just do git restore . to restore all those files

surreal veldt Mar 23, 2022, 4:22 AM

#

oh cool that worked thank you

vocal wolf Mar 23, 2022, 4:22 AM

#

ok_handbutflipped

surreal veldt Mar 23, 2022, 4:23 AM

#

i saw it in the error but wasn't sure

#

not error, in the git status command*

#

error: unknown switch `b'```

sharp crag Mar 23, 2022, 4:25 AM

#

Ah my bad there's no -b flag

#

just git branch branch-name like you said

surreal veldt Mar 23, 2022, 4:25 AM

#

what did I do wrong?

sharp crag Mar 23, 2022, 4:25 AM

#

Nothing, my fault. It's just git branch without git branch -b

#

I was looking at something else

#

Got it confused with checkout -b

vocal wolf Mar 23, 2022, 4:25 AM

#

if you want to make a branch and switch to it, you can do git checkout -b some-branch

#

git branch some-branch will just create the branch, and you won't switch to it

sharp crag Mar 23, 2022, 4:26 AM

#

Yeah that's just 2 steps in one, doesn't really matter

vocal wolf Mar 23, 2022, 4:26 AM

#

yep

surreal veldt Mar 23, 2022, 4:26 AM

#

oh wait what's the difference between git checkout [branch] and git checkout -b [branch]?

#

I just did git checkout [branch]

#

but it seemed to do the same thing though

vocal wolf Mar 23, 2022, 4:27 AM

#

Since you already created the branch, git checkout will switch to that branch you had previously created with git branch

#

git checkout -b some-branch combines the two steps into one by creating, then switching to said branch

surreal veldt Mar 23, 2022, 4:28 AM

#

Can I ask here the benefits for subclassing bot to put in the PR?

vocal wolf Mar 23, 2022, 4:28 AM

#

so, git checkout -b some-branch is equivilant to git branch some-branch && git checkout some-branch

surreal veldt Mar 23, 2022, 4:28 AM

#

This is what I have already

#

Subclassing Bot can be very beneficial as it provides you with more control and customizability of how your bot functions. For example, the default `commands.Context` can be overridden to add more functionality.```

sharp crag Mar 23, 2022, 4:50 AM

#

surreal veldt This is what I have already

Maybe you could add some more examples?

surreal veldt Mar 23, 2022, 5:39 AM

#

sharp crag Maybe you could add some more examples?

mind reviewing these?

sharp crag Mar 23, 2022, 5:46 AM

#

surreal veldt mind reviewing these?

Great, looks like you have it. Could you make a PR with it and I'll review it on github instead of here? I'd like to keep everything in one place and also have the others pitch in

#

If you could also request a review from me on github that sends me an email

#

You have a pretty good foundation to build upon which is awesome 😄

surreal veldt Mar 23, 2022, 5:48 AM

#

sharp crag If you could also request a review from me on github that sends me an email

How do I do this?

sharp crag Mar 23, 2022, 5:50 AM

#

Once you make a PR, you should see something like this with a little cog in the top right:

#

From there you should be able to request a review

surreal veldt Mar 23, 2022, 5:50 AM

#

What's your github username?

sharp crag Mar 23, 2022, 5:51 AM

#

Should just be Robin5605

surreal veldt Mar 23, 2022, 5:58 AM

#

okay thanks, will do in a bit

sharp crag Mar 23, 2022, 5:59 AM

#

Cool, I'm off to bed then. Thanks again for taking this up 😄

surreal veldt Mar 23, 2022, 6:00 AM

#

Good night!

surreal veldt Mar 23, 2022, 7:17 AM

#

~~I've made the PR, but can't find the button to add reviewers~~ I just saw it now, do I need to press the convert to draft button?

reef tinsel Mar 23, 2022, 8:06 AM

#

You can't add reviews if you don't have certain perms on the repo iirc

surreal veldt Mar 23, 2022, 8:11 AM

#

reef tinsel You can't add reviews if you don't have certain perms on the repo iirc

no not to add a review, I want to add a reviewer

reef tinsel Mar 23, 2022, 8:21 AM

#

surreal veldt no not to add a review, I want to add a reviewer

I meant requesting reviews, must have done the wrong word!

gritty wind Mar 23, 2022, 8:43 AM

#

If you’d like to request someone for review, you’re going to need to ask them on discord to request themselves, or just ask them to review right away

#

It’s a spam/harassment protection mechanism, otherwise you could just flood people with review requests

surreal veldt Mar 23, 2022, 8:47 AM

#

CC @sharp crag ^

sharp crag Mar 23, 2022, 1:05 PM

#

surreal veldt CC <@432643355634171905> ^

No prob, I’ll take a look at it later today

surreal veldt Mar 23, 2022, 1:22 PM

#

sharp crag No prob, I’ll take a look at it later today

Thank you, also I've more or less written the subclassing Context, for the most part i was able to copy subclassing bot and tweak a bit but I may PR that later if it's thought to be worth doing so

sharp crag Mar 23, 2022, 3:28 PM

#

👍

surreal veldt Mar 23, 2022, 5:53 PM

#

For making PR's, if I am on branch x and add a file, and then when I switch to another branch (take it as y), that same file that i made for branch x comes to the branch y. How or can do I prevent this?

cold island Mar 23, 2022, 5:57 PM

#

You commit it to branch x

gritty wind Mar 23, 2022, 5:57 PM

#

First save your changes. You can commit or stash. Then checkout the main branch, then create a new branch. You can do the last two steps at once with git checkout -b y main

surreal veldt Mar 23, 2022, 5:58 PM

#

i believe i did those steps

gritty wind Mar 23, 2022, 5:58 PM

#

Which steps

cold island Mar 23, 2022, 5:59 PM

#

gritty wind First save your changes. You can commit or stash. Then checkout the main branch,...

they didn't say they want to create a new branch though

gritty wind Mar 23, 2022, 6:03 PM

#

I believe the lower b flag checks out if it already exists

#

The crucial step here is commiting/stashing tho

surreal veldt Mar 23, 2022, 7:27 PM

#

by the way @sharp crag regarding the comment you made on the PR, would it be

async def start(self, token: str, *, reconnect: bool = False)
self.db = aiosqlite.connect('database')
await super().start(token, reconnect)

#

I'll get it updated soon

sharp crag Mar 23, 2022, 8:51 PM

#

And also, acquiring a cursor using custom context is another excellent use case. RoboDanny has that feature, I would recommending checking out its implementation and maybe include it in your custom context guide

surreal veldt Mar 24, 2022, 3:58 AM

#

sharp crag And also, acquiring a cursor using custom context is another excellent use case....

Mind Linking it? Can't seem to find it

surreal veldt Mar 24, 2022, 4:00 AM

#

surreal veldt by the way <@!432643355634171905> regarding the comment you made on the PR, woul...

Also, for this, how would the database be accessed? self.db in the main file and self.bot.db in cogs?

sharp crag Mar 24, 2022, 4:00 AM

#

surreal veldt Also, for this, how would the database be accessed? `self.db` in the main file a...

Yeah, or use the custom context database connection

#

https://github.com/Rapptz/RoboDanny/blob/rewrite/cogs/utils/context.py#L10-L25 might be interesting

surreal veldt Mar 24, 2022, 4:00 AM

#

yeah i will remove the overriding start method from subclassing bot I think

#

or maybe I can just write

sharp crag Mar 24, 2022, 4:01 AM

#

Yeah I think having custom context with a database connection would be really good since you can just do something like

async with ctx.cursor() as cur:
  await cur.execute(...)

surreal veldt Mar 24, 2022, 4:01 AM

#

async def start(self, token: str, *, reconnect: bool = False):
# here you are overriding the default start method. You can do some code here for example establish a database connection
await super().start(token, reconnect)

#

why is it blue?

sharp crag Mar 24, 2022, 4:02 AM

#

You forgot the : after the function declaration

surreal veldt Mar 24, 2022, 4:02 AM

#

oh lol

#

class _ContextDBAcquire:
    __slots__ = ('ctx', 'timeout')

    def __init__(self, ctx, timeout):
        self.ctx = ctx
        self.timeout = timeout

    def __await__(self):
        return self.ctx._acquire(self.timeout).__await__()

    async def __aenter__(self):
        await self.ctx._acquire(self.timeout)
        return self.ctx.db

    async def __aexit__(self, *args):
        await self.ctx.release()

Yeah I don't understand anything here

#

robodanny uses postrgreSQL?

sharp crag Mar 24, 2022, 4:04 AM

#

yeah

sharp crag Mar 24, 2022, 4:04 AM

#

surreal veldt ```py class _ContextDBAcquire: __slots__ = ('ctx', 'timeout') def __ini...

It's just implementing a async context manager

#

the __await__ isn't important

#

__aenter__ and __aexit__ is what's important

surreal veldt Mar 24, 2022, 4:05 AM

#

so..robodanny is able to do this


        query = """INSERT INTO guild_mod_config (id, mute_role_id)
                   VALUES ($1, $2) ON CONFLICT (id)
                   DO UPDATE SET
                       mute_role_id = EXCLUDED.mute_role_id;
                """
        await ctx.db.execute(query, guild_id, role.id)

sharp crag Mar 24, 2022, 4:05 AM

#

async with ... as something: # __aenter__() is called and passed to `something`
  ... 
  # __aexit__() is called

sharp crag Mar 24, 2022, 4:05 AM

#

surreal veldt so..robodanny is able to do this ```py query = """INSERT INTO guild_mod...

Well not really

#

    def acquire(self, *, timeout=300.0):
        """Acquires a database connection from the pool. e.g. ::
            async with ctx.acquire():
                await ctx.db.execute(...)
        or: ::
            await ctx.acquire()
            try:
                await ctx.db.execute(...)
            finally:
                await ctx.release()
        """
        return _ContextDBAcquire(self, timeout)

#

https://github.com/Rapptz/RoboDanny/blob/rewrite/cogs/utils/context.py#L204-L218

surreal veldt Mar 24, 2022, 4:07 AM

#

is this a lot more easier or efficient for aioqlite? compared to using the default way

sharp crag Mar 24, 2022, 4:07 AM

#

Definetely not easier. It's on the advanced side but gives you much more customizability

#

You can also include some other examples that RoboDanny has for the custom context doesn't have to be this

surreal veldt Mar 24, 2022, 4:08 AM

#

i saw he has ctx.prompt too may do that

sharp crag Mar 24, 2022, 4:08 AM

#

Yeah that might be interesting to people

#

For the database if you want you can just stick to overriding start() and doing it there so we don't confuse people too much

surreal veldt Mar 24, 2022, 4:10 AM

#

okay also for that when it's self.db in main but self.bot.db in cogs, can you tell me if it is self.bot.db in cogs, why isn't it bot.db in main?

sharp crag Mar 24, 2022, 4:11 AM

#

Well in main we're inside thee commands.Bot subclass so it would be self instead of bot

#

If we didn't subclass, then yeah it'd be bot.db

surreal veldt Mar 24, 2022, 4:16 AM

#

class CustomBot(commands.Bot):
    def __init__(self):
        super().__init__(
            command_prefix = #your prefix here as a string
            intents = #your intents here
            #other kwargs can be put here
        )
        #custom bot attributes can be set here, for example:
        self.launch_time = datetime.datetime.utcnow()
        self.example_integer = 5


    async def start(self, *args, **kwargs):

    # here you are overriding the default start method. You can do some code here for example establish a database connection
    #as shown in this example below
    self.db = await aiosqlite.connect('database file')
        await super().start(*args, **kwargs)


bot = CustomBot()

token = YOUR_TOKEN_HERE
bot.run(token)

This is correct?

sharp crag Mar 24, 2022, 4:34 AM

#

surreal veldt ```py class CustomBot(commands.Bot): def __init__(self): super().__i...

Correct me if I'm wrong, don't you have to await aiosqlite.connect()?

surreal veldt Mar 24, 2022, 4:41 AM

#

sharp crag Correct me if I'm wrong, don't you have to await `aiosqlite.connect()`?

nope

#

wait

#

oh wait you have to

#

i guess i never used it that way

surreal veldt Mar 24, 2022, 8:16 AM

#

Can I make some changes to the code by pressing the edit button?

#

I'm having some issues when trying to update the code in the PR

gritty wind Mar 24, 2022, 8:39 AM

#

You can edit it in the GitHub interface if you want, that’s up to you

surreal veldt Mar 24, 2022, 9:48 AM

#

okay so I noticed that if I start with a PR for branch x with a starting file, and then after that I make a new branch y and make a new file, when I PR the changes in branch y both the changes from branch x and y gets added

gritty wind Mar 24, 2022, 9:49 AM

#

Are your changes commited to branch x or not

#

If they are, you have to make sure that the branch y is created from the “main” branch, not the x branch. That is something you have to ensure when creating the branch.

If the change isn’t commited, git won’t automatically remove it when you open a new branch, you need to make sure you have no changes. You can do that by commiting your existing changes on branch x, or use git stash

cursive relic Mar 24, 2022, 10:05 AM

#

Why does !ot <anything after that> not work?

surreal veldt Mar 24, 2022, 10:09 AM

#

gritty wind If they are, you have to make sure that the branch y is created from the “main” ...

. That is something you have to ensure when creating the branch. how does one do this?

gritty wind Mar 24, 2022, 10:10 AM

#

git checkout -b branch_name main

#

This will create a branch called branch_name, and it’ll start from the main branch, not x

vale ibex Mar 24, 2022, 10:11 AM

#

cursive relic Why does `!ot <anything after that>` not work?

Since it's a tag, and !ot is fuzzy matching to !off-topic, I imagine the extra stuff on the end is interfering the the fuzzy matching

cursive relic Mar 24, 2022, 10:12 AM

#

Oh I see, thx for the info 😄

surreal veldt Mar 24, 2022, 10:13 AM

#

gritty wind `git checkout -b branch_name main`

so if I were to do git branch something and do git checkout -b something it's wrong?

gritty wind Mar 24, 2022, 10:13 AM

#

No, it just won’t do anything special

#

But if you’re still in the x branch when you run that

#

It’ll keep your changes from the x branch in the new branch

#

Fwiw, I typically don’t recommend people who are still trying to wrap their heads around git start from the command line.

Tree visualizations, and not having to memorize commands helps you understand first, then you can learn the commands when you want

surreal veldt Mar 24, 2022, 10:16 AM

#

oh okay so that's where I went wrong

#

unfortunately I made a PR with two extra files which weren't relevant so three in total now I have to delete them

surreal veldt Mar 24, 2022, 2:29 PM

#

What's the status on the bots in this server's library? Are they fully moved to dpy?

cold island Mar 24, 2022, 3:20 PM

#

yes

surreal veldt Mar 24, 2022, 3:27 PM

#

so...i had a suggestion: Make the bookmark command into a message application command. Can I make a PR/issue?

vale ibex Mar 24, 2022, 3:29 PM

#

a context menu would likely be even better

#

Does d.py support those yet? I'm not even sure

surreal veldt Mar 24, 2022, 3:30 PM

#

vale ibex Does d.py support those yet? I'm not even sure

is this what you mean?

#

the apps

vale ibex Mar 24, 2022, 3:31 PM

#

Yea, that's called a context menu

surreal veldt Mar 24, 2022, 3:31 PM

#

okay so I'm not sure why I keep calling it a message application command but I thought it was that

#

anyways, that's what I meant

surreal veldt Mar 24, 2022, 3:32 PM

#

surreal veldt okay so I'm not sure why I keep calling it a message application command but I t...

oh i remember now

cold island Mar 24, 2022, 3:33 PM

#

We're not on the latest commit yet, but we thought of doing that, yeah

surreal veldt Mar 24, 2022, 3:33 PM

#

vale ibex Does d.py support those yet? I'm not even sure

I'm pretty sure, there were so many changes added in the last two weeks or so

surreal veldt Mar 24, 2022, 3:34 PM

#

surreal veldt There is no command that shows the python guides on the pydis site?

oh and also can I have response on this?

cold island Mar 24, 2022, 3:34 PM

#

No, there isn't

patent pivot Mar 24, 2022, 3:35 PM

#

vale ibex Does d.py support those yet? I'm not even sure

yea it does

#

https://discordpy.readthedocs.io/en/master/interactions/api.html#contextmenu

surreal veldt Mar 24, 2022, 3:36 PM

#

cold island No, there isn't

and there aren't any plans to do this?

cold island Mar 24, 2022, 3:36 PM

#

I don't think it's something that's ever come up before

#

That list and the quality of the guides is a little undefined at the moment

wind ruin Mar 24, 2022, 3:37 PM

#

patent pivot yea it does

(the pip version is still on 1.7.3 though, so technically not yet - despite it being there in the github)

cold island Mar 24, 2022, 3:37 PM

#

For example the dpy guide is very outdated

surreal veldt Mar 24, 2022, 3:38 PM

#

fair

#

but, on another topic, it's going to be updated?

cold island Mar 24, 2022, 3:38 PM

#

I guess so, after dpy 2.0 comes out

vale ibex Mar 24, 2022, 3:39 PM

#

wind ruin (the pip version is still on 1.7.3 though, so technically not yet - despite it b...

we download directly from master on github

#

pinned to a commit hash

wind ruin Mar 24, 2022, 3:39 PM

#

ah

wind ruin Mar 24, 2022, 3:40 PM

#

surreal veldt but, on another topic, it's going to be updated?

but yeah - the 2.0 components are still very much work in progress as far as I know, there could be breaking changes until they 'officially' release 2.0

small oar Mar 25, 2022, 12:42 AM

#

Hi I downloaded the zip of python discord bot

#

from the github, how would i set it up?
https://github.com/python-discord/bot

GitHub

GitHub - python-discord/bot: The community bot for the Python Disco...

The community bot for the Python Discord community - GitHub - python-discord/bot: The community bot for the Python Discord community

#

like which file do i edit.

dim pelican Mar 25, 2022, 12:52 AM

#

small oar from the github, how would i set it up? https://github.com/python-discord/bot

Hello! Check out this page for contributing to (and setting up) the bot: https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/bot/

Python Discord - Contributing to Bot

A guide to setting up and configuring Bot.

#

Please note that we do consider Sir-Lancebot to be a bit more beginner friendly:
https://github.com/python-discord/sir-lancebot
https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/sir-lancebot/

small oar Mar 25, 2022, 12:54 AM

#

!!!! alr

#

thx

signal forge Mar 25, 2022, 1:22 AM

#

Oh dear @brisk brook - I'm so sorry for waisting your time by removing the new lines again. I pushed the update adding back the new lines and will hopefully not cause such trivial wastes of time again!

wild prism Mar 25, 2022, 4:07 AM

#

could we fuzzy-match tags only up until a newline?

surreal veldt Mar 25, 2022, 8:55 AM

#

What is meant by a new line?

coral relic Mar 25, 2022, 9:28 AM

#

It is the '\n' character, you can't see it, but it signals the device to print the other characters on a new line

#

For example
"Hello\n World!"

#

That will print the following
Hello
World!

surreal veldt Mar 25, 2022, 10:01 AM

#

Who's jchristgit?

rapid swallow Mar 25, 2022, 10:03 AM

#

surreal veldt Who's jchristgit?

@Volcyy#2359

surreal veldt Mar 25, 2022, 10:04 AM

#

@last patio about the comments for the PR can I ask you something about it here? I find it easier

last patio Mar 25, 2022, 10:48 AM

#

hit me

surreal veldt Mar 25, 2022, 11:00 AM

#

last patio hit me

What did you mean by It may be nice to maybe run the full codeblock through a formatter to adapt it to a single style.?

#

And this bottom comment should be a docstring?

sharp crag Mar 25, 2022, 1:48 PM

#

surreal veldt What did you mean by `It may be nice to maybe run the full codeblock through a f...

I’m guessing run it through black?

surreal veldt Mar 25, 2022, 1:50 PM

#

sharp crag I’m guessing run it through black?

What's that?

sharp crag Mar 25, 2022, 1:50 PM

#

Python formatter, In goes ugly code, out comes consistent and good code

surreal veldt Mar 25, 2022, 1:51 PM

#

~~How can I get that set up?~~

sharp crag Mar 25, 2022, 1:55 PM

#

I haven’t used it before let me check

gritty wind Mar 25, 2022, 1:56 PM

#

pip install black

#

There’s also an online version of it

#

https://black.vercel.app/

Black Playground

Playground for Black, the uncompromising Python code formatter.

sharp crag Mar 25, 2022, 1:57 PM

#

Ah yeah just use whichever you find convenient, either way make a commit after you’ve prettied up the code

surreal veldt Mar 25, 2022, 2:02 PM

#

it raises a lot of cannot parse errors

#

oh nevermnind oops

#

Cannot parse: 121:4: elif request_confirm is True:

cold island Mar 25, 2022, 2:39 PM

#

wild prism could we fuzzy-match tags only up until a newline?

A different solution I've been thinking about is to take one additional word at a time, and see if there's still a fuzzy match with the message taken so far. Once you encounter no fuzzy matches, you use the last fuzzy match found

wild prism Mar 25, 2022, 3:25 PM

#

yeah that could work

surreal veldt Mar 25, 2022, 6:12 PM

#

for site#703 how would I link another file on the site as a hyperlink? or would it have to be done by staff here

dusky shoreBOT Mar 25, 2022, 6:12 PM

#

GitHub

PROpen Subclassing context.md

gritty wind Mar 25, 2022, 6:15 PM

#

You just specify the path to the file. For instance, for a file in the same directory, the url would be:
./file_name

For a file in a directory higher:
../file_name

#

Etc

#

I found an example

#

https://github.com/python-discord/site/blob/main/pydis_site/apps/content/resources/guides/pydis-guides/contributing/bot.md#L50

stable mountainBOT Mar 25, 2022, 6:17 PM

#

pydis_site/apps/content/resources/guides/pydis-guides/contributing/bot.md line 50

See [here](../creating-bot-account) for help with setting up a bot account. Once you have a bot account, invite it to the test server you created in the previous section.```

gritty wind Mar 25, 2022, 6:18 PM

#

Which references this file:
https://github.com/python-discord/site/blob/main/pydis_site/apps/content/resources/guides/pydis-guides/contributing/creating-bot-account.md

surreal veldt Mar 25, 2022, 6:20 PM

#

thank you

#

also, the black code formatter is super helpful

hoary haven Mar 25, 2022, 8:29 PM

#

right now are all users able to edit/cancel other people's reminders?

#

i just accidentally edited the duration of someone else's reminder

molten perch Mar 25, 2022, 8:31 PM

#

Nope, that's just an admin thing:
https://github.com/python-discord/bot/blob/main/bot/exts/utils/reminders.py#L476:L477

stable mountainBOT Mar 25, 2022, 8:31 PM

#

bot/exts/utils/reminders.py lines 476 to 477

if await has_any_role_check(ctx, Roles.admins):
    return True```

hoary haven Mar 25, 2022, 8:32 PM

#

Skull ic ic

wild prism Mar 25, 2022, 8:32 PM

#

can we exclude mina from that

hoary haven Mar 25, 2022, 8:32 PM

#

lmao

#

hard code it

molten perch Mar 25, 2022, 8:34 PM

#

Sure, sure 😂

hoary haven Mar 25, 2022, 8:35 PM

#

wild prism can we exclude mina from that

try !remind edit duration 4286 1d

wild prism Mar 25, 2022, 8:36 PM

#

!remind edit duration 4286 1d

stable mountainBOT Mar 25, 2022, 8:36 PM

#

Nah.

You can't modify reminders of other users!

austere hornet Mar 25, 2022, 10:43 PM

#

Hmm I wonder why anyone would need to edit someone else's reminder. That would be.....rude ig lol. Just like with the !user command, you can only run it on yourself, so I suggest the same for the reminder command.

cold island Mar 25, 2022, 10:45 PM

#

Mods can run user on others though 🙂

#

I think it's just an extension of admins being able to delete other's reminders, I don't mind disallowing editing though

hoary haven Mar 26, 2022, 12:45 AM

#

even for deleting.. idk that i would expect to have that ability thru the bot. a confirmation would be nice if i'm about to modify or remove anyone else's reminder. it's all too easy to mistype a reminder ID

#

but yeah in the meantime i will be more diligent if i ever edit my reminders

cold island Mar 26, 2022, 1:10 AM

#

I'd rather not have to directly mess with the database to delete a reminder

hoary haven Mar 26, 2022, 1:15 AM

#

sure, it makes sense to have a feature to delete your own
it also makes sense for it to be made known if you're deleting someone else's bc you have elevated perms

hoary haven Mar 26, 2022, 2:22 PM

#

re: https://github.com/python-discord/site/pull/691#discussion_r833742960

perhaps we can add a new directory of images under pydis_site/static/images/content ?

GitHub

Added Discord messages with colors guide by kkrypt0nn · Pull Reques...

This adds the Discord embed limits pinned message as a guide, as asked by @Shom770.

surreal veldt Mar 26, 2022, 4:23 PM

#

I updated site#703 , if anyone can check that

dusky shoreBOT Mar 26, 2022, 4:23 PM

#

GitHub

PROpen Subclassing context.md

surreal veldt Mar 26, 2022, 4:24 PM

#

also, site#702

dusky shoreBOT Mar 26, 2022, 4:24 PM

#

GitHub

PROpen Subclassing bot

signal forge Mar 26, 2022, 11:14 PM

#

Anyone else have trouble installing rethinkdb on mac?

#

 ericfletcher@Erics-MBP  ~  brew install rethinkdb                                                                                                                                                                                                                                                   1 ↵  1460  19:11:14
Error: rethinkdb: no bottle available!

#

I could install from source, but am wondering if anyone else dealt with the above error.

signal forge Mar 26, 2022, 11:30 PM

#

Or maybe I should use the docker approach to installation

#

Actually, looks like rethink doesn't work with ARM Macs https://github.com/rethinkdb/rethinkdb/issues/6932

GitHub

Add Mac ARM build · Issue #6932 · rethinkdb/rethinkdb

It would be nice if ARM users could run RethinkDB natively. Or even, if we could verify that the x86 build runs properly under emulation.

signal forge Mar 27, 2022, 12:34 AM

#

It appears that I've gotten things working with Docker... would love to screen share with someone more familiar with running site locally.

brisk brook Mar 27, 2022, 1:03 AM

#

What's up? You need to modify the .env variables slightly, but afterwards, you should just need to run docker up inside the site folder and it'll start!

signal forge Mar 27, 2022, 1:31 AM

#

brisk brook What's up? You need to modify the `.env` variables slightly, but afterwards, you...

Oh my....

#

I got it the website running locally that is!

#

So much damn abstraction happening with Docker....

brisk brook Mar 27, 2022, 1:31 AM

#

Yup 😅

signal forge Mar 27, 2022, 1:31 AM

#

Feel like it would be helpful to know what it's doing.

#

Excited to get going on the scraping API feature.

austere hornet Mar 27, 2022, 2:47 AM

#

Seems like a bug, you could open an issue on https://git.pydis.com/bot

GitHub

GitHub - python-discord/bot: The community bot for the Python Disco...

The community bot for the Python Discord community - GitHub - python-discord/bot: The community bot for the Python Discord community

hoary haven Mar 27, 2022, 3:31 AM

#

we might just have to correct something with the !docs command
i'm not too familiar with how to do that though

cold island Mar 27, 2022, 3:54 AM

#

They just have conflicting namespaces

#

Not sure there's a better solution than dropping one of them

fallen patrol Mar 27, 2022, 5:42 AM

#

cold island Not sure there's a better solution than dropping one of them

internal priority

#

add some sort of priority for packages

#

well, take the existing priority and add it to the site and add a command to set it

cold island Mar 27, 2022, 5:43 AM

#

What would be the purpose of that? in the end it's for it to be fetched via the docs command

fallen patrol Mar 27, 2022, 5:43 AM

#

catSip I see you're not familiar with the source

cold island Mar 27, 2022, 5:43 AM

#

?

fallen patrol Mar 27, 2022, 5:44 AM

#

there's already programmed priority which renames symbols when they conflict, as is shown in the screenshot above

#

it makes the stdlib and a few other things have top priority to not be renamed--it will rename the other object

#

(that's how the current docs inventory code solves the name conflicts, by renaming existing objects, unless they're in the priority)

#

so just take the existing system, and modify it a bit to store the priority on the site, and a command to set the priority

cold island Mar 27, 2022, 5:46 AM

#

That's what I figured could be a solution, although I'm not sure how much I like it given that you're not actually going to use that namespace in code. But if it already exists then shrug

#

!d discord

stable mountainBOT Mar 27, 2022, 5:50 AM

#

discord

In order to work with the library and the Discord API in general, we must first create a Discord Bot account.

Creating a Bot account is a pretty straightforward process.

cold island Mar 27, 2022, 5:50 AM

#

That works too 🙂

fallen patrol Mar 27, 2022, 5:51 AM

#

what did you do?

#

add them in a different order?

cold island Mar 27, 2022, 5:51 AM

#

I just re-added dpy yeah

#

I guess it retains the order

fallen patrol Mar 27, 2022, 5:52 AM

#

I wonder if it does

#

could you check if this is persistent by reloading the cog?

#

ext is doc iirc

cold island Mar 27, 2022, 5:52 AM

#

!ext reload doc

stable mountainBOT Mar 27, 2022, 5:52 AM

#

:ok_hand: Extension successfully reloaded: bot.exts.info.doc.

cold island Mar 27, 2022, 5:52 AM

#

!d discord

stable mountainBOT Mar 27, 2022, 5:52 AM

#

discord

In order to work with the library and the Discord API in general, we must first create a Discord Bot account.

Creating a Bot account is a pretty straightforward process.

cold island Mar 27, 2022, 5:53 AM

#

oh

#

bummer

fallen patrol Mar 27, 2022, 5:53 AM

#

lmao so no consistency whatsoever

#

I should add some sort of priority to my own....

cold island Mar 27, 2022, 5:53 AM

#

!src d

stable mountainBOT Mar 27, 2022, 5:53 AM

#

Command: docs

Look up documentation for Python symbols.

Source Code

Go to GitHub

fallen patrol Mar 27, 2022, 5:54 AM

#

fallen patrol I should add some sort of priority to my own....

I've taken the docs command and heavily modified it for my own use, and then extended it to some other things as well

#

you're all welcome to take some of its changes back upstream if you want to

vale ibex Mar 27, 2022, 11:28 AM

#

We already have a system! 😄 All our tags are kept here https://github.com/python-discord/bot/tree/main/bot/resources/tags

GitHub

bot/bot/resources/tags at main · python-discord/bot

The community bot for the Python Discord community - bot/bot/resources/tags at main · python-discord/bot

#

So to add a new tag it's as simple as opening a pull request and getting it merged

#

This gives us the chance to check the content of tags before they're added to the bot.

#

No problem! As for tags, the usual process is to open an issue first, with your suggestion, just to gather interest in the tag, before you spend time writing it

surreal veldt Mar 27, 2022, 11:59 AM

#

When we post github links with the line specified, how is the embed automatically removed when the bot responds with the code in the line(s)

rapid swallow Mar 27, 2022, 12:05 PM

#

surreal veldt When we post github links with the line specified, how is the embed automaticall...

https://github.com/python-discord/bot/blob/93fafa22e3a01583fe4e5c232f1cef03d7b289ff/bot/exts/info/code_snippets.py#L257

stable mountainBOT Mar 27, 2022, 12:05 PM

#

bot/exts/info/code_snippets.py line 257

await message.edit(suppress=True)```

surreal veldt Mar 27, 2022, 12:06 PM

#

rapid swallow https://github.com/python-discord/bot/blob/93fafa22e3a01583fe4e5c232f1cef03d7b28...

Wait what... bots can do that?

fallen patrol Mar 27, 2022, 12:06 PM

#

to note that requires manage_message permissions in the channel

#

that is the only thing bots can edit about other user's messages

surreal veldt Mar 27, 2022, 12:11 PM

#

Interesting

woven gate Mar 27, 2022, 5:58 PM

#

I just wanted to say there should be a command for python discord bot, the command being called "give" (or any other name) the command passes over the channel to another user

austere hornet Mar 27, 2022, 6:00 PM

#

woven gate I just wanted to say there should be a command for python discord bot, the comma...

Are you talking about the help channels?

woven gate Mar 27, 2022, 6:01 PM

#

austere hornet Are you talking about the help channels?

yes sir

austere hornet Mar 27, 2022, 6:01 PM

#

Ok, I'm not sure why that would be necessary then

woven gate Mar 27, 2022, 6:02 PM

#

austere hornet Ok, I'm not sure why that would be necessary then

if there is a fairly simple issue and instead of closing the channel it could be passed over to someone who has a more difficult issue to fix.

austere hornet Mar 27, 2022, 6:05 PM

#

Hmm, not sure I'm following what you're saying, but let's see what the admins think about this

placid ermine Mar 27, 2022, 6:06 PM

#

woven gate if there is a fairly simple issue and instead of closing the channel it could be...

anyone can claim their own help channel from the available help channels category

#

there's always 3 available

signal forge Mar 27, 2022, 6:34 PM

#

Wanted to live stream my digging into site, but am unable to find out how to get the video role. Does anyone have guidance on this?

vocal prairie Mar 27, 2022, 6:50 PM

#

signal forge Wanted to live stream my digging into `site`, but am unable to find out how to g...

If there is a moderator in VC, you can ask them.

signal forge Mar 27, 2022, 6:50 PM

#

vocal prairie If there is a moderator in VC, you can ask them.

Nice to know. Thanks! Unfortunately, there isn't one now, but maybe one later!

#

@warm vigil told me I have to fight to the death to be able to stream.... so am willing to do whatever it takes!

surreal veldt Mar 28, 2022, 6:27 AM

#

For site#697 Migrate VPS services pin by Python bot to site, how about we incorporate this message in it too #discord-bots message
CC @sharp crag because you're the author of the PR

dusky shoreBOT Mar 28, 2022, 6:27 AM

#

GitHub

PROpen Migrate VPS services pin by Python bot to site

sharp crag Mar 28, 2022, 12:49 PM

#

surreal veldt For site#697 `Migrate VPS services pin by Python bot to site`, how about we inco...

Sounds good!

molten perch Mar 28, 2022, 2:39 PM

#

We're gonna wait until the permission rework. Then we'll assess our situation.

wind ruin Mar 28, 2022, 2:40 PM

#

discord is changing the way slash commands permissions work (as in, who can use or see slash commands and how admins can manage that)

molten perch Mar 28, 2022, 2:40 PM

#

Yeah, and right now, everyone can see all of the commands, if I remember correctly.

gritty wind Mar 28, 2022, 2:41 PM

#

It is not

#

We'll first see what they do with the new system

#

Then go from there

wind ruin Mar 28, 2022, 2:41 PM

#

and even then, once some are implemented, it will most likely not be for all commands for quite a while (if ever)

vale ibex Mar 28, 2022, 2:43 PM

#

For something specific?

wind ruin Mar 28, 2022, 2:44 PM

#

iirc we're keeping an eye out on the Forums as a possible replacement for the help channels, and considering using threads for #discord-bots and possibly other topical channels, but either way no immediate action planned

vale ibex Mar 28, 2022, 2:44 PM

#

We're currently looking at forum channels for the help channels. We have them on this server already, but the API doesn't support them yet, so we're waiting for that.

#

The publicly documented API that is

thorny obsidian Mar 28, 2022, 2:45 PM

#

Threads for topical channels when 🥺

wild prism Mar 28, 2022, 2:46 PM

#

someone missed a staff meeeeting

wind ruin Mar 28, 2022, 2:46 PM

#

#951803543407448075 PB_kek

vale ibex Mar 28, 2022, 2:46 PM

#

There's a couple of moderation related things that need to be done before we allow members to create their own threads

#

which just hasn't had anyone pick it up yet, due to other more pressing things coming up

thorny obsidian Mar 28, 2022, 2:47 PM

#

wild prism someone missed a staff meeeeting

I was literally working

#

😔 on a Sunday for 14 days in a row

cold island Mar 28, 2022, 3:33 PM

#

thorny obsidian 😔 on a Sunday for 14 days in a row

Hopefully at least your bank account is happy 😃

thorny obsidian Mar 28, 2022, 4:00 PM

#

cold island Hopefully at least your bank account is happy 😃

🤑

green oriole Mar 28, 2022, 4:59 PM

#

vale ibex which just hasn't had anyone pick it up yet, due to other more pressing things c...

Happy to help?

#

Did a bunch of thread related stuff, might as well finish :P

brisk brook Mar 28, 2022, 7:00 PM

#

Site does migration on startup right?

tawdry vapor Mar 28, 2022, 7:00 PM

#

Yes

brisk brook Mar 28, 2022, 7:03 PM

#

Okay, thank you.

muted osprey Mar 28, 2022, 7:45 PM

#

Hi, any interesting python open source projects you're familiar with to contribute to? ones that are active and for building useful tools

austere hornet Mar 28, 2022, 8:01 PM

#

muted osprey Hi, any interesting python open source projects you're familiar with to contribu...

We have 3 open source projects right on this server! @dusky shore is the easiest project to contribute to (for beginners in Discord bot programming). There's also @stable mountain which is a bit harder, and lastly there is the PyDis site. You can find the Github repos for all 3 projects at https://git.pydis.com

dim pelican Mar 28, 2022, 8:01 PM

#

(!contribute tag also lemon_wink )

austere hornet Mar 28, 2022, 8:01 PM

#

Oh yeah forgot about that

wind ruin Mar 28, 2022, 8:02 PM

#

!contribute

stable mountainBOT Mar 28, 2022, 8:02 PM

#

Contribute to Python Discord's Open Source Projects
Looking to contribute to Open Source Projects for the first time? Want to add a feature or fix a bug on the bots on this server? We have on-going projects that people can contribute to, even if you've never contributed to open source before!

Projects to Contribute to
• Sir Lancebot - our fun, beginner-friendly bot
• Python - our utility & moderation bot
• Site - resources, guides, and more

Where to start

Read our contribution guide
Chat with us in #dev-contrib if you're ready to jump in or have any questions
Open an issue or ask to be assigned to an issue to work on

austere hornet Mar 29, 2022, 2:19 AM

#

Not that I think this matters, but I noticed that the buttons for the Announcements and PyWeek Announcements roles on the !subscribe command have a period at the end I personally think the periods there are unnecessary, but it's such a tiny detail so I don't expect anything to be done about it, but thought I'd point it out anyway just to gather some other opinions purely out of curiosity.

sharp crag Mar 29, 2022, 2:38 AM

#

austere hornet Not that I think this matters, but I noticed that the buttons for the Announceme...

If people agree it's not a big deal, it's a really small PR and we could get it merged in no time

cold island Mar 29, 2022, 5:03 AM

#

Hahaha

#

@vale ibex looks like you reverted one too many changes

vocal wolf Mar 29, 2022, 7:36 AM

#

@vale ibex @brisk brook @exotic ember @patent pivot I require reviews. https://github.com/python-discord/black-knight/pull/36

brisk brook Mar 29, 2022, 7:40 AM

#

joe_salute

vocal wolf Mar 29, 2022, 7:40 AM

#

joe_salute

brisk brook Mar 29, 2022, 7:42 AM

#

This is the way

vocal wolf Mar 29, 2022, 7:44 AM

#

This is the way

fallen patrol Mar 29, 2022, 8:30 AM

#

vocal wolf <@!126811506632294400> <@!344404945359077377> <@!475186523575287808> <@!16502394...

what's it do?

last escarp Mar 29, 2022, 8:32 AM

#

vocal wolf <@!126811506632294400> <@!344404945359077377> <@!475186523575287808> <@!16502394...

Okay

molten perch Mar 29, 2022, 8:56 AM

#

@fading gale
That's it. :)
Read the bot description. :)

vale ibex Mar 29, 2022, 9:19 AM

#

cold island <@126811506632294400> looks like you reverted one too many changes

I think that was part of a larger commit, so didn't even realise when I was reverting

#

lol, yea https://github.com/python-discord/bot/commit/4fcca02e5dee769c1ad4b679238717cc1a471940

GitHub

Revert "No longer use Interaction.message, as it was removed from d...

…nake"

This reverts commit a1c73b5eca88d1b92cd42d3c41183387209461b9.

austere hornet Mar 29, 2022, 11:33 AM

#

sharp crag If people agree it's not a big deal, it's a really small PR and we could get it ...

Great!

brazen charm Mar 29, 2022, 1:19 PM

#

It returns a link to the first symbol loaded with that name

#

Because the libraries all share it there's really not much to do apart from giving discord a priority, but I'm also not sure if the page that links is what people want when they try to look it up

stable mountainBOT Mar 29, 2022, 1:23 PM

#

discord.User


class discord.User```
Represents a Discord user.

x == y Checks if two users are equal.

x != y Checks if two users are not equal.

hash(x) Return the user’s hash.

str(x) Returns the user’s name with discriminator.

#

discord

In order to work with the library and the Discord API in general, we must first create a Discord Bot account.

Creating a Bot account is a pretty straightforward process.

fervent sage Mar 29, 2022, 1:24 PM

#

Hm I wonder how to get sphinx to just not document the 'discord' name for nextcord and disnake

#

cause the discord alias reaslly doesnt need to be included in the docs for the libs

#

since its only there for compat

#

ok I have concluded i dont have a clue how sphinx works lol

gritty wind Mar 29, 2022, 1:38 PM

#

Surprisingly not much info to be found if you look it up

#

But we already do manipulation on the loader side, so this is just more manipulation

#

That said, a bespoke system for a single bad symbol is overkill

fervent sage Mar 29, 2022, 1:38 PM

#

Yeah that's why I'd rather change it docs-wide

gritty wind Mar 29, 2022, 1:39 PM

#

Are you suggesting changing it upstream?

fervent sage Mar 29, 2022, 1:39 PM

#

Yeah

gritty wind Mar 29, 2022, 1:39 PM

#

Ah gotcha

fervent sage Mar 29, 2022, 1:39 PM

#

I'm in a slightly unique position of being able to achieve that too kek