#dev-contrib | Python | Page 160

fallen patrol Dec 19, 2021, 7:42 AM

#

👀 we can, we can

#

and arrow will actually determine that

gritty wind Dec 19, 2021, 7:42 AM

#

we can what, I gave two options hyperlemon

static canyon Dec 19, 2021, 7:44 AM

#

Ab, right. I listed most of the ones I was interested in on the issue. There's probably the odd extra one I missed though

#

I do think we shouldn't support dd-mm-yyyy or mm-dd-yyyy though

#

Just because they're potentially ambiguous

fallen patrol Dec 19, 2021, 7:44 AM

#

gritty wind we can what, I gave two options <:hyperlemon:435707922563989524>

!e yespy import arrow print(arrow.get('hello arrow, take my extra (2013-09-29T01:26:43.830580) information and parse the timestamp kthx'))

stable mountainBOT Dec 19, 2021, 7:44 AM

#

@fallen patrol :x: Your eval job has completed with return code 1.

001 | Traceback (most recent call last):
002 |   File "<string>", line 1, in <module>
003 | ModuleNotFoundError: No module named 'arrow'

fallen patrol Dec 19, 2021, 7:45 AM

#

i-

gritty wind Dec 19, 2021, 7:45 AM

#

👌

#

lol

#

unlucky

fallen patrol Dec 19, 2021, 7:45 AM

#

when was it removed?

gritty wind Dec 19, 2021, 7:45 AM

#

I forgot to install any modules, let me fix that

fallen patrol Dec 19, 2021, 7:46 AM

#

https://github.com/python-discord/snekbox/blob/dc9a9e0aa9c0d56b8cbfd2e3f84f011ce0e3201d/deployment.yaml#L36

stable mountainBOT Dec 19, 2021, 7:46 AM

#

deployment.yaml line 36

arrow~=1.2.1```

static canyon Dec 19, 2021, 7:46 AM

#

fallen patrol when was it removed?

It wasn't. We just swapped to hosting on Scale's server which meant stuff got uninstalled

fallen patrol Dec 19, 2021, 7:46 AM

#

gritty wind I forgot to install any modules, let me fix that

ohhh, its not, I get it

#

lol

gritty wind Dec 19, 2021, 7:46 AM

#

That actually happened a week or so ago

#

There was another switch yesterday that dropped it though

fallen patrol Dec 19, 2021, 7:46 AM

#

I remember now

#

here's the full list https://github.com/python-discord/snekbox/blob/dc9a9e0aa9c0d56b8cbfd2e3f84f011ce0e3201d/deployment.yaml#L35-L53

gritty wind Dec 19, 2021, 7:46 AM

#

Yeah, I've got it

#

I don't have a volume mounted though, which makes this annoying

fallen patrol Dec 19, 2021, 7:47 AM

#

smh

#

wait

#

so if snekbox is not on pydis's cluster, how are requests authenticated?

gritty wind Dec 19, 2021, 7:47 AM

#

They've never been authenticated

#

We have https running obviously, but that's not the point

fallen patrol Dec 19, 2021, 7:48 AM

#

gritty wind They've never been authenticated

yes, but they've been internal before, and now they're going over the network

gritty wind Dec 19, 2021, 7:48 AM

#

Yes?

fallen patrol Dec 19, 2021, 7:49 AM

#

which means anyone can run code with that api if they have the url right? 👀

gritty wind Dec 19, 2021, 7:49 AM

#

Yes

#

It's not really a concern atm though

#

This isn't a permanent solution

#

If it proves to be a problem, we'd just throw some basic auth in front of it

#

traefik for all it's problems does make that trivial

fallen patrol Dec 19, 2021, 7:50 AM

#

May I use it too? 🤡

gritty wind Dec 19, 2021, 7:50 AM

#

I'm not going to be hosting it much longer, so nah

fallen patrol Dec 19, 2021, 7:50 AM

#

well, that's a good thing, so

#

anyways

gritty wind Dec 19, 2021, 7:52 AM

#

btw

#

!e import arrow

stable mountainBOT Dec 19, 2021, 7:52 AM

#

@gritty wind :warning: Your eval job has completed with return code 0.

[No output]

static canyon Dec 19, 2021, 7:53 AM

#

!e ```py
import arrow
print(arrow.get('hello arrow, take my extra (2013-09-29) information and parse the timestamp kthx', ['YYYY-MM-DD))

stable mountainBOT Dec 19, 2021, 7:53 AM

#

@static canyon :x: Your eval job has completed with return code 1.

001 | Traceback (most recent call last):
002 |   File "<string>", line 2, in <module>
003 |   File "/snekbox/user_base/lib/python3.10/site-packages/arrow/api.py", line 91, in get
004 |     return _factory.get(*args, **kwargs)
005 |   File "/snekbox/user_base/lib/python3.10/site-packages/arrow/factory.py", line 254, in get
006 |     dt = parser.DateTimeParser(locale).parse_iso(arg, normalize_whitespace)
007 |   File "/snekbox/user_base/lib/python3.10/site-packages/arrow/parser.py", line 208, in parse_iso
008 |     raise ParserError(
009 | arrow.parser.ParserError: Expected an ISO 8601-like string, but was given 'hello arrow, take my extra (2013-09-29T01:26:43.830580) information and parse the timestamp kthx'. Try passing in a format string to resolve this.

static canyon Dec 19, 2021, 7:53 AM

#

Smh

fallen patrol Dec 19, 2021, 7:54 AM

#

👀

#

I uh

#

am I tired and shouldn't be coding? yes

static canyon Dec 19, 2021, 7:54 AM

#

!e ```py
import arrow
print(arrow.get('hello arrow, take my extra (2013-09-29) information and parse the timestamp kthx', ['YYYY-MM-DD']))

gritty wind Dec 19, 2021, 7:55 AM

#

#bot-commands hyperlemon

static canyon Dec 19, 2021, 7:55 AM

#

There were go

#

You just need to specify the format you're looking for

fallen patrol Dec 19, 2021, 7:55 AM

#

hmm i wonder where the default list is

static canyon Dec 19, 2021, 7:56 AM

#

It probably doesn't have one as such

#

Smh

fallen patrol Dec 19, 2021, 7:56 AM

#

!d arrow.api.get

stable mountainBOT Dec 19, 2021, 7:56 AM

#

arrow.api.get

arrow.api.get(*, ...) → arrow.arrow.Arrow``````py
arrow.api.get(*args: int, ...) → arrow.arrow.Arrow``````py
arrow.api.get( ...) → arrow.arrow.Arrow```
Returns an [`Arrow`](https://arrow.readthedocs.io/en/latest/index.html#arrow.arrow.Arrow "arrow.arrow.Arrow") object based on flexible inputs.

fallen patrol Dec 19, 2021, 7:56 AM

#

(yeah their sphinx docs are weird)

static canyon Dec 19, 2021, 7:57 AM

#

Found this btw https://arrow.readthedocs.io/en/latest/#supported-tokens

static canyon Dec 19, 2021, 7:57 AM

#

fallen patrol (yeah their sphinx docs are weird)

Thanks lol

fallen patrol Dec 19, 2021, 7:59 AM

#

fallen patrol hmm i wonder where the default list is

got it

#

https://github.com/arrow-py/arrow/blob/a2ebb7e20b4897ee7b7bf4676a5ac3e6c0f27f47/arrow/parser.py#L218-L236

GitHub

arrow/parser.py at a2ebb7e20b4897ee7b7bf4676a5ac3e6c0f27f47 · arrow...

Better dates & times for Python. Contribute to arrow-py/arrow development by creating an account on GitHub.

#

arrow.get is arrow.factory.ArrowFactory().get, of when a string as the first param and no second param are supplied, uses a DateTimeParser().parse_iso() which has this list in its body.

static canyon Dec 19, 2021, 8:01 AM

#

Right

#

Makes sense

#

I suppose really we don't want all of those combinations

fallen patrol Dec 19, 2021, 8:01 AM

#

yeah, we only want a few

static canyon Dec 19, 2021, 8:01 AM

#

But at the same time is actually harmful to keep them as extras?

fallen patrol Dec 19, 2021, 8:02 AM

#

so I'm thinking to defer to the existing iso8601 converter on bot and if that fails, then match on our own definitions with arrow.get

static canyon Dec 19, 2021, 8:03 AM

#

!e py import arrow print(arrow.get('16:00', ['HH:mm']))

stable mountainBOT Dec 19, 2021, 8:03 AM

#

@static canyon :white_check_mark: Your eval job has completed with return code 0.

0001-01-01T16:00:00+00:00

static canyon Dec 19, 2021, 8:03 AM

#

Hmm

#

That's annoying

#

It doesn't do today's date

#

So we'll need to do that ourselves ig

fallen patrol Dec 19, 2021, 8:04 AM

#

uhhh we can continue to use dateutil for that -- the Duration converter

static canyon Dec 19, 2021, 8:04 AM

#

I think we can use our own DayDuration or something, no?

#

What ModPings uses

fallen patrol Dec 19, 2021, 8:05 AM

#

btw not sure if this method is useful but:

#

https://arrow.readthedocs.io/en/latest/#dehumanize

#

!d arrow.arrow.Arrow.dehumanize

stable mountainBOT Dec 19, 2021, 8:05 AM

#

arrow.arrow.Arrow.dehumanize


dehumanize(input_string, locale='en_us')```
Returns a new [`Arrow`](https://arrow.readthedocs.io/en/latest/index.html#arrow.arrow.Arrow "arrow.arrow.Arrow") object, that represents the time difference relative to the attrbiutes of the [`Arrow`](https://arrow.readthedocs.io/en/latest/index.html#arrow.arrow.Arrow "arrow.arrow.Arrow") object.

static canyon Dec 19, 2021, 8:05 AM

#

Yeah, I saw that

fallen patrol Dec 19, 2021, 8:05 AM

#

static canyon I think we can use our own DayDuration or something, no?

*reopens editor*

static canyon Dec 19, 2021, 8:05 AM

#

Not sure how useful it is to be honest

fallen patrol Dec 19, 2021, 8:06 AM

#

The following formats are excepted:
    - H:M
    - H:M am/pm
    - H am/pm
    - H

well that solves those on their own, kiiinda

fallen patrol Dec 19, 2021, 8:06 AM

#

static canyon Not sure how useful it is to be honest

I don't think its useful for this usecase

#

since I'd like to be able to support a timezone as well 🙃

static canyon Dec 19, 2021, 8:07 AM

#

fallen patrol > The following formats are excepted: > - H:M > - H:M am/pm ...

Who put excepted there smfh

#

It should be accepted

static canyon Dec 19, 2021, 8:07 AM

#

fallen patrol > The following formats are excepted: > - H:M > - H:M am/pm ...

We could use that and then extend to determine whether the next occurrence is today or tomorrow

fallen patrol Dec 19, 2021, 8:08 AM

#

static canyon Who put excepted there smfh

bot#2001 review comment for jason lol

dusky shoreBOT Dec 19, 2021, 8:08 AM

#

GitHub

PROpen Modpings Improvements

static canyon Dec 19, 2021, 8:08 AM

#

Nice

#

Will do

short snow Dec 19, 2021, 8:08 AM

#

👀

#

its accepted

#

#

volC already said that in his reviewa

fallen patrol Dec 19, 2021, 8:09 AM

#

i must have cherrypicked a commit with an older version 😓 cc @static canyon

short snow Dec 19, 2021, 8:10 AM

#

tizzy still review it

static canyon Dec 19, 2021, 8:10 AM

#

short snow tizzy still review it

lmao

static canyon Dec 19, 2021, 8:11 AM

#

fallen patrol i must have cherrypicked a commit with an older version 😓 cc <@!44224413584038...

To be honest when we merge we're going to remove your commit? i.e. if Jason's merges first (which I think is likely) then your commit adding the converter etc. won't be needed

fallen patrol Dec 19, 2021, 8:12 AM

#

yeah, it was to be able to use it now, I'll rebase after its merged

#

(I would be surprised if this reminder feature gets merged before modpings improvements)

#

I made a list of formats earlier that I'd like to be able to support, although if we can't do all of them I'd like that too
(currently supported conversions)...

09:27
"9:27 am"
"9:27 pm"
9:27pm
-? tomorrow (maybe)
24H
~~19/12/21~~
~~19/12/2021~~
2021/12/19

#

not sure if all of these are useful tho

#

and actually, these are all easy on their own

#

The problem arises when supporting +02 or timezones

static canyon Dec 19, 2021, 8:18 AM

#

The day/month/year I don't want to support

static canyon Dec 19, 2021, 8:18 AM

#

static canyon I do think we shouldn't support dd-mm-yyyy or mm-dd-yyyy though

^

fallen patrol Dec 19, 2021, 8:19 AM

#

edited to cross those out

fallen patrol Dec 19, 2021, 8:22 AM

#

fallen patrol The problem arises when supporting +02 or timezones

but yeah, all of these are easy enough on their own, but once we start to mix them (eg date + time) we either need to make a lot of custom strings (can be done programmably) or figure out a better way to parse them or something. Then there's do we also add timezone, or something about that

#

i'm gonna go sleep

static canyon Dec 19, 2021, 8:24 AM

#

fallen patrol i'm gonna go sleep

'Night

#

@gritty wind are you free to answer a query I have RE bot#2001?

dusky shoreBOT Dec 19, 2021, 8:24 AM

#

GitHub

PROpen Modpings Improvements

fallen patrol Dec 19, 2021, 8:24 AM

#

static canyon 'Night

.bm read from here

gritty wind Dec 19, 2021, 8:24 AM

#

Sure, go ahead and ask

fallen patrol Dec 19, 2021, 8:25 AM

#

~~I already know I'll be back tonight~~

static canyon Dec 19, 2021, 8:25 AM

#

gritty wind Sure, go ahead and ask

Do we think this should be a log.warning instead of log.info since it means there's a moderator in the modpings list that shouldn't be there https://github.com/python-discord/bot/pull/2001/files#diff-d82a54c450ea031f87210217bd9b41f10344938751efefdf015f27d9404a9a06R92

short snow Dec 19, 2021, 8:26 AM

#

fallen patrol I made a list of formats earlier that I'd like to be able to support, although i...

imo just add a regex for handling date in front of the day duration in the three ways you mentioned above

static canyon Dec 19, 2021, 8:26 AM

#

I suppose we should technically check the moderator has the Moderation Team role too (i.e. Akarys)

gritty wind Dec 19, 2021, 8:26 AM

#

Honestly, either will be fine given how unlikely that situation is in the first place

#

the mod team isn't losing members every other week

static canyon Dec 19, 2021, 8:26 AM

#

I agree, but I do think it's something we should catch

#

We do get people stepping down every so often, and we should account for that imo

fallen patrol Dec 19, 2021, 8:28 AM

#

static canyon I suppose we should technically check the moderator has the Moderation Team role...

bot#2008

dusky shoreBOT Dec 19, 2021, 8:28 AM

#

GitHub

PROpen fix: check for the modteam role before reassigning the user's moderation role

short snow Dec 19, 2021, 8:28 AM

#

doesn't arl's pr handle ti

#

yeah that one

fallen patrol Dec 19, 2021, 8:29 AM

#

fallen patrol ~~I already know I'll be back tonight~~

why'd you have to say i'd return smh

#

bad arl

fallen patrol Dec 19, 2021, 8:31 AM

#

gritty wind Honestly, either will be fine given how unlikely that situation is in the first ...

imo its more of a security issue, as mods can be on modping leave for up to 28 days iirc.
So if a mod is demoted while on leave, they would have perms again until someone noticed they weren't supposed to and was able to act on it
This is fine in a graceful demotion, but you don't want something who was demoted for not being responsible to have permissions back all of a sudden

#

so while its a (very) unlikely situation, its not one to want to be in

gritty wind Dec 19, 2021, 8:31 AM

#

I think you missed the part where the question was should this be an info log, or a warning

#

not whether we should do it or not

short snow Dec 19, 2021, 8:32 AM

#

imo, it isn't really a warning, its just they aren't on the server anymore

#

so a info should be fine

fallen patrol Dec 19, 2021, 8:32 AM

#

gritty wind I think you missed the part where the question was should this be an info log, o...

yeah gonna go to bed now & mute the channel for the next eight hours so i stop trying to respond to the wrong thing like i've said 4 times so far and haven't acted on

gritty wind Dec 19, 2021, 8:33 AM

#

If you want, you could always break a couple rules and get muted /s

short snow Dec 19, 2021, 8:33 AM

#

!mure @fallen patrol 8H lol

fallen patrol Dec 19, 2021, 8:33 AM

#

gritty wind If you want, you could always break a couple rules and get muted /s

you could just mute me

gritty wind Dec 19, 2021, 8:33 AM

#

We don't hand out mutes for no reason on policy

short snow Dec 19, 2021, 8:34 AM

#

really?

#

where did tizzy's review request devlog message go pithink

#

the red one

static canyon Dec 19, 2021, 8:42 AM

#

How do I do a multi-line suggestion on a review?

#

Ah, got it

#

You just drag

static canyon Dec 19, 2021, 8:57 AM

#

short snow tizzy still review it

Reviewed 👍

#

Ah crap I approved

short snow Dec 19, 2021, 9:01 AM

#

static canyon Reviewed 👍

you can just request changes without comments btw instead of do not merge

static canyon Dec 19, 2021, 9:02 AM

#

It said I had to leave a comment in order to request changes

#

Ah, there we go

green oriole Dec 19, 2021, 9:09 AM

#

static canyon It said I had to leave a comment in order to request changes

Do you?

static canyon Dec 19, 2021, 9:15 AM

#

I had to give a reason why I was requesting changes, I didn't have to leave a comment on a changed line

#

if that makes sense

#

i.e. just had to write here

short snow Dec 19, 2021, 9:21 AM

#

short snow you can just request changes without comments btw instead of do not merge

yeah, without comments meant those commetns you give on code separately

static canyon Dec 19, 2021, 9:22 AM

#

yeah

green oriole Dec 19, 2021, 10:07 AM

#

Right, yeah

severe tangle Dec 19, 2021, 12:56 PM

#

!ot command broke

stable mountainBOT Dec 19, 2021, 12:56 PM

#

Did you mean ...

» ot
» off-topic-names

severe tangle Dec 19, 2021, 12:57 PM

#

!ot

stable mountainBOT Dec 19, 2021, 12:57 PM

#

Off-topic channel: #ot2-never-nester’s-nightmare

Please read our off-topic etiquette before participating in conversations.

severe tangle Dec 19, 2021, 12:57 PM

#

See, both of those worked before, but they don't work now, soo, uhhh

cursive relic Dec 19, 2021, 12:59 PM

#

I just saw the same thing, also it would be nice if the ot channel was randomized if it makes sense

static canyon Dec 19, 2021, 1:28 PM

#

severe tangle See, both of those worked before, but they don't work now, soo, uhhh

The latter still works perfectly fine

#

The !ot some text here doesn't work since it fuzzymatches but ends up not being able to distinguish between ot and off-topic-names, but there is a PR to fix that

severe tangle Dec 19, 2021, 1:30 PM

#

static canyon The latter still works perfectly fine

But it doesn't show all the channels

static canyon Dec 19, 2021, 1:30 PM

#

cursive relic I just saw the same thing, also it would be nice if the ot channel was randomize...

It's a static file so that's not possible

static canyon Dec 19, 2021, 1:30 PM

#

severe tangle But it doesn't show all the channels

It's not supposed to

#

There was a conscious decision to change it

severe tangle Dec 19, 2021, 1:30 PM

#

Huh?

static canyon Dec 19, 2021, 1:30 PM

#

!off-topic-names shows them instead

stable mountainBOT Dec 19, 2021, 1:30 PM

#

Off-topic channels

There are three off-topic channels:
• #ot0-psvm’s-eternal-disapproval
• #ot1-perplexing-regexing
• #ot2-never-nester’s-nightmare

The channel names change every night at midnight UTC and are often fun meta references to jokes or conversations that happened on the server.

See our off-topic etiquette page for more guidance on how the channels should be used.

severe tangle Dec 19, 2021, 1:30 PM

#

Ah

static canyon Dec 19, 2021, 1:30 PM

#

!ot

stable mountainBOT Dec 19, 2021, 1:30 PM

#

Off-topic channel: #ot2-never-nester’s-nightmare

Please read our off-topic etiquette before participating in conversations.

severe tangle Dec 19, 2021, 1:30 PM

#

Any reason for the change?

static canyon Dec 19, 2021, 1:31 PM

#

It's used to redirect people when they're off-topic and so you only need to list one channel. Listing more just clutters the channel (people will usually just click the first channel anyway)

severe tangle Dec 19, 2021, 1:31 PM

#

Ah understandable

clever wraith Dec 19, 2021, 1:58 PM

#

static canyon It's used to redirect people when they're off-topic and so you only need to list...

!ot why this does not?

stable mountainBOT Dec 19, 2021, 1:58 PM

#

Did you mean ...

» ot
» off-topic-names

clever wraith Dec 19, 2021, 1:59 PM

#

we kinda usually used to message like.

!ot you shall question here

brazen charm Dec 19, 2021, 1:59 PM

#

bot#2023

dusky shoreBOT Dec 19, 2021, 1:59 PM

#

GitHub

PROpen Try an exact match with only the name when a tag with a group is searched

clever wraith Dec 19, 2021, 1:59 PM

#

which puts both message and command in one go.

brazen charm Dec 19, 2021, 1:59 PM

#

That pr should fix it

#

Currently it's not an exact match because it looks it up as a tag with an ot group and then falls back to fuzzying

clever wraith Dec 19, 2021, 2:00 PM

#

oh i see. alright that would help a lot. thanks for the pr!!

static canyon Dec 19, 2021, 2:07 PM

#

clever wraith !ot why this does not?

I already explained that above if you read what I said

static canyon Dec 19, 2021, 2:07 PM

#

static canyon The `!ot some text here` doesn't work since it fuzzymatches but ends up not bein...

^

#

So basically what Numerlor said just now

clever wraith Dec 19, 2021, 2:08 PM

#

I see. I apologise. Din't read above part.

static canyon Dec 19, 2021, 2:08 PM

#

clever wraith I see. I apologise. Din't read above part.

No worries lol

hoary haven Dec 19, 2021, 5:42 PM

#

dusky shore

any chance we can speedrun reviews/approval for this?

magic arch Dec 19, 2021, 5:43 PM

#

I can add in another review, but all that's really left is a core dev 😂

patent pivot Dec 19, 2021, 5:54 PM

#

merged

fallen patrol Dec 19, 2021, 6:21 PM

#

static canyon It's not supposed to

.. iit might be worth #changelog

static canyon Dec 19, 2021, 6:29 PM

#

fallen patrol .. iit might be worth <#748238795236704388>

Eh, that's something for core-devs to decide

#

I don't have permissions to that channel anyway

patent pivot Dec 19, 2021, 6:30 PM

#

fallen patrol .. iit might be worth <#748238795236704388>

don't think we need that

austere hornet Dec 19, 2021, 6:51 PM

#

patent pivot don't think we need that

Yeah me neither

fallen patrol Dec 19, 2021, 9:51 PM

#

bot#2006 needs one core dev review
bot#2017 is ready for review

sir-lancebot#969 needs two reviews
sir-lancebot#981 is ready for review
sir-lancebot#982 is ready for review and needs two reviews

dusky shoreBOT Dec 19, 2021, 9:51 PM

#

GitHub

PROpen fix: subcommands inherit their parent's whitelist
PROpen enhancement(filters): use a stricter bot token regex
PROpen Interaction tic tac toe
PROpen nit: make last refreshed time above the rest of the embed
PROpen fix: don't include replied mentions in mention filter

austere hornet Dec 19, 2021, 9:52 PM

#

Ig while we're at it, sir-lancebot#901 needs one core-dev review

dusky shoreBOT Dec 19, 2021, 9:52 PM

#

GitHub

PROpen Madlibs

fallen patrol Dec 19, 2021, 10:57 PM

#

@summer garden are you the creator of the sudoku issue?

summer garden Dec 19, 2021, 10:58 PM

#

fallen patrol <@348828427333140482> are you the creator of the sudoku issue?

that would be @austere hornet

austere hornet Dec 19, 2021, 10:58 PM

#

summer garden that would be <@!853309207922212965>

Yep

fallen patrol Dec 19, 2021, 10:58 PM

#

summer garden that would be <@!853309207922212965>

ahh, is your github sn4u

summer garden Dec 19, 2021, 10:58 PM

#

that's right

fallen patrol Dec 19, 2021, 10:59 PM

#

okay, that's what I was trying to figure out lol

austere hornet Dec 19, 2021, 10:59 PM

#

But isn't it not obvious who is who? Like who created the issue and who commented?

fallen patrol Dec 19, 2021, 10:59 PM

#

FWIW, if going down to a 4x4 array, I'd suggest doing something with buttons, like the pending tic tac toe enhancements

fallen patrol Dec 19, 2021, 11:00 PM

#

austere hornet But isn't it not obvious who is who? Like who created the issue and who commente...

I thought I saw the author badge on bones

austere hornet Dec 19, 2021, 11:00 PM

#

fallen patrol FWIW, if going down to a 4x4 array, I'd suggest doing something with buttons, li...

Oh yeah that's a good idea

austere hornet Dec 19, 2021, 11:00 PM

#

fallen patrol I thought I saw the author badge on bones

Ahh

summer garden Dec 19, 2021, 11:00 PM

#

fallen patrol FWIW, if going down to a 4x4 array, I'd suggest doing something with buttons, li...

sounds like a lot of buttons

austere hornet Dec 19, 2021, 11:00 PM

#

Only 16

fallen patrol Dec 19, 2021, 11:00 PM

#

you can have up to 25 buttons, arranged in a 5x5 array on a message

summer garden Dec 19, 2021, 11:01 PM

#

the tic tac toe has 9, and that already looks like a lot to me. It would be good to see before judging though

austere hornet Dec 19, 2021, 11:01 PM

#

Well 9 is less than 16, I'm not sure why it seems like a lot

fallen patrol Dec 19, 2021, 11:05 PM

#

(9 already seems like a lot to them, so they want to see 16 before they judge)

fallen patrol Dec 19, 2021, 11:06 PM

#

summer garden the tic tac toe has 9, and that already looks like a lot to me. It would be good...

have you seen the tic tac toe yet? The pr is waiting for review, so I can show it to you

austere hornet Dec 19, 2021, 11:06 PM

#

fallen patrol (9 already seems like a lot to them, so they want to see 16 before they judge)

Ahh gotcha

brisk brook Dec 19, 2021, 11:08 PM

#

You can only have a 5x5 grid with buttons in Discord!

austere hornet Dec 19, 2021, 11:08 PM

#

brisk brook You can only have a 5x5 grid with buttons in Discord!

Oh, you can't have less than that?

brisk brook Dec 19, 2021, 11:09 PM

#

You can, but not more

austere hornet Dec 19, 2021, 11:09 PM

#

Ah

summer garden Dec 19, 2021, 11:12 PM

#

fallen patrol have you seen the tic tac toe yet? The pr is waiting for review, so I can show i...

i've not seen it no

fallen patrol Dec 19, 2021, 11:14 PM

#

summer garden i've not seen it no

sir-lancebot#982, I included some screen shots

dusky shoreBOT Dec 19, 2021, 11:14 PM

#

GitHub

PROpen Interaction tic tac toe

fallen patrol Dec 19, 2021, 11:17 PM

#

I need to update those screenshots, lol

patent pivot Dec 20, 2021, 12:06 AM

#

streaming me attempting a new method of snekbox deployment

fallen patrol Dec 20, 2021, 12:11 AM

#

just got on pc and updated screenshots

#

@summer garden

#

so presumably we could do something like this for Sudoku

trail pilot Dec 20, 2021, 12:13 AM

#

Oh yeah that would work

#

since a max of 5 buttons per row

magic arch Dec 20, 2021, 12:13 AM

#

patent pivot streaming me attempting a new method of snekbox deployment

Not sure what I'm seeing but the terminal is pretty so I'm staying

fallen patrol Dec 20, 2021, 12:13 AM

#

a nice feature, is buttons don't have to be enabled to exist, so we could send 25 disabled buttons and use them as the UI

fallen patrol Dec 20, 2021, 12:13 AM

#

patent pivot streaming me attempting a new method of snekbox deployment

😔 I can't join, smh discord

#

May I be dragged in?

patent pivot Dec 20, 2021, 12:14 AM

#

oop

#

fixing

#

fixed

magic arch Dec 20, 2021, 12:14 AM

#

live: joe fixing perms

patent pivot Dec 20, 2021, 12:14 AM

#

lol

fallen patrol Dec 20, 2021, 12:14 AM

#

lol that channel has always been private, hasn't it?

austere hornet Dec 20, 2021, 12:14 AM

#

magic arch live: joe fixing perms

Lol

magic arch Dec 20, 2021, 12:14 AM

#

fallen patrol lol that channel has always been private, hasn't it?

I think so?

patent pivot Dec 20, 2021, 12:14 AM

#

yea but sometimes I open it when I stream here

fallen patrol Dec 20, 2021, 12:14 AM

#

ah I can't speak in it, but can join now neat

patent pivot Dec 20, 2021, 12:14 AM

#

okay let's give this a go

fallen patrol Dec 20, 2021, 12:15 AM

#

trail pilot since a max of 5 buttons per row

yeah, and it could just be the way to see the board, not necessarily interact with it 😄

trail pilot Dec 20, 2021, 12:16 AM

#

also I heard discord is adding text input fields

fallen patrol Dec 20, 2021, 12:16 AM

#

this is tic tac toe after a win

#

yeah, they are

#

although not for buttons

#

those will be part of slash commands

trail pilot Dec 20, 2021, 12:16 AM

#

oh, unfortunate

fallen patrol Dec 20, 2021, 12:17 AM

#

(old screenshot)

magic arch Dec 20, 2021, 12:17 AM

#

watching joe slowly read error messages 👀

austere hornet Dec 20, 2021, 12:17 AM

#

Lol

fallen patrol Dec 20, 2021, 12:17 AM

#

but slash commands & autocomplete is awesome

trail pilot Dec 20, 2021, 12:18 AM

#

fallen patrol (old screenshot)

oh, I thought they were gonna add like actual fields that you can use

#

rather than self.bot.wait_for("on_message", ...)

fallen patrol Dec 20, 2021, 12:18 AM

#

that's a different thing, uhhh lemme find it

hoary haven Dec 20, 2021, 12:19 AM

#

are we still on scale's thing for snekbox?

fallen patrol Dec 20, 2021, 12:20 AM

#

can't find it but its a different thing

fallen patrol Dec 20, 2021, 12:21 AM

#

hoary haven are we still on scale's thing for snekbox?

so far yes

thorny obsidian Dec 20, 2021, 12:30 AM

#

Also goddamn talking while running is hard. My lung capacity was not prepared for that

fallen patrol Dec 20, 2021, 12:36 AM

#

hm why is there a 99 member limit on this channel?

magic arch Dec 20, 2021, 12:36 AM

#

Every channel here has a limit (even staff), I assume for raids maybe

fallen patrol Dec 20, 2021, 12:37 AM

#

magic arch Every channel here has a limit (even staff), I assume for raids maybe

#756327105389920306 doesn't lol

austere hornet Dec 20, 2021, 12:37 AM

#

fallen patrol <#756327105389920306> doesn't lol

That doesn't really count tbh

magic arch Dec 20, 2021, 12:37 AM

#

Every non-AFK channel then lol

fallen patrol Dec 20, 2021, 12:37 AM

#

(ofc that might be an oversight or smth)

#

ah

#

I wonder if its used as a counter on the staff channel, since there's more than 100 staff now

austere hornet Dec 20, 2021, 12:38 AM

#

fallen patrol I wonder if its used as a counter on the staff channel, since there's more than ...

Yeah that's another reason for the limit I believe

fallen patrol Dec 20, 2021, 12:39 AM

#

although given staff can have perms that don't count, that's probably what's going on, so its really just a counter

austere hornet Dec 20, 2021, 12:39 AM

#

At least I've asked that question before and someone (can't remember who) said that in response

#

So yeah

fallen patrol Dec 20, 2021, 12:41 AM

#

fallen patrol I made a list of formats earlier that I'd like to be able to support, although i...

@static canyon so with these formats, how would we support an optional combinations.. either time then date, or date then time, or time, date, timezone, etc?

#

That's a lot of different date and/or time formats that could be used

#

but in the end it makes it a pretty powerful converter lol

#

I can't wait until discord adds that talked about datetime slash command input

#

^ in regard to that, probably easiest to go with a really simple input since hopefully can convert it to a slash command at some point

thorny obsidian Dec 20, 2021, 12:43 AM

#

It has a cap of 99 so it has the badge of how many people are in it. That's all

vocal wolf Dec 20, 2021, 12:48 AM

#

what's going on over here

#

in there

#

@patent pivot you better be talking about k8s

fallen patrol Dec 20, 2021, 12:49 AM

#

vocal wolf <@!165023948638126080> you better be talking about k8s

no comment

#

👀

austere hornet Dec 20, 2021, 12:50 AM

#

Lmao

fallen patrol Dec 20, 2021, 12:50 AM

#

also @patent pivot you should optimize your screensharing for text

ashen isle Dec 20, 2021, 12:50 AM

#

koo burr nuh tees

vocal wolf Dec 20, 2021, 12:51 AM

#

kyoo brr net ez

austere hornet Dec 20, 2021, 12:52 AM

#

kyu berr niiites

fallen patrol Dec 20, 2021, 12:52 AM

#

ty

patent pivot Dec 20, 2021, 12:52 AM

#

vocal wolf <@!165023948638126080> you better be talking about k8s

close enough

austere hornet Dec 20, 2021, 12:52 AM

#

fallen patrol ty

To whom? Me?

vocal wolf Dec 20, 2021, 12:52 AM

#

patent pivot close enough

good

fallen patrol Dec 20, 2021, 1:03 AM

#

@short snow #dev-log message

#

bot#2008 is ready for re-review @static canyon @cold island, as you both requested changes

dusky shoreBOT Dec 20, 2021, 1:07 AM

#

GitHub

PROpen fix: check for the modteam role before reassigning the user's moderation role

austere hornet Dec 20, 2021, 1:10 AM

#

Could a core-dev take a look at and maybe approve sir-lancebot#985?

dusky shoreBOT Dec 20, 2021, 1:10 AM

#

GitHub

IssueOpen Sudoku command

fallen patrol Dec 20, 2021, 1:14 AM

#

austere hornet Could a core-dev take a look at and maybe approve sir-lancebot#985?

joe just approved it, I left a comment

austere hornet Dec 20, 2021, 1:14 AM

#

fallen patrol joe just approved it, I left a comment

Oh nice, saw your comment

fallen patrol Dec 20, 2021, 1:52 AM

#

re-reviewed #901 @austere hornet, I missed this earlier but not worth not approving. The timeout message is a bit not related, also the user can try again right then, they don't have to wait

Additonally, I'm not sure about the random titles, as its somewhat unprompted. I would make this mention the user, as well

austere hornet Dec 20, 2021, 2:02 AM

#

fallen patrol re-reviewed #901 <@!853309207922212965>, I missed this earlier but not worth not...

.bm

#

Whoops sorry for ping

fallen patrol Dec 20, 2021, 2:03 AM

#

pings don't bother me that much ¯_(ツ)_/¯

austere hornet Dec 20, 2021, 2:03 AM

#

Yeah me neither but I meant to disable it (hence why I have "pings ok" in my nickname for the server)

fallen patrol Dec 20, 2021, 2:06 AM

#

fixing bot#2022, thinking to export the get tag out of the error handler as well, to be able to fuzzy match the tags when using !src as well pithink

dusky shoreBOT Dec 20, 2021, 2:06 AM

#

GitHub

IssueOpen Incorrect handling of tags by the !source command

fallen patrol Dec 20, 2021, 2:07 AM

#

since it has that fuzzy matcher which is used for commands, since this takes a command argument as well, I feel like it should use the fuzz too

austere hornet Dec 20, 2021, 2:07 AM

#

fallen patrol re-reviewed #901 <@!853309207922212965>, I missed this earlier but not worth not...

Btw before I say anything about this, I think you should put this in a review on the PR

fallen patrol Dec 20, 2021, 2:10 AM

#

cool

austere hornet Dec 20, 2021, 2:10 AM

#

Will respond there

fallen patrol Dec 20, 2021, 2:31 AM

#

@brazen charm honestly the solution is to not be importing objects from other extensions

#

or do something with get_cog...

fallen patrol Dec 20, 2021, 5:10 AM

#

I left a new comment on bot#2022

dusky shoreBOT Dec 20, 2021, 5:10 AM

#

GitHub

IssueOpen Incorrect handling of tags by the !source command

fallen patrol Dec 20, 2021, 5:10 AM

#

I think the best solution is to move the Tag Identifier class out of the cog

static canyon Dec 20, 2021, 9:19 AM

#

fallen patrol <@!442244135840382978> so with these formats, how would we support an optional c...

I don't really understand what you're asking

static canyon Dec 20, 2021, 9:22 AM

#

fallen patrol bot#2008 is ready for re-review <@!442244135840382978> <@!512354988157173763>, a...

!remind 1h

stable mountainBOT Dec 20, 2021, 9:22 AM

#

I'll allow it.

Your reminder will arrive on <t:1639995725:F>!

frigid latch Dec 20, 2021, 10:01 AM

#

anything that i can contribute to

#

any open issues?

gritty wind Dec 20, 2021, 10:03 AM

#

We have open issues on all our big projects @stable mountain/@dusky shore/website

#

If you aren't looking for anything in particular, sir-lancebot is the most welcoming for beginners

#

There is more info about all three projects here

#

!contribute

stable mountainBOT Dec 20, 2021, 10:04 AM

#

Contribute to Python Discord's Open Source Projects
Looking to contribute to Open Source Projects for the first time? Want to add a feature or fix a bug on the bots on this server? We have on-going projects that people can contribute to, even if you've never contributed to open source before!

Projects to Contribute to
• Sir Lancebot - our fun, beginner-friendly bot
• Python - our utility & moderation bot
• Site - resources, guides, and more

Where to start

Read our contributing guidelines
Chat with us in #dev-contrib if you're ready to jump in or have any questions
Open an issue or ask to be assigned to an issue to work on

stable mountainBOT Dec 20, 2021, 10:22 AM

#

static canyon !remind 1h

It has arrived!

Here's your reminder: bot#2008 is ready for re-review @static canyon @cold island, as you both requested changes
[Jump back to when you created the reminder](#dev-contrib message)

static canyon Dec 20, 2021, 11:40 AM

#

stable mountain

re-reviewed with one more nitpick

austere hornet Dec 20, 2021, 12:48 PM

#

@patent pivot It looks like you approved sir-lancebot#985 but haven't assigned me, could you please assign me?

dusky shoreBOT Dec 20, 2021, 12:48 PM

#

GitHub

IssueOpen Sudoku command

austere hornet Dec 20, 2021, 12:49 PM

#

Also @fallen patrol what do you think about this? https://github.com/python-discord/sir-lancebot/issues/985#issuecomment-997542842

GitHub

Sudoku command · Issue #985 · python-discord/sir-lancebot

Description I would like to make a Sudoku game command for Lancebot. Here are the rules for playing Sudoku, in case you don't know: https://sudoku.com/how-to-play/sudoku-rules-for-complete-...

patent pivot Dec 20, 2021, 12:53 PM

#

austere hornet <@165023948638126080> It looks like you approved sir-lancebot#985 but haven't as...

done

austere hornet Dec 20, 2021, 12:53 PM

#

patent pivot done

Thanks!

austere hornet Dec 20, 2021, 1:25 PM

#

austere hornet Also <@717983911824588862> what do you think about this? https://github.com/pyth...

And this https://github.com/python-discord/sir-lancebot/pull/901#issuecomment-997543363

GitHub

Madlibs by DMFriends · Pull Request #901 · python-discord/sir-lance...

Relevant Issues
Closes #847
Description

This PR is designed to add a fun Madlibs game to Sir Lancebot.
When the command, .madlibs, is run, the bot will ask the user to enter a word that fits a ran...

fallen patrol Dec 20, 2021, 8:34 PM

#

static canyon I don't really understand what you're asking

we can take a time, date, and timezone, but how should we separate that in the converter? what I'm asking is, could we brainstorm a list of all valid input styles?

static canyon Dec 20, 2021, 8:35 PM

#

fallen patrol we can take a time, date, and timezone, but how should we separate that in the c...

Just separate the same way as ISO does

#

YYYY-MM-DD HH:mm:SS+00:00 where +00:00 is the UTC offset

#

I think there should be a T there somewhere

fallen patrol Dec 20, 2021, 8:37 PM

#

and which subsets of that should we support? date, time, timezone, date and time, date and time and timezone

summer garden Dec 20, 2021, 8:38 PM

#

are you not planning on using a parser? Say dateutil's for example

static canyon Dec 20, 2021, 8:39 PM

#

fallen patrol and which subsets of that should we support? date, time, timezone, date and time...

YYYY-mm-DD HH
YYYY-mm-DD HH:MM
YYYY-mm-DD HH:MM±00:00
HH:MM
HH:MM+00:00

Notes:
- Dates can also have `/` instead of `-`
- Spaces before the time can be replaced with a `T` (as per ISO)
- Times can be 24hr or 12hr
- Timezone assumes UTC when not provided
- When minutes not provided, assume value of 0
- Seconds not permitted
```I guess something like this. We don't want to allow just date since we wouldn't know what time on that date to send the reminder (unless we just use the current time I guess)

fallen patrol Dec 20, 2021, 8:39 PM

#

summer garden are you not planning on using a parser? Say dateutil's for example

it expects the entire format string

#

so this is basically all of the different format strings I have to generate, and then a different parser for the strings missing a date

static canyon Dec 20, 2021, 8:40 PM

#

And I suppose all the stuff with a space should allow for a T instead of a space because that's what ISO says

fallen patrol Dec 20, 2021, 8:43 PM

#

static canyon ``` YYYY-mm-DD HH YYYY-mm-DD HH:MM YYYY-mm-DD HH:MM±00:00 HH:MM HH:MM+00:00 Not...

👀 if we keep this format then we can use the iso8601 converter with some preprocessing

static canyon Dec 20, 2021, 8:43 PM

#

The main thing is that just HH:MM isn't supported by ISO

#

And we don't want to support seconds/milliseconds

fallen patrol Dec 20, 2021, 8:45 PM

#

hm I thought date was part of the original issue, which would send at midnight utc or what timezone they specified

static canyon Dec 20, 2021, 8:46 PM

#

I don't think so

#

I don't like that idea

#

I think if anything it should be at the current time on that date

#

But I think just date is too ambiguous really

#

So I'd say if date is provided then time needs to be too

#

That's my opinion anyway

#

If you disagree feel free to say so

fallen patrol Dec 20, 2021, 8:49 PM

#

i liked being able to put just the date in from my testing

#

although i can see the complexity that would add and such, so probably best to not have it

static canyon Dec 20, 2021, 8:51 PM

#

fallen patrol i liked being able to put just the date in from my testing

If it's something you found useful, then we can try to keep it

#

This entire PR is just me going "I wanted this feature all the times I've used the command"

fallen patrol Dec 20, 2021, 8:52 PM

#

same tho

static canyon Dec 20, 2021, 8:53 PM

#

I'm happy to keep that if you'd like it

#

The thing is whether we'd want it to remind at midnight or whether we'd want to remind the same time the command was invoked

fallen patrol Dec 20, 2021, 8:54 PM

#

either way is fine on the implementation side

#

i personally liked midnight

static canyon Dec 20, 2021, 8:55 PM

#

I think UX wise I'd expect it to be the same time as me invoking the command though

#

Maybe someone else can give their thoughts? CC @summer garden if you're still here

cold island Dec 20, 2021, 8:56 PM

#

static canyon The thing is whether we'd want it to remind at midnight or whether we'd want to ...

I think it might be unintuitive regardless

static canyon Dec 20, 2021, 8:56 PM

#

cold island I think it might be unintuitive regardless

Yeah, it's kinda ambiguous which is why I was initially against the idea -- but then arl said they've found it useful so 🤷

cold island Dec 20, 2021, 8:57 PM

#

One approach might make sense to the developer as they're writing the feature, but from a user perspective I'm not sure it makes sense to not provide an hour

static canyon Dec 20, 2021, 8:57 PM

#

cold island One approach might make sense to the developer as they're writing the feature, b...

I mean providing an hour will still work

#

It's just that you don't have to

cold island Dec 20, 2021, 8:57 PM

#

Yes, I'm saying I'm not sure it makes sense to not have to

fallen patrol Dec 20, 2021, 8:58 PM

#

yeah that makes sense

static canyon Dec 20, 2021, 8:58 PM

#

Yeah, okay

#

Let's not do that then

fallen patrol Dec 20, 2021, 8:59 PM

#

static canyon ``` YYYY-mm-DD HH YYYY-mm-DD HH:MM YYYY-mm-DD HH:MM±00:00 HH:MM HH:MM+00:00 Not...

.bm bot#1924

dusky shoreBOT Dec 20, 2021, 8:59 PM

#

GitHub

IssueOpen Allow passing end time to !remind

static canyon Dec 20, 2021, 8:59 PM

#

There you go :p

fallen patrol Dec 20, 2021, 9:01 PM

#

(@austere hornet I left comments on those two)

fallen patrol Dec 20, 2021, 9:01 PM

#

static canyon There you go :p

thanks

fallen patrol Dec 20, 2021, 9:02 PM

#

static canyon ``` YYYY-mm-DD HH YYYY-mm-DD HH:MM YYYY-mm-DD HH:MM±00:00 HH:MM HH:MM+00:00 Not...

!remind 2H work on 1924

stable mountainBOT Dec 20, 2021, 9:02 PM

#

Yeah okay.

Your reminder will arrive on <t:1640041355:F>!

austere hornet Dec 20, 2021, 9:10 PM

#

fallen patrol (<@!853309207922212965> I left comments on those two)

Oh ok, will take a look

austere hornet Dec 20, 2021, 9:28 PM

#

@fallen patrol Just to make sure I understood - did you want me to add an author mention inside or outside the embed?

fallen patrol Dec 20, 2021, 9:31 PM

#

outside the embed, mentions within embeds don't actually ping ppl

austere hornet Dec 20, 2021, 9:31 PM

#

Yeah ik, but I wasn't sure if you actually wanted to ping the user or not

fallen patrol Dec 20, 2021, 9:50 PM

#

austere hornet Yeah ik, but I wasn't sure if you actually wanted to ping the user or not

yeah

austere hornet Dec 20, 2021, 9:51 PM

#

@fallen patrol How does this look?

fallen patrol Dec 20, 2021, 9:52 PM

#

sure

stable mountainBOT Dec 20, 2021, 11:02 PM

#

fallen patrol !remind 2H work on 1924

It has arrived!

Here's your reminder: work on 1924
[Jump back to when you created the reminder](#dev-contrib message)

vale ibex Dec 20, 2021, 11:09 PM

#

Huh, this is a new one. Anyone seen this before? ```
☸ pydis (default) in metricity 🍣 message-sync-command 📦 📝 ×1🛤️ ×1via 🐳 default 🐍 v3.10.0
🕙 23:08:14 ❯ docker-compose up --build
[+] Building 0.7s (4/4) FINISHED
=> [internal] load build definition from Dockerfile 0.0s
=> => transferring dockerfile: 436B 0.0s
=> [internal] load .dockerignore 0.0s
=> => transferring context: 2B 0.0s
=> ERROR [internal] load metadata for docker.io/library/python:3.9-slim 0.7s
=> [auth] library/python:pull token for registry-1.docker.io 0.0s

[internal] load metadata for docker.io/library/python:3.9-slim:

failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: failed to authorize: rpc error: code = Unknown desc = failed to fetch oauth token: unexpected status: 503 Service Unavailable

#

I am assuming desc = failed to fetch oauth token: unexpected status: 503 Service Unavailable is the important part

#

huh, interesting ```
☸ pydis (default) in metricity 🍣 message-sync-command 📦 📝 ×1🛤️ ×1via 🐳 default 🐍 v3.10.0 took 26s
🕙 23:10:21 ❯ docker login
Authenticating with existing credentials...
Login did not succeed, error: Error response from daemon: Get "https://registry-1.docker.io/v2/": received unexpected HTTP status: 503 Service Unavailable
Login with your Docker ID to push and pull images from Docker Hub. If you don't have a Docker ID, head over to https://hub.docker.com to create one.
Username (chrisjl95):
Password:
Error response from daemon: Get "https://registry-1.docker.io/v2/": received unexpected HTTP status: 503 Service Unavailable

#

getting 503 from docker login

#

Guess I'm not pulling any images this evening haha

fallen patrol Dec 20, 2021, 11:18 PM

#

vale ibex Guess I'm not pulling any images this evening haha

https://status.docker.com/

Docker system status real-time view

Current system status. View active incidents or upcoming maintenances. Subscribe to receive status notifications.

#

vale ibex Dec 20, 2021, 11:18 PM

#

heh that'll be it

fallen patrol Dec 20, 2021, 11:19 PM

#

yeah lol

austere hornet Dec 20, 2021, 11:34 PM

#

Sounds fun

gritty wind Dec 21, 2021, 12:02 AM

#

I’m sorry but are we just ignoring that beautiful terminal

#

So many emojis

#

Dockers back btw

vale ibex Dec 21, 2021, 12:03 AM

#

colour too 😄

clever wraith Dec 21, 2021, 12:15 AM

#

what is your largest project?

austere hornet Dec 21, 2021, 12:15 AM

#

clever wraith what is your largest project?

Probably the site

gritty wind Dec 21, 2021, 12:16 AM

#

By what metric lol

clever wraith Dec 21, 2021, 12:16 AM

#

https://discordpy.readthedocs.io/en/stable/

gritty wind Dec 21, 2021, 12:16 AM

#

Bot is biggest by contributions and code base size

clever wraith Dec 21, 2021, 12:16 AM

#

this one?

austere hornet Dec 21, 2021, 12:16 AM

#

clever wraith https://discordpy.readthedocs.io/en/stable/

No, that is not our project

gritty wind Dec 21, 2021, 12:16 AM

#

Nah we aren’t related to the discordpy project

clever wraith Dec 21, 2021, 12:16 AM

#

sorry

gritty wind Dec 21, 2021, 12:17 AM

#

This is our site: https://pythondiscord.com

Python Discord | Home

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

It’s okay haha

clever wraith Dec 21, 2021, 12:17 AM

#

yeah, that's what I was looking for :)

austere hornet Dec 21, 2021, 12:18 AM

#

gritty wind Bot is biggest by contributions and code base size

I was thinking bot too but felt like the site was a bigger project idk

gritty wind Dec 21, 2021, 12:18 AM

#

I did actually collect a bunch of numbers for this year during the staff meeting

#

Fun fact: up until then, we’ve merged/closed 1000 PRs this year

austere hornet Dec 21, 2021, 12:18 AM

#

gritty wind Fun fact: up until then, we’ve merged/closed 1000 PRs this year

Oh wow

gritty wind Dec 21, 2021, 12:18 AM

#

999, then I closed one during the meeting

austere hornet Dec 21, 2021, 12:19 AM

#

gritty wind 999, then I closed one during the meeting

Oh lol

gritty wind Dec 21, 2021, 12:19 AM

#

I may put out a contrib announcement, sounds like fun

austere hornet Dec 21, 2021, 12:19 AM

#

gritty wind I may put out a contrib announcement, sounds like fun

Yeah might be worth it

vocal prairie Dec 21, 2021, 12:19 AM

#

We also hit 2000 issues/prs on bot, which is nice

clever wraith Dec 21, 2021, 12:19 AM

#

hey. a stupind question: https://pythondiscord.com/ this looks like it could be made without 280k people

Python Discord | Home

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

austere hornet Dec 21, 2021, 12:19 AM

#

vocal prairie We also hit 2000 issues/prs on bot, which is nice

Nice

gritty wind Dec 21, 2021, 12:19 AM

#

855 events on bot, 218 on site

gritty wind Dec 21, 2021, 12:20 AM

#

clever wraith hey. a stupind question: https://pythondiscord.com/ this looks like it could be ...

Contributors to the site are closer to 28 than 280000

#

Naturally, not all people in the community contribute to everything

#

If you’d like to contribute, all our projects are open source

#

!contribute

stable mountainBOT Dec 21, 2021, 12:20 AM

#

Contribute to Python Discord's Open Source Projects
Looking to contribute to Open Source Projects for the first time? Want to add a feature or fix a bug on the bots on this server? We have on-going projects that people can contribute to, even if you've never contributed to open source before!

Projects to Contribute to
• Sir Lancebot - our fun, beginner-friendly bot
• Python - our utility & moderation bot
• Site - resources, guides, and more

Where to start

Read our contributing guidelines
Chat with us in #dev-contrib if you're ready to jump in or have any questions
Open an issue or ask to be assigned to an issue to work on

clever wraith Dec 21, 2021, 12:21 AM

#

I'd like to propose a new project

gritty wind Dec 21, 2021, 12:21 AM

#

Go ahead, the floor is open

#

May have to redirect you to a different place depending

clever wraith Dec 21, 2021, 12:23 AM

#

let's build a search engine. without scrapers, with only human input and with federation (trolls get yeeeted)

gritty wind Dec 21, 2021, 12:23 AM

#

It’s an interesting idea, but we lack the resources to possibly ever moderate something like that reliably, or build it

clever wraith Dec 21, 2021, 12:23 AM

#

I tried :)

#

that's my dream

#

won't stop trying :D

gritty wind Dec 21, 2021, 12:24 AM

#

Well I can respect that, good luck to ya

austere hornet Dec 21, 2021, 12:25 AM

#

gritty wind Contributors to the site are closer to 28 than 280000

@clever wraith If you're interested, you can check this out: https://github.com/python-discord/site/graphs/contributors

GitHub

Contributors to python-discord/site

pythondiscord.com - A Django and Bulma web application. - Contributors to python-discord/site

clever wraith Dec 21, 2021, 12:25 AM

#

I'm not

austere hornet Dec 21, 2021, 12:25 AM

#

Ok

clever wraith Dec 21, 2021, 12:25 AM

#

it seems to have connection with your project

#

only :)

austere hornet Dec 21, 2021, 12:26 AM

#

Well yes I was just wondering if you were interested to see how many contributors there are to https://pythondiscord.com. That's all.

clever wraith Dec 21, 2021, 12:27 AM

#

that I am

#

but the number seems obfuscated :/

gritty wind Dec 21, 2021, 12:28 AM

#

59

clever wraith Dec 21, 2021, 12:28 AM

#

sorry, I don't see that

#

can give you a screenshot

gritty wind Dec 21, 2021, 12:29 AM

#

I don’t think it gives you a number, but it sorts everyone on that page. If you scroll to the bottom, the last contrib is number 59

#

The GitHub site is kinda weird on mobile, it’s scrolling up on its own

austere hornet Dec 21, 2021, 12:29 AM

#

gritty wind I don’t think it gives you a number, but it sorts everyone on that page. If you ...

Was just about to type that exact thing lol

clever wraith Dec 21, 2021, 12:29 AM

#

yeah

gritty wind Dec 21, 2021, 12:29 AM

#

It’s a bit difficult to take a screenshot

clever wraith Dec 21, 2021, 12:29 AM

#

true

clever wraith Dec 21, 2021, 12:29 AM

#

gritty wind I don’t think it gives you a number, but it sorts everyone on that page. If you ...

true

clever wraith Dec 21, 2021, 12:33 AM

#

gritty wind It’s an interesting idea, but we lack the resources to possibly ever moderate so...

Why moderate it?

#

approve it

#

federate it

#

ok, that's naive, I'm sure

gritty wind Dec 21, 2021, 12:34 AM

#

Unfortunately you significantly underestimate the number of trolls we deal with

#

And when a group of apes get together, there’s no telling what they’ll do

#

They might even start riding horses

clever wraith Dec 21, 2021, 12:34 AM

#

:D

austere hornet Dec 21, 2021, 12:34 AM

#

Lol

clever wraith Dec 21, 2021, 12:35 AM

#

no, I understand that

#

but I don't understand how points/weight don't solve that

#

https://ncase.me/trust/

The Evolution of Trust

an interactive guide to the game theory of why & how we trust each other

#

example

gritty wind Dec 21, 2021, 12:37 AM

#

Because from a legal aspect, we may or may not end up responsible for what’s on that service. It also wouldn’t be a very good service if enough trolls manage to overturn the odds. It’s also only part of the reason we aren’t working on a search engine

clever wraith Dec 21, 2021, 12:38 AM

#

Because from a legal aspect, we may or may not end up responsible for what’s on that service. 1.

#

ok, so you've thought about it

#

eh

#

the choice is either google and the likes similar swallow us

#

or we start building something of our own

#

so it won't be a search engine

#

but recommendations from my friends

fallen patrol Dec 21, 2021, 12:42 AM

#

gritty wind Unfortunately you significantly underestimate the number of trolls we deal with

and shitposters!

clever wraith Dec 21, 2021, 12:43 AM

#

:)

gritty wind Dec 21, 2021, 12:45 AM

#

It’s easy to say google and big companies suck, let’s build our own. That is a little naive though, because unlike google, we don’t have billions of dollars to fall on if we have problems. Legal problem, lack of work, moderation, the project outright failing, etc.

#

I’m not saying you shouldn’t try to change the world, I’m saying pick your battles

clever wraith Dec 21, 2021, 12:45 AM

#

I agree

#

I suggest that we try :)

#

that's all

gritty wind Dec 21, 2021, 12:46 AM

#

Alright, thanks for your suggestion, will keep it in mind

#

If you want, you can open an issue on our meta tracker linked in #community-meta

#

But I doubt we’ll take it on

clever wraith Dec 21, 2021, 12:46 AM

#

I doubt I'll open an issue

#

but thanks :)

fallen patrol Dec 21, 2021, 1:26 AM

#

@vale ibex docker is back up 🙂

austere hornet Dec 21, 2021, 2:28 AM

#

@fallen patrol On your last comment on the Sudoku issue you mentioned I could use different codeblock languages to get different colors for the codeblock, right? What languages specifically do you know will give you different colors for the codeblock?

fallen patrol Dec 21, 2021, 2:32 AM

#

austere hornet <@!717983911824588862> On your last comment on the Sudoku issue you mentioned I ...

this was the specific one I was thinking of, its prolog

  A B C D E F G H I
A 1 2 3 4 5 6 7 8 9
B 2
C 3
D 4
E 5 
F 6
G 7
H 8 
I 9

austere hornet Dec 21, 2021, 2:33 AM

#

fallen patrol this was the specific one I was thinking of, its `prolog` ```prolog A B C D E ...

Ah I see, that looks pretty nice, but would dashes have different colors too or no?

fallen patrol Dec 21, 2021, 2:34 AM

#

uhhh not sure

#

well technically they have a grey colour

austere hornet Dec 21, 2021, 2:35 AM

#

fallen patrol well technically they have a grey colour

But grey is not really a color that stands out that much tbh

#

So idk. But as I posted on the issue I'm going to think about this more tomorrow maybe if I have time and will post there when I make a final decision as to how I want it implemented and we'll go from there.

fallen patrol Dec 21, 2021, 2:40 AM

#

@short snow I'm trying to test bot#2021 but for some reason its not doing anything?

dusky shoreBOT Dec 21, 2021, 2:40 AM

#

GitHub

PROpen More Message Link Unfurls

short snow Dec 21, 2021, 2:41 AM

#

add print to on_message, see what msg links it gets

fallen patrol Dec 21, 2021, 2:43 AM

#

just a sec

short snow Dec 21, 2021, 2:44 AM

#

and check if this is valid for your setup, like the on_message doesn't return early when it shouldn't

hoary haven Dec 21, 2021, 2:46 AM

#

fallen patrol this was the specific one I was thinking of, its `prolog` ```prolog A B C D E ...

@austere hornet beware that syntax highlighting varies depending on the device or OS and is absolutely non-existent on iOS

#

austere hornet Dec 21, 2021, 2:48 AM

#

hoary haven <@!853309207922212965> beware that syntax highlighting varies depending on the d...

Oh, thanks for the heads up! I actually don't have an iOS and I'm on PC currently so it's fine

fallen patrol Dec 21, 2021, 2:48 AM

#

hoary haven <@!853309207922212965> beware that syntax highlighting varies depending on the d...

def foo():
  ...
  do_thing()

is this coloured on iOS?

hoary haven Dec 21, 2021, 2:49 AM

#

no it's plain

#

wasn't this an idea for sudoku though? we have plenty of iOS users

hoary haven Dec 21, 2021, 2:49 AM

#

fallen patrol ```py def foo(): ... do_thing() ``` is this coloured on iOS?

no not at all

austere hornet Dec 21, 2021, 2:49 AM

#

Well guess what, it's plain on Android too smhhh

fallen patrol Dec 21, 2021, 2:49 AM

#

fallen patrol ```py def foo(): ... do_thing() ``` is this coloured on iOS?

this has some colour on android

austere hornet Dec 21, 2021, 2:50 AM

#

fallen patrol this has *some* colour on android

Yep I see some color

fallen patrol Dec 21, 2021, 2:50 AM

#

ugh, PIL might end up being what has to be used ;-;

short snow Dec 21, 2021, 2:50 AM

#

IMO, there are many websites for solving sudoku online providing a much better ui than discord so not sure if should have sudoku game support

austere hornet Dec 21, 2021, 2:52 AM

#

short snow **IMO**, there are many websites for solving sudoku online providing a much bett...

Well maybe you're right and I think bones asked about that on the issue (sir-lancebot#985) and they suggested to have a 4x4 grid instead of the traditional 9x9 grid

thorny obsidian Dec 21, 2021, 2:52 AM

#

The lack of robust syntax highlighting for mobile is unfortunate

dusky shoreBOT Dec 21, 2021, 2:52 AM

#

GitHub

IssueOpen Sudoku command

hoary haven Dec 21, 2021, 2:52 AM

#

no landscape mode and no syntax highlighting for iOS, imagine what it's like to help on pydis on an iphone lol

thorny obsidian Dec 21, 2021, 2:53 AM

#

short snow **IMO**, there are many websites for solving sudoku online providing a much bett...

A lot of the games on sir lancebot have better UI elsewhere and that's fine. The goal of Sir Lancebot is to not to make an optimal game playing experience, but as a way for people to strengthen their python and contributing skills. If someone is interested in implementing something and it isn't too costly, then just because it exists elsewhere shouldn't be a blocker

austere hornet Dec 21, 2021, 2:53 AM

#

Yeah totally agree with Kat

short snow Dec 21, 2021, 2:53 AM

#

using PIL would be costly 🤷‍♂️

fallen patrol Dec 21, 2021, 2:53 AM

#

austere hornet Well maybe you're right and I think bones asked about that on the issue (sir-lan...

I feel like 4x4 would be too easy, and at minimum should have a 6x6 option (ooh imagine if its scalable and the user can input what size, to a point)

fallen patrol Dec 21, 2021, 2:54 AM

#

short snow using PIL would be costly 🤷‍♂️

the avatar commands exist, and we have...

#

!d asyncio.loop.run_in_executor

stable mountainBOT Dec 21, 2021, 2:54 AM

#

asyncio.loop.run\_in\_executor


awaitable loop.run_in_executor(executor, func, *args)```
Arrange for *func* to be called in the specified executor.

The *executor* argument should be an [`concurrent.futures.Executor`](https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.Executor "concurrent.futures.Executor") instance. The default executor is used if *executor* is `None`.

Example:

fallen patrol Dec 21, 2021, 2:54 AM

#

which is what the avatar commands use

austere hornet Dec 21, 2021, 2:54 AM

#

fallen patrol I feel like 4x4 would be too easy, and at minimum should have a 6x6 option (ooh ...

Heh, I said the same thing but I wasn't sure what others thought about that but now I know. 6x6 sounds good

thorny obsidian Dec 21, 2021, 2:54 AM

#

short snow using PIL would be costly 🤷‍♂️

We already use PIL for avatar commands and Chris spent a lot of good time fixing that up to run without being costly

fallen patrol Dec 21, 2021, 2:54 AM

#

thorny obsidian We already use PIL for avatar commands and Chris spent a lot of good time fixing...

what I just said ^.^

short snow Dec 21, 2021, 2:55 AM

#

yes but we can't do that sudoku, he added a good "ratelimiter", which can't be done for sudoku when you have to edit the images so muany times

#

for a single game

austere hornet Dec 21, 2021, 2:57 AM

#

short snow yes but we can't do that sudoku, he added a good "ratelimiter", which can't be d...

First of all, who is "he"? Me?

thorny obsidian Dec 21, 2021, 2:57 AM

#

Sure, that reasoning may be a blocker. We'll have to fully discuss with core devs. But I do want to be careful that we don't turn down ideas just because it exists elsewhere, because that's not the point of sir lancebot.

short snow Dec 21, 2021, 3:02 AM

#

austere hornet First of all, who is "he"? Me?

chris

short snow Dec 21, 2021, 3:02 AM

#

thorny obsidian Sure, that reasoning may be a blocker. We'll have to fully discuss with core dev...

Yeah 👍

austere hornet Dec 21, 2021, 3:05 AM

#

short snow chris

Oh

fallen patrol Dec 21, 2021, 5:06 AM

#

@patent pivot #dev-log message probably worth turning these off

#

suggestion (to bikeshed): help command support tags, perhaps with fuzzy match

cold island Dec 21, 2021, 7:30 AM

#

fallen patrol suggestion (to bikeshed): help command support tags, perhaps with fuzzy match

Not sure what that means

cursive relic Dec 21, 2021, 7:44 AM

#

if @stable mountain goes down/restarts will the reminders still work after it, I mean the reminds set before restart

short snow Dec 21, 2021, 7:47 AM

#

reminders are stored in a database, so it doesn't matter if python goes down/restarts, yes

cursive relic Dec 21, 2021, 7:52 AM

#

hm weird

fallen patrol Dec 21, 2021, 8:10 AM

#

#

darned python making me ghost ping, sorry

#

I feel like the help command should support tags if the query isn't found

gritty wind Dec 21, 2021, 8:13 AM

#

We already do fuzzy matching on tags

#

If the fuzzy matching there didn’t return anything, what will it return exactly in that embed

fallen patrol Dec 21, 2021, 8:38 AM

#

gritty wind If the fuzzy matching there didn’t return anything, what will it return exactly ...

wut?

#

ot is a tag name now, I'm proposing that running help on a query that matches a tag name should be shown in the help command

static canyon Dec 21, 2021, 8:40 AM

#

fallen patrol `ot` is a tag name now, I'm proposing that running help on a query that matches ...

What would it say in the help text though?

fallen patrol Dec 21, 2021, 8:41 AM

#

say its a tag and show the first line as a summary

static canyon Dec 21, 2021, 8:42 AM

#

First line probably wouldn't make much sense in a lot of tags

#

First sentence would probably work better

#

But then that assumes all tags have proper punctuation etc. which some don't

gritty wind Dec 21, 2021, 8:43 AM

#

What’s the end goal anyway

fallen patrol Dec 21, 2021, 9:45 AM

#

i've seen uses where it wasn't known that a tag was a tag, so it wasn't too easy to get info about it

fallen patrol Dec 21, 2021, 10:36 AM

#

bot#2022 is loosely related

dusky shoreBOT Dec 21, 2021, 10:36 AM

#

GitHub

IssueOpen Incorrect handling of tags by the !source command

obsidian patio Dec 21, 2021, 1:29 PM

#

I'm planning to create a .twemoji <codepoint|emoji> command that displays the given emoji and sends a link to the twemoji source file. This will probably come in handy in certain discussions in #dev-branding

#

I presume no core devs have anything against adding this command? I'm thinking of adding it to @dusky shore

patent pivot Dec 21, 2021, 1:34 PM

#

would like to see an issue opening for it, but I don't have anything against it

obsidian patio Dec 21, 2021, 1:56 PM

#

There we go sir-lancebot#987

dusky shoreBOT Dec 21, 2021, 1:56 PM

#

GitHub

IssueOpen Twemoji utility command

obsidian patio Dec 21, 2021, 2:29 PM

#

What interpreter should I select in VSC when running the bot through docker?

#

Without it, VSC doesn't recognize the imported packages

thorny obsidian Dec 21, 2021, 2:51 PM

#

If it's running through docker compose vsc's interpreter shouldn't matter

cold island Dec 21, 2021, 2:53 PM

#

You might be able to attach the container with VSC, but for simplicity I'd set up my own environment locally

vale ibex Dec 21, 2021, 2:53 PM

#

If you want vsc to have code completion, and you want local linting, you need to poetry install all deps locally too

cold island Dec 21, 2021, 2:54 PM

#

https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/bot/#setting-up-a-development-environment

Python Discord - Contributing to Bot

A guide to setting up and configuring Bot.

obsidian patio Dec 21, 2021, 2:55 PM

#

vale ibex If you want vsc to have code completion, and you want local linting, you need to...

I'll do that too then, thanks 👍

brazen charm Dec 21, 2021, 3:06 PM

#

Might as well run it locally

cold island Dec 21, 2021, 3:10 PM

#

Yeah it's more convenient to run it locally. You can keep the other services like the site in Docker

obsidian patio Dec 21, 2021, 3:21 PM

#

Yep, that's what I usually do. I just finally have enough storage to use docker, so I'm trying that out

fallen patrol Dec 21, 2021, 5:41 PM

#

I've been following the snekbox saga mostly, but why exactly is it broken on the cluster, but not on scale's server?

#

IK its something to do with cgroups, but I have no idea what those are or why they're a problem

gritty wind Dec 21, 2021, 5:43 PM

#

pydis cluster is running cv2, mine is running cv1

#

Since both are managed clusters, we have no control over what is what

#

Mark is working on getting things working again hopefully

fallen patrol Dec 21, 2021, 5:44 PM

#

gritty wind pydis cluster is running cv2, mine is running cv1

but what is cv2

gritty wind Dec 21, 2021, 5:44 PM

#

cgroups version 2

fallen patrol Dec 21, 2021, 5:44 PM

#

gritty wind Since both are managed clusters, we have no control over what is what

...does that mean that your cluster could be upgraded and stop working too?

gritty wind Dec 21, 2021, 5:45 PM

#

What's cgroups version 2; well, I don't think the person that wrote the spec could even answer that

gritty wind Dec 21, 2021, 5:45 PM

#

fallen patrol ...does that mean that your cluster could be upgraded and stop working too?

Yes, but I do tend to screen my upgrades lol

patent pivot Dec 21, 2021, 5:45 PM

#

lmfao

#

the main difference is

#

in cgroups v1 you would write to something like

fallen patrol Dec 21, 2021, 5:45 PM

#

gritty wind Yes, but I do tend to screen my upgrades lol

ah, unlike joe 🤡

gritty wind Dec 21, 2021, 5:45 PM

#

I wouldn't be surprised if this was forced upon him >.>

patent pivot Dec 21, 2021, 5:45 PM

#

/sys/fs/cgroups/memory/snekbox.aaa-bbb-ccc/memory.limit_in_bytes

#

and you write to that file and add processes to the cgroup

#

and they get a mem limit applied

#

and then if you want to limit PIDs you write to /sys/fs/cgroups/pids/snekbox.aaa-bbb-ccc/pids.max

#

that filename is wrong but I can't remember it

#

aaa-bbb-ccc is something we generate for each exec

#

anyway, cgroups v2 just changes the filesystem structure

fallen patrol Dec 21, 2021, 5:46 PM

#

gritty wind What's cgroups version 2; well, I don't think the person that wrote the spec cou...

well, what is cgroup overall? What's it used for?

patent pivot Dec 21, 2021, 5:47 PM

#

so you write to /sys/fs/cgroups/snekbox.aaa-bbb-ccc/memory.max

fallen patrol Dec 21, 2021, 5:47 PM

#

I thinkk its memory limits/management?

gritty wind Dec 21, 2021, 5:47 PM

#

Well, joe basically explained it

patent pivot Dec 21, 2021, 5:47 PM

#

fallen patrol well, what is cgroup overall? What's it used for?

cgroup = contorl group

#

memory limits, PID limits, CPU limits

#

you set limits and add processes into the cgroup

fallen patrol Dec 21, 2021, 5:47 PM

#

ahh

#

so what broke in v2?

patent pivot Dec 21, 2021, 5:48 PM

#

nothing broke

#

it's just a change in the structure of the filesystem which snekbox isn't used to

#

so we need to make code amendments to snekbox to let it handle that

fallen patrol Dec 21, 2021, 5:48 PM

#

since if its just the filesystem paths, wouldn't that be simple to change?

patent pivot Dec 21, 2021, 5:48 PM

#

there are also some modifications in how docker exposes the control group to the container which we have to work around

#

in theory yes, but the docker modifications make it a bit harder

fallen patrol Dec 21, 2021, 5:48 PM

#

patent pivot there are also some modifications in how docker exposes the control group to the...

oh that changes things

patent pivot Dec 21, 2021, 5:48 PM

#

notably, you can't enable these controllers if there are processes already in a cgroup, which there are (when snekbox boots, docker adds it to a cgroup)

thorny obsidian Dec 21, 2021, 5:49 PM

#

I feel bad for Mark, having to adapt snekbox for cv2 and docker adjustments

patent pivot Dec 21, 2021, 5:49 PM

#

we asked around and yesterday we found our answer

gritty wind Dec 21, 2021, 5:49 PM

#

I always knew Mark was a bot

#

He's just too efficient

thorny obsidian Dec 21, 2021, 5:49 PM

#

Xith and Mark, the two bots that keep us running

fallen patrol Dec 21, 2021, 5:49 PM

#

and scale

patent pivot Dec 21, 2021, 5:49 PM

#

the container will boot and put snekbox in it's own root private cgroup, then we have to move the container into it's own child cgroup, then we can modify which controllers are enabled, then snekbox can be on it's merry way

#

we did draw up some plans to deploy snekbox to it's own host at https://github.com/python-discord/snekbox-deploy

GitHub

GitHub - python-discord/snekbox-deploy: Deployment scripts for snek...

Deployment scripts for snekbox using Ansible. Contribute to python-discord/snekbox-deploy development by creating an account on GitHub.

fallen patrol Dec 21, 2021, 5:50 PM

#

oh that's fun

patent pivot Dec 21, 2021, 5:50 PM

#

which we might still use, because we may be able to throw gVisor into the mix for some added security

fallen patrol Dec 21, 2021, 5:50 PM

#

https://snekbox.pythondiscord.com

#

👀

patent pivot Dec 21, 2021, 5:50 PM

#

https://snekbox.pydis.com/, but I tore thta down

#

but we do now know that it will work inside our k8s

fallen patrol Dec 21, 2021, 5:50 PM

#

@gritty wind :glare:

patent pivot Dec 21, 2021, 5:50 PM

#

patent pivot https://snekbox.pydis.com/, but I tore thta down

(it also has auth)

fallen patrol Dec 21, 2021, 5:51 PM

#

yeah, makes sense

patent pivot Dec 21, 2021, 5:51 PM

#

fallen patrol ah, unlike joe 🤡

on this: linode did not tell us that it was a deb 11 upgrade

#

and most people don't need to know that, because most people don't mess with cgroups on the regular

#

our use case is very unique

fallen patrol Dec 21, 2021, 5:51 PM

#

patent pivot (it also has auth)

imagine running a snekbox on a publicly accessible domain that anyone can use without auth ~~ahem scale~~

gritty wind Dec 21, 2021, 5:52 PM

#

Imagine using it and getting nginx banned

fallen patrol Dec 21, 2021, 5:52 PM

#

patent pivot and most people don't need to know that, because most people don't mess with cgr...

given that it changes the pre-installed programs, isn't it worth knowing that its being upgraded like that?

patent pivot Dec 21, 2021, 5:52 PM

#

fallen patrol imagine running a snekbox on a publicly accessible domain that anyone can use wi...

for a minor workaround I don't think this is a major problem, as long as no one is irresponsible about using it

patent pivot Dec 21, 2021, 5:52 PM

#

fallen patrol given that it changes the pre-installed programs, isn't it worth knowing that it...

kind of

#

in theory, with kubernetes upgrades, the only noticeable change should be in cluster

fallen patrol Dec 21, 2021, 5:53 PM

#

i mean yeah, afaik, its kubernetes, so the underlying OS shouldn't matter

patent pivot Dec 21, 2021, 5:53 PM

#

cgroups really is a fairly abstract portion when you're doing container orchestration, this is the stuff that containers are built on and generally only the container engine will mess with cgroups

#

cgroups is the tech that docker+other engines use to do container limits

#

so you're not really expected to play with it yourself

#

it is supported though, so you can do that

gritty wind Dec 21, 2021, 5:54 PM

#

New idea: spin up a new snekbox pod for each eval

patent pivot Dec 21, 2021, 5:54 PM

#

it's just that there is a bit of a weird grey area where tools like kubernetes don't expose things that you can configure like docker does

gritty wind Dec 21, 2021, 5:54 PM

#

It's going to be wonderful during outages

patent pivot Dec 21, 2021, 5:54 PM

#

lmfao

#

https://man7.org/linux/man-pages/man7/cgroups.7.html

#

a good read

fallen patrol Dec 21, 2021, 5:56 PM

#

well, why does snekbox need to use cgroups itself?

#

why can it not use a container engine to manage that itself?

gritty wind Dec 21, 2021, 5:56 PM

#

Running docker inside docker heh

#

Well, we use cgroups + nsjail to get isolation and resource limits

patent pivot Dec 21, 2021, 5:57 PM

#

yeah

#

snekbox executions aren't containers, they're jails

#

and keeping them as jails makes it easier for us

#

we don't want to run an engine inside an engine, that leads to a load of unexpected behaviour

fallen patrol Dec 21, 2021, 5:58 PM

#

fallen patrol why can it not use a container engine to manage that itself?

wait I think I can answer this, it would need to have a lot of permissions to work, essentially decontainerizing snekbox

#

right?

patent pivot Dec 21, 2021, 5:59 PM

#

kind of

#

snekbox is already a privileged container

#

https://github.com/python-discord/snekbox/blob/main/deployment.yaml#L21-L22

stable mountainBOT Dec 21, 2021, 6:00 PM

#

deployment.yaml lines 21 to 22

securityContext:
  privileged: true```

patent pivot Dec 21, 2021, 6:01 PM

#

which means it's already a fairly powerful container

#

and we need that there to be able to write and control cgroups

#

but using nsjail instead of a container engine gives us the control we need without having to start up some daemon that is doing all sorts of unnecessary things

#

nsjail is a form of container engine

#

it's doing the exact same things that docker and containerd would do

fallen patrol Dec 21, 2021, 6:02 PM

#

ahhh

clever wraith Dec 21, 2021, 6:33 PM

#

You should use individual capabilities rather than using privileged fwiw

patent pivot Dec 21, 2021, 6:36 PM

#

clever wraith You should use individual capabilities rather than using privileged fwiw

yeah, not a bad shout, can't remember which capabilities snekbox specifically needs but once we get things back on-cluster we can look at this

clever wraith Dec 21, 2021, 6:38 PM

#

Oh right, I forgot that it isn't running on the cluster lmao

#

I believe NsJail documents the capabilities required somewhere somewhere

patent pivot Dec 21, 2021, 6:44 PM

#

clever wraith I believe NsJail documents the capabilities required *somewhere somewhere*

their official guidance on running in docker is to use --privileged

#

so I suspect finding the specific caps would be a matter of trial and error

tawdry vapor Dec 21, 2021, 7:11 PM

#

Any thoughts on how to write an automated test for this? https://github.com/python-discord/snekbox/issues/83

#

It needs to basically be a systems test

#

Where it goes through an actual container running the api with gunicorn

fallen patrol Dec 21, 2021, 7:36 PM

#

how can I run the bot not in docker, but redis in docker?

gritty wind Dec 21, 2021, 7:36 PM

#

docker-compose up redis snekbox

#

config:

fallen patrol Dec 21, 2021, 7:37 PM

#

they're up, so my config is bad

gritty wind Dec 21, 2021, 7:37 PM

#

    host:  "localhost"
    port:  6379
    password: !ENV "REDIS_PASSWORD"
    use_fakeredis: false

or use_fakeredis to true /shrug

fallen patrol Dec 21, 2021, 7:38 PM

#

odd

#

ohhh

#

yeah it works now

#

host: "localhost"
had this set to 'redis' since I was previously running the bot in docker

#

which means I also have to do the same thing for site

#

fix submitted, bot#2025

dusky shoreBOT Dec 21, 2021, 7:46 PM

#

GitHub

PROpen fix: pass required argument to docs cache delete

austere hornet Dec 21, 2021, 7:46 PM

#

Eyy #2025 that's the year I graduate lol (yes ik that's off topic)

fallen patrol Dec 21, 2021, 8:04 PM

#

metricity#11 @vale ibex, was automatically redirected to main

dusky shoreBOT Dec 21, 2021, 8:04 PM

#

GitHub

PRDraft Message sync command

vale ibex Dec 21, 2021, 8:07 PM

#

cool, github smart

#

Rebased it onto main now anyway, since it was missing a fix commit

fallen patrol Dec 21, 2021, 8:08 PM

#

lint failure 🥲

#

imagine not linting before you push

fallen patrol Dec 21, 2021, 8:10 PM

#

dusky shore

!remind 1H review if not already merged

stable mountainBOT Dec 21, 2021, 8:10 PM

#

Sure.

Your reminder will arrive on <t:1640121027:F>!

fallen patrol Dec 21, 2021, 8:12 PM

#

!remind delete 3782

stable mountainBOT Dec 21, 2021, 8:12 PM

#

Okay.

That reminder has been deleted successfully!

fallen patrol Dec 21, 2021, 8:12 PM

#

Chris keeps pushing to it ;-;

vale ibex Dec 21, 2021, 8:20 PM

#

That push was a rebase lol

austere hornet Dec 21, 2021, 8:21 PM

#

Wait so PyDis supports threads now? Now sure what the PR Scale merged was about

vale ibex Dec 21, 2021, 8:22 PM

#

We've had threads for a while, just limitted to staff channels

#

The PR that was just merged was to add support for threads in metricity

austere hornet Dec 21, 2021, 8:22 PM

#

Ohh ok

#

Got it

fallen patrol Dec 21, 2021, 8:22 PM

#

vale ibex That push was a rebase lol

are you done for the moment?

vale ibex Dec 21, 2021, 8:23 PM

#

Done until there are comments

fallen patrol Dec 21, 2021, 8:23 PM

#

good

#

and now the question you've all been waiting for.... how do I set up metricity?

vale ibex Dec 21, 2021, 8:24 PM

#

The readme should cover it

fallen patrol Dec 21, 2021, 8:34 PM

#

lets see

#

lol, can I make a pull to unpin the docker *image version to use the latest 3.9 version?

#

I've previously made one for lance, so its something we've done before

gritty wind Dec 21, 2021, 8:36 PM

#

I don't think that's a good idea, but people have been unpinning it without any discussion before so I guess

fallen patrol Dec 21, 2021, 8:36 PM

#

bot#1727

dusky shoreBOT Dec 21, 2021, 8:36 PM

#

GitHub

PRMerged change dockerfile python version to latest 3.9.x

fallen patrol Dec 21, 2021, 8:36 PM

#

#dev-contrib message

gritty wind Dec 21, 2021, 8:37 PM

#

There is no reasoning

#

You realize that right

#

And that's what I'm getting at

#

There is a good reason for locking the version that tight

fallen patrol Dec 21, 2021, 8:37 PM

#

gritty wind There is no reasoning

security updates is why I would think we would unpin, but why is the reason to lock it?

gritty wind Dec 21, 2021, 8:38 PM

#

Security updates won't happen unconsciously, someone has to come in and at the very least rebuild the container

#

The reason is it's 100% clear what version we're using. That means everyone can use the same version, and for updates specifically, it means we have an easy way to know what version we're on, and what to update to

#

Here for instance: tell me what version forms-backend is on

fallen patrol Dec 21, 2021, 8:39 PM

#

ah. That makes sense

#

👀

#

!paste

#

https://paste.pythondiscord.com/sehecaquhu.sql

gritty wind Dec 21, 2021, 8:40 PM

#

What do you have in your config

fallen patrol Dec 21, 2021, 8:40 PM

#

I'm running the container generated by the bot's docker compose

#

(ignore the first db that's for a different bot)

#

although maybe that's related

gritty wind Dec 21, 2021, 8:41 PM

#

It's not bot, it's the other one

#

metricity tries to claim 5432 too

vale ibex Dec 21, 2021, 8:41 PM

#

You're running --no-deps

fallen patrol Dec 21, 2021, 8:41 PM

#

gritty wind What do you have in your config

https://paste.pythondiscord.com/qitosakola.ini

vale ibex Dec 21, 2021, 8:41 PM

#

so postgres isn't getting started

fallen patrol Dec 21, 2021, 8:41 PM

#

vale ibex You're running --no-deps

yeah, because I already have the database running, and I wanted to be able to use the same db for metricity as site

#

although that doesn't work, so I'm curious why not

gritty wind Dec 21, 2021, 8:42 PM

#

Network

#

Compose isolates the network for each stack

#

You can pass a network flag to override it, or use the underlaying tunnels that join all containers

fallen patrol Dec 21, 2021, 8:42 PM

#

ah

gritty wind Dec 21, 2021, 8:42 PM

#

docker network ls

#

probably something along bot_default or site_default

fallen patrol Dec 21, 2021, 8:43 PM

#

gritty wind `docker network ls`

#

okay

gritty wind Dec 21, 2021, 8:43 PM

#

You could also try docker inspect <container name> and grep for the right one

fallen patrol Dec 21, 2021, 8:44 PM

#

gritty wind You can pass a network flag to override it, or use the underlaying tunnels that ...

what's the flag name?

#

to docker-compose run

gritty wind Dec 21, 2021, 8:45 PM

#

--project-name

#

It's a bit hacky though

#

Since it'll deploy it to the site other project's stack

#

docker run without compose accepts network

fallen patrol Dec 21, 2021, 8:46 PM

#

ah gotcha

gritty wind Dec 21, 2021, 8:46 PM

#

Considering metricity is a single container, that might be your best bet here

#

If you're running the metricity bot locally, you don't actually need the docker stuff for anything

fallen patrol Dec 21, 2021, 8:46 PM

#

I'll just... build a metricity image, and make a container from that without compose

gritty wind Dec 21, 2021, 8:46 PM

#

Just point the config at 7777

fallen patrol Dec 21, 2021, 8:46 PM

#

(canary died again lol)

gritty wind Dec 21, 2021, 8:47 PM

#

Join the dark side, come to stable

fallen patrol Dec 21, 2021, 8:47 PM

#

I'm on stable atm

#

...

gritty wind Dec 21, 2021, 8:47 PM

#

3rd time's the charm

fallen patrol Dec 21, 2021, 8:47 PM

#

I sent it once on canary, and once on stable

gritty wind Dec 21, 2021, 8:48 PM

#

I have this, it might help

@REM Update
git fetch
git pull

@REM Build
docker build . -t metricity

@REM Cleanup
docker container stop metricity
docker container rm metricity
docker image prune -f

@REM Run
docker compose -f ../site/docker-compose.yml up -d
docker exec -it site-postgres-1 /bin/bash -c "psql -U pysite -d metricity -c 'DROP SCHEMA public CASCADE; CREATE SCHEMA public;'"

docker run -d --env-file .env --network site_default --name metricity metricity

#

Usually, when I'm using metricity I'm just pulling the latest changes, and having the bot start up in the background

fallen patrol Dec 21, 2021, 8:50 PM

#

docker exec -it site-postgres-1 /bin/bash -c "psql -U pysite -d metricity -c 'DROP SCHEMA public CASCADE; CREATE SCHEMA public;'
what does this do?

green oriole Dec 21, 2021, 8:50 PM

#

https://github.blog/changelog/2021-12-21-specify-who-can-force-push-to-a-repository

The GitHub Blog

Sidi Merzouk

Specify who can force push to a repository | GitHub Changelog

Specify who can force push to a repository

#

Could be relevant for pydis

fallen patrol Dec 21, 2021, 8:50 PM

#

gritty wind I have this, it might help ```bat @REM Update git fetch git pull @REM Build doc...

interesting

fallen patrol Dec 21, 2021, 8:51 PM

#

gritty wind I have this, it might help ```bat @REM Update git fetch git pull @REM Build doc...

interesting

patent pivot Dec 21, 2021, 8:52 PM

#

green oriole Could be relevant for pydis

prooooobably unnecessary, force pushes aren't super harmful since we already block main pushes for everyone (including admins).

#

and we encourage force pushes on branches/forks

#

and I don't think we're going to go back to the model of allowing contributors to the org

gritty wind Dec 21, 2021, 8:54 PM

#

fallen patrol > `docker exec -it site-postgres-1 /bin/bash -c "psql -U pysite -d metricity -c ...

The database that we get from site compose comes with pre-existing tables for metricity, which are actually incompatible with metricity if it tried to run on them. This just deletes them. It isn't a problem on bot compose though

fallen patrol Dec 21, 2021, 8:56 PM

#

gritty wind The database that we get from site compose comes with pre-existing tables for me...

i honestly just deleted all of my pydis images and containers lol

#

gonna restart from the beginning so I can maybe work on some site issues mayhaps

#

wait...

#

docker-compose.overide.yml is a thing

#

;-;

#

I can just make an override file for bot which instead of pulling web, will build it from the neighbouring folder

gritty wind Dec 21, 2021, 9:03 PM

#

What are you even doing

fallen patrol Dec 21, 2021, 9:04 PM

#

getting my docker containers in order and to submit to me

#

also my development environment too

austere hornet Dec 21, 2021, 9:05 PM

#

@fallen patrol Have you seen this? #dev-log message

fallen patrol Dec 21, 2021, 9:05 PM

#

austere hornet <@717983911824588862> Have you seen this? https://discord.com/channels/267624335...

!remind 2H

stable mountainBOT Dec 21, 2021, 9:05 PM

#

No problem.

Your reminder will arrive on <t:1640127951:F>!

fallen patrol Dec 21, 2021, 9:15 PM

#

gritty wind What are you even doing

trying to make it so I can use my local bot/site/metricity/etc images instead of docker pulling the latest

#

how do I do that?

gritty wind Dec 21, 2021, 9:15 PM

#

I'll need more details lol

#

How are you spinning up the dependent images, which project are you working on

fallen patrol Dec 21, 2021, 9:16 PM

#

hope to review a few pulls on site, so I'm trying to get that working along with corresponding bot pulls

gritty wind Dec 21, 2021, 9:16 PM

#

Okay, spin up docker compose on site as normal

#

If you want site running that is

#

Then in bot's docker compose, modify the image to point towards the site image that was just built locally

fallen patrol Dec 21, 2021, 9:17 PM

#

ooh i think i got it!

gritty wind Dec 21, 2021, 9:17 PM

#

I personally actually modify the site address in the bot's config so I can have each stack separate and consistent

fallen patrol Dec 21, 2021, 9:17 PM

#

fallen patrol docker-compose.overide.yml is a thing

.

gritty wind Dec 21, 2021, 9:17 PM

#

yup

fallen patrol Dec 21, 2021, 9:17 PM

#

version: "3.6"
services:
  web:
    build:
      context: ../site
      dockerfile: Dockerfile

#

my file structure is ~/pydis/bot and ~/pydis/site

summer garden Dec 21, 2021, 9:20 PM

#

@thorny obsidianI'm pretty much finished with the epoch command, although I wasn't able to implement parsing named timezones eg. EST, PST. I would appreciate any comments whenever you are free :p sir-lancebot#983

dusky shoreBOT Dec 21, 2021, 9:20 PM

#

GitHub

PROpen Epoch command

thorny obsidian Dec 21, 2021, 9:21 PM

#

summer garden <@!212644551926611969>I'm pretty much finished with the epoch command, although ...

I'll take a look when I get home! Thank you so so much for implementing this

fallen patrol Dec 21, 2021, 9:21 PM

#

summer garden <@!212644551926611969>I'm pretty much finished with the epoch command, although ...

there's a util for those in our dependencies, heh

#

~~definitely didn't find both of them the past few days~~

#

!d dateutil.tz

stable mountainBOT Dec 21, 2021, 9:22 PM

#

dateutil.tz

This module offers timezone implementations subclassing the abstract datetime.tzinfo type. There are classes to handle tzfile format files (usually are in /etc/localtime, /usr/share/zoneinfo, etc), TZ environment string (in all known formats), given ranges (with help from relative deltas), local machine timezone, fixed offset timezone, and UTC timezone.

summer garden Dec 21, 2021, 9:23 PM

#

From what I saw it only accepts a weird format rather than the shortened timezone version

fallen patrol Dec 21, 2021, 9:24 PM

#

!e ```py
import dateutil.tz
print(dateutil.tz.gettz('CET'))

stable mountainBOT Dec 21, 2021, 9:24 PM

#

@fallen patrol :white_check_mark: Your eval job has completed with return code 0.

tzfile('CET')

summer garden Dec 21, 2021, 9:25 PM

#

I'll be damned

dim pelican Dec 21, 2021, 9:25 PM

#

No you'll be bones

fallen patrol Dec 21, 2021, 9:27 PM

#

also:

#

!d arrow.arrow.Arrow.replace

stable mountainBOT Dec 21, 2021, 9:27 PM

#

arrow.arrow.Arrow.replace


replace(**kwargs)```
Returns a new [`Arrow`](https://arrow.readthedocs.io/en/latest/index.html#arrow.arrow.Arrow "arrow.arrow.Arrow") object with attributes updated according to inputs.

Use property names to set their value absolutely:

```py
>>> import arrow
>>> arw = arrow.utcnow()
>>> arw
<Arrow [2013-05-11T22:27:34.787885+00:00]>
>>> arw.replace(year=2014, month=6)
<Arrow [2014-06-11T22:27:34.787885+00:00]>
```...

fallen patrol Dec 21, 2021, 9:27 PM

#

(usable as arrow.Arrow().replace, but their docs are weird)

fallen patrol Dec 21, 2021, 9:28 PM

#

summer garden I'll be damned

😛

#

want me to comment these on the issue or pull?

summer garden Dec 21, 2021, 9:34 PM

#

these docs are such a nightmare 🙄

summer garden Dec 21, 2021, 9:35 PM

#

fallen patrol want me to comment these on the issue or pull?

I'm good for now. Trying to come up with a game plan

fallen patrol Dec 21, 2021, 9:36 PM

#

👍

#

@gritty wind hellllp

#

I spent 20 minutes on that

#

as soon as I pinged you I saw the typo

gritty wind Dec 21, 2021, 9:37 PM

#

You know you can set that in the config, right?

fallen patrol Dec 21, 2021, 9:38 PM

#

~~I did but for some reason it didn't want it~~ nvm

gritty wind Dec 21, 2021, 9:38 PM

#

uri = { env = "DATABASE_URI", optional = true }
to
uri = "postgresql://"

#

What'd you set it to?

fallen patrol Dec 21, 2021, 9:38 PM

#

no comment, see edit

gritty wind Dec 21, 2021, 9:39 PM

#

I'm saying you don't actually need to pass it in as an env var

clever wraith Dec 21, 2021, 9:40 PM

#

gritty wind Dec 21, 2021, 9:40 PM

#

It makes the image easier to run if you set everything in the config.toml lol

clever wraith Dec 21, 2021, 9:40 PM

#

metricity broke

#

cc @patent pivot

gritty wind Dec 21, 2021, 9:40 PM

#

Did you reinstall deps?

fallen patrol Dec 21, 2021, 9:41 PM

#

gritty wind > uri = { env = "DATABASE_URI", optional = true } to > uri = "postgresql://"

odd, something is wrong

clever wraith Dec 21, 2021, 9:41 PM

#

are you talking to me

gritty wind Dec 21, 2021, 9:41 PM

#

Yeah, but I see the GH issue now

clever wraith Dec 21, 2021, 9:41 PM

#

gdude is fast

gritty wind Dec 21, 2021, 9:42 PM

#

gotta figure out the exact event fired

#

But it wouldn't make sense for one event to have to two different sigs

clever wraith Dec 21, 2021, 9:42 PM

#

I mean

gritty wind Dec 21, 2021, 9:42 PM

#

It would either mean always using variadic args or function overrides

clever wraith Dec 21, 2021, 9:42 PM

#

it is d.py

gritty wind Dec 21, 2021, 9:43 PM

#

Which aren't a thing in python

fallen patrol Dec 21, 2021, 9:43 PM

#

!remind 15M sigh

stable mountainBOT Dec 21, 2021, 9:43 PM

#

I'll allow it.

Your reminder will arrive on <t:1640123894:F>!

clever wraith Dec 21, 2021, 9:43 PM

#

there

vale ibex Dec 21, 2021, 9:43 PM

#

metricity#12

dusky shoreBOT Dec 21, 2021, 9:43 PM

#

GitHub

PROpen Fix on_thread_update as it takes 2 args, not one

fallen patrol Dec 21, 2021, 9:43 PM

#

i can't review yet ;-;

clever wraith Dec 21, 2021, 9:44 PM

#

i wonder how this got past code reviewing

gritty wind Dec 21, 2021, 9:44 PM

#

The same way anything gets past code reviewing

#

Don't merge yet, I've gotta check something

fallen patrol Dec 21, 2021, 9:45 PM

#

4 days later

clever wraith Dec 21, 2021, 9:45 PM

#

I mean, any change to a thread would have ran into a traceback

gritty wind Dec 21, 2021, 9:45 PM

#

Yes, but that wasn't tested

#

We tested changes on startup mostly

#

And migration stuff

clever wraith Dec 21, 2021, 9:45 PM

#

also please link the issue in the PR

clever wraith Dec 21, 2021, 9:46 PM

#

gritty wind Yes, but that wasn't tested

bad reviewer :bonk:

gritty wind Dec 21, 2021, 9:46 PM

#

There is no real issue to link

clever wraith Dec 21, 2021, 9:46 PM

#

oh right, it was the same

gritty wind Dec 21, 2021, 9:46 PM

#

We have one issue on metricity

#

in total

fallen patrol Dec 21, 2021, 9:46 PM

#

lmfao and my metricity instance still isn't up ;-;

clever wraith Dec 21, 2021, 9:46 PM

#

no sentry either, I'm guessing?

fallen patrol Dec 21, 2021, 9:46 PM

#

(I'm eating rn and will continue resolving in a bit)

gritty wind Dec 21, 2021, 9:47 PM

#

grep sentry

0 results

patent pivot Dec 21, 2021, 9:47 PM

#

don’t think we’ve for sentry no

#

we should add it one day

vale ibex Dec 21, 2021, 9:47 PM

#

No sentry, but that wouldn't have helped anyway, since this wasn't on pydis's instance

clever wraith Dec 21, 2021, 9:47 PM

#

I mean I know haha

#

but pydis could have ran into the same issue

fallen patrol Dec 21, 2021, 9:47 PM

#

^

#

it would've happened the moment a thread was updated in nominations

clever wraith Dec 21, 2021, 9:48 PM

#

I mean they use way more threads than that

fallen patrol Dec 21, 2021, 9:48 PM

#

i don't know that ¯_(ツ)_/¯

clever wraith Dec 21, 2021, 9:48 PM

#

but it does seem unlikely that a state change occurred in a little timeframe like that

fallen patrol Dec 21, 2021, 9:49 PM

#

they (gdude's server) has a large server with many members and threads enabled which its used on, soooo

clever wraith Dec 21, 2021, 9:49 PM

#

there were threads in like every single staff channel, it was crazy

#

threads in quilt are very nice

#

quite a nice example of how threads could be used, someone from here should have a tour one day

#

especially on the tooling aspects, because there are many things you don't think about beforehand

gritty wind Dec 21, 2021, 9:54 PM

#

Trying to repro the last thing from gdude

#

If I understand correctly:

Archive thread
Turn on bot
Unarchive
State incorrect

clever wraith Dec 21, 2021, 9:55 PM

#

yes

gritty wind Dec 21, 2021, 9:55 PM

#

I wonder if the thread was in the table before the first bot start

clever wraith Dec 21, 2021, 9:56 PM

#

no

gritty wind Dec 21, 2021, 9:56 PM

#

That didn't even fire off an event though hmm

#

Yeah no event is being fired off at all for this

fallen patrol Dec 21, 2021, 9:57 PM

#

I'm gonna probably sleep and resolve these docker issues in the morning

clever wraith Dec 21, 2021, 9:57 PM

#

gritty wind Yeah no event is being fired off at all for this

for what?

gritty wind Dec 21, 2021, 9:58 PM

#

gritty wind If I understand correctly: 1. Archive thread 2. Turn on bot 3. Unarchive 4. Stat...

I did this, but on_thread_update was never called

clever wraith Dec 21, 2021, 9:58 PM

#

unarchiving sure calls it

gritty wind Dec 21, 2021, 9:58 PM

#

Did not in this case

clever wraith Dec 21, 2021, 9:58 PM

#

discord dispatches a thread edit event

gritty wind Dec 21, 2021, 9:59 PM

#

It really isn't lol

#

I just tested the same break point

#

For unarchiving, if the bot was up when it was archived, it'll work

#

But if you turn the bot off, archive, then bot on, and unarchive, it won't call the event

#

I'm gonna copy the socket stuff from bot

clever wraith Dec 21, 2021, 9:59 PM

#

seems like a software bug

fallen patrol Dec 21, 2021, 10:00 PM

#

uhhh

gritty wind Dec 21, 2021, 10:00 PM

#

wdym

fallen patrol Dec 21, 2021, 10:00 PM

#

use the gateway even thing

#

!d discord.on_socket_event_type

stable mountainBOT Dec 21, 2021, 10:01 PM

#

discord.on\_socket\_event\_type


discord.on_socket_event_type(event_type)```
Called whenever a websocket event is received from the WebSocket.

This is mainly useful for logging how many events you are receiving from the Discord gateway.

New in version 2.0.

clever wraith Dec 21, 2021, 10:01 PM

#

discord is supposed to be sending an event

fallen patrol Dec 21, 2021, 10:01 PM

#

log those see if you get it

clever wraith Dec 21, 2021, 10:01 PM

#

d.py could just be dropping it

fallen patrol Dec 21, 2021, 10:01 PM

#

^ if it's not in the cache that's definitely probable

#

this event above will ensure you can see if you get a THREAD_UPDATE

gritty wind Dec 21, 2021, 10:05 PM

#

I brought in the big guns

#

Copied the int cog from python

molten bough Dec 21, 2021, 10:06 PM

#

it me

fallen patrol Dec 21, 2021, 10:06 PM

#

lol

#

hi gdue

molten bough Dec 21, 2021, 10:06 PM

#

I suspect d.py making too many caching assumptions

fallen patrol Dec 21, 2021, 10:06 PM

#

gudue

#

gdue

molten bough Dec 21, 2021, 10:06 PM

#

you'll get there in the end lmao

fallen patrol Dec 21, 2021, 10:06 PM

#

I'm tiried

austere hornet Dec 21, 2021, 10:07 PM

#

I can tell

fallen patrol Dec 21, 2021, 10:07 PM

#

gdude

molten bough Dec 21, 2021, 10:07 PM

#

ayy

gritty wind Dec 21, 2021, 10:07 PM

#

Metricity is being wonderful and refusing to respond to commands, despite me setting the prefix

#

Now to find out why it's blocked

molten bough Dec 21, 2021, 10:07 PM

#

it has commands now?

fallen patrol Dec 21, 2021, 10:07 PM

#

it's the owner check since you did a 1:1 copy

clever wraith Dec 21, 2021, 10:07 PM

#

GNUdude

vale ibex Dec 21, 2021, 10:07 PM

#

it'll be because we overwrite the on_message handler

fallen patrol Dec 21, 2021, 10:07 PM

#

clever wraith GNUdude

actually GNU/Linux dude

vale ibex Dec 21, 2021, 10:07 PM

#

add a process commands in there

clever wraith Dec 21, 2021, 10:08 PM

#

true true

gritty wind Dec 21, 2021, 10:08 PM

#

molten bough it has commands now?

I ported over a statistics command to count stuff

#

I think both issues might have to do with the

#

max_messages being set to None

#

    The maximum number of messages to store in the internal message cache.
    This defaults to ``1000``. Passing in ``None`` disables the message cache.

vale ibex Dec 21, 2021, 10:08 PM

#

nah, I ran into this with my other PR

molten bough Dec 21, 2021, 10:08 PM

#

I don't see why that'd matter

vale ibex Dec 21, 2021, 10:08 PM

#

see my messages above

gritty wind Dec 21, 2021, 10:08 PM

#

Ah, right ofc

fallen patrol Dec 21, 2021, 10:08 PM

#

vale ibex it'll be because we overwrite the on_message handler

... that'z annoying why not write anew command or listezner?

molten bough Dec 21, 2021, 10:08 PM

#

it's a simple bot

vale ibex Dec 21, 2021, 10:08 PM

#

molten bough it has commands now?

I'm planning on adding one actually

#

see my other PR

#

it'll be a way to force sync messages

clever wraith Dec 21, 2021, 10:09 PM

#

fallen patrol ... that'z annoying why not write anew command or listezner?

nice layout

fallen patrol Dec 21, 2021, 10:09 PM

#

so it doesn't require process commands

molten bough Dec 21, 2021, 10:09 PM

#

it's a simple bot arl, it doesn't even use cogs

fallen patrol Dec 21, 2021, 10:09 PM

#

with like, @bot.event or bot.listen

#

rather than overwriting the existing one

clever wraith Dec 21, 2021, 10:09 PM

#

slash commands anyone? 😔

molten bough Dec 21, 2021, 10:09 PM

#

I do love my application commands haha

fallen patrol Dec 21, 2021, 10:10 PM

#

clever wraith slash commands anyone? 😔

I am looking forward to when pydis switches to a fork

molten bough Dec 21, 2021, 10:10 PM

#

is this issue not fixed by any of the forks?

#

if so that's probably a drop-in fix

fallen patrol Dec 21, 2021, 10:10 PM

#

well, they'd have to choose a fork so

clever wraith Dec 21, 2021, 10:10 PM

#

I think forks fixed the caching issue

fallen patrol Dec 21, 2021, 10:11 PM

#

let's have that discussion rn /s

molten bough Dec 21, 2021, 10:11 PM

#

y'all can have it, I don't write python anymore lmao

fallen patrol Dec 21, 2021, 10:11 PM

#

molten bough I do love my application commands haha

BTW what fork do you use?

#

oh

clever wraith Dec 21, 2021, 10:11 PM

#

I would say it is about time pydis chooses a fork tbf, there is nothing irreversible here

molten bough Dec 21, 2021, 10:11 PM

#

I use a framework called KordEx for kotlin

#

wrote it myself

#

whee

fallen patrol Dec 21, 2021, 10:11 PM

#

clever wraith I would say it is about time pydis chooses a fork tbf, there is nothing irrevers...

any suggestions of a fork?

molten bough Dec 21, 2021, 10:12 PM

#

I've heard good things about pycord

fallen patrol Dec 21, 2021, 10:12 PM

#

I'm partial to one of them but want to let opposing views get in first

clever wraith Dec 21, 2021, 10:12 PM

#

🤷 my only experience was with disnake, worked fine, but not enough to voice an opinion