clever wraith Dec 1, 2021, 10:41 PM

#

^ @green oriole

vale ibex Dec 1, 2021, 10:41 PM

#

but I've changed it to ping now

#

just dev testing

#

depends on the context

#

simpler can be good, unless there's a good reason for convention

magic arch Dec 1, 2021, 10:50 PM

#

love the new buttons for help groups zig

#

all these new buttons are great lol

vale ibex Dec 1, 2021, 10:50 PM

#

alright, small PR to improve ux for the subscribe command bot#1985

dusky shoreBOT Dec 1, 2021, 10:50 PM

#

GitHub

PROpen Redirect subscribe command output to bot commands

#

GitHub

PROpen Make development workflow easier to use

cold island Dec 1, 2021, 10:56 PM

#

!help reminders

stable mountainBOT Dec 1, 2021, 10:56 PM

#

Command Help

!remind [mentions]... <expiration> [content]
Can also use: reminder, reminders, remindme

*Commands for managing your reminders.

The expiration duration of !remind new supports the following symbols for each unit of time: - years: Y, y, year, years - months: m, month, months - weeks: w, W, week, weeks - days: d, D, day, days - hours: H, h, hour, hours - minutes: M, minute, minutes - seconds: S, s, second, seconds

For example, to set a reminder that expires in 3 days and 1 minute, you can do !remind new 3d1M Do something.*

Subcommands:

!remind delete <id_>
Delete one of your active reminders.
!remind edit
Commands for modifying your current reminders.
!remind list
View a paginated embed of all reminders for your user.
!remind new [mentions]... <expiration> [content]
Set yourself a simple reminder.

cold island Dec 1, 2021, 10:56 PM

#

Nice

vale ibex Dec 1, 2021, 10:57 PM

#

Yea, just pointing it out since poetry run task test is a lot longer than just plain pytest

#

In bot we have it since we add a bunch of params for xdist and code coverage

#

and retesting config

fallen patrol Dec 1, 2021, 10:57 PM

#

vale ibex In bot we have it since we add a bunch of params for xdist and code coverage

which aren't even necessary, either

#

addopts can be configured to always run with those params

clever wraith Dec 1, 2021, 10:58 PM

#

core devs: might want to comment on the open api PRs so no more work in being put into them, no?

fallen patrol Dec 1, 2021, 11:03 PM

#

vale ibex Yea, just pointing it out since `poetry run task test` is a lot longer than just...

I just realised, those aren't comparable

#

poetry run runs it in the environment, pytest must be ran within the environment as well

#

so its only comparing task test to pytest

#

if you're running pytest, its either already in the venv OR poetry run pytest

#

and task test and pytest are about the same length so

dusky shoreBOT Dec 1, 2021, 11:07 PM

#

GitHub

PROpen Make development workflow easier to use

magic arch Dec 1, 2021, 11:19 PM

#

dusky shore

!remind 90M review this and api-18

stable mountainBOT Dec 1, 2021, 11:19 PM

#

Alright.

Your reminder will arrive on <t:1638406149:F>!

fallen patrol Dec 1, 2021, 11:23 PM

#

small pr to fix the hanukkah command before hanukkah is over, since its currently live!
sir-lancebot#959

dusky shoreBOT Dec 1, 2021, 11:23 PM

#

GitHub

PROpen fix: hanukkah command respects month boundaries

fallen patrol Dec 1, 2021, 11:40 PM

#

only one more review needed ^^

trail pilot Dec 2, 2021, 12:02 AM

#

fallen patrol only one more review needed ^^

approved

#

it's ready for merge now 🎉

fallen patrol Dec 2, 2021, 12:02 AM

#

yay i can't merge it tho 😔

#

@vale ibex wat, no automerge turned on?

#

yay

#

vale ibex Dec 2, 2021, 12:09 AM

#

@fallen patrol what do you mean by no labels added to the pr yet, tho?

fallen patrol Dec 2, 2021, 12:09 AM

#

triage

vale ibex Dec 2, 2021, 12:09 AM

#

PR labels are mostly just for categorisation, rather than functionality

fallen patrol Dec 2, 2021, 12:09 AM

#

:facepalm:

vale ibex Dec 2, 2021, 12:09 AM

#

unless its the Do not merge, or needs devops

fallen patrol Dec 2, 2021, 12:10 AM

#

i have been out of it today lol

vale ibex Dec 2, 2021, 12:10 AM

#

😄

fallen patrol Dec 2, 2021, 12:10 AM

#

oh lol i have sir-lancebot#950 also open--needs one review

dusky shoreBOT Dec 2, 2021, 12:10 AM

#

GitHub

PROpen Remove unnecessary edits during pagination

fallen patrol Dec 2, 2021, 12:11 AM

#

then i'll go sleep

#

because i apparently need it

vale ibex Dec 2, 2021, 12:11 AM

#

deleting code, nice

fallen patrol Dec 2, 2021, 12:11 AM

#

yep

#

nice

#

#

as there is no trashcan, its clear that lance was killed while I was paginating 😂

fallen patrol Dec 2, 2021, 12:14 AM

#

vale ibex deleting code, nice

100% that's why I used to think that lance had a slow paginator

vale ibex Dec 2, 2021, 12:16 AM

#

yup it is 😛

thorny obsidian Dec 2, 2021, 12:29 AM

#

If anyone's in my test server, could you test the .aoc link command?

short snow Dec 2, 2021, 12:37 AM

#

Zig modpings 👀

thorny obsidian Dec 2, 2021, 12:40 AM

#

hm... I actually found a decent use case for the walrus operator in this feature and it's readable

trail pilot Dec 2, 2021, 12:44 AM

#

thorny obsidian hm... I actually found a decent use case for the walrus operator in this feature...

What's the use case?

Depending on the case I think I have a few cases in my code where a walrus could also benefit from the usecase you had the walrus operator for

#

usually I've just used the walrus operator for truthiness checks like:
if role := discord.utils.get(guild.roles, name="Role Name")

thorny obsidian Dec 2, 2021, 12:46 AM

#

trail pilot usually I've just used the walrus operator for truthiness checks like: `if role ...

Very similar to that. I'm checking to see if something exists in a cache. If it does, I want to use it.

trail pilot Dec 2, 2021, 12:47 AM

#

thorny obsidian Very similar to that. I'm checking to see if something exists in a cache. If it ...

Ahh, that's one of my favorite cases of the walrus operator, a lot better than:

if truthiness_check:
  item = truthiness_check

stable mountainBOT Dec 2, 2021, 12:49 AM

#

magic arch !remind 90M review this and api-18

It has arrived!

Here's your reminder: review this and api-18
[Jump back to when you created the reminder](#dev-contrib message)

magic arch Dec 2, 2021, 3:24 AM

#

Hey can someone peek at sir-lancebot#962? It should be an incredibly quick fix and it'd be awesome to have it live before AoC day 2 opens.

dusky shoreBOT Dec 2, 2021, 3:24 AM

#

GitHub

IssueOpen Better handling of AoC usernames with spaces

short snow Dec 2, 2021, 3:25 AM

#

You can put them into "" though

magic arch Dec 2, 2021, 3:25 AM

#

True, but that seems unnecessary complicated for folks who don't know that when it's the only argument

short snow Dec 2, 2021, 3:26 AM

#

Hmm yeah, you could probably just PR IMO

thorny obsidian Dec 2, 2021, 3:26 AM

#

magic arch Hey can someone peek at sir-lancebot#962? It should be an incredibly quick fix a...

A PR likely won't get reviewed and merged in 90 minutes by a core dev. But I'm fine with PRing this in general, so consider this approval.

fallen patrol Dec 2, 2021, 3:27 AM

#

yeah, chris is asleep (or at least not online)

magic arch Dec 2, 2021, 3:29 AM

#

thorny obsidian A PR likely won't get reviewed and merged in 90 minutes by a core dev. But I'm f...

Fair enough, and if it doesn't happen before day 2 then so be it, still a good little thing to have soon imo

fallen patrol Dec 2, 2021, 3:30 AM

#

magic arch Fair enough, and if it doesn't happen before day 2 then so be it, still a good l...

hey if i pr it then you'll only need one review 👀, since you'll be able to review it

thorny obsidian Dec 2, 2021, 3:31 AM

#

I already have lance up and running for a few feature reviews, so it's not the contrib review I'm concerned about

magic arch Dec 2, 2021, 3:32 AM

#

Plus a core dev would need to review and merge either way

short snow Dec 2, 2021, 3:32 AM

#

ping joe/scal/xith lol

#

all are online

fallen patrol Dec 2, 2021, 3:32 AM

#

oh, didn't actually realise that a core dev had to review everything

#

thought it was 2 (authorized) people or a core dev

magic arch Dec 2, 2021, 3:33 AM

#

Yeah it's 2 staff and a core dev 🤷‍♂️ (core dev also counts for staff)

thorny obsidian Dec 2, 2021, 3:33 AM

#

If it's not a tag speedrun, then you need a core dev + 1

vocal prairie Dec 2, 2021, 3:33 AM

#

two staff/contrib reviews, one has to be a core dev

short snow Dec 2, 2021, 3:33 AM

#

one staff + one coredev

fallen patrol Dec 2, 2021, 3:33 AM

#

okay i think i got it

#

😂

thorny obsidian Dec 2, 2021, 3:33 AM

#

Some changes require specific admin approval too depending on which repo and which features they're changing

thorny obsidian Dec 2, 2021, 3:34 AM

#

short snow ping joe/scal/xith lol

both scale and joe should be asleep and this is not urgent enough to ping over. Xith is busy enough as it is

patent pivot Dec 2, 2021, 3:35 AM

#

imagine sleep

magic arch Dec 2, 2021, 3:35 AM

#

loll

thorny obsidian Dec 2, 2021, 3:35 AM

#

patent pivot imagine sleep

spray go sleep

#

ugh, I have no good way of splitting this feature into more than one commit

magic arch Dec 2, 2021, 3:37 AM

#

thorny obsidian <:spray:718705604067196951> go sleep

or stay for like a few minutes if u wanna review something lol

short snow Dec 2, 2021, 3:41 AM

#

thorny obsidian both scale and joe *should* be asleep and this is not urgent enough to ping over...

ah ok

fallen patrol Dec 2, 2021, 3:42 AM

#

sadly joe is above

#

joe go to sleep

short snow Dec 2, 2021, 3:42 AM

#

so should you

fallen patrol Dec 2, 2021, 3:44 AM

#

no

short snow Dec 2, 2021, 3:46 AM

#

i won't review 🙃

magic arch Dec 2, 2021, 3:48 AM

#

well it is done, everyone wish the pr good luck! sir-lancebot#963

dusky shoreBOT Dec 2, 2021, 3:48 AM

#

GitHub

PROpen Make self_placement_name keyword-only in .aoc lb

thorny obsidian Dec 2, 2021, 3:57 AM

#

magic arch well it is done, everyone wish the pr good luck! sir-lancebot#963

It does have the effect of .aoc lb "My Name" no longer working and people have already gotten used to that

magic arch Dec 2, 2021, 3:58 AM

#

true, maybe we can strip quotes? not sure if it's valid for aoc usernames to have quotes

thorny obsidian Dec 2, 2021, 3:59 AM

#

I think the solution there would be to see if starts and ends with " and if so, it strips just that from the ends

magic arch Dec 2, 2021, 3:59 AM

#

gotcha, will do really quick

short snow Dec 2, 2021, 4:00 AM

#

what if someone's name has" at end and start lol

thorny obsidian Dec 2, 2021, 4:00 AM

#

can you show an example?

short snow Dec 2, 2021, 4:00 AM

#

lemme try

magic arch Dec 2, 2021, 4:01 AM

#

can't see a single " in our 700+ people on the leaderboard, so my guess is no but idk

thorny obsidian Dec 2, 2021, 4:01 AM

#

Because I don't know of anyone's AoC leaderboard starting and ending with " since the name comes from one of the Auth methods or you select Anonymous #121312

magic arch Dec 2, 2021, 4:01 AM

#

although there is � so there's that

short snow Dec 2, 2021, 4:02 AM

#

how do make it choose your github name, not username

#

it = adventofcode

#

i had seen eivl paste a screenshot containing his github name

thorny obsidian Dec 2, 2021, 4:02 AM

#

These are the only options I have

#

It comes from GitHub when you Auth I'm pretty sure

short snow Dec 2, 2021, 4:03 AM

#

ok yeah had to reauth

#

https://adventofcode.com/2021/leaderboard/private/view/968271

thorny obsidian Dec 2, 2021, 4:04 AM

#

Right, so people can. Who does though?

#

And they need their Github name to be that and they need to Auth with their github name being that

short snow Dec 2, 2021, 4:04 AM

#

🤷‍♂️

vocal prairie Dec 2, 2021, 4:05 AM

#

I think having a QoL feature that works for 99% of people is more important than the odd person sticking quotes in their name

short snow Dec 2, 2021, 4:05 AM

#

yeah

magic arch Dec 2, 2021, 4:05 AM

#

technically if that happens they can just go like ""Shivansh"" and this'll work for that 0.01%

short snow Dec 2, 2021, 4:05 AM

#

but then that odd person won't be able to use it

magic arch Dec 2, 2021, 4:06 AM

#

no i'm saying they can with two double quotes on each end instead

#

it'll only strip one pair of quotes

short snow Dec 2, 2021, 4:06 AM

#

hmm maybe

magic arch Dec 2, 2021, 4:07 AM

#

        if self_placement_name and self_placement_name.startswith('"') and self_placement_name.endswith('"'):
            self_placement_name = self_placement_name[1:-1]

like this, if self_placement_name is passed as ""Shivansh"" it'll turn into "Shivansh"

short snow Dec 2, 2021, 4:07 AM

#

yeah

#

and use all()

magic arch Dec 2, 2021, 4:09 AM

#

yeah just super rough code to test it first lol

#

actually looks like it might have to be ands, otherwise it doesn't check self_placement_name first

#

that arg can be none, None.startswith raises an error, etc

short snow Dec 2, 2021, 4:11 AM

#

yeah i was just writing that lol

#

and instead of .starswith/etc you could self_placement_name[0] == self_placement_name[-1] == '"'

magic arch Dec 2, 2021, 4:12 AM

#

ah true

#

just getting set up to add our staff lb in there so I have a two word name to actually test

short snow Dec 2, 2021, 4:13 AM

#

and shorten the var name ig lol

magic arch Dec 2, 2021, 4:15 AM

#

maybe, should we change that arg to just username maybe @thorny obsidian?

thorny obsidian Dec 2, 2021, 4:18 AM

#

magic arch maybe, should we change that arg to just `username` maybe <@!212644551926611969>...

yeah just call it username or aoc_name

short snow Dec 2, 2021, 4:19 AM

#

yeah aoc_name is okay also you could make it a single line if you are changing the name

fallen patrol Dec 2, 2021, 4:29 AM

#

left new review

magic arch Dec 2, 2021, 4:29 AM

#

also might go back to startswith/endswith for readability if its shorter now

fallen patrol Dec 2, 2021, 4:29 AM

#

there's also these two in the stdlib now https://docs.python.org/3/library/stdtypes.html?highlight=str#str.removeprefix

#

!d str.removeprefix

stable mountainBOT Dec 2, 2021, 4:29 AM

#

str.removeprefix


str.removeprefix(prefix, /)```
If the string starts with the *prefix* string, return `string[len(prefix):]`. Otherwise, return a copy of the original string:

```py
>>> 'TestHook'.removeprefix('Test')
'Hook'
>>> 'BaseTestCase'.removeprefix('Test')
'BaseTestCase'
```   New in version 3.9.

magic arch Dec 2, 2021, 4:30 AM

#

i think we just want to strip if they're at the start and end

fallen patrol Dec 2, 2021, 4:30 AM

#

👍

fallen patrol Dec 2, 2021, 6:54 AM

#

!remind 6H meta tag issue
crossref: #community-meta message

or make pr

stable mountainBOT Dec 2, 2021, 6:54 AM

#

Sure thing!

Your reminder will arrive on <t:1638449648:F>!

green oriole Dec 2, 2021, 7:39 AM

#

It was mostly a joke amegablobsweats but it is true I didn't run it locally because

I/we already tested it on chris' bot
Two people already approved, it just needed a final sign off to confirm that's the two staff reviews are good enough
The main thing is that I didn't know how d.py 2.0a0 views work so reviewing that is a bit tricky

short snow Dec 2, 2021, 10:05 AM

#

If I understand bot-core currently, we would probably move the extensions cog to bot-core right? Since it is something which is needed on both the bots

patent pivot Dec 2, 2021, 10:06 AM

#

yeah I suspect we'll move things like that across

#

I don't see a reason why we can't do something like https://jishaku.readthedocs.io/en/latest/cog.html though and just pass in a bot core module

short snow Dec 2, 2021, 10:06 AM

#

So even https://github.com/python-discord/sir-lancebot/pull/745 would be moved right?

patent pivot Dec 2, 2021, 10:07 AM

#

probably, yes

short snow Dec 2, 2021, 10:08 AM

#

ok 👍 Also if some coredev has got sometime, it needs another approval :D

vale ibex Dec 2, 2021, 11:35 AM

#

@vocal wolf @molten perch @brisk brook Pinging since you have approved/have open feedback on it.

I've pulled sir-lancebot#778 up to speed with main and added a commit on top to fix an issue I found during testing

dusky shoreBOT Dec 2, 2021, 11:35 AM

#

GitHub

PROpen Merge automatic issue linking into the github cog

vocal wolf Dec 2, 2021, 11:36 AM

#

you fixed stuff just now?

vale ibex Dec 2, 2021, 11:36 AM

#

yea

vocal wolf Dec 2, 2021, 11:36 AM

#

ah I see the force push

vale ibex Dec 2, 2021, 11:36 AM

#

the last commit

vocal wolf Dec 2, 2021, 11:36 AM

#

thought you meant a different pr lol

vale ibex Dec 2, 2021, 11:36 AM

#

Yea, force pushed to get it up to main

#

and resolve conflicts

vocal wolf Dec 2, 2021, 11:36 AM

#

roight

vale ibex Dec 2, 2021, 11:36 AM

#

the final commit I just added

vocal wolf Dec 2, 2021, 11:36 AM

#

wait I thought this PR was merged already

#

dang

vale ibex Dec 2, 2021, 11:37 AM

#

it should probably be tested again before merging

vocal wolf Dec 2, 2021, 11:37 AM

#

thanks for bringing it up to head

#

ye

vale ibex Dec 2, 2021, 11:37 AM

#

I've done some local testing but the merge conflicts were extensive

vocal wolf Dec 2, 2021, 11:38 AM

#

I will test after I wake

#

if it's not merged by then

vale ibex Dec 2, 2021, 11:38 AM

#

👌

vocal wolf Dec 2, 2021, 11:38 AM

#

oh right

vale ibex Dec 2, 2021, 11:38 AM

#

I'm gonna dismiss your review just incase another core dev clicks the shiny green button

vocal wolf Dec 2, 2021, 11:38 AM

#

!remind 10h thing #dev-contrib message

stable mountainBOT Dec 2, 2021, 11:38 AM

#

I got you.

Your reminder will arrive on <t:1638481109:F>!

vocal wolf Dec 2, 2021, 11:38 AM

#

vale ibex I'm gonna dismiss your review just incase another core dev clicks the shiny gree...

very well

brisk brook Dec 2, 2021, 11:42 AM

#

vale ibex <@!196664644113268736> <@!263957159807549450> <@!344404945359077377> Pinging sin...

Alrighty, I'll get to it after school

molten perch Dec 2, 2021, 11:47 AM

#

Oh yeah, sorry. When I approved this we were not gonna remove the issue command, and such. (And I was not even a staffer back then) I’ll check it out as soon as I can.

short snow Dec 2, 2021, 11:48 AM

#

Dorsan congrats on coredev btw

vale ibex Dec 2, 2021, 11:53 AM

#

molten perch Oh yeah, sorry. When I approved this we were not gonna remove the issue command,...

Nothing to be sorry about I just grabbed the names of people who approved it, since it was quite an old PR that needed rebasing onto main 😄

clever wraith Dec 2, 2021, 12:14 PM

#

Hello, first time im in this channel, just checked the !contributing and it brought me here. So anyone can add anything in the sir lancebot open-source project? Are there any requirements? I mean, if I'm allowed can I try to implement a user vs bot blackjack game.... ?

vale ibex Dec 2, 2021, 12:16 PM

#

The usual process is to create an issue on the github repo with as much information on what you want to make

#

Then we discuss it within the issue, until it gets appoved/denied

#

Once the issue is approved, we would then accept a PR that implements it

#

We advise you to wait until the PR is approved before starting work, since we don't want you to waste time building something that may be denied at some point

#

Of course, you can always look at the already open issues for things to work on too 😄

clever wraith Dec 2, 2021, 12:18 PM

#

vale ibex Once the issue is approved, we would then accept a PR that implements it

Sorry, what is PR?

vale ibex Dec 2, 2021, 12:19 PM

#

A pull request, it's a concept in most version control systems https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests

short snow Dec 2, 2021, 12:19 PM

#

github pull request, basically they are merge requests which you open to repositories to merge your "code" in theirs

vale ibex Dec 2, 2021, 12:19 PM

#

essentially you write the code, and then request maintainers of the main code to pull those changes into the source

short snow Dec 2, 2021, 12:19 PM

#

chris can you review a PR on lance ducky_wizard

vale ibex Dec 2, 2021, 12:20 PM

#

I've been slowly making my way through Github notifications, so feel free to request my review from github

#

unless it's a tiny PR that I can review quickly 😅

clever wraith Dec 2, 2021, 12:20 PM

#

vale ibex essentially you write the code, and then request maintainers of the main code to...

Ah I see, but I've checked a lot of the source codes in the bots, they import functions and other stuff I have no clue about, would an expert here help me with making the PR valid?

#

and when I mean import functions, its some custom stuff

vale ibex Dec 2, 2021, 12:21 PM

#

If you get an idea of what you want to implement, and it gets approved

#

then we can help you out with implementation details 😄

#

You can always ask here with any specific questions you have

clever wraith Dec 2, 2021, 12:22 PM

#

Okay, is there a link to where I can post an issue in the github? Also do you have like a template I can follow when describing what my idea is?

#

sorry if im being annoying

vale ibex Dec 2, 2021, 12:22 PM

#

.src

dusky shoreBOT Dec 2, 2021, 12:22 PM

#

Sir Lancebot's GitHub Repository

Repository

Go to GitHub

vale ibex Dec 2, 2021, 12:22 PM

#

!src

stable mountainBOT Dec 2, 2021, 12:22 PM

#

Bot's GitHub Repository

Repository

Go to GitHub

short snow Dec 2, 2021, 12:22 PM

#

https://github.com/python-discord/sir-lancebot/pull/745/files tiny PR 🙃

vale ibex Dec 2, 2021, 12:22 PM

#

on those repositories, go to the issue tab

#

I wouldn't call that tiny haha, quite intricate changes

clever wraith Dec 2, 2021, 12:23 PM

#

Thank you! 🙂

short snow Dec 2, 2021, 12:23 PM

#

clever wraith Okay, is there a link to where I can post an issue in the github? Also do you ha...

sir-lance has templates so if you want to open issues on bot you can probably just copy over the template

vale ibex Dec 2, 2021, 12:23 PM

#

I've added it to the list though

short snow Dec 2, 2021, 12:23 PM

#

it was already in the list lol

#

clever wraith Dec 2, 2021, 12:25 PM

#

Add user vs sir-lancebot games where people can enjoy some games :)

Idk if this counts as cheating, but am I allowed to ask if this would be a valid title for the issue? or do I need to be more specific?

vale ibex Dec 2, 2021, 12:25 PM

#

Yea, you need to be specific to what you want to add.

clever wraith Dec 2, 2021, 12:25 PM

#

What if I want to implement 2 games? Do I make 2 issues or the 2 games in 1 issue?

short snow Dec 2, 2021, 12:26 PM

#

2 different issues

#

since one could be approved whereas the second doesn't

#

and its easier understanding the discussion

clever wraith Dec 2, 2021, 12:27 PM

#

Alright thanks, what does proposal mean? Isn't it marriage?

#

It's in the template "description proposal"

short snow Dec 2, 2021, 12:28 PM

#

describe your proposal, describe what you are wanting to add to sir-lancebot

clever wraith Dec 2, 2021, 12:28 PM

#

Ohhhh sorry, okay thanks!

#

@short snow(sry for ping)

## Proposed Implementation
<!-- Detail any implementation you had in mind, including any screenshots if possible -->

I don't understand this one

short snow Dec 2, 2021, 12:35 PM

#

how would you want your suggesiton to be implemented, like if you are making a issue for a tic-tac-toe game then we could probably include how the board will be looking, will it be using buttons/reactions. How owuld the tic tac toe leaderboard work

clever wraith Dec 2, 2021, 12:35 PM

#

Oh okay, thanks

short snow Dec 2, 2021, 12:36 PM

#

if you are fine with anything/haven't planned anything yet you can jsut skip that seciton

#

its optional

clever wraith Dec 2, 2021, 12:36 PM

#

Oh alright

short snow Dec 2, 2021, 12:36 PM

#

just helps the contributor who would be assigned to that issue (if it gets approved) better understand the issue to get some insight of what the issue author is asking

stable mountainBOT Dec 2, 2021, 12:54 PM

#

fallen patrol !remind 6H meta tag issue crossref: https://discord.com/channels/267624335836053...

It has arrived!

Here's your reminder: meta tag issue
crossref: #community-meta message

or make pr
[Jump back to when you created the reminder](#dev-contrib message)

vale ibex Dec 2, 2021, 3:53 PM

#

!e @short snow ```py
my_optional_string = None
if my_optional_string and my_optional_string.startswith("a"):
print("something")

if all((my_optional_string, my_optional_string.startswith("a"))):
print("something else")

stable mountainBOT Dec 2, 2021, 3:54 PM

#

@vale ibex :x: Your eval job has completed with return code 1.

001 | Traceback (most recent call last):
002 |   File "<string>", line 5, in <module>
003 | AttributeError: 'NoneType' object has no attribute 'startswith'

short snow Dec 2, 2021, 3:54 PM

#

ah, thanks 👍 didn't know about that

vale ibex Dec 2, 2021, 3:55 PM

#

Yea I just ran into it a few weeks ago myself

short snow Dec 2, 2021, 3:55 PM

#

after looking it its understandable though

fallen patrol Dec 2, 2021, 3:55 PM

#

.... I just realised something

#

and and or always return something

#

thanks for coming to arl's realisations

vale ibex Dec 2, 2021, 3:56 PM

#

Almost everything returns something if you include None 😄

austere hornet Dec 2, 2021, 3:58 PM

#

vale ibex !e <@!736234578745884682> ```py my_optional_string = None if my_optional_string ...

For a second I thought you were evaling Shivansh's ID lmao

vale ibex Dec 2, 2021, 3:59 PM

#

hah

#

I do quite like that feature of the eval command

#

where it only evaluates code inside blocks if there are any

austere hornet Dec 2, 2021, 3:59 PM

#

vale ibex where it *only* evaluates code inside blocks if there are any

Ah I see

vale ibex Dec 2, 2021, 3:59 PM

#

!e py a = 5 like this ```py
print(a)

stable mountainBOT Dec 2, 2021, 3:59 PM

#

@vale ibex :white_check_mark: Your eval job has completed with return code 0.

thorny obsidian Dec 2, 2021, 3:59 PM

#

I love that you can eval across codeblocks

austere hornet Dec 2, 2021, 3:59 PM

#

Aha

thorny obsidian Dec 2, 2021, 4:00 PM

#

By far my favorite thing for illustrating points in help channels

vale ibex Dec 2, 2021, 4:00 PM

#

yupyup

austere hornet Dec 2, 2021, 4:00 PM

#

Mhm

fallen patrol Dec 2, 2021, 4:00 PM

#

thorny obsidian I *love* that you can eval across codeblocks

I'm definitely taking inspiration from python when i make a really good eval command for my bot lol

#

which i haven't written because I'm still trying to figure out the best way

vale ibex Dec 2, 2021, 4:01 PM

#

you could always fork snekbox and add additional language support 😛

#

while it may not be accepted as a PR upstream, it's a nice base to start from

fallen patrol Dec 2, 2021, 4:02 PM

#

vale ibex you could always fork snekbox and add additional language support 😛

👀 who told you

vale ibex Dec 2, 2021, 4:03 PM

#

lol I was thinking about doing it myself a few weeks back

#

Just didn't have time for another project 😄

fallen patrol Dec 2, 2021, 4:03 PM

#

I was trying to do it, but haven't recently

#

problem is the language I'm trying to add only works on windows, so I have to use wine

#

so far I just haven't sat down long enough to try and get it to work

short snow Dec 2, 2021, 4:04 PM

#

which language?

#

anyone else needs some reviews :D

clever wraith Dec 2, 2021, 4:20 PM

#

Hey @patent pivot, are the two worker PRs good to go?

#

they all got an approval

patent pivot Dec 2, 2021, 4:21 PM

#

has it actually been tested

#

how are you reading files in workers (for robots.txt)

thorny obsidian Dec 2, 2021, 4:30 PM

#

@short snow have you tested the .aoc link feature?

dusky shoreBOT Dec 2, 2021, 4:30 PM

#

GitHub

PROpen Make development workflow easier to use

clever wraith Dec 2, 2021, 4:38 PM

#

patent pivot how are you reading files in workers (for robots.txt)

Statically linked into the binary using include_dir

#

Hmm, didn't someone wanted to build upon it to serve standard files

#

I guess it can be done in a second PR

patent pivot Dec 2, 2021, 4:39 PM

#

might have been me with .well-known

short snow Dec 2, 2021, 4:40 PM

#

thorny obsidian <@!736234578745884682> have you tested the `.aoc link` feature?

nope, jsut code review as of now

patent pivot Dec 2, 2021, 4:40 PM

#

why don't we add the robots to django though out of interest

#

lol

thorny obsidian Dec 2, 2021, 4:40 PM

#

short snow nope, jsut code review as of now

some of your comments will likely be answered by testing locally

clever wraith Dec 2, 2021, 4:41 PM

#

patent pivot why don't we add the robots to django though out of interest

Because that worker can serve on any subdomain, like paste.pythondiscord.com

short snow Dec 2, 2021, 4:42 PM

#

probably just the one you commented on, anyways i am going to bed now, will look into that tomorrow

clever wraith Dec 2, 2021, 4:42 PM

#

https://github.com/python-discord/workers/pull/13

GitHub

Serve robots worker by Akarys42 · Pull Request #13 · python-discord...

This worker will be used to serve robots.txt files across our infrastructure.
The worker should be set on *pythondiscord.com/robots.txt. Each robot file is defined in the robots/ directory, the fil...

patent pivot Dec 2, 2021, 4:44 PM

#

clever wraith Because that worker can serve on any subdomain, like `paste.pythondiscord.com`

ya i'm just not sure how critical that is

clever wraith Dec 2, 2021, 4:44 PM

#

It isn't, but the PR is two months old heh

#

Or do you mean how important it is to serve robots.txt on other domains?

patent pivot Dec 2, 2021, 4:46 PM

#

on other domains

clever wraith Dec 2, 2021, 4:57 PM

#

Wasn't that discussed in #dev-ops?

#

Gah, review auto-dismissal is frustrating sometimes

patent pivot Dec 2, 2021, 5:03 PM

#

clever wraith Wasn't that discussed in #dev-ops?

maybe, can't remember

dusky shoreBOT Dec 2, 2021, 5:41 PM

#

GitHub

PROpen Make development workflow easier to use

patent pivot Dec 2, 2021, 5:45 PM

#

hold on all API work for now

#

we're talking about the future of the project, will discuss publicly in due course

magic arch Dec 2, 2021, 6:00 PM

#

Will make the suggested changes to my lance PR tonight when I’m home, thanks for reviews

fallen patrol Dec 2, 2021, 6:21 PM

#

hey can i pr a fix for https://github.com/python-discord/bot/blob/8408fb5686a7af43ee9ee9f8c192574e34a5f931/bot/constants.py#L694

stable mountainBOT Dec 2, 2021, 6:21 PM

#

bot/constants.py line 694

THREE_DAY = 4230```

timid sentinel Dec 2, 2021, 6:21 PM

#

where is it used?

fallen patrol Dec 2, 2021, 6:21 PM

#

https://github.com/python-discord/bot/blob/8408fb5686a7af43ee9ee9f8c192574e34a5f931/bot/constants.py#L691-L695

stable mountainBOT Dec 2, 2021, 6:21 PM

#

bot/constants.py lines 691 to 695

class ThreadArchiveTimes(Enum):
    HOUR = 60
    DAY = 1440
    THREE_DAY = 4230
    WEEK = 10080```

fallen patrol Dec 2, 2021, 6:21 PM

#

!e print(1440 * 3)

stable mountainBOT Dec 2, 2021, 6:21 PM

#

@fallen patrol :white_check_mark: Your eval job has completed with return code 0.

fallen patrol Dec 2, 2021, 6:22 PM

#

timid sentinel where is it used?

not sure, but its a typo

#

@clever wraith i think the reason its not day * 7 in the constant is because weird stuff happens with enums when that's done

timid sentinel Dec 2, 2021, 6:23 PM

#

not even sure ThreadArchiveTimes is used anywhere

fallen patrol Dec 2, 2021, 6:23 PM

#

Its probably worth keeping since thread support still hasn't been implemented or adopted by the server (in a public setting)

fiery sage Dec 2, 2021, 6:24 PM

#

I'd assume it's really not worth keeping with the Discord.py constant that apparently exists

clever wraith Dec 2, 2021, 6:27 PM

#

It is used

#

Look at the blame

#

I think it is used by the nomination thread system

#

I guess you want to rename to THREE_DAYS?

fallen patrol Dec 2, 2021, 6:28 PM

#

no, the math is wrong

clever wraith Dec 2, 2021, 6:28 PM

#

Three days is 4230 minutes though

fallen patrol Dec 2, 2021, 6:28 PM

#

someone entered 4230 when it should be 4320

clever wraith Dec 2, 2021, 6:28 PM

#

Oh right

fallen patrol Dec 2, 2021, 6:29 PM

#

clever wraith Three days is 4230 minutes though

... did you enter it ?

#

!e print(60 * 24)

stable mountainBOT Dec 2, 2021, 6:29 PM

#

@fallen patrol :white_check_mark: Your eval job has completed with return code 0.

clever wraith Dec 2, 2021, 6:29 PM

#

I didn't see the typo

#

That's probably worth a fix then, yes

#

You have ak's approval to PR directly, apparently

#

So have fun

fiery sage Dec 2, 2021, 6:30 PM

#

Unless I'm crazy, I don't see where this constant is used

#

other than the section right underneath where it's defined

fallen patrol Dec 2, 2021, 6:31 PM

#

bot#1986

dusky shoreBOT Dec 2, 2021, 6:31 PM

#

GitHub

PROpen set three_day to 4320, the number of minutes in 3 days

clever wraith Dec 2, 2021, 6:31 PM

#

https://github.com/python-discord/bot/blob/main/bot/exts/recruitment/talentpool/_review.py#L99

stable mountainBOT Dec 2, 2021, 6:31 PM

#

bot/exts/recruitment/talentpool/_review.py line 99

auto_archive_duration=DEFAULT_THREAD_ARCHIVE_TIME```

fallen patrol Dec 2, 2021, 6:32 PM

#

actually that line is not necessary anymore

#

one sec

#

ah

#

https://github.com/python-discord/bot/blob/8408fb5686a7af43ee9ee9f8c192574e34a5f931/bot/exts/recruitment/talentpool/_review.py#L18

stable mountainBOT Dec 2, 2021, 6:32 PM

#

bot/exts/recruitment/talentpool/_review.py line 18

from bot.constants import Channels, Colours, DEFAULT_THREAD_ARCHIVE_TIME, Emojis, Guild, Roles```

fallen patrol Dec 2, 2021, 6:32 PM

#

i mean

#

dpy naturally will use the default for the channel

#

https://github.com/Rapptz/discord.py/blob/4aafa39e8ca7fcdc7acd34295eed41bd3700d44b/discord/channel.py#L726-L733

stable mountainBOT Dec 2, 2021, 6:33 PM

#

discord/channel.py lines 726 to 733

if message is None:
    data = await self._state.http.start_thread_without_message(
        self.id,
        name=name,
        auto_archive_duration=auto_archive_duration or self.default_auto_archive_duration,
        type=type.value,
        reason=reason,
    )```

fallen patrol Dec 2, 2021, 6:33 PM

#

https://github.com/Rapptz/discord.py/blob/4aafa39e8ca7fcdc7acd34295eed41bd3700d44b/discord/channel.py#L196

stable mountainBOT Dec 2, 2021, 6:33 PM

#

discord/channel.py line 196

self.default_auto_archive_duration: ThreadArchiveDuration = data.get('default_auto_archive_duration', 1440)```

fallen patrol Dec 2, 2021, 6:34 PM

#

clever wraith https://github.com/python-discord/bot/blob/main/bot/exts/recruitment/talentpool/...

we can just cut that entirely

#

and instead, set it on the channel's themselves

fiery sage Dec 2, 2021, 6:34 PM

#

Are you able to change the default?

#

Currently it's at a week with the constant

fallen patrol Dec 2, 2021, 6:35 PM

#

fiery sage Are you able to change the default?

ye

fiery sage Dec 2, 2021, 6:35 PM

#

oh, I see

fallen patrol Dec 2, 2021, 6:35 PM

#

this is the default for the channel

fallen patrol Dec 2, 2021, 6:35 PM

#

fiery sage Currently it's at a week with the constant

honestly that's a bit dangerous lmao

#

if the server ever goes to level 2 boosting that feature will stop working

#

it shouldn't happen, but best to not plan on always having it

vale ibex Dec 2, 2021, 6:37 PM

#

It's there so that we can use the shorter times in dev

#

since dev guilds won't have nitro boosts

#

also, just an easily accessible enum of options

fiery sage Dec 2, 2021, 6:38 PM

#

I don't think that'd be a problem if the default is per-guild

#

I think essentially this solves a problem that doesn't really exist

vale ibex Dec 2, 2021, 6:39 PM

#

Is there a guild default?

#

I thought it was channel default?

fallen patrol Dec 2, 2021, 6:41 PM

#

vale ibex I thought it was channel default?

channel default is 24 h

#

the constant isn't necessary IMO, just change channel defaults to 1w

fallen patrol Dec 2, 2021, 6:44 PM

#

vale ibex I thought it was channel default?

er i mean, there's an indirect guild default of 24 h, since that's the default of the channel default

vale ibex Dec 2, 2021, 6:44 PM

#

Yea, I see your point about it breaking if we ever lose level 3 boosts

#

however unlikely that is to ever happen lol

#

Feel free to open another PR removing it, just make sure to update the reviewer cog that references them too 😄

fallen patrol Dec 2, 2021, 6:45 PM

#

but granted, it also means that it could break if discord changes: "You now need boost level four for threads"

vale ibex Dec 2, 2021, 6:45 PM

#

Yea

#

I feel like having the enum there isn't causing harm and could be useful for future

fallen patrol Dec 2, 2021, 6:45 PM

#

same

vale ibex Dec 2, 2021, 6:45 PM

#

since I imagine it would have been added to d.py regardless at some point

fallen patrol Dec 2, 2021, 6:46 PM

#

i'm about to open an issue on the fork i favour to add it

vale ibex Dec 2, 2021, 6:46 PM

#

Make sure not to include my typo

#

😄

fallen patrol Dec 2, 2021, 6:46 PM

#

lol

#

fwiw, @vale ibex, they aren't accurate anyways

#

if you set, eg 1h archive time on a thread, it could be 1 hour, 10 minutes

#

so the typo isn't that bad, but the api would complain

vale ibex Dec 2, 2021, 6:54 PM

#

hah good to know

fallen patrol Dec 2, 2021, 6:57 PM

#

erg, i've never set up bot

#

lol idk why i find this a bit funny

#

#

setting up the advanced thing is required for the intermediate thing

last patio Dec 2, 2021, 7:04 PM

#

well, setup difficulty isn't contribution difficulty

fallen patrol Dec 2, 2021, 7:04 PM

#

true

#

actually

#

i shouldn't have to start the bot to remove this constant

vale ibex Dec 2, 2021, 7:07 PM

#

fallen patrol setting up the advanced thing is required for the intermediate thing

If you use docker it's done for you 😄

fallen patrol Dec 2, 2021, 7:07 PM

#

I haven't gotten around to fixing my gpg problems so I can't right now

#

...wow I'm that lazy

#

@vale ibex making the pr, have you already changed the default of the channel to a week, or should i mention that needs to be done?

fallen patrol Dec 2, 2021, 7:12 PM

#

fallen patrol and instead, set it on the channel's themselves

(this thing, in channel settings)

vale ibex Dec 2, 2021, 7:13 PM

#

yea I can do that now

#

done 😄

fallen patrol Dec 2, 2021, 7:13 PM

#

sweet

#

bot#1987

dusky shoreBOT Dec 2, 2021, 7:13 PM

#

GitHub

PROpen remove default thread archive time

fallen patrol Dec 2, 2021, 7:15 PM

#

@patent pivot can you turn off the king arthur checks

patent pivot Dec 2, 2021, 7:16 PM

#

lol

#

should be a bit quieter now

fallen patrol Dec 2, 2021, 7:16 PM

#

thank you lol

vale ibex Dec 2, 2021, 7:16 PM

#

totally didn't discover that by trying to do arthur deployments redeploy snexbox

patent pivot Dec 2, 2021, 7:17 PM

#

wait what happens

#

arthur deploy redeploy ohno

radiant merlinBOT Dec 2, 2021, 7:17 PM

#

:x: Redeployment aborted

radiant merlinBOT Dec 2, 2021, 7:17 PM

#

radiant merlin :x: Redeployment aborted

:no_entry_sign: 'Tis but a scratch! Could not find deployment, check the namespace.

radiant merlinBOT Dec 2, 2021, 7:17 PM

#

radiant merlin :x: Redeployment aborted

:no_entry_sign: 'Tis but a scratch! Could not find deployment, check the namespace.

vale ibex Dec 2, 2021, 7:17 PM

#

it's fine

patent pivot Dec 2, 2021, 7:17 PM

#

amazing

vale ibex Dec 2, 2021, 7:17 PM

#

it just will never work, so no point allowing it to spam and click buttons again

patent pivot Dec 2, 2021, 7:17 PM

#

no it's a non-existing deployment

cold island Dec 2, 2021, 7:24 PM

#

@vale ibex so remind me, the first message in the cache is the earliest?

vale ibex Dec 2, 2021, 7:25 PM

#

yea

#

it's a fifo queue

cold island Dec 2, 2021, 7:26 PM

#

umm

#

yeah

#

ok

fallen patrol Dec 2, 2021, 7:28 PM

#

well i just learned about this

#

#

uh

#

why are there so many help channel prs?

#

nvm there's not that many

#

no, theres 3

#

sir-lancebot#953
this feels a bit overdone?
Like, I feel like help, ping, text commands, avatar, should continue to work in dms

dusky shoreBOT Dec 2, 2021, 7:37 PM

#

GitHub

PROpen Add Better Support For Whitelisting DM Commands

clever wraith Dec 2, 2021, 7:42 PM

#

The reasoning about forbidding DMs is that it can't be easily observated and moderated

fallen patrol Dec 2, 2021, 7:43 PM

#

I mean, does a help command have to be moderated??

#

and avatar commands?

#

serious question, btw

clever wraith Dec 2, 2021, 7:46 PM

#

Avatar commands, I think so

#

Help channels it is mostly for observability

#

But I'm not a core dev

cold island Dec 2, 2021, 7:56 PM

#

How do I show trace logs on the bot?

#

(in dev)

fallen patrol Dec 2, 2021, 7:57 PM

#

TRACE_LOGGERS

#

iirc

cold island Dec 2, 2021, 7:57 PM

#

BOT_TRACE_LOGGERS according to the bot guide which I wrote myself lol

fallen patrol Dec 2, 2021, 7:57 PM

#

https://github.com/python-discord/bot/blob/8408fb5686a7af43ee9ee9f8c192574e34a5f931/bot/constants.py#L197-L203

stable mountainBOT Dec 2, 2021, 7:57 PM

#

bot/constants.py lines 197 to 203

class Bot(metaclass=YAMLGetter):
    section = "bot"

    prefix: str
    sentry_dsn: Optional[str]
    token: str
    trace_loggers: Optional[str]```

fallen patrol Dec 2, 2021, 7:58 PM

#

bot:
  trace_loggers:

#

that too i think

#

just make a config system that doesn't care if its env or yaml 🤡

cold island Dec 2, 2021, 8:02 PM

#

stable mountain `bot/constants.py` lines 197 to 203 ```py class Bot(metaclass=YAMLGetter): s...

That's the bot constant, not what should be set in the env file

vale ibex Dec 2, 2021, 8:05 PM

#

Yea, it's BOT_TRACE_LOGGERS

#

It's a comma separated list of cog names

#

or, BOT_TRACE_LOGGERS=*

#

which I have in my env

fallen patrol Dec 2, 2021, 8:09 PM

#

vale ibex It's a comma separated list of cog names

its nice, I've been inspired by the idea and built on it for my own bot lol, although I might tone it down a bit

fervent sage Dec 2, 2021, 8:14 PM

#

Is there an open issue currently for adding a few discord.py forks to the docs command, I'd look but mobile

fallen patrol Dec 2, 2021, 8:14 PM

#

not that i know of uh i'll check for you

fervent sage Dec 2, 2021, 8:14 PM

#

Tyty

fallen patrol Dec 2, 2021, 8:14 PM

#

power moderator/shitposter of said forks smh

fervent sage Dec 2, 2021, 8:15 PM

#

Shhhh Kek

#

Its mainly because more people are asking about them now in discord-bots so being able to get up symbols is useful

fallen patrol Dec 2, 2021, 8:16 PM

#

fervent sage Is there an open issue currently for adding a few discord.py forks to the docs c...

i don't see any open on bot or meta

fallen patrol Dec 2, 2021, 8:17 PM

#

fervent sage Its mainly because more people are asking about them now in discord-bots so bein...

well, the problem is namespacing, i think. Not sure if all of the forks changed from the discord namespace

fervent sage Dec 2, 2021, 8:17 PM

#

Yeah that's my concern

#

The only one I'm positive won't break anything is disnake

#

Since the shim is optional

fallen patrol Dec 2, 2021, 8:17 PM

#

and dislash

fervent sage Dec 2, 2021, 8:17 PM

#

Dislash is an extension for dpy rather than a dork

#

Fork

fallen patrol Dec 2, 2021, 8:17 PM

#

fervent sage Since the shim is optional

actually they even recommend to not use the shim

fervent sage Dec 2, 2021, 8:17 PM

#

Lol dork

#

Yeah the shim ain't really great

fallen patrol Dec 2, 2021, 8:18 PM

#

is there really a good way to make a shim?

fervent sage Dec 2, 2021, 8:18 PM

#

I can probably make nextcord releases that don't have the shim too

fallen patrol Dec 2, 2021, 8:19 PM

#

can I dm you?

fervent sage Dec 2, 2021, 8:19 PM

#

fallen patrol is there really a good way to make a shim?

Nextcords method is fairly solid iirc (I didn't touch it so idk) but the main issue is interference

fallen patrol Dec 2, 2021, 8:19 PM

#

I have some fork info that I don't want to share here

fervent sage Dec 2, 2021, 8:19 PM

#

Sure

fallen patrol Dec 2, 2021, 8:42 PM

#

bot#1988

dusky shoreBOT Dec 2, 2021, 8:42 PM

#

GitHub

IssueOpen Add more Discord libs to !docs

cold island Dec 2, 2021, 8:49 PM

#

Might move it to meta

fervent sage Dec 2, 2021, 8:49 PM

#

cold island Might move it to meta

Sounds good

stable mountainBOT Dec 2, 2021, 9:38 PM

#

vocal wolf !remind 10h thing https://canary.discord.com/channels/267624335836053506/6359505...

It has arrived!

Here's your reminder: thing #dev-contrib message
[Jump back to when you created the reminder](#dev-contrib message)

fallen patrol Dec 2, 2021, 9:43 PM

#

vale ibex <@!196664644113268736> <@!263957159807549450> <@!344404945359077377> Pinging sin...

hey you left me off of that, I reviewed too!

vale ibex Dec 2, 2021, 9:46 PM

#

fallen patrol hey you left me off of that, I reviewed too!

I only tagged people who approved or had open comments

#

there were a few others who reviewed too

#

(The first sentence of the message you linked)

brisk brook Dec 2, 2021, 9:52 PM

#

@gritty wind why is it better that the __init__ silently fails rather than error (such as when you're developing).

gritty wind Dec 2, 2021, 9:52 PM

#

No that's the thing, the way I did it it won't silently fail

#

I'm saying if we did it some other way, it would

brisk brook Dec 2, 2021, 9:53 PM

#

Ah, I see.

fallen patrol Dec 2, 2021, 10:06 PM

#

ah I'll review it

#

hmmm

fallen patrol Dec 2, 2021, 10:14 PM

#

vale ibex <@!196664644113268736> <@!263957159807549450> <@!344404945359077377> Pinging sin...

should this be moved to @stable mountain?

fallen patrol Dec 2, 2021, 10:15 PM

#

stable mountain `bot/constants.py` lines 197 to 203 ```py class Bot(metaclass=YAMLGetter): s...

reason: merging the autolink feature with that as well

#

clearly this pr should be merged, but after that, maybe it belongs on python

#

oof, sorry, I will have a lot of suggested changes

gritty wind Dec 2, 2021, 10:35 PM

#

brisk brook Ah, I see.

Hey do you have any more questions/suggestions or are we good to merge

fallen patrol Dec 2, 2021, 10:35 PM

#

which pr?

brisk brook Dec 2, 2021, 10:36 PM

#

gritty wind Hey do you have any more questions/suggestions or are we good to merge

No I don't really see anything wrong but I was planning on attempting to build the documentation locally once.

gritty wind Dec 2, 2021, 10:37 PM

#

No rush then

fallen patrol Dec 2, 2021, 10:37 PM

#

ah, botcore 😔

gritty wind Dec 2, 2021, 10:37 PM

#

I just woke up a few hours ago, so I'll probably be around to merge it all day lol

#

Yup

fallen patrol Dec 2, 2021, 10:37 PM

#

ugh i'd love to help with that

#

saw you're using sphinx with the furo theme, nice

brisk brook Dec 2, 2021, 10:38 PM

#

gritty wind I just woke up a few hours ago, so I'll probably be around to merge it all day l...

Oh, well I am going to bed now 😅

#

So this was a "do tomorrow" kind of thing

magic arch Dec 2, 2021, 10:38 PM

#

@short snow hey, addressed your review in sir-lancebot#963 (and thanks @/arl)

gritty wind Dec 2, 2021, 10:38 PM

#

That's alright lol

dusky shoreBOT Dec 2, 2021, 10:38 PM

#

GitHub

PROpen Make self_placement_name keyword-only in .aoc lb

fallen patrol Dec 2, 2021, 10:39 PM

#

magic arch <@!736234578745884682> hey, addressed your review in sir-lancebot#963 (and thank...

i have nothing better to do 🤷‍♀️

magic arch Dec 2, 2021, 10:39 PM

#

fallen patrol i have nothing better to do 🤷‍♀️

yeah that was fast 🤣

brisk brook Dec 2, 2021, 10:39 PM

#

gritty wind That's alright lol

Were you hoping to merge it soon?

I could take one last look (especially on the Sphinx configuration file and GitHub actions) and see if I can spot anything. (and have you merge it afterward).

gritty wind Dec 2, 2021, 10:40 PM

#

Yes, but this isn't exactly a critical PR we can merge it later

#

Go sleep :bonk:

brisk brook Dec 2, 2021, 10:40 PM

#

Thanks lol

magic arch Dec 2, 2021, 10:41 PM

#

dusky shore

^ heya scaleios if you want a quick pr to review btw 😂

#

niceee ty

gritty wind Dec 2, 2021, 10:43 PM

#

Wanna squash it or just merge

magic arch Dec 2, 2021, 10:44 PM

#

eh up to you, i have no opinion there tbh

gritty wind Dec 2, 2021, 10:44 PM

#

Cool cool cool

magic arch Dec 2, 2021, 10:45 PM

#

awesomeee ty

gritty wind Dec 2, 2021, 10:45 PM

#

.aoc_leaderboard Hassan Abouelela

magic arch Dec 2, 2021, 10:46 PM

#

mm not reconnected yet

gritty wind Dec 2, 2021, 10:46 PM

#

Channel

#

It should've still worked off the old bot

fallen patrol Dec 2, 2021, 10:46 PM

#

.aoc_leaderboard

magic arch Dec 2, 2021, 10:46 PM

#

oh it's no _

fallen patrol Dec 2, 2021, 10:46 PM

#

not sure its a command

#

.aoc lb

magic arch Dec 2, 2021, 10:46 PM

#

wait now it's up

fallen patrol Dec 2, 2021, 10:46 PM

#

the few seconds while lance was down lmfao

gritty wind Dec 2, 2021, 10:46 PM

#

#bot-commands

dusky shoreBOT Dec 2, 2021, 10:46 PM

#

:x: Please use #aoc-bot-commands for aoc commands instead.

fallen patrol Dec 2, 2021, 10:47 PM

#

gritty wind <#267659945086812160>

lance does not agree with you 😂

magic arch Dec 2, 2021, 10:47 PM

#

awesome all working

gritty wind Dec 2, 2021, 10:47 PM

#

Good reminder to go do by aoc too

vale ibex Dec 2, 2021, 10:48 PM

#

cough cough sir-lancebot#960

dusky shoreBOT Dec 2, 2021, 10:48 PM

#

GitHub

PROpen Redirect aoc commands

fallen patrol Dec 2, 2021, 10:48 PM

#

vale ibex cough cough sir-lancebot#960

cough make me a contrib or helper and my review would count /s

vale ibex Dec 2, 2021, 10:49 PM

#

actually, thinking of it, this isn't going to affect the leaderboard command anyway

fallen patrol Dec 2, 2021, 10:50 PM

#

lol i'm only on line 100 of the first file of lance#778 with 7 comments already

#

sorry for the work

thorny obsidian Dec 2, 2021, 10:51 PM

#

vale ibex actually, thinking of it, this isn't going to affect the leaderboard command any...

.aoc lb is already restricted to like... 3 channels if that

vale ibex Dec 2, 2021, 10:51 PM

#

Yea, I realised lb isn't actually a command that is allowed outside and would be redirected 😄

thorny obsidian Dec 2, 2021, 10:51 PM

#

I can review that as soon as I finish this sticker

vale ibex Dec 2, 2021, 10:51 PM

#

the PR only affects the ones that could be ran in #advent-of-code

#

oooo sticker 👀

#

I hope it's as artistic as this one

austere hornet Dec 2, 2021, 10:52 PM

#

vale ibex

Lmao

thorny obsidian Dec 2, 2021, 10:52 PM

#

vale ibex

that was so fucking funny, even out of context

vale ibex Dec 2, 2021, 10:52 PM

#

lol yea

#

ducky_drawing

austere hornet Dec 2, 2021, 10:55 PM

#

This is probably not the right channel for this, but @thorny obsidian I noticed that you have the "Partner: r/Python" role but not "Partners". Is it supposed to be like that?

fallen patrol Dec 2, 2021, 10:55 PM

#

.....github that is dumb

austere hornet Dec 2, 2021, 10:55 PM

#

Lmfao

fallen patrol Dec 2, 2021, 10:56 PM

#

what just happened

thorny obsidian Dec 2, 2021, 10:56 PM

#

austere hornet This is probably not the right channel for this, but <@212644551926611969> I not...

I'unno ask @patent pivot, he's the one who gave me the roles

patent pivot Dec 2, 2021, 10:56 PM

#

oh lol

#

im moron

#

pleadbless

austere hornet Dec 2, 2021, 10:56 PM

#

Lmfao

fallen patrol Dec 2, 2021, 10:56 PM

#

fallen patrol what just happened

....uh lance

thorny obsidian Dec 2, 2021, 10:56 PM

#

patent pivot im moron

lmfao, tbf I didn't notice

fallen patrol Dec 2, 2021, 10:56 PM

#

that is a help command or error handler bug

thorny obsidian Dec 2, 2021, 10:57 PM

#

I saw that I had access to the correct channels and didn't even bother to verify

austere hornet Dec 2, 2021, 10:57 PM

#

fallen patrol what just happened

You used .....github in an unauthorized channel, which not even a valid command

fallen patrol Dec 2, 2021, 10:57 PM

#

yeah

austere hornet Dec 2, 2021, 10:58 PM

#

.github is though

fallen patrol Dec 2, 2021, 10:58 PM

#

@patent pivot are you at the pub again lmao

#

because i saw that in the channel list with #dev-announcements

fallen patrol Dec 2, 2021, 10:59 PM

#

fallen patrol .....github that is dumb

anyways, the thing is that /repos/{org}/{repo}/issues/{num} provided a pull request works
/repos/{org}/{repo}/pulls/{num} provided an issue does not work

patent pivot Dec 2, 2021, 11:00 PM

#

fallen patrol <@!165023948638126080> are you at the pub again lmao

no?

#

lol

fallen patrol Dec 2, 2021, 11:00 PM

#

Note: GitHub's REST API v3 considers every pull request an issue, but not every issue is a pull request. For this reason, "Issues" endpoints may return both issues and pull requests in the response.

trail pilot Dec 2, 2021, 11:16 PM

#

vale ibex

ducky_drawing

austere hornet Dec 2, 2021, 11:22 PM

#

trail pilot <:ducky_drawing:912087610527207455>

Do only staff members have access to that emoji?

trail pilot Dec 2, 2021, 11:23 PM

#

austere hornet Do only staff members have access to that emoji?

Nope, anyone can use it!

#

i think

austere hornet Dec 2, 2021, 11:23 PM

#

ducky_drawing

#

ah ok

static canyon Dec 2, 2021, 11:23 PM

#

Anyone can use it here, people with nitro can use it in any discord server

austere hornet Dec 2, 2021, 11:23 PM

#

static canyon Anyone can use it here, people with nitro can use it in any discord server

Gotcha

static canyon Dec 2, 2021, 11:23 PM

#

Same applies for all our custom emotes (that's how they work on discord)

fallen patrol Dec 2, 2021, 11:49 PM

#

ooh sweet i found a place which can cut down a request on github autolinking

#

this will half the requests made to github by @dusky shore when running pull autolinking

#

...oh wait, it doesn't provide draft info. darn.

#

ooh yes it does!

#

@vale ibex i left a review on sir-lancebot#778, found a place where two requests are used, except all of the data is supplied in the first request

dusky shoreBOT Dec 3, 2021, 12:16 AM

#

GitHub

PROpen Merge automatic issue linking into the github cog

fallen patrol Dec 3, 2021, 12:16 AM

#

so instead of lance making two requests per pr, only one request is needed

#

I also left an implementation example

#

uh

#

@gritty wind... it actually does count? https://policy-bot.pythondiscord.com/details/python-discord/bot/1990

#

gritty wind Dec 3, 2021, 12:30 AM

#

Yeah I saw

#

No idea

fallen patrol Dec 3, 2021, 12:33 AM

#

lol

fallen patrol Dec 3, 2021, 1:30 AM

#

@brisk brook did you actually run sir-lancebot#745

dusky shoreBOT Dec 3, 2021, 1:30 AM

#

GitHub

PROpen Add logic for preserving unloaded Cogs.

short snow Dec 3, 2021, 1:45 AM

#

When we are waiting for the guild to be available there isn;t a need to fetch channels right? Since the cache would already be updated and would contain the channel

#

uhhh

thorny obsidian Dec 3, 2021, 1:59 AM

#

re-pull the image and re-build

short snow Dec 3, 2021, 2:01 AM

#

i rebuilt the venv, but why did that happen?

#

Kat, removing it works (commented on github-)

fallen patrol Dec 3, 2021, 2:08 AM

#

yummy reviews

#

@thorny obsidian and @hoary haven ~~I feel like you would know~~
I'm reviewing the patron pr rn and am wondering, should it be prepared for members to have multiple patreon roles?

thorny obsidian Dec 3, 2021, 2:15 AM

#

fallen patrol <@!212644551926611969> and <@!568276116062863405> ~~I feel like you would know~~...

It just needs to select the highest. The multiple patreon roles is only really a thing when a user goes from one tier to another within the same month iirc

hoary haven Dec 3, 2021, 2:15 AM

#

yeah basically what kat said

fallen patrol Dec 3, 2021, 2:15 AM

#

well, it would be on the first of each month when it would be a problem

#

since the first of each month is when the info embed is sent to #community-meta

hoary haven Dec 3, 2021, 2:15 AM

#

i tried to reproduce it but couldn't get it to work (bc it was during a month where i already had the highest role i think)

fallen patrol Dec 3, 2021, 2:15 AM

#

bot#1917 btw

dusky shoreBOT Dec 3, 2021, 2:15 AM

#

GitHub

PROpen Patreon

thorny obsidian Dec 3, 2021, 2:16 AM

#

first of each month should be fine because patreon should resolve it and remove one of the roles

hoary haven Dec 3, 2021, 2:16 AM

#

i think when the 1st of the month came, my lower tier role went away

thorny obsidian Dec 3, 2021, 2:16 AM

#

The only hellish race condition I could think of is if a person like... somehow upgraded during the patreon integration update? maybe?

thorny obsidian Dec 3, 2021, 2:18 AM

#

short snow Kat, removing it works (commented on github-)

huh, I accidentally refactored that problem away. I'll take that as an accidental victory. I'll update the PR in a bit when I finish this next part of my project

magic arch Dec 3, 2021, 2:34 AM

#

short snow uhhh

(off-topic here but we use the same shell/theme and I love it)

fallen patrol Dec 3, 2021, 2:34 AM

#

jeez, i should take a break

#

i've reviewed half of lance's and bot's open prs today

#

er, more than half

#

well time to look at site

fallen patrol Dec 3, 2021, 3:08 AM

#

inb4 kronifer asks for reviews

clever wraith Dec 3, 2021, 3:09 AM

#

@vale ibex and @molten perch, as you both have reviewed bot#1889 i should probably let both of you know that it has been updated to use tldextract

dusky shoreBOT Dec 3, 2021, 3:09 AM

#

GitHub

PROpen feat: added url parsing to the filter

clever wraith Dec 3, 2021, 3:09 AM

#

fallen patrol inb4 kronifer asks for reviews

screw you arl

fallen patrol Dec 3, 2021, 3:09 AM

#

lol

fallen patrol Dec 3, 2021, 3:09 AM

#

clever wraith <@!126811506632294400> and <@!263957159807549450>, as you both have reviewed bot...

checks failed 👀

clever wraith Dec 3, 2021, 3:10 AM

#

fallen patrol checks failed 👀

https://github.com/python-discord/bot/runs/4403684494?check_suite_focus=true shush

GitHub

chore: removed unused import · python-discord/bot@dbd77e3

The community bot for the Python Discord community - chore: removed unused import · python-discord/bot@dbd77e3

fallen patrol Dec 3, 2021, 3:10 AM

#

ah, i see now

fallen patrol Dec 3, 2021, 3:11 AM

#

clever wraith screw you arl

anyways, reviewing

#

@clever wraith why be sorry lol

clever wraith Dec 3, 2021, 3:13 AM

#

idk i just feel like its gonna be an annoying thing to review

#

i havent contributed in a month ok im out of the loop

fallen patrol Dec 3, 2021, 3:13 AM

#

lol

#

I uh

#

I have reviewed 20+ prs today so

clever wraith Dec 3, 2021, 3:17 AM

#

wow

short snow Dec 3, 2021, 3:18 AM

#

and they were at the hospital yesterday

fallen patrol Dec 3, 2021, 3:23 AM

#

clever wraith idk i just feel like its gonna be an annoying thing to review

eh, everyone makes that mistake

#

(the one i left instructions on how to fix)

#

because i have seen it so much, even to go as far to do it myself

#

i- I'll put it this way

#

that's happened so much, I have a taskipy task.

gritty wind Dec 3, 2021, 3:27 AM

#

There is really no problem with bumping all deps in that PR tbh

#

We modify them so rarely, and we don't have any alerts to keep us up to date

fallen patrol Dec 3, 2021, 3:27 AM

#

redis got bumped to 4.0.0

gritty wind Dec 3, 2021, 3:27 AM

#

If they work, might as well

#

So....?

#

Is it broken

fallen patrol Dec 3, 2021, 3:27 AM

#

not sure, I was investigating the changelogs

gritty wind Dec 3, 2021, 3:28 AM

#

I see only one breaking change, and it doesn't impact us

clever wraith Dec 3, 2021, 3:30 AM

#

fallen patrol that's happened so much, I have a taskipy task.

lmao

#

oh is my pr gonna mess things up?

fallen patrol Dec 3, 2021, 3:32 AM

#

its what i said about the poetry lock updates

#

but it might not be a problem, from what scale is saying

fallen patrol Dec 3, 2021, 3:32 AM

#

gritty wind I see only one breaking change, and it doesn't impact us

there's one minor change with rapidfuzz which may cause different results, but nothing major

#

tldr rapidfuzz wasn't computing a fuzz properly and now it does

brisk brook Dec 3, 2021, 4:25 AM

#

fallen patrol <@!344404945359077377> did you actually run sir-lancebot#745

Yeah?

fallen patrol Dec 3, 2021, 4:25 AM

#

nvm, I had missed an obvious line of code

#

I wrote up a whole thing on how there was discrepancies between coros and non-coros

#

then noticed its taken care of with an if action is load await else..

fallen patrol Dec 3, 2021, 7:16 AM

#

would someone drop a sanitised summary of why commands can't be ran in dms?

#

(cont from #community-meta)

green oriole Dec 3, 2021, 7:16 AM

#

peepoArrive

#

so yeah, the two reasons is we want to have information if the command fails, and be able to moderate the result

fallen patrol Dec 3, 2021, 7:17 AM

#

Well, for some commands I get that

#

for others, not so much

green oriole Dec 3, 2021, 7:18 AM

#

that's why I think !user would be fine to allow

#

although I would like to make it clear that if we allow it it is because it will have another purpose in DMs

gritty wind Dec 3, 2021, 7:18 AM

#

My reasoning is partly because of the debugging stuff, but also because running stuff in DMs means we have much less control over what's happening with the bot. We can't as easily figure out what's happening, and why. If something starts breaking because someone found a loophole, we have no way of dealing with it

#

But I really don't think being able to run this command in DMs is that much of a benefit

fallen patrol Dec 3, 2021, 7:18 AM

#

green oriole that's why I think `!user` would be fine to allow

and actually, allowing user in dms brings some other issues, which are more implementation details. Specifically, the author would be a user obj instead of member obj

gritty wind Dec 3, 2021, 7:19 AM

#

We can still just add it as an option on discord

green oriole Dec 3, 2021, 7:19 AM

#

we do have stuff like battleship running in DMs

fallen patrol Dec 3, 2021, 7:19 AM

#

hrmmmm, compromise?

gritty wind Dec 3, 2021, 7:19 AM

#

Yes, but only for the game itself, and even then, not a fan

green oriole Dec 3, 2021, 7:19 AM

#

fallen patrol and actually, allowing user in dms brings some other issues, which are more impl...

that's fine, we have the guild ID

gritty wind Dec 3, 2021, 7:19 AM

#

!u infractions for instance could DM you

fallen patrol Dec 3, 2021, 7:19 AM

#

remove the infraction info from !user for non-staff

#

and then do what scale just said before me

gritty wind Dec 3, 2021, 7:19 AM

#

That way we get the DMs aspect, without having to accept commands from DMs

fallen patrol Dec 3, 2021, 7:19 AM

#

in other news scale and I tend to think on the same page, apparently

green oriole Dec 3, 2021, 7:20 AM

#

gritty wind `!u infractions` for instance could DM you

that's a good compromise, I was thinking about that

fallen patrol Dec 3, 2021, 7:20 AM

#

😂

gritty wind Dec 3, 2021, 7:20 AM

#

I mean, I've been saying it here and #community-meta for like 10 messages >.>

green oriole Dec 3, 2021, 7:20 AM

#

yup

fallen patrol Dec 3, 2021, 7:20 AM

#

i didn't see you say making a subcommand

gritty wind Dec 3, 2021, 7:20 AM

#

I guess we could make it an option but eh

fallen patrol Dec 3, 2021, 7:21 AM

#

that wasn't clear to me 😓

#

I thought you were talking about making dm vs not dm an option

#

huh if it becomes a subcommand, it can become a bit more detailed with infraction information, if y'all want that

gritty wind Dec 3, 2021, 7:22 AM

#

Do you mean like seeing the specific infractions?

#

We did discuss specifically allowing that in the mod team before

fallen patrol Dec 3, 2021, 7:22 AM

#

or summaries

gritty wind Dec 3, 2021, 7:22 AM

#

Let me see where that weant

fallen patrol Dec 3, 2021, 7:22 AM

#

Its not like I have 8 infractions or anything ~~plus a few notes~~

gritty wind Dec 3, 2021, 7:23 AM

#

Actually, now I remember

fallen patrol Dec 3, 2021, 7:23 AM

#

its also not like I know exactly what they all are already including at least one of my notes

gritty wind Dec 3, 2021, 7:23 AM

#

There are specific limitations that mean we can't send any past infraction text

#

Maybe infraction type, but that's as far as we can go

fallen patrol Dec 3, 2021, 7:23 AM

#

limitation as?

gritty wind Dec 3, 2021, 7:23 AM

#

We usually edit the infractions afterwards with information intended for the mod-team

fallen patrol Dec 3, 2021, 7:23 AM

#

ahhhh

#

although the resend dm feature is in a pr right now

gritty wind Dec 3, 2021, 7:24 AM

#

Since we don't store edits, we have no way of automatically going back to the original

green oriole Dec 3, 2021, 7:24 AM

#

I wouldn't mind changing the detail infraction per infraction

gritty wind Dec 3, 2021, 7:24 AM

#

!note @green oriole test

stable mountainBOT Dec 3, 2021, 7:24 AM

#

:ok_hand: applied note to @green oriole.

gritty wind Dec 3, 2021, 7:24 AM

#

I was hoping for an infrac number

fallen patrol Dec 3, 2021, 7:24 AM

#

just warn him then

green oriole Dec 3, 2021, 7:24 AM

#

I mean it is gonna be 100

gritty wind Dec 3, 2021, 7:24 AM

#

56171

#

we can't filter them by hand

green oriole Dec 3, 2021, 7:24 AM

#

oh, ID

fallen patrol Dec 3, 2021, 7:25 AM

#

oh shit i gotta go sleep

gritty wind Dec 3, 2021, 7:25 AM

#

If we wanted to send the reasons in DMs in the future, we can start now recording the original message

#

But we can't make it retroactive

green oriole Dec 3, 2021, 7:25 AM

#

Showing like

Your total infractions:
Mutes: 24 (1 active)
Superstars: 1
Voice_bans: 6
Warnings: 49
doesn't sound so bad

#

that's what is on the mod embed, without shadow infracs

gritty wind Dec 3, 2021, 7:25 AM

#

Yes, that's fine if we want to do it

fallen patrol Dec 3, 2021, 7:25 AM

#

yeah I figured

green oriole Dec 3, 2021, 7:26 AM

#

that's my infraction count if you are wondering

fallen patrol Dec 3, 2021, 7:26 AM

#

Superstars: 1
wait how many of these do I have?

#

I think only one, but eivl might have done a second one too

fallen patrol Dec 3, 2021, 7:27 AM

#

green oriole that's my infraction count if you are wondering

i was half thinking it was either yours or fake data

green oriole Dec 3, 2021, 7:27 AM

#

do I look fake to you? lemon_sentimental

fallen patrol Dec 3, 2021, 7:27 AM

#

no

gritty wind Dec 3, 2021, 7:28 AM

#

green oriole do I look fake to you? <:lemon_sentimental:843396743541293056>

Count from [0:101:10]

#

That's the only true way to identify who's on the other side

green oriole Dec 3, 2021, 7:29 AM

#

wat

#

is that a python range notation

gritty wind Dec 3, 2021, 7:29 AM

#

This is a python server after all

fallen patrol Dec 3, 2021, 7:30 AM

#

green oriole is that a python range notation

no, never has been

#

that's python slice notation

green oriole Dec 3, 2021, 7:30 AM

#

gritty wind Count from [0:101:10]

0, 10, 20, 30, 40, 50, 60, 70, 80, 90, 100

fallen patrol Dec 3, 2021, 7:30 AM

#

sorry, had to be pydantic 👀

green oriole Dec 3, 2021, 7:30 AM

#

have I passed your captcha?

gritty wind Dec 3, 2021, 7:31 AM

#

Faaaake, a true frenchman would break out the calculator and a notebook for this

#

Though I suppose you're more italian

#

Conclusion: uncertain, need more tests

green oriole Dec 3, 2021, 7:32 AM

#

akarys_pensive

clever wraith Dec 3, 2021, 8:53 AM

#

how long would it take until my issue is answered, looking in #dev-log others get answered very quick

#

ah okay, also one more question, i saw in the topic above us, what is a superstar?

clever wraith Dec 3, 2021, 8:58 AM

#

green oriole Showing like > Your total infractions: > Mutes: 24 (1 active) > Superstars: 1 > ...

^^

short snow Dec 3, 2021, 9:01 AM

#

IIRC its when someone has a inappropriate name and moderators force a discord nickname to them which they can't change for a certain while (taking away their nickname change permission)

clever wraith Dec 3, 2021, 9:04 AM

#

ahh alr

#

Ah also, if my issue is accepted, and i make a code for the bot do i get the contribute role?

#

what does substantial mean

brisk brook Dec 3, 2021, 9:28 AM

#

clever wraith what does substantial mean

It means several contributions over time, you don't get it over one.

static canyon Dec 3, 2021, 9:28 AM

#

brisk brook It means several contributions over time, you don't get it over one.

Eh, not exactly

#

If that one contribution was really big, then you could get it for just that

#

But generally speaking, yes

brisk brook Dec 3, 2021, 9:29 AM

#

Think of it similar to the helper role, you don't get it for helping one person once 😅

static canyon Dec 3, 2021, 9:29 AM

#

clever wraith what does substantial mean

It's deliberately left open-ended so that it's at the discretion of the core dev team, rather than people saying "I've submitted X PRs so give me contributor"

brisk brook Dec 3, 2021, 9:30 AM

#

static canyon If that one contribution was really big, then you could get it for just that

Sure if someone built the entire API in a PR maybe, but even then I would count that as many contributions (many added features).

static canyon Dec 3, 2021, 9:31 AM

#

brisk brook Sure if someone built the entire API in a PR maybe, but even then I would count ...

Yeah, true.

dusky shoreBOT Dec 3, 2021, 9:32 AM

#

GitHub

PROpen Make development workflow easier to use

clever wraith Dec 3, 2021, 9:32 AM

#

brisk brook Sure if someone built the entire API in a PR maybe, but even then I would count ...

I wanna make a whole game system for Sir Lancebot, it would need me to add like 4-5 games and a main file off if it gets approved

gritty wind Dec 3, 2021, 9:35 AM

#

No, it's dead

#

So ig you really don't want reviews on that

gritty wind Dec 3, 2021, 9:36 AM

#

clever wraith I wanna make a whole game system for Sir Lancebot, it would need me to add like ...

What do you have in mind for a "game system"? We already have a ton of games, so I guess we kinda already have a system?

brisk brook Dec 3, 2021, 9:36 AM

#

clever wraith I wanna make a whole game system for Sir Lancebot, it would need me to add like ...

That's cool, I am not a core dev - so I am not one to say whether you get the contributor role from that. You'll just have to see afterwards.

short snow Dec 3, 2021, 9:36 AM

#

gritty wind No, it's dead

dead?

clever wraith Dec 3, 2021, 9:37 AM

#

brisk brook That's cool, I am not a core dev - so I am not one to say whether you get the co...

Yeah I just wish it gets acceptes, it will be my first contribute ever in my life and first time i actually work with github, it would be a great experience and ngl i look forward for it 🙂

gritty wind Dec 3, 2021, 9:37 AM

#

We are not going to be continuing it, though an official announcement has not been made

clever wraith Dec 3, 2021, 9:39 AM

#

gritty wind What do you have in mind for a "game system"? We already have a ton of games, so...

uh im on my phone its har to write mich but like i wanna make a blackjack game, battle ship game, the 4 in row (idk what its called) and a few other games where players can play against each other, each win gives you x amount of chips and these chips can let you upgrade stuff like ”15% chip booster” and similar stuff

#

im bad at explainign whats in my mind but i wanna try to do this

gritty wind Dec 3, 2021, 9:39 AM

#

Hmm, well we can take it one step at a time, the store system, and the games aren't necessarily dependent on each other

#

The whole store thing sounds like a hard sell though

clever wraith Dec 3, 2021, 9:40 AM

#

whats a hard sell?

#

sry

gritty wind Dec 3, 2021, 9:40 AM

#

Like the whole chips, and being able to upgrade and what not

#

It's not a small thing, and I don't know if we want something like that or not

#

You can open an issue for it, though I'm not sure how I feel about it

clever wraith Dec 3, 2021, 9:41 AM

#

oh okay maybe the games can be accepted though? i did already do a issue yesterday, still waiting

gritty wind Dec 3, 2021, 9:41 AM

#

(you can also open individual issues for each game, though battleships and connect 4 already exist)

clever wraith Dec 3, 2021, 9:42 AM

#

oh it does? i made an issue for blackjack

gritty wind Dec 3, 2021, 9:42 AM

#

I don't think we have one open for blackjack, though we may have shot it down in the past for gambling

clever wraith Dec 3, 2021, 9:43 AM

#

oh… damn.. but my idea has no gamble but i get the idea, blackjack is usually used for that

gritty wind Dec 3, 2021, 9:43 AM

#

Though I'm not too opposed to blackjack

#

probably best I spell that out

clever wraith Dec 3, 2021, 9:44 AM

#

ill just wait and see if its denied or accepted blobshrug

short snow Dec 3, 2021, 9:44 AM

#

gritty wind We are not going to be continuing it, though an official announcement has not be...

why?

gritty wind Dec 3, 2021, 9:45 AM

#

Just gonna have to wait for the announcement for further details

short snow Dec 3, 2021, 9:46 AM

#

well lemon_pensive ok

short snow Dec 3, 2021, 10:04 AM

#

yeah dorsan's work on API testing

green oriole Dec 3, 2021, 10:13 AM

#

Dorsan was part of the meeting that led to the API sunset

green oriole Dec 3, 2021, 10:57 AM

#

I do not

brisk brook Dec 3, 2021, 10:57 AM

#

Soon™

green oriole Dec 3, 2021, 10:57 AM

#

not like it really matters though

austere hornet Dec 3, 2021, 12:29 PM

#

Wait so the API repo is getting deleted? I missed the convo a bit

green oriole Dec 3, 2021, 12:32 PM

#

perhaps just archived, but yes

short snow Dec 3, 2021, 12:33 PM

#

there was no convo here, just a coredev meeting IIRC

green oriole Dec 3, 2021, 12:33 PM

#

I wasn't there, but didn't it take place in #763406158522220544 ?

short snow Dec 3, 2021, 12:34 PM

#

Idk

austere hornet Dec 3, 2021, 12:34 PM

#

Oh I was asleep probably then

#

So I didn't see

austere hornet Dec 3, 2021, 12:35 PM

#

short snow there was no convo here, just a coredev meeting IIRC

Well I saw something about the API repo here but wasn't sure what it was about

short snow Dec 3, 2021, 12:36 PM

#

just joe saying hold on your development on API and wcodes asking for updates ig

austere hornet Dec 3, 2021, 12:36 PM

#

Ahhh gotcha

fervent sage Dec 3, 2021, 12:54 PM

#

green oriole perhaps just archived, but yes

Wait why?

green oriole Dec 3, 2021, 12:55 PM

#

announcement to come soon

fallen patrol Dec 3, 2021, 2:20 PM

#

@thorny obsidian you said "we won't we doing this" in aoc but I don't see any replies on either of my issues about aoc commands, could please provide a reason why the ideas bsoyka and I came up with won't work?

thorny obsidian Dec 3, 2021, 2:21 PM

#

fallen patrol <@212644551926611969> you said "we won't we doing this" in aoc but I don't see a...

I will, once I have some time. But I wanted to be clear that that's not something we're doing before people started to invest too much time in it.

fallen patrol Dec 3, 2021, 2:22 PM

#

if you didn't read the full text of the issue, the title that you saw does not match the rest of the pr, I think I updated it after sending that embed

thorny obsidian Dec 3, 2021, 2:22 PM

#

Like I said, I will take a look and respond once I have some time.

dark ginkgo Dec 3, 2021, 2:31 PM

#

How to convert django project into exe file?

vale ibex Dec 3, 2021, 2:32 PM

#

dark ginkgo How to convert django project into exe file?

Hey, this channel is for discussing Python Discord projects, it sounds like you are looking for #tools-and-devops

fallen patrol Dec 3, 2021, 2:34 PM

#

which pr num is Christmasify

vale ibex Dec 3, 2021, 2:40 PM

#

yea, sir-lancebot#956

dusky shoreBOT Dec 3, 2021, 2:40 PM

#

GitHub

PRDraft .christmasify Command

vale ibex Dec 3, 2021, 2:40 PM

#

currently draft

fallen patrol Dec 3, 2021, 2:42 PM

#

I left a comment on bot#1991, even thought it already got merged

dusky shoreBOT Dec 3, 2021, 2:42 PM

#

GitHub

PRMerged Update PEP Repo URL

fallen patrol Dec 3, 2021, 2:42 PM

#

vale ibex yea, sir-lancebot#956

thanks

gritty wind Dec 3, 2021, 2:51 PM

#

What's the point of leaving that comment four hours after the PR was merged

#

Anyways, it's probably a wont-fix because most repos don't change master every week

fallen patrol Dec 3, 2021, 2:53 PM

#

gritty wind What's the point of leaving that comment four hours after the PR was merged

I was asleep 🤷‍♀️

#

Hmmm

#

From what I can tell, a value that's been saved to a dictionary and then the reference is updated will keep the old reference

#

!e ```py

create the objects

sen1 = object()
sen2 = object()
assert sen1 is not sen2

d = {'a': sen1}

print("is sen1", d['a'] is sen1)
print("is sen2", d['a'] is sen2)

sen1 = sen2
print('reassigned sen1')

print("is sen1", d['a'] is sen1)
print("is sen2", d['a'] is sen2)

stable mountainBOT Dec 3, 2021, 3:00 PM

#

@fallen patrol :white_check_mark: Your eval job has completed with return code 0.

001 | is sen1 True
002 | is sen2 False
003 | reassigned sen1
004 | is sen1 False
005 | is sen2 False

fallen patrol Dec 3, 2021, 3:00 PM

#

(I promise this is relevant)

#

@vale ibex I'm reviewing bot#1990 right now, and have found a future hidden bug, which may or may not be worth just letting it occur, with a comment

dusky shoreBOT Dec 3, 2021, 3:01 PM

#

GitHub

PROpen Patch d.py's message convertor to infer channelID from the given context

fallen patrol Dec 3, 2021, 3:01 PM

#

library objects are made by this mapping https://github.com/Rapptz/discord.py/blob/1a4e73d59932cdbe7bf2c281f25e32529fc7ae1f/discord/ext/commands/converter.py#L984-L990

stable mountainBOT Dec 3, 2021, 3:01 PM

#

discord/ext/commands/converter.py lines 984 to 990

CONVERTER_MAPPING: Dict[Type[Any], Any] = {
    discord.Object: ObjectConverter,
    discord.Member: MemberConverter,
    discord.User: UserConverter,
    discord.Message: MessageConverter,
    discord.PartialMessage: PartialMessageConverter,
    discord.TextChannel: TextChannelConverter,```

fallen patrol Dec 3, 2021, 3:02 PM

#

so this line, won't change any params that are hinted with discord.PartialMessage
https://github.com/python-discord/bot/blob/02bc740b08e99caa9214461a91f5e885e65fc826/bot/__init__.py#L21

stable mountainBOT Dec 3, 2021, 3:02 PM

#

bot/__init__.py line 21

commands.converter.PartialMessageConverter = monkey_patches.FixedPartialMessageConverter```

fallen patrol Dec 3, 2021, 3:03 PM

#

however, the bot doesn't use PartialMessage as a typehint for any command, so it should be good, but this would crop up in the future if one was implemented

vale ibex Dec 3, 2021, 3:04 PM

#

Yea, that's a good point, I'm not sure if we'll ever run into it, since there's rarely a reason to use PartialMessage over normal Message

#

but probably worth a comment at least, so that people don't need to do that investigation themselves

brisk brook Dec 3, 2021, 3:04 PM

#

fallen patrol !e ```py # create the objects sen1 = object() sen2 = object() assert sen1 is not...

If you're expecting that to give you True, False (after the reassignment) then you are misunderstanding on how Python works.

vale ibex Dec 3, 2021, 3:04 PM

#

I checked, and this bug is also in disnake, probably any other forks

fallen patrol Dec 3, 2021, 3:05 PM

#

Probably because they don't know yet, probably worth making an issue on one of them 😛

vale ibex Dec 3, 2021, 3:05 PM

#

hah yea, there's so many I'd feel bad raising an issue on one and missing others

brisk brook Dec 3, 2021, 3:05 PM

#

Things don't have names

fallen patrol Dec 3, 2021, 3:06 PM

#

brisk brook If you're expecting that to give you True, False (after the reassignment) then y...

The point was to illustrate the CONVERTER_MAPPING and monkeypatch of the library below

brisk brook Dec 3, 2021, 3:06 PM

#

When you insert something into the dictionary you aren't binding the variable name, you are putting in the value of that variable

fallen patrol Dec 3, 2021, 3:06 PM

#

yeah

vale ibex Dec 3, 2021, 3:06 PM

#

vale ibex but probably worth a comment at least, so that people don't need to do that inve...

I added this comment

fallen patrol Dec 3, 2021, 3:06 PM

#

lol at this point where's my co-author /s

#

jk

#

unless...

vale ibex Dec 3, 2021, 3:07 PM

#

Hah

brisk brook Dec 3, 2021, 3:07 PM

#

Why not just update the dictionary too instead?

fallen patrol Dec 3, 2021, 3:07 PM

#

Its not part of the public api

brisk brook Dec 3, 2021, 3:08 PM

#

The repo is archived 😆

fallen patrol Dec 3, 2021, 3:08 PM

#

I'm more concerned about forks doing weird stuff

#

although when delving into the converter world a few weeks ago I did find that you can make a class method named convert on objects, and dpy will use that, so you don't need to make a converter for every rich class you have

vale ibex Dec 3, 2021, 3:09 PM

#

Yea, we don't want to go too much in depth with monkeypatches, since that makes migrating harder

#

So preferably we keep them to just what we actually need

brisk brook Dec 3, 2021, 3:10 PM

#

The thing is that I would hate to be the person debugging this later on 😅

fallen patrol Dec 3, 2021, 3:10 PM

#

sigh I guess I'll figure out how to run bot 😔

vale ibex Dec 3, 2021, 3:11 PM

#

brisk brook The thing is that I would hate to be the person debugging this later on 😅

hence the comment right next to the monkey patch 😄

#

I highly doubt we would ever use the PartialMessage convertor

#

but if we do, the comment is there to save them debug time

#

Since this patch won't break it, it just won't have the fix

fallen patrol Dec 3, 2021, 3:13 PM

#

..where's the guide to setting up site?

#

~~without docker~~

vale ibex Dec 3, 2021, 3:13 PM

#

https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/bot/#with-the-bot-running-locally

Python Discord - Contributing to Bot

A guide to setting up and configuring Bot.

brisk brook Dec 3, 2021, 3:14 PM

#

vale ibex Since this patch won't break it, it just won't have the fix

Ah, yeah it's pretty minor. I would argue that the comment isn't visible enough (as it stands I can't see myself going to that file when debugging something).

vale ibex Dec 3, 2021, 3:14 PM

#

on the same page

#

right below the docker instructions

vale ibex Dec 3, 2021, 3:14 PM

#

brisk brook Ah, yeah it's pretty minor. I would argue that the comment isn't visible enough ...

What would you be debugging?

fallen patrol Dec 3, 2021, 3:14 PM

#

and right below that: docker-compose up web to start the site container. This is required.

#

lol

vale ibex Dec 3, 2021, 3:14 PM

#

You'd be debugging, "oh the fix we made the the message convertor isn't working" let me see how we did that

brisk brook Dec 3, 2021, 3:15 PM

#

Hmmm, you have some good arguments..

fallen patrol Dec 3, 2021, 3:15 PM

#

wait, i need a database too

brisk brook Dec 3, 2021, 3:15 PM

#

https://c.tenor.com/yJJgQYoS0RMAAAAM/thats-a-damn-good-argument-pointing.gif

fallen patrol Dec 3, 2021, 3:15 PM

#

might be worth figuring out how to run docker i guess

brisk brook Dec 3, 2021, 3:16 PM

#

Yeah uhh, Docker is great. I still have never installed Redis on my system (well, other than inside Docker).

fallen patrol Dec 3, 2021, 3:17 PM

#

oh wait i can run them on different machines

#

which is good, since i have docker on one machine, but i haven't debugged with gpg isn't working yet so i don't use it for my development

#

could use it for review i guess

gritty wind Dec 3, 2021, 3:18 PM

#

You're probably struggling because those are the instructions for bot lol

#

https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/site/#without-docker

#

Though yes, docker would be ideal

#

Esp if you want to avoid PG

fallen patrol Dec 3, 2021, 3:18 PM

#

yeah i'm just going that route for the site so i can run bot

brisk brook Dec 3, 2021, 3:18 PM

#

gritty wind You're probably struggling because those are the instructions for bot lol

Lmaoo

#

Ikea moment

fallen patrol Dec 3, 2021, 3:19 PM

#

gritty wind You're probably struggling because those are the instructions for bot lol

(also i did go to the site docs after that but didn't say anything smh)

#

well currently no docker issues

#

does site run on 0.0.0.0 by default?

#

says it is

#

but I can't access it from a different machine

brisk brook Dec 3, 2021, 3:26 PM

#

No, because it is only exposed on your machine right?

fallen patrol Dec 3, 2021, 3:26 PM

#

i suppose that's what happening

brisk brook Dec 3, 2021, 3:26 PM

#

You need to port-forward it

fallen patrol Dec 3, 2021, 3:27 PM

#

kk

gritty wind Dec 3, 2021, 3:27 PM

#

tfw cf tunnels are the easiest port forwards

#

My life as a web dev hasn't been the same since someone told me about it

fallen patrol Dec 3, 2021, 3:28 PM

#

its a local machine so using cf would be... worse

gritty wind Dec 3, 2021, 3:28 PM

#

No network connection at all?

fallen patrol Dec 3, 2021, 3:29 PM

#

uh

#

fallen patrol Dec 3, 2021, 3:30 PM

#

gritty wind No network connection at all?

Its local to my own network. I can use 10.0.0.201 to access the machine, but since 8000 isn't running on 0.0.0.0 I can't access it from this machine

gritty wind Dec 3, 2021, 3:31 PM

#

If it has an internet connection (which I assume it does since you installed docker and pulled the repo), cf's argo tunnels are basically magic for this, but I digress.

Did you start forwarding the port?

fallen patrol Dec 3, 2021, 3:32 PM

#

Did you start forwarding the port?
not well, apparently

#

~~how do you forward a port from an ssh session?~~

gritty wind Dec 3, 2021, 3:34 PM

#

-R

fallen patrol Dec 3, 2021, 3:34 PM

#

when connecting to the session?

gritty wind Dec 3, 2021, 3:34 PM

#

Well, this will be a non-interactive session, but yeah

#

It's... a tunnel 🙃

fallen patrol Dec 3, 2021, 3:35 PM

#

uh, it was interactive

gritty wind Dec 3, 2021, 3:36 PM

#

Wdym?

fallen patrol Dec 3, 2021, 3:36 PM

#

gritty wind `-R`

(whats the syntax for the arg to this?)

gritty wind Dec 3, 2021, 3:36 PM

#

Nightmare

fallen patrol Dec 3, 2021, 3:36 PM

#

ssh -R 8000:localhost:8000 pc_name

gritty wind Dec 3, 2021, 3:36 PM

#

ssh -R 8000:127.0.0.1:8000 remote

fallen patrol Dec 3, 2021, 3:38 PM

#

...

#

why is that not working

gritty wind Dec 3, 2021, 3:39 PM

#

In my experience, it's impossible to make work

#

Any output?

fallen patrol Dec 3, 2021, 3:39 PM

#

docker is up, i think

#

yeah, it is

#

...wow i can't believe i thought of using curl from another session to request 0.0.0.0:8000 😂

#

@gritty wind

gritty wind Dec 3, 2021, 3:43 PM

#

nice

#

what's up with the red

fallen patrol Dec 3, 2021, 3:44 PM

#

vscode will just automatically forward running services so 🤷‍♀️

#

its my firefox theme

fallen patrol Dec 3, 2021, 3:44 PM

#

gritty wind what's up with the red

austere hornet Dec 3, 2021, 3:51 PM

#

dusky shore

Oh that's mine

#

Yeah it's draft

#

I'm working on it

#

Been a bit busy lately

#

But I'll get to it

#

That reminds me actually

#

sir-lancebot#901 needs reviews

dusky shoreBOT Dec 3, 2021, 3:52 PM

#

GitHub

PROpen Madlibs

austere hornet Dec 3, 2021, 3:53 PM

#

Oh and thanks for dismissing the review @trail pilot

fallen patrol Dec 3, 2021, 3:53 PM

#

poetry.

#

#

this just in: 3.9 is 3.8

trail pilot Dec 3, 2021, 3:54 PM

#

austere hornet Oh and thanks for dismissing the review <@584817706646110333>

Np

fallen patrol Dec 3, 2021, 3:59 PM

#

!paste

#

https://paste.pythondiscord.com/vojaxaqeho.sql

#

I've done this part

#

austere hornet Dec 3, 2021, 4:00 PM

#

fallen patrol !paste

Wait why didn't the command work

fallen patrol Dec 3, 2021, 4:00 PM

#

(it did, i deleted the result with the trashcan emote)

austere hornet Dec 3, 2021, 4:00 PM

#

Ahhh

gritty wind Dec 3, 2021, 4:03 PM

#

What's your proto

#

It should be under it's own var

fallen patrol Dec 3, 2021, 4:04 PM

#

proto?

#

no results for proto in my config.yml

gritty wind Dec 3, 2021, 4:04 PM

#

It's called scheme

#

L373

#

& 371

#

gotta make sure they are both on http

fallen patrol Dec 3, 2021, 4:05 PM

#

gritty wind Dec 3, 2021, 4:05 PM

#

No clue then

#

Can you still access the site from your browser

fallen patrol Dec 3, 2021, 4:05 PM

#

yep

#

#

even checked by refreshing without cache

#

....

fallen patrol Dec 3, 2021, 4:07 PM

#

gritty wind Can you still access the site from your browser

y&n

#

gritty wind Dec 3, 2021, 4:07 PM

#

yeah that sounds about right

fallen patrol Dec 3, 2021, 4:07 PM

#

windows subsystem has entered the chat

gritty wind Dec 3, 2021, 4:08 PM

#

if you're running in WSL, that may not have the same localhost as the rest of your system

short snow Dec 3, 2021, 4:08 PM

#

that's a lot of red

fallen patrol Dec 3, 2021, 4:08 PM

#

gritty wind if you're running in WSL, that may not have the same `localhost` as the rest of ...

yeah, need to figure that out

gritty wind Dec 3, 2021, 4:09 PM

#

Though I guess you wouldn't get a connection refused

short snow Dec 3, 2021, 4:09 PM

#

zig modpings pr 🙃 friendly bump

cold island Dec 3, 2021, 4:09 PM

#

Hmmm I want to make utility modules on the bot, but I don't want to prefix each one with an underscore

cold island Dec 3, 2021, 4:09 PM

#

short snow zig modpings pr 🙃 friendly bump

Sorry, whatever attention for dev I have right now will probably go elsewhere

gritty wind Dec 3, 2021, 4:09 PM

#

Could you give an example of what the module looks like

#

Is it a cog, standalone functions, etc

short snow Dec 3, 2021, 4:10 PM

#

hmm ok

cold island Dec 3, 2021, 4:10 PM

#

I have a cog in a file, and then I have other files next to it

#

But I have a lot of files next to it

#

So prefixing each one is kinda annoying. I'd like to just define __all__ in the ext init

green oriole Dec 3, 2021, 4:11 PM

#

gritty wind Though I guess you wouldn't get a connection refused

You do get a connection refused because nothing is bound to the loopback on port 8000

fallen patrol Dec 3, 2021, 4:12 PM

#

cold island So prefixing each one is kinda annoying. I'd like to just define `__all__` in th...

_utils/__init__.py: __all__

green oriole Dec 3, 2021, 4:12 PM

#

Windows doesn't know what to do so it just refuses to connect

cold island Dec 3, 2021, 4:12 PM

#

fallen patrol `_utils/__init__.py: __all__`

What I mean is that I want the extension loader to use it

gritty wind Dec 3, 2021, 4:13 PM

#

Do what arl is suggesting:

\
  | cog.py
  | _utils
   \
    | file_1.py
    | file_2.py

I thiiiink it shouldn't load those

cold island Dec 3, 2021, 4:14 PM

#

hmmm

fallen patrol Dec 3, 2021, 4:14 PM

#

gritty wind Do what arl is suggesting: ``` \ | cog.py | _utils \ | file_1.py ...

it will load those

#

wait

cold island Dec 3, 2021, 4:14 PM

#

It won't

fallen patrol Dec 3, 2021, 4:14 PM

#

is this bot or lance?

cold island Dec 3, 2021, 4:14 PM

#

I guess that'll work

#

bot

fallen patrol Dec 3, 2021, 4:14 PM

#

(they have slightly differing implementations)

#

    for module in pkgutil.walk_packages(exts.__path__, f"{exts.__name__}.", onerror=on_error):
        if unqualify(module.name).startswith("_"):
            # Ignore module/package names starting with an underscore.
            continue

fallen patrol Dec 3, 2021, 4:15 PM

#

fallen patrol it will load those

update: it won't

#

oh wait

#

no it might

gritty wind Dec 3, 2021, 4:18 PM

#

Why are you going back and forth so much lol, it wont

cold island Dec 3, 2021, 4:19 PM

#

it does 😔

#

Except now it throws an import error because of the underscore I guess

gritty wind Dec 3, 2021, 4:22 PM

#

We can probably switch up the searching function to make it work pretty safely

#

if any(name.startswith("_") for name in module.name.split(".")):

cold island Dec 3, 2021, 4:23 PM

#

It's using pkgutil.walk_packages and I can't really tell it to not go into the subpackages

gritty wind Dec 3, 2021, 4:23 PM

#

Yeah, that does seem to work, and doesn't break anything

cold island Dec 3, 2021, 4:23 PM

#

hmm

gritty wind Dec 3, 2021, 4:23 PM

#

We can tell it to stop searching if it finds an underscore at any point in the tree

cold island Dec 3, 2021, 4:24 PM

#

Hmm well it won't stop searching, we can tell it to just ignore each file

gritty wind Dec 3, 2021, 4:24 PM

#

wdym?

cold island Dec 3, 2021, 4:24 PM

#

Like