#dev-contrib | Python | Page 135

fallen patrol Sep 9, 2021, 11:54 PM

#

oops this isn't #tools-and-devops sorry

thorny obsidian Sep 10, 2021, 12:09 AM

#

So, thinking on the contributing tag, something like this? Or do y'all think it's not worth having?

austere hornet Sep 10, 2021, 12:13 AM

#

thorny obsidian So, thinking on the contributing tag, something like this? Or do y'all think it'...

Ooh, I love that command! I think we should definitely have it!

trail pilot Sep 10, 2021, 12:28 AM

#

thorny obsidian So, thinking on the contributing tag, something like this? Or do y'all think it'...

That looks amazing!

One suggestion - link buttons to the sir lancebot and python repos

but it may be inconsistent with the current tags

#

Not sure if the main bot has upgraded to the latest DPY version tho

thorny obsidian Sep 10, 2021, 12:28 AM

#

That would require a large overhaul to how our tags are currently processed

trail pilot Sep 10, 2021, 12:28 AM

#

Ah

thorny obsidian Sep 10, 2021, 12:28 AM

#

All of our tags are markdown files that are processed into embeds

trail pilot Sep 10, 2021, 12:29 AM

#

Ah alright, that makes more sense than just having one large cog with a ton of different commands

#

I wonder if the .tictactoe could be rewritten with the discord UI

vocal prairie Sep 10, 2021, 1:31 AM

#

Hmm, that sounds interesting

#

It could be buttons attacked in a 3x3 or something like that

trail pilot Sep 10, 2021, 1:39 AM

#

Yea

#

Once I’m done with my current PRs I might mess around with it

stable mountainBOT Sep 10, 2021, 2:39 AM

#

It has arrived!

Here's your reminder: that
[Jump back to when you created the reminder](#dev-contrib message)

clever wraith Sep 10, 2021, 2:43 AM

#

what are you gamering

clever wraith Sep 10, 2021, 4:12 AM

#

Hi

patent pivot Sep 10, 2021, 5:51 AM

#

clever wraith what are you gamering

rimworld

fallen patrol Sep 10, 2021, 6:24 AM

#

what in the world

#

loguru is one of the most cursed libraries i have ever seen

green oriole Sep 10, 2021, 8:47 AM

#

Pressing submit review when entering a tunnel is always fun

static canyon Sep 10, 2021, 8:50 AM

#

@green oriole what exactly do you mean by an "explanation" of the regex?

#

I figured the variable name was enough to tell you what it does

green oriole Sep 10, 2021, 8:50 AM

#

Like comments saying what each part do, similar to https://github.com/python-discord/bot/blob/main/bot/utils/regex.py#L3

#

Yes, you did say what it does, but you didn't say how

static canyon Sep 10, 2021, 8:51 AM

#

Ah right

green oriole Sep 10, 2021, 8:51 AM

#

This regex is too complex to be understood like that

static canyon Sep 10, 2021, 8:53 AM

#

reg = r"(?:`[^`\\]*(?:\\.[^`\\]*)*`)" \  # matches inside codeblocks without a group
      r"| ([_|])"  # matches `_` and `|` that weren't captured by previous part, in group 1 for access```something like this?

#

Not quite sure how to word it

#

And I guess I should use re.compile? (never used that before)

short snow Sep 10, 2021, 9:19 AM

#

you can use () rather \, liek:

reg = (
  r"(?:`[^`\\]*(?:\\.[^`\\]*)*`)"  # matches inside codeblocks without a group
  r"| ([_|])"  # matches `_` and `|` that weren't captured by previous part, in group 1 for access
)

static canyon Sep 10, 2021, 9:22 AM

#

I just prefer \ for separating strings

#

But yeah

#

What do you think of the comments though? @short snow

#

Are they good enough?

short snow Sep 10, 2021, 9:26 AM

#

gimme a minute, need to put it into regex101, i don't remember regex symbols 😔

green oriole Sep 10, 2021, 9:26 AM

#

short snow you can use `()` rather `\`, liek: ```py reg = ( r"(?:`[^`\\]*(?:\\.[^`\\]*)*`...

^ we use this style for multi-line strings

#

@static canyon seems like I forgot to mention we should use named capture groups, sorry

#

I'd personally add more comments, but I guess that's good enough

short snow Sep 10, 2021, 9:33 AM

#

yeah the coments are prett nice, what does without a group mean in the first comment pithink

static canyon Sep 10, 2021, 9:51 AM

#

short snow yeah the coments are prett nice, what does `without a group` mean in the first ...

As in it only matches, it doesn't give any groups

#

All the () are non-capturing

static canyon Sep 10, 2021, 9:51 AM

#

green oriole <@!442244135840382978> seems like I forgot to mention we should use named captur...

Nw, will do that and change the multi-line string format

#

Currently gotpy markdown_regex = ( r"(?:`[^`\\]*(?:\\.[^`\\]*)*`)" # matches inside codeblocks (no capturing groups) r"|(?P<markdown>[_|])" # matches `_` and `|` that weren't captured by previous part inside `markdown` group ) markdown_outside_codeblocks_indices = [ m.span()[0] for m in re.finditer(markdown_regex, content) if m.groupdict().get('markdown') ]

#

Thoughts?

green oriole Sep 10, 2021, 9:56 AM

#

you don't need a non capturing group anymore

static canyon Sep 10, 2021, 9:56 AM

#

True

#

I'll get rid of it

#

        markdown_regex = (
            r"(`[^`\\]*(\\.[^`\\]*)*`)"  # matches anything inside codeblocks (backquotes)
            r"|(?P<markdown>[_|])"  # matches `_` and `|` that weren't captured by previous part inside `markdown` group
        )
        markdown_outside_codeblocks_indices = [
            m.span()[0]
            for m in re.finditer(markdown_regex, content)
            if m.groupdict().get('markdown')
        ]```

#

Would help to shorten the second comment but not sure what to (line is exactly 120 chars)

brisk brook Sep 10, 2021, 10:23 AM

#

One source or confusion I can find is why this means that we now ignore underscores inside codeblocks

#

Can you just mention like "By matching whole codeblocks here first, it means that the following regex won't match characters inside codeblocks"

#

Pretty rough comment, but should get the idea across of what I am imagining @static canyon

static canyon Sep 10, 2021, 10:38 AM

#

Yep

#

Will add that before

#

        # By first matching everything inside codeblocks, the part that 
        # matches underscores and pipes won't match those within backquotes
        markdown_regex = (
            r"(`[^`\\]*(\\.[^`\\]*)*`)"  # matches anything inside codeblocks (backquotes)
            r"|(?P<markdown>[_|])"  # matches `_` and `|` that weren't captured by previous part inside `markdown` group
        )
        markdown_outside_codeblocks_indices = [
            m.span()[0]
            for m in re.finditer(markdown_regex, content)
            if m.groupdict().get('markdown')
        ]```this good? @brisk brook

brisk brook Sep 10, 2021, 10:46 AM

#

Yeah I like that

short snow Sep 10, 2021, 10:46 AM

#

maybe add an example, like the __eq__ one, which was included in the issue description

static canyon Sep 10, 2021, 10:55 AM

#

short snow maybe add an example, like the `__eq__` one, which was included in the issue des...

There's an example in the PR. It's a bit much to include it in the code really

#

I'm happy with this so gonna push in ~3hrs (when I get home) if there's no other feedback

#

    @staticmethod
    def escape_markdown(content: str) -> str:
        """Escape the markdown underlines and spoilers that aren't in codeblocks."""
        # By first matching everything inside codeblocks, the part that
        # matches underscores and pipes won't match those within backquotes
        markdown_regex = (
            r"(`[^`\\]*(\\.[^`\\]*)*`)"  # matches anything inside codeblocks (backquotes)
            r"|(?P<markdown>[_|])"  # matches `_` and `|` that weren't captured by previous part inside `markdown` group
        )
        indices_of_markdown_outside_codeblocks = [
            m.span()[0]
            for m in re.finditer(markdown_regex, content)
            if m.groupdict().get('markdown')
        ]

        escaped_content = ""
        for index, char in enumerate(content):
            if index in indices_of_markdown_outside_codeblocks and (index == 0 or content[index-1] != "\\"):
                escaped_content += "\\" + char
            else:
                escaped_content += char
        return escaped_content

cold island Sep 10, 2021, 1:02 PM

#

What is the purpose of the \\ and the \\.?

#

For content[index-1] != "\\", include a negative lookbehind

#

And then the loop becomes

escaped_content = "\\".join(content[indices[i]:indices[i+1]] for i in range(len(indices)-1))

(yes, yes, I used range-len)

#

Except if it starts with 0 you'll need to add another \ at the beginning 🤔

#

Actually you don't even need to do that

static canyon Sep 10, 2021, 1:14 PM

#

cold island What is the purpose of the `\\` and the `\\.`?

It's from an old version of the regexpy r"(`[^`]*([^`]*)*`)|(?P<markdown>[_|])"this works just as well

cold island Sep 10, 2021, 1:14 PM

#

cold island Actually you don't even need to do that

Since everything else is escaped, even if you have a markdown symbol at index 0, it will have no match

#

What is the purpose of the

([^`]*)*

static canyon Sep 10, 2021, 1:17 PM

#

Can't remember exactly how it works, but```
([^]*([^]*)*)

cold island Sep 10, 2021, 1:18 PM

#

Why doesn't

`[^`]*`

Do that?

static canyon Sep 10, 2021, 1:18 PM

#

That's not between quotes iirc

cold island Sep 10, 2021, 1:18 PM

#

Or even just

`.*?`

static canyon Sep 10, 2021, 1:19 PM

#

The latter should work actually yeah

#

My regex knowledge isn't great so I often do stuff way too convoluted

static canyon Sep 10, 2021, 1:20 PM

#

cold island For `content[index-1] != "\\"`, include a negative lookbehind

What do you mean by this?

cold island Sep 10, 2021, 1:20 PM

#

You can specify in a regex pattern that you want the match to not follow a specific string

#

So you can say "give me all the markdown symbols that don't follow slashes"

#

https://www.regular-expressions.info/lookaround.html

Regex Tutorial - Lookahead and Lookbehind Zero-Length Assertions

Test for a match, or test for failure, without actually consuming any characters.

#

Also, are you trying to handle multi-line string as well? I don't use finditer much, but you might need to add the DOTALL flag

#

And if you're trying to handle multi-line code blocks, then the pattern becomes a bit more complex

static canyon Sep 10, 2021, 1:25 PM

#

Sopy `.*?`|(?P<markdown>(?<!\\)[_|])?

static canyon Sep 10, 2021, 1:25 PM

#

cold island And if you're trying to handle multi-line code blocks, then the pattern becomes ...

From my testing it made no difference (presumably because it's still within backquotes)

cold island Sep 10, 2021, 1:29 PM

#

Hmmm.. that's true

#

Although I feel like there's an edge case here

static canyon Sep 10, 2021, 1:30 PM

#

static canyon So```py `.*?`|(?P<markdown>(?<!\\)[_|])```?

It doesn't work with this regex though

#

Worked before but not now

cold island Sep 10, 2021, 1:31 PM

#

||Hel_lo||`

#

!raw 885880207662280734

stable mountainBOT Sep 10, 2021, 1:31 PM

#

== Raw message ==

``||Hel_lo||`

cold island Sep 10, 2021, 1:32 PM

#

Surrounded by backticks, but not in a codeblock

#

You'll need to make sure that you're ignoring proper code blocks

#

The snekbox module handles codeblock detection if you want to take a look

brazen charm Sep 10, 2021, 1:34 PM

#

how likely is that to occur in a mailing lists?

#

We don't need a needlessly complex regex; it's only to make the text more readable which that wouldn't really be in the first place

static canyon Sep 10, 2021, 1:35 PM

#

This seems to work for multi-line codeblocks

cold island Sep 10, 2021, 1:35 PM

#

If it's just for the mailing lists and there's no issue with an occasional mistake a simplified version is fine

#

But that should probably be documented, lest someone copies it later

#

You should really just use the flag for multiline strings

static canyon Sep 10, 2021, 1:37 PM

#

nvm it doesn't work

static canyon Sep 10, 2021, 1:37 PM

#

cold island You should really just use the flag for multiline strings

Wdym?

cold island Sep 10, 2021, 1:39 PM

#

The wildcard won't match newlines unless you add the DOTALL flag

cold island Sep 10, 2021, 1:41 PM

#

static canyon It doesn't work with this regex though

What didn't work?

static canyon Sep 10, 2021, 1:48 PM

#

If a line within the codeblock was empty it didn't work, but made changes which fix it

#

#

but this breaks if the end of codeblock isn't on a newline lol

cold island Sep 10, 2021, 1:57 PM

#

I tried in Python and seems to work just fine

#

import re

pattern = r"`.*?`|(?P<markdown>(?<!\\)[_|])"
s = """
\`\`\`py
test_in_g

\`\`\`_in_g
"""

indices_of_markdown_outside_codeblocks = [
    m.span()[0]
    for m in re.finditer(pattern, s, re.DOTALL)
    if m.groupdict().get('markdown')
]

print(indices_of_markdown_outside_codeblocks)```

#

Ignore the slashes in the string lol

static canyon Sep 10, 2021, 1:59 PM

#

But```py
```py
test```

#

(If the closing backquote is same line)

cold island Sep 10, 2021, 2:00 PM

#

It does

static canyon Sep 10, 2021, 2:01 PM

#

#

But then you're using a completely different reg to me

cold island Sep 10, 2021, 2:01 PM

#

There's a limit for regex101, you need to try in proper python code

static canyon Sep 10, 2021, 2:01 PM

#

Right

cold island Sep 10, 2021, 2:01 PM

#

There's no finditer option there as far as I know

static canyon Sep 10, 2021, 2:02 PM

#

r"`.*?`|(?P<markdown>(?<!\\)[_|])"

#

static canyon Sep 10, 2021, 2:08 PM

#

cold island ```py import re pattern = r"`.*?`|(?P<markdown>(?<!\\)[_|])" s = """ \`\`\`py t...

This seems to be working correctly

#

So I've now got```py
@staticmethod
def escape_markdown(content: str) -> str:
"""Escape the markdown underlines and spoilers that aren't in codeblocks."""
# By first matching everything inside codeblocks, the part that
# matches underscores and pipes won't match those within backquotes
markdown_regex = (
r". *?" # matches anything inside codeblocks (backquotes)
r"|(?P<markdown>(?<!)[_ |])" # matches unescaped _ and | that weren't captured by previous part
)
indices_of_markdown_outside_codeblocks = [
m.span()[0]
for m in re.finditer(markdown_regex, content, re.DOTALL)
if m.groupdict().get('markdown')
]

    escaped_content = ""
    for index, char in enumerate(content):
        if index in indices_of_markdown_outside_codeblocks:
            escaped_content += "\\" + char
        else:
            escaped_content += char
    return escaped_content```

cold island Sep 10, 2021, 2:13 PM

#

cold island And then the loop becomes ```py escaped_content = "\\".join(content[indices[i]:i...

You can get rid of the loop, even though this line is a bit ugly ^

static canyon Sep 10, 2021, 2:14 PM

#

return "".join(
    char
    for index,char in enumerate(content)
    if index not in indices_of_markdown_outside_codeblocks
    else "\\" + char
)

cold island Sep 10, 2021, 2:15 PM

#

Hmm yeah that might work better

#

Though it that case I'd change indices_of_markdown_outside_codeblocks to a set

static canyon Sep 10, 2021, 2:15 PM

#

Except that's invalid syntax lol

cold island Sep 10, 2021, 2:16 PM

#

lol, you need to move the if-else to the beginning

static canyon Sep 10, 2021, 2:16 PM

#

Does this look good?py return "".join( char if index not in indices_of_markdown_outside_codeblocks else "\\" + char for index, char in enumerate(content) )

#

Not quite sure where to split the newlines

cold island Sep 10, 2021, 2:17 PM

#

I'd put the else on the next line

static canyon Sep 10, 2021, 2:17 PM

#

I was thinking there because then lines 1+3 directly show the yielded value

#

But if you think I should move then I will @cold island

cold island Sep 10, 2021, 2:19 PM

#

It seems better to me, but I don't have a strong opinion about it

cold island Sep 10, 2021, 2:23 PM

#

static canyon So I've now got```py @staticmethod def escape_markdown(content: str) -> ...

Why do you have a space in the character group on the 8th line?

#

There's also a space on the 7th line

static canyon Sep 10, 2021, 2:28 PM

#

yeah I fixed the spaces

#

When I copied it added a load of spaces

static canyon Sep 10, 2021, 2:28 PM

#

cold island It seems better to me, but I don't have a strong opinion about it

Ehh yeah, I decided that I prefer having the if and else inline so changed

#

Full Function:```py
@staticmethod
def escape_markdown(content: str) -> str:
"""Escape the markdown underlines and spoilers that aren't in codeblocks."""
# By first matching everything inside codeblocks, the part that
# matches underscores and pipes won't match those within backquotes
markdown_regex = (
r".*?" # matches anything inside codeblocks (backquotes)
r"|(?P<markdown>(?<!)[_|])" # matches unescaped _ and | that weren't captured by previous part
)
indices_of_markdown_outside_codeblocks = {
m.span()[0]
for m in re.finditer(markdown_regex, content, re.DOTALL)
if m.groupdict().get('markdown')
}

    return "".join(
        char
        if index not in indices_of_markdown_outside_codeblocks
        else "\\" + char
        for index, char in enumerate(content)
    )```

brisk brook Sep 10, 2021, 2:31 PM

#

What is the output of the same blog post I opened the issue for?

#

That should be a good test

cold island Sep 10, 2021, 2:33 PM

#

m.groupdict().get('markdown') can be replaced with m.group("markdown")

#

m.span()[0] can be replaced with m.start()

#

It doesn't particularly matter, but in your case where you have a constant pattern I'd store it after compilation

#

Meaning markdown_regex = re.compile(...) and then markdown_regex.finditer(...)

static canyon Sep 10, 2021, 2:41 PM

#

cold island Meaning `markdown_regex = re.compile(...)` and then `markdown_regex.finditer(......

Where would I assign?

#

As a constant at top of file?

cold island Sep 10, 2021, 2:42 PM

#

Either instead of the current line or at the top of the file yeah

#

We do it at the top in other modules so let's go with that

#

with screaming snake case

static canyon Sep 10, 2021, 2:47 PM

#

Yep

#

Screaming since constant

static canyon Sep 10, 2021, 3:24 PM

#

Does this look good? @cold island```py
MARKDOWN_REGEX = re.compile(
r".*?" # matches anything inside codeblocks (backquotes)
r"|(?P<markdown>(?<!\)[_|])", # matches unescaped _ and | that weren't captured by previous part
re.DOTALL
)

...
@staticmethod
def escape_markdown(content: str) -> str:
"""Escape the markdown underlines and spoilers that aren't in codeblocks."""
# By first matching everything inside codeblocks, the part that
# matches underscores and pipes won't match those within codeblocks
indices_of_markdown_outside_codeblocks = {
m.start()
for m in re.finditer(MARKDOWN_REGEX, content)
if m.group('markdown')
}

    return "".join(
        "\\" + char
        if index in indices_of_markdown_outside_codeblocks
        else char
        for index, char in enumerate(content)
    )

cold island Sep 10, 2021, 3:37 PM

#

You can use MARKDOWN_REGEX.finditer(content). Otherwise I think looks fine

static canyon Sep 10, 2021, 3:38 PM

#

Right yeah

#

Thanks

static canyon Sep 10, 2021, 3:56 PM

#

brisk brook What is the output of the same blog post I opened the issue for?

It outputs exactly as it should 👍

#

@cold island @brisk brook @green oriole all pushed into bot#1822, thanks for the help 👍

dusky shoreBOT Sep 10, 2021, 3:56 PM

#

GitHub

PROpen Fix escapes in python-news posts

patent pivot Sep 10, 2021, 7:20 PM

#

why do we only have 5 projects on site homepage

#

ah we transferred django-simple-bulma

#

what should we replace it with? poll time.

#

!poll "What should be the 6th repository on pythondiscord.com homepage?" "King Arthur" "Pixels" "Quackstack"

stable mountainBOT Sep 10, 2021, 7:22 PM

#

What should be the 6th repository on pythondiscord.com homepage?

🇦 - King Arthur
🇧 - Pixels
🇨 - Quackstack

patent pivot Sep 10, 2021, 7:22 PM

#

!remind 3h check this

stable mountainBOT Sep 10, 2021, 7:22 PM

#

Sure.

Your reminder will arrive on <t:1631312528:F>!

vale ibex Sep 10, 2021, 7:22 PM

#

branding?

patent pivot Sep 10, 2021, 7:22 PM

#

we've always locked it to python projects in prior, I'm not opposed to branding though

vale ibex Sep 10, 2021, 7:23 PM

#

hmm yea true

#

I'm not fussed

vale ibex Sep 10, 2021, 7:43 PM

#

austere hornet Sep 10, 2021, 7:49 PM

#

Nooo RIP @Code Jam Participants

#

Ik that's off topic mb

#

There's nowhere else to write it tho

patent pivot Sep 10, 2021, 7:49 PM

#

has a decent few users

vale ibex Sep 10, 2021, 7:50 PM

#

speaking of metricity

#

metricity#7

dusky shoreBOT Sep 10, 2021, 7:50 PM

#

GitHub

PROpen Metricity creates own database

austere hornet Sep 10, 2021, 7:50 PM

#

You're lucky @clever wraith you're name is still green, but lighter

#

Well yeah

vale ibex Sep 10, 2021, 7:51 PM

#

they're auto-dismissed

#

from the force pushes

#

bash has shopt

dim pelican Sep 10, 2021, 7:52 PM

#

This aint luck, this is dedicated hard work

vale ibex Sep 10, 2021, 7:53 PM

#

https://github.com/python-discord/metricity/blob/main/entry_point.sh#L6

stable mountainBOT Sep 10, 2021, 7:53 PM

#

entry_point.sh line 6

shopt -s nocasematch```

dim pelican Sep 10, 2021, 7:53 PM

#

Mine is sad: https://github.com/brad90four?org=python-discord&year_list=1

vale ibex Sep 10, 2021, 7:54 PM

#

the next line I do a string compare

#

that shopt makes it case insensitive

#

yup

dim pelican Sep 10, 2021, 7:57 PM

#

That's not bad, that is like looking for something relatively quick and easy to help out with

dusky shoreBOT Sep 10, 2021, 8:00 PM

#

GitHub

PROpen Smarter Resources

dim pelican Sep 10, 2021, 8:11 PM

#

that is 113 files my man

vocal prairie Sep 10, 2021, 8:16 PM

#

dim pelican that is 113 files my man

I am reviewing it right now, most of that number is just resources yaml alterations

austere hornet Sep 10, 2021, 8:25 PM

#

Hey @vale ibex , when you have a moment, could you please "accept" the changes on sir-lancebot#843 so this is not showing up? Would greatly appreciate it. Thanks so much!

dusky shoreBOT Sep 10, 2021, 8:25 PM

#

GitHub

PROpen Hangman

vale ibex Sep 10, 2021, 8:25 PM

#

feel free to dismiss my review if you've done the changes

#

Then if another core dev looks at it before me then it's fine

green oriole Sep 10, 2021, 8:25 PM

#

Psstt.. they can't dismiss reviews

vale ibex Sep 10, 2021, 8:25 PM

#

ah lol

austere hornet Sep 10, 2021, 8:25 PM

#

green oriole *Psstt.. they can't dismiss reviews*

Yeah I was gonna say

vale ibex Sep 10, 2021, 8:26 PM

#

well someone can at some point if they get to it before me 😛

green oriole Sep 10, 2021, 8:26 PM

#

Imagine me logging in to that device

#

It has become a meme at that point

vocal prairie Sep 10, 2021, 8:27 PM

#

vale ibex well someone can at some point if they get to it before me 😛

done

austere hornet Sep 10, 2021, 8:27 PM

#

vocal prairie done

Thanks so much!

vocal prairie Sep 10, 2021, 8:28 PM

#

np, i was reviewing stuff anyway

dusky shoreBOT Sep 10, 2021, 9:17 PM

#

GitHub

IssueClosed Use GitHub accounts linked to discord.

#

GitHub

IssueOpen Make storage of static data consistent

#

GitHub

IssueOpen .timeleft command should be a subcommand of hacktoberfest

stable mountainBOT Sep 10, 2021, 10:22 PM

#

patent pivot !remind 3h check this

It has arrived!

Here's your reminder: check this
[Jump back to when you created the reminder](#dev-contrib message)

patent pivot Sep 10, 2021, 10:22 PM

#

okay king arthur wins

#

PRing

#

https://github.com/python-discord/site/pull/589

GitHub

Update repository selection on home page by jb3 · Pull Request #589...

In accordance with a poll in #dev-contrib, King Arthur becomes the 6th repository featured on the Python Discord homepage.

#

wait why did tests fail

#

is github ratelimited or something

#

hmmmmm

#

yeah idk what's going on

#

this works locally

#

#

ah wait the tests do fail locally

#

fixed it, had to update the test data json

#

okay, PR is ready for review

short snow Sep 11, 2021, 1:38 AM

#

Anyone needing some reviews lemon_hyperpleased

#

oh shit my green 😔

austere hornet Sep 11, 2021, 1:44 AM

#

short snow oh shit my green 😔

Yeah lemon_angrysad

vocal prairie Sep 11, 2021, 1:45 AM

#

dusky shore

@short snow Rick was asking about this one ^

short snow Sep 11, 2021, 1:45 AM

#

I dunno django

patent pivot Sep 11, 2021, 1:46 AM

#

patent pivot https://github.com/python-discord/site/pull/589

😎

vocal prairie Sep 11, 2021, 1:47 AM

#

oh yeah I meant to review that but I lost wifi lemon_angrysad

dim pelican Sep 11, 2021, 1:47 AM

#

Just noticed the passes in the tests for that one

short snow Sep 11, 2021, 1:48 AM

#

joe why not make it 9 ferrisBongoHyper

patent pivot Sep 11, 2021, 1:49 AM

#

9 projects?

short snow Sep 11, 2021, 1:49 AM

#

yeah

patent pivot Sep 11, 2021, 1:49 AM

#

maybe in future, but for now we need to get 6, lol

vocal prairie Sep 11, 2021, 1:49 AM

#

Do we have that many significant projects that are accepting open source contribs?

short snow Sep 11, 2021, 1:49 AM

#

quackstack, kubernetes, pixels

#

kubernetes idts

vocal prairie Sep 11, 2021, 1:49 AM

#

True

short snow Sep 11, 2021, 1:49 AM

#

but there isn't another one

#

lol

vocal prairie Sep 11, 2021, 1:50 AM

#

Forms could be a possibility once it becomes not just staff

patent pivot Sep 11, 2021, 1:50 AM

#

Kubernetes has accepted contribs iirc

#

in fact

short snow Sep 11, 2021, 1:50 AM

#

then there you go 🙃

patent pivot Sep 11, 2021, 1:50 AM

#

!remind 14h docs for k8s

stable mountainBOT Sep 11, 2021, 1:50 AM

#

You got it!

Your reminder will arrive on <t:1631375433:F>!

patent pivot Sep 11, 2021, 1:50 AM

#

I'm migrating internal docs from notion to GitHub pages

#

our run books, post-mortems and hopefully much more

thorny obsidian Sep 11, 2021, 1:51 AM

#

nah, .aoc countdown should be fine

short snow Sep 11, 2021, 2:01 AM

#

who is shom770 on discord?

thorny obsidian Sep 11, 2021, 2:02 AM

#

frontogensis iirc?

short snow Sep 11, 2021, 2:05 AM

#

Ah so @trail pilot I really like the use of discord menus for this but as a user, I would like to view the basic information about the challenge first and then if I am interested in it, I would go see the full problem description. So I think there should be two views, one which would be originally sent, something like the original of this PR and then we should go show the full problem (like the default view of the current PR state).

But that's personal preference.

trail pilot Sep 11, 2021, 2:07 AM

#

Hello! Thanks for the feedback. The thing is though that I'm not really sure, as I've gotten conflicting feedback. Some people want the description and the difficulty, then miscellaneous infomration

#

and others want the same as you want

#

So I'm not really sure what to do tbh

short snow Sep 11, 2021, 2:08 AM

#

Ah, I see, we could probably have a vote here?

short snow Sep 11, 2021, 2:52 AM

#

@cold island I think we need to update the message content limits on site

cold island Sep 11, 2021, 2:54 AM

#

I updated it for the embed. I recalled we already updated it in other places. It still bugs out with the latest version of the site?

short snow Sep 11, 2021, 2:55 AM

#

yeah

#

is the capping done on the database, so i would need to create the tables again?

cold island Sep 11, 2021, 2:56 AM

#

Should've been just validation

short snow Sep 11, 2021, 2:58 AM

#

https://github.com/python-discord/site/pull/585/files hmm you did update it pithink

cold island Sep 11, 2021, 3:00 AM

#

Might try running a migration when I'm more awake

short snow Sep 11, 2021, 3:01 AM

#

how do you delete everything from a db

cold island Sep 11, 2021, 3:02 AM

#

I'd just delete the container

short snow Sep 11, 2021, 3:02 AM

#

not running with docker 🙃

cold island Sep 11, 2021, 3:03 AM

#

Well there's your mistake right there

short snow Sep 11, 2021, 3:05 AM

#

kek for some reason, docker just makes my memory usage go brrr, so i use it only for extreme cases

sullen phoenix Sep 11, 2021, 3:22 AM

#

delete the db with DROP DATABASE <name> lol

#

don't go fooling around with that in production though lmao

#

i vaguely remember someone dropping some dbs in production..

short snow Sep 11, 2021, 3:32 AM

#

Yeah I don't do that in production, just seeing if that's the problem with the content limits

trail pilot Sep 11, 2021, 4:15 AM

#

short snow Ah, I see, we could probably have a vote here?

Alright:

#

React to this for Option 1, Option 1 is the image below:

#

React to this for Option 2, Option 2 is the image below:

#

uncut shore Sep 11, 2021, 4:19 AM

#

!voiceverification

stable mountainBOT Sep 11, 2021, 4:19 AM

#

Voice verification

Can’t talk in voice chat? Check out #voice-verification to get access. The criteria for verifying are specified there.

proper oyster Sep 11, 2021, 7:05 AM

#

#bot-commands

fallen patrol Sep 11, 2021, 7:32 AM

#

Hey, could sir-lance get the trashcan added to the bottom of issue autolinking?

#

#

I've done it here, its not hard, willing to implement it for lance ( since all of the stuff for it already exists)

placid ermine Sep 11, 2021, 8:04 AM

#

trail pilot React to this for Option 1, Option 1 is the image below:

imo the main problem statement deserves more space in the embed

#

this stuff isn't as important

molten perch Sep 11, 2021, 8:12 AM

#

fallen patrol Hey, could sir-lance get the trashcan added to the bottom of issue autolinking?

I’m not sure about the “button policy” but it might look a bit better with a button 😄

fallen patrol Sep 11, 2021, 8:14 AM

#

Well

#

The automatic file link stuff already has a trashcan

#

And IMO anything that parses user msgs like should have an option to delete the response

glacial veldt Sep 11, 2021, 8:28 AM

#

uhh is this supposed to happen? #async-and-concurrency message

static canyon Sep 11, 2021, 8:29 AM

#

[Errno 38] Function not implemented
I'd guess the feature was removed from snekbox to protect it

#

Can't be certain though

cold island Sep 11, 2021, 10:46 AM

#

short snow <@!512354988157173763> I think we need to update the message content limits on s...

I tested it locally now and it seems to work

#

(on main)

dim pelican Sep 11, 2021, 1:00 PM

#

Hey all, can I get some opinions on this? https://github.com/python-discord/sir-lancebot/pull/859#issuecomment-915352246
sir-lancebot#859

dusky shoreBOT Sep 11, 2021, 1:00 PM

#

GitHub

PROpen Add WTF Python Command

dim pelican Sep 11, 2021, 1:01 PM

#

Essentially I am at a stand still trying to figure out whether to leave the command the way it is, with sending a link, or sending the text of the README section, or as Joe suggested, writing to a file and letting Discord preview it.

short snow Sep 11, 2021, 1:07 PM

#

cold island I tested it locally now and it seems to work

Alright cool, my nitro gone so I can't test it anyways now lemon_pensive

sinful knot Sep 11, 2021, 2:25 PM

#

ah I noticed my code had bugs and fixed it but someone else is actually working on it smh

trail pilot Sep 11, 2021, 2:46 PM

#

placid ermine imo the main problem statement deserves more space in the embed

Yeah, the new one has only the desc and the difficuty on the front page

#

then other info

placid ermine Sep 11, 2021, 3:10 PM

#

👍

static canyon Sep 11, 2021, 3:15 PM

#

dim pelican Essentially I am at a stand still trying to figure out whether to leave the comm...

Joe's suggestion seems a good middle ground imo

#

But also link to since preview doesn't exist on mobile

sinful knot Sep 11, 2021, 3:19 PM

#

hey I'm the guy who worked on the markdown escaping in python news before.
by the time I noticed you were working on it, I also worked on a fix if you wanna look at it
https://github.com/Ryu1845/bot/commit/5a6dc8840fa39cb5d6baedd166a48569f45e26e8
@static canyon

#

it works afaik

dim pelican Sep 11, 2021, 3:20 PM

#

Thanks @static canyon !

green oriole Sep 11, 2021, 3:29 PM

#

fallen patrol Hey, could sir-lance get the trashcan added to the bottom of issue autolinking?

Sure, feel free to PR it, you have my approval

green oriole Sep 11, 2021, 3:30 PM

#

glacial veldt uhh is this supposed to happen? https://discord.com/channels/267624335836053506/...

Haha, that's an interesting error. It is most probably because it doesn't have the permission to create a lock.

stable mountainBOT Sep 11, 2021, 3:50 PM

#

patent pivot !remind 14h docs for k8s

It has arrived!

Here's your reminder: docs for k8s
[Jump back to when you created the reminder](#dev-contrib message)

trail pilot Sep 11, 2021, 3:51 PM

#

placid ermine 👍

it looks like this

placid ermine Sep 11, 2021, 3:52 PM

#

that's perfect

trail pilot Sep 11, 2021, 3:52 PM

#

placid ermine that's perfect

And in case people want to see more information, the dropdown is there with different pages of information

placid ermine Sep 11, 2021, 3:52 PM

#

nice

#

is this the first command on lance with menus/buttons 👀

glacial veldt Sep 11, 2021, 3:55 PM

#

green oriole Haha, that's an interesting error. It is most probably because it doesn't have t...

Yeah it's odd because I'm sure I tested it when the permission to make more processes was added

trail pilot Sep 11, 2021, 3:55 PM

#

placid ermine is this the first command on lance with menus/buttons 👀

Yep

#

I might start adding buttons to other commands

#

like possibly buttons for tictactoe

brazen charm Sep 11, 2021, 3:57 PM

#

glacial veldt Yeah it's odd because I'm sure I tested it when the permission to make more proc...

Processes themselves work fine

trail pilot Sep 11, 2021, 3:57 PM

#

at least making issues for it

brazen charm Sep 11, 2021, 3:58 PM

#

what's the view button for when the title has the link?

trail pilot Sep 11, 2021, 4:10 PM

#

brazen charm what's the view button for when the title has the link?

Wdym?

#

Ohhh

#

It was on my PR

#

to add the link to the name along with the link button

green oriole Sep 11, 2021, 4:12 PM

#

glacial veldt Yeah it's odd because I'm sure I tested it when the permission to make more proc...

Oh we raised the process limit?

glacial veldt Sep 11, 2021, 4:14 PM

#

From 1 to like 5?

patent pivot Sep 11, 2021, 4:37 PM

#

think we went 6 or something in the end so that a multiprocessing pool worked

cold island Sep 11, 2021, 4:37 PM

#

short snow Alright cool, my nitro gone so I can't test it anyways now <:lemon_pensive:75444...

You can. I noticed the error because I tried to clean the help embed for the top-level command, which is over 2000 characters. Bots don't need nitro to post over 2000 characters embeds

vale ibex Sep 11, 2021, 5:31 PM

#

@brazen charm Just out of interest, since my knowledge on async is a little limited. What is the use of specifying a loop, if it'll just get the running one anyway?

brazen charm Sep 11, 2021, 5:32 PM

#

The init tasks are started before the loop is started so they'd fail with a runtime error

vale ibex Sep 11, 2021, 5:32 PM

#

ahhh right, so adding it to the bot loop means they'll wait until that loop is started?

brazen charm Sep 11, 2021, 5:33 PM

#

yes, it creates a task bound to that loop and then it'll be scheduled when the loop is started

vale ibex Sep 11, 2021, 5:33 PM

#

That makes a lot of sense, thanks

wild prism Sep 11, 2021, 5:59 PM

#

@thorny obsidian did you do anything with the dddg issue? I can take care of it, I just haven't been paying attention and making sure you're not already sitting on something

thorny obsidian Sep 11, 2021, 6:01 PM

#

wild prism <@!212644551926611969> did you do anything with the dddg issue? I can take care ...

oh nah, I still need to make it

vale ibex Sep 11, 2021, 6:33 PM

#

@cold island What version of docker-compose are you running?

#

I don't get an issue with this compose file

cold island Sep 11, 2021, 6:34 PM

#

Version? how do I check? the version of the compose is set in the file, isn't it?

vale ibex Sep 11, 2021, 6:34 PM

#

docker-compose --version

#

https://github.com/compose-spec/compose-spec/blob/master/spec.md#depends_on

cold island Sep 11, 2021, 6:35 PM

#

1.25.5

vale ibex Sep 11, 2021, 6:35 PM

#

Your terminal is complaining about lines 42-44, but it's valid syntax

#

hmm, I'm on 1.29.2

cold island Sep 11, 2021, 6:36 PM

#

I suppose I can try updating docker

vale ibex Sep 11, 2021, 6:36 PM

#

yea, but it's not a good sign that this is such a recent feature

#

since contribs might run into it too

cold island Sep 11, 2021, 6:36 PM

#

If there's a simple backwards compatible solution then that might be good

vale ibex Sep 11, 2021, 6:36 PM

#

could you try updating the version string in the compose to 3.9 and see if it complains?

cold island Sep 11, 2021, 6:37 PM

#

sec

vale ibex Sep 11, 2021, 6:37 PM

#

I'm hoping it'll give a nicer message saying you need to update

cold island Sep 11, 2021, 6:38 PM

#

Are you sure there's 3.9? https://docs.docker.com/compose/compose-file/compose-versioning/

Docker Documentation

Compose file versions and upgrading

Compose file reference

vale ibex Sep 11, 2021, 6:38 PM

#

https://docs.docker.com/compose/

Docker Documentation

Overview of Docker Compose

Introduction and Overview of Compose

#

has 3.9 in the example so I had guessed that's the most recent

cold island Sep 11, 2021, 6:39 PM

#

Hmm.. I guess since it's from 1.27 my version isn't even aware of it

vale ibex Sep 11, 2021, 6:40 PM

#

yea, that mmakes sense

#

These topics describe the Docker Compose implementation of the Compose format. Docker Compose 1.27.0+ implements the format defined by the Compose Specification.

static canyon Sep 11, 2021, 6:40 PM

#

sinful knot it works afaik

From my testing this doesn't work with multi-line codeblocks, and it also doesn't taken into account pre-escaped markdown (the latter definitely being any easy fix).

Although honestly at this point I've got a working solution so unless you can come up with something better I'll just stick to what I came up with thanks to Zig's help.

vale ibex Sep 11, 2021, 6:41 PM

#

The reason I want to keep this, as it's a very nice way to make containers wait for psql to be ready, rather than doing it in code

#

If we can't use these, I'd need to add health checks to site and metricity, since they don't wait for postgres otherwise

cold island Sep 11, 2021, 6:43 PM

#

I don't mind being on the bleeding edge, I'm just wondering if there's no version of this functionality in 3.8

vale ibex Sep 11, 2021, 6:43 PM

#

It looks like this was added in 1.27

#

rather than a specific compose spec version

cold island Sep 11, 2021, 6:44 PM

#

I see

#

I'll just update then

vale ibex Sep 11, 2021, 6:44 PM

#

I am wonder wtf the version string is for

#

ah

#

cold island Sep 11, 2021, 6:44 PM

#

compose file version

vale ibex Sep 11, 2021, 6:44 PM

#

There is no point

cold island Sep 11, 2021, 6:44 PM

#

lol

gritty wind Sep 11, 2021, 6:45 PM

#

I don't think asking people to upgrade compose is such a bad thing anyways

#

How else would anyone know they even have to update lol

vale ibex Sep 11, 2021, 6:45 PM

#

!vote "If you run docker-compose --version what version is output?" "<1.27.0" ">=1.27.0"

stable mountainBOT Sep 11, 2021, 6:45 PM

#

If you run `docker-compose --version` what version is output?

🇦 - <1.27.0
🇧 - >=1.27.0

gritty wind Sep 11, 2021, 6:45 PM

#

(Doesn't docker windows force updates on you actually)

vale ibex Sep 11, 2021, 6:45 PM

#

yup

#

docker desktop pops up on boot fit here's an update

sinful knot Sep 11, 2021, 6:46 PM

#

static canyon From my testing this doesn't work with multi-line codeblocks, and it also doesn'...

I didn't have any problem with multiline codeblocks can you give me your test?

cold island Sep 11, 2021, 6:46 PM

#

gritty wind (Doesn't docker windows force updates on you actually)

You can skip them indefinitely thisisfinefire

gritty wind Sep 11, 2021, 6:46 PM

#

Ahh

#

I like what chrome does

#

It displays a color in your address bar on the settings button, and it goes from green to blood red the longer you put off an update

static canyon Sep 11, 2021, 6:47 PM

#

sinful knot I didn't have any problem with multiline codeblocks can you give me your test?

Pastelink so I don't have to worry about discord formatting it: https://paste.pythondiscord.com/evibigorij.py
The issue I had is that the __eq__ within the multi-line still gets escaped

gritty wind Sep 11, 2021, 6:47 PM

#

And I exist in the danger zone

vale ibex Sep 11, 2021, 6:48 PM

#

lol

fallen patrol Sep 11, 2021, 6:48 PM

#

.src gh

#

.....

#

at some point

#

i

#

can .src be whitelisted in these channels??

static canyon Sep 11, 2021, 6:49 PM

#

.src

dusky shoreBOT Sep 11, 2021, 6:49 PM

#

Sir Lancebot's GitHub Repository

Repository

Go to GitHub

static canyon Sep 11, 2021, 6:49 PM

#

.src src

dusky shoreBOT Sep 11, 2021, 6:49 PM

#

Command: source

Display information and a GitHub link to the source code of a command, tag, or cog.

Source Code

Go to GitHub

vocal prairie Sep 11, 2021, 6:49 PM

#

That would be nice. I kind of wish that command only took one word for an arg

fallen patrol Sep 11, 2021, 6:49 PM

#

dusky shore

is that a yes 😛

static canyon Sep 11, 2021, 6:49 PM

#

.src gh

dusky shoreBOT Sep 11, 2021, 6:49 PM

#

Command: github

Commands for finding information related to GitHub.

Source Code

Go to GitHub

sinful knot Sep 11, 2021, 6:49 PM

#

static canyon Pastelink so I don't have to worry about discord formatting it: https://paste.py...

it is escaped in the string you sent xD

trail pilot Sep 11, 2021, 6:50 PM

#

by the way src can be weird sometimes

#

.src help help help help help

static canyon Sep 11, 2021, 6:50 PM

#

sinful knot it is escaped in the string you sent xD

So it is 🤦

trail pilot Sep 11, 2021, 6:50 PM

#

#sir-lancebot-playground message

sinful knot Sep 11, 2021, 6:50 PM

#

static canyon So it is 🤦

I'd have to unescape it???

vale ibex Sep 11, 2021, 6:50 PM

#

trail pilot https://discord.com/channels/267624335836053506/607247579608121354/8863227658026...

what's wrong with that?

static canyon Sep 11, 2021, 6:50 PM

#

fallen patrol is that a yes 😛

Yeah, I don't see what's wrong with that

vocal prairie Sep 11, 2021, 6:50 PM

#

trail pilot by the way src can be weird sometimes

.src test
whattt. This fails

dusky shoreBOT Sep 11, 2021, 6:50 PM

#

That was a mistake.

Your input was invalid: Unable to convert test whattt. This fails to valid command or Cog.

Usage:```
.source [source_item]

trail pilot Sep 11, 2021, 6:51 PM

#

vale ibex what's wrong with that?

just confused on how it handles stuff
Because help help help help is a valid src?

vocal prairie Sep 11, 2021, 6:51 PM

#

I don't get why this takes the whole sentence and that doesn't

trail pilot Sep 11, 2021, 6:51 PM

#

yea^

sinful knot Sep 11, 2021, 6:51 PM

#

static canyon So it is 🤦

I mean that the string you sent has the backslashes in it

vale ibex Sep 11, 2021, 6:52 PM

#

.src help ping

dusky shoreBOT Sep 11, 2021, 6:52 PM

#

Command: help

Shows Command Help.

Source Code

Go to GitHub

vale ibex Sep 11, 2021, 6:52 PM

#

.src help some random

dusky shoreBOT Sep 11, 2021, 6:52 PM

#

Command: help

Shows Command Help.

Source Code

Go to GitHub

sinful knot Sep 11, 2021, 6:52 PM

#

static canyon So it is 🤦

so of course they're still there afterwards

fallen patrol Sep 11, 2021, 6:52 PM

#

ah yeah

vale ibex Sep 11, 2021, 6:52 PM

#

I mean it just uses the first arg right?

fallen patrol Sep 11, 2021, 6:52 PM

#

@vale ibex check the source, it has a special check for help

vale ibex Sep 11, 2021, 6:52 PM

#

.src ping ping

dusky shoreBOT Sep 11, 2021, 6:52 PM

#

Command: ping

Ping the bot to see its latency and state.

Source Code

Go to GitHub

vale ibex Sep 11, 2021, 6:52 PM

#

.src ping random

static canyon Sep 11, 2021, 6:52 PM

#

@sinful knot
edit: doesn't have the dotall which is probs why

dusky shoreBOT Sep 11, 2021, 6:52 PM

#

Command: ping

Ping the bot to see its latency and state.

Source Code

Go to GitHub

vale ibex Sep 11, 2021, 6:52 PM

#

??

#

I don't see the issue

fallen patrol Sep 11, 2021, 6:52 PM

#

vale ibex Sep 11, 2021, 6:52 PM

#

well yea, that's not a valid cog

fallen patrol Sep 11, 2021, 6:53 PM

#

vale ibex Sep 11, 2021, 6:53 PM

#

ooga isn't a valid command

sinful knot Sep 11, 2021, 6:53 PM

#

static canyon <@!791120905651617812> edit: doesn't have the dotall which is probs why

vale ibex Sep 11, 2021, 6:53 PM

#

so you'd expect it not to error?

#

I might be missing something here, but if you give it an invalid command, then it'll error, if you give it a valid one it'll give you the source?

sinful knot Sep 11, 2021, 6:54 PM

#

static canyon <@!791120905651617812> edit: doesn't have the dotall which is probs why

look in the link you sent
https://paste.pythondiscord.com/evibigorij.py

patent pivot Sep 11, 2021, 6:54 PM

#

that's working as expected

static canyon Sep 11, 2021, 6:54 PM

#

sinful knot look in the link you sent https://paste.pythondiscord.com/evibigorij.py

That image shows the definition without it escaped, but the issue was that the version you sent didn't have the DOTALL flag

fallen patrol Sep 11, 2021, 6:54 PM

#

vale ibex ooga isn't a valid command

oofadf is not a valid command. That should error.

fallen patrol Sep 11, 2021, 6:54 PM

#

fallen patrol

this is the bug.

vale ibex Sep 11, 2021, 6:54 PM

#

yea, but it only looks at the first arg right?

fallen patrol Sep 11, 2021, 6:54 PM

#

fallen patrol

does it?

#

that one got both

patent pivot Sep 11, 2021, 6:55 PM

#

it looks for subcommands

#

it won't factor in arguments

#

that is working as expected, there is no bug

sinful knot Sep 11, 2021, 6:55 PM

#

static canyon That image shows the definition without it escaped, but the issue was that the v...

but the commit I sent you does?

patent pivot Sep 11, 2021, 6:55 PM

#

it resolved up to the last working command and returned the help for that

vale ibex Sep 11, 2021, 6:55 PM

#

this

fallen patrol Sep 11, 2021, 6:55 PM

#

then why

static canyon Sep 11, 2021, 6:55 PM

#

sinful knot but the commit I sent you does?

It doesn't?

fallen patrol Sep 11, 2021, 6:55 PM

#

vale ibex Sep 11, 2021, 6:55 PM

#

.src ping Check here for the source of the ping command

dusky shoreBOT Sep 11, 2021, 6:55 PM

#

Command: ping

Ping the bot to see its latency and state.

Source Code

Go to GitHub

fallen patrol Sep 11, 2021, 6:55 PM

#

does this error

#

hmmmm

vale ibex Sep 11, 2021, 6:56 PM

#

because sdf isn't a sub command

fallen patrol Sep 11, 2021, 6:56 PM

#

because ext is a command isn't it?

vocal prairie Sep 11, 2021, 6:56 PM

#

ahh, it's subcommands

#

that makes more sense

fallen patrol Sep 11, 2021, 6:56 PM

#

vale ibex because sdf isn't a sub command

well Check isn't a subcommand of ping and that worked.

vale ibex Sep 11, 2021, 6:56 PM

#

yea, but ping doesn't have sub commands

vocal prairie Sep 11, 2021, 6:57 PM

#

ping has no subcommands, so it doesn't check for them

static canyon Sep 11, 2021, 6:57 PM

#

They one you linked on Discord does but I copied from the one you linked on GH which doesn't @sinful knot

patent pivot Sep 11, 2021, 6:57 PM

#

yeah it's fine, I'm telling you, this isn't a bug

sinful knot Sep 11, 2021, 6:58 PM

#

static canyon They one you linked on Discord does but I copied from the one you linked on GH w...

but it's the same

static canyon Sep 11, 2021, 7:00 PM

#

sinful knot but it's the same

sinful knot Sep 11, 2021, 7:00 PM

#

huh

vale ibex Sep 11, 2021, 7:00 PM

#

@cold island @green oriole re bot#1817 this regex isn't behaving as I'd expect. See https://regex101.com/r/jCW2t4/1 it doesn't match for this string, even though I'd expect it too

dusky shoreBOT Sep 11, 2021, 7:00 PM

#

GitHub

PROpen Regex: add a word boundary before .gg

vale ibex Sep 11, 2021, 7:00 PM

#

For some reason changing the \b to \B works

sinful knot Sep 11, 2021, 7:01 PM

#

static canyon

you're not seeing the most recent version for some reason?

cold island Sep 11, 2021, 7:03 PM

#

cold island I'll just update then

Hmm I'm up to date now but version is still 1.25

green oriole Sep 11, 2021, 7:03 PM

#

Huh

#

That's interesting

#

I'll have a look tomorrow

#

That and the robots.txt PR

static canyon Sep 11, 2021, 7:04 PM

#

@sinful knot you also have to use *? instead of just * for the codeblock part, or it breaks when there's more than one

vale ibex Sep 11, 2021, 7:04 PM

#

green oriole That and the robots.txt PR

sinful knot Sep 11, 2021, 7:05 PM

#

static canyon <@!791120905651617812> you also have to use `*?` instead of just `*` for the cod...

I know
https://github.com/Ryu1845/bot/commit/5a6dc8840fa39cb5d6baedd166a48569f45e26e8#diff-a5e847a4b76e807117aea9a2441d5cb71222e8c26c50b974ad07ca492bf3b848R80

#

are you still using an outdated version?

vale ibex Sep 11, 2021, 7:06 PM

#

cold island Hmm I'm up to date now but version is still 1.25

that's weird what os are you on/what method for update did you use?

cold island Sep 11, 2021, 7:06 PM

#

vale ibex For some reason changing the \b to \B works

Ahh I think it's because the dot itself is not a word

vale ibex Sep 11, 2021, 7:06 PM

#

Makes sense

cold island Sep 11, 2021, 7:06 PM

#

So a word boundary doesn't really make sense

static canyon Sep 11, 2021, 7:06 PM

#

sinful knot I know https://github.com/Ryu1845/bot/commit/5a6dc8840fa39cb5d6baedd166a48569f45...

You should add the negative look-behind thing as well to not escape pre-escaped markdown (i.e. (?<!\\))

vale ibex Sep 11, 2021, 7:07 PM

#

Ah yea, it matches on dotgg/

vocal prairie Sep 11, 2021, 7:07 PM

#

vale ibex !vote "If you run `docker-compose --version` what version is output?" "<1.27.0" ...

I'm on v2.0.0-rc.1, pydis projects start fine

vale ibex Sep 11, 2021, 7:08 PM

#

bleeeeeding edge there dawn

#

nicee

cold island Sep 11, 2021, 7:08 PM

#

cold island Ahh I think it's because the dot itself is not a word

A way to fix that would be a negative lookbehind for a \w

vocal prairie Sep 11, 2021, 7:08 PM

#

yeah, I broke docker-compose a while ago so I started using it as part of the docker cli

cold island Sep 11, 2021, 7:09 PM

#

vale ibex that's weird what os are you on/what method for update did you use?

I'm on Windows. compose came with docker desktop, so I just tried updating that

vale ibex Sep 11, 2021, 7:09 PM

#

yea that's all I had to do

#

Maybe it needs a reboot? shrugR

cold island Sep 11, 2021, 7:10 PM

#

ugh, maybe

vale ibex Sep 11, 2021, 7:10 PM

#

unless the old version is still there and your path env has it hoisted

sinful knot Sep 11, 2021, 7:11 PM

#

static canyon You should add the negative look-behind thing as well to not escape pre-escaped ...

I don't understand what this does, could you explain?

cold island Sep 11, 2021, 7:11 PM

#

It checks that there's no preceding slash

#

It's called a negative lookbehind

static canyon Sep 11, 2021, 7:13 PM

#

sinful knot I don't understand what this does, could you explain?

re.sub(
    r"(?P<code_block>`.*?`)|(?P<markdown>(?<!\\)[_|])",
    lambda match: "\\" + match.groupdict()["markdown"]
    if match.groupdict()["markdown"] is not None
    else match.groupdict()["code_block"],
    string,
    flags=re.DOTALL,
)```it's used in the markdown part, to essentially say "match `_` or `|`, but not if it has a `\` before it"

#

Aka don't match pre-escaped markdown

sinful knot Sep 11, 2021, 7:13 PM

#

Ah ok got it thx

brisk brook Sep 11, 2021, 7:15 PM

#

gritty wind And I exist in the danger zone

Didn't you setup your computer like yesterday

gritty wind Sep 11, 2021, 7:15 PM

#

Shh don't expose me like this

static canyon Sep 11, 2021, 7:16 PM

#

# By first matching everything within a codeblock,
# when matching markdown it won't be within a codeblock
MARKDOWN_REGEX = re.compile(
    r"(?P<code_block>`.*?`)"  # matches everything within a codeblock
    r"|(?P<markdown>(?<!\\)[_|])",  # matches unescaped `_` and `|`
    re.DOTALL
)

...
def escape_markdown(content):
    """..."""
    return re.sub(
        MARKDOWN_REGEX,
        lambda match: "\\" + markdown_group
        if (markdown_group := match.group("markdown"))
        else match.group("code_block"),
        content
    )```I guess this is the end-version that I'd PR if I go for this @sinful knot

#

Thoughts?

fallen patrol Sep 11, 2021, 7:17 PM

#

brisk brook Didn't you setup your computer like yesterday

lol i used vsc all day yesterday with a pending update 👀

#

if I had closed vsc it would have updated

cold island Sep 11, 2021, 7:20 PM

#

static canyon ```py # By first matching everything within a codeblock, # when matching markdow...

MARKDOWN_REGEX.sub(...) with no flags

static canyon Sep 11, 2021, 7:20 PM

#

Right yeah

#

Move the re.DOTALL

sinful knot Sep 11, 2021, 7:20 PM

#

static canyon ```py # By first matching everything within a codeblock, # when matching markdow...

Looks about right.
I missed the part about using names with the group method in the docs, I thought it was stupid doing it with groupdict xD

fallen patrol Sep 11, 2021, 7:21 PM

#

oh that's what the r is for

cold island Sep 11, 2021, 7:21 PM

#

vale ibex Maybe it needs a reboot? <:shrugR:727587457046151301>

nope

fallen patrol Sep 11, 2021, 7:21 PM

#

regex

cold island Sep 11, 2021, 7:21 PM

#

Considering just re-installing docker

cold island Sep 11, 2021, 7:21 PM

#

fallen patrol `r`egex

raw

fallen patrol Sep 11, 2021, 7:21 PM

#

oh

cold island Sep 11, 2021, 7:21 PM

#

Means, escape all special characters

#

so \n is literally slash-n and not a newline

fallen patrol Sep 11, 2021, 7:24 PM

#

ah

static canyon Sep 11, 2021, 7:25 PM

#

sinful knot Looks about right. I missed the part about using names with the group method in ...

Thoughts on the added walrus to previous double .group lookup?

#

I'm a big advocate of walrus so use it pretty much wherever I can

sinful knot Sep 11, 2021, 7:28 PM

#

static canyon Thoughts on the added walrus to previous double `.group` lookup?

It's kinda useless imo
it looks weird considering it's defined after being used when you read the code and it's not really more explicit

cold island Sep 11, 2021, 7:29 PM

#

static canyon Thoughts on the added walrus to previous double `.group` lookup?

You don't gain much and since it's in a comprehension just seems confusing

green oriole Sep 11, 2021, 7:29 PM

#

static canyon ```py # By first matching everything within a codeblock, # when matching markdow...

Eh, match.group("markdown") or match.group("code_block") is much l'or readable imo

cold island Sep 11, 2021, 7:30 PM

#

green oriole Eh, `match.group("markdown") or match.group("code_block")` is much l'or readable...

Not equivalent to the above expression though

green oriole Sep 11, 2021, 7:30 PM

#

Is it

cold island Sep 11, 2021, 7:30 PM

#

Because of the slash

green oriole Sep 11, 2021, 7:30 PM

#

Yeah, plus the slash

#

Oh wait

cold island Sep 11, 2021, 7:31 PM

#

the or won't work with the slash though

green oriole Sep 11, 2021, 7:31 PM

#

You don't want to add a slash if markdown didn't match?

static canyon Sep 11, 2021, 7:31 PM

#

markdown has slash, code_block does not

green oriole Sep 11, 2021, 7:32 PM

#

Doesn't re.Match.group return None if there is no match though

#

Oh nevermind, that works

cold island Sep 11, 2021, 7:32 PM

#

You can switch it around I guess. Check if there is a codeblock

#

match.group("code_block") or "\\" + match.group("markdown")

green oriole Sep 11, 2021, 7:32 PM

#

Eeeh, I feel like it should be a function with an explicit if. I find it very hard to understand as you may have guessed haha

#

That or works too

static canyon Sep 11, 2021, 7:33 PM

#

cold island `match.group("code_block") or "\\" + match.group("markdown")`

Does this work though? Do we always want to use code_block when it's not None?

#

The two statements aren't the same

cold island Sep 11, 2021, 7:34 PM

#

We want the code block to still be in the escaped text, do we not?

green oriole Sep 11, 2021, 7:35 PM

#

amegablobsweats

static canyon Sep 11, 2021, 7:35 PM

#

What I'm saying is both code_block and markdown can be not-None

green oriole Sep 11, 2021, 7:35 PM

#

Can we just use an actual function please

cold island Sep 11, 2021, 7:35 PM

#

static canyon What I'm saying is both `code_block` and `markdown` can be not-None

How? each starts with a different character

static canyon Sep 11, 2021, 7:35 PM

#

Because it's an | (or)

cold island Sep 11, 2021, 7:35 PM

#

Yes

static canyon Sep 11, 2021, 7:35 PM

#

Wait nvm

cold island Sep 11, 2021, 7:35 PM

#

So only one

static canyon Sep 11, 2021, 7:36 PM

#

codeblock|markdown can only give one or the other?

cold island Sep 11, 2021, 7:36 PM

#

Correct

green oriole Sep 11, 2021, 7:36 PM

#

if markdown_match := match.group("markdown"):
    return r"\" + markdown_group
else:
    return match.group("code_block")
```and everyone is happy

cold island Sep 11, 2021, 7:36 PM

#

If it matches one part, it won't continue to the next

gritty wind Sep 11, 2021, 7:36 PM

#

Anyone know how the changelog blacklist works with threads?

static canyon Sep 11, 2021, 7:37 PM

#

green oriole ```py if markdown_match := match.group("markdown"): return r"\" + markdown_g...

It'd be "\\" + markdown_group but yea

cold island Sep 11, 2021, 7:37 PM

#

gritty wind Anyone know how the changelog blacklist works with threads?

changelog blacklist?

static canyon Sep 11, 2021, 7:37 PM

#

r"\" doesn't work btw

green oriole Sep 11, 2021, 7:37 PM

#

Fair

gritty wind Sep 11, 2021, 7:37 PM

#

As expected is the answer

#

It's called that in the config

#

Basically what channels are ignored from #message-change-log

green oriole Sep 11, 2021, 7:37 PM

#

gritty wind Anyone know how the changelog blacklist works with threads?

Right now it won't look at the parent channel and I should totally add that

gritty wind Sep 11, 2021, 7:38 PM

#

I mean, see #staff-voice

green oriole Sep 11, 2021, 7:38 PM

#

!remind 13h this

stable mountainBOT Sep 11, 2021, 7:38 PM

#

I'll allow it.

Your reminder will arrive on <t:1631435885:F>!

gritty wind Sep 11, 2021, 7:38 PM

#

It ignores threads is what I'm saying

green oriole Sep 11, 2021, 7:38 PM

#

I mean

#

2.0 hasn't been merged lol

static canyon Sep 11, 2021, 7:38 PM

#

green oriole ```py if markdown_match := match.group("markdown"): return r"\" + markdown_g...

What would the function be called? process_markdown_regex or something?

cold island Sep 11, 2021, 7:38 PM

#

# By first matching everything within a codeblock,
# when matching markdown it won't be within a codeblock
MARKDOWN_REGEX = re.compile(
    r"(?P<code_block>`.*?`)"  # matches everything within a codeblock
    r"|(?P<markdown>(?<!\\)[_|])",  # matches unescaped `_` and `|`
    re.DOTALL
)

...
def escape_markdown(content):
    """..."""
    return MARKDOWN_REGEX.sub(
        lambda match: match.group("code_block") or "\\" + match.group("markdown"),
        content
    )

Seems fine, assuming it works

gritty wind Sep 11, 2021, 7:38 PM

#

Oh fair lol

green oriole Sep 11, 2021, 7:38 PM

#

static canyon What would the function be called? `process_markdown_regex` or something?

Yeah, that works

static canyon Sep 11, 2021, 7:39 PM

#

I'll test what Zig said and if it works I'll go with it

#

Otherwise I'll make it a function

green oriole Sep 11, 2021, 7:40 PM

#

I've realized I totally overlooked #message-change-log when migrating to 2.0, I shall fix that

cold island Sep 11, 2021, 7:41 PM

#

Threads shouldn't be blacklisted though

static canyon Sep 11, 2021, 7:41 PM

#

It doesn't work

cold island Sep 11, 2021, 7:41 PM

#

cold island Threads shouldn't be blacklisted though

unless you mean threads within blacklisted channels

green oriole Sep 11, 2021, 7:41 PM

#

Yeah, like threads in #admins should be blacklisted

static canyon Sep 11, 2021, 7:41 PM

#

wait a sec

green oriole Sep 11, 2021, 7:41 PM

#

Also #mod-log should have better messages than "channel created"

static canyon Sep 11, 2021, 7:43 PM

#

It seems to work

#

So I'll go with Zig's message

static canyon Sep 11, 2021, 7:44 PM

#

cold island ```py # By first matching everything within a codeblock, # when matching markdow...

aka this

cold island Sep 11, 2021, 7:44 PM

#

Which is really just a combo of what Ryu and Akarys suggested

static canyon Sep 11, 2021, 7:44 PM

#

Yeah

#

# By first matching everything within a code block,
# when matching markdown it won't be within a code block
MARKDOWN_REGEX = re.compile(
    r"(?P<code_block>`.*?`)"  # matches everything within a codeblock
    r"|(?P<markdown>(?<!\\)[_|])",  # matches unescaped `_` and `|`
    re.DOTALL  # required to support multi-line code blocks
)
...
    @staticmethod
    def escape_markdown(content: str) -> str:
        """Escape the markdown underlines and spoilers that aren't in codeblocks."""
        return MARKDOWN_REGEX.sub(
            lambda match: match.group("code_block") or "\\" + match.group("markdown"),
            content
        )```this look good?

cold island Sep 11, 2021, 7:45 PM

#

You can include Ryu as co-author fwiw

green oriole Sep 11, 2021, 7:47 PM

#

OK I didn't want any co-authoring anyway lemon_pensive

static canyon Sep 11, 2021, 7:47 PM

#

static canyon ```py # By first matching everything within a code block, # when matching markdo...

Should I push this?

gritty wind Sep 11, 2021, 7:48 PM

#

Can I get some quick reviews on

#

https://github.com/python-discord/bot/pull/1826

#

Just a change to config, shouldn't take much time

cold island Sep 11, 2021, 7:49 PM

#

static canyon Should I push this?

If it works blobshrug

static canyon Sep 11, 2021, 7:49 PM

#

Aight

#

And how exactly do I add a co-author?

cold island Sep 11, 2021, 7:51 PM

#

Co-authored-by: username <email>

#

In the commit body

fallen patrol Sep 11, 2021, 7:51 PM

#

so what is message changelog

static canyon Sep 11, 2021, 7:52 PM

#

It can go in the description right?

cold island Sep 11, 2021, 7:52 PM

#

static canyon It can go in the description right?

has to be there

brazen charm Sep 11, 2021, 7:52 PM

#

Yes, at the bottom

gritty wind Sep 11, 2021, 7:52 PM

#

Morged, thanks y'all

static canyon Sep 11, 2021, 7:53 PM

#

username or @username ?

fallen patrol Sep 11, 2021, 7:53 PM

#

fallen patrol so what is message changelog

@gritty wind

#

i saw that pr but what even was it

gritty wind Sep 11, 2021, 7:53 PM

#

Message change log is the dark place where edited/deleted messages get logged for moderation purposes

fallen patrol Sep 11, 2021, 7:53 PM

#

ah

#

👀

#

and this channel is exempt

#

noice

gritty wind Sep 11, 2021, 7:53 PM

#

The blacklist excludes certain channels from making it there, such as the admins channel

fallen patrol Sep 11, 2021, 7:54 PM

#

#dev-contrib

#

lol

brazen charm Sep 11, 2021, 7:54 PM

#

this channel is not excluded

fallen patrol Sep 11, 2021, 7:54 PM

#

this channel is exempt

#

oh

#

wait

#

https://github.com/python-discord/bot/commit/71ce990ba28dca3edf713ac28eff81065155f793

GitHub

Adds Core Dev Voting To Changelog Blacklist · python-discord/bot@71...

Adds the channel used for voting on contributors to the message
changelog blacklist.

Signed-off-by: Hassan Abouelela

#

that diff confused me

gritty wind Sep 11, 2021, 7:55 PM

#

Had to do it that way to maintain alignment

fallen patrol Sep 11, 2021, 7:55 PM

#

#core-dev-voting is the exempt channel

#

why is it named core-dev and not dev-core

gritty wind Sep 11, 2021, 7:55 PM

#

#core-dev-announcements

patent pivot Sep 11, 2021, 7:56 PM

#

fallen patrol *why is it named core-dev and not dev-core*

because it's voting on core devs

#

not voting on dev cores

fallen patrol Sep 11, 2021, 7:57 PM

#

ah

cold island Sep 11, 2021, 7:58 PM

#

cold island Considering just re-installing docker

It's still 1.25 (╯°□°）╯︵ ┻━┻

#

Time for a new computer

green oriole Sep 11, 2021, 7:59 PM

#

lol

#

What is the issue?

static canyon Sep 11, 2021, 7:59 PM

#

cold island `Co-authored-by: username <email>`

Don't think I did it right

#

bot#1822

dusky shoreBOT Sep 11, 2021, 7:59 PM

#

GitHub

PROpen Fix escapes in python-news posts

static canyon Sep 11, 2021, 7:59 PM

#

https://github.com/python-discord/bot/pull/1822/commits/a8338895bdc892fe7390514e196443e031fce5d0

green oriole Sep 11, 2021, 7:59 PM

#

I'd usually just copy paste the author line from a commit of this user

#

Yeah, you forgot the 📧

#

Wat

#

The email

static canyon Sep 11, 2021, 8:00 PM

#

It doesn't show the email on the github page though

#

So idk it

#

Unless I'm blind

fallen patrol Sep 11, 2021, 8:00 PM

#

pretty sure caps: Co-Authored-By: username <email>

green oriole Sep 11, 2021, 8:00 PM

#

For example, look at the from line here https://github.com/python-discord/bot/commit/a8338895bdc892fe7390514e196443e031fce5d0.patch

#

Actually I'll use mine since it doesn't have any private information

#

My author line is usually Matteo Bertucci <matteobertucci2004@gmail.com>

#

So you can add to your commit Co-authored-by: Matteo Bertucci <matteobertucci2004@gmail.com>

static canyon Sep 11, 2021, 8:01 PM

#

Ah, got it

#

ty

green oriole Sep 11, 2021, 8:02 PM

#

If you are wondering how I got this link btw, you just have to find a commit from the author you want to co author and add .patch at the end of the url

static canyon Sep 11, 2021, 8:02 PM

#

Yeah

#

I noticed

cold island Sep 11, 2021, 8:02 PM

#

What horrible UI

green oriole Sep 11, 2021, 8:02 PM

#

I think it makes sense

cold island Sep 11, 2021, 8:03 PM

#

green oriole What is the issue?

I'm trying to update docker-compose to latest version

green oriole Sep 11, 2021, 8:03 PM

#

Please tell me you aren't on windows

cold island Sep 11, 2021, 8:03 PM

#

I am

green oriole Sep 11, 2021, 8:03 PM

#

Gosh no

#

Could you just pip install it?

#

And pretend the docker desktop version doesn't exist?

static canyon Sep 11, 2021, 8:04 PM

#

There we go, it worked this time. Thanks @green oriole 👍

green oriole Sep 11, 2021, 8:04 PM

#

No probs

cold island Sep 11, 2021, 8:06 PM

#

green oriole Could you just pip install it?

That worked, thank you

green oriole Sep 11, 2021, 8:08 PM

#

Sweet

brisk brook Sep 11, 2021, 8:14 PM

#

static canyon `username` or `@username` ?

This is the same as you see in git log

cold island Sep 11, 2021, 8:23 PM

#

@vale ibex hmmm how can I start the bot with metricity but assume site is already up

vale ibex Sep 11, 2021, 8:24 PM

#

How would you start the bot now and assume site is already up?

#

Since bot depends on web now, I don't think you can, so we're not regressing on that

#

for these edge cases, you can make a docker-compose override file

cold island Sep 11, 2021, 8:26 PM

#

The issue is that I want to test the whole thing, but I can't test your bot branch with the site main version

#

I need to use your site branch

vale ibex Sep 11, 2021, 8:26 PM

#

Ah, if you build the site image from my branch

#

then change the image string in the bot compose to the name of the local image, rather than the url

#

IE image: ghcr.io/python-discord/site:latest -> image: site_web

cold island Sep 11, 2021, 8:29 PM

#

yeah tried it just now, doesn't work

#

can't connect

vale ibex Sep 11, 2021, 8:30 PM

#

did you stop the site container?

cold island Sep 11, 2021, 8:31 PM

#

yeah

#

otherwise it would say the port is busy

vale ibex Sep 11, 2021, 8:32 PM

#

hmmm

#

That's odd

#

What's the error?

cold island Sep 11, 2021, 8:32 PM

#

Ahh I think I know, the config is set to running the bot locally

vale ibex Sep 11, 2021, 8:33 PM

#

Which config?

cold island Sep 11, 2021, 8:33 PM

#

the bot's

vale ibex Sep 11, 2021, 8:33 PM

#

how so?

#

I run it all in docker fine

cold island Sep 11, 2021, 8:33 PM

#

Nope, still not connecting

vale ibex Sep 11, 2021, 8:33 PM

#

So the only change from my branch you've made is setting the site image right?

cold island Sep 11, 2021, 8:34 PM

#

yeah

vale ibex Sep 11, 2021, 8:34 PM

#

kk lemme try

#

kk, I've checked out my site branch and building that image

#

I then kill the container and do docker-compose down

#

checkout my bot branch and change site image to site_web

#

docker-compose up

#

site starts before metricty finishes migrations

#

hmmm

#

ah lol

#

line 49

#

I've got metricity pushing to pysite

sinful knot Sep 11, 2021, 8:40 PM

#

@static canyon you might wanna add escaping to the titles
#mailing-lists message

vale ibex Sep 11, 2021, 8:40 PM

#

kk that commit should sort it @cold island

#

nice catch, since I think had psql already migrated somehow when testing 😦

cold island Sep 11, 2021, 8:57 PM

#

vale ibex Sep 11, 2021, 8:58 PM

#

lmfao

austere hornet Sep 11, 2021, 9:00 PM

#

cold island

Lmfao

patent pivot Sep 11, 2021, 9:14 PM

#

lmfao

#

!duckify #dev-contrib message

cold island Sep 11, 2021, 9:29 PM

#

vale ibex kk that commit should sort it <@!512354988157173763>

still no

vale ibex Sep 11, 2021, 9:30 PM

#

Is it an error within docker, or a container

#

I only ask as that fixed worked for me, on a fresh setup

cold island Sep 11, 2021, 9:31 PM

#

vale ibex Sep 11, 2021, 9:31 PM

#

it looks like your config.yml is trying to connect to localhost

#

rather than site in docker

cold island Sep 11, 2021, 9:31 PM

#

yyyes.. that's what I always used to run the bot

#

Should I change it to web?

vale ibex Sep 11, 2021, 9:32 PM

#

#

Yea, this is my config for running in docker

cold island Sep 11, 2021, 9:33 PM

#

ok great

#

I'll finish it tomorrow, need to now create a local image of metricity to use a different config

#

Also metricity logs are a bit noisy

patent pivot Sep 11, 2021, 9:34 PM

#

true

vale ibex Sep 11, 2021, 9:35 PM

#

yea lol

static canyon Sep 11, 2021, 11:03 PM

#

sinful knot <@!442244135840382978> you might wanna add escaping to the titles https://canary...

Yeah, I will, although that seems out of scope for this PR so will probs make a separate PR. I'll do it when I wake up since going to bed now 👍

#

!remind 9h add escaping to py-news titles

stable mountainBOT Sep 11, 2021, 11:04 PM

#

Yeah okay.

Your reminder will arrive on <t:1631433862:F>!

fallen patrol Sep 11, 2021, 11:29 PM

#

!src src

stable mountainBOT Sep 11, 2021, 11:29 PM

#

Command: source

Display information and a GitHub link to the source code of a command, tag, or cog.

Source Code

Go to GitHub

austere hornet Sep 12, 2021, 12:28 AM

#

CC @patent pivot #dev-log message

patent pivot Sep 12, 2021, 12:29 AM

#

!doc refreshdoc

stable mountainBOT Sep 12, 2021, 12:29 AM

#

Inventories refreshed

austere hornet Sep 12, 2021, 12:29 AM

#

Thx

fallen patrol Sep 12, 2021, 3:17 AM

#

@patent pivot how can you use something as cursed as loguru

patent pivot Sep 12, 2021, 3:17 AM

#

?

fallen patrol Sep 12, 2021, 3:17 AM

#

https://github.com/Delgan/loguru/blob/68616485f4f0decb5fced36a16040f5e05e2842f/loguru/_get_frame.py#L5-L12

stable mountainBOT Sep 12, 2021, 3:17 AM

#

loguru/_get_frame.py lines 5 to 12

def get_frame_fallback(n):
    try:
        raise Exception
    except Exception:
        frame = exc_info()[2].tb_frame.f_back
        for _ in range(n):
            frame = frame.f_back
        return frame```

patent pivot Sep 12, 2021, 3:17 AM

#

what's wrong with that

fallen patrol Sep 12, 2021, 3:17 AM

#

that runs on every single log method

patent pivot Sep 12, 2021, 3:18 AM

#

the point of using loguru is so that loguru does that for me and I don't need to do it - it's doing it for a purpose, not for shits and giggles

fallen patrol Sep 12, 2021, 3:18 AM

#

is that not cursed tho?

patent pivot Sep 12, 2021, 3:18 AM

#

not really?

#

it's doing something that it can only capture that way

fallen patrol Sep 12, 2021, 3:19 AM

#

!d sys._getframe

stable mountainBOT Sep 12, 2021, 3:19 AM

#

sys.\_getframe


sys._getframe([depth])```
Return a frame object from the call stack. If optional integer *depth* is given, return the frame object that many calls below the top of the stack. If that is deeper than the call stack, [`ValueError`](https://docs.python.org/3.10/library/exceptions.html#ValueError "ValueError") is raised. The default for *depth* is zero, returning the frame at the top of the call stack.

Raises an [auditing event](https://docs.python.org/3.10/library/sys.html#auditing) `sys._getframe` with no arguments.

**CPython implementation detail:** This function should be used for internal and specialized purposes only. It is not guaranteed to exist in all implementations of Python.

fallen patrol Sep 12, 2021, 3:19 AM

#

it can do it a different way

patent pivot Sep 12, 2021, 3:19 AM

#

yes... and it does

#

note the name: fallback

#

https://github.com/Delgan/loguru/blob/68616485f4f0decb5fced36a16040f5e05e2842f/loguru/_get_frame.py#L15-L18

stable mountainBOT Sep 12, 2021, 3:19 AM

#

loguru/_get_frame.py lines 15 to 18

if hasattr(sys, "_getframe"):
    get_frame = sys._getframe
else:
    get_frame = get_frame_fallback```

patent pivot Sep 12, 2021, 3:19 AM

#

it uses the above method if the sys provided one is not present

fallen patrol Sep 12, 2021, 3:20 AM

#

is there not a better way to get the frame if the method does not exist?

#

try/except just seems....

#

cursed

patent pivot Sep 12, 2021, 3:20 AM

#

there isn't really a better way, no

#

it's not that bad

#

you generate an exception to grab you the frame, that makes sense in my head

#

but as the docstring above notes _getframe isn't present in all implementations, you are looking at a compatibility snippet, and yeah, they do get pretty weird sometimes, is it cursed? no.

fallen patrol Sep 12, 2021, 3:21 AM

#

eh

#

i guess?

patent pivot Sep 12, 2021, 3:22 AM

#

it's literally only fell back on for compatibility with a variety of interpreters

#

it's the best way to capture a trace

#

it guarantees you to have a frame without needing to be in the middle of an actual exception

fallen patrol Sep 12, 2021, 3:23 AM

#

i guess... idk

#

it just feels like there should be a better way to get a frame

patent pivot Sep 12, 2021, 3:24 AM

#

yeah

#

there is

#

it's _getframe

#

this is just for the environments where that's not implemented

fallen patrol Sep 12, 2021, 3:24 AM

#

but in not-cpython pithink

#

it doesn't make sense to me that the only place to get a frame is in excepts

patent pivot Sep 12, 2021, 3:25 AM

#

i mean, a good few of them still implement it, it's just not guaranteed

#

pypy does ```py
➜ ~ pypy3
Python 3.7.10 (77787b8f4c49115346d1e9cbaf48734137417738, Jun 13 2021, 02:02:23)
[PyPy 7.3.5 with GCC 11.1.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import sys
sys._getframe
<built-in function _getframe>

patent pivot Sep 12, 2021, 3:26 AM

#

fallen patrol it doesn't make sense to me that the only place to get a frame is in `except`s

makes sense imo, in python stacktraces are heavily tied to exceptions, the whole concept revolves around an exception being present

#

and _getframe is prefixed with _ because of that, it isn't a super public method

#

but it works for cases like this, and where it's not implemented the workaround there makes sense

fallen patrol Sep 12, 2021, 3:27 AM

#

eh... still not convinced, will have to sleep on it ig

patent pivot Sep 12, 2021, 4:44 AM

#

https://python-discord.github.io/kubernetes/

PyDis DevOps

Home

Knowledgebase for all things DevOps in Python Discord.

#

i will announce at some point

#

but i migrated all our internal docs to residing within github, and will be trying to add more for all tasks we have - stuff like adding new prometheus alerts

celest charm Sep 12, 2021, 5:16 AM

#

patent pivot but as the docstring above notes _getframe isn't present in all implementations,...

in inspect.currentframe

This function relies on Python stack frame support in the interpreter, which isn’t guaranteed to exist in all implementations of Python
If the interpreter doesn't support frames, what kind of "frame object" would an exception traceback have?

#

The thing is, all more or less working Python implementations (CPython, PyPy, Jython, IronPython, GraalVM, Brython) have sys._getframe, so how would you even test this function?

#

roflmao it monkeypatches sys when testing
https://github.com/Delgan/loguru/blob/68616485f4f0decb5fced36a16040f5e05e2842f/tests/test_get_frame.py

patent pivot Sep 12, 2021, 5:34 AM

#

celest charm in `inspect.currentframe` > This function relies on Python **stack frame support...

Cython doesn't have frames iirc

celest charm Sep 12, 2021, 5:34 AM

#

cython isn't an implementation

#

well, sort of

patent pivot Sep 12, 2021, 5:35 AM

#

in terms of things loguru will support, it's an environment

celest charm Sep 12, 2021, 5:35 AM

#

let me try

short snow Sep 12, 2021, 5:38 AM

#

patent pivot https://python-discord.github.io/kubernetes/

"Joe Banks responded" "Joe Banks responded" "Joe Banks responded" "Joe Banks responded" lol

patent pivot Sep 12, 2021, 5:39 AM

#

lol

#

I'm the only on call

#

I don't trust my alerting enough to wake others

celest charm Sep 12, 2021, 5:40 AM

#

@patent pivot Cython does have sys._getframe, why wouldn't it

short snow Sep 12, 2021, 5:40 AM

#

thankyou for the query section, makes my life easier to not go google and spend hours on docs 🙃

celest charm Sep 12, 2021, 5:40 AM

#

Cython runs on CPython, CPython has _getframe

#

This test... I sort of have questions
https://github.com/Delgan/loguru/blob/68616485f4f0decb5fced36a16040f5e05e2842f/tests/test_get_frame.py#L7-L13

stable mountainBOT Sep 12, 2021, 5:40 AM

#

tests/test_get_frame.py lines 7 to 13

def test_with_sys_getframe(monkeypatch):
    def patched():
        return

    monkeypatch.setattr(sys, "_getframe", patched())
    get_frame_module = importlib.reload(loguru._get_frame)
    assert get_frame_module.get_frame == patched()```

short snow Sep 12, 2021, 5:41 AM

#

btw look like wikiguess game didn't get change logged, might want to do that?

celest charm Sep 12, 2021, 5:41 AM

#

it really seems like testing for the sake of testing

#

it would also happily pass this implementation ```py
get_frame = None

#

and what's the point of this patched function?

brazen charm Sep 12, 2021, 5:44 AM

#

patent pivot !doc refreshdoc

On a related note, bot#1795

dusky shoreBOT Sep 12, 2021, 5:44 AM

#

GitHub

PROpen Prevent repetitive stale inventory warnings from erroneously generated inventories

fallen patrol Sep 12, 2021, 5:48 AM

#

celest charm This test... I sort of have questions <https://github.com/Delgan/loguru/blob/686...

i thiiiink it looks like its testing that it's running on cpython?!?

#

i have no idea!

celest charm Sep 12, 2021, 5:48 AM

#

fallen patrol i *thiiiink* it looks like its testing that it's running on cpython?!?

I understand what it's doing, but not why like that

#

it's monkeypatching the stdlib

fallen patrol Sep 12, 2021, 5:49 AM

#

yeh

celest charm Sep 12, 2021, 5:50 AM

#

I'm not confused about the monkeypatch, but why make a function that returns none and then call it right away?

sour viper Sep 12, 2021, 5:51 AM

#

Hey ! If I were to start discussing something about contributing here, would I be interrupting someone right now or is there a channel specific or this the one ?

celest charm Sep 12, 2021, 5:51 AM

#

it's okay to talk past each other here 👍

#

well, with reasonable limits

sour viper Sep 12, 2021, 5:52 AM

#

So I was going through the issues and found one interesting and maybe one I could implement, let me just quickly grab the issue

#

https://github.com/python-discord/sir-lancebot/issues/836

GitHub

Add Hangman game command · Issue #836 · python-discord/sir-lancebot

Description I created a Hangman game in Python and would like to add it to Sir Lancebot via a new cog. Reasoning I think Hangman is a game I am sure many people will want to play! Proposed Implemen...

#

Oh god, I didn't see the comments but it is marked as closed, does that mean its implemented already ?

#

Was the ok for me ?

#

I dont see any PR for the Hangman command so I'm not sure if it is just gone or closed as in no one will do it

placid ermine Sep 12, 2021, 6:10 AM

#

sour viper I dont see any PR for the Hangman command so I'm not sure if it is just gone or ...

https://github.com/python-discord/sir-lancebot/pull/843

GitHub

Hangman by Shom770 · Pull Request #843 · python-discord/sir-lancebot

Relevant Issues

Closes #599
Description

This PR creates a classic hangman game with just the guesser portion. From the original issue, I considered that the executioner may have been a bit too b...

static canyon Sep 12, 2021, 6:16 AM

#

I need to implement escaping into the titles of #mailing-lists posts; should I put it as part of bot#1822 or make a new issue+PR?

dusky shoreBOT Sep 12, 2021, 6:16 AM

#

GitHub

PROpen Fix escapes in python-news posts

sour viper Sep 12, 2021, 6:20 AM

#

placid ermine https://github.com/python-discord/sir-lancebot/pull/843

Hey thanks for clearing that up, I only checked the open PRs completely slipped my mind I should be looking at close PRs. Bit disappointed was looking forward to implementing this, eh. Onto the next issue !

short snow Sep 12, 2021, 7:33 AM

#

you could put into the same PR tizzy imo since its basically fixing the escapes

#

jsut remember to update the pr descrition

static canyon Sep 12, 2021, 7:49 AM

#

Oh yeah

#

ty

short snow Sep 12, 2021, 7:53 AM

#

you are fast 👀

static canyon Sep 12, 2021, 7:55 AM

#

lol

#

Being able to type 120wpm has its advantages

stable mountainBOT Sep 12, 2021, 8:04 AM

#

static canyon !remind 9h add escaping to py-news titles

It has arrived!

Here's your reminder: add escaping to py-news titles
[Jump back to when you created the reminder](#dev-contrib message)

static canyon Sep 12, 2021, 8:04 AM

#

Already done :p

stable mountainBOT Sep 12, 2021, 8:38 AM

#

green oriole !remind 13h <:this:470903994118832130>

It has arrived!

Here's your reminder: this
[Jump back to when you created the reminder](#dev-contrib message)

vale ibex Sep 12, 2021, 8:56 AM

#

Oh no, I just realised that everytime I start the bot I get an email from metabase saying there's a new login on my account

#

I have over 100 emails

cold island Sep 12, 2021, 8:59 AM

#

Lmao

vale ibex Sep 12, 2021, 8:59 AM

#

i didn't notice since they were put under the promotions label in gmail for some reason 😅

sour viper Sep 12, 2021, 9:11 AM

#

Hey so I found an issue I think i will be able to contribute to ? Should I just comment in the issue, Id like to contribute and will it get assigned to me ?

#

Or is there any other procedure for assigning the items to yourself ?

molten perch Sep 12, 2021, 9:20 AM

#

sour viper Hey so I found an issue I think i will be able to contribute to ? Should I just ...

If the issue is approved, and haven't been assigned to anyone (or stalled). Then I believe so, yes.

sour viper Sep 12, 2021, 9:21 AM

#

Okay, thanks for the info !

static canyon Sep 12, 2021, 9:43 AM

#

@sour viper if you're the user wanting to work on the anagrams game, I recommend looking into itertools.permutations
https://docs.python.org/3/library/itertools.html#itertools.permutations

#

That way you just need a list of valid words, random letters for the user using itertools.permutations to make sure there's at least one valid word, and then for validation that's it's a valid word just check it's in the list

#

Or perhaps it would be better to randomly pick a word from the list of valid words, and shuffle the letters (random choice from the permutation or something)

sour viper Sep 12, 2021, 9:45 AM

#

Looks interesting my approach was a bit straightforward Create a list of all anagrams which can be made (JSON file maybe)
Select a word which has anagrams from JSON at random and scramble the word so its letters are jumbled
Users will suggest words which are anagrams, check in JSON if they are valid anagrams if yes award points (still figuring out how to do that)

static canyon Sep 12, 2021, 9:45 AM

#

All anagrams is going to be way too big to account for though

sour viper Sep 12, 2021, 9:45 AM

#

i looked online

static canyon Sep 12, 2021, 9:46 AM

#

Just store all valid words

sour viper Sep 12, 2021, 9:46 AM

#

apparently small list

#

http://www.english-for-students.com/Complete-List-of-Anagrams.html

English for Students

Complete List of Anagrams : Anagram : Peculiar Vocabulary : English

#

Not sure if this the exhaustive list

sour viper Sep 12, 2021, 9:46 AM

#

static canyon Or perhaps it would be better to randomly pick a word from the list of valid wor...

I agree with this

static canyon Sep 12, 2021, 9:47 AM

#

sour viper Not sure if this the exhaustive list

That's definitely not exhaustive

#

Doesn't even have santa and satan smh

#

Lol

sour viper Sep 12, 2021, 9:49 AM

#

Huh, can you point me in the direction where I could find an exhaustive list ? Or Google will be my buddy.

static canyon Sep 12, 2021, 9:53 AM

#

sour viper Huh, can you point me in the direction where I could find an exhaustive list ? O...

By anagrams you mean a word which makes another word, right?

#

Not just letters that can make a word

#

So e.g. pat --> tap
bpta can make tap but doesn't count since bpta isn't a word

sour viper Sep 12, 2021, 9:54 AM

#

static canyon So e.g. `pat` --> `tap` `bpta` can make `tap` but doesn't count since `bpta` isn...

Yep exactly, I googled some but all I found were examples of some anagrams nowhere near an exhaustive list

static canyon Sep 12, 2021, 9:55 AM

#

And do you want one word things?

#

Or can funeral --> real fun be valid?

#

I suppose it'd interpret as real, fun (two separate)

sour viper Sep 12, 2021, 9:56 AM

#

I was thinking of keeping it simple single word only, i saw some 2 words examples but thought implementation would be a bit complicated

static canyon Sep 12, 2021, 9:57 AM

#

I mean you can just treat it as two separate entries I guess

static canyon Sep 12, 2021, 9:58 AM

#

sour viper Yep exactly, I googled some but all I found were examples of some anagrams nowhe...

Looks like you're going to have to brute-force that. Which sucks but can't seem to find a good list

#

I mean do you really need to store all anagrams? I don't get why you do

#

hmm

sour viper Sep 12, 2021, 10:03 AM

#

Im not sure how Id go on about, if someone enters anagram command, i cant just list out some random letters and expect them to make words it may or may not be possible. But if I have a list of preconfirmed anagrams

vale ibex Sep 12, 2021, 10:04 AM

#

Have a long word list, when the command is invoked, choose one at random and shuffle the word

#

then when the user answers check if the answer is in the world list

static canyon Sep 12, 2021, 10:04 AM

#

But there's no guarantee the shuffled word is an anagram

#

We're only counting as an anagram when the shuffled word is also a valid word

static canyon Sep 12, 2021, 10:04 AM

#

static canyon So e.g. `pat` --> `tap` `bpta` can make `tap` but doesn't count since `bpta` isn...

^

vale ibex Sep 12, 2021, 10:05 AM

#

ahhhh right, yea forgot anagrams need to be valid words lol

short snow Sep 12, 2021, 10:05 AM

#

is there a list of all dictionary words?

static canyon Sep 12, 2021, 10:05 AM

#

vale ibex ahhhh right, yea forgot anagrams need to be valid words lol

I did too originally lol

static canyon Sep 12, 2021, 10:05 AM

#

short snow is there a list of all dictionary words?

There are files out there with all words

short snow Sep 12, 2021, 10:05 AM

#

you can geenrate anagrams through that then

static canyon Sep 12, 2021, 10:05 AM

#

But that's gonna take so long to generate them all

sour viper Sep 12, 2021, 10:05 AM

#

static canyon But that's gonna take so long to generate them all

Yeah

short snow Sep 12, 2021, 10:05 AM

#

cap them at x anagrams

static canyon Sep 12, 2021, 10:06 AM

#

My vote right now is just shuffle the word and give it whether it's valid or not

#

So bta --> bat counts

#

And you'd probably want it to be at least x chars

#

the more chars, the more potentially words

celest charm Sep 12, 2021, 10:06 AM

#

I think you could make some clever algorithm with a trie so that the decision tree is smaller

static canyon Sep 12, 2021, 10:06 AM

#

I think the start word should be like at least 5 and end word at least 3

#

So like great --> eat tea gear ear gate etc.

#

It's better to just have it allow any amount really

vale ibex Sep 12, 2021, 10:08 AM

#

There's a bunch in here http://itools.subhashbose.com/wordfind/common-anagrams/

List of common Anagram words - 1533 Anagrams | WordFind

List of common Anagram words - 1533 Anagrams

static canyon Sep 12, 2021, 10:08 AM

#

By definition it needs to be all letters but then by definition it also has to be a valid start word

static canyon Sep 12, 2021, 10:08 AM

#

vale ibex There's a bunch in here http://itools.subhashbose.com/wordfind/common-anagrams/

Not a full list though

#

Like it doesn't have santa and satan

patent pivot Sep 12, 2021, 10:09 AM

#

@clever wraith https://Python-discord.GitHub.io/kubernetes/

PyDis DevOps

Home

Knowledgebase for all things DevOps in Python Discord.

vale ibex Sep 12, 2021, 10:09 AM

#

Does it need to have all of them?

static canyon Sep 12, 2021, 10:09 AM

#

vale ibex Does it need to have *all* of them?

I think if we have a list of anagrams it should include all of them

vale ibex Sep 12, 2021, 10:09 AM

#

just a bunch of known words that have valid anagrams, then use an english dict to check answers

static canyon Sep 12, 2021, 10:10 AM

#

I might make a script later for generating anagrams and just see what happens

sour viper Sep 12, 2021, 10:10 AM

#

Do let me know about it @static canyon I'd love to watch your approach on this

static canyon Sep 12, 2021, 10:11 AM

#

👍

#

Will do

#

It'll be a few hours/possibly tomorrow

#

!remind 8h do this if you haven't already

stable mountainBOT Sep 12, 2021, 10:11 AM

#

I'll allow it.

Your reminder will arrive on <t:1631470305:F>!

patent pivot Sep 12, 2021, 10:12 AM

#

ebic

#

I'm going to add more documents at some point, stuff like the list of components in our monitoring stack and how they are configured (an overview of my SD genius)

#

my magnum opus: https://github.com/python-discord/kubernetes/blob/main/namespaces/monitoring/alerts/alertmanager/initscript.yaml

GitHub

kubernetes/initscript.yaml at main · python-discord/kubernetes

Kubernetes manifests for Python Discord services. Contribute to python-discord/kubernetes development by creating an account on GitHub.

short snow Sep 12, 2021, 10:14 AM

#

patent pivot Sep 12, 2021, 10:19 AM

#

✨

#

for sure yeah, that'd be dope

short snow Sep 12, 2021, 10:46 AM

#

Would love to get some reviews on bot#1634 bot#1446 sir-lancebot#745

dusky shoreBOT Sep 12, 2021, 10:46 AM

#

GitHub

PROpen Modpings schedule
PROpen Add logic for preserving unloaded Cogs.
PROpen Enhancing information within the incidents channel.

short snow Sep 12, 2021, 11:01 AM

#

@clever wraith on smart-resources PR, I am up to date with the branch

stable mountainBOT Sep 12, 2021, 11:02 AM

#

You're the boss!

Your reminder will arrive on <t:1631473322:F>!

short snow Sep 12, 2021, 11:02 AM

#

🙇‍♂️

#

and this

#

one more, the tools page on the menu dropdown

#

and on no selection, shouldn't it just show all of the resources?

#

do it

#

oh i get it, he has your commits, but his commits overwrite yours

#

i think

#

cuz i see your commits in that

#

oh nvm

#

only some are there

cold island Sep 12, 2021, 11:09 AM

#

dusky shore

!remind 5h look at it

stable mountainBOT Sep 12, 2021, 11:09 AM

#

You got it!

Your reminder will arrive on <t:1631462969:F>!

short snow Sep 12, 2021, 11:09 AM

#

good zebra 🍪

molten perch Sep 12, 2021, 11:18 AM

#

Hey, could someone take a look at, api#16 ? 😄

dusky shoreBOT Sep 12, 2021, 11:18 AM

#

GitHub

IssueOpen Migrate models based on the current Database Schema to SQLAlchemy

dim pelican Sep 12, 2021, 12:26 PM

#

Hey all, any tips for getting a markdown file to preview correctly?

#

This is for sir-lancebot#859

dusky shoreBOT Sep 12, 2021, 12:26 PM

#

GitHub

PROpen Add WTF Python Command

molten perch Sep 12, 2021, 12:53 PM

#

dim pelican Hey all, any tips for getting a markdown file to preview correctly?

I'm a bit behind regarding your PR, that file preview would be the content you get back from the WTF python repository, right?

stable mountainBOT Sep 12, 2021, 12:53 PM

#

Hey @lone lava!

It looks like you tried to attach file type(s) that we do not allow (.md). We currently allow the following file types: .gif, .jpg, .jpeg, .mov, .mp4, .mpg, .png, .mp3, .wav, .ogg, .webm, .webp, .flac, .m4a.

Feel free to ask in #community-meta if you think this is a mistake.

lone lava Sep 12, 2021, 12:53 PM

#

oops i wanted to see how a rendered file looks like

short snow Sep 12, 2021, 12:55 PM

#

brad some of the wtf example don't follow that regex so just cross check over each of those once, according to my testing which was done about 5-6 months back:
16, 25, 26, 40, 43, 55 don't follow that order

short snow Sep 12, 2021, 12:55 PM

#

molten perch I'm a bit behind regarding your PR, that file preview would be the content you g...

yes

molten perch Sep 12, 2021, 12:55 PM

#

Oh, okay. I see.

dim pelican Sep 12, 2021, 12:56 PM

#

short snow brad some of the wtf example don't follow that regex so just cross check over ea...

Yikes, yeah I'll check that out

dim pelican Sep 12, 2021, 12:56 PM

#

molten perch Oh, okay. I see.

Yessir, I'm slicing the raw text response, then creating a .md file from that

molten perch Sep 12, 2021, 12:57 PM

#

I'm not an async expert, but using open by itself, is a blocking call, isn't it?

#

(I just took a quick look at your PR)

brazen charm Sep 12, 2021, 12:58 PM

#

Usually not blocking for long enough to be a worry

dim pelican Sep 12, 2021, 12:58 PM

#

Hmmm...it likely is. But I was having trouble looking for an example or docs for a temp creation and attachment of a file in discord.py. The open call is the way I know how to create a file

molten perch Sep 12, 2021, 12:59 PM

#

I'd prefer to use StringIO instead, though. It's a file like object, you can use it with discord.File.

#

But I might be very well wrong.

short snow Sep 12, 2021, 12:59 PM

#

Not sure if that's something to be worried about but we could always use aiofiles

dim pelican Sep 12, 2021, 12:59 PM

#

Time to do some more research

molten perch Sep 12, 2021, 1:00 PM

#

I tried out using StringIO with Discord, it worked just fine.

dim pelican Sep 12, 2021, 1:01 PM

#

Yeah that looks like it would be a straight oneliner lol

dim pelican Sep 12, 2021, 1:21 PM

#

short snow brad some of the wtf example don't follow that regex so just cross check over ea...

These are the ones giving me trouble:
-How not to use is operator: Doesn't work for .wtf is, but does work for operator
-+= is faster: Doesn't work for .wtf +=, but does for faster or --

Just so I'm on the same page with you:
16: ▶️ is not ... is not is (not ...)
25: ▶ not knot!
26: ▶ Half triple-quoted strings
40: ▶ Deleting a list item while iterating
43: ▶ Beware of default mutable arguments!
55: ▶ goto, but why?

short snow Sep 12, 2021, 1:37 PM

#

I only had the serial number of them stored, so can't really tell but you can jsut quickly make the bot send all and speed run over each to verify them (starting and end)

green oriole Sep 12, 2021, 2:16 PM

#

Alright, the 2.0a0 PR has been updated to correct mod-log and silence

static canyon Sep 12, 2021, 2:54 PM

#

@sour viper I'll need a list of words to do the brute force on, should i just use https://github.com/python-discord/sir-lancebot/blob/c7ccfbc95bb5b73d04c24a137a2bcf6b98d77ddd/bot/resources/fun/hangman_words.txt?

#

That has 869 words, all at least 3 chars

#

By no means all words but I believe it's a filtered down top 1k words

#

Or should I use a list of just all words like https://github.com/dwyl/english-words

short snow Sep 12, 2021, 2:59 PM

#

static canyon Or should I use a list of just all words like <https://github.com/dwyl/english-w...

just use that and cap the size to 200 words maybe? like after 200 words just stop it or let it continue and go to sleep lol

dim pelican Sep 12, 2021, 3:03 PM

#

Having issues with this working for both .txt and .md files

molten perch Sep 12, 2021, 3:08 PM

#

Indeed it does. 🙂 That's why I mentioned it as one of the possible solutions, but I don't think it's worth to add a new dependency for such a small thing like that.

sour viper Sep 12, 2021, 3:20 PM

#

@static canyon can you wait for like half an hour if you are still available
I think an easy way would be just to sort the words as per letters
And just find the same words with same letters and we have our anagrams

static canyon Sep 12, 2021, 3:25 PM

#

import json
from itertools import permutations

with open("words.txt") as f:
    words = set(json.load(f))

amount_words = len(words)

anagrams = {}

done = {}

# words = ['santa', 'satan']

for index, word in enumerate(sorted(list(words))):
    print(f"{index+1}/{amount_words} ({word})")

    if word in done:
        print(f"{word} has already been done as part of {done[word]}")
        break

    for permutation in set(permutations(word)):
        permutation = "".join(permutation)
        # print(permutation)

        if permutation == word:
            continue

        if permutation in words:
            print(f"Anagram for {word}: {permutation}")
            if word not in anagrams:
                anagrams[word] = []
            done[permutation] = word
            anagrams[word].append(permutation)

    print()
```this is what I have right now

#

I'm just letting it run

sour viper Sep 12, 2021, 3:29 PM

#

Huh that's neat

static canyon Sep 12, 2021, 3:30 PM

#

I guess what you're suggesting would be```py

anagrams = {}
for word in words:
if (sorted_letters := ''.join(sorted(word))) not in anagrams:
anagrams[sorted_letters] = []

anagrams[sorted_letters].append(word)

#

Which is definitely way better complexity lol

sour viper Sep 12, 2021, 3:30 PM

#

I don't know if mine would be faster ? Would it ?

static canyon Sep 12, 2021, 3:31 PM

#

Then the anagrams are just things where the len(anagrams[sorted_letters]) > 1

sour viper Sep 12, 2021, 3:31 PM

#

Yes right

static canyon Sep 12, 2021, 3:31 PM

#

So yeah, I guess that's a smarter approach

sour viper Sep 12, 2021, 3:32 PM

#

Which file are you running this on ?

#

The smaller one or the larger one ?

static canyon Sep 12, 2021, 3:33 PM

#

larger

sour viper Sep 12, 2021, 3:34 PM

#

Sure, let me know when it's done, interested to see how much time it takes

static canyon Sep 12, 2021, 3:34 PM

#

sour viper Sure, let me know when it's done, interested to see how much time it takes

It's literally instant lol

#

Without any print statements

#

The part that lags is printing the dictionary xD

sour viper Sep 12, 2021, 3:35 PM

#

Woaw

short snow Sep 12, 2021, 3:37 PM

#

super computer

static canyon Sep 12, 2021, 3:38 PM

#

>>> len(anagrams_builder)
326648
>>> len(actual_anagrams)
30022```

#

Out of 326k words, 30k of them are anagrams

#

Assuming the code works

static canyon Sep 12, 2021, 3:39 PM

#

short snow super computer

on my laptop lol

#

ah slight issue

#

So I might've tried to print over 350k items, each on their own line

sour viper Sep 12, 2021, 3:43 PM

#

Ctrl + C

static canyon Sep 12, 2021, 3:43 PM

#

It's not responsive lol

#

Just gotta wait for it to crash

sour viper Sep 12, 2021, 3:43 PM

#

Call the big bois

#

C + A + D

static canyon Sep 12, 2021, 3:44 PM

#

That doesn't work either lol

sour viper Sep 12, 2021, 3:44 PM

#

Call the biggest boi
Off switch

Don't just kidding

static canyon Sep 12, 2021, 3:45 PM

#

lol

#

Can my laptop survive this?

#

That would be a no

#

rofl

#

Attempt #3

#

ehh nope lol