static canyon Jul 23, 2021, 3:22 PM

#

Yep

brisk brook Jul 23, 2021, 3:24 PM

#

PS: You probably want to add labels

static canyon Jul 23, 2021, 3:24 PM

#

brisk brook PS: You probably want to add labels

What do you mean?

brisk brook Jul 23, 2021, 3:25 PM

#

To the right

#

I think it's a low-priority, enhancement, frontend change?

static canyon Jul 23, 2021, 3:30 PM

#

Thanks

#

I think that's right @brisk brook

#

It has passed flake8 so rest of linting should work

brisk brook Jul 23, 2021, 3:36 PM

#

Now I am confused again, why did this cause ghost pings?

Because you need to confirm the trashcan icon, so you will know where the ping came from?

static canyon Jul 23, 2021, 3:37 PM

#

It deletes the ctx.message as well

#

So you've now got a ghost ping

#

The point of this is to only delete ctx.message if it DOESN'T have pings

brisk brook Jul 23, 2021, 3:39 PM

#

static canyon So you've now got a ghost ping

Ah, alright. I think I got it then again haha.

static canyon Jul 23, 2021, 3:39 PM

#

lol

#

So does it look good?

sleek steppe Jul 23, 2021, 3:40 PM

#

brisk brook Ah, alright. I think I got it then again haha.

did you see the example I showed you?

brisk brook Jul 23, 2021, 3:40 PM

#

sleek steppe did you see the example I showed you?

Yeah I think so

sleek steppe Jul 23, 2021, 3:40 PM

#

cool

static canyon Jul 23, 2021, 3:43 PM

#

Does this make sense by the way @brisk brook https://github.com/python-discord/bot/pull/1694/files/b2061e4f5afab8d8d714ca7a1f969d84c6f1e213#r675657869?

sleek steppe Jul 23, 2021, 3:45 PM

#

Is it supposed to delete the error_message after the timeout?

static canyon Jul 23, 2021, 3:46 PM

#

No

#

Only if it doesn't timeout

brisk brook Jul 23, 2021, 3:46 PM

#

It's a bit different. You see wait_for_deletion() puts both the wait_for() and message.delete() inside the same supress(). Meaning it won't get deleted if it timed out, the old code deleted the message if it timed out, do we wish to keep this behaviour?

static canyon Jul 23, 2021, 3:47 PM

#

Meaning it won't get deleted if it timed out
That's what my intention was

brisk brook Jul 23, 2021, 3:49 PM

#

Hmm, good point. It looks weird if someone did !doc and it looks like they got no response (but it's just that the failure message that got deleted)

#

You should clear the reactions then, because like this looks like they will stay? Which again can make the bot look unresponsive if someone tries it after the timeout.

static canyon Jul 23, 2021, 3:50 PM

#

Yep, good point

#

Hmm

#

There's no real way to know if it got deleted though

#

I guess try to remove it and just suppress the error if we get NotFound

wide elm Jul 23, 2021, 3:52 PM

#

Hi :D

#

I can ask questions related to different aspects of pydis project source codes here, right?

brazen charm Jul 23, 2021, 3:53 PM

#

yes

wide elm Jul 23, 2021, 3:53 PM

#

ok

brisk brook Jul 23, 2021, 3:53 PM

#

static canyon There's no real way to know if it got deleted though

suppres()

wide elm Jul 23, 2021, 3:54 PM

#

so I was wondering, so with how pixels implemented ratelimits, does it just check if a user has a cooldown or how many requests they had remaining through redis each time the user requested an endpoint?

brazen charm Jul 23, 2021, 3:55 PM

#

When i was initially adding the automatic deletion of the invocation and the error message, the reason was because of some people just trying out the command, or (unsuccessfully) trying to find some symbol, leading to a chain of lookup errors as it's rarely cleaned up, but I guess it is a bit confusing in lower traffic channels

static canyon Jul 23, 2021, 3:57 PM

#

brisk brook `suppres()`

Do you happen to know what error is? The docs don't actually say

sleek steppe Jul 23, 2021, 3:57 PM

#

NotFound

static canyon Jul 23, 2021, 3:57 PM

#

It says that's if the reaction is invalid

#

So is it just both?

sleek steppe Jul 23, 2021, 3:57 PM

#

If you add a reaction to a message that is deleted then it will 404

static canyon Jul 23, 2021, 3:57 PM

#

Aight, thanks

brisk brook Jul 23, 2021, 3:59 PM

#

wide elm so I was wondering, so with how pixels implemented ratelimits, does it just chec...

https://tenor.com/view/run-gotta-go-fast-fast-zoom-coming-gif-15534185

Tenor

#

Yup, reddis is speed

wide elm Jul 23, 2021, 3:59 PM

#

ok

#

So they just checked through redis each time someone requested an endpoint?

sleek steppe Jul 23, 2021, 4:00 PM

#

pretty much yeah

brisk brook Jul 23, 2021, 4:01 PM

#

wide elm So they just checked through redis each time someone requested an endpoint?

It generates a key with the user ID (gotten from the token they authorize with) and looks this up in Redis. Redis handles expiring the keys: https://github.com/python-discord/pixels/blob/3346f31f74d18b40c50a1aa8c239b770a41a3651/pixels/utils/ratelimits.py#L278-L323

GitHub

pixels/ratelimits.py at 3346f31f74d18b40c50a1aa8c239b770a41a3651 · ...

Pixels is an introductory API from Python Discord for painting on a collaborative canvas. - pixels/ratelimits.py at 3346f31f74d18b40c50a1aa8c239b770a41a3651 · python-discord/pixels

wide elm Jul 23, 2021, 4:01 PM

#

brisk brook It generates a key with the user ID (gotten from the token they authorize with) ...

ah ok, thanks :D

vale ibex Jul 23, 2021, 4:02 PM

#

Yup Redis is real quick

brisk brook Jul 23, 2021, 4:02 PM

#

request_id is an increment from here: https://github.com/python-discord/pixels/blob/3346f31f74d18b40c50a1aa8c239b770a41a3651/pixels/utils/ratelimits.py#L115

stable mountainBOT Jul 23, 2021, 4:02 PM

#

pixels/utils/ratelimits.py line 115

request_id = next(self.request_id)```

vale ibex Jul 23, 2021, 4:02 PM

#

we couldn't do in-memory since we have multiple workers

#

and even 2 versions of it running (k8s replicas)

brisk brook Jul 23, 2021, 4:02 PM

#

self.request_id is a itertools.count

#

It's not garuanteed unique across the deployment (for example if they restart).

#

But the chance of someone:

Making a request with a low request_id (insert into redis)
Causing it to restart
Doing another request and get the same request_id

static canyon Jul 23, 2021, 4:04 PM

#

@brisk brook can you review please? 👉 👈 https://github.com/python-discord/bot/pull/1694

brisk brook Jul 23, 2021, 4:05 PM

#

All without the key from step 1 expiring, is so extremely low that we can consider it unique.

brisk brook Jul 23, 2021, 4:05 PM

#

static canyon <@!344404945359077377> can you review please? 👉 👈 <https://github.com/python-...

I'll take a look!

molten perch Jul 23, 2021, 4:06 PM

#

Hey! I think my draft pull request is ready to “go”. What should I do? Is there a standard protocol that I have to follow?

sleek steppe Jul 23, 2021, 4:07 PM

#

Are you talking about bot#1678?

dusky shoreBOT Jul 23, 2021, 4:07 PM

#

GitHub

PRDraft Add Leads to Server info Embed.

molten perch Jul 23, 2021, 4:11 PM

#

Yes, I am, I think it’s ready to be formally reviewed.

sleek steppe Jul 23, 2021, 4:12 PM

#

You should mark it as ready then

molten perch Jul 23, 2021, 4:16 PM

#

Alright, Thanks. I’ll do it soon then, I’m away from my computer right now.

green oriole Jul 23, 2021, 4:21 PM

#

why do I get two thousands emails about bot#1664

dusky shoreBOT Jul 23, 2021, 4:21 PM

#

GitHub

IssueOpen Command to resend infraction embed

green oriole Jul 23, 2021, 4:21 PM

#

haha

vale ibex Jul 23, 2021, 4:24 PM

#

molten perch Alright, Thanks. I’ll do it soon then, I’m away from my computer right now.

No worries, I've done it for you and merged in main

molten perch Jul 23, 2021, 4:33 PM

#

vale ibex No worries, I've done it for you and merged in main

Oh, wow thanks. 😄

static canyon Jul 23, 2021, 5:01 PM

#

I responded to your comment by the way @brisk brook

brisk brook Jul 23, 2021, 5:05 PM

#

Yes I am going to take a look, sorry I was eating.

static canyon Jul 23, 2021, 5:06 PM

#

No worries 👍

#

Just pinged because I didn't know if you were like me and didn't really check GitHub

static canyon Jul 23, 2021, 5:37 PM

#

Can I get two more reviews on bot#1694 please?

dusky shoreBOT Jul 23, 2021, 5:37 PM

#

GitHub

PROpen Prevent ghost-pings in docs get command

viscid coral Jul 23, 2021, 6:01 PM

#

static canyon Can I get two more reviews on bot#1694 please?

Here? And to write what is my opinion on the purpose of it?

#

static canyon Jul 23, 2021, 6:06 PM

#

The idea is to say the code's okay

#

And if you go to the "files" page there should be a thing in top-right

#

Gimme a few minutes and I'll show you

viscid coral Jul 23, 2021, 6:08 PM

#

Show me how?

static canyon Jul 23, 2021, 6:09 PM

#

Screenshot

#

Just not on laptop right now

#

This is it @viscid coral

#

Although I think only staff can Approve

#

There's "Comment", "Approve" and "Request Changes"

brazen charm Jul 23, 2021, 6:14 PM

#

anyone can approve, it just won't directly count towards the approvals required for a merge

viscid coral Jul 23, 2021, 6:14 PM

#

So I should comment?

static canyon Jul 23, 2021, 6:14 PM

#

viscid coral So I should comment?

It depends on what you're doing

#

If you're approving the code (saying it's good quality etc.) then you'd "Approve"

If you're asking for a change to be made (e.g. adding a comment or whatever) then you'd "Request changes"

If it's neither, and you're just posting a general comment or question (e.g. "This might not work how you expect it because ...") then you use a "Comment"

#

You can approve if you'd like to, just it doesn't count towards the required 3 approvals since you're not staff/core-dev(which is what Numerlor was saying). Still good to do though

viscid coral Jul 23, 2021, 6:18 PM

#

What is the else for? Which statement?

#

Oh if it wasn't found?

static canyon Jul 23, 2021, 6:19 PM

#

Which else?

#

The bottom one (bottom of screenshot)?

viscid coral Jul 23, 2021, 6:19 PM

#

Yeah i think I got it

#

If there is a correct search

static canyon Jul 23, 2021, 6:19 PM

#

viscid coral If there is a correct search

Yeah, exactly

#

It's linked to the if doc_embed is None:

viscid coral Jul 23, 2021, 6:20 PM

#

Oh ok

#

Why not just do if doc_embed or something? Even tho it's the same

static canyon Jul 23, 2021, 6:21 PM

#

That's just how the previous person wrote it

viscid coral Jul 23, 2021, 6:21 PM

#

Well the code seems okay to me, I'll try to press the approve review or how it's called

static canyon Jul 23, 2021, 6:22 PM

#

Generally as long as you aren't flipping a condition (not) first it's fine

#

https://github.com/TizzySaurus/bot/blob/Update-docs-get-to-prevent-ghost-pings/bot/exts/info/doc/_cog.py#L341-L350 is the lines without the diff by the way (I find the diff gets in the way)

stable mountainBOT Jul 23, 2021, 6:22 PM

#

bot/exts/info/doc/_cog.py lines 341 to 350

if doc_embed is None:
    error_message = await send_denial(ctx, "No documentation found for the requested symbol.")
    await wait_for_deletion(error_message, (ctx.author.id,), timeout=NOT_FOUND_DELETE_DELAY)
    with suppress(discord.NotFound):
        await error_message.clear_reaction(Emojis.trashcan)

    # Make sure that we won't cause a ghost-ping by deleting the message
    if not (ctx.message.mentions or ctx.message.role_mentions):
        with suppress(discord.NotFound):
            await ctx.message.delete()```

viscid coral Jul 23, 2021, 6:23 PM

#

Is that ok? Anything else I should add?

static canyon Jul 23, 2021, 6:23 PM

#

static canyon This is it <@!480404983372709908>

That's good 👍 Make sure you selected "Approve" under these options

viscid coral Jul 23, 2021, 6:23 PM

#

static canyon Jul 23, 2021, 6:23 PM

#

Yep, perfect 👍

viscid coral Jul 23, 2021, 6:24 PM

#

Submitted

static canyon Jul 23, 2021, 6:24 PM

#

Even though your approval doesn't count towards the 3-approval requirement, it's still good to get the extra feedback, and can be good practice for you too

#

So it's definitely still worth doing

viscid coral Jul 23, 2021, 6:24 PM

#

Yeah

#

Just happy to help!

static canyon Jul 23, 2021, 6:25 PM

#

(Also why your tick isn't green)

#

But thanks 👍

viscid coral Jul 23, 2021, 6:26 PM

#

static canyon (Also why your tick isn't green)

I have no idea, it says maybe because I don't have write access?

static canyon Jul 23, 2021, 6:26 PM

#

viscid coral I have no idea, it says maybe because I don't have write access?

(I meant that as an explanation to why)

#

The reason it's not green is because you don't have write access (because you're not staff/core-dev)

viscid coral Jul 23, 2021, 6:27 PM

#

Oh ok

static canyon Jul 23, 2021, 6:40 PM

#

static canyon Can I get two more reviews on bot#1694 please?

Still need 1 more approval on this by the way if anyone's free

viscid coral Jul 23, 2021, 7:06 PM

#

I think it was approved

static canyon Jul 23, 2021, 7:06 PM

#

Nice

viscid coral Jul 23, 2021, 7:06 PM

#

Test it on me lol

static canyon Jul 23, 2021, 7:07 PM

#

!d @viscid coral

#

nice

#

!d @viscid coral

stable mountainBOT Jul 23, 2021, 7:07 PM

#

Fat chance.

No documentation found for the requested symbol.

static canyon Jul 23, 2021, 7:07 PM

#

And if you don't react it should remove the reaction

viscid coral Jul 23, 2021, 7:07 PM

#

!d discord.ext.commands.Bot.blahblah @static canyon

stable mountainBOT Jul 23, 2021, 7:07 PM

#

Not gonna happen.

No documentation found for the requested symbol.

static canyon Jul 23, 2021, 7:08 PM

#

Nice

viscid coral Jul 23, 2021, 7:08 PM

#

Yap

static canyon Jul 23, 2021, 7:08 PM

#

Gone are the days of ghost-pings in docs command

#

~~let's test if it works with role pings~~ (don't actually lol)

viscid coral Jul 23, 2021, 7:08 PM

#

Yap, unless someone does it on purpose

viscid coral Jul 23, 2021, 7:08 PM

#

static canyon ~~let's test if it works with role pings~~ (don't actually lol)

Sure let me ping the mods one sec lol

static canyon Jul 23, 2021, 7:08 PM

#

no lol

#

lemon_ping

#

The !pypi command has the same issue, so should I code the same thing for that? Or would it make more sense to make it a util function?

viscid coral Jul 23, 2021, 7:11 PM

#

It'll make more sense to make it a util function yeah

#

Open a pull request or something ig

brisk brook Jul 23, 2021, 7:12 PM

#

static canyon The `!pypi` command has the same issue, so should I code the same thing for that...

Doesn't make sense to make it a util function, it's really just an if statement.

static canyon Jul 23, 2021, 7:12 PM

#

I mean it's a bit more than that

static canyon Jul 23, 2021, 7:13 PM

#

stable mountain `bot/exts/info/doc/_cog.py` lines 341 to 350 ```py if doc_embed is None: err...

It's this

#

To change in pypi command would be like 5 lines of changing code I think

viscid coral Jul 23, 2021, 7:13 PM

#

Yeah it's a bit more, I think you should do it a util function

static canyon Jul 23, 2021, 7:15 PM

#

if error:
    await ctx.send(embed=embed, delete_after=INVALID_INPUT_DELETE_DELAY)
    await ctx.message.delete(delay=INVALID_INPUT_DELETE_DELAY)
```would become```py
if error:
    error_message = await ctx.send(embed=embed)
    await wait_for_deletion(error_message, (ctx.author.id,), timeout=INVALID_INPUT_DELETE_DELAY)
    with suppress(NotFound):
        await error_message.clear_reaction(Emojis.trashcan)
    # If won't ghost-ping when deleting message 
    if not (ctx.message.mentions or ctx.message.role_mentions):
        with suppress(NotFound):
            await ctx.message.delete()```

viscid coral Jul 23, 2021, 7:15 PM

#

Makes the code look better and that it dpesn't repeat itself

static canyon Jul 23, 2021, 7:15 PM

#

@brisk brook ^

#

Or```py
async def delete_message_if_no_pings(message: discord.Message):
"""Checks whether message pings any users. If it doesn't, will safe-delete it."""
# If won't ghost-ping when deleting message, delete it
if not (message.mentions or message.role_mentions):
with suppress(NotFound):
await message.delete()

...

in command

if error:
error_message = await ctx.send(embed=embed)
await delete_invocation_if_no_pings(ctx)```

brisk brook Jul 23, 2021, 7:18 PM

#

That's not a fair comparison, the latter codeblock does not do the same thing

static canyon Jul 23, 2021, 7:19 PM

#

Right my bad

#

lemme fix

#

I think actually we should just make wait_for_deletion remove the reaction. Then it'd be the same

brazen charm Jul 23, 2021, 7:20 PM

#

wait_for_deletion usually deals with timeouts where it really isn't necessary to remove

static canyon Jul 23, 2021, 7:21 PM

#

Would it be bad to make it remove though? I can't really see any downside to it

#

Would mean changingpy with contextlib.suppress(asyncio.TimeoutError): await bot.instance.wait_for('reaction_add', check=check, timeout=timeout) await message.delete()topy try: await bot.instance.wait_for('reaction_add', check=check, timeout=timeout) except asyncio.TimeoutError: await message.clear_reactions() else: await message.delete()

#

There's also the fact that if the message still has reactions, but isn't listening for reaction_add anymore, then it makes it look like the bot isn't working when someone clicks a reaction

brisk brook Jul 23, 2021, 7:32 PM

#

Might be good to research the use of wait_for_deletion()

static canyon Jul 23, 2021, 7:32 PM

#

brisk brook Might be good to research the use of `wait_for_deletion()`

~~No clue how to do that~~

brisk brook Jul 23, 2021, 7:32 PM

#

Could be a deal-breaker for some code

brisk brook Jul 23, 2021, 7:33 PM

#

static canyon ~~No clue how to do that~~

Search the repository for that function name and see if adding that line will break any code using it.

static canyon Jul 23, 2021, 7:33 PM

#

How do I search the repository?

#

Can only search for a file

brisk brook Jul 23, 2021, 7:35 PM

#

You can search locally in whatever editor you use, I am pretty sure all editors have this option.

Otherwise you could use sourcegraph or similar online options. Sourcegraph is pretty cool!

static canyon Jul 23, 2021, 7:42 PM

#

Just had a look and it won't break anything anywhere

#

Wouldn't even have to touch the other files using it

#

(https://sourcegraph.com/search?q=context:global+repo:^github\.com/python-discord/bot%24+wait_for_deletion&patternType=literal)

#

The only case it'd break is if you tried to remove the reactions without suppressing which is never done (only place that tries to remove is my PR, which uses contextlib.suppress so wouldn't raise an error)

#

@brisk brook ^

brisk brook Jul 23, 2021, 7:47 PM

#

I see, well in that case sounds good

#

!eval print(0)

stable mountainBOT Jul 23, 2021, 7:47 PM

#

@brisk brook :white_check_mark: Your eval job has completed with return code 0.

static canyon Jul 23, 2021, 7:48 PM

#

That doesn't timeout but I can always only remove when a timeout is specified

#

(Logic would be in same function so have access to the timeout)

brisk brook Jul 23, 2021, 7:49 PM

#

How long was the time? It's like only a few minutes right?

I think this is a nice QoL, because eventually this message here won't delete when I click 🗑️. If we clear the reaction when this happens means we don't break any user-made assumptions.

static canyon Jul 23, 2021, 7:49 PM

#

In fact that does have a timeout

#

It's the default, 60 * 5 (5mins)

#

I think this is a nice QoL
QoL to make the change I'm suggesting?

brisk brook Jul 23, 2021, 7:50 PM

#

Yes, please change this to remove the reaction.

static canyon Jul 23, 2021, 7:51 PM

#

Will do 👍

#

Are you cool with me @ing you in the GitHub issue?

viscid coral Jul 23, 2021, 7:51 PM

#

What is QoL?

static canyon Jul 23, 2021, 7:51 PM

#

Quality of life

brisk brook Jul 23, 2021, 7:52 PM

#

static canyon Are you cool with me `@ing` you in the GitHub issue?

Feel free, that is no problem.

static canyon Jul 23, 2021, 7:57 PM

#

static canyon Would mean changing```py with contextlib.suppress(asyncio.TimeoutError): ...

This should be the only change right? @brisk brook

brisk brook Jul 23, 2021, 7:58 PM

#

It's so small there's probably no issue if you do both the remove the reaction change as well as adding that usage to the command

static canyon Jul 23, 2021, 7:58 PM

#

I mean I've already created the issue now lol

#

But yeah you're right, probably could've done in the same one

viscid coral Jul 23, 2021, 7:59 PM

#

How come none of you have the contributors role? I mean ya'll do a lot

static canyon Jul 23, 2021, 7:59 PM

#

viscid coral How come none of you have the contributors role? I mean ya'll do a lot

I mean this is one of the first things I've really done on the GitHub personally

viscid coral Jul 23, 2021, 8:00 PM

#

It doesn't have to only be on github tho(I think), you also help a lot about the server in community-meta

static canyon Jul 23, 2021, 8:00 PM

#

It's GitHub only (or more specifically dev-ops If I remember correctly)

brisk brook Jul 23, 2021, 8:01 PM

#

viscid coral How come none of you have the contributors role? I mean ya'll do a lot

I haven't contributed a lot over time yet. I mean, I reviewed Chris's Pixels V2 pr as well as submitted my own. But not much else yet.

static canyon Jul 23, 2021, 8:01 PM

#

static canyon This should be the only change right? <@!344404945359077377>

Can I get a yes/no confirmation for this please @brisk brook

#

Wanna make sure I'm not missing anything stupid

brisk brook Jul 23, 2021, 8:02 PM

#

static canyon Can I get a yes/no confirmation for this please <@!344404945359077377>

I am not sure how to interpret what you said?

Your PR can both add clear_reaction to wait_for_deletion() and change the !pypi command to use wait_for_deletion()

#

It's not a big change, so it should be good.

static canyon Jul 23, 2021, 8:03 PM

#

I did the wait_for_deletion() as its own issue

#

So I guess I can just make it solve both issues?

brisk brook Jul 23, 2021, 8:03 PM

#

Yes but the PR to fix it can do both

static canyon Jul 23, 2021, 8:03 PM

#

Right okay

brisk brook Jul 23, 2021, 8:03 PM

#

static canyon So I guess I can just make it solve both issues?

Yes!

static canyon Jul 23, 2021, 8:03 PM

#

I am not sure how to interpret what you said?
Is that the only change needed for the wait_for_deletion update?

brisk brook Jul 23, 2021, 8:04 PM

#

They're quite related

brisk brook Jul 23, 2021, 8:04 PM

#

static canyon > I am not sure how to interpret what you said? Is that the only change needed f...

Yeah pretty much. Just add awair message.clear_reaction() at the end of the function.

static canyon Jul 23, 2021, 8:05 PM

#

Only want to clear the reactions when we don't delete the message though

#

To save the error

#

Hence I changed to try/except/else

brisk brook Jul 23, 2021, 8:05 PM

#

Ah, yes that code looks correct

static canyon Jul 23, 2021, 8:05 PM

#

👍

static canyon Jul 23, 2021, 8:08 PM

#

static canyon Or```py async def delete_message_if_no_pings(message: discord.Message): """C...

And I want to add the other utility right? The delete_message_if_no_pings

#

@brisk brook ^

brisk brook Jul 23, 2021, 8:11 PM

#

I mean I may not be one to have complete control over that, but I don't like it. It's like 1 line saved?

static canyon Jul 23, 2021, 8:11 PM

#

2 lines each time you use it, and I'll be using it at least twice

brisk brook Jul 23, 2021, 8:12 PM

#

3 lines of code vs (usage + import). 2 lines

static canyon Jul 23, 2021, 8:12 PM

#

Right yea true

#

I mean it saves duplicate code again

brisk brook Jul 23, 2021, 8:12 PM

#

static canyon 2 lines each time you use it, and I'll be using it at least twice

It also makes the code less readable. One has to look up the function definition to see what it does

static canyon Jul 23, 2021, 8:12 PM

#

Yeah true

#

I agree

#

Think I'll leave that

brisk brook Jul 23, 2021, 8:13 PM

#

Sounds good

static canyon Jul 23, 2021, 8:21 PM

#

Should I be suppressing anything here? https://github.com/TizzySaurus/bot/blob/main/bot/utils/messages.py#L98-L103

stable mountainBOT Jul 23, 2021, 8:21 PM

#

bot/utils/messages.py lines 98 to 103

try:
    await bot.instance.wait_for('reaction_add', check=check, timeout=timeout)
except asyncio.TimeoutError:
    await message.clear_reactions()
else:
    await message.delete()```

static canyon Jul 23, 2021, 8:21 PM

#

@brisk brook ^

#

Don't think I need to

#

Yeah, I shouldn't need to

brisk brook Jul 23, 2021, 8:22 PM

#

The original code didn't suppress anything other than TimeoutError so no

static canyon Jul 23, 2021, 8:22 PM

#

brisk brook The original code didn't suppress anything other than TimeoutError so no

I have now added the clear_reactions() but that shouldn't be an issue

#

Only case it might is if there was no reactions but the function returns before this line if that happens so no issues

#

Let's see if I can remember how to do the PR lemon_grimace

viscid coral Jul 23, 2021, 8:27 PM

#

I think I did something weird once about forking the project, changing what neeeded, and submitting it

static canyon Jul 23, 2021, 8:30 PM

#

Does this look right? @brisk brook

viscid coral Jul 23, 2021, 8:31 PM

#

I think it looks ok, but not 100% sure

static canyon Jul 23, 2021, 8:31 PM

#

Slightly reworded

#

I wonder

#

nvm

brisk brook Jul 23, 2021, 8:33 PM

#

You won't be correctly linking both issues

static canyon Jul 23, 2021, 8:34 PM

#

brisk brook You won't be correctly linking both issues

Wdym?

#

#

#

They seem to both be linked

brisk brook Jul 23, 2021, 8:35 PM

#

GitHub doesn't understand "and"

static canyon Jul 23, 2021, 8:36 PM

#

Both display though?

brisk brook Jul 23, 2021, 8:36 PM

#

It links the issue so that you can click it. But it won't show "This issue will be automatically closed when this pull request is merged"

viscid coral Jul 23, 2021, 8:36 PM

#

So just:
Solves #1695
Solves #1624?

static canyon Jul 23, 2021, 8:36 PM

#

Or this?

brisk brook Jul 23, 2021, 8:37 PM

#

viscid coral So just: `Solves #1695` `Solves #1624`?

Yeah you need one of those verbs in front of it. But you could word it better.

static canyon Jul 23, 2021, 8:38 PM

#

Wording doesn't really matter, as long as it makes sense

#

I'd rather not ducky_bike like we did with the docstring tag earlier lol

#

Also is the "Can't automatically merge" an issue?

#

@brisk brook

viscid coral Jul 23, 2021, 8:40 PM

#

It says you can still open PR, I wonder what it's cause

brisk brook Jul 23, 2021, 8:40 PM

#

static canyon Also is the "Can't automatically merge" an issue?

Hm?

static canyon Jul 23, 2021, 8:41 PM

#

brisk brook Hm?

green oriole Jul 23, 2021, 8:42 PM

#

You have conflicts to solve

static canyon Jul 23, 2021, 8:42 PM

#

God damn it

green oriole Jul 23, 2021, 8:42 PM

#

Just create the PR for now, we can solve them later

static canyon Jul 23, 2021, 8:43 PM

#

Alright

brisk brook Jul 23, 2021, 8:43 PM

#

This is probably because you have changes from your old PR on that branch

#

You should always create a new branch when making a PR so that this doesn't happen.

YOU/main should preferably always be up-to-date python-discord/main

green oriole Jul 23, 2021, 8:44 PM

#

You should work on the pydis repo though

static canyon Jul 23, 2021, 8:45 PM

#

green oriole Just create the PR for now, we can solve them later

Fixed it

#

Think I did anyway

#

God damn it

#

Linting has gone back to being the bane of my existence

#

Doesn't even say the error lemon_grimace

thorny obsidian Jul 23, 2021, 8:46 PM

#

Trailing whitespace

static canyon Jul 23, 2021, 8:47 PM

#

Again lemon_exploding_head

viscid coral Jul 23, 2021, 8:48 PM

#

lol

brisk brook Jul 23, 2021, 8:48 PM

#

It's in the comment I think?

static canyon Jul 23, 2021, 8:50 PM

#

Yeah I fixed one in a comment

#

Don't understand this comment @brisk brook https://github.com/python-discord/bot/pull/1696/files#r675857486

brisk brook Jul 23, 2021, 8:51 PM

#

Since you removed this code: await error_message.clear_reaction(Emojis.trashcan) you no longer need to import Emojis

static canyon Jul 23, 2021, 8:51 PM

#

Right

brisk brook Jul 23, 2021, 8:51 PM

#

from bot.constants import MODERATION_ROLES, RedirectOutput

static canyon Jul 23, 2021, 8:52 PM

#

Don't think that's what you linked to though?

#

#

Unless me/GitHub is just messing up

brazen charm Jul 23, 2021, 8:56 PM

#

https://github.com/python-discord/bot/pull/1663/files has been lying around for a bit now if anyone's up for it

GitHub

Add tag groups and in file metadata by Numerlor · Pull Request #166...

Introduces tag groups described in #1545.
When matching a tag with a group, the group is matched with no minimum amount of chars (unlike a tag that has to have 3 chars of its name) to allow a short...

vocal wolf Jul 23, 2021, 8:56 PM

#

what is going on over here?

green oriole Jul 23, 2021, 8:56 PM

#

Fisher is fishing resources

vocal wolf Jul 23, 2021, 8:56 PM

#

nais

#

have fun

#

and also someone review that PR Numerlor linked

twilit juniper Jul 23, 2021, 8:57 PM

#

vocal wolf what is going on over here?

Illegal activity

static canyon Jul 23, 2021, 8:59 PM

#

Hopefully this time 🤞

#

Finally 🎉

#

Just needs the reviews now https://github.com/python-discord/bot/pull/1696
CC @brisk brook (and @viscid coral if you'd like to do another)

#

bot#1696

dusky shoreBOT Jul 23, 2021, 9:02 PM

#

GitHub

PROpen Prevent ghost-pings in pypi command

viscid coral Jul 23, 2021, 9:07 PM

#

Seems ok to me

static canyon Jul 23, 2021, 9:39 PM

#

@brisk brook can't figure out how to do the docstring

#

    """
    Wait for up to `timeout` seconds for a reaction by any of the specified `user_ids` to delete the message.
    If user doesn't respond in time, will clear all reactions to indicate option to delete has expired.

    An `attach_emojis` bool may be specified to determine whether to attach the given
    `deletion_emojis` to the message in the given `context`.
    An `allow_mods` bool may also be specified to allow anyone with a role in `MODERATION_ROLES` to delete
    the message.
    """```did this but it failed linting because it needs a blank line between summary and description (considers 2nd line as description rather than part of summary)

brazen charm Jul 23, 2021, 9:40 PM

#

multi line docstrings should be laid out with one line at the top, an empty line, and then the more verbose description

#

You should either condense it into one line, or move it to a more fitting place

static canyon Jul 23, 2021, 9:41 PM

#

move it to a more fitting place
What do you mean by this? @brazen charm

brazen charm Jul 23, 2021, 9:47 PM

#

I think in this case a newline between the first two lines would be the nicest

brisk brook Jul 23, 2021, 9:47 PM

#

    """
    Wait for up to `timeout` seconds for a reaction by any of the specified `user_ids` to delete the message.

    If user doesn't respond in time, will clear all reactions to indicate option to delete has expired.
    An `attach_emojis` bool may be specified to determine whether to attach the given
    `deletion_emojis` to the message in the given `context`.
    An `allow_mods` bool may also be specified to allow anyone with a role in `MODERATION_ROLES` to delete
    the message.
    """

#

Just put it in the description

brazen charm Jul 23, 2021, 9:48 PM

#

I'd leave the newline after it in place

static canyon Jul 23, 2021, 9:48 PM

#

    """
    Wait for up to `timeout` seconds for a reaction by any of the specified `user_ids` to delete the message.
    
    If user doesn't respond in time, will clear all reactions to indicate option to delete has expired.

    An `attach_emojis` bool may be specified to determine whether to attach the given
    `deletion_emojis` to the message in the given `context`.
    An `allow_mods` bool may also be specified to allow anyone with a role in `MODERATION_ROLES` to delete
    the message.
    """```so this?

#

"""
Wait for any of `user_ids` to react with one of the `deletion_emojis` within `timeout` seconds to delete `message`.

If `timeout` expires then reactions are cleared to indicate the option to delete has expired.
...
"""```think this is more descriptive actually

#

Committed for now since going to bed in a minute

#

Going to bed now, bot#1696 just needs 2 more reviews and then bot#1624 and bot#1695 should be able to be closed

dusky shoreBOT Jul 23, 2021, 10:05 PM

#

GitHub

PROpen Prevent ghost-pings in pypi command

trim cradle Jul 23, 2021, 10:25 PM

#

For the new resources system, we need something that reads all the resource yaml files and aggregates certain data from them. I want this to run once when the site launches and then cache that information. How should I approach this? Do TemplateViews have an "on launch" event?

vale ibex Jul 23, 2021, 10:36 PM

#

Might be easier to cache it into redis on the first hit

#

then subsequent hits can just check for that key first

#

I'm not sure if we already have a pattern like this setup in site or not

trim cradle Jul 23, 2021, 10:54 PM

#

CC @blazing magnet

blazing magnet Jul 24, 2021, 1:22 AM

#

trim cradle CC <@!233481908342882304>

Yeah, that makes sense to me. I have zero experience with redis though. Only have a bit of experience consuming in js

blazing magnet Jul 24, 2021, 1:29 AM

#

trim cradle For the new resources system, we need something that reads all the resource yaml...

Any code you put in the app's urls.py file will run when the app is started up. Although this could be a little hacky

green oriole Jul 24, 2021, 6:53 AM

#

Eh, using Redis comes with a lot of problems due to race conditions. How intensive would be this computation?

static canyon Jul 24, 2021, 8:03 AM

#

Can I get 2 more review on bot#1696 please? It closes bot#1695 and also bot#1624

dusky shoreBOT Jul 24, 2021, 8:03 AM

#

GitHub

IssueOpen Do not delete !docs/!pypi invocation if it contains a ping
PROpen Prevent ghost-pings in pypi command
Change utils.messages.wait_for_deletion to delete reactions after timeout

last patio Jul 24, 2021, 10:01 AM

#

I'll take a look after trackmania

static canyon Jul 24, 2021, 10:08 AM

#

Thanks 👍

eternal owl Jul 24, 2021, 1:51 PM

#

can anyone core-dev/admin re-run the test/lint for this PR
https://github.com/python-discord/site/pull/508

last patio Jul 24, 2021, 1:52 PM

#

isn't it missing a push?

#

i requested a re-run but i don't think it's going to change anything

eternal owl Jul 24, 2021, 1:52 PM

#

I thought I forgot to make migrations for a model or so, but I have everything migarted

#

everything is pushed

#

maybe I should just update the branch and see

#

updated the branch rn

last patio Jul 24, 2021, 1:54 PM

#

yeah, the django error about migrations still pops up:

CommandError: Conflicting migrations detected; multiple leaf nodes in the migration graph: (0070_auto_20210519_0545, 0071_increase_message_content_4000 in api).
21

eternal owl Jul 24, 2021, 1:54 PM

#

right

#

trying to run those commands and fixing it

#

should hopefully fix it now

last patio Jul 24, 2021, 1:58 PM

#

@green oriole do you mind if i request you in for a few reviews

eternal owl Jul 24, 2021, 1:58 PM

#

passed \o/

clever wraith Jul 24, 2021, 2:05 PM

#

@lime sluice

exotic ember Jul 24, 2021, 3:05 PM

#

@static canyon re:ghost pings, go for it, I think it's how it used to be too

green oriole Jul 24, 2021, 3:52 PM

#

last patio <@!407110650217627658> do you mind if i request you in for a few reviews

Sure, although I will probably not have enough time for huge PRs until next week, I have to rush a project for work and finish my talk

last patio Jul 24, 2021, 3:55 PM

#

ah you're already requested in one of them (site #526) as code owner

#

i'll throw in another

green oriole Jul 24, 2021, 3:56 PM

#

Sounds good

viscid coral Jul 24, 2021, 8:14 PM

#

!user

stable mountainBOT Jul 24, 2021, 8:14 PM

#

You are not allowed to use that command here. Please use the #bot-commands channel instead.

viscid coral Jul 24, 2021, 8:17 PM

#

I think joined should be used this format: x years, x months, x days ago(unix timestamp here of joined date) because if the user language is not English it isn'y understandable

vocal prairie Jul 24, 2021, 8:17 PM

#

If they hover over it, they can see the exact time

#

It's a feature of Discord handled by your client (so it should be your own language)

#

Looks like this when I switched my discord language to french

gritty wind Jul 24, 2021, 8:46 PM

#

viscid coral I think joined should be used this format: `x years, x months, x days ago(unix t...

Even though it isn’t relevant here, not sure any of this server is understandable if you don’t speak English.

tawdry vapor Jul 25, 2021, 12:25 AM

#

For sentry

#

https://docs.sentry.io/product/releases/

Releases

Learn how to provide information to Sentry about your releases to determine regressions and resolve issues quickly.

weary pumice Jul 25, 2021, 1:16 PM

#

why is the main folder containing the application files for sir lancebot called bot instead of src, is this some convention to make the src folder be more informative?

patent pivot Jul 25, 2021, 1:18 PM

#

weary pumice why is the main folder containing the application files for sir lancebot called ...

when writing a python application, you should always title the source code directory as the name of the application

#

src is not a convention in python

#

because when you come to run your application, you use python -m my_module

#

so in our case, python -m bot

weary pumice Jul 25, 2021, 1:22 PM

#

i see, thx joe

peak monolith Jul 25, 2021, 3:47 PM

#

hey guys

#

I'm getting this error when pushing my git

#

I will send a ss

#

can anyone welp

#

#

this

brisk brook Jul 25, 2021, 3:59 PM

#

So if your branch looks like this: ```
A -> B -> C -> D


Your repository looks like this: ```
A -> B -> C -> D -> F

What type of changes have you made? Do you know why your repository has the F commit, but you don't?

cold island Jul 25, 2021, 4:07 PM

#

Is this about one of our projects? this channel is for conversations about the development of our projects.

brisk brook Jul 25, 2021, 9:51 PM

#

Do all projects on the whole organization use LF as line endings? What's the policy there?
There was no mention on which character to use here: https://pythondiscord.com/pages/guides/pydis-guides/contributing/style-guide/#line-breaks

Python Discord - Style Guide

Coding conventions for our Open Source projects.

gritty wind Jul 25, 2021, 9:53 PM

#

So, yes technically we do use LF, and it used to be enforced using pre-commit

#

The thing is, it isn’t really all that convenient for most beginners and unaware people (particularly windows, where git by default clones in CRLF, and checks in with LF)

#

Ultimately, it doesn’t make any actual difference for most purposes

#

And it is still enforced to some extent using gitattributes

#

The repos that don’t have it, you’d have to specifically want and know to commit non-LF ending

#

So it’s mostly ignored

brisk brook Jul 25, 2021, 9:56 PM

#

gritty wind And it is still enforced to some extent using gitattributes

Ah, yeah.

viscid coral Jul 26, 2021, 7:35 AM

#

@old shard

old shard Jul 26, 2021, 7:53 AM

#

!d aiohttp Returns the page https://docs.aiohttp.org/en/stable/structures.html#module-aiohttp instead of the homepage for aiohttp

viscid coral Jul 26, 2021, 8:08 AM

#

Maybe open an isuue https://github.com/python-discord/bot/issues

brazen charm Jul 26, 2021, 9:04 AM

#

old shard `!d aiohttp` Returns the page https://docs.aiohttp.org/en/stable/structures.html...

The bot just sends what was provided for a given symbol by the maintainers of the library

brisk brook Jul 26, 2021, 2:56 PM

#

@vale ibex what the hell

vale ibex Jul 26, 2021, 2:56 PM

#

lmfao

#

picking up an old branch

#

was quite out of date so I did a merge commit

#

rather than dealing with the endless conflicts with rebasing

brisk brook Jul 26, 2021, 2:58 PM

#

What will happen when you're gonna merge it into main?

vale ibex Jul 26, 2021, 2:58 PM

#

they won't be duplicated

brazen charm Jul 26, 2021, 2:58 PM

#

It'll have a merge commit

vale ibex Jul 26, 2021, 2:59 PM

#

If you take a look at https://github.com/python-discord/bot/pull/1527/commits

GitHub

Re-work clean command to be more efficient, have more features. by ...

Justification
Our current implementation of clean is fairly inefficient with how it handles message deletion.
Few examples of that are:

Using two different ways of deleting messages, depending on ...

brisk brook Jul 26, 2021, 2:59 PM

#

Ah yeah, that's true haha

vale ibex Jul 26, 2021, 2:59 PM

#

the 3rd from last will be in the history

#

I'm not actually sure what's best practice tbh

#

I think we mostly do merge commits from what I've seen

brisk brook Jul 26, 2021, 3:01 PM

#

Yeah I think it seems so

#

I was looking at this:
https://github.com/python-discord/bot/compare/e5e4343435c3...1d08b29aedd6

GitHub

Comparing e5e4343435c3...1d08b29aedd6 · python-discord/bot

The community bot for the Python Discord community - Comparing e5e4343435c3...1d08b29aedd6 · python-discord/bot

#

There the commits brought from the merge is shown, so I thought those would also be added onto main 😅

vale ibex Jul 26, 2021, 3:02 PM

#

lol yea, luckily not

cold island Jul 26, 2021, 3:52 PM

#

Yeah we just do merge commits

sleek steppe Jul 26, 2021, 4:11 PM

#

brisk brook There the commits brought from the merge is shown, so I thought those would also...

yeah the commits are already there

steel isle Jul 26, 2021, 4:18 PM

#

I had this idea of storing roles on leaving

It allows for temporary leaves and rejoins
On tempban, it allows for regaining of roles

The main argument against this is storage.

This is my counter-argument:

Say a user can have max 15 roles.
That's a max of 16 bigints (User ID + Role IDs)
A quick google search tells me that each bigint = 8 bytes of storage
so that would be 16*8 bytes or an 8th of a kb

Say we have 200k members
that would be 200k * 1/8 kb or 25k kb or ~25 mb

A generalized formula:
m = number of roles
n = number of members

Total Storage = (m+1)8n bytes

This is not much storage at all - Much smaller than anticipated!
I suggest removal of roles after some time like a month to save space anyway

hardy gorge Jul 26, 2021, 4:20 PM

#

What kind of roles do we want to persist?

#

We're already persisting the Muted-role, which is the most important role to persist

steel isle Jul 26, 2021, 4:20 PM

#

something like the pixelators role

#

the reason is that I would like to leave the server temporarily

hardy gorge Jul 26, 2021, 4:21 PM

#

That's a temporary role, right?

steel isle Jul 26, 2021, 4:21 PM

#

it is?

hardy gorge Jul 26, 2021, 4:21 PM

#

Typically, if someone gets a role here, they get a role for a reason

#

If they leave the community and come back, we typically want to decide whether or not they should have the role back

steel isle Jul 26, 2021, 4:22 PM

#

okay

hardy gorge Jul 26, 2021, 4:28 PM

#

I'm not sure, but we typically don't have vanity roles or the like

#

We typically have temporary roles for an event for if we want to do things like an event announcement

steel isle Jul 26, 2021, 4:28 PM

#

ah okay

#

even then, 25 mb is a stupidly small amount of storage to store all roles
I expected it to take more

tawdry vapor Jul 26, 2021, 4:35 PM

#

I don't think storage is the main concern like you purport. Every user's role is already being stored (except it's deleted when they leave).

#

A similar system already exists, but it's only for mute roles.

#

However, I think that relies on infraction data (which is not deleted) rather than the saved roles.

steel isle Jul 26, 2021, 4:37 PM

#

tawdry vapor A similar system already exists, but it's only for mute roles.

I would like to expand it to useful roles like the helper, etc

#

cosmetic roles would be nice too

tawdry vapor Jul 26, 2021, 4:40 PM

#

It's a niche situation. There are few people with "cosmetic" roles and it also seems rare to leave and then come back.

#

Rare enough that there's likely the capacity to handle it on a case by case basis.

#

There may also be user privacy concerns with retaining that data when they leave, especially since the DB schema is designed to tie the roles to the user object. I am not familiar with privacy stuff though.

hardy gorge Jul 26, 2021, 4:43 PM

#

In addition, when it comes to roles that grant someone permissions, I doubt we will ever create a system that would grant that role automatically when someone rejoins the guild. If someone leaves by accident, it's not too much work to give them back the role manually.

steel isle Jul 26, 2021, 4:49 PM

#

ah okay

#

I see

viscid coral Jul 26, 2021, 6:15 PM

#

A few days ago, TizzySaurus made a PR and an issue to avoid ghost pings in docs and pypi commands. Shouldn't it be reported in #changelog ?

tawdry vapor Jul 26, 2021, 6:24 PM

#

This question belongs in #tools-and-devops

weary pumice Jul 26, 2021, 6:24 PM

#

ah sry

tawdry vapor Jul 26, 2021, 6:24 PM

#

No problem

viscid coral Jul 26, 2021, 6:39 PM

#

viscid coral A few days ago, TizzySaurus made a PR and an issue to avoid ghost pings in `docs...

?

gritty wind Jul 26, 2021, 6:42 PM

#

Yeah, it’s usually just whenever someone with perms get around to it

viscid coral Jul 26, 2021, 6:54 PM

#

Yeah I asked chris and he said to send it here

viscid coral Jul 26, 2021, 9:02 PM

#

So isn't there someone with perms?

brisk brook Jul 26, 2021, 9:04 PM

#

There's probably nobody with time atm

green oriole Jul 26, 2021, 9:29 PM

#

I'll relay it in #dev-core, someone will probably come around and do it

viscid coral Jul 26, 2021, 9:30 PM

#

Ok thanks

green oriole Jul 26, 2021, 9:31 PM

#

I don't have perms to post anymore if that's what you are asking

#

lol

brazen charm Jul 26, 2021, 9:32 PM

#

doesn't feel like a very noteworthy change

thorny obsidian Jul 26, 2021, 9:33 PM

#

An admin will get around to it at some point. It's not exactly urgent or that big of a change.

green oriole Jul 26, 2021, 9:36 PM

#

Yep

#

Even if it is changelogged in a week, who is counting tbh

patent pivot Jul 26, 2021, 10:11 PM

#

our k8s or generic k8s? feel free to post here

#

ahh lol

viscid coral Jul 27, 2021, 6:53 AM

#

Isn't it better to not do if channel is None and do: if not channel? Or better yet, just channel = channel or ctx.channel

#

I can see it is used many times in code

left flume Jul 27, 2021, 7:05 AM

#

i think ill tell it here

#

the bookmark command cannot bookmark msgs from other channels

#

could the ability to bookmark msgs from other channels be added to lancebot?

vale ibex Jul 27, 2021, 7:48 AM

#

left flume the bookmark command cannot bookmark msgs from other channels

It can, you just need to use the full message link, or do channelid-messageid

#

That's because just message ids aren't enough to get the message, you need channelid and messageid

#

Due to this fact, we assume the channelid is the current channelid none is specified

viscid coral Jul 27, 2021, 8:05 AM

#

viscid coral A few days ago, TizzySaurus made a PR and an issue to avoid ghost pings in `docs...

Chris, what about that?

left flume Jul 27, 2021, 8:39 AM

#

ohhh okay

cold island Jul 27, 2021, 8:54 AM

#

viscid coral Isn't it better to not do `if channel is None` and do: `if not channel`? Or bett...

Well, there's no goal of making the code as concise as possible. This is also a goal that often comes at the expense of readability. So one reason for the author to have written it this way can be that they thought that made the code more verbose and English-like

viscid coral Jul 27, 2021, 8:54 AM

#

Oh ok thanks

cold island Jul 27, 2021, 8:55 AM

#

In this case if not channel seems equally fine

#

In other cases however an object can have a defined state of false-iness. For example an empty list is evaluated as False.

if not my_list will be true in all cases in which it's False, while if my_list is not None will only be True in a single case

rigid rain Jul 27, 2021, 4:22 PM

#

Can some tell me what is "pre commit Failing after n seconds" in github?

gritty wind Jul 27, 2021, 4:24 PM

#

Well I’m assuming that’s the lint action, on the pre-commit step. Pre commit runs a bunch of linting tools like flake. You can expand it to see the specific error

rigid rain Jul 27, 2021, 4:26 PM

#

gritty wind Well I’m assuming that’s the lint action, on the pre-commit step. Pre commit run...

I don't know how to expand it to specific. I am getting this first time

gritty wind Jul 27, 2021, 4:27 PM

#

Can you send a link to the workflow?

cold island Jul 27, 2021, 4:36 PM

#

Or just the pull request

rigid rain Jul 27, 2021, 4:56 PM

#

https://github.com/TheAlgorithms/Python/pull/4573

GitHub

Modified for making the code readable by Miltonbhowmick · Pull Requ...

Describe your change:

Fix a readable issue in a_star[dot]py algo?

Checklist:

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull req...

#

@gritty wind

gritty wind Jul 27, 2021, 4:57 PM

#

The failing action is black (make sure to lint before you push)

#

https://github.com/TheAlgorithms/Python/pull/4573/checks?check_run_id=3173500521

#

(From the actions tab)

#

Well that’ll depend entirely on the project you’re working on. If they have a contributing guide, make sure to go over it. Linting is just making sure you follow the style guidelines

rigid rain Jul 27, 2021, 4:59 PM

#

oh ...i understand

gritty wind Jul 27, 2021, 4:59 PM

#

Also, for general contributing questions not related to this server’s projects, you can claim a help channel (#❓｜how-to-get-help)

rigid rain Jul 27, 2021, 4:59 PM

#

sorry for using wrong channel

gritty wind Jul 27, 2021, 4:59 PM

#

It’s fine

shut aspen Jul 27, 2021, 6:19 PM

#

threads are here, how is python bot handling that

thorny obsidian Jul 27, 2021, 6:20 PM

#

It's not because d.py 2.0 hasn't been released yet. No part of the current stable release of d.py can handle threads.

shut aspen Jul 27, 2021, 6:20 PM

#

thorny obsidian It's not because d.py 2.0 hasn't been released yet. No part of the current stabl...

yee i noticed, my mod bot is kinda not a good bot atm

#

the d.py server seems unbothered by thsi massive breaking change

thorny obsidian Jul 27, 2021, 6:20 PM

#

Danny's been working on it since the api docs got released but it takes time

shut aspen Jul 27, 2021, 6:21 PM

#

it always does, but for discord to drop this so suddenly

#

kinda opens servers up to all sorts of issues considering libraries arent ready for it

thorny obsidian Jul 27, 2021, 6:22 PM

#

So threads are opt in. For us threads are locked to certain staff roles and to internal channels.

gritty wind Jul 27, 2021, 6:28 PM

#

Also discord gave 2 months heads up

shut aspen Jul 27, 2021, 6:33 PM

#

gritty wind Also discord gave 2 months heads up

ya i think its really more that d.py chose a VERY bad time to decide to migrate to 2.0 now

vale ibex Jul 27, 2021, 6:41 PM

#

You've got it the wrong way around

#

2.0 is because of threads & interactions

#

the Discord v9 gateway brings in breaking changes, so a breaking change was also required in d.py

green oriole Jul 27, 2021, 6:47 PM

#

gritty wind Jul 27, 2021, 6:47 PM

#

@patent pivot hi no questions just wanted to say hi

green oriole Jul 27, 2021, 6:47 PM

#

Let's go

patent pivot Jul 27, 2021, 6:47 PM

#

approved

green oriole Jul 27, 2021, 6:48 PM

#

joe_salute is now our new shipit

shut aspen Jul 27, 2021, 7:02 PM

#

vale ibex the Discord v9 gateway brings in breaking changes, so a breaking change was also...

oof, other libs have already updated tho, d.py is being incredibly slow

vale ibex Jul 27, 2021, 7:03 PM

#

shut aspen oof, other libs have already updated tho, d.py is being incredibly slow

discord.js also hasn't updated yet.

#

discord.js and discord.py are the two most used libs, so they want to get it right, and have to worry a lot about backwards compatibility, and maintenance

vale ibex Jul 27, 2021, 7:05 PM

#

shut aspen oof, other libs have already updated tho, d.py is being incredibly slow

https://github.com/Rapptz/discord.py/projects/3 These are the changes coming in 2.0

shut aspen Jul 27, 2021, 7:06 PM

#

ya ive been following it, afaik no date of arrival tho

#

unless i missed that

vale ibex Jul 27, 2021, 7:07 PM

#

nope, because they don't want to commit to a date, since it's all in their free time

shut aspen Jul 27, 2021, 7:08 PM

#

such is the pain of relying on open source i suppose

green oriole Jul 27, 2021, 7:15 PM

#

https://xkcd.com/2347/

xkcd: Dependency

last patio Jul 27, 2021, 7:19 PM

#

green oriole https://xkcd.com/2347/

Is that libcurl? 😛

green oriole Jul 27, 2021, 7:20 PM

#

lol, yes

#

The curl guy is quite nice though

green oriole Jul 27, 2021, 7:55 PM

#

About the snekbox issue: line numbers are super useful on mobile to distinguish between line wrapping and actual line breaks

remote wigeon Jul 27, 2021, 8:29 PM

#

green oriole https://xkcd.com/2347/

oh god, its actually quite scary how accurate this is

green oriole Jul 27, 2021, 8:30 PM

#

I know, right

brisk brook Jul 27, 2021, 8:34 PM

#

green oriole About the snekbox issue: line numbers are super useful on mobile to distinguish ...

Agreed, you can also point to it when explaining output.

#

There's not much to gain from removing them

fallen patrol Jul 27, 2021, 9:13 PM

#

vale ibex discord.js and discord.py are the two most used libs, so they want to get it rig...

AcTUAlly, dpy doesn't care about backwards compat rn, v2.0 is fully breaking

brisk brook Jul 27, 2021, 9:17 PM

#

fallen patrol AcTUAlly, dpy doesn't care about backwards compat rn, v2.0 is fully breaking

If they don't get it right, they can't change it later

fallen patrol Jul 27, 2021, 9:18 PM

#

it must be [isort] in tox.ini

#

i have tested this very thoroughly

fallen patrol Jul 27, 2021, 9:19 PM

#

brisk brook If they don't get it right, they can't change it later

yeah, true

vale ibex Jul 27, 2021, 9:21 PM

#

brisk brook If they don't get it right, they can't change it later

Yea, this is what I meant with backwards compatibility

fallen patrol Jul 27, 2021, 9:23 PM

#

anyways

#

https://github.com/python-discord/king-arthur/pull/4

GitHub

remove `tool` from `[tool.isort]` by onerandomusername · Pull Reque...

isort does not recognise [tool.isort] as a section for it in the tox.ini file.
It is only recognised as [tool.isort] in a pyproject.toml file, and [isort] in tox.ini
Isort docs: https://pycqa.githu...

#

:)

#

really really really learned this the wrong way!

#

as evidenced by the failing workflow :)

fallen patrol Jul 27, 2021, 10:33 PM

#

Yay I'm now a KA contributor too :)

patent pivot Jul 27, 2021, 10:34 PM

#

lul

fallen patrol Jul 27, 2021, 10:34 PM

#

Hm, will KA be added to #dev-log?

patent pivot Jul 27, 2021, 10:40 PM

#

uhhhhhhhh

#

yes

fallen patrol Jul 27, 2021, 11:25 PM

#

patent pivot yes

~~gross~~

patent pivot Jul 27, 2021, 11:25 PM

#

lol

#

winner

fallen patrol Jul 27, 2021, 11:26 PM

#

why 4 embeds smh

#

kinda tempted to add the status embed code flushball

patent pivot Jul 27, 2021, 11:31 PM

#

lol go for it

#

chris added it to k8s repo earlier today

sleek steppe Jul 28, 2021, 12:03 AM

#

returning a message when the annotation is None squint

balmy sparrow Jul 28, 2021, 5:10 AM

#

sleek steppe returning a message when the annotation is `None` <:squint:759935311769501696>

vocal wolf Jul 28, 2021, 5:57 AM

#

balmy sparrow

oh my god

green oriole Jul 28, 2021, 7:24 AM

#

I would like to ping this but we are in a public channel and gotta look like serious people pithink

thorny obsidian Jul 28, 2021, 11:11 AM

#

balmy sparrow

vale ibex Jul 28, 2021, 11:15 AM

#

Very professional

fallen patrol Jul 28, 2021, 11:26 AM

#

ablobflushed

viscid coral Jul 28, 2021, 12:58 PM

#

Why can't I send there messages noooo

toxic token Jul 28, 2021, 1:14 PM

#

https://github.com/python-discord/kubernetes/blob/main/postgresql/deployment.yaml why deployment not sts? CheemsSmuggle

green oriole Jul 28, 2021, 2:30 PM

#

toxic token https://github.com/python-discord/kubernetes/blob/main/postgresql/deployment.yam...

sts?

patent pivot Jul 28, 2021, 2:31 PM

#

toxic token https://github.com/python-discord/kubernetes/blob/main/postgresql/deployment.yam...

sts doesn't bring anything

toxic token Jul 28, 2021, 2:32 PM

#

aPES_Think

toxic token Jul 28, 2021, 2:32 PM

#

green oriole sts?

statefulset

patent pivot Jul 28, 2021, 2:32 PM

#

we don't run multi-node Postgres

#

we don't need any ordering

toxic token Jul 28, 2021, 2:32 PM

#

ah noobthink

#

ok CheemsSmuggle

patent pivot Jul 28, 2021, 2:33 PM

#

in future it's possible we'd look at multiple Postgres instances, but they'd be uniquely tied to the service they are responsible for

#

so still not a huge appeal for statefulsets

toxic token Jul 28, 2021, 2:34 PM

#

aPES_Think

patent pivot Jul 28, 2021, 2:34 PM

#

we do use statefulsets around and about, but really our two workforce units are just regular deployments and daemonsets

#

we use daemonset for ingress, log accumulation and a few other things

toxic token Jul 28, 2021, 2:35 PM

#

hmm

patent pivot Jul 28, 2021, 2:35 PM

#

sts does power our log accumulator primary but not by choice lol

#

helm install

gritty wind Jul 28, 2021, 2:35 PM

#

Ooh speaking of

#

Are the helm installs and config listed anywhere in the repo

#

If not, might be a fun thing to try and document

#

For my own installs, I just list the names, versions, and the settings that have to be changed 🤡

green oriole Jul 28, 2021, 2:38 PM

#

Right

green oriole Jul 28, 2021, 2:38 PM

#

patent pivot in future it's possible we'd look at multiple Postgres instances, but they'd be ...

When we will have two thousands concurrent connections I feel like that's a thing we will have to do haha

patent pivot Jul 28, 2021, 2:40 PM

#

gritty wind Are the helm installs and config listed anywhere in the repo

ones with custom config are yea

green oriole Jul 28, 2021, 2:40 PM

#

We could have full deployment steps, how to bring the infra to zero to what it is now, that'd be a fun thing to do

patent pivot Jul 28, 2021, 2:41 PM

#

gritty wind Are the helm installs and config listed anywhere in the repo

https://github.com/python-discord/kubernetes/tree/main/nginx
https://github.com/python-discord/kubernetes/tree/main/prestashop
https://github.com/python-discord/kubernetes/tree/main/cert-manager

#

the only one not there is loki

green oriole Jul 28, 2021, 2:43 PM

#

green oriole We could have full deployment steps, how to bring the infra to zero to what it i...

stuff like that

mellow hare Jul 28, 2021, 7:29 PM

#

Feeling dumb. Can someone remind me how to do the like... relative to you time stamp/humanized time?

patent pivot Jul 28, 2021, 7:30 PM

#

it's just unix timestamps with some format designators

#

one second

patent pivot Jul 28, 2021, 7:31 PM

#

mellow hare Feeling dumb. Can someone remind me how to do the like... relative to you time ...

https://canary.discord.com/developers/docs/reference#message-formatting-formats last item here

Discord Developer Portal

Discord Developer Portal — API Docs for Bots and Developers

Integrate your service with Discord — whether it's a bot or a game or whatever your wildest imagination can come up with.

mellow hare Jul 28, 2021, 7:31 PM

#

Cheers

patent pivot Jul 28, 2021, 7:31 PM

#

<t:1234:R> <t🔢R>

#

wow

mellow hare Jul 28, 2021, 7:31 PM

#

HA

patent pivot Jul 28, 2021, 7:31 PM

#

nice one discord

mellow hare Jul 28, 2021, 7:31 PM

#

That's amazing

patent pivot Jul 28, 2021, 7:31 PM

#

<t:12345:R> <t:12345:R>

#

there we go lol

mellow hare Jul 28, 2021, 7:31 PM

#

I appreciate it

vocal wolf Jul 28, 2021, 7:37 PM

#

Is there another error that we usually use for these situations, or am I going crazy?

https://github.com/python-discord/bot/blob/b2b9d23469960bcf9c8a0e17af7a6c0d51dda58a/bot/utils/helpers.py#L36-L44

stable mountainBOT Jul 28, 2021, 7:37 PM

#

bot/utils/helpers.py lines 36 to 44

def join_role_stats(role_ids: List[int], name: str, guild: Guild) -> Dict[str, int]:
    """Return a dict object with the number of `members` of each role given, and the `name` for this joined group."""
    members = []
    for role_id in role_ids:
        if (role := guild.get_role(role_id)) is None:
            raise BadArgument("Unable to fetch role data, the specified role does not exist.")
        else:
            members += role.members
    return {name: len(set(members))}```

vocal wolf Jul 28, 2021, 7:37 PM

#

(Looking at BadArgument)

brazen charm Jul 28, 2021, 7:45 PM

#

Not sure, but at least something like ValueError feels more fitting when it's not because of argument conversion from the discord side.

vocal wolf Jul 28, 2021, 7:46 PM

#

I agree, that does seem more fitting

green oriole Jul 28, 2021, 8:01 PM

#

BadArgument is handled by the error handler though, and will display a proper error message

#

Ah, I see the context

#

Yeah, okay, that error shouldn't be caught by the handler

vocal prairie Jul 29, 2021, 11:32 AM

#

For embeds such as !user I think we should use the timestamp style that displays the exact date and time rather than how long ago it was. The former is much more descriptive at first glance and you don't have to hover over it to get detail.

cold island Jul 29, 2021, 11:44 AM

#

We use it for moderation, and it's more convenient to get the relative time at a glance.

brisk brook Jul 29, 2021, 11:45 AM

#

What's wrong with didplaying both?

cold island Jul 29, 2021, 11:46 AM

#

Takes more space, and you already get the date by hovering over it.

#

I've been actually toying with the idea of splitting off the user command as used by the mods

brisk brook Jul 29, 2021, 11:50 AM

#

Could have the bot detect moderator and display it differently? Or create a subcommand that shows it differently..

Hmm...

cold island Jul 29, 2021, 11:50 AM

#

The command is already doing something else in mod channels

#

But I'm not sure if absolute time is preferred over relative time, maybe other people have a different opinion. Technically speaking, the relative stamp offers you more information than the absolute one.

brisk brook Jul 29, 2021, 12:20 PM

#

Well the thing is that eventually it becomes "X years", and at that point it's rather unhelpful when you want to be more precise.

molten perch Jul 29, 2021, 3:37 PM

#

Hey!
Just out of pure curiousity,
In that issue https://github.com/python-discord/api/issues/7
current database schema as the actual deployed one, or the literal python-discord/api schema? (that doesn't seem to exist just now.)
(I know it's already assigned, I just like to go over issues and find a solution, sometimes develop one on my own.)

GitHub

Alembic project setup · Issue #7 · python-discord/api

Set up the Alembic project for migrating the database, and create an initial migration to bootstrap the database based on the current API database schema.

cold island Jul 29, 2021, 3:39 PM

#

I believe it's the deployed one

#

I think this project leaves most of the API unchanged, it just decouples it from the site and rewrites it in FastAPI.

molten perch Jul 29, 2021, 4:09 PM

#

Yeah, but the deployed one uses the Django ORM whereas the API uses SQLAlchemy with Alembic. (That is strictly for sqlalchemy as far as I know)

cold island Jul 29, 2021, 5:24 PM

#

molten perch Yeah, but the deployed one uses the Django ORM whereas the API uses SQLAlchemy w...

Yes, that's what the project is about. The API as in the exposed routes and what they accept / return

vocal prairie Jul 29, 2021, 5:33 PM

#

brisk brook Well the thing is that eventually it becomes "X years", and at that point it's r...

That's what I was referring to, it's rather unclear with the relative time.

#

!server too

stable mountainBOT Jul 29, 2021, 5:33 PM

#

Server Information

Created: <t:1483877013:R>
Voice region: europe
Features: THREE_DAY_THREAD_ARCHIVE, PARTNERED, VIP_REGIONS, VANITY_URL, SEVEN_DAY_THREAD_ARCHIVE, NEWS, MEMBER_VERIFICATION_GATE_ENABLED, THREADS_ENABLED, WELCOME_SCREEN_ENABLED, RELAY_ENABLED, PREVIEW_ENABLED, PRIVATE_THREADS, BANNER, DISCOVERABLE, INVITE_SPLASH, COMMUNITY, ANIMATED_ICON
Roles: 88
Member status: status_online 51804 status_offline 181727

Members: 233531

Helpers: 122
Moderation Team: 33
Admins: 15
Owners: 3
Contributors: 39

Channels: 300

Category: 32
News: 8
Staff: 75
Stage_Voice: 1
Text: 176
Voice: 8

cold island Jul 29, 2021, 5:47 PM

#

tbh I'd rather show the manual relative time we had there before

brisk brook Jul 29, 2021, 5:51 PM

#

There may be a better format than R?

#

Where could I read all of them again?

#

<t:1483877013:t>---------------------<t:1483877013:T>----------<t:1483877013:d>----<t:1483877013:D>--<t:1483877013:f>--<t:1483877013:F>-<t:1483877013:R>
<t:1483877013:t> <t:1483877013:T> <t:1483877013:d> <t:1483877013:D> <t:1483877013:f> <t:1483877013:F> <t:1483877013:R>

last patio Jul 29, 2021, 5:55 PM

#

cold island I think this project leaves most of the API unchanged, it just decouples it from...

Yes, this is correct.

brisk brook Jul 29, 2021, 5:56 PM

#

I mean, I kind of liked: <t:1483877013:D> (<t:1483877013:R>) - <t:1483877013:D> (<t:1483877013:R>)

brazen charm Jul 29, 2021, 5:59 PM

#

I don't think that brings much benefit over the hover

brisk brook Jul 29, 2021, 6:02 PM

#

What's to loose? I think it's much nicer to view it like that, and it's not like it will cause that line to wrap or something similar.

fallen patrol Jul 29, 2021, 6:25 PM

#

brisk brook Could have the bot detect moderator and display it differently? Or create a subc...

yeah it already does that for a lot of things in the user embed

fallen patrol Jul 29, 2021, 6:26 PM

#

stable mountain

THREADS_ENABLED

molten perch Jul 29, 2021, 7:14 PM

#

cold island Yes, that's what the project is about. The API as in the exposed routes and what...

Alright, but SQLAlchemy (and Alembic) still needs the models to be defined, doesn't it? 😄

hardy gorge Jul 29, 2021, 7:15 PM

#

Yes, although there are reflection options to help with the generation of the models

cold island Jul 29, 2021, 7:18 PM

#

molten perch Alright, but SQLAlchemy (and Alembic) still needs the models to be defined, does...

Maybe I'm not understanding you. Yes, this is part of what needs to be done to move away from django.

molten perch Jul 29, 2021, 7:25 PM

#

Yeah, I see now. SQLAlchemy has this Automap functionality.(Alternatively, sqlacodegen that actually generates the models in respect of PEP8)

celest charm Jul 29, 2021, 11:22 PM

#

<#async-and-concurrency message>
Can we use this instead of the formatting hack in !int e?

#

!source int e

stable mountainBOT Jul 29, 2021, 11:22 PM

#

Command: internal eval

Run eval in a REPL-like format.

Source Code

Go to GitHub

brazen charm Jul 29, 2021, 11:23 PM

#

I think there was supposed to be something to replace the current implementation that would be less hacky, no idea on the status of it though

glacial veldt Jul 29, 2021, 11:25 PM

#

Y no PyCF_ALLOW_TOP_LEVEL_YIELD

#

Nobody likes Twisted :(

fallen patrol Jul 29, 2021, 11:48 PM

#

🥺

#

https://github.com/python-discord/.github/branches

granite plaza Jul 30, 2021, 2:00 AM

#

IS there anything in the code that makes sure everything in the database exists. EX: If a column is not there it creates it?

#

Ping me thx (probly wont respond till towmarro tho)

steel isle Jul 30, 2021, 7:42 AM

#

this might be preposterous, but what about tags for !github, !wsl, etc

#

or atleast an faq channel

#

!source docs

stable mountainBOT Jul 30, 2021, 7:44 AM

#

Command: docs

Look up documentation for Python symbols.

Source Code

Go to GitHub

steel isle Jul 30, 2021, 3:12 PM

#

I see I have killed chat

#

but I do think this is a valid suggestion

gritty wind Jul 30, 2021, 4:36 PM

#

I’m not sure what you have in mind

#

What would those tags contain?

gritty wind Jul 30, 2021, 4:38 PM

#

granite plaza IS there anything in the code that makes sure everything in the database exists....

This’ll depend entirely on which database you’re referring to, as we have quite a few. For our main ones though (the ones that power this server, the ones on the site) are managed by django. Django’s ORM creates them and manages migrations

#

Though that’s currently changing over to alembic I believe?

fallen patrol Jul 30, 2021, 5:11 PM

#

for anyone here who is having trouble with poetry, aside from amazing docs, they also have a discord server
https://discord.gg/GP9bXx2FcW

#

~~thanks joe for whitelisting it~~

last patio Jul 30, 2021, 6:15 PM

#

glacial veldt Nobody likes Twisted :(

twisted is stellar i love twisted

viscid coral Jul 31, 2021, 7:22 AM

#

stack_tag stack_eye

#

cool

cold island Jul 31, 2021, 4:55 PM

#

How can I open the website locally after launching site from docker?

brazen charm Jul 31, 2021, 4:56 PM

#

should be on localhost:8000

cold island Jul 31, 2021, 5:00 PM

#

Thanks

#

Hmm.. whenever I press I link it tries to open it through pythondiscord.local

#

Ok, I found the line that changes it. Am I supposed to provide an env file or something?

vale ibex Jul 31, 2021, 5:11 PM

#

recommended to change your hosts file

#

Are you on windows?

cold island Jul 31, 2021, 5:12 PM

#

yeah

vale ibex Jul 31, 2021, 5:12 PM

#

put ```
127.0.0.1 pythondiscord.local
127.0.0.1 api.pythondiscord.local
127.0.0.1 staff.pythondiscord.local
127.0.0.1 admin.pythondiscord.local

#

c:\Windows\System32\Drivers\etc\hosts

cold island Jul 31, 2021, 5:12 PM

#

tnx

viscid coral Jul 31, 2021, 6:04 PM

#

Can I ask questions about stuff the python bot do?

#

Like how did they do it

vale ibex Jul 31, 2021, 6:06 PM

#

Sure

viscid coral Jul 31, 2021, 6:07 PM

#

How does python take github link and show it's code?

vale ibex Jul 31, 2021, 6:09 PM

#

There's an on message listener in the issue cog

#

On mobile so can't get you a link to it right now

molten perch Jul 31, 2021, 6:10 PM

#

https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/evergreen/issues.py#L213
That's the current location.

stable mountainBOT Jul 31, 2021, 6:10 PM

#

bot/exts/evergreen/issues.py line 213

async def on_message(self, message: discord.Message) -> None:```

viscid coral Jul 31, 2021, 6:10 PM

#

!source issue

stable mountainBOT Jul 31, 2021, 6:10 PM

#

Bad argument

Unable to convert 'issue' to valid command, tag, or Cog.

viscid coral Jul 31, 2021, 6:10 PM

#

Oh ok thanks

molten perch Jul 31, 2021, 6:11 PM

#

But in the future it'll be probably moved to the GithubInfo Cog, and the issue command will be removed.

brazen charm Jul 31, 2021, 6:11 PM

#

wrong bot, the code content is done in https://github.com/python-discord/bot/blob/main/bot/exts/info/code_snippets.py

molten perch Jul 31, 2021, 6:12 PM

#

Oh, right lol. Nevermind it's a message listener too 😄

viscid coral Jul 31, 2021, 6:14 PM

#

Yeah I see it, thanks

cold island Jul 31, 2021, 8:12 PM

#

But I already have it thonking

#

When trying to do poetry install

tawdry vapor Jul 31, 2021, 8:14 PM

#

I had that issue for a long time..I had visual studio but it wouldn't detect msvc..one day I decided to try again to install build tools and that time it actually started detecting it

cold island Jul 31, 2021, 8:14 PM

#

Hmm odd, it worked before on this computer

vale ibex Jul 31, 2021, 8:19 PM

#

Is it on your path?

tawdry vapor Jul 31, 2021, 8:20 PM

#

I don't think that's how it detects it

#

Iirc it has its own environment variable

#

Don't know if python uses it

cold island Jul 31, 2021, 8:23 PM

#

Tried reinstalling, didn't help

cold island Jul 31, 2021, 8:57 PM

#

Anyway, I'm currently unable to create the env and run the pre-commit hook, so if someone can fix https://github.com/python-discord/site/pull/560 that'd be appreciated

green oriole Jul 31, 2021, 8:57 PM

#

get it again and blame poetry for its poor deps handling

#

I can probably do that

#

should I amend and force push?

cold island Jul 31, 2021, 8:58 PM

#

Either is fine I think

green oriole Jul 31, 2021, 8:58 PM

#

Will amend then

cold island Jul 31, 2021, 8:58 PM

#

tnx

green oriole Jul 31, 2021, 9:00 PM

#

now we have a fancy commit because Git wanted to sign it

viscid coral Jul 31, 2021, 10:06 PM

#

How did you do the GitHub updates?

gritty wind Jul 31, 2021, 10:06 PM

#

Hmm strange

#

I’m not sure why you’d need build tools

#

You reallly shouldn’t because the docker image is working

vale ibex Jul 31, 2021, 10:09 PM

#

viscid coral How did you do the `GitHub` updates?

which github updates?

#

the ones in #dev-log ?

viscid coral Jul 31, 2021, 10:10 PM

#

Likes this

vale ibex Jul 31, 2021, 10:10 PM

#

That's a webhook from GitHub, rather than in a bot

viscid coral Jul 31, 2021, 10:10 PM

#

webhook from GitHub?

#

I mean I know it's not a bot

vale ibex Jul 31, 2021, 10:10 PM

#

if you goto the settings of a github repo you have admin access to, there is a webhook section

#

you can then add a webhook there

#

https://gist.github.com/jagrosh/5b1761213e33fc5b54ec7f6379034a22

#

here's a guide I found

#

That's how most of the events come into #dev-log

#

However, the ones liek this #dev-log message

#

are custom github actions

#

https://github.com/python-discord/bot/blob/main/.github/workflows/status_embed.yaml

viscid coral Jul 31, 2021, 10:12 PM

#

vale ibex here's a guide I found

Oh thank you! Sorry for the wrong place I thought it was some @stable mountain bot feature

vale ibex Jul 31, 2021, 10:12 PM

#

No worries 🙂

fallen patrol Jul 31, 2021, 10:20 PM

#

green oriole get it again and blame poetry for its poor deps handling

hey, poetry actually has great dep management, much better than pip or pipenv

#

@patent pivot is pydis sponsored by honeycomb or do you have the base plan?

vale ibex Jul 31, 2021, 10:23 PM

#

We're on the free plan

#

it's pretty generous

fallen patrol Jul 31, 2021, 10:33 PM

#

well

#

that's just gonna be more effective imo

#

thanks

patent pivot Jul 31, 2021, 11:05 PM

#

this

#

hoeycomb free is generous

vocal wolf Jul 31, 2021, 11:55 PM

#

Thank you @sleek steppe for throwing that command into the sun so quickly lol

green oriole Aug 1, 2021, 6:02 AM

#

fallen patrol *hey, poetry actually has great dep management, much better than pip or pipenv*

Disagree sir, poetry does very weird stuff for its own deps. Like on a 3.8 install it tried to load python.3.9.so

fallen patrol Aug 1, 2021, 6:02 AM

#

wdym

fallen patrol Aug 1, 2021, 6:50 AM

#

@green oriole^

green oriole Aug 1, 2021, 6:51 AM

#

It is just very broken

#

It wrongly detects the Python version and does some stupid stuff

fallen patrol Aug 1, 2021, 6:52 AM

#

are you using pyenv with it?

fallen patrol Aug 1, 2021, 6:53 AM

#

green oriole Disagree sir, poetry does very weird stuff for its own deps. Like on a 3.8 insta...

poetry env use 3.8

marsh jewel Aug 1, 2021, 9:57 AM

#

i make website in Django i already host after..........I am facing big issues on Websurfer ISP.
I'm just buying Hosting Domain.
Everything is ok but I can’t open my website from Websurfer ISP
From my mobile network it can access like Ncell , NTC, World link and other network but can't access from
Websurfer ISP
Any Solution Please..

vocal prairie Aug 1, 2021, 9:58 AM

#

marsh jewel i make website in Django i already host after..........I am facing big issues on...

This channel is for discussion of Python Discord's projects, but you could ask in #tools-and-devops (sounds like a DevOps issue to me)

marsh jewel Aug 1, 2021, 10:00 AM

#

vocal prairie This channel is for discussion of Python Discord's projects, but you could ask i...

thank you for your suggestion

toxic token Aug 1, 2021, 1:01 PM

#

how do you handle prometheus huge data mhm

patent pivot Aug 1, 2021, 1:03 PM

#

toxic token how do you handle prometheus huge data <:mhm:835187413714075649>

wdym

#

how do we store all prom data?

toxic token Aug 1, 2021, 1:04 PM

#

prometheus scraps a lot of data which needs a big storage to store, and by looking at the manifests in the repo you have a 20GB volume noobthink

patent pivot Aug 1, 2021, 1:04 PM

#

20GB volume

#

yeah

#

we can provision volumes of any size

toxic token Aug 1, 2021, 1:04 PM

#

hmmGe

patent pivot Aug 1, 2021, 1:05 PM

#

yeah just checked

#

up to 10,000 GiB lol

#

we currently use uhhh

#

4.6G

toxic token Aug 1, 2021, 1:06 PM

#

hmm

#

how much has it been running? hmmGe

patent pivot Aug 1, 2021, 1:07 PM

#

this volue actually got reset a little bit ago since I changed how we deploy prometheus

#

9 days

#

we retain for 15 days

toxic token Aug 1, 2021, 1:09 PM

#

oh ok thx, i thought i was going something wrong, the volume got 75MB in less than a min mhm

patent pivot Aug 1, 2021, 1:10 PM

#

that sounds about right

#

part of that is just basic data dir stuff

toxic token Aug 1, 2021, 1:10 PM

#

yeye thanks for help

#

@patent pivot if you don't mind me asking, since when have you been into devops peep

patent pivot Aug 1, 2021, 1:12 PM

#

hmmmmmmmm

#

I started with Kubernetes about a year ago

#

June 26 2020 was when I moved personal stuff there

toxic token Aug 1, 2021, 1:13 PM

#

noice

patent pivot Aug 1, 2021, 1:13 PM

#

we created the pydis cluster on the 14th November 2020

toxic token Aug 1, 2021, 1:14 PM

#

the first time i tried kubernets was 2 months ago 😄

#

it is really nice how it works mhm

patent pivot Aug 1, 2021, 1:15 PM

#

we were finished with migration by the 21st it seems

#

last non-crit services migrated 29th though

toxic token Aug 1, 2021, 1:15 PM

#

aPES_Think

#

i am managing 2 clusters rn, one of them with average 7k requests/hour noobthink

#

are you the only one who manages the devops in pydis? smilecat

patent pivot Aug 1, 2021, 1:18 PM

#

pydis sees 10k/hr peak

toxic token Aug 1, 2021, 1:18 PM

#

noice

patent pivot Aug 1, 2021, 1:18 PM

#

there is a devops team, I'm the lead of that team

#

Akarys, Sebastiaan and Scragly are also on my team

toxic token Aug 1, 2021, 1:18 PM

#

nice

patent pivot Aug 1, 2021, 1:18 PM

#

and @radiant merlin

toxic token Aug 1, 2021, 1:19 PM

#

hahaha

#

toxic token Aug 1, 2021, 1:21 PM

#

patent pivot and <@!861747395632037890>

you have the king and i will make the princess diamondweapon

patent pivot Aug 1, 2021, 1:21 PM

#

wholesome

timid sentinel Aug 1, 2021, 5:00 PM

#

Any idea why i'm getting this error https://paste.pythondiscord.com/lifecohamu.py whenever I send a message (I think) running @stable mountain locally. I've heard other people say they were getting the same error but am not sure if the discussion went anywhere.

#

oh

#

I think i'm just missing the channel in the config

green oriole Aug 1, 2021, 7:09 PM

#

timid sentinel I think i'm just missing the channel in the config

Ya, you need to update using the config in notion

#

How is it going to work when you turn auto reviews back on?

#

Is it gonna drop every reviews it has been holding onto?

timid sentinel Aug 1, 2021, 7:11 PM

#

Nah, it doesn't post any older than a day already https://github.com/python-discord/bot/blob/e65afc4e83f822f06fa2d25a7eb8c233b1cce71a/bot/exts/recruitment/talentpool/_review.py#L73

stable mountainBOT Aug 1, 2021, 7:11 PM

#

bot/exts/recruitment/talentpool/_review.py line 73

# If it's over a day overdue, it's probably an old nomination and shouldn't be automatically reviewed.```

timid sentinel Aug 1, 2021, 7:12 PM

#

That was from when we first introduced the system to prevent review-spam, and I thought the easiest option was just to make use of that here

#

So old ones will need to be posted manually with !tp post_review or actually manually

green oriole Aug 1, 2021, 7:43 PM

#

Right

viscid coral Aug 1, 2021, 9:01 PM

#

I think I just made a bad comment on bot#1702

dusky shoreBOT Aug 1, 2021, 9:01 PM

#

GitHub

PROpen Add virtual environment (venv) tag

viscid coral Aug 1, 2021, 9:02 PM

#

What is venv anyway

gritty wind Aug 1, 2021, 10:37 PM

#

There are usually very few bad on-topic comments

#

Virtual environments, basically an isolated version of your “global” site packages (packages that you install through methods such as pip). Usually used so you can have things like different environments and packages for each project

fallen patrol Aug 2, 2021, 5:34 AM

#

<@&831776746206265384> above. they (@gritty wind) sent in every channel too

#

just realised now the second person was answering them, not spamming

gritty wind Aug 2, 2021, 5:49 AM

#

I did probably send in every channel at some point, but I think I have good excuses for most 🙃

fallen patrol Aug 2, 2021, 6:02 AM

#

i wonder if there's any channel you haven't sent a message in from what i can see

fallen patrol Aug 2, 2021, 6:03 AM

#

gritty wind I did probably send in every channel at some point, but I think I have good excu...

😔 i was hoping i would have caught you

gritty wind Aug 2, 2021, 6:09 AM

#

😄

sterile grotto Aug 2, 2021, 1:29 PM

#

hello

viscid coral Aug 2, 2021, 1:30 PM

#

Hi

sterile grotto Aug 2, 2021, 1:31 PM

#

hi

#

where do you from

static canyon Aug 2, 2021, 1:31 PM

#

Please use #python-discussion for general chatter. This channel is for contributing to one of our many open source projects @sterile grotto

brisk brook Aug 2, 2021, 3:24 PM

#

Is there any PR needing some review love (that may have been forgotten), I may have some more time to review anything today.

thorny obsidian Aug 2, 2021, 3:35 PM

#

@brisk brook persist in that most recent comment on the tag PR is referring to persisting the cooldowns across bot restarts, not persistent storage.

brisk brook Aug 2, 2021, 3:36 PM

#

Are those not the same thing?

#

If we want it to persist across restarts, then we need to store it persistently on disk (PostgreSQL)

thorny obsidian Aug 2, 2021, 3:39 PM

#

Redis will keep state even if the bot restarts, we just can't rely on it to have that data forever. So it will persist even if the bot restarts, but it's not permanent storage.

brisk brook Aug 2, 2021, 3:40 PM

#

In that regard, because of it being in another Docker container, yeah.

brazen charm Aug 2, 2021, 3:41 PM

#

It's also backed up to disk, I believe the redis instance used for the server is configured to do that on every write

thorny obsidian Aug 2, 2021, 3:42 PM

#

Yeah, our redis does write to disk. But it's still not permanent storage to us since we'll dump it when needed.

brazen charm Aug 2, 2021, 3:42 PM

#

But other than that I don't see any benefit over a normal python dict for the cooldowns like I mentioned in the comment

thorny obsidian Aug 2, 2021, 3:42 PM

#

Yeah, unless there's a strong benefit to using redis I don't see why we should try to use it everywhere

brisk brook Aug 2, 2021, 3:43 PM

#

Alright sounds good!

remote wigeon Aug 2, 2021, 8:40 PM

#

im saying this cause it was mentioned by staff sometime ago, but you have considered an automated slowmode for @stable mountain, is that right?
i would be willing/interested in contributing something like that, but i'd obviously wanna get approval for that to begin with

viscid coral Aug 2, 2021, 8:42 PM

#

You mean like after a spam of messages the bot will automatically set a slowmode delay?

thorny obsidian Aug 2, 2021, 8:42 PM

#

It would take some fine tuning in terms of what data would determine the slowmode. Also for me I would need to see a demonstrated need for it. I know we were roughly collecting data to look into what are the consistent factors that we could use to determine when slowmode is needed, but it's pretty low priority.

viscid coral Aug 2, 2021, 8:43 PM

#

Yeah but it can some in handy sometimes, it is pretty easy to make as well

thorny obsidian Aug 2, 2021, 8:44 PM

#

I think you're underestimating finding the right criteria to base the slowmode off of and also the maintenance cost. Right now it's very easy for us to adjust slowmode.

#

It's something we're interested in and have discussed previously, but it's very low priority for us

green oriole Aug 2, 2021, 8:54 PM

#

We do record the current slowmode of a few of our channels, so we should have some data to play with if we ever want to look at it

remote wigeon Aug 2, 2021, 9:00 PM

#

oh fair

tough imp Aug 2, 2021, 9:23 PM

#

Would the approach be something like analysing historical data to see what kind of traffic / msg throughput usually results in a slowmode bump in each specific channel, and the having the bot detect that threshold in a live situation?

#

Its an interesting problem

#

Probably lots of possible variables too like amount of active speakers, msg length, etc

remote wigeon Aug 2, 2021, 9:24 PM

#

i mean you could run a nn on the typing events and messages sent and their corresponding slowmodes

#

would be actually quite interesting

thorny obsidian Aug 2, 2021, 9:25 PM

#

mhm, there are a lot of factors at play like # of total messages, # of speakers, # of messages/speaker, message length, duration of the timeframe that we'd be looking at. Only recently have we even begun to receive typing events.

#

It would also have to play nicely with our existing antispam

cold island Aug 2, 2021, 9:26 PM

#

Honestly I doubt an nn is necessary here. Some regression model should do fine

remote wigeon Aug 2, 2021, 9:27 PM

#

true

tough imp Aug 2, 2021, 9:29 PM

#

an ML / statistical approach could be used to only analyse the historical data; find the relevant variables, perhaps the thresholds

#

for the sake of transparency & easy configuration the rule can then probably be enforced via more standard means

viscid coral Aug 2, 2021, 10:08 PM

#

I see a lot of caps issues in https://github.com/python-discord/sir-lancebot/blob/f5ca5dc712b63ca8a88dfa7a8717abbf96974a02/bot/resources/evergreen/py_topics.yaml , but Xithrius opened a PR about it, so I can't open a new one of my own to do so myself(to help), is there anything I can do?

tough imp Aug 2, 2021, 10:10 PM

#

Xith already opened a PR for the issue but some were missed?

#

if that's the case it's probably best to leave a comment on the PR and point out what you think should be changed

viscid coral Aug 2, 2021, 10:11 PM

#

wookie already did earlier

tough imp Aug 2, 2021, 10:11 PM

#

oh so you'd just like to help make the changes?

viscid coral Aug 2, 2021, 10:12 PM

#

Yeah but I have no permissions and there is not point opening a PR for the same purpose

tough imp Aug 2, 2021, 10:12 PM

#

you can leave a comment on the PR offering your help

#

the way you'd do it technically is make a PR targetting Xith's branch

#

it'd then be merged into Xith's branch and appear in the PR into master

#

however you probably shouldn't work on it without coordinating with Xith first

#

it may be unnecessarily complicated

viscid coral Aug 2, 2021, 10:13 PM

#

How should I contact him

tough imp Aug 2, 2021, 10:13 PM

#

comment on their PR or ping them here 😄

#

however if its just a capitalisation issue I'd leave it to them to resolve

#

unless it's a complex feature that requires coordinated work of multiple people, or the PR author cannot continue working on the issue, it is best to just give them time to make the changes

#

sometimes people just get busy and it may take a while

viscid coral Aug 2, 2021, 10:15 PM

#

Yeah ok

#

Thanks

hoary vessel Aug 3, 2021, 5:43 AM

#

How do the Sir Lancebot's creators host this bot?

#

I am just wondering on what should I do to make my bot online all the time!

vocal wolf Aug 3, 2021, 5:47 AM

#

hoary vessel How do the Sir Lancebot's creators host this bot?

We use linode

hoary vessel Aug 3, 2021, 5:47 AM

#

vocal wolf We use linode

And it is paid?

vocal wolf Aug 3, 2021, 5:47 AM

#

yes

hoary vessel Aug 3, 2021, 5:47 AM

#

vocal wolf yes

Oh-

hoary vessel Aug 3, 2021, 5:48 AM

#

vocal wolf yes

Do you know some free hosting?

vocal wolf Aug 3, 2021, 5:48 AM

#

hoary vessel Do you know some free hosting?

no good ones are free

#

afaik

hoary vessel Aug 3, 2021, 5:49 AM

#

vocal wolf no good ones are free

Yeah but currently I can't pay.

green oriole Aug 3, 2021, 6:21 AM

#

You can take a free tier on popular hosting platforms, but it won't get you really far

fallen patrol Aug 3, 2021, 8:00 AM

#

hoary vessel And it is paid?

~~i mean yes but also no~~
(they got sponsored)

viscid coral Aug 3, 2021, 10:08 AM

#

bot#1709 I was correct, it's discord.HTTPException?

dusky shoreBOT Aug 3, 2021, 10:08 AM

#

GitHub

PROpen Catch 404 error when waiting to delete message

viscid coral Aug 3, 2021, 10:12 AM

#

Xithrius, need help with the py_topics python(s) caps?

hoary vessel Aug 3, 2021, 2:37 PM

#

fallen patrol ~~i mean yes but also no~~ (they got sponsored)

Oh-

patent pivot Aug 3, 2021, 2:42 PM

#

repl.it, heroku and similar are fine for hobbyist development, not prod workloads though

viscid coral Aug 3, 2021, 2:44 PM

#

Does replit even allow hosting?

patent pivot Aug 3, 2021, 3:06 PM

#

It does have some functionality yeah

viscid coral Aug 3, 2021, 4:51 PM

#

Where is the code that sends the message when a user opens a channel?

timid sentinel Aug 3, 2021, 4:55 PM

#

viscid coral Where is the code that sends the message when a user opens a channel?

The DM you get? That is here https://github.com/python-discord/bot/blob/1e3d8fa4d8e6ba4bdabc96e31bb7c0c4ab82b1d5/bot/exts/help_channels/_message.py#L95

stable mountainBOT Aug 3, 2021, 4:55 PM

#

bot/exts/help_channels/_message.py line 95

async def dm_on_open(message: discord.Message) -> None:```

viscid coral Aug 3, 2021, 4:55 PM

#

I mean when the channel is opened

#

Not the dm, the process

gritty wind Aug 3, 2021, 4:57 PM

#

Can you give an example

timid sentinel Aug 3, 2021, 4:58 PM

#

Well there's an on_message listener, https://github.com/python-discord/bot/blob/1e3d8fa4d8e6ba4bdabc96e31bb7c0c4ab82b1d5/bot/exts/help_channels/_cog.py#L461, which in turn calls claim_channel, https://github.com/python-discord/bot/blob/1e3d8fa4d8e6ba4bdabc96e31bb7c0c4ab82b1d5/bot/exts/help_channels/_cog.py#L119. There's quite a lot going on there though, not exactly sure what you're looking for

viscid coral Aug 3, 2021, 4:58 PM

#

Yeah I got what I need, thanks

#

I just saw many people open help channels and the original message was deleted, probably by them

timid sentinel Aug 3, 2021, 5:02 PM

#

Yeah usually that's because the person who opened it deleted their message, it could also happen if it was deleted by antispam/a bot filter, but that's less likely

#

In those cases the channels should close faster

tawdry vapor Aug 3, 2021, 5:10 PM

#

Sentry has 380 issues of ConnectionRefusedError 😒

#

We have to look into a better way to catch ConnectionRefusedError, OSError, DiscordServerError, ClientConnectorError, and ServerDisconnected cause those just spam Sentry.

patent pivot Aug 3, 2021, 5:20 PM

#

a few of those may have been (inadvertedly) me

#

when we routed API traffic directly to Django from bot the server would sometimes randomly drop the connection

#

leading to ServerDisconnected

#

we now route internally through NGINX which seems to just... not do that

#

it could be worker restarts, unsure

tawdry vapor Aug 3, 2021, 5:28 PM

#

What do you think of telling sentry to just ignore those errors?

#

I guess we would have to filter that via Python since Sentry's website doesn't give us powerful filtering.

#

Granted, it is nice to know when there are network issues, but I'd rather we aggregate them into a single custom webhook than spam Sentry with new issues.

vale ibex Aug 3, 2021, 5:37 PM

#

there's some decent filtering we use at work in sentry, but it's a paid tier

#

not sure what tier we're on

tawdry vapor Aug 3, 2021, 5:39 PM

#

Yeah we don't have access to that

#

I think we need to intercept the logging before it gets to sentry sdk

#

Or maybe the sdk has a filter

vale ibex Aug 3, 2021, 5:41 PM

#

Yea, there's a before_send kwarg you can pass a filter func to when you init the sdk

#

you can make it return None to drop the event entirely

#

or you can make it do smarter things like add or strip data to the event

tawdry vapor Aug 3, 2021, 5:43 PM

#

A problem we have is that sometimes exceptions are caught and logged without the exception object, making it difficult to filter out.

#

The idea with that is that the traceback isn't useful for those exceptions, so it's omitted.

vale ibex Aug 3, 2021, 5:44 PM

#

the filter gets given the full event payload, along with the exception if there is one

tawdry vapor Aug 3, 2021, 5:44 PM

#

I think the stdlib logging lets us attach arbitrary data, so we could use that.

vale ibex Aug 3, 2021, 5:44 PM

#

so in theory we could filter on certain event types

tawdry vapor Aug 3, 2021, 5:44 PM

#

But if I do log.error then how will it get the exception?

vale ibex Aug 3, 2021, 5:45 PM

#

it won't in that case, it'll just get the data you see in sentry

tawdry vapor Aug 3, 2021, 5:45 PM

#

Well that's my point. It's difficult to filter those out.

vale ibex Aug 3, 2021, 5:46 PM

#

Yea, so would you propose filtering it lower down, in the logging module?

tawdry vapor Aug 3, 2021, 5:46 PM

#

No. I think we just need to modify those places to also include some data with the log message.

vale ibex Aug 3, 2021, 5:46 PM

#

The sentry filter would allow us to fiter specific ~~errors~~ exceptions we don't want to send, but as you say it won't give us everything we may want

tawdry vapor Aug 3, 2021, 5:47 PM

#

Ideally we could attach all the exception info but tell the logger not to output the traceback.

#

So we don't see it in stdout or log files

vale ibex Aug 3, 2021, 5:48 PM

#

Hmm yea

tawdry vapor Aug 3, 2021, 5:51 PM

#

I think it lets us attach any data so maybe we could do log.exception("blah", silent=True) and then have a custom log handler for stdout which doesn't send the traceback. (silent is a bad name but it's just for an example)

tawdry vapor Aug 3, 2021, 7:10 PM

#

@vale ibex Would it be safe to assume metabase will always return data in utf-8? There was an error where aiohttp incorrectly detected it as another codec and consequently failed to decode the data. https://sentry.io/organizations/python-discord/issues/2419912603/

#

Their API does not document the response encoding

#

I just made an issue for it bot#1713

dusky shoreBOT Aug 3, 2021, 7:15 PM

#

GitHub

IssueOpen Wrong encoding guessed for Metabase API responses

vale ibex Aug 3, 2021, 7:25 PM

#

huh I missed that one

#

I thought aiohttp automatically decodes the content from the server, so I guess something went wrong there

#

I think it was some odd unicode char in a user's name that caused it

#

utf-8 could be safe to assume

#

I might give that one a go now, since I can test it with my creds

#

🌕ℳℴℴ퓷퓲ℯ🌕 this caused the issue

#

!charinfo 🌕ℳℴℴ퓷퓲ℯ🌕

stable mountainBOT Aug 3, 2021, 7:27 PM

#

Character Info

\u0060 : GRAVE ACCENT - `
\U0001f315: FULL MOON SYMBOL - 🌕
\u2133 : SCRIPT CAPITAL M - ℳ
\u2134 : SCRIPT SMALL O - ℴ
\u2134 : SCRIPT SMALL O - ℴ
\ud4f7 : HANGUL SYLLABLE PYULH - 퓷
\ud4f2 : HANGUL SYLLABLE PYULM - 퓲
\u212f : SCRIPT SMALL E - ℯ
\U0001f315: FULL MOON SYMBOL - 🌕
\u0060 : GRAVE ACCENT - `

Full Raw Text

\u0060\U0001f315\u2133\u2134\u2134\ud4f7\ud4f2\u212f\U0001f315\u0060

tawdry vapor Aug 3, 2021, 7:30 PM

#

Yeah it detected the wrong encoding

#

chardet isn't 100% accurate

#

It detected it as Windows-1254

vale ibex Aug 3, 2021, 7:34 PM

#

ah, makes sense

#

forcing utf-8 seems to have done the job

#

#476196003733569547 message

#

I'll commit and pr now

tawdry vapor Aug 3, 2021, 7:37 PM

#

Thanks

vocal wolf Aug 3, 2021, 9:33 PM

#

@vale ibex https://github.com/python-discord/sir-lancebot/pull/796

vale ibex Aug 3, 2021, 9:35 PM

#

joe_salute

patent pivot Aug 3, 2021, 9:36 PM

#

joe_salute

vocal wolf Aug 3, 2021, 9:36 PM

#

joe_salute

#

@patent pivot review pls thanks joe_salute

#

Thank you joe

vale ibex Aug 3, 2021, 9:38 PM

#

Lol I was really expecting you to leave it at a comment

vocal wolf Aug 3, 2021, 9:38 PM

#

I was too

#

"did I just troll myself or did joe troll me?"

patent pivot Aug 3, 2021, 9:39 PM

#

command+enter did me dirty

vocal wolf Aug 3, 2021, 9:39 PM

#

lol

#

ok

#

now it should work

#

.so Python doesn't recognize newly imported package

dusky shoreBOT Aug 3, 2021, 9:40 PM

#

Search results - Stackoverflow

Here are the top 3 results:

numpy.f2py - extension doesn't exist when source distribution is installed with pip

reddit_upvote 1 stack_eye 34 reddit_comments 0 stack_tag python, python-3.x, numpy

Recognizing cx_Oracle install within PyDev

reddit_upvote 8 stack_eye 2610 reddit_comments 1 stack_tag python, windows, anaconda

Why does Python (with twill) not want to log me in to a Yahoo mail box here?

reddit_upvote 2 stack_eye 1487 reddit_comments 1 stack_tag python, login, twill

patent pivot Aug 3, 2021, 9:41 PM

#

hell yeah

vale ibex Aug 3, 2021, 9:45 PM

#

.so Discord emoji not working when I don't give id

dusky shoreBOT Aug 3, 2021, 9:45 PM

#

No search results found for Discord emoji not working when I don't give id

vale ibex Aug 3, 2021, 9:45 PM

#

sadge

patent pivot Aug 3, 2021, 9:45 PM

#

.so quit vim

dusky shoreBOT Aug 3, 2021, 9:45 PM

#

Search results - Stackoverflow

Here are the top 5 results:

Why argument like q not mentioned in vim manual?

reddit_upvote 0 stack_eye 51 reddit_comments 3 stack_tag linux, vim

How to remap ESC key to CAPS LOCK in VsVIM in Visual studio

reddit_upvote 0 stack_eye 13 reddit_comments 1 stack_tag visual-studio, vsvim

How do I exit the Vim editor?

reddit_upvote 4356 stack_eye 2400330 reddit_comments 11 stack_tag vim, vi

TMUX: how to make new window stay when start shell-command quits?

reddit_upvote 7 stack_eye 9862 reddit_comments 5 stack_tag shell, tmux

Is it possible to prevent vim from quitting from the status of QuitPre autocommand? (e.g. prevent close on syntax issues)

reddit_upvote 0 stack_eye 21 reddit_comments 1 stack_tag vim

patent pivot Aug 3, 2021, 9:46 PM

#

lmfao

vale ibex Aug 3, 2021, 9:46 PM

#

.so why is ed the best editor

dusky shoreBOT Aug 3, 2021, 9:46 PM

#

Search results - Stackoverflow

Here are the top 4 results:

how to loop and get articles nested array key and value PHP

reddit_upvote -2 stack_eye 38 reddit_comments 1 stack_tag php, json, foreach

Detecting sections of a pdf with pdfminer

reddit_upvote 4 stack_eye 5449 reddit_comments 1 stack_tag python, pdf, nlp

GameObject Prefabs floating away

reddit_upvote 0 stack_eye 1169 reddit_comments 1 stack_tag unity3d

Join columns from multiple tables

reddit_upvote 4 stack_eye 318 reddit_comments 1 stack_tag mysql, database, join

vale ibex Aug 3, 2021, 9:46 PM

#

PHP first result

patent pivot Aug 3, 2021, 9:46 PM

#

true true

vale ibex Aug 3, 2021, 9:46 PM

#

oof

tawdry vapor Aug 3, 2021, 10:02 PM

#

This is fucked on mobile

timid sentinel Aug 3, 2021, 10:03 PM

#

Yeah, should probably just be the titles that are the the links tbh

gritty wind Aug 3, 2021, 10:17 PM

#

The upvotes, views, and comments all fit on one row for me (iPhone 8)

#

It could probably be cleaned up a bit by removing the tags, or pushing them to a new line

#

And yes 100% clean up the links haha

brisk brook Aug 3, 2021, 10:19 PM

#

For me, my phone detects it as a phone number. Like sometimes happens with the Reddit page thing

#

gritty wind Aug 3, 2021, 10:20 PM

#

Hmm those just seem like the emoji IDs

brisk brook Aug 3, 2021, 10:20 PM

#

#

Yup

vocal wolf Aug 3, 2021, 10:21 PM

#

oh god

gritty wind Aug 3, 2021, 10:21 PM

#

I’ve seen people post that before, but I’m not sure there’s anything we can do there

#

I guess other than not use emojis

brisk brook Aug 3, 2021, 10:21 PM

#

Time to call reddit_post_text

green oriole Aug 4, 2021, 6:25 AM

#

I wonder if putting the markdown in a different order or adding spaces would fix it

viscid coral Aug 4, 2021, 7:11 AM

#

While making the source command, and the bot doesn't find the source, it sends two messages. Why not make button for each response to delete it?

vale ibex Aug 4, 2021, 8:01 AM

#

!src not-a-cog

stable mountainBOT Aug 4, 2021, 8:01 AM

#

Bad argument

Unable to convert 'not-a-cog' to valid command, tag, or Cog.

#

Command Help

!source [source_item]
Can also use: src

Display information and a GitHub link to the source code of a command, tag, or cog.

vale ibex Aug 4, 2021, 8:02 AM

#

I think this is similar behaviour to a lot of places where we raise a userinputerror

#

we send the error embed, then the help for that command

#

I think having the error embed delete_after a few seconds would be fine

molten perch Aug 4, 2021, 8:59 AM

#

I thought the handle for UserInputError puts the error and the help content into the same embed.
Like.

viscid coral Aug 4, 2021, 10:48 AM

#

If I have a suggestion about the help-channels, should I open an issue ir PR.

static canyon Aug 4, 2021, 10:48 AM

#

viscid coral If I have a suggestion about the help-channels, should I open an issue ir PR.

Issue

#

PR is the coded solution

#

Issue is the proposal

viscid coral Aug 4, 2021, 11:03 AM

#

Ok

vale ibex Aug 4, 2021, 11:05 AM

#

molten perch I thought the handle for UserInputError puts the error and the help content int...

Yea, that looks like it may be a disparity between the two bots

#

We're working on something at the moment that may solve this long term, but for now I'd suggest you raise an issue if you want to solve it

viscid coral Aug 4, 2021, 11:21 AM

#

Anyone care to review bot#1717

dusky shoreBOT Aug 4, 2021, 11:21 AM

#

GitHub

IssueOpen Send message when help channel closed.

molten perch Aug 4, 2021, 11:29 AM

#

vale ibex We're working on something at the moment that may solve this long term, but for ...

Like, putting sir lancebot’s UserinputError handle into bot ?

vale ibex Aug 4, 2021, 11:33 AM

#

bot already has a handler for it, it would be a proposal to change that handler to only output 1 embed

molten perch Aug 4, 2021, 11:39 AM

#

Yes, that’s what I meant. Sir Lancebot already has a proper handler.

#

Shall I open an issue? If I may.

viscid coral Aug 4, 2021, 11:44 AM

#

viscid coral Anyone care to review bot#1717

? And maybe I can try to code it myself but I don't know where the source code is, and I know nothing about discord.py

vale ibex Aug 4, 2021, 11:47 AM

#

molten perch Shall I open an issue? If I may.

Yup, always feel free to open an issue

vale ibex Aug 4, 2021, 11:49 AM

#

viscid coral ? And maybe I can try to code it myself but I don't know where the source code i...

it can take a day or more for a core dev to take a look at new issues, especially during the week, as we're all volunteers and look in our free time

viscid coral Aug 4, 2021, 11:49 AM

#

Yeah ok

#

Thanks

tulip marsh Aug 4, 2021, 12:27 PM

#

Do you guys think it would be beneficial to close help channels after a period of time if their pinned message is deleted and there's no longer any activity? Because there have been several occurrences of people thinking the help channels are bugged as they see it's occupied but there's no messages there

#

Although, the more I think about it the less beneficial it seems

thorny obsidian Aug 4, 2021, 12:30 PM

#

If the first message is deleted and there have been no other messages it'll close in 5 minutes usually. Otherwise it'll be 10 minutes after the last non-op response and 30 after the last op response.

vale ibex Aug 4, 2021, 12:31 PM

#

Yea, I think Jack's proposal is to close after 5 minutes even if there are messages from non-claimants

timid sentinel Aug 4, 2021, 2:03 PM

#

If nobody is working on https://github.com/python-discord/sir-lancebot/pull/558, could I take it over? And if I were to take it over, should I just finish it off, or would it be ok if I rewrote it to implement some improvements (namely, including a markov chain implementation, since that's cooler than using a module that does it for you, and also generating the markov chain backwards so you can start with the rhymes, meaning it can run in a fixed amount of time so you don't have to implement timeouts and stuff in case it doesn't finish in time).

cold island Aug 4, 2021, 2:06 PM

#

I'd check whether the author has any plans of finishing it

#dev-contrib

in command