!pypi taskipy
#dev-contrib
sleek steppe
stable mountainBOT
gritty wind
It’s not a feature in poetry, it is in pipenv
fallen patrol
Ah
gritty wind
The second one there shouldn’t use a task though
We don’t have a task called pre-commit
gritty wind
Or just pre-commit without the task if you want to run pre-commit
fallen patrol
Yeah
fallen patrol
@vale ibex one of the workflows failed on @dusky shore after your commits were pushed 👀
specifically, build
vale ibex
<@!126811506632294400> one of the workflows failed on <@!528937022996611082> aft...
worked now 👍
vocal wolf
https://github.com/python-discord/bot/pull/1487 needs review
tawdry vapor
Are you waiting for another review before addressing mine?
vocal wolf
Are you waiting for another review before addressing mine?
Yes.
Making sure what needs to work, works, before taking more time to see if refactoring should be done.
short snow
Repository labels need changes according the python versions
Bot still has python37 label, and Lance has python38
Also, https://github.com/python-discord/bot/pull/1446 needs a review
exotic ember
have you addressed kwzrd's latest review in that PR?
short snow
have you addressed kwzrd's latest review in that PR?
There a few questions I had with it, they told me they were gonna reply to it last week, probably got busy.
I have commented on the changes
exotic ember
i don't see any "required changes" added in the PR after this review
the review comment directly after that which you marked as resolved is also not seen in the PR
short snow
One second, lemme see
Aha, that last comment, I had mentioned it locally, forgot to unresolve it when you told me to only resolve on pushes
I haven’t pushed since i was waiting to push all changes together
exotic ember
when you told me to only resolve on pushes
I don't remember saying that
I haven’t pushed since i was waiting to push all changes together
that's not really a good idea, since kwzrd wouldn't know that you've addressed his review comments then
short snow
Yup 👍
vocal wolf
@brazen charm would you mind if I took bot#943, or would you like to do it?
dusky shoreBOT
brazen charm
<@!184351770636582913> would you mind if I took bot#943, or would you like to do...
You can take it
vocal wolf
You can take it
Thank you.
dusky shoreBOT
clever wraith
xith the changes you've asked for on sir-lancebot#758 are done. please review when time suits you.
dusky shoreBOT
short snow
Dawn had done a PR to add a few more superstarify names, https://github.com/python-discord/bot/issues/662 this could probably be closed then.
I don’t think this is needed any more, https://github.com/python-discord/bot/issues/716 the guide pretty much sums it up.
Guide here points to, https://github.com/python-discord/bot/tree/main/tests
mint tartan
what do you guys use for python bot eval
brazen charm
https://github.com/python-discord/snekbox , it runs the python process in a sandboxed environment
keen valley
What does it mean?
log = logging.getLogger(__name__)
__name__ is a built in for the current file’s name
keen valley
So where we can see the logs ? In which file
keen valley
@dusky shore
gritty wind
I don’t think that writes to a file
stable mountainBOT
bot/bot.py line 14
log = logging.getLogger(__name__)```That part has nothing to do with the output stream besides formatting
Line 49 of the init defines the handlers
It outputs to bot/log/hackbot it seems
keen valley
That part has nothing to do with the output stream besides formatting
Is that compulsory to create logs?
gritty wind
I don’t understand your question
tough imp
it's giving the log instance a name, in this case it's being set to the name of the module
so in the log output you can see which module is writing which logs
it looks like the logs should show up in bot/logs/hackbot.log
stable mountainBOT
bot/__init__.py line 46
log_file = log_dir / "hackbot.log"```Ya, I got it, it will going to create file
tough imp
ye, so the log format is being set here: https://github.com/python-discord/sir-lancebot/blob/4970d9642f2a3eed8a3db5e1c438ee8cd4be72d9/bot/__init__.py#L73-L74
stable mountainBOT
bot/__init__.py lines 73 to 74
logging.basicConfig(
format="%(asctime)s - %(name)s %(levelname)s: %(message)s",```name is the logger's name
which is being set by this in each module:
log = logging.getLogger(__name__)
so each module has its own logger instance with its name set to the module's name, and as a result, each line in the output will contain the name of the module that made the log
keen valley
Okay, Thank you
fallen patrol
https://github.com/python-discord/sir-lancebot/blob/4970d9642f2a3eed8a3db5e1c438...
What does that /do?
sleek steppe
What does that /do?
Path("/foo") / "bar" = Path("/foo/bar")
fervent sage
<@!297045071457681409> oi you available?
i uh....
nocturnal 
tough imp
What does that /do?
ye as Toxic demonstrates above, pathlib joins path components with the division operator
or rather lets you join them with it, its not the only way to do it
I let myself hold the opinion that it's unnecessary, ugly, unexpected, and borderline operator abuse
fallen patrol
ye as Toxic demonstrates above, pathlib joins path components with the division ...
That's horrible and I completely forgot about division which is why I was forgetting here
fervent sage
I let myself hold the opinion that it's unnecessary, ugly, unexpected, and borde...
agreed
placid ermine
same
fervent sage
im pretty sure when laundmo first showed me it i was like "what the fuck? thats horrible...!"
fallen patrol
im pretty sure when laundmo first showed me it i was like "what the fuck? thats ...
It's both cool and horrible abuse of the system
Cool because it shows you can change that behavior
placid ermine
it came up in pygen too, today
fallen patrol
Horrible because it's horrible, bad, and operator abuse
But it does show something I wouldn't have realized otherwise
vale ibex
Is anyone against me turning off auto-restart of lance and bot?
I'm getting frustrated whenever I start up docker desktop that I need to stop both of those before I can use postgres/redis in another container
since we use the same ports for each across the board
brazen charm
What was the initial reason for setting it to always? unless-stopped or on-failure seem more fitting depending on what it was
You can override it in a docker-compose.override.yml file in the meantime
vale ibex
Ah, yea that's a good point, I'll do that for now
Yea, one of those other two seem better
It's currently always
fallen patrol
Is anyone against me turning off auto-restart of lance and bot?
Yea, probably. Since if it crashes it restarts automatically
whole forge
original reason was so that it restarts if api/db arent reachable but thats long since solved way better
i have nothing against it
vocal prairie
Is anyone against me turning off auto-restart of lance and bot?
I get annoyed by auto-restart, so I'm definitely not against it
fallen patrol
original reason was so that it restarts if api/db arent reachable but thats long...
i've seen joe use an sys.exit() to restart the bot lol
vale ibex
yea docker-compose is only for dev, k8s is what's used in prod
I'll push PRs in a bit now then
I'm thinking unless-stopped is best here
whole forge
schould be a 1 line change
fallen patrol
production uses different set of preferences entirely
oh, how?
does it not run in docker on kubers?
patent pivot
not with docker compose, no
fallen patrol
hm
fallen patrol
not with docker compose, no
okay
fallen patrol
ah
patent pivot
fallen patrol
inb4 pythondiscord/mainifests
patent pivot
fallen patrol
ah
lol
that's the official installer lmao
ah
use
curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/install-poetry.py | python -
install-poetry.py not get-poetry.py
lovely lol
1.2 is breaking
vale ibex
got bot#1625 and sir-lancebot#770 up for the changes to docker-compose
vocal wolf
i uh....
nocturnal <:Pepesmile:775826770065883157>
How about now?
@vale ibex both PRs you made can be merged now.
fervent sage
oh lmao i thought i finished the review on it
i just left the tab open without clicking the submit button
vocal wolf
lol
@fervent sage ty for review
I've never gotten unit tests to work this fast, I think I'm finally understanding them
fervent sage
<@!297045071457681409> ty for review
there anything else that needs reviewing (preferably on lancebot because it doesnt require site to be up lol)?
vocal wolf
there anything else that needs reviewing (preferably on lancebot because it does...
Take this for now: https://github.com/python-discord/sir-lancebot/pull/756
fervent sage
that was a very relaxing non-code review, very nice
dry folio
that was a very relaxing non-code review, very nice
lol, compared to last time take this as a relaxation therapy
fervent sage
yeah lol, when i only need to review (mostly) non-code stuff i dont have to checkout the branch (or worse, fork) and i can just run through and look at stuff
that being said I have a grudge against the current quiz system that will need a code change
dry folio
yeah lol, when i only need to review (mostly) non-code stuff i dont have to chec...
website code updated, i'll fire up pycharm and get started now :D
fervent sage
why are question answers in the format "answer1, answer2" not ["answer1", "answer2"]
dry folio
why are question answers in the format `"answer1, answer2"` not `["answer1", "an...
ah... long story
basically it was easier to manipulate in the code using strings instead of json lists
fervent sage
json is nice because it does have structures like lists lol
dry folio
json is nice because it does have structures like lists lol
true. when our cat devs was in phase one - gathering up quiz entries for "math" and "science", we first went for "ans1, ans2", then changed to list, then changed back
fervent sage
what if i want to use a , in an answer though?
dry folio
what if i want to use a `,` in an answer though?
the forbidden question, one which i have so long avoided, has been asked
simple: just don't add those answers-
fervent sage
thats not a good answer lol
dry folio
when i made the linear system of equations dynamic question, i changed the format to a & b instead of a, b
fervent sage
if the workaround to a problem that shouldnt exist is "dont do it" thats bad lol
dry folio
so just avoid it
dry folio
@fervent sage all your changes have been implemented, mind doing review time ™️ #2?
trivia_quiz.json is typing...
fervent sage
eh the trivia quiz is static questions which should be editable by pr
so json is good (that being said, i wouldnt mind yaml 
)
dry folio
so json is good (that being said, i wouldnt mind yaml <:kek:585617800257863727>)
ah okay
@fervent sage i deleted the word "public", it seems as if when i deleted it the first time it didn't save or something
dry folio
@sleek steppe all your changes have been implemented :D
fervent sage
@patent pivot this is like one of the randomest things ive suggested so far lol, but what're the chances we (pydis) can have some sort of "Learn to API" type repo that people can just add cool features to as requested, kinda like lancebot but fastapi
This is 100% not at all related to the benedict cumberbatch discussion 
patent pivot
hmmm, an interesting idea
probably one to raise as an org ticket, and one that I can also raise with core devs
fervent sage
time to put on my spec writing hat
patent pivot
I think it's a bit out of scope, and without a clear direction for an API could potentially be more harmful than educational, but I'd be open to a discussion on it
fallen patrol
<@!165023948638126080> this is like one of the randomest things ive suggested so...
starlette > fastapi
fervent sage
opinion
fallen patrol
fastapi abstracts too much away imo
fervent sage
not if youre making it so there's a really low bar to entry
fallen patrol
ig..
gritty wind
CI is currently running the branch for pytest-xdist
Hoping to see some nice performance improvements
Oooh it's done
Coverage broke, but it's down to 50 seconds from 90 which is pretty nice
Ah right, that makes sense
I didn't include the test directory in the new coverage
It didn't make much sense for it to be included in the first place
You aren't testing your tests
fallen patrol
I didn't include the test directory in the new coverage
Should be ignored then
brazen charm
Why not? You should make sure that every test runs, and there are helpers under the tests dir which are tested
short snow
the first .rcaps r
short snow
yeah ik that, i am talking about This year 2021 is not yeat supported
clever wraith
oh aight!
exotic ember
the first `.rcaps r`
I can't reproduce it
short snow
yeah even I can't dunno how that popped up
short snow
do i need to have redis locally?
did a system reinstall due to some problems so had to make the setup again
short snow
@exotic ember regarding #dev-log message, should make a dynamic question object or should I make those class constants file constants but they don't get used anywhere else
another option would be to add () in each call
Also regarding your main comment, i think that should be mentioned in a separate PR, it isn't really related to what I am working on
exotic ember
<@!475186523575287808> regarding https://discord.com/channels/267624335836053506...
in that case I think classmethods are best suited
exotic ember
Also regarding your main comment, i think that should be mentioned in a separate...
I don't feel like the fixes for these should go in this PR, so just keep in mind the above quirks for this game so the bot still works for this topic until the fix is made. A separate issue should be created after this PR.
short snow
ah didn't reach that part yet. SHould I open a issue for it? I don't think I would be able to mention it anytime soon, got units coming and already have few issues assigned
exotic ember
I'll open that issue, no worries
short snow
alright 🙂
clever wraith
in ttt, there is a usecase that when before all emojis are loaded, if we kinda click on any emoji, it does not play that move.
exotic ember
in practice, that isn't too much of a problem, simply removing and readding the reaction will work
trying to handle that scenario brings up some pain points to me, like what if after emojis load there are multiple reactions added by the user
clever wraith
makes sense
also i have a linting question
in js, eslint is good enough to enforce us to use const if we don't manipulate variable, while altho its not a headache, can some linting be done in terms of lists to enforce to convert them as tuples(if they are constant)?
exotic ember
I don't think that's currently possible
clever wraith
oh i see, so do we define the rules or we use some standards? i think we use pep8 right?
exotic ember
we enforce certain linters in our projects, I just don't think any of them check for unchanged mutable variables
clever wraith
oh i see. alright thanks.
short snow
kosa question about no infinte loops of fetch, earlier i did such that it will run until it has 10 questions and error responses are below 3, should i do the same?
exotic ember
what happens if error responses reach 3?
short snow
it would unload the cog and do a error log
exotic ember
why not disable the wikipedia topic and allow others?
short snow
sounds better, will do that
sharp zephyr
i found something that i see is going to be really great integrated into the discord . i dont want to tell anybody about it until i've looked further into how the python bots operate . id be upset if someone else got into integrating it before i could get into it . i see it is a large addition and is going to work to solve a problem for the community 🙂
patent pivot
if you open an issue we can reserve implementation for you
when you open an issue you can optionally select to add it yourself and then it's yours until you do it
sharp zephyr
i will create an issue thread when i have become more familiar with the bots' code and post a screenshot of this pair of messages in the issue.
vale ibex
hey @clever wraith just in case you didn't notice sir-lancebot#760 failed linting
dusky shoreBOT
vale ibex
I'll give it another look once it's passed
vale ibex
Cool, I'll take a look after work
clever wraith
kay, thanks
fallen patrol
the first `.rcaps r`
The year 2021 is not yet supported.
twilit juniper
This else is updating the message_caches on every message... for every channel on the guild... Is this the wanted behaviour?
Personally I would have expected that type of functionality to be on the bot, not within the cog specifically for help channels.
https://github.com/python-discord/bot/blob/main/bot/exts/help_channels/_cog.py#L466-L470
stable mountainBOT
bot/exts/help_channels/_cog.py lines 466 to 470
if channel_utils.is_in_category(message.channel, constants.Categories.help_available):
if not _channel.is_excluded_channel(message.channel):
await self.claim_channel(message)
else:
await _message.update_message_caches(message)```update_message_caches() has a check that the message is from an in-use help channel
fervent sage
it only actually updates ^ https://github.com/python-discord/bot/blob/main/bot/exts/help_channels/_message.py#L51
stable mountainBOT
bot/exts/help_channels/_message.py line 51
if is_in_category(channel, constants.Categories.help_in_use):```ahh ok
vale ibex
IG that could be moved for clarity
twilit juniper
We could if we wanted to
spare plaza
well if the redist is global, might as well be on the bot instance. right?
twilit juniper
^
spare plaza
as that represents the whole instance
vale ibex
IE ```py
if channel_utils.is_in_category(message.channel, constants.Categories.help_available):
if not _channel.is_excluded_channel(message.channel):
await self.claim_channel(message)
elif channel_utils.is_in_category(message.channel, constants.Categories.help_in_use):
await _message.update_message_caches(message)
and then we can remove the check in the func
spare plaza
vale ibex
well if the redist is global, might as well be on the bot instance. right?
wdym? This is on the bot right?
twilit juniper
Yeah, should someone make an issue for that?
vale ibex
Yeah, should someone make an issue for that?
Yea, I'd be hesitant to just make this change, since there might be a reason for it to be this way
IE another piece of code calling that func or something
spare plaza
wdym? This is on the bot right?
its in the help_channels cog. pretty sure you can have event listeners on the Bot class itself.
If it only needs to cache message channel message. then it makes sense, I just assumed from the name it was all channels
vale ibex
its in the help_channels cog. pretty sure you can have event listeners on the Bo...
Yea you can, but I'm not sure why having a message listener that is only used for the help channel system makes more sense outside of the help system cog
spare plaza
mhm, it was a misunderstanding from the name. I thought it was all message caches
vale ibex
Nah, the caches used are specifically the help system ones
vale ibex
I am just to lazy to look for it
Just checked, there isn't 😛
fervent sage
IE another piece of code calling that func or something
➜ bot git:(main) grep -r "update_message_caches" .
./bot/exts/help_channels/_cog.py: await _message.update_message_caches(message)
./bot/exts/help_channels/_message.py:async def update_message_caches(message: discord.Message) -> None:
damnit why do you have to be faster
twilit juniper
Oh lol
fervent sage
lol
vale ibex
It's because I used ripgrep
fervent sage
i should just keep a terminal open for all popular pydis projects ready to grep as needed
vale ibex
Lol Griff abusing mod power
vale ibex
He must be dealt with
twilit juniper
This is why you don't drive
last patio
hello, i'd like to work on https://github.com/python-discord/site/issues/391, is there anything blocking it or preventing me from taking over it?
gritty wind
Doesn't seem like it
It may have been blocked at some point due to dewiki or something, but I don't realistically see a blocker now
last patio
excellent
patent pivot
hello, i'd like to work on https://github.com/python-discord/site/issues/391, is...
👍. It's sort of an issue that will solve itself since when we split out API and use https://github.com/python-discord/logcord then the subdomains will go, but I see no problem making that shift now.
last patio
the other django apps in site will still need subdomain change though, no?
last patio
ah, i missed that staff already has an url
twilit juniper
<@!670802831678373908> oi m8 your build failed for linting.
Yeah, I fixed it
unless it failed again
sleek steppe
it did
twilit juniper
fml
vocal wolf
it is currently failing, at this very moment
sleek steppe
or you can do poetry run task precommit which won't let you commit unless lint passes
vocal wolf
You can do both
sleek steppe
true
twilit juniper
sorry about that.
vocal wolf
np
fallen patrol
You can do both
If you messed up the one, you have to do both
vale ibex
no worries 😄
My only suggestion would be setting up the pre-commit hook locally
will save a lot of effort 😄
vocal wolf
@twilit juniper If you have build failing locally, you can git commit --amend --no-edit. Source: https://dangitgit.com/#change-last-commit.
twilit juniper
will save a lot of effort 😄
Yeah lol I will from now on.
vocal wolf
git add the changes first though
tbh you should read that site if you haven't already
it has the good stuff
brazen charm
There's also fixups and rebases for mistakes that are older in the history
sharp zephyr
getting an error while executing poetry run task start , starting the python bot
server for the first time. (running in virtualbox)
#help-grapes
#help-grapes message
vale ibex
Hmm, I'm getting linting errors trying to do this in a function sig requested_state: allowed_strings("yes", "no")
undefined name 'yes' flake8(F821)
same on no too
anyone seen this before?
happens in vscode and when I run poetry run task lint
brazen charm
Use a noqa to ignore it
vale ibex
yea, was just confused where it's coming from lol
brazen charm
It interprets the strings as forward refs
vale ibex
ahh right
makes sense how it's happening now we've gone to py3.9 and wasn't before
since I'm assuming this is due to the string annotations added in 3.9
brazen charm
What do you mean? Forward refs are included in PEP 484 and all uses of that annotation should be noqa'd unless there is a coincidentally existing name in the scope
vale ibex
ohh right, it's my misunderstanding then
I'm confused how this line doesn't raise the linting error though https://github.com/python-discord/bot/blob/c89e3fd7e10b686acc1ecb1182d78abbafaea1b1/bot/exts/moderation/metabase.py#L94
stable mountainBOT
bot/exts/moderation/metabase.py line 94
extension: allowed_strings("csv", "json") = "csv"```both of them are valid names
vale ibex
oh, yea ofc, they're builtins
brazen charm
Being stdlib doesn't matter much, but they're imported at the top which defines them so the linter is happy that they could be resolved if it was an actual forward ref
gritty wind
Joking aside, that has fallen behind a bit, and should be updated
there are 9 env vars in the config, yet only 5 are documented
fallen patrol
there are 9 env vars in the config, yet only 5 are documented
whats the metabase for?
sharp zephyr
I wonder whether there’s a place on GitHub for issues about documentation/install process of the python bot . Documented a report of the process while installing the bot locally for the first time . Consists of issue, then comment
I see It’s long to post in this channel
I see maybe on the site project GitHub (instead of the bot)
thorny obsidian
Are you following our contributing guide? I know we looked into updating it a bit ago and I think had an issue open for feedback
short snow
question regarding modpings schedule issue, should this be implemented along side the current modpings on/off feature.
If yes, should the role be handed in even if they are on the break?
~~Also to implement parsing, ca I add dateutil parsing, https://dateutil.readthedocs.io/en/stable/parser.html~~
bot uses this
vocal prairie
I see maybe on the site project GitHub (instead of the bot)
You may want to take a look at https://pythondiscord.com/pages/guides/pydis-guides/contributing/site/
short snow
going afk, ping me when you answer
patent pivot
so we can pull data out of metabase and play with it on the bot
primarily for moderation stufff
patent pivot
short snow
its for making those graphs joe shares in ot channels
short snow
@exotic ember for sir-lancebot#772, what are the commands to copy the bahviour? I think I had made a fix for it when i was testing it out for the update emojis PR.
dusky shoreBOT
short snow
wanted to confirm it
exotic ember
short snow
Yeah I did that, but didn't get any error
exotic ember
right, that's my bad. I've updated the reproduction steps to make it clearer
the implementation detail is that the user is placed in the players list before the AI, so the check always short circuits before it reaches the AI in the check if the command is called by the same user
with a different user, it does not short circuit and thus errors out when it reaches the AI
short snow
could you join my test server for a minute?
fallen patrol
Yeah I did that, but didn't get any error
are you running with debug?
short snow
that's not the issue, you need to use another user to do the second .ttt
commented the fix, someone can take it up if they want it now
fallen patrol
ah
short snow
@clever wraith in case you missed out, you have a few comments on sir-lancebot#699
fallen patrol
Is it intentional that the purge command doesn't avoid purging pins?
green oriole
What do you mean
If you delete a pin, it will be gone, right?
Oh, avoid pins
I see
I don't think it is an issue
short snow
question regarding modpings schedule issue, should this be implemented along sid...
there you are, was waiting for you to come online @green oriole
short snow
perfect
short snow
is it possible to take two parameters like 10h pm and 10h?
Like what would the parameter format
take them as a full string (*, schedule: str) and write a regex expression for that?
whoops I had review the wrong pr, that was meant for python-discord/sir-lancebot#760
dusky shoreBOT
short snow
is there way to remove a review?
gritty wind
~~Also to implement parsing, ca I add dateutil parsing, https://dateutil.readthe...
Please just stick with the same time parsing everything else in the bot uses
short snow
yeah, bot uses datetutil already
gritty wind
Also I’d prefer going for 24H format
short snow
yup
sharp zephyr
Are you following our contributing guide? I know we looked into updating it a bi...
yes i followed the contributing guide for the site and the bot . I'll look for the issue
update: i saw that the most recent issue that was most-related to the docs in the bot repo was this . https://github.com/python-discord/bot/issues/496 which opened in oct 2019 and closed feb 2020
edit:
i opened a new issue
https://github.com/python-discord/bot/issues/1631
short snow
We need to add a option to make task repetitive on the scheduler so that I can work on the mod pings schedule, it would add a parameter called is_repetitive: bool = False, keyword only parameter interval: int = 0.
While deleting the task, if this is true, then it would re-add the task (or just don't delete the task) after adding interval on the time.
cc @tawdry vapor as you are the codeowner
green oriole
is there way to remove a review?
You can dismiss it I believe
You have to go to the reviews at the bottom above merge, press the three dots and then dismiss
Lemme know if you don't have the perms to do so
sleek steppe
You can dismiss it I believe
I don't think jason can dismiss reviews
vale ibex
you can possibly dismiss your own without extra perms
green oriole
Yeah, that was my thought, although there are some pretty tight restrictions on who can dismiss even inside an org
short snow
Nope
sleek steppe
what PR is this?
sleek steppe
Why are you sending this issue here? This channel is for python discord project discussions
vocal wolf
@noble hull Please read the descriptions of channels before posting. This channel is for Python Discord specific projects.
green oriole
<https://github.com/python-discord/sir-lancebot/pull/773#pullrequestreview-67826...
Oh, it doesn't seem like we can even dismiss because you aren't in the org. That's quite silly
fallen patrol
Oh, it doesn't seem like we can even dismiss because you aren't in the org. That...
It doesn't make a difference tho because he's not in the org so his review doesn't block it.
Although that could be changed 👀
fallen patrol
Yea
fallen patrol
If you have a custom integration (like our review bot) it could matter
I was talking about the fact that he's not in the org could be changed 👁️
green oriole
lol, Jason would need to be yellow for that
twilit juniper
This is from the allowed_strings function, I don't see of I could define those.
state: allowed_strings("on", "off") = None
Ignore the error
twilit juniper
But that's with flake
last patio
that's flake8 though, not pycharm, isn't it?
twilit juniper
Yeah
brazen charm
last patio
i think it's because it tries to resolve on and off to defined names because you can do annotations with quotes for e.g. forward refernces (no longer needed in newer pythons)
from other code, looks like noqa: F821 is the way to go
see e.g. bot/exts/moderation/infraction/management.py
tawdry vapor
We need to add a option to make task repetitive on the scheduler so that I can...
I think there's a much simpler solution: make the coroutine responsible for rescheduling itself. That's pretty simple: just add a schedule_at() at the bottom of the coroutine.
sleek steppe
This is from the allowed_strings function, I don't see of I could define those.
Soon this can be changed as discord.py added a typing.Literal converter in version 2.0 once it comes out. So
state: allowed_strings("on", "off") = None
would change to
state: Literal["on", "off"] = None
alright I will do that
gritty wind
This also does lowercase conversion, which a literal wouldn't I don't think
twilit juniper
Yeah
sleek steppe
oh true
twilit juniper
Can we force push it?
gritty wind
You can force push anything on your branch provided it doesn't mess with reviews
twilit juniper
Or is that not possible.
gritty wind
If it'll mess with them, then ignore it and rebase once it's approved
last patio
doesn't a rebase post-approval make github dismiss the reviews?
twilit juniper
alright, so should I just use literal or stick to allowed_strings?
gritty wind
it's a setting which is off by default
last patio
ahhh
last patio
alright, so should I just use literal or stick to allowed_strings?
discord.py 2.0 isn't out yet, i would use allowed_strings and the noqa comment
twilit juniper
Alright 👍
vale ibex
ah sorry @twilit juniper I had an old version open while writing up my comments, missed your updates
also, I see now I missed this conversation on the PR
twilit juniper
all good lol 👍
vale ibex
It seems my comments are still appropriate though
twilit juniper
Yeah
sleek steppe
@twilit juniper https://github.com/python-discord/bot/pull/1629#discussion_r647689497 still isn't resolved :P
vale ibex
feel free to ping me if you have questions on my comments
twilit juniper
twilit juniper
feel free to ping me if you have questions on my comments
Will do!
twilit juniper
Smh
dry folio
wait how many staff jakes are there
short snow
I think there's a much simpler solution: make the coroutine responsible for resc...
Yeah that was what I was doing initially but then I thought this would be useful for other features too.
tawdry vapor
I'm sure there are other features that rely on this but from an implementation perspective it's much easier to do it as I described. Trying to make the Scheduler support it just complicates the interfaces and its internals, for little benefit.
short snow
Agreed, thanks!
I forgot my mobile at school and now can’t login to GitHub, jake !close isn’t the only way to close the channel.
sleek steppe
I forgot my mobile at school and now can’t login to GitHub, jake `!close` isn’t ...
is there another way?
tawdry vapor
It has aliases
sleek steppe
!help close
stable mountainBOT
Command Help
tawdry vapor
Also, I think there's a way to parse the message into a context and check which command was invoked
More robust way that wont rely on checking strings
sleek steppe
I would use bot.get_context there
yeah this ^
clever wraith
hi guys i was wondering how the python bot has a link connected to the white title when i try to do it i can only get my text to be blue
the thing i marked in yellow is what i mean
tawdry vapor
Does it have a link?
clever wraith
yes
tawdry vapor
stable mountainBOT
bot/exts/moderation/infraction/_utils.py line 180
embed.set_author(name=INFRACTION_AUTHOR_NAME, icon_url=icon_url, url=RULES_URL)```
short snow
do we want to ping the mods when its time for their duty? i.e. their schedule start time
patent pivot
no, it's fine to just add/remove roles silently
short snow
cool 👍
short snow
Ok so am adding modpings schedule to modpings.py therefore it will use the same scheduler as modpings on/off. This means that once a person schedules worktime, he cannot use on/off until they remove it. So there are two possible solutions that I can see to this, use a different ID format for scheduling, currently I am using ctx.author.id as modpings on/off. The other solution to this is adding another scheduler to the Cog/Class, which one would be better?
ping me when you answer
green oriole
Ok so am adding modpings schedule to `modpings.py` therefore it will use the sam...
Two schedulers sounds like the more logical move
short snow
Two schedulers sounds like the more logical move
right, I will do that
which pr is that chris"?
green oriole
something something scheduler
short snow
lol
vale ibex
bot#1570
dusky shoreBOT
green oriole
as you can see, I can't remember 4 numbers more than 0.42s
vale ibex
!remind @green oriole 0.41s what was the number?
stable mountainBOT
vale ibex
green oriole
lol
short snow
I am not using redis cache for this btw, modpings schedule
green oriole
How is that so?
short snow
nvm , I thought scheduler tasks was persistent, unti l saw zig's PR
short snow
Looks like WIP PR icon got updated
green oriole
What a format
stable mountainBOT
.github/workflows/lint.yaml lines 18 to 19
# Configure pip to cache dependencies and do a user install
PIP_NO_CACHE_DIR: false```
empty sluice
Doesn't PIP_NO_CACHE_DIR=false turn off caching?
clever wraith
hey @green oriole ive started to notice that github turns any transparent sponsor image i upload to non transparent. any idea why?
lemme show you quick
transparent cloudflare
github cloudflare https://github.com/Kronifer/site-1/blob/patch-1/pydis_site/static/images/sponsors/cloudflare.png?raw=true
wait what
the devil
why is it only fucked up on the siite
heyy it works
green oriole
Hahaha
green oriole
Hey @clever wraith, why not use the old PR?
clever wraith
someone nuked it
short snow
You might wanna squash the commits btw
clever wraith
someone closed it sorry
sleek steppe
yeah kosa closed it
green oriole
A'ight
short snow
Doesn't `PIP_NO_CACHE_DIR=false` turn off caching?
pypa/pip#5735
vale ibex
Doesn't `PIP_NO_CACHE_DIR=false` turn off caching?
Yes, we don't want a cache inside the container, since the container itself only ever runs that pip command once, so no need to cache it internally
we do have a build cache, so when the container itself is built, that's partially cached
last patio
hey @mellow hare, how are you doing? i have a short question, are you available for reviews?
empty sluice
Yes, we don't want a cache inside the container, since the container itself only...
#dev-contrib message
This is in the lint workflow and the line right above says to use caching.
last patio
What's up
nothing in particular right now, I'm just looking to refresh the group of active reviewers i had in my head :D
mellow hare
HA, fair enough
green oriole
https://discord.com/channels/267624335836053506/635950537262759947/8522062410349...
Uuh that sounds problematic. Do we really not have any cache in the CI?
mellow hare
I'm going to be slammed for a little while. We're migrating our email system to Outlook 365, so I'm fielding all the trouble that comes with that
green oriole
Oh no, not a 365 migration
green oriole
That was my worse 3 weeks at school, because I wasn't at school I was doing migrations for a company
Spent my days in team viewer calls waiting for this stupid installer to do its thing
mellow hare
Well for comparison, here's what we're moving away from. https://www.lan-aces.com/
fallen patrol
Uuh that sounds problematic. Do we really not have any cache in the CI?
pypa/pip#5735
fallen patrol
jason brought it up above
green oriole
Well for comparison, here's what we're moving away from. https://www.lan-aces.c...
Oh wow, you didn't even have office?
fallen patrol
so this means that its enabled: PIP_NO_CACHE_DIR: false
green oriole
There's a linked PR that fixes it though
Can we actually test that?
I'm not sure if we even want caches in CI
last patio
Well for comparison, here's what we're moving away from. https://www.lan-aces.c...
what a gorgeous website
mellow hare
Welcome to my hell
clever wraith
my god that looks like hell
eternal owl
https://github.com/python-discord/site/pull/508
ready for reivew
cold island
Well for comparison, here's what we're moving away from. https://www.lan-aces.c...
2004 wants its UI back
vale ibex
RE sir-lancebot#774, here's the emoji if anyone reviewing wants to confirm the ids
dusky shoreBOT
mellow hare
2004 wants its UI back
2004 is being generous.
fallen patrol
RE sir-lancebot#774, here's the emoji if anyone reviewing wants to confirm the i...
Discord changed the IDs?
I mean
Github changed the UI?
patent pivot
yeah
short snow
RE sir-lancebot#774, here's the emoji if anyone reviewing wants to confirm the i...
pr open remains the same?
short snow
yep looks like it remains the same
fallen patrol
yep looks like it remains the same
no
slightly different
top is current bot, bottom is current on github itself
short snow
umm yeah, they are a bittt different
fallen patrol
@exotic ember 
exotic ember
wat
fallen patrol
You can comment on commits?
exotic ember
yes
echo karma
i made a macro to level up on mee6 using python
fervent sage
thats client automation which is against discord's terms of service https://dis.gd/terms, which is also therefor against the rules of this community
echo karma
but its just a spam bot
its code that lets u spam in server spam channels
also it does not trigger the cool down
it does it slowly
cold island
@echo karma This channel is for projects developed for this server such as our bots and our website. Regardless, what you're describing is account automation and can result in your account being shut down.
vale ibex
top is current bot, bottom is current on github itself
Ah yea, you are right
Any chance someone can edit this svg https://github.com/primer/octicons/blob/main/icons/git-pull-request-24.svg to rgb(107, 196, 109) and export as a png?
I'll get it added to this PR
Also, this one https://github.com/primer/octicons/blob/main/icons/git-merge-24.svg to rgb(152, 110, 226)
vale ibex
posted in #dev-branding
short snow
Is there anyway to test rediscache related code without manually injecting key value pairs during start up?
vale ibex
are you using docker-compose?
If so, you can do docker-compose up bot (or sir-lancebot if it's on there) so that when you ctrl+c out, it leaves the other containers running
short snow
Umm, yeah I would need to use docker-compose to test it out, it isn't possible normally (with peotry) right?
vale ibex
not unless you have a seperate Redis instance running
but no, it's not possible using fakeredis
short snow
👍 alright thanks
another question:
So I am adding the task again as soon as it gets over, but know the problem is I am adding it inside the function which is being called when it is time to call the task, so basically that means it that the task is still present and I am making another task which is not possible as it shows in the logs. So how should I do that?
green oriole
RE sir-lancebot#774, here's the emoji if anyone reviewing wants to confirm the i...
They look good, but they are too zoomed in IMO
brazen charm
So I am adding the task again as soon as it gets over, but know the problem is I...
Cancel the scheduled task first; https://github.com/python-discord/bot/blob/c89e3fd7e10b686acc1ecb1182d78abbafaea1b1/bot/exts/info/doc/_cog.py#L138-L153 does similar rescheduling
vale ibex
They look good, but they are too zoomed in IMO
Yea, when the emojis are directly above/below another on the same line, they do get very close
They possibly do need a small border around them
I'll take a look tonight
since I've got PNGs now, I can actually work with them myself 😛
sharp zephyr
#help-lemon setting up linting
sharp zephyr
i notice when submitting a new issue to https://github.com/python-discord/bot/issues it does not have a template .
when i submitted an issue to lancebot it did have 3 templates .
sleek steppe
i notice when submitting a new issue to https://github.com/python-discord/bot/is...
our bot repository has no templates
sharp zephyr
our bot repository has no templates
are we able to use templates from the other repository? I see it'd have been a better structure for the issue i posted
green oriole
You are free to use a similar template honestly
We just want to give more freedom to contributors
vale ibex
hah true
short snow
Cancel the scheduled task first; https://github.com/python-discord/bot/blob/c89e...
Ah thanks!
clever wraith
could i get some review on site#527
dusky shoreBOT
clever wraith
bloody hell i still dont have codespaces
vocal prairie
The merger can squash it (if that's permitted in settings), idk about the author
green oriole
Can we get a contrib/staff review on this please?
vocal prairie
Testing right now
short snow
that was fast
vocal prairie
That was very fast
balmy sparrow
auto-merge was enabled so after i approved it went through quick 
green oriole
Niiiice, good job!
Interestingly enough commits squashed by github don't get signed
patent pivot
very nice
green oriole
Oh they do get signed, I guess it is a bug in github's patch generation
fallen patrol
Oh they do get signed, I guess it is a bug in github's patch generation
they do or don't
clever wraith
Interestingly enough commits squashed by github don't get signed
huh
fallen patrol
It is lacking the signature
green oriole
I mean, look at the link
The patch is lacking the signature
Which got me confused at first
But in the history they do actually be signed
clever wraith
oh for fucks sakes
fallen patrol
😂
clever wraith
Github kept fucking up my logo, making the bloody background black and shit
fallen patrol
site#515
site#527
dusky shoreBOT
clever wraith
blame Kosa for closing the first one
fallen patrol
blame Kosa for closing the first one
fwiw you could've opened a new pr with the same branch lol
clever wraith
i used the same branch wdym
fallen patrol
o lol
sleek steppe
I don't think that's a good idea, ten commits that edits 2 lines
green oriole
You can squash and force push
clever wraith
yeah i shouldve done that :/
fallen patrol
I don't think that's a good idea, ten commits that edits 2 lines
you can squash lol
sleek steppe
that is true
fallen patrol
that is true
which is worse?:
multiple prs for the same thing
squash commits
vale ibex
Thoughts on the new emoji?
They've each got a border now too
fervent sage
They look so nice
crude gyro
lovely
fallen patrol
Ah yea, you are right
Oh God. Checking the git blame, these have been that way for over 14 months on github. It almost seems not necessary to update the icons.
But they do look nice.... So....
vale ibex
yea, the octicons have been there all this time
But the push to github might not have been that long ago
fallen patrol
No, https://github.com/primer/octicons/blob/main/icons/git-pull-request-24.svg == 14 months ago
wicked inlet
Just tried to copy bits of your lint and test workflow
It worked just fine until running flake8
I have 120k lines of errors
Looking something like this
So annoying cause flake8 works locally
Just not through the workflow
Please redirect me to a different channel if I should not post this here :/
vale ibex
It seems like you're not installing the dependancies in your workflow
or at least that's what it seems like from that image
I'd suggest opening a help channel though, since it's not related to any PyDis repo.
Maybe ask in #tools-and-devops if you don't have any luck in the help channels
wicked inlet
I have posted directly in #tools-and-devops
short snow
how do i set level to show trace logs? running from peotry
clever wraith
im not sure
short snow
would it be possible include the scheduler name at start of the logs of scheduler?
here, these are two are of two different schedulers, and it is difficult to understand which is of which
maybe we can add <name> | <logs>
nvm am dumb, it is shown there already
short snow
Do i write unittests for it?
tawdry vapor
"ScheduleScheduler" is very odd name
short snow
lol yeah, I changed it to be ModPingsSchedule
-self._role_scheduler = Scheduler(self.__class__.__name__)
+self._role_scheduler = Scheduler("ModPingsOnOff")
+self._modpings_scheduler = Scheduler("ModPingsSchedule")
@vocal wolf is it possible to send two embeds in a single message?
nah, that won't look good lol
vocal wolf
Never tried.
short snow
There weren't any tests written for modpings earlier so do I write them for this feature?
vocal wolf
There weren't any tests written for modpings earlier so do I write them for this...
you don't have to
tests for new features aren't required
passing tests for enhancements with previously written tests are
short snow
ah, but if someone writes them will they be accepted?
vocal wolf
if it's within scope of a PR, yes
so if you wanted to for modpings and the mod schedule thingy, go ahead
just make sure that the content of the PR is edited to tell reviewers what's going on
short snow
I will keep it separate from this PR, since I am not really experienced with unittests, and may take time.
vocal wolf
green oriole
<@!196664644113268736> is it possible to send two embeds in a single message?
Only with webhooks iirc
short snow
yep looks like that 
fallen patrol
<@!196664644113268736> is it possible to send two embeds in a single message?
No, but I saw an issue about it somewhere
fervent sage
<@!196664644113268736> is it possible to send two embeds in a single message?
webhook yes bot no
because discord is very consistent 👍
full fractal
@gritty wind so now I'm not breaking rule 7, let's continue here
gritty wind
Lol
full fractal
I can get excited inducting a new sacrificial goat to the academy of pydis contributing
I'm concerned now
gritty wind
Oh no, you'll probably be fine
vocal wolf
triage vs triage
gritty wind
Is this a multiple choice question?
vocal wolf
500 words minimum
full fractal
I'm assuming that I don't need to add the black channel to guild.channels
patent pivot
category should be fine
gritty wind
I had a look at the reminders src
full fractal
and ....
gritty wind
It would require some modification to work with categories too
So it's fine if you add just black for now
patent pivot
ah
vocal wolf
what's being worked on?
gritty wind
If you want to have a go at giving it full support, that would be amazing, but not needed for this
Allowing !remind in #black-formatter or OSS in general
vocal wolf
I see
vocal wolf
ye
gritty wind
bumped up to 3.9(.5) recently which was
vocal wolf
given modern python is like 3.9+
gritty wind
so sweet
full fractal
okay, so does this looks fine (watch this break later):
diff --git a/bot/constants.py b/bot/constants.py
index ab55da48..ca9ec7c5 100644
--- a/bot/constants.py
+++ b/bot/constants.py
@@ -399,6 +399,7 @@ class Categories(metaclass=YAMLGetter):
moderators: int
modmail: int
voice: int
+ open_source_projects: int
class Channels(metaclass=YAMLGetter):
diff --git a/config-default.yml b/config-default.yml
index 55388247..83118d96 100644
--- a/config-default.yml
+++ b/config-default.yml
@@ -142,6 +142,7 @@ guild:
moderators: &MODS_CATEGORY 749736277464842262
modmail: &MODMAIL 714494672835444826
voice: 356013253765234688
+ open_source_projects: 846434038251782214
channels:
# Public announcement and news channels
@@ -244,6 +245,7 @@ guild:
reminder_whitelist:
- *BOT_CMD
- *DEV_CONTRIB
+ - *BLACK_FORMATTER
roles:
announcements: 463658397560995840
that was bigger than I had expected
gritty wind
oh wow, you made an actual diff 
Where was BLACK_FORMATTER added
the category looks good though
full fractal
category should be fine
oh ok, so joe was wrong here /j
patent pivot
lol
full fractal
I mean, I probably should've caught the fact there was no id declaration for the channel I was adding
gritty wind
I think the process just got muddled up due to channel vs category
patent pivot
wonder if there is a YAML linter that could help with things like that
full fractal
v2:
diff --git a/bot/constants.py b/bot/constants.py
index ab55da48..ca9ec7c5 100644
--- a/bot/constants.py
+++ b/bot/constants.py
@@ -399,6 +399,7 @@ class Categories(metaclass=YAMLGetter):
moderators: int
modmail: int
voice: int
+ open_source_projects: int
class Channels(metaclass=YAMLGetter):
diff --git a/config-default.yml b/config-default.yml
index 55388247..894b1aff 100644
--- a/config-default.yml
+++ b/config-default.yml
@@ -142,6 +142,7 @@ guild:
moderators: &MODS_CATEGORY 749736277464842262
modmail: &MODMAIL 714494672835444826
voice: 356013253765234688
+ open_source_projects: 846434038251782214
channels:
# Public announcement and news channels
@@ -176,6 +177,9 @@ guild:
user_log: 528976905546760203
voice_log: 640292421988646961
+ # Open Source Projects
+ black_formatter: 846434317021741086
+
# Off-topic
off_topic_0: 291284109232308226
off_topic_1: 463035241142026251
@@ -244,6 +248,7 @@ guild:
reminder_whitelist:
- *BOT_CMD
- *DEV_CONTRIB
+ - *BLACK_FORMATTER
roles:
announcements: 463658397560995840
we could probably write one that checks that constants.py and the config file match up
full fractal
oh wow, you made an actual diff <:lemon_hyperpleased:754441879822663811>
Other than typo fixes, I don't use the online editor
gritty wind
That would also need a reference to actually mention
like the one after modmail
&BLACK_FORMATTER
gritty wind
Haha you can declare yaml variables after the key name:
black_formatter: &VARIABLE_NAME 000000```I don't actually know if it's case sensitive
Line 157 is an example of this
full fractal
I'm sad now
gritty wind
You can then reference the variable's value in the YAML using *VARIABLE_NAME
full fractal
the channel name is so long that it doesn't align with the rest of the ids
gritty wind
Idk if this is standard yml, because if so, it just reinforces my belief yaml is evil
Feel free to realign everything 👀
full fractal
I just assumed you guys were hacking yaml
gritty wind
We definitely are with the ENV tags at the top lol
full fractal
black_formatter: &BLACK_FORMATTER 846434317021741086
gritty wind
that lgtm
is it in constants.py?
I feel bad making you do all this work, esp with no testing env
full fractal
oh fun
gritty wind
lol
full fractal
❯ git diff bot/constants.py
diff --git a/bot/constants.py b/bot/constants.py
index ab55da48..4cd17425 100644
--- a/bot/constants.py
+++ b/bot/constants.py
@@ -399,6 +399,7 @@ class Categories(metaclass=YAMLGetter):
moderators: int
modmail: int
voice: int
+ open_source_projects: int
class Channels(metaclass=YAMLGetter):
@@ -433,6 +434,8 @@ class Channels(metaclass=YAMLGetter):
off_topic_1: int
off_topic_2: int
+ black_formatter: int
+
bot_commands: int
discord_py: int
esoteric: int
looking good
gritty wind
just... ;
full fractal
So wait, why are we adding the oss category again?
gritty wind
it may not be necessary at this point
full fractal
and that's why I'm asking you 😄
gritty wind
lol
full fractal
❯ git diff
diff --git a/bot/constants.py b/bot/constants.py
index ab55da48..3d960f22 100644
--- a/bot/constants.py
+++ b/bot/constants.py
@@ -433,6 +433,8 @@ class Channels(metaclass=YAMLGetter):
off_topic_1: int
off_topic_2: int
+ black_formatter: int
+
bot_commands: int
discord_py: int
esoteric: int
diff --git a/config-default.yml b/config-default.yml
index 55388247..48fd7c47 100644
--- a/config-default.yml
+++ b/config-default.yml
@@ -176,6 +176,9 @@ guild:
user_log: 528976905546760203
voice_log: 640292421988646961
+ # Open Source Projects
+ black_formatter: &BLACK_FORMATTER 846434317021741086
+
# Off-topic
off_topic_0: 291284109232308226
off_topic_1: 463035241142026251
@@ -244,6 +247,7 @@ guild:
reminder_whitelist:
- *BOT_CMD
- *DEV_CONTRIB
+ - *BLACK_FORMATTER
roles:
announcements: 463658397560995840
or... should I add back the oss category
gritty wind
The category is not necessary anymore
full fractal
And see kids, asking a question a second time but with slightly different wording is how you get full answers to your questions
full fractal
it may not be necessary at this point
You went from this7
full fractal
The category is not necessary anymore
To this
gritty wind
words me no good
full fractal
OK, time for my favourite part of development, writing a good commit msg /hj
gritty wind
I've seen some atrocious stuff. As long as you aren't filling it with gibberish you'll be fiiiine.
Now if your plan was to fill it with gibberish
full fractal
In all seriousness, this is the longest commit msg I've ever written: https://github.com/psf/black/commit/62bfbd6a63dcac2f6f31eb014f69397c9eb967d2
gritty wind
Did you reorganize the docs into the msg?
vocal wolf
holy
full fractal
yeah I had to write that one in a separate file + copy and paste lol
full fractal
The root title was ## not # that was causing myst-parser to emit some of 'em warnings
and we enforce warning free documentation builds 😄
gritty wind
I love that we went full circle and started going OT here with #black-formatter stuff
gritty wind
and we enforce warning free documentation builds 😄
windows tho 😬
full fractal
I told you I have a problem
gritty wind
Adds the black-formatter channel to the remind
command overrides to allow usage of the command
in the channel.```
Line length is probably off, but that's the best I can do eyeballingyou were pretty off mate
gritty wind
let's pretend I get paid by the line ¯_(ツ)_/¯
full fractal
I totally didn't just mess up my auth for a git push
anyway, here's the commit https://github.com/ichard26/bot/commit/c26a03a90a7d7d92fc07a1074965371d007428d8
I see you're one of the those vigilant mode users 👀
full fractal
so you're taking your security advice from and I quote: "Tfw joe isn't the smartest person in the room" /j
gritty wind
he was last week
full fractal
I see how it is
gritty wind
Unless vigilant mode has a negative effect on brain functionality, I think he should be fine again next week
patent pivot
lmfao
full fractal
and PR created!
gritty wind
I wonder if I can review it
full fractal
ah yes, the "workflow awaiting approval"
gritty wind
It may not count cuz co-author
full fractal
oh lol
gritty wind
You know what I should do
clever wraith
joe converted me last week
Chris got me
gritty wind
I should go and copy your first time contributor message
gritty wind
I had keys for a long time, just didn't have the vigilant setting enabled
full fractal
It's a pytest plugin that parallelizes your code. I don't really have anything else to say about that. It worked really well out of the box, and I didn't run into any problems. Here are some numbers:
Us over at psf/black had a lot of issues with pytest-dev/pytest-xdist#620
full fractal
You too!
clever wraith
Thanks
gritty wind
ayyy it counted
gritty wind
> It's a pytest plugin that parallelizes your code. I don't really have anything...
did you end up disabling it all together, or just in CI?
vocal wolf
!source remind
stable mountainBOT
full fractal
did you end up disabling it all together, or just in CI?
just for ci because the bug was too frequent due to how many times we run the test suite
locally we didn't hit much
but yeah, here's a random failure we encountered: https://github.com/psf/black/runs/2730726139?check_suite_focus=true
gritty wind
I wonder if there's a stable parallelization tool then
full fractal
I haven't looked into it
vocal wolf
@full fractal your PR has been merged.
full fractal
that is a quick turnaround time 👀
gritty wind
All PRs on pydis have the same turnaround period, regardless of length
Money back gaurnteed
full fractal
<@!429445826251587616> your PR has been merged.
Thanks for the review!
vocal wolf
👍
full fractal
You too @gritty wind and also the guidance
gritty wind
*disclaimer: your PR may take longer depending on length, reviewer availability, and the orientation of the sun
full fractal
and that's what we were waiting for lol
vocal wolf
*disclaimer: your PR may take longer depending on length, reviewer availability,...
and also which timezone I decide to sleep in
gritty wind
you sleep?
full fractal
also how much the maintainer is bored that day
vocal wolf
you sleep?
correct.
gritty wind
Interesting...
full fractal
Y'all seem fine with pytest-xdist, I see each CI run only runs the test suite once, not 24 times like us 😛
full fractal
well, I already created it in #bot-commands but OK
gritty wind
lol
full fractal
it worked :hooray:
gritty wind
testing in prod 101
gritty wind
They're a fantastic machine
gritty wind
We get a lot of stuff, so it's great not to have to worry about it. It also means more consistent triaging most of the time
dude
full fractal
They're a fantastic machine
they sleep so they aren't a machine
gritty wind
Windows updates
vocal wolf
I run linux.
full fractal
Me too.
gritty wind
linux updates*
full fractal
well linux doesn't force you to update
full fractal
I say that and I have Windows dual booted on this machine and I haven't booted it in a long time, can't wait for when I boot it and have to wait out the hours of updates
vocal wolf
I put windows on a separate drive so I don't have to worry about it overwriting partitions and breaking my manjaro programming environment by not letting me boot.
full fractal
My protection method is just not booting Windows, which is shockingly easy to avoid doing
full fractal
Sadly enough
OK, time for me to go back to my psf/black maintainer duties (i.e. derailing all the channels I'm in). In all seriousness, it was fun to contribute, I'd encourage you to maybe bump the priority of making it easier to set up a dev env but it sounds like lack of time is the main issue (which I can totally relate to)
vocal wolf
Improvements are occurring for users setting up dev environments, yes. Thank you for the contribution!
fallen patrol
All PRs on pydis have the same turnaround period, regardless of length
.bm
full fractal
The triager within me found this issue that should probably be closed: bot#1585
dusky shoreBOT
vocal wolf
The triager within me found this issue that should probably be closed: bot#1585
thanks!
trim cradle
The bot needs to be able to look up sklearn docs.
tawdry vapor
Okay
Are you able to add it?
Not sure what the permissions on the command are
!docadd
!help doc
stable mountainBOT
Command Help
tawdry vapor
Well I guess that means I can't
fallen patrol
The bot needs to be able to look up sklearn docs.
get the objects.inv link and send it in #community-meta 😛
trim cradle
Not sure what the permissions on the command are
!docs add
stable mountainBOT
stable mountainBOT
trim cradle
Looks like it's here: https://github.com/scikit-image/scikit-image/blob/1f8c74f69e0f9e72c59f180b2fc96d311659c609/doc/source/_intersphinx/sklearn-objects.inv
no actually
tawdry vapor
You want scikit image rather than scitkit learn?
This is for scikit learn
https://scikit-learn.org/stable/objects.inv
I'm not entirely sure what the base url should be
One of these, probably
https://scikit-learn.org/stable/modules/
https://scikit-learn.org/stable/modules/generated/
fallen patrol
Looks like it's here: https://github.com/scikit-image/scikit-image/blob/1f8c74f6...
I mean, ig that works lol
The objects.inv is normally located on the docs at whatever/objects.inv
Yeah the link that mark sent above
exotic ember
!d sklearn.covariance
stable mountainBOT
short snow
https://github.com/python-discord/bot/pull/1634/files#diff-d82a54c450ea031f87210217bd9b41f10344938751efefdf015f27d9404a9a06R17 should I make this configurable?
(in config.yml)
also should add a delete sub-command, so that you can delete your modpings schedule?
dry folio
hey, if anyone wants a non-code PR to review you can look at sir-lancebot#756. it has been waiting for almost 20 days :D
velvet sequoia
Does anybody know what the python icon next to the commenters username means in the cpython bug tracker? Does that indicate the person is a core developer?
brazen charm
This channel is about python discord projects, but depending on the colour it either means they are a python triager or commiter, you can see it on hover
trim cradle
!d sklearn.covariance
Was that already a thing or did you add it?
!docs sklearn.cluster.KMeans
stable mountainBOT
trim cradle
vale ibex
!otn a k means klustering
stable mountainBOT
:ok_hand: Added k-means-klustering to the names list.
vocal wolf
@vale ibex wanna #changelog that?
vale ibex
oui
vale ibex
Just had a thought after merging, would it be useful to push !helpdm invocations to statsd?
could be a cool stat to have
brazen charm
Aren't there stats already for command invocations? Or would it be for the amount of times it sent dms
vale ibex
Aren't there stats already for command invocations? Or would it be for the amoun...
It keeps track of invocations yea, I should have bene more specific, I was more asking if knowing how many people had turned it on vs off could be good
vocal wolf
@vale ibex sir-lancebot#774 merged
dusky shoreBOT