#dev-contrib

1 messages · Page 107 of 1

tough imp
#

you probably don't need 100% coverage either, just write tests that make some amount of sense

#

I've written those tests back when there was still a desire to keep increasing the overall coverage; afaik the paradigm has shifted since then

#

for example, it's probably not necessary to test the on_message listener, since it's simple enough that you can more or less see that it works by just glancing over it

#

and testing it via Discord is trivial

short snow
#

starting with the regex sounds good
ok cool, I will start of with that as of now.

afaik the paradigm has shifted since then
yeah it has shifted, 100% coverage isn't aimed nor tests are compulsory for all features

it's probably not necessary to test the on_message listener, since it's simple enough that you can more or less see that it works by just glancing over it
Then, the only test case i think we need is for regex, which is not reallly necessary also imo

tough imp
#

maybe we should fix it then 😄

#

what's wrong with it?

#

is it broken for the main bot too?

gritty wind
#

Haha just sir-lance

#

It's actually fine

#

but the paginator can't handle it

short snow
#

the paginator doesn't work perfectly

gritty wind
#

we have an issue open, but that's gone stale multiple times

short snow
#

issue link?

gritty wind
#

sir-lancebot#553

#

sir-lancebot#533

tough imp
#

ah, that looks fixable

#

want me to look at it?

gritty wind
#

It's had a PR open for 3 months

#

But the author was mia up until 3 days ago

#

seems things are happening again

tough imp
#

awesome

short snow
#

i think, there is a simple fix for it, lemme test if that's ok

#

ok nope, it doesn't work

#

what i thought, was to just remove the empty lines after each item, and strip them

patent pivot
#

i don't get it at all lol

tough imp
#

shipit rat cannot be controlled

patent pivot
#

shipit RAT?????

#

wow kwzrd.....

glass pecan
#

squirrel?

patent pivot
#

quite evidently a squirrel in a mobster fit

vocal wolf
#

beautiful.

glass pecan
#

squirrels are just rats

vocal wolf
tough imp
#

squirrel falls into rat class 😌

glass pecan
#

rats have no class. neither do squirrels. otherwise they'd wear something better

vocal wolf
#

@patent pivot catjam after pr when

patent pivot
#

lol

#

i think i have the template workflow somewhere

vocal wolf
#

is it still on ledger?

patent pivot
#

yea

#

lul

vocal wolf
#

the code

#

hand it over

brazen charm
#

Could use a review on bot#1529 to make development a bit nicer

short snow
patent pivot
#

yeah

gritty wind
#

@brazen charm just waiting on a branch update, but the PR is good to go

short snow
#

or it is the expected behaviour

cold island
#

no, I was planning on changing it so that the pants would have a complementary color, just didn't get around to it

cold island
#

but you can go for it if you want

short snow
#

or if you want to do it, you can go ahead, no worries

fervent sage
#

hang on when tf did quackstack switch to using hypercorn

#

i dont even remember seeing the pr Thonk

fervent sage
#

im going insane

#

im actually going insane

vale ibex
#

lol

fervent sage
#

this is fine, everything is fine

vale ibex
cold moon
#

Nothing is fine

vocal wolf
#

@vale ibex for sir-lancebot#702 which subreddit did you test?

dusky shoreBOT
short snow
fervent sage
#

i am very confused

#

i guess we decided to use hypercorn and then my brain was just like "sure", did it, and then completely forgot

vale ibex
#

.reddit yeethon

vocal wolf
#

ty

vale ibex
#

Alec broke it first

fervent sage
#

:)

vocal wolf
#

lol

vale ibex
#

all credit to him

fervent sage
vale ibex
#

lol

#

There's another issue that iceman is working on to make the NSFW check work better

#

as in filter out NSFW posts, rather than just check the first

#

So this PR is purely just to fix the errors

short snow
#

and why are docs disabled?

#

i was looking to test manduck, and found no docs

fervent sage
#

theyre not in the pr i'm about to make kek

#

quackstack#36

dusky shoreBOT
fervent sage
#

would appreciate a staff review quickly if anyone is available, it should take like 10s to look over :P

short snow
#

merge it, i am staff

edit: was

cold island
short snow
#

so basically i just generate the shirt color, and get the compliment of (that and the ducky colors)

cool, ok, i will do it

#

how about i generate Triad from the ducky body color?

#

and take one as shirt and the second as pant?

short snow
#

need to figure out a algorithm for it pithink

short snow
#

should be simple, figured it out

patent pivot
#

lol

#

i didn't change anything though

#

so

#

¯_(ツ)_/¯

short snow
clever wraith
#

Anyone needs help In code?

patent pivot
#

it's more a shock that it worked for toxic earlier, it just seems like something on discord's end

short snow
#

hmm

short snow
#

is that ok or there is a better way?

vocal wolf
#

@vale ibex you tested that reddit PR, ye?

clever wraith
#

can any staff review splitify

#

its been sitting ready to be merged for like 3 days

vocal wolf
#

alright I'm pretty sure my emojis on the paginator are just broken

#

not part of this PR

#

unless...?

#

it shows page 1/2, are you able to get to the second page? I'm not able to.

vale ibex
#

I could when my bot was running

vocal wolf
#

could you start your bot real quick?

clever wraith
#

am i invisible

vocal wolf
#

@clever wraith you are not. I'm staring at your PR atm.

clever wraith
#

i dont really get it

#

catify got merged like the next day it was started

vocal wolf
#

Shouldn't we put some limitations on processing these images?

clever wraith
#

is there a problem with me?

vocal wolf
#

no

#

Some PRs get merged faster than others

brazen charm
#

It hasn't been open for that long

#

It's all voluntary work, so set your expectations with that in mind

vale ibex
clever wraith
#

i have set it

vocal wolf
#

@vale ibex ty

#

@clever wraith so the images in first post of the PR are up to date?

clever wraith
#

yes

vocal wolf
#

alright sick

clever wraith
#

that never changed

short snow
#

@cold island look what do we have 🙃

clever wraith
#

and it also got way more attention

cold island
clever wraith
#

it seemed like some people liked mine when i just started it but then sort of stopped caring about it

short snow
#

perfect 😄

vocal wolf
sleek steppe
#

@vocal wolf when you requested changes that were already dealt with in another PR 🙃

vocal wolf
#

@sleek steppe which one?

deft patrol
short snow
#

hash of time

sleek steppe
#

sir-lancebot#569

dusky shoreBOT
vocal wolf
clever wraith
#

i dont want to name anyone specifically but yeah

#

anyways, thanks for looking at it at least

short snow
#

how to add descriptions while using git commit ?

vocal wolf
short snow
#

git commit -m "title" "descrition"?

vocal wolf
#

or just using \

#

I never did one before lol

short snow
#

i always used the pycharm so never used this

sleek steppe
#

You mean like

git commit -m "Foo blah bar spam

Some other stuff here
...
"
short snow
#

ok cool

#

using neovim, so was asking

tough imp
#

if you just git commit it should open the configured editor and you can write it there

#

you can configure git to open neovim

vocal wolf
safe gorge
#

Does @stable mountain auto-delete any .py file uploads? I feel like they could be allowed in help channels since discord offers this nice viewer

clever wraith
#

so if i made smth like this:

.wingify

buddy choke --> ༼༻buddy choke༺༽

would it get approved way faster? @vocal wolf

vocal wolf
#

I cannot determine the amount of time something will take to be reviewed.

clever wraith
#

well i mean is it about the complexity or what is that matters

sleek steppe
safe gorge
#

Ahh, I see

vocal wolf
thorny obsidian
#

That feature is still very new, so we're going to wait until it's a bit more developed and has the features we need

sleek steppe
#

Now that we're talking about Pr's that should be reviewed, what about bot#1529

sleek steppe
#

wait no

#

huh

clever wraith
sleek steppe
#

bot#1531

short snow
#

but eventually someone will review the pr

patent pivot
#

I don't think there are any metrics that really make up how long a PR will sit in the review queue

#

sometimes PRs go fast, sometimes they go slow, in the worst cases we've had PRs last for years

clever wraith
#

💀

sleek steppe
#

lol

patent pivot
#

obviously yours won't take years, but just because one PR takes a short period of time that isn't anything to base your, separate, PR off

clever wraith
#

ok

#

ill make an issue about these wings then, maybe someone will like it

vocal wolf
#

Something something "you can't do this here"?

sleek steppe
vocal wolf
#

ty

patent pivot
#

I'm meh on the idea of a wings command, feels like just noise

balmy sparrow
#

do we really need to redirect output now, when the command works in almost every channel anyways?

short snow
#

@cold island sorry for the 3rd ping in an hour, could you review quackstack#37 as you are the "codeowner"

dusky shoreBOT
patent pivot
#

I can test out sir-lancebot#688 now

dusky shoreBOT
clever wraith
sleek steppe
patent pivot
#

it's more than just adding something before and after

clever wraith
#

ok then

patent pivot
#

alright, checking out splitify

clever wraith
#

thanks

short snow
#

the wings are too "noisy" and decorative

#

something which i don't like personally

vocal prairie
brazen charm
#

I don't think they're much more noisy than the cat thing, but they aren't really used by anyone to warrant a command to add them

clever wraith
#

was cat used outside here?

short snow
#

yes, a llooot

clever wraith
#

oh

#

ive never heard of it

short snow
#

check the vc chats

#

you will find it there

clever wraith
#

i dont know what vc is

short snow
#

mina introduced it

vocal wolf
#

What doesn't redirect output in #python-discussion to #bot-commands for regular users? doc?

short snow
#

voice channel

clever wraith
#

i meant outside this server

short snow
#

we can't say about that 🙃

sleek steppe
patent pivot
#

hmm I think 193600 is way too many squares, and it's noticably slower (I haven't measured resource usage yet)

#

but I'll add this as a review

vocal wolf
clever wraith
#

it is way slower, yes

patent pivot
#

also, for future reference, PRs should have an issue opened on lancebot before the feature is implemented

sleek steppe
#

I know that !zen does, !raw, but not !doc

clever wraith
#

it was opened and approved by akarys

#

opened by me*

short snow
#

yeah this

vocal wolf
#

I thought raw doesn't work for regular users?

patent pivot
#

oh?

brazen charm
#

doc is allowed everywhere

patent pivot
#

which issue?

brazen charm
#

I believe it was discussed here

patent pivot
#

ah

short snow
#

687

clever wraith
#

i need to find it

clever wraith
short snow
#

sir-lancebot#687

patent pivot
#

ah

vocal wolf
#

add that to the top of the PR please

clever wraith
#

and what do u mean by too many squares

#

it creates cool unique images

vocal wolf
short snow
#

those split squares, it would take up resources

clever wraith
#

it sure may not look like ur pfp anymore but the pieces are used from it

short snow
#

which would be blocking

#

and slow down the bot

clever wraith
#

i can thread it

short snow
clever wraith
#

like speed it up by running a few threads on it

short snow
#

joe can explain better

patent pivot
#

I'd much rather we set a more sane limit like 10,000

clever wraith
patent pivot
#

I don't think blocking is an issue since we use an executor

clever wraith
#

i made my own executor

patent pivot
clever wraith
#

im not hostile

#

im just saying that no one mentioned any problems with square amount

short snow
#

man, come on, we got got a valid point here

#

because joe knows that better than us, he is the one who manages the hosting and stuff iirc

clever wraith
#

i do not agree that its too much, i can code it better if thats needed

vocal wolf
#

@sleek steppe have you tested output redirection?

short snow
#

it is not code about it, it is about the resources it is burning and slowing down the stuff

clever wraith
#

i said i can code it better

patent pivot
#

I just think that at 10,000 it's nice and still interesting, generating pure noise is just a little weird

balmy sparrow
#

i think as the number of squares get too large, the output image just looks like random grain

short snow
#

ok go and try this, run the command about 100 times on your system, and see your CPU usage

clever wraith
#

just because its not how u want it right now doesnt mean i cant make it better

sleek steppe
#

So the commands that have the in_whitelist decorator are the !ping, !charinfo, !sf, !subscribe, !unsubcribe, !voiceverify, and !raw, and !eval has the not_in_blacklist deco

sleek steppe
short snow
#

..., tried my best to explain it

vocal wolf
#

oh I'm blind

#

lol

clever wraith
patent pivot
#

cool it.

vocal wolf
#

@clever wraith Calm down.

clever wraith
#

i said i can code it better 3 times

#

and i get the same response

#

like what

vocal wolf
#

We heard you the first time, but you saying you can code it better doesn't mean that the number can always be so high.

clever wraith
#

why everyone jumps to a no instead of how to achieve the same result with a better method

#

this is so unmotivating

#

like 1 guy says oh thats too much and then everyone jumps at me

#

really nice supportive group

vocal wolf
#

We're not your enemy.

balmy sparrow
#

nobody is jumping at you, this isn't a fight

clever wraith
patent pivot
#

right, okay, it's clear this conversation is going nowhere. I'm going to summarise my thoughts into a GitHub review and we can continue from there.

vocal wolf
#

I'm hoping you did a fuzzy search in your editor and didn't manually search all of the bot lol

patent pivot
#

lol

vocal wolf
#

I think that's something else, but whatevs

#

wack.

patent pivot
#

alright, github review left

patent pivot
#

unsure

vocal wolf
#

@clever wraith hey, what's going on?

clever wraith
#

im done

vocal wolf
#

why?

clever wraith
#

because i dont get to do what i want

#

its like i come up with an idea and then someone else tells me how to do it

#

im done being some puppet

#

yall can go ahead and make it urself way better and how you want it

#

its like everything right now would be changed

#

the squares, the name, even my fucking variable names are bad

#

like what in the world

patent pivot
#

I'm sorry to hear that you feel like that. The nature of a code review process is that features do get adapted but of course the core idea is still there, just more suited to the project and environment, that is just how open source works.

clever wraith
#

well i dont like open source then

#

there's the conclusion

sleek steppe
#

I'm guessing the PR/issue should get the up for grabs label then...

patent pivot
#

yeah, it can go up for grabs

#

@clever wraith please stop closing the issue, if you aren't interested in implementing it then someone else will.

clever wraith
#

what are you gonna do about it?

patent pivot
#

alright

#

issue is restored and up for grabs for anyone that wants to take it, drop a comment on there and I can assign

vocal wolf
#

@sleek steppe my @stable mountain instance is broken, will review once I wake.

sleek steppe
#

Alright lol

short snow
#

@cold island what should be correct order, you can see the order in the dict of template generation.

cold island
#

The order in aaaaAAAA should be correct

#

but it's weird because other ducks you show seem fine

short snow
#

also that can be mentioned in a separate pr

#

it is unrelated to the current one

#

could u open a issue, or i can do it in a while

cold island
#

I'm not really following this project so feel free to. I don't know under which circumstances it might happen

short snow
#

alright

vale ibex
patent pivot
#

👍

fallen patrol
#

How bad will this impact this server

#

Second, pull requests from first-time contributors will require manual approval from a repository collaborator with write access before any Actions workflows run. When a first-time contributor opens a pull request, they’ll see a message that a maintainer must approve their Actions workflow before it will run.

#

The biggest impact is new prs to lancebot by new people won't be lined upon first run.

sleek steppe
#

I guess it means people who haven't contributed before won't have their code linted until an approval

patent pivot
#

It just means that your initial PR won't get a linting check immediately

#

The solution to which is lint and test locally before pushing to a PR

fallen patrol
#

Which should already be done anyhow

patent pivot
#

Exactly, yeah

#

I assume that our policy system will still run since it's not a GitHub Action

patent pivot
#

wdf?

fallen patrol
#

no idea

patent pivot
#

but I mean that the linting is a github actions job

#

and the policy bot is not

fallen patrol
#

wdf means "what" i suppose

patent pivot
fallen patrol
#

oh

#

yeah

severe tangle
#

The webhooks in #code-of-conduct, they are deleted after the bot sent the message?

sleek steppe
#

I'm pretty sure they're all the same webhook

severe tangle
#

Well, it would be better to get an answer from a dev, because they created it (no offense)

sleek steppe
#

Wdym by dev 🤔

vocal prairie
#

I guess they mean whoever coded that webhook.

severe tangle
#

Like, one of the owners/mods

severe tangle
sleek steppe
#

Clicking on their profiles, they all have the same name and profile pic, so that's my hunch

fallen patrol
#

unlikely

#

yes

#

the webhooks have not been deleted

vocal prairie
#

I believe they were created and managed by @stable mountain.

severe tangle
#

Well I wanted to know, we're they deleted?

#

The webhooks

#

Nothing else

fallen patrol
#

why

#

fwiw, its only one webhook

thorny obsidian
#

We typically only create webhooks for as long as we need them. Having webhooks that aren't needed hanging around isn't usually good practice

fallen patrol
#

there's at least 3 in this server

thorny obsidian
#

typically

fallen patrol
#

as long as we need them

thorny obsidian
#

Yeah, usually we only have webhooks for as long as we need them, but there are some situations where they hang around a bit longer. Hence my usage of the word typically

patent pivot
#

all the webhooks we have right now are required, yeah

fallen patrol
#

!guild

stable mountainBOT
#
Server Information

Created: 4 years, 3 months and 15 days ago
Voice region: europe
Features: INVITE_SPLASH, PARTNERED, PREVIEW_ENABLED, COMMUNITY, VANITY_URL, WELCOME_SCREEN_ENABLED, MEMBER_VERIFICATION_GATE_ENABLED, RELAY_ENABLED, BANNER, VIP_REGIONS, NEWS, ANIMATED_ICON, DISCOVERABLE
Roles: 80
Member status: status_online 50142 status_offline 131814

Members: 181957

Helpers: 102
Moderators: 27
Admins: 15
Owners: 3
Contributors: 38

Channels: 215

Category: 27
News: 11
Staff: 61
Text: 106
Voice: 10

fallen patrol
#

RELAY_ENABLED

#

seems related to the lag here today

#

since some other servers im in aren't lagging at all today

patent pivot
fallen patrol
#

since when

patent pivot
#

since i asked

#

lol

remote abyss
#

Is it just me or is the python bot being verrry slow today

#

Or is it just discord

vocal wolf
#

This server specifically is a bit slow today

fallen patrol
vocal wolf
#

oof

fallen patrol
remote abyss
#

Maybe it's due to the sharks chewing the internet lines in the ocean flushsit

sleek steppe
fallen patrol
#

because technically the latency isn't impacted

#

in dms

#

everything is instant as normal

#

around 2 seconds per api call per user synchronously
meaning:
every api call is blocking on a per user basis. Ex. trying to send a message takes 2 seconds and then it will take the next message and take 2 seconds to process that and so on. Its a very interesting issue.

fallen patrol
#

gone

#

now

vocal wolf
#

is it?

#

oh sick

patent pivot
#

lol, called it

fervent sage
#

Is it intentional that tags can be triggered even if there's an extra trailing character? For example !start triggers the star tag, as does !stare and !stark

fallen patrol
#

@patent pivot how 2 configure local

#

Uh

fallen patrol
#

ex graphena.pythondiscord.local
How is that done

patent pivot
#

uhhhh

#

a local grafana instance?

#

do you mean grafana or graphite

short snow
#

alec there is a pr for you to review 🙃

fervent sage
short snow
#

and we have another bug to solve

fervent sage
short snow
#

zig's comment

#

lol ig

fervent sage
#

poor duck

#

ok i'm only on my computer for the next few minutes so i dont think i can do the review justice in that time

#

!remind 8h quackstack#37

stable mountainBOT
#
Can do!

Your reminder will arrive in 8 hours!

dusky shoreBOT
short snow
#

ok cool, standard 8h time you got i c 😛

fervent sage
#

some day for the hell of it i'm gonna make a reminder like !remind 21600s do something just so people are like "tf how do you remember that"

#

to which the answer is: that's the longest possible slowmode duration in seconds

sharp timber
#

lol

cold island
vocal wolf
#

@ashen isle please update these PRs when you're able to: bot#1520 and bot#1517.

dusky shoreBOT
vocal wolf
#

@green oriole I have no idea how I missed that line lol, I thought it said something else I guess

#

mentioned/linked once is enough imo, should be good to go.

green oriole
#

A'ight

#

Let's merge it then

#

Also @gritty wind, new PR template merged ducky_party

vocal wolf
green oriole
#

Ah

#

Well

#

That's pretty minor tbh

#

Will address that later today

vocal wolf
#

thank

green oriole
#

!remind 6h Escape Xith's deadly poking

stable mountainBOT
#
Can do!

Your reminder will arrive in 6 hours!

short snow
short snow
#

ok yeah

remote wigeon
#

for discord handled slowmode that is

#

you can still enforce longer slowmode using bots

short snow
#

why not more pithink

#

oh

remote wigeon
#

why would you need more

short snow
#

🤷, for standup channels where you need one msg per day?
off topic

fallen patrol
patent pivot
#

for what

#

I'm confused as to what the question is

#

oh how to add subdomains? Right

#

uhhh

fallen patrol
#

How did you set up sub.pythondiscord.local

patent pivot
#

Linux / Mac / Windows?

fallen patrol
#

Linux

patent pivot
#

/etc/hosts

#

man hosts

fallen patrol
#

And will that work even over a network?

patent pivot
#

so you add a line like 127.0.0.1 pythondiscord.local

#

no

#

it's only for the single machine

#

it can point to external addresses if that's what you mean

#

but if you want it on a network you need to host a DNS server and configure it on each device / set the DNS of the router

fallen patrol
#

Because I can get pythondiscord.local to work, just not a sub domain to work over the network.

#

Ah.

patent pivot
#

yeah you need to run something like BIND or unbound for that level of DNS granularity

fallen patrol
#

Okay

#

Thanks.

#

:(

patent pivot
#

What use case are you trying to go for?

fallen patrol
#

Was trying to make a sub domain on my pi to use for an external service lol

#

Nothing that a / can't do.

#

Just gave it a /servicename/ and made nginx proxy the request anyhow so it's eaten by nginx

green oriole
#

If you are on a local network some modem can intercept DNS requests and return a local url

fallen patrol
#

Yeah

#

I can't access the config of it :(

#

Like, it's hard coded dns on it

low robin
#

can someone help me with Json files

fallen patrol
#

75.75.76.76

fallen patrol
green oriole
#

Well

#

In this case there isn't much you can do without actually modifying the network

fallen patrol
#

Yeah

#

Took a long time to get it to where it is now so I'm kinda glad I can't make it a subdomain

#

Like

#

I spent hours trying to make it add a header since it's unintuitive

#

NO:```nginx
proxy_set_header Header stuff;
proxy_pass url;

YES:```nginx
proxy_pass url;
proxy_set_header Header stuff;
stable mountainBOT
#

@green oriole

It has arrived!

Here's your reminder: Escape Xith's deadly poking.
[Jump back to when you created the reminder](#dev-contrib message)

green oriole
#

run!

#

NGL this is a long test name test_create_user_embed_uses_string_representation_of_user_in_title_if_nick_is_not_available

sharp timber
#

test_create_user_embed_nick_unavailable still long but maybe better?

stable mountainBOT
#

@fervent sage

It has arrived!

Here's your reminder: quackstack#37.
[Jump back to when you created the reminder](#dev-contrib message)

fervent sage
stable mountainBOT
#
Sure.

Your reminder will arrive in 3 hours!

fallen patrol
#

Has the dutie cog been deployed?

green oriole
#

yes

stable mountainBOT
#

@fervent sage

It has arrived!

Here's your reminder: procrastinate [#dev-contrib message](/guild/267624335836053506/channel/635950537262759947/).
[Jump back to when you created the reminder](#dev-contrib message)

fervent sage
stable mountainBOT
#
Alright.

Your reminder will arrive in 12 hours!

fallen patrol
stable mountainBOT
#
You're the boss!

Your reminder will arrive in 1 day!

fallen patrol
#

what happened

#

why has offtopic names started looping from the start again?

stable mountainBOT
#

@fervent sage

It has arrived!

Here's your reminder: seriously do quackstack pr [#dev-contrib message](/guild/267624335836053506/channel/635950537262759947/).
[Jump back to when you created the reminder](#dev-contrib message)

deft patrol
#

😅

fervent sage
#

@short snow #37 merged

cold island
#

this one

static canyon
#

You can tell by the fact it was merged an 1 hour ago by vco

#

The other ones are ages ago (2018)

short snow
#

And get someone to make a pet leash

ashen isle
short snow
#

Maybe we should create a small script for viewing tags, it would be easier for contributors

#

With just the tags

#

A simple bot or something like that

ashen isle
#

actually i don't have to load the bot i can just steal the code that makes the embeds and splice that into my own bot 👀

#

whatever

short snow
#

Yes that’s it

vocal wolf
ashen isle
#

mhm

short snow
#

Why would u need that if u have a bot up

fervent sage
#

i just paste the content into chat and use my bot's eval to get the content and stick it in an embed

short snow
#

Just put the Markdown file and done

#

Yeah, just a bot with eval command

#

Btw Alec do u know why the bill’s layer is wrong, I am using the same layer formats as aaaaAAAA

fervent sage
#

no idea Hmmmm

short snow
#

Found it

#

The problem is with the bill itself

#

@crude gyro would you like u fix it as u have committed it?

crude gyro
#

I don't have time for a while. what's the problem?

#

@short snow

short snow
crude gyro
#

it's being rendered incorrectly

#

wrong order

#

bill is supposed to be rendered under the head

#

I believe I documented the order quite well

short snow
#

I will do that

crude gyro
#

there's a readme in the duck-builder folder

#

should be easy to find

#

but the bill is the bottom layer, below everything else

short snow
#

Yeah found it

crude gyro
#

if you get the order right it'll look good

short snow
#

👍 thanks

#

@fervent sage should I refactor, or whatever u call it, the duck generator code according to manduck, it has some repetitive code like the 400 error

#

Like the same way of generating templates and stuff

shut aspen
#

so the bot makes requests to the site for data persistence etc, my question is why was that architecture chosen and has it worked well or do you regret it

#

im in the beginning stages of designing a website for my bot

patent pivot
#

I think that not having to roll an ORM on bot has been a pretty great help

green oriole
#

With Redis it is a good design solution in my opinion

patent pivot
#

Yeah, Redis on bot works well

green oriole
#

Without Redis anything that required persistence felt very punishing to setup because you had to make two PRs and stuff

patent pivot
#

but I don't think something like Postgres would

green oriole
#

It would make the bot way more bulky, that's for sure

short snow
#

@green oriole since u asked about this, me and kwzrd had a sort I’d discussion, here #dev-contrib message, do u agree with it? And what tests would u want to have after seeing this

Discord

Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

green oriole
short snow
green oriole
#

Yep

#

Although I disagree with kwrzd here, I think it should go through the on_message handler :P

short snow
#

Hmm, how would I get the link of message to pass it into the on message handler?

shut aspen
#

Do you have some data you don’t send to disk?

green oriole
green oriole
shut aspen
#

That makes sense

green oriole
#

Thanks to async-rediscache it is really easy to do

shut aspen
#

Things like say the help channels state id imagine

shut aspen
#

Does the site also have access to the in mem db

slow steppe
#

how do we feel about improving @dusky shore's "ttt" command by using buttons (the new feature)? Danny has already made an ext for them, so it shouldnt be too hard to migrate.

short snow
#

Could u link Danny’s ext?

slow steppe
#

or at least, when the feature is fully released.

shut aspen
#

Danny just committed the button stuff last night, it’s still pretty wip

#

I read through the whole commit

#

It’s on the interaction branch

short snow
#

Yeah, it can be done when it is released for all platforms

shut aspen
#

Don’t ask me why I’m sitting in the d.py repo late at night 🌛

slow steppe
shut aspen
slow steppe
#

another thing that should be done, is have @stable mountain check if someone is still streaming like 5 min after they lose the role, and if they are the bot moves them to a different vc and back so they stop streaming. This would would prevent things like people streaming for 7 hours and making everyone else lose perms.

twilit juniper
#

Or just ping staff, because if someone is getting help with something and they just get kicked out of the vc it would be kinda annoying.

green oriole
green oriole
shut aspen
green oriole
#

yep

#

both are presistent

shut aspen
#

and both the site and the bot have access to both servers right

green oriole
#

Wdym by servers?

shut aspen
#

pg and redis servers

#

the db servers

green oriole
#

Right, we just run them as containers. Only the site has access to Redis Postgres, only the two bots have access to Redis currently

shut aspen
#

you mean only the site has access to pg?

green oriole
#

Yep

#

I got my wire crossed, woops

shut aspen
#

interesting, makes sense i suppose, alot fo bot data you want to persist is just state and is non relational

green oriole
#

Yup

shut aspen
#

now is this all handled with docker/k8s on a single vm or have you built out a cloud infra

green oriole
#

We use Linode hosted k8s

sleek steppe
#

!remind 5M ` this

stable mountainBOT
#
Okay.

Your reminder will arrive in 5 minutes!

slow steppe
green oriole
#

Reviews are always good, although yours won't count toward the requirements

#

But please don't feel like not reviewing because of that

shut aspen
green oriole
#

We can't ever have enough reviews

shut aspen
#

I’m curious

green oriole
#

I'm afraid our k8s manifests are currently private, I think there were plans to make them public, not sure if it is something we are still going to do (CC @patent pivot)

patent pivot
#

We're most likely not going to, since we do have unannounced things there and the costs outweigh the benefits

shut aspen
#

Ahh ok

green oriole
#

Oh that's a good point

stable mountainBOT
#

@sleek steppe

It has arrived!

Here's your reminder: `` this`.
[Jump back to when you created the reminder](#dev-contrib message)

short snow
green oriole
#

I don't know, that's something you'll have to ask to an admin

sleek steppe
#

I thought it only does it when you use !revokestream

short snow
fallen patrol
patent pivot
#

hmmm

#
pythondiscord=# SELECT used, COUNT(1) FROM api_offtopicchannelname GROUP BY 1;
 used | count
------+-------
 f    |   411
 t    |   710
(2 rows)
#

they won't cycle for another year

#

going by message change logs we've definitely not seen 𝖲𝖢𝖱𝖤𝖠𝖬𝖨𝖭𝖦-𝖲𝖭𝖠𝖪𝖤-𝖢𝖠𝖲𝖤 before

#

it was added on the 21st March and first used today

placid ermine
#

latex unload or something

#

idek at this point

wide elm
#

haha

fallen patrol
#

.latex

fallen patrol
placid ermine
#

it was

fervent sage
placid ermine
#

wHATaBOUTtHISoNEtHOUGH

fervent sage
#

we call that inverted pascal case i think

sleek steppe
fervent sage
stable mountainBOT
#

@fallen patrol

It has arrived!

Here's your reminder: see if alec actually seriously really indeed did quackstack pr [#dev-contrib message](/guild/267624335836053506/channel/635950537262759947/).
[Jump back to when you created the reminder](#dev-contrib message)

sleek steppe
#

yes, he did

fallen patrol
#

Wut why is it put in `

#

I-

vocal prairie
#

quackstack#37

dusky shoreBOT
clever wraith
#

Hey how do you get a duck from quackstack

sleek steppe
#

depends

#

Do you want a manducky or a ducky

clever wraith
#

Is that a post request?

short snow
#

nope

#

just get

#

see /docs

#

to get the swagger ui

clever wraith
#

Huh cause ducky doesn't work

#

Oh thanks

#

That's beautiful

short snow
#

@fervent sage short short pr to review

clever wraith
#

!eval

stable mountainBOT
#
Command Help

!eval [code]
Can also use: e

*Run Python code and get the results.

This command supports multiple lines of code, including code wrapped inside a formatted code
block. Code can be re-evaluated by editing the original message within 10 seconds and
clicking the reaction that subsequently appears.

We've done our best to make this sandboxed, but do let us know if you manage to find an
issue with it!*

clever wraith
#

!eval py import os print(os.listdir())

stable mountainBOT
#

@clever wraith :white_check_mark: Your eval job has completed with return code 0.

['Pipfile.lock', 'Pipfile', 'config', 'snekbox', 'user_base', 'tests', 'LICENSE']
clever wraith
#

!eval ```py
import os
os.system("cd user_base")
print(os.listdir())

stable mountainBOT
#

@clever wraith :white_check_mark: Your eval job has completed with return code 0.

['Pipfile.lock', 'Pipfile', 'config', 'snekbox', 'user_base', 'tests', 'LICENSE']
clever wraith
#

!eval ```py
import os

print(os.listdir("user_base"))

stable mountainBOT
#

@clever wraith :white_check_mark: Your eval job has completed with return code 0.

['lib', 'share', 'bin']
clever wraith
#

print(os.listdir("user_base/lib"))

#

!eval ```py
import os
print(os.listdir("/usr"))

stable mountainBOT
#

@clever wraith :white_check_mark: Your eval job has completed with return code 0.

['local', 'lib']
clever wraith
#

!eval ```py
import os
print(os.listdir("/usr/local"))

stable mountainBOT
#

@clever wraith :white_check_mark: Your eval job has completed with return code 0.

['bin', 'lib']
clever wraith
#

hmmm

gritty wind
#

Hey, please use #bot-commands

clever wraith
#

oh ok

short snow
#

there are some gifs which crash discord, does @stable mountain handle them somehow or it is done manually?

gritty wind
#

It's done manually. Usually it's a link or two that make their way around discord, so we blacklist them pretty quickly. We also have other secret projects in the work, that we may or may not introduce

short snow
#

oh ok.

fallen patrol
#

or /openapi.json to see the entire json of the api

short snow
#

press the button

fervent sage
keen valley
#

Hey @short snow

short snow
short snow
#

#bot-commands message 🐛 bug

sleek steppe
#

I could make a fix for that

#

Just needs to be approved by a code dev

cold island
#

what was expected to happen?

sleek steppe
#

It should probably send an error message when there are zero issues sent

fallen patrol
#

it honestly wouldn't be too hard to maintain the syntax of each

sleek steppe
fallen patrol
sleek steppe
#

Yes it is

#

If we were to move the .issue command into the github group, I would say we would wait for sir-lancebot#597 to be merged so that we would have root_aliases

dusky shoreBOT
vocal prairie
#

I have a question about the site. Why was django-simple-bulma needed? Would a regular import of Bulma not work?

vale ibex
short snow
#

indeed, someone needs to review that pr ducky_lemon

clever wraith
#

Hey @short snow I've been wanting to make something similar to quackstack how did you guys generate the duckies?

short snow
#

PIllow

clever wraith
#

Ah

#

Alright, thanks!

#

.bm 836253663545917481 catstack

fervent sage
#

i thought for a sec that said cactus stack

#

which has funny meaning

sleek steppe
#

lol

fervent sage
#

this is a naturally generating cactus in minecraft, for context

short snow
#

Lol 😂

deft patrol
#

ok

patent pivot
#

Hey folks, a minor change to review policy for bot tags. If a PR only changes tags on the bot it now only needs one review approval by a staff member.

#

You'll know if your PR is eligible since the tag speedrun policy will be marked as pending (example below is eligible)

#

whereas a PR that is not eligible will have tag speedrun marked as skipped

thorny obsidian
#

tag PR go brrrrrrrr

patent pivot
#

exactly that

sleek steppe
#

Oh .github doesn't show up in #dev-log 🤔

patent pivot
sleek steppe
#

ah nice

patent pivot
#

done

fallen patrol
#

where is that edited in?

patent pivot
#

.github

dusky shoreBOT
#
Command Help

.github
Can also use: gh, git

Commands for finding information related to GitHub.

Subcommands:
repository [repo...]
Fetches a repositories' GitHub information.
user <username>
Fetches a user's GitHub information.

patent pivot
#

no i didn't what

fallen patrol
#

yeah

#

you did

#

because its a command and . is the bot prefix

fallen patrol
#

bot/.github or python-discord/.github

#

how does it only work on bot/ then?

patent pivot
#

most of our repos pull from that policy file

fallen patrol
patent pivot
#

wat

fallen patrol
#

but how does the tags only check run on bot/ only?

patent pivot
#

because only bot has a bot/resources folder

fallen patrol
#

.gh sir-lancebot

#

sir-lancebot#1 ffs

dusky shoreBOT
patent pivot
#

actually

#

lancebot might

#

I'll tighten that lock to bot/resources/tags

fallen patrol
patent pivot
#

yeah, i've updated the specifier now

sleek steppe
#

committing to main smh

patent pivot
#

lol

#

arrest me

#

we're probably going to have a similar policy introduced on site when we merge dewikification

thorny obsidian
patent pivot
#

i.e. content changes require different approvals to code changes

brazen charm
#

Any reason it's named resources on the bot if tags are all it currently contains?

fallen patrol
#

because its not

patent pivot
#

yeah, it does contain a few things

fallen patrol
#

and lance is

brazen charm
#

Ah for some reason I remembered it looking like the tag subdir directly

fervent sage
#

!remind 20h make that quackstack issue

stable mountainBOT
#
Yep.

Your reminder will arrive in 20 hours!

fervent sage
#

Ayyy 2021

sleek steppe
#

Nice

fervent sage
#

2022 will come in 2022 lol

sleek steppe
#

#bot-commands ?

vale ibex
sleek steppe
#

There were a good amount of bot commands but they were all deleted

vale ibex
#

oh, I'll check out the log

fallen patrol
#

it was me lol

fallen patrol
thorny obsidian
#

Let's not trial-and-error commands in this channel. The proper channel would be #bot-commands or #sir-lancebot-playground

vale ibex
#

Yea, and if you want to see what correct input looks like you can do !help remind

fallen patrol
#

i got the first one just not the second one because til reminders does not take years

patent pivot
#

cleared up

sleek steppe
#

It would be cool if someone reviewed bot#1531

vocal prairie
patent pivot
#

iirc things such as the js needed to operate bulma components

#

as well as support for things like generating different css packs based on themes

vocal prairie
patent pivot
#

that project is maintained by @crude gyro now though, so he can probably explain it better.

patent pivot
#

it's not supposed to never be used with JS, it's just not like bootstrap where you get CSS + JS

#

so for things like modals, file uploads and other stuff you need JS

vocal prairie
#

Got it. So django-simple-bulma allows you to use the utils and js easily, not specifically the base Bulma package?

patent pivot
#

it provides bulma, with some added QoL features

#

as I said though, lemon understands it better than me

short snow
short snow
#

also i can't seem to replicate the bug, i only get the logging when it is required

#

i.e. the webhook msg is deleted but the incident is just getting resolved/deleted

crude gyro
# vocal prairie Got it. So `django-simple-bulma` allows you to use the utils and js easily, not ...

Okay, so, django-simple-bulma solves a few problems.

  1. Adding a Bulma installation to your repo is a pain in the ass. There's a whole bunch of files that you now need to have in your repo, and even more if you want any of the Bulma-Extensions (which are quite nice). If you want to update Bulma, you have to replace a bunch of files. Gross.
  2. django-simple-bulma reduces that complexity to a single pip install. Everytime we do a new release, we fetch the latest version of Bulma and all the Extensions.
  3. django-simple-bulma also provides best-practice JS for components like dropdowns and modals, so you don't need to write any javascript if you don't want to.
  4. If you want FontAwesome icons (which Bulma uses for a bunch of its examples), we provide you with that, too.
  5. You can also compile your own SCSS files via django-simple-bulma, if you want.
  6. But if you don't like writing CSS, you don't need to. Every single Bulma configuration can be done in the Django settings.py file, so you never have to interact with CSS, SCSS, or JS. You just write template files full of classes.
#

Basically it removes all the friction from using Bulma with Django.

#

but also gives you the flexibility to enable or disable whatever you need. You want to implement dropdowns with your own JS? You can. It's your choice.

short snow
#

@tough imp how do I solve this? I have imported extract_message_links but am not able to pass it, I get this error:

UnboundLocalError: local variable 'extract_message_links' referenced before assignment
#

and also am i doing it the right way?

fallen patrol
#

and different variable names?

short snow
#

hmm, lemme try that lemon_sweat

#

ok cool that works, but pithink

#

if the msg is a incident it would have been awaited once

#

and it is a incident msg :

short snow
#

thanks, the problem was when i redefined the variable, python took that as the variable to be searched for which wasn't defined. So I had two ways to fix this:

  • add global on the imported function
  • renamed the mocked function

I thought the second one was a better way so went ahead with that

mighty raft
#

Hi, beginner to open source here. Wanted to fix a grammatical issue with one of the files. What type of issue should I select while creating a new issue? Please help

vale ibex
#

label it as a bug for now. Once the issue has been raised we can change it if needed 🙂

mighty raft
#

Okay. Thanks

short snow
#

looks like we need to command to make pfp bubble of the first letter 🙃

whole forge
stable mountainBOT
#

bot/exts/backend/sync/_cog.py lines 44 to 59

@Cog.listener()
async def on_guild_role_create(self, role: Role) -> None:
    """Adds newly create role to the database table over the API."""
    if role.guild.id != constants.Guild.id:
        return

    await self.bot.api_client.post(
        'bot/roles',
        json={
            'colour': role.colour.value,
            'id': role.id,
            'name': role.name,
            'permissions': role.permissions.value,
            'position': role.position,
        }
    )```
vocal wolf
#

sick

patent pivot
#

niiiiiiice

#

great work @mossy bluff! 🎉

mossy bluff
#

Thanks everyone 😄

#

Sorry the pr was a bit of a mess though

stable mountainBOT
#

bot/exts/filters/antispam.py lines 1 to 22

import asyncio
import logging
from collections.abc import Mapping
from dataclasses import dataclass, field
from datetime import datetime, timedelta
from operator import itemgetter
from typing import Dict, Iterable, List, Set

from discord import Colour, Member, Message, NotFound, Object, TextChannel
from discord.ext.commands import Cog

from bot import rules
from bot.bot import Bot
from bot.constants import (
    AntiSpam as AntiSpamConfig, Channels,
    Colours, DEBUG_MODE, Event, Filter,
    Guild as GuildConfig, Icons,
    STAFF_ROLES,
)
from bot.converters import Duration
from bot.exts.moderation.modlog import ModLog
from bot.utils.messages import send_attachments```
vocal wolf
#

oh damn

patent pivot
#

hahahha

#

nice

vocal wolf
#

@mossy bluff great PR, thank you for coming back to it after so long lol

#

There's like a gap of 2-3 months

patent pivot
#

this is super neat

placid ermine
#

damn
is it just for pydis repos?

patent pivot
#

you wanna changelog xith?

vocal wolf
#

ye

patent pivot
vocal wolf
#

oh god there's going to be so many people to ping though isn't there

stable mountainBOT
#

Kconfig lines 1 to 10

# SPDX-License-Identifier: GPL-2.0
#
# For a description of the syntax of this configuration file,
# see Documentation/kbuild/kconfig-language.rst.
#
mainmenu "Linux/$(ARCH) $(KERNELVERSION) Kernel Configuration"

source "scripts/Kconfig.include"

source "init/Kconfig"```
placid ermine
#

nice

patent pivot
#

LOL HOW DID THIS HAPPEN???

vocal wolf
#

It's a really old PR

#

ELA has a comment on it

patent pivot
#

right but I don't get why there are so many reviews lmfao

#

I thiiiink

#

lol wow

#

can probably just thank reviewers, vco, mark and pythonic

vocal wolf
#

ye

#

wait what this do

#

ok that feature was yoinked

#

good

patent pivot
#

ya, that's for .gh

#

iirc

#

.gh python-discord/bot

#

.gh repo python-discord/bot

vocal wolf
#

nah I'm talking about the original screenshot in the PR

patent pivot
#

SMH

vocal wolf
#

bot#1028

dusky shoreBOT
vocal wolf
#

second screenshot

patent pivot
#

yeah, we removed it in favour of that

#

.gh repo python-discord/bot

dusky shoreBOT
#
bot

The community bot for the Python Discord community

vocal wolf
#

oh sick

short snow
#

this is a awesome feature nicee

vocal wolf
#

@patent pivot changelog posted.

patent pivot
vocal wolf
#

alright

stable mountainBOT
#

.gitignore lines 2 to 4

__pycache__/
*.py[cod]
*$py.class```
fervent sage
#

this feature is gonna change my life

vocal wolf
#

@patent pivot It is done, but shouldn't the PR do for screenshots?

#

Either way, my screenshot was posted to #changelog.

gritty wind
#

Discord ladies and gentlemen

vocal wolf
#

lol

short snow
#

probably missing a \n after/before the ```

gritty wind
#

It’s not

#

Discord just bugs out

short snow
#

pithink smh

placid ermine
#

#bot-commands message

short snow
#

oof

vocal wolf
#

do we... do we not have a limit?

placid ermine
#

its on char count

#

i think

#

not on lines

short snow
#

i think i tested it here, while xith was typing

#

but 🐛

placid ermine
#

time to abuse this in all channels

#

/s

mossy bluff
#

Oops len(all_snippets) <= 15 should be message_to_send.count('\n') <= 15

#

My bad

short snow
#

looks like there are no checks for length too, hmmm

#

ah nvm, dolph commented, was up in channel history

mossy bluff
#

Discord has a built in 2000 char limit

short snow
#

that is kinda lot and can fill the window

mossy bluff
#

True

patent pivot
#

happy to review a quick PR for that

mossy bluff
#

What should the char limit be?

#

1000?

short snow
#

yep 1000 sounds good, that's what snekbox uses too

fervent sage
#

also a line limit

short snow
#

yeah that's already there, of 15

fervent sage
#

ah right

#

in that case 1k chars doesnt actually seem that high for a block of code tbh

short snow
fervent sage
#

perhaps if it's above 1k redierct it to #bot-commands instead

fervent sage
#

i had an idea last night and assumed i would remember it

#

evidently i havent

short snow
#

no lemon facepalm emojis lemon_pensive

#

one more thing, about quackstack you missed

#

lemme get the linik

placid ermine
#

bruh moment

short snow
fervent sage
short snow
#

you think a lot ducky_lemon

#

lol

fervent sage
#

as someone who thinks a lot im clearly not very good at it lmao

#

HOWEVER i have just remembered i need to make a randomspace font which is basically the opposite of monospace

#

it will be awful™️

balmy sparrow
#

why no

#

dont

fervent sage
#

blame last night's vc

#

they suggested it

balmy sparrow
#

you're at a high after cyeethon

#

don't do this

whole forge
#

vco
what you need
is a very very good way of taking notes

fervent sage
#

normally i just use a reminder and it reminds me and i remember

#

but sometimes im dumb and i dont actually stick the useful part of the information in the reminder

short snow
#

sticky notes

#

i always use them

#

or a whiteboard, i have on my table

fervent sage
#

god i'd love a whiteboard

whole forge
#

i want a whiteboard

#

yes

fervent sage
#

theyre so satisfying to just... yes... whiteboard cool

short snow
whole forge
#

but i also want a decent minimal kanban

#

i have my eyes on focalboard rn

fervent sage
short snow
#

to include the new features?

#

idk

whole forge
vocal prairie
fervent sage
#

@sleek steppe you can receive message events before the cache is filled

sleek steppe
#

I thought you received guild create before message create 🤔

fervent sage
mighty raft
mighty raft
#

Guys, thanks a lot for approving lemon_pleased

green oriole
#

Quick tip if you are working on the bot using Docker: Using docker-compose up bot when starting it up will mean that only the bot container will be brought down when you'll press CTRL + C, making the shutdown and the next restart way faster

vocal prairie
#

Does the same work for site and sir-lancebot?

whole forge
vocal prairie
#

Cool, thanks for the tip!

short snow
#

No deps are not needed particular

stable mountainBOT
#

@fervent sage

It has arrived!

Here's your reminder: make that quackstack issue.
[Jump back to when you created the reminder](#dev-contrib message)

short snow
#

Lol

patent pivot
#

what is your username?

#

I only see these

#

know which repo it was on?

#

these are the ones you've commented on

short snow
#

You got a pr assigned to you

#

About blocking tag

sleek steppe
#

bot#1410

dusky shoreBOT
patent pivot
#

aha! all good, no worries!

cold moon
#

I think this is Merge Request in GL?

patent pivot
#

It is yeah

#

it's a request to pull changes onto the main branch of a project, so it kinda makes sense

#

but yeah, merge request is a nice phrasing as well

vocal prairie
#

Push request sounds good too

green oriole
#

It comes from the time when you would actually use git pull to incorporate contributions into your project

placid ermine
#

there's an SO post about this

green oriole
#

Could be a Patch Apply Request, could be worse