#dev-contrib | Python | Page 104

vale ibex Apr 18, 2021, 2:51 PM

#

Try doing git add . then pipenv run pre-commit

#

make sure your pipenv shell is active though

clever wraith Apr 18, 2021, 2:51 PM

#

how do i activate it?

vale ibex Apr 18, 2021, 2:51 PM

#

py -m pipenv shell

clever wraith Apr 18, 2021, 2:52 PM

#

ok ty

#

C:\Users\VIncas\Desktop\sir-lancebot>py -m pipenv shell
Loading .env environment variables...
Launching subshell in virtual environment...
Microsoft Windows [Version 10.0.19042.928]
(c) Microsoft Corporation. All rights reserved.

(sir-lancebot-1zef5-9i) C:\Users\VIncas\Desktop\sir-lancebot>git add .

(sir-lancebot-1zef5-9i) C:\Users\VIncas\Desktop\sir-lancebot>pipenv run pre-commit
'pipenv' is not recognized as an internal or external command,
operable program or batch file.``` still unrecognized

vale ibex Apr 18, 2021, 2:53 PM

#

oh, look like pipenv deps weren't installed on your pipenv shell

#

ok, so with your pipenv she;l active run these commands:
python -m pip install pipenv
pipenv sync --dev
pipenv run precommit

clever wraith Apr 18, 2021, 2:54 PM

#

ok

vale ibex Apr 18, 2021, 2:54 PM

#

that will setup your pipenv shell

clever wraith Apr 18, 2021, 2:54 PM

#

thanks for helping

#

ok so all those commands worked

#

no errors

#

should i do git add . and then commit?

vale ibex Apr 18, 2021, 2:56 PM

#

so you've already done git add .

#

so its in the staging area

clever wraith Apr 18, 2021, 2:56 PM

#

oh ok

vale ibex Apr 18, 2021, 2:56 PM

#

you should be able to do pipenv run pre-commit

clever wraith Apr 18, 2021, 2:56 PM

#

yeah i did it

#

vale ibex Apr 18, 2021, 2:56 PM

#

There's two precommit is for setting it up pre-commit is for running

#

you only need to do precommit once

clever wraith Apr 18, 2021, 2:57 PM

#

oh

#

ok im running the pipenv run pre-commit now

vale ibex Apr 18, 2021, 2:57 PM

#

cool

#

it'll give you any linting errors

clever wraith Apr 18, 2021, 2:58 PM

#

i got some errors from my cog

#

but they're not really errors

#

its like D204 1 blank line required after class docstring

#

should i patch them all up right now?

vale ibex Apr 18, 2021, 2:59 PM

#

Yea, those are our styling requirements

clever wraith Apr 18, 2021, 2:59 PM

#

ok

vale ibex Apr 18, 2021, 2:59 PM

#

fix them all up, run git add . and then run the pre-commit again

clever wraith Apr 18, 2021, 3:03 PM

#

after the -> its the return type?

#

def join_images(imgs: list) -> Image:```

#

this func returns Image so i put that, dont know if its correct tho

vale ibex Apr 18, 2021, 3:05 PM

#

Yup, that's exactly right

#

(as long as you have Image imported)

clever wraith Apr 18, 2021, 3:06 PM

#

ye ye

#

ok fixed all those up

#

and no styling errors occurred this time

vale ibex Apr 18, 2021, 3:07 PM

#

Nice, everything passed?

clever wraith Apr 18, 2021, 3:07 PM

#

yep

#

Loading .env environment variables...
Check for merge conflicts................................................Passed
Check Toml...........................................(no files to check)Skipped
Check Yaml...........................................(no files to check)Skipped
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
check blanket noqa.......................................................Passed
Flake8...................................................................Passed```

vale ibex Apr 18, 2021, 3:07 PM

#

Cool! now you can commit your local code to your branch

clever wraith Apr 18, 2021, 3:08 PM

#

ok

#

git commit -m "Your commit message" like that?

vale ibex Apr 18, 2021, 3:08 PM

#

If you do ```
git commit -m "commit title here

commit summary here
over some lines if needed"

#

Yea, the title should be limited to 72 characters

#

the summary can be as long as you like

clever wraith Apr 18, 2021, 3:09 PM

#

is it enough to just say: Adding new cog - splitify?

vale ibex Apr 18, 2021, 3:11 PM

#

We usually prefer a little more information that than in the commit

clever wraith Apr 18, 2021, 3:11 PM

#

oh ok

vale ibex Apr 18, 2021, 3:11 PM

#

The commit title could be that, but the commit should have a summary

#

We've got a writeup here https://pythondiscord.com/pages/contributing/contributing-guidelines/supplemental-information/#writing-good-commit-messages

Python Discord | Supplemental Information

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

We also link to Chris Beam's How to Write a Git Commit Message blog post too, which is some good reading

clever wraith Apr 18, 2021, 3:12 PM

#

yeah im looking at it right now

#

i-

#

i think i messed it up a bit

#

i was trying to write from new line and i think i accidentally commited

sleek steppe Apr 18, 2021, 3:18 PM

#

You can always do git reset HEAD^

clever wraith Apr 18, 2021, 3:19 PM

#

oh then i add the rest of the message?

#

nvm im prob wrong

sleek steppe Apr 18, 2021, 3:20 PM

#

It just takes away the last commit

clever wraith Apr 18, 2021, 3:20 PM

#

ok

#

so how do i do newline?

clever wraith Apr 18, 2021, 3:20 PM

#

vale ibex If you do ``` git commit -m "commit title here commit summary here over some li...

i was trying to follow this

sleek steppe Apr 18, 2021, 3:21 PM

#

Just don't end the quote

clever wraith Apr 18, 2021, 3:21 PM

#

yeah i didnt

#

Check for merge conflicts................................................Passed
Check Toml...........................................(no files to check)Skipped
Check Yaml...........................................(no files to check)Skipped
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
check blanket noqa.......................................................Passed
Flake8...................................................................Passed
[splitify b76aef0] Adding new cog - splitify
 1 file changed, 131 insertions(+)
 create mode 100644 bot/exts/evergreen/splitify.py```

#

you see i didnt there and it still did all of this

sleek steppe Apr 18, 2021, 3:22 PM

#

Hmm

clever wraith Apr 18, 2021, 3:23 PM

#

i could just do git commit -m "Adding new cog - splitify. Summary: Merged splitifer and a discord command for it together, added neat descriptions for each function and the discord command, fixed all the styling errors."

#

in 1 line i mean

sleek steppe Apr 18, 2021, 3:23 PM

#

That's too long for the commit title

clever wraith Apr 18, 2021, 3:24 PM

#

oh is a title an actual thing?

#

i thought its just what you guys call it

green oriole Apr 18, 2021, 3:25 PM

#

You should try without the -m option

clever wraith Apr 18, 2021, 3:25 PM

#

ok

green oriole Apr 18, 2021, 3:25 PM

#

It will open your editor for you to type a message

clever wraith Apr 18, 2021, 3:25 PM

#

``` got this now

green oriole Apr 18, 2021, 3:25 PM

#

On the first line you have to put a summary (less than 50 chars), and empty line and then the extended description

green oriole Apr 18, 2021, 3:26 PM

#

clever wraith ```error: pathspec 'Adding new cog - splitify' did not match any file(s) known t...

Just run git commit

clever wraith Apr 18, 2021, 3:26 PM

#

ok

#

Check for merge conflicts............................(no files to check)Skipped
Check Toml...........................................(no files to check)Skipped
Check Yaml...........................................(no files to check)Skipped
Fix End of Files.....................................(no files to check)Skipped
Trim Trailing Whitespace.............................(no files to check)Skipped
check blanket noqa...................................(no files to check)Skipped
Flake8...............................................(no files to check)Skipped
On branch splitify
nothing to commit, working tree clean```

#

it still ran, didnt let me write anything

clever wraith Apr 18, 2021, 3:27 PM

#

green oriole Just run `git commit`

.

green oriole Apr 18, 2021, 3:28 PM

#

Ah, you didn't select anything to commit

#

You can run git status to see what you modified

clever wraith Apr 18, 2021, 3:28 PM

#

On branch splitify
nothing to commit, working tree clean```

green oriole Apr 18, 2021, 3:28 PM

#

Then git add [path] to add the file in [path]

#

Hmm

#

Did you modified anything yet?

clever wraith Apr 18, 2021, 3:29 PM

#

its cuz i already committed accidentally

#

when i was trying to do new line

#

and then toxic told me to run some command, i did it, but i guess it didnt help me here

sleek steppe Apr 18, 2021, 3:30 PM

#

sleek steppe You can always do `git reset HEAD^`

This should work ^

clever wraith Apr 18, 2021, 3:30 PM

#

yes i did that

#

what am i suppose to put here?

green oriole Apr 18, 2021, 3:31 PM

#

Right

#

If you want to modify the last commit message you should run git commit --amend

clever wraith Apr 18, 2021, 3:32 PM

#

oh it worked

#

im kinda stuck here, i cant remove that first line there and dont know how to finish this off

clever wraith Apr 18, 2021, 3:37 PM

#

green oriole If you want to modify the last commit message you should run `git commit --amend...

.

green oriole Apr 18, 2021, 3:58 PM

#

That looks like vim, do you know how to use it?

#

Hey @short snow, I mentioned that those were still not addressed because you rerequested our reviews, I assumed that you missed it

clever wraith Apr 18, 2021, 4:10 PM

#

green oriole That looks like vim, do you know how to use it?

i dont know whats vim, no

green oriole Apr 18, 2021, 4:11 PM

#

Hmm that was probably the default

#

I don't know git on windows enough to help you change it though, sorry

clever wraith Apr 18, 2021, 4:12 PM

#

could i maybe commit with just the title and add the summary somewhere else then?

green oriole Apr 18, 2021, 4:15 PM

#

Hmm you can do git commit -m "First line" -m "extended description"

clever wraith Apr 18, 2021, 4:15 PM

#

ok

#

it says that im working on a clean tree

#

i tried git reset HEAD^

#

and it then says: More? and i dont know what to put there

#

i tried putting the whole commit there but an error occurred

clever wraith Apr 18, 2021, 4:22 PM

#

green oriole Hmm you can do `git commit -m "First line" -m "extended description"`

.

wise oriole Apr 18, 2021, 4:37 PM

#

I'm confused.

#

gimme a min lemme send one thing.

#

look at that?

#

I just typed it

#

did you mean is suggesting the same thing I sent.
!help reason

#

whats it supposed to show btw

subtle kraken Apr 18, 2021, 4:43 PM

#

pretty sure its !remind edit reason command that you got suggested

#

currently suggestion takes whatever name matches regardless if its top level command or not which results in recommending subcommands without telling what the top command is

sleek steppe Apr 18, 2021, 5:20 PM

#

!source ErrorHandler

stable mountainBOT Apr 18, 2021, 5:20 PM

#

Cog: ErrorHandler

Handles errors emitted from commands.

Source Code

Go to GitHub

sleek steppe Apr 18, 2021, 5:22 PM

#

Ah it just replaces the misspelled command with the command's name

patent pivot Apr 18, 2021, 6:46 PM

#

I have just the document for you

#

where is it

gritty wind Apr 18, 2021, 6:46 PM

#

Yeah hemlock and Akarys wrote one

#

it's on the main contrib page

patent pivot Apr 18, 2021, 6:46 PM

#

https://pythondiscord.com/pages/resources/guides/code-reviews-primer/

Python Discord | Code Reviews: A Primer

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

green oriole Apr 18, 2021, 6:48 PM

#

Did we ever #dev-announcementsed it?

gritty wind Apr 18, 2021, 6:52 PM

#

yup

tawdry vapor Apr 18, 2021, 6:52 PM

#

Yes, you don't need any permission to leave reviews.

#

Just pick something you're comfortable with and have at it.

#

Yes

gritty wind Apr 18, 2021, 6:54 PM

#

Yeah that's valid

sleek steppe Apr 18, 2021, 7:02 PM

#

lol

green oriole Apr 18, 2021, 7:03 PM

#

haha

#

do you want a suggestion?

#

Alright, any favorite project?

#

https://github.com/python-discord/bot/pull/1426 this one should work

GitHub

Add bot and verified bot badges to the user embed. by Akarys42 · Pu...

This PR adds a bot tag in the embed title if the user is a bot, and properly handles the verified bot tag.
Here is how it looks with both badges:

Closes #1365.

clever wraith Apr 18, 2021, 7:04 PM

#

@green oriole dont want to annoy you, but are you able to help me now?

sleek steppe Apr 18, 2021, 7:05 PM

#

What do you need help with?

clever wraith Apr 18, 2021, 7:05 PM

#

the same thing with commiting

sleek steppe Apr 18, 2021, 7:05 PM

#

ah

clever wraith Apr 18, 2021, 7:06 PM

#

i think i already committed it, but i didnt include the summary

#

its kind of a mess ngl

sleek steppe Apr 18, 2021, 7:07 PM

#

Hmm. Is it really worth putting a summary? Can't you just write it in the PR description?

clever wraith Apr 18, 2021, 7:07 PM

#

not me to ask

#

i actually even offered to do that

#

or something alike that

clever wraith Apr 18, 2021, 7:08 PM

#

clever wraith could i maybe commit with just the title and add the summary somewhere else then...

there

brazen charm Apr 18, 2021, 7:08 PM

#

Don't need to write anything

sleek steppe Apr 18, 2021, 7:09 PM

#

yep ✅

clever wraith Apr 18, 2021, 7:09 PM

#

btw what happens after i commit

#

like does the code get sent somewhere or..

sleek steppe Apr 18, 2021, 7:10 PM

#

You need to push

fallen patrol Apr 18, 2021, 7:10 PM

#

not staff i think

clever wraith Apr 18, 2021, 7:10 PM

#

oh...

brazen charm Apr 18, 2021, 7:10 PM

#

When you commit it, it gets locally saved into the git history of the project. Then you can push it to the remote where it does the same thing but also goes to the PR etc.

sleek steppe Apr 18, 2021, 7:10 PM

#

Because the approval doesn't actually count for the checks

fallen patrol Apr 18, 2021, 7:11 PM

#

brazen charm When you commit it, it gets locally saved into the git history of the project. T...

git is fun!

#

there's before you do anything

sleek steppe Apr 18, 2021, 7:11 PM

#

same xd

clever wraith Apr 18, 2021, 7:11 PM

#

brazen charm When you commit it, it gets locally saved into the git history of the project. T...

so i have committed it alrd but i didnt put the summary in the commit, can i just push now?

fallen patrol Apr 18, 2021, 7:12 PM

#

there's before you do anything
then working tree edits
then index/staged changes
then commit to local repo
then push to remote

fallen patrol Apr 18, 2021, 7:12 PM

#

sleek steppe same xd

idk, some people became staff after only a few weeks zoomEyes

brazen charm Apr 18, 2021, 7:12 PM

#

It does count towards the checks afaik, but you're not a member of the repo so github doesn't regard them as of the same level of importance. For example if you disapproved then a member disapproval would block the PR while a non member disapproval is more of a comment

sleek steppe Apr 18, 2021, 7:12 PM

#

fallen patrol idk, some people became staff after only a few weeks <a:zoomEyes:544960568709349...

lol

brazen charm Apr 18, 2021, 7:12 PM

#

sorry, organization

#

https://github.com/orgs/python-discord/people; a contributor is anyone who contributed to the project, even when not a member of the pydis org

fallen patrol Apr 18, 2021, 7:14 PM

#

brazen charm <https://github.com/orgs/python-discord/people>; a contributor is anyone who con...

hehe

#

i have the contributor tag on python because i made a permission change to defcon

#

added connect=False to disable voice channels when defcon is turned on

#

and connect=True when its turned off

patent pivot Apr 18, 2021, 7:15 PM

#

anyone with the contributors role can leave an approving review, though github may not always green tick it

fallen patrol Apr 18, 2021, 7:15 PM

#

which is set in the organization defaults

patent pivot Apr 18, 2021, 7:15 PM

#

https://github.com/python-discord/.github/blob/main/review-policies/core-developers.yml

GitHub

python-discord/.github

Organisation defaults. Contribute to python-discord/.github development by creating an account on GitHub.

fallen patrol Apr 18, 2021, 7:15 PM

#

.github#1

dusky shoreBOT Apr 18, 2021, 7:15 PM

#

GitHub

PRMerged Create cat thanker

fallen patrol Apr 18, 2021, 7:15 PM

#

https://github.com/python-discord/.github/blob/e6eb0cfdbd2493b377c3ca000d1f9f16f276b806/review-policies/core-developers.yml#L37-L47

GitHub

python-discord/.github

Organisation defaults. Contribute to python-discord/.github development by creating an account on GitHub.

fallen patrol Apr 18, 2021, 7:16 PM

#

dusky shore

ignore this ty

patent pivot Apr 18, 2021, 7:16 PM

#

I just linked it lol

fallen patrol Apr 18, 2021, 7:16 PM

#

patent pivot I just linked it lol

i linked exact lines lol

clever wraith Apr 18, 2021, 7:17 PM

#

if i have committed smth already but i didnt put the summary in the commit, can i still push now and put it in pr description?

patent pivot Apr 18, 2021, 7:17 PM

#

does anyone want to add an is deleted channel attribute to metricity channels

brazen charm Apr 18, 2021, 7:17 PM

#

patent pivot anyone with the contributors role can leave an approving review, though github m...

Ah, how are reviews from people outside of the server contribs and the org regarded with the new system?

brazen charm Apr 18, 2021, 7:18 PM

#

clever wraith so i have committed it alrd but i didnt put the summary in the commit, can i jus...

If you think the summary is necessary then you can ammend the description which will replace the old commit with a new one with an updated body, otherwise you can just push it

clever wraith Apr 18, 2021, 7:18 PM

#

i tried so many ways and everything failed

patent pivot Apr 18, 2021, 7:18 PM

#

brazen charm Ah, how are reviews from people outside of the server contribs and the org regar...

I can add names there, it's just generally easier to lock it to a Discord role since I can periodically assess it. I'm very much happy to add you to that policy though.

clever wraith Apr 18, 2021, 7:19 PM

#

and summary i dont think is necessary or that important since im just adding something for the first time

#

so there's no changes

sleek steppe Apr 18, 2021, 7:19 PM

#

If no one is assigned

tawdry vapor Apr 18, 2021, 7:19 PM

#

If it's taken then someone would have commented or it would've been assigned to some user (listed at the right column)

#

I'm not sure there's a consensus yet on that issue

brazen charm Apr 18, 2021, 7:22 PM

#

patent pivot I can add names there, it's just generally easier to lock it to a Discord role s...

Not necessary, I was more curious about how a new contrib would be viewed by the system and core devs when merging

patent pivot Apr 18, 2021, 7:23 PM

#

I'm not sure I follow, the groups that can leave an approving review are those with the discord contributors role and those in the staff team, additionally there must be at least one core developer review on top of that.

tawdry vapor Apr 18, 2021, 7:24 PM

#

Yes. Do you want me to assign you to it?

#

What's your username on GitHub

#

Yeah, please. It seems I can't assign you to it through GH. Probably cause you've not contributed anything yet.

#

Yeah, your comment made your name show up in the list.

clever wraith Apr 18, 2021, 7:27 PM

#

@brazen charm i pushed it

sleek steppe Apr 18, 2021, 7:30 PM

#

Now you can write up a PR

clever wraith Apr 18, 2021, 7:30 PM

#

oh shit i pushed from the wrong github account

#

my god...

#

this was not meant for me

#

too many signs ive missed... 😭

#

can i still continue right now

brazen charm Apr 18, 2021, 7:37 PM

#

patent pivot I'm not sure I follow, the groups that can leave an approving review are those w...

I was comparing it with the previous system with the bot that added tags around which seemed to count reviews from anyone for its count, with requiring reviews beyond that left to the person merging it

patent pivot Apr 18, 2021, 7:38 PM

#

ahh right, yeah that was just a pure count of how many reviews there were on the PR, the new one now will only mark the check as green when the full policies are met (hence why we disabled the github feature and now go purely off the check status)

clever wraith Apr 18, 2021, 7:39 PM

#

ok so i made the pr and somehow it was successful

brazen charm Apr 18, 2021, 7:39 PM

#

Can the bot be overridden if you had for example 1 missing contrib/member review but multiple approvals from people outside of that?

patent pivot Apr 18, 2021, 7:40 PM

#

Bypasses can be made by owners, yep

sleek steppe Apr 18, 2021, 7:42 PM

#

They should already be filled out if you copied the config-default.yml. The guide shows what parts need to change in order for the bot to actually be ran, like for example the site domain.

fallen patrol Apr 18, 2021, 7:45 PM

#

e

clever wraith Apr 18, 2021, 7:45 PM

#

how long does it usually take for a pr to be checked

fallen patrol Apr 18, 2021, 7:45 PM

#

sir-lancebot#688

dusky shoreBOT Apr 18, 2021, 7:46 PM

#

GitHub

PROpen Adding new cog - splitify

fallen patrol Apr 18, 2021, 7:46 PM

#

e

#

there's a template for the explanation

clever wraith Apr 18, 2021, 7:46 PM

#

oh thats me

fallen patrol Apr 18, 2021, 7:47 PM

#

fallen patrol there's a template for the explanation

## Relevant Issues
<!-- List relevant issue tickets here. -->
<!-- Say "Closes #0" for issues that the PR resolves, replacing 0 with the issue number. -->


## Description
<!-- Describe how you've implemented your changes. -->


## Reasoning
<!-- Outline the reasoning for how it's been implemented. -->


## Screenshots
<!-- Remove this section if the changes don't impact anything user-facing. -->
<!-- You can add images by just copy pasting them directly in the editor. -->


## Additional Details
<!-- Delete this section if not applicable. -->


## Did you:
<!-- These are required when contributing. -->
<!-- Replace [ ] with [x] to mark items as done. -->

- [ ] Join the [**Python Discord Community**](https://discord.gg/python)?
- [ ] If dependencies have been added or updated, run `pipenv lock`?
- [ ] **Lint your code** (`pipenv run lint`)?

brazen charm Apr 18, 2021, 7:47 PM

#

You don't really need anything except the trashcan in most cases

fallen patrol Apr 18, 2021, 7:48 PM

#

fallen patrol ```md ## Relevant Issues  <!-- Say "Cl...

@clever wraith edit your pr to use this

sleek steppe Apr 18, 2021, 7:48 PM

#

Unless the PR has something to do with emojis

clever wraith Apr 18, 2021, 7:49 PM

#

fallen patrol <@456226577798135808> edit your pr to use this

but it doesnt have any of those things

#

there are no issues, no changes or anything really

#

its just a description and i title that i put there

fallen patrol Apr 18, 2021, 7:50 PM

#

reference to a previous set thing

#

so it can reference those variables later down

sleek steppe Apr 18, 2021, 7:50 PM

#

clever wraith there are no issues, no changes or anything really

You opened an issue for that command. You added a new command to sir-lancebot.

fallen patrol Apr 18, 2021, 7:50 PM

#

clever wraith its just a description and i title that i put there

riiiight. you have to use the template tho

clever wraith Apr 18, 2021, 7:50 PM

#

so what will i put there?

sleek steppe Apr 18, 2021, 7:51 PM

#

And it would be useful to see screenshots for that command

clever wraith Apr 18, 2021, 7:51 PM

#

oh well that i could

patent pivot Apr 18, 2021, 7:57 PM

#

It should be up to date, which bits do you think are missing?

#

We have merged a few channels together, such as merging logs into one channel

brazen charm Apr 18, 2021, 7:58 PM

#

What are you implementing? I doubt you'll need to set the modmail category

clever wraith Apr 18, 2021, 7:58 PM

#

fallen patrol riiiight. you have to use the template tho

done

brazen charm Apr 18, 2021, 8:00 PM

#

If the bot never uses them then it'll work fine, there are only a few channels/categories that it'll have to fetch without you explicitly doing something to create the request

sleek steppe Apr 18, 2021, 8:00 PM

#

You don't

#

Not really. Maybe just a log message

#

You could set up the config file, but a lot of it you wouldn't need at this point

brazen charm Apr 18, 2021, 8:05 PM

#

Can't go wrong with filling it out all, but I'd probably just run the bot and add values that it errors out on

clever wraith Apr 18, 2021, 8:05 PM

#

how long does it usually take for a pr to be checked

gritty wind Apr 18, 2021, 8:05 PM

#

It depends on the length of the PR, and who's available

clever wraith Apr 18, 2021, 8:06 PM

#

ok

gritty wind Apr 18, 2021, 8:06 PM

#

usually triaged pretty quickly, then review depends significantly

vocal prairie Apr 18, 2021, 8:06 PM

#

triaged?

gritty wind Apr 18, 2021, 8:06 PM

#

Triage in programming refers to getting things where they need to be. We do that by assigning tags and priorities

vocal prairie Apr 18, 2021, 8:07 PM

#

Got it. Ty

gritty wind Apr 18, 2021, 8:07 PM

#

Xith is our master triager

sleek steppe Apr 18, 2021, 8:07 PM

#

Why were my review comments duplicated 😩

gritty wind Apr 18, 2021, 8:08 PM

#

lol you should be to resolve the duplicates

clever wraith Apr 18, 2021, 8:09 PM

#

@sleek steppe i cant respond to u on that pr for some reason so can i do it here?

sleek steppe Apr 18, 2021, 8:09 PM

#

I accidentally reloaded the page and lost all of my comments, but they reappeared.

clever wraith Apr 18, 2021, 8:09 PM

#

cuz i have a lot to say

brazen charm Apr 18, 2021, 8:10 PM

#

You should be able to comment on all of the review comments if you're logged in

clever wraith Apr 18, 2021, 8:10 PM

#

it only says resolve convo

#

it let me before but didnt let me then send the reply

#

and after i refreshed the reply button was gone

#

and im logged in

#

@brazen charm

#

oh i see the reply again

brazen charm Apr 18, 2021, 8:13 PM

#

No idea what it could be but responding here would lead to confusion around the discussion

clever wraith Apr 18, 2021, 8:15 PM

#

ok i responded

#

ill do some changes now

sleek steppe Apr 18, 2021, 8:52 PM

#

A lot of PRs have only one commit when the PR is opened

#

The current implementation won't work

#

You'll need to use typing.Optional

#

There's a difference between default arguments and Optional

#

So, basically, you have multiple default arguments. So if I were to do !superstar @user breaking the rules, breaking would be the duration argument and the command will fail

#

https://discordpy.readthedocs.io/en/latest/ext/commands/commands.html#typing-optional Here's what typing.Optional does

#

The second reason it wouldn't work, is because the Expiry converter returns a datetime object, and you're defaulting to a str.

clever wraith Apr 18, 2021, 9:00 PM

#

@sleek steppe are you able to add my cog to the lancebot?

#

hypothetically speaking

sleek steppe Apr 18, 2021, 9:00 PM

#

What do you mean?

#

Nope.

#

You can keep it as Optional, like this ^, and if it's None, make the duration datetime.datetime.now() + datetime.timedelta(hours=1)

clever wraith Apr 18, 2021, 9:03 PM

#

sleek steppe What do you mean?

like approve it or whatever you call it

sleek steppe Apr 18, 2021, 9:03 PM

#

You want me to approve the PR?

clever wraith Apr 18, 2021, 9:13 PM

#

sleek steppe You want me to approve the PR?

im asking if you're able

#

and yes

sleek steppe Apr 18, 2021, 9:13 PM

#

You didn't check if it was None

clever wraith Apr 18, 2021, 9:13 PM

#

i reflected on your comments and made changes

sleek steppe Apr 18, 2021, 9:13 PM

#

clever wraith im asking if you're able

Haven't tested it yet

clever wraith Apr 18, 2021, 9:14 PM

#

can you?

sleek steppe Apr 18, 2021, 9:16 PM

#

yep

#

sure

fallen patrol Apr 18, 2021, 9:23 PM

#

clever wraith <@!506618674921340958> are you able to add my cog to the lancebot?

It gets added automatically on two approving reviews by pydis staff

sleek steppe Apr 18, 2021, 9:24 PM

#

Ah that's what they were asking

clever wraith Apr 18, 2021, 9:24 PM

#

fallen patrol It gets added automatically on two approving reviews by pydis staff

ok

fallen patrol Apr 18, 2021, 10:17 PM

#

wut

#

short snow Apr 19, 2021, 12:47 AM

#

@gritty wind uhh, the tests are working now, i did no change, https://github.com/python-discord/bot/runs/2376723492?check_suite_focus=true#step:10:176

GitHub

Build software better, together

GitHub is where people build software. More than 56 million people use GitHub to discover, fork, and contribute to over 100 million projects.

#

pithink

fallen patrol Apr 19, 2021, 12:54 AM

#

hey

#

i found both an issue and a solution

#

basically, not every embed on the bots are colored and this was previous pointed out

vocal prairie Apr 19, 2021, 1:01 AM

#

fallen patrol basically, not every embed on the bots are colored and this was previous pointed...

And what's the solution?

fallen patrol Apr 19, 2021, 1:01 AM

#

sorry got distracted

#

basically we replace the embed class

#

class Embed(discord.Embed):
    def __init__(self, color=default_color_variable, **attrs):
        attrs["color"] = color
        super().__init__(**attrs)

discord.Embed = Embed

vocal prairie Apr 19, 2021, 1:04 AM

#

Can't you just search for all the embeds?

#

And manually recolor them?

fallen patrol Apr 19, 2021, 1:04 AM

#

which makes more sense, lol

vocal prairie Apr 19, 2021, 1:04 AM

#

It can't be that hard to do a local search.

vocal prairie Apr 19, 2021, 1:04 AM

#

fallen patrol which makes more sense, lol

But why overcomplicate it?

fallen patrol Apr 19, 2021, 1:04 AM

#

its not overcomplicated?

#

it makes all embeds have a default color of the bots specific color or they need to all be changed individually

short snow Apr 19, 2021, 1:07 AM

#

there is already a issue open for embed helper, it somewhat does this part

fallen patrol Apr 19, 2021, 1:08 AM

#

which bot?

short snow Apr 19, 2021, 1:08 AM

#

bot

#

by vester

#

don't remember the number

vocal prairie Apr 19, 2021, 1:13 AM

#

fallen patrol it makes all embeds have a default color of the bots specific color or they need...

Yeah ig

fallen patrol Apr 19, 2021, 3:52 AM

#

wait hold on a moment

short snow Apr 19, 2021, 4:00 AM

#

https://github.com/python-discord/bot/pull/1446#pullrequestreview-638324182 Am not exactly sure how I would go upon doing this? Could someone help me out with this, maybe summarizing the process and then I could go ahead.

Like how I can check webhook embed descriptions, how can i form a message link.

GitHub

Enhancing information within the incidents channel. by Shivansh-007...

Relevant Issues
Closes #1226
Description
Whenever a staff member would post a message in #incidents channel, it would be searched through a regex and all the message links in it would be extracted....

short snow Apr 19, 2021, 5:47 AM

#

https://github.com/python-discord/sir-lancebot/issues/573 this issue has been resolved, could someone close it?

GitHub

Adding int eval command to Sir Lancebot · Issue #573 · python-disco...

Description Adding command such as int eval to Sir Lancebot Reasoning It often might be useful to have some form of evaluation command to debug certain things that can't necessarily be debu...

stable mountainBOT Apr 19, 2021, 6:46 AM

#

All inventories (`22` total)

• GitPython
• aiohttp
• arcade
• asyncpg
• dateutil
• discordpy
• django

brazen charm Apr 19, 2021, 6:46 AM

#

I'd guess through the site as it still isn't restricted

#

The names shouldn't be there in the first place so I don't believe so

tawdry vapor Apr 19, 2021, 6:50 AM

#

No don't continue

#

In fact the site pr can be merged

#

I guess we just forgot about it

#

Well, not yet cause the migration would fail if GitPython is currently stored like that

#

It may be possible to write a migration that automatically fixes that

#

Strictly speaking that would be the most correct approach

glass pecan Apr 19, 2021, 6:55 AM

#

@tawdry vapor do you want me to lowercase it?

tawdry vapor Apr 19, 2021, 6:57 AM

#

glass pecan <@!137073073168973824> do you want me to lowercase it?

Sure. Not sure if I still have access to it and I'm on mobile anyway. Need to make sure all entries are correct not just that one

glass pecan Apr 19, 2021, 6:57 AM

#

ok

tawdry vapor Apr 19, 2021, 6:57 AM

#

The base url had to end in a slash too

stable mountainBOT Apr 19, 2021, 6:57 AM

#

All inventories (`22` total)

• GitPython
• aiohttp
• arcade
• asyncpg
• dateutil
• discordpy
• django

glass pecan Apr 19, 2021, 6:59 AM

#

tawdry vapor The base url had to end in a slash too

did a check over them. only gitpython was uppercase. also checked all the base urls, they all end in /

tawdry vapor Apr 19, 2021, 6:59 AM

#

Okay then that pr on site should be good to go

glass pecan Apr 19, 2021, 7:00 AM

#

this is correct, it's based on character index, i.e. the codepoint value iirc

#

str.casefold is best to use for case normalisation

#

because a lot of people only have to deal with english, probably

#

i suspect anyone who's had to process something like greek or such knows of casefold well

#

thanks @tawdry vapor for that

#

it's still based on codepoint value, but on the normalised strings. So for all the standard english letters, it's as if they're all lowered

#

403 Forbidden
wat

tawdry vapor Apr 19, 2021, 7:08 AM

#

Yeah good luck with that one

glass pecan Apr 19, 2021, 7:08 AM

#

This is a common issue (#127) with the deprecated GitHub Packages Docker Registry (aka docker.pkg.github.com). I suggest to migrate to GitHub Container Registry instead.

#

i thought we already were

#

@tawdry vapor guess what i changed

tawdry vapor Apr 19, 2021, 7:16 AM

#

Nothing

glass pecan Apr 19, 2021, 7:16 AM

#

exactly

#

¯_(ツ)_/¯

tawdry vapor Apr 19, 2021, 7:17 AM

#

Guess it's an upstream issue

patent pivot Apr 19, 2021, 7:17 AM

#

Someone had that the other day yeah

#

I think it's a ghcr blip

glass pecan Apr 19, 2021, 7:17 AM

#

i think it might be caused from ghcr possibly just letting our connection go halfway through pushing a layer

#

maybe

real steeple Apr 19, 2021, 1:18 PM

#

!voiceverify

vocal prairie Apr 19, 2021, 1:23 PM

#

real steeple !voiceverify

#voice-verification

clever wraith Apr 19, 2021, 2:20 PM

#

how do i get links to certain site pages

#

.roles

vocal prairie Apr 19, 2021, 2:20 PM

#

clever wraith how do i get links to certain site pages

!site

stable mountainBOT Apr 19, 2021, 2:20 PM

#

Command Help

!site
Can also use: s

Commands for getting info about our website.

Subcommands:

!site faq
Info about the site's FAQ page.
!site help
Info about the site's Getting Help page.
!site home
Info about the website itself.
!site resources
Info about the site's Resources page.
!site rules [rules]...
Provides a link to all rules or, if specified, displays specific rule(s).
!site tools
Info about the site's Tools page.

clever wraith Apr 19, 2021, 2:21 PM

#

ty

#

!site roles

#

am i missing something

#

@vocal prairie is this not how im suppose to do it?

brazen charm Apr 19, 2021, 2:22 PM

#

It only has some predefined things, it can't fetch urls from the site itself

vocal prairie Apr 19, 2021, 2:22 PM

#

There's nothing for the roles page.

clever wraith Apr 19, 2021, 2:22 PM

#

thats a shame

vocal prairie Apr 19, 2021, 2:22 PM

#

You can open an issue on the bot repository if you wish.

clever wraith Apr 19, 2021, 2:23 PM

#

i already have 1 open

#

about smth different tho

green oriole Apr 19, 2021, 2:26 PM

#

There is https://pydis.com/roles

Python Discord | Python Discord Server Roles

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

We have a bunch of short links like that

clever wraith Apr 19, 2021, 2:27 PM

#

@green oriole can i get it with a command tho?

green oriole Apr 19, 2021, 2:28 PM

#

Nope, I just memorised them personally 👀

clever wraith Apr 19, 2021, 2:28 PM

#

that wouldnt be hard to make if the links are as simple as that

#

just website + page name

#

and doing !site roles would be nice to get a link to that

green oriole Apr 19, 2021, 2:31 PM

#

Yep, although we have a bunch of short links that don't always point to the website like https://pydis.com/welcome

YouTube

Python Discord

Welcome to Python Discord

What is Python Discord?We're a large Discord community focused around the Python programming language. We believe anyone can learn to code, and are very dedi...

▶ Play video

#

I guess we could have a command to look up the short code but I wouldn't find that very useful

clever wraith Apr 19, 2021, 2:33 PM

#

convenience, no?

fallen patrol Apr 19, 2021, 2:33 PM

#

green oriole Yep, although we have a bunch of short links that don't always point to the webs...

fyi https://pydis.com/.env is public and it should not be

clever wraith Apr 19, 2021, 2:33 PM

#

i clicked...

green oriole Apr 19, 2021, 2:34 PM

#

I mean, I was here when Joe added it haha

fallen patrol Apr 19, 2021, 2:34 PM

#

damnit

vocal prairie Apr 19, 2021, 2:34 PM

#

fallen patrol fyi <https://pydis.com/.env> is public and it should not be

I-

#

That's smart.

green oriole Apr 19, 2021, 2:34 PM

#

Because https://pydis.com/admin was a rickroll but I use this url to get to DJ Admin haha

sleek steppe Apr 19, 2021, 2:34 PM

#

clicked but recognized the link, so didn't get rickrolled

fallen patrol Apr 19, 2021, 2:34 PM

#

vocal prairie I-

thank you, i set it up (/j)

vocal prairie Apr 19, 2021, 2:36 PM

#

green oriole Because https://pydis.com/admin was a rickroll but I use this url to get to DJ A...

And here I thought the admin dash was https://admin.pydis.com

green oriole Apr 19, 2021, 2:36 PM

#

I don't even know if we have an admin dashboard haha

vocal prairie Apr 19, 2021, 2:37 PM

#

Really? I thought that was how you guys viewed stats and stuff.

#

Internal stats.

vale ibex Apr 19, 2021, 2:38 PM

#

Nah that's all on grafana

#

and metabase for other things

brazen charm Apr 19, 2021, 2:39 PM

#

Speaking of which, do we want all of them moved? https://github.com/python-discord/bot/issues/1473

GitHub

Move static content site commands to tags · Issue #1473 · python-di...

The site commands tools, resources, help and home construct embeds from mostly static strings, with only the site url being variable. The url is already referenced in other tags so this won&#39...

sleek steppe Apr 19, 2021, 2:41 PM

#

Also what's stopping sir-lancebot#597 from being merged 🤔

dusky shoreBOT Apr 19, 2021, 2:41 PM

#

GitHub

PROpen Move pfp commands into executors

vale ibex Apr 19, 2021, 2:41 PM

#

sleek steppe Also what's stopping sir-lancebot#597 from being merged 🤔

reviews

sleek steppe Apr 19, 2021, 2:41 PM

#

Ah

vale ibex Apr 19, 2021, 2:41 PM

#

brazen charm Speaking of which, do we want all of them moved? https://github.com/python-disco...

That looks like a good refactor to me tbh

clever wraith Apr 19, 2021, 2:41 PM

#

@sleek steppe idk if u know but i made changes to my command if u wanna check it out

sleek steppe Apr 19, 2021, 2:42 PM

#

Will test later, gonna test #597 first

vale ibex Apr 19, 2021, 2:42 PM

#

sleek steppe Ah

yea, all PRs need to be approved by at least 2 staff, with at least one of which being a core dev

sleek steppe Apr 19, 2021, 2:43 PM

#

Yeah I know about that part, I just thought there was a reason not much people have reviewed it thonk

vale ibex Apr 19, 2021, 2:43 PM

#

ahhh, probably the large diff lol

short snow Apr 19, 2021, 2:43 PM

#

I have approved your pr, or I have review still pending, lemme see

thorny obsidian Apr 19, 2021, 2:43 PM

#

I'm not sure how many people are comfortable with executors and the like

short snow Apr 19, 2021, 2:44 PM

#

vale ibex ahhh, probably the large diff lol

There is no much diff, those are just cuz of transfer of the cogs

clever wraith Apr 19, 2021, 2:44 PM

#

thorny obsidian I'm not sure how many people are comfortable with executors and the like

i started using one

brazen charm Apr 19, 2021, 2:44 PM

#

vale ibex That looks like a good refactor to me tbh

My main question here would be if the site help command should be moved because of the concerns I mentioned in the comment

vale ibex Apr 19, 2021, 2:45 PM

#

!remind 90M https://github.com/python-discord/bot/issues/1473

GitHub

Move static content site commands to tags · Issue #1473 · python-di...

The site commands tools, resources, help and home construct embeds from mostly static strings, with only the site url being variable. The url is already referenced in other tags so this won&#39...

stable mountainBOT Apr 19, 2021, 2:45 PM

#

Sure.

Your reminder will arrive in 1 hour and 30 minutes!

clever wraith Apr 19, 2021, 2:45 PM

#

short snow I have approved your pr, or I have review still pending, lemme see

are you talking about me?

clever wraith Apr 19, 2021, 2:45 PM

#

clever wraith are you talking about me?

they glow in the dark...

sleek steppe Apr 19, 2021, 2:45 PM

#

clever wraith are you talking about me?

Nope, chris' PR

clever wraith Apr 19, 2021, 2:45 PM

#

oh

vale ibex Apr 19, 2021, 2:45 PM

#

brazen charm My main question here would be if the site help command should be moved because ...

I'll give it a proper read through after work

short snow Apr 19, 2021, 2:45 PM

#

clever wraith are you talking about me?

No, about chris’ pr

#

Ah nvm, toxic said

clever wraith Apr 19, 2021, 2:46 PM

#

.duckify

short snow Apr 19, 2021, 2:46 PM

#

Ok yeah I have finished

clever wraith Apr 19, 2021, 2:47 PM

#

clever wraith they glow in the dark...

they die in the light

short snow Apr 19, 2021, 2:48 PM

#

Also a quackstack or needs another approval

#

Lemme get the link

#

https://github.com/python-discord/quackstack/pull/31

GitHub

Switch random generation to use HSV over RGB by Shivansh-007 · Pull...

Closes #26
Uses implementation of the staff PyWeek submission

Adds colors.py which contains all util functions i.e. make_color, make_duck_colors, make_man_duck_colors.

Get rid of random RGB ge...

fervent sage Apr 19, 2021, 2:48 PM

#

short snow Also a quackstack or needs another approval

is it the one i have commits on and cant merge lmao

#

yep

#

lol

short snow Apr 19, 2021, 2:49 PM

#

Lol, Alec lost his powers on the pr

fervent sage Apr 19, 2021, 2:49 PM

#

for no reason too, my commit was unneeded blob_pain

sleek steppe Apr 19, 2021, 2:49 PM

#

Is there a way to test quackstack 🤔

fervent sage Apr 19, 2021, 2:50 PM

#

clone the repo and docker-compose up

sleek steppe Apr 19, 2021, 2:50 PM

#

oh lol

short snow Apr 19, 2021, 2:51 PM

#

Or uvicorn main:app —reload

#

If I typed correctly

fervent sage Apr 19, 2021, 2:51 PM

#

yeah that's probably the easier way

short snow Apr 19, 2021, 2:51 PM

#

Docker, slower than 🐢

fervent sage Apr 19, 2021, 2:51 PM

#

i've just got alias ucr="uvicorn main:app --port 1337 --reload" in my zshrc for convenience

short snow Apr 19, 2021, 2:52 PM

#

Lol, same

#

uvistart

clever wraith Apr 19, 2021, 2:52 PM

#

i wanted to know if other people can change my code without my approval in my issue

short snow Apr 19, 2021, 2:52 PM

#

Instead

vocal prairie Apr 19, 2021, 2:52 PM

#

clever wraith i wanted to know if other people can change my code without my approval in my is...

Yes, maintainers can.

dry folio Apr 19, 2021, 2:52 PM

#

@thorny obsidian i'm here now!

clever wraith Apr 19, 2021, 2:52 PM

#

dry folio <@!212644551926611969> i'm here now!

https://media.discordapp.net/attachments/763871227663220756/771055337192292353/697995591921172532.gif

sleek steppe Apr 19, 2021, 2:53 PM

#

People with write access should be able to make changes to your branxh

fervent sage Apr 19, 2021, 2:53 PM

#

pydis org members can push commits to your pr branches if you enable that option yes

clever wraith Apr 19, 2021, 2:53 PM

#

vocal prairie Yes, maintainers can.

is that just owners

thorny obsidian Apr 19, 2021, 2:53 PM

#

dry folio <@!212644551926611969> i'm here now!

Hi! So, step 0: Get a github account and take a look here: https://github.com/python-discord/sir-lancebot

dry folio Apr 19, 2021, 2:53 PM

#

after discussion with my friends in #ot0-psvm’s-eternal-disapproval we decided to make .catify

short snow Apr 19, 2021, 2:53 PM

#

vocal prairie Yes, maintainers can.

He meant, after getting merged , if someone wants to edit the code, could they do that?

dry folio Apr 19, 2021, 2:53 PM

#

thorny obsidian Hi! So, step 0: Get a github account and take a look here: https://github.com/py...

step 0 is completed! i have an acc already 😉

short snow Apr 19, 2021, 2:53 PM

#

Without consulting him first

fervent sage Apr 19, 2021, 2:53 PM

#

short answer: yes

thorny obsidian Apr 19, 2021, 2:53 PM

#

You can navigate to the issues tab which is where we track feature requests and all that goodness

dry folio Apr 19, 2021, 2:54 PM

#

thorny obsidian You can navigate to the issues tab which is where we track feature requests and ...

i'm on the tab!

thorny obsidian Apr 19, 2021, 2:54 PM

#

You can click the "new issue" button and there should be a template you can follow to fill out

#

In this case the "feature" template

wide elm Apr 19, 2021, 2:55 PM

#

Can anyone just PR sir lancelot?

thorny obsidian Apr 19, 2021, 2:55 PM

#

wide elm Can anyone just PR sir lancelot?

If there's an approved issue and you're assigned to it, yeah!

dry folio Apr 19, 2021, 2:55 PM

#

thorny obsidian In this case the "feature" template

oof, i have to do proposed implementation? i have no idea how to code this tho lol

wide elm Apr 19, 2021, 2:55 PM

#

thorny obsidian If there's an approved issue and you're assigned to it, yeah!

alright

sleek steppe Apr 19, 2021, 2:55 PM

#

Sure anyone can at any time; doesn't mean it'll get approved mmLul

thorny obsidian Apr 19, 2021, 2:55 PM

#

dry folio oof, i have to do proposed implementation? i have no idea how to code this tho l...

Nope, that's only if you have an idea of what it should be implemented like if it's a complicated feature

dry folio Apr 19, 2021, 2:55 PM

#

thorny obsidian Nope, that's only if you have an idea of what it should be implemented like if i...

ah i see!

short snow Apr 19, 2021, 2:56 PM

#

Someone already made a issue

dry folio Apr 19, 2021, 2:56 PM

#

thorny obsidian Nope, that's only if you have an idea of what it should be implemented like if i...

thanks a lot! i'll chat with my friends in #ot0-psvm’s-eternal-disapproval to see

clever wraith Apr 19, 2021, 2:56 PM

#

Mighta been me 🥴

short snow Apr 19, 2021, 2:56 PM

#

#dev-log message don’t agree here, I think it should be put after there nickname

wide elm Apr 19, 2021, 2:56 PM

#

pfft

short snow Apr 19, 2021, 2:56 PM

#

And we can multiple versions of the cat

#

Like mine is one

#

Should edit the user’s nickname

clever wraith Apr 19, 2021, 2:57 PM

#

I like that better

short snow Apr 19, 2021, 2:57 PM

#

As it is weere this is being used as of now

#

“That” is yours or what I just said?

clever wraith Apr 19, 2021, 2:58 PM

#

prob his

sleek steppe Apr 19, 2021, 2:58 PM

#

@vale ibex you messed up somewhere lol

vocal prairie Apr 19, 2021, 2:58 PM

#

I like it where you stick it between words

vale ibex Apr 19, 2021, 2:59 PM

#

ummm wtf

#

lol

short snow Apr 19, 2021, 2:59 PM

#

sleek steppe <@!126811506632294400> you messed up somewhere lol

Ahh yes, when I tested this wasn’t there, I think Ik why

#

Lemme get the link

vale ibex Apr 19, 2021, 3:00 PM

#

I think this is usually caused when the file names of the attachments don't match between whats in ctx.send and the embed

#

!remind 90M Also, this

stable mountainBOT Apr 19, 2021, 3:00 PM

#

ROGER THAT

Your reminder will arrive in 1 hour and 30 minutes!

short snow Apr 19, 2021, 3:02 PM

#

ok, idk why that happens

fallen patrol Apr 19, 2021, 3:02 PM

#

sleek steppe <@!126811506632294400> you messed up somewhere lol

twice where

#

wait what pr is that

sleek steppe Apr 19, 2021, 3:02 PM

#

https://github.com/python-discord/sir-lancebot/pull/597

fallen patrol Apr 19, 2021, 3:06 PM

#

lmfao

vocal prairie Apr 19, 2021, 3:06 PM

#

RIP me

sleek steppe Apr 19, 2021, 3:06 PM

#

It needs to be M

vocal prairie Apr 19, 2021, 3:06 PM

#

I figured that out after.

thorny obsidian Apr 19, 2021, 3:09 PM

#

@clever wraith in case you miss it in the issue, you are assigned to it and it's approved. Have fun~

clever wraith Apr 19, 2021, 3:09 PM

#

Thanks!

#

Speedy approval

thorny obsidian Apr 19, 2021, 3:09 PM

#

I have to take training that is dreadfully boring, so I'm catching up on some PyDis tasks ¯_(ツ)_/¯

vocal prairie Apr 19, 2021, 3:10 PM

#

Good luck getting through that training

sleek steppe Apr 19, 2021, 3:25 PM

#

bot#1531 needs a speedy approval too CatJam (/s)

dusky shoreBOT Apr 19, 2021, 3:25 PM

#

GitHub

PROpen Redirect output to bot-commands channel for the !eval command

clever wraith Apr 19, 2021, 3:40 PM

#

discord.gg/python

sleek steppe Apr 19, 2021, 3:41 PM

#

Oh. Thanks for the invite, it's a really cool server

clever wraith Apr 19, 2021, 3:44 PM

#

i might have been there once

short snow Apr 19, 2021, 3:45 PM

#

The best airlines on the planet ✈️ indeed

clever wraith Apr 19, 2021, 3:46 PM

#

its not about snakes?

short snow Apr 19, 2021, 3:46 PM

#

Snakified plane

stable mountainBOT Apr 19, 2021, 4:15 PM

#

@vale ibex

It has arrived!

Here's your reminder: https://github.com/python-discord/bot/issues/1473.
[Jump back to when you created the reminder](#dev-contrib message)

stable mountainBOT Apr 19, 2021, 4:30 PM

#

@vale ibex

It has arrived!

Here's your reminder: Also, ![this](https://cdn.discordapp.com/emojis/470903994118832130.webp?size=128 "this").
[Jump back to when you created the reminder](#dev-contrib message)

dusky shoreBOT Apr 19, 2021, 4:39 PM

#

GitHub

IssueOpen Move static content site commands to tags

clever wraith Apr 19, 2021, 5:33 PM

#

are dbs available to use for our own features?

green oriole Apr 19, 2021, 5:34 PM

#

Are you asking if our bots have access to a database?

clever wraith Apr 19, 2021, 5:34 PM

#

basically

#

im asking if i could make a feature that would use them

#

hypothetically though

fallen patrol Apr 19, 2021, 5:36 PM

#

yesn't

vocal prairie Apr 19, 2021, 5:37 PM

#

Yes, you could.

fallen patrol Apr 19, 2021, 5:37 PM

#

clever wraith im asking if i could make a feature that would use them

@stable mountain has a db
@viscid badge has a db
@slow bone has a db
@dusky shore does not have a db

fervent sage Apr 19, 2021, 5:37 PM

#

iirc lancebot doesnt currently have a db so eh

vocal prairie Apr 19, 2021, 5:37 PM

#

But only Python, Modmail, and Metricity use a proper db, Sir Lancebot uses Redis I think.

clever wraith Apr 19, 2021, 5:37 PM

#

damn rip

fallen patrol Apr 19, 2021, 5:37 PM

#

a volatile redis*

green oriole Apr 19, 2021, 5:38 PM

#

Lancebot has access to a Redis cache

fervent sage Apr 19, 2021, 5:38 PM

#

lance uses redis entirely as cache rather than any sort of persistent storage

fallen patrol Apr 19, 2021, 5:38 PM

#

and @slow bone isn't even developed by this server

green oriole Apr 19, 2021, 5:38 PM

#

Do you have anything in mind?

fallen patrol Apr 19, 2021, 5:38 PM

#

however you can actually add a feature to @slow bone if you want by creating a plugin hehe

vocal prairie Apr 19, 2021, 5:38 PM

#

@slow bone uses Mongo, right?

fervent sage Apr 19, 2021, 5:38 PM

#

sqlite i think

#

no

#

mongo

clever wraith Apr 19, 2021, 5:38 PM

#

also has there ever been a thought of making a level-like system? smth like MEE6 has

fervent sage Apr 19, 2021, 5:38 PM

#

yes (context: mongo)

vocal prairie Apr 19, 2021, 5:39 PM

#

clever wraith also has there ever been a thought of making a level-like system? smth like MEE6...

I think they didn't want to gamify the system.

fallen patrol Apr 19, 2021, 5:39 PM

#

and a good reason to not add it either

fervent sage Apr 19, 2021, 5:39 PM

#

I can list 10 reasons not to add levelling kek

vocal prairie Apr 19, 2021, 5:39 PM

#

Same

fallen patrol Apr 19, 2021, 5:39 PM

#

fervent sage yes (context: mongo)

yes both lol

clever wraith Apr 19, 2021, 5:39 PM

#

is it like spam inducing?

fallen patrol Apr 19, 2021, 5:39 PM

#

fervent sage I can list 10 reasons not to add levelling <:kek:585617800257863727>

joe will just add a db restriction to give himself the most all the time

fervent sage Apr 19, 2021, 5:40 PM

#

Incentivises spam
Low quality conversation is encouraged
Causes people to act 'elitist' about their roles/xp
<more>

vocal prairie Apr 19, 2021, 5:40 PM

#

clever wraith is it like spam inducing?

Just in general, it makes the community and conversation less organic.

clever wraith Apr 19, 2021, 5:40 PM

#

yeah i get it

fervent sage Apr 19, 2021, 5:40 PM

#

? (context: deleted)

clever wraith Apr 19, 2021, 5:41 PM

#

also is there a topic limit, like how far from python could a feature be about

fallen patrol Apr 19, 2021, 5:41 PM

#

what feature do you have in mind as a baseline?

thorny obsidian Apr 19, 2021, 5:42 PM

#

clever wraith also is there a topic limit, like how far from python could a feature be about

Sir Lancebot is intended as a way for people to learn how to contribute to open source repos and projects. As long as it's coded in python and it's something you want to make and will be beneficial/fun for the server, then we'll pretty much allow it.

vale ibex Apr 19, 2021, 5:43 PM

#

Hah sorry @eternal owl commited before I saw your comment

thorny obsidian Apr 19, 2021, 5:44 PM

#

@fallen patrol If you have an issue with staff behavior then contact modmail.

vale ibex Apr 19, 2021, 5:44 PM

#

FWIW I copied the paginator from !otn l

eternal owl Apr 19, 2021, 5:45 PM

#

btw, # This is so that output can be sorted on [0] before passed it's to the paginator, the [0] means the first index, i.e, UtcPosixTimestamp @vale ibex

#

line 189

vale ibex Apr 19, 2021, 5:45 PM

#

Yea, that's what we sort on 😄

eternal owl Apr 19, 2021, 5:45 PM

#

maybe we can replace [0] with UtcPosixTimestamp?

#

in the comment

vale ibex Apr 19, 2021, 5:47 PM

#

What do you think of So that the list can be sorted on the UtcPosixTimestamp before the message is passed to the paginator.

eternal owl Apr 19, 2021, 5:48 PM

#

~~so that the output ..~~

vale ibex Apr 19, 2021, 5:48 PM

#

Updated

eternal owl Apr 19, 2021, 5:48 PM

#

👍

vale ibex Apr 19, 2021, 5:49 PM

#

Done

eternal owl Apr 19, 2021, 5:50 PM

#

https://github.com/python-discord/bot/issues/1506

GitHub

Stop an in-progress stream if a user's role is revoked · Issue #150...

If a user's streaming permission is removed via the revoke stream command, we want to stop any stream that may be in-progress. If a user's video role drops off due to the normal sch...

#

thoughts on my comment?

#

do you have any other methods to suspend stream?

vale ibex Apr 19, 2021, 5:51 PM

#

Yea, my idea was to move them to #756327105389920306 and back

eternal owl Apr 19, 2021, 5:51 PM

#

alright 👍

#

guess thats the only way rn

#

maybe discord will add a feature in the future to disable stream

#

like server mute, etc

vale ibex Apr 19, 2021, 5:52 PM

#

Yea that would be useful

fallen patrol Apr 19, 2021, 5:53 PM

#

eternal owl maybe discord will add a feature in the future to disable stream

won't happen easily

eternal owl Apr 19, 2021, 5:53 PM

#

we are not counting on it

fallen patrol Apr 19, 2021, 5:53 PM

#

vale ibex Yea, my idea was to move them to <#756327105389920306> and back

honestly i'd add a portion of this logic to the mute command as well

eternal owl Apr 19, 2021, 5:53 PM

#

nothing wrong with speculating

vale ibex Apr 19, 2021, 5:53 PM

#

fallen patrol honestly i'd add a portion of this logic to the mute command as well

The mute command just moves the user out of voice entirely

fallen patrol Apr 19, 2021, 5:53 PM

#

ah

dry folio Apr 19, 2021, 5:56 PM

#

@thorny obsidian we've worked out the code, could you please tell us where to submit?
code (only first prototype, probably gonna change):

    @commands.command(aliases=["ᓚᘏᗢ", "ᓚᘏᗢify"])
    async def catify(self, ctx, *string: Optional[str]) -> None:
        if string == ():
            if len(ctx.author.name) > 28:
                await ctx.send("Your name exceeds character limits after catification. Please change your name!")
                return
            else:
                try:
                    await ctx.author.edit(nick=ctx.author.nick + " | ᓚᘏᗢ")
                except:
                    await ctx.author.edit(nick=ctx.author.name + " | ᓚᘏᗢ")
                return
        string = " ".join(string)
        print(string)

        string_list = string.split()
        for index, name in enumerate(string_list):
            if "cat" in name:
                string_list[index] = string_list[index].replace("cat", 'ᓚᘏᗢ')

        for i in range(random.randint(1, len(string_list)//3)):
            # insert cat at random index
            string_list.insert(random.randint(0, len(string_list)-1), "ᓚᘏᗢ")

        await ctx.channel.send(" ".join(string_list))

thorny obsidian Apr 19, 2021, 5:57 PM

#

dry folio <@!212644551926611969> we've worked out the code, could you please tell us where...

So the next step would be for you to fork Sir Lancebot, add in that code to your local copy, (test it and make sure it works), and then create a Pull Request to merge it back to our repository. I think we have a guide or two that can walk you through that process if you haven't done it before

dry folio Apr 19, 2021, 5:58 PM

#

thorny obsidian So the next step would be for you to fork Sir Lancebot, add in that code to your...

yes, Kronifer had already forked it and we just did a complete test with several dozens of inputs. now we just need to merge it back, yes?

sleek steppe Apr 19, 2021, 5:59 PM

#

Yep, you'll need to create a pull request

dry folio Apr 19, 2021, 6:00 PM

#

alright, got it

#

this is going to be r e v o l u t i o n a r y

sleek steppe Apr 19, 2021, 6:10 PM

#

Does @dusky shore have permissions to change nicknames?

vale ibex Apr 19, 2021, 6:11 PM

#

let me check

#

Yea, it does

thorny obsidian Apr 19, 2021, 6:12 PM

#

I generally wouldn't want us to have the command change the nickname. I'd rather it just provide the text so someone can copy it to their nickname if they want.

sleek steppe Apr 19, 2021, 6:12 PM

#

Yeah, like the *duckify command

clever wraith Apr 19, 2021, 6:12 PM

#

Hey could someone take a look at sir-lancebot#691

dusky shoreBOT Apr 19, 2021, 6:12 PM

#

GitHub

IssueOpen Add .catify

clever wraith Apr 19, 2021, 6:13 PM

#

oop

#

meant sir-lancebot#694

dusky shoreBOT Apr 19, 2021, 6:13 PM

#

GitHub

PROpen Catify

sleek steppe Apr 19, 2021, 6:13 PM

#

Looking

fervent sage Apr 19, 2021, 6:13 PM

#

time to go bother a core dev to look at my feature proposal /s

clever wraith Apr 19, 2021, 6:14 PM

#

hey @fervent sage congrats on helper

fervent sage Apr 19, 2021, 6:15 PM

#

lol thanks ~~although about 4 weeks later than expected :P~~

clever wraith Apr 19, 2021, 6:16 PM

#

sorry :/

sleek steppe Apr 19, 2021, 6:16 PM

#

aaaaAAAA there were commits before I finished the review

fervent sage Apr 19, 2021, 6:17 PM

#

sleek steppe aaaaAAAA there were commits before I finished the review

blob_pain

clever wraith Apr 19, 2021, 6:17 PM

#

lol sorry

fervent sage Apr 19, 2021, 6:17 PM

#

no lol nothing to be sorry about

#

toxic enjoys the pain mmLol
well maybe not
but anyways
mmLol

sleek steppe Apr 19, 2021, 6:18 PM

#

I hit refresh but the comment was still there lemon_pensive

#

@clever wraith #dev-contrib message

patent pivot Apr 19, 2021, 6:20 PM

#

I think changing the nickname on a command invoke is pretty fine imo

#

UX sucks to have to manually copy, especially since on iOS you can't copy text out of embeds

thorny obsidian Apr 19, 2021, 6:21 PM

#

It won't be in an embed though, right?

patent pivot Apr 19, 2021, 6:21 PM

#

Almost all Lancebot commands use embeds, so I assumed, I guess it's better if not, though still quite annoying on mobile since you can't selectively copy

#

Though I guess it's fine if we have no additional text

#

but yeah, I just think that for this it's totally fine to change nickname if we want to do that

dry folio Apr 19, 2021, 6:22 PM

#

patent pivot but yeah, I just think that for this it's totally fine to change nickname if we ...

thank you joe!!

patent pivot Apr 19, 2021, 6:23 PM

#

that's just my personal take btw, not approval

dry folio Apr 19, 2021, 6:23 PM

#

so we merge now @clever wraith?

patent pivot Apr 19, 2021, 6:23 PM

#

my opinion doesn't override anyone

thorny obsidian Apr 19, 2021, 6:23 PM

#

If you think it's fine then it's probably fine. I'm just a bit weird about potentially unexpectedly changing nicknames when it's not moderation actions. It's always jarring and generally "wtf" if you don't expect it from that command

dry folio Apr 19, 2021, 6:23 PM

#

patent pivot that's just my personal take btw, not approval

oh? would the entire mod team have to vote?

patent pivot Apr 19, 2021, 6:24 PM

#

dry folio oh? would the entire mod team have to vote?

no, I'm just saying we should talk about it here

dry folio Apr 19, 2021, 6:24 PM

#

thorny obsidian If you think it's fine then it's probably fine. I'm just a bit weird about poten...

alright, but this is only modifying their own username, not others, so it should be okay right?

dry folio Apr 19, 2021, 6:24 PM

#

patent pivot no, I'm just saying we should talk about it here

oh ok

thorny obsidian Apr 19, 2021, 6:24 PM

#

For a PR to get merged at least one core dev needs to review and accept it and then one other staff/contributor

dry folio Apr 19, 2021, 6:25 PM

#

thorny obsidian For a PR to get merged at least one core dev needs to review and accept it and t...

so one core dev's approval + one staff/contrib's approval = good?

clever wraith Apr 19, 2021, 6:25 PM

#

yeah

dry folio Apr 19, 2021, 6:25 PM

#

is joe a core dev?

patent pivot Apr 19, 2021, 6:25 PM

#

There might be some surprise, I guess, but a) it's a command invoke so it's intentional user action b) nicknames are very easy to restore

thorny obsidian Apr 19, 2021, 6:25 PM

#

mhm, if there aren't any blocking changes requested then it can get merged in.

patent pivot Apr 19, 2021, 6:25 PM

#

I am a core dev, yeah

dry folio Apr 19, 2021, 6:26 PM

#

so joe's approval + kutiekat's approval = good!

thorny obsidian Apr 19, 2021, 6:26 PM

#

I think a bunch of the core devs are busy right now, but I'm sure one might find time to review in the next day or two

patent pivot Apr 19, 2021, 6:26 PM

#

Although Toxic's comment about using display name has merit, what do we think on that?

thorny obsidian Apr 19, 2021, 6:26 PM

#

I'll have to properly test it before I sign off on it, which I can only do on my home computer

patent pivot Apr 19, 2021, 6:26 PM

#

I'm going to do a code/doc review now

clever wraith Apr 19, 2021, 6:26 PM

#

patent pivot Although Toxic's comment about using display name has merit, what do we think on...

i think thats okay, ive changed

dry folio Apr 19, 2021, 6:27 PM

#

i understand. thank you @patent pivot and @thorny obsidian immensely for your time!

clever wraith Apr 19, 2021, 6:31 PM

#

okay, sounds good!

#

!remind 1h check on sir-lancebot#294

stable mountainBOT Apr 19, 2021, 6:31 PM

#

Can do!

Your reminder will arrive in 1 hour!

dusky shoreBOT Apr 19, 2021, 6:31 PM

#

GitHub

PRMerged Limit the issue and AoC commands to a superset of the global whitelist instead of bypassing it entirely

thorny obsidian Apr 19, 2021, 6:32 PM

#

I think you meant 694 =P

patent pivot Apr 19, 2021, 6:32 PM

#

that wasn't the feedback item that toxic meant I don't think

clever wraith Apr 19, 2021, 6:32 PM

#

thorny obsidian I think you meant 694 =P

yep

sleek steppe Apr 19, 2021, 6:33 PM

#

There's one more bug

patent pivot Apr 19, 2021, 6:34 PM

#

the argument shouldn't be a type of string list

clever wraith Apr 19, 2021, 6:35 PM

#

fixed display name thing

clever wraith Apr 19, 2021, 6:35 PM

#

sleek steppe There's one more bug

?

patent pivot Apr 19, 2021, 6:37 PM

#

review left

dusky shoreBOT Apr 19, 2021, 6:38 PM

#

GitHub

PROpen !superstarify default time

thorny obsidian Apr 19, 2021, 6:38 PM

#

oooh, thank you for taking up that issue

#

Maybe I do set up Python to review that...

#

... in my.... *checks calendar* no spare time available

#

But I'll see if I can get something spun up and contribute a review there.

sleek steppe Apr 19, 2021, 6:39 PM

#

~~Even though kutie said in the issue that the default should be something like 5 or 10~~

thorny obsidian Apr 19, 2021, 6:40 PM

#

Oh I have no idea. I was suggesting maybe 5 or 10 minutes but there's also logic for the default time to match the tempmute implementation

#

You just need 1 core dev + 1 staff/contrib approval. It just sends out the review request wide.

sleek steppe Apr 19, 2021, 6:42 PM

#

That isn't a lot

thorny obsidian Apr 19, 2021, 6:43 PM

#

Are you looking to tackle more issues? =P

sleek steppe Apr 19, 2021, 6:44 PM

#

@clever wraith what error are you getting 🤔? I'm curious

sleek steppe Apr 19, 2021, 6:44 PM

#

sleek steppe <@456226577798135808> what error are you getting 🤔? I'm curious

list_string[index] is the exact same thing as name

patent pivot Apr 19, 2021, 6:45 PM

#

@clever wraith you'll need to pull the new changes locally to fix up linting

sleek steppe Apr 19, 2021, 6:45 PM

#

I have a PR fixing one line I think

#

multiple

thorny obsidian Apr 19, 2021, 6:46 PM

#

That is not at all a bad thing. At this point with Python's complexity we should be giving out cookies to people who can remove lines without impacting functionality or readability

clever wraith Apr 19, 2021, 6:46 PM

#

patent pivot <@456226577798135808> you'll need to pull the new changes locally to fix up lint...

did

fervent sage Apr 19, 2021, 6:49 PM

#

thorny obsidian That is not at all a bad thing. At this point with Python's complexity we should...

cookies you say? I'll have 17 PRs by the end of the night mmLol

cold island Apr 19, 2021, 6:49 PM

#

I'll review that one now

clever wraith Apr 19, 2021, 6:49 PM

#

fervent sage cookies you say? I'll have 17 PRs by the end of the night <:mmLol:35683169738542...

oh? well ill get 20

#

i want the cookies

patent pivot Apr 19, 2021, 6:49 PM

#

fervent sage cookies you say? I'll have 17 PRs by the end of the night <:mmLol:35683169738542...

have you guys stopped hammering my database yet

#

oh you have

#

nice

sleek steppe Apr 19, 2021, 6:49 PM

#

Is it really optimizing anything

patent pivot Apr 19, 2021, 6:50 PM

#

spot laundmo + vco

#

database queries per second

thorny obsidian Apr 19, 2021, 6:50 PM

#

stress testing a system for an upcoming event

fervent sage Apr 19, 2021, 6:50 PM

#

me and laundmo ~~dosing~~ stress testing a thing

sleek steppe Apr 19, 2021, 6:50 PM

#

lol

fervent sage Apr 19, 2021, 6:50 PM

#

i'm gonna start up my client again mmLol

patent pivot Apr 19, 2021, 6:51 PM

#

tbf we peaked at 2.46k per second so I'll take it

sleek steppe Apr 19, 2021, 6:51 PM

#

thorny obsidian That is not at all a bad thing. At this point with Python's complexity we should...

I'd be happy to make a PR to lancebot that reduces a bunch of outdated code and bad type hints lol

fervent sage Apr 19, 2021, 6:51 PM

#

ic we have gone up again

patent pivot Apr 19, 2021, 6:51 PM

#

worst case scenario event mmLul

thorny obsidian Apr 19, 2021, 6:51 PM

#

sleek steppe I'd be happy to make a PR to lancebot that reduces a bunch of outdated code and ...

Lancebot could use some spring cleaning, so go for it

clever wraith Apr 19, 2021, 6:52 PM

#

alright joe, that one fix you suggested has been made

fervent sage Apr 19, 2021, 6:52 PM

#

sleek steppe I'd be happy to make a PR to lancebot that reduces a bunch of outdated code and ...

wanna collaborate on that?

sleek steppe Apr 19, 2021, 6:52 PM

#

fervent sage wanna collaborate on that?

That'd be cool

sleek steppe Apr 19, 2021, 6:53 PM

#

sleek steppe That'd be cool

Then the branch could actually be on sir-lancebot's repo

patent pivot Apr 19, 2021, 6:53 PM

#

stop

#

collaborate and listen

fervent sage Apr 19, 2021, 6:53 PM

#

sleek steppe Then the branch could actually be on sir-lancebot's repo

would you actually be able to push to it?

sleek steppe Apr 19, 2021, 6:54 PM

#

Probably not

patent pivot Apr 19, 2021, 6:54 PM

#

so

#

yeah

#

I'd recommend working on a fork

sleek steppe Apr 19, 2021, 6:54 PM

#

Fine my fork it is

fervent sage Apr 19, 2021, 6:54 PM

#

joe am i beating laundmo again?

eternal owl Apr 19, 2021, 6:55 PM

#

which PR is urs @clever wraith ?

dusky shoreBOT Apr 19, 2021, 6:55 PM

#

GitHub

PROpen !superstarify default time

eternal owl Apr 19, 2021, 6:55 PM

#

alright

fervent sage Apr 19, 2021, 6:56 PM

#

sleek steppe Fine my fork it is

oki, add me and we can get to work making lance beautiful(er)

fallen patrol Apr 19, 2021, 6:56 PM

#

fervent sage i'm gonna start up my client again <:mmLol:356831697385422848>

wait how do you have access to a prod database?

fallen patrol Apr 19, 2021, 6:57 PM

#

patent pivot spot laundmo + vco

are they that bump at the beginning?

fervent sage Apr 19, 2021, 6:57 PM

#

no we're the spikes at the end lol

patent pivot Apr 19, 2021, 6:57 PM

#

laund is the first bump iirc

#

laund + vco combined is the second

fallen patrol Apr 19, 2021, 6:57 PM

#

is that a prod db?

clever wraith Apr 19, 2021, 6:58 PM

#

alright joe fixed that small change let me know how it is locally

fallen patrol Apr 19, 2021, 6:59 PM

#

fallen patrol wait how do you have access to a prod database?

is it a prod db?

eternal owl Apr 19, 2021, 7:00 PM

#

requested a small change @clever wraith

fervent sage Apr 19, 2021, 7:00 PM

#

@sleek steppe which branch?

sleek steppe Apr 19, 2021, 7:01 PM

#

https://github.com/ToxicKidz/sir-lancebot/tree/spring-cleanup

#

I think we could just split the seasons in half and work on them

fervent sage Apr 19, 2021, 7:02 PM

#

sure, I'll make a start on evergreen if you want

sleek steppe Apr 19, 2021, 7:02 PM

#

Sounds good

fervent sage Apr 19, 2021, 7:02 PM

#

actually what's on the agenda for being fixed up, it's just general improvements right?

eternal owl Apr 19, 2021, 7:03 PM

#

make sure to read the new comments @clever wraith

fervent sage Apr 19, 2021, 7:03 PM

#

so missing/wrong typehints, any weird spelling, simplifying functions that are needlessly complex, that sorta thing

fallen patrol Apr 19, 2021, 7:03 PM

#

fallen patrol is it a prod db?

@fervent sage pls

sleek steppe Apr 19, 2021, 7:03 PM

#

fervent sage so missing/wrong typehints, any weird spelling, simplifying functions that are n...

Yeah that sounds right

eternal owl Apr 19, 2021, 7:04 PM

#

https://github.com/python-discord/bot/pull/1532
need another review on this

sleek steppe Apr 19, 2021, 7:05 PM

#

I'll start with halloween

#

@fervent sage Do you think it'd be a good idea to change commands.Bot type hints to bot.Bot?

fervent sage Apr 19, 2021, 7:06 PM

#

yes

#

means we get useful suggestions like bot.http_session

#

which i'd have quite liked earlier

eternal owl Apr 19, 2021, 7:11 PM

#

https://github.com/python-discord/bot/pull/1538
need another review on this

whole forge Apr 19, 2021, 7:13 PM

#

fervent sage i'm gonna start up my client again <:mmLol:356831697385422848>

you wont beat my query count let me start mine too

patent pivot Apr 19, 2021, 7:14 PM

#

lol

#

@fallen patrol yeah, it's a prod db, it isn't a prod service

thorny obsidian Apr 19, 2021, 7:14 PM

#

🧹 back to the proper event organizing channel!! 🧹

patent pivot Apr 19, 2021, 7:15 PM

#

they're just running queries on a db in our postgres

fallen patrol Apr 19, 2021, 7:15 PM

#

how did you make it take a lot of concurrent requests?

patent pivot Apr 19, 2021, 7:15 PM

#

lol

clever wraith Apr 19, 2021, 7:15 PM

#

just added a bunch of cats

patent pivot Apr 19, 2021, 7:16 PM

#

it just took them ¯_(ツ)_/¯

#

it's a pretty efficient service and database

sleek steppe Apr 19, 2021, 7:17 PM

#

Hmm, is it preferred to use with ctx.typing() or async with ctx.typing()

fervent sage Apr 19, 2021, 7:18 PM

#

patent pivot Apr 19, 2021, 7:18 PM

#

they're back at it 😔

sleek steppe Apr 19, 2021, 7:18 PM

#

fervent sage

How'd you do it so fast

fervent sage Apr 19, 2021, 7:18 PM

#

smh now that laundmo's doing it again half my requests error

patent pivot Apr 19, 2021, 7:18 PM

#

lmfao

thorny obsidian Apr 19, 2021, 7:18 PM

#

at least we know we'll be able to handle the event even if it gets popular

patent pivot Apr 19, 2021, 7:18 PM

#

which error are you even getting at this point because all i see is 200

patent pivot Apr 19, 2021, 7:18 PM

#

thorny obsidian at least we know we'll be able to handle the event even if it gets popular

lol

fallen patrol Apr 19, 2021, 7:19 PM

#

hey joe, which cog authenicates github requests again?

thorny obsidian Apr 19, 2021, 7:19 PM

#

gah! boring training finally done! I can now accomplish some real work!

fervent sage Apr 19, 2021, 7:19 PM

#

i'm not sure, i dont get the error content because it's getting a json decode error because its returning content type text/html for whatever reason

patent pivot Apr 19, 2021, 7:20 PM

#

fallen patrol hey joe, which cog authenicates github requests again?

what do you mean

patent pivot Apr 19, 2021, 7:20 PM

#

fervent sage i'm not sure, i dont get the error content because it's getting a json decode er...

gold

fallen patrol Apr 19, 2021, 7:20 PM

#

trying to find the code that makes github requests with a token

fervent sage Apr 19, 2021, 7:21 PM

#

p sure its in .src Issues

fallen patrol Apr 19, 2021, 7:21 PM

#

in either @stable mountain or @dusky shore

patent pivot Apr 19, 2021, 7:21 PM

#

uhhh

fervent sage Apr 19, 2021, 7:21 PM

#

l...lmao

fallen patrol Apr 19, 2021, 7:21 PM

#

no that edit was never needed

patent pivot Apr 19, 2021, 7:21 PM

#

I don't think we have authenticated requests yet do we

#

well, all issue stuff is handled on lancebot

#

I know that much

fallen patrol Apr 19, 2021, 7:22 PM

#

smh ur the guy who said they were

fervent sage Apr 19, 2021, 7:22 PM

#

i love how this lancebot cleanup is basically me and toxic for some reason willingly volunteering to review all of the source lmao

fallen patrol Apr 19, 2021, 7:24 PM

#

okay yes

thorny obsidian Apr 19, 2021, 7:24 PM

#

listen I'm just gonna happily accept the work and provide virtual cookies

fallen patrol Apr 19, 2021, 7:24 PM

#

patent pivot I don't think we have authenticated requests yet do we

its in the issues cog but not in the github cog

#

which imo should be merged lmfao

sleek steppe Apr 19, 2021, 7:25 PM

#

Hmm I'm seeing logging.info in one place, shouldn't it be log.info?

fallen patrol Apr 19, 2021, 7:26 PM

#

search for logging

sleek steppe Apr 19, 2021, 7:26 PM

#

logging is the module and log is the Logger object

fallen patrol Apr 19, 2021, 7:26 PM

#

if its logging.INFO that's fine

sleek steppe Apr 19, 2021, 7:26 PM

#

No the function

fallen patrol Apr 19, 2021, 7:26 PM

#

but as a property not a method

fallen patrol Apr 19, 2021, 7:27 PM

#

sleek steppe Hmm I'm seeing logging.info in one place, shouldn't it be log.info?

then yes, probably

stable mountainBOT Apr 19, 2021, 7:31 PM

#

@clever wraith

It has arrived!

Here's your reminder: check on sir-lancebot#294.
[Jump back to when you created the reminder](#dev-contrib message)

clever wraith Apr 19, 2021, 7:31 PM

#

Okay

patent pivot Apr 19, 2021, 7:35 PM

#

patent pivot spot laundmo + vco

update:

fervent sage Apr 19, 2021, 7:35 PM

#

I'm counting this as a success

whole forge Apr 19, 2021, 7:36 PM

#

and what we see here is cloudflare kicking me and vco out because "oh noe a DDoS"

patent pivot Apr 19, 2021, 7:36 PM

#

lmfao

fervent sage Apr 19, 2021, 7:36 PM

#

actually they only kicked you out

#

it still worked fine for me

#

kek

whole forge Apr 19, 2021, 7:37 PM

#

ah, idiots

clever wraith Apr 19, 2021, 7:38 PM

#

whole forge and what we see here is cloudflare kicking me and vco out because "oh noe a DDoS...

Lmao

#

@vale ibex fixed the changes!

fervent sage Apr 19, 2021, 7:40 PM

#

@sleek steppe do you think we should be fixing punctuation inconsistencies, for example a load of messages end with . and many dont, seemingly at random

fallen patrol Apr 19, 2021, 7:43 PM

#

bruh

#

https://github.com/python-discord/sir-lancebot/blob/7c12cbd3cd744cd7df16cc4a5fbaec4058801cfa/bot/exts/evergreen/issues.py#L37-L38

#

where on github does one get one of those tokens?

fervent sage Apr 19, 2021, 7:45 PM

#

https://github.com/settings/tokens

eternal owl Apr 19, 2021, 7:46 PM

#

ye

#

go through the conversations

sleek steppe Apr 19, 2021, 7:46 PM

#

fervent sage <@!506618674921340958> do you think we should be fixing punctuation inconsistenc...

Yeah that makes sense

fervent sage Apr 19, 2021, 7:47 PM

#

sleek steppe Yeah that makes sense

ok, do we go for add . or remove it? i'm minded towards add

eternal owl Apr 19, 2021, 7:49 PM

#

no, just define it below the import statements in the superstarify.py file

#

it should

#

mb, did not include it in the 2nd suggestion

#

looks like you have been mistaken, lol @clever wraith

#

in the function signature, it stays t.Optional[Expiry]

#

duration: t.Optional[Duration]
this should be duration: t.Optional[Expiry]

#

we want to user to either specify the duration or the datetime in ISO format or if they don't specify anything, the default will be duration of 1 hour

#

we need 2 approvals

dusky shoreBOT Apr 19, 2021, 9:32 PM

#

GitHub

IssueOpen Docs command listing order

clever wraith Apr 19, 2021, 9:44 PM

#

hey @patent pivot have you had time to test the .catify locally?

patent pivot Apr 19, 2021, 9:46 PM

#

I've not, I probably won't be able to anytime soon

#

Kat said she'd get around to it

#

but don't stress over it, the feature is done from your point of view for now so you can leave it in our hands and we'll review

clever wraith Apr 19, 2021, 9:47 PM

#

patent pivot Kat said she'd get around to it

alright great!

clever wraith Apr 19, 2021, 9:47 PM

#

patent pivot but don't stress over it, the feature is done from your point of view for now so...

thanks, ill kick back and relax a bit

#

lol

patent pivot Apr 19, 2021, 9:48 PM

#

I'm sure she will at some point or someone else on the Core team will, we are just volunteers at the end of the day

#

actually I can spin up a codespace for catify

#

@clever wraith getting errors locally

#

yeah

#

so

#

single words break it

#

e.g. .catify hello results in ```
04/19/21 22:00:45 - root DEBUG: Error Encountered: ValueError - empty range for randrange() (1, 1, 0), Command: catify, Author: joe#6000, Channel: bot-commands
04/19/21 22:00:45 - bot.exts.evergreen.error_handler ERROR: Unhandled command error: empty range for randrange() (1, 1, 0)
Traceback (most recent call last):
File "/workspaces/sir-lancebot/.venv/lib/python3.8/site-packages/discord/ext/commands/core.py", line 85, in wrapped
ret = await coro(*args, **kwargs)
File "/workspaces/sir-lancebot/bot/exts/evergreen/catify.py", line 36, in catify
for _i in range(random.randint(1, len(string_list) // 2)):
File "/opt/python/3.8.6/lib/python3.8/random.py", line 248, in randint
return self.randrange(a, b+1)
File "/opt/python/3.8.6/lib/python3.8/random.py", line 226, in randrange
raise ValueError("empty range for randrange() (%d, %d, %d)" % (istart, istop, width))
ValueError: empty range for randrange() (1, 1, 0)

sleek steppe Apr 19, 2021, 10:05 PM

#

Smart idea

patent pivot Apr 19, 2021, 10:06 PM

#

@clever wraith another review left

sleek steppe Apr 19, 2021, 10:06 PM

#

For bot#1540, maybe a !redo command?

dusky shoreBOT Apr 19, 2021, 10:06 PM

#

GitHub

IssueOpen If an edited message becomes a command, execute that command

patent pivot Apr 19, 2021, 10:07 PM

#

yeah, as well as inserting a cat at a random index, or altering the nickname

sleek steppe Apr 19, 2021, 10:07 PM

#

are we fine with editing the nickname?

patent pivot Apr 19, 2021, 10:07 PM

#

yep

#

I think that for a command which is invoked by a user knowingly and providing it is documented, nickname altering is fine

#

a nickname is very easy to reset

sleek steppe Apr 19, 2021, 10:09 PM

#

This line is very sad for me 😔 https://github.com/Rapptz/discord.py/blob/master/discord/ext/commands/cog.py#L123

#

It hurts when I see the unused self variable

#

line 121 actually

#

staticmethods solve that

patent pivot Apr 19, 2021, 10:10 PM

#

you can't use staticmethods with discord.py since the context argument must be passed

#

or

#

wait

#

no you can

#

yeah why does no one do that lol

#

I think it's fine without, it's really just a QoL thing and I'd rather keep things standard

#

it's not even QoL really

thorny obsidian Apr 19, 2021, 10:16 PM

#

eeey nice!

sleek steppe Apr 19, 2021, 10:17 PM

#

I finished cleaning up halloween

#

only 14 files changed, 216 insertions(+), 230 deletions(-)

fallen patrol Apr 19, 2021, 10:37 PM

#

!guild

stable mountainBOT Apr 19, 2021, 10:37 PM

#

Server Information

Created: 4 years, 3 months and 11 days ago
Voice region: europe
Features: ANIMATED_ICON, PREVIEW_ENABLED, INVITE_SPLASH, PARTNERED, VIP_REGIONS, NEWS, WELCOME_SCREEN_ENABLED, DISCOVERABLE, RELAY_ENABLED, COMMUNITY, BANNER, MEMBER_VERIFICATION_GATE_ENABLED, VANITY_URL
Roles: 79
Member status: status_online 38951 status_offline 140956

Members: 179907

Helpers: 101
Moderation Team: 29
Admins: 15
Owners: 3
Contributors: 37

Channels: 212

Category: 27
News: 11
Staff: 58
Text: 106
Voice: 10

fallen patrol Apr 19, 2021, 10:37 PM

#

odd.…

#

no additional features...

patent pivot Apr 19, 2021, 10:38 PM

#

which additional features are you looking for

fallen patrol Apr 19, 2021, 10:38 PM

#

#ot2-never-nester’s-nightmare was dead to me

#

red banner and such, even after relaunching discord

#

no other channels in here were affected of what i looked at

patent pivot Apr 19, 2021, 10:38 PM

#

ah

fallen patrol Apr 19, 2021, 10:39 PM

#

this is the only channel where i can view the features

#

figured it was worth a check since some of them mess up typing events

fallen patrol Apr 19, 2021, 11:03 PM

#

fyi i have not forgotten about the color command

#

i just

#

#

i have too many projects but i will get to the command anyhow

sleek steppe Apr 19, 2021, 11:04 PM

#

How close are you to finishing it lol

vocal prairie Apr 19, 2021, 11:04 PM

#

I'll do the same for the about command

#

Eventually

#

Soon

fallen patrol Apr 19, 2021, 11:05 PM

#

sleek steppe How close are you to finishing it lol

barely started lol

#

I have around 6 projects plus school

#

fwiw i have the logic pretty much done just haven't cloned sir-lancebot since i need to do that on an x86 server

#

or well

#

i have an x86 server i just

#

don't wanna go through the pain of trying on ARM

#

and i haven't been doing much with that server for the past week

gritty wind Apr 19, 2021, 11:10 PM

#

@wide elm any reason you're commenting code instead of committing it to Kronifer's fork? Just a bit unusual is all

wide elm Apr 19, 2021, 11:10 PM

#

gritty wind <@!416345453530054657> any reason you're commenting code instead of committing i...

I can commit?

#

LOL

gritty wind Apr 19, 2021, 11:10 PM

#

Kronifer can give you permission to commit to that branch

wide elm Apr 19, 2021, 11:10 PM

#

oh lol

#

Thanks :D

gritty wind Apr 19, 2021, 11:10 PM

#

You wouldn't be able to review, but you probably shouldn't be reviewing your own code anyway

wide elm Apr 19, 2021, 11:11 PM

#

yeah

clever wraith Apr 19, 2021, 11:45 PM

#

gritty wind Kronifer can give you permission to commit to that branch

oh shoot i should do that

#

@wide elm you should be invited to be a collaborator now

short snow Apr 19, 2021, 11:47 PM

#

short snow https://github.com/python-discord/bot/pull/1446#pullrequestreview-638324182 Am n...

bump

and bump: #dev-contrib message

wide elm Apr 20, 2021, 12:10 AM

#

clever wraith <@!416345453530054657> you should be invited to be a collaborator now

ah ok

eternal owl Apr 20, 2021, 7:45 AM

#

@sleek steppe https://github.com/python-discord/sir-lancebot/issues/695

#

@short snow

short snow Apr 20, 2021, 8:51 AM

#

cool, i will have a look, i think i had got a fix for that locally

gritty bolt Apr 20, 2021, 8:56 AM

#

If I have constants inside a class, should they moved outside of the class, to the top of the file?

clever wraith Apr 20, 2021, 9:03 AM

#

gritty bolt If I have constants inside a class, should they moved outside of the class, to t...

yes

gritty bolt Apr 20, 2021, 9:07 AM

#

Okay, thanks

short snow Apr 20, 2021, 9:25 AM

#

bot#1541 , messages already stored in metricity, so should there be another table for help channel messages?

dusky shoreBOT Apr 20, 2021, 9:25 AM

#

GitHub

IssueOpen Process help channel messages

vale ibex Apr 20, 2021, 9:27 AM

#

iirc message meta data is stored. This is going to be the actual content of the message, so that we can do some NLP on it

#

There's some privacy implementation detail that I left out of the issue, which I should add.

vale ibex Apr 20, 2021, 9:49 AM

#

Added that to the issue now

patent pivot Apr 20, 2021, 9:54 AM

#

hello

#

i have commented on the issue

#

metricity will not be used for this I don't think, if anything we'll put it in bot

short snow Apr 20, 2021, 9:57 AM

#

patent pivot metricity will not be used for this I don't think, if anything we'll put it in b...

what would "separate service" be?

patent pivot Apr 20, 2021, 9:57 AM

#

we'll make one

short snow Apr 20, 2021, 9:57 AM

#

like metricity?

patent pivot Apr 20, 2021, 9:57 AM

#

I'm just saying we shouldn't try integrate this into metricity

#

no

short snow Apr 20, 2021, 9:58 AM

#

ok

patent pivot Apr 20, 2021, 9:58 AM

#

it'll be a brand new service, or if not then integrated into bot

vale ibex Apr 20, 2021, 9:59 AM

#

maybe a basic fastapi microservice, with a psql db

#

the bot helpchannel system just posts to this api

patent pivot Apr 20, 2021, 9:59 AM

#

that was what I was thinking

#

yeah

vale ibex Apr 20, 2021, 9:59 AM

#

👍

patent pivot Apr 20, 2021, 9:59 AM

#

and we could even handle compliance at that API

#

so we post all data and the microservice drops it

vale ibex Apr 20, 2021, 10:00 AM

#

Yea, agreed

#

I'm wondering if we should also store opt-out status in this other service then too

patent pivot Apr 20, 2021, 10:00 AM

#

yeah, we should

vale ibex Apr 20, 2021, 10:01 AM

#

Cool, I'll setup a new repo after work and get some issues together

patent pivot Apr 20, 2021, 10:01 AM

#

nice

short snow Apr 20, 2021, 10:01 AM

#

yeah a fastapi microservice would be good, would it be integrated into the site, to see the information

patent pivot Apr 20, 2021, 10:01 AM

#

nah

vale ibex Apr 20, 2021, 10:01 AM

#

!remind 6h fastapi fun times

stable mountainBOT Apr 20, 2021, 10:01 AM

#

Affirmative!

Your reminder will arrive in 6 hours!

patent pivot Apr 20, 2021, 10:01 AM

#

we won't build a frontend for it, since we have the internal tooling to view it and export datasets for those who need access to it

#

it'll be all administrators and a subset of moderators+helpers who want to work with NLP

short snow Apr 20, 2021, 10:02 AM

#

nice, another command for working with it, or just using int e

patent pivot Apr 20, 2021, 10:03 AM

#

no commands on bot should be added other than the necessary opt-in/out commands

#

but no, not int e

#

I mean internal tooling as in off discord

#

short snow Apr 20, 2021, 10:04 AM

#

oh like that

#

how would you do some NLP on it, if you can't get it through any command?

patent pivot Apr 20, 2021, 10:04 AM

#

I'll export from postgres

#

it doesn't need to be pulled into discord (nor do I really think it should)

short snow Apr 20, 2021, 10:06 AM

#

won't it be easier if we pull it into discord

patent pivot Apr 20, 2021, 10:06 AM

#

I don't see why

#

I'd much rather have fine grained control over access rather than dumping ZIP files

#

there is potential for this dataset to be very large

short snow Apr 20, 2021, 10:07 AM

#

dumping zip files? i didn't get you

#

we could access it through an api

#

hmm, yeah it is gonna be fairly a big one

#

i get it know, keeping it off discord would be better 👍

green oriole Apr 20, 2021, 10:08 AM

#

as well as the fact that other communities use metricity
I didn't know it was infrastructure agnostic 👀

patent pivot Apr 20, 2021, 10:09 AM

#

green oriole > as well as the fact that other communities use metricity I didn't know it was ...

lol ya it's not loads of communities but I know of a few

green oriole Apr 20, 2021, 10:11 AM

#

My thoughts with making the dataset public is that anybody could technically scrap the help channels using a self bot, although I didn't think about it privacy wise lemon_sweat

clever wraith Apr 20, 2021, 10:12 AM

#

cant you not make a new commit if u only change doscstring?

#

its saying im working on a clean tree

short snow Apr 20, 2021, 10:16 AM

#

you can ammend to the earlier commit

#

but there is no way to push some change without commiting

clever wraith Apr 20, 2021, 10:16 AM

#

when i try to push it says im working on a clean tree

#

even tho i changed the docstring

#

and i did do all the . git add, all those precommits and so on

vale ibex Apr 20, 2021, 10:17 AM

#

did you git add and git commit before pushing?

clever wraith Apr 20, 2021, 10:17 AM

#

ye ye

vale ibex Apr 20, 2021, 10:17 AM

#

do git log

#

is your commit there?

clever wraith Apr 20, 2021, 10:17 AM

#

i dont think so

#

i did all this yesterday

#

ill just try again

short snow Apr 20, 2021, 10:18 AM

#

which editor are you working on?

clever wraith Apr 20, 2021, 10:18 AM

#

pycharm?

#

is that what ur asking

short snow Apr 20, 2021, 10:19 AM

#

ok then you can press the push button on the cross, and check if you have any commits to push

#

and there is a commit button where you can check which files you have added but not commited

clever wraith Apr 20, 2021, 10:20 AM

#

wait how do i see my full code on github

#

in the issue

#

cuz i only see changes and conversations

short snow Apr 20, 2021, 10:20 AM

#

the files section on the pr tab

clever wraith Apr 20, 2021, 10:21 AM

#

found it

#

wait

#

can i just change it from github?

#

cuz its just docstrings

#

i have an option to edit this file

#

@short snow

short snow Apr 20, 2021, 10:24 AM

#

you could, but you can't lint on github

#

sometimes, the extra whitespaces are left out

#

which are not seen on the diff

#

so i would recommend doing it locally

clever wraith Apr 20, 2021, 10:25 AM

#

ok

#

just said everything is up to date

short snow Apr 20, 2021, 10:27 AM

#

do git status

clever wraith Apr 20, 2021, 10:28 AM

#


Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
        modified:   bot/exts/evergreen/splitify.py```

short snow Apr 20, 2021, 10:28 AM

#

you didn't do git add <file path>

clever wraith Apr 20, 2021, 10:28 AM

#

i just do git add .

#

and i do it after i activate shell

short snow Apr 20, 2021, 10:30 AM

#

ok yeah

#

you forgot git commit -m "good commit message here"

#

Changes to be committed:

clever wraith Apr 20, 2021, 10:30 AM

#

im doing it now, but yeah

#

ok now its all good

short snow Apr 20, 2021, 10:32 AM

#

#dev-log message perfect worked now

clever wraith Apr 20, 2021, 10:32 AM

#

if no one asks for anymore changes i think it could get approved

short snow Apr 20, 2021, 10:49 AM

#

yeah, if no one has any changes, they would approve your pr

#

and once you get 2 approvals from staff, it can get merged

whole forge Apr 20, 2021, 10:56 AM

#

it also helps if you mention the PR in here when talking about it, so that people looking at this channel have a easy time finding it

fervent sage Apr 20, 2021, 11:01 AM

#

@clever wraith since github is being a dick rn, there's `193,000` :nerd: with a space and `perfect square`:exclamation: without one

#

same with the `positive number`:exclamation: one

whole forge Apr 20, 2021, 11:03 AM

#

seems fine to me to have this emoji without a space❗

fervent sage Apr 20, 2021, 11:03 AM

#

its still inconsistent

#

also there's a 400% chance that android's markdown rendering will break at some point soon with something like a codeblock directly next to an emoji

#

since it always does that stuff

whole forge Apr 20, 2021, 11:04 AM

#

consider:
193,000 🤓
193,000 🤓
perfect square❗
perfect square ❗

fervent sage Apr 20, 2021, 11:05 AM

#

tbh i dont see why the perfect square needs to be in a codeblock

clever wraith Apr 20, 2021, 11:05 AM

#

fervent sage <@456226577798135808> since github is being a dick rn, there's `` `193,000` :ner...

yep thats on purpose

#

because discord is being a dick on how it displays emojis

short snow Apr 20, 2021, 11:06 AM

#

lol

fervent sage Apr 20, 2021, 11:06 AM

#

?

#

how does that make it need to be in a codeblock?