no idea what that is lol
#dev-contrib
patent pivot
gritty wind
Got an issue open for that
patent pivot
hmmm, that is interesting
sleek steppe
no idea what that is lol
!pypi jishaku
stable mountainBOT
patent pivot
hmmmmmm
gritty wind
no experience with osx, but on windows you can just have it check and auto sync
patent pivot
bringing on a dep for utils like that feels a bit off
gritty wind
your internal timing is out of sync with discord's, which leads to oddoties with datetime
usually not noticeable with most datetime ops
but when you work in ms, it matters
I can't confirm if this works, but https://superuser.com/questions/369852/force-date-time-clock-sync
oh, comments say it doesn't
it links to
sudo sntp -sS pool.ntp.org
do at your own risk and all the shebang, but this should be fairly innocuous
fallen patrol
have you?
patent pivot
no
giving it more resources is somewhat last resort
we should figure out what is going on first and see if we can mitigate another way
thorny obsidian
Nah, hoping to finish it up today if I can get a clarification on a comment from Akarys
gritty wind
No worries, situation has been resolved. Take your time
fallen patrol
Nah, hoping to finish it up today if I can get a clarification on a comment from...
what pr is it?
sleek steppe
sir-lancebot#673 I know this won't work
dusky shoreBOT
sleek steppe
stable mountainBOT
@patent pivot
It has arrived!
patent pivot
!remind 24h changelog doc changes if no one else has
stable mountainBOT
sleek steppe
nice Oh
fervent sage
Ok, so, currently when there's an error in a command you try to time this happens:
however
patent pivot
~~nice~~ Oh
exams lol
sleek steppe
ctx = getattr(ctx, "subcontext", ctx) 
thorny obsidian
what pr is it?
The lancebot int e is what Scale was referring to. I don't know what number it is
fallen patrol
yes, ik
it was your pr so i thought you would know
anyways, found it and submitted my review
sleek steppe
The lancebot int e is what Scale was referring to. I don't know what number it i...
I linked it though lol
sleek steppe
anyways, found it and submitted my review
A duplicate review?
fallen patrol
i learned a bit more on how to use github*
suggested changes > reviewed
because i did suggest changes in the first one
just not well.…
thorny obsidian
Oh, I already made the fix locally. I don't think the duplicate suggestion was necessary
stable mountainBOT
@vale ibex
It has arrived!
vale ibex
So pillow-simd doesn't seem like an option as far as I can see rn
had to install gcc and build tools on the docker container, since there doesn't seem to be a wheel around
sleek steppe
Docker isn't being friendly https://paste.pythondiscord.com/amiyejakit.less
I have sir-lancebot running but can't stop it 😩
vale ibex
a wheel is a pre-built python dependancy
sleek steppe
I have sir-lancebot running but can't stop it 😩
wait nvm it just stopped 
patent pivot
ahh that sounds about right
yeah
hm
wait
why no wheels
oh
because they just don't have wheels lol
vale ibex
yea lol
Anyways, I'm going to leave that for another day, so that this pfp PR actually gets merged this year
I think after this PR, we should refactor it to be a generic folder for image processing cogs
Don't underestimate procrastination lol
sleek steppe
there are some very old PR's that haven't been merged yet lol
fallen patrol
sir-lancebot#677 will someone approve?
dusky shoreBOT
sleek steppe
Someone needs to make a PR for that lol (I meant the repo#num thingy)
patent pivot
https://github.com/python-discord/sir-lancebot/issues/677
done, I'm going to add a comment with checkboxes of functionality so we can add things gradually
patent pivot
done
fallen patrol
yay
i probably won't look at it anymore until at least start on it next week, this week is a once in a lifetime special to me
🙂 i've had my bone marrow transplant for one year now
and been cancer free for also about that long
.ping @patent pivot
would an issue to port over most of the @stable mountain or create a new ping command for @dusky shore likely be okayed as well?
just realized its non-existent
patent pivot
hmmmmm
don't think we need it
ping has a genuine use on python for checking the status of services, not just as a generic ping pong
fallen patrol
but we could use it anyways, ya?
thorny obsidian
!otn a generic-ping-pong
stable mountainBOT
:ok_hand: Added generic-ping-pong to the names list.
fallen patrol
Command processing time
69.230 ms
Discord API latency
111.634 ms
it would be nice to see those on lancebot as well
patent pivot
it's not necessary, I don't think we should be duplicating that
fallen patrol
after all, that's what's on python and that isn't any more than a typical bot
patent pivot
maybe a very generic .ping to "Pong! 🏓" message, but I'd be fairly against anything else
fallen patrol
ah, could you explain more in detail why?
fallen patrol
```py
Command processing time
69.230 ms
Discord API latency
111.634 ms
```
because I don't fully understand what part of the replied is useful for @stable mountain which wouldn't be for @dusky shore
patent pivot
it's not that it isn't useful for Lancebot, it's just that it's a duplicated feature
fallen patrol
why is that?
patent pivot
we use ping to determine if the site is up, API is responsive, among other things, lancebot doesn't need that functionality because if python reports an error then lancebot is likely susceptible (and lancebot is much less dependent)
patent pivot
@fallen patrol I've specified the issue
fallen patrol
which one
patent pivot
colours
fallen patrol
ah
colo[u]rs
yeah
(what I'll probably do is code everything as color and then replace it all with colour)
fallen patrol
welp
patent pivot
I've split up the features into implementable segments if you want to go through multiple PRs
fallen patrol
that will be my last commit
patent pivot
4 PRs sounds like a decent spread of the work, in order I suggested colour information, random colours, conversions and naming
patent pivot
yep
fallen patrol
add label 🥺
sleek steppe
joe's just fast ¯_(ツ)_/¯
fallen patrol
faster than my internet
brb adding it to the discussion
Some of the features would be:
embedding an image of the color using pillow to create it converting the color to other formats using colorsys giving the closest matching name from one of these two lists (xkcd and this one suggested by joe), merged and stored locally.
fallen patrol
Embed should include:
The colour itself as both the embed colour and as the thumbnail. Colour conversions (see below). Colour name (see below).
patent pivot
fallen patrol
*color
vocal prairie
This kind of colour image?
vocal prairie
Except with other info, of course.
patent pivot
pretty much that! I'd say thumbnail instead though
fallen patrol
!d PIL
stable mountainBOT
patent pivot
one second
vocal prairie
pretty much that! I'd say thumbnail instead though
Yeah, that would be cleaner.
patent pivot
i'll generate a mock embed
vocal prairie
And the embed color should definitely be the color.
patent pivot
yep
fallen patrol
one second
lmfao. Joe said this and then instantly my modmail thread closed
patent pivot
that was on a timer lol
sleek steppe
Who knows
gritty wind
topic use color
fallen patrol
how'd you create that 🥺
fallen patrol
I pinged you in your issue
ah, i'll dm you
vocal prairie
And yes, I'm calling it that just to annoy you.
fallen patrol
I'll provide an actual response on the issue but
vocal prairie
Okie
woven solsticeBOT
woven solsticeBOT
patent pivot
could also consider uhhh
woven solsticeBOT
fallen patrol
this one is better imo
fallen patrol
nah its the fields aren't in line anymore which is imo better
patent pivot
I think that's the one to work towards
fallen patrol
i really really wish there was a way to have two fields in line
fallen patrol
I think that's the one to work towards
fwiw most of what you just sent is like
late game
patent pivot
late game?
vocal prairie
This is cleaner
patent pivot
right, yeah, but it's good to specify anyway
vocal prairie
The other one is too wide imo
fallen patrol
first i have to process the color and everything and then make the embed which is like
really easy to change
patent pivot
added to issue
the reason I used function notation is because it's fairly standard syntax for CSS
vocal prairie
I think 2x2 is better, as long as you can limit width to 2 units instead of 3
Then full function notation would be fine
sleek steppe
I think 2x2 is better, as long as you can limit width to 2 units instead of 3
That doesn't work very well
vocal prairie
Why
sleek steppe
On pc yes, but on mobile there's a big gap
vocal prairie
#1
sleek steppe
Yeah because there isn't any inline on mobile
vocal prairie
#3
sleek steppe
Bikeshedding occurs when a development team spends a disproportionate amount of time and effort on a trivial or unimportant detail of a system, such as the color of a bikeshed
vocal prairie
Eh, this is fun
But this is still fun
@patent pivot Do you have an example of 2x2, just to see?
patent pivot
how do I do 2x2
fallen patrol
<@!165023948638126080> Do you have an example of 2x2, just to see?
its impossible
patent pivot
yeah
vocal prairie
Wait really? I swear I've seen it before.
vocal prairie
Wait, you can add fake fields.
fallen patrol
Wait, you can add fake fields.
!charinfo \u200b
stable mountainBOT
You are not allowed to use that command here. Please use the #bot-commands channel instead.
fallen patrol
zero width space
sleek steppe
Mobile has no inline...so it'll just be a blank field. So it's gonna look bad
fallen patrol
oh shit i just realized
@patent pivot …did you mention anything about redis catching because its color generation
caching should probably be in the spec
patent pivot
<@!165023948638126080> …did you mention anything about redis catching because it...
should be low resource enough to be fine, we can think about that later
fallen patrol
ah
patent pivot
redis will not cache image data though, so we'll have to do a volatile FS cache in that case
fallen patrol
well
vocal prairie
Mobile has no inline...so it'll just be a blank field. So it's gonna look bad
Oh I see.
fallen patrol
should be low resource enough to be fine, we can think about that later
i just learned that creating an image of a specific colour is as simple as img = Image.new('RGBA', (300, 300), (228, 150, 150, 255)) so i think caching won't be too much of an issue
patent pivot
yeah, it should be fine
fallen patrol
hm
the basis of the color command might be easier than i thought
…
no one saw that did they?
vocal prairie
*no one saw that did they?*
#mod-logs
vocal prairie
the basis of the color command might be easier than i thought
It shouldn't be too hard.
Conversion might be fun.
But not too bad.
fallen patrol
is the algorithm that complex to implement outselves?
No
I looked in the source of the library
It's like
3 lines
But I also thought it was part of the stdlib
!d colorsys
stable mountainBOT
fallen patrol
Yeah
It's part of the stdlib
@patent pivot it's up to you if you want me to copy the relevant methods out of the stdlib
patent pivot
Part of it is, yes
So for that we use stdlib
but I thought you were referencing a package for CMYK
fallen patrol
My goal is not to add any dependencies, so whatever is already there is what I'll use
Ah, no
patent pivot
https://stackoverflow.com/a/14088415/12100882
that logic is here
fallen patrol
Can I write formulas?
Go for it :P
vocal prairie
YAY
patent pivot
it should only be necessary for CMYK
vocal prairie
Oh wait, that's in colorsys.
patent pivot
CMYK is not, no
vocal prairie
So only one formula?
patent pivot
I guess it's two if you count to and from
patent pivot
RGB --> CMYK --> RGB
vocal prairie
It's late. That's my excust
fallen patrol
I haven't looked too much into it but I was going to use either hex or rgb to represent every number
Probably rgb
vocal prairie
Why rgb instead of rgba?
patent pivot
We don't need to support transparency
fallen patrol
Right I was gonna actually use rgba 
patent pivot
We can't
vocal prairie
Why?
patent pivot
Our color models, HSV, HSL, RGB and CMYK do not support transparency
fallen patrol
Ah
patent pivot
RGBA is not relevant in this conntext
fallen patrol
True
fallen patrol
Right
vocal prairie
Got it
patent pivot
Pillow can just support RGB
fallen patrol
I mean, it supports RGBA
patent pivot
It does, but we don't need to use that.
For the initial iteration, we probably need to support only RGB/Hex input, since they are identical and can go straight into Pillow
I would strongly advise breaking it up into separate PRs to avoid huge PRs and long review processes.
vocal prairie
Google is giving me conflicting answers on what K is in CMYK.
And how to calculate it.
Is it just 1?
fallen patrol
Google is giving me conflicting answers on what K is in CMYK.
Black
vocal prairie
So do I just put 1?
vocal prairie
Yeah, but what do I use in calculations?
patent pivot
I linked the SO answer from above which seemed to have a good impl
let me test it
alright so
#C763BD is 199, 99, 189 in RGB and 0, 50, 5, 22 in CMYK
vocal prairie
Wait, if that answer exists, there's really no reason for me to write a formula, is there?
patent pivot
In [1]: RGB_SCALE = 255
...: CMYK_SCALE = 100
...:
...:
...: def rgb_to_cmyk(r, g, b):
...: if (r, g, b) == (0, 0, 0):
...: # black
...: return 0, 0, 0, CMYK_SCALE
...:
...: # rgb [0,255] -> cmy [0,1]
...: c = 1 - r / RGB_SCALE
...: m = 1 - g / RGB_SCALE
...: y = 1 - b / RGB_SCALE
...:
...: # extract out k [0, 1]
...: min_cmy = min(c, m, y)
...: c = (c - min_cmy) / (1 - min_cmy)
...: m = (m - min_cmy) / (1 - min_cmy)
...: y = (y - min_cmy) / (1 - min_cmy)
...: k = min_cmy
...:
...: # rescale to the range [0,CMYK_SCALE]
...: return c * CMYK_SCALE, m * CMYK_SCALE, y * CMYK_SCALE, k * CMYK_SCALE
...:
In [2]: rgb_to_cmyk(199, 99, 189)
Out[2]: (0.0, 50.251256281407045, 5.0251256281406995, 21.96078431372549)
other than the rounding required, it got it there
vocal prairie
What's all the ...:?
vocal prairie
So I don't really need to write a formula.
If a formula already exists.
It just needs to round.
patent pivot
yep
vocal prairie
To an int.
So just```py
return round(c * CMYK_SCALE), round(m * CMYK_SCALE), round(y * CMYK_SCALE), round(k * CMYK_SCALE)
With that line, it returns:(0, 50, 5, 22)
short snow
Even review my PRs 
sleek steppe
Which ones
short snow
here they are
Here,
- https://github.com/python-discord/sir-lancebot/pull/673#discussion_r611180044
- https://github.com/python-discord/sir-lancebot/pull/673#discussion_r611180290
These two variables are getting used at multiple places, so would they be constants?
sleek steppe
sleek steppe
Ah ok
short snow
pillow simd didn't complain for me, hmmm
lemme try that in docker
Btw, would anyone like to solve https://github.com/python-discord/sir-lancebot/issues/549 with me?
vocal prairie
I'd be willing to.
sleek steppe
Can we upgrade to discord.py v1.7.1 too?
vocal prairie
how badly have i fucked up
I don't have context, but I doubt it's that bad.
placid ermine
apparently @dusky shore keeps dying because of the latex
sleek steppe
lol
fallen patrol
apparently <@!528937022996611082> keeps dying because of the latex
Just a few times
I think @patent pivot mitigated it somehow
short snow
I'd be willing to.
sure, which seasons would you like to handle
sleek steppe
vocal prairie
Okie
sleek steppe
Can I do evergreen then lol
vocal prairie
Why not
short snow
push changes thro PRs to my fork, do you want to fork my fork, or would like to have push access?
placid ermine
i think i have a fix to the latex consuming too much memory
i can't reproduce the problem on my test bot though
sleek steppe
push changes thro PRs to my fork, do you want to fork my fork, or would like to ...
I like the sound of forking your fork better lol
short snow
so even you want to help?
sleek steppe
Yeah
sullen phoenix
we coulddd just raise our set resource limits on sir lancebot
although, do you know how much memory the latex command can take?
sleek steppe
I like the sound of forking your fork better lol
actually forking sounds not too good I'd like push access
short snow
lol, tell me one option.
cc: @vocal prairie
placid ermine
it looks like the memory usage just spikes as soon as there is bad input
it jumped from 63MB to 112MB and then to 159MB
and it doesn't drop down either
for proper input there is hardly any change
hmm
sullen phoenix
hmm alrighty, that would probably be something you’d want to look into then
placid ermine
I think I should handle this error in the cog itself instead of raising BadArgument
short snow
are you storing the image as a image or in bytes?
placid ermine
in bytes for sending, also saving it as a png in cache
short snow
if we store it as bytes in cache, would it reduce the space, and is that possible
placid ermine
I don't think that would reduce RAM usage
If I had to guess, the problem is that the figure isn't removed from memory when there is an error
short snow
I think I should handle this error in the cog itself instead of raising BadArgum...
this could be done, if thats the case
try raising multiple errors, and does it increase with every error?
placid ermine
yes
placid ermine
it jumped from 63MB to 112MB and then to 159MB
.
vocal prairie
push changes thro PRs to my fork, do you want to fork my fork, or would like to ...
I can fork the fork
vocal prairie
lol, tell me one option.
cc: <@!788119126450765844>
Option of what?
sharp timber
oh
short snow
fork the fork, or get push access to fork
sharp timber
I've seen something about this issue before
vocal prairie
fork the fork, or get push access to fork
Fork the fork.
sharp timber
We're not closing the figure after generating it
short snow
perfect
sharp timber
@staticmethod
def _render(text: str, filepath: pathlib.Path) -> BytesIO:
"""
Return the rendered image if latex compiles without errors, otherwise raise a BadArgument Exception.
Saves rendered image to cache.
"""
fig = plt.figure()
rendered_image = BytesIO()
fig.text(0, 1, text, horizontalalignment="left", verticalalignment="top")
try:
plt.savefig(rendered_image, bbox_inches="tight", dpi=600)
except ValueError as e:
raise commands.BadArgument(str(e))
finally:
plt.close(fig)
rendered_image.seek(0)
with open(filepath, "wb") as f:
f.write(rendered_image.getbuffer())
return rendered_image
i tried plt.close(fig)
sharp timber
Did you use finally: to ensure it fires regardless of exception status?
sharp timber
Try firing a gc.collect() after plt.close
You will probably have to import gc in there to do so
For temporary debugging only, this is not a serviceable default fix
placid ermine
nope, still doesn't drop
sharp timber
I would try rewriting it to use the base class method, rather than pyplot, next then
It should be fairly straightforwards since I don't see complicated stuff here
fallen patrol
we coulddd just raise our set resource limits on sir lancebot
joe said that was a last resort
sullen phoenix
yeah, that's what i'm thinking as well
sharp timber
I would fire up a fork myself but I am about to be passing out
hopefully that link is helpful
!remindme 12H ^ check on
stable mountainBOT
fallen patrol
I would fire up a fork myself but I am about to be passing out
smh chainsaws tho
sharp timber
I have earplugs
fallen patrol
lol
vocal prairie
A fork? I would personally use a knife.
fallen patrol
fire up a fork == flaming pitchforks
vocal prairie
What, knives are sharper.
fallen patrol
fire up a knife == ???
vocal prairie
A knife lit on fire.
placid ermine
See https://matplotlib.org/stable/gallery/user_interfaces/web_application_server...
will look into it, thank
short snow
@sleek steppe lets just use forks then
@short snow - christmas, easter, pride
toxic - evergreen
@vocal prairie - utils, halloween, valentine
sounds good?
vocal prairie
That works.
placid ermine
YES
latex fixed
it never crosses 110MB anymore
not matter how many times you give bad input
vocal prairie
Yay!
placid ermine
for some reason using matplotlib.figure.Figure instead of matplotlib.pyplot.figure fixed it
vocal prairie
Weird. But that's good.
fallen patrol
Weird. But that's good.
go figure
short snow
ahhhh, it has been locking past 10 minutes
updated all dependencies to supported latest, for supporting 3.9
on lance
cold moon
@short snow @vocal prairie @sleek steppe So all of you will work on sir-lancebot#549 together?
short snow
yeah, since it is kinda big issue, and needs lot of testing
cold moon
Okay, I can assign you already, others need to comment in issue first before I can assign.
short snow
wait why didn't lance put the issue embed?
Toxic and dawn i think it might be easier to do the changes according to the libraries rather than cog wise
patent pivot
I think <@165023948638126080> mitigated it somehow
it's not that
this is actual OOM
surreal venture
I need to add some emojis to my server for the stackoverflow command, but if I store them on my server and use my server's emoji_id, then it won't work on this server right?
tough imp
You can use the local config to override the IDs for local development, and keep the production config as is
If you're adding new emoji you can ask a staff member to add them to the production emoji guild and give you the IDs so that you can configure the prod env
surreal venture
okie thanks!
gritty wind
Hey, this channel is for pythondiscord projects, not for advertising your own. If you'd like to discuss your own, try the off-topic channels, or the relevant topical channel
surreal venture
sir-lancebot#583
surreal venture
Hey, this channel is for pythondiscord projects, not for advertising your own. I...
it is a pydis project
gritty wind
I deleted a message
gritty wind
no worries
short snow
sir-lancebot#583
weird why is sir lancebot failing on this
surreal venture
weird why is sir lancebot failing on this
yeah I was wondering the same
gritty wind
Yup, in that sense
short snow
only on on_message right?
gritty wind
I do not know
placid ermine
so uh the way i fixed the memory issue is pretty weird
i have to clear the figure, del the figure and run gc.collect()
removing any of those makes it stop working
gritty wind
Are you working on the latex thing?
placid ermine
yes
gritty wind
I already have a fix that just limits memory
But if you also have a memory cleaner, that would be a nice addition
placid ermine
hmm
turned out there's a memory usage spike whenever there is improper input
placid ermine
For temporary debugging only, this is not a serviceable default fix
why is that though
gritty wind
Even if you managed to clean up input perfectly, you shouldn't give people a function that runs code internally without any memory protections
I'm not sure what Bast's reason is, but that's the reason for my fix
placid ermine
yeah i'm not trying to clean the input, i'm just trying to make sure the memory is cleared even for bad input
gritty wind
The problem isn't clearing it i don't think
the problem is it tries to allocate more than is available
no amount of cleaning will matter if you never get past the allocation
placid ermine
well the memory usage does seem to stay within a certain limit now
hasn't crossed 110mb
although tbh i don't really know whether the way i'm measuring it is right
i'm just looking at the memory usage for the python process in task manager
short snow
I do not know
hmm, any logs?
gritty wind
Sir-lancebot basically logs nothing
There is no error except for the ones introduced in the PR
with parsing or whatever
I literally have no idea, I haven't been keeping up
short snow
ok no worries, i will look into it
short snow
hmm, on updating it to python3.9 and discord.py1.7.1
i get this error
can't seem to understand it
vale ibex
bot/utils/pagination/LinePaginator subclasses paginator
looks like in the new version of d.py there's a new attribute, that .close_page() is looking for, and it doens't exist
short snow
it needs a super.__init__(), since we calling close_page(), which we have not written i.e. doesn't exist, and there is no linesep in our init, so it is looking for one
so should i add linesep or do super.__init__()
vale ibex
depends if you want to overwrite it, or use the default
short snow
linesep is added in 1.7, ahh that's why
vale ibex
yea, there's going to be a bunch of new things added in the new version of d.py
so I imagine there's going to be more things like this
vale ibex
👍
balmy sparrow
was there a reason for not subclassing HelpCommand in lancebot?
that'd be the standard way of making a help command for a bot, so the current way feels a bit more complicated than it needs to be
vale ibex
Not entirely sure on the reasons for the decision, I wasn't around back then
cold moon
I think there is issue for migrating
short snow
@vale ibex #dev-log message yes we are upgrading to python3.9.4
vale ibex
Cool, I'll update the issue title
gritty wind
due to python's dependency hell, we'll be upgrading to... nothing 👀
vale ibex
hah the description is so accurate
green oriole
Haha yeah
vocal prairie
<@!736234578745884682> <@!788119126450765844> <@!506618674921340958> So all of y...
Yes, I'll go ahead and comment.
short snow
https://xkcd.com/2347/
so right, it is 🤯
whole forge
https://xkcd.com/2347/
leftpad
sleek steppe
What version of Python and d.py is Lancebot on right now?
According to Pipfile, discord.py is version 1.5.1, and python is version 3.8
vocal prairie
Oh, so we're not upgrading that much.
Now I have to go read the changelogs.
I have no idea what came when.
sleek steppe
@short snow If I'm forking your fork that means I have to delete my fork right?
vocal prairie
<@!736234578745884682> If I'm forking your fork that means I have to delete my f...
Just delete your fork of PyDis Lancebot, and then fork Jason Lancebot.
cold moon
Hmm, other way is that Jason give you write access to his fork, so changes can be pushed directly to there
short snow
yeah i asked them which one they would like, they went with forks, so i was fine
short snow
According to Pipfile, discord.py is version 1.5.1, and python is version 3.8
i updated them to be 1.7.1 and 3.9 on Pipfile
see my fork's update/python3.9 branch
stable mountainBOT
fallen patrol
that source is really helpful btw
i have used that code to learn how to rjust strings rather than find the docs 
whole forge
leftpad was a npm thing, almost every npm package used it and t hen the author deleted it
what followed was a glorious clusterfuck of breaking builds
because of a 12-line npm package
whole forge
yea
vocal prairie
Yarn is better.
short snow
dawn you want push access or still want to work with fork?
advantage with push is, you won't need to pull and rebase everytime
and you won't need to delete the pydis fork
deft patrol
👀
vocal prairie
dawn you want push access or still want to work with fork?
advantage with push i...
Then pushing is fine.
whole forge
why would you need to delete any forks? just add the other fork as a seperate remote, manually merge over the changes, make your changes and ask the other person to merge back, or PR into the other persons fork
short snow
there you go @vocal prairie @sleek steppe
and you could work on branches like: update/python3.9/dawn
fallen patrol
there you go <@!788119126450765844> <@!506618674921340958>
and you could work o...
what is going on on your fork?
whole forge
also why not PR into the fork from a different fork?
short snow
investigating update to python 3.9.4
short snow
also why not PR into the fork from a different fork?
that would be tiring, rebasing and pulling everytime
stable mountainBOT
vocal prairie
Yes, because fancy new features.
fallen patrol
@stable mountain uses 3.8
vocal prairie
Sebastiaan explained it in the issue.
whole forge
that would be tiring, rebasing and pulling everytime
better than having to merge because origin changed while you were editing
short snow
there you go <@!788119126450765844> <@!506618674921340958>
and you could work o...
[edited]
vocal prairie
sir-lancebot#549
dusky shoreBOT
fallen patrol
ohhh there's an issue for it
fervent sage
Yarn is better.
i dont see how that's relevant to the leftpad stuff?
fallen patrol
short snow
it worked now 👀
vocal prairie
it worked now 👀
No
thorny obsidian
Typing generics is worth the cutover. Lancebot doesn't need to match Python exactly
short snow
ah ok
vocal prairie
short snow
so i need to look into the regex it seems
whole forge
regex fix still hasnt been merged ig
we discussed it extensively yesterday but i had to go
short snow
!remind 10H fix the issue with automatic issue mapper
stable mountainBOT
thorny obsidian
Who was going to PR the regex fix? I don't remember
whole forge
no clue, i had to go
short snow
i will delete the reminder if thats the case
fervent sage
laundmo probably should since iirc he did most of the work in beefing up and making the regex better
fallen patrol
Who was going to PR the regex fix? I don't remember
no one lol
whole forge
if it was just the regex, i would, but people kept wanting to add additional checks and i just dont wanna bother with that
fervent sage
i think the regex is most important right now to make it work
fallen patrol
i'd say fix the regex and any additional features can be added later
fervent sage
^
dusky shoreBOT
fervent sage
people can add all the checks they want after the fact, but currently a very useful feature is totally broken
fallen patrol
it would be nice for it to repeat the repo and issue/pr number in a later pr
whole forge
fair, just gonna PR from the web editor then lol
fallen patrol
so that's a later fix
vocal prairie
fair, just gonna PR from the web editor then lol
That's probably best.
fallen patrol
^
placid ermine
lul
whole forge
hah, my PR passed flake8 even though i literally have no linter in the web version
vocal prairie
Noice
whole forge
dusky shoreBOT
fallen patrol
i don't know what i was expecting
whole forge
not yet lol
fervent sage
i didnt realise how important that feature was to us until it broke
? (context: someone added 10 'youtried' emojis)
vocal prairie
That's a lot of stars.
fallen patrol
pls 
fervent sage
we have reached peak rotat banan
fallen patrol
someone approve it even if the regex doesn't always work
whole forge
but it works in more cases than it should
whole forge
it allows a--b/a--b#123
fallen patrol
Actually, I can just test the regEx.
yeah
vocal prairie
Is it supposed to allow *s?
fervent sage
whole forge
Is it supposed to allow *s?
allow *s?
vocal prairie
asterisks
whole forge
where does it do thaT?
vocal prairie
python/cp*ython#4865 returns ython#4865 for me.
fallen patrol
its supposed to work for now
vocal prairie
oh wait, that'll return invalid.
fallen patrol
^
vocal prairie
So it doesn't matter.
whole forge
python/cp*ython#4865 returns ython#4865 for me.
yeah because asterisk isnt allowed in github
vocal prairie
Okie, then it's fine.
fallen patrol
the problem is if it matches above a /
basically it should error somehow
but
this is to make it usable
.issue 555
i
that command should really be allowed here
would be a bit of a solution to the auto linker
vocal prairie
Why does the pr say that linting wasn't done?
Is there just no point?
Since it's the same?
whole forge
because i literally cant lint, i did this all in the web
fervent sage
because linting wasnt done
whole forge
yes
fervent sage
if you dont do something dont say you did /shrug
vocal prairie
But eh, ig it doesn't really matter.
whole forge
and i mean the actions auto-lint so
i did commit a second time to make sure linting has a better chance of passing
kinda wanna see if i can get the review done instantly if i ping akarys, because akarys is the one that bonked it
🎶 git blame tightens
whole forge
jo @vale ibex any chance we could speed-merge https://github.com/python-discord/sir-lancebot/pull/680
because sir-lancebot#680
sleek steppe
@short snow you made commits to evergreen 😦
fervent sage
could be restarting
fallen patrol
there's no ping command
placid ermine
nop
fallen patrol
nope take it up with joe
whole forge
@patent pivoteeeeeeeeeeeeeeeeeeeeeeeeeeee (lancebot ping command when)
fervent sage
atjoe ping command ples
fallen patrol
would be redundant to python is what he said
if something is affecting python it would be affecting sir lance as well
vocal prairie
Reasoning: to see if lancebot goes brrrrr
whole forge
nice to check whether its bonked
deft patrol
off messages n messages 🥴
fallen patrol
we use ping to determine if the site is up, API is responsive, among other things, lancebot doesn't need that functionality because if python reports an error then lancebot is likely susceptible (and lancebot is much less dependent)
vocal prairie
if something is affecting python it would be affecting sir lance as well
Yeah, but like, the latex sometimes screwed it up, what says something else can't.
fervent sage
i like to always have ping commands and always have them public because even if you dont care about ping it can show you if the bot is dead
patent pivot
I didn't say no ping
whole forge
literally just respond with pong
fervent sage
ok ping command pr in 10 :)
whole forge
also while your here joe can you merge https://github.com/python-discord/sir-lancebot/pull/680
patent pivot
or something short
fallen patrol
ok ping command pr in 10 :)
make it embed at least
vocal prairie
Can I pr the ping, or does someone else want to?
fervent sage
vocal prairie
Go ahead
patent pivot
@whole forge done
vocal prairie
sir-lancebot#680
dusky shoreBOT
patent pivot
won't have deployed yet
vocal prairie
Didn't deploy yet ig.
patent pivot
takes a few minutes at least
you'll see it restart in #dev-log
but yeah I agree a ping command would be nice to have, it's just that when I was approached about it the proposal was to rip the one out of @stable mountain
which is total overkill
whole forge
agree
fervent sage
i'm just gonna create an embed that says pong + ws latency
patent pivot
sounds good
fervent sage
since thats all thats really needed
patent pivot
mayyyybe uptime?
fervent sage
sure
fallen patrol
.uptime
patent pivot
just thinking to know when this actually did deploy
fallen patrol
sir-lancebot#680
dusky shoreBOT
patent pivot
kinda a useful thing sometimes
dusky shoreBOT
I started up 22 seconds ago.
placid ermine
lol
patent pivot
nevermind then, just pong + ws latency
fallen patrol
!uptime
vocal prairie
Noice one laundmo
vocal prairie
*python needs the uptime command*
Why, when you can check #dev-log?
fallen patrol
why not, when sir-lancebot has it
patent pivot
it would be nice to include uptime and hit SHA
Maybe we add an !about command
!about
include some details on the bot project
fallen patrol
.about
whole forge
test with a full repo name julvo/reloading#11
whole forge
nice
placid ermine
interesting
vocal prairie
Should I open an issue for reference?
patent pivot
nah it's fine to just PR
vocal prairie
Time to set up a test server.
placid ermine
While y'all here
how do you feel about a fix to the latex which doesn't make 100% sense but works?
whole forge
!otn a joe's-issueless-PR's
fervent sage
short and simple
vocal prairie
While y'all here
how do you feel about a fix to the latex which doesn't make 100...
That sounds good to me.
patent pivot
A link to this conversation and a summary of what we decided and why wouldn't go amiss in the PR
@fervent sage maybe use lancebot green colour
fervent sage
ok
patent pivot
your colour SUCKS worst blue ever
fallen patrol
Nah it doesn't suck
fervent sage
doesnt suck as much as you 
fallen patrol
@fervent sage gimme hex
fervent sage
87ceeb
patent pivot
say it again and I'll find you
vale ibex
say it again and I'll find you
now thats some mosh pit hair
fallen patrol
say it again and I'll find you
U look like the least threatening teen I have ever seen
fervent sage
has been my main pfp colour on most of my pfps so its useful to know
patent pivot
now thats some mosh pit hair
haircut booked April 20th
fervent sage
if you grep -r "87CEEB" . basically any of my bot repos you'll probably find it somewhere 
whole forge
dont cut it off, let it grow into a mane
vocal prairie
@short snow @sleek steppe Want to set up a test server for the upgrade?
patent pivot
lmfao
vale ibex
haircut booked April 20th
I need to book mine in soon
fallen patrol
!ot
stable mountainBOT
vale ibex
you have 5 seconds or i use vco blue <:kek:585617800257863727>
bot.constants.Colours.green?
fervent sage
kk
vale ibex
I think
fallen patrol
bot.constants.Colours.green?
That took at least 8 seconds
whole forge
bot.constants.Colours.green?
AttributError
vocal prairie
The light green or the dark green?
vale ibex
it might be like soft_green or something
it has green in it 😄
ah yea, light_green or dark_green
whole forge
class Colours:
blue = 0x0279fd
bright_green = 0x01d277
dark_green = 0x1f8b4c
orange = 0xe67e22
pink = 0xcf84e0
purple = 0xb734eb
soft_green = 0x68c290
soft_orange = 0xf9cb54
soft_red = 0xcd6d6d
yellow = 0xf9f586
python_blue = 0x4B8BBE
python_yellow = 0xFFD43B
grass_green = 0x66ff00
take your pick
dusky shoreBOT
YOU wIll NeveR UNseE iT
patent pivot
lol looks good
fervent sage
i was so close to committing this
placid ermine
lol
fervent sage
100% didnt copy the file :)
fallen patrol
Lmfao
fervent sage
but its my code anyway so its fine
whole forge
actually i dont see a single embed using that green
its a darker one for the ones that are gree
vocal prairie
Me neither
whole forge
scrolling though #sir-lancebot-playground
vocal prairie
They all use default or dark green
fervent sage
bot#1
dusky shoreBOT
vocal prairie
Nvm
vale ibex
I imagine there may be a few constants that just aren't used anymore
fallen patrol
Search for ittttt
fallen patrol
Use a color picker and mouse over it
fervent sage
vocal prairie
At least for me.
fallen patrol
!raw #dev-contrib message
stable mountainBOT
You are not allowed to use that command here. Please use the #bot-commands channel instead.
whole forge
I imagine there may be a few constants that just aren't used anymore
at some point im going to create a reference counting class that works exactly like the arguemnt it gets, but counts how often and where its accessed in any way
fallen patrol
!raw https://discord.com/channels/267624335836053506/635950537262759947/83153675...
Someone pls do it it's relevant
vocal prairie
Color: 0x1d277
whole forge
!raw #dev-contrib message
stable mountainBOT
== Raw embeds (1/1) ==
author:
name: GitHub
url: https://github.com/python-discord
color: 0x1d277
description:  [Add "Now playing" status](https://github.com/python-
discord/bot/pull/1)
type: rich
There's the color
fallen patrol
I rep the file too
If you want to grep it again, please talk to a union representative
fervent sage
actually bright green is even less common than soft_green - it's used solely in the issues cog once
whole forge
then do soft
fervent sage
bright looks nicer tbh
vale ibex
I'm against having colours named as their colour IE soft_green
fervent sage
okay colour bikeshedding session
well if we're going to
vale ibex
We should have success/failure etc
whole forge
colour is less typing and less typo prone
vale ibex
yea, having the colours named after their function
fervent sage
Colours.ping
vale ibex
hah
vocal prairie
yea, having the colours named after their function
Yeah, that would be easier imo.
whole forge
Colours.ping
from bot.constants import Colours
Colours.ping = 0x1d277
monkey patch go brrrr
vale ibex
lol
fervent sage
why update files when you can monkey patch classes
fervent sage
one 16k line file that monkeypatches every other file
fallen patrol
okay colour bikeshedding session
Colors.bikeshedding = 0xff0000
sleek steppe
it's 87ceeb
yes.
whole forge
> `dir(Colors)`
`color`
class Colours:
def __getattribute__(self, name):
return 0x87ceeb
Also how do you update python for pipenv 
vocal prairie
#9cfff1 is the color I use for embeds on my bots.
fallen patrol
```py
class Colours:
def __getattribute__(self, name):
return 0x87ce...
*color
sleek steppe
Colour
fervent sage
colour
fallen patrol
Color
whole forge
its colour in the repo currently
vocal prairie
color, but colour is used more
fervent sage
embed = Embed(
colour=randrange(0, 0xFFFFFF),
...,
)
It's wrong. Use color.
vale ibex
Also how do you update python for pipenv <:thonk:785637987480371220>
pipenv is a package against a python version. So you update python and then install pipenv on the new environment
fallen patrol
pipenv is a package against a python version. So you update python and then inst...
Or update python with pipenv lol
fervent sage
It's wrong. Use color.
uh, this feels quite aggressive...
sleek steppe
pipenv is a package against a python version. So you update python and then inst...
Ah I see
fallen patrol
uh, this feels quite aggressive...
Color is the only answer
sleek steppe
> py -3.8 -m pip uninstall pipenv
> pip install pipenv
I'm guessing
vale ibex
Let's chill out with the color vs colour argument.
fallen patrol
Color is the only answer
No one saw that I just realized I had a typo
vale ibex
```
> py -3.8 -m pip uninstall pipenv
> pip install pipenv
```
I'm guessing
so py -x.x will choose which python environment you use you use
But pipenv creates a virtual env within the dir when you init it
sleek steppe
I don't even have pipenv on 3.8
vale ibex
so you'll need to delete the virtual env for that folder and make a new one with the new python version
vale ibex
if you activate your pipenv shell
you can do pipenv --rm
then you can do pipenv --python 3.9 or whatever
sleek steppe
Should the ping command have a 🏓 ?
vocal prairie
That would be nice.
whole forge
wait how many people are working on the ping command right now?
sleek steppe
just vco
fervent sage
okie ping command is sir-lancebot#681
dusky shoreBOT
fervent sage
Should the ping command have a 🏓 ?
done
sleek steppe
LGTM
fervent sage
we need that cloudflare worker that filters github events to do something else too
it needs to translate :shipit: into for the webhook
@patent pivot with the gateway thing every other time i've made ping commands people complain to me that they dont know what the gateway is, this is one of the only times i havent used it, i guess there's no winning either way
patent pivot
hmmm, I prefer gateway to just WS, alternatively "Discord WebSocket" or "Discord Gateway" might be good
fervent sage
oh yeah, i definitely prefer more discord-y terms
but apparently not everyone enjoys reading the developer docs for entertainment
(they should)
vocal prairie
Agreed
I still have a pr open to them
They're quite interesting.
Anyway, "Discord Gateway" sounds clear to me.
fervent sage
i'm just gonna leave it at 'Gateway' - again that's secondary to the main purpose which is just seeing that the bot isnt dead
fallen patrol
we need that cloudflare worker that filters github events to do something else t...
Doesn't github send them directly to here?
patent pivot
No, it doesn't
fallen patrol
Then
patent pivot
it needs to translate `:shipit:` into <:shipit:826492371813400637> for the webho...
LOL NOT A BAD SHOUT
I love it
fervent sage
i got about as far as actually opening the worker's index.ts before i realised i had no idea what i was doing and went back lol
fallen patrol
Lmfao
fallen patrol
Does it reformat them for discord?
fallen patrol
Like?
patent pivot
uhhh
fallen patrol
Ah
I thought you could filter that with githubs options
So how exactly is the chain configured?
patent pivot
Coveralls, stuff from bots (cloudflare pages), all dependabot stuff, bot PR approvals, empty review comments
you can't filter with that granularity at GitHub
You can only say "I want all push events"
not "I want push events but not from X users"
fallen patrol
Ah
patent pivot
So now we go from GitHub into a Cloudflare Worker 
which forwards on to Discord
vocal prairie
dependabot?
gritty wind
Updates dependency versions on some projects
sleek steppe
Oh for the colour command, in 1.7 they support rgb(x, x, x)
short snow
<@!736234578745884682> you made commits to evergreen 😦
I replied and pinged you guys earlier than it would be easier doing the changes library wise.
fallen patrol
holy shit you can now mention voice channels and join them by clicking
sleek steppe
Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.
Ooof how to fix it
fallen patrol
sleek steppe
holy shit you can now mention voice channels and join them by clicking
yes that is true
fallen patrol
```
Another git process seems to be running in this repository, e.g.
an editor o...
rm -rf ./git /s don't
short snow
<@!736234578745884682> <@!506618674921340958> Want to set up a test server for t...
Sure just bot commands should be enough
sleek steppe
Or do I just delete this file -> .git/index.lock
fallen patrol
¯_(ツ)_/¯
short snow
say it again and I'll find you
Lol I was just like you until yesterday, when all my hard work got cut in 5 minutes
sleek steppe
Or do I just delete this file -> `.git/index.lock`
Ah yeah that worked
stable mountainBOT
@sharp timber
It has arrived!
short snow
Or should I comment it on the original issue on the sir Lance repo
sleek steppe
I guess that would work
I changed asyncio.ensure_future -> asyncio.create_task and loop.run_in_executor -> asyncio.to_thread
sleek steppe
Hmm should I PR now
short snow
Dunno, if you have tested it right and it works perfectly, a push should be good
sleek steppe
I changed typing.Iterable to collections.abc.Iterable since it's deprecated in 3.9
short snow
👍
sleek steppe
I know I can get assigned if I comment but what do I even comment lol
short snow
lol
also
it has even been done for,
from collections.abc import Mapping, Sequence, Callable
you could update those too
vale ibex
@short snow You're likely going to need to upgrade dev dependencies as part of the python upgrade too
short snow
i just gave a bump to dev dependencies, other dependencies are to be updated as they introduce support for python3.9
vale ibex
Alright cool, just checking as I saw they were missing from your table on the issue
If they're dealt with, then no worries
sleek steppe
AttributeError: 'LinePaginator' object has no attribute 'max_lines' that's an interesting error
short snow
hmm, it worked for me lemme see the code one minute
vocal prairie
I don't know if I should click the link…
short snow
no, i by mistake removed self.max_lines = max_lines
does it work after adding self.max_lines = max_lines, toxic?
sleek steppe
yep
short snow
cool, you can just add it with your commit
sleek steppe
best_board, _count = min(current_board_counts.items(), key=operator.itemgetter(1))
current_board_count is an empty iterable
I can just except the ValueError
short snow
yeah, since there no boards given to it