#dev-contrib | Python | Page 83

dusky shoreBOT Feb 9, 2021, 12:19 PM

#

Command Help

.wolfram <query>
Can also use: wolf, wa

Requests all answers on a single image, sends an image of all related pods.

Subcommands:
cut <query>
Requests a drawn image of given query.
page <query>
Requests a drawn image of given query.
short <query>
Requests an answer to a simple question.

patent pivot Feb 9, 2021, 12:20 PM

#

.wa short time in florida

dusky shoreBOT Feb 9, 2021, 12:20 PM

#

Wolfram Alpha

07:20:16 Eastern Standard Time, Tuesday, 9 February 2021

short snow Feb 9, 2021, 12:20 PM

#

oh, didn't know that

surreal venture Feb 9, 2021, 1:55 PM

#

RuntimeError: Session is closed Why's that? I'm using self.bot.http_session

#

async with self.bot.http_session as session:
    async with session.get(...) as response:
        ...

green oriole Feb 9, 2021, 1:56 PM

#

You shouldn’t use the first with block

#

just async with self.bot.http_session.get(...) as response:

surreal venture Feb 9, 2021, 1:56 PM

#

Ah I see

#

Also where is the http_session defined?

#

of the bot?

green oriole Feb 9, 2021, 1:57 PM

#

Probably in bot.bot

surreal venture Feb 9, 2021, 1:58 PM

#

oh yeah it's there

short snow Feb 9, 2021, 2:35 PM

#

first review on mobile!!! 🙃

mossy wolf Feb 9, 2021, 3:04 PM

#

short snow first review on mobile!!! 🙃

nice congrats on getting the first review passed

#

i'm still waiting after a reject for changes

green oriole Feb 9, 2021, 3:10 PM

#

!remind 18h Write an issue about the phan message

stable mountainBOT Feb 9, 2021, 3:10 PM

#

You're the boss!

Your reminder will arrive in 18 hours!

green oriole Feb 9, 2021, 3:10 PM

#

and prove f1re wrong while you’re at it :P

gritty wind Feb 9, 2021, 3:10 PM

#

What PR are you looking at, I’m pretty sure I don’t know what granularity is either lmao

short snow Feb 9, 2021, 3:33 PM

#

mossy wolf nice congrats on getting the first review passed

It was the first review on mobile, i have 5-6 otherwise on pydis

clever wraith Feb 9, 2021, 4:01 PM

#

@green oriole would a tag on blocking/non-blocking be a good idea?

#

not an entire one on concurrency

gritty wind Feb 9, 2021, 4:03 PM

#

If you can succinctly explain it, I wouldn't mind it. If you think you can, feel free to draft something up, but keep in mind if it has to be really long in order for it to achieve its purpose, we'd be better off including resources instead of explaining it ourselves

cold moon Feb 9, 2021, 4:05 PM

#

I think blocking/non-blocking quick summary (show blocking and non-blocking) would be useful for #discord-bots

#

And like giving few examples about blocking libraries and non-blocking libraries.

clever wraith Feb 9, 2021, 4:06 PM

#

gritty wind If you can succinctly explain it, I wouldn't mind it. If you think you can, feel...

yeah sure, i'll try and keep it short

clever wraith Feb 9, 2021, 4:06 PM

#

cold moon I think blocking/non-blocking quick summary (show blocking and non-blocking) wou...

yes this is what i was thinking of

#

ok dumb question, how do I pull from the python-discord/bot repo to my fork so its up to date?

green oriole Feb 9, 2021, 4:10 PM

#

git remote add upstream https://git.pydis.com/bot
git checkout master
git pull upstream master
git push origin master```

#

You will only need to run the first command once

clever wraith Feb 9, 2021, 4:12 PM

#

@green oriole was doing git pull upstream master and got this:

fatal: 'upstream/master' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

green oriole Feb 9, 2021, 4:13 PM

#

Okay, try again with a space instead or a slash

clever wraith Feb 9, 2021, 4:13 PM

#

ok works

short snow Feb 9, 2021, 4:22 PM

#

Here is what i do

clever wraith Feb 9, 2021, 4:28 PM

#

should I make a new branch, or just commit directly on master?

#

also, what's this? Don't forget to lint!

gritty wind Feb 9, 2021, 4:29 PM

#

new branches is usually what's expected for fork & pull models

#

We have pre-commit which basically runs a few checks on your code/work to make sure it meets the style guide requirements

#

If you're writing a tag, you're unlikely to hit many errors, but there are still a few

#

if you have pipenv installed, you can run

#

pipenv install --dev
followed by
pipenv run lint

#

(all in the root directory of the project, so where you see the Pipfile file)

clever wraith Feb 9, 2021, 4:30 PM

#

i don't have pipenv

#

how to install?

gritty wind Feb 9, 2021, 4:30 PM

#

pip install pipenv

#

I would usually say it's a requirement, but if you aren't planning on contributing code often to the projects its fine to skip

short snow Feb 9, 2021, 4:31 PM

#

u have pycharm?

clever wraith Feb 9, 2021, 4:31 PM

#

no vscode

surreal venture Feb 9, 2021, 4:56 PM

#

Pycharm warning: Package containing module 'discord' is not listed in project requirements

#

I guess it's because it's called "discord.py" in the Pipfile and not discord

gritty wind Feb 9, 2021, 4:57 PM

#

Yeah it's a little funky

#

But you can mostly ignore that error for d.py

green oriole Feb 9, 2021, 4:57 PM

#

Yeah, you can ignore it

#

It is a configuration error on d.py side

surreal venture Feb 9, 2021, 4:58 PM

#

yeah

surreal venture Feb 9, 2021, 6:09 PM

#

Is there a way to make HTML encoded content (like "Hello") into a normal python string ('Hello')?

brazen charm Feb 9, 2021, 6:10 PM

#

html.unescape

surreal venture Feb 9, 2021, 6:11 PM

#

Thanks!

mossy wolf Feb 9, 2021, 6:12 PM

#

cold moon I think blocking/non-blocking quick summary (show blocking and non-blocking) wou...

https://discordpy.readthedocs.io/en/latest/faq.html#what-does-blocking-mean

balmy sparrow Feb 9, 2021, 6:13 PM

#

yeah that FAQ is what i usually link to people too there

mossy wolf Feb 9, 2021, 6:13 PM

#

it's too long for a tag really

📎 unknown.png

clever wraith Feb 9, 2021, 6:13 PM

#

mossy wolf https://discordpy.readthedocs.io/en/latest/faq.html#what-does-blocking-mean

this is where I point out people don't always like to read docs

#

kek

balmy sparrow Feb 9, 2021, 6:13 PM

#

it's a good enough explanation that's easily accessible though

clever wraith Feb 9, 2021, 6:13 PM

#

lets move this convo somehwere else in #ot0-psvm’s-eternal-disapproval

balmy sparrow Feb 9, 2021, 6:13 PM

#

clever wraith this is where I point out people don't always like to read docs

the FAQ isn't written in the same style as the documentation though

#

it's much more approachable

gritty wind Feb 9, 2021, 6:14 PM

#

I don't really like the idea of using the discord tag, because there is quite a bit of it specific to the d.py library

#

Calling this the blocking tag when it's mostly related to d.py is misleading

cold island Feb 9, 2021, 6:14 PM

#

The idea of blocking seems too much for a tag

clever wraith Feb 9, 2021, 6:14 PM

#

cold island The idea of `blocking` seems too much for a tag

ok

surreal venture Feb 9, 2021, 6:25 PM

#

Is the format for emojis <:emoji_name:emoji_id>?

green oriole Feb 9, 2021, 6:26 PM

#

Think so

gritty wind Feb 9, 2021, 6:27 PM

#

I think in code you just need the name and id without the <>

#

!int e

await ctx.send("![dice_1](https://cdn.discordapp.com/emojis/755891608859443290.webp?size=128 "dice_1")")

stable mountainBOT Feb 9, 2021, 6:27 PM

#

dice_1

#

In [1]: await ctx.send("![dice_1](https://cdn.discordapp.com/emojis/755891608859443290.webp?size=128 "dice_1")")```

gritty wind Feb 9, 2021, 6:27 PM

#

ah nevermind

surreal venture Feb 9, 2021, 6:30 PM

#

Thanks!

#

Pycharm and Discord both don't work well with the emoji selector thing in Ubuntu

gritty wind Feb 9, 2021, 6:32 PM

#

windows finally wins out? :D

surreal venture Feb 9, 2021, 6:32 PM

#

nah ubuntu's the best

#

😅

#

*linux

clever wraith Feb 9, 2021, 7:43 PM

#

i made a PR, and the lint test failed, anything to be worried about?

obsidian patio Feb 9, 2021, 7:46 PM

#

That simply means that your code doesn't follow the required formatting. You could set up a precommit in order to avoid this in the future

clever wraith Feb 9, 2021, 7:46 PM

#

obsidian patio That simply means that your code doesn't follow the required formatting. You cou...

ok

obsidian patio Feb 9, 2021, 7:46 PM

#

For now, simply fix the linting issues and you'll be all good

#

What project is it for?

clever wraith Feb 9, 2021, 7:46 PM

#

obsidian patio What project is it for?

hmm? oh I was making a tag

#

and run pre-commit hooks failed

#

for the python bot

obsidian patio Feb 9, 2021, 7:47 PM

#

Hmm, not sure how that could fail the lint. Could you link the PR?

gritty wind Feb 9, 2021, 7:47 PM

#

It's probably trailing whitespace, or new lines

clever wraith Feb 9, 2021, 7:47 PM

#

more specifically, Trim Trailing Whitespace.................................................Failed

#

how would I fix that?

gritty wind Feb 9, 2021, 7:47 PM

#

It means you have somnthing like:
this is an example

clever wraith Feb 9, 2021, 7:48 PM

#

gritty wind It means you have somnthing like: `this is an example `

ok

gritty wind Feb 9, 2021, 7:48 PM

#

You need to remove the extra whitespace after text or on new lines

clever wraith Feb 9, 2021, 7:48 PM

#

ok

#

i removed it, but still i got the trailing-whitespace failed

obsidian patio Feb 9, 2021, 7:50 PM

#

Could you link the PR?

gritty wind Feb 9, 2021, 7:50 PM

#

Oh that's not what I meant

#

let me get an example from the actual code

clever wraith Feb 9, 2021, 7:50 PM

#

hold on

gritty wind Feb 9, 2021, 7:51 PM

#

Here for example
**Resources for Further Reading**

#

You have a space after the last star

clever wraith Feb 9, 2021, 7:52 PM

#

ok

#

why does it check for whitespace?

obsidian patio Feb 9, 2021, 7:52 PM

#

Here is where there's a trailing whitespace in the example, just to make it extra clear

📎 Screenshot_2021-02-09_at_20.51.50.png

clever wraith Feb 9, 2021, 7:53 PM

#

ok

#

i removed everything thinking

#

why is it giving this?

#

I removed all whitespaces

#

@obsidian patio

obsidian patio Feb 9, 2021, 7:56 PM

#

I can't provide any more help if you don't send me a link to the PR

clever wraith Feb 9, 2021, 7:57 PM

#

ok

#

i get this:

Fix End of Files.........................................................Failed

#

https://github.com/python-discord/bot/pull/1410/

GitHub

Added blocking tag by MrKomodoDragon · Pull Request #1410 · python-...

gritty wind Feb 9, 2021, 7:57 PM

#

That's because you probably pushed with windows line endings

#

That's a whole topic, but the point is git should've automatically caught for you with a default setup

buoyant grove Feb 9, 2021, 7:58 PM

#

hey

vale ibex Feb 9, 2021, 8:01 PM

#

Do you have the pre-commit hook setup @clever wraith ?

vale ibex Feb 9, 2021, 8:01 PM

#

buoyant grove hey

👋

thorny obsidian Feb 9, 2021, 8:02 PM

#

If you're on windows you need to alter the pre-commit to fix it

buoyant grove Feb 9, 2021, 8:02 PM

#

vale ibex 👋

i am completing the 50 msg to speak in vcs

thorny obsidian Feb 9, 2021, 8:03 PM

#

After troubleshooting, numerlor helped me to get to this solution

📎 unknown.png

vale ibex Feb 9, 2021, 8:05 PM

#

Huh, I didn't need to change the pre commit hook, just doing git config core.autoclrf input worked for me

#

I'm interested in why the pre commit change was needed

gritty wind Feb 9, 2021, 8:06 PM

#

You may need to modify sometimes if you're using certain IDEs because flake8 is fucky

thorny obsidian Feb 9, 2021, 8:06 PM

#

I work from vscode and don't actually use git cmd line

gritty wind Feb 9, 2021, 8:06 PM

#

but they don't really need flake8 for a tag haha

vale ibex Feb 9, 2021, 8:07 PM

#

thorny obsidian I work from vscode and don't actually use git cmd line

ahhh, that makes sense. I use vsc and had errors when trying to commit, I didn't bother looking into it and just used cmd line, I might give that a go

#

Is this in notion?

thorny obsidian Feb 9, 2021, 8:07 PM

#

my personal notion page

vale ibex Feb 9, 2021, 8:07 PM

#

Any chance you can copy the hook code? 😄

clever wraith Feb 9, 2021, 8:07 PM

#

vale ibex Do you have the pre-commit hook setup <@456226577798135808> ?

no

thorny obsidian Feb 9, 2021, 8:07 PM

#

if sys.platform == 'win32':  # https://bugs.python.org/issue19124
    import subprocess

    if sys.version_info < (3, 7):  # https://bugs.python.org/issue25942
        raise SystemExit(subprocess.Popen(CMD).wait())
    else:
        raise SystemExit(subprocess.run([INSTALL_PYTHON.replace('python.exe', 'activate.bat'), '&&', *CMD]).returncode)
        #raise SystemExit(subprocess.call(CMD))
else:
    os.execvp(CMD[0], CMD)

vale ibex Feb 9, 2021, 8:07 PM

#

👍

brazen charm Feb 9, 2021, 8:08 PM

#

Wasn't there a pr that was supposed to fix it? or was that for something else

gritty wind Feb 9, 2021, 8:08 PM

#

it was already merged iirc

#

The relevant change:
https://github.com/python-discord/bot/commit/d3492b961618f4d6d0ec6622cffda3dadcd4b7a4

brazen charm Feb 9, 2021, 8:10 PM

#

seems to work now after a new precommit install

thorny obsidian Feb 9, 2021, 8:11 PM

#

I'm too lazy to change my set-up 😎

vale ibex Feb 9, 2021, 8:11 PM

#

Yea, looks like it. Re-running pipenv run precommit and my python install path is setup for my pipenv env

vale ibex Feb 9, 2021, 8:12 PM

#

clever wraith no

I would suggest setting it up, as you can then run these checks on your local machine before pushing to the repo

brazen charm Feb 9, 2021, 8:12 PM

#

Only non standard thing for pycharm I have now is mockign sys.stdout.isatty to get proper colored logs

vale ibex Feb 9, 2021, 8:13 PM

#

Run these steps:

python -m pip install pipenv to install pipenv.
2.python -m pipenv shell from the bot root dir to enter the pipenv env.
pipenv sync --dev to install project dependencies
pipenv run precommit to install the hook.

brazen charm Feb 9, 2021, 8:14 PM

#

brazen charm Only non standard thing for pycharm I have now is mockign sys.stdout.isatty to g...

and looks like those work too now

gritty wind Feb 9, 2021, 8:15 PM

#

vale ibex Run these steps: 1. `python -m pip install pipenv` to install pipenv. 2.`python ...

Do you also have to install depends?

vale ibex Feb 9, 2021, 8:15 PM

#

Hmmm, possibly?

#

@clever wraith #dev-contrib message

clever wraith Feb 9, 2021, 8:18 PM

#

vale ibex I would suggest setting it up, as you can then run these checks on your local ma...

ok

clever wraith Feb 9, 2021, 8:19 PM

#

vale ibex Run these steps: 1. `python -m pip install pipenv` to install pipenv. 2.`python ...

python, or python3?

vale ibex Feb 9, 2021, 8:20 PM

#

depends, what os are you running?

clever wraith Feb 9, 2021, 8:20 PM

#

vale ibex depends, what os are you running?

mac

vale ibex Feb 9, 2021, 8:20 PM

#

yea, python3

clever wraith Feb 9, 2021, 8:21 PM

#

ok, so how would I fix the line ending thing anyway?

sleek steppe Feb 9, 2021, 8:22 PM

#

check each line for whitespace at the end I guess

gritty wind Feb 9, 2021, 8:22 PM

#

The line endings are different from the whitespace

#

The precommit hook should be able to fix both anyways

#

But..

#

Due to some git funkiness, it'll appear locally as though you changed every file in the repo

#

It shouldn't be a problem though

clever wraith Feb 9, 2021, 8:23 PM

#

after doing pipenv run precommit, what should I do?

gritty wind Feb 9, 2021, 8:23 PM

#

When you go to commit, it'll automatically run

clever wraith Feb 9, 2021, 8:24 PM

#

gritty wind When you go to commit, it'll automatically run

ok

gritty wind Feb 9, 2021, 8:24 PM

#

If you have no changes, you can manually trigger to run pipenv run lint

clever wraith Feb 9, 2021, 8:28 PM

#

ok

#

i still get Fix End of Files.........................................................Failed

gritty wind Feb 9, 2021, 8:29 PM

#

Does it say changed under that?

clever wraith Feb 9, 2021, 8:29 PM

#

Fix End of Files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing bot/resources/tags/blocking.md

full outpt

gritty wind Feb 9, 2021, 8:30 PM

#

Right, so it failed and fixed them

#

You should be good now

#

If you'd like to be 100% sure, run it again

#

it should pass

clever wraith Feb 9, 2021, 8:31 PM

#

ok

#

what's coverall?

gritty wind Feb 9, 2021, 8:35 PM

#

Code Coverage, essentially how much of the codebase has unit testing

#

Doesn't matter for tags though

clever wraith Feb 9, 2021, 8:39 PM

#

ok

clever wraith Feb 9, 2021, 9:34 PM

#

how long does it take for a pull requests to be revied/merged?

brazen charm Feb 9, 2021, 9:35 PM

#

Depends on its complexity, people's availability and how much needs to be changed

clever wraith Feb 9, 2021, 9:44 PM

#

brazen charm Depends on its complexity, people's availability and how much needs to be change...

ok

vale ibex Feb 9, 2021, 10:15 PM

#

@clever wraith What editor are you using to code?

clever wraith Feb 9, 2021, 10:16 PM

#

vale ibex <@456226577798135808> What editor are you using to code?

vscode

#

:D

vale ibex Feb 9, 2021, 10:16 PM

#

Open the .md file and look at the top right of vsc

#

You should see this bar

📎 unknown.png

#

Clicking the second button will preview the .md file with formatting

clever wraith Feb 9, 2021, 10:16 PM

#

ok

vale ibex Feb 9, 2021, 10:16 PM

#

You will need to add some line breaks in between the different sections

clever wraith Feb 9, 2021, 10:17 PM

#

ok

cold island Feb 10, 2021, 2:00 AM

#

He's probably not available rn, no point in pinging him twice

clever wraith Feb 10, 2021, 2:01 AM

#

ok

#

so how is it?

short snow Feb 10, 2021, 5:49 AM

#

ok. till 18th i don't think i would be able to mention any changes on the two prs, so they would be stale for a week.

#

sorry.

#

would appreciate if someone gives reviews on the two till then

gritty wind Feb 10, 2021, 5:50 AM

#

Don't worry, you're always free to step back

#

You can get back to your PRs when you have time

short snow Feb 10, 2021, 5:51 AM

#

ok thanks. my finals start from 18th hence.

green oriole Feb 10, 2021, 7:51 AM

#

Good luck for your finals!

stable mountainBOT Feb 10, 2021, 9:10 AM

#

@green oriole

It has arrived!

Here's your reminder: Write an issue about the phan message.
[Jump back to when you created the reminder](#dev-contrib message)

green oriole Feb 10, 2021, 9:10 AM

#

phan

lament hedge Feb 10, 2021, 5:38 PM

#

did the way to create fake redis change? cuz doing taskCache = RedisCache(use_fakeredis=True) throws TypeError: __init__() got an unexpected keyword argument 'use_fakeredis'

vale ibex Feb 10, 2021, 5:39 PM

#

Anyone know why I got a ping here?

#

Can't see a message that would have caused it

lament hedge Feb 10, 2021, 5:40 PM

#

#dev-contrib message

vale ibex Feb 10, 2021, 5:40 PM

#

Yea, I replied to that one already

vale ibex Feb 10, 2021, 5:40 PM

#

lament hedge did the way to create fake redis change? cuz doing ```taskCache = RedisCache(use...

What repo?

lament hedge Feb 10, 2021, 5:41 PM

#

trying to create fake redis for testing from async_rediscache

vale ibex Feb 10, 2021, 5:41 PM

#

is this for sirlancebot or bot?

lament hedge Feb 10, 2021, 5:41 PM

#

bot

vale ibex Feb 10, 2021, 5:41 PM

#

in config.yml set use_fakeredis to true

subtle kraken Feb 10, 2021, 5:42 PM

#

RedisSession is the thing that accepts that keyword

#

fwiw

lament hedge Feb 10, 2021, 5:42 PM

#

subtle kraken `RedisSession` is the thing that accepts that keyword

ahh yea

surreal venture Feb 10, 2021, 6:03 PM

#

Uh I think I had accidentally reverted the Issue Regex thing using git revert how do I revert the revert?

#

Whyyy does git need to be so confusing 😦

#

Should I just manually change it?

#

git pull upstream master isn't changing it

#

WHY

vale ibex Feb 10, 2021, 6:08 PM

#

git revert just creates a commit that is the opposite of the commit your reverting

#

It doesn't remove a commit from the history

green oriole Feb 10, 2021, 6:09 PM

#

There is a way to obliterate a commit from existence, but I wouldn't recommend it

surreal venture Feb 10, 2021, 6:09 PM

#

Yes, but how can I revert it? Should I just revert the revert commit?

rapid swallow Feb 10, 2021, 6:09 PM

#

git reset (replying to akarys)

vale ibex Feb 10, 2021, 6:09 PM

#

You could just commit the change back into the branch, since removing the revert commit from history isn't recommended

rapid swallow Feb 10, 2021, 6:09 PM

#

surreal venture Yes, but how can I revert it? Should I just revert the revert commit?

you could jump back to the commit or something

vale ibex Feb 10, 2021, 6:09 PM

#

So just make the change again and commit it

surreal venture Feb 10, 2021, 6:09 PM

#

vale ibex So just make the change again and commit it

So manually?

rapid swallow Feb 10, 2021, 6:10 PM

#

yeah, that's the easiest way

#

I guess you could checkout the old commit

#

it'll still be there

surreal venture Feb 10, 2021, 6:10 PM

#

isn't git checkout for changing branches?

#

Okay thanks its fixed

tawdry vapor Feb 10, 2021, 6:15 PM

#

git checkout can check out arbitrary refs.

#

A ref can be any commit

#

Though it's more idiomatic to do git reset <commit sha>, possibly with the --hard option if you want to discard the revert commit entirely

#

I think if you use git checkout it'd put you in a detached HEAD

clever wraith Feb 10, 2021, 6:17 PM

#

would a chatbot feature be good for @dusky shore

surreal venture Feb 10, 2021, 6:17 PM

#

Chatbot as in an AI-powered chatbot?

#

or what?

clever wraith Feb 10, 2021, 6:18 PM

#

surreal venture Chatbot as in an AI-powered chatbot?

^

#

there are a couple apis

surreal venture Feb 10, 2021, 6:19 PM

#

I don't know, you might need to create an entirely new channel for that

#

to converse with the bot

clever wraith Feb 10, 2021, 6:19 PM

#

yes

surreal venture Feb 10, 2021, 6:19 PM

#

plus to just ask questions we have the wolfram-alpha command.

#

.wa

vale ibex Feb 10, 2021, 6:20 PM

#

Your best bet would be to raise an issue, select feature and try to best describe your suggestion

#

It'll give us the opportunity to give feedback and keep the discussion in one place.

clever wraith Feb 10, 2021, 6:21 PM

#

ok

static shale Feb 10, 2021, 6:47 PM

#

i have a problem with the GitHub python-discord / bot bot

#

📎 unknown.png

cold moon Feb 10, 2021, 6:59 PM

#

static shale i have a problem with the GitHub `python-discord / bot` bot

You have to use pipenv to run bot instead manual execution. You should read our contributing guide: https://pythondiscord.com/pages/contributing/bot/

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

static shale Feb 10, 2021, 7:08 PM

#

but then can i do os.system("pipenv sys.executable") or something similar?

#

what?

umbral scroll Feb 10, 2021, 7:10 PM

#

just wanted to create a dev group

vale ibex Feb 10, 2021, 7:14 PM

#

static shale but then can i do os.system("pipenv sys.executable") or something similar?

Why do you need to do that?

vocal wolf Feb 10, 2021, 7:14 PM

#

@umbral scroll this is the place to discuss the development of repos from the org of pydis.

static shale Feb 10, 2021, 7:15 PM

#

vale ibex Why do you need to do that?

to execute the python script from itself with pipenv

umbral scroll Feb 10, 2021, 7:16 PM

#

@vocal wolf ohh my bad i just wanted to post a project i wanted to colab. May u point me in the right direction

vale ibex Feb 10, 2021, 7:16 PM

#

Could you give our contributing guide a read? https://pythondiscord.com/pages/contributing/bot/

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

It explains how to get setup and run the bot

#

I think you are misunderstanding how to get it running

static shale Feb 10, 2021, 7:17 PM

#

I want to do this:
The code starts itself with pipenv like ```py
os.system("pipenv (the path to the python script)")

vale ibex Feb 10, 2021, 7:17 PM

#

umbral scroll <@!196664644113268736> ohh my bad i just wanted to post a project i wanted to co...

If you are looking for help/code review etc then a help channel might be the best place, check out #❓｜how-to-get-help

vale ibex Feb 10, 2021, 7:18 PM

#

static shale I want to do this: The code starts itself with pipenv like ```py os.system("pipe...

That's not how to start the bot. You run pipenv run start from cmd

umbral scroll Feb 10, 2021, 7:18 PM

#

nope i want some contributors

#

but anyways i appriciate ur help

static shale Feb 10, 2021, 7:18 PM

#

vale ibex That's not how to start the bot. You run `pipenv run start` from cmd

but i want to start it from the script itself

gritty wind Feb 10, 2021, 7:19 PM

#

umbral scroll nope i want some contributors

We don't have a channel for finding contributors, you'd be better off on the subreddit or discussing your project in the relevant topical channel and catching people's attention

vale ibex Feb 10, 2021, 7:19 PM

#

Then you'd need to set the current working directory to the root of the project, activate the pipenv shell and then run pipenv run start

static shale Feb 10, 2021, 7:20 PM

#

ok

#

but i have an idea

gritty wind Feb 10, 2021, 7:20 PM

#

vale ibex Then you'd need to set the current working directory to the root of the project,...

You don't need to activate the shell, you can run right away

vale ibex Feb 10, 2021, 7:20 PM

#

You'd need the path to the pipenv python binary right?

gritty wind Feb 10, 2021, 7:21 PM

#

If you want to do pipenv run directly, but if you have it installed globally it should be fine. python -m pipenv run would also work

static shale Feb 10, 2021, 7:22 PM

#

i have an idea for this

#

📎 unknown.png

gritty wind Feb 10, 2021, 7:23 PM

#

I... what? Why are you not just doing pip install pipenv lmao

static shale Feb 10, 2021, 7:24 PM

#

gritty wind I... what? Why are you not just doing `pip install pipenv` lmao

To do it silently and without the "script location" warning

vale ibex Feb 10, 2021, 7:24 PM

#

Why are you scripting this?

static shale Feb 10, 2021, 7:25 PM

#

TO DO IT FROM THE SCRIPT

#

ok wtf happened

#

d

📎 unknown.png

gritty wind Feb 10, 2021, 7:26 PM

#

Alright, you don't need to be abrasive, this channel is very much not meant for what you're doing

vale ibex Feb 10, 2021, 7:26 PM

#

Yea, I understand that, but what is doing it from a script gaining over just running the install from the command line?

#

As its a one time install

gritty wind Feb 10, 2021, 7:27 PM

#

Eh it just runs python under the hood, so it'll open it in a different window

#

probably

vale ibex Feb 10, 2021, 7:27 PM

#

That error specifically is most likely due to you missing a -

static shale Feb 10, 2021, 7:28 PM

#

I created a new file to start the bot

#

📎 unknown.png

#

oh yea

#

(in python)

gritty wind Feb 10, 2021, 7:29 PM

#

vale ibex That error specifically is most likely due to you missing a `-`

^

#

a single - is usually only followed by a single letter, words are prefixed with --

vale ibex Feb 10, 2021, 7:29 PM

#

You might want to look into the docker workflow if starting the bot locally is an issue

static shale Feb 10, 2021, 7:30 PM

#

ok... when i use pipenv... it gives the CMD error that pipenv is not a command

gritty wind Feb 10, 2021, 7:30 PM

#

Try python -m pipenv

static shale Feb 10, 2021, 7:30 PM

#

oh

#

mmmmmm.................

#

Warning: Python 3.8 was not found on your system...
Neither 'pyenv' nor 'asdf' could be found to install Python.
You can specify specific versions of Python with:
$ pipenv --python path\to\python

#

(i use python 3.9.1)

gritty wind Feb 10, 2021, 7:32 PM

#

What did you put?

static shale Feb 10, 2021, 7:32 PM

#

📎 unknown.png

#

but doesn't really care

#

cuz i dont have python 3.8

gritty wind Feb 10, 2021, 7:33 PM

#

You need to have 3.8 to run the bot

static shale Feb 10, 2021, 7:34 PM

#

or install pyenv and asdf to install py 3.8 via pipenv

#

but i cant install pyenv for windows because doesnt appear here https://github.com/pyenv/pyenv#installation and i cant install it via pip (WTF??)

GitHub

pyenv/pyenv

Simple Python version management. Contribute to pyenv/pyenv development by creating an account on GitHub.

gritty wind Feb 10, 2021, 7:36 PM

#

pyenv will just install python 3.8 for you

#

Pipenv will insist you use 3.8, unless you manually override it

static shale Feb 10, 2021, 7:37 PM

#

but i cant install pyenv for windows

gritty wind Feb 10, 2021, 7:37 PM

#

You don't need to, as all it literally will do for your case is install python 3.8

static shale Feb 10, 2021, 7:38 PM

#

yes i know

#

but im a bit lazy to install python

gritty wind Feb 10, 2021, 7:38 PM

#

See this line?

[requires]
python_version = "3.8"

#

in Pipfile

green oriole Feb 10, 2021, 7:38 PM

#

Well, you will need Python for our projects

gritty wind Feb 10, 2021, 7:38 PM

#

you are free to change it

#

but we will not support any changes you make

#

If things act weird, it will be hard for us to debug and fix

static shale Feb 10, 2021, 7:39 PM

#

gritty wind See this line? ```py [requires] python_version = "3.8" ```

where

gritty wind Feb 10, 2021, 7:39 PM

#

The file titled Pipfile

static shale Feb 10, 2021, 7:40 PM

#

i found it

#

📎 unknown.png

#

No module named colorama

#

but its not a 3.9 error, its just that colorama was not imported

green oriole Feb 10, 2021, 7:42 PM

#

Can you run py -v?

static shale Feb 10, 2021, 7:42 PM

#

3.9

green oriole Feb 10, 2021, 7:42 PM

#

Okay, now run pipenv --python 3.9 sync

static shale Feb 10, 2021, 7:43 PM

#

python -m pipenv --python 3.9 sync

green oriole Feb 10, 2021, 7:43 PM

#

Sure

gritty wind Feb 10, 2021, 7:43 PM

#

colorama doesn't have binaries for 3.9 iirc

green oriole Feb 10, 2021, 7:43 PM

#

Ung

static shale Feb 10, 2021, 7:43 PM

#

gritty wind colorama doesn't have binaries for 3.9 iirc

it does

gritty wind Feb 10, 2021, 7:43 PM

#

I mean i'm literally looking at their pypi page, but if it works for you, it works ig

green oriole Feb 10, 2021, 7:43 PM

#

Is pipenv syncing right now?

static shale Feb 10, 2021, 7:44 PM

#

just the colorama was not imported (replying to Scaleios)

static shale Feb 10, 2021, 7:44 PM

#

green oriole Is pipenv syncing right now?

yep

green oriole Feb 10, 2021, 7:44 PM

#

Sweet

#

Tell us when it is done

static shale Feb 10, 2021, 7:45 PM

#

green oriole Tell us when it is done

me*

#

not us

thorny obsidian Feb 10, 2021, 7:45 PM

#

colorama's last wheel upload was oct 12, python 3.9's earliest stable release was oct 5. I don't think colorama had binaries ready that quickly

static shale Feb 10, 2021, 7:46 PM

#

but i use colorama in a py code and it works but in another file it doesnt work R O T F F L M F A O
o n h u l a y u s f
l e c o u c s f
l k o g k
i i r h i
n n i n
n 😄

green oriole Feb 10, 2021, 7:53 PM

#

What is that

gritty wind Feb 10, 2021, 7:54 PM

#

yeet time

static shale Feb 10, 2021, 7:54 PM

#

green oriole What is that

Rollin On The Fuckin Floor Laughing My Fuckin Ass Off

#

@green oriole done

green oriole Feb 10, 2021, 7:55 PM

#

Let's not send such messages please

#

Okay so

#

Are you in the bot or the site?

static shale Feb 10, 2021, 7:56 PM

#

in the bot with CMD open

#

And again, the circular import error

green oriole Feb 10, 2021, 7:57 PM

#

Do you have the site setup?

static shale Feb 10, 2021, 7:57 PM

#

what site

green oriole Feb 10, 2021, 7:58 PM

#

You need to have a local copy of our site in order to get the bot working

static shale Feb 10, 2021, 7:58 PM

#

BUT WHAT SITE IS THAT

green oriole Feb 10, 2021, 7:58 PM

#

Well, pythondiscord.org

#

You can find the source code at https://git.pydis.com/site

GitHub

python-discord/site

pythondiscord.com - A Django and Bulma web application. - python-discord/site

#

Can you clone that and open a new command line in it?

static shale Feb 10, 2021, 8:00 PM

#

- I'll dinner now and I will not come back today but
+ I (maybe) come back tomorrow

OK?

green oriole Feb 10, 2021, 8:00 PM

#

Alrighty

static shale Feb 10, 2021, 8:00 PM

#

green oriole Can you clone that and open a new command line in it?

i have the original but tomorrow or past tomorrow

green oriole Feb 10, 2021, 8:01 PM

#

Sure thing, be sure to ping me when you come back

clever wraith Feb 10, 2021, 8:31 PM

#

could someone look at this PR and give feedback?https://github.com/python-discord/bot/pull/1410

GitHub

Added blocking tag by MrKomodoDragon · Pull Request #1410 · python-...

vale ibex Feb 10, 2021, 8:39 PM

#

I've given it a quick once over, I'm going to grab some dinner now though, so tag me if you have any questions.

#

Are you able to get a screenshot of what it looks like when the bot sends it? That could be useful to anyone else code reviewing it.

#

If not, I could get one for you when I'm back.

clever wraith Feb 10, 2021, 8:42 PM

#

vale ibex Are you able to get a screenshot of what it looks like when the bot sends it? Th...

how do I run the bot?

gritty wind Feb 10, 2021, 8:42 PM

#

If it's @stable mountain you should be able to follow this guide
https://pythondiscord.com/pages/contributing/bot/

#

It's a bit long though, so someone can just get it for you

clever wraith Feb 10, 2021, 8:43 PM

#

i installed dependencies

gritty wind Feb 10, 2021, 8:43 PM

#

Ah okay

#

Did you get the site up and running?

clever wraith Feb 10, 2021, 8:43 PM

#

gritty wind Did you get the site up and running?

wha?

gritty wind Feb 10, 2021, 8:44 PM

#

Having the site (which contains the API) running is part of the requirements

#

https://pythondiscord.com/pages/contributing/bot/#requirements

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

you can either set it up manually, or use docker to run everything for you

#

that tag is still a bit long huh

#

I can barely get it in one screenshot

#

📎 unknown.png

vale ibex Feb 10, 2021, 8:50 PM

#

In what instance are we expecting this tag to be invoked?

#

If its when someone uses a blocking call and doesn't know why their process is hanging, maybe we should keep it hyper focuessed to that

#

and offer more further reading

gritty wind Feb 10, 2021, 8:51 PM

#

cc @green oriole

clever wraith Feb 10, 2021, 8:52 PM

#

ok

clever wraith Feb 10, 2021, 8:52 PM

#

vale ibex If its when someone uses a blocking call and doesn't know why their process is h...

ok

gritty wind Feb 10, 2021, 8:52 PM

#

I'm not too sure about the content itself tbh. A lot of it is adapted from d.py (without proper citation hyperlemon ), and is specific to the problems people face when using the library.

clever wraith Feb 10, 2021, 8:52 PM

#

ok

gritty wind Feb 10, 2021, 8:52 PM

#

It also doesn't explain what async is outside of the library's context, and I don't know that the d.py docs explain it outside of that context either

#

I'm tempted to say a shortened version of this will work as a d.py tag

#

but I don't think that works too well as a standalone async/blocking tag

clever wraith Feb 10, 2021, 9:10 PM

#

gritty wind but I don't think that works too well as a standalone async/blocking tag

ok

clever wraith Feb 10, 2021, 9:33 PM

#

gritty wind I'm not too sure about the content itself tbh. A lot of it is adapted from d.py ...

ok

#

@gritty wind so any suggestions on how to imporve??

short snow Feb 10, 2021, 11:58 PM

#

@surreal venture gave a review lemon_pleased

short snow Feb 11, 2021, 4:22 AM

#

@surreal venture go to #reddit , right click on the emojis, open it in a new link and download it

#

and then put it on on the emojis of your server

surreal venture Feb 11, 2021, 4:38 AM

#

short snow <@!576100587494440971> gave a review <:lemon_pleased:754441880263196742>

Yeah thanks!

surreal venture Feb 11, 2021, 4:38 AM

#

short snow <@!576100587494440971> go to <#458224812528238616> , right click on the emojis, ...

Okie

short snow Feb 11, 2021, 5:01 AM

#

👍 .

gritty wind Feb 11, 2021, 5:08 AM

#

clever wraith <@!386599446571384843> so any suggestions on how to imporve??

Well you can take this one of two directions imo.

You can either make this a d.py tag specifically, and entirely remove the middle third (Another example is requests... + codeblock). The how to find async modules can probably be shortened, or even removed. Do call it a d.py tag though.
Alternatively, if you want a general async tag, you'll have to start explaining what it is, or what blocking is, not just what its effects are and how to get around them. Point is, that'll require a bit of rewriting. You'll also need better sources than discord.py docs which is not really focused on teaching what async is.

In both cases, I think that tag will have to be shortened to be considered.

balmy sparrow Feb 11, 2021, 5:39 AM

#

@obsidian patio I've made the changes you've requested on bot#1398

dusky shoreBOT Feb 11, 2021, 5:39 AM

#

GitHub

PROpen [bot] #1398 Make KeyError tag

balmy sparrow Feb 11, 2021, 5:39 AM

#

Akarys had approved the PR, should I re-request review as I've made changes?

short snow Feb 11, 2021, 5:42 AM

#

yes, u re-request a review

obsidian patio Feb 11, 2021, 6:11 AM

#

@balmy sparrow did you see this? https://github.com/python-discord/bot/pull/1398#discussion_r571492763

balmy sparrow Feb 11, 2021, 6:13 AM

#

#dev-contrib message This was what I'd been told about the try-except, I don't mind removing it though

obsidian patio Feb 11, 2021, 6:14 AM

#

I think that @gritty wind would be fine with removing it, but we can check. I’m fine with it both ways

balmy sparrow Feb 11, 2021, 6:15 AM

#

I split up the codeblock the way Xithrius said to avoid the need for that odd in-line comment, that's fine right?

gritty wind Feb 11, 2021, 6:15 AM

#

I wanted them mentioned so we can describe more normal possibilities, but if you think it flows better without it, go for it

obsidian patio Feb 11, 2021, 6:17 AM

#

Alright

#

Give it some thought and see what you think works best. I’m fine with both, as long as we make it flow well

balmy sparrow Feb 11, 2021, 6:20 AM

#

Didn't see this haha I've removed the try-except reference

#

I can see it being just unnecessary fluff on there

obsidian patio Feb 11, 2021, 6:21 AM

#

Alrighty👍

#

And for the record, I definitely think Xith’s suggestion is great! We all pick up on different parts, so having multiple reviews can really be beneficial

#

@vocal wolf if I want to discuss a way to increase the number of PR reviews done, should I talk to you or Ak about it? You would be best fit, right?

vocal wolf Feb 11, 2021, 6:24 AM

#

ye

#

I'll be reviewing stuff later tonight, not really available at this current moment though. Finishing up Java assignment (I know, traitor).

obsidian patio Feb 11, 2021, 6:25 AM

#

Hahah alright

#

I’ll just send a message here that you can ponder on whenever you want to and have time

vocal wolf Feb 11, 2021, 6:26 AM

#

Don't merge that KeyError tag yet, I need to review it again I think

obsidian patio Feb 11, 2021, 6:26 AM

#

Yeppers; I don’t even have the permissions

vocal wolf Feb 11, 2021, 6:26 AM

#

alright

obsidian patio Feb 11, 2021, 6:30 AM

#

Soo, in the media projects, we’re planning on shining some more light on the contributors—by including their names in the credits—which I think will help with drawing more contributors into the projects.

We often post about new features and mention the PR authors in #changelog, but we never care about the reviewers and not always the people who have contributed to the discussions. I think that mentioning who reviewed it, especially for larger PRs, could really help improve the visibility of reviewing and thereby getting people more interested in the topic and helping out, instead of just submitting PRs. It’s an integral part of the process, and I think we should value it as such—especially since reviews are something we really, really need

short snow Feb 11, 2021, 6:30 AM

#

Well i have done few reviews till now, any comments on how i should improve them? am a doing something wrong, etc.

short snow Feb 11, 2021, 6:31 AM

#

obsidian patio Soo, in the media projects, we’re planning on shining some more light on the con...

We could do that for large PRs, and those who have done a good review, not like a one line review just to get their name in change-log

obsidian patio Feb 11, 2021, 6:32 AM

#

(Cc @vocal wolf, whenever you’re free)

short snow Feb 11, 2021, 6:35 AM

#

👀 seems like a long essay incoming

obsidian patio Feb 11, 2021, 6:37 AM

#

short snow We could do that for large PRs, and those who have done a good review, not like ...

I kind of agree, in theory. However, some PRs really just need a LGTM. We also don’t want to make people nit-pick for ages, because a LGTM won’t get them into the changelog. I think it could be something for the person sharing it to decide, but it’s an implementation detail that I’m very open about

vocal wolf Feb 11, 2021, 7:58 AM

#

@obsidian patio I think we need to sit down together sometime and work this out. We'll be able to get more information to go between the teams.

obsidian patio Feb 11, 2021, 8:08 AM

#

vocal wolf <@!572303014346489866> I think we need to sit down together sometime and work th...

I’m not quite following. What information should go between what teams?

vocal wolf Feb 11, 2021, 8:09 AM

#

Me and you sitting down together and discussing this out, because I'm not sure if I quite understand what needs to be done.

#

It may just me being tired

obsidian patio Feb 11, 2021, 8:09 AM

#

Ah, yeah. Sure thing, that could be good

vocal wolf Feb 11, 2021, 8:09 AM

#

ye

#

the keyerror tag was merged

#

bot hasn't connected yet tho

obsidian patio Feb 11, 2021, 8:10 AM

#

Ah, lovely

gritty wind Feb 11, 2021, 8:10 AM

#

changelog?

vocal wolf Feb 11, 2021, 8:10 AM

#

changelog.

gritty wind Feb 11, 2021, 8:10 AM

#

👍 I'll send it out when @stable mountain is reborn

vocal wolf Feb 11, 2021, 8:10 AM

#

veri nais

obsidian patio Feb 11, 2021, 8:12 AM

#

Excellent

short snow Feb 11, 2021, 8:12 AM

#

triple !!!?

vocal wolf Feb 11, 2021, 8:12 AM

#

!dict-get

stable mountainBOT Feb 11, 2021, 8:12 AM

#

Often while using dictionaries in Python, you may run into KeyErrors. This error is raised when you try to access a key that isn't present in your dictionary. Python gives you some neat ways to handle them.

The dict.get method

The dict.get method will return the value for the key if it exists, and None (or a default value that you specify) if the key doesn't exist. Hence it will never raise a KeyError.

>>> my_dict = {"foo": 1, "bar": 2}
>>> print(my_dict.get("foobar"))
None

Below, 3 is the default value to be returned, because the key doesn't exist-

>>> print(my_dict.get("foobar", 3))
3

Some other methods for handling KeyErrors gracefully are the dict.setdefault method and collections.defaultdict (check out the !defaultdict tag).

vocal wolf Feb 11, 2021, 8:12 AM

#

short snow triple `!!!`?

my prefix on the test server

#

guess it's fuzzy enough to work here lol

short snow Feb 11, 2021, 8:12 AM

#

how did it work here?

#

ah

vocal wolf Feb 11, 2021, 8:13 AM

#

It just took the prefix ! and then added whatever I had

#

searched for the tag from there I guess

short snow Feb 11, 2021, 8:13 AM

#

👍.

gritty wind Feb 11, 2021, 8:15 AM

#

is the tag dict-get or key error?

vocal wolf Feb 11, 2021, 8:15 AM

#

dict get

short snow Feb 11, 2021, 8:15 AM

#

yes ig

vocal wolf Feb 11, 2021, 8:15 AM

#

!keyerror

short snow Feb 11, 2021, 8:16 AM

#

wasn't it originally on key error?

vocal wolf Feb 11, 2021, 8:17 AM

#

not sure

gritty wind Feb 11, 2021, 8:17 AM

#

the PR is key error 🦐

#

That's not the right emoji

vocal wolf Feb 11, 2021, 8:17 AM

#

lol

balmy sparrow Feb 11, 2021, 8:22 AM

#

it originally was on keyerrors, but akarys said I should rename it

#

after all, dict-get is the only thing being explained there

gritty wind Feb 11, 2021, 8:23 AM

#

It's a nice tag

balmy sparrow Feb 11, 2021, 8:24 AM

#

lemon_hyperpleased hope it'll be useful

short snow Feb 11, 2021, 8:27 AM

#

#dev-log message why did sir-lance reconnect?

sharp timber Feb 11, 2021, 8:50 AM

#

So I broke the paginator again, I'm thinking of setting aside some time to work on it, if nobody's already got something that'd conflict?

gritty wind Feb 11, 2021, 8:50 AM

#

Hmm I don't think anything is happening on @stable mountain right now

#

I think there is porting or something happening for lance though

sharp timber Feb 11, 2021, 8:50 AM

#

!raw 809345696696238102

#

this, basically

stable mountainBOT Feb 11, 2021, 8:51 AM

#

Sorry, an unexpected error occurred. Please let us know!

RuntimeError: Line exceeds maximum page size 1992

sharp timber Feb 11, 2021, 8:51 AM

#

Ok

gritty wind Feb 11, 2021, 8:51 AM

#

There is an open issue if you'd like an official assignment

#

Though mark is assigned to that

obsidian patio Feb 11, 2021, 9:05 AM

#

Seems like we have a bug

📎 image0.png

green oriole Feb 11, 2021, 9:06 AM

#

Haha

#

Well

#

It isn’t really a bug

obsidian patio Feb 11, 2021, 9:06 AM

#

Oh wait, it’s the say Command?

#

And it thought I misspelled s?

green oriole Feb 11, 2021, 9:06 AM

#

It is the site command

obsidian patio Feb 11, 2021, 9:06 AM

#

Aah

green oriole Feb 11, 2021, 9:07 AM

#

Yep, since a mention is a valid prefix it tried to correct you

#

@stable mountain site hom

stable mountainBOT Feb 11, 2021, 9:07 AM

#

Command Help

!site
Can also use: s

Commands for getting info about our website.

Subcommands:

!site faq
Info about the site's FAQ page.
!site help
Info about the site's Getting Help page.
!site home
Info about the website itself.
!site resources
Info about the site's Resources page.
!site rules [rules]...
Provides a link to all rules or, if specified, displays specific rule(s).
!site tools
Info about the site's Tools page.

green oriole Feb 11, 2021, 9:07 AM

#

hom

obsidian patio Feb 11, 2021, 9:07 AM

#

Yeah. Just didn’t understand why it used that exact thing, but that makes sense

#

Could we disable it for helpers as well? I think we know the commands

gritty wind Feb 11, 2021, 9:08 AM

#

Ehh it's still probably helpful, and I'd like to see it eventually become mod+ too

green oriole Feb 11, 2021, 9:08 AM

#

We were actually supposed to re-enable them for mods

gritty wind Feb 11, 2021, 9:08 AM

#

but I don't know that @stable mountain prefix is used

obsidian patio Feb 11, 2021, 9:08 AM

#

Why?

green oriole Feb 11, 2021, 9:09 AM

#

It is useful to copy paste the command when you made a typo

obsidian patio Feb 11, 2021, 9:09 AM

#

Ah, makes sense

#

I guess I’ll just have to live with that

green oriole Feb 11, 2021, 9:10 AM

#

gritty wind but I don't know that <@!409107086526644234> prefix is used

It is a default thing on d.py bots, it is a bit weird

gritty wind Feb 11, 2021, 9:10 AM

#

I mean you can definitely set the prefix

obsidian patio Feb 11, 2021, 9:10 AM

#

It makes sense, since people use so many different prefixes. If you don’t know the one for the current bot, you just mention it

gritty wind Feb 11, 2021, 9:11 AM

#

command_prefix=commands.when_mentioned_or(constants.Bot.prefix)

#

This is our current prefix, I don't think mention is default

green oriole Feb 11, 2021, 9:11 AM

#

Hmm

gritty wind Feb 11, 2021, 9:12 AM

#

Removing that line

#

📎 unknown.png

green oriole Feb 11, 2021, 9:13 AM

#

Hmm okay

keen valley Feb 11, 2021, 9:23 AM

#

!dict-get

stable mountainBOT Feb 11, 2021, 9:23 AM

#

Often while using dictionaries in Python, you may run into KeyErrors. This error is raised when you try to access a key that isn't present in your dictionary. Python gives you some neat ways to handle them.

The dict.get method

The dict.get method will return the value for the key if it exists, and None (or a default value that you specify) if the key doesn't exist. Hence it will never raise a KeyError.

>>> my_dict = {"foo": 1, "bar": 2}
>>> print(my_dict.get("foobar"))
None

Below, 3 is the default value to be returned, because the key doesn't exist-

>>> print(my_dict.get("foobar", 3))
3

Some other methods for handling KeyErrors gracefully are the dict.setdefault method and collections.defaultdict (check out the !defaultdict tag).

keen valley Feb 11, 2021, 9:23 AM

#

how to make a tag

gritty wind Feb 11, 2021, 9:23 AM

#

Open an issue on the bot repository to get approved, then add it to the tags folder

#

https://github.com/python-discord/bot/issues

#

and the folder: https://github.com/python-discord/bot/tree/master/bot/resources/tags

green oriole Feb 11, 2021, 9:34 AM

#

Actually, you should comment on https://github.com/python-discord/meta/discussions/86 instead of opening a new issue

GitHub

Tag suggestions · Discussion #86 · python-discord/meta

keen valley Feb 11, 2021, 9:35 AM

#

how to connect the my discord account to discord

obsidian patio Feb 11, 2021, 9:36 AM

#

What do you mean?

short snow Feb 11, 2021, 9:36 AM

#

github account to discord?

#

!ot channels please.

stable mountainBOT Feb 11, 2021, 9:37 AM

#

Off-topic channels

There are three off-topic channels:
• #ot0-psvm’s-eternal-disapproval
• #ot1-perplexing-regexing
• #ot2-never-nester’s-nightmare

Their names change randomly every 24 hours, but you can always find them under the OFF-TOPIC/GENERAL category in the channel list.

short snow Feb 11, 2021, 9:37 AM

#

this is strictly for python discord projects discussion

keen valley Feb 11, 2021, 9:49 AM

#

shall i add a tag

#

Its almost ready

obsidian patio Feb 11, 2021, 9:50 AM

#

Feel free to comment on the discussion Akarys sent, and we’ll see if it’s something worth adding

gritty wind Feb 11, 2021, 9:52 AM

#

hey @vocal wolf if you'll do the work on a new branch, mind deleting the old one?

vocal wolf Feb 11, 2021, 9:53 AM

#

right now, it's the same branch

#

I un-deleted it because I was going to continue working on it

#

currently creating the PR

gritty wind Feb 11, 2021, 9:53 AM

#

Ah I thought there was a different message for undeleting

vocal wolf Feb 11, 2021, 9:53 AM

#

oh wait

#

god dammit

#

lmao I named the branch origin/dynamic-stuff

#

I'll uh

#

I'll delete that if I can

gritty wind Feb 11, 2021, 9:54 AM

#

loool

vocal wolf Feb 11, 2021, 9:54 AM

#

removed

keen valley Feb 11, 2021, 9:55 AM

#

I am unable to add a md file in the tag

gritty wind Feb 11, 2021, 9:56 AM

#

Did you leave a comment on the discussion thread first?

short snow Feb 11, 2021, 9:56 AM

#

keen valley I am unable to add a md file in the tag

you need to have a fork, a isssue which is approved

#

without a approved issue which is assigned to you, your contribution can't get merged

keen valley Feb 11, 2021, 9:57 AM

#

so what should I do now

gritty wind Feb 11, 2021, 9:57 AM

#

Ehh we sometimes skip the issues, but you should at least comment so we can discuss it

short snow Feb 11, 2021, 9:57 AM

#

green oriole Actually, you should comment on https://github.com/python-discord/meta/discussio...

this

gritty wind Feb 11, 2021, 9:57 AM

#

green oriole Actually, you should comment on https://github.com/python-discord/meta/discussio...

Go here and leave a comment with your idea ^

short snow Feb 11, 2021, 9:57 AM

#

oh sry for the ping

gritty wind Feb 11, 2021, 9:57 AM

#

oh well

short snow Feb 11, 2021, 9:57 AM

#

lol double ping

vocal wolf Feb 11, 2021, 9:57 AM

#

@gritty wind there, I did it correctly this time

keen valley Feb 11, 2021, 9:58 AM

#

Here what to do

📎 Screenshot_2021-02-11_152738.png

short snow Feb 11, 2021, 9:58 AM

#

not there

vocal wolf Feb 11, 2021, 9:58 AM

#

last time I accidentally did git push -u origin/dynamic-available-message-patch instead of git push -u origin dynamic-available-message-patch

short snow Feb 11, 2021, 9:58 AM

#

green oriole Actually, you should comment on https://github.com/python-discord/meta/discussio...

this

#

read what ak sent.

gritty wind Feb 11, 2021, 9:58 AM

#

vocal wolf last time I accidentally did `git push -u origin/dynamic-available-message-patch...

Do you have to specify origin 🤔

vocal wolf Feb 11, 2021, 9:58 AM

#

it's for my sanity

short snow Feb 11, 2021, 11:02 AM

#

@vocal wolf can give a review on your pypi pr now

#

or should i wait

vocal wolf Feb 11, 2021, 11:02 AM

#

It's a draft, so no touchy.

short snow Feb 11, 2021, 11:02 AM

#

okiee

#

it regarding the return type annotations

vocal wolf Feb 11, 2021, 11:03 AM

#

Will fix later, yes.

short snow Feb 11, 2021, 11:03 AM

#

ok_handbutflipped

vocal wolf Feb 11, 2021, 11:03 AM

#

@green oriole do you think you'll pick this back up eventually?

https://github.com/python-discord/bot/pull/1203

short snow Feb 11, 2021, 11:04 AM

#

that is a problem in many files of sir-lance

#

dunno about python

green oriole Feb 11, 2021, 11:04 AM

#

vocal wolf <@!407110650217627658> do you think you'll pick this back up eventually? <https...

I don't think I'll have enough time honestly

vocal wolf Feb 11, 2021, 11:04 AM

#

rip

short snow Feb 11, 2021, 12:20 PM

#

kwzrd is back?

hardy gorge Feb 11, 2021, 12:54 PM

#

They've been active again in the community for a while

short snow Feb 11, 2021, 12:56 PM

#

but they are not in the server right?

hardy gorge Feb 11, 2021, 12:57 PM

#

They are here

#

They were active this morning

short snow Feb 11, 2021, 12:58 PM

#

ah yess, can see them

hardy gorge Feb 11, 2021, 12:58 PM

#

In any case, I don't like discussing someone in public like that

short snow Feb 11, 2021, 12:58 PM

#

yeah, sorry.

vale ibex Feb 11, 2021, 1:29 PM

#

vocal wolf rip

I had a look into that a few weeks ago, but I'm still on the waiting list for Codespaces, so can't do anything about it

wise oriole Feb 11, 2021, 1:40 PM

#

#sir-lancebot-playground message

#

whome

#

oh wait sorry

#

I thought a spelling mistake

gritty wind Feb 11, 2021, 1:41 PM

#

hmm is sir-lancebot#575 still open

dusky shoreBOT Feb 11, 2021, 1:41 PM

#

GitHub

PROpen [sir-lancebot] #575 Fixes Valentine Commands Bug.

gritty wind Feb 11, 2021, 1:41 PM

#

yes

wise oriole Feb 11, 2021, 1:41 PM

#

ohk

gritty wind Feb 11, 2021, 1:41 PM

#

alright, for now you should be able to specify the user

#

.bemyvalentine 785425328033103872

short snow Feb 11, 2021, 3:00 PM

#

and the connect 4 one

clever wraith Feb 11, 2021, 3:13 PM

#

gritty wind Well you can take this one of two directions imo. 1. You can either make this a ...

ok

clever wraith Feb 11, 2021, 3:14 PM

#

gritty wind Well you can take this one of two directions imo. 1. You can either make this a ...

i'll go with the general async tag

cosmic moat Feb 11, 2021, 4:56 PM

#

Hmm, is there any reason I would get this?

    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno 8] nodename nor servname provided, or not known

This is when running pipenv run start, but docker-compose up works fine.

gritty wind Feb 11, 2021, 4:56 PM

#

Can you post the rest of the traceback

#

!paste

stable mountainBOT Feb 11, 2021, 4:56 PM

#

Pasting large amounts of code

If your code is too long to fit in a codeblock in discord, you can paste your code here:
https://paste.pydis.com/

After pasting your code, save it by clicking the floppy disk icon in the top right, or by typing ctrl + S. After doing that, the URL should change. Copy the URL and post it here so others can see it.

cosmic moat Feb 11, 2021, 4:56 PM

#

Yes

#

https://paste.pythondiscord.com/umupetuxeg.py

gritty wind Feb 11, 2021, 4:59 PM

#

Alright, that's a common redis issue

#

Just set USE_FAKEREDIS to true in your env

cosmic moat Feb 11, 2021, 5:03 PM

#

sounds good, what causes it?

gritty wind Feb 11, 2021, 5:03 PM

#

Well you don't have a redis database running on your local host

#

When you run through docker, you get one setup for you

#

I want to clean up the errors a bit, but I don't have time for that now

#

(FWIW, you don't have to use fake redis. You can setup a local redis instance, or set the host to the one running on docker, but they are mostly the same for all intents and purposes)

cosmic moat Feb 11, 2021, 5:04 PM

#

Ah, I see, I haven't done much with redis so I wouldn't know

#

thanks :D

gritty wind Feb 11, 2021, 5:05 PM

#

If you need to start saving/caching things, drop in here and we can talk about redis

#

You won't need it for most things though, because a lot of things are in the momemnt type of deals

cosmic moat Feb 11, 2021, 5:06 PM

#

yep, the issue I'm working on doesn't require a db

cosmic moat Feb 11, 2021, 5:24 PM

#

How do we handle api keys?

gritty wind Feb 11, 2021, 5:25 PM

#

.env vars on local dev

cosmic moat Feb 11, 2021, 5:25 PM

#

I see that wolfram references the constants.py api key that gets it from .env

gritty wind Feb 11, 2021, 5:25 PM

#

and environment variables in the code

cosmic moat Feb 11, 2021, 5:25 PM

#

Do we send env vars to eachother?

gritty wind Feb 11, 2021, 5:25 PM

#

Nah

#

We'll get a key for pydis, and set it up on the server

cosmic moat Feb 11, 2021, 5:25 PM

#

alright

#

sounds good 👍

#

lastly, do we preference adding another dependency or using the base API?

#

e.g. google has an api package that makes it easier to search, but isn't necessary

gritty wind Feb 11, 2021, 5:29 PM

#

If the setup is relatively simple without the library, then no we don't usually add

#

We really only add if the library provides really important features that would otherwise be difficult to implement, or if the cost of maintenance is higher than the cost of adding a dependency.

cosmic moat Feb 11, 2021, 5:33 PM

#

Alright, thanks for the help

cosmic moat Feb 11, 2021, 6:03 PM

#

alright, I wrote all of the code for the youtube command, I just have to test it and get an API key which I'll do after classes

gritty wind Feb 11, 2021, 6:04 PM

#

No rush

cosmic moat Feb 11, 2021, 6:34 PM

#

do we have a helper to escape markdown characters?

gritty wind Feb 11, 2021, 6:35 PM

#

d.py has a builtin

#

we use it somewhere

#

let me just

cosmic moat Feb 11, 2021, 6:35 PM

#

alright

#

https://github.com/python-discord/bot/pull/437/commits/6815bca50816678f6069516ef564ecb4a4d01d83 I saw this too

gritty wind Feb 11, 2021, 6:36 PM

#

Are you trying to send markdown, or read markdown?

vale ibex Feb 11, 2021, 6:36 PM

#

commands.clean_content(*, escape_markdown=True)

cosmic moat Feb 11, 2021, 6:36 PM

#

vale ibex `commands.clean_content(*, escape_markdown=True)`

Thanks!

cosmic moat Feb 11, 2021, 6:36 PM

#

gritty wind Are you trying to send markdown, or read markdown?

I have text that could be markdown that I need to escape

gritty wind Feb 11, 2021, 6:37 PM

#

Clean content then

#

just remember to use it as a converter

vale ibex Feb 11, 2021, 6:37 PM

#

this

cosmic moat Feb 11, 2021, 6:38 PM

#

what do you mean?

gritty wind Feb 11, 2021, 6:38 PM

#

converters are used in function type annotations, and d.py converts arguments using them under the hood

#

for example, if I had

def myFunction(a_number: int):
  ...

d.py would convert the input to int

cosmic moat Feb 11, 2021, 6:39 PM

#

gritty wind converters are used in function type annotations, and d.py converts arguments us...

Right, but, I don't really need them in that way

gritty wind Feb 11, 2021, 6:39 PM

#

replace int there with the converter you want to use, in this case clean_content

vale ibex Feb 11, 2021, 6:39 PM

#

There's also a util to escape markdown

gritty wind Feb 11, 2021, 6:39 PM

#

What are you using it for?

cosmic moat Feb 11, 2021, 6:39 PM

#

            for item in data["items"]:
                results.append(
                    {"title": clean_content(item["snippet"]["title"], escape_markdown=True), "id": item["id"]["videoId"]}
                )

This is the snippet in question

vale ibex Feb 11, 2021, 6:39 PM

#

ahh, possibly better to use utils.escape_markdown() then

gritty wind Feb 11, 2021, 6:39 PM

#

I think that's the reverse of clean_content

#

Clean content is for sanitizing received data, here you want to clean data you are going to send

#

(Though I guess you can hack it to do that)

cosmic moat Feb 11, 2021, 6:40 PM

#

vale ibex ahh, possibly better to use `utils.escape_markdown()` then

Looking at the clean_content docs helped me realize I need to escape mentions too

vale ibex Feb 11, 2021, 6:40 PM

#

https://discordpy.readthedocs.io/en/latest/api.html#discord.utils.escape_markdown

#

there's also utils.escape_mentions too

cosmic moat Feb 11, 2021, 6:41 PM

#

gritty wind Clean content is for sanitizing received data, here you want to clean data you a...

ah okay

cosmic moat Feb 11, 2021, 6:42 PM

#

vale ibex there's also utils.escape_mentions too

If we don't have a helper in lancebot for it, I'll probably make an issue and pr a helper like escape_discord or something

vale ibex Feb 11, 2021, 6:44 PM

#

In @stable mountain I can only see escape_markdown being used, no use of escape mentions

#

and that's all at the cog level, rather than a helper func

patent pivot Feb 11, 2021, 6:44 PM

#

we use allowed mentions

cosmic moat Feb 11, 2021, 6:44 PM

#

def escape_discord(message: str) -> str:
  no_markdown = utils.escape_markdown(message)
  no_mentions = utils.escape_mentions(no_markdown)
  return no_mentions

#

or something

vale ibex Feb 11, 2021, 6:45 PM

#

patent pivot we use allowed mentions

Ahhh, that makes sense

cosmic moat Feb 11, 2021, 6:45 PM

#

do we have that on lancebot too?

vale ibex Feb 11, 2021, 6:45 PM

#

Yea

#

bot.py:152

cosmic moat Feb 11, 2021, 6:46 PM

#

alright, then I shouldn't need to escape_mentions, right

vale ibex Feb 11, 2021, 6:46 PM

#

nope 🙂

cosmic moat Feb 11, 2021, 6:46 PM

#

Can lancebot mention users though?

vale ibex Feb 11, 2021, 6:46 PM

#

The bot will only be able to mention staff roles

cosmic moat Feb 11, 2021, 6:46 PM

#

What happens if the youtube video is titled @Admins

vale ibex Feb 11, 2021, 6:48 PM

#

Admins complain i guess? shrugR

gritty wind Feb 11, 2021, 6:48 PM

#

are you not embedding the response?

stable mountainBOT Feb 11, 2021, 6:50 PM

#

test

@Scaleios#8200

test

@Scaleios#8200

balmy sparrow Feb 11, 2021, 6:50 PM

#

even if it wasn't embedded, I don't think it'd ping the role (the ping would actually happen only with <@admin role id>

#

the only risk would be everyone and here

#

But yeah embed outputs will look cleaner along with the added advantage of not really pinging anyone

vale ibex Feb 11, 2021, 6:51 PM

#

gritty wind are you not embedding the response?

I think it would work if you did @gritty wind

sleek steppe Feb 11, 2021, 6:52 PM

#

vale ibex Admins complain i guess? <:shrugR:727587457046151301>

how about allowed mentions

vale ibex Feb 11, 2021, 6:52 PM

#

I don't think you'd get a ping, but it would be formatted

cold moon Feb 11, 2021, 6:52 PM

#

Putting any mention into embed make this instantly not pinging

gritty wind Feb 11, 2021, 6:52 PM

#

here and everyone is safe, even in text

📎 unknown.png

stable mountainBOT Feb 11, 2021, 6:54 PM

#

test

@gritty wind

test

@gritty wind

gritty wind Feb 11, 2021, 6:54 PM

#

embeds simply don't ping at all

cosmic moat Feb 11, 2021, 6:55 PM

#

gritty wind are you not embedding the response?

If it is in an embed, can it not ping? It is embedded

vale ibex Feb 11, 2021, 6:56 PM

#

Nope, no pings in embeds

cosmic moat Feb 11, 2021, 6:56 PM

#

oh cool

gritty wind Feb 11, 2021, 6:56 PM

#

no ping, no notification

📎 unknown.png

cosmic moat Feb 11, 2021, 6:57 PM

#

oh, cool

#

thanks yet again 😅

cosmic moat Feb 11, 2021, 7:35 PM

#

I'm assuming we don't have a branching guideline? (specifically for forks)

gritty wind Feb 11, 2021, 7:35 PM

#

The general guideline (i think this is on the site or contributing guide) is to fork and pull

#

but for people with write perms

#

I.E staff

#

You should just push directly to the repo

#

then PR

cosmic moat Feb 11, 2021, 7:37 PM

#

gritty wind The general guideline (i think this is on the site or contributing guide) is to ...

I'd like to copy the same github workflow we use in lancebot on my local fork, which is why I was wondering if we had a branching convention?

#

Also wdym by pushing and then making a pr?

gritty wind Feb 11, 2021, 7:37 PM

#

We don't not really

#

Push on a new branch to the origin repo (python-discord/sir-lancebot) and PR from there

#

You can use a fork if you want to, but a lot of staff use it for convenience

cosmic moat Feb 11, 2021, 7:39 PM

#

Alright, I'll do that then

#

It seems a bit cleaner to pr then make a new branch each time though, no?

gritty wind Feb 11, 2021, 7:39 PM

#

Like PR from master to master?

#

You'll be making a new branch whether on the main repo or a fork

#

then it'll be deleted after its merged (at least ones on the main repo)

cosmic moat Feb 11, 2021, 7:41 PM

#

gritty wind Like PR from master to master?

If I PR from a branch on the fork to master on the main repo, no new branches would be created on the main repo, right?

gritty wind Feb 11, 2021, 7:50 PM

#

Yeah, but creating temporary branches is fine

#

Either way, whichever repo you pick, the whole thing will look pretty identical

#

New branch from master -> PR -> delete branch

cosmic moat Feb 11, 2021, 7:52 PM

#

Alright, since I already have a fork that I've been developing on, it's probably easier in this case to just pr from the fork right?

gritty wind Feb 11, 2021, 7:53 PM

#

Yeah whatever you're comfortable with

#

I personally prefer working on the main repo directly because I don't have to keep merging updates into my master 👀

cosmic moat Feb 11, 2021, 7:57 PM

#

alright, thanks :D

clever wraith Feb 11, 2021, 7:57 PM

#

dumb question, what's the stars.json file in the bot repo?

gritty wind Feb 11, 2021, 7:58 PM

#

iirc those are the names for

#

!source superstarify

stable mountainBOT Feb 11, 2021, 7:58 PM

#

Command: superstarify

Temporarily force a random superstar name (like Taylor Swift) to be the user's nickname.

Source Code

Go to GitHub

cosmic moat Feb 11, 2021, 8:01 PM

#

How can I allow only staff to use the command outside of the bot channel?

gritty wind Feb 11, 2021, 8:02 PM

#

That's already done by default for you

cosmic moat Feb 11, 2021, 8:02 PM

#

ah, awesome :D

gritty wind Feb 11, 2021, 8:02 PM

#

If you dig in the bot.main file, it's #sir-lancebot-playground #bot-commands (a few more), and staff roles

cosmic moat Feb 11, 2021, 8:03 PM

#

Alright

#

thanks

vale ibex Feb 11, 2021, 8:04 PM

#

oh is it preferred to branch and PR directly from the repo? I've been using my fork still

gritty wind Feb 11, 2021, 8:04 PM

#

I'm also still stuck on my fork for @stable mountain because of an old PR

#

but yeah, that's what is in the contributing guide

#

If you feel more comfortable with forks, that works too

vale ibex Feb 11, 2021, 8:04 PM

#

I should actually read these documents properly

gritty wind Feb 11, 2021, 8:05 PM

#

May need a cup of coffee, and 10-15 minutes

vale ibex Feb 11, 2021, 8:05 PM

#

Got the review guide first

#

then maybe the contrib stuff

gritty wind Feb 11, 2021, 8:06 PM

#

You'd need to have a general idea of the contributing guidelines to adequately review things, but the contib guide is pretty straightforward stuff you'd expect in any project

#

That is to say, you can look over it after the review guide

vale ibex Feb 11, 2021, 8:08 PM

#

Yea, I skimmed them when I started for important info, but reading and understanding them is something different 😛

cold island Feb 11, 2021, 8:25 PM

#

Yeah it's simpler to just open a feature branch

cosmic moat Feb 11, 2021, 8:25 PM

#

i opened my pr alas

vale ibex Feb 11, 2021, 8:33 PM

#

cosmic moat i opened my pr alas

and suddenly swamped with comments 😛

cosmic moat Feb 11, 2021, 8:40 PM

#

vale ibex and suddenly swamped with comments 😛

And replies 😎

#

What should the commits be named once I fix this?

#

I don't think one batch Reviewed is best

#

Also, how would I do this https://github.com/python-discord/sir-lancebot/pull/586#discussion_r574799314 @vale ibex?

GitHub

Implemented youtube command by SuperMaZingCoder · Pull Request #586...

Relevant Issues
Closes #585
Description
Implemented a new youtube cog which has a youtube (alias: yt) command to search youtube from a specified query. Additionally, there is a fifteen-second coold...

vale ibex Feb 11, 2021, 8:42 PM

#

Take a look at https://github.com/python-discord/sir-lancebot/blob/9441c7284e4230b96ce0cd79e6fa86f457530f3c/bot/exts/evergreen/cheatsheet.py#L77

GitHub

python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - python-discord...

#

commands.BucketType.user

cosmic moat Feb 11, 2021, 8:43 PM

#

ah, very nice, thanks :D

cosmic moat Feb 11, 2021, 8:43 PM

#

cosmic moat What should the commits be named once I fix this?

What do we typically do with this?

vale ibex Feb 11, 2021, 8:43 PM

#

ummm

#

i try to group my commits based of a single theme

#

So maybe 1 commit per fix, unless the two or more fixes are a similar thing

cosmic moat Feb 11, 2021, 8:44 PM

#

alright,

vale ibex Feb 11, 2021, 8:44 PM

#

At least that's my preference, not sure what the core team think

#

4. Make great commits. A well structured git log is key to a project's maintainability; it efficiently provides insight into when and why things were done for future maintainers of the project.
  - Commits should be as narrow in scope as possible. Commits that span hundreds of lines across multiple unrelated functions and/or files are very hard for maintainers to follow. After about a week they'll probably be hard for you to follow too.
  - Avoid making minor commits for fixing typos or linting errors. Since you've already set up a pre-commit hook to run the linting pipeline before a commit, you shouldn't be committing linting issues anyway.
  - A more in-depth guide to writing great commit messages can be found in Chris Beam's How to Write a Git Commit Message

#

fromhttps://github.com/python-discord/bot/blob/master/CONTRIBUTING.md#Rules

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

cosmic moat Feb 11, 2021, 8:48 PM

#

@celest charm Did you delete the comment about escaping the markdown?

vale ibex Feb 11, 2021, 8:49 PM

#

📎 unknown.png

cosmic moat Feb 11, 2021, 8:49 PM

#

vale ibex ```md 4. Make great commits. A well structured git log is key to a project's mai...

There was one about """Wikipedia Cog""", any suggestions for fixing that 😅

cosmic moat Feb 11, 2021, 8:49 PM

#

vale ibex

ah

vale ibex Feb 11, 2021, 8:49 PM

#

cosmic moat There was one about `"""Wikipedia Cog"""`, any suggestions for fixing that 😅

I'd say just tag it onto one of the other commits

cosmic moat Feb 11, 2021, 8:50 PM

#

vale ibex I'd say just tag it onto one of the other commits

👍

cosmic moat Feb 11, 2021, 9:05 PM

#

I'm in a predicament, precommit won't let me commit YouTube for YouTube Cog setup because of the capitalization

#

But, if I change it there, I'd have to change it everywhere and that's not what we want

vale ibex Feb 11, 2021, 9:09 PM

#

Load the YouTube cog. should work

#

iirc its the first word of the doc string that needs to be properly capitalised

cosmic moat Feb 11, 2021, 9:12 PM

#

Alright

cosmic moat Feb 11, 2021, 10:13 PM

#

It seems like escape_markdown is escaping ' characters?

📎 unknown.png

sharp timber Feb 11, 2021, 10:28 PM

#

Supposed to handle * _ and stuff, if you're talking about discord.py's escape_markdown

vale ibex Feb 11, 2021, 10:29 PM

#

it looks like that's what's returned from the API, rather than being caused by escape_markdown

cosmic moat Feb 11, 2021, 10:29 PM

#

vale ibex it looks like that's what's returned from the API, rather than being caused by e...

hmm

gritty wind Feb 11, 2021, 10:29 PM

#

wow you guys hammered super haha

#

for commits, we generally follow an atomic style

#

meaning a commit is only concerned with something that can be described in one sentence

cosmic moat Feb 11, 2021, 10:30 PM

#

vale ibex it looks like that's what's returned from the API, rather than being caused by e...

you're right

gritty wind Feb 11, 2021, 10:30 PM

#

We don't particularly enforce it too much though, especially not on sir-lancebot (unless you commit your entire PR in one commit)

vale ibex Feb 11, 2021, 10:30 PM

#

cosmic moat you're right

Yea, checkout #476196003733569547

#

This looks like it needs deleting bot#1417

dusky shoreBOT Feb 11, 2021, 10:43 PM

#

GitHub

IssueOpen [bot] #1417 poop

gritty wind Feb 11, 2021, 10:47 PM

#

Thank you

cosmic moat Feb 11, 2021, 10:48 PM

#

I did it

clever wraith Feb 11, 2021, 10:48 PM

#

@gritty wind should I include an example of real life scenario of asynchrnous?

cosmic moat Feb 11, 2021, 10:48 PM

#

I went through every single review comment

gritty wind Feb 11, 2021, 10:48 PM

#

clever wraith <@!386599446571384843> should I include an example of real life scenario of asyn...

It will depend on the length of the rest of the tag, and the length of the examples

vale ibex Feb 11, 2021, 10:48 PM

#

cosmic moat I went through every single review comment

trial by fire 😛

clever wraith Feb 11, 2021, 10:49 PM

#

gritty wind It will depend on the length of the rest of the tag, and the length of the examp...

it's long

#

maybe i should just link the video

cosmic moat Feb 11, 2021, 10:49 PM

#

they've all been eliminated

gritty wind Feb 11, 2021, 10:49 PM

#

It'll be really difficult to merge a long tag

clever wraith Feb 11, 2021, 10:50 PM

#

gritty wind It'll be really difficult to merge a long tag

ok

gritty wind Feb 11, 2021, 10:50 PM

#

Just so we don't end up closing it, and wasting all your effort, I have to ask: is async really going to work as a tag?

#

The initial proposal was accepting it as an article, and if it can be shortened enough, as a tag

clever wraith Feb 11, 2021, 10:50 PM

#

gritty wind The initial proposal was accepting it as an article, and if it can be shortened ...

ok

cosmic moat Feb 11, 2021, 10:51 PM

#

@celest charm Did you just dissaprove the pr? lemon_sentimental

#

I can't tell if it's from before or now

gritty wind Feb 11, 2021, 10:52 PM

#

lol fresh disapprovals should pop up in #dev-log unless github or discord died

clever wraith Feb 11, 2021, 10:52 PM

#

gritty wind lol fresh disapprovals should pop up in <#622895325144940554> unless github or d...

ok

gritty wind Feb 11, 2021, 10:52 PM

#

I uhh.. that was targeted towards super haha

cosmic moat Feb 11, 2021, 10:53 PM

#

gritty wind lol fresh disapprovals should pop up in <#622895325144940554> unless github or d...

oh yeah, didn't think about that haha

celest charm Feb 11, 2021, 10:56 PM

#

@cosmic moat Have you considered using TypedDict or NamedTuple or dataclass for the result type?

cosmic moat Feb 11, 2021, 10:57 PM

#

celest charm <@!523662958916665361> Have you considered using `TypedDict` or `NamedTuple` or ...

Oh, I forgot about that lemon_sentimental

celest charm Feb 11, 2021, 10:57 PM

#

something like

@dataclass
class SearchResult:
    title: str
    author: str
    id: str

#

if flake8 complains about id, just tell it to shut up

#

not a very useful builtin imo

vale ibex Feb 11, 2021, 10:58 PM

#

What would the type hint be then? I'm curious as i've never used them

#

List[SearchResult]?

celest charm Feb 11, 2021, 10:58 PM

#

yep

vale ibex Feb 11, 2021, 10:58 PM

#

Cool

celest charm Feb 11, 2021, 10:58 PM

#

a dataclass is just a normal class

cosmic moat Feb 11, 2021, 10:58 PM

#

celest charm something like ```py @dataclass class SearchResult: title: str author: s...

Why not like the docs say?

class Point2D(TypedDict):
    x: int
    y: int
    label: str

celest charm Feb 11, 2021, 10:59 PM

#

because it's a TypedDict, which is a type hint for something which is a dict at runtime

#

I'd say just use a normal class

#

no need for dicts here

celest charm Feb 11, 2021, 10:59 PM

#

celest charm something like ```py @dataclass class SearchResult: title: str author: s...

^

cosmic moat Feb 11, 2021, 11:00 PM

#

I'm not entirely following

#

which is a type hint for something which is a dict at runtime
I'd say just use a normal class
no need for dicts here
TypedDict does the same, no?

celest charm Feb 11, 2021, 11:01 PM

#

TypedDict is a type describing a dict with a fixed set of fields. At runtime, it's a dict

dataclass is a way of quickly creating a class. At runtime, it's that class.

clever wraith Feb 11, 2021, 11:01 PM

#

gritty wind Just so we don't end up closing it, and wasting all your effort, I have to ask: ...

it'll be just an intro, i'll link to couple or resources

celest charm Feb 11, 2021, 11:02 PM

#

celest charm `TypedDict` is a type describing a **dict** with a fixed set of fields. At runti...

TypedDict is usually used when you need to describe an already existing dict from some other API. When creating your own types, it's better to use dataclasses.

celest charm Feb 11, 2021, 11:02 PM

#

celest charm something like ```py @dataclass class SearchResult: title: str author: s...

and then just

                results.append(
                    Result(
                        title = escape_markdown(
                            html.unescape(item["snippet"]["title"])
                        ),
                        author = escape_markdown(
                            html.unescape(item["snippet"]["channelTitle"])
                        ),
                        id = item["id"]["videoId"]
                    }
                )

cosmic moat Feb 11, 2021, 11:03 PM

#

What's the difference between a dictionary and a dict?

celest charm Feb 11, 2021, 11:03 PM

#

synonyms

#

i.e. no difference

cosmic moat Feb 11, 2021, 11:04 PM

#

type describing a dictionary with a fixed set of fields. At runtime, it's a dict
It seemed like there was a difference here, no?

celest charm Feb 11, 2021, 11:04 PM

#

no

#

sorry if the wording is confusing

#

fixed it

cosmic moat Feb 11, 2021, 11:05 PM

#

ok, so you're saying you'd rather have a class that we can create and reference via item.title than a dict? (Both (dataclass and typedict) can be used as type hints it seems)

clever wraith Feb 11, 2021, 11:05 PM

#

does pipenv run lint automatically modify the files?

celest charm Feb 11, 2021, 11:06 PM

#

cosmic moat ok, so you're saying you'd rather have a class that we can create and reference ...

Yep.

#

!e

from typing import TypedDict

class Point2D(TypedDict):
    x: int
    y: int

print(Point2D(x=1, y=2))

stable mountainBOT Feb 11, 2021, 11:06 PM

#

@celest charm :white_check_mark: Your eval job has completed with return code 0.

{'x': 1, 'y': 2}

celest charm Feb 11, 2021, 11:06 PM

#

^ this is what typeddict does

cosmic moat Feb 11, 2021, 11:06 PM

#

ah okay, so, why is the class better again (sorry :c)

vale ibex Feb 11, 2021, 11:06 PM

#

clever wraith does `pipenv run lint` automatically modify the files?

yes, but it doesn't stage those changes

clever wraith Feb 11, 2021, 11:07 PM

#

vale ibex yes, but it doesn't stage those changes

ah

#

@gritty wind made a couple changes. can you check it out?

celest charm Feb 11, 2021, 11:10 PM

#

cosmic moat ah okay, so, why is the class better again (sorry :c)

Well, it's not a lot better. But I'd prefer dataclass because:

TypedDict is much less known
It's designed as more of a patch when you need to typehint a dict when you get a dict from somewhere.
You don't get a clear string while debugging ({"x": 1, "y": 1} instead of Point2D(x=1, y=2)) or in error messages because again, it's just a dict
You can't add methods to the class

gritty wind Feb 11, 2021, 11:10 PM

#

clever wraith <@!386599446571384843> made a couple changes. can you check it out?

Did you push to the PR?

#

alrighty

cosmic moat Feb 11, 2021, 11:11 PM

#

celest charm Well, it's not a lot better. But I'd prefer `dataclass` because: 1) `TypedDict` ...

awesome, thanks

clever wraith Feb 11, 2021, 11:16 PM

#

dumb question, what is a lint?

vale ibex Feb 11, 2021, 11:17 PM

#

From wikipedia lint is a static code analysis tool used to flag programming errors, bugs, stylistic errors, and suspicious constructs

celest charm Feb 11, 2021, 11:18 PM

#

@dataclass
class Video:
    """Represents one video."""

    title: str
    author: str
    id: str

Ugh. I forgot that we have mandatory docstrings.

#

That really looks ugly, together with def start

#

Video
"i wonder what this could possibly represent"
"ah yes, a video"

vale ibex Feb 11, 2021, 11:20 PM

#

~~I mean there's always --no-verify and force merge~~

celest charm Feb 11, 2021, 11:20 PM

#

Although @cosmic moat I would name it SearchResult or something like that. But that's up to you.

cosmic moat Feb 11, 2021, 11:20 PM

#

celest charm Although <@!523662958916665361> I would name it `SearchResult` or something like...

Alright

short snow Feb 11, 2021, 11:21 PM

#

@cosmic moat can unget the upvotes, views count also?

cosmic moat Feb 11, 2021, 11:22 PM

#

celest charm Although <@!523662958916665361> I would name it `SearchResult` or something like...

Done

cosmic moat Feb 11, 2021, 11:22 PM

#

short snow <@!523662958916665361> can unget the upvotes, views count also?

I could, but I don't think it's something we would need or want in this command

#

@vale ibex I made some fixes if you want to reapprove

short snow Feb 11, 2021, 11:23 PM

#

We can use it like the reddit command then

#

showing upvotes and view count

cosmic moat Feb 11, 2021, 11:24 PM

#

Well, I'm aiming for it to be a tool helpful to helpers or sharing videos with others and I think it would take too much space imo

gritty wind Feb 11, 2021, 11:24 PM

#

clever wraith <@!386599446571384843> made a couple changes. can you check it out?

Well as a start, you can definitely drop the section about finding modules. You can usually google python + async + what you want and find something that solves your problem. We don't really have space to spare, so only keep the essentials.

Without a proper explanation, saying that async is flat out faster than sync is misleading. If we can't fit in when it is faster, we can drop that part completely.

Use some line breaks here and there. Blocky paragraphs don't work too well, and people will just end up glossing over, try to limit the paragraphs to two or so lines.

Minor note: You missed Python in Real Python at the bottom.
This does not take into account grammar/spelling, those can be reviewed later.

Reference image of breaking text up, with no other changes:
before: #bot-commands message
vs after: #bot-commands message

short snow Feb 11, 2021, 11:24 PM

#

cosmic moat Well, I'm aiming for it to be a tool helpful to helpers or sharing videos with o...

Well , could u give it a rey?

#

lets see how it goes

#

imo reddit doesn’t much space

gritty wind Feb 11, 2021, 11:25 PM

#

Are you guys speed running a PR? Very nice

vale ibex Feb 11, 2021, 11:25 PM

#

I'm expecting the favour to be returned one day @cosmic moat

cosmic moat Feb 11, 2021, 11:25 PM

#

vale ibex I'm expecting the favour to be returned one day <@!523662958916665361>

Will do

vale ibex Feb 11, 2021, 11:25 PM

#

When you least expect it, I'll call on you

cosmic moat Feb 11, 2021, 11:25 PM

#

gritty wind Are you guys speed running a PR? Very nice

Yes

short snow Feb 11, 2021, 11:26 PM

#

sir-lancebot#586

dusky shoreBOT Feb 11, 2021, 11:26 PM

#

GitHub

PROpen [sir-lancebot] #586 Implemented youtube command

cosmic moat Feb 11, 2021, 11:26 PM

#

YOOOOOO

#

When will it be restarted?

gritty wind Feb 11, 2021, 11:26 PM

#

did you merge?

celest charm Feb 11, 2021, 11:26 PM

#

not yet

#

merge is purple

cosmic moat Feb 11, 2021, 11:27 PM

#

just got pranked

📎 unknown.png

vale ibex Feb 11, 2021, 11:27 PM

#

cosmic moat YOOOOOO

getting ahead of yourself there lol

cosmic moat Feb 11, 2021, 11:27 PM

#

thought that meant a merge

celest charm Feb 11, 2021, 11:27 PM

#

you forgot to change the docstring @cosmic moat lemon_enraged

cosmic moat Feb 11, 2021, 11:27 PM

#

celest charm you forgot to change the docstring <@!523662958916665361> <:lemon_enraged:754441...

Why does it need to be?

#

It represents one video

short snow Feb 11, 2021, 11:27 PM

#

short snow Well , could u give it a rey?

Bump.

cosmic moat Feb 11, 2021, 11:27 PM

#

and is a search result

cosmic moat Feb 11, 2021, 11:27 PM

#

short snow Bump.

Let me get you a screenshot

celest charm Feb 11, 2021, 11:27 PM

#

cosmic moat Why does it need to be?

It represents a search result, not a video, really

cosmic moat Feb 11, 2021, 11:27 PM

#

the search results are videos though pithink

vale ibex Feb 11, 2021, 11:27 PM

#

📎 unknown.png

celest charm Feb 11, 2021, 11:28 PM

#

That's why it's called SearchResult, not Video. If you want to say that it represents a video, call it Video (the naming is up to you)

cosmic moat Feb 11, 2021, 11:28 PM

#

📎 unknown.png

#

Mine is cooler :c

vale ibex Feb 11, 2021, 11:28 PM

#

They're already across multiple lines, so I think adding more without cutting off the line length might look weird

short snow Feb 11, 2021, 11:28 PM

#

cosmic moat Let me get you a screenshot

Cool

cosmic moat Feb 11, 2021, 11:29 PM

#

celest charm That's why it's called `SearchResult`, not `Video`. If you want to say that it r...

I see.. what do you suggest as docstring?

celest charm Feb 11, 2021, 11:29 PM

#

"represents a search result", I guess

vale ibex Feb 11, 2021, 11:29 PM

#

Represents a search result.**

#

gotta abide by the law of doc strings

celest charm Feb 11, 2021, 11:30 PM

#

celest charm "represents a search result", I guess

See, that's my issue with mandatory docstrings. Comments aren't always a good. Sometimes they add absolutely nothing and just repeat what's already said.

#

I'd just leave it at "Represents a video search result" or something like that

vale ibex Feb 11, 2021, 11:30 PM

#

class SearchResult: I wonder what this does?

cosmic moat Feb 11, 2021, 11:31 PM

#

commit -m "more explicit docstring" <- seems like a bad commit, is there anyway to make that better somehow? lol

celest charm Feb 11, 2021, 11:31 PM

#

fix docstring

#

🙂

vale ibex Feb 11, 2021, 11:31 PM

#

fi doc str

cosmic moat Feb 11, 2021, 11:31 PM

#

I honestly like class Video a bit more

celest charm Feb 11, 2021, 11:31 PM

#

Then use Video

gritty wind Feb 11, 2021, 11:31 PM

#

celest charm `fix docstring`

Fixes Docstring

cosmic moat Feb 11, 2021, 11:32 PM

#

does chris have to review again now lol

short snow Feb 11, 2021, 11:34 PM

#

Why do we need the dataclass?

cosmic moat Feb 11, 2021, 11:34 PM

#

short snow Why do we need the dataclass?

Better typehinting

#

and it is nicer to use a class than dict

#

I realize that now after implementing

celest charm Feb 11, 2021, 11:34 PM

#

It's also better if you're going to test it or extend it with new functionality.

vale ibex Feb 11, 2021, 11:34 PM

#

cosmic moat does chris have to review again now lol

lemonshake

cosmic moat Feb 11, 2021, 11:35 PM

#

vale ibex <a:lemonshake:436911467598577664>

Fancy seeing you here, how'd you know to come?

vale ibex Feb 11, 2021, 11:35 PM

#

I sense a ghost ping

clever wraith Feb 11, 2021, 11:35 PM

#

vale ibex

peppa pig

#

lol

celest charm Feb 11, 2021, 11:35 PM

#

celest charm It's also better if you're going to test it or extend it with new functionality.

Also keep in mind that lancebot is a learning project, and this short module is a good example of using dataclasses to describe your data.

sleek steppe Feb 11, 2021, 11:36 PM

#

is it fine that the 8bitify command is blocking?

celest charm Feb 11, 2021, 11:37 PM

#

sleek steppe is it fine that the 8bitify command is blocking?

can you give a link?

vale ibex Feb 11, 2021, 11:37 PM

#

There's a few things in @dusky shore that are blocking

#

I think 8bitify is the worst offender

sleek steppe Feb 11, 2021, 11:37 PM

#

oops

#

.source 9bitify

#

.source 8bitify

#

oh

gritty wind Feb 11, 2021, 11:38 PM

#

.source 8bitify

#

@dusky shore you there?

vale ibex Feb 11, 2021, 11:38 PM

#

gritty wind .source 8bitify

I don't think sir lance has a channel override

gritty wind Feb 11, 2021, 11:38 PM

#

.source 8bitify

dusky shoreBOT Feb 11, 2021, 11:38 PM

#

Command: 8bitify

Pixelates your avatar and changes the palette to an 8bit one.

Source Code

Go to GitHub

clever wraith Feb 11, 2021, 11:38 PM

#

gritty wind Well as a start, you can definitely drop the section about finding modules. You ...

i don't get what you mean about breaking text?

vale ibex Feb 11, 2021, 11:38 PM

#

oh, i lied

celest charm Feb 11, 2021, 11:38 PM

#

It's generally not fine, because, well... while it's blocking, the entire bot halts execution.

#

But for how long does it block?

sleek steppe Feb 11, 2021, 11:39 PM

#

usually like 5-10 seconds

vale ibex Feb 11, 2021, 11:39 PM

#

it depends on the size of the image, I've seen it take seconds before.

gritty wind Feb 11, 2021, 11:39 PM

#

clever wraith i don't get what you mean about breaking text?

Like instead of

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Cras vehicula ligula eu lorem tempus malesuada. Nunc consectetur velit aliquet dui fringilla, sit amet pulvinar mi suscipit. Nulla vehicula quis arcu vitae rhoncus.

we can do

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Cras vehicula ligula eu lorem tempus malesuada.

Nunc consectetur velit aliquet dui fringilla, sit amet pulvinar mi suscipit. Nulla vehicula quis arcu vitae rhoncus.```

celest charm Feb 11, 2021, 11:39 PM

#

sleek steppe usually like 5-10 seconds

If it blocks for 5-10 seconds, then it's not okay, and it should be run in an executor.

#

.8bitify

#

.source 8bitify

dusky shoreBOT Feb 11, 2021, 11:40 PM

#

Command: 8bitify

Pixelates your avatar and changes the palette to an 8bit one.

Source Code

Go to GitHub

sleek steppe Feb 11, 2021, 11:40 PM

#

yea that's what I was thinking

clever wraith Feb 11, 2021, 11:40 PM

#

gritty wind Like instead of ```md Lorem ipsum dolor sit amet, consectetur adipiscing elit. C...

ah

cosmic moat Feb 11, 2021, 11:40 PM

#

we need one more ~~automatic approval~~ review 😎

gritty wind Feb 11, 2021, 11:40 PM

#

Look over the latest round of feedback first 👀

cosmic moat Feb 11, 2021, 11:49 PM

#

@short snow what do you mean?

📎 unknown.png

#

They're guaranteed to have the properties ["snippet"]["title"] because of type=video

short snow Feb 11, 2021, 11:50 PM

#

All the image related commands seem to be blocking.

cosmic moat Feb 11, 2021, 11:50 PM

#

?

short snow Feb 11, 2021, 11:51 PM

#

cosmic moat <@!736234578745884682> what do you mean?

Like on the result json u get, there is no link key or the link key is empty.

cosmic moat Feb 11, 2021, 11:51 PM

#

the link is created by getting the video id -- there is no key for the link directly

#

Also, I don't think it would be empty, since each response is guaranteed to be a valid video

short snow Feb 11, 2021, 11:52 PM

#

Yeah my bad, lets take the title examlle then

cosmic moat Feb 11, 2021, 11:53 PM

#

Well, it has to have a title too

celest charm Feb 11, 2021, 11:53 PM

#

If you're worried about the bot going down -- it won't happen, exceptions are already handled at the top-level by discord.py

#

In this case, an exception doesn't mean a recoverable error -- if google has something unexpected going on, we can't do much about it

#

I'll just repost my comment

📎 unknown.png

cosmic moat Feb 11, 2021, 11:54 PM

#

celest charm In this case, an exception doesn't mean a recoverable error -- if google has som...

Ah, if he meant api going down or such, I'm already handling the errors for that

celest charm Feb 11, 2021, 11:54 PM

#

Google API not being available falls under the "alien lasers" category

#

i.e. unrecoverable error

short snow Feb 11, 2021, 11:55 PM

#

not api, but the result se get is not sccording to our needs, like it didn’t have a certain key or the key was empty

cosmic moat Feb 11, 2021, 11:55 PM

#

Also google won't change their api (iirc) because we're specifically using v3

short snow Feb 11, 2021, 11:55 PM

#

But yeah, there shouldn’t be a chance of this

cosmic moat Feb 11, 2021, 11:56 PM

#

short snow not api, but the result se get is not sccording to our needs, like it didn’t hav...

I don't think this is possible

#

I mean, it could happen

#

But, the chances are so infinitesimally small we don't need to account for it imo

celest charm Feb 11, 2021, 11:56 PM

#

Just like someone could use forbiddenfruit to remove the append method of lists.

#

But we don't check for that.

#

or like we don't check for MemoryError everywhere

#

even though it could occur at almost every line of code.

short snow Feb 11, 2021, 11:57 PM

#

cosmic moat But, the chances are so infinitesimally small we don't need to account for it im...

Yeah

cosmic moat Feb 11, 2021, 11:57 PM

#

as for this, I'm not sure what you mean?

📎 unknown.png

short snow Feb 11, 2021, 11:57 PM

#

fix error already told it

cosmic moat Feb 11, 2021, 11:57 PM

#

ah, could you send a link?

short snow Feb 11, 2021, 11:57 PM

#

marked it as resolved

cosmic moat Feb 11, 2021, 11:58 PM

#

ah, I see :D

#

Alright, finally, the last comment

short snow Feb 11, 2021, 11:58 PM

#

https://github.com/python-discord/sir-lancebot/pull/586#discussion_r574903488

GitHub

Implemented youtube command by SuperMaZingCoder · Pull Request #586...

Relevant Issues
Closes #585
Description
Implemented a new youtube cog which has a youtube (alias: yt) command to search youtube from a specified query. Additionally, there is a fifteen-second coold...

cosmic moat Feb 11, 2021, 11:58 PM

#

how come I can't comment :c

📎 unknown.png

#

Anyways, we should talk about the likes/disklikes/views

#

I started discussing on the pr

clever wraith Feb 12, 2021, 1:47 AM

#

@gritty wind how are the changes I made

short snow Feb 12, 2021, 2:34 AM

#

@cosmic moat just give me a ping whenever you put the ss here.

clever wraith Feb 12, 2021, 2:35 AM

#

@gritty wind

short snow Feb 12, 2021, 2:38 AM

#

he is busy.

#

no need of two pings.

clever wraith Feb 12, 2021, 2:39 AM

#

ok

sleek steppe Feb 12, 2021, 2:47 AM

#

Any tutorials/guides to contributing? the contributing.md kinda confusing and I need to understand it a bit more

short snow Feb 12, 2021, 2:48 AM

#

sleek steppe Any tutorials/guides to contributing? the contributing.md kinda confusing and I ...

which bot?

sleek steppe Feb 12, 2021, 2:49 AM

#

sir lancebot for now

short snow Feb 12, 2021, 2:50 AM

#

sleek steppe sir lancebot for now

https://pythondiscord.com/pages/contributing/sir-lancebot/

Python Discord | Contributing to Sir Lancebot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

sleek steppe Feb 12, 2021, 2:50 AM

#

thank you

clever wraith Feb 12, 2021, 4:10 AM

#

would some image manipulation commands be a good idea?

#

for sir lancebot

keen valley Feb 12, 2021, 5:51 AM

#

what is this pull request in python-discord/bot in github

short snow Feb 12, 2021, 6:13 AM

#

keen valley what is this pull request in python-discord/bot in github

i didn't get you. sorry

keen valley Feb 12, 2021, 6:16 AM

#

https://github.com/python-discord/bot/pulls What is this

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

short snow Feb 12, 2021, 6:17 AM

#

https://guides.github.com/activities/hello-world/#:~:text=Pull Requests are the heart,merge them into their branch.&text=You can even open pull,repository and merge them yourself.

#

it is a feature of github

#

where users can merge their code into the main code