#dev-contrib | Python | Page 54

stable mountainBOT May 9, 2020, 12:55 AM

#

@tawdry vapor :white_check_mark: Your eval job has completed with return code 0.

['A', 'B', 'C', '']

tawdry vapor May 9, 2020, 12:56 AM

#

Is it like so you can always discard the last item?

#

Yeah that was it

#

Looks like it works

#

But I think it's less intuitive than what I had

brazen charm May 9, 2020, 12:59 AM

#

Yeah so just the len can be checked, but they're both a bit hacky

tawdry vapor May 9, 2020, 12:59 AM

#

Maybe I'd use that if it wasn't in a separate function, cause that'd be more convenient

#

But since it's in a function I'll go for what is easier to understand

#

I put it in a function anyway to hide the hack

#

I just couldn't live with doing .count

#

Even though it's negligible here

#

Ah right I couldn't use count anyway cause of the trailing newline thing

brazen charm May 9, 2020, 1:02 AM

#

yeah it doesn't scale too nicely when you don't care about most of the results, and the manual depends on where the last newline is

tawdry vapor May 9, 2020, 1:03 AM

#

My benchmarks were with 2k chars (max for a discord message) and IDK, maybe 10-15 newlines total

#

I used 3 as the count

#

count was .10 seconds

#

Split was like .035

#

And my manual method was 1.1 seconds

brazen charm May 9, 2020, 1:03 AM

#

typo?

tawdry vapor May 9, 2020, 1:03 AM

#

Where?

brazen charm May 9, 2020, 1:04 AM

#

the 1.1 sec

tawdry vapor May 9, 2020, 1:04 AM

#

No. In the help channel I said that

brazen charm May 9, 2020, 1:04 AM

#

that seems way too slow

tawdry vapor May 9, 2020, 1:04 AM

#

I believe it's cause string functions are in C

#

So they are super fast

#

Oh it's cause I have 100000 runs for the timeit

#

😄

brazen charm May 9, 2020, 1:05 AM

#

that's better then

#

the manual should be the fastest if the chars are near the start but that's fairly unlikely to happen with newlines

hollow lichen May 9, 2020, 4:49 PM

#

Good evening, I was looking at how the reminder command was coded, because I needed a similar thing for another project, and looking at the converter: https://github.com/python-discord/bot/blob/d11f077a3402b5efd79f1948c6067e9972dfbea4/bot/converters.py#L197

What's the point of passing ctx as a parameter since it's not used?

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

woeful thorn May 9, 2020, 4:50 PM

#

It's a library requirement

cold moon May 9, 2020, 4:50 PM

#

@hollow lichen It's required on every command

woeful thorn May 9, 2020, 4:51 PM

#

https://discordpy.readthedocs.io/en/latest/ext/commands/api.html#discord.ext.commands.Converter.convert

#

Custom convert functions overload Converter's

hollow lichen May 9, 2020, 4:53 PM

#

Thanks for the insights! I thought it was called like as a "normal" function, but it's not

woeful thorn May 9, 2020, 4:54 PM

#

This is specifically for converters that inherit Converter, you can also ~~decorate~~ annotate them with regular functions where context doesn't need to be passed

#

https://discordpy.readthedocs.io/en/latest/ext/commands/commands.html#basic-converters

hollow lichen May 9, 2020, 4:58 PM

#

It uses the implicit conversion provided by discord.py, ok. I want to say the server's bot is the standard I refer to when searching things on discord bots, thanks for that! I should contribute again

brazen charm May 9, 2020, 8:37 PM

#

Was looking at doing some reviews to help out; with core dev features developed on the repo's branches I can simply pull and then switch to that branch to test it out.
How would I achieve this across forks without some cloning etc.?

molten bough May 9, 2020, 8:37 PM

#

Forks still have all the branches

tawdry vapor May 9, 2020, 8:52 PM

#

Here's an alias you can add which will make it easy to check out PRs

#

[alias]
    cpr = "!cd ${GIT_PREFIX:-.} && git fetch origin refs/pull/${1}/head && git checkout FETCH_HEAD #"

#

You'd just need to type the PR number

#

A more cumbersome way is to add a new remote for the user and then you can checkout PRs from that remote

brazen charm May 10, 2020, 12:49 AM

#

@mellow hare how did this end up? https://discordapp.com/channels/267624335836053506/635950537262759947/707252195006873662

mellow hare May 10, 2020, 12:52 AM

#

It didn't. Sorry, I've been really scatter brained as of late. I think the best course of action is to make an issue for it so it can be discussed and put on the record there

night berry May 10, 2020, 4:18 AM

#

Can someone tell me where exactly await ctx.guild.ban is located?

#

@gusty sonnet Can you help me please

gusty sonnet May 10, 2020, 4:20 AM

#

It's exactly within apply_ban() you can see it here - https://github.com/python-discord/bot/blob/44b33d570642905d4eeb64300a3a2d3d0cb80b72/bot/cogs/moderation/infractions.py#L247

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

night berry May 10, 2020, 4:20 AM

#

Oh!

gusty sonnet May 10, 2020, 4:20 AM

#

It's using the ban() from discord.py, which you can read about here

#

!docs get discord.Guild.ban

stable mountainBOT May 10, 2020, 4:20 AM

#

`discord.Guild.ban`

await ban(user, *, reason=None, delete_message_days=1)```
This function is a [*coroutine*](https://docs.python.org/3/library/asyncio-task.html#coroutine).

Bans a user from the guild.

The user must meet the [`abc.Snowflake`](#discord.abc.Snowflake "discord.abc.Snowflake") abc.

You must have the [`ban_members`](#discord.Permissions.ban_members "discord.Permissions.ban_members") permission to do this.

Parameters  • **user** ([`abc.Snowflake`](#discord.abc.Snowflake "discord.abc.Snowflake")) – The user to ban from their guild.

• **delete\_message\_days** ([`int`](https://docs.python.org/3/library/functions.html#int "(in Python v3.8)")) – The number of days worth of messages to delete from the user in the guild. The minimum is 0 and the maximum is 7.

• **reason** (Optional[[`str`](https://docs.python.org/3/library/stdtypes.html#str "(in Python v3.8)")]) – The reason the user got banned.

Raises  • [`Forbidden`](#discord.Forbidden "discord.Forbidden") – You do not have the proper permissions to ban.
... [read more](https://discordpy.readthedocs.io/en/stable/api.html#discord.Guild.ban)

night berry May 10, 2020, 4:22 AM

#

Where is shadow_tempban function being used?

#

okay, its a command

#

but what is FetchedMember

gusty sonnet May 10, 2020, 4:25 AM

#

It's a converter, so we can do user: FetchedMember in our command, you can read about it here - https://github.com/python-discord/bot/blob/44b33d570642905d4eeb64300a3a2d3d0cb80b72/bot/converters.py#L288

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

#

You can read about converters here - https://discordpy.readthedocs.io/en/latest/ext/commands/commands.html#converters

night berry May 10, 2020, 4:25 AM

#

Oh

#

@gusty sonnet Can you please teach me how to use this converter to ban a user, I have this in my pydisconverter.py file: https://paste.pythondiscord.com/itibajobuv.py

#

How should I use it if I want to make a simple await ctx.guild.ban?

gusty sonnet May 10, 2020, 4:34 AM

#

For normal usages you don't really need to go this far, what are you trying to do

night berry May 10, 2020, 4:34 AM

#

I'm trying to ban/unban a user even if he leaves with his tag or id

gusty sonnet May 10, 2020, 4:35 AM

#

You can still do it if you simply create a discord.Object using their id

#

If they have left the guild, then you have to use the id

night berry May 10, 2020, 4:36 AM

#

oh, okay

#

https://paste.pythondiscord.com/iwowayaget.py

#

I have this

bronze hare May 10, 2020, 3:43 PM

#

I dont know if this is the right channel, but IMHO it would be great to have an alias for !remind as !remindme

brazen charm May 10, 2020, 3:44 PM

#

Think #community-meta would be more sutied but you could also make an issue

glass pecan May 10, 2020, 3:45 PM

#

here is pretty fine i think

#

if you want do want it not potentially lost, an issue will always be better, but casual suggestions as a topic isn't a bad thing here

crude gyro May 10, 2020, 9:26 PM

#

@bronze hare I think it's a good suggestion and you have my approval if you wanna make an issue or a pull request. it's a oneliner to add this alias, so its pretty much a free contribution.

bronze hare May 10, 2020, 9:33 PM

#

unfortunately I'm a bit busy lately and don't think I can set up workflow for it, so if anyone want's to take it over it'd be great.

crude gyro May 10, 2020, 9:45 PM

#

any <@&295488872404484098> want a five minute PR? cuneiform_this

sleek mason May 10, 2020, 9:46 PM

#

hey man i can turn a five minute PR into a five year PR 🙃

rocky bloom May 10, 2020, 9:51 PM

#

im here

valid quest May 10, 2020, 9:51 PM

#

I don't have anything set up yet, so nope :(

#

oh you have some one, nice

rocky bloom May 10, 2020, 9:52 PM

#

just an alias right?

crude gyro May 10, 2020, 9:54 PM

#

just an alias.

rocky bloom May 10, 2020, 9:54 PM

#

cool

#

Done!

tawdry vapor May 10, 2020, 10:11 PM

#

Merged before I could even add labels 😔

#

I'm crazy for those labels

crude gyro May 10, 2020, 10:11 PM

#

merged. feature will be live in like ten minutes, @bronze hare

#

thanks @rocky bloom

#

appreciate it.

rocky bloom May 10, 2020, 10:15 PM

#

no problemo

#

that's actually my first bot contrib 😂

bronze hare May 10, 2020, 10:17 PM

#

It's awesome, ty all folks

rocky bloom May 10, 2020, 10:21 PM

#

Also this is a very small thing

#

but the site still shows the game jam as "upcoming"

sullen phoenix May 10, 2020, 10:56 PM

#

yes, the whole game jam page also needs to be updated. i can work on that tomorrow if someone else doesn't want to do it

tawdry vapor May 11, 2020, 12:50 AM

#

When would this raise a ValueError? https://github.com/python-discord/bot/blob/master/bot/cogs/token_remover.py#L119

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

#

Ah I was testing with "x.y." but if I remove the last dot then it throws the error

#

Never mind

crude gyro May 11, 2020, 5:39 AM

#

@sullen phoenix would be great if you could look at that.

sullen phoenix May 11, 2020, 2:41 PM

#

will do

cold moon May 11, 2020, 2:46 PM

#

https://github.com/python-discord/bot/pull/901#pullrequestreview-408800768 About it, I'd like to get some core devs opinion before I start making changes.

GitHub

PEP command improvisations by ks129 · Pull Request #901 · python-di...

Resolve #891

Made pep_number type hint to int to avoid unnecessary manual converting.
Added ctx.trigger_typing calling to show a user that bot is responding.

Notes

I made it automatically conver...

patent pivot May 11, 2020, 2:47 PM

#

numerlors comments look good

#

However

#

I've been meaning to add stats to the pep command for a while

#

on the PEP command (once we have confirmed it exists and sent it and whatnot) a line like:

self.bot.stats.incr(f"pep_fetches.{pep_number}")

cold moon May 11, 2020, 2:49 PM

#

Basically I should add this to end, then this is guaranteed that this exist

#

But one thing: What about these refreshes command? Should I revert it like this was?

patent pivot May 11, 2020, 2:51 PM

#

what do you mean?

cold moon May 11, 2020, 2:53 PM

#

Numerlor said that current refreshing is not required and this loop request was enough.

cold moon May 11, 2020, 4:37 PM

#

So should I revert this change or stay like it is?

tawdry vapor May 11, 2020, 7:23 PM

#

@dry turret I recently encountered the same thing when writings tests

#

Here's how I did it

#

I moved the string template into a module-scoped variable here https://github.com/python-discord/bot/pull/937/commits/09a6c2e211c0f209b258a02d9677240282c4fab3

#

Here I wrote the test for it https://github.com/python-discord/bot/pull/937/commits/567a5f9242912d6a3340c088c0ae1a62977a141e

#

I mock the string itself so I can assert format() gets called

#

Do you think that is a good approach?

dry turret May 11, 2020, 7:25 PM

#

Yes, seems I just had a case of tunnel vision with it being a f-string to start with, this way makes sense.

dry turret May 13, 2020, 1:40 PM

#

Thanks for the in depth reviews mark, I'm planning on doing some more to get accustomed with the code base and then maybe move on to also doing some features.

tough imp May 13, 2020, 1:59 PM

#

@clever wraith I left a comment under your PR, could you please let us know what the status is? https://github.com/python-discord/seasonalbot/pull/386

GitHub

Bookmark by AG4lyf · Pull Request #386 · python-discord/seasonalbot

This PR is addition to #349
I had to destroy that PR because it got old and due to some reasons(me not knowing how to use github CLI tool) I couldn't update the branch and i can't f...

#

If you don't want to work on it anymore that's ok, but please let us know, so that someone else can finish it

clever wraith May 13, 2020, 2:00 PM

#

I think i don't have anymore time to work on it . sorry for that

tough imp May 13, 2020, 2:01 PM

#

alright, thats ok

clever wraith May 13, 2020, 2:01 PM

#

just need to fix the conflict and it can be merged imo

#

trying to contribute to repos in python-discord github

#

repos are mostly for @dusky shore @stable mountain and pythondiscord.com

#

https://pythondiscord.com/pages/contributing/

Python Discord | Contributing

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

you can look here if you wanna contribute

brazen charm May 13, 2020, 2:06 PM

#

you can take a look at the individual issues in the repos and see if you can help

#

seasonalbot is more friendly to start with and is easier to set up

cold moon May 13, 2020, 2:13 PM

#

About bookmark, is Core Devs able to solve conflicts?

tough imp May 13, 2020, 2:18 PM

#

yeah but since AG no longer has time to work on it, I think it'd be best for potential contributors to implement the feature in their own forks and open their own PRs

#

reading through and taking into account already existing feedback

clever wraith May 13, 2020, 2:19 PM

#

if you can tell me how can i solve conflicts i can try to do so

cold moon May 13, 2020, 2:19 PM

#

You should see Resolve Conflicts button?

clever wraith May 13, 2020, 2:20 PM

#

it is blocked ....

cold moon May 13, 2020, 2:21 PM

#

You should use Sublime Merge https://www.youtube.com/watch?v=ZrdkEBJV660

clever wraith May 13, 2020, 2:25 PM

#

I need to first set it up since i hopped my OS

#

is it normal for this to take ages ?

📎 unknown.png

#

restarted..

dry turret May 13, 2020, 2:34 PM

#

pipenv can be slow at times.

clever wraith May 13, 2020, 3:02 PM

#

ok i installed pipenv
but it is not in path

#

can't lint ...

#

looks like i needed to have something in my Scripts folder with name pipenv.exe can't seems to find that

brazen charm May 13, 2020, 3:07 PM

#

how did you create the environment?

clever wraith May 13, 2020, 3:07 PM

#

python -m pipenv

brazen charm May 13, 2020, 3:08 PM

#

you can do the same for lint then

clever wraith May 13, 2020, 3:08 PM

#

I don't think so cuz it failed

#

📎 unknown.png

brazen charm May 13, 2020, 3:11 PM

#

you can change the entry in pre-commit-config.yaml under flake8 or run it directly

#

but did you create your path var manually? If python is on path then its tools should also be there

clever wraith May 13, 2020, 3:11 PM

#

yes but actually no

#

I should reinstall whole python

clever wraith May 13, 2020, 3:27 PM

#

I am confused i reinstalled it saying pipenv is already installed

#

still no path

#

should try installing somewhere else

brazen charm May 13, 2020, 3:32 PM

#

if it all works like above, just run flake8 through pipenv run

clever wraith May 13, 2020, 4:58 PM

#

@green oriole since you are working on my issue

#

Here is the solution to last problem

#

You use discord.Member instead User in typing and comparing this fix it all and make it ready to be merged

#

I have tested that and that works

green oriole May 13, 2020, 5:00 PM

#

Okay thanks for the tip!

cold moon May 13, 2020, 5:11 PM

#

When using async_cache decorator on function that increase stat, is this increasing stat every time when function is called in cache or not?

patent pivot May 13, 2020, 5:12 PM

#

I presume not

cold moon May 13, 2020, 5:13 PM

#

Hmm...

#

Maybe I should make get_pep_embed returning bool too that show is this success or not?

patent pivot May 13, 2020, 5:16 PM

#

what does it do?

cold moon May 13, 2020, 5:19 PM

#

With this I can make check in !pep command function is embed that returned correct PEP embed, not error message

brazen charm May 13, 2020, 5:28 PM

#

returning the proper embed or None seems to be what you want here

cold moon May 13, 2020, 6:39 PM

#

This may return error embed too

brazen charm May 13, 2020, 6:51 PM

#

imo it would be better if it the error embed was handled elsewhere, since it wouldn't be a pep embed then

solemn cliff May 14, 2020, 1:53 AM

#

hi i'm trying to start out by contributing to something, and if i've done it right so far this issue may be assigned to me later? https://github.com/python-discord/seasonalbot/issues/174

#

i'm just wondering how to start with it

sullen phoenix May 14, 2020, 1:55 AM

#

here's the guide to setup seasonalbot https://pythondiscord.com/pages/contributing/seasonalbot/

Python Discord | Contributing to Seasonalbot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

solemn cliff May 14, 2020, 1:55 AM

#

alright thanks!

sullen phoenix May 14, 2020, 1:57 AM

#

i’ve assigned you the issue

solemn cliff May 14, 2020, 2:01 AM

#

thank you

solemn cliff May 14, 2020, 2:19 AM

#

i'm not sure why but when I try to add the bot to my server, it doesn't do anything when I click on the server I made

#

I do have manage server permissions

#

and it lights up and everything

#

but it doesn't do anything

#

📎 2020-05-13_19-20-19.mp4

sullen phoenix May 14, 2020, 2:22 AM

#

hm clicking on your server doesn't work?

solemn cliff May 14, 2020, 2:23 AM

#

yeah

#

it just doesn't do anything

#

maybe i'm trying to do it from the wrong url?

#

i found this in some stackoverflow thread on adding a bot to discord

sullen phoenix May 14, 2020, 2:25 AM

#

follow this https://discordpy.readthedocs.io/en/latest/discord.html#inviting-your-bot

solemn cliff May 14, 2020, 2:26 AM

#

oh i see what i did wrong

#

i went to a different url

#

still won't let me click 😦

#

same issue

📎 2020-05-13_19-27-03.mp4

sullen phoenix May 14, 2020, 2:28 AM

#

odd

solemn cliff May 14, 2020, 2:35 AM

#

i tried making a new bot and using that, didn't work either

#

new server also didn't work

sullen phoenix May 14, 2020, 2:45 AM

#

you followed the guide i sent right? it seems like some sort of discord issue

solemn cliff May 14, 2020, 2:47 AM

#

yeah it's 100% with discord

patent pivot May 14, 2020, 2:53 AM

#

discord oauth is broken right now I thinkk

#

see https://github.com/discord/discord-api-docs/issues/1623

GitHub

Guild Select Not working · Issue #1623 · discord/discord-api-docs

While Inviting Bot, can't Select Guild from Dropdown. Console

#

solution for now is to add &guild_id=<YOUR GUILD ID> to the end

solemn cliff May 14, 2020, 3:01 AM

#

what's a guild id? how do i find it?

#

oh, okay never mind! i found it

#

thanks!

patent pivot May 14, 2020, 3:05 AM

#

no problem!

clever wraith May 14, 2020, 3:48 AM

#

What database is @stable mountain running on?

#

Its probably the site with rest api, isn't it?

sullen phoenix May 14, 2020, 3:49 AM

#

yes, the site runs postgre

clever wraith May 14, 2020, 3:49 AM

#

How much do you guys pay to run it?

sullen phoenix May 14, 2020, 3:50 AM

#

we're sponsored, so none

clever wraith May 14, 2020, 3:50 AM

#

How much would it take? any ideas?

#

And linode, is it?

sullen phoenix May 14, 2020, 3:51 AM

#

that would depend on the service you're using

#

yes, we're using linode

clever wraith May 14, 2020, 3:52 AM

#

Okay, thank you 🙂

sullen phoenix May 14, 2020, 3:54 AM

#

here's $100 digital ocean free credits if you want it: https://www.digitalocean.com/?refcode=74a1c5d63dac&utm_campaign=Referral_Invite&utm_medium=Referral_Program&utm_source=CopyPaste

clever wraith May 14, 2020, 3:55 AM

#

Thank you @sullen phoenix !

sullen phoenix May 14, 2020, 3:55 AM

#

no problem!

clever wraith May 14, 2020, 4:02 AM

#

@sullen phoenix I had some questions about it

#

What can I do with $100?

#

And will it ask me to pay for anything unless if I ask to purchase something?

sullen phoenix May 14, 2020, 4:04 AM

#

let's move to an off-topic channel instead

clever wraith May 14, 2020, 4:04 AM

#

Oh, sure

quartz halo May 14, 2020, 5:43 AM

#

hello

#

russians here?

hardy gorge May 14, 2020, 5:49 AM

#

Hello,@quartz halo, probably! This is a channel for discussion our community's open source projects, though (see https://git.pythondiscord.com)

quartz halo May 14, 2020, 5:51 AM

#

ok

green oriole May 14, 2020, 8:02 AM

#

Wait, mods was getting pinged eveytime someone did a @something?

hardy gorge May 14, 2020, 8:04 AM

#

Only in #352442727016693763

green oriole May 14, 2020, 8:05 AM

#

Ah I see

crude gyro May 14, 2020, 8:14 AM

#

mostly because when someone pinged us in #352442727016693763 the message is deleted by the bot

#

so we needed to relay it somewhere so we could actually read it

#

but for some reason, users see an @Admins ping on the #352442727016693763 page and they just ping it immediately, for no reason.

#

or they do stuff like !accept @Admins

#

or 1 million other variations on this

molten bough May 14, 2020, 8:16 AM

#

Can confirm, people do this on another server where we have a similar setup

#

Super weird

green oriole May 14, 2020, 8:19 AM

#

Weird people

green oriole May 14, 2020, 8:51 AM

#

It seems like the .uwu <link> feature isn't working properly, am I doing something wrong?

molten bough May 14, 2020, 8:57 AM

#

Uses the ID I think

green oriole May 14, 2020, 8:58 AM

#

The help page says message link

eternal owl May 14, 2020, 2:56 PM

#

@gusty sonnet Im not sure how to resolve the conflict

📎 unknown.png

#

I don't see a button to resolve it :/

gusty sonnet May 14, 2020, 2:57 PM

#

Normally you can resolve it when you pull from master into the branch

#

Then you can resolve the conflict locally, and push a commit to resolve that

#

When you pull there will be a conflict being raised

eternal owl May 14, 2020, 2:58 PM

#

okay I will try

green oriole May 14, 2020, 3:02 PM

#

If the base branch is on the pydis repo you won't be able to push

#

Yup it is

patent pivot May 14, 2020, 3:02 PM

#

ah yeah you'll need to migrate to a fork

cold moon May 14, 2020, 3:03 PM

#

I use Sublime Merge for this

solemn cliff May 14, 2020, 4:17 PM

#

hi, someone sent me the guide for working on seasonal bot - i just had a quick question

#

at the top it says to make a channel "seasonalbot-log" for the server i'm testing in

#

but around the middle it asks for a "dev-log" channel instead

#

which one do I need?

brazen charm May 14, 2020, 4:18 PM

#

It had its own log channel but they got merged into dev-log, so you should only need that one along with the other required channels

woeful thorn May 14, 2020, 4:19 PM

#

The guide has been fixed

solemn cliff May 14, 2020, 4:25 PM

#

alright thanks!

cold moon May 14, 2020, 4:26 PM

#

One thing I found on python-discord/bot repo: this have python37 tag, but this should python38 now

woeful thorn May 14, 2020, 4:27 PM

#

The tag has been changed

cold moon May 14, 2020, 4:44 PM

#

https://github.com/python-discord/bot/pull/817 Can anyone give 2nd review to it? This is pretty old now already and I'd like that when now someone change code, then he change tests too instead that I have to do it.

GitHub

Writing tests for moderation utils. by ks129 · Pull Request #817 · ...

I wrote tests for tests/bot/cogs/moderation/utils.py and created to same folder file init.py (empty).

solemn cliff May 14, 2020, 5:27 PM

#

how should i find the file i'm looking to modify? for the issue i'm working on right now it's modifying the ".earth_photo" command but i'm not sure where to find said command to modify it.

brazen charm May 14, 2020, 5:32 PM

#

I believe that is a new command

solemn cliff May 14, 2020, 5:33 PM

#

https://github.com/python-discord/seasonalbot/issues/174
this thread seems to say that it's been added but needed to be modified, i'm not sure - if it is a new command, where should i create that file? thanks for the help 🙂

GitHub

[Feature Request] Earth Photos · Issue #174 · python-discord/season...

.earth_photo should should make the bot post a random beautiful earth / environment photograph. These must be licensed as public domain or CC. Either add a selection of appropriately licensed photo...

brazen charm May 14, 2020, 8:03 PM

#

@solemn cliff if you meant the previous pull request that has been opened, then that was closed without merging so it's not in the codebase right now. The file itself should be placed into the easter folder inside exts as suggested by the easter tag on the issue

solemn cliff May 15, 2020, 2:03 AM

#

alright, so create a file called "earth_photo.py" in the easter folder?

solemn cliff May 15, 2020, 2:31 AM

#

ok ill summarize what i need rn, i posted this in a help thread but i didnt realize i should probably get someone to help me first

#

i'm trying to write a ".earth_photo" command for seasonalbot, and i'm not really sure where to start; looking at a similar function "april fools videos", I found a basic structure for what i'm writing but i'm not sure how to expand on it.
my code so far:

from pathlib import Path
from discord.ext import commands
log = logging.getLogger(__name__)
class earthPhotos(commands.Cog):
    def __init__(self, bot: commands.Bot):
        self.bot = bot```
a suggestion was to use images from r/earthporn on reddit in order to get the images
but i'm not sure how to load those images or even start with that, this is my first time writing code for a discord bot and any help would be appreciated 🙂

crude gyro May 15, 2020, 11:47 AM

#

@jade tiger hey dude, are you around?

jade tiger May 15, 2020, 12:21 PM

#

Just about to head off to bed, what's up @crude gyro?

hardy gorge May 15, 2020, 12:24 PM

#

we dismissed a stale review on your help PR and are now discussing some of the implementation details

#

I think we figured it out, though

#

it's related to which part you decided to create_taskify in the decorator and why that means you have wrap it around a ctx helper to get it to run properly

jade tiger May 15, 2020, 12:26 PM

#

Ah. Something about it stopping stuff from running while waiting for a delete or timeout or something iirc. I can have a look

hardy gorge May 15, 2020, 12:28 PM

#

Yeah, no worries. I know what it does and why you've done it, I'm looking at another solution that will work for all interactive commands that don't finish immediately

#

instead of making help a special case with an early-return helper function to make sure the decorator finishes in time

crude gyro May 15, 2020, 12:30 PM

#

I also left a review with some minor nitpicks and a question about why you're decorating the prepare function instead of the command function, @jade tiger

#

and Ves will run a quick test and add his thoughts about the redirect. once these things are settled, we will merge it immediately.

#

it's old and it's time to get it merged.

hardy gorge May 15, 2020, 12:31 PM

#

the prepare function is currently necessary

#

because the early return is needed for the decorator to continue in its execution

#

but I've got a proposal to change that

crude gyro May 15, 2020, 12:32 PM

#

but with your suggested refactor might not be?

#

that works for me

hardy gorge May 15, 2020, 12:32 PM

#

yes

crude gyro May 15, 2020, 12:32 PM

#

I think it's very surprising that it decorates that one

#

and it looks suspicious to me

#

a bit like a code smell

hardy gorge May 15, 2020, 12:32 PM

#

Anyway, I've tested the alternative and it works

jade tiger May 15, 2020, 12:33 PM

#

Uhhhh there was a reason why I put the decorator on that one

hardy gorge May 15, 2020, 12:33 PM

#

yes

jade tiger May 15, 2020, 12:33 PM

#

Does ctx.send_help work when it's on the command?

hardy gorge May 15, 2020, 12:33 PM

#

The decorated function needs to return to allow the decorator to continue its execution

#

that's why you needed a helper that quickly returns

jade tiger May 15, 2020, 12:33 PM

#

That's the one

hardy gorge May 15, 2020, 12:34 PM

#

but I've got an alternative that will work in general (for if we decide to add more interactive/long-running commands)

jade tiger May 15, 2020, 12:35 PM

#

Sweet 👍 I'll get to the nitpicks in the morning.... Tired + coding never goes down well with me 😂

crude gyro May 15, 2020, 12:35 PM

#

sorry it took so long to get to

jade tiger May 15, 2020, 12:36 PM

#

No prob

cold moon May 15, 2020, 2:58 PM

#

I asked in issues too but can I get assigned on @stable mountain repo issue #939 and #898?

gusty sonnet May 15, 2020, 3:07 PM

#

Sure, I'll assign you @cold moon

#

Hmm, I can't assign you on 898, didnt show up in the list for me

brazen charm May 15, 2020, 3:09 PM

#

It was still in planning last time I checked so probably needs more discussion on the actual implementation

gusty sonnet May 15, 2020, 3:09 PM

#

That's probably why

brazen charm May 15, 2020, 3:09 PM

#

oh ves just commented

gusty sonnet May 15, 2020, 3:10 PM

#

939 is clear enough, if we can coordinate and get it done with 898 it'll be great too

hardy gorge May 15, 2020, 3:10 PM

#

It's something that could lead to a very ugly implementation rather quickly

#

but we need something that's robust and doesn't use a lot of resources

gusty sonnet May 15, 2020, 3:10 PM

#

What's our stand on the persistent cache, how will it be implemented

hardy gorge May 15, 2020, 3:11 PM

#

Redis

#

@patent pivot was already working on that

#

There may be an issue in the organisation repo

#

not sure

gusty sonnet May 15, 2020, 3:11 PM

#

Hmm, should we wait for it first then, having a redis is probably better to execute this

#

Hmm says Joe is done with it, the issue is here - https://github.com/python-discord/organisation/issues/239

hardy gorge May 15, 2020, 3:13 PM

#

Okay, but is it already easy to use from bot?

#

I've never worked with redis before and we probably need some examples so everyone follows the same naming conventions and the like (for keys and so on)

patent pivot May 15, 2020, 3:51 PM

#

@hardy gorge my part is done

#

I was just setting up redis, @crude gyro is integrating it

green oriole May 15, 2020, 4:59 PM

#

Is it kicking into action?

patent pivot May 15, 2020, 5:03 PM

#

@gusty sonnet with regards to the persistent cache: in theory it will require zero to minimal code changes. the design will be a dictionary like structure but backed by redis. you can still assign with blah["abcdef"] = "abcdef" and fetch with the same method.

#

this will be reused around the bot and be namespaced so it will store in redis as like blah.<key>

#

lemon will write that class and then any persistent storage will be done with that

#

however I see a bit of a flaw with the internal issue. @crude gyro when you say cog-local I think it needs to be more local than that. the help channel cog needs two caches, unanswered & help channel claimants. I think doing it by cog is more confusing than just doing like self.help_channel_claimants = RedisDictionary("prefix")

green oriole May 15, 2020, 5:07 PM

#

Can't have nested dictionaries?

patent pivot May 15, 2020, 5:07 PM

#

not with redis no

#

well

#

you could

#

but I don't think it needs to be that complex

#

either way the proposal is that all cogs get self.cache as a dictionary

#

there needs to be some way to have individual dictionaries, whether that be using a manual constructor or some other clever way

#

dinner time

green oriole May 15, 2020, 5:09 PM

#

Caches are mapping a string to a string, it cannot hold anything fancier, right?

patent pivot May 15, 2020, 5:10 PM

#

Yeah

green oriole May 15, 2020, 5:13 PM

#

What if we make a RedisSerializable ABC, with a method for serializing and deserializing the object, and work around that? We could have a serializable subcache dict that can go in any cache, and will be serialized using simple json?

hardy gorge May 15, 2020, 5:17 PM

#

I don't think our Cogs should become mappings

#

They could have a caching/mapping attribute, as in composition, but they are not mapping objects themselves

#

I don't think we need an abstract base class in this case

gusty sonnet May 15, 2020, 5:18 PM

#

redis is a Dict[str, str] iirc

#

So unless we have ways to serializable complex structure

green oriole May 15, 2020, 5:19 PM

#

Technically, all objects are mapping

gusty sonnet May 15, 2020, 5:19 PM

#

I mean, we can also use json

hardy gorge May 15, 2020, 5:19 PM

#

No, not all objects implement the mapping protocol

#

but, we're getting off-topic

gusty sonnet May 15, 2020, 5:19 PM

#

But for what it's worth redis should stay a simple cache

patent pivot May 15, 2020, 5:20 PM

#

Agreed Ves

green oriole May 15, 2020, 5:20 PM

#

(Mind explaining why not in #internals-and-peps you got me curious? lemon_pika )

patent pivot May 15, 2020, 5:21 PM

#

I don't like the idea of serialising it @green oriole

#

Nested dictionaries aren't a pretty cache

#

And we'd have to be careful of race conditions

#

Redis alone wouldn't have race conditions but if we were serialising the same key we'd have to knock off some performance with locks to achieve the same thing as just have two keys

cold moon May 15, 2020, 5:22 PM

#

@patent pivot I got StatsD now working, but how to make this logging to console?

patent pivot May 15, 2020, 5:22 PM

#

I think a hash set might be a better alternative

#

https://github.com/statsd/statsd/blob/master/exampleConfig.js

GitHub

statsd/statsd

Daemon for easy but powerful stats aggregation. Contribute to statsd/statsd development by creating an account on GitHub.

#

If we did a hash set we'd have two namespaces

#

the command looks like this https://redis.io/commands/hset

green oriole May 15, 2020, 5:23 PM

#

But is making two cache so much of a problem?

patent pivot May 15, 2020, 5:23 PM

#

HSET help-channel-claimants 112233445566778899 123456789123456789

#

then you get a nice dictionary

#

I think that's the better way of doing things

#

Two keys one value

#

One key for the cache name, one key for the cache key, one value

#

Also means less prefixing and easier debugging

#

📎 unknown.png

#

that is what that would look like

#

@crude gyro what do you think of that? prevents us having an overload of keys in the top level namespace. I think hashes are the way to go for the redis integration

#

also I think it's tidier than prefixes

hardy gorge May 15, 2020, 5:31 PM

#

@patent pivot I got StatsD now working, but how to make this logging to console?
@cold moon

What do you mean? To test the stats function you've added? Or?

patent pivot May 15, 2020, 5:32 PM

#

yeah I was telling ks earlier how to debug statsd

hardy gorge May 15, 2020, 5:32 PM

#

I guess we could add trace logging to the method on our asyncclient

#

oh

patent pivot May 15, 2020, 5:32 PM

#

nah it's easier than that

#

you can run a statsd instance to test it

#

uhhh

#

{
    port: 8125,
    backends: [ "./backends/console" ]
}

#

that's all the config I needed

#

and then basically instead of flushing to another backend and storing it just logs all the stats it's accumulated since the last flush there

hardy gorge May 15, 2020, 5:34 PM

#

Do we have that documented somewhere?

patent pivot May 15, 2020, 5:34 PM

#

I'll add it to the stats infra page now

#

Added @hardy gorge @cold moon https://pythondiscord.com/pages/statistic-infrastructure/#running-a-local-statsd-client

Python Discord | Statistic Infrastructure

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

hardy gorge May 15, 2020, 5:40 PM

#

Nice

#

It'll come in handy for our other snek

patent pivot May 15, 2020, 5:40 PM

#

yep yep

hardy gorge May 15, 2020, 6:00 PM

#

@jade tiger I'm sorry, I wrote an essay to suggest a one-line change

woeful thorn May 15, 2020, 6:01 PM

#

Something to print and frame on the wall 🙂

green oriole May 15, 2020, 6:08 PM

#

You could make a blog post out of this one haha lemon_pleased

#

"Why should you use asyncio.~~schedule_task~~create_task instead of await"

hardy gorge May 15, 2020, 6:09 PM

#

I messed up again

#

It's create_task

#

Never type when you're in a hurry

cold moon May 15, 2020, 6:22 PM

#

Nice, thanks

green oriole May 15, 2020, 6:29 PM

#

I'm working on a library to fetch docstrings from builtins and modules, with some smart caching for another project, would you be interested into integrating it into the !doc command, so things like str.replace can be found?

brazen charm May 15, 2020, 6:30 PM

#

!d str.replace

stable mountainBOT May 15, 2020, 6:30 PM

#

`str.replace`

str.replace(old, new[, count])```
Return a copy of the string with all occurrences of substring *old* replaced by *new*. If the optional argument *count* is given, only the first *count* occurrences are replaced.

brazen charm May 15, 2020, 6:30 PM

#

seems to work

green oriole May 15, 2020, 6:32 PM

#

!d str.index

stable mountainBOT May 15, 2020, 6:32 PM

#

`str.index`

str.index(sub[, start[, end]])```
Like [`find()`](#str.find "str.find"), but raise [`ValueError`](exceptions.html#ValueError "ValueError") when the substring is not found.

green oriole May 15, 2020, 6:32 PM

#

Unh

#

Did it get an update?

brazen charm May 15, 2020, 6:32 PM

#

not recently

#

But I have an issue up for some improvements

#

It can't find most of the list methods because they aren't in the inventory if you were remembering those

green oriole May 15, 2020, 6:34 PM

#

Maybe that wasn't str, but some of the builtins doesn't have a proper documentation and are only documented in the tutorial pages

#

I remember there was an issue like that

patent pivot May 15, 2020, 6:38 PM

#

hmm I think I remember

hardy gorge May 15, 2020, 7:13 PM

#

Those are the list methods just mentioned

green oriole May 15, 2020, 7:14 PM

#

Ah indeed

#

Would you be interested by that?

brazen charm May 15, 2020, 7:24 PM

#

how would it work?

#

the closest the inventory gets is some tut-whatever entries on the page where the list methods are listed, so for getting them individually it would have to crawl the docs in some way or some sort of specific way to get those

hardy gorge May 15, 2020, 7:58 PM

#

Akarys probably means fetching the docstrings from the function objects

green oriole May 15, 2020, 8:28 PM

#

Yup, that's the library I'm working on

#

Well, not only functions, modules and attributes have docstrings too

hardy gorge May 15, 2020, 8:32 PM

#

Are you using inspect.getdoc?

jade tiger May 15, 2020, 11:42 PM

#

Lol. No worries ves. And I seemed to find a lot of "ninja code" floating around 😂

jade tiger May 16, 2020, 12:18 AM

#

quick question. how the heck do I run these linters? 😂

#

I tried running pipenv run lint and that went along and fixed a million other files so I just had to revert

#

I then tried pre-commit run --files blah and it tells me flake8 failed

#

I then tried pipenv run flake8 and it tells me that flake8 passed, lol

#

oh and just committing fails too and tells me flake8 failed

#

and running flake8 is fine too

brazen charm May 16, 2020, 12:25 AM

#

What error is it failing with?

#

May need to recreate the precommit or something, there have been some larger changes to the type of linting that gets ran

jade tiger May 16, 2020, 12:26 AM

#

Flake8...................................................................Failed - hook id: flake8 - exit code: 1 Loading .env environment variables�

#

maybe I screwed something up with .env

brazen charm May 16, 2020, 12:28 AM

#

is there anything below that ?

jade tiger May 16, 2020, 12:28 AM

#

nope

#

that's just when I try to commit

brazen charm May 16, 2020, 12:29 AM

#

that is the first line that shows up when it runs

#

do you also get the other checks with precommit like check blanket noqa?

#

that one should be above flake8

jade tiger May 16, 2020, 12:29 AM

#

~~I added -v flag to pre-commit and it's telling me there's no hook with id /bot/cogs/help.py in stage commit. Not sure what that's about~~ nvm that's me mixing up arg order

#

yeah they all passed fine

#

📎 unknown.png

#

pre-commit run -v --files bot/cogs/help.py

Check for merge conflicts................................................Passed
- hook id: check-merge-conflict
- duration: 0.3s
Check Toml...........................................(no files to check)Skipped
- hook id: check-toml
Check Yaml...........................................(no files to check)Skipped
- hook id: check-yaml
Fix End of Files.........................................................Passed
- hook id: end-of-file-fixer
- duration: 0.34s
Mixed line ending........................................................Passed
- hook id: mixed-line-ending
- duration: 0.4s
Trim Trailing Whitespace.................................................Passed
- hook id: trailing-whitespace
- duration: 0.33s
check blanket noqa.......................................................Passed
- hook id: python-check-blanket-noqa
- duration: 0.77s
Flake8...................................................................Failed
- hook id: flake8
- duration: 1.71s
- exit code: 1

Loading .env environment variables�

brazen charm May 16, 2020, 12:35 AM

#

if everything's up to date and pipenv run flake8 works then I've got no idea

tawdry vapor May 16, 2020, 12:38 AM

#

If you'd like, you can create a patch and send it to me. I can then apply it locally and test it out

jade tiger May 16, 2020, 12:42 AM

#

sure

#

I could always just not run the checks and just commit anyway

stable mountainBOT May 16, 2020, 12:43 AM

#

Hey @jade tiger!

It looks like you tried to attach file type(s) that we do not allow (.patch). We currently allow the following file types: .3gp, .3g2, .avi, .bmp, .gif, .h264, .jpg, .jpeg, .m4v, .mkv, .mov, .mp4, .mpeg, .mpg, .png, .tiff, .wmv, .svg, .psd, .ai, .aep, .xcf, .mp3, .wav, .ogg.

Feel free to ask in #community-meta if you think this is a mistake.

jade tiger May 16, 2020, 12:43 AM

#

oh shush

#

could you add me as a friend and I can dm please?

tawdry vapor May 16, 2020, 12:45 AM

#

Can't you paste it here

#

!paste

stable mountainBOT May 16, 2020, 12:45 AM

#

Pasting large amounts of code

If your code is too long to fit in a codeblock in discord, you can paste your code here:
https://paste.pydis.com/

After pasting your code, save it by clicking the floppy disk icon in the top right, or by typing ctrl + S. After doing that, the URL should change. Copy the URL and post it here so others can see it.

jade tiger May 16, 2020, 12:46 AM

#

👍 https://paste.pythondiscord.com/ezatowadal.py

#

not quite sure if I did that right

tawdry vapor May 16, 2020, 12:50 AM

#

Everything works on my end

#

Try re-creating your venv and/or pre-commit cache

#

I just tested with a fresh venv on Windows

jade tiger May 16, 2020, 1:01 AM

#

righto

green oriole May 16, 2020, 7:31 AM

#

Are you using inspect.getdoc?
@hardy gorge well I was using the .__doc__ attribute, it looks like this functions is just a fancy way of getting it, I guess I could use that if that's any better

cold moon May 16, 2020, 9:13 AM

#

I don't understand why but @stable mountain don't send stats to my local StatsD.

#

When I use IDLE and statsd myself, I can send stats

#

But bot don't do anything

hardy gorge May 16, 2020, 9:22 AM

#

Did you look at the __init__ of the Bot class

#

It redirects the output to localhost; is that should happen for you?

#

Maybe @patent pivot can help with that later, but I think he's currently at work

#

I haven't actually set it up myself yet

cold moon May 16, 2020, 9:44 AM

#

Yes, this redirect to localhost for me too

patent pivot May 16, 2020, 11:32 AM

#

Hello @cold moon

#

That's odd

#

Can you connect to statsd manually?

cold moon May 16, 2020, 11:37 AM

#

@patent pivot This is increasing correctly

📎 Screenshot_2020-05-16_at_14.36.32.png

#

But that's only in list. Bot stats should there too.

📎 Screenshot_2020-05-16_at_14.48.53.png

#

I found that setting Graphite + StatsD up is simple with Docker

#

https://github.com/graphite-project/docker-graphite-statsd

GitHub

graphite-project/docker-graphite-statsd

Official Docker image for Graphite. Contribute to graphite-project/docker-graphite-statsd development by creating an account on GitHub.

green oriole May 16, 2020, 12:18 PM

#

statD isn't already on the development stack?

#

We should add a dockerfile for them

patent pivot May 16, 2020, 12:26 PM

#

there isn't much use for most people to run an extra container

#

@cold moon I think it's because your graphite function is incorrect

#

you probably want something like

#

integral(stats_counts.bot.test)

#

but yeah I'm on the fence about adding it to Docker

green oriole May 16, 2020, 12:28 PM

#

I mean we can have multiple dockerfiles

patent pivot May 16, 2020, 12:30 PM

#

right, but this isn't even a dockerfile

#

docker run -d\
 --name graphite\
 --restart=always\
 -p 80:80\
 -p 2003-2004:2003-2004\
 -p 2023-2024:2023-2024\
 -p 8125:8125/udp\
 -p 8126:8126\
 graphiteapp/graphite-statsd

green oriole May 16, 2020, 12:31 PM

#

Well, we could do that too

#

My idea was that you have the main dockerfile, and then some other ones that are the main dockerfle plus some features, like redis or the stats stack

patent pivot May 16, 2020, 12:32 PM

#

right, but they aren't custom pydis services

#

I was speaking with lemon on this and there is no point running redis locally

#

redis doesn't even have windows support

#

so we'll just back the redis cache with a dict locally

#

since persistence isn't required

green oriole May 16, 2020, 12:33 PM

#

And the dict will be dumped to the disk?

#

Because it would mean that you can't test redis features

patent pivot May 16, 2020, 12:34 PM

#

we'll make it optional

#

if you want to run redis locally you can

green oriole May 16, 2020, 12:34 PM

#

Like what if for some reason redis doesn't properly load your cache? You'd push something broken in prod

patent pivot May 16, 2020, 12:34 PM

#

well that's more on redis than the code in bot

#

our redis config file is only 3 lines long, none of which are technically needed in dev

#

# Store all commands used and replay on server startup
appendonly yes

# Set password
requirepass {{ pillar.redis.password }}

# Set working directory
dir /data

cold moon May 16, 2020, 12:39 PM

#

@patent pivot this don't show on cloned StatsD only node too

patent pivot May 16, 2020, 12:39 PM

#

what do you mean?

#

as in console mode?

cold moon May 16, 2020, 12:40 PM

#

Yes

patent pivot May 16, 2020, 12:40 PM

#

hmm

#

even if you connect with a client manually?

cold moon May 16, 2020, 12:40 PM

#

What you mean?

patent pivot May 16, 2020, 12:40 PM

#

in IDLE

cold moon May 16, 2020, 12:41 PM

#

No, then this show

#

Maybe is thing on Docker because I can't connect to local snekbox too

patent pivot May 16, 2020, 12:42 PM

#

oh yeah what IP are you using?

#

and are you running it with ```
docker run -d
--name graphite
--restart=always
-p 80:80
-p 2003-2004:2003-2004
-p 2023-2024:2023-2024
-p 8125:8125/udp
-p 8126:8126
graphiteapp/graphite-statsd

cold moon May 16, 2020, 12:42 PM

#

Yes

patent pivot May 16, 2020, 12:42 PM

#

hmmmmmm

#

if you telnet to localhost:8125 and do something like

#

my_stat:1|c

#

does that appear in graphite

#

honestly I'm tempted to say don't bother running statsd locally

#

maybe you should try hosting a UDP service on port 8125 echoing all messages received (you can do this with netcat if you have it, else should be simple with python)

cold moon May 16, 2020, 1:01 PM

#

I have basically same problem with Snekbox: I can execute it in IDLE, but in bot (Docker) this say can't connect.

#

my_stat:1|c is working

patent pivot May 16, 2020, 1:01 PM

#

hmmm

#

what IP do you connect to in IDLE for statsd

#

same one as the bot does?

cold moon May 16, 2020, 1:02 PM

#

Yep, 127.0.0.1

#

Should I try it in Linux computer?

#

I'm currently on Mac

patent pivot May 16, 2020, 1:03 PM

#

hmmm

#

that's super weird

#

You could try it on Linux but I wrote all the stats stuff purely on Mac

cold moon May 16, 2020, 1:17 PM

#

Huh! Got it working: I run site + postgres in Docker and bot with pipenv run start

#

Then everything works

#

@patent pivot About server boosts, I think easiest way is make task that report amount of Nitro boosts like in every 1h. dpy don't provide events for these. Only way is scan #community-meta messages and message types, but this only show boosts, not unboosts.

patent pivot May 16, 2020, 1:25 PM

#

yeah every 1 hour sounds reasonable to me

#

can add a loop to the stats cog

cold moon May 16, 2020, 1:26 PM

#

ok

solemn cliff May 16, 2020, 3:27 PM

#

hi i'm working on a ".earth_photo" command for the seasonal bot

cold moon May 16, 2020, 3:27 PM

#

@patent pivot So I now added all statistics in https://github.com/python-discord/bot/pull/945 except these #303934982764625920 stats

solemn cliff May 16, 2020, 3:28 PM

#

and i found a library that would speed up the process called PRAW (python reddit API wrapper) and i was wondering if that was installed on the main branch, and if not would it be possible to do so? thanks for the help 🙂

glass pecan May 16, 2020, 3:28 PM

#

hi there

crude gyro May 16, 2020, 3:28 PM

#

you can check that pretty easily, @solemn cliff

#

just look at the Pipfile in that repo

solemn cliff May 16, 2020, 3:29 PM

#

oh alright! thanks!

#

which folder is it in?

crude gyro May 16, 2020, 3:29 PM

#

in the root

glass pecan May 16, 2020, 3:29 PM

#

none

solemn cliff May 16, 2020, 3:29 PM

#

oh alright i found it! thanks for the help!

glass pecan May 16, 2020, 3:29 PM

#

praw we don't have installed because it relies on requests pretty sure btw

crude gyro May 16, 2020, 3:29 PM

#

that's how we track all the dependencies. I'm not sure whether praw is there, but probably not

solemn cliff May 16, 2020, 3:29 PM

#

can I add it? i'm not sure how to do that lol

glass pecan May 16, 2020, 3:29 PM

#

also as a note, is there an issue ticket for the feature already and if so, did you comment on it?

solemn cliff May 16, 2020, 3:29 PM

#

yeah i did

#

i can send it, let me find it real quick

glass pecan May 16, 2020, 3:30 PM

#

coolio thanks

#

and no, you won't be able to add it as it uses requests, which is a http library designed for non-async projects

solemn cliff May 16, 2020, 3:30 PM

#

https://github.com/python-discord/seasonalbot/issues/174
here it is

glass pecan May 16, 2020, 3:30 PM

#

while the bot is async, so we must use an async-compatible http library, which is the lib called aiohttp

solemn cliff May 16, 2020, 3:30 PM

#

oh, okay

#

i'm very new to that kind of thing, are there any resources i can use to find out how to use that?

glass pecan May 16, 2020, 3:31 PM

#

thanks for the link

#

the documentation for aiohttp is here:
https://docs.aiohttp.org/en/stable/

We have an aiohttp session available for usage already intitialised on the bot instance also, i think accessible under bot.http_session or something, will have to check the code to see

#

it's best to use this existing session though rather than creating a new one

solemn cliff May 16, 2020, 3:32 PM

#

alright, thanks for the help!

glass pecan May 16, 2020, 3:33 PM

#

there also should be existing usages in the bot that access that session that you can use as an example

hardy gorge May 16, 2020, 3:33 PM

#

it's http_session

glass pecan May 16, 2020, 3:33 PM

#

thanks

solemn cliff May 16, 2020, 3:33 PM

#

so is this just an API to access webpages?

glass pecan May 16, 2020, 3:33 PM

#

it's a library to request data from web urls

#

so if it's an api, it'll return whatever data it's giving, such as a json formatted data

#

if you give it a webpage, then it'll download the raw html instead

solemn cliff May 16, 2020, 3:34 PM

#

oh so if i put in like "python.org" it'll return an html file?

glass pecan May 16, 2020, 3:35 PM

#

it'll return the raw html content, not a file

solemn cliff May 16, 2020, 3:35 PM

#

like a string? sorry i'm new to this kind of thing lol

glass pecan May 16, 2020, 3:35 PM

#

you'd save that content into a file after retreival if you wanted it to be a file, but we wouldn't since we'd need to use it

#

and yeah like a string

solemn cliff May 16, 2020, 3:35 PM

#

ok cool

glass pecan May 16, 2020, 3:35 PM

#

reddit has an api, and they have docs for it too, but something of note is that we must authenticate our reddit requests to their apis

#

it's part of the agreement, even for apis that are considered public and unrestricted

solemn cliff May 16, 2020, 3:36 PM

#

is that in the docs for the reddit api?

glass pecan May 16, 2020, 3:36 PM

#

it is, but we should have existing uses of this already

#

either in seasonalbot or pythonbot

solemn cliff May 16, 2020, 3:36 PM

#

oh, any specific commands I can check out?

glass pecan May 16, 2020, 3:36 PM

#

i'll have a look, i can't recall atm

solemn cliff May 16, 2020, 3:37 PM

#

thanks

sullen phoenix May 16, 2020, 3:37 PM

#

https://github.com/python-discord/bot/blob/master/bot/cogs/reddit.py

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

#

there’s also another for seasonalbot

solemn cliff May 16, 2020, 3:38 PM

#

ok thanks!

sullen phoenix May 16, 2020, 3:39 PM

#

here it is https://github.com/python-discord/seasonalbot/blob/master/bot/exts/evergreen/reddit.py

GitHub

python-discord/seasonalbot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to bot that changes with the seasons. - python-discord/seasonalbot

solemn cliff May 16, 2020, 3:39 PM

#

(for seasonalbot) is it the one in /evergreen?

#

ok yeah it is thanks!

green oriole May 16, 2020, 5:03 PM

#

Aren't those messages supposed to disappear after some time? #ot1-perplexing-regexing message

cold moon May 16, 2020, 5:21 PM

#

About https://github.com/python-discord/bot/issues/331 , should inspect.getsource help?

GitHub

Source command. · Issue #331 · python-discord/bot

A source command has been discussed as a good addition in the past for the bot, with the following features: !source shows the base github repository link !source <command> will provi...

#

!d inspect.getsource

stable mountainBOT May 16, 2020, 5:21 PM

#

`inspect.getsource`

inspect.getsource(object)```
Return the text of the source code for an object. The argument may be a module, class, method, function, traceback, frame, or code object. The source code is returned as a single string. An [`OSError`](exceptions.html#OSError "OSError") is raised if the source code cannot be retrieved.

Changed in version 3.3: [`OSError`](exceptions.html#OSError "OSError") is raised instead of [`IOError`](exceptions.html#IOError "IOError"), now an alias of the former.

hardy gorge May 16, 2020, 5:29 PM

#

Aren't those messages supposed to disappear after some time? #ot1-perplexing-regexing message
@green oriole

I don't know, but the decorator has never implemented something like that. The redirect_output decorator does, but snekbox isn't using that one.

#

It's using the in_whitelist one (formerly in_channel)

#

The message did change slighty (for if you're wondering what changed)

📎 2020-05-16_19-30.png

green oriole May 16, 2020, 6:25 PM

#

Shouldn't we fix that then?

ocean flame May 16, 2020, 8:27 PM

#

Mb

hardy gorge May 16, 2020, 8:30 PM

#

Shouldn't we fix that then?
@green oriole

What do you mean with fixing? The reason it's not redirected or autodeleted is that the code posted, even without output, is often relevant to the conversation in the channel to which it was posted. Deleting it would also mean we'd have to implement a custom decorator, as I'd hate for the member to lose their input message with the code they wrote during the redirection process.

#

I don't really see it as something that is not working at the moment

#

It's working as intended

brazen charm May 16, 2020, 8:32 PM

#

mildly related, were there any thoughts about sending DMs with contents or something like that when a message gets deleted for attachments?

#

Have seen a few people post a longer message to start a help channel just for it to be removed and lost

woeful thorn May 16, 2020, 8:35 PM

#

Lost?

#

Weren't they attachments the user just sent?

brazen charm May 16, 2020, 8:35 PM

#

They can send a message along with the attachments, which will get deleted

molten bough May 16, 2020, 8:37 PM

#

They seem to be talking about the eval command

woeful thorn May 16, 2020, 8:38 PM

#

And he's asking about something else

molten bough May 16, 2020, 8:38 PM

#

Oh right, I'm blind

hardy gorge May 16, 2020, 8:39 PM

#

Doesn't Discord only suggest the text file if you pasted text into the client?

#

I've not seen it happening when I actually typed a message myself

#

Which also means that deleting that .txt file should not erase the source they copied it from

brazen charm May 16, 2020, 8:40 PM

#

In general when sending a file that'll get caught by the filter

#

You can add a message before uploading, or it'll use the existing one if something was in the input box

hardy gorge May 16, 2020, 8:41 PM

#

So, it's for the message/comment attached to the file?

brazen charm May 16, 2020, 8:41 PM

#

yes

hardy gorge May 16, 2020, 8:42 PM

#

I guess we could try to DM it to the user. I'm less keen on saving a message off Discord, as it could contain personally identifiable information.

brazen charm May 16, 2020, 8:53 PM

#

Could also be extended to some of the other filters, should I make an issue?

#

also got a small pr for increasing the timeout on !eval's re eval timeout if anyone feels like taking a look https://github.com/python-discord/bot/pull/944

hardy gorge May 16, 2020, 8:55 PM

#

Yeah, I was just talking about that to Joe

#

I was wondering why we keep it so short

brazen charm May 16, 2020, 8:57 PM

#

It does check all the events, but I guess there aren't that many edits

hardy gorge May 16, 2020, 8:57 PM

#

I don't think it's much of an issue

#

We're not running into those kind of bottlenecks currently

brazen charm May 16, 2020, 8:58 PM

#

Not that familiar with discordpy (or the dicsord api) but I assume it receives and handles those events in some way anyway?

hardy gorge May 16, 2020, 8:59 PM

#

The events are send out by the API regardless of what we do with them

#

They are gateway events, like your client also receives

#

discord.py dispatches them internally to all listeners

#

So, the cost is running the check function a couple times more, but it doesn't involve additional API calls

brazen charm May 16, 2020, 9:03 PM

#

the simple checks probably take less than how d.py handles the event; what duration were you thinking of?

hardy gorge May 16, 2020, 9:07 PM

#

I wouldn't mind 2 minutes

#

That gives you some time to go back and edit something

cold moon May 17, 2020, 5:41 AM

#

@tawdry vapor I think you should re-review https://github.com/python-discord/bot/pull/901 because this got really big changes after your review.

ocean flame May 17, 2020, 11:51 AM

#

how to create your own repository in git

molten bough May 17, 2020, 11:52 AM

#

Not really the right channel, but if you're using GitHub, just click the + at the top right

#

#tools-and-devops is good for Git chat

ocean flame May 17, 2020, 11:53 AM

#

thx

#

@molten bough in theory from these files that the program earned it is necessary only all .py?

📎 unknown.png

molten bough May 17, 2020, 12:03 PM

#

Again, not the right channel (unless this is a project on the python-discord GitHub)

#

The files required for a project depend on the project, though.

ocean flame May 17, 2020, 12:03 PM

#

@molten bough this project is simple GIF on avatar puts

molten bough May 17, 2020, 12:04 PM

#

!off-topic in that case, I guess

stable mountainBOT May 17, 2020, 12:04 PM

#

Off-topic channels

There are three off-topic channels:
• #ot0-psvm’s-eternal-disapproval
• #ot1-perplexing-regexing
• #ot2-never-nester’s-nightmare

Their names change randomly every 24 hours, but you can always find them under the OFF-TOPIC/GENERAL category in the channel list.

crude gyro May 17, 2020, 12:23 PM

#

#tools-and-devops is acceptable too for git questions

#

and #698153923982262314

#

@molten bough @ocean flame

cold moon May 17, 2020, 12:58 PM

#

@hardy gorge Note about Context.send_help: I already made this in https://github.com/python-discord/bot/pull/860 .

GitHub

discord.py 1.3.x Functionality Migrating by ks129 · Pull Request #8...

To-do list:

Commands directly awaiting: From await ctx.invoke to await cmd(ctx, ...).
Use discord.utils.sleep_until.
Use Context.send_help
Remove unnecessary patch
Use Message.clear_reaction(...

hardy gorge May 17, 2020, 12:59 PM

#

The help invocation was failling after the merge of the help command refactor PR

#

We had to fix it and fix it now

cold moon May 17, 2020, 12:59 PM

#

ok

#

I fix this PR now too

jade tiger May 17, 2020, 1:00 PM

#

Re. Commands per page Ves, could always take that constant at top of file down to 6-7 if it's too annoying

green oriole May 17, 2020, 3:08 PM

#

.. that's an issue

📎 unknown.png

#

Ah okay I'm just being silly haha

cold moon May 17, 2020, 3:14 PM

#

https://github.com/python-discord/bot/issues/796 This issue have been opened some months, but still no decision is this approved or not?

GitHub

Command for fetching package information from PyPi · Issue #796 · p...

These should !package <name> command, that fetch information from PyPi JSON API. This should go under Utils cog. Information that will be shown in embed Name Summary Author Maintainer...

patent pivot May 17, 2020, 3:15 PM

#

seems like a bit more of a seasonalbot thing imo

#

I thought we took a stance that Python should be more focused on guild utilities a while ago

#

though i guess we have stuff like PEP in there so maybe not

hardy gorge May 17, 2020, 3:25 PM

#

I think this is a handy tool that could be used in most channels, while seasonalbot has "fun" commands that should ideally just be run in #sir-lancebot-playground

green oriole May 17, 2020, 3:31 PM

#

@hardy gorge well, that's fair, would it be possible to add reminders to this channel though?

tawdry vapor May 17, 2020, 3:59 PM

#

@cold moon hi. I just noticed your pr and commits use "improvisation". I think you meant to use "improvement"? The former doesn't make sense

cold moon May 17, 2020, 3:59 PM

#

Oh shit... my english... sorry

tawdry vapor May 17, 2020, 4:00 PM

#

It's alright

#

I wonder if it's worth rebasing right before merging to correct that

#

Also, you should keep each line of your commit message at a maximum of 72 characters. If I remember correctly, some of yours were too long and getting cut off for that PR

#

If the prefix is too long to make that feasible then either shorten the prefix (like to "pep:") or remove it completely.

cold moon May 17, 2020, 4:06 PM

#

Okay, I'm turning on PyCharm alerting for that

tawdry vapor May 17, 2020, 4:06 PM

#

This is being said more for future reference as I'm not sure if a rebase should happen

cold moon May 17, 2020, 4:06 PM

#

Is first line limit 50 chars and body line 72 chars?

tawdry vapor May 17, 2020, 4:07 PM

#

Yeah, ideally. Summary can go to 72 though

cold moon May 17, 2020, 4:08 PM

#

ok

solemn cliff May 17, 2020, 4:27 PM

#

how do i test code for the bot?

#

ie if made a new command how do i set up the usage of that command

cold moon May 17, 2020, 4:29 PM

#

You have to run it

#

You have to have testing server + bot

solemn cliff May 17, 2020, 4:29 PM

#

yeah i have that

#

but i mean how do i make it so when i type in the command it runs the function

cold moon May 17, 2020, 4:29 PM

#

Do you know Discord.py well?

solemn cliff May 17, 2020, 4:29 PM

#

no i don't

cold moon May 17, 2020, 4:30 PM

#

I'd suggest to learn dpy first.

#

https://discordpy.readthedocs.io/en/latest/

solemn cliff May 17, 2020, 4:30 PM

#

whats the best way to learn that

#

ok thanks

brazen charm May 17, 2020, 4:33 PM

#

You can look at how other commands are implemented and then use the logic you need for your own one

solemn cliff May 17, 2020, 4:34 PM

#

alright, is there a specific file within the seasonalbot\ repository where the commands are implemented?

brazen charm May 17, 2020, 4:35 PM

#

They'll be under the exts

solemn cliff May 17, 2020, 4:35 PM

#

is it bot.py?

#

oops never mind

#

that's the wrong folder from me lmao

#

wait i think we're thinking of 2 different things

brazen charm May 17, 2020, 4:36 PM

#

discordpy uses Cogs which are classes that contain commands (and then the code needed alongside) and for seasonalbot are loaded when the bot starts

solemn cliff May 17, 2020, 4:36 PM

#

the file i'm looking for is the file where it'll detect an input for example ".hello" and then run the command script which is within \exts\easter for example

#

ok ill read the docs on cogs

#

thanks

brazen charm May 17, 2020, 4:38 PM

#

This is a short one which shows how a command is added https://github.com/python-discord/seasonalbot/blob/master/bot/exts/evergreen/recommend_game.py

GitHub

python-discord/seasonalbot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to bot that changes with the seasons. - python-discord/seasonalbot

#

you create the cog where your code and commands are, then the setup function, then in case of seasonalbot I believe they are added automatically

stable mountainBOT May 17, 2020, 4:39 PM

#

Hey @solemn cliff!

It looks like you tried to attach a Python file - please use a code-pasting service such as https://paste.pythondiscord.com

solemn cliff May 17, 2020, 4:40 PM

#

oops ok

#

https://paste.pythondiscord.com/cinareferu.py

#

i copy pasted reddit.py to see how it works

#

and was gonna modify it after

cold moon May 17, 2020, 4:41 PM

#

Why you have Reddit command there?

solemn cliff May 17, 2020, 4:41 PM

#

the command is ".earth_photo" and its supposed to fetch an image from r/earthporn (it's pictures of earth not... nsfw stuff lol) and send that image

#

already approved on github

cold moon May 17, 2020, 4:43 PM

#

Yes, but you can't just copy-paste existing command

solemn cliff May 17, 2020, 4:43 PM

#

yeah i'm not just submitting that obviously

#

i said im modifying it once i figure out how it works

#

so how do i make it go from

#

receives message ".earth_photo"

#

to

runs the function

brazen charm May 17, 2020, 4:50 PM

#

that's what the command decorator does

solemn cliff May 17, 2020, 4:52 PM

#

ohhhhhhhhh

#

so i change this to name="earth_photo" and it'll do that?

📎 unknown.png

solemn cliff May 17, 2020, 5:25 PM

#

is that how it works?

solemn cliff May 17, 2020, 5:46 PM

#

https://pastebin.com/70LDD5sw
anyone know how to fix this error? when i modified my stuff i didn't touch any of those files

tough imp May 17, 2020, 5:46 PM

#

hmm interesting

#

i'm looking into it

solemn cliff May 17, 2020, 5:47 PM

#

ok thanks

tawdry vapor May 17, 2020, 5:48 PM

#

My guess is something needs to specify unicode encoding when opening a file

tough imp May 17, 2020, 5:48 PM

#

yeah, but it's odd that it never happened until now

#

we were fixing a similar issue in bot for windows users right?

solemn cliff May 17, 2020, 5:49 PM

#

it happened when i ran pipenv run start if that matters

tawdry vapor May 17, 2020, 5:49 PM

#

I don't know. The bot doesn't read as many files

#

Regardless, all files should explicitly specify an encoding

tough imp May 17, 2020, 5:49 PM

#

are you on windows, @solemn cliff ?

tawdry vapor May 17, 2020, 5:49 PM

#

So this never happens

#

Yes, Windows file paths in the log

solemn cliff May 17, 2020, 5:49 PM

#

yes i am on windows

tough imp May 17, 2020, 5:49 PM

#

what's the default encoding there

solemn cliff May 17, 2020, 5:49 PM

#

not sure, how do i check? i'm really new to this

tough imp May 17, 2020, 5:50 PM

#

dont worry ill find it somewhere

tawdry vapor May 17, 2020, 5:50 PM

#

It depends on the OS language

solemn cliff May 17, 2020, 5:50 PM

#

alright

tough imp May 17, 2020, 5:50 PM

#

right so that will be the culprit

#

yeah I can reproduce this if I specify encoding="cp1252"

#

so this particular traceback can be fixed if you go to bot.exts.evergreen.trivia_quiz.py and on line 43 specify p.open(encoding="utf-8") as ...

#

but I reckon another open will fail then

solemn cliff May 17, 2020, 5:55 PM

#

alright ill see if something else fails with that

tough imp May 17, 2020, 5:55 PM

#

it tries to open a lot of resource files

solemn cliff May 17, 2020, 5:55 PM

#

oh

tough imp May 17, 2020, 5:56 PM

#

I'm not sure what we can do to mitigate this apart from going through all of those open calls and specifying the encoding

solemn cliff May 17, 2020, 5:57 PM

#

Traceback (most recent call last):
File "c:\program files\python38\lib\runpy.py", line 184, in _run_module_as_main
mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
File "c:\program files\python38\lib\runpy.py", line 143, in _get_module_details
return _get_module_details(pkg_main_name, error)
File "c:\program files\python38\lib\runpy.py", line 110, in get_module_details
import(pkg_name)
File "C:\Users\aaryan\Documents\python stuff\git stuff\seasonalbot\bot_init.py", line 6, in <module>
import arrow
ModuleNotFoundError: No module named 'arrow'

#

looks like a different error

tough imp May 17, 2020, 5:57 PM

#

yeah thats a separate problem

#

have you done pipenv sync --dev?

#

your environment should have arrow if so, it's in the lock file

solemn cliff May 17, 2020, 5:58 PM

#

oh i think i know what happened

#

i renamed the folder so i probably have to redo pipenv stuff

tough imp May 17, 2020, 5:59 PM

#

yeah it may not be finding the venv then

#

anyway I should make an issue for the encoding thing

#

but I don't look forward to having to do it

dry turret May 17, 2020, 6:00 PM

#

May be it's worth linting for it?

tough imp May 17, 2020, 6:00 PM

#

does flake8 have a plugin for that?

dry turret May 17, 2020, 6:00 PM

#

probably

solemn cliff May 17, 2020, 6:01 PM

#

the sync --dev seems to have done something? but now my cmd is stuck on
05/17/20 11:00:32 - bot.utils.decorators INFO: Starting seasonal task PrideFacts.send_pride_fact_daily (June)

tough imp May 17, 2020, 6:01 PM

#

https://github.com/rayjolt/flake8-file-encoding I will try this and if it's good propose it in the issue

GitHub

rayjolt/flake8-file-encoding

A Flake8 plugin to check for files opened without an explicit encoding - rayjolt/flake8-file-encoding

solemn cliff May 17, 2020, 6:01 PM

#

alright

#

seems to have connected to the server though

📎 unknown.png

tough imp May 17, 2020, 6:01 PM

#

are you sure it's stuck?

solemn cliff May 17, 2020, 6:01 PM

#

that's weird

tough imp May 17, 2020, 6:01 PM

#

yeah

solemn cliff May 17, 2020, 6:02 PM

#

oh so is it just done loading?

tough imp May 17, 2020, 6:02 PM

#

no that's just the last log from the start-up routine

#

yeah

solemn cliff May 17, 2020, 6:02 PM

#

oh ok

#

thanks

tough imp May 17, 2020, 6:02 PM

#

it won't continue logging forever

#

ok but thats weird

#

are you saying that just specifying utf-8 once fixed everything?

#

I thought it'd just fail on another file but looks like that's not the case

solemn cliff May 17, 2020, 6:02 PM

#

yeah

tough imp May 17, 2020, 6:02 PM

#

ok

solemn cliff May 17, 2020, 6:03 PM

#

this is a completely different issue - it looks like I didn't fully input the code for something? i'm not sure what to do from here

📎 unknown.png

tough imp May 17, 2020, 6:03 PM

#

uh oh

solemn cliff May 17, 2020, 6:03 PM

#

happened when i ran the command i just made

brazen charm May 17, 2020, 6:03 PM

#

oh guess the seasonalbot also has the issue

tough imp May 17, 2020, 6:03 PM

#

is that the eventloop thing?

brazen charm May 17, 2020, 6:03 PM

#

Looks like it

#

as a simple temporary fix, doing asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy()) where the bot starts should work beans

solemn cliff May 17, 2020, 6:04 PM

#

alright where should that be put in though? at the top of the <command name>.py file i made?

#

or in the _init_ function

brazen charm May 17, 2020, 6:05 PM

#

it needs to be ran before the bot starts the event loop

solemn cliff May 17, 2020, 6:06 PM

#

sorry im not sure where to find that, is it in the setup() definition?

brazen charm May 17, 2020, 6:06 PM

#

__init__.py or __main__.py should work

solemn cliff May 17, 2020, 6:06 PM

#

ok i'll put it in _init_

brazen charm May 17, 2020, 6:06 PM

#

under seasonalbot/bot

#

but don't commit it as it needs a proper fix

solemn cliff May 17, 2020, 6:07 PM

#

alright

brazen charm May 17, 2020, 6:07 PM

#

you need to put it in the init file, not function; mind that

#

And the file under the above dir beacuse the others may be ran after it's running

solemn cliff May 17, 2020, 6:08 PM

#

ohh ok

#

where in the file? just at the top?

brazen charm May 17, 2020, 6:09 PM

#

should work, just make sure to import asyncio before that

solemn cliff May 17, 2020, 6:09 PM

#

yeah ok

#

ok now the error's in the thing im coding so i should be fine from here on out

#

thanks for the help

tough imp May 17, 2020, 6:13 PM

#

I'll make issues for those two problems so that we can get them fixed in the future, but it won't be instant

#

thanks for reporting them by the way

#

helps us improve the project and make setup easier for others

solemn cliff May 17, 2020, 6:14 PM

#

yeah of course!

tough imp May 17, 2020, 6:22 PM

#

@solemn cliff do you mind if I use the screenshot you posted for the official issue on our github

#

it shows your windows username

#

I can censor it if you prefer

solemn cliff May 17, 2020, 6:23 PM

#

uh censor the username but yeah you can post it

tough imp May 17, 2020, 6:23 PM

#

sure thing thanks

solemn cliff May 17, 2020, 6:23 PM

#

yup

#

would it be possible to import praw for this command? it would be a lot easier than using the kinda process that reddit.py uses

#

sorry to install* praw

#

not import it

tawdry vapor May 17, 2020, 6:39 PM

#

No because praw doesn't support asyncio

solemn cliff May 17, 2020, 6:39 PM

#

oh ok

#

05/17/20 11:48:12 - bot.exts.evergreen.error_handler ERROR: Unhandled command error: 'NoneType' object has no attribute 'url'
Traceback (most recent call last):
  File "C:\Users\aaryan\.virtualenvs\seasonalbot-okXAdm8a\lib\site-packages\discord\ext\commands\core.py", line 83, in wrapped
    ret = await coro(*args, **kwargs)
  File "C:\Users\aaryan\Documents\python stuff\git stuff\seasonalbot\bot\exts\easter\earth_photo.py", line 125, in get_reddit
    embed.set_author(name=f"r/{posts[0]['data']['subreddit']} - {sort}", icon_url=reddit_emoji.url)
AttributeError: 'NoneType' object has no attribute 'url'```
is this an error in my code or in evergreen code?

brazen charm May 17, 2020, 9:51 PM

#

@tough imp were you planning to make an issue for the encodings?

tough imp May 17, 2020, 10:00 PM

#

yes but I was trying to investigate and got distracted

#

if you feel like doing it, it would be greatly appreciated

#

since it looks like it was just one file causing issues in this particular case, I wasn't sure whether we want to go & specify encoding for all io (I naively searched the repo for open( and got 57 results) and maybe propose introducing https://github.com/rayjolt/flake8-file-encoding or maybe just fix up that one line as a stop-gap

brazen charm May 17, 2020, 10:21 PM

#

Will do, got 41 occurrences when I filtered out my search for the open

tough imp May 17, 2020, 10:23 PM

#

excellent, thank you!

#

@solemn cliff sorry for the late reply - yes it's getting triggered in bot\exts\easter\earth_photo.py, based on the traceback it looks like reddit_emoji was None and so didn't have the url attribute

solemn cliff May 18, 2020, 12:50 AM

#

alright, thanks for the help

solemn cliff May 18, 2020, 2:57 AM

#

anyone know how to get the emoji id for a non-custom emoji?

#

for example

#

📷

#

the \:emojiname: doesn't work

patent pivot May 18, 2020, 3:29 AM

#

There isn't one

#

You just use the Unicode

solemn cliff May 18, 2020, 3:33 AM

#

so do i just put 📷 into the place i'd have put the emoji id?

#

it's something for the discord bot

#

(i'm using google translate to see what that meant)

sullen phoenix May 18, 2020, 3:43 AM

#

@solemn cliff we have a command for that

#

!charinfo 📷

stable mountainBOT May 18, 2020, 3:43 AM

#

Character Info

\U0001f4f7: CAMERA - 📷

solemn cliff May 18, 2020, 3:43 AM

#

oh cool, thanks!

#

!charinfo 📹

stable mountainBOT May 18, 2020, 3:43 AM

#

You are not allowed to use that command here. Please use the #bot-commands channel instead.

cold moon May 18, 2020, 5:18 AM

#

@tawdry vapor Removed loop from PEP refresh check

clever wraith May 18, 2020, 9:11 AM

#

Cuando te pregunte

#

me dices

#

de mientras

#

no

molten bough May 18, 2020, 9:12 AM

#

!rule 4 - sorry, but I can't understand you with Google Translate even

stable mountainBOT May 18, 2020, 9:12 AM

#

Rules

4. This is an English-speaking server, so please speak English to the best of your ability.

clever wraith May 18, 2020, 9:14 AM

#

Wait

#

If i am spanish i need talk english

#

wtf

molten bough May 18, 2020, 9:18 AM

#

The staff here mostly speaks English, so it's impossible for them to moderate other languages

cold moon May 18, 2020, 10:37 AM

#

Why Mocks don't allow you to add new attribute: AttributeError: Mock object has no attribute ... (MockContext)

hardy gorge May 18, 2020, 10:52 AM

#

It's because they follow the specification of an actual instance of Context

#

Why do you want to assign an additional attribute?

cold moon May 18, 2020, 10:53 AM

#

I'm testing error handler and this check attribute invoked_from_error_handler.

hardy gorge May 18, 2020, 10:54 AM

#

If that's a custom attribute that we set, we need to adjust the mock to reflect that

cold moon May 18, 2020, 10:55 AM

#

Okay

hardy gorge May 18, 2020, 10:57 AM

#

You should be able to set it on the context instance we use to create the mock

cold moon May 18, 2020, 10:57 AM

#

But I need to do that this is not on every instance

hardy gorge May 18, 2020, 10:57 AM

#

We just need to make sure that the mock object recognizes that it's a valid attribute that may exist

#

If you add the second line to helpers.py at the right place, it should work:

context_instance = Context(message=unittest.mock.MagicMock(), prefix=unittest.mock.MagicMock())
context_intance.invoked_from_error_handler = None

cold moon May 18, 2020, 10:59 AM

#

OK, thanks

#

Wait, now I added this and now this attribute always exist

#

What mean existing tests fails

hardy gorge May 18, 2020, 11:03 AM

#

It always exists in the sense that just like with every other valid attribute of a normal Context instance, the mock will happily provide a mock for it

#

That is the default behavior of regular mocks that do not follow a specification:

#

>>> from unittest.mock import MagicMock
>>> m = MagicMock()
>>> hasattr(m, "invoked_from_error_handler")
True

#

What our spec_set does is say "Only every allow there attributes and raise an AttributeError for any other attribute that something tries to access or set"

#

Since we actually use that attribute in production, we must make sure that our mock allows it as an attribute as well

#

That's what you just did

cold moon May 18, 2020, 11:15 AM

#

I have to change error handler code then a bit

hardy gorge May 18, 2020, 11:17 AM

#

Why? Can you just check what kind of value we have for that attribute?

#

If the code assigns a value, you should be able to see that it assigned that explicit value

cold moon May 18, 2020, 11:18 AM

#

I changed hasattr to getattr

#

if isinstance(e, errors.CommandNotFound) and not getattr(ctx, "invoked_from_error_handler", False):

celest charm May 19, 2020, 12:43 AM

#

Does the bot support live reloading? Or do I have to restart the server every time I change a cog?

brazen charm May 19, 2020, 12:44 AM

#

could unload and load it again

#

I just restart the bot personally, but I'm running it directly

celest charm May 19, 2020, 12:46 AM

#

I'm using docker

brazen charm May 19, 2020, 12:50 AM

#

looks like there's https://github.com/python-discord/bot/blob/master/bot/cogs/extensions.py#L59 for a neat interface

celest charm May 19, 2020, 1:00 AM

#

Oh, thanks

celest charm May 19, 2020, 1:29 AM

#

Would a regexp testing command make sense on this server?

#

It can be kinda useful when explaining regular expressions.

📎 unknown.png

#

You can use emojis as subcommand aliases... but I don't know how useful that is.

📎 unknown.png

cold moon May 19, 2020, 6:37 AM

#

RuntimeWarning: coroutine 'AsyncMockMixin._mock_call' was never awaited

How to remove this warning without awaiting. https://paste.pythondiscord.com/zuritaqipe.py . This ErrorHandler.get_help_command is reason

#

But I don't know how to fix

hardy gorge May 19, 2020, 6:42 AM

#

Oh

#

That's actually something that's not okay in the current code

#

In some situations, the coroutine isn't awaited

#

I introduced that mistake

#

One way to solve this would be to change the way it's done

#

Remove the

        prepared_help_command = self.get_help_command(ctx)

and alter these lines:

            await prepared_help_command

to

            await self.get_help_command(ctx)

cold moon May 19, 2020, 6:46 AM

#

OK, thanks

green oriole May 19, 2020, 8:02 AM

#

Does the bot support live reloading? Or do I have to restart the server every time I change a cog?
@celest charm !extensions reload <extension name> can do that

cold moon May 19, 2020, 8:57 AM

#

Should I include stats increasing too into tests?

green oriole May 19, 2020, 9:02 AM

#

I don't think so

cold moon May 19, 2020, 10:22 AM

#

How some peoples can self-assign in issues?

#

https://github.com/python-discord/bot/issues/953

woeful thorn May 19, 2020, 10:31 AM

#

Staff

cold moon May 19, 2020, 10:36 AM

#

But decorator-factory have only Contributor badge in GitHub?

woeful thorn May 19, 2020, 10:39 AM

#

You don’t need to make membership public

cold moon May 19, 2020, 10:43 AM

#

Oh

crimson beacon May 19, 2020, 11:11 AM

#

I'm new in this chanel and I'm Polish I use with google translater and I started with phyton I need some help with open image can anyone help me

cold moon May 19, 2020, 11:14 AM

#

@crimson beacon This is not right channel for this. I'd suggest to read #❓｜how-to-get-help , smaller/quick questions you can ask in #python-discussion but something bigger get one available help channel and send your question and code.

molten bough May 19, 2020, 11:14 AM

#

This might also be helpful https://wiki.python.org/moin/LocalUserGroups#Poland

#

Wonder if it'd be useful to have a command that parses this page

cold moon May 19, 2020, 11:17 AM

#

There should tag

signal kestrel May 19, 2020, 8:24 PM

#

Hello people!

celest charm May 20, 2020, 1:43 AM

#

Is it OK if I stick to a shorter line length limit? Given that it's consistent inside a single file.

tawdry vapor May 20, 2020, 1:44 AM

#

Yes

#

I do it all the time and no one complains 🤷‍♂️

celest charm May 20, 2020, 1:45 AM

#

👍

#

Although it might be an issue because of D200 One-line docstring should fit on one line with quotes
This fits in 80 characters, but fails with flake8:

        """
        Commands for exploring the misterious world of regular expressions.
        """

But this one is 82 characters long:

        """Commands for exploring the misterious world of regular expressions."""

celest charm May 20, 2020, 2:36 AM

#

How do I add a new dependency?
I added this line to [packages] in bot's Pipfile:
regex = "~=2020.5.14"
then I ran:
pipenv lock
pipenv sync --dev
Now I can use regex in the REPL, but it can't find the module when running with docker.

#

I also have regex installed on all python3 interpreters on my system, so that isn't the problem.

green oriole May 20, 2020, 6:13 AM

#

You can murder the cache by running docker-compose up --build maybe that could help

crude gyro May 20, 2020, 6:38 AM

#

@celest charm your local pipenv does not affect what's in the docker containers. it only installs new dependencies when you rebuild the container

#

so after changing the pipfile, do docker-compose build bot or docker-compose up --build

#

and it will take care of it.

#

the pipenv install for that dependency only happens inside the Dockerfile, but when you up a container it usually does not run the code in the Dockerfile. it just runs an existing container on your computer

#

that's why you have to rebuild

green oriole May 20, 2020, 6:45 AM

#

That’s weird that docker doesn’t want to rollback the container and rebuild, because the pipfile changed

tawdry vapor May 20, 2020, 6:49 AM

#

I don't find it weird

#

Containers are not "tied" to the build steps

#

They're just instances of a certain build

green oriole May 20, 2020, 6:51 AM

#

I guess I need to read the docs again then haha

tawdry vapor May 20, 2020, 6:53 AM

#

Think of it like this: Dockerfile is the analogous to source code, an image analogous to a binary, and a container analogous to a process

#

The process is executing a particular version of the binary. It's not aware of the underlying source.

cold moon May 20, 2020, 6:59 AM

#

About source command, should this have channel limitations?

crude gyro May 20, 2020, 7:08 AM

#

probably not

#

@cold moon couple of questions for you on https://github.com/python-discord/bot/pull/864

GitHub

Ban and kick reason length fix by ks129 · Pull Request #864 · pytho...

Closes #861
Description
This PR main direction is to shorten reason in places, where is limit of characters. Main places is: Kick and Ban Audit Log entries, user notification and ModLog entries. Th...

#

sorry the review took a while, it's been a crazy month

#

my bad

cold moon May 20, 2020, 8:17 AM

#

@crude gyro This is now done.

crude gyro May 20, 2020, 8:25 AM

#

will take a look in a second

#

@cold moon did you test this after making these changes?

celest charm May 20, 2020, 11:33 AM

#

Thanks, @crude gyro

crude gyro May 20, 2020, 11:59 AM

#

no problem

celest charm May 20, 2020, 1:04 PM

#

I'm having a problem with the bot: I fetched the main repo to update Pipfile, and the bot fails to build now because of linting errors on lots of files:
https://dev.azure.com/python-discord/Python Discord/_build/results?buildId=7022&view=logs&j=5264e576-3c6f-51f6-f055-fab409685f20&t=ba73fe70-97c4-5e2d-5cc4-47c0f87130c8
and flake8 produces the same output. How to deal with that?

#

I mean, that f-string is missing placeholders

            title=f"**PEP 0 - Index of Python Enhancement Proposals (PEPs)**",

brazen charm May 20, 2020, 1:07 PM

#

I'm not really sure how the version pinning works but your flake8 got updated to 3.8.1 which introduced new linting errors

celest charm May 20, 2020, 1:07 PM

#

Can I just switch to a new branch and fix them?

brazen charm May 20, 2020, 1:08 PM

#

The flake8 update is already in one of the open prs so I think it should all be handled there

celest charm May 20, 2020, 1:08 PM

#

Well, some of them aren't really errors, that's the issue.

brazen charm May 20, 2020, 1:08 PM

#

(and probably already is)

#

could maybe pin the version directly for now? Feels hacky though

#

and the other pr may get merged before, not really sure myself how it should be handled here or if it's an issue with how pipenv interpreted the ~=

tough imp May 20, 2020, 1:11 PM

#

we should have probably done the flake8 bump in a separate PR

#

but the lockfile still has 3.7

#

so unless you re-lock you shouldn't have that problem

celest charm May 20, 2020, 1:12 PM

#

Well, I relocked, that's the issue

brazen charm May 20, 2020, 1:12 PM

#

They did introduce a new package

celest charm May 20, 2020, 1:12 PM

#

Because I had to add feedparser and something else from master

#

And also a new package

tough imp May 20, 2020, 1:12 PM

#

ah right, is there no way to do that without relocking everything?

hardy gorge May 20, 2020, 1:12 PM

#

No

brazen charm May 20, 2020, 1:12 PM

#

Was planning to make a pr but kept delaying it until lemon added it to the redis pr

hardy gorge May 20, 2020, 1:12 PM

#

But we could pin the flake8 version more strictly

tough imp May 20, 2020, 1:12 PM

#

could this be solved by cherry picking the commit from lemon's branch?

hardy gorge May 20, 2020, 1:12 PM

#

I think the redis PR in its current form is dead

#

It needs a major overhaul

celest charm May 20, 2020, 1:13 PM

#

So I'll just pin flake8 to 3.8.0?

brazen charm May 20, 2020, 1:13 PM

#

you'll want before 3.8

celest charm May 20, 2020, 1:13 PM

#

right

#

because it's semantically versioned

hardy gorge May 20, 2020, 1:14 PM

#

flake8 = "~=3.7.9" should work

tough imp May 20, 2020, 1:14 PM

#

we could also just bump it to 3.8 and fix up the new errors in a separate PR

hardy gorge May 20, 2020, 1:14 PM

#

yeah, but it will have to be done

tough imp May 20, 2020, 1:15 PM

#

I want to say that I can do it tonight, but I already have a lot on my plate

celest charm May 20, 2020, 1:15 PM

#

alas, I will have to see that god damn long Locking... animation again

hardy gorge May 20, 2020, 1:15 PM

#

@crude gyro How do you feel? The current change is in your PR, but that PR is probably going to take a while

brazen charm May 20, 2020, 1:16 PM

#

I could do it if needed but I'm not very familiar with pipenv beyond setting it up for running

crude gyro May 20, 2020, 1:16 PM

#

if you guys wanna do that work in a different PR, you can easily cherry pick my commit for it

tough imp May 20, 2020, 1:16 PM

#

yeah I'm thinking that the work is basically done

crude gyro May 20, 2020, 1:16 PM

#

it is done, and it's all in one commit

tough imp May 20, 2020, 1:16 PM

#

just need to cherry pick it into a separate branch

crude gyro May 20, 2020, 1:16 PM

#

yeah. and if you do that, I don't need to change anything either

tough imp May 20, 2020, 1:17 PM

#

true, I'd be in favour of doing that then

crude gyro May 20, 2020, 1:17 PM

#

it's actually better because it makes my PR easier to review

#

removes all the noise

#

once it's merged to master, at least

celest charm May 20, 2020, 1:17 PM

#

So git cherry-pick -x e993566

crude gyro May 20, 2020, 1:18 PM

#

what's -x supposed to do

#

aha

celest charm May 20, 2020, 1:19 PM

#

Should I pick your version?

📎 unknown.png

crude gyro May 20, 2020, 1:19 PM

#

-x
When recording the commit, append a line that says "(cherry picked from commit …)" to the original commit message in order to indicate which commit this change was cherry-picked from. This is done only for cherry picks without conflicts. Do not use this option if you are cherry-picking from your private branch because the information is useless to the recipient. If on the other hand you are cherry-picking between two publicly visible branches (e.g. backporting a fix to a maintenance branch for an older release from a development branch), adding this information can be useful.

#

yes, my version has the lint fix

#

or else the linter will complain on flake8 3.8

#

strings without any interpolated data don't need to be f-strings

#

flake8 3.8 complains about this

brazen charm May 20, 2020, 1:20 PM

#

I'm curious, how does the ~= work that it skipped to 3.8?

celest charm May 20, 2020, 1:20 PM

#

🤔
bot/cogs/error_handler.py:170:31: F821 undefined name 'help_command'

clever wraith May 20, 2020, 1:20 PM

#

how can i help here?

celest charm May 20, 2020, 1:20 PM

#

Maybe I shouldn't have picked your version there

clever wraith May 20, 2020, 1:21 PM

#

new here

crude gyro May 20, 2020, 1:21 PM

#

@brazen charm ~= 2.2 means >= 2.2 and also ==2.*

brazen charm May 20, 2020, 1:21 PM

#

ah so == 3.7.* would be more suited then?

crude gyro May 20, 2020, 1:22 PM

#

if that's what you want

#

in this case I think upgrading to 3.8 is good

#

~= is called "closest compatible release"

#

in the relevant PEP

#

of course, minor versions do sometimes introduce breaking changes

#

but they're not really supposed to. with a linter it's a bit special

#

it's not really introducing breaking changes, just new rules

brazen charm May 20, 2020, 1:23 PM

#

Upgrading is good, but with flake8 those usually need to be taken care of in a pr

crude gyro May 20, 2020, 1:23 PM

#

yes

#

so perhaps pinning it more strictly now could be good

hardy gorge May 20, 2020, 1:23 PM

#

In this case, "~=3.7.9" would have been the right pick

#

It says everything from 3.7.9 and up, but below 3.8

#

So, 3.7.10 would have been fine, but 3.8.0 not

#

And 3.7.6 also wouldn't have been fine (lower than 3.7.9)

brazen charm May 20, 2020, 1:24 PM

#

Just that it could be changed in the update pr if it's still like before so the above problems could be avoided when 3.9 comes

celest charm May 20, 2020, 1:30 PM

#

cherry-picked the commit, build is successful! thanks everyone

cold moon May 20, 2020, 1:31 PM

#

I have one idea: !source command should have 2 subcommands: site and seasonalbot that have short description of these projects and GitHub link.

celest charm May 20, 2020, 1:32 PM

#

Maybe that commit could be removed later with git history screwery because here it's a temporary solution, but that sounds extra hacky.