dense barn Jun 24, 2021, 5:11 PM

#

perhaps

#

for webhooks

#

probably

tiny shard Jun 24, 2021, 5:12 PM

#

but that sounds good yeah i see no issue with the entity obj

dense barn Jun 24, 2021, 5:12 PM

#

fetch apis are the priority for api/v1

tiny shard Jun 24, 2021, 5:12 PM

#

@dense barn oh oh oh, you might want to pass like, a discordId in the entity

#

cuz arent ids not discord bound anymore

dense barn Jun 24, 2021, 5:13 PM

#

yea

#

the id = discord id for now

tiny shard Jun 24, 2021, 5:13 PM

#

rihgt

#

maybe userId then?

#

not sure

dense barn Jun 24, 2021, 5:13 PM

#

user

#

the webhook won't change

#

user: string still gives the user id

tiny shard Jun 24, 2021, 5:13 PM

#

yeah, but how do u access the top.gg user's id?

dense barn Jun 24, 2021, 5:13 PM

#

ah

#

for api/v1 we will expose a basic user payload

tiny shard Jun 24, 2021, 5:14 PM

#

ok_spin

dense barn Jun 24, 2021, 5:14 PM

#

e.g.

#

user {
  id: string;
  connections: [
    { type: "discord", id: string },
  ];
}

tiny shard Jun 24, 2021, 5:14 PM

#

got it

dense barn Jun 24, 2021, 5:14 PM

#

gmm

#

connections: {
  discord: {}
}

#

also looking clean

#

but it might be a little bit more complicated

tiny shard Jun 24, 2021, 5:16 PM

#

dense barn ``` user { id: string; connections: [ { type: "discord", id: string }, ...

iirc what most people do is this

#

discord does it, google does it, plenty others

dense barn Jun 24, 2021, 5:17 PM

#

yea

#

this is what we also do under the hood

dusky shale Jun 25, 2021, 8:01 AM

#

@surreal socket https://github.com/top-gg/python-sdk/blob/master/topgg/client.py#L63 still refers to on_guild_post. Maybe it can get fixed along with the README.md—the redundant variable and consistency in using quotes mark. It can be copy-pasted from https://docs.top.gg/libraries/python/, I guess. Or you may have fixed it?

surreal socket Jun 25, 2021, 8:02 AM

#

Oh huh what

#

I'll get on it after college

#

Thanks for noticing 👀

dusky shale Jun 25, 2021, 8:04 AM

#

Okie, np

worthy cypress Jun 25, 2021, 2:02 PM

#

dense barn fetch apis are the priority for api/v1

poggers dude

#

honestly looking forward to that

surreal socket Jun 26, 2021, 5:54 PM

#

@dusky shale all deps in requirements-dev except pytest itself

dusky shale Jun 26, 2021, 5:56 PM

#

Yeah?

surreal socket Jun 26, 2021, 5:57 PM

#

Should I add pytest in requirements-dev? 😂

dusky shale Jun 26, 2021, 5:58 PM

#

pytest-asyncio and pytest-mock depends on it I guess

#

But if you wanna explicitly list it, why not? xd

surreal socket Jun 26, 2021, 5:58 PM

#

I don't think so

#

sec

dusky shale Jun 26, 2021, 5:59 PM

#

It didn't install pytest?

surreal socket Jun 26, 2021, 5:59 PM

#

Oh yeah it did

#

I'm just being dumb

dusky shale Jun 26, 2021, 6:00 PM

#

You're not 🍭

#

Is it rolling out pogey

surreal socket Jun 26, 2021, 6:00 PM

#

I'm trying to get back my PyCharm settings I used before KEKW

dusky shale Jun 26, 2021, 6:01 PM

#

topggJoy

surreal socket Jun 26, 2021, 6:02 PM

#

Mmmm yes

#

attr is a list and is either owners or guilds

dusky shale Jun 26, 2021, 6:07 PM

#

Why does it match the key type though?

surreal socket Jun 26, 2021, 6:08 PM

#

tbf the list check is redundant

#

both of those keys are lists anyway and if they're not then shit's very bad

dusky shale Jun 26, 2021, 6:09 PM

#

Wait, the attr itself is the list, not the value

#

Or rather, the key

#

The list won't equal both owners and guilds, will it?

surreal socket Jun 26, 2021, 6:10 PM

#

It won't, hence the in

#

I was accidentally checking if attr itself is a list and then if attr is either equal to owners or guilds

#

I'm surprised PyCharm wasn't yelling at me for this before

dusky shale Jun 26, 2021, 6:10 PM

#

exdee, prob caching issues

surreal socket Jun 26, 2021, 6:11 PM

#

oh wait no I just excluded the tests folder from inspections

dusky shale Jun 26, 2021, 6:11 PM

#

Ah

worthy cypress Jun 27, 2021, 5:32 AM

#

be me
be trying to fix your top.gg library code for almost a month now
you realize the error was within your class initializer function
you forgot ["status"] because you were checking the object and not the JSON response code

#

on the more bright side that doesn't include my highly shown stupidity, i can finally push the update to the PHP library that implements automatic stats posting and webhook integrations

surreal socket Jun 27, 2021, 7:20 AM

#

KEKW

#

@dusky shale like 3 years and we haven't thought about closing the request in HTTPClient.request method

#

This is fun!

dusky shale Jun 27, 2021, 7:28 AM

#

Closing the request? Isn't it a context manager?

surreal socket Jun 27, 2021, 7:28 AM

#

It is, and we either return the request body or raise an error

#

so basically it doesn't close

#

Makes sense for me to only keep my log.debug in the context manager, right?

dusky shale Jun 27, 2021, 7:29 AM

#

__aexit__ does close it though

surreal socket Jun 27, 2021, 7:31 AM

#

I don't think it closes when I return within it?

#

Since it doesn't actually exit topggThink

dusky shale Jun 27, 2021, 7:36 AM

#

surreal socket I don't think it closes when I `return` within it?

It's still called even when you return it, because it goes out of that block. Kind of behave like finally I guess.

surreal socket Jun 27, 2021, 7:36 AM

#

Oh, I see

dusky shale Jun 27, 2021, 7:36 AM

#

But yeah, I think it actually just "releases" the connection. There's release and close lmao. Probably a good idea to call it explicitly

surreal socket Jun 27, 2021, 7:37 AM

#

You mean close the request manually?

dusky shale Jun 27, 2021, 7:37 AM

#

It got these comments ```

We're basing behavior on the exception as it can be caused by

user code unrelated to the status of the connection. If you

would like to close a connection you must do that

explicitly. Otherwise connection error handling should kick in

and close/recycle the connection as required.

#

So, either way is fine, I guess

surreal socket Jun 27, 2021, 7:38 AM

#

Where's that? 👀

dusky shale Jun 27, 2021, 7:38 AM

#

https://github.com/aio-libs/aiohttp/blob/master/aiohttp/client.py#L1072-L1086

surreal socket Jun 27, 2021, 7:49 AM

#

oh

brisk fossil Jun 27, 2021, 2:23 PM

#

Since when did topggpy stop returning dictionaries?

dusky shale Jun 27, 2021, 2:26 PM

#

Since never

surreal socket Jun 27, 2021, 2:37 PM

#

DataDict is subclass of dict, v1.1

worthy cypress Jun 27, 2021, 3:59 PM

#

surreal socket <:KEKW:727825308404940800>

utter pain

surreal socket Jun 27, 2021, 4:26 PM

#

Pain

surreal socket Jun 27, 2021, 5:33 PM

#

https://github.com/top-gg/python-sdk/issues/53 @dusky shale what do you mean with this? What's wrong with sleeping on 429 instead of continuing to second iteration?

GitHub

Unnecessary backoff and dubious sleep delay · Issue #53 · top-gg/py...

python-sdk/topgg/http.py Lines 126 to 148 in 6752d47 elif resp.status == 429: # we are being ratelimited fmt = "We are being ratelimited. Retrying in %.2f seconds (%.3f minutes)."...

dusky shale Jun 27, 2021, 5:36 PM

#

surreal socket https://github.com/top-gg/python-sdk/issues/53 <@456226577798135808> what do you...

It's not a big deal though, just a bit unnecessary, I think. I don't know what's the chance to get rate limited on the second try, but consider this case:

Makes a request
Gets ratelimited, sleep a bit.
Do the second try
Still gets ratelimited, sleep again (is this necessary?)
Raises error

surreal socket Jun 27, 2021, 5:39 PM

#

I don't think there are big chances to get ratelimited with the current local ratelimiter, but it's still possible if you restart your bot while the local ratelimiter is "capped" at max_calls

#

As for second-try ratelimit I'm not sure honestly

dusky shale Jun 27, 2021, 5:43 PM

#

Yeah, now that I think of that, it's trivial and unlikely gonna happen

surreal socket Jun 27, 2021, 5:49 PM

#

I'll keep it in mind but close the issue ig

#

People are free to report it when it becomes an actual issue

dusky shale Jun 27, 2021, 5:59 PM

#

Sure topggThumbsUp . It's not gonna be an issue as far as I'm aware, just gonna delay the lock release a bit

surreal socket Jun 27, 2021, 6:19 PM

#

Oh my God

#

Oh I didn't tick these two apparently

dusky shale Jun 27, 2021, 6:23 PM

#

Das pog you got those options. I need to add it manually mmLol

surreal socket Jun 27, 2021, 6:23 PM

#

🤣

dusky shale Jun 27, 2021, 6:23 PM

#

Btw, you don't install topgg or what?

surreal socket Jun 27, 2021, 6:24 PM

#

All of it is local and since all my tests do import topgg instead of from .. import topgg, it can't find the module in the tests folder

#

I used to but not anymore KEKW

#

Oh nice 403s when trying to push

dusky shale Jun 27, 2021, 6:24 PM

#

Yeah, but shouldn't you got it installed?

surreal socket Jun 27, 2021, 6:25 PM

#

In my Git repo or as a package via pip?

dusky shale Jun 27, 2021, 6:25 PM

#

Locally, with the editable flag

surreal socket Jun 27, 2021, 6:25 PM

#

Nop KEKW

dusky shale Jun 27, 2021, 6:28 PM

#

lmao, that's a pain

surreal socket Jun 27, 2021, 6:29 PM

#

idk I'm used to just working with the repo clone locally and then updating that

dusky shale Jun 27, 2021, 6:31 PM

#

What I usually do:

clone the repo
pip install -erepo
profit

#

Prob cuz I tend to test it in a real project that depends on it

surreal socket Jun 27, 2021, 6:37 PM

#

Probs

#

I just don't think I have any need for the PyPi package altogether since I don't even personally use it

#

KEKW

dusky shale Jun 27, 2021, 6:38 PM

#

KEKW LMAO

#

But yeah, the editable flag is useful since it creates sort of a symlink. So the changes reflect in real time (taking runtime caches into account, obv) which is useful for development

surreal socket Jun 27, 2021, 6:40 PM

#

Note to self: stop forgetting to add changelogs

#

I'll take a look at it, sounds helpful for... whenever I'll need it

surreal socket Jun 28, 2021, 10:30 AM

#

v1.2 is out and should be good to go

dusky shale Jun 28, 2021, 12:47 PM

#

pogey

brisk fossil Jun 28, 2021, 6:17 PM

#

surreal socket DataDict is subclass of dict, v1.1

so dictionaries with extra steps lul

surreal socket Jun 28, 2021, 6:17 PM

#

Pretty much 😂

brisk fossil Jun 28, 2021, 6:17 PM

#

surreal socket Note to self: stop forgetting to add changelogs

~~1.3.4: remembered to add changelogs~~

surreal socket Jun 28, 2021, 6:17 PM

#

v2 changelog be like: added appropriate changelog for v1.2

brisk fossil Jun 28, 2021, 6:18 PM

#

lmao

#

changelogs are hard, I just let the users figure it out tbh

surreal socket Jun 28, 2021, 6:18 PM

#

🤣 Can't have that in my case. they ain't the smartest

brisk fossil Jun 28, 2021, 6:18 PM

#

You'd be surprised how idiot proof you can make stuff

#

~~I say this while still trying to investigate why my bot can only make one request before it gets ratelimited~~

surreal socket Jun 28, 2021, 6:19 PM

#

KEKW

brisk fossil Jun 28, 2021, 6:19 PM

#

I'm praying to god it's a bug in the bot instead of the lib, because if it's the lib then I've been debugging the wrong thing for ages

surreal socket Jun 28, 2021, 6:21 PM

#

Good luck lmfao

brisk fossil Jun 28, 2021, 6:21 PM

#

I'm gonna need that

brisk fossil Jun 28, 2021, 6:23 PM

#

surreal socket 🤣 Can't have that in my case. they ain't the smartest

I mean I just found this comment in my code

        # Yes, this is the function that single-handedly carries this module
        # Yes, it's a bit jank
        # Yes, you're welcome to tidy it up
        # No, there's no need to change anything
        # It works perfectly fine
        # JUST DON'T *TRY* TO BREAK IT

If that gives you any idea how confident I am in it

surreal socket Jun 28, 2021, 6:27 PM

#

LMFAO

#

Poor you

tiny shard Jun 28, 2021, 6:28 PM

#

@dense barn @wintry marten progress on how to push to git? what's the plan

dense barn Jun 28, 2021, 6:35 PM

#

No need to ping Xetera

#

I haven't done this yet

tiny shard Jun 28, 2021, 6:37 PM

#

dense barn I haven't done this yet

well i dont even thing any of us know what has to be done, we havent decided on how, what user, what tokens etc

dense barn Jun 28, 2021, 6:37 PM

#

I just need to set up the secrets, correct?

tiny shard Jun 28, 2021, 7:07 PM

#

dense barn I just need to set up the secrets, correct?

if we're using top-gg-bot, but you said we shouldnt so idk

dense barn Jun 29, 2021, 5:17 PM

#

yo pog

#

@ornate kite wrote us a ruby lib

tiny shard Jun 29, 2021, 5:19 PM

#

noice

dense barn Jun 29, 2021, 5:19 PM

#

Can we quickly jump into a call btw

#

so we can get this thing done

tiny shard Jun 29, 2021, 6:00 PM

#

@dense barn what was the domain you set it up on?

dense barn Jun 29, 2021, 6:00 PM

#

none

#

it didn't build yet

tiny shard Jun 29, 2021, 6:00 PM

#

i mean netlify

#

oh

#

uh

#

ok

worthy cypress Jun 30, 2021, 2:37 PM

#

new build for PHP library deployed to fix JSON query-string construction on the HTTP URI path

worthy cypress Jun 30, 2021, 9:13 PM

#

@dense barn do we have any information about upcoming new endpoints for API/v1?
Refer: #topgg-api message

dense barn Jun 30, 2021, 9:46 PM

#

no

tiny shard Jul 1, 2021, 5:29 PM

#

@wintry marten in case you missed it https://github.com/top-gg/node-sdk/pull/63 is ready for review

GitHub

Redo documentation by jpbberry · Pull Request #63 · top-gg/node-sdk

This PR adds TypeDoc as the docs builder and publisher.
Steps needed before merge

Empty docs branch made
Add CNAME into the docs branch with the contents
In draft while workflow for deploying d...

worthy cypress Jul 1, 2021, 5:33 PM

#

not sure if you noticed, but Veld posted this:

tiny shard Jul 1, 2021, 5:46 PM

#

worthy cypress not sure if you noticed, but Veld posted this:

not sure why but that was ran on the old docs so its fine

tiny shard Jul 1, 2021, 6:28 PM

#

(@wintry marten just so you know the preview for what i just made is here https://deploy-preview-63--jolly-benz-150468.netlify.app/classes/api.html)

wintry marten Jul 1, 2021, 6:32 PM

#

i know i saw

#

btw stringified bigint does break code since it's not compatible with string in my experience

#

I think we should leave the bigint change for a major change

tiny shard Jul 1, 2021, 6:35 PM

#

wintry marten btw stringified bigint does break code since it's not compatible with string in ...

yeah i found that out half an hour ago, i pushed the revert

wintry marten Jul 1, 2021, 6:35 PM

#

oh wtf my github didn't update with the new comments, my bad

tiny shard Jul 1, 2021, 6:35 PM

#

oop

#

@dense barn just pushed the new docs, can you update the netlify and let me know what the slug is

#

well it is updated, but you said you were gonna add a custom slug, then i can apply for the js.org

dense barn Jul 1, 2021, 6:42 PM

#

ok

#

https://jolly-benz-150468.netlify.app

@top-gg/sdk | @top-gg/sdk

Documentation for @top-gg/sdk

#

this is the url btw

tiny shard Jul 1, 2021, 6:42 PM

#

ye ik, do u want a slug?

#

like topgg.netlify.app

dense barn Jul 1, 2021, 6:42 PM

#

it shouldn't matter

#

because it'll never be used

#

other than in the DNS

tiny shard Jul 1, 2021, 6:43 PM

#

right

#

ok

tiny shard Jul 1, 2021, 6:44 PM

#

dense barn it shouldn't matter

actually i think js.org has a requirement on that

#

just make it topgg-node-sdk.netlify.app or sumn

#

i lied they dont

#

ok nvrm

dense barn Jul 1, 2021, 6:45 PM

#

ok

worthy cypress Jul 1, 2021, 6:45 PM

#

Berry squint

#

Which one is it

dense barn Jul 1, 2021, 6:45 PM

#

wack

tiny shard Jul 1, 2021, 6:45 PM

#

idk

#

most of them in there have slugs

#

but i see like

#

2

#

that dont

worthy cypress Jul 1, 2021, 6:46 PM

#

I gotta know too for my stuff lmao

dense barn Jul 1, 2021, 6:46 PM

#

here u go

tiny shard Jul 1, 2021, 6:46 PM

#

~~i mean should make a slug regardless but i dont wanna annoy veld kek ~~

dense barn Jul 1, 2021, 6:46 PM

#

https://topgg-node-sdk-docs.netlify.app

@top-gg/sdk | @top-gg/sdk

Documentation for @top-gg/sdk

tiny shard Jul 1, 2021, 6:46 PM

#

ty

worthy cypress Jul 1, 2021, 9:30 PM

#

Giving webhook posting header support in PHP for easy compatibility

#

The error handling has been reworked now to work in compliance with custom exceptions now, so the response code will be tracked and forced rate limiting will occur within the script if it notices the limit is active on the API token regardless of calls being requested

#

Rate limits will currently be sent as PHP warnings instead, while anything error/fatal within the script receives a mutable BaseException with throwable defaults.

#

On another side note, I am still actively testing Issues written in the top-gg/issues repository (hopefully this gives some aid to Xignotic who's been doing a good majority of the labeling on them so far) to help have secondhand reports either confirming or denying something is an issue existent with the website(s).

tiny shard Jul 2, 2021, 1:31 PM

#

I've already added your requested subdomain to JS.ORGs zonefile. You may have to configure your host to accept the custom domain.
I'll merge after we have "contact". Please keep this PR open.
@dense barn

#

you have to add the custom domain to the netlify app

tiny shard Jul 2, 2021, 3:17 PM

#

@wintry marten uuuh how should i re-publish the release so that the action works?

#

i cant delete a previous release so i cant just redo it again

#

and re-running all jobs reruns the old script

#

nvrm i can delete old release github just poopoo

wintry marten Jul 2, 2021, 3:18 PM

#

netlify should already be getting updated by master

tiny shard Jul 2, 2021, 3:19 PM

#

the npm publish i mean

#

yeah pain

#

i cant delete the tag either

#

that i cant actually delete cuz i dont have write perms

wintry marten Jul 2, 2021, 3:20 PM

#

which tag

tiny shard Jul 2, 2021, 3:20 PM

#

3.1.2

wintry marten Jul 2, 2021, 3:20 PM

#

why do you need to delete it

tiny shard Jul 2, 2021, 3:20 PM

#

because the action failed so i cant publish to v3.1.2

wintry marten Jul 2, 2021, 3:21 PM

#

do we need to publish anything for docs changes?

tiny shard Jul 2, 2021, 3:21 PM

#

the docs url to the readme

#

and the homepage

wintry marten Jul 2, 2021, 3:21 PM

#

ah

#

ok try again

tiny shard Jul 2, 2021, 3:23 PM

#

there we go

#

thanks

#

@dense barn https://github.com/top-gg/docs/pull/31 btw you do know that extreme was basically just copy pasting existing documentation so that it can just be in docs, can't expect there to be code changes, atleast until its rewritten

GitHub

Add proper top-gg/go-sdk documentation by ExtremeDevelopments · Pul...

This Pull Request provides documentation updates to the Go section of the website to show proper methods and use of the library instead of linking to a external page just as the Java page did. This...

dense barn Jul 2, 2021, 3:29 PM

#

Sounds like a recipe for disaster

tiny shard Jul 2, 2021, 3:29 PM

#

eyes

worthy cypress Jul 4, 2021, 4:02 AM

#

PHP library now allows direct widget creation with HTML/markdown variation for webservers.

surreal socket Jul 4, 2021, 5:37 AM

#

Pog

tiny shard Jul 4, 2021, 7:26 AM

#

@wintry marten lul should i make a react element for widgets in the sdk? or do it out-of-lib

wintry marten Jul 4, 2021, 7:27 AM

#

separate lib

tiny shard Jul 4, 2021, 7:27 AM

#

gamer

worthy cypress Jul 4, 2021, 2:39 PM

#

should be separate tbh, only reason it's in PHP library is because PHP can be used for webserver or pure backend development

dense barn Jul 6, 2021, 6:07 AM

#

btw fun fact

#

top.gg public API v1 is live in internal networking and will be implemented on the site this week

high depot Jul 6, 2021, 6:09 AM

#

do be poggers

worthy cypress Jul 6, 2021, 8:38 AM

#

dense barn top.gg public API v1 is live in internal networking and will be implemented on t...

gimme a ring when it's out for us to use ✌️

surreal socket Jul 6, 2021, 9:47 AM

#

ring as in 💍 or as in 📞

worthy cypress Jul 6, 2021, 10:16 AM

#

if i sell both of them i'll get more money than the $11.38 in my bank account right now

#

so either is fine

high depot Jul 6, 2021, 10:28 AM

#

surreal socket ring as in 💍 or as in 📞

as 🔔

surreal socket Jul 6, 2021, 11:18 AM

#

Ya'll istg

dense barn Jul 6, 2021, 6:06 PM

#

topggSunglasses

#

wary stratus Jul 6, 2021, 6:11 PM

#

very pogs

worthy cypress Jul 6, 2021, 7:45 PM

#

Poggies

worthy cypress Jul 15, 2021, 4:01 AM

#

PSR-2 support has been extended to PHP library via. separation of all interfaces and classes to customized "stubs" layout, this allows easy toggling and the ability to load specific namespaces faster.

dusky shale Jul 15, 2021, 9:38 AM

#

BabyYodaSip

worthy cypress Jul 25, 2021, 5:38 AM

#

@karmic valley I'll be sharing the PHPDocs with you later this week

kindred maple Jul 30, 2021, 4:41 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

tiny shard Aug 5, 2021, 2:38 PM

#

@wintry marten im removing the double / in the _request method, but im curious if i should care about it being a breaking change, since it's private, marked with an underscore, and is not documented? or should i care and just do something like

    let url = `https://top.gg/api${path.startsWith("/") ? path : `/${path}`}`;```

wintry marten Aug 5, 2021, 3:25 PM

#

should be fine to break that as long as it doesn't break the user-facing api

#

if you're using underscored functions in js that's your fault

tiny shard Aug 5, 2021, 4:21 PM

#

ok_spin

kindred maple Aug 5, 2021, 5:35 PM

#

One message removed from a suspended account.

high depot Aug 7, 2021, 1:07 PM

#

@tiny shard https://github.com/top-gg/node-sdk/pull/69

GitHub

Remove unnecessary double slashes by Pacmard · Pull Request #69 · t...

The request method already has a / in front of the PATH which is passed by other methods. Passing an additional slash at the beginning of the PATH for a request from a function is not required

tiny shard Aug 7, 2021, 3:52 PM

#

high depot <@!142408079177285632> https://github.com/top-gg/node-sdk/pull/69

why. i already said i was going to fix it myself

#

smh

high depot Aug 7, 2021, 4:00 PM

#

tiny shard why. i already said i was going to fix it myself

ah didnt notice

#

pr closed

tiny shard Aug 7, 2021, 4:00 PM

#

and then

#

pain

#

alright don’t do stuff like that, reopen the pr. it’s just git etiquette not to do things like that, but once you’ve already done it there’s no point in wasting it @high depot

#

sadge

high depot Aug 7, 2021, 4:01 PM

#

i just cant do normal fix rn

#

im palying warzone

tiny shard Aug 7, 2021, 4:01 PM

#

just reopen it it’s fine

dusky shale Aug 11, 2021, 11:36 AM

#

Interesting to know that you get muted for showing how disrespectful someone is pithink

#

@spare sedge so I guess he will just get along with nothing, right?

spare sedge Aug 11, 2021, 11:47 AM

#

@dusky shale feel free to dm me if you would like to report what had happened, or talk about the reason for your mute

dusky shale Aug 12, 2021, 8:28 AM

#

@fathom vapor #general (got banned)

surreal socket Aug 12, 2021, 9:01 AM

#

P.S. this isn't #reports

spare sedge Aug 12, 2021, 4:35 PM

#

@dusky shale i know you are unmuted now but in the future please keep this chat on topic and do not use it to bypass a mute either :( Otherwise it could lead to further punishment, which i dont want to happen

#

can dm a mod for reports

worthy cypress Aug 24, 2021, 3:42 PM

#

@surreal socket hey

#

wanna make the Rust API wrapper together with me?

#

unless

surreal socket Aug 24, 2021, 5:24 PM

#

I don't know Rust well enough soz

#

I've been thinking about transferring topggpy over to norizon as I cba to maintain any public projects at this time

worthy cypress Aug 24, 2021, 5:26 PM

#

boohoo

high depot Aug 25, 2021, 8:23 PM

#

what the fuck was that

worthy cypress Aug 25, 2021, 8:29 PM

#

#

only at top.gg

high depot Aug 25, 2021, 8:33 PM

#

@wary stratus join dev vc

worthy cypress Aug 25, 2021, 8:33 PM

#

flushed

#

imagine not being able to type in any of the channels

#

lib devs get the free pass 😎

true portal Aug 28, 2021, 7:53 PM

#

KEKW

surreal socket Sep 9, 2021, 2:57 PM

#

@dusky shale Why is VT set as the kwargs type for some DataDict subclasses?

#

KEKW

dusky shale Sep 9, 2021, 2:59 PM

#

surreal socket <@456226577798135808> Why is VT set as the kwargs type for some DataDict subclas...

For the base class?

surreal socket Sep 9, 2021, 2:59 PM

#

I think

#

Oh yeah

dusky shale Sep 9, 2021, 3:00 PM

#

**kwargs' keys are always str

#

We type hint the values of it

surreal socket Sep 9, 2021, 3:00 PM

#

Why not just Any it like the rest?

dusky shale Sep 9, 2021, 3:00 PM

#

The rest was Any to fill that VT

#

It's a type variable, isn't it?

surreal socket Sep 9, 2021, 3:01 PM

#

VT = TypeVar("VT")

dusky shale Sep 9, 2021, 3:03 PM

#

Yeah, it needs to be a TypeVar for this to work

#

We can actually make use of TypedDict, so that we have no Anys

surreal socket Sep 9, 2021, 3:07 PM

#

Eh

#

It's probably fine as-is tbh

#

Doesn't really matter anyway

dusky shale Sep 9, 2021, 3:15 PM

#

Okie, I don't mind implementing it any time

tiny shard Sep 10, 2021, 5:50 PM

#

@dusky shale i guess you're the uh, new dev for the py lib just so you know

dusky shale Sep 10, 2021, 5:53 PM

#

tiny shard <@456226577798135808> i guess you're the uh, new dev for the py lib just so you ...

Yeah, shiv has told me. Thanks anyway

tiny shard Sep 10, 2021, 5:53 PM

#

dusky shale Yeah, shiv has told me. Thanks anyway

yup. alright so i would make a pr into https://github.com/top-gg/docs/blob/master/CODEOWNERS to get codeowner for the python docs on the main docs site

dusky shale Sep 10, 2021, 5:56 PM

#

tiny shard yup. alright so i would make a pr into <https://github.com/top-gg/docs/blob/mast...

Will do later, thanks!

tiny shard Sep 10, 2021, 5:56 PM

#

also feel free to bounce any ideas off of me, i do have some python experience and if you need that top.gg library feedback i'll be here for ya

dusky shale Sep 10, 2021, 5:57 PM

#

Sure, I have something in mind

tiny shard Sep 10, 2021, 5:57 PM

#

👀

kindred maple Sep 10, 2021, 11:09 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

kindred maple Sep 10, 2021, 11:09 PM

#

tiny shard yup. alright so i would make a pr into <https://github.com/top-gg/docs/blob/mast...

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

kindred maple Sep 11, 2021, 4:38 AM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

kindred maple Sep 20, 2021, 5:01 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

high depot Sep 24, 2021, 2:59 PM

#

@noble shadow maybe yeet vanity url for a bit to prevent bots joining

vast cliff Sep 24, 2021, 3:12 PM

#

No

fair goblet Sep 24, 2021, 3:12 PM

#

high depot <@!395526710101278721> maybe yeet vanity url for a bit to prevent bots joining

vanity isnt the only invite we have

high depot Sep 24, 2021, 3:12 PM

#

fair goblet vanity isnt the only invite we have

well bruh

#

lock #site-translators pls

#

since they'll spam here once general is locked

#

kek

#

lmao

wintry marten Oct 1, 2021, 9:50 PM

#

I added a few hacktoberfest issues if anyone's interested in taking them up before some rando who doesn't even have an anime avatar does
https://github.com/top-gg/docs/issues/45
https://github.com/top-gg/node-sdk/issues/61
https://github.com/top-gg/node-sdk/issues/70

true portal Oct 2, 2021, 3:40 AM

#

Time to get to looking

amber drum Oct 8, 2021, 5:21 PM

#

lmfao

high depot Nov 18, 2021, 8:37 PM

#

dis channel ze ded

wary stratus Nov 18, 2021, 8:49 PM

#

guraVibe

true portal Nov 20, 2021, 12:42 AM

#

Not much to talk about rn :>

dusky shale Nov 21, 2021, 12:33 PM

#

dancingduck

tiny shard Nov 21, 2021, 1:39 PM

#

boi wat da hell boi

high depot Nov 21, 2021, 1:46 PM

#

boi your pic crashed my discord boi

pastel girder Nov 21, 2021, 8:40 PM

#

tiny shard boi wat da hell boi

when pull requests get long boi

dusky shale Jan 31, 2022, 7:13 PM

#

That's where rebasing becomes handy when merging.

PS: First message of 2022 on the most active channel

amber drum Jan 31, 2022, 10:04 PM

#

lets gooooooooooo

cunning locust Feb 15, 2022, 2:17 PM

#

how i got access to this channel

true portal Feb 22, 2022, 4:15 AM

#

extremepog4

wary stratus Feb 22, 2022, 7:03 AM

#

the pog emojis still exist? FLOSHAD

true portal Feb 27, 2022, 3:29 AM

#

Yews

#

Oh wait

#

I forgot about that

#

oops

tiny shard Mar 15, 2022, 7:16 PM

#

@wintry marten not sure if you're the person to go to, but i think it would be valuable for the api to treat @me on bot_id endpoints (similar to how discord does it) would be valuable and more readable to replace the current way of doing it which is just completely omitting the bot_id entirely. so for posting stats it would be POST /bots/@me/stats instead of POST /bots/stats, obviously you need it for non-breaking purposes. but i think @me would be a good alternative that can eventually phase out the old way

wintry marten Mar 16, 2022, 1:01 AM

#

I don't think we'll be making any changes to the old api at this point

tiny shard Mar 16, 2022, 9:01 PM

#

wintry marten I don't think we'll be making any changes to the old api at this point

will the new api have this distinction?

wintry marten Mar 16, 2022, 9:20 PM

#

not sure, we're not really there yet

high depot Mar 17, 2022, 7:38 AM

#

ayo just making you aware that this shit right here added a malware that purges users disks
make sure u dont update so topgg stays cool and working
https://github.com/RIAEvangelist/node-ipc

wary stratus Mar 17, 2022, 8:06 AM

#

Like I again get the message

#

But

#

Why would you want to put it in code that is possibly used in production environments

#

Another user on another discord server I provide support on reported that 000webhost injects a goddamn banner with such message, even on data response stuff like php scripts

#

depresion

#

Took us ages to debug why the fuck it didn't work

#

Just imagine the issues it might cause when something like that is used within banking or a more important environment like hospitals CalliSus

#

Aaaaand enough GitHub, reading the issues on the peacenotwar repo made my braincells die

cunning locust Mar 17, 2022, 8:21 AM

#

Christ why would anyone even try do that, regardless of if there is a war or not, on a widely used package and then tell people to “just use another version” when complaining?

wary stratus Mar 17, 2022, 8:22 AM

#

They reverted the commit or GitHub did

#

KEKW good

cunning locust Mar 17, 2022, 8:22 AM

#

Good angery

wary stratus Mar 17, 2022, 8:23 AM

#

Trust killed off on that repo nonetheless

cunning locust Mar 17, 2022, 8:24 AM

#

Hehe

wary stratus Mar 17, 2022, 9:52 AM

#

~~also unity updated to that version and had people appear that file~~

#

Great view on a supply chain attack though

#

Also the snyk cve for anyone interested https://snyk.io/blog/peacenotwar-malicious-npm-node-ipc-package-vulnerability/
https://security.snyk.io/vuln/SNYK-JS-NODEIPC-2426370

Snyk

Alert: peacenotwar module sabotages npm developers in the node-ipc ...

Vue.js users using the dependency “node-ipc” are experiencing a supply chain attack protesting the invasion of Ukraine, from a package named “peacenotwar”.

Snyk Vulnerability Database

Malicious Package in node-ipc | CVE-2022-23812 | Snyk

Snyk Vulnerability Database

high depot Mar 17, 2022, 4:18 PM

#

wary stratus They reverted the commit or GitHub did

they did only on master Sadge

tiny shard Mar 20, 2022, 12:05 AM

#

@wintry marten could we change the link on node-sdk to https://topgg.js.org ?

@top-gg/sdk | @top-gg/sdk

Documentation for @top-gg/sdk

cunning locust Mar 20, 2022, 12:07 AM

#

Also we should probably reference 418 codes on the rate limit page, a few people have had those this week

wintry marten Mar 20, 2022, 12:11 AM

#

418 only ever appears if you do a get request to /api which you have no reason to do and does not happen on rate limits

#

a bug with a library update maybe

#

kindred maple Mar 20, 2022, 12:17 AM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

cunning locust Mar 20, 2022, 12:18 AM

#

wintry marten 418 only ever appears if you do a get request to `/api` which you have no reason...

Oh, I looked online and it said its when you ignore a cloudflare's 429 code. I'll check with the person who said, but I'm pretty sure they got it from posting stats

wintry marten Mar 20, 2022, 12:18 AM

#

where did you see that

kindred maple Mar 20, 2022, 12:19 AM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wintry marten Mar 20, 2022, 12:19 AM

#

man can't you just set up a reminder for yourself

kindred maple Mar 20, 2022, 12:19 AM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wintry marten Mar 20, 2022, 12:20 AM

#

not at all what I meant by that

cunning locust Mar 20, 2022, 12:20 AM

#

wintry marten where did you see that

#support message is them talking about the 418

#topgg-api message is me referencing the 418 definition i found

#

not sure which you meant kek

wintry marten Mar 20, 2022, 12:21 AM

#

I can't find any docs at all to back up that 418 claim

cunning locust Mar 20, 2022, 12:21 AM

#

oh sus it was the first result i found and several other pages said the same

kindred maple Mar 20, 2022, 12:21 AM

#

One message removed from a suspended account.

wintry marten Mar 20, 2022, 12:22 AM

#

cloudflare will hit you up with a 429, 418 is the 4 year old meme endpoint response we never changed

kindred maple Mar 20, 2022, 12:22 AM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wintry marten Mar 20, 2022, 12:23 AM

#

every single one of these requests have been made to /api not stats

#

it's just a library error

cunning locust Mar 20, 2022, 12:23 AM

#

oh ok

kindred maple Mar 20, 2022, 12:23 AM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wintry marten Mar 20, 2022, 12:24 AM

#

one of the old devs put it in as a joke but nothing has changed about it for many years, this isn't a recent bug or anything

cunning locust Mar 20, 2022, 12:25 AM

#

makes sense Hehe

kindred maple Mar 24, 2022, 4:20 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wintry marten Mar 24, 2022, 7:32 PM

#

kindred maple One message removed from a suspended account.

submit PRs for now and we'll see

kindred maple Mar 24, 2022, 7:32 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wary stratus Mar 24, 2022, 7:44 PM

#

I can assure you nik won't respond on the repo stuff

#

There's 2-3 prs from 2018-19

kindred maple Mar 24, 2022, 7:48 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wary stratus Mar 24, 2022, 7:51 PM

#

Alrighty

#

Only stuff that's honestly needed there is some cleanup and compatibility stuff

#

As it's technically still up-to-date except perhaps the domain and old readme

kindred maple Mar 25, 2022, 3:38 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wary stratus Mar 25, 2022, 3:40 PM

#

Hi

#

Sure

#

Send a message and I'll pin it

kindred maple Mar 25, 2022, 3:59 PM

#

One message removed from a suspended account.

tiny shard Mar 29, 2022, 6:13 AM

#

@wintry marten why was 72 merged?

#

That completely removes the ability to leave the instantiating generic

wintry marten Mar 29, 2022, 6:15 AM

#

uh maybe we can just add a comment for eris or something idk

tiny shard Mar 29, 2022, 6:15 AM

#

wintry marten uh maybe we can just add a comment for eris or something idk

idk why it’s need at all

#

probably would’ve been better to just

#

({ … })

wintry marten Mar 29, 2022, 6:16 AM

#

idk I mean to me these docs are just examples shrug

tiny shard Mar 29, 2022, 6:17 AM

#

wintry marten idk I mean to me these docs are just examples <:shrug:332268181517238272>

exactly and now the example implies that you need these intents or you need these options on things like a sharding manager which isn’t the case

wintry marten Mar 29, 2022, 6:18 AM

#

sure

tiny shard Mar 29, 2022, 6:18 AM

#

that’s not good

wintry marten Mar 29, 2022, 6:18 AM

#

I just rolled it back

tiny shard Mar 29, 2022, 6:19 AM

#

if you feel the need to differentiate between instantiations i can make it, but i don’t think it’s strictly necessary

wintry marten Mar 29, 2022, 6:19 AM

#

I don't think it's necessary

kindred maple Mar 30, 2022, 6:25 PM

#

One message removed from a suspended account.

kindred maple Mar 31, 2022, 5:31 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wary stratus Mar 31, 2022, 5:39 PM

#

Hi am online

#

What's up

kindred maple Mar 31, 2022, 5:40 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wary stratus Mar 31, 2022, 5:41 PM

#

Are you referring to the java sdk?

kindred maple Mar 31, 2022, 6:18 PM

#

One message removed from a suspended account.

wary stratus Mar 31, 2022, 6:22 PM

#

You'd need xetera to add you as a maintainer then

kindred maple Mar 31, 2022, 6:26 PM

#

One message removed from a suspended account.

wintry marten Mar 31, 2022, 7:04 PM

#

i have no idea who has access to maven or wherever its hosted

#

the last push for that was before anyone on the team joined

wary stratus Mar 31, 2022, 7:16 PM

#

Would otherwise say just yeet the maven and refer Devs to jitpack

#

Oh wait

#

Nah the docs mentions jitpack, jitpack isn't owned by anyone, it just translates the GitHub repo to a maven dependency

#

So any changes you make on master will be reflected by jitpack automatically once someone tries to update

#

Same on the gradle one

#

https://jitpack.io

jitpack

JitPack | Publish JVM and Android libraries

JitPack makes it easy to release your Java or Android library. Publish straight from GitHub or Bitbucket.

kindred maple Mar 31, 2022, 7:25 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wary stratus Mar 31, 2022, 7:35 PM

#

You never made a release

kindred maple Mar 31, 2022, 7:35 PM

#

One message removed from a suspended account.

wary stratus Mar 31, 2022, 7:35 PM

#

The last one is still from 2018

kindred maple Mar 31, 2022, 7:35 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wary stratus Mar 31, 2022, 7:36 PM

#

Yup a maintainer has to create a release

kindred maple Mar 31, 2022, 7:36 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

kindred maple Apr 4, 2022, 7:34 PM

#

One message removed from a suspended account.

amber drum Apr 5, 2022, 5:19 PM

#

confusion

#

im reading your pr it sounds like youre taking over the java sdk in general? @kindred maple wouldnt you be the one to merge your pr and create a release

#

i dont actually have perms on that repo atm

kindred maple Apr 5, 2022, 5:21 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

amber drum Apr 5, 2022, 5:21 PM

#

oh lmao

#

okok ill bug someone

kindred maple Apr 5, 2022, 5:25 PM

#

One message removed from a suspended account.

kindred maple Apr 9, 2022, 1:27 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

amber drum Apr 9, 2022, 6:34 PM

#

kindred maple One message removed from a suspended account.

iara_nervous_sweat

#

it was busy im sorry i forgot 🥺

kindred maple Apr 14, 2022, 8:27 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

amber drum Apr 14, 2022, 8:30 PM

#

sorry im out of office at the moment. fwiw weve been super busy and this wasnt part of our planned work so i hadnt brought it up yet, no one is ignoring you or anything

#

i dont have perms in the org or the repo at all

kindred maple Apr 14, 2022, 8:31 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

amber drum Apr 14, 2022, 8:31 PM

#

its rly a xettypoo question thats who i would/will be bugging

kindred maple Apr 14, 2022, 8:48 PM

#

amber drum its rly a xettypoo question thats who i would/will be bugging

One message removed from a suspended account.

kindred maple Apr 25, 2022, 4:24 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wary stratus Apr 25, 2022, 4:39 PM

#

I wish we mods had access to repo stuff istg

#

one thing I dont get though, why is org.json as a dependency when you have gson

#

or whats the difference between both

#

oh nvm one can be used to serialize

#

honestly the repo needs a breaking restructure regarding the classes, bunch of cleanup etc

kindred maple Apr 25, 2022, 4:51 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wary stratus Apr 25, 2022, 4:55 PM

#

nah KEKW dont have the time to

kindred maple Apr 25, 2022, 5:35 PM

#

One message removed from a suspended account.

#topgg-open-source

We're basing behavior on the exception as it can be caused by

user code unrelated to the status of the connection. If you

would like to close a connection you must do that

explicitly. Otherwise connection error handling should kick in

and close/recycle the connection as required.