#topgg-open-source | Top.gg | Page 5

worthy cypress May 18, 2021, 8:09 PM

#

are we actually losing anything in terms of processing, or memory, etc.?

dense barn May 18, 2021, 8:09 PM

#

yea

high depot May 18, 2021, 8:09 PM

#

Xetera will fix that ig

worthy cypress May 18, 2021, 8:09 PM

#

how so Veld

tiny shard May 18, 2021, 8:09 PM

#

eyes

dense barn May 18, 2021, 8:10 PM

#

Performance doesn't really matter

plain storm May 18, 2021, 8:10 PM

#

always optimize for the developer before optimizing for the program

dusky shale May 18, 2021, 8:10 PM

#

hmmrun

dense barn May 18, 2021, 8:10 PM

#

It's not like a webhook needs to be ran 100/s

jade cobalt May 18, 2021, 8:10 PM

#

dense barn It's not like a webhook needs to be ran 100/s

@tiny shard

dense barn May 18, 2021, 8:10 PM

#

imagine overengineering a webhook

worthy cypress May 18, 2021, 8:10 PM

#

yeah, so i don't see the prevalent need of ternary operations

high depot May 18, 2021, 8:10 PM

#

tiny shard eyes

oh yeah I forgot to use alt shift f

#

KEK

dense barn May 18, 2021, 8:10 PM

#

btw

jade cobalt May 18, 2021, 8:10 PM

#

worthy cypress yeah, so i don't see the prevalent need of ternary operations

I would say just for readability and shortening lines lengths

worthy cypress May 18, 2021, 8:11 PM

#

the character thing was a joke, scrolling left to right isn't too difficult imo

tiny shard May 18, 2021, 8:11 PM

#

i mean it cant hurt to add some simple ratelimit handling to make sure you dont miss something entirely

high depot May 18, 2021, 8:11 PM

#

tiny shard i mean it cant hurt to add some simple ratelimit handling to make sure you dont ...

well there's no need in them since that thing is made for crowdin webhooks

#

I don't think crowdin will spam it out

tiny shard May 18, 2021, 8:12 PM

#

if 6 people submit a string at the same time you'll lose one

high depot May 18, 2021, 8:12 PM

#

no?

tiny shard May 18, 2021, 8:12 PM

#

yes

dense barn May 18, 2021, 8:12 PM

#

const StringsAdded = "string.added";

...

let stringsAdded = 0;
if(eventsStructured[StringsAdded]) {
  stringsAdded = eventsStructured[StringsAdded].length;
}

tiny shard May 18, 2021, 8:12 PM

#

discord ratelimits

dense barn May 18, 2021, 8:12 PM

#

This is what I would do

#

PogChamp

#

or probably use Number

#

because JS handles str <> num

#

then again

high depot May 18, 2021, 8:13 PM

#

fiiine I'll add them tmrw if Xetera will not do it before I do

dense barn May 18, 2021, 8:13 PM

#

I have too little context on the actual reason why we JSON.stringify it

tiny shard May 18, 2021, 8:13 PM

#

yeah you can just put numbers in string templates lol

dusky shale May 18, 2021, 8:13 PM

#

Doesn't that property already return a number

dense barn May 18, 2021, 8:14 PM

#

oh wait

#

.length

high depot May 18, 2021, 8:14 PM

#

dusky shale Doesn't that property already return a number

nope

worthy cypress May 18, 2021, 8:14 PM

#

it's not like we can re-use it if need be

dusky shale May 18, 2021, 8:14 PM

#

.length

#

is a number

high depot May 18, 2021, 8:14 PM

#

o wait yeah .length returns a number

#

I need a coffee KEK

jade cobalt May 18, 2021, 8:15 PM

#

wait a minute did you just stringify a number?

high depot May 18, 2021, 8:15 PM

#

jade cobalt wait a minute did you just stringify a number?

lol no

tiny shard May 18, 2021, 8:15 PM

#

brup

high depot May 18, 2021, 8:16 PM

#

O wait

#

I did

#

KEK KEK KEK KEK

dusky shale May 18, 2021, 8:16 PM

#

You literally JSON.stringify(<number>)

#

Man you need some sleep

high depot May 18, 2021, 8:16 PM

#

dusky shale Man you need some sleep

Yeah I slept like 3 hours today

ashen dragon May 18, 2021, 8:16 PM

#

dusky shale You literally `JSON.stringify(<number>)`

thats deep

high depot May 18, 2021, 8:17 PM

#

dusky shale You literally `JSON.stringify(<number>)`

@wintry marten

#

mind me fixing it?

#

or you already on it?

jade cobalt May 18, 2021, 8:17 PM

#

berry is doing a pr so....

dusky shale May 18, 2021, 8:17 PM

#

Berry speedrunning

wintry marten May 18, 2021, 8:17 PM

#

I'm doing it dw

#

I'll push change in a sec

jade cobalt May 18, 2021, 8:18 PM

#

@tiny shard

wintry marten May 18, 2021, 8:18 PM

#

also trying to fix top.gg code on the side ahh

tiny shard May 18, 2021, 8:18 PM

#

dw

#

ill do it and pr

high depot May 18, 2021, 8:18 PM

#

tiny shard ill do it and pr

you're late

tiny shard May 18, 2021, 8:18 PM

#

pain

#

?

dusky shale May 18, 2021, 8:20 PM

#

monkaHmm

tiny shard May 18, 2021, 8:22 PM

#

sob

high depot May 18, 2021, 8:22 PM

#

KEK

wintry marten May 18, 2021, 8:24 PM

#

oh I didn't know you were already working on it lol

tiny shard May 18, 2021, 8:24 PM

#

eez what it eez

jade cobalt May 18, 2021, 8:24 PM

#

lmao they both closed their own prs

high depot May 18, 2021, 8:25 PM

#

jade cobalt lmao they both closed their own prs

since xetera pushed refactor

jade cobalt May 18, 2021, 8:25 PM

#

yea ik

#

who is going to be the "manager" of this channel? Xet or Veld? (who is going to review most of the prs)

ashen dragon May 18, 2021, 8:25 PM

#

3 diffrent fixes pogey

dense barn May 18, 2021, 8:26 PM

#

I'll take it

wintry marten May 18, 2021, 8:27 PM

#

some typescript issues also needs fixing, would be a good idea to set up github workflows for building the project

high depot May 18, 2021, 8:27 PM

#

Xet it seems liek something is broken

wintry marten May 18, 2021, 8:27 PM

#

yeah

high depot May 18, 2021, 8:27 PM

#

#

I used test update event

jade cobalt May 18, 2021, 8:27 PM

#

might want to just append lines to a base content string so you don't deal with 0 lines added.

wary stratus May 18, 2021, 8:27 PM

#

Can't remember, but do webhooks support context being added too? Or possibly issues being created?

#

oh fuck wrong channel

#

or wait

#

is this for the crowdin webhook too hmmm

wintry marten May 18, 2021, 8:28 PM

#

ye we did it with cloudflare workers PeepoHmm did we not tell you im sorry

worthy cypress May 18, 2021, 8:28 PM

#

high depot

@tiny shard moment

wary stratus May 18, 2021, 8:28 PM

#

Gave up after 5 minutes anyways, don't like js sadcry

wintry marten May 18, 2021, 8:28 PM

#

same

high depot May 18, 2021, 8:28 PM

#

wary stratus Gave up after 5 minutes anyways, don't like js <a:sadcry:768499472685858816>

spent 3 hours on it

#

KEK

jade cobalt May 18, 2021, 8:29 PM

#

on that pr?

worthy cypress May 18, 2021, 8:29 PM

#

~~join me with the php lib hope~~

dusky shale May 18, 2021, 8:29 PM

#

You spent 3 hours on that?

#

whatNOyoucantdothis

high depot May 18, 2021, 8:29 PM

#

dusky shale You spent 3 hours on that?

well actually 30 mins

tiny shard May 18, 2021, 8:29 PM

#

WEFDLKJK

wintry marten May 18, 2021, 8:29 PM

#

probably 90% spent reading docs

high depot May 18, 2021, 8:29 PM

#

wintry marten probably 90% spent reading docs

yep

jade cobalt May 18, 2021, 8:29 PM

#

docs for what?

wintry marten May 18, 2021, 8:29 PM

#

learning new technologies gang

wary stratus May 18, 2021, 8:29 PM

#

high depot spent 3 hours on it

good job headpats

high depot May 18, 2021, 8:29 PM

#

jade cobalt docs for what?

workers

high depot May 18, 2021, 8:30 PM

#

high depot

@wintry marten string.updated isnt being counted properly idk why

wary stratus May 18, 2021, 8:30 PM

#

Though referring to these webhooks, probably useful to include when context is being added and/or when a new issue gets created/resolved

tiny shard May 18, 2021, 8:30 PM

#

high depot <@!140862798832861184> string.updated isnt being counted properly idk why

~~try my pr~~

wary stratus May 18, 2021, 8:30 PM

#

if crowdin supports that, can't remember

high depot May 18, 2021, 8:30 PM

#

Its ok with delete and add

wintry marten May 18, 2021, 8:30 PM

#

I'm busy with top.gg stuff I'll take a look later

high depot May 18, 2021, 8:32 PM

#

tiny shard ~~try my pr~~

nah its not bcuz of it

#

o wait

warm marsh May 18, 2021, 8:40 PM

#

time to make a pr to add an extra space between a = in a function call kwarg

icy kayak May 18, 2021, 8:41 PM

#

urgent PR

#

missing semicolon on line 34

jade cobalt May 18, 2021, 8:42 PM

#

public JS and TS top.gg repos should all have eslint and prettier for standardization and readability tbh

high depot May 18, 2021, 8:42 PM

#

jade cobalt public JS and TS top.gg repos should all have eslint and prettier for standardiz...

InaOI

jade cobalt May 18, 2021, 8:42 PM

#

smol

icy kayak May 18, 2021, 8:42 PM

#

high depot <:InaOI:813179745482440774>

disgustang

high depot May 18, 2021, 8:43 PM

#

icy kayak disgustang

yeah its automatically generated

#

KekDoggo

icy kayak May 18, 2021, 8:43 PM

#

aaah

#

ig that's fine if it's a standard

#

i don't follow the rules 😎

wintry marten May 18, 2021, 8:43 PM

#

alright I fixed the build errors

icy kayak May 18, 2021, 8:43 PM

#

double quotes, tabs, and semis

wintry marten May 18, 2021, 8:43 PM

#

funny meme caused by esnext

#

yeah we have topgg-eslint but I haven't pushed it to npm yet ugh

high depot May 18, 2021, 8:43 PM

#

funni

warm marsh May 18, 2021, 8:43 PM

#

urgent pr change all " to '

icy kayak May 18, 2021, 8:43 PM

#

yes

worthy cypress May 18, 2021, 8:44 PM

#

dang that was funny lemme schedule in a laugh for you

warm marsh May 18, 2021, 8:44 PM

#

thank you

jade cobalt May 18, 2021, 8:44 PM

#

icy kayak double quotes, tabs, and semis

warm marsh May 18, 2021, 8:44 PM

#

i feel happy that you got joy

worthy cypress May 18, 2021, 8:44 PM

#

i don't

warm marsh May 18, 2021, 8:44 PM

#

KaguyaPensive i hope you get the happy one day then

high depot May 18, 2021, 8:46 PM

#

wintry marten funny meme caused by esnext

works fine now

#

love ya

wintry marten May 18, 2021, 8:47 PM

#

maybe the pluralization needs to be fixerino'd 👼

high depot May 18, 2021, 8:47 PM

#

wintry marten maybe the pluralization needs to be fixerino'd 👼

just add ()

jade cobalt May 18, 2021, 8:47 PM

#

(s)

high depot May 18, 2021, 8:47 PM

#

FubukiYes

jade cobalt May 18, 2021, 8:47 PM

#

unless you really care that much

wintry marten May 18, 2021, 8:49 PM

#

we still need the project name to be fetched from query params btw

#

but other than that I think this one's ready to go pogger

icy kayak May 18, 2021, 8:49 PM

#

jade cobalt <:No:619659711649808384>

yes

#

cryaboutit

dusky shale May 18, 2021, 8:51 PM

#

"tabWidth": 2
"singleQuote": true
Cry about it

high depot May 18, 2021, 8:53 PM

#

wintry marten we still need the project name to be fetched from query params btw

i can do that rq

wintry marten May 18, 2021, 8:53 PM

#

donggiefeelsgood

high depot May 18, 2021, 8:54 PM

#

wintry marten <:donggiefeelsgood:446231982267957259>

done

#

lemme push

wintry marten May 18, 2021, 8:54 PM

#

now that we fixed the basic issues let's pr any new changes

high depot May 18, 2021, 8:54 PM

#

okie

#

ill pr it then

#

https://github.com/top-gg/crowdin-discord/pull/3 done

high depot May 18, 2021, 9:01 PM

#

wintry marten now that we fixed the basic issues let's pr any new changes

merged

#

and now we're done

true portal May 18, 2021, 9:09 PM

#

icy kayak cryaboutit

can you link to that repo

jade cobalt May 18, 2021, 9:10 PM

#

true portal can you link to that repo

thats his prettier for his code kekw

true portal May 18, 2021, 9:10 PM

#

oh I thought that was for top.gg lul

#

I am dumb

wintry marten May 18, 2021, 9:17 PM

#

When you're reviewing code or discussing contributions please be kind. Piling up on someone because of their code or belittling them is not acceptable. We want to create an environment where everyone feels comfortable contributing without the fear of feeling of being made fun of. If you have constructive comments to make it's up to you to make sure that does not come off as hostile, we're all learning here.

wintry marten May 18, 2021, 9:17 PM

#

wintry marten When you're reviewing code or discussing contributions please be kind. Piling up...

high depot May 18, 2021, 9:20 PM

#

Will be happy to something like that again, cool experience

#

FubukiYes

true portal May 18, 2021, 9:20 PM

#

Why not move the github updates to this channel for the sdks?

unreal lagoon May 18, 2021, 9:20 PM

#

wintry marten When you're reviewing code or discussing contributions please be kind. Piling up...

my english is not very good im sorry if we had a misunderstanding situation i apologize.

wintry marten May 18, 2021, 9:20 PM

#

blinkwhat

jade cobalt May 18, 2021, 9:21 PM

#

wut?

high depot May 18, 2021, 9:22 PM

#

https://tenor.com/view/star-wars-visible-confusion-confused-gif-14771834

Tenor

unreal lagoon May 18, 2021, 9:22 PM

#

😆

true portal May 18, 2021, 9:29 PM

#

facepalm

neat cobalt May 18, 2021, 9:29 PM

#

confundida_e

jade cobalt May 18, 2021, 11:28 PM

#

OSS Contributor

#

is that really a good idea?

kindred maple May 18, 2021, 11:29 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

burnt sinew May 18, 2021, 11:49 PM

#

why is this channel made?

odd heron May 19, 2021, 12:12 AM

#

oh new channel

#

458th msg

plain storm May 19, 2021, 12:17 AM

#

It feels like a subset of library developer.

dusky shale May 19, 2021, 12:47 AM

#

luca

sly jay May 19, 2021, 1:10 AM

#

New Channel Cool

true portal May 19, 2021, 1:25 AM

#

kindred maple One message removed from a suspended account.

and lib hunter

kindred maple May 19, 2021, 1:25 AM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

true portal May 19, 2021, 1:26 AM

#

lib dev*

kindred maple May 19, 2021, 1:26 AM

#

One message removed from a suspended account.

true portal May 19, 2021, 1:26 AM

#

NO

#

but some tried

kindred maple May 19, 2021, 1:30 AM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

plain storm May 19, 2021, 1:43 AM

#

is the translator role just a thank you card

high depot May 19, 2021, 2:11 AM

#

I have advice for role hunters

#

If you want a role => earn it

#

Simple, isn’t it?

#

KekDoggo

wary stratus May 19, 2021, 2:14 AM

#

OhMyGod

vast cliff May 19, 2021, 2:15 AM

#

CB_cool_umaru

plain storm May 19, 2021, 2:21 AM

#

and just like that he influenced the lives of over 100,000 people

worthy cypress May 19, 2021, 2:37 AM

#

true portal but some tried

mhm

ornate kite May 19, 2021, 4:06 AM

#

top.gg is open source now?

wanton tapir May 19, 2021, 4:12 AM

#

I think

kindred maple May 19, 2021, 4:16 AM

#

ornate kite top.gg is open source now?

One message removed from a suspended account.

ornate kite May 19, 2021, 4:16 AM

#

sad

dusky shale May 19, 2021, 4:32 AM

#

no copy pastas yet

left eagle May 19, 2021, 5:22 AM

#

ey

wraith flint May 19, 2021, 5:25 AM

#

owowhatsthis

gaunt sand May 19, 2021, 5:54 AM

#

@high depot https://github.com/top-gg/crowdin-discord is this for workers.dev?

GitHub

top-gg/crowdin-discord

Forward Crowdin webhooks to Discord. Contribute to top-gg/crowdin-discord development by creating an account on GitHub.

tiny shard May 19, 2021, 6:06 AM

#

gaunt sand <@!299176718713880577> https://github.com/top-gg/crowdin-discord is this for wor...

yes

high depot May 19, 2021, 6:33 AM

#

gaunt sand <@!299176718713880577> https://github.com/top-gg/crowdin-discord is this for wor...

Yes

dusky shale May 19, 2021, 8:39 AM

#

👀

wintry marten May 19, 2021, 12:38 PM

#

how do you write a comment in the exact same second as me on a pr that was created 4 hours ago

#

I'm starting to think berry is outside my window or something

tiny shard May 19, 2021, 12:39 PM

#

yeah idfk

#

i posted my comment and look up and you're there

#

kek

jade cobalt May 19, 2021, 2:20 PM

#

which repo?

#

ah I see

dusky shale May 19, 2021, 3:11 PM

#

the number of channels is increasing exponentially

worthy cypress May 19, 2021, 3:15 PM

#

How is it exponential

dusky shale May 19, 2021, 3:17 PM

#

idk

soft sorrel May 19, 2021, 3:22 PM

#

dusky shale the number of channels is increasing exponentially

everyday one new lol

river trail May 19, 2021, 3:23 PM

#

soft sorrel everyday one new lol

I thought the role-hunters are gonna flood this channel too like #site-translators

#

But it's abnormally quite

dusky shale May 19, 2021, 3:24 PM

#

GIME TOPUMGEGEE OPENSUS DEV ROLE

#

toppu jj role hunter

deft merlin May 19, 2021, 3:39 PM

#

Please keep this channel on topic ^^

dusky shale May 19, 2021, 8:09 PM

#

#767074831400960061

silent cedar May 19, 2021, 8:29 PM

#

you can mention voice channels??

dusky shale May 19, 2021, 8:41 PM

#

#609604489900589066

plain storm May 19, 2021, 8:53 PM

#

You can now

deft merlin May 19, 2021, 9:10 PM

#

Again please keep this channel on topic

placid crow May 19, 2021, 9:49 PM

#

@ashen quartz

#

whoops

#

#339488212206485504

dusky shale May 20, 2021, 7:16 AM

#

Applause, you know how to mention a voice channel Clap

pulsar coral May 20, 2021, 8:03 AM

#

How

bronze cave May 20, 2021, 8:10 AM

#

<#channelid> @pulsar coral
Just like a text channel

pulsar coral May 20, 2021, 8:10 AM

#

I can't in mobile but i know now

#

#609604489900589066

#

here!!

surreal socket May 20, 2021, 8:44 AM

#

deft merlin Please keep this channel on topic ^^

Everyone clearly just missing the point of this message

stark quiver May 20, 2021, 1:24 PM

#

mmLol

wraith pelican May 20, 2021, 1:28 PM

#

How to make a message which is sent when someone votes? Discord.js

worldly orchid May 20, 2021, 2:07 PM

#

#topgg-api

#

@wraith pelican

kindred maple May 20, 2021, 2:08 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wintry marten May 20, 2021, 2:32 PM

#

would be cool if we could give people access to this channel once they open a pr or issue but that's not really possible

surreal socket May 20, 2021, 2:35 PM

#

Well technically

jade cobalt May 20, 2021, 2:54 PM

#

you could make it something someone could request. For example someone could go to top.gg/open-source or something and it would give them the role to see this channel. Then they don't need to really make a change if they want to know whats going on but it removes the people who don't realize what the channel is actually for

kindred maple May 20, 2021, 3:01 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wary stratus May 20, 2021, 3:19 PM

#

wintry marten would be cool if we could give people access to this channel once they open a pr...

hmmm webhook magic

wintry marten May 20, 2021, 3:21 PM

#

give me webhooks magical enough to find out people's discord ids from their github actions and I'll code it

soft sorrel May 20, 2021, 3:22 PM

#

wintry marten give me webhooks magical enough to find out people's discord ids from their gith...

they just give it in a field lol

jade cobalt May 20, 2021, 3:24 PM

#

I would just say use oauth

wintry marten May 20, 2021, 3:25 PM

#

I'll think about some other way to make it work later

honest ingot May 20, 2021, 3:25 PM

#

How do you get <@&844267965742186619>?

hollow jacinth May 20, 2021, 3:25 PM

#

honest ingot How do you get <@&844267965742186619>?

check pins

honest ingot May 20, 2021, 3:26 PM

#

I already did

surreal socket May 20, 2021, 3:26 PM

#

It means you contributed to top.gg OSS in one way or another

honest ingot May 20, 2021, 3:26 PM

#

Does opening issues count? Cuz I have a few currently open

hollow jacinth May 20, 2021, 3:26 PM

#

such as a pull request

#

that adds a new feature

#

lol

surreal socket May 20, 2021, 3:26 PM

#

#topgg-open-source message

high depot May 20, 2021, 3:27 PM

#

surreal socket It means you contributed to top.gg OSS in one way or another

And if this contribution was really good

surreal socket May 20, 2021, 3:27 PM

#

Sort of, yeah. The guideline really helps with what is considered a valid contribution

hollow jacinth May 20, 2021, 3:27 PM

#

something like adding a comma doesn't count

honest ingot May 20, 2021, 3:27 PM

#

https://github.com/top-gg/issues/issues/619
https://github.com/top-gg/issues/issues/680
https://github.com/top-gg/issues/issues/682
https://github.com/top-gg/issues/issues/700

dusky shale May 20, 2021, 3:27 PM

#

Bumping versions smirk

hollow jacinth May 20, 2021, 3:27 PM

#

has to be actual something useful

surreal socket May 20, 2021, 3:28 PM

#

dusky shale Bumping versions <:smirk:585884287320981554>

🤣 I mean...

hollow jacinth May 20, 2021, 3:28 PM

#

like adding a feature or fixing the code examples in the top.gg docs for example

surreal socket May 20, 2021, 3:28 PM

#

Hey technically speaking

#

Where's your role nori

hollow jacinth May 20, 2021, 3:28 PM

#

What if the Version bumps are security patches

#

that fix major vulnerabilitys

#

lol

dusky shale May 20, 2021, 3:29 PM

#

IDK, I don't really care either, I genuinely contributed because I wanted to

hollow jacinth May 20, 2021, 3:29 PM

#

I don't see much I could contribute to honestly

#

although I do have an idea but idk if it would be useful at all

surreal socket May 20, 2021, 3:30 PM

#

It's still recognition so @wintry marten could you give norizon the contributor role?

high depot May 20, 2021, 3:30 PM

#

kek

wintry marten May 20, 2021, 3:30 PM

#

if you have an idea pls open an issue first

honest ingot May 20, 2021, 3:31 PM

#

honest ingot <https://github.com/top-gg/issues/issues/619> <https://github.com/top-gg/issues/...

So would these count as a "contribution"?

honest ingot May 20, 2021, 3:36 PM

#

honest ingot <https://github.com/top-gg/issues/issues/619> <https://github.com/top-gg/issues/...

And also add https://github.com/top-gg/issues/issues/704 and https://github.com/top-gg/issues/issues/705

jade cobalt May 20, 2021, 3:36 PM

#

likely not

surreal socket May 20, 2021, 3:37 PM

#

Well, it's just issue reports and not code contributions

jade cobalt May 20, 2021, 3:37 PM

#

since you aren't really contributing anything

surreal socket May 20, 2021, 3:37 PM

#

I doubt that counts as contributing, yeah

jade cobalt May 20, 2021, 3:43 PM

#

@fair goblet all of the issues about a bug on the resign should get a redesign tag or something so users can search for an already-existing issue documenting the bug they found, which would reduce the duplicates

fair goblet May 20, 2021, 3:43 PM

#

pretty sure there is

jade cobalt May 20, 2021, 3:44 PM

#

ah I see the beta label

fair goblet May 20, 2021, 3:44 PM

#

oh i guess it wasnt applied to most of the issues

jade cobalt May 20, 2021, 3:44 PM

#

yeah only 8 or something

worthy cypress May 20, 2021, 4:39 PM

#

wintry marten would be cool if we could give people access to this channel once they open a pr...

i was honestly thinking keeping this channel to the contributor role people so that spam can be avoided, plus a clear indication that those who get it actively wish to contribute to top.gg. i think everyone should be able to read this channel but only OSS role peeps can talk

wintry marten May 20, 2021, 4:40 PM

#

alright, I'll do that. I don't mind counting valid bug reports as OSS contributions either

worthy cypress May 20, 2021, 4:48 PM

#

~~can u also merge #39 too plz~~ blobpain

kindred maple May 20, 2021, 4:49 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

kindred maple May 20, 2021, 4:51 PM

#

wintry marten alright, I'll do that. I don't mind counting valid bug reports as OSS contributi...

One message removed from a suspended account.

tiny shard May 20, 2021, 4:51 PM

#

so over kill honestly

#

i think it’s fine how it is

kindred maple May 20, 2021, 4:51 PM

#

One message removed from a suspended account.

worthy cypress May 20, 2021, 4:51 PM

#

this is good enough imo

#

we just don't need random white names getting OT in here or shitposting

kindred maple May 20, 2021, 4:51 PM

#

One message removed from a suspended account.

tiny shard May 20, 2021, 4:51 PM

#

it creates an open discussion for users who might want to contribute but if you lock it now they can’t and those are the people who need the most guidance via discussion

worthy cypress May 20, 2021, 4:52 PM

#

xet's updated the channel desc already, so presuming people end up reading it they'll know how to get OSS access

kindred maple May 20, 2021, 4:52 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

tiny shard May 20, 2021, 4:52 PM

#

oof

kindred maple May 20, 2021, 4:52 PM

#

One message removed from a suspended account.

worthy cypress May 20, 2021, 4:55 PM

#

There are a series of Issues for the top-gg/issues repo that have yet to receive any labels about it being a bug or wontfix. Any clear info on these in particular?

#658-#661
#663-#675
#683
#686
#688-#703
#705

#

Some have discussion on them but badges/labels haven't been placed. https://i.imgur.com/enpa1RT.png

Imgur

tiny shard May 20, 2021, 5:06 PM

#

idk there's some people who are basically contributors but haven't ever actually contributed to any repo, like @jade cobalt @hollow jacinth @soft sorrel have all been helpful in this channel already but they're not actual contribs

#

oh xet hasnt actually locked it yet

jade cobalt May 20, 2021, 5:07 PM

#

im pretty sure Xetera did an overwite for me so I couldn't be doing it for the role
which is pretty smart

tiny shard May 20, 2021, 5:07 PM

#

or just hasnt locked it yet idk

jade cobalt May 20, 2021, 5:08 PM

#

it was locked before so thats why I thought it was overwritten

tiny shard May 20, 2021, 5:08 PM

#

ah

kindred maple May 20, 2021, 5:08 PM

#

jade cobalt it was locked before so thats why I thought it was overwritten

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

jade cobalt May 20, 2021, 5:09 PM

#

then Xetera is very smart

kindred maple May 20, 2021, 5:12 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

tiny shard May 20, 2021, 5:19 PM

#

stop talking to reaction faith

kindred maple May 20, 2021, 5:19 PM

#

One message removed from a suspended account.

high depot May 20, 2021, 6:48 PM

#

@dense barnsolved your issue with 45 symbols Hehe

dense barn May 20, 2021, 6:48 PM

#

Yea I'm looking at it

#

I'm thinking whether this is a great solution though 🥺

#

The more we add to it, the more the string feels unreadable

high depot May 20, 2021, 6:49 PM

#

lmao

#

I'll try to make it an embed

dense barn May 20, 2021, 6:49 PM

#

one sec

#

I'm doing a suggestion on your review

worthy cypress May 20, 2021, 6:49 PM

#

regex is a programmer's way of sleeping in bed with the devil

#

or is this not regex 👀

high depot May 20, 2021, 6:49 PM

#

worthy cypress or is this not regex 👀

not regex

worthy cypress May 20, 2021, 6:50 PM

#

oh no

high depot May 20, 2021, 6:50 PM

#

dense barn May 20, 2021, 6:50 PM

#

Added my feedback

worthy cypress May 20, 2021, 6:50 PM

#

can't you make it a footer instead?

high depot May 20, 2021, 6:51 PM

#

dense barn Added my feedback

I'm making it an embed rn

dense barn May 20, 2021, 6:51 PM

#

Ah kk

high depot May 20, 2021, 7:06 PM

#

@dense barn https://github.com/top-gg/crowdin-discord/pull/5/commits/cad31ce85639727bcab2b17db7ccbfeed452f014

#

#

@wintry martenBtw I just realized that we can catch project name from crowdin event itself without getting in from query params

wintry marten May 20, 2021, 7:23 PM

#

oh?

#

that's cool

#

feel free to pr it, I'll add a github workflow later so we can autodeploy the changes

high depot May 20, 2021, 7:27 PM

#

wintry marten feel free to pr it, I'll add a github workflow later so we can autodeploy the ch...

I have a pr about embeds

#

Will add it into this one then

#

Done

worthy cypress May 21, 2021, 3:33 AM

#

@wintry marten are people gonna reaction spam too?

#

Almost every message has a watermelon reaction now

fair goblet May 21, 2021, 5:41 AM

#

i checked yesterday, xet disabled reaction perms for everyone after that

wary stratus May 21, 2021, 1:49 PM

#

high depot

Pretty pog, good job

surreal socket May 21, 2021, 3:42 PM

#

Literally re-implementing dict methods just to mimic a dictionary is such a pain

worthy cypress May 21, 2021, 4:42 PM

#

For the python lib?

surreal socket May 21, 2021, 4:42 PM

#

Yeah

kindred maple May 21, 2021, 4:42 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

surreal socket May 21, 2021, 4:43 PM

#

Yeah so does Python

#

The thing here is

worthy cypress May 21, 2021, 4:43 PM

#

So does PHP

#

laugh

surreal socket May 21, 2021, 4:43 PM

#

I need to work with my object's __dict__ attribute

#

And not directly with the object's hash

surreal socket May 21, 2021, 5:06 PM

#

@dusky shale let's talk here

#

And nah, I do this:

    def __init__(self, **kwargs):
        self.__dict__ = parse_dict(kwargs)

dusky shale May 21, 2021, 5:09 PM

#

Why?

#

I think ```py
def init(self, *args, **kwargs):
self.dict = self
super().init(*args, **parse_dict(kwargs))

surreal socket May 21, 2021, 5:10 PM

#

having a superinit clones the data, no?

dusky shale May 21, 2021, 5:10 PM

#

Nope, since its __dict__ is a reference to itself

#

You can test the identity ig

surreal socket May 21, 2021, 5:12 PM

#

...

#

I see KEKW

#

dusky shale May 21, 2021, 5:15 PM

#

Right

#

Will be there other aliased keys by the way?

surreal socket May 21, 2021, 5:16 PM

#

I don't think so

#

I've gone over the attributes and only colours seems to be an alias I need to handle

dusky shale May 21, 2021, 5:18 PM

#

Ah, so there are only 3 overridden methods, aren't there?

surreal socket May 21, 2021, 5:19 PM

#

Pretty much

#

getitem, setitem, and get

#

All of this to waste

#

KEKW

dusky shale May 21, 2021, 5:20 PM

#

exdee, that's what you'd do if you don't inherit the dict

surreal socket May 21, 2021, 5:21 PM

#

It's rather funny how the default JSONEncoder only supports built-in types

dusky shale May 21, 2021, 5:22 PM

#

Default to str smirk

surreal socket May 21, 2021, 5:22 PM

#

KEKW

dusky shale May 21, 2021, 5:22 PM

#

Was it the datetime messing it?

surreal socket May 21, 2021, 5:23 PM

#

surreal socket It's rather funny how the default JSONEncoder only supports built-in types

Yeah, but this is also why I wanted to subclass dict

#

I mean to be fair

dusky shale May 21, 2021, 5:23 PM

#

I see, nested objects will still be fine ig

surreal socket May 21, 2021, 5:24 PM

#

I don't have datetime object being sent to top.gg so if someone has an issue with it, they can technically Google it iara_xD

dusky shale May 21, 2021, 5:27 PM

#

lol The only thing one would post is the stats which doesn't have the model, isn't it?

surreal socket May 21, 2021, 5:27 PM

#

I added a BotStats... something model

#

Ah, BotStatsData

dusky shale May 21, 2021, 5:28 PM

#

How's the API gonna be? Are users supposed to be able to pass the data on to the parameters directly as well as passing BotStatsData object?

surreal socket May 21, 2021, 5:30 PM

#

Ah no, BotStatsData is for receiving bot stats. Parameters will stay

dusky shale May 21, 2021, 5:31 PM

#

Ahh

surreal socket May 21, 2021, 6:01 PM

#

@dusky shale guess who tests are failing

#

    def test_data_dict_fields(data_dict: types.DataDict):
        for attr in data_dict:
            if "id" in attr.lower():
>               assert isinstance(data_dict[attr], int) or data_dict[attr] is None
E               AssertionError: assert (False or '264811613708746752' is None)
E                +  where False = isinstance('264811613708746752', int)

test_type.py:102: AssertionError

#

Oh hold on what

#

...???

dusky shale May 21, 2021, 6:04 PM

#

exdee

#

Did you figure out something

surreal socket May 21, 2021, 6:04 PM

#

>> from topgg.types import DataDict
... from tests.test_type import d
>>> dd = DataDict(**d)
>>> dd
{'def_avatar': '6debd47ed13483642cf09e832ed0bc1b', 'invite': None, 'website': 'https://top.gg', 'support': 'KYZsaFb', 'github': 'https://github.com/top-gg/Luca', 'longdesc': 'Luca only works in the **Discord Bot List** server.    \nPrepend commands with the prefix `-` or `@Luca#1375`.    \n**Please refrain from using these commands in non testing channels.**\n- `botinfo @bot` Shows bot info, title redirects to site listing.\n- `bots @user`* Shows all bots of that user, includes bots in the queue.\n- `owner / -owners @bot`* Shows all owners of that bot.\n- `prefix @bot`* Shows the prefix of that bot.\n* Mobile friendly version exists. Just add `noembed` to the end of the command.\n', 'shortdesc': 'Luca is a bot for managing and informing members of the server', 'prefix': '- or @Luca#1375', 'lib': None, 'clientid': 264811613708746752, 'avatar': '7edcc4c6fbb0b23762455ca139f0e1c9', 'id': 264811613708746752, 'discriminator': '1375', 'username': 'Luca', 'date': datetime.datetime(2017, 4, 26, 18, 8, 17, 125000), 'server_count': 2, 'guilds': [417723229721853963, 264445053596991498], 'shards': [], 'monthly_points': 19, 'points': 397, 'certified_bot': False, 'owners': [129908908096487424], 'tags': ['Moderation', 'Role Management', 'Logging'], 'donatebotguildid': None}
>>> dd.id
264811613708746752
>>> type(dd.id)
<class 'int'>

#

Literally ran this in Python Console

dusky shale May 21, 2021, 6:05 PM

#

So, the attribute was int but not the item?

surreal socket May 21, 2021, 6:05 PM

#

Oh did I not copy that

#

>>> type(dd['id'])
<class 'int'>

dusky shale May 21, 2021, 6:06 PM

#

lmao

surreal socket May 21, 2021, 6:06 PM

#

My test is failing because my ID attr is str for... whatever reason

dusky shale May 21, 2021, 6:06 PM

#

What attribute was that?

surreal socket May 21, 2021, 6:06 PM

#

oh oops

dusky shale May 21, 2021, 6:07 PM

#

donatbotguildid mmulu

surreal socket May 21, 2021, 6:07 PM

#

I didn't unpack my dict

dusky shale May 21, 2021, 6:07 PM

#

It's Optional[int]

surreal socket May 21, 2021, 6:07 PM

#

Yeah it's None if Top.gg returns ''

dusky shale May 21, 2021, 6:07 PM

#

Ah, so that wasn't the issue?

#

mfw didn't see this

surreal socket May 21, 2021, 6:09 PM

#

Ya, nah. I rely on kwargs for parse_dict and I forgot to unpack it

#

did DataDict(d) instead of DataDict(**d)

dusky shale May 21, 2021, 6:14 PM

#

Ah, since you only parse the kwargs but not if the dict was passed as positional argument

#

Maybe you also want to parse the args? But w/e it's not meant to be instantiated by users anyway

surreal socket May 21, 2021, 6:21 PM

#

dusky shale Maybe you also want to parse the args? But w/e it's not meant to be instantiated...

idec about args in the first place really

#

I'm thinking about removing *args altogether since I don't use it anyway

dusky shale May 21, 2021, 6:23 PM

#

Ah true

surreal socket May 21, 2021, 6:26 PM

#

Weee, tests pass

dusky shale May 21, 2021, 6:27 PM

#

POG

high depot May 21, 2021, 7:31 PM

#

Xet I'll note it as TODO in my TODO list

#

Will do

surreal socket May 21, 2021, 7:45 PM

#

What do you guys think about having a slash prepended to the endpoints in top.gg docs?
For example:

wintry marten May 21, 2021, 7:46 PM

#

I added a wrangler workflow to automatically update the bot with the new version

#

don't change crowdin-discord to yourname again otherwise it'll break the build

wintry marten May 21, 2021, 7:47 PM

#

surreal socket What do you guys think about having a slash prepended to the endpoints in top.gg...

if we check to make sure the url isn't absolute first, sure

high depot May 21, 2021, 7:48 PM

#

wintry marten don't change `crowdin-discord` to `yourname` again otherwise it'll break the bui...

yeah ok

#

I noticed that it crashed

#

Decided not to ping you since I thought you already got a notif

worthy cypress May 21, 2021, 8:58 PM

#

surreal socket What do you guys think about having a slash prepended to the endpoints in top.gg...

Seems fine to me

high depot May 22, 2021, 1:56 PM

#

@wintry marten #818685400667127808

wintry marten May 22, 2021, 1:56 PM

#

I don't have permission to block on the organization level

#

@dense barn

high depot May 22, 2021, 1:56 PM

#

@dense barn

#

Wake up

wary stratus May 22, 2021, 1:58 PM

#

Just yeet their commands for now

#

Comments

wintry marten May 22, 2021, 1:59 PM

#

pretty sure github bans for this behavior but we'll see

#

literally 0 value user account

high depot May 22, 2021, 1:59 PM

#

Deleted them on GitHub, can’t do so in #818685400667127808 since I’m not mod heh

#

I’ll save a ss for veld

#

I have a fucking shitton of GitHub notifications on my email now KEK

surreal socket May 22, 2021, 2:08 PM

#

What happened lol

high depot May 22, 2021, 2:08 PM

#

surreal socket What happened lol

Guy tried to promote using #818685400667127808

#

I’m banned from server he sent KEK

surreal socket May 22, 2021, 2:09 PM

#

You have to be kidding

#

LMFAO

worthy cypress May 22, 2021, 2:15 PM

#

I will be pushing an update for the PHP library soon for webhooks to work, however for now they will be webserver in terms of implementation.

high depot May 22, 2021, 2:21 PM

#

@wintry marten #818685400667127808

#

I locked convo

wintry marten May 22, 2021, 2:22 PM

#

dude what do you want me to do

surreal socket May 22, 2021, 2:22 PM

#

KEKW

high depot May 22, 2021, 2:22 PM

#

wintry marten dude what do you want me to do

Delete messages in #818685400667127808

#

LaffeyDrink

wintry marten May 22, 2021, 2:26 PM

#

I just moved to webhook temporarily until his github account gets banned

#

I'll move it back

#

gonna go back to my project now

dense barn May 22, 2021, 3:08 PM

#

What happened

surreal socket May 22, 2021, 3:09 PM

#

Someone spammed in 2 repos and got banned from this server

kindred maple May 22, 2021, 3:10 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

surreal socket May 22, 2021, 3:10 PM

#

Xetera wanted you to ban the guy from the org

kindred maple May 22, 2021, 3:10 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

surreal socket May 22, 2021, 3:10 PM

#

Nah

#

Some bot dev

kindred maple May 22, 2021, 3:11 PM

#

One message removed from a suspended account.

high depot May 22, 2021, 3:22 PM

#

I’ll dm u veld

dense barn May 22, 2021, 3:42 PM

#

oh ok

worthy cypress May 22, 2021, 5:42 PM

#

worthy cypress There are a series of Issues for the `top-gg/issues` repo that have yet to recei...

Bringing this up again in case it wasn't seen. @dense barn

high depot May 22, 2021, 6:44 PM

#

reported this guy tho

tiny shard May 22, 2021, 10:35 PM

#

worthy cypress Bringing this up again in case it wasn't seen. <@!121919449996460033>

they’ll get to it eventually they’re not gonna disappear overnight

#

plus i’m sure half of the issues you brought up were already known and were gonna be / have been fixed already

surreal socket May 23, 2021, 9:44 PM

#

Poor GitHub webhook still hidden

high depot May 23, 2021, 9:46 PM

#

KEK

wary stratus May 23, 2021, 9:46 PM

#

nah not broken

high depot May 23, 2021, 9:46 PM

#

Let xet have his weekend

wary stratus May 23, 2021, 9:46 PM

#

let's just say intentionally broken

high depot May 23, 2021, 9:47 PM

#

wary stratus let's just say intentionally broken

Yeah xet moved it to mod channel Bcuz guy was spamming

surreal socket May 23, 2021, 9:49 PM

#

What weekend? /s

tiny shard May 24, 2021, 2:17 AM

#

maybe make it only viewable to open source contribs cuz i use it to see stuff tbh

surreal socket May 24, 2021, 5:49 AM

#

@dense barn what do you think? 👀

surreal socket May 24, 2021, 7:13 AM

#

Be sure to follow consistent formatting, kids

surreal socket May 24, 2021, 8:31 AM

#

@dusky shale Does :meth:WebhookManager.run is now awaitable make sense KEKW

dusky shale May 24, 2021, 8:31 AM

#

It's always been awaitable 🔫

surreal socket May 24, 2021, 8:31 AM

#

XGWkekwlaugh

#

Since the method can be used without await

dusky shale May 24, 2021, 8:33 AM

#

What about "can optionally be awaited"? Lmao, I suck at wording tbh

surreal socket May 24, 2021, 8:33 AM

#

O sounds good

#

... more or less KEKW

dusky shale May 24, 2021, 9:52 AM

#

@surreal socket shiv xd

surreal socket May 24, 2021, 9:53 AM

#

Eh I'll probably add additional ratelimiter for specific routes and update that

#

v1.1.1 changelog: update examples

#

mmulu

dusky shale May 24, 2021, 9:56 AM

#

LMAO, it's on me tbh, forgot to delete it blobweary

surreal socket May 24, 2021, 9:56 AM

#

Nah it's okay

#

I kinda forgot about that example trying to figure out all the DataDict crap

dusky shale May 24, 2021, 10:07 AM

#

LUL

surreal socket May 24, 2021, 11:01 AM

#

@wintry marten Can you update the docs URL for the Python SDK repo to topggpy.rtfd.io?

wintry marten May 24, 2021, 11:07 AM

#

I'll take a look tomorrow, vacation for top.gg today

surreal socket May 24, 2021, 11:07 AM

#

No problem

worthy cypress May 24, 2021, 1:25 PM

#

PR up for documenting error handling

high depot May 24, 2021, 2:09 PM

#

Got a message about guy who was spamming on GitHub

#

worthy cypress May 24, 2021, 2:24 PM

#

I mean it's a one-and-done kind of deal; very old related information that I don't think we have to bring up anymore

surreal socket May 25, 2021, 12:53 PM

#

Webhook for Python SDK when

dusky shale May 25, 2021, 2:28 PM

#

@surreal socket wdyt of making topggpy PEP 561 compliant?

surreal socket May 25, 2021, 3:15 PM

#

You mean adding stubs?

dusky shale May 25, 2021, 3:15 PM

#

Um, not really. Just make it so that mypy can detect the lib types

#

Inline annotations is fine imo, since we're working with python 3.6+

dusky shale May 25, 2021, 3:17 PM

#

dusky shale Um, not really. Just make it so that mypy can detect the lib types

Essentially, adding an empty file named py.typed in the package dir

surreal socket May 25, 2021, 3:18 PM

#

Sounds good to me

dusky shale May 25, 2021, 3:18 PM

#

Oh yeah, another thing, is this intended to be 500?

surreal socket May 25, 2021, 3:19 PM

#

Yeah, I'm not sure if the search endpoint is fixed yet but when I wrote that, it allowed max 500 results at a time

dusky shale May 25, 2021, 3:20 PM

#

I see

#

And is there a case where the response returns without json content type?

surreal socket May 25, 2021, 3:21 PM

#

Yeah. Say, CF errors

dusky shale May 25, 2021, 3:21 PM

#

Cuz 😅

surreal socket May 25, 2021, 3:22 PM

#

uhhhh

#

Wait, don't I raise ServerError with response codes >= 500?

dusky shale May 25, 2021, 3:25 PM

#

Yep, you do

surreal socket May 25, 2021, 3:25 PM

#

Refusing to claim to be smart was a rather good idea, it seems

#

Yeah that annotation should be changed

#

There's no endpoint that returns an invalid JSON

dusky shale May 25, 2021, 3:36 PM

#

So, would you rather check the type at runtime or just lie to the type checker by casting it? The former might/might not add an overhead while the latter should be just as fast

surreal socket May 25, 2021, 3:42 PM

#

The latter sounds more appropriate in this case imo

surreal socket May 25, 2021, 4:29 PM

#

@dusky shale stares at the failing tests

#

KEKW

dusky shale May 25, 2021, 4:29 PM

#

LMAO

#

Fixed it LUL

surreal socket May 25, 2021, 4:30 PM

#

yee haw

#

Now we're talking

dusky shale May 25, 2021, 4:31 PM

#

Tried to use AsyncMock from the mocker fixture as mypy screamed at me doing mock.AsyncMock for whatever reason. Turned out, it's not compatible with 3.6 mmulu Let's just # type: ignore them

surreal socket May 25, 2021, 4:31 PM

#

🤣

surreal socket May 25, 2021, 4:52 PM

#

Well, I think my dumb way of implementing ratelimiters into the request method should work

#

        async with (global_ratelimiter, bot_endpoint_ratelimiter
        if route.startswith("/bots") else global_ratelimiter):

because we can Shrug

dusky shale May 25, 2021, 4:57 PM

#

Multiple global ratelimiters? Wouldn't it cause issues as the lock is waiting for itself? Not sure mmulu

surreal socket May 25, 2021, 4:58 PM

#

It works

dusky shale May 25, 2021, 4:59 PM

#

Oh well, if it works it works kek

surreal socket May 25, 2021, 4:59 PM

#

KEKW

#

Oh God, you're right

#

... or not. I should probably test with a period that isn't equal to a second

dusky shale May 25, 2021, 5:02 PM

#

If that's the case, I think https://docs.python.org/3/library/contextlib.html#contextlib.nullcontext is the way to go

surreal socket May 25, 2021, 5:03 PM

#

Nah, it was ratelimiting at half the max_calls

#

    ratelimiter = (global_ratelimiter, bot_endpoint_ratelimiter) if route.startswith("/bots") else global_ratelimiter
    for _ in range(200):
        async with ratelimiter:
            print(_)

:)

dusky shale May 25, 2021, 5:05 PM

#

exdee, yeah that's basically the same as else (global_ratelimiter, nullcontext()) with less import

surreal socket May 25, 2021, 5:06 PM

#

Yeah, I didn't want to do it with nullcontext

tiny shard May 26, 2021, 5:40 PM

#

@wintry marten im gettin a bit of an issue with the topgg-autoposter that im not sure how to deal with in typescript, i did a stupid thing and made the AutoPoster and all of it's properties export via an index.js because i wanted normal js users just to be able to do const AutoPoster = require('topgg-autoposter'), but now im stuck in a pickle because i want to fix this by making it export via const { AutoPoster } = require('topgg-autoposter'), but i don't want it to be a breaking change, so i tried something like this

module.exports = AutoPoster

export { DJSPoster } from './structs/DJSPoster'
export { ErisPoster } from './structs/ErisPoster'
export { DJSSharderPoster } from './structs/DJSSharderPoster'
export { RosePoster } from './structs/RosePoster'```
Which WOULD work, but typescript exports the bottom part as defineProperty to `exports` rather than `module.exports` which makes it not work :/
As you know export default makes it define the `default` property which is super duper annoying now but e, i'm just trying to remove the js part, and also trying to make it actually pass along typings because typings would not work when im exporting it via an index.js file.

surreal socket May 26, 2021, 5:41 PM

#

Why not let it be a breaking change?

tiny shard May 26, 2021, 5:42 PM

#

because i don't want to bump for a stupid export change

dusky shale May 26, 2021, 6:34 PM

#

Long life to this channel

high depot May 26, 2021, 6:34 PM

#

This channel isnt locked

#

pog

surreal socket May 26, 2021, 6:34 PM

#

We are superior

dusky shale May 26, 2021, 6:34 PM

#

Well it's locked for people without the role

#

So now we can feel like mods in #general

high depot May 26, 2021, 6:34 PM

#

SenkoWin

wintry marten May 26, 2021, 6:49 PM

#

tiny shard <@!140862798832861184> im gettin a bit of an issue with the topgg-autoposter tha...

not sure how you would be able to fix this one without a breaking change tbh

surreal socket May 26, 2021, 7:01 PM

#

Well since all chat channels are locked, I'm gonna ask here

#

Does anyone know if the @everyone role has the same ID as the guild itself for new servers?

wary stratus May 26, 2021, 7:02 PM

#

yes it does

#

afaik

surreal socket May 26, 2021, 7:03 PM

#

ty

wary stratus May 26, 2021, 7:03 PM

#

well

#

doesn't actually ping it

#

but it does

surreal socket May 26, 2021, 7:03 PM

#

Got it

#

thanks

tiny shard May 26, 2021, 10:34 PM

#

wintry marten not sure how you would be able to fix this one without a breaking change tbh

alright its breaking, so https://github.com/top-gg/docs/pull/42 if you could

true portal May 26, 2021, 11:34 PM

#

Why not put notis in here and just remove comments from the webhook responses?

tiny shard May 27, 2021, 1:38 AM

#

no point

tiny shard May 27, 2021, 1:38 AM

#

tiny shard alright its breaking, so <https://github.com/top-gg/docs/pull/42> if you could

@dense barn @royal breach

royal breach May 27, 2021, 1:41 AM

#

tiny shard <@!121919449996460033> <@!184632227894657025>

out of curiosity, did you make this a breaking change?

tiny shard May 27, 2021, 1:41 AM

#

yes

#

2.0.0

royal breach May 27, 2021, 1:41 AM

#

neat

#

done

tiny shard May 27, 2021, 1:42 AM

#

thanks

royal breach May 27, 2021, 1:42 AM

#

smiles np

#

yea if xet is not online feel free to ping me for docs stuff

tiny shard May 27, 2021, 1:43 AM

#

sounds good SCyes

dense barn May 27, 2021, 3:33 AM

#

weirdChamp

#

What's the reason of that change tho

worthy cypress May 27, 2021, 3:41 AM

#

Docs change faster than my github issues pogey

dense barn May 27, 2021, 4:58 AM

#

sadge sorry I haven't been working on top.gg in the last few days

#

Focusing on auctions atm

kindred maple May 27, 2021, 3:06 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

tiny shard May 27, 2021, 3:20 PM

#

dense barn What's the reason of that change tho

types would never work because its it would use module.exports

#

and there's no real way to export as everything in typescript

#

it'd be export default but it sets default rather than the base of the export pensiveFast

kindred maple May 27, 2021, 7:09 PM

#

One message removed from a suspended account.

high depot May 27, 2021, 8:28 PM

#

imagine

surreal socket May 27, 2021, 8:29 PM

#

_ _

jade cobalt May 28, 2021, 1:17 AM

#

tiny shard types would never work because its it would use module.exports

you use module.exports on a ts project?

tiny shard May 28, 2021, 1:17 AM

#

shush

#

not anymore

jade cobalt May 28, 2021, 1:17 AM

#

hmm

surreal socket May 28, 2021, 1:41 PM

#

@wintry marten Any news on the slashes PR? 😛

wintry marten May 28, 2021, 1:42 PM

#

oh I thought I responded to that

surreal socket May 28, 2021, 1:42 PM

#

I did some changes regarding the review

kindred maple May 28, 2021, 2:18 PM

#

One message removed from a suspended account.

worthy cypress May 31, 2021, 1:44 AM

#

@dense barn sorry to ask, but what's the Top.gg code stack you guys employ again?

#

As well, are there plans in API/1.1 to support endpoints to DSL?

tiny shard May 31, 2021, 2:35 AM

#

worthy cypress <@!121919449996460033> sorry to ask, but what's the Top.gg code stack you guys e...

https://stackshare.io/top-gg/top-gg

StackShare

top.gg - Top.gg Tech Stack

JavaScript, GitHub, Git, jQuery, and Node.js are some of the popular tools that top.gg uses. Learn more about the Language, Utilities, DevOps, and Business Tools in Top.gg's Tech Stack.

worthy cypress May 31, 2021, 2:35 AM

#

Thank you Berry

tiny shard May 31, 2021, 2:35 AM

#

worthy cypress As well, are there plans in API/1.1 to support endpoints to DSL?

they plan on combining bots and servers so likely yes

worthy cypress May 31, 2021, 2:35 AM

#

pepega

tiny shard May 31, 2021, 10:37 PM

#

@wintry marten so do you think you can do the docs strategy this week?

tiny shard Jun 1, 2021, 5:46 PM

#

me when semicolons and double quotes in top-gg eslint config sadge

dusky shale Jun 1, 2021, 5:49 PM

#

The semi-colons are fine, but y double quotes tho

#

Smh my head

wintry marten Jun 1, 2021, 5:54 PM

#

does it really matter

#

I don't use semicolons myself but it's like such a meaningless thing

tiny shard Jun 1, 2021, 5:59 PM

#

like ill work with them i dont really care thaat much they're just stinky to look at for me atleast

wintry marten Jun 1, 2021, 6:21 PM

#

the only thing I don't like about semicolons is when I want to refactor f(x); into f(a(x)); I add the opening parentheses f(a(x); and after I press shift-A to go to the end of the line to add closing parentheses it turns into f(a(x);) so I have to delete the semicolon which is very annoying

worthy cypress Jun 1, 2021, 7:17 PM

#

I mean personally it's just a configuration, as long as some standard is being kept then imo no reason to worry

#

also

#

@wintry marten

surreal socket Jun 1, 2021, 7:20 PM

#

We need a fucking bot that generates these memes, like "I am once again asking for you to merge PR #x in top-gg/docs"

wintry marten Jun 1, 2021, 7:20 PM

#

this is honestly a pretty bad system I mean I don't know any of these libraries how am I supposed to approve them or why do they even belong in the docs in the first place

worthy cypress Jun 1, 2021, 7:20 PM

#

maintenance

#

keeping it open-sourced™️

tiny shard Jun 1, 2021, 7:23 PM

#

wintry marten this is honestly a pretty bad system I mean I don't know any of these libraries ...

tbh, i feel like it'd be better if the different libraries on the docs just redirected to the docs for that library and just keep them separately hosted and everything

#

that would make autodocs much better as well

wintry marten Jun 1, 2021, 7:23 PM

#

yes

tiny shard Jun 1, 2021, 10:37 PM

#

@fair goblet could you give @sacred belfry the oss contributor role

wary stratus Jun 1, 2021, 10:42 PM

#

where did they contribute?

tiny shard Jun 1, 2021, 10:43 PM

#

wary stratus where did they contribute?

node-sdk

wary stratus Jun 1, 2021, 10:44 PM

#

done

tiny shard Jun 1, 2021, 10:44 PM

#

thank

sacred belfry Jun 1, 2021, 10:44 PM

#

thank

tiny shard Jun 1, 2021, 10:44 PM

#

bonk @sacred belfry

sacred belfry Jun 1, 2021, 10:44 PM

#

i am now contributor

kindred maple Jun 1, 2021, 10:44 PM

#

One message removed from a suspended account.

sacred belfry Jun 1, 2021, 10:44 PM

#

where new color?

kindred maple Jun 1, 2021, 10:44 PM

#

One message removed from a suspended account.

sacred belfry Jun 1, 2021, 10:44 PM

#

frick

kindred maple Jun 1, 2021, 10:45 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

dusky shale Jun 3, 2021, 9:27 AM

#

Should have a color and be above bot dev

#

5_SadgeCry

jade cobalt Jun 3, 2021, 10:20 AM

#

It really shouldn’t. Top.gg isn’t trying to make people want to make contributions, they just want to be open to it. If the role was hoisted then people would be doing it only for the role

surreal socket Jun 3, 2021, 10:48 AM

#

This

wintry marten Jun 3, 2021, 10:49 AM

#

sadly we can't have nice things in topgg because people ruin it for everyone else

fair goblet Jun 3, 2021, 11:00 AM

#

https://img.marcorennmaus.de/tev3aPwH how to get this role @mods

high depot Jun 3, 2021, 11:08 AM

#

how to become more weeb than @fair goblet atTeam

jade cobalt Jun 3, 2021, 11:20 AM

#

its literally impossible

worthy cypress Jun 3, 2021, 2:37 PM

#

not every role is supposed to be collected Rinsip

dusky shale Jun 3, 2021, 3:10 PM

#

worthy cypress not every role is supposed to be collected <:Rinsip:692999161527926805>

pepeLaugh collecting muted role

surreal socket Jun 3, 2021, 5:07 PM

#

Rules Only

kindred maple Jun 4, 2021, 5:14 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

fair goblet Jun 4, 2021, 8:15 PM

#

eh disagree

#

helps managing stuff like this channel etc

worthy cypress Jun 4, 2021, 10:02 PM

#

i agree

#

helps also with keeping stuff serious

kindred maple Jun 5, 2021, 5:50 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

wintry marten Jun 7, 2021, 11:50 AM

#

sigh looks like I might have to fork nextjs soon lol

#

https://github.com/vercel/next.js/issues/21693 why isn't this added already? so stupid

GitHub

NEXT_LOCALE does not work with sub-path · Issue #21693 · vercel/nex...

What version of Next.js are you using? 10.0.6 What version of Node.js are you using? 14.15.0 What browser are you using? Safari What operating system are you using? macOS How are you deploying your...

#

my god this code https://github.com/vercel/next.js/blob/canary/packages/next/next-server/lib/i18n/normalize-locale-path.ts

GitHub

vercel/next.js

The React Framework. Contribute to vercel/next.js development by creating an account on GitHub.

tiny shard Jun 7, 2021, 12:02 PM

#

next moment

#

seems stink

high depot Jun 7, 2021, 3:00 PM

#

next is bruh

#

use nuxt

#

KEK

dense barn Jun 7, 2021, 5:27 PM

#

topggNotGood

#

I don't wanna work in vue in scale

tiny shard Jun 7, 2021, 6:04 PM

#

true

high depot Jun 7, 2021, 8:01 PM

#

dense barn I don't wanna work in vue in scale

Vue 3 > React

dense barn Jun 7, 2021, 8:01 PM

#

topggNotGood

dusky shale Jun 10, 2021, 6:17 AM

#

yes

surreal socket Jun 11, 2021, 8:04 PM

#

@wintry marten docs PR #48 merge plz

wintry marten Jun 11, 2021, 8:18 PM

#

ok this is a really stupid system this is the last library related pr I'm merging

surreal socket Jun 11, 2021, 8:31 PM

#

LMFAO

tiny shard Jun 11, 2021, 10:17 PM

#

auto build for docs when

kindred maple Jun 11, 2021, 10:32 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

tiny shard Jun 11, 2021, 10:38 PM

#

thats stinky

kindred maple Jun 11, 2021, 10:53 PM

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

#

One message removed from a suspended account.

tiny shard Jun 12, 2021, 1:07 AM

#

kindred maple One message removed from a suspended account.

we dont even

#

its all pr based and thats how it is and always should be with out-of-company contributors

kindred maple Jun 12, 2021, 1:08 AM

#

One message removed from a suspended account.

high depot Jun 12, 2021, 1:16 AM

#

Y’all just need a NDA

#

Veld make NDA and give library devs to sign it

#

||add a line that they should pay you $1000 monthly||

tiny shard Jun 12, 2021, 1:19 AM

#

what does an nda have to do with it

high depot Jun 12, 2021, 1:21 AM

#

Non-disclosure agreement

#

Mark in it info you can’t disclose and responsibility for prohibited actions (like filling docs with hentai), etc

#

That’s how NDA works

wintry marten Jun 12, 2021, 5:48 AM

#

why would you need to write to the topgg docs? Does discord.js put examples in discord's dev documentation?

#

I think yall just need to have the docs set up in your own Readme or a separate markdown file instead

worthy cypress Jun 12, 2021, 5:51 AM

#

NDA would be a disastrous idea

worthy cypress Jun 12, 2021, 5:52 AM

#

wintry marten why would you need to write to the topgg docs? Does discord.js put examples in d...

I think having one common-ground place to find all of the documentation for each API wrapper would prove more efficient than having the detriment of each of them having their own docs page that you have to go to. While it is probably better that way, it's easier for people to remember "oh go to docs.top.gg for the API docs"

#

people won't remember "okay JS is topgg.rtfd.io and python is ..., etc."

#

big fancy words to come out of me, but probably easier to remember the top.gg url than each individual one

wintry marten Jun 12, 2021, 5:53 AM

#

but wrappers are not topgg documentation. If you need to find js docs for python you Google that

#

like 3 people in total are going to use more than one api client

#

why do I need to make my life harder for 3 people

worthy cypress Jun 12, 2021, 5:53 AM

#

i don't think that's necessarily it

#

it's just a good idea imo to have a place to organize all of them under 1 source that can easily be remembered and referred to

#

that's the gist of my thoughts at least

wintry marten Jun 12, 2021, 5:56 AM

#

I'll add links so people can discover api clients but I'm not gonna be adding documentation for it under the topgg docs anymore. This is for the top.gg api so I just don't see why any library developer should be trying to keep a 3rd party docs up to date or have write access.

If we get new clients I'm happy to add them to the docs so people can go to one place to discover what they need

worthy cypress Jun 12, 2021, 5:57 AM

#

understood, i'll begin moving all of my lib documentation off of the docs page and refer to it on the website as a link to my own docs page

#

should be a happy compromise that way

wintry marten Jun 12, 2021, 5:57 AM

#

sounds great. I'm not gonna be doing that this weekend but probably sometime next week

worthy cypress Jun 12, 2021, 5:57 AM

#

no rush 👍

tiny shard Jun 12, 2021, 6:01 AM

#

@wintry marten well the conversation initially sparked from me asking veld about domains for the node-sdk typedoc change, he said to use docs.top.gg, so i asked him then you about an auto-build strategy that could centralize the library docs for auto-generated documentation, because obviously we shouldn't just be copy and pasting an entire typedoc into a single md file in a pr. we can stepback that and i can go get something like topgg.js.org for the node-sdk

wintry marten Jun 12, 2021, 6:03 AM

#

@dense barn this is not a sustainable way to do documentation and I don't think it's worth my time to work on a generic autobuild solution for documentation either

tiny shard Jun 12, 2021, 6:03 AM

#

he never said thats what we should do i just thought that would be the only feasible way to get auto-generated docs onto the docs.top.gg page

#

food for thought but maybe like a libs.top.gg or docs.top.gg/libaries could be a directory of autogen docs

#

shrug

wintry marten Jun 12, 2021, 6:04 AM

#

if you have websites for library docs it could be ok to lease something like js.docs.top.gg I suppose but getting pinged about accepting random PRs for libraries of languages I've never used before is pretty ridiculous

#

if someone has the time to work on that, maybe but I'm not gonna be doing it

#

if you have a solution that works on github actions and works generically for every language then feel free to make something like that

tiny shard Jun 12, 2021, 6:06 AM

#

it'd be neat but feels like centralized docs in the first place brings like no foreseen advantages tbh

wintry marten Jun 12, 2021, 6:06 AM

#

yes

#

clicking on a link that brings you to a different repo vs clicking a link that opens a different page on the same domain to show docs that could possibly be stale. One is about 10 minutes worth of work the other is like 10 hours

tiny shard Jun 12, 2021, 6:09 AM

#

i think editing the docs.top.gg library mds is fine how it is right now

#

but it shouldnt be like filled with documentation, just common examples

worthy cypress Jun 12, 2021, 6:09 AM

#

i mean i have no issues with migrating my docs honestly

#

it supersedes the write access issue we have

#

and takes off the workload of them having to check our PRs all the time for changes to doc

wintry marten Jun 12, 2021, 6:10 AM

#

maybe fine for you writing the docs, but not me who has to read them and accept changes

tiny shard Jun 12, 2021, 6:10 AM

#

well they shouldnt be so constant either

#

tis the life of a code reviewer KEK

worthy cypress Jun 12, 2021, 6:10 AM

#

idk the workload xet has outside of our docs writing

#

but i'm sure it's not out of pure laziness

#

otherwise it would not be such a prevalent complaint

tiny shard Jun 12, 2021, 6:11 AM

#

shruggy

worthy cypress Jun 12, 2021, 6:11 AM

#

plus honestly not our judgement call.

tiny shard Jun 12, 2021, 6:11 AM

#

fair

worthy cypress Jun 12, 2021, 6:11 AM

#

i'm here just so that there is a wrapper for their API

#

and nothing more

#

so whatever changes they make, i'm only for adapting to them

#

there's not much else to be asked out of that tbh

wintry marten Jun 12, 2021, 6:12 AM

#

there's just no reason for these docs to be in the api documentation for the exact same reason why discord doesn't have d.py in their documentation

tiny shard Jun 12, 2021, 6:12 AM

#

well d.py isnt discord official

#

these sdks are

worthy cypress Jun 12, 2021, 6:12 AM

#

i mean xet has a point

tiny shard Jun 12, 2021, 6:12 AM

#

alot of companies do the sdks on their docs all the time

worthy cypress Jun 12, 2021, 6:12 AM

#

the docs should be solely about their API

#

we're only offering the means of substitution and pre-written code for use

#

i can't really argue against that stance because there's no fallacy to it

tiny shard Jun 12, 2021, 6:13 AM

#

if we were random developers just making wrappers of your api i'd agree

#

but all of these sdks are atleast approved by employees or whatnot, and some maintained by them

worthy cypress Jun 12, 2021, 6:13 AM

#

i mean honestly, we are random developers

#

this is voluntary work as well

tiny shard Jun 12, 2021, 6:14 AM

#

of course but it's still an official sdk

#

not just some random wrapper like d.py and djs

#

no discord developer is approving prs on d.js repo

worthy cypress Jun 12, 2021, 6:14 AM

#

if i was being paid, i think i'd likely have some arguing point

#

i don't think our work is official SDK

#

i think it's open-sourced, volunteered wrapeprs

tiny shard Jun 12, 2021, 6:15 AM

#

really even the sdks are owned by top.gg

#

we're just contributors

worthy cypress Jun 12, 2021, 6:15 AM

#

after all we got our own channel archived in favor for an open source channel

#

which is more like private source now

#

kek

tiny shard Jun 12, 2021, 6:15 AM

#

its on the top-gg repo i mean like we have #topgg-api too its safe to say its official

worthy cypress Jun 12, 2021, 6:16 AM

#

feel like its a moot point

#

ig declaring it an official top.gg library makes it sdk

tiny shard Jun 12, 2021, 6:16 AM

#

topggSunglasses

wintry marten Jun 12, 2021, 6:16 AM

#

I'm not against the idea of having docs in one place but I can't be spending time accepting prs of things I literally do not know like golang into the documentation

worthy cypress Jun 12, 2021, 6:16 AM

#

then trust us with the PRs and accept merging since we're the ones maintaining our own wrappers

#

verycool

tiny shard Jun 12, 2021, 6:16 AM

#

i mean they shouldn't be happening so often

worthy cypress Jun 12, 2021, 6:16 AM

#

easy solution

tiny shard Jun 12, 2021, 6:16 AM

#

the main job with you approving prs at this point is like spelling mistakes and stuff lmao

worthy cypress Jun 12, 2021, 6:16 AM

#

im not sure who is making sporadic PRs for doc changes either

tiny shard Jun 12, 2021, 6:17 AM

#

because you just have to trust the maintainer

worthy cypress Jun 12, 2021, 6:17 AM

#

I guess I did, but I think I had a 3 week window between mine

#

or well

#

you could just let us directly commit

#

but blobpain

#

also inb4 berry kills me

#

is there a need for our lib dev role anymore? maybe it makes us stand out in #topgg-api sure but feels cosmetic now

tiny shard Jun 12, 2021, 6:18 AM

#

like js docs were edited 2 weeks ago, and 2 months before that

#

both were just for updates to the examples

#

i think that's how it should be

worthy cypress Jun 12, 2021, 6:18 AM

#

mm idk xet wasn't arguing about how consistently updated the docs are

#

xet was simply arguing their ignorance about what languages the API was being wrapped for

#

it's not an entirely invalid thing to stand on, but at the same time, at some point, i feel that you've gotta trust the lib devs

tiny shard Jun 12, 2021, 6:21 AM

#

could also just iframe the repos README ez

#

wouldnt be a bad idea just to like do that and display the readme or something tbh

worthy cypress Jun 12, 2021, 6:22 AM

#

tbqh i don't like the idea of migrating our docs to our own sites

#

because what if those sites go down?

#

there go your docs.

tiny shard Jun 12, 2021, 6:25 AM

#

what

#

use github pages or something

surreal socket Jun 12, 2021, 7:19 AM

#

I use rtfd.io which is never down basically

dense barn Jun 12, 2021, 7:27 AM

#

wintry marten <@!121919449996460033> this is not a sustainable way to do documentation and I d...

they have their own generated docs right?

#

I don't see a problem. Just have an introduction on the API on our actual docs page

#

If that's too much manual work, then I am quitting with all the manual work I do every week for top.gg sip

wintry marten Jun 12, 2021, 7:30 AM

#

I'm just not interested in maintaining this and keeping up with changes to libraries on top of everything else

dense barn Jun 12, 2021, 7:30 AM

#

The library maintainers can PR it

wintry marten Jun 12, 2021, 7:31 AM

#

I still have to go through the prs and check them

dense barn Jun 12, 2021, 7:31 AM

#

Anyone from the team*

#

We're a team of 5

wintry marten Jun 12, 2021, 7:31 AM

#

nobody else does open source

#

me and you

dense barn Jun 12, 2021, 7:31 AM

#

Feel free to reach out if you don't have time for it

wintry marten Jun 12, 2021, 7:31 AM

#

I don't

#

it's just extra work that can be avoided

dense barn Jun 12, 2021, 7:32 AM

#

It's a 5 minute PR review

wintry marten Jun 12, 2021, 7:32 AM

#

not worth the extra effort when we can just link to the docs of the library and never have to keep up with it

dense barn Jun 12, 2021, 7:33 AM

#

That's fine with me too

#

As long as it goes to an onboarding page on that docs page

wintry marten Jun 12, 2021, 7:33 AM

#

sure we can have a libraries index in the docs for useful clients

tiny shard Jun 12, 2021, 12:41 PM

#

wintry marten not worth the extra effort when we can just link to the docs of the library and ...

what abt what i said before and just using the sdks README as the page instead

wintry marten Jun 12, 2021, 12:45 PM

#

yeah that's what I want

#

link to the repo and the readme is the page people read

tiny shard Jun 12, 2021, 3:23 PM

#

wintry marten link to the repo and the readme is the page people read

no i mean like the page on the docs.top.gg use the source for the README.md so you don’t have to go to a different site maybe

#

or maybe some custom thing like DOCS.md on each of the sdks

wintry marten Jun 12, 2021, 3:24 PM

#

if you can set up the build for it with gatsby it's possible

tiny shard Jun 12, 2021, 3:24 PM

#

i’ll take a look

kindred maple Jun 20, 2021, 3:34 PM

#

One message removed from a suspended account.

wintry marten Jun 20, 2021, 3:35 PM

#

tomorrow

kindred maple Jun 20, 2021, 3:35 PM

#

One message removed from a suspended account.

tiny shard Jun 20, 2021, 8:14 PM

#

@wintry marten for docs autobuild what should i do for this?

#

should i just keep it my info

wintry marten Jun 20, 2021, 8:15 PM

#

what do you need this for

tiny shard Jun 20, 2021, 8:15 PM

#

or do we have a top-gg bot?

#

docs building

wintry marten Jun 20, 2021, 8:15 PM

#

we do have topgg bot

tiny shard Jun 20, 2021, 8:15 PM

#

.github/workflows/docs.yml

name: Build Docs
on:
  push:
    branches:
      - 'master'

jobs:
  Docgen:
    name: Docgen
    runs-on: ubuntu-latest
    steps:
      - name: Checkout Project
        uses: actions/checkout@v2
      - name: Use Node.js 14
        uses: actions/setup-node@v2
        with:
          node-version: 14
      - name: Restore CI Cache
        uses: actions/cache@v2.1.4
        with:
          path: node_modules
          key: ${{ runner.os }}-14-${{ hashFiles('**/package-lock.json') }}
      - name: Install Dependencies
        run: npm i --also=dev
      - name: Build documentation
        run: npm run docs
      - name: Publish Docs
        run: |
          REPO="https://${GITHUB_ACTOR}:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git"
          echo -e "\n# Checkout the repo in the target branch"
          TARGET_BRANCH="docs"
          git clone $REPO out -b $TARGET_BRANCH
          echo -e "\n# Move the generated docs to the newly-checked-out repo, to be committed and pushed"
          rsync -vaI README.md out/
          rsync -vaI docs/ out/
          echo -e "\n# Commit and push"
          cd out
          git add --all .
          git config user.name "${GITHUB_ACTOR}"
          git config user.email "${GITHUB_EMAIL}"
          git commit -m "docs: api docs build for ${GITHUB_SHA}" || true
          git push origin $TARGET_BRANCH
        env:
          GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
          GITHUB_ACTOR: jpbberry
          GITHUB_EMAIL: jb@jt3ch.net```

wintry marten Jun 20, 2021, 8:16 PM

#

https://github.com/top-gg-bot

GitHub

top-gg-bot - Overview

GitHub is where top-gg-bot builds software.

tiny shard Jun 20, 2021, 8:16 PM

#

got all this stuff

tiny shard Jun 20, 2021, 8:16 PM

#

wintry marten https://github.com/top-gg-bot

what's the info or is it in a team secret etc? what should i put basically

wintry marten Jun 20, 2021, 8:18 PM

#

I don't know

#

there's a git push action tho why are you doing this by hand

tiny shard Jun 20, 2021, 8:19 PM

#

i need to generate the docs to a diff folder so i thought might as well

wintry marten Jun 20, 2021, 8:19 PM

#

idk I'll look at this tomorrow

tiny shard Jun 20, 2021, 8:19 PM

#

alr

tiny shard Jun 20, 2021, 10:16 PM

#

@wintry marten i looked into the build error im getting and apparently the eslint report thing you got goin only works for contributors who have full write perms, so it doesnt work for anyone without them and fails on build

dense barn Jun 21, 2021, 8:28 AM

#

top-gg-bot is such a good bot

tiny shard Jun 21, 2021, 2:18 PM

#

dense barn top-gg-bot is such a good bot

do you know what the github secret names are for it? so that we can push docs to a diff branch with the bot

kindred maple Jun 21, 2021, 2:19 PM

#

wintry marten tomorrow

One message removed from a suspended account.

surreal socket Jun 21, 2021, 2:22 PM

#

@tiny shard did you

tiny shard Jun 21, 2021, 2:22 PM

#

yeah i did and i’m still trying to learn the full thing before i try implementing it

kindred maple Jun 21, 2021, 2:22 PM

#

One message removed from a suspended account.

surreal socket Jun 21, 2021, 2:23 PM

#

Ah ok

tiny shard Jun 21, 2021, 2:23 PM

#

also considering maybe waiting for v1 before implementing them because there’s no major changes happening rn

#

and v1 will have those

wintry marten Jun 21, 2021, 2:23 PM

#

v1 graphql maybe hmmGe

tiny shard Jun 21, 2021, 2:23 PM

#

a_eyesshaking

kindred maple Jun 21, 2021, 2:23 PM

#

One message removed from a suspended account.

wintry marten Jun 21, 2021, 2:24 PM

#

probably not but it's on the table

kindred maple Jun 21, 2021, 4:13 PM

#

One message removed from a suspended account.

tiny shard Jun 21, 2021, 6:27 PM

#

wintry marten idk I'll look at this tomorrow

you figure out the top-gg-bot credentials?

wintry marten Jun 21, 2021, 6:28 PM

#

idk I'm working on something else atm

tiny shard Jun 21, 2021, 6:28 PM

#

prolly the best way to do it is to define an org secret with like BOT_TOKEN BOT_USERNAME BOT_EMAIL, and then can just use those

#

alr lmk

wintry marten Jun 21, 2021, 6:28 PM

#

im not sure idk about topgg bot maybe ask veld about it

tiny shard Jun 21, 2021, 6:38 PM

#

@dense barn

high depot Jun 21, 2021, 6:38 PM

#

That time when I don't want to be Veld

#

KEK

dense barn Jun 21, 2021, 6:38 PM

#

whats up

tiny shard Jun 21, 2021, 6:39 PM

#

can you add org secrets for the credentials of top-gg-bot?

dense barn Jun 21, 2021, 6:39 PM

#

no public access to top-gg-bot

#

it has access to our private repos

tiny shard Jun 21, 2021, 6:39 PM

#

not public

#

i mean for workflows

dense barn Jun 21, 2021, 6:39 PM

#

well it still is public access

tiny shard Jun 21, 2021, 6:39 PM

#

github actions stuff

dense barn Jun 21, 2021, 6:39 PM

#

yes

tiny shard Jun 21, 2021, 6:39 PM

#

i mean everything uses it would need approval from trusted people

high depot Jun 21, 2021, 6:39 PM

#

they couldnt be accessed out of workflows yknow

dense barn Jun 21, 2021, 6:40 PM

#

It's a security concern for now

#

What do you need the bot for?

tiny shard Jun 21, 2021, 6:40 PM

#

pushing docs for github pages to a docs branch

tiny shard Jun 21, 2021, 6:40 PM

#

tiny shard **.github/workflows/docs.yml** ```yml name: Build Docs on: push: branches:...

this

#

need to replace

        env:
          GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
          GITHUB_ACTOR: jpbberry
          GITHUB_EMAIL: jb@jt3ch.net```

high depot Jun 21, 2021, 6:41 PM

#

pff don't use secrets

#

just put it in public

#

/j

tiny shard Jun 21, 2021, 6:43 PM

#

dense barn What do you need the bot for?

https://github.com/jpbberry/node-sdk/tree/docs so like on my fork it does this

GitHub

jpbberry/node-sdk

An official module for interacting with the Top.gg API - jpbberry/node-sdk

dense barn Jun 21, 2021, 6:44 PM

#

isn't it

#

GITHUB_TOKEN

#

instead of GH_TOKEN

tiny shard Jun 21, 2021, 6:44 PM

#

its a secret

#

so its defined in the repo

#

#

and then i generate a token and add that to repo secrets

#

but i dont really want to use my own github token for the pushes unless ig i have to, i also dont think i even can cuz i dont have full write perms

#

its already kinda weird that it uses my npm token to publish but

worthy cypress Jun 21, 2021, 8:07 PM

#

Thonk interesting

tiny shard Jun 23, 2021, 10:08 PM

#

@dense barn

dense barn Jun 23, 2021, 10:09 PM

#

?

tiny shard Jun 23, 2021, 10:18 PM

#

dense barn ?

still looking for an answer to this

dense barn Jun 23, 2021, 10:19 PM

#

oh i haven't had time to look into this yet

dense barn Jun 24, 2021, 5:03 PM

#

hey

#

for vote webhooks

#

is the "type" property right now either "bot" or "guild"?

#

cc @worthy cypress @kindred maple @surreal socket @tiny shard

#

I saw for test webhooks we handle it as "test" type

#

but that seems kind of intuitive

tiny shard Jun 24, 2021, 5:04 PM

#

“upvote”

dense barn Jun 24, 2021, 5:04 PM

#

Oh i see

tiny shard Jun 24, 2021, 5:04 PM

#

yeah it’s like extremely useless but

dense barn Jun 24, 2021, 5:04 PM

#

How would you know whether the type is a guild or bot though

tiny shard Jun 24, 2021, 5:04 PM

#

it’s there lol

#

check if vote.bot or vote.guild

dense barn Jun 24, 2021, 5:04 PM

#

weirdChamp

#

OK

#

understood

#

I wanna do some layout adjustments

#

as we move into our new backend for things

tiny shard Jun 24, 2021, 5:05 PM

#

yeah for sure

dense barn Jun 24, 2021, 5:07 PM

#

so what I propose is

type WebhookPayload {
  guild?: string; // @deprecated - use entity.id instead
  bot?: string;   // @deprecated - use entity.id instead
  type: "vote" | ...,
  entity: BasicEntity {
    id: string;
    name: string;
    avatarUrl?: string;
    url: string; // e.g. https://top.gg/bot/miki
  }
  user: string;
}

#

I don't want to break it, but i want to expose a bit more data for the entity

#

However as you can see we no longer would send "test" in type

#

instead we have a header

#

X-TOPGG-TENANCY: "live" | "test"

#

so any payload would be the exact same for webhooks

#

e.g. a test vote would show as a vote

tiny shard Jun 24, 2021, 5:09 PM

#

right right, hm

dense barn Jun 24, 2021, 5:09 PM

#

Just to not break the API though

#

"test" will still be the type in v0

kindred maple Jun 24, 2021, 5:09 PM

#

dense barn cc <@!242351388137488384> <@!301379068941828096> <@!247741991310327810> <@!14240...

One message removed from a suspended account.

dense barn Jun 24, 2021, 5:09 PM

#

but the header will be added in advance

#

ok

#

no pressure

tiny shard Jun 24, 2021, 5:10 PM

#

is there a way to version the webhooks?

#

so we dont have to care abt breaking stuff

dense barn Jun 24, 2021, 5:10 PM

#

we can add a version header

tiny shard Jun 24, 2021, 5:10 PM

#

cant you do something with headers

#

yeah

dense barn Jun 24, 2021, 5:10 PM

#

X-TOPGG-API: v0

#

but I'll have to think more about the design of that

tiny shard Jun 24, 2021, 5:10 PM

#

ye just default to v0 and then libs can implement v1 and just pass the header

#

i thought for the webhook payloads you were gonna do something like...

dense barn Jun 24, 2021, 5:11 PM

#

this is still for v0

#

to expose a little more data

#

most likely for v1 it'll look more like this

tiny shard Jun 24, 2021, 5:11 PM

#

interface WebhookPayload {
  event: string // example bot::vote
  
}```

#

oh got it

#

ok

dense barn Jun 24, 2021, 5:11 PM

#

{
   type: "VOTE"
   body: {}
}

tiny shard Jun 24, 2021, 5:11 PM

#

~~is v1 that far off lol~~