making-mods-general

[latent mauve]

And GMCM's gear icon is still missing on the title screen with the SMAPI update, poor casey. xD

[rain basalt]

my game still saying beta hmm to leave or not to leave

[blissful panther]

Definitely leave the beta branch. It won't switch automatically!

[rancid musk]

My Steam doesn't want to install an update after leaving beta branch.

Very rude of it

[velvet narwhal]

oh yeah i had to do a circleback, it queued twice rather than actually downloading

[rain basalt]

time to wipe mod list and start clean lol

[velvet narwhal]

oh god watching the emotes on the everyone ping

[royal nimbus]

that latest update being out x____x i hope it wont break my mod

[blissful panther]

Yeah, it didn't for me until I forced it to verify the files.

[royal nimbus]

i dont think i have the energy to do a major update anytime soon

[rain basalt]

well space core has update but its not top on download list

[latent mauve]

Spacecore and GMCM 1.6.9-beta files (so, 1.26.0 and 1.14.0) are in Optional Files right now, they'll get moved to Main Files later in Pathos's mod update wave

[rain basalt]

👍

[royal nimbus]

im gonna test it out rn. i was just on the game earlier recording a video

if anyone's interested
https://www.youtube.com/watch?v=TIVRP5T7Gq4

i might cry if my mod breaks lol

[royal stump]

(okay this EMP update is out, enjoy TimeChanged and OneSecond trigger crimes)

[rain basalt]

im just gona blame you if my maps break lol

[thin hamlet]

Whelp ill get around to making sure my mod works when i actually have time

[royal nimbus]

pls pls pls no break D:

[rain basalt]

sigh ranch warp map broken >.> time to fix links

[royal nimbus]

im thinking i might have to test EVERYTHING again now too.

i hate updates lmfao

[tiny zealot]

i'm gonna go make coffee and let off some steam

[blissful panther]

It's mostly/entirely content pack stuff, right? If it is, you should honestly be pretty safe! Any bugs to be fixed are most likely going to be in the hands of the framework authors.

[spice inlet]

1.6.9 is not greeting me kindly

DivideByZeroException: Attempted to divide by zero.

[royal nimbus]

O______O

[pearl junco]

Let the crashes begin!

[velvet narwhal]

yeah i'm turning off all NPC mods right now to see if it's specifically custom NPCs

[tiny zealot]

custom spouse rooms might be the crash dimension right now (mine is!)

[velvet narwhal]

all of my NPCs are crashing too

[rain basalt]

lol this why i was testing beta early ( spouse rooms being worked on )

[royal nimbus]

okay things are looking good according to smapi so far OTL

[blissful panther]

I don't know, I like my spouse rooms divided into zero.

[royal nimbus]

NEVERMIND

[velvet narwhal]

but spacecore threw an error, so i'm looking into that instead

[lucid iron]

I think the maps fix is supposed to be in smapi right

[rain basalt]

it might if you hit esc

[lucid iron]

Rather than base game

[royal nimbus]

my mod isnt showing up. maybe just update the versions.. lets see

im gonna have to release an update after all for sure. damn

[tiny zealot]

it might not have made it in

[iron ridge]

is [18:24:03 TRACE SMAPI] Content Patcher edited ... logged for all changes by content patcher?

[velvet narwhal]

divide by 0 happens on the 4.1.0 just released smapi, yeah

[lucid iron]

Yeah

[royal nimbus]

</3

[rain basalt]

just remember gotta give modders a few days (months) to fix everything

[lucid iron]

It's always been like that I think, I often go look for that in modded support

[iron ridge]

oh its only when theyre loaded

[lucid iron]

And invalidated

[royal nimbus]

dumb question but what do we put for the version now? <__>

[lucid iron]

Ralo you can leave ur content pack alone tbh

[rancid musk]

Now the question is, do I update the decomp repo now or do I hold off a day expecting an emergency patch to the game because something somewhere will have broken

[velvet narwhal]

your personal mod version does not matter

[rain basalt]

what version ?

[royal nimbus]

no i cant

[rancid musk]

Got all my updates up and they... appear to work

[royal nimbus]

its broken

[lucid iron]

I think that's not u rn but whole maps system

[velvet narwhal]

your content pack is fine, it's currently something you can't control, it's quite literally all custom npc spouserooms from what i can tell

[royal nimbus]

its no longer even reading my mod

[blissful panther]

Honestly, Khloe, I would wait off on the decompile repo.

I'd be shocked if there weren't some tiny patches.

[royal nimbus]

dying honestly

[velvet narwhal]

take a walk, come back once pathos pings

[royal nimbus]

i hope i wont have to rearrange files. thats always the WORST

[royal stump]

I appreciate the repo updates whenever they happen, but I'm gonna sleep after this either way

[royal nimbus]

[rain basalt]

ok no red so far

[next plaza]

My hiatus might last longer than I originally mentioned - unsure how long at this point

[ivory plume]

(It can be useful to see what changed in the emergency patch too.)

[royal nimbus]

this is what im wondering what to change to first off. idk since its not the same as the game <___>;;;

[latent mauve]

GMCM gear is still invisible, is that fix going in a later build of SMAPI, Pathos?

[rancid musk]

(This is very fair.)

[latent mauve]

Or did I download a wrong version somehow?

[royal nimbus]

i finally get the term 'gutted'. me rn x__x

[ivory plume]

I'm not sure why; I'll look into that (and any other issues) after the initial update wave + work.

[rain basalt]

welp >.> thats broken lol

[ivory plume]

(Technically I'm on lunch break at work.)

[velvet narwhal]

it's not spouserooms, it's tmxes isn't it

[blissful panther]

Where's the most current GMCM commit/branch?

[velvet narwhal]

https://smapi.io/log/1ebfa26db138469fbdcfb5a3ba5abd3d (i'll also throw this in the support channel in a sec, but upon further inspection, it throws the dividebyzero exception for the 'editmap')

[ocean sail]

Log Info: SMAPI 4.1.0 with SDV 1.6.9 build 24309 on Microsoft Windows 10 Home, with 25 C# mods and 1 content packs.
Suggested fixes: One or more mods are out of date, consider updating them

[latent mauve]

oh, wait, you meant on Github

[blissful panther]

[latent mauve]

I deleted my message because I directed you to NexusMods Main Files section by instinct, but you meant Github. >_>

[blissful panther]

Okay, looks like it's just in the main branch.

[latent mauve]

Sorry

[tame anchor]

https://smapi.io/log/67949483c6b84015b54df7c0fad0083c I'm sorry to bother you. May I ask what caused this?

[ocean sail]

Log Info: SMAPI 4.1.0 with SDV 1.6.9 build 24309 on Microsoft Windows 10 专业版, with 16 C# mods and 19 content packs.
Suggested fixes: One or more mods are out of date, consider updating them

[rain basalt]

well greenhouse mod works but farmhouse mod broke

[blissful panther]

You're good, pings don't bother me!

[velvet narwhal]

i have attempted my narrowing, i take a breakfast break

[rain basalt]

welp custom cellars broke the game

[tiny zealot]

only my spouse room crashes the game. until this update lacey's house worked fine (at this point, it still loads but the camera is locked way off center when i warp to it so i'm not sure what's going on there

[rain basalt]

hmm strange if it draws the map after the fact it crashes but if the map is loaded pre draw the camera breaks and you cant see past entrance

[old edge]

Hello would anyone be able to demonstrate how to do hourly ambient lighting update in C# for a map.

[velvet narwhal]

yeah, i tested with just a singular tile editmap and it threw the dividebyzero, so it has something to do with that

[rain basalt]

i could with CP lol

[royal nimbus]

what are the first steps to take to get a mod working again for an update? im at a loss

[velvet narwhal]

again, literally nothing you can do right now, this is a deeply internal problem and your content pack is fine

[royal nimbus]

oh okay

[tiny zealot]

i can give you one that operates smoothly via UpdateTicked but that's all i've got (i use it temporarily, in an event, and don't recommend using UpdateTicked in general)

[rain basalt]

this the CP version but i have time range set
"Action": "EditMap",
"When": {"House Lights": "true", "Time": "{{Range: 0610, 2600}}" },
"Update": "OnTimeChange",
"Target": "Maps/FarmHouse",
"MapProperties": {
"AmbientLight": "20 20 20",
"AmbientNightLight": "20 20 20",

[royal nimbus]

so will it start working again soon or something?

[tiny zealot]

hopefully. holding pattern for now though

[old edge]

Oh Im not sure if the CP version would work on a farm? Right

[spice inlet]

Hm, the game seems to crash with specific custom farm types installed like Personal FarmType.
Considering that's not the only type it's probably a more general problem

[old edge]

Been working on a ambient light method. I basically been trying to take the code from islandforestlocation.cs and inject it into my farm map.

[rain basalt]

not sure but since im targeting the map file ambient data it seems to work for me

[royal nimbus]

im kinda glad i got my mod finished before the update came out because i wouldnt even be able to work on it anymore rn

[rancid musk]

Decomp why are you doin this to me, lol

[rain basalt]

yah Ralo my cellars are 100% messed up

[royal nimbus]

X___X HAAAAATE updates. ive always known they're the modders worst nightmares since back when i was into modding minecraft

[faint ingot]

I think there were some changes to spouse rooms/patios in 1.6.9 but I can't find them in the mod migration guide, and my 1.6 spouse rooms are rendering from the wrong tileset. Can anyone point me to the doc or an example of what I need to change?

[rain basalt]

spouse rooms have issues due to a draw error

[old edge]

oh no mods are breaking

[rain basalt]

just wait a little lol there working on it

[old edge]

I barely updated to 1.6.8 yesterday

[royal nimbus]

ohhhhhh nooooo.... im gonna have to redo rooms then in tiled... ugh x___x

[iron ridge]

is contenthashes.json only for PC?

[old edge]

I will try and post my code

[latent mauve]

I'm trying a quick swap to tbin from tmx and gonna see if that gets past the error for the moment

[old edge]

I think there might be bugs

[velvet narwhal]

tmx will still give you the error https://smapi.io/log/98b068bc202647fbb7ccd9c917643f67

[ocean sail]

Log Info: SMAPI 4.1.0 with SDV 1.6.9 build 24309 on Microsoft Windows 10 Home, with 4 C# mods and 1 content packs.

[velvet narwhal]

op sorry for the ping

[latent mauve]

Avi, I'm saying I'm gonna try to use a tbin and NOT a tmx 😛

Since TMX is the error

[velvet narwhal]

i'm checking now if it's specifically the editmap patch or if it's in general

oh i thought you meant you were going from tbin -> tmx

[calm nebula]

Anything with tmxtile is problematic rn

[spice inlet]

atra to the rescue ^^

[rain basalt]

odly enough my ranch loaded >.> but not the warp map

[stone crypt]

Anyone else experiencing this? After the 1.6.9 update some cutscene events in custom locations have the camera start at the 0, 0 position, regardless of the viewport x y command

[tiny zealot]

yeah the camera in mine is locked at 0,0 in normal gameplay now.
(note that before, if your location fit entirely in the viewport it would center the camera regardless of viewport x y)

(funny story, the camera works in events in mine, probably because i patched the fits-in-viewport behavior when events are running on my map)

[latent mauve]

okay, so confirmed, my EditMaps work with all the TMX files swapped to TBIN

no red errors with a DivideByZero

[clever sinew]

@mellow gate apologies for the ping — can i potentially dm you about tasty treats?

[stone crypt]

Normal gameplay? Not during events?

[mellow gate]

@clever sinew Oh, yes, go ahead.

[old edge]

Tbin still good

[tiny zealot]

yeah. not an issue in the beta builds, only release 1.6.9/4.1.0

[stone crypt]

The viewport move command still works though

[stone crypt]

What do you mean by this?

[tiny zealot]

i mean for my mod specifically i patch the game code to fix undesirable camera behavior in events on my custom map. i suspect that without that patch, i would get the same behavior as you

[stone crypt]

Is this a mod or something you wrote?

[tiny zealot]

both. my mod

(this is the patch in question, for the curious https://github.com/ichortower/HatMouseLacey/blob/main/SMAPI/Patcher.cs#L329)

[stone crypt]

Ah, you're the creator of the Hat Mouse Lacey mod? Pleased to meet you.

[tiny zealot]

guilty (nice to meet you, too!)

[royal stump]

suddenly, 4 posts about the divide by zero bug & one about AT for some reason

[velvet narwhal]

i am ignoring any and all issues regarding dividebyzero until a public notice has been released

[stone crypt]

Yeah, you're right if the map fits in the viewport it shows normally:

but if not it shows this:

[tiny zealot]

right now i'm just trying to remain chill before i leave for about six hours. when i come back maybe there will be something i can do

[velvet narwhal]

(tbf i gave out a lil mini notice to my own little niche following: )

Do not bother posting about it to mod authors, we know```

[latent mauve]

I put a brief note in modded-farmers just now, feel free to copy/paste it.

[rancid musk]

Hmm. This is a fun bug. There are absolutely zero changes to SkiaSharp in the decomp, and yet

[latent mauve]

this one

[rain basalt]

na im not investigating im twiddling my thumbs waiting on pathos

[latent mauve]

It was me, I investigated by changing my TMXs to TBINs.

[rancid musk]

I actually don't know why the heck it's trying to use Utils.AsSpan because that applys to an IntPtr and I have a byte[]

[rain basalt]

i use rotated tiles >.>

it just looks nice

[stone crypt]

I think it works becaus the map fits the screen

[cyan marsh]

we get new SDV patch today?

[latent mauve]

Oh, I agree. I just happened to have one of my map files that doesn't use rotated tiles to test with.

[rain basalt]

lol thats a 1.6.8 screen shot

[cyan marsh]

<.< wat

[blissful panther]

1.6.9 on PC, and 1.6 in general on consoles/mobile!

[rain basalt]

it doesnt load anymore in 1.6.9 and when it did the camera doesnt move

[cyan marsh]

ah

[old edge]

So tmx is broken or something

[rain basalt]

for now yep

[old edge]

Wow that's like every mod

[cyan marsh]

best check my stuff then

[stone crypt]

Is this something we need to fix (I dunno, add a map property) or is it been looked at?

because the vanilla game also uses tmx

[old edge]

I think it's most likely a bug

[blissful panther]

This kind of thing is likely to be 100% out of everyone's hands. It'll either be a SMAPI, CP or game fix.

[latent mauve]

Yep

[old edge]

I won't update then

[stone crypt]

Great! 🥶 I won't be able to continue working on my mod for now...

[old edge]

Stayin on 1.6.8

[lusty halo]

...uuuh I have steam so it directly say "update", can I use the desktop shortcut to open the game or will it auto update?

[tiny zealot]

the bad news is, it's out of our hands to fix. the good news is, it's out of our hands to fix.

[mellow gate]

Okay, so the divide by zero thing is something I can't deal with. Ah. Alas.

[iron ridge]

the desktop shortcut, if done via steam, just runs via steam

[cyan marsh]

you can tecnically not use steam to run the game

[iron ridge]

if your shortcut is actually to the file, not a internet link via steam, then you can

[blissful panther]

Also, friendly reminder for...

!revert

[ocean sail]

If you are looking to downgrade to 1.5.6 for the last working mods while people are updating their mods, please follow the following instructions:

• Install .NET 6 or later.
• Download the latest DepotDownloader release.
• Open a command prompt in the DepotDownloader folder.
• Run one of the following commands (replace <username>/<password> with your Steam login, being prepared to enter a 2FA code if you have it enabled):

• On Windows:
  dotnet DepotDownloader.dll -app 413150 -depot 413151 -manifest 5609262347030774375 -username <username> -password <password>

• On Linux:
  dotnet DepotDownloader.dll -app 413150 -depot 413153 -manifest 5898757968212855302 -username <username> -password <password>

• On MacOS:
  dotnet DepotDownloader.dll -app 413150 -depot 413152 -manifest 7794216274031597899 -username <username> -password <password>

• Launch Stardew Valley.exe in the downloaded folder.

To use this command, type !revert.

[blissful panther]

Just in case.

Though the manifest ID will be 1777024427851858279 for 1.6.8 on Windows.

[latent mauve]

I mean, technically, if your mod uses TMX and you can swap to TBIN, that would avoid the issue for the moment, but, probably better to just wait for SMAPI or CP to update with a fix.

There are many reasons why TMX was preferred, after all

[finite meadow]

Hello! hope you're doing good! just got back from vacation, glad to see you're still around helping here!

[mellow gate]

I have no idea what uses TMX on mine, probably HxW Tilesheets? Or all of Expanded, who knows.

[cyan marsh]

Looks like Event Repeater works fine

[old edge]

Launch the game from the StardewmoddingApi executable to bypass opening steam and updating

[wanton pebble]

Remind me in 4 hours to update this

[patent lance]

mmmmmmmmmmmmmmmmmmmmmaybe (#6343246) (4h | <t:1730762431>)

[lusty halo]

yeah I was about to try that.

[wanton pebble]

Thanks Maru's Robot

[velvet narwhal]

maru on strike, we all on strike

[latent mauve]

I think HxW Tilesheets is just .png file types.

[calm nebula]

You can send Pathos a PR

[tiny zealot]

nah i have to leave in about 10 minutes. maybe tonight

[mellow gate]

Yea, I just don't know what is using TMX other than Expanded probably, then.

[blissful panther]

I can do it now if you'd prefer!

[wanton pebble]

If you do just let me know you did

[brittle ledge]

Most things, probably

[mellow gate]

Okay. I'm just...going to go get lunch.

[brittle ledge]

The community mostly moved to TMX/away from TBIN during 1.5, I believe.

[rain basalt]

yah tmx alowed for more custimization

[tiny zealot]

about two hours ago, i would have said tbin provides no (meaningful) advantages over tmx

[brittle ledge]

Doesn't TMX have slightly better performance?

[velvet narwhal]

(i think it's smapi)

(no dividebyzero on the beta smapi)
if you're curious https://smapi.io/log/277be58c63c1485abbd21ccc95b8e817

[royal stump]

afaik (not much) it's just the better option here, aside from the current specific bug

[tiny zealot]

it might. tbin is binary and so usually takes less disk space, but the absolute sizes are small so file size is almost never relevant

[tiny zealot]

smapi was supposed to get the 64px tilesize fix instead of the base game, but i suspect something went wrong in the merge to release and caused this instead

(speculation! asserted without evidence!)

[velvet narwhal]

i'm very glad i'm a hoarder, i have like 6 smapis

[rancid musk]

(The elites don't want you to know this but the SMAPI at the GitHub is free you can download them I have 458 SMAPIs)

[deep cypress]

Apparently, Farmer.checkForQuestComplete has changed, I cannot find it in the documentation tho

[tiny zealot]

(someone who's good at modding help me budget this. my family is dying)

[rancid musk]

https://stardewvalleywiki.com/Modding:Migrate_to_Stardew_Valley_1.6.9#Quest_event_revamp

[brittle ledge]

Slightly fewer SMAPIs

[tiny zealot]

no

[velvet narwhal]

wait all the smapis? damn i have a use for my external drives then

[rancid temple]

Let them go, they would want you to have this

[deep cypress]

THanks Khloe!

[lusty halo]

I remembered the old trick with different mods folders each with its own SMAPI load, and yes it stays 1.6.8. I can still test my things while they fix the bug since it may cause several mods to be updated again once fixed.

[blissful panther]

Oh, looks like someone beat me to updating the command.

[mellow gate]

I believe I am just...waiting now for...the divide by zero to get fixed.

[blissful panther]

(I blamethank you, @haughty charm!)

[haughty charm]

[mellow gate]

good luck little chicken!

[calm nebula]

Worse lol but it's more flexible

[rancid musk]

... I think ILSpy is drunk.

Actually I think the compiler was drunk too I have no freaking idea what it's trying to do looking at the IL.

And switching to a newer ILSpy didn't make things better. I'll just add this to a list of things to ask Pathos about later.

[teal bridge]

What's the issue?

[rancid musk]

The issue is that the above code doesn't make any sense and doesn't even compile. (I am working on updating the decomp repo.)

[rain basalt]

everything

[teal bridge]

Hm, there've been bugs with byref types in ILSpy in the past but those were generally resolved years ago.

Where's this code even from?

[lucid iron]

netdictionary

[teal bridge]

Was just looking in there as it's the only place where I found TSerialDict, but the 1.6.8 version is not even close to that...

[lucid iron]

roslyn is moody

[blissful panther]

https://github.com/Pathoschild/SMAPI/compare/f2cf0a3125b5a66035157a2745a1d1bf3d3cd774...7a91eeebe21c5032c661905364126c823501aa55

So, so many changes in SMAPI between the seemingly working 4.1.0-beta.5 and the release.

[calm nebula]

It's fuckkng tmxtile

Fuckifn tmxtile

[blissful panther]

I am not shocked.

[calm nebula]

I'm pretty sure I know what when I get off work in like 5 to 6 hours

[blissful panther]

If you know a rough file, I can have a dig myself between now and then!

[golden spire]

eek

[rancid musk]

This is some outstanding code gen from ILSpy csharp IList<object> GetPath() { return ForEachItemHelper.CombinePath(((_003C_003Ec__DisplayClass4_0<TItem>)this).getParentPath, ((_003C_003Ec__DisplayClass4_0<TItem>)this).list); }

That type... doesn't exist. And this is in a static function so this also doesn't exist.

[blissful panther]

...wow.

I... wow. Yeah, ILSpy is having a bad time.

Which file is this in, and is this for the latest build?

[rancid musk]

That's StardewValley.Internal.ForEachItemHelper

And yeah, it's for the release build.

[blissful panther]

Huh. So I tried dotPeek, and it isn't even generating that method at all.

[rancid musk]

ILSpy really isn't good at delegates.

[blissful panther]

The only things I'm getting are d-

Yeah.

IList<object> GetPath() => ForEachItemHelper.CombinePath(getParentPath, (object) field);

[rancid musk]

All these? Delegates.

[teal bridge]

Some of those error codes, I didn't even know existed.

(Like CS8374)

[rancid musk]

Oh wow this is straight up garbage ILSpy

The heck

[teal bridge]

You'll have to just rewrite it yourself and pray.

[blissful panther]

I'm actually shocked dotPeek is doing better here. I've normally found it to be fairly noticeably worse.

[royal stump]

so about the tmx thing, I poked both xTile and SMAPI with WinMerge out of insomnia curiosity, and the closest relevant bit I noticed is this in SCore.cs

//SMAPI beta5:
FormatManager.Instance.RegisterMapFormat((IMapFormat)new TMXFormat(16, 16, 4, 4));
//SMAPI release:
FormatManager.Instance.RegisterMapFormat((IMapFormat)new TMXFormat(16, 16));

which just looks like this in the original C# for both, I think

// init TMX support
xTile.Format.FormatManager.Instance.RegisterMapFormat(new TMXTile.TMXFormat(Game1.smallestTileSize, Game1.smallestTileSize));```

[teal bridge]

Well, I guess you don't have to pray, you can check if the rewritten version compiles down to the same IL.

[royal stump]

there are random changes elsewhere regarding tilesheets and in xtile versions, but nothing stood out at a very tired glance

[rancid musk]

1.6.8 code: ```csharp
case "1":
fruitTree.treeId.Value = "629";
break;

1.6.9 code: ```csharp
    case '1':
        goto IL_0112;``` then ```csharp
IL_0112:
    fruitTree.treeId.Value = "629";
    goto IL_01ad;```

[velvet narwhal]

(i was curious about the smallestTileSize and it's set to a const int 16 )

[rancid musk]

What happened to you ILSpy why are you doing this

[royal stump]

yeah, it converts to 16 in the code, but for some reason tmxtile(?) is using a different constructor that might be setting tile size multiplier to 1 instead of 4, if I read it right

[lucid iron]

oh i dont have that one, it seems like the switch on string thing atra mentioned

[royal stump]

not sure how that gets to a 0 height/width tilesheet in SDV, but it's odd

[velvet narwhal]

ilspy is definitely on strike

[brittle pasture]

I think I got the latter code a bunch of times (including that spot) in ilspy even in 1.6.8

switch case compiler optimization is taken from the pages of the necronomicon

[teal bridge]

Has the IL itself changed a lot? Pathos mentioned AoT stuff, I wouldn't expect it to change IL to any significant degree but maybe there's something going on there.

[brittle pasture]

I do know one function switching from regular ol local variables to capture classes even though nothing in the code changed

coughsclickCraftingRecipecoughs

[calm nebula]

Android only

[blissful panther]

@royal stump (who figured out the SMAPI problem)! Just replace SMAPI 4.1.0's StardewModdingAPI.dll in your Stardew folder with this version for now.

[haughty charm]

Thank you, Esca!!!

[royal stump]

(I don't actually have any mods erroring & am gonna go sleep for real this time, but nice~)
(also i interpreted that as "hey esca, i figured it out" rather than "esca figured it out"?) (tired! )

[rain basalt]

well that one loads gmcm on main menu lol

and maps are fixed

[brittle pasture]

I read up on what is AOT and yeah, if Android modding isn't dead before it's certainly bones and dust now

[rain basalt]

should we poke pathos lol

[proven vigil]

That fix works! Thank you @blissful panther

[blissful panther]

Super simple one line change for Pathos to make, at least!

[tepid escarp]

Is there anyway to get this for Mac please? ❤️

[proven vigil]

Yeah happy it's a simple fix

[velvet narwhal]

pathos probably knows, let him enjoy his lunch

[blissful panther]

This should also work for Mac and Linux!

[proven vigil]

What's the specific fix?

[tepid escarp]

Just tried it and gave me red text saying it’s for windows and won’t work for Mac

[blissful panther]

#making-mods-general message

[faint ingot]

mine still has messed up spouse room textures but I could be doing somethign wrong

[royal stump]

the pathos-side C# code didn't change, but it started using a different construction method for TMX maps that I think is setting tile size multiplier to 1 instead of 4

because the default "make a tmx format" thing shifted, I guess (possibly due to xTile updates)

[blissful panther]

Huh... let me just generate an installer like it would for a proper release instead. Shouldn't be too long!

[tepid escarp]

Wait it’s telling me it’s for Mac and Linux and I’m on windows, but I’m on Mac. Man I hate computer stuff 😦

[tender bloom]

can you screenshot the error?

[naive gyro]

at least you got that far, i'm also on mac and can't even figure out where to put the file

[brittle pasture]

You're just unzipping that file into the directory right

what would the error be like

[rancid musk]

(Reminder if you generate an installer and have a -whatever flag in the version because it's unofficial, make sure you bump the version from 4.1.0 to 4.1.1 or every mod with a minimum version of 4.1.0 is gonna not load.)

[blissful panther]

You should be running the StardewModdingAPI.exe. You'll need to install 4.1.0 from https://smapi.io manually first.

[tender bloom]

I mean DH's full thing should fix it but I'm surprised the error messages are that specific on mac vs windows

Maybe I've just never done this

[rancid musk]

I'm gonna stop on the decomp for the moment. I cannot with ILSpy's nonsense.

[calm nebula]

No this feels like the fix to the custom spouse rooms breaking

If this is beta 5 tell people to use beta 5

[frail elm]

Are CP mods going to keep working as usual?

[rain basalt]

yes and no some new fields will need to be added to some mods

[calm nebula]

Please hold for twenty four fucking hours

[royal stump]

didn't realize they're different problems, every log i happened to see was the same div-by-zero thing
(rapidly fading, gl to whoever's seen that part)

[calm nebula]

Things should be fine.

[deep cypress]

What the fuck I'm divifing by zero too

[calm nebula]

Twenty fjcking hours from now

PLEASE DO NOT ATTEMPT TO PLAY MODDED AT ALL RIGHT NOW

[rain basalt]

#making-mods-general message

[calm nebula]

Fucking tmxtile

Completely BS

[velvet narwhal]

i didn't think they were different problems either, but DH's/Esca's fix worked https://smapi.io/log/060c162de83a480f8694ef147ff9ed7b

[ocean sail]

Log Info: SMAPI 4.1.0 with SDV 1.6.9 build 24309 on Microsoft Windows 10 Home, with 29 C# mods and 8 content packs.
Suggested fixes: One or more mods are out of date, consider updating them

[frail elm]

I am sure all the mod makers are scramblign right noe

[rain basalt]

actualy we not lol we taking it slow watching the chaos getting lunch and coffee

[tender bloom]

Eh some of them are scrambling

I'm not

It's going to be fine

[uncut viper]

(im scrambling to figure out a bug/incompatibility (not a smapi one a "between mods" one) with my 1.6.8 mod...)

[deep cypress]

Whar's Esca's Fix?

[royal stump]

replace this DLL or use smapi's beta-5 if needed, Apryll

[rain basalt]

download the file and replace it

[royal stump]

hope I didn't ping, sorry if so, in bed now

[tame anchor]

Please ask my partner room is still confused, what is the cause.T T

[tender bloom]

The cause is within the C# parts of SMAPI — there's a place where the code is using the wrong numbers

Esca found the part with the wrong numbers, and DH made a new version with the numbers corrected

But it's not officially fixed yet

[wise berry]

Ask in #1272025932932055121, but most probably it's the problem with SMAPI that's currently being fixed as MathPerson has said

[tender bloom]

When Pathos gets a chance (because he's an adult with a job), I am sure he will release a fix

[tame anchor]

Thank you !

[wise berry]

If you want terribly to play modded stardew now, you'll have to downgrade to 1.6.8

[tender bloom]

There's a part of the code that deals with maps that's bad and annoying that got a little bit messed up

[golden basin]

does anyone understand how to do the space core thingy to add buffs to rings? ive been trying to do it and its not quite working for me

[spice inlet]

[rancid temple]

Time to disable comments

[spice inlet]

I mean to be fair I already have the 1.6 release ready, just spending my time playing games than quickly testing and uploading them 🙃

[tender bloom]

I'm not familiar offhand but post your json and mayve someone can take a look?

[golden basin]

okay ill do that

[ivory plume]

Did you just re-add the tile size premultiplication (i.e. the 4, 4 bit when initializing TMXTile)? That'll break TMX patches if so (e.g. spouse rooms). I'll look into what changed between the beta and release.

[tender bloom]

smapi.io/json link please?

[golden basin]

oh okay sure

[golden basin]

https://smapi.io/json/none/d1c78b029329461cb190008c62ad96d8

[blissful panther]

Yup! Just used the previous version's constructor.

See: #making-mods-general message

[ivory plume]

At least it won't crash, but it'll lead to fun patches like this:

[velvet narwhal]

oh that break

[proven vigil]

it's almost kinda of a room

[tender bloom]

Can you describe what's going wrong? I don't see anything obviously wrong

[rain basalt]

but for some reason it fixed the other map breaks

[lucid iron]

what if you put 1, 1

[blissful panther]

It's a room of nightmares for sure.

[tender bloom]

I would be scared to walk into that room 😂

[rain basalt]

abigail lol

i think shes crying

[brittle pasture]

that's me during home renovation

[proven vigil]

at least she has half an arcade sign here and there

[tender bloom]

more than one whole arcade sign total!

[sweet sphinx]

So, when should I update my game & smapi now that the updates are out? (Are both updates out?)

[teal bridge]

Well, that's weird. I didn't even update anything, but as of this morning, SDV (1.6.8) freezes on startup, stuck on some wait handle somewhere.

[rancid temple]

Stuff's broke right now

[teal bridge]

Is anything in there capable of auto-updating?

[tender bloom]

wait 24 hours and check back maybe

[sweet sphinx]

Good to know, gonna wait on them then

[tender bloom]

the game will probably auto-update on you

[teal bridge]

No, I use GOG, not Steam, so it hasn't auto-updated (and clearly says it's 1.6.8 in the SMAPI window).

[ivory plume]

Well, this isn't right.

[calm nebula]

Looks like my room. Perfect!

[teal bridge]

I see the update but haven't installed it. And yet... broken.

[tender bloom]

huh....very weird

[sweet sphinx]

I removed my game file from Steam's folders so Steam would not open when I ran the game(I have a potatoe, so Steam being open as well, the memory hog it is), and I don't otherwise open Steam unless I need to update smth

[ivory plume]

So there's a bug with TMXTile where omitting the optional premultiplication argument defaults to (1, 1)... but not fully. I'll release SMAPI 4.1.1 soon.

[rain basalt]

[tender bloom]

what a fun bug

[proven vigil]

great work pathos!

[sweet sphinx]

Tbh I wish I could trade my steam copy of the game for a non-steam copy

[velvet narwhal]

? there's no drm, unless you meant console

[haughty charm]

Thank you, Pathos! You are amazing.

[rancid musk]

(I miss when GOG had that thing that let you unlock games you already owned on Steam for some games.)

[sweet sphinx]

Drm? Nah I just mean I hate having games on steam

[teal bridge]

(It's freezing in GraphicsDevice.PlatformPresent after the title screen shows. WTF?)

[brittle pasture]

still nothing stopping you from making a copy of the SDV folder and store it in your eternal RAID array

it has no DRM, not even Steam's bare minimal one

[calm nebula]

We love you, Pathos!

[golden basin]

the buff just isnt applying in game when i wear the ring. the icon for it isnt appearing or being applied

[sweet sphinx]

Yeah, but how would I update it then?

[brittle pasture]

ah fair

[lucid iron]

just setup automatic sdv archiving system

[brittle pasture]

but that would apply even with GOG right

[lucid iron]

wonder if anyone did this for every nightly beta build

[sweet sphinx]

But does GOG's app run while the game is running?

[tender bloom]

Try adding (R) to the item ID?

It looks like Spacecore docs say qualified item ID

[velvet narwhal]

depending on what broke, i did have like 5 different decompiles

[brittle pasture]

you can run SDV without Steam, just execute the binary directly

[tender bloom]

https://smapi.io/json/none/832fe3df801047d09363c36a5f02756f like this

[golden basin]

if its that simple i will eat my hands

[lucid iron]

take your rings off before you eat your hands

[golden basin]

that didnt work either himmm

[sweet sphinx]

Funfact, b4 I moved the whole Stardew folder out of Steam's, even running the exe file(with a shortcut) would make Steam open and run in the background

[final arch]

is there an issue with mods patching maps in 1.6.9?

[brittle pasture]

Yes

[final arch]

nice

[velvet narwhal]

we wait on smapi 4.1.1

[rain basalt]

pathos on it

[latent mauve]

It'll be officially fixed in SMAPI 4.1.1, but there's a temp fix

[final arch]

@Flip and @Rotation?

[sweet sphinx]

I assume it was for Steam's achievements and onlineplay(unless I can still co-op w/o Steam?)

[velvet narwhal]

dividebyzero xTile

[final arch]

ah good

was wondering how RSV causes this

[brittle pasture]

I don't have the game on Windows but I'm about 60% sure there's another binary that starts the game directly, and the binary you're running hooks to Steam before running that one

[lucid iron]

you need to start StardewModdingAPI i think

rather than the exe

[sweet sphinx]

SMAPI would also open Steam in the background

[lucid iron]

it doesn't, not unless you have steam already up

[sweet sphinx]

After moving the whole folder out of Steam's folder, it no longer does that

[clever sinew]

if you put steam offline then use smapi, it should work normally

(it is for me, at any rate)

[sweet sphinx]

idk, I just know how Steam works for me ¯_(ツ)_/¯

[tender bloom]

Are your rings definitely type (R)? Have you checked the qualified item ID? (Potentially with Lookup Anything). You can use patch export on the spacecore dictionary make sure it matches exactly.

[velvet narwhal]

which one? graveyards? i can go back to debugging

[golden basin]

let me take a look

[rancid musk]

Users are the best, a story in three parts.

[rain basalt]

lol

[clever sinew]

[wanton pebble]

Wait how do you get to that third screen

[velvet narwhal]

page stats iirc?

[rancid musk]

Manage menu on a user's comment.

[wanton pebble]

TIL. Thank you!

[whole raptor]

Knowing Nexus, it probably updates once an hour

[golden basin]

It matches yeah im not sure whats wrong with it

[brittle pasture]

dang, didnt know you can bring Receipts™ against someone on Nexus

[uncut viper]

its graveyards yeah, specifically when on v1.6.8 tho (bc its still broken in 1.6.9 ofc) and im mostly confident its just from some mod in the mod list in the log i was given since it all works fine for me

[lusty egret]

Better Chests Mod is Broken with 1.6.9? Getting "Method 'get_IsLocalPlayerInventory' [...] does not have an implementation."`
Wanted to look into it myself, having never modded for SDV before though.
What confuses me, looking into git, I could not find anything that is written like "IsLocalPlayerInventory" in the code? Anyone any ideas what happens there, where this comes from?

https://smapi.io/log/e669de5ccc724a2698660c098ed2c57c

[brittle ledge]

!log a log would probably help Khloe better

[ocean sail]

Important note: Your computer username may appear in the log. If your username is your full name, please be aware of this before uploading it.

Please share your SMAPI log file. To do so:

1. Open this page: smapi.io/log.
2. Follow the instructions at the top of the page to upload the log file. (Don't copy & paste from the console window!)
3. After uploading, it will show a green box with a URL to share. Post that URL here.

Please do it even if you don't see any errors. This has useful info like what mods and versions you have, what the mods are doing, etc. If the issue didn’t occur in your last session, please load the game to the point where the issue occurs, then upload the log.

To use this command, type !log.

[tender bloom]

Do you know of any working mods that use this feature? You could also try with a buff that's just vanilla out of Data/Buffs maybe?

[rancid musk]

(Better Chests is Matt, not me.)

And that error is because Better Chests has custom IInventory implementations, and the game modified that interface in 1.6.9.

[golden basin]

I dont know anyone who uses it but ill keep an eye out

[brittle ledge]

How dare you people all use "Better" monikers and confuse me like that

[rancid musk]

I didn't think people would download my mod if I called it Overengineered Crafting Menu Replacement

(This is a joke. Better is just an easy name to use.)

[rain basalt]

fixed mod breaks mod fixes mod again watches it all crash and burn

[blissful panther]

Smart Building was originally Better Building.

[brittle pasture]

what about Immersive Crafting

[rancid musk]

There's nothing immersive about Stardew's crafting system lol

[velvet narwhal]

tis all hellfire 'round here

[rain basalt]

https://tenor.com/view/chaos-gif-22919457

[ruby rapids]

Well, from the looks of things it would be better for me to just wait to play SDV or roll it back to its previous edition. I was wondering if I wasn't the only one having problems. But it seems like everything is on fire. LOL

[rain basalt]

smapi 4.1.1 should fix it

[deep cypress]

Looks like Rings doent have UniqueId anymore

[fierce dagger]

what is the motive of this?

is the current smpai version bugged?

[lucid iron]

yes, this is a temp fix

until smapi 4.1.1 comes out properly

[blissful panther]

It fixes the crashing, but that's about it.

[ivory plume]

(You can ignore that file if you don't get a crash loading your save.)

[ruby rapids]

Darn, the fix didn't work for me. I guess I am going to have to wait on this. How much of a pain is it to roll back to a previous version?

[lucid iron]

what are you hoping to do

[fierce dagger]

ohhhhhh

[ruby rapids]

Just play my game as I wait for all the modding fires to be put out.

[blissful panther]

Not very: https://www.nexusmods.com/stardewvalley/mods/2400?tab=files&file_id=113649

[fierce dagger]

i guess im going to stop doing my updating sequence

ill wait

[blissful panther]

That's the last known non-breaking version.

[ivory plume]

SMAPI 4.1.1 is released with the spouse room crash fix.

[latent mauve]

Pathos spoiling us with that quick hotfix turnaround

[rain basalt]

looks at time stamp from last night hmm i guess within 24 hours is quick lol

[blissful panther]

(Wait a bloody minute... you can do BBCode in the file description?!)

[uncut viper]

takes up hella character count tho

[rain basalt]

maps broken again @ivory plume

[lucid iron]

i think ViewportFollowPlayer got changed

[golden basin]

got it working its (O) not (R)

[ruby rapids]

Thank you! (My game is starting now. 🎉)

[rain basalt]

no error log >.>

[uncut viper]

(editing in a ping wont ping them btw)

[rain basalt]

i know lol

[ruby rapids]

(😂 I have so many red errors in smapi but I am hoping by updating my mods most will go away... I hope)

[teal bridge]

What's the "for developers" installer?

Never noticed that before.

[uncut viper]

verbose logging iirc

[lucid iron]

it just makes trace print to stdout

[lucid iron]

if you put map property ViewportFollowPlayer T then it should temporarily get fixed

[rain basalt]

is this a new map property or just one to force the fix?

[lucid iron]

temp fix

i dont think u normally want that for a small location like cellar

[rain basalt]

O >.> its not always small

[deep stag]

hey i play with a bunch of mods but a lot of them dont work anymore with 1.6.9, is there a fix for this or do i have to wait for the mods to update?

[rain basalt]

i have a max map cellar

[lucid iron]

well if it's big then u probably want it

so that the camera can follow player

[haughty charm]

Hey, there! This channel is for making mods. Please be patient and wait for mod updates. #modded-stardew

[rain basalt]

ill start adding just as a habbit to prevent issues

[deep stag]

oh whoops sorry

[haughty charm]

All good.

[rain basalt]

download new smapi CP and update everything and pray

[ivory plume]

Does this only affect custom locations, or are there vanilla locations affected too?

[ruby rapids]

I'm kind of a newbie in this mod making thing. I notice that everyone is updating their mods since the update. Where can I get info on what needs to be updated in a mod with this new update? I am only working in CP atm.

[brittle pasture]

if you're only making CP mods you likely don't have to do anything

[ruby rapids]

Yay!

[rancid temple]

https://stardewvalleywiki.com/Modding:Migrate_to_Stardew_Valley_1.6.9
If you're interested in the changes, most of them are going to affect C# though

[final arch]

only custom locations

[ruby rapids]

Thanks rokugin.

[rancid temple]

That's also where any of the new stuff will be for a while

[rain basalt]

jsut custom so far built in maps seem to track correctly

[final arch]

well at least not vanilla locations, dont have any mod that completely replaces a vanilla locations to test that tho

[velvet narwhal]

i have an editmap and a custom location, gimme a sec

just came across this strange thing though...

[final arch]

editmap is fine (RSV busstop)

custom locations are borked

vanilla are fine

vanilla that are replaced by modded is what I dont know

[lucid iron]

it happened in farmcave for me

where i did Load over Maps/FarmCave

[final arch]

vanilla farmcave is fine

[rain basalt]

thanks fix works ill add to update just so people dont complain lol

[lucid iron]

yea, though it could just be too small to notice

[tawny ore]

Will the Modding Gods be kind to me today. Is the fix as simple as recompiling with the new interface? Let's see...

[rain basalt]

my mushroom cave had collisions

[final arch]

nvm that must be some mod

[velvet narwhal]

yeah there's a bush without collision

i'm checking now if i caused this by turning off my stuff

[rancid musk]

All my mods were surprisingly simple to update.

[lucid iron]

i tested out loading FarmCave.tmx from unpacked, so doing a Load at all causes it to misalign on the viewport

[ivory plume]

Can you send me that content pack to reproduce it?

[lucid iron]

yea sure ill trim it down

[velvet narwhal]

yeah, modded behavior, as soon as anything affects the map the layering gets screwed up

[unreal belfry]

Aimon Fancy Greenhouse and Aimon Tidy Cozy Cellar also broken

[lucid iron]

FarmCave-original.tmx in here is copy of the game's Maps/FarmCave.tmx

i didnt get any collision problems though, just viewport

[ivory plume]

For players who want to wait until mods are ready:

1. Right-click Stardew Valley in Steam.
2. Click Properties.
3. Go to the Betas section.
4. In the dropdown, choose legacy_1.6.8.

[whole raptor]

Might be good idea to also pin it in #modded-stardew

[tender bloom]

yay!! glad it works, confusing that it asks for (O)

[calm nebula]

No rings don't get their own data asset

(R) is not a thing

[tall wind]

I don't see 1.6 in the Beta section, what should I do?

[velvet narwhal]

try to put in the private beta code stardewvalley169

see if that repopulates all of the betas

[ivory plume]

It was just added; you may need to exit Steam (including from the system tray) and reopen it.

[tall wind]

1.6 has appeared! Thank you!!!!!!

[final arch]

thanks for all your hard work pathos

[pine elbow]

Hi, can someone tell me in which class of Stardew Valley, which has the game code that checks the items in the shipping box, at 2 am, and makes the payment for them and removes them, I wanted to make a change in this code, but I don't know where it is

[devout oriole]

any1 if json assets is usable in the newest version of sv

[tall wind]

It was a great help because the mods were no longer loading and I couldn't do anything.(´；ω；`)

[calm nebula]

Middle of _newDayAfterFade

[devout oriole]

nvm the error fixed itself

[final arch]

Farm.getShippingBin and go from there 😉

[finite meadow]

what happened Dx

[rain basalt]

changed map mid game

just got the same thing when testing different maps

[finite meadow]

This is when creating new file

[calm nebula]

Update to smapi 4.1.1

[finite meadow]

wait it already updateD? fudfshdfus tyvm

didnt check that 😄

[teal bridge]

Well, I got dragged into 1.6.9 involuntarily because of the screwy GraphicsDevice hang. The good news is that, apparently between the 1.6.9 beta I tried a month ago and the release version, my mods all fixed themselves.

[pine elbow]

public IInventory getShippingBin(Farmer who)
{
if (Game1.player.team.useSeparateWallets.Value)
{
return who.personalShippingBin.Value;
}
return sharedShippingBin.Value;
}

But I don't understand, this code is short, you can't see the part that takes the items, adds their values, adds the money, and removes the items from the shipping box

I think it must be another method

[teal bridge]

(The bad news is, of course, that a dozen other mods are broken, but I guess it's not like I was playing much lately anyway)

[final arch]

right click -> "Find all References"

[rain basalt]

nvm mine was a bad map call lol

[teal bridge]

Pathos must have added a rewriter for GetContainingBuilding.

[calm nebula]

Lol, yeah

[teal bridge]

Clear Glasses is super-broken, makes the whole game crash (sigh).

[brave fable]

i'm so relieved everything is broken. noone will notice my mods are broken 😌

[calm nebula]

Don't make huge harmony mods if you want stability

[teal bridge]

And UIIS2 is emitting a lot of spam on click. But not that bad overall.

[calm nebula]

Instead, consider going outside into the tornado watch

[rancid musk]

Hey all my huge harmony patches were fine

[brave fable]

how's Prismatic Items holding up

[rancid musk]

It was minor things that broke

[uncut viper]

all my huge harmony mods are fine thank you very much

[teal bridge]

None of my Harmony mods are broken, ironically.

Even the mod that was broken last month, wasn't broken in any of the Harmony parts.

[calm nebula]

To be fair my mods broke in 1.6.0 and were not fixed since so

I don't actually know what broke this time around because I am the laziest

[mellow gate]

I have to fix my mod at some point, but that's cause it's using json assets, and I need to change to content patcher.

[lucid iron]

Atra ur combined rings survived with no extra changes

[velvet narwhal]

(no more funny collisions for me, i am set free to the void!)
https://github.com/Aviroen/Mycology/blob/9e5cceebe249e6b6dfa723c61a90970eb0906168/data/Location.json#L182

[brave fable]

JA to CP is a pretty simple conversion

[quaint moss]

Anyone else having problems with the camera getting locked at the top right corner of the Wizard's Tower? I do have a mod doing a complete replacement of the map, but I feel like it could be relevant. Also /warp wizard placed me in a wall, when normally it places you in the middle of the main room.

[next plaza]

Someone said DGA is now broken in 1.6.9 and asked for an update

[teal bridge]

The only mods I had to quarantine outright were Better Special Orders (which never worked right to begin with), Clear Glasses (that one hurts) and RFD (a 5-line utility mod that does Harmony stuff).

[next plaza]

(For the unaware, I never updated it to 1.6)

[tepid escarp]

I’ve made an edit for the saloon map and now my viewport is on the map change (where Alex’s heart event is)

[mellow gate]

@brave fable My problem is more called 'i made this literally years ago, and barely remember how I did it then, much less recreate it in CP'

[teal bridge]

One or two others are wonky, like UIIS2, but not a complete disaster.

[brave fable]

excuse me, mod developer? pytk has not yet been updated to 1.6.9.

[teal bridge]

And StardewUI is fine, thank you Pathos for not messing with the asset loader too much

[calm nebula]

My new party line is "no" and "there are approximately 20k mods that are better than this one. Try one of those."

[brave fable]

the beauty of JA and CP is that at the very least you can see exactly what your mod is and what it's doing, so if you're keen you'll be able to sort it out

[wise berry]

Issue with SMAPI right now, but you can do this #making-mods-general message to fix it

[soft wolf]

How do you play a sound for just the local player? Like for a menu?

[brave fable]

Game1.playSound(id)

[soft wolf]

Ez, thanks

[teal bridge]

Anyway, further evidence for my Unified Theory of Procrastination (all problems fix themselves if you wait long enough).

[calm nebula]

Mod problems always resolve if you delay

[rain basalt]

hmm not sure if its smapi stardew or CP but if i change an option (map type) and it adds the map while games live the building that its a part of looses collision and no errors showing

[calm nebula]

Eventually people forget you exist

And then you are free

[brave fable]

god i wish

[calm nebula]

Forever. And ever

[brittle ledge]

(Hi tikamin, you have some neat mods )

[tepid escarp]

Also if you marry a custom NPC, you no clip everything lol

[teal bridge]

No, you also have to go through a 14-month gloating period.
(Kidding. Maybe.)

[calm nebula]

Yes

[velvet narwhal]

it's still the xTile problem, but in a new way, so honestly, come back in like 48 hours and re-check your mods, turn off nexus notifications, get a pina colada if you're of age

[rain basalt]

lol

[next plaza]

Tell that to Android SMAPI

[teal bridge]

The theory is still valid, you just have to wait longer.

[ruby rapids]

I forgot today was update day. And of course I decided to work on one of my mods and tried to test it... LOL,

[ivory plume]

The map viewport issue is... TMX tile size premultiplication.

[pine elbow]

I've looked through the StardewValley.Farm code quite a bit, but I haven't found the method that would save the day, which is probably where the thing that counts the inventory items adds their values, adds the money, and removes the items is, could it be somewhere else?

[teal bridge]

It might involve waiting until Android itself is dead, or until the sun burns itself out, but eventually Android SMAPI will fix itself too.

[mellow gate]

Time for a wawa trip and wait to see if it gets fixed so we don't spawn into the mountain on the farm.

[lucid iron]

TMXTile sounds haunted my next map mod is gonna apply the whole map via EditMap tiles exclusively \s

[final arch]

was TMXTile updated between beta and now?

cus beta didnt have any issues iirc...

[calm nebula]

No

[mellow gate]

Sometimes computers are just...like that.

[calm nebula]

So, DH

Time for RustTile to shine?

[ivory plume]

The map override changes for tilesheet handling changed fairly late in beta. The TMX tile size premultiplication breaks that logic, but removing the premultiplication breaks the map viewport centering.

[teal bridge]

Were I at work, I'd say "time for a rollback".

[ivory plume]

(We're not going to rollback Stardew Valley due to a SMAPI issue though.)

[wanton field]

Hi guys i was workin on my 1st mod. And everything looks soooo good. Proudly i wanted to show it to my hubby and nothing worked anymore. Is there a new issue, becouse of the update mess, with the CP Custom_locations?

[rancid temple]

Maps are busted right now

[tender bloom]

sure is!

[rancid temple]

New update brokeded things

[acoustic summit]

I didnt have any issues with my custom maps tbh

[ivory plume]

You can switch back to 1.6.8 temporarily; see instructions in the pins.

[calm nebula]

From scratch rewrite of tmxtile time?

[teal bridge]

Heh, not my problem, I don't even use any map mods.

[tender bloom]

Pathos above is discussing this exact issue

[acoustic summit]

and custom locations

Test what you have, it may require a small fix, or a bigger fix, but best to test

[wanton field]

smapi tells me "[game] Warp to Custom_Northwestcoast failed: location wasn't found or couldn't be loaded." and i cannot use the debug command too

[velvet narwhal]

you're definitely on something different then, one tile overlay has screwed the entire forest
but generally, come back in 48 hours, get a cheat-snack for yourself, walk your dog, call your mother /lh

[teal bridge]

lgtm

ship it

[wanton field]

so the best think is to wait a few days and this will be possible again?

[wanton field]

try mine if i get it finished ❤️

Thank you all 🙏

[latent mauve]

I'm just glad that my mods are not frequented enough that they posted before I could about the SMAPI tmx issue xD

[teal bridge]

Crap, I think something in UI did break - did the behavior of IClickableMenu.receiveGamepadButton change in 1.6.9? My breakpoint isn't even being hit now.

[latent mauve]

So I ended up with 0 new comments on my mod

hooray for relative obscurity

[velvet narwhal]

hell yeah, 0 notif groop
(tbf, i gave live notifications to my niche discord)

[finite meadow]

in my case Im spawning in the right area, but camera is.. weird..
This is the view of my whole map, camera won't follow my char

[lucid iron]

Tmx viewport problem, fix wip please standby

[finite meadow]

O tyvm

[rancid temple]

In most cases, currently the best fix is going to be "wait a day or two"

[lusty egret]

Thanks for looking into this! I just had a try at adding:

    public int Reduce(Item item, int count, bool reduceRemainderFromInventory = false) { return 0;}
    public bool IsLocalPlayerInventory { get; set; }

To HeldItemsWrapper and it seems to work haha (I'm using your mod mainly for stash into nearby chests only though). Just the UI got somehow wonky? Color selector reverted to vanilla.

[crimson meteor]

A question, is smapi for Android going to be updated?

[fickle totem]

We already told you it's not. Please drop this

The person working on it has stopped

[rancid temple]

It has gotten even harder to update as of 1.6.9 too

[hallow prism]

hi! just wanted to say thanks to all mod authors that are currently out there releasing builds and updates to put out the fires and all

[tawny ore]

I actually managed to get my mods updated for 1.6.9 and was in the middle of testing functionality, and then the power goes out. So I'll upload the fixes as soon as power is restored to my house.

[hallow prism]

as a content author i'm grateful for the work of the frameworks makers and other C# mods for that

[fickle totem]

Thanks goes to you too Lumi!

[crimson meteor]

Do you know the people or has the person said something about it, just asking

[teal bridge]

False alarm, folks... my gamepad handler wasn't working because for some reason the entire gamepad had become disabled.

[fickle totem]

You were already asked not to harass the person that used to work on it. Please stop

[rancid temple]

Did your restart your computer? Mine doesn't turn itself back on, on a restart

[hallow prism]

(i remember the person working on smapi for android being harrassed by users with questions about progress on the update)

[fickle totem]

^^

[lusty egret]

Dude, your mod is cursed! While testing I had a short power shortage too!

[fickle totem]

They have been told this and do not seem to care

[hallow prism]

sure, always happy to help by (checks note) not doing anything 😄

[lucid iron]

morale support!

[brittle pasture]

hmm anyone else on Linux seeing this weird issue (chu you had this right)

[lucid iron]

yep

[fickle totem]

Taking a break is productive too

[velvet narwhal]

support in spirit

[lucid iron]

linux L

aviroen checked for me on windows, its just linux

[hallow prism]

i'm half joking, i played SDV but i had my game folder renamed so i don't have to update right now

[deep cypress]

Alles Ded. Makes sense in English too

[crimson meteor]

Who is talking about harassment I'm just asking I just want to know if it won't continue

[lucid iron]

unfortunately it'll hit steamdeck people too, but they can just unzip on windows before moving mods to deck

[soft wolf]

So this works, but it feels super dirty. Got a better solution?

private bool GetIsTwig(StardewValley.Object obj)
{
    return obj is not Chest && obj?.Name == "Twig"; // TODO: Data driven check
}

private bool GetIsWeed(StardewValley.Object obj)
{
    return obj is not Chest && obj?.Name == "Weeds"; // TODO: Data driven check
}

private bool GetIsStone(StardewValley.Object obj)
{
    return obj is not Chest && obj?.Name == "Stone"; // TODO: Data driven check
}

[fickle totem]

A handful of people have already told you it's not gonna be continued. It has been abandoned, dropped and it is dead

[crimson meteor]

O saber si dijo algo al respecto

[fickle totem]

Idk how to make this any clearer

[blissful panther]

Please stop asking. You've been answered several times.

1. The person working on it hasn't made any updates for a long time.
2. There are new technical reasons that making SMAPI work on Android will be absurdly difficult to impossible.

So now that subject is over... how about those mod updates?

[calm nebula]

....weird

[fickle totem]

Thanks DL

[calm nebula]

I'm volunteering you to rewrite xtile in rust

[blissful panther]

It's me, DecidedlyLuman!

[fickle totem]

OH SHOOT

DH*

[brave fable]

thanks Decided Lee

[tender bloom]

Maybe you're just on the Down Low

[finite meadow]

There was a mod called NPC adventures, creator would get harrassed in her irl media after 1.6 until she couldn't take it anymore. It's discontinued sadly, sometimes it may look simple but sometimes its more complicated than that.. so just, move on

[rancid temple]

What mod updates? No mod updates here, not in #modded-support-2

[tender bloom]

I should see if my mods work in 1.6.9

but that feels like maybe more of a tomorrow or later thing

[velvet narwhal]

ain't got no mod updates here, only debugging tilesheet collision re-arrangement

[soft wolf]

Well I just finished my mod, now to make sure today's update didn't brick it 😛

[tender bloom]

I am thinking about finally updating my last couple of mods

[wanton field]

got the same on mac... Folders are missing.

[brave fable]

maybe next week i'll see if things have settled enough to push my mod updates

[finite meadow]

fix smapi ty 😛

[latent mauve]

All of my mods deal with custom maps, so I might as well just wait at this point so I don't have to add ViewportClamp or ViewportFollowPlayer to everything. >_>

[atomic vale]

what is the damage on mod broken due to the updata that we know of?

[calm nebula]

This is hilarious. How

[tender bloom]

I had someone ask about my prismatic mod so it feels like time — initially I was waiting for more frameworks, but I feel like I don't need anymore now

[brave fable]

catastrophic, billions of dollars

[velvet narwhal]

xTile is the problem, always has been, always will be

[brittle pasture]

weird, should we ping Pathos
or I can steal look up a command to fix this maybe

[uncut viper]

on the bright side... at least nexus didnt die today (yet)?

[soft wolf]

Buy the dip

[atomic vale]

has is died in the past?

[rancid temple]

They did their dying yesterday to prepare for today

[tender bloom]

Plus I think I can update my artifact spot duggy mod to check locationcontext seasons

[calm nebula]

What zipper is he using

[velvet narwhal]

it died mid-debugging for me trying to cross-ref your bugreport

[finite meadow]

hows your island mod btw 😄

[tender bloom]

so that VMV artifact spots can look less funny with my mod

[ruby rapids]

Shoot. I can't even test my edits on SDV right now. It crashes even when I start a new game. Darn it. I just edited a tile map and wanted to see what it looked like. I got to learn to be patient... I am also hoping some of the older mods that haven't been updated in a while still work after the dust settles. I did some retextures and would hate for them to go to waste.

[blissful panther]

But we want something better, not worse!

[wanton field]

im a newbie i dont know. but i fixed it for myself with adding folders and rename everything.

[latent mauve]

Can test on legacy 1.6.8 if you want to, just have to download and install the older SMAPI

[teal bridge]

Ok, UI Info Suite, you really need to stop throwing an exception on every single click, I heard you the first time.

[rancid temple]

Can we settle for something working?

[brittle pasture]

https://stackoverflow.com/questions/71826297/path-separator-backslash-in-zip-files-created-from-dll-net-4-8 it seems to be a problem ppl are having. I don't know why it's happening now, but it is happening

[crimson meteor]

Sorry, I don't know English. When they say dead, do you mean it literally or is the project dead?

[blissful panther]

Please stop. Now.

[fickle totem]

Please stop pinging me about this.

[calm nebula]

That's fucking hilarious

[brittle pasture]

truly a Linux L for the ages

[calm nebula]

Just amazing

[soft wolf]

Your avatar kinda fits this sentence.

[fickle totem]

Wdym

[velvet narwhal]

microsoft yet again coming from the top rope for linux users

[soft wolf]

I just meant you sound done lol

[crimson meteor]

I'm just asking, why are you taking it so badly?

[finite meadow]

[atomic vale]

My god, hey on the bright side I don't have to fix my mod!

[sullen vale]

guys what happened to expanded?

[clever sinew]

It is being fixed

[fickle totem]

Well that's a lot of red

[latent mauve]

SVE is hidden until the tile issues are resolved.

[tender bloom]

SMAPI has a booboo, fix is in progress

[atomic vale]

i can update about half

[sullen vale]

I'm afraid I'll lose everything

[proven vigil]

Yeah I'll unhide the page when SMAPi is ready

[tender bloom]

where's the artifact spot in inventory description

[dense crane]

Oh boy new update! Hope I won't have to do any mod updates, but I guess I'll have to check tomorrow

[atomic vale]

do you have a SV 1.6.8 game?

[teal bridge]

AtraCore? That hasn't been compatible since 1.6.

[latent mauve]

Save your sanity, definitely wait to update until tomorrow. xD

[tender bloom]

There is a beta for 1.6.8 (see pins)

[atomic vale]

if you have any you prob will

[rancid temple]

Just don't update? Or don't play until it's fixed

[sullen vale]

It's updated

oh[

[latent mauve]

!legacy

[ocean sail]

The game has two 'legacy' versions you can use:

• legacy_1.5.6 is the last version before Stardew Valley 1.6. This is a (probably temporary) branch for players whose mods don't work in 1.6 yet.
• compatibility is the latest game update, but using outdated frameworks. This is more compatible with some older systems, but mods do not work in this branch.

To switch branch:

• On Steam: In your Steam library, right-click Stardew Valley and select Properties... > Betas, and then choose the branch under the dropdown.
• On GOG: From the game's page in GOG Galaxy, click the settings icon > Manage installation > Configure... and choose the branch under the Beta channels dropdown.

To use this command, type !legacy.

[latent mauve]

Except we need to update the legacy numbers there

[atomic vale]

I have a SV 1.6.8 game save and a 1.6.9 game

[rancid temple]

Looks like that hasn't been updated lol

It's in the pins

[dense crane]

Ah yeah will probs need to update all my installed mods. Just thinking about pushing an update to a mod i've made

[velvet narwhal]

did revert get updated? i go check

[sullen vale]

thing is

[lucid iron]

if you are not working on mod or fixing mod please go to #modded-stardew

[rancid temple]

Your saves are separated from the game version to a degree, just don't play and save until after everything is properly updated

[tender bloom]

read the pins please

[sullen vale]

i already deleted the mod to install it again

[dense crane]

Wait how do I get the mod author role?

[haughty charm]

Hi! This channel is for mod making; for questions about using mods, please go to #modded-stardew

[tender bloom]

Mod author role = have a published mod, be level 25 here, add yourself to the wiki, request it

50? nope I was wrong

[uncut viper]

level 25

[sullen vale]

okay! thanks

[uncut viper]

also you're supposed to ask before adding to the wiki i thought

[velvet narwhal]

(revert did get updated)

[rancid temple]

Check #roles

[uncut viper]

or maybe it depends on the junimo and the day idk

[atomic vale]

oooooooooohhhhh SMAPI got a new update

[soft wolf]

I'm a level 25 crook.

[tender bloom]

Advice differs on which to do first lol

[velvet narwhal]

tbh i asked bouncer first, then got told to go edit wiki

[rancid temple]

That's because it's different depending on where you look and who you ask lol

[tender bloom]

if you're sure you qualify, editing the wiki saves time, but if you aren't sure, don't add yourself

the idea is that plenty of people forget the level requirement so asking helps you check you qualify before you add

[lucid iron]

dm'ing the bouncer is free

[ruby rapids]

Mad respect for all you who are putting out these coded fires.

[latent mauve]

I treat adding to the wiki as the final step before the cheeto dusting

[tender bloom]

maaaybe DM bouncer tomorrow tho today has a bit of fires

DMing bouncer is free but unfortunately the humans behind it don't have free eyeballs

I wish I had extra eyeballs for free

[atomic vale]

same

[velvet narwhal]

"All of our agents are currently putting out fires, your call is important to us. Please stay on the line." /lh

[rancid temple]

Where would you keep them? Seems unsanitary

[tender bloom]

I could find some sterile solution

[uncut viper]

on the inside. bloodborne style

[rancid temple]

Ooh, cancerous

[tender bloom]

i hear there is some anime with creepy eye stealing stuff in it

[rancid temple]

There's some anime with blank, yes

[lucid iron]

https://tenor.com/view/ill-add-you-to-my-collection-gif-19698046

[rancid temple]

The "meme" popping into existence a half second late is sending me

[brittle pasture]

ah yes, fiction's most incompetent war criminal

[teal bridge]

Captured by the world's most ridiculously-named video capturing software.

[dense crane]

what is powerdirector?

[haughty charm]

Don't mind me...just making an announcement to pin.

QUICK ANNOUNCEMENT:

There is currently an issue with SMAPI for 1.6.9. Pathos is aware. Please do not harass him or any other mod author about updates.

It (and other mods) will be updated when it is updated. Please be patient.

[hallow prism]

and i have another mod joining the big list of "mods that i should look into one day" : Machine Terrain Framework

[eternal mortar]

how do i get path tiles to actually work in mapping? For example placing down a tree tile and a tree appears on the map in game.

[teal bridge]

Everything made by CyberLink is POWERFUL

[rain basalt]

remember Flashplayer

[hallow prism]

(will probably do nothing about it soon, but it seems having some cool potential)

[tender bloom]

The paths tiles are special, you have to reset terrain features before they take effect in an existing game

[brittle pasture]

if the location is already created in your save, you'd need reset terrain features

[dense crane]

Ah gotcha. Got rejected sadly since NSFW mods aren't allowed in the discord, but it is what it is!

[tender bloom]

!rtf

[ocean sail]

Reset Terrain Features (https://smapi.io/mods/#Reset_Terrain_Features) is a mod that lets you reset, clear, or generate everything that spawns on a map using an in-game menu. That's especially useful when changing maps mid-save, as the debris will otherwise use the old layout (causing things like trees in the water or bushes blocking exits).

To use this command, type !rtf.

[ivory plume]

Update on the map issue: the upcoming 1.6.10 will revert some changes that were added late in the 1.6.9 beta, then SMAPI will need an update for it.

[teal bridge]

whistling

[eternal mortar]

so if i make a new save with the tiles it will appear or? how do i reset terrain features lol?

[tender bloom]

see the link above

it's a mod

new save also works

[ruby rapids]

Thanks for all of you who suggested the legacy 1.6.8 version... unfortunately since my mod depends on some other mods that are broken atm. I'll have to wait til things are fix. Going back to the 1.6.8 version didn't work for what I need. 🥲

[sweet sphinx]

Revert the broken mods to 1.6.8 too?

[fierce dagger]

can someone please explain what is happening with the new smapi update?

im so confused

[sweet sphinx]

Stuff borked and everything's on fire

[ocean sail]

@sweet sphinx You leveled up to Farmer. You're now a prettier shade of blue. Thanks for sticking around!

[teal bridge]

Check the pinned messages.

[fierce dagger]

oooooh

thanks!!

[proud wyvern]

Heh, Android port of 1.6 is AOT compiled? Fun

[rancid musk]

I hope the decomp of 1.6.10 is less insane because 1.6.9 has so many wild things.

[brittle pasture]

yep. no more SMAPI mobile /hj

[vale stream]

Has anyone invoked another mod's methods? Not sure how to give ModEntry to the method

[uncut viper]

(out of curiosity what is AOT and why is it bad for mobile modding)

[proud wyvern]

I for one am grateful

[lucid iron]

do they have an API for you?

[teal bridge]

Ahead of time compilation. Makes it a lot harder to patch IL.

[uncut viper]

is there like a brief summary of what that even means or am i better off just doin independent research into it and not in this channel

[lucid iron]

its a java 9 feature from what i gathered

[teal bridge]

It means compiled to native code, i.e. bypassing the JIT compilation of MSIL.

[lucid iron]

as alternative to the usual JIT on vm business

[uncut viper]

that does seem quite troublesome for modding

[proud wyvern]

And more advanced mods leveraged the MSIL part to do their edits

[teal bridge]

Yes, that's why "effectively impossible" was the phrase some folks used.

[rancid musk]

Depends on the mod. I would suggest reaching out to the author to request an API method if you can. If you can't, you can probably reflect into SMAPI and grab the Mod instance from that.

[vale stream]

Nope- I have one though, so i might have to ask them

[teal bridge]

I don't know enough about Java/Android AoT to be certain of that... my understanding of Android AoT was that it was more along the lines of "hints" about what the jitted code should look like, but maybe things have changed.

Baseline profiles and all that funky stuff.

[vale stream]

I see, I'll try reaching out then. Thanks!

[tender bloom]

as an extreeeemely metaphorical description, my understanding is it's like the game is a cake. AOT = baking the cake the day before (before it gets to the users) vs before was more like baking the cake so it's ready right before the user opens it

if you wanted to add blueberries (mods), you'd be out of luck if the cake is already baked

though this is an oversimplification

and also I don't know the details

[proud wyvern]

I didn’t look at the Android version of the game, and never worked with AOT before, but if it’s done with something like IL2CPP, then I think HarmonyX specifically works with that - but transpilers are out of the question

[latent mauve]

Thank you for that tasty example. Now I'm hungry. xD

[uncut viper]

an oversimplification it may be but it does help me understand the broad strokes of it a lot more, thank you

[tender bloom]

i think it's spiritually right but not technically right

[calm nebula]

NativeAOT

[rancid temple]

Oops all prefixes

[proud wyvern]

That doesn’t tell me anything atra

[finite meadow]

ty for your hard work

[teal bridge]

Ok, that's what I wasn't sure about. So they're AoTing the .NET code, not the Android Java code.

Then yeah, modders are screwed.

[rancid musk]

The Native AOT deployment model uses an ahead-of-time compiler to compile IL to native code at the time of publish. Native AOT apps don't use a just-in-time (JIT) compiler when the application runs. Native AOT apps can run in restricted environments where a JIT isn't allowed.

[proud wyvern]

Yay, we can keep living as if Android didn’t exist

[velvet narwhal]

man i gotta change the meme now

[teal bridge]

I mean, you can still patch native code, that's what 15 years of Bethesda mods have been doing. But it'd have to be a totally different model and process.

[calm nebula]

The Microsoft AOT

[patent lance]

@wanton pebble: update this (4h ago)

[brittle pasture]

(it's already updated 😆 )

[rancid musk]

There are definitely people who patch native code. But that's a huge project and I doubt anyone is going to want to jump through that just to support one platform of many for a game from 2016, even as popular a one as Stardew. And pretty much the best you could hope for is getting Content Patcher working because every C# mod would have to be completely rewritten and that loops right back to no one wanting to jump through those hoops.

[proud wyvern]

StormAndroid

[knotty phoenix]

Anyone know if there's a way to attach a light source to an NPC? I want her to glow

[rancid musk]

Honestly, the better approach would be to make a wrapper to get the Linux build of Stardew running on Android.

That'd be way more actually possible + worth it

[calm nebula]

Smapi uses no harmony

[brittle pasture]

not with vanilla. my memory fails me but I think there's a framework for it?

[calm nebula]

The type tokens exist

[wanton pebble]

Yep, I saw, but thank you selph - given I made that reminder on break at work I would have forgotten if I hadn't seen it XD

[calm nebula]

You can get reflection

[proud wyvern]

That’s what I had in mind for the past like 3 years

[brittle pasture]

(but I might be confusing that with Glow Buff)

[proud wyvern]

Mostly in regards to iOS modding

Sorta, kinda

[lucid iron]

how well does wine work on android/ios these days?

[brittle pasture]

I dont recall Wine was ever a thing on them?

[teal bridge]

I didn't think so either.

[lucid iron]

https://dl.winehq.org/wine-builds/android/

[teal bridge]

There are Windows emulators, but they're notoriously crash-prone.

[lucid iron]

2018

so answer is probably "badly"

[brittle pasture]

hmm okay, apparently there is a very experimental Wine build for Android. Last updated 2022 though, so the entire thing is likely quietly abandoned

[lucid iron]

ah no i just had to scroll, 2022 last release

[calm nebula]

(Keep in mind stardew is x86)

[hallow prism]

don't put wine on your phone

(sorry not sorry)

[calm nebula]

And phones are not

[teal bridge]

Hell, even the Android emulators on Windows aren't so hot. Windows emulators on Android? Fuhgeddaboutit.

[brittle pasture]

I mean Apple/Mac does have a x86/ARM translation layer right? though last I heard they're trying to pretend that doesn't exist to "encourage" native apps

[lucid iron]

tbh even if it works there's barrier of OEMs cracking down on root

[rancid musk]

Stardew is 99% managed though. I expect you could use native arm .net and be mostly there.

[teal bridge]

Linux version is definitely the more practical option, for certain definitions of "practical".

[calm nebula]

Monogame

[brittle ledge]

(I appreciate all y'all's explanations of what's going on )

[latent mauve]

hooray!

[rain basalt]

lol

on load it dissapears a second then pops back up

[calm nebula]

That's normal

[lapis tiger]

uh can anyone help

[calm nebula]

What is the issue

[lapis tiger]

the beach map is stuck here

I couldn't see furthur than this

[rancid temple]

Wait for next SMAPI

[ivory plume]

The latest SMAPI 4.1.2 released seven seconds ago should fix that.

[rancid temple]

Oh, 🔥 hot off the presses

[lapis tiger]

oh nice

thanks

[teal bridge]

Was there always a MenuTilesUncolored, or is that new?

[lapis tiger]

I will let you know if it fixes it

[lucid iron]

i get strange issue when trying to build project

/usr/share/dotnet/sdk/8.0.402/Microsoft.Common.CurrentVersion.targets(3413,5): error MSB3552: Resource file "**/*.resx" cannot be found.

[teal bridge]

Does this set a new record for most SMAPI releases in a single day?

[lucid iron]

it only happens on the second build and on, and goes away if i delete obj

(but then comes back right after restore ofc)

[calm nebula]

No

[brave fable]

it's not from 1.6.9 at least, it's used for menus such as the FieldOfficeMenu and maybe also DyeMenu

[faint ingot]

Yay, my spouse rooms / patios are fixed!

[lapis tiger]

nice

I don't have to reset my day for the 6th time now

lol

[brave fable]

you sure were determined to play a lot of modded sdv on the day of a mod-breaking update hahah

a lot of brave souls around here

[lapis tiger]

well

I just miss my spouse

lmao

[tepid escarp]

Thank you pathoschild ❤️

[mighty quest]

What the hell happened with 1.6.9?

[rancid temple]

🔥

[brave fable]

some small conflicts between sdv, smapi, and its libraries lol

🤏 minor

[calm nebula]

No need to worry lol

[languid aurora]

Question for those that have messed with the Net* fields and their event handlers/delegates. Is there anything wrong with this approach to subscribing and unsubscribing?

FieldChange<NetRef<Crop>, Crop> fieldChangedEventDelegate = null;
fieldChangedEventDelegate = delegate (NetRef<Crop> field, Crop oldValue, Crop newValue)
{
    // DO STUFF

    // Unsubscribe now that we've done stuff
    dirtNetCrop.fieldChangeVisibleEvent -= fieldChangedEventDelegate;
};

// Initial subscribe
dirtNetCrop.fieldChangeVisibleEvent += fieldChangedEventDelegate;

[lucid iron]

you only care about the first change?

[lapis tiger]

is there a mod that fixes lag spikes?

[velvet narwhal]

you're better off with those questions in #modded-stardew

[languid aurora]

I have some extra logic that does a few checks before doing anything, but when I do anythign I also immediately unsub

There's basically an if with a few conditions that the DO STUFF and unsub are inside of

[lapis tiger]

thank you

[lucid iron]

although i think this probably works, i feel you can just stay subscribed

[languid aurora]

Well the stuff that happens shouldn't happen more than once ideally

[lucid iron]

what is behavior the second time crop changes then

[languid aurora]

And I don't know if crop and fruit tree and bush objects persist across days, because then there would be an issue

[teal bridge]

Nothing wrong, it's just a ListenOnce pattern. The only thing that's a tiny bit sketchy is using a closure capture to do it, but as long as it's actually really unsubscribing, then you should be OK.