Cruiser Improved

[oak oracle]

and don't decrease the stiffness as much if you do this route

[floral mist]

ah okay

maybe

[oak oracle]

you'd need to play around with the friction in editor or something to see what "feels right"

[floral mist]

fair enough

[oak oracle]

it'll differ from wheel to wheel but that's fine since people can change that on their end

when trying to drive forward it should slip quite a bit, and then turning should be orders of magnitude worse

even if you turn the wheels full lock, it should struggle to turn

lol

anyways, the feel is entirely up to you for this one

you can either have complete loss of grip, or some loss of forward grip and serious difficulty turning

the latter of which is probably more realistic

[spring brook]

So that's why when I push the cruiser, it fell so easily.

[oak oracle]

potentially

[spring brook]

Something strange happened when I got out of the interior. All items from the cruiser disappeared, but for the host and another client, all items were there.

Some scraps were from the previous day

and after bringing the cruiser to the ship and resetting the lobby, I was able to see all the scraps.

[oak oracle]

can't say i've heard of this issue before

[oak oracle]

i am pretty confident that this mod will still work in v80 without me doing anything to it

zeeks literally changed nothing on the cruiser

not even a new radio song

not a single qol

not a single bugfix

yuppo, it does

[oak oracle]

zeekerss messed with the cruiser in the newest patch

shouldn't affect CI though

since it was a minor change

[cobalt prairie]

Wait we're doing minor updates to the same beta now

That sounds fun

[oak oracle]

well

the tl;dr of the change he made is

if the cruiser is parked

with ignition off

no enemy can damage it

ever

[cobalt prairie]

Seems like a fine enough change

[oak oracle]

reversing into enemies also wont damage them

[oak oracle]

kind of a dum change imo

its just making the car even more invincible

its another buff for an already indestructible car

[cobalt prairie]

This is dumb

[oak oracle]

the car was already invincible to stuff like dogs

as of v70

[oak oracle]

so i found the real reason the cruisers suspension is borked

the sprung mass on the front tyres is like

8

which is caused by zeeks setting the CoM on start

[oak oracle]

seems like zeeks fixed masked being unable to be run over

this mod should still work if anyones wondering

no code changes to the cruiser under the hood other than just removing some debug text

[quasi sonnet]

Cool beans

[mighty agate]

[14:44:41.7230833] [Warning:CruiserImproved] Could not patch ItemFallthroughPatch!

[mighty agate]

@oak oracle

[oak oracle]

yes I am aware of this

just haven't had a chance to look into it

[mighty agate]

have a chance then

[oak oracle]

...when i can get round to it

i don't think this will cause issues at the moment anyways

[spring brook]

Did you fix that problem about scrap that you lost or sold being brought back to the ship again after reopening the lobby, no matter if it's in orbit or mid-game? “All Cruiser items brought into the ship after reopening the lobby” was implemented in the dawnlib save system and fixed that issue above.

[oak oracle]

this is a vanilla issue I swear

unless I'm misunderstanding the issue

[spring brook]

Here

[oak oracle]

im not understanding the problem, sorry

you're going to have to be a little more clear with me

[spring brook]

Basically, if you die or lost your scraps/sold them with Cruiserimproved installed (without dawnlib to overrides) and reopen the lobby the scrap will be there again inside the ship.

[oak oracle]

yeah no I'm pretty sure this is a vanilla issue

have you tried without cruiser improved and without dawn lib

[floral mist]

I did hear about this

[oak oracle]

It being vanilla?

[spring brook]

With dawnlib is working

I will test vanilla later

[oak oracle]

yeah, I'm pretty sure this is a vanilla problem lol

if it is I don't think it's something cruiser improved should fix

[floral mist]

yea

[oak oracle]

i knew i wasn't misremembering

because i recall it happening alot in my modpacks that didn't have cruiserimproved

and in pub lobs

[floral mist]

iirc it was something about the save system not running if you had 0 items in the ship

[signal wave]

I noticed this. Sometimes the game just doesn't save properly.

[thin hearth]

not exactly but this is sort of the gist

what was happening before is that when GameNetworkManager.SaveItemsInShip() is called

it searches for all the items on the ship which are saveable

in the case none exist, the function returns early:

if (list.Count <= 0)
{
    Debug.Log("Got no ship grabbable items to save.");
    return;
}

the problem is that the save file still has all of the items from last save written to it

so what it actually needs to do is "save 0 items to the file", not "skip saving to the file"

otherwise you get the bug where dumping everything off your ship respawns everything from the previous day

this is how people were able to sell everything on their ship, then rehost, and wind up on day 3 of a new quota with everything from the previous quota back on their ship and able to sell again

i say "were" because he fixed this in v81

Fixed issue where if you reloaded a file where the sticky note and manual were thrown out and there were no objects in the ship, the items that were previously there when the game had last saved would return

        if (list.Count <= 0)
        {
            Debug.Log("Got no ship grabbable items to save.");
+           ES3.DeleteKey("shipGrabbableItemIDs", this.currentSaveFileName);
+           ES3.DeleteKey("shipGrabbableItemPos", this.currentSaveFileName);
+           ES3.DeleteKey("shipScrapValues", this.currentSaveFileName);
+           ES3.DeleteKey("shipItemSaveData", this.currentSaveFileName);
            return;
        }

[gilded girder]

can there be an option to disable the cruiser scan node?

[spring brook]

Gale you can just disable all but idk if its gonna actually disable.

[gilded girder]

I would assume not since it isn't listed as an option here

[ancient totem]

set it to anything but enabled

[gilded girder]

ah, i see

i suppose that makes sense but it's a bit unintuitive without using the mod manager config editor

oh well

[thin hearth]

i think this is a lethalconfig issue

this is a bitflag

but lethalconfig treats it like a dropdown

im not sure if lethalconfig actually supports bitflags, if it does it might require explicitly specifying lethalconfig compatibility and using the API

anyways yeah to get around the fact you can't just remove all the flags, you can just set any of the flags except "enabled" and it'll be fine

[spring brook]

Sort equipment on load still doesn't work

[oak oracle]

i'm pretty confident SEOL was working when i tested it

[spring brook]

019e4020-9aee-b3da-33a3-dc1048c24b00

I tested with only Cruiser Improved and a mod of infinity money too, and the same result.

[oak oracle]

sigh

i will look into this "at some point"

no ETA since it's not a priority/major thing

I'm quite hung up with other stuff and I just haven't had much motivation to work on cruiser improved

[oak oracle]

i'm finally trying to look into the sort equipment on load shit ;p

plus some other stuff

i believe i have a fix for seol

i added a bounds check on SetItemPosition

and i also removed the coroutine

[mighty agate]

im floating above the seat, cant reach controls

[oak oracle]

do you hav a mod breaking animations

sorry my E key is kinda busted

do you have a modpack code, infact

[mighty agate]

019e7964-4c30-3c3b-566a-93b27d51f4ee

[oak oracle]

do you have any steps to reproduce

unrelated but oh god

cruiserimproved doesn't mess with animations, for the record

and have you confirmed this is cruiserimproved causing this

[mighty agate]

is it a bad one

[oak oracle]

yes

lol

[mighty agate]

why

[oak oracle]

it wouldn't cause this bug i just found it funny you have this

just use it and find out lmfao

it is literally a slapped together cruiser reskin

infact let me find the video of it

[oak oracle]

https://cdn.discordapp.com/attachments/1168657096758267904/1419140282351358102/Untitled_video_-_Made_with_Clipchamp_3.mp4?ex=6a1c3e21&is=6a1aeca1&hm=1e0cf3cbebb04781bbc3f642b4add5809a40894970f401308178fcb0433b83cf& again this has nothing to do with the bug you're having i just found it funny for the record

but here's that mod in action

hope this answers your "why"

[oak oracle]

anyways

have you confirmed this is just cruiserimproved causing this bug, because nothing in ci touches animations in any way
do you have any steps to reproduce

[oak oracle]

1.6.0 is just a minor patch for the scan while seated thing

so it doesn't apply to modded vehicles

[mighty agate]

i wasnt in a modded vehicle

[oak oracle]

i released that probably like 2 hours ago and it's only just coming through

[mighty agate]

wait or was i

[oak oracle]

i know i was talking about 1.6.0 and the changes it brings

1.6.0 is just a minor patch to prevent the scan while seated applying to anything but the vanilla cruiser

[oak oracle]

anyways, this

[mighty agate]

i dont have any specific steps and im unsure if any of my mods affect animations

[oak oracle]

well i can sure as hell tell you cruiserimproved doesn't touch animations

it seems like something is triggering the SA_StopAnimation trigger on the player

which immediately results in standing up if you enter a vehicle seat

or are actively in one

or any "special animation" for the matter

[mighty agate]

i do remember trying to get in the cruiser through ship windows tho :p

[oak oracle]

that probably wouldn't cause it

i'm pretty confident this is some mod on your pack causing bugs

not cruiserimproved

[oak oracle]

this tells me nothing

this is just a vehicle being deleted

[mighty agate]

what can i do to help you identify the issue? I'm not sure what would be causing this

[oak oracle]

it would probably help to confirm if cruiserimproved alone is causing this bug

if it is, i then need reproduction steps

so i can actually look into this

you probably have some mod that is breaking animations one way or another

[spring brook]

I played a lot with cruiser this morning and I didn't have problems with animations

[mighty agate]

there's a chance i could have been riding a modded cruiser, which looks almost identical to the vanilla cruiser heh

[oak oracle]

not a thing unless you're using my version55 cruiser, but that bricks completely with cruiserimproved and doesn't even spawn correctly

the only modded vehicles right now are:

The CyberTruck (which is a straightup reskinned cruiser with no custom code)
Booms RoadRage which is a 'refurbished company cruiser'
My Version55 Company Cruiser
My Vandal Electronics ScanVan
My and Glojams Company Hauler

[mighty agate]

ok then yeah it mustve been the vanilla one

[oak oracle]

yes

it would be a little silly to make a "modded vehicle that's just an identical cruiser with no differences"

my version55 cruiser, while looking identical to vanilla, does have some differences and is a faithful recreation to v55 + some extra stuff of my own

[mighty agate]

i deleted the modded vehicles i had since i dont care for them, i'll see if that makes a difference

[oak oracle]

but that doesn't work with improved anyways

[mighty agate]

i don't have any mods that should mess with animations, at least not that i know of

[oak oracle]

well CI doesn't touch animations so i'm unsure what to tell you 😄

[oak oracle]

you only had one and i don't think it would of been causing this bug

[mighty agate]

from my code do u suspect anything?

[mighty agate]

i had 2

[oak oracle]

unsure without testing it

you did?

which ones

i saw the cybertruck

[mighty agate]

the cybertruck and booms roadrage

[oak oracle]

i don't think booms roadrage would cause it

[mighty agate]

¯_(ツ)_/¯

[oak oracle]

since it too has no custom animation code

so you have something else messing with animations

my vehicles have custom animations but i put many things in place to prevent issues

and the only incompat with them is BetterEmotes that breaks all custom animations

[mighty agate]

is there a chance it couldve been the cybertruck?

[oak oracle]

i just said i don't think it is, no

i only pointed it out because it was funny

don't hone in on that mod too much, i was just poking fun at it

[mighty agate]

0 chance?

[oak oracle]

statistically unlikely

i mean you can pull it if you want i don't really care

i was just poking fun at it ;p

[mighty agate]

i removed it because i dont use it eitherway heh

but then again all the mods in my modpack are well known mods that dont touch animations afaik

they're all mods you're familiar with im pretty sure

[oak oracle]

something tells me that's not true but like, y'know

[mighty agate]

lmao

[oak oracle]

i don't think it would be this because of how it works but like

y'know

[mighty agate]

well besides emotes

[oak oracle]

well emotes touch animations technically

lol

anyways, if you find CruiserImproved to be at fault, you can let me know along with reproduction steps

and i can look into it

[mighty agate]

im sure you would've had a lot of ppl complaining here bc that mod is used in many modpacks

[oak oracle]

infact

i might know what it is

you have something using itolib that has a PlayerSeater script

hang on

@signal plinth pacooo you didn't fix the stop animation thing

you're still setting the stop animation trigger instead of resetting

which is causing bugs

[mighty agate]

well good news i removed itolib

should work fine now then

:D

[oak oracle]

i'd assume so

the issue is Itolib has this

it's setting instead of resetting

which immediately cancels "special animations"

such as vehicle ones

[mighty agate]

scandal there's 1 small issue here

you're speaking to me as if i have technical modding knowledge

[oak oracle]

apologies 😅

[signal plinth]

Ye I haven't updated it yet

[oak oracle]

blegh
it's okay

[mighty agate]

it's so hard having a bug free modpack on v81 😔

i blame butterystancakes

[oak oracle]

i haven't really even put together a proper modpack in v81 because none of my friends have been on to play

don't blame buttery

she's awsome sawesome

[oak oracle]

i have like, a stable client side modpack with qol/bugfixes

but that's it

[mighty agate]

yeah that was a joke i decided to blame a random person ahah

@thin hearth is awesome indeed

[mighty agate]

i would say the one i have atm is quite decent