#Good Item Scan

1279 messages · Page 2 of 2 (latest)

rain talon
#

already changed

#

oh, wait

#

lol

half nexus
#

Uuuh plink

I wasn't talking about the directory 💀

rain talon
#

changed

image.png
#

time to check again

#

ok, no error logs

#

ok, now it's working

image.png
#

altought blue + blue is kinda hard to read

#

but I can confirm it's a lot more smoothly than the previous version

#

||also neat scan animation btw||

half nexus
floral pier
rain talon
half nexus
floral pier
# half nexus Huh?

I had a crazy hard time to cache default colors for all esp for the enemy one cuz it starts with blue colors

half nexus
#

Ah, yeah... I nuked the coloring from the animations SCaraara

#

I just apply them manually

floral pier
#

Fair

half nexus
#

@floral pier do you know the default value for font color?
I'm lazy SCaraara

floral pier
#

All of them use different, I know the red one uses black font

half nexus
floral pier
#

I probably have it saved somewhere

wild talon
#

Sorry test, ive been exteemely busy with stuff, i wish i could help you

half nexus
#

Everyone's busy... Almost as if they had lives besides working for the company suspensive

rain talon
wild talon
#

ok SO

#

whats the state of this mod, was the weird lag with it fixed?

rain talon
wild talon
#

oof oki

#

will prob disable then for the meantime hehe

strange igloo
#

Yeah I also hate the annoying issue with it rn

half nexus
wild talon
#

ajgfdjkfds do you still need help with that

half nexus
#

No, but I'll need some tiny adjustments

#

So... I'll post the update soon

wild talon
#

okieee

#

sorry, i finally have some time to spare

languid sorrel
#

I dont see what yall seeing

#

mine arent laggy at all for whatever reason

rain talon
wild talon
#

I did notice it quite a lot

rain talon
wild talon
#

Moving your camera

#

Its less like lag and more like delay

flint plinth
#

the scan node position updates are not synced with the framerate

#

thats why people can see it

#

it updates at a different rate than the game runs

half nexus
half nexus
#

I pushed the update

#

I wonder how much broke, @floral pier

tacit shuttle
half nexus
#

Good news, s1ck!
Your mod just doesn't have an effect yoiled

#

The entire "ScanNodes" category does nothing greed

#

Oh...

#

Toggle scan mode is brokey

#

It shows funny scan lines, but never actually scans peepoGiggles

#

Hold mode works fine ^^

#

Even if GIS and LethalHUD both have it enabled

floral pier
floral pier
half nexus
floral pier
half nexus
flint plinth
#

the nodes are indeed smooth

onyx musk
#

That's uh.. normal

Screenshot_1901.png
half nexus
onyx musk
#

Bruh

peak badge
#

it'll be in like 2 hours, if you're playing you're probably just better off downgrading one version of gooditemscan (idk what this update provided though tbh)

#

:p

#

you're lucky my pc got fixed yesterday night

#

smh test

dusky smelt
#

@half nexus [15:45:01.1154679] [Error : Unity Log] MissingFieldException: Field not found: UnityEngine.RectTransform GoodItemScan.ScannedNode.rectTransform Due to: Could not find field in class
Stack trace:
Dawn.Utils.ForceScanColorOnItem.LateUpdate () (at ./src/Utils/MiscScripts/ForceScanColorOnItem.cs:36)

#

this gets spammed in console

rain talon
dusky smelt
#

oh

#

no

rain talon
silk summit
#

They don't looks jittery anymore

#

they smooooth now

#

but what are the colour values that vanilla uses?

half nexus
wild talon
#

Scannodes are fixed??

onyx musk
#

no

#

Still broken with DawnLib

half nexus
half nexus
half nexus
wild talon
#

Im confused!!!!

strange igloo
#

No more jitters or fps drops from scan nodes

#

LethalHud will need an update though

peak badge
wild talon
#

fix Xu fix!!

strange igloo
#

It was already fixed

floral pier
frank minnow
#

the patch in v0.9.14 doesn't actually work

#

GIS broke xu's changes again after they were implemented

#

lol

#

i think she's fixing it again (in what i assume will be v0.9.15)

#

but the situation is "gooditemscan latest and dawnlib latest do not currently function together" regardless

wild talon
#

ye

peak badge
#

Wait what he broke it again?

#

@half nexus test.

wild talon
#

YES

#

HE DID

peak badge
#

Hmm latest is 2.1.0

#

I thought I updated for that one

#

I'll test it more when I'm on the pc

half nexus
peak badge
half nexus
#

Me neither Fish

wild talon
#

whats the issue?

frank minnow
#

@peak badge @half nexus it's the issue you already acknowledged in the dawnlib thread

#

the missing recttransform field

# 
[Info   :   BepInEx] Loading [DawnLib 0.9.14]
[Info   :   BepInEx] Loading [GoodItemScan 2.1.0]

MissingFieldException: Field not found: UnityEngine.RectTransform GoodItemScan.ScannedNode.rectTransform Due to: Could not find field in class
  at (wrapper dynamic-method) GoodItemScan.Scanner.DMD<GoodItemScan.Scanner::DisableScanNode>(GoodItemScan.Scanner,GoodItemScan.ScannedNode)
  at System.Collections.Generic.List`1[T].ForEach (System.Action`1[T] action) [0x0001e] in <1071a2cb0cb3433aae80a793c277a048>:0 
  at GoodItemScan.Scanner.HandlePendingRemovals () [0x00018] in ./Scanner.cs:213 
  at (wrapper dynamic-method) GoodItemScan.Scanner.DMD<GoodItemScan.Scanner::UpdateScanNodes>(GoodItemScan.Scanner)
  at GoodItemScan.Patches.HUDManagerPatch.UpdateScanNodes (System.Action`2[T1,T2] orig, HUDManager self, GameNetcodeStuff.PlayerControllerB playerScript) [0x00000] in ./Patches/HUDManagerPatch.cs:63 
  at (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Hook<HUDManager::UpdateScanNodes>?408679996(HUDManager,GameNetcodeStuff.PlayerControllerB)
  at (wrapper dynamic-method) HUDManager.DMD<HUDManager::Update>(HUDManager)

(Filename: ./Scanner.cs Line: 213)
strange igloo
#

I'm not seeing this throw

#

Are you sure it's not cus of LethalHud?

peak badge
strange igloo
#

I turned it off

frank minnow
#

i dont use lethalhud

strange igloo
#

Yeah I'm not seeing this throwing in my logs with both the latest versions

frank minnow
#

and this error throws as soon as i scan anything

strange igloo
#

Weird

frank minnow
#

and totally breaks the hud

peak badge
#

Oh that is also a weird error

strange igloo
#

HUH

#

it works for me

peak badge
#

I actually don't know where that error even comes from

strange igloo
#

Yeah it may be from some other mod

peak badge
#

I'm on phone but I'm not seeing anything much

frank minnow
#

i mean

#

come to think of it

#

i guess dawnlib isn't even in this error

#

maybe im conflating it for the same issue dawnlib was experiencing

strange igloo
#

Yeah I was gonna say lol

frank minnow
#

and it's actually just a GIS issue

peak badge
#

It feels like it's an error inside of good item scan itself

#

But like

floral pier
peak badge
#

How do you even do this to yourself

strange igloo
#

If it's Good Item Scan why is it fine for me though?

peak badge
#

I didn't know it was possible to invoke missing field exception on your own assembly

frank minnow
#

shrugs violently

peak badge
strange igloo
#

Am I safe cus I'm on Linux? lol

frank minnow
#

oh im dyupif

frank minnow
#

im leaving it

wild talon
#

OMG

frank minnow
#

anyways

wild talon
#

WHAT HAPPENED

frank minnow
#

i saw this and totally forgot about it until just now

wild talon
#

oooh lol hehe

strange igloo
#

Oh that explains a lot lol

frank minnow
#

when i saw somebody post in the thread

#

thanks for enlightening me Pain Elemental (explodingturtle)

strange igloo
#

@half nexus if there is one suggestion I have, setting the default text color to black and not keeping the vanilla style makes scan nodes really hard to read sometimes. You should prolly change that

#

I fixed it myself manually lol

wild talon
#

WHAT

#

why is it black??

wild talon
#

who has to fix the issue? test or sciencebird?

drowsy abyss
#

Good Item Scan

half nexus
half nexus
wild talon
half nexus
wild talon
#

white letters

#

haii test

#

goodmorning

half nexus
half nexus
wild talon
half nexus
#

Yes, very mean greed

wild talon
wild talon
half nexus
wild talon
#

are you talking bout the sciencebird issue?

half nexus
#

Yeah. Or am I misunderstanding the message by @drowsy abyss

drowsy abyss
#

No i was just being funny

#

I just saw this thread and decided to message the name of it

#

unfortunate that the one time i chose to do it led you to believe I was answering a question

#

my bad

half nexus
#

that's funny

#

I blame @floral pier for being gullible greed

How dare you misinterpret my buddy's message?

floral pier
wild talon
#

I completely understood your message as a joke

#

Same as when everyone else types the name of the mod because funny hehe

#

Didnt realize it could be seen as you answering me lol xD

#

Test is just so gullible hehe

jolly hornet
wild talon
jolly hornet
#

so much for downloading VanillaImprovements and forgetting about it

wild talon
#

the one that gives like a cool green effect when you scan

#

idk how its called lel

jolly hornet
wild talon
#

add Starter Pack stare

jolly hornet
#

I'll try to tinker with Sciencebird

wild talon
#

ok no more shameless plug

#

now is shameful plug

jolly hornet
#

it's another mod pack on thunderstore?

#

(by you?)

wild talon
#

maayyyyybeeeeee :3

#

-# yes

jolly hornet
#

heheh

#

okay, I'll take a look

#

although that means if i have incompatiblility issues, I'm bitching about them here

#

(please help if I can't figure it out)

wild talon
#

starter pack idea is to get all performance and bugfixes mods into one place, they SHOULD work with most mods, but since v80 stuff is still a bit unstable, there might be issues so please report them!

frank minnow
# silk summit but what are the colour values that vanilla uses?

for you (and any other lovely folks that want vanilla's palette back)

  • tool text color should be #00B2FF (RGB: 0,178,255)
  • tool text background color should be #0B00B2 (11,0,178)
  • scrap text color should be #58FF00 (88, 255, 0)

the rest are correct by default

wild talon
#

does anyone have a side by side difference with vanilla and gooditemscan colors?

#

i didnt even know they were different

frank minnow
#

the main difference is that gooditemscan makes the text black on blue/green scan nodes

#

which makes them significantly harder to read

#

in vanilla it is cyan and neon green respectively

wild talon
#

whaaat

#

i never noticed that

frank minnow
#

the tool text background color is also slightly lighter (11,66,178; vanilla has no green component in this color)

wild talon
#

is that from the new update?

frank minnow
wild talon
#

oooh

frank minnow
#

which i havent been using until now because it was broken with SBT's scan highlights

wild talon
#

thats... weird

wild talon
#

ill check rn

#

wait what why

#

why is it black

#

test why is it black kjfhsajfkasjds

wild talon
#

im so confused as to why its black now

frank minnow
#

judging by chat history it was probably just a mistake

#

but it is the case nonetheless

wild talon
#

wait does gooditemscan add like a cool animation when scanning?

#

yeah definitely

#

it looks so smooth omg i love it

#

i do wish the total scrap prompt wouldnt appear when only scanning 1 item

rain talon
frank minnow
#

enemy text color defaults to black for me

#

which is correct

#

#000000

#

0,0,0

#

idk how it gave you a diff value

rain talon
wild talon
#

yeah gis default has black text

rain talon
frank minnow
#

oo yeah

rain talon
#

Would be neat to be able to change color of the scan depending of the Danger Level of the creature. (I know it's just text on the bestiary)
Like for example, the black/red one would be smth like
"FCUK RUN!!!!"

rain talon
#

scanning this item from UsualScrap, causes this log to show

image.png
upper blaze
half nexus
#

So... This is on UsualScrap to fix.

Though, I could make the system more robust to avoid throwing exceptions like this

wild talon
half nexus
wild talon
#

idk on who this is

half nexus
#

It's biodegradable

wild talon
#

OMG