#Premium Scraps

1296 messages Β· Page 2 of 2 (latest)

west dove
#

Maybe your version of TypeLoadExceptionFixer you got cached is different from the TS release?

bright stratus
#

there is only one release on TS though

#

one difference is that I'm on Linux and running the game through wine/proton but I don't believe that should affect this

#

okay this is unrelated but interesting, it seems like there's maybe localization stuff in printing of some instructions from EntranceTeleportOptimizations (, vs .). Noticed this because I'm looking at a diff between the original log and mine, where mine is mostly just missing the TypeLoadExceptions

#

the only mod difference I can notice is that BFLABP doesn't do anything since of that issue where it sees that space under linux is under 10 GB, so I guess I'll install the workaround for that if there was one

#

no idea why that would affect anything though

#

hold on... how the fuck is PremiumScraps here? It's not even close to being loaded by this point

bright stratus
bright stratus
#

okay, I probably figured out why removing TLEF (TypeLoadExceptionFixer) fixes some issue, and it's because of this code:

// Note: I removed most code from this method for clarity
private void RegisterCustomTypes()
{
    Assembly[] assemblies = AppDomain.CurrentDomain.GetAssemblies();
    foreach (Assembly assembly2 in assemblies)
    {
        try
        {
            // assembly2.GetTypes() doesn't throw here because of TLEF patcher;
            // normally it'd throw ReflectionTypeLoadException which would
            // cause the assembly to be skipped in this instance (probably)
            RegisterCustomTypes(assembly2.GetTypes());
            break;
        }
        catch (ReflectionTypeLoadException)
        {
        }
    }
}

After this, RegisterCustomTypes(Type[] types) throws because TLEF plugin hasn't loaded yet.

#

I have no idea why I can't replicate this though

#

but basically, this means that the nuclar option of making Assembly.GetTypes just work can have unintended consequences, meaning I should not hook it directly

bright stratus
#

anyways I'll add it to the preloader patcher to make sure the hook is applied in time for sure

bright stratus
bright stratus
bright stratus
#

okay the issue should be fixed in 1.0.1

weary lark
#

Oh wow some things happened here, that was quite an issue
Thanks again Hamunii, you the goat πŸ™Œ πŸ€—

weary lark
bright stratus
weary lark
#

Yep, I'll try the new version later and see if it works then

bright stratus
weary lark
#

Not only that but also my plugins name starts with "z" so it should load last lol

bright stratus
#

damn, ye

weary lark
#

Ok i can confirm the issue has been fixed πŸ™Œ

#

@fleet frost update all your mods in your pack and you should be good to go

broken karma
bright stratus
broken karma
#

My own mod would've had the same issue if I didn't add TLEF as a dependency, since I trigger the Input System in the second line of code in Awake

bright stratus
#

mm I see

broken karma
#

Preload also makes it so I don't have to add a BepInDependency

bright stratus
#

yep

broken karma
#

Otherwise BepInDependency is required to guarantee TLEF to load before your mod does

#

Is why in Content Warning I blanket patch Assembly.GetTypes in preload as well instead of just crossing my fingers hoping nothing triggers it before my mod loads

#

At least TLEF should almost 100% revert all the assembly load fluff to however it worked in V72 and before

bright stratus
#

yep I had the Assembly.GetTypes hook in a preloader, but yeah I did remove it now because of the possible consequences

broken karma
#

Wait it gone?

#

Gotta check a thing real quick lol

bright stratus
#

yeah there was a case where TLEF broke more things because of that hook apparently

broken karma
#

That is strange though, since TLEF made Assembly.GetTypes behave almost the same way as it did in V72 and earlier

#

only difference between V72 and V73 + TLEF 1.0.0 is null types are removed from the array

bright stratus
broken karma
#

I tested it, V72 GetTypes did not throw

#

Likely a bug in old mono, or they weren't up to spec

bright stratus
#

oh right yeah I forgot you did some testing

bright stratus
broken karma
broken karma
#

So I doubt removing nulls caused issues, but it does alter the behavior just a teeny tiny bit from V72

bright stratus
#

I can add the Assembly.GetTypes hook back though and we can just hope it doesn't break anything

broken karma
#

Would have to test extensively first I think just to be sure

#

And the issue with Premium Scraps I believe was just caused by load order right?

bright stratus
broken karma
#

Funny thing about specifically the input system errors, is that they do catch ReflectionTypeLoadException, but IsAssignableFrom throws TypeLoadExceptions instead (which aren't caught)

For specifically that case is why a seperate patch was needed

bright stratus
broken karma
#

I could eventually also check what the behavior for IsAssignableFrom/RegisterCustomTypes was in V72

#

If we want to go for 100% (or as close to) parity with V72

bright stratus
#

not sure if we care about 100% parity as long as everything just works

broken karma
#

Yeah that's the most important part

#

Just saying that if everything in V72 worked, feature parity would likely make everything work in V73 as well

bright stratus
#

true

broken karma
#

TLEF 1.0.1 indeed breaks for me again

bright stratus
#

shit

broken karma
#

(also maybe an idea to move to #dev-general, this is now not really related to Premium Scraps anymore)

bright stratus
#

okay I'll just add the Assembly.GetTypes hook back

weary lark
bright stratus
weary lark
#

Ah ok, its fine then, thanks

weary lark
#

I updated the mod just now
It adds an evil feature for the spanish drink 🀫 😌

vocal zenith
#

spanish bread can spawn and kill you

west dove
#

@weary lark

#

Error happens after the new update

weary lark
#

uuuuh what the hell lol

#

can you share your profile code please

west dove
#

019a288b-132f-c56c-cf11-35a251bf50af

lament geyser
weary lark
weary lark
spice idol
#

lol

#

nice

west dove
weary lark
#

oh shit no, i deleted all the scripts inside abibabou, not just the item but also the audio, the collider etc πŸ’€

west dove
#

☠️

west dove
#

Thy ball has been sent to thy abyss lol

weary lark
# spice idol github:

i removed tracking on my unity project a few weeks ago because it was too big πŸ’€ πŸ’€ πŸ’€ πŸ’€ πŸ’€ πŸ’€ πŸ’€ πŸ’€ πŸ’€

spice idol
#

skull

weary lark
#

lol, im gonna recreate it the best i can

spice idol
#

were you using unity's version control lol

weary lark
#

no

spice idol
#

huh, then idk why it was big, coderebirth's is just fine :p (though obv i dont include anything base game for legality)

weary lark
#

oh yeah no, not big like that but just some "useless files" i thought
and also there was vanilla scripts but thats a detail

#

anyways, this should be easy to recreate, thats just a variant of the soccer ball

spice idol
#

it'll never be the same

meager rose
west dove
#

Does the new version of the mod work at least outside of Abibabou being broken?

#

I downgraded it incase

#

lol

#

@weary lark Mpreg this man

weary lark
#

LMAO

simple pewter
#

Photoshop

meager rose
simple pewter
#

AI generated convo

weary lark
simple pewter
#

STOP

#

I will kill both of u

meager rose
simple pewter
weary lark
simple pewter
weary lark
#

see? it's already almost fully restored

lament geyser
#

Mpreg Abibabou

simple pewter
simple pewter
#

You're being brainwashed

lament geyser
#

Mpreg Zigzag bigbrain

simple pewter
normal saddle
lament geyser
normal saddle
weary lark
#

zigzag55Abibabou lets go

simple pewter
weary lark
#

Listen Kiszony, I'm sorry

weary lark
#

It is uploaded

#

fixed now

weary lark
lusty bronze
#

logs mentioned PremiumScraps specifically

  • Started a solo run.
  • Gone to company.
  • Sold stuff. Modded scrap: (iirc) Out of PremiumScraps there was El Gazpacho, and out of ChillaxScraps there was UNO Card.
  • Bought Jetpack and Shovel.
  • Picked up them, then dropped them.
  • Shovel had Jetpack's holding animation for some reason.
  • Being confused - pick up Shovel.
  • Holdin' nothing, white square in inventory slot, and game is softlocked with constantly repeating message from copiedlog.txt
weary lark
#

oh no

lusty bronze
weary lark
#

Ok so after analyzing the problem, i can say that this should not be possible while playing solo, this effect only run when some other player is using the Controller item on you
Ill try reproducing your steps in the following days, thanks for the report

#

As of right now, im not really sure what happened, but ill try do dig deeper

lusty bronze
#

And, no, not controller from Chillax/PremiumScraps, but rather a gamepad/joystick (technically it's still a controller)

weary lark
#

Yeah this should not be linked to this error

lusty bronze
#

so... your recommendation is just to not use PremiumScraps for solo runs rn?

weary lark
#

wait i think i know what happened

lusty bronze
#

i think I've got 1 guess as well, since you mentioned "solo" specifically

#

might conflict with LethalInternship. Like, some Intern, who should be treated as player, but is actually a mob, could potentially take Controller scrap (and not bring it back since Interns die a lot in my runs) and somehow interacted with it?

weary lark
#

There was something weird going on when grabbing/droping your items, like you had the jetpack animation for the shovel, this should not be my mod's doing
But then you said "Holdin' nothing, white square in inventory slot", what i can understand from that is that there was an item (not null) in your inventory, probably a bugged or glitch item from the interaction with your items (maybe caused by other mods?), this caused my check in IsInControlMode : item != null to pass successfully since the item was not null
But then the white square is the default icon for items that dont have any icons attached to them, or for items that dont have any itemProperties, so the next check item.itemProperties.name == "ControllerItem" fails miserably because itemProperties is null due to the white square of the glitched item
So, to explain it better
This is caused by a problem in my code that happens because of a problem caused by another mod that caused your glitched item
The softlock was expected because i was checking the state of your hold items, which was semi real semi null
What i can do, is to add a check to verify if itemProperties != null which will fix the problem, but your glitch item could theorically still happen so watch out for other mods that could be incompatible with each others and caused this glitch item issue

weary lark
lusty bronze
#

btw, I didn't launch that Save File since softlock, I can try to check it to see if anything's here to help with the problem

weary lark
#

If you can reproduce it easily then yeah it could help determining what caused the bugged white square item

lusty bronze
#

should I perhaps record then?

#

instead of screenshootin'?

weary lark
#

if not, then dw, ill try to fix that by adding some safety checks in the following days

weary lark
lusty bronze
#

Google Disk , bugged Shovel animation happened, however, null item nor softlock happen

weary lark
#

hmm yeah ok

#

so this must have been a really rare case where the grab animation wasnt completely over ? im not sure

loud pecan
lusty bronze
loud pecan
#

I swore there was a way to send the list without needing to import a code. I was hoping I could look it over while at work for ya

vocal zenith
#

i mean

#

screenshots

lusty bronze
#

you asked for a pack

vocal zenith
#

but that would be a lot

lusty bronze
#

it was easier for me to send a code rather than multiple images, yeh

spice idol
loud pecan
loud pecan
# lusty bronze : (

Also bad news. I looked over it briefly as im about to go into a case again right now and there are a lot of mods in there that are gonna be broken for v73 or have been broken prior. Premium Scraps is most definitely not the culprit here. After my case is over I'll give you the names of the mods you should highly consider removing.

lusty bronze
spice idol
loud pecan
loud pecan
#

The evil effect was either Harry Mason or the job application cause that was grabbed by a cursed player πŸ˜† so I was trying to figure which of the two it was cause I swore Harry Mason never had a cursed effect before.

simple pewter
vocal zenith
#

not as good as ABIBABOU SID

weary lark
#

You want a job my friend? Lmao πŸ—Ώ plink

simple pewter
weary lark
#

Damn...

vocal zenith
#

wtf?@weary lark

west dove
#

I'm not too big a fan of the SSS christmas stuff though

weary lark
west dove
#

I can't think of what else might make them appear stretched

weary lark
#

I tested in my dev profile

#

Hmmmm

#

Idk what's happening maybe I broke it accidentally?

west dove
#

Possible

loud pecan
weary lark
#

Well yeah I think, but either way it should not be wide like that even with the Wide version

weary lark
#

I'll check it later and see if I can fix it (+add something for glitch at the same time)

weary lark
# west dove Possible

ok so i can confirm i broke it lol, but for now i dont know how to fix that???? wait a moment ill try to find

#

ok i found the problem erjhtgqjrsdkkhntgkerj

weary lark
#

@loud pecan @west dove it is done

hollow canyon
#

Our friend POV , we absolutely didnt leave him a chance to survive crine

#

we were three in poltergeist mode

weary lark
#

Ah very cool (this is epic lmao) but I found this situation to be perfect because of the recent fix in the poltergeist mod by @carmine nacelle (thanks again btw!)

Like before the update, using the item on ghost pov would have activated the effect several times already so if 3 players are doing it it was even worse lol

Anyways, glad you're enjoying the Fake airhorn hehehe

carmine nacelle
#

Lol, that's evil

weary lark
#

2.4.4

  • Changed ShipInventoryUpdated soft dependency detection to be compatible with the latest update
  • Moved the Fake airhorn scan node to be closer to the vanilla Airhorn scan node position πŸ₯Έ
  • Updated some christmas assets
  • Fixed Galvanized square steel spawned by Basics of architecture having a desynced position for host players
vocal zenith
#

@weary lark basics of architecture doesnt give galvanized square steel at all now

weary lark
#

😳 what

#

it was working for me whats going on

vocal zenith
#

hold on

#

oh wait nvm

#

i need to generate a log for you later

loud pecan
#

I can unfortunately say it works in my pack πŸ˜’ I forgot when I reset my configs that it turned the book back on.....now I have to hear that damn metal dropping sound again. I dont know why but I just cant stand that sound from the galvanized square steel (I know its meant to be annoying ) lol πŸ˜‚ and I have players who will purposely troll me with it. I decided screw it im a keep it on.

weary lark
#

Even me I'm sometime annoyed by this item lol so I understand you

vale jolt
#

hello, havent played in a while. i reported an issue caused when using imperium and this mod a while ago, would anyone know if thats been fixed? think it was spawn animation

vocal zenith
#

disable betterspraypaint and it will let you use imperium with the mod

#

the dev doesnt know how to fix this

vale jolt
#

hm, unfortunate. i only had imperium to fix OTHER bugs and issues to ill try imperium first. thanks

weary lark
#

Oh yeah for this issue Purple is right
But there is also something you can do in the Config to fix that without removing any mods let me double check

#

You can enable player spawn skip animation in imperium config

vale jolt
#

ya i was the one to figure that out πŸ’€. such a nightmare, i was just hoping it was fixed by now, but thank you

weary lark
#

Lmao yeah it's def not fixed

normal saddle
weary lark
#

Lmao that's a legend French moment right there

west dove
simple pewter
#

It's like mona lisa being painted

normal saddle
#

The crouton is my voice yoiled

stark yacht
#

FiEyennn

weary lark
#

πŸ’€ lethal sponge lol

vague wave
#

Seems like this mod crashes my game when Imperium is enabled
V73 btw with Imperium 1.1.1

Is this a known issue?

#

Btw i'm very eagar to try this mod, it looks very fun

weary lark
vague wave
#

Oh, that worked
Thank you very much

west dove
#

@weary lark Did you reverse the cursed player effect for the stick?

#

LMAO

#

Cus the stick is nuts rn and noone in our lobby is cursed

#

XD

weary lark
#

Oh 😳

#

Hmm maybe i did an ooopsie? lmao

west dove
#

I think so, cus we kept getting sent flying to our deaths

#

LMAO

#

VV funny at least

#

XD

weary lark
#

lmao πŸ˜‚ well ill see if i can fix it

west dove
simple pewter
#

Make it default, and strenghten the stick further

weary lark
#

Lmao that would be cool

west dove
simple pewter
#

I only have seen only one person being angry abt it

west dove
#

Nah Jacu and Whovian got angry when you killed them during an active round with it on Titan, if it stays broken it can only be used on the Company and not everyone can contain themselves lol

simple pewter
west dove
#

It does just send you directly in the air immobile to fall to your death which during active games can be annoying

simple pewter
#

Jacu was in fact targeted but whovian got yeeted at perfect frame

west dove
simple pewter
#

There's only one parrot I shall kneel before

#

And it's @onyx talon's parrot

#

But like I said
I would rez asap if you havent took defib with you at the time bruh

#

I would buy it, but we're broke most of the time

#

And like I said
Gatekeeping (such as destroying or leaving on the middle of nowhere) corpses from rez'ing is not fun
-# unless justified by certain circumstances

onyx talon
simple pewter
simple pewter
onyx talon
simple pewter
weary lark
severe kelp
#
Stack trace:
UnityEngine.Object.get_name () (at <c39a522eee05469b8171a6cfeb646c59>:IL_0001)
PremiumScraps.CustomEffects.ControllerMovement.IsInControlMode (GameNetcodeStuff.PlayerControllerB player, PremiumScraps.CustomEffects.Controller& controller) (at <d753a0b5ac114f01a0887bdce9748b7c>:IL_002E)
PremiumScraps.CustomEffects.ControllerMovement.PlayerVectorPatch (GameNetcodeStuff.PlayerControllerB player, PremiumScraps.CustomEffects.ControllerMovement+ControllerActions action) (at <d753a0b5ac114f01a0887bdce9748b7c>:IL_0029)
PremiumScraps.Utils.ControllerPlayerControllerBPatch.PlayerLookInputControllerPrePatch (GameNetcodeStuff.PlayerControllerB __instance) (at <d753a0b5ac114f01a0887bdce9748b7c>:IL_0001)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::PlayerLookInput>(GameNetcodeStuff.PlayerControllerB)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::LateUpdate>(GameNetcodeStuff.PlayerControllerB)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Trampoline<GameNetcodeStuff.PlayerControllerB::LateUpdate>?1981291704(GameNetcodeStuff.PlayerControllerB)
CodeRebirth.src.Patches.PlayerControllerBPatch.PlayerControllerB_LateUpdate (On.GameNetcodeStuff.PlayerControllerB+orig_LateUpdate orig, GameNetcodeStuff.PlayerControllerB self) (at ./src/Patches/PlayerControllerBPatch.cs:257)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Hook<GameNetcodeStuff.PlayerControllerB::LateUpdate>?757292872(GameNetcodeStuff.PlayerControllerB)``` had a shovel in my inventory swapped moons when saw it was gone swapped over to it and it froze my character
severe kelp
#

[Error  : Unity Log] NullReferenceException while executing 'performed' callbacks of 'Movement/SwitchItem[/Mouse/scroll/up,/Mouse/scroll/down]'
[Error  : Unity Log] NullReferenceException
Stack trace:
UnityEngine.Object.get_name () (at <c39a522eee05469b8171a6cfeb646c59>:IL_0001)
ChillaxScraps.CustomEffects.DarkBook.PreventPocket (GameNetcodeStuff.PlayerControllerB player) (at E:/Productions/LethalCompany-Mods-dev/ChillaxScraps/ChillaxScraps/CustomEffects/DarkBook.cs:108)
ChillaxScraps.Utils.ChillaxPlayerControllerBPatch.ScrollMouse_performedDarkBookPatch (GameNetcodeStuff.PlayerControllerB __instance) (at E:/Productions/LethalCompany-Mods-dev/ChillaxScraps/ChillaxScraps/Utils/Patches.cs:44)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::ScrollMouse_performed>(GameNetcodeStuff.PlayerControllerB,UnityEngine.InputSystem.InputAction/CallbackContext)
UnityEngine.InputSystem.Utilities.DelegateHelpers.InvokeCallbacksSafe[TValue] (UnityEngine.InputSystem.Utilities.CallbackArray`1[System.Action`1[TValue]]& callbacks, TValue argument, System.String callbackName, System.Object context) (at <7d67996a352a4f4fa0df2b7c9570fda6>:IL_001B)
UnityEngine.InputSystem.LowLevel.<>c__DisplayClass7_0:<set_onUpdate>b__0(NativeInputUpdateType, NativeInputEventBuffer*)
UnityEngineInternal.Input.NativeInputSystem:NotifyUpdate(NativeInputUpdateType, IntPtr)

[Error  : Unity Log] NullReferenceException while executing 'performed' callbacks of 'Movement/SwitchItem[/Mouse/scroll/up,/Mouse/scroll/down]'``` ok chillaxscraps now i found the shovel it was invisible after i quit the first time
#

Ima restart again leaving the shovel to see if i can get another error out

weary lark
#

Hmm I'm confused these errors says an object was null? Can you reproduce this consistently or not with your pack?

severe kelp
#

when i have gotten errors like this i have swapped moons, in one case it made a pearl from pikmoons pink and when i picked it up i got frozen, the other time i had a shovel in my inventory, the shovel vanished and when i swapped to it is when i got frozen, i left and disabled premium scraps relogged, i later found the shovel invisible picking it up did not freeze me tho, but i could not swap it i will at some point see if i can do this with just the mods

severe kelp
#

019dd4c6-8b1a-b10c-2ec7-ec61e3b7f902 Heres the current pack both scraps are disabled

severe kelp
#

Current testing i have no clue, however thinking on it rn the items that did this were both on the pikmoons, even more so both items are ones that ether spawn rightaway or when doing something

#

ima test again in my main pack, the pearl spawns when attacking the clam clam, and the shovel spawns at the gate, i have an idea

severe kelp
weary lark
#

Ok thats what i thought
This already happened to another user once and the problem was very similar, another mod's scrap broke (for some reasons) then my patches are no longer working because of the item not being here anymore
Your player freezing is expecting as this patch is supposed to freeze your local movement until you receive a movement call from another player using the controller on you
Now of course this should never happen if no one is using the controller on you, but this can still happen whenever an unexpected error occurs inside the controller patch (this means, whenever an item is broken by another mod)

#

I hope this other mod will get fixed soon, or maybe, the conflict will be resolved

severe kelp
#

i sent a video i recorded over to them

west dove
#

It also becomes sideways for every player after lol

#

I picked up an entirely different one and it was sideways

#

vv odd