#darmuhsTerminalStuff (3.7.7) - Terminal Mod

1 messages · Page 7 of 1

wraith minnow
#

This with just OpenBodyCams

simple sierra
#

Okay so that’s something I can look into

wraith minnow
#

I think the issue is when putting in commands, you have the mod turn off the radar map but not body cam?

simple sierra
#

Yes if the vanilla radar map is enabled I disable it for the same commands I would disable my own things

wraith minnow
#

Perhaps do that for the body cam as well

#

Here’s the result with your mod also enabled

simple sierra
#

I am not able to look currently but I’m hopeful I can double check if openbodycams is active and NOT hide the radar map if it is

wraith minnow
#

That’s good

simple sierra
#

If you want both to hide id just recommend using my minicams command and disabling view bodycam from openbodycams

#

It’s essentially the same type of command but the bodycam is in the top right

wraith minnow
#

I'll try it out

wraith minnow
#

Here's another issue I encountered

#

I upgraded vitals, but it now carries over to other profiles, plus I get stuck near the end of the video

#

@simple sierra

#

To better clairfy, I got the upgrade on one profile, but the upgrade transfers to all other profiles I load up

cunning moss
#

wait I saw a ping in here, where it at

#

oh here nvm

#

it isn't intended for the bodycam to stay visible if the map disappears, no

#

I'll have to take a look at that issue

#

are you trying to implement perspective change in OpenLib? or are you and @tough adder referring to something else?

wraith minnow
#

I should correct myself on something: the radar map disappears regardless of what config TerminalScreen is set to

simple sierra
simple sierra
simple sierra
cunning moss
#

I believe @wraith minnow tested without the mod installed, so I probably forgot to hook when the vanilla map gets disabled

wraith minnow
simple sierra
#

okay yeah that is intended so long as the upgrade is actually enabled in the config

wraith minnow
#

that's the issue I'm having

simple sierra
cunning moss
simple sierra
cunning moss
#

oh I see

simple sierra
#

thats why i still recommend OpenBodyCams hahaha

#

Most of my improvements have been on the culling mask and getting things to show properly between different mods that modify the player body layer

cunning moss
#

there's still some stuff I have to revisit as well, I have been so busy I haven't added support for the ReservedItemSlot item attachments

simple sierra
simple sierra
#

i had no idea that was added lmao

simple sierra
cunning moss
cunning moss
simple sierra
#

but also I allow for my mirror command to still work alongside vanilla and if the mirror command is called then the vanilla map needs to be disabled

#

the rest of my commands I added the warning if your command is enabled or the warning to let people know the vanilla map is disabled due to the certain commands being enabled

#

when it comes to your stuff, I dont want to force stop anything so if you have expected logic when it should be enabled that's fine. I just want to emulate it

cunning moss
#

is there anything you need on my side? I'm not sure I'm totally understanding what you meant by #1180739684654121091 message

simple sierra
#

let me find the code to show you

#

would be better than me trying to explain it I think

#

Line 77 where it says !Plugin.instance.splitViewCreated means that my other cams commands have not created the smaller image that I use for minicams/minimap and overlay when it's resized

#

so that is what determines whether the image should be enabled or disabled for vanilla map, since vanilla uses (bool)Plugin.instance.Terminal.displayingPersistentImage

#

hopefully that explains things better or gives you a better idea of what im yappin about

cunning moss
#

right, so all this is to prevent the map from displaying when you have other things that take priority over it?

#

did you need a way to check if my body cam PiP is enabled or something?

simple sierra
simple sierra
#

Can you reproduce with logging config options all enabled and post the logs?

simple sierra
#

Lol no problem, still confused what exactly is causing the issue for you. Hard to track down the inconsistent ones

winged panther
#

my client keeps freezing on the terminal, this time when typing view monitor. but there were no errors in log>

simple sierra
#

You might want to turn on the debug log settings for this mod

#

Those will give you useful logs for troubleshooting

winged panther
#

Ok I turned it o

#

Is it ok if I add view monitor as a command for opening the map?

simple sierra
#

yes that is fine, you can use that as a custom keyword

winged panther
#

Ok let me try that too

winged panther
#

I think what broke it was general improvements fast cam switch. Also changing it to client only helped. Didn’t get a chance to do testing with extensive logging as the time to play with the group was already scheduled lol

simple sierra
winged panther
#

Could it be with more company? I just realized that issue didn’t happen before and we had 6 people today. Could it be like desyncing on who the target is?

simple sierra
#

I dont think so

#

i wouldnt be able to point at anything without a log

winged panther
#

Ok I’ll get some logs tomorrow

simple sierra
#

feel free to give me a shout if any bugs are discovered with v65

naive cedar
#

got this bug with the terminal. Also got this on v64 so it's not caused by v65. When loading a save sometimes the terminal starts with a blank screen and doesn't activate properly when interacted with. This can happen with saves created as recently as the same hour. I created this save, closed the game, and when i reopened it and loaded that save, it bugged the terminal. creating a fresh save fixes it, so idk what causes it

image.png
simple sierra
#

Can I get full logs

#

most likely something errored out before that one

naive cedar
simple sierra
#

can you see if you can reproduce the issue with WeatherRegistry disabled? Looks like it threw an error at Terminal.Start which could cause issues for anything else patched into terminal start

Parameter name: key
Stack trace:
System.Collections.Generic.Dictionary`2[TKey,TValue].TryInsert (TKey key, TValue value, System.Collections.Generic.InsertionBehavior behavior) (at <787acc3c9a4c471ba7d971300105af24>:IL_0008)
System.Collections.Generic.Dictionary`2[TKey,TValue].set_Item (TKey key, TValue value) (at <787acc3c9a4c471ba7d971300105af24>:IL_0000)
WeatherRegistry.Definitions.CurrentWeathers.SetWeathersFromStringDictionary (System.String serializedWeathers) (at ./Definitions/CurrentWeathers.cs:153)
WeatherRegistry.Patches.SetPlanetsWeatherPatch.GameMethodPatch (System.Int32 connectedPlayersOnServer, StartOfRound __instance) (at ./Patches/SetPlanetsWeather.cs:49)
(wrapper dynamic-method) StartOfRound.DMD<StartOfRound::SetPlanetsWeather>(StartOfRound,int)
WeatherRegistry.Patches.TerminalStartPatch.Postfix (Terminal __instance) (at ./Startup.cs:322)
(wrapper dynamic-method) Terminal.DMD<Terminal::Start>(Terminal)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Trampoline<Terminal::Start>?2140091534(Terminal)
LethalLib.Modules.Enemies.Terminal_Start (On.Terminal+orig_Start orig, Terminal self) (at <64fae9f52f324ab2a8065723b0759a64>:IL_0350)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Hook<Terminal::Start>?1801601100(Terminal)
naive cedar
#

ok

naive cedar
simple sierra
#

so yeah might wanna let mrov know about that error

naive cedar
#

it's probably caused by the newest update which added the feature to remember what weather was there when the save was last played

simple sierra
#

maybe, I've not touched much of the weather stuff so I wouldnt know

#

seems to me one of his key values in his list is returning null

naive cedar
#

considering it only happens on saves that were already in progress, that's the closest point of reference i have

simple sierra
#

gotcha, yeah I'd just report the issue here and see if he can figure it out

winged panther
winged panther
simple sierra
#

I had to do something similar for LethalConstellations when generating config items for each moon

simple sierra
#

smol update

#

[3.6.6]

  • Added Soft-Compatibility for CruiserTerminal.
    • Commands that quit the terminal now properly quit from the CruiserTerminal
    • Added config items to permit/deny certain keywords from the CruiserTerminal. Use the CruiserKeywordList as either a permit or deny list.
#

darmuhsTerminalStuff (3.6.6) - Terminal Mod

radiant lodge
#

Hello, If you type "gamble" without any arguments or any incorrect argument it will print the exception and all commands wont work until you type clear and get another error

simple sierra
radiant lodge
#

oh

#

sec

#

[20:24:28.4773645] [Error : OpenLib] node detected as NULL

#

This is an attempt to execute any command

simple sierra
#

Checked it out in-game and I know of the issue. Have a fix in another mod I'll bring to this one. I think this is the only command that takes input that requires confirmation after a valid input has been detected so just need it for this one command 😅

#

sorry for missing it 🙂

radiant lodge
#

btw when I use tp [name], does it do "silent autocomplete"?

#

If I write only the first letters of the nickname

simple sierra
#

in a recent update the name matching for tp was improved to try to match directly to another player's name

radiant lodge
#

Good!

simple sierra
#

It wasnt tested as much as I'd like, so if you notice any issues please let me know

#

here's the update where it was changed

#

oh wait, I dont think tp uses the name matching right now, only switch

#

i can change that 🙂

simple sierra
#

[3.6.7]

  • Fixed issue with gamble command where input failures would cause the terminal to get stuck waiting for a confirm/deny
    • Thanks @radiant lodge for the report on discord
  • Fixed/Updated tp name matching to properly take input for a player name and tp the best matching name
  • Added handling for when no names match the input provided to the better name matching used by switch & tp
#

darmuhsTerminalStuff (3.6.7) - Terminal Mod

peak patrol
#

I don't think the compatibility with CruiserTerminal works quite right. I was able to use the control commands from the cruiser even though they were set to Deny by default

#

I'll try to get logs for it

peak patrol
#

No logs since I forgot to turn on debug for the mod, but heres a video

simple sierra
#

LOL I'll have to figure out a fix for that. Looks like the command still runs AND it shows the blocked page

#

thanks for finding that

summer raft
late niche
#

having this issue again reboot in ghost codes also seemed to not do anything basically same pack just updated but 0192e759-06e0-3077-b230-44d812c8107a

📎 LogOutput.log
simple sierra
# late niche having this issue again reboot in ghost codes also seemed to not do anything bas...

see if the issue persists after disabling weather registry please

  at System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) [0x0001e] in <787acc3c9a4c471ba7d971300105af24>:IL_001E 
  at WeatherRegistry.WeatherSync.ApplyReceivedWeathers (System.String weathers) [0x0006a] in ./WeatherSync.cs:99 
  at WeatherRegistry.WeatherSync.WeathersReceived (Unity.Collections.FixedString4096Bytes oldWeathers, Unity.Collections.FixedString4096Bytes weathers) [0x00022] in ./WeatherSync.cs:76 
  at Unity.Netcode.NetworkVariable`1[T].Set (T value) [0x0001f] in <895801699cfc4b4ab52267f31e2a4998>:IL_001F 
  at Unity.Netcode.NetworkVariable`1[T].set_Value (T value) [0x00045] in <895801699cfc4b4ab52267f31e2a4998>:IL_0045 
  at WeatherRegistry.WeatherSync.set_Weather (System.String value) [0x00000] in ./WeatherSync.cs:49 
  at WeatherRegistry.WeatherSync.SetNewOnHost (System.String weathers) [0x0006e] in ./WeatherSync.cs:62 
  at WeatherRegistry.Definitions.CurrentWeathers.CallSync () [0x0000d] in ./Definitions/CurrentWeathers.cs:81 
  at WeatherRegistry.Definitions.CurrentWeathers.SetWeathers (System.Collections.Generic.Dictionary`2[TKey,TValue] weathers) [0x00043] in ./Definitions/CurrentWeathers.cs:129 
  at WeatherRegistry.Definitions.CurrentWeathers.SetWeathersFromStringDictionary (System.String serializedWeathers) [0x000a5] in ./Definitions/CurrentWeathers.cs:163 
  at WeatherRegistry.Patches.SetPlanetsWeatherPatch.GameMethodPatch (System.Int32 connectedPlayersOnServer, StartOfRound __instance) [0x000f2] in ./Patches/SetPlanetsWeather.cs:49 
  at (wrapper dynamic-method) StartOfRound.DMD<StartOfRound::SetPlanetsWeather>(StartOfRound,int)
  at WeatherRegistry.Patches.TerminalStartPatch.Postfix (Terminal __instance) [0x007e3] in ./Startup.cs:322 
  at (wrapper dynamic-method) Terminal.DMD<Terminal::Start>(Terminal)```
vernal shard
#

oh, not THAT again

#

how does this happen

simple sierra
vernal shard
#

is that, like

#

super bad?

#

also hi darmuh 🤭

simple sierra
#

hi lol

#

I think those can usually be ignored it's just like failed soft compatibility

#

weird that it says that after ghostcodes because I dont have any soft compat for that mod LMAO

vernal shard
simple sierra
#

yeah I saw that too lmao

#

I'd bet the mod is probably no longer necessary or no longer does what it intended

image.png
vernal shard
#

11 months?

#

bruh don't touch that 😭

#

how nice that no other logs are present

image.png
simple sierra
#

yeah... KEKW

#

that's why I'm asking if disabling weather registry in the profile causes the issues to go away or not

#

cant really check rn i'm at work 👀

vernal shard
#

i mean

#

disabling registry would prevent this error

simple sierra
#

but prob doesnt resolve the root issue yeah lol

vernal shard
#

but i can bet that Registry is not the sole cause of this happening

#

and so i dig deeper 🫡

simple sierra
#

if you're looking into it you can prob go toggle some of my debug log config items on to make sure it isn't any of my stuff

#

I'm pretty doubtful it would be tho shrug

naive cedar
vernal shard
#

exactly

late niche
#

alright disabling registry and removing the centipede lag launching it now see y'all in like 20 mins lol

vernal shard
#

alright, I see the fucking error

#

and I was SURE it was resolved already

#

aaaaargh

#

this throws

late niche
#

yippee time to restart computer and try again to launch company lol

image.png
simple sierra
late niche
simple sierra
#

wild, what kinda specs does your computer have?

summer raft
simple sierra
#

that would explain why restarting would fix it, he's clearing RAM usage that way lol

simple sierra
vernal shard
#

no

#

i mean

#

but it seems like the issue is elsewhere

#

will find, will fix

simple sierra
#

gotcha, no worries

#

do you have nullable in your project?

#

You could set ES3.Load<string>(SaveKey, GameNetworkManager.Instance.currentSaveFileName to a nullable string and then check if it has a value

#

something like

string? saveString = ES3.Load<string>(SaveKey, GameNetworkManager.Instance.currentSaveFileName;

if(saveString.HasValue)
    WeatherManager.currentWeathers.SetWeathersFromStringDictionary(saveString);```
#

actually ignore everything i've said I looked at the error again lol

vernal shard
#

the error comes from the fact that moon list changed between sessions

#

OH I THINK I SEE IT

#

i've accounted for the moons being removed, but not added!

#

fuck

simple sierra
#

yeah I was jumping between your repos trying to figure it out lol

vernal shard
#

will check

simple sierra
#

I was wondering how a valid planet name would not be a valid key in your dictionary

simple sierra
# peak patrol

btw I have a fix for this ready but it requires updating OpenLib that will break current/older versions of terminal stuff, so will probably push something later tonight when no one is playing

#

I needed to update an OpenLib event to make it more useful 🙂

late niche
simple sierra
#

take what I say with a grain of salt tho, only repeating information I've read elsewhere

late niche
#

does fix the scrolling

#

sucks that it kills code rebirth tho

simple sierra
#

how many moons do you have 👀

late niche
#

uh good question

simple sierra
#

also yeah it looks like mrov figured out the issue and is working on trying to resolve it

late niche
simple sierra
#

all that with 8GBs of ram 😮

#

hahaha ikea? Loading from data: for IKEA: iterations at 0,

late niche
simple sierra
#

dang no pictures

late niche
#

damn i have 106 moons?

image.png
#

if im reading that correctly atleast

simple sierra
#

it does count the vanilla ones too

#

so probably more like 106-12*

late niche
simple sierra
#

lmao nice

late niche
simple sierra
#

the fallen A is a nice touch for sure

late niche
#

got thrown to the roof lol

#

anyway any other moons you want to see?

simple sierra
#

haha I appreciate the screenshots but I'm good now

late niche
#

anyway if y'all want the logs of going to ikea getting put on the roof and dying have fun with that lol

📎 LogOutput.log
simple sierra
#

any issues besides that? lol

late niche
#

nah even got a ghost code while i was up there of the ghost saying shit lol

simple sierra
late niche
#

clearly something bad happened according to the ghost lol

#

i let one of my friends who doesn't even have lethal add fucking anything they want to those messages a while back lol

#

you may not have lethal but you get to influence the ghost

simple sierra
#

haha nice

late niche
#

my guess would have probably been like 50 lol

simple sierra
#

Yeah it is a lot lmao, think most I’ve played with is 15 or so at a time

#

15 on top of vanilla

young stag
#

minimap does not show up when other people are using the terminal

image.png
simple sierra
#

just minimap?

young stag
#

well i think its just the usual view monitor thing or whatever

#

we dont use any of the other cameras this mod adds

simple sierra
#

oh vanilla view monitor does not have support for networked nodes

young stag
#

i see

simple sierra
#

I've only recently started supporting the vanilla view monitor command alongside the mirror command which was a pretty big headache

#

I've always seen networking that bit as also a bit of a headache too

young stag
#

i can see the ship monitor from all the way over here

image.png
simple sierra
young stag
#

ummm not sure which one that is but maybe its in here

image.png
simple sierra
#

okay glad to see it's set to alwayson

#

it's the TerminalScreen config item

#

if you want it to turn off when you leave the ship change it to "inship" (pretty sure that's the name of it)

#

alwayson will just never turn it off

simple sierra
young stag
simple sierra
#

yes

#

it will only ever be on when you are in (the) ship

young stag
#

and this setting still applies?

image.png
simple sierra
#

yes that is a separate setting that affects all 3

young stag
#

alright cool

simple sierra
#

that said, I haven't tested screenonwhile dead with the inuse or inship settings

#

like if you die outside the ship it might not turn on again

#

would be interested in testing that at some point lol

cunning moss
#

huh, why not just check if the spectated player is in the ship?

simple sierra
#

so screen wont be turned on if it was already off, but it at least turns the screen off if it should be off when the player dies

#

think i'll probably need to make an event for switching between spectated player to check if the spectated player is in the ship to keep with the consistent logic

simple sierra
#

gonna have to test this out some time tomorrow when I find the time

image.png
#

3 events in PlayerControllerB update Aware

vernal shard
#

fun

cunning moss
#

oh man

#

making those into events is one way to do it I guess lol

#

I just poll it directly in my update method for OpenBodyCams

simple sierra
cunning moss
#

I suppose that can be helpful if whatever you need to react to that isn't in a behavior

simple sierra
#

it's mostly just future proofing but ye

simple sierra
young stag
simple sierra
#

should be fixed in next update!

#

speaking of,

[3.6.8]

  • Fixed issue with vitals and bioscan upgrades persisting to different game saves. They are now added to a key in the game save.
  • Fixed issue with credits not being reduced for upgrades (bioscan/vitals) purchased.
  • Added handling for screen logic when spectating for the different possible modes.
  • Improved flashlight color handling. You no longer need to be holding a flashlight to run the command and it will now save your preference.
    • Already modified flashlights will not be changed and your helmet light color will update to any flashlight you are holding.
    • Rainbow flashlight coroutine will stop and start depending on if you have an active flashlight.
    • Setting flashlight color preference to "default" or "normal" will return the color to it's default.
#

darmuhsTerminalStuff (3.6.8) - Terminal Mod

wraith minnow
simple sierra
summer raft
#

I like how both of our answers are similar 😆

simple sierra
cunning moss
#

it's not really reasonable to say people should use custom RPCs for things that can be achieved through existing RPCs imo

#

using existing functionality means that mods can more easily hook into relevant portions of code rather than having to poll things every frame

#

for example, in the healing station in Black Mesa, I specifically decided to call PlayerControllerB.DamageOnOtherClients() to make sure that any mods trying to track player health can be aware of the change to the health value

#

(originally I was also going to use negative damage, but for a reason I don't recall rn, it didn't quite work how I wanted it to)

simple sierra
#

yeah definitely. I think the anticheat mod is great for vanilla lobbies but the second you start playing with a lot of mods of course you'll run into the issue of it thinking another mod is trying to give the player cheats lmao

cunning moss
#

yeeep

#

it's really just not reasonable to use that with mods imo

simple sierra
#

especially if it's a mod that's required by all players there isnt really a point to playing with it

cunning moss
#

there's just way too much to account for with gameplay mods involved

simple sierra
cunning moss
#

if it was built into the game, we could account for it, but for every mod to have to soft compat with either an anti cheat mod or any mods that need to be aware of changing state is just not reasonable

cunning moss
simple sierra
#

I guess it'd be neat if I made it fancier with a lerp or something

#

but yeah no real need to

cunning moss
#

but that would essentially be purely cosmetic wouldn't it?

simple sierra
#

yepp

cunning moss
#

you could just lerp on the client then probably

#

assuming the player doesn't get hit while healing I guess...

simple sierra
#

yeah that would be awkward KEKW

#

it's not something i'm really pursuing, just a thought that I'm sure there's room for improvement

#

but there's also other mods completely dedicated to healing the player in the ship so not worth the effort lol

cunning moss
#

yeah probably not

#

I think the GI implementation seems to fit fairly well in vanilla from what I've seen

simple sierra
#

yeah GI's is really well done

frigid dock
#

hey, I just wanted to check in on the slight strangeness of how the custom purchase packs display in the terminal - is there any kind of conflict occurring to cause it? the only other terminal thing I'm really using is terminal formatter, so is it just going a bit weird because of it?

first pic shows the two default packs you've added under decorations, and then the second and third pics shows it under upgrades, but with a slightly odd name

image.png image.png image.png
simple sierra
#

if I recall correctly, without terminal formatter they'd all show up as decorations

#

or wait, were you showing that they are shown twice?

#

that is interesting for sure

frigid dock
#

yeah it's showing up twice, haha - is there anything I can do to push the essentials/pack somewhere else, or is it just destined to be there until the foreseeable future

simple sierra
#

uh yeah for the forseaable future it will be in both so long as you have terminal formatter installed

#

it's something I (and maybe mrov idk) need to look into at some point

frigid dock
#

no problem, cheers \o/

vernal shard
#

oh dear

frigid dock
# vernal shard oh dear

:D... I hate to be the bearer of bad news, haha, but I've also noticed that it spawns twice for lethal things' "small rug" - it is seen as both an upgrade (first pic) and as a decoration lmao (second pic). just letting you and @simple sierra know about this in addition to the previous bug I encountered \o

image.png image.png
vernal shard
#

that's interesting

#

will check how and why

#

and if my new system will fix that 🤭

wraith minnow
#

Could you add a config that keeps the "view monitor" thing up?

#

You have it so certain commands turn off the the "view monitor" thing, but it's a bit disorienting; I like inputting the command myself, mainly because of the ability to look through my command history

simple sierra
wraith minnow
#

Never noticed it. Thank you!

simple sierra
#

no worries! You are not the only one who has requested this feature lol

wraith minnow
#

Lol

simple sierra
simple sierra
vernal shard
#

the way my stuff works is: it tries to get if the unlockable is a decoration/upgrade based on how it's terminal nodes are set up

#

which makes it interesting that some items duplicate

frigid dock
#

so is it accurate to say that it's morvin' time

vernal shard
frigid dock
vernal shard
#

i've got no idea why it even shows up lol

broken coyote
#

I have a question...

broken coyote
#

How can I make it return to the Help start page by default? Except minicams, map @simple sierra

#

Some players get confused and don't understand what to do next xD

cunning moss
#

@simple sierra I'm seeing an issue in @broken coyote's profile where with the terminal set to visible only inside the ship, the terminal body cam is still rendering while outside the ship, any idea why that is? I forget if you are the one instantiating that even when TwoRadarMaps is present, but it looks like it's not got the OpenBodyCams.TerminalBodyCamVisibilityTracker component that I use to switch it off and on based on whether the terminal is on, unsure if you intended to use your own method of toggling it

#

profile code: 01931b69-6f67-b645-ce6c-8083a186f0ae

simple sierra
cunning moss
#

I would think so, yeah

#

you should have full control over whether it's enabled, if you didn't pass it a mesh

#

(I'm assuming it's a body cam you instantiated through the API?)

simple sierra
#

I'd have to double check the config from the profile

#

so probably I just need to disable the camera as well, with the game object

cunning moss
cunning moss
#

you shouldn't need to set an initial value for ForceEnableCamera, it will be false by default, which seems like what you would want until the player shows it with a command

simple sierra
cunning moss
#

yeah, no problem

unkempt spire
#

How do i make the terminal go back to the home page after i stop using it?

quiet smelt
#

Got a thing where typing a turret or door code while viewing monitor makes the monitor view close

#

Also have openbodycams which might be relevant

#

basically I do view monitor then l0 or whatever other turret code and the monitor closes

#

then oddly enough if i do another door code it opens again

naive cedar
#

i have this problem too

#

and i also use OBC

#

don't know if that affects it

cunning moss
#

it definitely shouldn't

#

at least not in the OpenBodyCams code, maybe some of the terminalStuff compat code affects that

tough adder
#

My group has it even without OBC

#

so it's a terminalstuff bug

simple sierra
simple sierra
unkempt spire
simple sierra
#

try it with a lowercase "h"

unkempt spire
#

ah okay

simple sierra
#

it shouldnt be case sensitive but I think it is at the moment

#

another small thing to fix

unkempt spire
#

well it didn't work

simple sierra
#

what happens when you type home into the terminal

#

because it literally just loads the terminal node associated with the keyword

unkempt spire
#

it works normally

simple sierra
#

send a profile code and i'll look into it at some point

unkempt spire
#

it is weird there is no error or anything

#

okay

#

0193276d-67ee-a01c-9538-f7027b6d0ff0

#

hope you get well soon btw

simple sierra
#

appreciate it 🙏

#

just took a peek at your code, looks like the config item works only while changing it mid-game. So probably an issue with how i'm initially calling it during lobby load

#

ok yeah I see the issue

#

i'll have it fixed in the next update but basically it's due to an early return when CreateMoreMenus is set to false

unkempt spire
#

thanks for looking into it

unkempt spire
simple sierra
wraith minnow
#

@simple sierra I couldn't find the post for ghost codes, but rebooting doesn't undo the "view monitor" or "view body" command. Also, there was a glitch I encountered where I couldn't leave the terminal during rebooting.

simple sierra
wraith minnow
#

Thank you

simple sierra
#

also i'll look into it when I find the chance 👍

wraith minnow
#

Sounds good!

summer silo
#

how do i set keybinds for terminal commands?

#

i cant see a list i can edit in the config and bind/unbind isn't a terminal command either

summer silo
#

ok i found the config to turn the keybind feature on

#

but i cant set any keybinds ingame

#

im trying to bind previous to left arrow and switch to right arrow on my arrow keys

broken coyote
#

When writing the fun command from the terminal

image.png
#

Only sends to this one planet(((

#

More precisely

#

It doesn’t let you see what’s in the list of these commands and immediately directs you to select moons by tag

simple sierra
simple sierra
# broken coyote It doesn’t let you see what’s in the list of these commands and immediately dire...

yes unfortunately any moon tag will create a keyword through LLL. I do not replace any already existing keywords in my command creation process so the tag command will not be replaced. I think if you're playing with this moon for now you should probably just set CreateMoreMenus (in Quality of Life section) to false. This will get rid of the more command and all of it's sub menus (fun/extras/etc.)

#

I may try using some FauxKeywords in the future for this menu system to avoid this issue

summer silo
#

the former gave this error

Screenshot_10.png
#

the latter gave this error

Screenshot_11.png
#

keep in mind i did make sure to write both the command and key correctly

simple sierra
#

try bind rightarrow switch

#

also make sure this is enabled if you are doing this in-game

image.png
#

in the Comfort Commands (On/Off) section

summer silo
#

yeah that was on

simple sierra
#

if you dont want to bind them in-game, this should also work (from another person's profile)

image.png
#

LeftArrow=previous;RightArrow=switch

summer silo
#

didn't realise it had to be all lower case

simple sierra
#

I'm not 100% sure if it's case sensitive, just something worth trying

#

I'd have to dive into the shortcut creation code to be sure 🙂

summer silo
#

ok 1st solution didn't do anything

simple sierra
#

also, is this enabled in Quality of Life?

image.png
summer silo
#

is it supposed to say that it was typed incorrectly even if it works?

summer silo
simple sierra
summer silo
simple sierra
#

oh no that would go in your config

summer silo
simple sierra
#

what happens if you type bind by itself

summer silo
#

no action supplied with the word

simple sierra
#

now type bind rightarrow

summer silo
#

same error

simple sierra
#

then the bind command was not created

summer silo
simple sierra
#

yeah that means the keyword doesnt exist

simple sierra
simple sierra
summer silo
#

both are enabled

simple sierra
#

go to main menu and start a lobby again

#

if you enabled them while already in the lobby it wont work

summer silo
#

i'll restart the game too just incase

Screenshot_14.png Screenshot_15.png
#

and im starting on a save file i've never used

simple sierra
#

can you share a profile code

summer silo
#

im'a rename it first gimme a sec, the name is kind of innapropriate

#

01934bd1-7fc3-e471-18b7-60e3222c7389

summer silo
#

playing a different game simultaneously with friends

summer silo
#

and surprisingly it doesn't conflict with the controls in suits terminal

simple sierra
summer silo
#

idk why binding ingame doesn't work, but i find changing it in the config more convienent imo
you might want to look into that when you have time

simple sierra
#

yeah I'll look into it, might be an oopsy somewhere

simple sierra
#

ok yeah I see an issue lmao

#

will have it fixed whenever I can get to it

summer silo
#

reporting another possible bug, this time for both suitsterminal and terminalstuff:
when tapping a key that is binded to a command very quickly, the command sometimes does not register, although the key itself is registered as the terminal plays a typing sound.

#

it still works fine so long as you hold down the key for about half a second or so

#

tested with all suits terminal buttons as well as switch and previous set to right arrow and left arrow respectively

simple sierra
#

yeah if you're quick enough you can time it so the key press doesnt get registered by my coroutine

summer silo
#

coroutine? whats that? :clueless:

hearty ingot
#

I noticed I couldn't use the fun command. And not only that, collecting a log from sector 0 mod moon, make me not able to use the terminal at all

simple sierra
simple sierra
#

Also looks like in the report I was replying to it was Hydro that had the tag fun?

tough adder
#

Not sure why it threw or what caused it

hearty ingot
simple sierra
# hearty ingot Is there anything I can do about this?

If you want the more menus then currently there is nothing you can do. If you dont care whether the command information goes in the more menus or just all gets listed in the 'Other' command, then you can set CreateMoreMenus to false

simple sierra
# tough adder Client error

This error comes from the client trying to ask the host what the current terminal page is and it's throwing a NRE on (int)StartOfRound.Instance.localPlayerController.playerClientId I'm guessing this was just a case of trying to call something a bit too early. I wouldnt notice it in lan testing as there's no latency but I can imagine with just enough latency some stuff not being initialized properly yet at the time of the call. It doesn't need to be called instantly so i'm adding a 1 second delay on this client function.

simple sierra
unkempt spire
#

is there a way to disable terminal starting with home screen scrolled down?

simple sierra
#

nah, this mod doesnt touch terminal scroll at the moment

unkempt spire
#

i see

simple sierra
#

next update will be 3.7.0, have a load of changes staged at this point

image.png
summer raft
#

greed more changes

simple sierra
#

autocomplete and terminal history compatibility for LateGameUpgrades (and other mods with interactive terminal api registered commands) coming soon ™️

simple sierra
#

[3.7.0]

  • Reworked TwoRadarMaps compatibility and removed lots of redundant code
    • In order to use switch/previous with this mod and have it synced with other players, you will need to enable networking in this mod.
    • I've not found a way to get TwoRadarMaps' terminal radar to sync with other players on it's own (and to be honest I dont think it was every intended to)
  • Cached the mapscreen radar, whether it's tworadarmaps' terminal radar or the vanilla one to remove redundant code/logic
  • Added MeetsCameraEnabledConditions patch per request from Zaggy to enable the terminal radar when it is in use.
    • Once Zaggy's mods are updated along-side this, it's supposed to help with performance.
  • Updated updateMapTarget patch to invoke a subscribe-able event
  • Added/Fixed networked nodes for vanilla view monitor command
    • it should now sync between players when enabled/disabled.
    • this feature is very new and intertwined with a lot of conditional logic so if you experience issues please provide a detailed bug report with steps to reproduce
  • Fixed issue with vanilla view monitor command where it would hide after door code commands
    • Thanks pkpenguin, glacialstage, and Lunxara for the reports.
    • This was due to the terminal node for door code commands being null, causing the current node to be reloaded (which would hide the map)
    • Fix is in Openlib specifically as part of the ParsePlayerSentence patch, to not invoke the event for null terminalnodes
  • Fixed issue where TerminalStartPage config item was ignored due to an early return in codebase.
    • Thanks kaplumbava for the report!
  • Fixed issue with bind/unbind commands not being added regardless of config setup due to an unnecessary early return in codebase.
    • Thanks 6rag0n for the report!
  • Reworked key detection for shortcuts, autocomplete, history, and walkie terminal use while at the terminal
    • Now uses the update patch from OpenLib as opposed to a coroutine constantly running in the background while in the terminal.
      • Openlib has a new keydetection event that is subscribed to in this mod
    • May see some performance benefits, however, this has not been profiled in any way.
    • Holding a key down will not cause the function to repeat now. Key presses will also feel much more responsive than before.
#
  • Removed TerminalClock coroutine in favor of event-based system.
    • TerminalClock will now update at the same rate as the hud clock
    • Should be a performance gain now that this feature is not a continuous coroutine.
    • Clock is hidden at the start of a new day (after ship returns to orbit)
    • While in orbit if you try to run the associated clock command, it will let you know the clock cannot determine time zones from orbit
    • If for whatever reason the clock was not created, the command will let you know the component couldnt be found.
    • Tested with CruiserTerminal, unsure if this feature had worked via the prior implementation with cruiserterminal...
  • Fixed issue where upgrades (like furniture) were being added to the item count that would be sent to the dropship.
    • Thanks Lunxara for the report!
  • Delayed client networked methods to get things like the current node on join to deal with rare error (likely latency related)
    • Thanks Lunxara for the report!
  • Added handling for rare error occuring with flashlight color change logic where the player's client id was out of range
    • if your flashlight doesnt change color sometimes this is likely the reason why
  • Updated client sync methods to grab the current radar target and zoom from the host after joining.
  • Updated screen disable/enable logic to include enabling/disabling other components of the screen that may be added by this mod (clock/bodycams/custom map radar/etc.)
  • Updated some portions of the networked nodes syncing logic
  • Updated some portions of the screen settings logic
  • Fixed rare issue with previous command not going to the correct previous target
  • Updated restart command logic to reset persistant game save data
    • This should fix the issue of day counts persisting after running the command
  • Added FauxMoreMenu config item to allow for the use of faux keywords (only work when entered from a specific page) for the MoreMenu sections
    • With this addition the menu creation logic has been updated slightly to handle faux keywords as an option.
    • Thanks paradox75831004 for the reported keyword conflict issues, hope this setting helps!
  • Added SwitchKeywords config item for the switch command. If switch does not exist in this config item it will be auto-added.
  • Added compatibility for Auto-Complete and History features with commands added via LateGameUpgrades and InteractiveTerminalAPI
    • Thanks Whitespike for the help!
    • If there are other mods that are adding commands in an odd way that do not use InteractiveTerminalAPI that you would like supported by this feature please comment the mod's name and a link in Issue #37 on this mod's github.
  • Updated compatibility for CruiserTerminal for future version 1.1.0
    • If you do not have this version installed the compatibility features this mod adds will be disabled.
  • Removed failed commands from Terminal History listing.
#

darmuhsTerminalStuff (3.7.0) - Terminal Mod

naive cedar
#

sheesh you cooked

simple sierra
#

lmk if you have any issues and i'll try to drop a hotfix 🙂

naive cedar
#

how long were u in the kitchen for this

young stag
#

jesus christ

simple sierra
#

i've been working on it off and on as things get reported lmao

hazy orchid
#

jesus

young stag
#

read through the changelog, good shit

simple sierra
#

🫡

#

maybe some redundant information, portions of that changelog were written at like 4AM lol

summer raft
simple sierra
#

to be fair, a lot of it is shit like this because I was fucking with my project file trying to support both new and old cruiserterminal's dlls KEKW

image.png
summer raft
simple sierra
#

turns out you cant have a reference dll with the same name and namespaces 💀 💀

#

these would be the big changes that I actually made

image.png image.png image.png image.png
summer silo
#

Suggestion: when typing help and then a keyword for a command (for example: "Help Moons" or "Help Minicams" it would display a description of what the command does, this would be for both vanilla and the mod's commands. I believe this would help newcomers to either the game or the mod, since not all commands (especially some of the modded ones) are clear on what they do just by using them once.

cunning moss
#

I've not found a way to get TwoRadarMaps' terminal radar to sync with other players on it's own (and to be honest I dont think it was every intended to)
Ah yeah, this is because it's not currently spawned over the network (and I'm not sure how I would make it be Hmm)

Updating OpenBodyCams to account for the updated MeetsCameraEnabledConditions patch should be quite quick, I'll look into it asap

simple sierra
#

as for modded commands added via InteractiveTerminalAPI or stuff like LateGameUpgrades' commands that do not actually have a TerminalKeyword added to the game like vanilla commands, I dont think there's a way for me to easily grab information about each command

#

that might be better requested from those individual mods

simple sierra
cunning moss
#

it's not such a bad thing for it to be synced, but yeah, in vanilla it's not very noticeable

#

I forgot it wasn't for a looong time

#

I think if I want to make it synced I would have to

  • make it opt-in
  • create the terminal map on a separate object from a networked prefab
simple sierra
#

yeah it sounds like a lot of effort for minimal payoff on your end lmao

#

I dont mind supporting the networking bits on my end as I am now. It's not too hard to keep track of

simple sierra
#

Just noticed LLL was updated recently wooo! Gonna update font size to use this value in the next update (mostly leaving this here for myself as a reminder)

image.png
simple sierra
# simple sierra Just noticed LLL was updated recently wooo! Gonna update font size to use this v...

[3.7.1]

  • Added better handling for error that would occur in a specific user's profile when trying to reset customization for the MoneyBackground.
    • This object's color cannot be updated with the refresh customizations button in LethalConfig when this issue is encountered.
  • With LLL's recent update, you can now modify the main font size and see it update when playing with LLL!
    • Thanks IAmBatby for publicizing the cached font size variable in LLL!
  • Added support for suitsTerminal's recent terminal caret color variable.
    • Whenever this mod changes the color for the caret it will update suitsTerminal's reference to it.
  • Simplified LethalConstellations compat
  • Added a line to try and fix the vanilla issue of the terminal not being interactable (accepting input) when you start using it
#

darmuhsTerminalStuff (3.7.1) - Terminal Mod

simple sierra
#

oh shit

#

this mod turns a year old today

#

if anyone has been using this mod since the version 1 days, hell ya salute

tough adder
simple sierra
tough adder
#

Lol

#

the config cleanup updates for this mod and suitsTerminal were so nice

#

XD

simple sierra
#

continuous improvement NODDERS

#

a lot of features in this mod were developed purely out of community feedback and working on improving things

jade veldt
simple sierra
#

to be fair, v1 only lasted about 12 days 💀

image.png
tough adder
#

and just continued growth from there

#

lol

simple sierra
#

yeah a lot of the downloads back then came from TheMostLethalCompany modpack

near thicket
#

Cam/map commands don't work with OBC, right?

simple sierra
#

they do, but if you have OBC's picture in picture terminal commands enabled then I disable my stuff in favor of OBC's

near thicket
#

Right.

simple sierra
#

.

simple sierra
# simple sierra .

@near thicket that's the message that will appear if you try to enable any of the cams/map type commands when OpenBodyCams' stuff is enabled

#

and ofc, 'view monitor' will still work in that scenario

near thicket
#

Yeah, I saw that message. I just thought I did something wrong. What's the most convenient way of switching targets with OBC and your terminal?

simple sierra
#

I'd recommend trying out any of these commands

image.png
#

they're similar to OBC's picture in picture and will use a camera created by OBC if you have this set to true

image.png
#

also the message doesn't mean you did anything wrong necessarily. You're free to use the mod any way you'd like. It's just there to let you know that my view-type commands will not do anything when OBC is creating the 'view bodycam' command. Mostly because it would be a bit of a pain to make them all compatible

near thicket
simple sierra
#

they work with OBC, you just need to disable OBC's view bodycam command

near thicket
#

And by switching targets I meant players being monitored. Or is switch [player] the only option?

simple sierra
simple sierra
#

and if you want to bind a key to switch between players you'd use the shortcuts feature

#

this is a pretty common config setup for that (from Lunxara's profile)

image.png
near thicket
#

Thank you very much!

simple sierra
#

no problem! I know the mod's config is a bit to get thru so these are pretty common questions lol

#

one day I'll make a wiki on it all

near thicket
#

It's fine, other than being a bit time consuming. Just didn't have time to fully dig into it, so thought I'd ask for pointers.

silent quiver
# 
[12:14:28.3018841] [Error  : Unity Log] NullReferenceException: Object reference not set to an instance of an object    Stack trace:                                                                                                            TerminalStuff.EventSub.TerminalStart.StartCheck (Terminal thisterm, TerminalNode startNode) (at ./EventSub/TerminalStart.cs:183)                                                                                                                TerminalStuff.EventSub.TerminalStart+<TerminalDelayStartEnumerator>d__12.MoveNext () (at ./EventSub/TerminalStart.cs:127)                                                                                                                       UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <e27997765c1848b09d8073e5d642717a>:IL_0026)

When creating new save

simple sierra
simple sierra
#

would using your modpack work to get the error to show?

simple sierra
#

even tried downloading the modpack and updating all and not seeing it lol

simple sierra
#

[3.7.2]

  • Switched mapscreen radar cache logic to use a getter/setter to avoid rare NREs where the cached radar has not been updated* with the current game state.
    • I unforuntately was unable to replicate the error that was provided to me but this should fix it in theory.

@silent quiver lmk if you get the error again with this version

#

darmuhsTerminalStuff (3.7.2) - Terminal Mod

jade veldt
#

uhm hi!

#

I'm stuck

image.png
summer raft
jade veldt
# 
[04:06:37.1948360] [Error  : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
(wrapper dynamic-method) Terminal.DMD<Terminal::QuitTerminal>(Terminal,bool)
Terminal.PressESC (UnityEngine.InputSystem.InputAction+CallbackContext context) (at <d491ed1d4cc34874a2498af41192fe04>:IL_0013)
UnityEngine.InputSystem.Utilities.DelegateHelpers.InvokeCallbacksSafe[TValue] (UnityEngine.InputSystem.Utilities.CallbackArray`1[System.Action`1[TValue]]& callbacks, TValue argument, System.String callbackName, System.Object context) (at <dbb0ce7b96144bd8bcbcb8b0d765f970>:IL_001B)
UnityEngine.InputSystem.LowLevel.<>c__DisplayClass7_0:<set_onUpdate>b__0(NativeInputUpdateType, NativeInputEventBuffer*)
UnityEngineInternal.Input.NativeInputSystem:NotifyUpdate(NativeInputUpdateType, IntPtr)
simple sierra
jade veldt
simple sierra
#

also did it happen randomly or do you have solid steps to reproduce like typing quit in the terminal always has this happen

#

seeing a couple of errors before the quit ones btw

Stack trace:
LCTarrotCard.Networker.OnNetworkSpawn () (at <9496f24c9b0e4456ba53a46930bcad76>:IL_0037)
Unity.Netcode.NetworkBehaviour.VisibleOnNetworkSpawn () (at <895801699cfc4b4ab52267f31e2a4998>:IL_0000)```

```[04:04:39.4411632] [Error  : Unity Log] ArgumentException: '0' cannot be greater than -2925.
Stack trace:
System.Math.ThrowMinMaxException[T] (T min, T max) (at <787acc3c9a4c471ba7d971300105af24>:IL_0016)
GeneralImprovements.Patches.TerminalPatch.SetStartingMoneyPerPlayer () (at <b34775cfe2644fea827caf476d582c6d>:IL_0163)
GeneralImprovements.Patches.TerminalPatch.StartPre (Terminal __instance) (at <b34775cfe2644fea827caf476d582c6d>:IL_0029)
(wrapper dynamic-method) Terminal.DMD<Terminal::Start>(Terminal)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Trampoline<Terminal::Start>?1226717858(Terminal)
LethalLib.Modules.Enemies.Terminal_Start (On.Terminal+orig_Start orig, Terminal self) (at <64fae9f52f324ab2a8065723b0759a64>:IL_0350)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Hook<Terminal::Start>?981073772(Terminal)```

```[04:04:48.5172505] [Error  :HotbarPlus-1.8.0] Failed to add HotbarPlus tips to terminal. Maybe an update broke it?
[04:04:48.5172505] [Error  :ReservedItemSlotCore-2.0.38] Failed to add reserved item slots tip to terminal. Maybe an update broke it?```
#

I think the GI one specifically might have broken some terminal functions

tough adder
#

Yeah @jade veldt make sure GI's not touching the credits and have TerminalStuff handle it

#

set GI's setting to defaults

#

GI should never override TerminalStuff

simple sierra
#

I mean, I'd like GI's stuff to work with terminalstuff if possible

#

if there's an incompatibility I need to fix on my end i'd like to know so I can fix it lol

simple sierra
jade veldt
simple sierra
# jade veldt I did a rejoin

im not able to reproduce the issue with the profile code you gave (and installing darmuhsTerminalStuff v3.7.2 afterwards since it wasnt installed)

#

I'm just starting a new lobby, leaving, then starting the same save again (i also tried using a different save). Is this a client side issue?

near thicket
#

So, is GI's option that makes credits background scale causing issues with TerminalStuff?

#

I also wish GI's "arrow keys to switch targets" worked with TS. As doing something similar through TS actions is not as convenient, as it affects all screens and prints an error if you try to switch when not monitoring anyone. Ideally I'd like to see next/previous commands that allow you to switch pages and monitor targets, but without printing any "errors".

silent quiver
#

3.7.2 fixed that error.
Thanks!

simple sierra
simple sierra
#

and as far as I know GI's arrow keys to switch targets should work with terminalstuff

simple sierra
hazy orchid
#

I assume what was meant is the "LeftArrow=previous;RightArrow=switch" being able to be done on any screen in the terminal

simple sierra
hazy orchid
#

yeah

simple sierra
#

it should work from any page as far as i'm aware (outside stuff like suitsTerminal's menu where it is not intended)

hazy orchid
#

I don't think they want it to be able to be done on every screen lool

#

GI's only allows it when you're monitoring someone

simple sierra
#

ohhhh I see

#

interesting

#

I think the easier solution would be to remove There is no active monitoring to switch! in favor of switching to the first available monitoring view. (whether that be the default view monitor or one of the added commands) Like I remember there used to be a default cams view config item or something like that I did away with at some point

#

otherwise i'll probably need to add some new config items, something like PreviousShortcutAllpages SwitchShortcutAllpages

#

still I think GI's should work

hazy orchid
#

yeah

near thicket
#

If GI's option works, then I'll use that. I just forgot to test it with other players.

simple sierra
#

yeah I just checked and it still works, though their added text isn't the cleanest (with my added views, probably fine with vanilla). You can test it with a radar booster btw

simple sierra
#

and again, if anyone experiences any issues with using this mod and another please let me know (with logs & steps to reproduce) so I can try to sort it out

near thicket
#

What about that one where the things you type don't start from new line, but pretty much right after the text that is already on screen?

simple sierra
#

it is on a per page basis, and if the page can have different results then it can differ between results as well

#

I guess this is also something I could automate on my end, but would help to have examples so I can test a general fix for it

jade veldt
frigid dock
#

@simple sierra I searched for "wrapper dynamic" and saw that you were running into some potential things here, and I was wondering if you could help out with what I encountered here just an hour or so ago #help-and-troubleshooting message

frigid dock
#

adding to my earlier thing - it does seem to be this mod. disabling it has allowed me to enter and re-enter the lobby multiple times without the game freezing up and crashing

tough adder
#

@simple sierra I think the network syncing may be broken, I haven't seen it syncing pages when clients use the terminal recently and I've ran into a few issues of people getting voided on lobby join

#

with 3.7.2 btw, the probably didn't happen with the previous one

#

Also they get no errors btw, just soumdmanager spam

summer silo
tough adder
#

Wouldn't have been that

simple sierra
#

If you're not getting any errors i'm gonna have to ask that you turn on the extra debug logging options in terminalstuff and openlib. Then get a host/client to test the syncing and provide results + logs

#

It doesnt sound like an issue I can troubleshoot myself via LAN testing

simple sierra
frigid dock
# simple sierra the only errors I saw in your logs were not related to this mod, so not sure how...

then I am not sure \o/ all I can tell you is that with the current iteration of terminalstuff, it runs fine when I first make a lobby, but if I exit and then re-enter the lobby, it crashed. when I removed terminalstuff, I no longer have that problem.

the "wrapper dynamic method" thing was just something I put in the search bar and I saw it being traded back and forth in this thread so I was inquiring if there was correlation o7

simple sierra
frigid dock
#

this should be it 01938f3e-0d6e-a049-70e5-470d0056e09c

simple sierra
#

so steps are:
Make lobby (new game save),
exit to main menu,
re-enter same lobby/game save

correct?

frigid dock
#

ye

#

or even making another new lobby

simple sierra
#

gotcha, just want to be sure

frigid dock
simple sierra
#

quick glance looks like some openbodycams stuff

simple sierra
frigid dock
#

🤔

#

how very strange

simple sierra
#

let me try landing

frigid dock
#

it wasn't unique to me, either, is the thing - friend I was playing with also kept crashing when they were trying it out, so I'm very curious as to how it happened lol

#

memory? idk

simple sierra
#

I think I read something about gale having some issues lately with profiles not downloading fully

#

maybe that? or are yall using a diff mod manager

frigid dock
#

I was using r2mm and they were using gale

simple sierra
frigid dock
#

one second while discord pitifully attempts to play that back because discord please buy stock

simple sierra
#

lmao all good, its just me loading into a level and then another lobby

frigid dock
#

yeah I really don't know, would it have been down to pc specs? or just lethal being really w e i r d

simple sierra
#

maybe, I have no clue tbh. Parsing my log file rn to see what errors I got

frigid dock
#

even now some friends are trying to load in the code and apparently lethal is consuming 20+ gb on their end and it's like "what in tarnation did I do wrong"

simple sierra
#

💀 , yeah that's the nature of adding more and more mods

#

I also have a pretty decent gaming rig so anything resulting in too heavy of a load wouldnt affect me

frigid dock
#

a culling must happen once more then, probably 😔

simple sierra
#

Error 1:

Stack trace:
FurnitureLock.Patches.AutoParentToShipPatch.AfterAwake (AutoParentToShip __instance) (at ./src/Patches/AutoParentToShipPatch.cs:57)
(wrapper dynamic-method) AutoParentToShip.DMD<AutoParentToShip::Awake>(AutoParentToShip)
UnityEngine.GameObject:AddComponent()
GeneralImprovements.Utilities.ObjectHelper:AddPlaceableComponentToGameObject(GameObject, Int32, Single, PlaceableShipObject)
GeneralImprovements.Utilities.ObjectHelper:CreateMedStation(InteractTrigger)
GeneralImprovements.Patches.StartOfRoundPatch:Start(StartOfRound)
StartOfRound:DMD<StartOfRound::Start>(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?1967582022(StartOfRound)
LethalLib.Modules.Items:StartOfRound_Start(orig_Start, StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?-666337712(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?-457057856(StartOfRound)
LethalLib.Modules.Utilities:StartOfRound_Start(orig_Start, StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?1104677020(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?-1244336764(StartOfRound)
LethalThings.NetworkConfig:StartOfRound_Start(orig_Start, StartOfRound) (at O:/github/LethalThings/LethalThings/NetworkConfig.cs:272)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?100267352(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?582799890(StartOfRound)
LethalThings.Patches.Miscellaneous:StartOfRound_Start(orig_Start, StartOfRound) (at O:/github/LethalThings/LethalThings/Patches/Miscellaneous.cs:210)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?-159138736(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?580405102(StartOfRound)
LethalThings.Patches.Debug:StartOfRound_Start(orig_Start, StartOfRound) (at O:/github/LethalThings/LethalThings/Patches/Debug.cs:109)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?1501346612(StartOfRound)```
#

Error 2:

Stack trace:
FurnitureLock.Patches.AutoParentToShipPatch.AfterAwake (AutoParentToShip __instance) (at ./src/Patches/AutoParentToShipPatch.cs:57)
(wrapper dynamic-method) AutoParentToShip.DMD<AutoParentToShip::Awake>(AutoParentToShip)
UnityEngine.GameObject:AddComponent()
GeneralImprovements.Utilities.ObjectHelper:AddPlaceableComponentToGameObject(GameObject, Int32, Single, PlaceableShipObject)
GeneralImprovements.Utilities.ObjectHelper:CreateMedStation(InteractTrigger)
GeneralImprovements.Patches.StartOfRoundPatch:Start(StartOfRound)
StartOfRound:DMD<StartOfRound::Start>(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?1967582022(StartOfRound)
LethalLib.Modules.Items:StartOfRound_Start(orig_Start, StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?-666337712(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?-457057856(StartOfRound)
LethalLib.Modules.Utilities:StartOfRound_Start(orig_Start, StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?1104677020(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?-1244336764(StartOfRound)
LethalThings.NetworkConfig:StartOfRound_Start(orig_Start, StartOfRound) (at O:/github/LethalThings/LethalThings/NetworkConfig.cs:272)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?100267352(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?582799890(StartOfRound)
LethalThings.Patches.Miscellaneous:StartOfRound_Start(orig_Start, StartOfRound) (at O:/github/LethalThings/LethalThings/Patches/Miscellaneous.cs:210)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?-159138736(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?580405102(StartOfRound)
LethalThings.Patches.Debug:StartOfRound_Start(orig_Start, StartOfRound) (at O:/github/LethalThings/LethalThings/Patches/Debug.cs:109)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?1501346612(StartOfRound)```
#

Error 3:

Stack trace:
FurnitureLock.Patches.AutoParentToShipPatch.AfterAwake (AutoParentToShip __instance) (at ./src/Patches/AutoParentToShipPatch.cs:57)
(wrapper dynamic-method) AutoParentToShip.DMD<AutoParentToShip::Awake>(AutoParentToShip)
UnityEngine.GameObject:AddComponent()
GeneralImprovements.Utilities.ObjectHelper:AddPlaceableComponentToGameObject(GameObject, Int32, Single, PlaceableShipObject)
GeneralImprovements.Utilities.ObjectHelper:CreateMedStation(InteractTrigger)
GeneralImprovements.Patches.StartOfRoundPatch:Start(StartOfRound)
StartOfRound:DMD<StartOfRound::Start>(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?1967582022(StartOfRound)
LethalLib.Modules.Items:StartOfRound_Start(orig_Start, StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?-666337712(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?-457057856(StartOfRound)
LethalLib.Modules.Utilities:StartOfRound_Start(orig_Start, StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?1104677020(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?-1244336764(StartOfRound)
LethalThings.NetworkConfig:StartOfRound_Start(orig_Start, StartOfRound) (at O:/github/LethalThings/LethalThings/NetworkConfig.cs:272)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?100267352(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?582799890(StartOfRound)
LethalThings.Patches.Miscellaneous:StartOfRound_Start(orig_Start, StartOfRound) (at O:/github/LethalThings/LethalThings/Patches/Miscellaneous.cs:210)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?-159138736(StartOfRound)
MonoMod.Utils.DynamicMethodDefinition:Trampoline<StartOfRound::Start>?580405102(StartOfRound)
LethalThings.Patches.Debug:StartOfRound_Start(orig_Start, StartOfRound) (at O:/github/LethalThings/LethalThings/Patches/Debug.cs:109)
MonoMod.Utils.DynamicMethodDefinition:Hook<StartOfRound::Start>?1501346612(StartOfRound)```
#

^ this one repeats every time I start a lobby it looks like lol

frigid dock
#

I have no idea what that is and have been steadily ignoring it on my end 💀

simple sierra
#

looks like a potential compat issue between furniturelock and general improvements

#

might be worth reporting to them since it's consistent

frigid dock
#

med station doesn't like furniture lock

#

it checks out

simple sierra
#

yeah there probably needs to be explicit compatibility built between the two

#

I did find an issue with my mod while messing around with your profile, but it wouldnt cause crashes. Basically an issue with my quit command's compatibility with cruiser terminal, where typing quit throws this error and doesnt quit the terminal like it should

Stack trace:
TerminalStuff.Compatibility.CruiserTerm.Quit () (at ./Compatibility/CruiserTerm.cs:19)
TerminalStuff.TerminalEvents+<TerminalQuitter>d__9.MoveNext () (at ./PluginCore/TerminalEvents.cs:76)
UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <e27997765c1848b09d8073e5d642717a>:IL_0026)```
frigid dock
#

hmmm, icicic

simple sierra
#

totally unrelated to your issue, but yeah I did at least find something to fix

#

also should be a relatively easy fix 🙂

frigid dock
#

\o/ small things to fix good

simple sierra
#

so is the game still consistently crashing for you with terminal stuff?

frigid dock
#

I guess what I can do for now would be to... forcefully cull

#

and it indeed is

simple sierra
#

before you do that, could you turn on the debug logging config items for terminal stuff and open lib. Then get the game to crash and post the logs?

frigid dock
#

I will try and get that to you asap o7

#

(it'd be hilarious if it just works now)

simple sierra
#

these to be specific

image.png image.png
tough adder
#

@simple sierra What keeps exploding between TerminalStuff and GI?

simple sierra
#

a lot of the time stuff completely unrelated to the terminal can break terminal patches and crash the game and the first mods that will get blamed are other mods that patch the terminal lmao

tough adder
#

I'm just wondering what is going on in those errors

#

lol

#

Cus I've had none of that

simple sierra
#

the ones I posted are all furniturelock trying to touch the medpack GI adds from what I could see

tough adder
#

Ah yeah the medkit GI has isn't set up properly is why

simple sierra
#

I'm just posting errors I see from logs posted in here to give people an idea of what to troubleshoot in their profiles

simple sierra
simple sierra
frigid dock
#

as an aside, just a curiosity but do you know of any mod that makes it that we keep our tools on a wipe

simple sierra
#

and also no rush on the logs, I was just curious if it turns out the issues went away lol

frigid dock
#

am just wondering because that's a concurrent bug that I'm encountering and it's like "... wait"

simple sierra
#

I'm probably headed to bed soon myself

simple sierra
frigid dock
#

I will @ you for a future ref of the logs o7

simple sierra
frigid dock
#

nono thank you for your help c:

frigid dock
cunning moss
simple sierra
simple sierra
# frigid dock <@99711558879305728> \o

okay this is EXTREMELY helpful. I think I've narrowed down a potential issue on my end based on this error:

Stack trace:
UnityEngine.Object.get_name () (at <e27997765c1848b09d8073e5d642717a>:IL_0001)
TooManyEmotes.Patches.TerminalPatcher.EditExistingTerminalNodes () (at <269756645f9f47d2b56f18e9136cd133>:IL_003E)
TooManyEmotes.Patches.TerminalPatcher.InitializeTerminal (Terminal __instance) (at <269756645f9f47d2b56f18e9136cd133>:IL_002B)
(wrapper dynamic-method) Terminal.DMD<Terminal::Awake>(Terminal)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Trampoline<Terminal::Awake>?1934246542(Terminal)
LethalLib.Modules.Items.Terminal_Awake (On.Terminal+orig_Awake orig, Terminal self) (at <64fae9f52f324ab2a8065723b0759a64>:IL_07E1)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Hook<Terminal::Awake>?1461994652(Terminal)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Trampoline<Terminal::Awake>?647649116(Terminal)
LethalLib.Modules.Unlockables.Terminal_Awake (On.Terminal+orig_Awake orig, Terminal self) (at <64fae9f52f324ab2a8065723b0759a64>:IL_06DF)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Hook<Terminal::Awake>?-1778471876(Terminal)```
#

And after looking at TME's patch, I can understand why it's not a very consistent error

#

I'll try to have a fix out for this soon

simple sierra
#

ohhhhh, I see why I wasnt able to reproduce the issue. TooManyEmotes wasn't enabled in the profile code I downloaded from you

image.png
#

nvm I still can't reproduce it 💀

frigid dock
#

😔

simple sierra
#

if you're available to test, I was about to just push the change that should fix it anyway

#

if not, no worries I'll just upload to thunderstore and you can test later lol

frigid dock
#

It could just be a memory thing, ig? Friends noticed that when they first booted modded, it was using enough memory to blot out the sun. Then upon a reboot of game, it normalised into like 12gb usage

#

Though this was without your terminal thingy active, just lethal being lethal

simple sierra
#

I mean there was something on my end that was 100% causing issues at Terminal Awake for TooManyEmotes on lobby reload*

frigid dock
#

As for testing rn, I cannot, but if you push the update out I can get back to you ASAP \o/

simple sierra
#

as far as memory usage though, that could be anything

#

especially when adding scraps, moons, etc. All the extra content has to live somewhere lol

simple sierra
frigid dock
#

o7 gotcha boss

simple sierra
#

[3.7.3]

  • Fixed CruiserTerminal Quit command compatibility
  • Fixed issue with kick command getting stuck due to confirmation logic when not actively trying to kick anyone.
  • Renamed CamsNeverHide to MonitoringNeverHide to make more sense as to what it does.
  • Added MonitoringDefaultView to set a default monitoring view to enable when the switch or previous command is used and no active monitoring is detected.
    • Set to None to display the "No Active Monitoring" message.
    • If using the vanilla "view monitor" command, setting this to anything except None will enable the view monitor radar map.
    • If set to a monitoring mode that is not currently enabled, will use the next available mode.
  • Fixed issue caused by recent updates to switch command that was intermittently causing other mods to throw NRE on lobby reload.
    • Thank you @frigid dock on discord for assisting me with troubleshooting this issue as I was unable to reproduce it myself.
    • Issue was due to the fact that I am replacing terminalNodes.specialNodes[20] with my own node that is deleted each lobby reload. Which would result in a null node in the listing at Terminal Awake.
    • To resolve the issue I am setting terminalNodes.specialNodes[20] to it's vanilla TerminalNode on terminaldisable, until it is replaced again at Terminal Start with my node.
  • Added automated formatting where, if a node's displaytext is detected without new line entries at the end, new lines will be appended so that you are typing on a new line.
#

darmuhsTerminalStuff (3.7.3) - Terminal Mod

frigid dock
#

@simple sierra I can confirm that it works \o/

copper pagoda
#

Seem to be getting an inconsistent NRE on lobby load that well, breaks loading? Not entirely certain what it could be colliding with but being very glad smartitemsaving has a backup file

📎 LogOutput.log
summer raft
#

tried to use suits menu

#

for atleast one person (host) all was fine

summer raft
#

I couldn't repeat it, so I think the problem was in me

wraith minnow
#

@simple sierra is this issue caused by your mod or OpenBodyCams?

IMG_5675.jpg
#

Also, why is “switchedcam” showing up?

wraith minnow
#

Here's the modpack code so you can test it: 0193a8d3-6a9a-f016-88ae-4db4beb81d82

simple sierra
wraith minnow
simple sierra
# copper pagoda Seem to be getting an inconsistent NRE on lobby load that well, breaks loading? ...

for my own sanity (and to refer to later), posting relevant error here:

Stack trace:
TerminalStuff.SplitViewChecks.SetMiniScreen (System.String whatIsIt, System.Boolean state) (at ./VisualCore/SplitViewChecks.cs:125)
TerminalStuff.SplitViewChecks.CheckForSplitView (System.String whatIsIt) (at ./VisualCore/SplitViewChecks.cs:97)
TerminalStuff.EventSub.TerminalStart+<TerminalDelayStartEnumerator>d__13.MoveNext () (at ./EventSub/TerminalStart.cs:121)
UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <e27997765c1848b09d8073e5d642717a>:IL_0026)```
https://github.com/darmuh/TerminalStuff/blob/d971597d7f84a60345a62c3dfb986b73ae65ae17/DarmuhsTerminalCommands/VisualCore/SplitViewChecks.cs#L125
simple sierra
wraith minnow
#
  1. Joined lobby
  2. Accessed Terminal
  3. Typed “cc”
  4. Typed “cc” again
  5. Typed “view bodycam”
  6. Typed “cc” again
IMG_5679.jpg IMG_5680.jpg IMG_5681.jpg IMG_5682.jpg IMG_5683.jpg IMG_5684.jpg
simple sierra
#

can you post the logs in a text form

#

also is cc supposed to be a valid command?

wraith minnow
simple sierra
#

yeah it'd help to have these logs in a text form so I can parse thru them

wraith minnow
simple sierra
#

what happens if you type "character"?

#

I'm noticing in the logs conflict resolution is returning that for one of your inputs

wraith minnow
#

same result

#

It just shows the internal cam (given I didn't type view bodycam)

simple sierra
#

weird, can you see if you have the issue with conflict resolution disabled?

wraith minnow
#

I was thinking about that. Gimme a sec

#

It didn't change anything

#

I'll try it out with all my mods, but only enabling this one

#

So, it's there again. I'm gonna try installing it with default configs, still havign everything else disabled

#

Ok. so, it is something within your mod that's causing it, as it doesn't happen while I have default config settings for this mod

simple sierra
#

if you can narrow it down to a very small testing profile where the issue still happens I can work on it from there

wraith minnow
#

Sounds good.

simple sierra
#

I figure it's something between the view bodycam command (which OBC creates) and my logic I add for vanilla radar map compatibility

#

but of course, it gets very conditional so it would help to have the issue narrowed down to a test environment

wraith minnow
#

How does having the mod by itself, but with the configs I use sound?

simple sierra
#

I dont understand what you mean by that

wraith minnow
#

With changed configs: 0193a94f-259c-228c-73de-ed01c7a9c92e

Default configs: 0193a94f-6509-96ad-38a6-a1cd3b852a95

#

Each profile only has your mod installed. Something within the confg settings is generating the issue

simple sierra
#

thanks, i'll take a look to see whats going on sometime soon

wraith minnow
#

thanks

hearty ingot
#

Question, does darmuhsTerminalStuff take away the bestiary holograms? No matter what enemy I scan, there is no longer a hologram behind the text

simple sierra
hearty ingot
near thicket
#

Using minicams on terminal then leaving makes the cam part not show up when you come back.

hearty ingot
#

I was playing with a group of 8 and a guy changed his suits using darmuhterminal suits command. For some reason after he got his suit, he started occasionaly seeing the inside of his visor a bit. He changed suits at one point and couldn't see anything. Idk if it has anything to do with the suits command, but it only happened after he messed with that

simple sierra
#

will look into the above

#

also, would help if I had logs for each issue

hazy orchid
#

I think I may have encountered the visor thing when trying out the not being able to move cursor in the suits page

near thicket
simple sierra
simple sierra
hazy orchid
#

Yeah

#

I'm not gonna say anything further though because the issue is barely descriptive and what I got might just be a completely separate thing

#

Well I can say it was just with just SuitsTerminal putting on the suit it's already at just breaks the model so you you're seeing the third person model in first person camera

simple sierra
hazy orchid
simple sierra
#

yeah thats due to the suits menu being broken

hazy orchid
#

Yeah

simple sierra
#

due to the lack of terminalstuff (terminalstuff activates the openlib patch that the suits menu needs)

hearty ingot
hearty ingot
#

I'm sorry but i don't think I have the log

#

I swore I did 😭

near thicket
#

Check the latest changelogs.

simple sierra
#

just let me know if it happens again and try to reproduce with logging enabled (if it does)

wraith minnow
simple sierra
#

havent had a chance to look sorry

wraith minnow
#

no worries. It shouldn't be high priority anyways. It's just a small bug.

simple sierra
simple sierra
simple sierra
simple sierra
#

yep, fixed that one

wraith minnow
simple sierra
#

basically part of my compatibility for the vanilla view monitor command is that I need to make sure it shows/hides the terminal image in the same way as it does normally (or with my view commands). However I wasnt checking if the image was already showing, so when you hit the parser error node it would return that the image should be enabled (when really it should only be saying that if the image was already enabled)

wraith minnow
#

Huh

simple sierra
#

I wont be able to explain it further than that lmao

#

tl;dr its something on the backend I had to fix

simple sierra
#

[3.7.4]

  • Fixed compatibility with Route Random and RandomRouteOnly
    • issue was due to the node containing a null displayText property. Should fix compatibility with any mod that handles their terminal nodes in this manor.
    • Thanks zhenrong for troubleshooting this issue and helping identify the cause
  • Fixed issue where sometimes the Terminal's image would get enabled when it shouldn't be
    • Thanks thundershocker1 for the in-depth report
  • Fixed issue with bestiary animation videos not playing
    • Thanks crutled for the report!
  • Added handling for NRE reported by jk_5857
    • Will need to look into why this code was getting called when the miniScreen image was null, but for now it early returns if it is.
  • Simplified TerminalBeginUsing stuff (when you start using the terminal)
    • Should hopefully fix the issue reported by agitatio where the camera in minicams was getting disabled upon re-entering the terminal.
#

darmuhsTerminalStuff (3.7.4) - Terminal Mod

wraith minnow
#

If you could make it where having the “moons” commands disabled also disables any commands related to moons, that’d be helpful. Also, make that the case for the “store” command as well, as I assume it has the same issue.

simple sierra
wraith minnow
simple sierra
#

because all of the keywords for moons are their own keywords (have nothing to do with the moons keyword)

#

and I imagine changing how that works would cause a mixed bag of compatibility issues all over

wraith minnow
#

understandable

near thicket
simple sierra
near thicket
#

inuse

simple sierra
#

okay, should be fixed then. That's what I was testing against

frigid dock
simple sierra
near thicket
#

Sick!

jade veldt
fallow whale
#

@simple sierra There's an issue with version 3.7.4 on my mod pack. Version 3.7.3 works correctly, but when I upgrade to 3.7.4, the terminal mod seems to become completely deactivated. Could you check if there's any conflicting mod causing this, please? Here is my code if u ask 0193c2ac-9c6f-5195-01a1-a77e0a187d97

simple sierra
#

did your lethal company update?

fallow whale
#

updated just now

#

after I closed the game

simple sierra
#

weird, i'll have to look later. Bit busy at work

fallow whale
#

No problem, good luck

simple sierra
#

also just an fyi, if you're playing with bozoros you probably want this enabled so that you can navigate to the "fun" section of the more menu

image.png
simple sierra
simple sierra
#

also before anyone asks, yes.

SPOILER_image.png
naive cedar
#

So the moons screen is part of this mod?

#

I've never used constellations before so I thought it was part of that at first

jade veldt
near thicket
fallow whale
#

im testing it now

fallow whale
#

you are right gale is not updating dependency

#

dependency mod i mean

simple sierra
#

Really it’s just a hidden moon for whatever reason that may be

simple sierra
simple sierra
simple sierra
jade veldt
#

If even is possible to make the moon unlock (change to 0 when purchased) would be even better, specially cuz LethalMoonUnlocks have some issues related of showing some hidden moons

#

and afaik, xCore is no longer working on the mod

simple sierra
#

Also would hope mods like LethalMoonUnlocks would be compatible with the page, I would think at the very least the hiding/showing of moons would be since LethalConstellations stuff works

jade veldt
#

ChangeMoonPriceAfterRouteCuzMoroxiedSaidSo seems good

#

But actually I understand the difficulty of doing that

simple sierra
#

haha yeah, big respect for xCore and all their work

jade veldt
#

Most prob I'll only use Constellations and uninstall MoonUnlock

jade veldt
simple sierra
#

actually, would you want to try testing the new feature for me and let me know if you can find any issues?

jade veldt
#

Sure

simple sierra
#

One thing I will say is nothing is saved between game saves right now, but it's something I could probably add

#

alrighty, here's the latest devbuild. Let me know what ya think and if you find anything that needs fixing

#

^open to anyone who wants to try the fancy interactive moons page

simple sierra
jade veldt
#

Completely understandable

#

How it would act with TerminalFormatter?

simple sierra
#

I've been testing with the mod active. As far as I can see terminalformatter just doesnt do anything to my replacement

#

not sure if anything errors out though, I havent been diving too much into logs while testing yet

jade veldt
#

kk

simple sierra
#

also if you want both the regular moons page and the fancy one. Just remove moons from the keywords setting

jade veldt
#

opening the game rn :]

simple sierra
#

oh, one thing I just thought of. you'll probably need to reload the game after enabling the feature to see the other config items. I forgot to add an event subscription for that config change lol

#

will 100% cause errors if you try to load a lobby I think

jade veldt
#

so, I should open the game, close and open again?

simple sierra
#

open the game, enable the setting, then close/open

#

I was trying to make it so the other settings dont show up unless you have the feature enabled but yeah just thought of that issue

jade veldt
#

btw, 2 days ago I was trying to make a mod.
(It didn't go well)

image.png
#

oh, the game crashed lol

simple sierra
simple sierra
jade veldt
#

activated :]

image.png
#

welp, 2nd try

simple sierra
#

🫡

#

I'll try to whip up a version that doesnt have that issue (since I know exactly what the problem is) lol

#

jk, need to do one more thing

jade veldt
#

Seems that it behaves correctly when having more than 40 moons

image.png
#

the only issue is a small compat issue with the LethalMoonUnlocks cuz the price change doesn't update when buying

simple sierra
jade veldt
#

forget it, the price changed didn't work at all

simple sierra
jade veldt
simple sierra
#

I think I could fix that too relatively quick, one sec

jade veldt
#

does the MoonPlus have a filter option?

simple sierra
#

i'm gonna scrap the idea of the config options not showing up if the feature is disabled. Because then I'd have to go thru the hassle of refreshing the config with lethalconfig and I dont feel like doing all that KEKW

simple sierra
jade veldt
#

I mean, actual "filter"
Like "filter price" that makes the moon list don't show moons that you can't afford

simple sierra
#

oh yeah if you mean removing moons that dont fit a certain criteria then no I havent done that yet

jade veldt
#

kk

#

another thing, pressing up or down shows the history for one frame

#

command history

simple sierra
#

are you using terminalstuff for command history or GI?

jade veldt
#

wait, let me check

simple sierra
#

terminalstuff history stuff (and all shortcuts) should pause while in the menu but I cant stop other mods that insert stuff like that

jade veldt
#

GI

#

I'll change it

simple sierra
jade veldt
#

another thing.
I'd make that hidden moons (the ones that has [ ??? ] ) show their name permanently after being purchased.
If you buy a hidden moon, and then go to another moon, the hidden moon will hide again ( show again the [ ??? ] )

simple sierra
#

oh weird, it was working fine to permanently change in my testing

#

maybe an odd interaction with lethalmoonunlocks?

jade veldt
#

prob

simple sierra
#

I wonder if routing via the moonsplus page is not triggering things it should in lethalmoonunlocks

#

only speculating tho, not even glancing at code

simple sierra
jade veldt
simple sierra
#

hmmm, what does weather pick to disable? Eclipsed moons?

jade veldt
#

that's the option from LLL

simple sierra
#

I also think the tag filter is pretty pointless personally

jade veldt
jade veldt
simple sierra
#

yeah is that configurable in LLL or is it always the specific weathers that get removed

jade veldt
#

doing filter weather it will only show weather none moons

image.png
simple sierra
#

gotcha thanks, thats what my question was

jade veldt
#

also, typing Filter X, or preview X or Sort X will show the vanilla moon screen

simple sierra
#

oh interesting. I didnt expect that

#

I will prob just leave that, i'm not too concerned about blocking access to the vanilla one completely

#

like you can still type a moon name to route to it no matter what

jade veldt
#

understandable

#

Everything else seems to work perfectly

simple sierra
#

hell yeah

#

let me take some of your suggestions/reports and get back to you with another version

#

you can test it whenever you've got time

jade veldt
#

got it

hazy orchid
#

is this moon thing default false

simple sierra
#

yeah it is

hazy orchid
#

o

#

ok

simple sierra
#

And leaving it disabled should compartmentalize anything it adds to the mod

#

I dont wanna force features on people who dont want it lol

hazy orchid
simple sierra
#

here's another testing .dll for the fancy moons page

#

added some of the requested filtering and also tried to add some compatibility for weathertweaks' weather stuff

simple sierra
# jade veldt

I did weather/price from this list. Not sure if i'll do any more than that but I think I will add something other mods could touch for further filtering

peak patrol
#

The moons plus page is really nice and easy to use, are you at all considering doing the same for the store page?

simple sierra
simple sierra
#

think im gonna take this testing of the moons page to a thunderstore release

#

if anyone runs into any issues they should be able to just disable the feature

simple sierra
#

[3.7.5]

  • Added new experimental feature, MoonsPlus.
    • When enabled can either completely replace the moons catalogue or be used as a separate keyword to display an interactive listing of moons available for routing.
    • Compatibility has been added for LethalLevelLoader, LethalConstellations, and Weather Tweaks/Registry.
    • Has many configurable features for filtering/sorting. Can also be adjusted in the menus.
    • This feature is still very experimental and is default disabled.
  • publicized ShortcutBindings so that other mods can assign stopForAnyReason to stop/start the shortcut listening logic
#

darmuhsTerminalStuff (3.7.5) - Terminal Mod

simple sierra
#

[3.7.6]

  • Added a missing early return for when MoonsPlus is disabled which would still create the keyword.
#

darmuhsTerminalStuff (3.7.6) - Terminal Mod

turbid breach
#

for some reason some moons are listed as free and I can route to them for free on the moons plus menu like dine even though they should cost credits and do cost credits if I just type the name into the terminal

simple sierra
#

It’s set up to grab the price from it’s corresponding buy node so I’m not sure why it wouldn’t get the right price

turbid breach
#

I couldnt find anything in the console for it either

simple sierra
#

This was for Dine in particular right? Or was it multiple moons?

turbid breach
#

just dine

simple sierra
#

I’ll double check when I’m on my pc later that I can get dine’s price on my testing profile

#

If you’d like, you can post your profile code too. But if you don’t have any mods that affect moon price then it might just be something I missed

turbid breach
#

I removed the mod for now but the rest of the mods I use are in here: 0193d1c8-84a3-5249-5138-227fe8608e81

#

ill probably add it back but a mod I added recently was causing a ton of lag so im also individually re-testing them

simple sierra
turbid breach
#

im not sure why dine would be specifically affected

simple sierra
simple sierra
turbid breach
#

yeah its just my friends wanna hop on and I always have to host so bugfixing will annoy them lol

#

thanks though I really like your mod so far

simple sierra
#

able to fix it for your profile specifically pretty easy since I can just grab the price LLL has for it

#

if anyone experiences the issue without LLL though, i'll need to find another solution

simple sierra
#

[3.7.7]

  • Fixed rare issue where a moon's (dine) price was inaccurate in a specific profile.
    • This profile had LLL so I am leveraging getting the route price from LLL when it is present.
    • If anyone else experiences this issue without LLL present please report it when possible.
  • Fixed MoonsMenu not syncing for other players with networkednodes enabled
    • the moon previews will remain disabled for players not using the terminal
simple sierra
#

darmuhsTerminalStuff (3.7.7) - Terminal Mod

young stag
#

is the slick new moons page compatible with lethalmoonunlocks

hearty ingot
#

Has the whole bestiary hologram thing been fixed?

#

Well I'm going to play LC soon, I'll test it

simple sierra
simple sierra
simple sierra
naive cedar
#

moons plus looks so sick

simple sierra
#

I have some stuff xCore can hook into if/when they start working on LMU again

near thicket
young stag
#

it does add stuff for sales and other tags

simple sierra
tacit steppe
#

when i open the terminal nothin shows and i can even leave terminal no command works either

image.png
simple sierra
earnest coral
#

any way to have better formatting for the moons lists? i have so many moons and it doenst all fit

#

well it does

#

but the text is tiny

simple sierra
#

with the moons plus page?

earnest coral
#

moons plus page?

#

whats that?

naive cedar
simple sierra
earnest coral
naive cedar
#

remove some of your moons

#

the font gets smaller when you have a ton of moons

simple sierra
#

could also use a moon sorting mod (like lethalconstellations) or the moons plus page

near thicket
#

You can install LethalMoonUnlocks and disable unlocking in it. It has font option for moon page.

#

Or TerminalFormatter.

earnest coral
#

terminal formatter is compatible right?

simple sierra
#

yep, all of the mentioned mods are

earnest coral
#

COOL

simple sierra
#

although I dont think terminalformatter resizes the font if I remember correctly

earnest coral
#

a wman

#

aw man

simple sierra
#

best just to try it out

#

and see

earnest coral
#

okie ill update when im here

jaunty arrow
#

i'm having a slight problem with my custom keywords on reload. they function when 1st load. they not working unless I restart the game.
my modpack 0193d950-1042-b136-f7d3-c3cb689dadce if needed.

jaunty arrow
jade veldt
simple sierra
simple sierra
naive cedar
#

I think the moons plus page is displaying moons that are not registered in terminal in the LLL config

#

i have both Solace and Triskelion unregistered in LLL, but they still appear in the moons plus page and can be routed to

simple sierra
naive cedar
#

idk what they're referred to in LLL code

simple sierra
#

gotcha, I can look into it

#

I've only been referring to the locked/hidden properties LLL provides

#

thanks for providing the config item names