probably wait for discord to fix
#🖥-vesktop-development
viscid pier
🤷♂️
kaboom the pr then
i mean i can do
[class*="submenu"] [class*="scroller"] {
vernal lintel
this is bugged because it's not defined
just define custom-floating-layer-max-height to fix
viscid pier
thats fixes it yeah
vernal lintel
#textarea-context-vcd-spellcheck-settings {
--custom-floating-layer-max-height: 50vh;
}
actually
#textarea-context{
--custom-floating-layer-max-height: 50vh;
}
done
vernal lintel
it makes little sense to fix it in vesktop tho
vesktop is slow moving
this is just a discord bug that also affects vencord
we should either just wait for discord to fix it or if you really want to fix it, it should be fixed in vencord because vencord is also affected by it
this for example
and this
viscid pier
should be moved to vencord then, is there even a long enough dropdown in regular discord for them to actually fix it
vernal lintel
yes
vernal lintel
this is also broken
like this
clearly they are working on this because it was working a few days ago
they borked it with one of their changes
viscid pier
oh i thought this was broken for a while
might aswell wait to see if they fix it then
vernal lintel
well i dont mind fixing it ourselves
but not in vesktop xD
vesktop wont get a new release for another month at least
viscid pier
do you want me to pr vencord 
vernal lintel
we already fix a similar issue in vencord for BetterSettings but now they broke it even more
sour muralBOT
we already fix a similar issue in vencord for BetterSettings but now they broke ...
fullHeightContext.css: Lines 1-10
/*
* Discord has dumb max height logic for their context menus.
* If a context menu is at the bottom of the screen, its submenus are capped to its max height and can't even grow upwards
* We unset the variable they use to cap height. This allows submenus to grow as tall as they want
*/
#user-settings-cog,
[aria-activedescendant^="user-settings-cog"] {
--reference-position-layer-max-height: initial !important;
}
discord things 
simple groveBOT
viscid pier
idrk where i would add it to vencord tbh
simple groveBOT
vernal lintel
NICE
simple groveBOT
compact fjord
> saw electron patch note about colors
> immediately upgrades it on main
simple groveBOT
quasi spear
bringing it over here, would it be possible for us to downgrade electron? It was upgraded last week in https://github.com/Vencord/Vesktop/commit/4e13f6d99632c52c35ab98e70e07dba1f014d080
An issue was raised here: https://issues.chromium.org/issues/476855843
Probably won't break other deps. Making it 39.2.7 fixes the issue, as it uses an older version of Chromium (142.0.7444.265)
compact fjord
vesktop settings missing from settings context menu ☹️
rotund panther
humble mortar
vesktop settings missing from settings context menu ☹️
update your vencor
next sundial
@vernal lintel yo not sure if this is relevant in any way but
I was checking journalctl logs to diagonose a crash of another app
and found this in yellow color:
fev 05 13:41:31 archlinux plasmashell[1135]: Trying to replace notification with id 1216 which doesn't exist, creating a new one. This is a bug in the application "vesktop"
hmm, seems like there's multiple of that:
https://paste.ononoki.org/?638b53900330c908#DjouMUqbShoLXF8uL1ZjSjEZQ4HuM5B1o7sT2V1xfgHC
simple groveBOT
vernal lintel
DEPENDABOT YOU FUCKING PIECE OF SHIT I DO NOT GIVE SHIT ABOUT NODE TAR VULNERABILITIES
WHO CARESSSSSSS
it keeps spamming me with these irrelevant vulnerabilities
next sundial
titlebar is cursed again
X is not at the top-rightmost corner, it has an unneeded spacing there
dark quarry
yeah the .bar_c38106 has padding-right 12px but can't even determine where it comes from because devtools break
vernal lintel
i didnt even notice
how do u guys notice this stuff
.bar_c38106 {
padding-right: 0;
}
this vesktop patch broke
next sundial
how do u guys notice this stuff
because I tried to click the X from muscular memory and it didn't close the app
xd
it's always at the top-rightmost corner
funny part is that this also happens on the official discord client
vesktop is actually the app that does it correctly by patching it
vernal lintel
haha
simple groveBOT
humble mortar
<@343383572805058560> yo not sure if this is relevant in any way but
Somewhere between Discord app code and Chromium/Electron isnt checking if the notification is dismissed before trying to update it. not Vesktop
next sundial
are you guys the mantainers of the vesktop packages on the AUR?
if so, I believe vesktop-bin (and maybe vesktop too) should be installed on /opt instead of /usr
as a reference, I have localsend-bin and github-desktop-bin from the AUR and they are both installed to /opt
https://wiki.archlinux.org/title/Arch_package_guidelines#Directories
Package files should follow these general directory guidelines:
/opt/pkg Large self-contained packages
hmm...
ah I see
since vesktop-bin depends on electron40-bin, I think it makes sense not to be on /opt
whereas localsend-bin and github-desktop-bin probably bundle Electron
also, maybe only recommend vesktop-bin in the website for a better user experience
old juniper
are you guys the mantainers of the vesktop packages on the AUR?
nope
we do have comaintainer on vesktop-git
random nebula
@humble mortar
random nebula
also, maybe only recommend `vesktop-bin` in the [website](<https://vesktop.dev/i...
why are we still recommending vesktop even
@humble mortar fix
simple groveBOT
simple groveBOT
digital hare
time to update
random nebula
any MacOs users in chat where the app never quits after using the updater
the main window closes but the app stays open
and i need to manually quit for the app to restart
@humble mortar fix
how can i even test updater without always downgrading to 1.6.4
simple groveBOT
simple groveBOT
simple groveBOT
humble mortar
pretty sure this would have to be a vencord patch to block discord from getting wakelock
dont think theres a flag that disables it
or u can drop the request on the systemd side maybe
random nebula
pretty sure this would have to be a vencord patch to block discord from getting ...
how does it get wakelock
humble mortar
how does it get wakelock
theres like a zillion impls but they all use the dbus so just dbus-monitor while it does the thing
im gonna assume chromium uses the xdg portal
simple groveBOT
next sundial
I have a question about the Arch package: vesktop-bin has electron40-bin (both packages from the AUR) as dependency. Isn't it a problem to update Electron separately from the main Vesktop client?
For example, official RPM packages bundle the client and Electron updates, whereas on Arch Electron can be updated independently.
random nebula
@humble mortar
humble mortar
I have a question about the Arch package: `vesktop-bin` has `electron40-bin` (bo...
vesktop-bin isnt maintained by us and yes it can be problematic
random nebula
@humble mortar COOKIE
random nebula
vesktop-bin isnt maintained by us and yes it can be problematic
dont you have perms or something
simple groveBOT
humble mortar
is it bad to assume this is cause of the discord noise gate
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
compact fjord
not even thanked :///
lucid bridge
not even thanked :///
if you mean my PR, i did receive my thanks 😅
vernal lintel
not even thanked :///
i disabled webhook for pr comments
because people post way too many replies with little relevance
lucid bridge
i noticed you removed the license update, you have that on an eslint rule, is that only meant for new files ?
also ran into issues related to that due to most files being saved with CRLF
compact fjord
i disabled webhook for pr comments
for every channel? or just #🖥-vesktop-development
vernal lintel
i noticed you removed the license update, you have that on an eslint rule, is th...
yes
vernal lintel
i noticed you removed the license update, you have that on an eslint rule, is th...
also ran into issues related to that due to most files being saved with CRLF
no files use crlf
if you have crlf, it's on your end and you need to configure your git right
lucid bridge
hmmm, let me check again on my end, the repo is missing .gitattributes enforcing it though
vernal lintel
hmmm, let me check again on my end, the repo is missing .gitattributes enforcing...
not needed because formatter does it already https://github.com/Vencord/Vesktop/blob/main/.prettierrc.yaml#L8
sour muralBOT
not needed because formatter does it already https://github.com/Vencord/Vesktop/...
.prettierrc.yaml: Line 8
endOfLine: lf
yup, that did it, that's very weird though because i always install it and configure it to checkout as-is 😅
anyways, there isn't a problem after all, thank you
vernal lintel
yup, that did it, that's very weird though because i always install it and confi...
watch out that's going to force LF in all git projects
it might not be what you want if you work with a lot of windows projects
but imo every git project should use exclusively LF so it's a good thing to set
lucid bridge
watch out that's going to force LF in all git projects
yes, that is how i like it configured aswell, so it's all good 😄
you still have 2 files that are CRLF, but they aren't very important at all, but they managed to sneak in because there isn't a .gitattributes
.github\workflows\meta.yml
.vscode\settings.json
evil lewi
lucid bridge
i made a little program to scan a given directory recursively for things i don't like seeing in my projects , for example the EOL being CRLF, EOF isn't a new line, and such, that's how OCD i am about it 🤣
simple groveBOT
vernal lintel
sure man
just show me 30 irrelevant "vulnerabilities" in code that's not even used
lucid bridge
why is arrpc being pulled from a specific commit, instead of npmjs registry ? I'm guessing because at some point in time there was a change to their code that was needed for Vesktop, but they have since released a new version 3.6.0
electron-updater is also outdated
vernal lintel
ok
lucid bridge
😅 i could do a PR for just that, but seems a bit pointless
lucid bridge
ok, from what I'm seeing the electron-updater patch isn't needed anymore, they already wrap the check for the package manager in a try catch on the latest version, and they actually changed it from which to command -v too
https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/src/LinuxUpdater.ts#L56-L63
and the one for arrpc is still valid, i can PR if you want, but not that much changed tbh
sour muralBOT
ok, from what I'm seeing the `electron-updater` patch isn't needed anymore, they...
LinuxUpdater.ts: Lines 56-63
protected hasCommand(cmd: string): boolean {
try {
this.spawnSyncLog(`command`, ["-v", cmd])
return true
} catch {
return false
}
}
there is 0 reason to update
lucid bridge
i'd say getting rid of a patched dependency is a pretty good reason, but if you don't want to, then it is what it is 🤷♂️
vernal lintel
shush
vernal lintel
works on kde but doesnt work on gnome
it should work on gnome but electron doesn't even send the portal call 
i blame electron/chromium
it just returns success=false and no error, very useful
sudden trout
insane
how does electron even handle it does it check if the portal supports or is it hardcoded to work on kde and not gnome or smth
vernal lintel
how does electron even handle it does it check if the portal supports or is it h...
idk
I think it checks if wayland or x11
sudden trout
yeah I can't find anything useful on how it determines that and I don't exactly feel like grepping the entire chromium source for that but if it works on kde not on gnome I'm gonna guess it just has a list of working portals and doesn't even try if one of them isn't detected
vernal lintel
I'll just add a way to invoke shortcuts manually
eg via vesktop --shortcut toggleMute
then people can add desktop shortcuts that run that command
sudden trout
sure
vernal lintel
every desktop has a way to register custom keybinds that run commands
random nebula
wasn’t there a pr for global shortcuts @vernal lintel
vernal lintel
eg via vesktop --shortcut toggleMute
this works but it takes like 2 seconds
sucks ass
simple groveBOT
vernal lintel
wasn’t there a pr for global shortcuts <@343383572805058560>
overcomplicated and unmaintainable tbh
vernal lintel
add to libvesktop or smth
how
it wont solve the issue
i will probably use a unix socket server
echo "toggleMute" | nc -U $XDG_RUNTIME_DIR/vesktop.socket
smth like that
random nebula
overcomplicated and unmaintainable tbh
true
how do u plan to handle x11/bindows
or does the electron api do that
vernal lintel
I thought about it and it's not feasible for me to add such a large library + maintain it long term in a language I am not proficient at
vernal lintel
or does the electron api do that
it does
vernal lintel
I thought about it and it's not feasible for me to add such a large library + ma...
my own implementation using electron api is much simpler and more maintainable
doesnt support push to talk and mouse buttons but so be it
thats why I'm adding an alternative way to trigger shortcuts so people can do their own shortcuts via desktop
simple groveBOT
vernal lintel
KDE/Hyprland users test this branch please thanks
loud finch
some new electron builder version somehow messed up the dmg
simple groveBOT
simple groveBOT
loud finch
vesktop fixed finally
random nebula
vibesktop fixed, it is now fully human
random nebula
I don't understand this pull request
his clawdbot found vesktop and wanted to contribute
no human is making a 1k long file and pring it without at least discussing here or mentioning some issue
viscid pier
holy yap
vernal lintel
sudden trout
simple groveBOT
upper pine
@vernal lintel i'm not at my pc rn, i can check the next few days (will also update venmic to latest rohrkabel), but according to the logs this looks more like a vesktop issue
vernal lintel
not venmic issue
upper pine
Nice
Btw, Ive recently experimented with zig (as a compiler) again for saucer and actually got it working (had some issues before due to outdated libc++ and llvm backend) but it now works quite well and I could properly target older libc
Not sure if thats still a concern but I'll probably also include the necessary setup in the repo so that we can technically target older libc for those that might need it
simple groveBOT
deep thicket
why not js leave it open
deep thicket
aaaa
simple groveBOT
simple groveBOT
compact fjord
well atleast they were honest
loud finch
AI’s append their description with that I think
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
compact fjord
ai
sudden trout
pai
simple groveBOT
boreal dust
Is anyone else having a problem with spell check not working after deps bump commit?
Pre it works no prob
quasi junco
Is anyone else having a problem with spell check not working after deps bump com...
yea i noticed this too, not on vencord tho, but equibop
simple groveBOT
vernal lintel
it works fine for me
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
compact fjord
when did vee unmute comments for vesktop repo
compact fjord
it's off by default..?
simple groveBOT
simple groveBOT
vernal lintel
@next sundial Sorry, but I'm blocking you from leaving further comments. You're regularely leaving excessive, overly opinionated, demanding comments where you act like you're a maintainer and your opinions carry weight
It's annoying
next sundial
<@678334090704846858> Sorry, but I'm blocking you from leaving further comments...
I did not ask LucaHDR to make a PR. He decided to join the issue and discuss about it with me. If he wants to make a PR and make changes voluntarily, that is his choice. The issue has been up since 17 March; you or any other maintainer could have closed it beforehand. It is also possible to see that I do not have the "Member" tag when I comment, meaning that I am not a maintainer.
The fact that I am using correct English grammar to express my ideas/intentions clearly does not mean I am demanding something or that I do not think other opinions are valid. In fact, I am completely fine with the request being rejected.
I believe it is an over-reaction from your side, considering I do not frequently make issues/comments in the projects' repositories. But that is your choice and I respect it.
next sundial
well, the first one is because I was mentioned in the PR, and I really don't like to read things that seem to be vibecoded. the description of that PR is very non-natural and seems like an AI wrote it
so I just commented that I don't want to talk in order not to appear that I am ignoring it, and that's it
the second one is just what I said about using correct English grammar
but, again, I am fine with your decision, even though I believe it is an over-reaction
drink water and be happy 👍
hum, I just saw that the first PR was closed without discussion
welp, poor contributor
https://github.com/Vencord/Vesktop/issues/1252
I cannot reproduce this issue locally
works both on taskbar and tray for me
my setup is on Arch Linux, with vesktop from the AUR on KDE Plasma 6.6.4
loud finch
I’m testing electron updater with different identities rn
loud finch
I’ll make a pr soon with these changes
I just need to quadruple check everything so nothing goes wrong
If it does go wrong then Mac users will need to manually update
compact fjord
didnt even wait for a response #🖥-vesktop-support-🖥 message
compact fjord
oh my god
humble mortar
girl im bored lets delete the vesktop repo
compact fjord
girl im bored lets delete the vesktop repo
close random issues and flame argumenters
loud finch
I made an image bc im bad at explaining
loud finch
@sly cairn the cert change can’t happen immediately because it breaks the updater (users would need to manually update to the new version) but the release after the next release it can be changed
sly cairn
okie dokie
im actually getting a mac soon so i can help with mac development in some capacity
though cuz its a business machine i can only do a small amount
loud finch
huge honestly
I don't really know much typescript to help that much with vesktop for mac
vernal lintel
dw Claude can do it
loud finch
pixelmator pro
loud finch
idk if I sent this here already but this is vesktops mac icon project
simple groveBOT
simple groveBOT
sudden trout
just close as not planned tbh
loud finch
I like the idea of using obs camera
simple groveBOT
simple groveBOT
random nebula
i bet they added themselves into devs
you can't add yourself to devs on vesktop
@compact fjord you have lost it...
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
random nebula
vchars —
silk elk
loud finch
u didnt even need to check that to see if it were ai btw
random nebula
oh yk
loud finch
im experienced with ai i would know yk
simple groveBOT
digital hare
Crazy
deep thicket
have there been thoughts of using capacitor?
so that vesktop, since its electro, will run on ios and android
vernal lintel
you are losing it
deep thicket
i am curious as to why it wont work tho
ik from a frnd that forked hayase that its possible
he doesnt have it working fully yet but it runs
i mean, it could work as web app, with ofc tweaks to the site that would make it look/work as the actual app
ah fuck it lemme js fork and try and see
narrow pulsar
ah fuck it lemme js fork and try and see
best mindset to have honestly
deep thicket
(im going to fail, i barely know javascript)
digital hare
Well like, if we wanted this then we would just use our browsers
There’s a reason discord desktop is for desktop
old juniper
wtf 😭
simple groveBOT
compact fjord
1.7 to 1.16 😭
deep thicket
cant be a bump if its a downgade
compact fjord
DONT LET THE HATERS BRING YOU DOWN DEPENDABOT
simple groveBOT
simple groveBOT
compact fjord
chuddy gonna zeroday discord
digital hare
Perfect example of someone (immature) blindly trusting anything ChatGPT says
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
humble mortar
no its literally that the impl in that pr is bad
wayland global shortcuts are completely different from every other platform
you register them all at launch
you cant register shortcuts one at a time
humble mortar
you cant register shortcuts one at a time
I mean you could technically create a new session without killing the app to do this but 💀
vernal lintel
no its literally that the impl in that pr is bad
then we would have to hardcode keybinds and hope the desktop supports changing it and users are smart enough
the pr impl works fine on kde
which is the only backend that has a sane impl
the portal is just atrocious and not user friendly
also if I installed an app and immediately got prompted to add global keybinds on first launch i would uninstall it again
hella annoying
humble mortar
then we would have to hardcode keybinds and hope the desktop supports changing i...
its in the spec that you can just not declare defaults (also just dont use a bad desktop)
humble mortar
hella annoying
cope just press cancel
vernal lintel
nope
humble mortar
also if I installed an app and immediately got prompted to add global keybinds o...
it doesnt have to register right at launch it can be when the user navigates to the keybind UI or whatever
humble mortar
it doesnt have to register right at launch it can be when the user navigates to ...
and the app can request through the portal to open the keybinds settings
all your issues are from the gnome experience and being used to apps owning global keybinds
vernal lintel
its in the spec that you can just not declare defaults (also just dont use a bad...
not with electron api
vernal lintel
and the app can request through the portal to open the keybinds settings
not with electron api
humble mortar
yeah cause electron is bad
vernal lintel
all your issues are from the gnome experience and being used to apps owning glob...
yes and this is what 95% of people are used to
humble mortar
vee pay me money and ill finish my pr that makes electron global shortcuts actually work properly
vernal lintel
I dont understand why wayland insists on doing everything differently
it just hurts user friendliness
humble mortar
security or whatever
vernal lintel
it will never be the year of the linux desktop with the bullshit wayland is doing
vernal lintel
security or whatever
security is good but not when it conflicts with user friendliness, at least not in something like a personal computer 
humble mortar
honestly I like waylands shortcut impl cause then all the configurations are in one place
vernal lintel
99% of people dont care
vernal lintel
honestly I like waylands shortcut impl cause then all the configurations are in ...
yeah but most desktops don't even support it and no push to talk 😭
humble mortar
the user friendliness is fine if the app dev does Ir correctly
humble mortar
yeah but most desktops don't even support it and no push to talk 😭
wayland global shortcuts has up down events electron/chromium is just bad
humble mortar
vee pay me money and ill finish my pr that makes electron global shortcuts actua...
. (ill kms before I touch electron again)
genuinely insane that u need to compile and download all of chromium to make like a two like change
seven billion gigs
vernal lintel
build an electron alternative @humble mortar
you cant say tauri etc they're even worse
humble mortar
actually horror
I dont even think tauri has a wayland global shortcuts impl
and the fact that they rely on gtkwebview is so terrible
simple groveBOT
mellow pelican
the global keybinds pr is similar to the thing i did to get global keybinds to work
just adding a socket and using something else to send messages to it
thats amazing lmao
stupid question / probably been considered already but if electron's implementation of keybinds sucks so bad then why not make some lightweight process to run alongside vesktop and handle all the keybinds itself?
sudden trout
stupid question / probably been considered already but if electron's implementat...
tuxinal made a pr that did just that but it was kinda mid and smth else I forgor what exactly was the other major issue but adding something to libvesktop instead of a new thing would probably be worth considering given it already deals with dbus malware
sudden trout
it supports keybinds I'm not sure if it supports global correctly instead of being a keylogger
it's a keylogger
vernal lintel
the official discord app supports global keybinds right?
not on wayland i think
or if it does its very new
but doubt they do
sudden trout
I just tested they don't
vernal lintel
tuxinal made a pr that did just that but it was kinda mid and smth else I forgor...
I really don't want anything new to maintin
mellow pelican
it's a keylogger
lmao
vernal lintel
one of the main reasons i rejected the pr
vernal lintel
the responsibility would still be mine 
mellow pelican
sudden trout
I might try some bs tomorrow just to see how much effort it'd be to add to libvesktop
simple groveBOT
oblique egret
does vesktop run its own electron?
sudden trout
nop
