im not reading trademark law bucko
#🖥-vesktop-development
humble mortar
chatgpt hallucinating
vernal lintel
chatgpt hallucinating
how
vernal lintel
just because they're distributing it via the api doesnt mean you can use it in your app 😭
vernal lintel
discord.com/app
yeah that one ofc
oh yeah it's the same one https://discord.com/assets/7ba7fcf2c4710bb7.webm
humble mortar
oh yeah it's the same one https://discord.com/assets/7ba7fcf2c4710bb7.webm
playing this crashed my discord
old ass rn build moment
vernal lintel
we should just not add it at all and users can figure it out themselves 
we dont wanna become lightcord 2
lightcord got dmca from discord cause they used their logo on their website lol
humble mortar
blows you up big and round
vernal lintel
and once u got dmca it's like "damn what else might be infringing, we better remove anything that could be"
so I'd just preferably make sure nothing we do is potentially illegal in any way
we can just put it in the wiki
vernal lintel
rewrite from scratch
they're all not really proper
like way too specific
I'm gonna make a generic implementation that also copies the chosen file to the vesktop cache dir so users won't put it somewhere where it gets deleted
i think this one would be kinda funny but I have to figure out who made it and if it's okay to use
also it's not a proper loop, have to fix that 
did you see this
should I pr the fix to electron
oh yeah also did u consider pring this to electron? Vencord/Vesktop#686
how do u even pr to electron do you have to build chromium from source 
need to buy a 9950X3D
humble mortar
oh yeah also did u consider pring this to electron? [Vencord/Vesktop#686](https:...
i have a local branch with it working but puttered out when I looked at getting it merged 😃
same with linux accent access
humble mortar
need to buy a 9950X3D
took my r9 4900h like a day 💔
vernal lintel
lmfao
humble mortar
do you think it's not quality enough
i def didn't do it up to their standards and I was getting sick of building chromium
vernal lintel
tbh even if it's not good enough still pr just to get the ball rolling
humble mortar
the cache would break/invalidate every few days
vernal lintel
we need like distributed chromium build cache
humble mortar
ACTUALLY REAL
vernal lintel
some tool that rsyncs build cache from some google server
humble mortar
i think this one would be kinda funny but I have to figure out who made it and i...
SOOO UGLYYY
humble mortar
did you see this
i thought I responded 😭maybe you could get away with a simple find and replace and not even need to build electron
humble mortar
wait electron uses github runners right
vernal lintel
yeah
humble mortar
fork commit and run the action on the fork
vernal lintel
could just build on github
humble mortar
yea
vernal lintel
SOOO UGLYYY
you're a hater
humble mortar
horrible freeze in the middle
humble mortar
you're a hater
theres no sauce
vernal lintel
also it's not a proper loop, have to fix that <:love:1384660104699445410>
!!!!
humble mortar
no flavour
vernal lintel
cookie doesnt read anything i say...
humble mortar
vernal lintel
maybe this is more to your liking
humble mortar
i thought I responded 😭maybe you could get away with a simple find and replace ...
horrible thought just entered my mind
it might be a chromium internal that runs the xdg command
vernal lintel
no it's electron
humble mortar
u sure?
vernal lintel
humble mortar
maybe this is more to your liking
get a caitlyn edit
humble mortar
maybe just email Ubuntu
tell them to back port the fix
i bet no one has mentioned it
vernal lintel
it's one single line change 😭
humble mortar
electron takes forever to tag
ig Ubuntu might take forever too since it's so minor
god I hate electron
horrible horrible
vernal lintel
electron is nice until it isn't
simple groveBOT
woeful current
this behavior should be off by default
menu bar icon goes against macOS principles ykyk
simple groveBOT
simple groveBOT
humble mortar
20 billion comments about the same thing day after day
literally google "electron blurry Wayland"
simple groveBOT
woeful current
alpha DE
simple groveBOT
vernal lintel
how does one even manage to not have this library
Firefox depends on it and almost every Linux distro comes with Firefox preinstalled
gtk also depends on it
how does bro not have gtk installed
omg it's a Linux phone 😭
that's crazy
WOKE
humble mortar
god forsaken app
simple groveBOT
grizzled hemlock
@woeful current liquid ass being ass 
vernal lintel
Apple moment
woeful current
get to work
vernal lintel
woeful current
vee you have lost it
@vernal lintel, SHUT THE FUCK UP!
It's a bug alright - in the Vesktop. How long have you been a
maintainer? And you still haven't learnt the first rule of Vesktop
maintenance?
If a change results in Apple perfection breaking, it's a bug in the
Vesktop. We never EVER blame the Apple perfection. How hard can this be to
understand?
To make matters worse, commit f0ed2ce840b3 is clearly total and utter
CRAP even if it didn't break applications. ENOENT is not a valid error
return from an ioctl. Never has been, never will be. ENOENT means "No
such file and directory", and is for path operations. ioctl's are done
on files that have already been opened, there's no way in hell that
ENOENT would ever be valid.
topaz dove
vee doesn't know that github has mentions
(im fine with being mentioned on gh bc it doesn't annoy me)
vernal lintel
i deliberately sent link instead of mention so you don't get @d 😭
topaz dove
also is samara still here
if they left then i don't think i can tell them about the icon
vernal lintel
also is samara still here
no
woeful current
@vernal lintel, SHUT THE FUCK UP!
It's a bug alright - in the Vesktop. How long have you been a
maintainer? And you still haven't learnt the first rule of Vesktop
maintenance?
If a change results in Apple perfection breaking, it's a bug in the
Vesktop. We never EVER blame the Apple perfection. How hard can this be to
understand?
To make matters worse, commit f0ed2ce840b3 is clearly total and utter
CRAP even if it didn't break applications. ENOENT is not a valid error
return from an ioctl. Never has been, never will be. ENOENT means "No
such file and directory", and is for path operations. ioctl's are done
on files that have already been opened, there's no way in hell that
ENOENT would ever be valid.
they used a private api they kinda deserved yk
woeful current
fine
vernal lintel
vernal lintel
yop
humble mortar
@vernal lintel want me to update this PR with the new svg or just close
humble mortar
I'll update tmrw if i dont forget
@topaz dove send me the svg please
was one for Mac made as well?
topaz dove
<@298295889720770563> send me the svg please
topaz dove
was one for Mac made as well?
samara made one but i don't have the file
humble mortar
womp
vernal lintel
is that the black on top or bottom
simple groveBOT
vernal lintel
ugly creature
youre a hater
vernal lintel
tux as the default splash is so bad 😭
make a better default splash
humble mortar
@topaz dove what font did you use for the text? the same in the current server logo?
grizzled hemlock
tux as the default splash is so bad 😭
@vernal lintel dont listen to cookie
tux spin good
humble mortar
made a macos version @vernal lintel
i do feel like they need more pizzazz
maybe a shadow on the text and a highlight on the message bubble
vernal lintel
made a macos version <@343383572805058560>
did u see this
vernal lintel
ah
humble mortar
it looks so squishy like yumm
the shadow is there
ill kill you
find me an svg template for it
90kb
hortor
humble mortar
😭
vernal lintel
vernal lintel
i love svgs with pngs in them
humble mortar
WONDERFUl
humble mortar
yeag
humble mortar
???what virus did u sneak in that 90kb @slim tartan my inkscape is bugging tf out
vernal lintel
btw cookie ur pr removes icon from tray right
we're gonna have to add it back for customisable tray
humble mortar
btw cookie ur pr removes icon from tray right
no i just moved the file location
vernal lintel
oh
humble mortar
its the same old vc
vernal lintel
no i mean
u removed the explicit icon override
so it just uses the app icon
or am i going insane
humble mortar
yea
vernal lintel
oh wait that was splash
humble mortar
thats not the tray thou
vernal lintel
yeah okay
humble mortar
ur going insane
vernal lintel
its okay
humble mortar
im a little tea pot short and spout
i know
im playing around with it
?
the smaller sizes are getting this white artifact
evil
humble mortar
the smaller sizes are getting this white artifact
there was a useless invisible path
you love figma
</3 the one im generating is 1/4th the size
horrifying unoptimized png
yum
humble mortar
i have glee in my heart
wtfhg vesktop spell check is broken againn
@vernal lintel fix
why is it so bad
illl kill u
native macos slop
vernal lintel
wtfhg vesktop spell check is broken againn
how
humble mortar
gleep
topaz dove
<@298295889720770563> what font did you use for the text? the same in the curren...
didn't use one
humble mortar
how do we feel
topaz dove
i intentionally didn't add little flourishes
they become pretty much invisible at small sizes
topaz dove
couldn't find a place where we use it in a large size
its usually just an app or social icon
humble mortar
little flourishes likethat are def visible as social icons
humble mortar
480i monitor 😭
topaz dove
nop I'm on my phone
humble mortar
i can see it clear as day on my phone
the contrast is a little bad if i turn my phone brightness down tho
topaz dove
also i think the letters i made match the overall "bubbly" feel of the logo better
humble mortar
mh yeah
vernal lintel
how do we feel
dont like it
humble mortar
vernal lintel
did u send the same image twice
topaz dove
i like the changes to the V but im not sure about the grey
vernal lintel
maybe rename the icon files
icon.ico -> icon-windows.ico
icon.icns -> icon-mac.icns
icon.svg -> icon-linux.svg
so it's clearer
topaz dove
could probably also drop the icon- prefix if its in an icons folder
vernal lintel
is icon pr ready to merge? @humble mortar
simple groveBOT
topaz dove
we gonna keep the old tray icon?
i made a monochrome version of the new logo we can use
woeful current
i dont think tray should be monochrome tho
if we're gonna add macos tray it should be monochrome
on macos
add option ykyk
simple groveBOT
vernal lintel
simple groveBOT
humble mortar
@topaz dove @vernal lintel
these are solid dark/light
do we want it like that or with the pink
heres what that looks like
i really hate how electron passes it as a bitmap
even if you specify a system path (it being a system path would allow themes to override the icon by providing an icon with the same name)
vernal lintel
<@298295889720770563> <@343383572805058560>
seems a big too big compared to the others? (maybe just an issue with ur desktop)
humble mortar
seems a big too big compared to the others? (maybe just an issue with ur desktop...
likely a combo of my icon theme and it being non symmetrical making it feel bigger
this is it with breeze icons & heroic/spotify
ill commit and push so u can try on ur system
humble mortar
why tf is the tray getting destroyed
vernal lintel
if you toggle the setting
humble mortar
does it not need a restart
humble mortar
ill kill gnome devs with a hammer
humble mortar
yeah and it is invisible on light schemes
humble mortar
oh it has that shadow
humble mortar
still looks ass
vernal lintel
what de are u on
humble mortar
plasma
humble mortar
breeze classic
humble mortar
do we really have to add desktop detection lmao
could just make it pink
or add a shadow like discord does
humble mortar
heres what that looks like
.
we should make it default pink
and in settings be insane and provide an svg that gets recoloured
humble mortar
thats what i meant
https://www.electronjs.org/docs/latest/api/native-image#nativeimagecreatefromdataurldataurl
lol we could totally be insane and ship the tray as an svg and inject colours easily
humble mortar
dont even need to do that
vernal lintel
you can also do that for adding notification dot etc
vernal lintel
guh just do in renderer
humble mortar
heres what that looks like
this or solid pink
vernal lintel
this or solid pink
this is good
humble mortar
guh just do in renderer
way too much effort for an option 99% of people wont care for
vernal lintel
make a variant with notification dot
humble mortar
speaking of that
eh nvm
i was gonna yap about the dot following the system accent
vernal lintel
way too much effort for an option 99% of people wont care for
it's not that much effort...
i can do it if you want
humble mortar
i mean it could follow accent ig
electron doesnt have accent support on linux
vernal lintel
true
humble mortar
it's literally a 3 line change
cause chromium already fetches the accent
electron just doesnt expose it
vernal lintel
i experimented with making a native addon yesterday for dbus
i vibecoded it 
humble mortar
you are an evil being
vernal lintel
see it worked
humble mortar
give me a hex code for the notification dot @vernal lintel
vernal lintel
erm steal from discord ykyk
humble mortar
i hate their red
vernal lintel
seethe
humble mortar
ok im picking one
vernal lintel
actually if u dont wanna vibecode
we can yoink code from somewhere
horror image
humble mortar
it really isnt hard to implement
vernal lintel
like godot https://github.com/godotengine/godot/pull/104106/files
should we do this
humble mortar
no thats horribly evil and bad
vernal lintel
how
humble mortar
just do the 3 line patch for electron
humble mortar
i already have a bazillion times
this looks so ass
@vernal lintel @vernal lintel @vernal lintel @vernal lintel
on macos are notif badges also monochrome @slim tartan
should macos tray even have a unread icon
yeah
i wont then
gub
if we want the macos unread icon to have colour it cant be a template
which then also means the macos tray icons would have to handle dark/light switching
yep
can u show macos in dark mode @slim tartan @slim tartan @slim tartan @slim tartan
the tray
the macos badge has the dot for unread
does the tray really need it
no itd need to be baked in
sucks that Templates cant have non black colours that dont change
the tauri video capture situation is so terrible
it'd be a pain in the ass
tauri will be good once the implement cef support
real and true
vernal lintel
i didnt vibecode this time
vernal lintel
{
"targets": [
{
"target_name": "libvesktop",
"sources": [ "libvesktop.cc" ],
"include_dirs": [
"<!@(node -p \"require('node-addon-api').include\")"
],
"cflags": [
"<!(pkg-config --cflags dbus-1)"
],
"libraries": [
"<!(pkg-config --libs dbus-1)"
],
"dependencies": [
"<!(node -p \"require('node-addon-api').gyp\")"
],
"defines": [
"NODE_ADDON_API_CPP_EXCEPTIONS"
],
"cflags!": ["-fno-exceptions"],
"cflags_cc!": ["-fno-exceptions"]
}
]
}
idk if u need all that
vernal lintel
I just adapted godot code lmao
it can read colours, ints and bools from dbus settings
humble mortar
u can strip everything else and assume everything but a valid 6 char hex is an error
vernal lintel
why is it chonky
humble mortar
ur not compiling with optimizations
topaz dove
<@298295889720770563> <@343383572805058560>
i like
vernal lintel
i think it works
need to handle 3 billion errors tho
I love C style error handling
bool write_key_value(DBusMessageIter *dictIter, const char *key, const void *value, int type, const char *contained_signature)
{
DBusMessageIter variantIter;
if (!dbus_message_iter_open_container(dictIter, DBUS_TYPE_DICT_ENTRY, nullptr, &variantIter))
{
return false;
}
if (!dbus_message_iter_append_basic(&variantIter, DBUS_TYPE_STRING, &key))
{
dbus_message_iter_close_container(dictIter, &variantIter);
return false;
}
DBusMessageIter v;
if (!dbus_message_iter_open_container(&variantIter, DBUS_TYPE_VARIANT, contained_signature, &v))
{
dbus_message_iter_close_container(dictIter, &variantIter);
return false;
}
if (!dbus_message_iter_append_basic(&v, type, value))
{
dbus_message_iter_close_container(&variantIter, &v);
dbus_message_iter_close_container(dictIter, &variantIter);
return false;
}
if (!dbus_message_iter_close_container(&variantIter, &v))
{
dbus_message_iter_close_container(dictIter, &variantIter);
return false;
}
if (!dbus_message_iter_close_container(dictIter, &variantIter))
{
return false;
}
return true;
}
cleaner with C++
struct DBusIterScope
{
DBusMessageIter *parent;
DBusMessageIter iter;
bool open;
DBusIterScope(DBusMessageIter *p, int type, const char *sig = nullptr)
: parent(p), open(false)
{
if (dbus_message_iter_open_container(parent, type, sig, &iter))
{
open = true;
}
}
~DBusIterScope()
{
if (open)
{
dbus_message_iter_close_container(parent, &iter);
}
}
DBusMessageIter *get() { return &iter; }
operator bool() const { return open; }
};
bool write_key_value(DBusMessageIter *dictIter,
const char *key,
const void *value,
int type,
const char *contained_signature)
{
DBusIterScope entry(dictIter, DBUS_TYPE_DICT_ENTRY);
if (!entry)
return false;
if (!dbus_message_iter_append_basic(entry.get(), DBUS_TYPE_STRING, &key))
return false;
DBusIterScope variant(entry.get(), DBUS_TYPE_VARIANT, contained_signature);
if (!variant)
return false;
if (!dbus_message_iter_append_basic(variant.get(), type, value))
return false;
return true;
}
it uses gdbus afterall @humble mortar cause normal dbus is insane
you have to use dash to dock on gnome to get unity number lmao
topaz dove
vee forgot to change the icon back on his own pc
vernal lintel
nah
vernal lintel
I used Claude Sonnet 4 to clean it up
it came up with the smart pointer deleter stuff
topaz dove
yop
vernal lintel
lmaooo nodejs/node-gyp#2168
topaz dove
thread seems sane
they want to remove it but can't for historical and technical reasons
and they're moving away from it anyways
topaz dove
i do also want to say that i don't like the speech bubble being outlined
vernal lintel
in what logo
topaz dove
mostly i just think it looks worse but i also don't want the icon used on one operating system to be substantially different from the others
topaz dove
in what logo
the one that was made for macos
topaz dove
the other one
vernal lintel
i thought we would go with samaras
simple groveBOT
vernal lintel
i should see how gnome tweaks queries this
so we can have a proper isEnabled check that uses a portal instead of our own config bool (might be wrong if user manually disables autostart)
vernal lintel
I'm confused doesn't this mean this code (from GNOME and canonical) is memory leaking
oh i missed this line
what does floating mean
simple groveBOT
grizzled hemlock
hop on cmake.js
grizzled hemlock
.cc extension 
humble mortar
@vernal lintel unity count is int64 not int32
does the node module have to be built every time or is it like venmic
vernal lintel
<@343383572805058560> unity count is int64 not int32
explain
doesn't the library already use int64
Also js can't even store numbers that big
and no one is ever gonna have more than that many notifications...
vernal lintel
does the node module have to be built every time or is it like venmic
rn every time but we could publish to npm or just push prebuilds to the vesktop repo
although I'm kinda considering riir ngl
napi rs seems amazing
vernal lintel
napi rs seems amazing
why is the hello world so chonky tho lmao
humble mortar
doesn't the library already use int64
its taken in as 32 then gdbus casts it to 64 so nvm
also the api shouldn't be 0 as hidden
it should be null as hidden
so you just call gorp() to hide
and gorp(6263) to show
that's something that is annoying about electrons wrapping
badges can be negative 0 or positive it doesnt matter
0 makes sense as like an unread thingy
humble mortar
why is the hello world so chonky tho lmao
lots of things get bundled by default
having a native module for this stuff is so dumb
electron should just be better
vernal lintel
yeah true
vernal lintel
0 makes sense as like an unread thingy
that's why i used -1 and 0
humble mortar
it can still display 0 and negatives
vernal lintel
but we're not doing that
humble mortar
we could
and discord already has the option to disable the unread app badge if people dont like the 0
vernal lintel
0 would look retarded
vernal lintel
now the question is should we just push prebuilds to the vesktop repo or should we make a proper npm package for it
it's essentially the same
npm package just "hides" the binaries
grizzled hemlock
now the question is should we just push prebuilds to the vesktop repo or should ...
do you mean upload libvesktop binaries to the repo?
if so
grizzled hemlock
i feel like building vesktop should also build the native modules
vernal lintel
you will love having to install c++ compilers and glib headers just to run vesktop
venmic is already included as prebuild
grizzled hemlock
venmic is already included as prebuild
evil...
grizzled hemlock
you will love having to install c++ compilers and glib headers just to run veskt...
you mean to build vesktop?
vernal lintel
yes
grizzled hemlock
yeah if you're building vesktop wanting a c++ compiler and glib headers is reasonable
vernal lintel
no it isn't
you have lost it
we can just make it easy for people to build from source if it's so important
grizzled hemlock
me when it's unreasonable to need c++ build tools to build a project that uses c++
i see no issue with providing native binaries, but building from source should be default
maybe some command/script to download the prebuilt binaries
vernal lintel
that's worse
at least if the binaries are in the repo you can see that they haven't been changed
grizzled hemlock
that's worse
at least if the binaries are in the repo you can see that they hav...
insane
if you will provide native binaries in the build, at least build with -ggdb3
vernal lintel
wtf is that
grizzled hemlock
wtf is that
debug info for gdb at level 3
vernal lintel
why in the world would the release build include debug info
grizzled hemlock
why in the world would the release build include debug info
you're providing the binaries in the repo for people who just want to build vesktop from source without needing a c++ toolchain
or am i misunderstanding
@vernal lintel least insane hardcoded path
wait why not use giomm if you're using c++
vernal lintel
<@343383572805058560> least insane hardcoded path
vscode does ts automatically
vernal lintel
wait why not use giomm if you're using c++
there are so many options bro I just used whatever worked
also maybe we could disable exceptions to make the binary smaller
the only thing using exceptions is the napi c++ wrapper but could just use normal C napi
vernal lintel
one day I will fix it but not today
simple groveBOT
grizzled hemlock
vscode does ts automatically
yeah but when you commit it, it's annoying when it changes
also i'd gitignore compile_commands.json as well (generated by things like cmake and bear
grizzled hemlock
the only thing using exceptions is the napi c++ wrapper but could just use norma...
iirc it's such a pain to use the c napi
https://github.com/Vencord/Vesktop/blob/libvesktop/scripts/build/build.mts#L60-L64
If someone uses a local build for debugging, will it be in build/Release or something like build/Debug
sour muralBOT
https://github.com/Vencord/Vesktop/blob/libvesktop/scripts/build/build.mts#L60-L...
build.mts: Lines 60-64
await copyFile(
"./packages/libvesktop/build/Release/vesktop.node",
`./static/dist/libvesktop-${process.arch}.node`
);
console.log("Using local libvesktop build");
no one is gonna run the entirety of vesktop in gdb
you can just make a basic js script for testing
grizzled hemlock
you can just make a basic js script for testing
husk
no reason to not also check debug build
woeful current
@sly cairn would vesktop translations also be a part of translation v3
sly cairn
not initially
vesktop doesnt really have that much to translate regardless so it'd probs just use a simple system in comparison
they're probably meaning they want it for vencord
vernal lintel
@humble mortar check out and test that pr if u have time, it's ready
humble mortar
<@721853658941227088> check out and test that pr if u have time, it's ready
yeah I can tmrw if i dont forget
also if you can I'd really prefer if it used prebuilt binaries
needing gcc/make and python as a dep of the aur packages would make me kms
vernal lintel
also if you can I'd really prefer if it used prebuilt binaries
it does yeah
humble mortar
oh real?
humble mortar
HUSK ITS IN TREE
vernal lintel
needing gcc/make and python as a dep of the aur packages would make me kms
I think the git package should build from source
it's not too difficult to do
humble mortar
I think the git package should build from source
well yea but the non git packages exist
vernal lintel
just need build essentials and glib2.0 headers
yeah
i added a Dockerfile for building on oooold debian
these are all the deps u need (minus the aarch64 stuff, it's just for cross compiling arm64 binary, normal users won't need that)
humble mortar
curl??
vernal lintel
curl is used right below for fetching node-source
the nodejs in the debian11 repos is like node10 lmao
so old that you get errors from npm
the error was so fucking confusing
the error was like "Unexpected token ?"
i thought it was coming from building c++ or smth
couldn't figure it out until I asked chatgpt and it immediately knew it was cause ancient nodejs trying to run optional chaining (nullable?.prop)
vernal lintel
HUSK ITS IN TREE
eh I didn't wanna bother making it a npm package
just more painful cause it decouples it from the repo and it would just copy the files from the node_modules folder anyway
pushing 100kb of binaries to the repo is fine, it's no different to storing pngs in the repo which we have mbs of
My C++ code had some memory leaks until I asked claude to clean it up
GLib / dbus is a fucking landmine, every method call returns an object you have to free
humble mortar
Did you strip out all the unneeded return handling
vernal lintel
thats so normal
idk in nodejs it's kinda normal to ignore return values if you don't care about them
In C even if you don't care about the return value you still have to clean it up 😭
vernal lintel
Did you strip out all the unneeded return handling
wdym?
do you mean the horror code I showed the other day of handling errors and freeing before return
I switched from dbus to gdbus so that's all gone
dbus is very low level, gdbus is a high level wrapper
humble mortar
accent only needs tuple double and its container handling everything else you can assume is an error
let me just look
vernal lintel
the clamp shouldn't be needed
humble mortar
out of range (1-0) means its an error
vernal lintel
it's a value between 0 and 1
humble mortar
the spec specifies out of range means you should discard and assume theres no accent
humble mortar
github mobile code review is so ass oh my god
vernal lintel
BRAINROT
simple groveBOT
humble mortar
the wonderful !std::isfinite(v)
vernal lintel
okay
simple groveBOT
vernal lintel
<@343383572805058560> make sure to attribute this PR to copilot
how 😭
simple groveBOT
humble mortar
how 😭
Authored-by: Copilot (ihatetheenvironment@github.com)
vernal lintel
this lint rule is so troll
no it fucking can't cause esm doesn't support .node files 😭
vernal lintel
Authored-by: Copilot (ihatetheenvironment@github.com)
you're too woke oomfie...
humble mortar
gosh I'm so sorry 😔
vernal lintel
Authored-by: Copilot (ihatetheenvironment@github.com)
copilot didn't write shit in this pr but Claude cleaned it up for me ❤️
humble mortar
copilot didn't write shit in this pr but Claude cleaned it up for me ❤️
throw it in grok for a double check
vernal lintel
😭
vernal lintel
copilot didn't write shit in this pr but Claude cleaned it up for me ❤️
actually it was in Copilot
vernal lintel
copilot didn't write shit in this pr but Claude cleaned it up for me ❤️
these are ClaudeCode (actually yeah that's copilot)
but it makes a lot of sense
i forgot smart pointers existed but theyre sooooo good
can u tell i am bad at C++
humble mortar
@vernal lintel your brain is full of holes
humble mortar
i forgot smart pointers existed but theyre sooooo good
they might not even work here if the gio api expects things to be freed by their methods
extra cleanup or wtv
vernal lintel
that was the case with this variant
I cleaned it up myself and got really weird errors from glib
turns out g_variant_new returns a "floating" reference and _emit_signal cleans up the floating reference for you
vernal lintel
I'm confused doesn't this mean this code (from GNOME and canonical) is memory le...
xD
humble mortar
turns out g_variant_new returns a "floating" reference and _emit_signal cleans ...
well youre passing the reference directly to it .. it'd expect it to handle it
what else is gonna happen
the mind of a typescript dev
vernal lintel
well youre passing the reference directly to it .. it'd expect it to handle it
i mean the doc said the caller has ownership of the data
I missed a single line in the doc that said it will clean up parameters for you
humble mortar
@vernal lintel throws you in the garbage collector
vernal lintel
oh i missed this line
!!
this would all not have been a problem if I had just used glib C++ wrapper
but i didnt realise until sadan told me and now it's already written with the C methods
humble mortar
nobody has glib++ installed
vernal lintel
this would all not have been a problem if I had just used glib C++ wrapper
wrapper for your wrapper
goes hard
erm it's part of gio https://gitlab.gnome.org/GNOME/glibmm/-/tree/master/gio/giomm
humble mortar
erm it's part of gio https://gitlab.gnome.org/GNOME/glibmm/-/tree/master/gio/gio...
ask grok to convert it
vernal lintel
why grok 😭
I doubt grok is good at code
if anything I'd ask Claude Sonnet 4
I get a bunch of free requests with gh copilot
vernal lintel
why do you not wanna use the nazi AI?
humble mortar
https://x.com/elonmusk/status/1972992095859433671?s=19
he is such a dweeb oh my god
grokking it on the grokipedia
humble mortar
omw to consume 1/3 of the power grid to run wikipedia thru grok to dewoke the articles
humble mortar
okay lets see
I'm going to kill myself in front of you with my last words being "stop using AI"
vernal lintel
I'm going to kill myself in front of you with my last words being "stop using AI...
it can't do it
it doesn't know giomm
i tried a bit more but it just doesnt know
it's just like me
simple groveBOT
simple groveBOT
vernal lintel
@mild bone you will test:
git clone https://github.com/Covkie/Vesktop
cd Vesktop
git checkout feat/icons
pnpm i
pnpm package -c.mac.identity=null
should have working liquid ass icon
mild bone
okay
mild bone
<@785227396218748949> you will test:
```sh
git clone https://github.com/Covkie/...
working
mild bone
thanks koda
anytime
mild bone
love
topaz dove
i have a horizontal version of the logo we can use in there
topaz dove
topaz dove
simple groveBOT
simple groveBOT
humble mortar
@vernal lintel before tagging can we please use the dynamic arrpc db patches
1.5.8 is now 1700 game matches out of date
vernal lintel
1.5.8 is now 1700 game matches out of date
okay but 1699 of those are bad games so it doesnt really matter yk
simple groveBOT
simple groveBOT
humble mortar
okay but 1699 of those are bad games so it doesnt really matter yk
kill
vernal lintel
<@343383572805058560> before tagging can we please use the dynamic arrpc db patc...
i dont like adding it like that
we should just vendor a fork
topaz dove
should we start updating social avatars/icons to the new logo?
topaz dove
server, github
vernal lintel
thats just the vesktop icon silly
topaz dove
gluh
humble mortar
we should just vendor a fork
I'm going to blow you up with a bomb
I've been saying that for forever
vernal lintel
THEN DO IT
rotund panther
humble mortar
THEN DO IT
fork in the org and give me push perms
vernal lintel
sooooooon
humble mortar
gleep gorp
vernal lintel
should I just implement the new tray with dot rn
humble mortar
vernal lintel
abandonware
humble mortar
husk
humble mortar
why would it?
vernal lintel
accent
humble mortar
oh yeahg the icons need to change
vernal lintel
we should use the system accent colour
vernal lintel
that was ripped out
shouldnt be
vernal lintel
yes cause the PR shouldnt have customisation
since I'm doing that myself
and there shouldn't be a colour picker
just use system accent
humble mortar
what about systems without a defined accent
vernal lintel
use a default value
humble mortar
how do we show tray badge on mac
paige said some apps do it but then we'd have to handle dark/light switching ourselves since templates cant have any colour
grizzled hemlock
worse imo
vernal lintel
it's kinda awkward with the empty space
grizzled hemlock
eh, i dont think so
vernal lintel
and this looks horror too
simple groveBOT
simple groveBOT
vernal lintel
i meant to include one with a larger dot
give fixed
vernal lintel
TIL that the RequestBackground portal just creates a file in .config/autostart lmao
i thought it'd be more sophisticated than that
simple groveBOT
vernal lintel
gonna add start minimized
simple groveBOT
simple groveBOT
vernal lintel
i love org.chromium.Chromium.desktop 😭
method call time=1759519283.468133 sender=:1.802 -> destination=org.freedesktop.portal.Desktop serial=46 path=/org/freedesktop/portal/desktop; interface=org.freedesktop.portal.Background; member=RequestBackground
string ""
array [
dict entry(
string "autostart"
variant boolean true
)
dict entry(
string "commandline"
variant array [
string "/opt/Vesktop/Vesktop"
string "--start-minimized"
]
)
]
vernal lintel
idk how to fix this
there is https://docs.gtk.org/gio/func.bus_own_name.html but it's for server, not client
but when I run the code in vscode it uses code as the name
vesktop uses org.chromium.Chromium even when packaged
simple groveBOT
simple groveBOT
vernal lintel
isn't this a breaking change? electron-userland/electron-builder#9068
it changes the default executableName
it's technically a bug fix but I would still say it's a breaking change
humble mortar
idk how to fix this
how are you launching vesktop? from your app launcher .desktop?
if not its simply a limitation of the desktop portal registration
vernal lintel
isn't this a breaking change? [electron-userland/electron-builder#9068](https://...
it might be cause of this ngl
humble mortar
we yapped about this a while ago with the shortcuts portal
humble mortar
yeah
uhh I'll be able to get u the updated badge icon and review the native module Monday btw
vernal lintel
im gonna comment cause i think that's definitely a breaking change and I wasted a good amount of time debugging cause of it
vernal lintel
uhh I'll be able to get u the updated badge icon and review the native module Mo...
too slow...
i wanna releeeease
ive been hella productive
you're slowing me down 
humble mortar
I'm touching grass 😭😭
humble mortar
wtf is on vac
humble mortar
who tf abbreviates vacation as vac
vernal lintel
me
humble mortar
can u just send the updated badge icon or did u not make it yet
no its on my laptop
ur a weirdo @vernal lintel
hey maybe relax from your vibe coding and see the sun @vernal lintel @vernal lintel
vernal lintel
IM NOT VIBE CODING
vernal lintel
im gonna comment cause i think that's definitely a breaking change and I wasted ...
im gonna remove the I just spent a good amount of time
i dont wanna sound rude
thats nicer i think
vernal lintel
I'm going back to smelling the trees.. see you later loser
yeah okay i get it you go outside
vernal lintel
how are you launching vesktop? from your app launcher .desktop?
if not its simp...
yes
it just always names this file org.chromium.Chromium.desktop
only in flatpak it uses the right name
vernal lintel
@humble mortar for arrpc, using a cli on windows is terrible
i think we should use a small binary
either that or arrpc full native module
maybe rpc-rust
im tempted to do this
does arrpc not support mac
woeful current
does arrpc not support mac
it does
vernal lintel
wtf tokio supports named pipes and unix sockets
im tempted to do arrrrrpc riir
this shouldn't be too hard unironically
expecially cause I can just see how arrpc does things
topaz dove
vrpc
vernal lintel
rust so fat
vernal lintel
this rust shit is easy
somehow adding more libraries and code made the binary smaller
I'm actually gonna make arrpc riir
grizzled hemlock
somehow adding more libraries and code made the binary smaller
vernal lintel
rust so fat
oh wait cause I commented out this code
austere wolf
sub 1mb with tokio included no way
vernal lintel
r u planning to have multiple threads later
yes
sly cairn
hmm
i was gonna say u could use something like smol and u wouldnt need to include the whole tokio runtime then if ur not rly using tokio's features
austere wolf
you can not include parts of tokio if you only use specific ones
vernal lintel
loooovely electron/electron#48430 @humble mortar
when you try to open devtools, the app just full freezes, can't even ctrl + c it or close via tray / ctrl + q
have to send sigkill
grizzled hemlock
x11 my beloved
grizzled hemlock
erm it crashes in x11 mode too
On x11, or with xwayland
vernal lintel
why is this guy yapping so much 😭
simple groveBOT
scenic hollow
abandonware moment
woeful current
abandonware moment
when we bring back cookie from the dead it will stop being abandonware
simple groveBOT
simple groveBOT
next sundial
bad advice, /usr/share/applications/vesktop.desktop can be overriden with updates
the right thing to do is to copy it to ~/.local/share/applications and make the edit there
btw, doesn't https://vesktop.dev/wiki/linux/troubleshooting/#some-videos-dont-play-or-only-play-audio require video hw accel (plus normal hw accel) to work?
vernal lintel
senzawa pfp
simple groveBOT
vernal lintel
im also gonna link electron and chromium doc
simple groveBOT
vernal lintel
