github SO stupid
#๐ฅ-vesktop-development
humble mortar
vernal lintel
ur so mad lol
humble mortar
no i actually am
vernal lintel
im pushing 2000 commits to ur repo
vernal lintel
<@516750892372852754> pushed to aur btw
just tried, it broke
humble mortar
stop lying
i dont like that the auto updater script runs on a platform where it can't function but wtv
@worn harness i think we should move vesktop to /opt
why husk
worn harness
thats not the proper path
humble mortar
how
worn harness
it was there at first but then i fixed it later
humble mortar
why is it not right
worn harness
its the lazy way
worn harness
@humble mortar i had an idea
each package has the same desktop file so couldnt we just put one in the root of the repo and use that instead
and vesktop.sh
humble mortar
@vernal lintel can u retroactively push .pacman binaries for 1.5.5 or does it have to wait for 1.5.6
humble mortar
each package has the same desktop file so couldnt we just put one in the root of...
no afaik
worn harness
@humble mortar does symlink work
humble mortar
im not sure
i dont think aurpublish has any symlink handling
afterPack wouldnt be needed if vee just merged the stupid icon PR
im literally sobbing
worn harness
guhhh the current vesktop-bin package uses system electron
is vesktop-bin even maintained by us
humble mortar
no
worn harness
guhh steal vees login
vernal lintel
thats not the proper path
it literally is ๐ญ
humble mortar
..,.
vernal lintel
it would be wrong to install it to /usr/share because /usr/share is supposed to be architecture independent
worn harness
wha
humble mortar
electron IS architecture independent
arch electron packages are in /usr/lib
where vesktop is
vernal lintel
if you only install the .asar file and nothing else sure
worn harness
the only thing the pkgbuild puts in /usr/share is the desktop file and icons and license
vernal lintel
if you install the entire electron app including the binary then yes
humble mortar
/usr/lib/vesktop is where its installed rn
vernal lintel
and is that just the .asar file or also the electron binary
humble mortar
worn harness
oh my goddd
humble mortar
well system electron is /usr/lib so idk
worn harness
it works leave it alone
humble mortar
well im asking because the .pacman builds to /opt
vernal lintel
/usr/lib is only for libraries / object files
humble mortar
ill have to do some moving around
vernal lintel
if you want to put it in /usr then the correct way would be to split it up into /usr/share, /usr/lib and /usr/bin
but that's insane and not how electron works
that's why electron packages make most sense in /opt
humble mortar
that makes sense
vernal lintel
putting an entire app in /usr/lib is just wrong, you're violating spec
but it also doesn't really matter much
worn harness
the only thing the pkgbuild puts in /usr/share is the desktop file and icons and...
.
it is not the entire app
humble mortar
/lib not /share
vernal lintel
brother this is the entire app in /usr/lib
worn harness
those are libraries are they not
vernal lintel
/usr/lib is only for libarires (.so files and secondary binaries)
humble mortar
those are libraries are they not
vesktop binary right there
i'll leave it for now i guess
if someone complains it can be moved
worn harness
if there wasnt a vesktop.sh script then vesktop binary could go in /usr/bin
vernal lintel
brother this is the entire app in /usr/lib
if you wanna put these files in /usr then the "right" way would be something like this:
/usr/share: resources, locales, resources.pak, icudtl.dat
/usr/share/licenses: LICENSES.chromium.html, LICENSE.electron.txt
/usr/lib: vk_swiftshader, vesktop, *.bin, *.so, chrome-sandbox, chrome_crashpad_handler
/usr/bin: vesktop.sh
but electron wasn't made for splitting like that
that's why you put it in /opt cause opt is like the misc app folder
worn harness
@vernal lintel do youknow how to debug a specific line in electron-builder
node_modules electron builder is the built output
worn harness
different
humble mortar
make a pnpm patch
worn harness
does that work if its compiled already
humble mortar
yeah
vernal lintel
if it doesn't have to be inside the chroot then you can literally just edit the file in place
humble mortar
u just patch the js
vernal lintel
assuming it's a js file
worn harness
i cant
humble mortar
yop just pnpm patch electron-builder
worn harness
but i dont have a patch
vernal lintel
what r u even trying to debug
worn harness
cookie that just gives me the built binary
vernal lintel
show error or whatever
worn harness
im investigating somethiong on my own
humble mortar
cookie that just gives me the built binary
huhh?/..
it doesnt give u a dir with all the js files?
worn harness
no
worn harness
guh?
humble mortar
saves bytes!!!!!
vernal lintel
i wish npm banned pushing minified js
vernal lintel
i dont wanna edit minified code
you love
now you know what vencord plugin devs go through
worn harness
cookie will make plugins
humble mortar
my enemy
worn harness
what does hoisted mean
vernal lintel
ur hoisted
vernal lintel
actually we might not actually need it anymore
because we use esbuild to bundle dependencies
worn harness
if i comment out node-linker=hoisted then it builds without npm fully
worn harness
if i comment out `node-linker=hoisted` then it builds without npm fully
can we do that
vernal lintel
try it and see
in the past we bundled some dependencies and without hoisted, it bundles symlinks instead of the actual files
worn harness
it work
vernal lintel
but we don't do that anymore i think
worn harness
i think its working, i installed and im on it right now
vernal lintel
i think its working, i installed and im on it right now
i know ;)
worn harness
how
vernal lintel
๐ดโโ ๏ธ ๐
humble mortar
veeeeee how should i format itt
vernal lintel
veeeeee how should i format itt
not like that
worn harness
6502 etc
humble mortar
giant button
vernal lintel
veeeeee how should i format itt
you will design a Download on AUR button
dont be lazy I did that too a while ago
i made the UserScript button
worn harness
@vernal lintel will you gonna remove hoisting from the npmrc
vernal lintel
will you gonna
humble mortar
im looking for an existing design i can steal
vernal lintel
im looking for an existing design i can steal
AI generate
humble mortar
AI generate
ill chop off my head
humble mortar
one of these
SOOOOOO UGLYT
humble mortar
so insane
worn harness
ohh thats so husk
vernal lintel
worn harness
why did they think this was good
vernal lintel
its so stupid
humble mortar
adobe ahh
vernal lintel
worn harness
@humble mortar sniffs crumbs
vernal lintel
chatgpt has been going for minutes, why is it so slow
worn harness
since when could it run react
worn harness
humble mortar
that looks so asss
worn harness
@humble mortar sooo judgemental
humble mortar
yupp
vernal lintel
that looks so asss
u look ass ๐
humble mortar
rude
vernal lintel
chatgpt slower than cookie
humble mortar
Ill probably kill u if u use that badge
vernal lintel
<@343383572805058560> do my final project
we gotta kill Kylie first
worn harness
Kylieeee ๐ญ
worn harness
@vernal lintel make svg renderer plugin
vernal lintel
๐ฐ๐พ๐ฑ๐ฎ๐ช๐ช๐ช๐ช๐ช๐ช๐ช๐ช ๐ญ
worn harness
๐ฐ๐พ๐ฑ๐ฎ๐ช๐ช๐ช๐ช๐ช๐ช๐ช๐ช ๐ญ
humble mortar
ok i brb
worn harness
we win
humble mortar
๐ฐ๐พ๐ฑ๐ฎ๐ช๐ช๐ช๐ช๐ช๐ช๐ช๐ช ๐ญ
i just realized what this is
ur so insane
worn harness
@humble mortar dms
vernal lintel
<@343383572805058560> you scared me
how
humble mortar
tidal quarry
vesktop now on brew :D
stark falcon
simple groveBOT
scenic hollow
@brazen kite are you having any issues with the shortcuts pr right now? what was this about exactly?
i did test on windows btw it was seemingly fine (it also did notably need visual c++ for some reason)
serene sigil
@tidal quarry guh
serene sigil
u download packages off the aur
you dont click the link
and visit the aur
you use a package manager
husk
tidal quarry
<@836452332387565589> guh
?
humble mortar
you use a package manager
no you dont
serene sigil
no you dont
what
humble mortar
aur helpers arent official
serene sigil
guh
serene sigil
<@836452332387565589> guh
@humble mortar you were the one working on this right
serene sigil
I'm just using vesktop-git
humble mortar
nothing wrong with the package
humble mortar
its on by default in pkgbuild conf
serene sigil
its on by default in pkgbuild conf
oh hm
serene sigil
its on by default in pkgbuild conf
sorry for bothering
humble mortar
np
tidal quarry
ywww
brazen kite
<@602104493034831872> are you having any issues with the shortcuts pr right now?...
OK uh let me try to explain
so yk the issue where the discord keybind manager can't actually register mouse inputs
even if I were to register the bind through the CLI on windows, there's no apparent way for me to be able to go and actually bind my mouse to the bind
does that make sense?
like on KDE, for example, I could go to the keybinds manager and do it through there
so what I was asking was if it's possible to be able to pass in the key you want to bind to into the CLI
humble mortar
KDE doesnt support mouse shortcuts like that
brazen kite
KDE doesnt support mouse shortcuts like that
it's just an example
windows doesn't have a central place to do that is all I was trying to say
scenic hollow
so what I was asking was if it's possible to be able to pass in the key you want...
oh the cli triggers the shortcut doesn't have anything to do with bindings
brazen kite
oh the cli triggers the shortcut doesn't have anything to do with bindings
I figured
I was trying to mess with it to try and figure it out
so do I need to like make a script that executes the CLI thing when I press my mouse?
humble mortar
what is discord using for key capture in the bind menu?
scenic hollow
so do I need to like make a script that executes the CLI thing when I press my m...
yeah pretty much
humble mortar
what is discord using for key capture in the bind menu?
electron CAN detect mouse inputs so I'm a bit confused why their impl doesnt
scenic hollow
i think the official discord app's key capture thing is actually from the native part
we'd probably also have to rewrite it if we want it to capture mouse and stuff
humble mortar
renderer doesnt have access to more than the 2 side buttons
a native impl is def needed
i dont have a mouse with more than two side buttons so I can't test ๐ช
actually I could prob simulate it with xdotool key
scenic hollow
we could also just tell people to bind stuff to the cli.....
humble mortar
binding to the CLI with a script is ass cause no push to talk
brazen kite
renderer doesnt have access to more than the 2 side buttons
my two side buttons doesn't work
simple groveBOT
Content
Currently, as far as I can tell, the 1080x1080 image build/icon.png is downscaled to 256x256 using some non-nearest neighbor scaling algorithm. Only having a 256x256 icon is problematic as it can be scaled to as little as 16x16 and it looks pretty awful:
I strongly suggest that a proper ICO file with multiple different sizes, [ma...
simple groveBOT
vernal lintel
what
"i'm not sure why it hasn't been reported"
literally links other issue that reports the same issue
simple groveBOT
vernal lintel
im confused xd
simple groveBOT
vernal lintel
๐ญ
vernal lintel
why is that even necessary
not needed on linux & windows
why do they specifically block it on mac
but not windows
vernal lintel
thats so stupid lmao
lmao
why does mac even allow that
how? @humble mortar
XFCE
has working badge
humble mortar
error.code is the description
error.id is just the number
log the entire object to see
humble mortar
how? <@721853658941227088>
no idea
find ur lib folders for the libunity so
it might be a fake badge that does the count for the number of de notifications
vernal lintel
it might be a fake badge that does the count for the number of de notifications
I don't think so lol
it's XFCE
I use dunst for notifications
simple groveBOT
simple groveBOT
known and a fix has been made and will soon be released.
for now just use the native titlebar.
also:
woeful current
@vernal lintel update the wording to maintainer when
this makes it unclear because then "Hi I Vibe Coded A Website I am Developer"
simple groveBOT
scenic hollow
it only took a year and then some wooo
also tested stuff on flatpak and appimage everything works seemingly fine
humble mortar
it only took a year and then some wooo
how do i force the x11 shortcut method
scenic hollow
you can't on wayland unless you go into the code change the return conditions at the beginning of each function in the patch
scenic hollow
how do i force the x11 shortcut method
do you wanna do just the ui or also actually register the keybinds?
woeful current
fatpak
humble mortar
you can't on wayland unless you go into the code change the return conditions at...
xwayland
should probably be an env var for that case
scenic hollow
Uhhhhh I mean that wouldn't work except in other x11 apps but yeah it checks the XDG_SESSION_TYPE and WAYLAND_DISPLAY variables
vernal lintel
sadan would die
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
On Windows this still happens, When i search Deep Links i only find this:
set it to Not Eligible didnt help. Did i do sth wrong i didnt find the right setting
simple groveBOT
simple groveBOT
On Windows this still happens, When i search Deep Links i only find this:
set it to Not Eligible didnt help. Did i do sth wrong or i didnt find the right setting. @Vendicated
They removed the deep links experiment
vernal lintel
we should move most patches from vesktop to the vencord codebase
VesktopFixes core plugin
not rn tho
vernal lintel
we should move most patches from vesktop to the vencord codebase
either that or we need some way to hotfix vesktop renderer
just so we can fix broken patches without needing an entirely new vesktop release
simple groveBOT
cyan flame
either that or we need some way to hotfix vesktop renderer
RCE support for Vesktop
Remote update patchs
sly cairn
@vernal lintel re:
don't think this makes sense to be fixed upstream since we just repack the AppImage
if this was about my comment it was because we made desktop file changes upstream that then trickled down to flatpak, and we hadn't had any complaints about it since we did that so i wasn't sure if it was still needed
sly cairn
i cant quite remember but it was like
the name of something
ill see if i can find the commit that comment is referencing
vernal lintel
i really hope the fucking flathub autoupdater works now finally
after my previous fixes
sly cairn
sorry i would open that link but windows explorer decided to crash so now i cant open links
vernal lintel
i really hope it prs 1.5.6 soon
vernal lintel
should we ask the flathub maintainers if they can add our webhook now
or should we add a workflow that does it manually trol
vernal lintel
no response or no?
sly cairn
or should we add a workflow that does it manually trol
also i think they have security that prevents this
vernal lintel
should I open an issue on the flathub repo
sly cairn
not a bad idea tbh
sly cairn
yeye
simple groveBOT
next sundial
@vernal lintel no (at least for me)
btw not sure if I'm going crazy
but after upgrading to vesktop 1.5.6 text all over the app seems a bit blurry...?
probably some electron shenanigan
next sundial
<@343383572805058560> no (at least for me)
nevermind
I have a window rule applied to vesktop
so maybe it does appear
I had a similar issue with ruffle, the devs fixed it there
next sundial
but after upgrading to vesktop 1.5.6 text all over the app seems a bit blurry......
probably discord issue, see #๐ฅ-vesktop-support-๐ฅ
vernal lintel
dont get your hopes up
VICTORY
sly cairn
weird
vernal lintel
oh wait
it's cause I made a commit
one of them is outdated
ig it automatically made a second pr cause it noticed the first one was outdated
flatpak install --user https://dl.flathub.org/build-repo/176756/dev.vencord.Vesktop.flatpakref
time to test
rotund panther
humble mortar
look at this
the resolution is undefined when it refused to load
when hardware encoding is enabled
i wonder if thats related
sometimes it fails somtimes it takes a whie
weird as hell
[RTCConnection(111, stream)] Go Live Media sink wants: {"116989":100,"resolutionWants":{"116989":{"width":0,"height":0}}}
so the failure to load is cause its timing out
so why does it take forever to load
humble mortar
almost every time the hardware encoded stream fails that log happens
so for some reason the RTCControlSocket is closing which then triggers a retry timer
but that timer is too long and the stream times out
so why is the socket closing on hardware encoded streams
encoded webcam streams load just fine
tidal quarry
@vernal lintel https://github.com/Homebrew/homebrew-cask/commit/8828875750c633c588b196b27b7bab15dd299fa2 brew automatically updated it
so theres your answer hehe
vernal lintel
yay!!
sour muralBOT
index.ts: Lines 39-51
const settings = definePluginSettings({
// This needs to be all in one setting because to enable any of these, we need to make Discord use their desktop context
// menu handler instead of the web one, which breaks the other menus that aren't enabled
addBack: {
type: OptionType.BOOLEAN,
description: "Add back the Discord context menus for images, links and the chat input bar",
default: false,
restartNeeded: true,
// Web slate menu has proper spellcheck suggestions and image context menu is also pretty good,
// so disable this by default. Vesktop just doesn't, so we force enable it there
hidden: IS_VESKTOP,
}
});
thx for clarifying :p
that seemed like a bug because there is "Settings" without any settings
maybe just hide the cog wheel instead of the menu inside the cog wheel
next sundial
likely this
interesting; is there a way a patch could be made for vesktop to disable this new flag?
^ @simple willow
humble mortar
just launch Vesktop with the disable flag for it??
next sundial
just launch Vesktop with the disable flag for it??
what would that be? ๐
humble mortar
dunno
next sundial
found it
--disable-features=FontationsFontBackend
humble mortar
found it
`--disable-features=FontationsFontBackend`
where'd you go to find this
next sundial
where'd you go to find this
https://github.com/googlefonts/fontations/issues/1359 has https://issues.skia.org/issues/396360753, and the latter has https://issues.chromium.org/issues/375219950 (text is "issue 375219950" in the Skia page)
and in the chromium issue there is this: https://issues.chromium.org/issues/375219950#comment29
humble mortar
insane
i wonder if the electron people would be up for backporting the fix
ekse we'd need to wait for electron 36
next sundial
ekse we'd need to wait for electron 36
we'll probably need to wait
humble mortar
u dont need all that yap in the comment
not platform limiting means its obvious it affects all platforms
and it IS fixed in 36 cause that electron version has the chromium version with the fix
next sundial
u dont need all that yap in the comment
done @humble mortar https://github.com/Tiagoquix/Vesktop/commit/ac23f8ed60b53119d0cdf483b77dc9f245cd9b8e
next sundial
@vernal lintel pls take a look at https://github.com/Vencord/Vesktop/pull/1149 to make a new hotfix release ASAP. thanks!
vernal lintel
no that won't happen
if it really has to be a hotfix then it should be added to vencord instead. Making an entirely new release for that is insane
but so far only 2 people complained
you can just pass the flag yourself
next sundial
if it really has to be a hotfix then it should be added to vencord instead. Maki...
I didn't know it was possible to add new runtime flags to Vencord while also affecting Vesktop
I thought they were separate
this is already fixed on electron 36, but it's still in beta
next sundial
you can just pass the flag yourself
yep, did that already
simple groveBOT
next sundial
if it really has to be a hotfix then it should be added to vencord instead. Maki...
@humble mortar dissertate
humble mortar
<@721853658941227088> dissertate
i mean theyre right
its a PR that should exist if vesktop ever tags another version on 35
but its not high priority
vernal lintel
next tag 2027
humble mortar
@vernal lintel what happened to vesktop troubleshooting wiki
vernal lintel
<@343383572805058560> what happened to vesktop troubleshooting wiki
lazy
vernal lintel
youll make Tessie rule for blurry text/font
nope
next sundial
i mean theyre right
confirmed, @vernal lintel actively makes the linux experience worse
that's why he invented vesktop
humble mortar
you will push flag that fixes an edge case as a single commit tag
@vernal lintel I'm hostile forking vesktop to merge all the shit you won't (evil)
vernal lintel
yop
simple groveBOT
simple groveBOT
simple groveBOT
next sundial
loud finch
what a cute icon
vernal lintel
true
simple groveBOT
simple groveBOT
woeful current
tbf the form is quite unclear
since the random that vibecoded some next js app is a "developer" and to his eyes can open an issue
simple groveBOT
humble mortar
@vernal lintel another yapper in vesktop support about vesktop exploding cause no loadurl retrying..
you will merge the fix
vernal lintel
I DIDNT KNOW
vgif hammer @humble mortar
silk elkBOT
vgif hammer <@721853658941227088>
humble mortar
NO STOP HITTING HER
humble mortar
@vernal lintel ogrb
vernal lintel
still do like ```
Failed to load canary.discord.com: ERR_INTERNET_DISCONNECTED
long ass message
vernal lintel
is there an error map
vernal lintel
love
humble mortar
logs include the real description
vernal lintel
still do like ```
Failed to load canary.discord.com: ERR_INTERNET_DISCONNECTED
`...
just do this
vernal lintel
logs include the real description
no one who needs splash to tell them the problem will be looking at logs
humble mortar
evil
i love the word evil
wonderful
honestly id rather just Failed to load Discord: description
humble mortar
wonderful
if it fails with a uri payloud the actual error description could leak off the splash
humble mortar
honestly id rather just `Failed to load Discord: description`
ill do this
ok i pushed
OOPS
i may be stupid
i forgot to save
simple groveBOT
Content
It would be nice if the "about" page from the tray menu could show the current version.
simple groveBOT
humble mortar
@vernal lintel
vernal lintel
like arch repos?
humble mortar
extra yeah
vernal lintel
interesting
i wonder why the system electron choice
official discord packages and stuff don't do that either, do they?
humble mortar
no they dont
vernal lintel
i mean it doesn't matter that much but electron does have issues pretty often like the crashing in the past (v31 iirc) and the weird border rn on v35
humble mortar
yeah
and the recent hw acceleration flag changes
I'd be okay with the package bumping minor electron versions in the build and shipping that bundled
but system electron is too volatile
humble mortar
I'd be okay with the package bumping minor electron versions in the build and sh...
in fact I was thinking of doing this because of the border issue
vernal lintel
ah did they fix it?
vernal lintel
<@343383572805058560>
wonder if that guy even uses Discord
or if he's just interested in packaging it due to popularity
vernal lintel
cool
humble mortar
wonder if that guy even uses Discord
we'll see what they say about joining the server to talk about it
ughhh still no response from discord about the hardware encoded streams refusing to load issue
vernal lintel
I don't think anyone has ever successfully reported a bug via discord support
humble mortar
I don't think anyone has ever successfully reported a bug via discord support
there was the bitrate issue that was reported and fixed
was @hybrid fjord I think
vernal lintel
but system electron is too volatile
on the other hand, if they use independent electron version they can push electron fixes independent from us
which also has its upsides
I'm not against using system electron
it's only bad when it creates issues for us (aka people complaining to us over something we don't control)
humble mortar
which is why i think the package bundling electron that can be changed when the package builds is better
so it can be reverted or bumped
simple groveBOT
humble mortar
@charred geyser
humble mortar
<@1363481780979503127>
@vernal lintel this is their acc
woeful current
v+ prog 1363481780979503127
humble mortar
<@1363481780979503127>
Is your new account for privacy or because you don't use discord?
charred geyser
Hey
I have an account using my personal email, but created this one now since this is arch business
Not a regular user any more tho, no
Happy to hear your input on vesktop in official repos
charred geyser
draft PKGBUILD, for reference: https://gitlab.archlinux.org/-/snippets/3774
simple groveBOT
humble mortar
Not a regular user any more tho, no
I'd prefer someone who is a regular user to maintain it simply because of how things might break and the like
charred geyser
Sure, I see that PoV
Just generally, what breakage are you expecting? Electron packages are in my opinion very stable, as long as one uses the same major as upstream. But I can see how vesktop might be more complex
The ambition is to reduce issues for you, not the opposite ๐
humble mortar
draft PKGBUILD, for reference: https://gitlab.archlinux.org/-/snippets/3774
can you read over the pkgbuilds in https://github.com/vencord/pkgbuilds
why start fresh instead of using these existing packages that we support
I'd also prefer NOT to use system electron. (you can read why if you scroll up)
youre also not using the right desktop icon
vernal lintel
both are fine honestly, doesn't matter much ๐
what kind of delay is expected between us publishing a new release and it getting updated in the official repos?
humble mortar
what kind of delay is expected between us publishing a new release and it gettin...
I'm also curious if we can setup an action to publish the electron builder .pacman target instead of using the pkgbuild
vernal lintel
vesktop usually doesn't have that frequent updates but things are a bit volatile due to depending on discord
there's always the possibility that things could break badly if discord makes major changes and we need to push an update quickly
humble mortar
yop
vernal lintel
can you read over the pkgbuilds in https://github.com/vencord/pkgbuilds
why star...
I had a quick skim of the package and it seems to make sure it uses the same electron major as upstream
minors don't necessarily have to match, it's probably even beneficial to use independent minor to get new electron fixes quicker
like the window border jank on gnome rn
humble mortar
it uses system electron yeahg
system electron on arch is usually latest minor for the packaged major versions
electron is just a link to the latest electronXX major
vernal lintel
we should copy over some of these dependencies from the discord package
same optionals and libnotify (same story as official discord app, notifications with no libnotify will crash the app)
humble mortar
those will be brought in if using system electron
look at vencord/pkgbuilds/vesktop(-electron)
vernal lintel
libnotify won't
humble mortar
yes look at the packages ive already written ๐ญ๐ญ๐ญ๐ญ
ive been through this whole rigmarole
vernal lintel
would be better to use the desktop build generated by electron builder instead of manually maintaining a separate one
charred geyser
what kind of delay is expected between us publishing a new release and it gettin...
Generally pretty quick, I check daily for updates. But of course, it adds a middleman
humble mortar
Generally pretty quick, I check daily for updates. But of course, it adds a midd...
how difficult would be to have myself as a co maintainer as youre not super active on discord?
I'm not really familiar with official maintainer guidelines and the like
humble mortar
would be better to use the desktop build generated by electron builder instead o...
do you mean the pacman target?
vernal lintel
referring to the .desktop file
charred geyser
Depends on what you're comparing to x) It's an application process, generally requires a few years of packaging/involvment
charred geyser
would be better to use the desktop build generated by electron builder instead o...
That might a good idea, haven't looked into that
humble mortar
referring to the .desktop file
youd probably need an afterPack script to do that on the directory build
like what I'm currently doing for the icons
vernal lintel
the dir target for some reason doesn't generate a desktop file, it's dumb
there's a pacman target that generates a tar.xz pacman package, that should contain one I think
for the flatpak we just extract the desktop file from the appimage
humble mortar
the `dir` target for some reason doesn't generate a desktop file, it's dumb
the...
yeah I was gonna say just make it build the .pacman then extract it
it'd increase build times but since its only a build once distribute to everyone it doesnt really matter
humble mortar
Depends on what you're comparing to x) It's an application process, generally re...
so no easy way to have me just for the one package?
hm
could we maintain the official extra package on a clean branch in vencord/pkgbuilds then?
charred geyser
The source of truth for the PKGBUILD would be https://gitlab.archlinux.org/archlinux/packaging/packages/vesktop#
vernal lintel
could we maintain the official `extra` package on a clean branch in vencord/pkgb...
you're acting like we need to change it up all the time :P
just contribute to it now to make sure it's all good without issues and that should be all that's needed
we can always get in touch again later if there are any changes needed
humble mortar
The source of truth for the PKGBUILD would be https://gitlab.archlinux.org/archl...
oh I completely forgot I can send patches via the gitlab
yeah I'm overcomplicating it
oopsies
charred geyser
Just to circle back a bit on the discussion, the reason for adding to extra as I see it is that neither you nor the users would have to deal with build issues ๐ If you'd prefer to continue via the AUR, I'm not going to overrule that
charred geyser
I gotta log off pretty soon, I don't think there is any urgency to do anything really, so we can iterate on the PKGBUILD and also make sure you get accounts on gitlab.archlinux.org before doing anything
You'll need that for issues/patches
humble mortar
yeah i already have one
thanks!
I'll look at doing the .pacman target extraction stuff
charred geyser
Thank you! Good discussion all around ^^
vernal lintel
adding it to extra is definitely a good idea, thank you for taking initiative
it just needs to be done right, I still have ptsd from when one of the (unofficial) aur packages bumped to a broken electron major and we got tons of reports over that ๐ถ
charred geyser
Totally get that and empathize, AUR can be a bit chaotic at times ๐
hybrid fjord
was <@242305263313485825> I think
i don't think it's fixed
just reported and stalled
it's still occurs
humble mortar
@charred geyser
simple groveBOT
humble mortar
@vernal lintel you nuked issues?? ๐ญ
vernal lintel
ye i disabled them
humble mortar
insane
humble mortar
tracking issue for more customization gootbye
vernal lintel
people should post in support
vernal lintel
humble mortar
gonna open issues by PRing a space in the readme
vernal lintel
we can turn them on again in the future
humble mortar
thats what they all say...
next youll archive the repo..
vesktop going closed source!!!
vernal lintel
TRUE
lmfao
we just need to make vesktop wiki a reality
force me to tomorrow @humble mortar
humble mortar
im on vacation tomorrow
and every other day that ill need to help make a wiki
sorry!
how the hell do i fork on the arch packages gitlab
husk can i not do it cause the repo is empty
evill
humble mortar
<@1363481780979503127>
@charred geyser
tidal quarry
force me to tomorrow <@721853658941227088>
ill force you oomf
charred geyser
<@1363481780979503127>
Thanks for the patches! Busy with work mostly now during the weekdays, but Iโll get to it eventually ๐
humble mortar
@vernal lintel do wiki
vernal lintel
@humble mortar
โ ๏ธ Arcane is banned.
humble mortar
# <@721853658941227088>
# โ ๏ธ Arcane is banned.
me if you care
vernal lintel
me if you care
looks hideous...
did the blurfonts stuff get fixed in electron yet
oh my god ๐ญ
this is that gnome window border bug
humble mortar
did the blurfonts stuff get fixed in electron yet
its fixed in electron 36 unless they backport the patch
vernal lintel
is the fix just a chromium bump?
humble mortar
ya
vernal lintel
doubt they're gonna backport that unless google backports
does google backport to old versions?
or do they only have exactly one latest version
humble mortar
they back port some things
idk if slightly blurry fonts is a priority for them ๐ญ
vernal lintel
i am so thankful for github and friends so that I don't have to use this atrocious interface https://chromium.googlesource.com/chromium/src/+log/136.0.7103.25..136.0.7103.33?n=10000&pretty=fuller
i feel bad for google engineers
what do companies like google even gain from using their own git server
humble mortar
https://skia-review.googlesource.com/c/skia/+/952636 this is the blurry fonts fix btw
humble mortar
what do companies like google even gain from using their own git server
control
most have github mirrors anyway so like
humble mortar
isnt google git just one MASSIVE monorepo
is that true????
holy fuck
95% of google slop is in a mono repo
humble mortar
how tf do you even organize dependencies like that
vernal lintel
95% of google slop is in a mono repo
this is why you have to use some google program to clone code instead of git clone
humble mortar
this is why you have to use some google program to clone code instead of git clo...
hop on cloning from the github mirrors
vernal lintel
Typical use involves Clients in the Cloud (CitC). This system utilizes cloud backend and a local FUSE filesystem to create an illusion of changes overlaid on top of a full repository. This approach enables seamless browsing and use of standard Unix tools without explicit synchronization operations, thus keeping the local copy very small (average size of a local copy is less than ten files). All file writes are mapped to snapshots thus permitting restoration of the previous states of the code without explicit snapshotting. Due to the always-connected operation, CitC allows easy switching of the computers as well as sharing the modified code with other developers, the automated build system and testing tools.[7] As a result, the majority of Google developers practices trunk-based development with no personal branches; the branches are mostly used for releases.[8]
๐ญ
humble mortar
oh wow using a FUSE overlay is actually smart wtf
cloning the whole thing would be terrifying
humble mortar
WHAT THE FUCK
vernal lintel
as of 2016, the repository was storing 86 terabytes of data comprising two billion lines of code in nine million files (two orders of magnitude more than in the Linux kernel repository). 25 thousand developers contributed 16 thousand changes daily, with additional 24 thousand commit operations by bots. Read requests each day are measured in billions.[6]
2016
humble mortar
google literally reinvented old svn style takeout systems ontop of git
genuine insanity and not the good kind
cyan flame
> as of 2016, the repository was storing 86 terabytes of data comprising two bil...
Soon Vencord will have these stats too
teal stump
me if you care
D
scenic hollow
this is also related to capturing mouse button stuff
also rewrote the whole ui lol
SOMEONE PLEASE FIX MY UGLY ASS REACT CODE IDK REACT OR UI DESIGN
upper pine
Sorry for the inactivity on venmic - have a lot to do currently :) I've just updated rohrkabel to support coroutines (async/await) and made some general improvements.
Will work on a bigger venmic update soon :P
humble mortar
the thankless work continues..
upper pine
As always
simple groveBOT
Compiled this change and it doesn't seem to work on windows, apologies for the lack of input but I have 0 knowledge when it comes to electron's screwery.
simple groveBOT
humble mortar
@vernal lintel the DE might just be cooked and need the hint anyway
vernal lintel
simple groveBOT
sour muralBOT
cause of this? https://github.com/Vencord/Vesktop/blob/main/package.json#L67C10-...
package.json: Line 67
"productName": "Vesktop",
As name, but allows you to specify a product name for your executable which contains spaces and other special characters not allowed in the name property
????
closed by stalebot
vernal lintel
sour muralBOT
dude https://github.com/electron-userland/electron-builder/blob/c544abf1d7ada6d5...
LinuxTargetHelper.ts: Lines 136-141
// https://askubuntu.com/questions/367396/what-represent-the-startupwmclass-field-of-a-desktop-file
// must be set to package.json name (because it is Electron set WM_CLASS)
// to get WM_CLASS of running window: xprop WM_CLASS
// StartupWMClass doesn't work for unicode
// https://github.com/electron/electron/blob/2-0-x/atom/browser/native_window_views.cc#L226
StartupWMClass: appInfo.productName,
literally not true
humble mortar
dumb ass default tho
vernal lintel
In what scenario would you want the wm class to be the product name instead of the binary name
never
we should pr fix to it
humble mortar
the wmclass and binary name can be different
in fact by spec they should be
binary name of vesktop and class of dev.vencord.Vesktop
but nobody cares about the spec
hop on doing wtfyw
vernal lintel
but startupwm class has to match the desktop file name
either that or binary name idk this stuff is confusing
but product name is the worst possible default lmao
humble mortar
but startupwm class has to match the desktop file name
yop and the .desktop doesnt need to match the binary name
dev.vencord.Vesktop.desktop can launch vesktop just fine
humble mortar
productName is supposed to be dev.vencord.Vesktop I assume I think
name would then be Vesktop
so by spec its correct
but by convention ๐ถ
i think they'd reject that pr on grounds that it'd break people who are actually following spec
how do you even change the wmclass that vesktop uses
does electron even let you
vernal lintel
productName is supposed to be dev.vencord.Vesktop I assume I think
no
product name is human readable name
vernal lintel
i think so anyway lmao
maiden pulsar
how's that related to this channel
It might brick Vesktop considering all the desktop functionality would be reimplemented in that and work fundamentally different than how it does with Vesktop
maiden pulsar
Aight
scenic hollow
@brazen kite btw can you try your mouse buttons with the latest commit in the pr
oblique egret
// Transparency fixes, window is resizable when fullscreen/maximized
this.mainWindow.on('enter-html-full-screen', () => {
this.mainWindow.setResizable(false)
})
this.mainWindow.on('leave-html-full-screen', () => {
this.mainWindow.setResizable(!this.mainWindow.isMaximized())
})
this.mainWindow.on('enter-full-screen', () => {
this.mainWindow.setResizable(false)
})
this.mainWindow.on('leave-full-screen', () => {
this.mainWindow.setResizable(!this.mainWindow.isMaximized())
})
this.mainWindow.on('maximize', () => {
this.mainWindow.setResizable(false)
})
this.mainWindow.on('unmaximize', () => {
this.mainWindow.setResizable(true)
})
this.mainWindow.on('will-move', (e) => {
if (this.mainWindow.isMaximized()) {
this.mainWindow.setResizable(true)
this.mainWindow.unmaximize()
e.preventDefault()
}
})
some foolproof improvements for transparent window handling, enjoy
i couldnt fix the window snapping or the title bar dblclick to fullscreen
that'd require native code, cba
humble mortar
```ts
// Transparency fixes, window is resizable when fullscreen/maximized
this....
?
oblique egret
?
enabling transparency = buggy
this code fixes a lot of said bugs
well, works around them
but same thing
oblique egret
not an electron thing
humble mortar
transparency stuff works fine on linux
oblique egret
its a chromiumg thing
oblique egret
transparency stuff works fine on linux
no, no it doesnt
humble mortar
ive literally not had any issues๐ญ
humble mortar
its a chromiumg thing
i mean if chromium itself is never in a transparent state and it never can be it's really an electron issue
oblique egret
its a chromium issue
grizzled hemlock
Is vesktop taking forever to load a known issue
Recently it's been taking forever >30s to reload the page ctrl-r or from scratch
vernal lintel
Recently it's been taking forever >30s to reload the page ctrl-r or from scratch
ClientTheme issue maybe?
some people were saying it causes that
grizzled hemlock
ClientTheme issue maybe?
No, I don't have it enabled.
vernal lintel
No, I don't have it enabled.
you will debug why it happens
humble mortar
Recently it's been taking forever >30s to reload the page ctrl-r or from scratch
ur internet might just be cooked
or its not caching the page correctly for some reason
aren't you on nixos
maybe no perms write to cache
grizzled hemlock
maybe no perms write to cache
insane
woeful current
maybe no perms write to cache
remember: if you have an issue on NixOs the issue is NixOs
sudden trout
it's not a nixos issue cuz it works for me 
humble mortar
it's not a nixos issue cuz it works for me <:Shrug:1195822300503756920>
nixos is known to have one singular config file that everyone uses ๐ฅธ
sudden trout
nop but we both use the same vesktop package
brazen kite
<@602104493034831872> btw can you try your mouse buttons with the latest commit ...
sorry it took so long ๐. i reinstalled windows and couldnt be bothered to set up pnpm until now
it doesnt work yet
ok so it just broke all together, actually...
- switching tabs or leaving out of the keybinds menu resets the keybind u set
- in the menu while u have it set, trying to use the keybind doesnt work
also, just to reiterate, none of the buttons on my mouse are detected
scenic hollow
it doesnt work yet
yeah i wasn't entirely sure whether it would work or not
since then i have found out mouse buttons are an entirely separate event in libuiohook :P
scenic hollow
1. switching tabs or leaving out of the keybinds menu resets the keybind u set
huh weird how when recording keybinds it works just fine but not when saving them can you see if there is anything in the console logs??
scenic hollow
2. in the menu while u have it set, trying to use the keybind doesnt work
that's intentional. discord does the same thing
except it also has a warning about it :P
simple groveBOT
simple groveBOT
fallow quail
what's the context? i was honestly considering switching to using discord in firefox because electron font rendering is so bad lol
wait huh
Vesktop and Discord's official client use the same electron version now (it seems), but the latter somehow has font rendering more screwed lol
I assumed the issue was the same
the flatpak version is fine (just greyscale but still readable) but the portable is not (feels like I have eyesight problem)... ??
so I imagine this issue doesn't have many people complaining because it somehow depends on the environment (??) and I also imagine it's much worse at 1080p 1x scale (which I use )
vernal lintel
what's the context? i was honestly considering switching to using discord in fir...
cause its a bug and already fixed in electron
brazen kite
except it also has a warning about it :P
for what it's worth... I just tested it on linux with the latest PR (thank you for fixing the issue with the keybinds not saving) and it worked
I can try windows on the PR later
simple groveBOT
simple groveBOT
scenic hollow
can someone here clone my fork and update the venbind version to 0.1.6 and see if everything works properly on x11???
woeful current
twitter eleven
