#🖥-vesktop-development
sudden trout
humble mortar
simple groveBOT
next sundial
grizzled hemlock
Why are you posting this here? What does this mean?
vernal lintel
Why are you posting this here? What does this mean?
woke propaganda in my vesktop development channel??
grizzled hemlock
woke propaganda in my vesktop development channel??
humble mortar
Why are you posting this here? What does this mean?
why are you hating???
simple groveBOT
grizzled hemlock
why are you hating???
I just hate women
next sundial
are these flags from Vencord also applied to Vesktop?
btw here's my chrome://gpu in 1.5.5 :)
on AMD with Mesa drivers
also, what about ozone hint to wayland?
on chrome://gpu it says x11, so I think vesktop is running through xwayland
humble mortar
btw here's my `chrome://gpu` in 1.5.5 :)
mine
humble mortar
are these flags from Vencord also applied to Vesktop?
those are runtime flags so yes theyre applied
with these flags
amd mesa needs vulkan wayland for full hardware accel
humble mortar
also, what about ozone hint to wayland?
just pass the flag wdym
next sundial
with these flags
hmm, maybe we could add some of your flags to vesktop's default config?
next sundial
just pass the flag wdym
ozone-platform-hint defaults to x11 currently
humble mortar
no
next sundial
vesktop could use auto, potentially
humble mortar
hmm, maybe we could add some of your flags to vesktop's default config?
no they are config specific
humble mortar
ozone-platform-hint defaults to `x11` currently
yeah because thats the electron/chromium default
next sundial
I don't see any harm in enabling Vulkan, but I may be wrong
next sundial
yeah because thats the electron/chromium default
lemme check if there's any progress on upstream to change the default
humble mortar
I don't see any harm in enabling Vulkan, but I may be wrong
just enabling it does nothing it needs to be set as the backend which is where the issue is for setups that dont support it
the defaults are fine as is
humble mortar
thats likely due to their setup not working with wayland hardware accel
anyway doesnt matter
@vernal lintel what were the things u wanted me to do in the prs
next sundial
lemme check if there's any progress on upstream to change the default
TL;DR:
Electron devs don't want to deviate from official Chromium builds
as long as Chromium doesn't default to Wayland, neither will Electron
vernal lintel
<:SKULL_SKELETON:1133504974777757726> https://github.com/electron/electron/issue...
a bit of an overstatement but yes it's bad lol
vernal lintel
<@343383572805058560> what were the things u wanted me to do in the prs
idk bro
vernal lintel
as long as Chromium doesn't default to Wayland, neither will Electron
neither should we (but the flatpak does (and it's causing some issues lol))
next sundial
neither should we (but the flatpak does (and it's causing some issues lol))
then the flatpak shouldn't!
vernal lintel
yes i was thinking about it
vernal lintel
u wanted something in the arrpc prs done 😭 i dont rmember
oh just get ur arrpc pr merged
lol
next sundial
ideally, flatpak should match native packages' experience
humble mortar
yes i was thinking about it
maybe just have it not have perms to wayland backend by default
next sundial
I believe this can be consolidated into a single line
if [[ $XDG_SESSION_TYPE == "wayland" ]] && [[ -c /dev/nvidia0 ]]; then
I think it is this
btw
I personally use a custom vesktop.desktop to use the Discord icon instead of the default Vesktop icon
however, it requires a window rule in KDE to make the icon apply in other scenarios (such as alt+tab)
is there anything that can be done from Vesktop's side to avoid requiring the window rule?
sudden trout
shrimply build your own vesktop package with wayland flags hard coded 
vernal lintel
```bash
if [[ $XDG_SESSION_TYPE == "wayland" ]] && [[ -c /dev/nvidia0 ]]; then
`...
no
next sundial
thats what theyre for
what about gnome people :(
simple groveBOT
vernal lintel
happy? @next sundial
next sundial
XD
vernal lintel
gotta fix
next sundial
much important
btw @vernal lintel
lmao I had an idea
just change it to Copyright (c) $CURRENT_YEAR Vendicated and Vencord contributors
📈
vernal lintel
trolley
vernal lintel
just change it to `Copyright (c) $CURRENT_YEAR Vendicated and Vencord contributo...
yeah it's like that now
the rule was just configured poorly
sour muralBOT
https://github.com/Vencord/Vesktop/blob/main/scripts/header.txt#L1-L5
header.txt: Lines 1-5
/*
* Vesktop, a desktop app aiming to give you a snappier Discord Experience
* Copyright (c) {year} {author}
* SPDX-License-Identifier: GPL-3.0-or-later
*/
powerful
vernal lintel
I also changed everything from GPL-3.0 (unclear whether it means gpl3 only or gpl3 or later) to GPL-3.0-or-later
vernal lintel
all of them still use 2023
yes because they were mostly authored in 2023
next sundial
I also changed everything from `GPL-3.0` (unclear whether it means gpl3 only or ...
if you don't specify the "or later" clause then it's only, from my understanding of the license
next sundial
yes because they were mostly authored in 2023
hmm, I thought you meant to update the copyright year to $CURRENT_YEAR for all of them
but yeah that also works
the license says:
Each version is given a distinguishing version number. If the
Program specifies that a certain numbered version of the GNU General
Public License "or any later version" applies to it, you have the
option of following the terms and conditions either of that numbered
version or of any later version published by the Free Software
Foundation. If the Program does not specify a version number of the
GNU General Public License, you may choose any version ever published
by the Free Software Foundation.
in this case, it was specified that it was GPL 3.0, but "or later" was not specified, so it probably means "only"
vernal lintel
if you don't specify the "or later" clause then it's `only`, from my understandi...
it's not very clear
next sundial
this is mostly relevant for GPL 2.0 software because GPL v4 doesn't exist and there are some people that don't agree with GPL v3 (notably The Man™️, Linus Torvalds)
so yeah good to clarify but no danger not to clarify
vernal lintel
In a hypothetical case that a gpl4 ever comes out, it's good to have or later
because otherwise you have to ask everyone who contributed lol
next sundial
yep
theoretically, your change would require everyone to agree
because you're imposing a new license condition
but I don't think anyone will come and fight you for that
so that's fine
it would be a problem if it was from GPL-2.0 to GPL-2.0-or-later
but that's not the case, so no big worries
for peace of mind
Linux kernel uses
SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note
so only having the version number means "only this license"
vernal lintel
theoretically, your change would require everyone to agree
I know everyone who made substantial changes and know none of them would mind
the contributors I don't know all only made one single contribution which only changes a few lines which is not substantial enough to be able to copyright it
humble mortar
I know everyone who made substantial changes and know none of them would mind
UHHH EXCUSE ME I REJECT THIS LICENCE CHANGE!!!!!!!!!!!!.!>1.1.1.!!!1
vernal lintel
UHHH EXCUSE ME I REJECT THIS LICENCE CHANGE!!!!!!!!!!!!.!>1.1.1.!!!1
coming to your house and killing you so you can't object
vernal lintel
I will pay you with two bottles of maple syrup if you agree to the licence change
humble mortar
idiot i can go to the corner store and get two bottles so fast
real maple syrup too not that trash american shit
vernal lintel
no im full of maple syrup and have 10 bottles left
and you're getting none of this if you don't accept
humble mortar
no im full of maple syrup and have 10 bottles left
vernal lintel
NO
humble mortar
😭
vernal lintel
blocked
humble mortar
while we of yamatai bask in the warmth of her grace, those who oppose us will burn!!!!
vernal lintel
while we of yamatai bask in the warmth of her grace, those who oppose us will bu...
I will spoil tomb raider if u don't accept licence change
Lara dies and so does Sam (real fact)
humble mortar
NOOOO NOT MY LESIBIANBS
vernal lintel
I was sad that tomb raider rise doesn't have Sam
she's only in the one you're playing rn
vernal lintel
no it's true 😭
humble mortar
lalalalalala
humble mortar
did u watch the animated tomb raider show that netflix made
vernal lintel
lalalalalala
wdym that's not even a spoiler 😭
humble mortar
im in the fog
why the fuck is there an entire ship skeleton suspended on gondola towers 😭
who did that
insane
vernal lintel
lmaooo
tomb raider logic
video game logic never fails to crack me up
"QUICK YOU HAVE TO HELP US DEFEND AGAINST THESE INTRUDERS"
I stroll elsewhere and spend hours exploring random caves and treasure and what not, meanwhile the intruders nicely wait until I'm back before they attack
humble mortar
literally me 100%ing every area b4 i leave
vernal lintel
I'm way too lazy for that I just do it after finishing the game
sometimes you have to backtrack anyway cause of new equipment
vernal lintel
literally me 100%ing every area b4 i leave
I hate hate hate when linear games have two paths where one of them progresses the story with no way to go back and no warning
you have to guess which path is the explore path
vernal lintel
I hate hate hate when linear games have two paths where one of them progresses t...
fucking resident evil village
there's a few places like that in that game
next sundial
I will spoil tomb raider if u don't accept licence change
tomb raider spoiler:
there's a tomb that is raided
scenic hollow
is there already some sort of api for getting a context-thing or do i have to go find an instance of it myself with a patch
humble mortar
@vernal lintel I just realized the obs patch is always enabled even if youre in a flatpak or arrpc is disabled
vernal lintel
doesnt really matter
humble mortar
muh UX
vernal lintel
it also shows up if you use discord flatpak
humble mortar
thats not official tho
vernal lintel
yes it is lol
vernal lintel
simple groveBOT
next sundial
the ownership of this pile of trash has been verified by the garbage collectors
(I hate Electron)
simple groveBOT
silk elk
vernal lintel
but flatpak
cyan flame
gonna add `vflatpak` command soon
vnixos command 
simple groveBOT
It literally is a flathub issue. For some reason, every build is being held for manual review for apparently adding a permission that has already been there and approved before
vernal lintel
"i have no clue what im talking about but im still gonna pretend like I do and throw blame"
cyan flame
"i have no clue what im talking about but im still gonna pretend like I do and t...
just blame cookie
simple groveBOT
simple groveBOT
scenic hollow
oh and some docs would be nice maybe
simple groveBOT
humble mortar
just blame cookie
WHAT DID I DO
cyan flame
WHAT DID I DO
humble mortar
does discord use a native module for mic capture?
vernal lintel
ofc
simple groveBOT
simple groveBOT
floral ledge
@scenic hollow this behavior seems incorrect
I would check the modifiers / keys to make sure the keys/modifiers released are actually a part of the keybind
shouldnt be too hard
i also see it only allows one keybind to be down at once
next sundial
@vernal lintel https://github.com/flathub/dev.vencord.Vesktop/blob/master/dev.vencord.Vesktop.yml#L22-L23 are those just for convenience?
if so, I suggest we add xdg-desktop:ro too
humble mortar
electron xwaykand issue
humble mortar
its actually the entire show window process thats delayed
scenic hollow
i also see it only allows one keybind to be down at once
yeah i made it like that on the basis that only one keybind can be held down at a time
scenic hollow
<@339669513912057857> this behavior seems incorrect
how so? my logic was a keyup event can be triggered either when: 1. another new key is held thus technically making it not the same as the old keybind or 2. when any key is released thus making the whole keybind released (and we can be sure of that because of the first point. if a key not part of the keybind was pressed we can be sure we've already handled it)
scenic hollow
yeah i made it like that on the basis that only one keybind can be held down at ...
i actually have no idea if that's what vanilla discord does hm
floral ledge
how so? my logic was a keyup event can be triggered either when: 1. another new...
if its not only one keybind being able to be held then this logic doesnt work
this is also restrictive for any other potential users of the library
and may not match xdg behavior
scenic hollow
ok so vanilla discord also allows multiple keybinds
i still think it's acceptable behavior for now. i'll try to implement that later maybe
scenic hollow
and may not match xdg behavior
xdg behavior might even vary between desktop environments i don't think that's a standard thing to aim for at all
simple groveBOT
carmine drum
"prevent it"
that aint preventing shit thats just forcing the volume by setting it 10 times a second
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
humble mortar
thats an entirely different issue 😭
grand swift
it does now
(i made one :3)
I need to look into venmic to figure out how to get the pipewire node id (it's hardcoded rn) and then we good
humble mortar
holy shit thats awesome lol
how does it work
ohh right
so youre taking the gamescope provided pipe and wrapping it with dbus to pretend to be the screen capture portal?
grand swift
so youre taking the gamescope provided pipe and wrapping it with dbus to pretend...
correct
grand swift
it's a pipewire stream of the display output
there's also per app streams I think but those are way more complex
humble mortar
ohh for steams replay system I guess
humble mortar
there's also per app streams I think but those are way more complex
do that and proper screenshare portal wrapper whammo
grand swift
per app I don't really care
if it's not too ass to implement I'll do it
but I just want something
humble mortar
is this going to be a decky plugin
grand swift
yes because it needs a bind mount and some other configuration to tell xdg-desktop-portal about it
humble mortar
cool that decky lets u get that low
humble mortar
cool that decky lets u get that low
i put virus on decky store
grand swift
wrong
we check over everything and you need to build from source in our ci (aside from some special cases)
grand swift
yeah
humble mortar
love
grand swift
I don't usually do plugin review but sometimes I do
train and emerald usually do plugin review
vernal lintel
https://github.com/yshui/x11screencast-portal/issues/1
you will PR something good like Apache or GPL
vernal lintel
wait it's the Picom dev
horror
he loves MPL2.0
PR MPL2.0 @grand swift
this guy also loves not adding licenses to his projects
damn
grand swift
this guy also loves not adding licenses to his projects
very unfortunate
these people should stop doing that
humble mortar
github should change their uploading rules to make all public unlicensed projects public domain
real
grand swift
it does now
@vernal lintel love
vernal lintel
scary
grand swift
github should change their uploading rules to make all public unlicensed project...
Good
vernal lintel
why is it quadrupled
humble mortar
QAIT I DIDNT NOTICE THAT 😭
vernal lintel
https://github.com/yshui/x11screencast-portal/issues/1
why even base it on that wouldnt it have been easier to fork something else
grand swift
prototype
grand swift
why even base it on that wouldnt it have been easier to fork something else
nop
there's no sane portal impl that isn't 473828292828 lines of c or rust implementing every single interface
vernal lintel
love
grand swift
this just implements the bare minimum for screenshare
which is what i need
mainly I just copied all their types
and serialization shit for them
cuz i dont understand it well enough to implement that myself
humble mortar
cuz i dont understand it well enough to implement that myself
&good
do not try to understand
you will go down a rabbit hole
grand swift
dbus is horrifying
humble mortar
never to be seen again
grand swift
and this is my first ever time using rust for anything serious the serialization shit seems like magic rn
vernal lintel
hot juniper
github should change their uploading rules to make all public unlicensed project...
love
grand swift
<@343383572805058560>
they still didn't add
but they work for codeweavers so maybe they need permission or smth
I will wait
grand swift
@vernal lintel good
humble mortar
venmic has a hard minimum glibc version as well
look on the issue tracker
no point in supporting below that
humble mortar
@hybrid fjord youre probably better off directing people to #326
grizzled hemlock
@humble mortar uhhh is it a known issue that reloading while the debugger is paused crashes the app
vernal lintel
vesktop code cant cause segfault
grizzled hemlock
vesktop code cant cause segfault
not a segfault
execption in main process
i have to kill it
grizzled hemlock
what's the trace
humble mortar
vesktop code cant cause segfault
can call something that does
humble mortar
HORROR
grizzled hemlock
humble mortar
why isnt it happening for vee then
grizzled hemlock
set breakpoint, reload
everything will freeze, the screen will go white
after a bit (30-60 seconds) this pops up
humble mortar
breakpoint or pause
grizzled hemlock
set breakpoint, reload
everything will freeze, the screen will go white
reload while paused in the breakpoint
humble mortar
hm
I'm gonna say its likely the on page change detection that checks for error codes having an issue with paused renderer
humble mortar
sadan screenrecofd
vernal lintel
ctrl r?
grizzled hemlock
yeah
humble mortar
sadan screenrecofd
prepare for INSANE music
grizzled hemlock
horror
let me go to stable first
(not discord stable, but a non-devbuild of vencord)
humble mortar
🤨
vernal lintel
humble mortar
im doing absolute horror, but that shouldnt affect this
if u can't repo on mainline I'm gonna execute you
grizzled hemlock
if u can't repo on mainline I'm gonna execute you
grizzled hemlock
@humble mortar
humble mortar
YOURE BREAKPOINTING RENDERER
grizzled hemlock
YOURE BREAKPOINTING RENDERER
yea
was debugging something else that errored there
humble mortar
I'm gonna say its likely the on page change detection that checks for error code...
,
humble mortar
I'm not at laptop
and I dont even think its our fault
I'm consuming the event safely
(if it IS that)
grizzled hemlock
(Also have had the same issue with reloading after renderer, but can't repro)
I'll try and take a look at it later
simple groveBOT
humble mortar
some busybody noticed
wuh woh
also equibob
horror
definitely the most liscence abiding project
vernal lintel
<@721853658941227088>
why the fuck r u putting a breakpoint there 😭
cyan flame
bruh
grizzled hemlock
why the fuck r u putting a breakpoint there 😭
Not the exact place I was debugging, but it's similar and causes the same issue
That was just a easy place to test
cyan flame
definitely the most liscence abiding project
I genuinely don’t know if this is sarcasm or not
tired oak
@vernal lintel thank you all I did was merge your changes and this happened 😭
I'm not trying to start a fight or anything I want to be on good terms lol
vernal lintel
they werent even talking about ur fork
they were talking about my commit
and they're not wrong 
it's just I know everyone would agree
tired oak
I know but I was mentioned so I feel like a thank you as needed that's all
tired oak
Only issue I have is simple header fucking up eslint with the new lines 😭
https://codeberg.org/rini/eslint-plugin-simple-header/pulls/5
Not sure if it happens on Linux but at least on windows it does that
vernal lintel
Only issue I have is simple header fucking up eslint with the new lines 😭
htt...
how?
probably CRLF shenanigans
run this
git config --global core.autocrlf false
git config --global core.eol lf
changed my file to CRLF and cant repro
tired oak
probably CRLF shenanigans
run this
```sh
git config --global core.autocrlf fals...
I did thats the worst part
ill run it rq again just to see
it was on save eslint was fine
so ctrl s for example broke it
but pnpm lint:fix was good
and now suddenly its happy and all I did was change the package back
weird
probably vsc being vsc
next sundial
am I the only one that noticed a new fade effect when exiting image previews?
simple groveBOT
humble mortar
HOLY MOLY I JUST HAD PEAK IDEA FOR THE SPLASH SETTINGS TO MAKE IT MERGEABLE
let me cook
heady merlin
HOLY MOLY I JUST HAD PEAK IDEA FOR THE SPLASH SETTINGS TO MAKE IT MERGEABLE
hack into my account and merge
grizzled hemlock
?remind one week get @humble mortar to fix this
small lionBOT
Alright @grizzled hemlock, in 1 week: get @cookie to fix this
hybrid fjord
<@242305263313485825> youre probably better off directing people to #326
i've added note about 326 in top of the pr message
simple groveBOT
grand swift
git@github.com is ssh
vernal lintel
yeah but it's not
grand swift
I think npm defaults to git over ssh but I could be wron
Or there's some stupid npmrc in the actions image
vernal lintel
it worked fine before
simple groveBOT
next sundial
I noticed a little funny thing
after upgrading to Plasma 6.3.0
the notification badge in the Icons-Only Task Manager (taskbar) goes up and down when you receive a notification
it goes down when the pop-up is visible, and goes back up when it goes away
certified Electron+libunity moment
simple groveBOT
humble mortar
is that not just minimizing 😭
simple groveBOT
woeful current
AI pr my beloved
humble mortar
HELP I MADE A VIRUS
vernal lintel
what's a httsps
humble mortar
typo
trolley
should i implement splash ipc to give the user feedback when its in a retry loop
vernal lintel
event"Bus"
look inside
plain regular js eventemitter
humble mortar
trolley
vernal lintel
should i implement splash ipc to give the user feedback when its in a retry loop
I was gonna do this but I was lazy
like display what it's doing in the splash
kinda like discord
vernal lintel
ookie
humble mortar
ookie
also
you love how did-finish-load fires if it fails but .then doesnt
truely peak
also also should the retry loop be static time, linear, or exponential
i think discord does exponential
vernal lintel
also also should the retry loop be static time, linear, or exponential
don't change it
the way it is rn is already good
and pretty much copied over from discord but made the max delay much shorter
humble mortar
i write prod code first try (real)
ok time to write 3 line preload to expose main -> renderer ipc to the splash then have a 4 billion line entry the build script for it
let me write inline preload
grr
woeful current
i was thinking, is the vesktop flatpak supposed to support arrpc out of the box
humble mortar
we could add code to automatically handle spawning arrpc out of the sandbox and hook it in to the current handling
simple groveBOT
this PR also implements splash feedback while in the retry loop.
fixes: #1055, #969
to test uncomment lines 478 & 480 as electron will load from the cache if a remote fetch fails. (remove after review)
Splash CSS can prob be cleaned up/made prettier (raw chromium error code feedback probably isnt the most user friendly...,)
oblique egret
https://discord.com/channels/1015060230222131221/1026515880080842772/13398198028...
god i hate flatpak
hot juniper
god i hate flatpak
vesktop snap wen
safe olive
god i hate flatpak
Me too, but vesktop from flatpak is guaranteed to work on all distros
Not always, but in 9 out of 10 cases
oblique egret
Me too, but vesktop from flatpak is guaranteed to work on all distros
for my app its the other way around
.appimage and .deb just works
flatpak crashes, leaks memory, breaks hw accell
next sundial
flatpak crashes, leaks memory, breaks hw accell
flatpak is da best
just need to know the necessary flags to make it work
not that hard
also, electron/chromium has sandbox by default, that can cause issues as well
the worst thing in linux is app distribution, and flatpak/flathub is on the way to make it global
hybrid fjord
guys i have git skill issue😭 how to fix that shit xd
nvm i got it (i'm stupid enough at trying to fetch updates from local main repo............)
oblique egret
https://tenor.com/view/config-issue-onetap-hvh-csgo-gif-21674381
80% yes
20% flatpak being shit
hot juniper
stock discord doesnt even offer this
this should be a vencord plugin if anything
also i personally wouldnt freak out about the icon thing for this
hybrid fjord
omg that type of users are always here
woeful current
@humble mortar back in my arch era i never reviewed pkgbuilds
humble mortar
malware into my computer
woeful current
malware into my computer
malware in your bakery
sudden trout
the reason I love paru is that it actually makes you review the pkgbuild by default
also shrimply make your own package and hard code wayland flags
woeful current
the reason I love paru is that it actually makes you review the pkgbuild by defa...
yop
i just scrolled by
sudden trout
😭
humble mortar
also shrimply make your own package and hard code wayland flags <:trolley:102475...
paru -S vesktop --fm=nvim --savechanges
love
paru needs a better merge conflict system but other than that its perfect
woeful current
paru -S vesktop --fm=nvim --savechanges
nano.
austere wolf
how does vanilla discord stream certain application audios on windows?
is it some insane native or something?
everything i see online about how to get certain app audios needs a virtual cable
how tf
maybe something like this hm https://learn.microsoft.com/en-us/samples/microsoft/windows-classic-samples/applicationloopbackaudio-sample/
definitely needs an insane native
austere wolf
looks like it can be done without external software and in user mode though
as of windows 10
simple groveBOT
Discord Account
quadrinex
Motivation
The functionality of oppening links in app is usefull when you just want to see a post or smt like that, tho there are usecases where you need to open it in browser.
Solution
Add a "open in browser" button at 1 or 2.
Alternatives
When right clicking a link you have the option.
Additional context
No response
Request Agreement
- [x] ...
austere wolf
bro wtf
austere wolf
can you do that per-project
surely
bruh this file is crlf on remote
if i set vscode to lf it shows up as changes in git
what gives
literally all files are crlf
ah, git auto crlf
should ship a .gitattributes file, no?
austere wolf
i don't think this ever worked
this doesn't exist
this is like a chatgpt hallucination
also who's dr. vendicated vencord
vernal lintel
yeah it wont work lmao
oblique egret
tracks can have constraints and u can define them on getmediasession
but I don't think that exists in electon
that pr.is pure ai garbage
austere wolf
device id isn’t even an id lmao
humble mortar
????
austere wolf
anyways who wants to write like 50 lines of winapi ffi to capture audio from specific applications
humble mortar
pr it to venmic
austere wolf
oh ok
isn’t it just for linux tho?
i suck ass at C++ so i'd have a REAL hard time setting up the build chain for windows lol
should have used rust 🚀🚀🚀
humble mortar
what were you planning to use
austere wolf
didn't know venmic existed so i was literally just gonna brute force it with koffi
humble mortar
venmic is using napi so if you are kinda insane you could probably write the windows portion in rust without too much issue
austere wolf
but i do feel like that's a lot of opinionated changes so i'd probably want to talk to whoever does venmic first
humble mortar
@upper pine bwomp
austere wolf
austere wolf
otherwise i could make my own native probably
probably only for internal use tho
i ain't doin allat
maybe it would make more sense as its own native
humble mortar
i believe the idea of venmic is to have it be a viable screen audio module
having the windows portion be another module kinda defeats the point
simple groveBOT
Discord Account
pellern64
Motivation
i constantly have my discord's tray icon pinned to the task bar for when im in vcs. its very useful like that since it allows me to quickly check if im muted or not before i say something
for reference this is discord when im unmuted:
and when im muted:
while vesktop...
austere wolf
okay windows api in rust is miserable
i don't have to do much besides copy their C++ example and rust is making it harder so
hybrid fjord
Bro😭
hot juniper
???
humble mortar
unable to search issues syndrome
hybrid fjord
Question: what should i do or refactor in 517 tray icon PR for it to be merged? I want to work on it
hot juniper
unable to search issues syndrome
at least mark it as duplicate??
humble mortar
Question: what should i do or refactor in 517 tray icon PR for it to be merged? ...
right now I think you should just work on making it smaller and easier to review
theres lots of duplication last I checked
hot juniper
nope
it shows as closed as completed for me
watch this be locked to their new UI
github is so stupid
it is
upper pine
having the windows portion be another module kinda defeats the point
I was considering adding a gstreamer based windows audio capture, don't have the time to add it currently tho
hybrid fjord
theres lots of duplication last I checked
yeah but i really not sure that there is something not needed.
There's a lot of code for creating tray icon bc it sends from main -> rendered -> and back to main processed icon using IPC. That done because we don't want to add deps just for creating tray icon so i'm bypassing it using IPC and electron's canvas :c
But i'll try to recheck everything again and see what i can do
If you can, please also review what i can do for improving that
simple groveBOT
Discord Account
No response
Operating System
Arch Linux
Linux Only ~ Desktop Environment
Gnome on Wayland
Package Type
Flatpak
What happens when the bug or crash occurs?
Cancelling screen share through the system (portal) window picker makes Vesktop crash. Reproduces reliably every single time
Crashes when pressing cancel in this popup:
What is the expected behaviour?...
austere wolf
I was considering adding a gstreamer based windows audio capture, don't have the...
gstreamer?
i’m invested in this issue so i may be able to put in the time
upper pine
Yes, iirc they had quite the nice API for capturing audio and with all their other features it might be quite easy to feed that into a fake-node
The overall effort for windows is a lot higher since we cannot simply make a fake device / node as on linux iirc but we would have to create a dummy/fake-node for the JS audio capture
austere wolf
hmm right, i was looking into the windows api calls to get an audio stream but i didn’t think much further than that
austere wolf
buh how do i get it to put venmic as a dependency
the lockfile only downloads it for linux but i assume i shouldn't edit that
but i don't see anywhere else you can specify
oh, i see
build.mts
oh does gstreamer need to be installed by the end user
not epic
upper pine
oh does gstreamer need to be installed by the end user
You can make a static build for the required parts
austere wolf
oh hm oka
sudden trout
simple groveBOT
azure verge
mmmmm, no idea if this is an issue with just my system or if the plugin has started to randomly die out of nowhere but my streaming bitrate is VERY unstable and when it gets to around 2k, it drops down to like 100 before rising very slowly again
if anyone else is having issues i'll try to take some time to figure it out
next sundial
regarding https://github.com/Vencord/Vesktop/issues/758, I believe it should be reconsidered
as it seems, some flags (--enable-features) need to be used to allow HEVC playback on Linux
I'm on Fedora KDE with all codecs installed (proprietary included) and it still does not play
here's an example HEVC video
the video plays fine on VLC
but not via the embed
here is relevant info from chrome://gpu:
vernal lintel
humble mortar
defaulting to vulkan isnt a good idea
some cases electron cant access the drivers and crashes
vernal lintel
without vulkan hw video decode doesn't work at least for hvec
humble mortar
some cases electron cant access the drivers and crashes
on my system for instance theres two vulkan drivers it can use (nvidia or amd) chromium freaks out and fails unless I force override the vulkan icd path to just amd
humble mortar
without vulkan hw video decode doesn't work at least for hvec
using vulkan also causes x11 stability issues with webgl
and only works properly with ozone wayland
vernal lintel
people should just use good hardware and system imo
everything I ever tried works flawlessly for me on amd + fedora + gnome
humble mortar
angle also recently had a pr for wayland support so doing this vulkan thing will be useless soon(ish)
maybe we should just make a pinned issue containing the flags and some docs on what to do since it shouldn't be the default
vernal lintel
is it this? https://github.com/discord/electron/commit/4ef5f8d14be8cf005b1db5975...
we will fork discord electron
trol
humble mortar
4 years out of date
oh thats just main branch
still electron 32 is so old
also horror that they dont upstream their improvements
also also discord doesnt even have working linux hardware accel
its all software accelerated
humble mortar
theres no decoder or encoder usage when I test on discord desktop
vernal lintel
without vulkan hw video decode doesn't work at least for hvec
according to multiple sources you should only need PlatformHEVCDecoderSupport flag and nothing else but for me it only worked with all the other flags too
idek if my ffmpeg supports it so maybe that's why? aka I have no software decoder and only my gpu can decode it so I need full hardware acceleration
someone else should try if only that flag is enough for them
vernal lintel
according to multiple sources you should only need PlatformHEVCDecoderSupport fl...
yeah apparently ffmpeg does support hvec but pretty sure fedora doesn't include the nonfree stuff in their ffmpeg and I don't remember if I switched to full version
I should try with full ffmpeg and just the hvec flag to see if that will work
at the same time does chromium even use system ffmpeg (or ffmpeg at all) I have no idea
vernal lintel
btw I was looking at what flags discord passes earlier to see if that's why hvec works on discord desktop (it isn't) and noticed they disable a bunch of features
we should see what those are and if we should also copy those over
humble mortar
whered you see that
vernal lintel
literally just pgrep for discord while having it open lmao
check the commandline
you can unpack their asar files to look at the native code
maybe there's a comment saying what the flags are for but probably won't be
humble mortar
electron has a bunch of default flags too so a lot of it is likely that
hot juniper
https://cdn.discordapp.com/attachments/1024286218801926184/1236601516555767860/c...
this gif will never go away will it
cyan flame
this gif will never go away will it
It’ll go away when it’s not true
Which will never happen
hot juniper
It’ll go away when it’s not true
hot juniper
Actually I hope that gif escapes vencord one day
Please
I want to see github users being called out for not reading in many more places
austere wolf
vernal lintel
electron has a bunch of default flags too so a lot of it is likely that
nah
vee 13708 10.6 0.9 1212532728 148468 ? Sl 17:33 0:00 /home/vee/.dvm/Discord/Discord --type=renderer --crashpad-handler-pid=13667 --enable-crash-reporter=a6d9bc79-d635-4f5f-baaf-dc5eb8e0a18a,no_channel --user-data-dir=/home/vee/.config/discord --secure-schemes=disclip,sentry-ipc --bypasscsp-schemes=sentry-ipc --cors-schemes=sentry-ipc --fetch-schemes=disclip,sentry-ipc --app-path=/home/vee/.dvm/Discord/resources/_app.asar --no-sandbox --no-zygote --autoplay-policy=no-user-gesture-required --disable-background-timer-throttling --lang=en-GB --num-raster-threads=4 --enable-main-frame-before-activation --renderer-client-id=4 --time-ticks-at-unix-epoch=-1739807928523089 --launch-time-ticks=2076116206 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5509092303643614789,16162155985883643743,262144 --disable-features=AllowAggressiveThrottlingWithWebSocket,AllowAggressiveThrottlingWithWebSocketWinRetrieveSuggestionsOnlyOnDemand,HardwareMediaKeyHandling,IntensiveWakeUpThrottling,MediaSessionService,SpareRendererForSitePerProcess,UseEcoQoSForBackgroundProcess,WidgetLayering,WinRetrieveSuggestionsOnlyOnDemand --variations-seed-version
--disable-features=AllowAggressiveThrottlingWithWebSocket,AllowAggressiveThrottlingWithWebSocketWinRetrieveSuggestionsOnlyOnDemand,HardwareMediaKeyHandling,IntensiveWakeUpThrottling,MediaSessionService,SpareRendererForSitePerProcess,UseEcoQoSForBackgroundProcess,WidgetLayering,WinRetrieveSuggestionsOnlyOnDemand
vernal lintel
idk where tf SpareRendererForSitePerProcess is coming from
hot juniper
does anyone even know how chromium works
vernal lintel
neither discord nor vencord seem to set it
oblique egret
does anyone even know how chromium works
its hell trying to figure out
ive learnt to navigate the chromium source codebase
but its still hard
next sundial
is it this? https://github.com/discord/electron/commit/4ef5f8d14be8cf005b1db5975...
makes sense that would be it
next sundial
not sure which of those flags are necessary to play
I believe one or two are necessary
next sundial
we will fork discord electron
genuine question: why not have discord/electron as a base instead of upstream electron? wouldn't it be more benefitial? 🤔
next sundial
according to multiple sources you should only need PlatformHEVCDecoderSupport fl...
see https://rpmfusion.org/Howto/Multimedia, may be necessary for you
(in addition to the fedora's quick docs codec installation)
next sundial
according to multiple sources you should only need PlatformHEVCDecoderSupport fl...
if I use vesktop --enable-features=PlatformHEVCDecoderSupport, does it preserve the flags set by Vesktop or does it override all of them?
also, is it only temporarily or it gets saved for future launches?
oblique egret
if I use `vesktop --enable-features=PlatformHEVCDecoderSupport`, does it preserv...
if its the same flag 1:1 that it overwrites then whats in the js code will take priority
but if one flag is --enablefeature=x and another is --disablefeature=x its a pure gamba moment
some features prefer enabling ,some disabling
but if you mean if it nukes all the existing flags, then no
it prepends to what flags are set in js from my understanding of chromium switches
next sundial
regarding https://github.com/Vencord/Vesktop/issues/758, I believe it should be ...
tested here
vesktop --enable-features=PlatformHEVCDecoderSupport
does not work
vesktop --enable-features=CanvasOopRasterization,VaapiVideoDecoder,UseChromeOSDirectVideoDecoder,VaapiIgnoreDriverChecks,PlatformHEVCDecoderSupport,Vulkan,DefaultANGLEVulkan,VulkanFromANGLE
works
Fedora 41, Wayland, AMD, KDE
oblique egret
arent like half of those features build flags
not runtime flags?
PlatformHEVCDecoderSupport
yeah this is a .gn flag:enable_platform_hevc=true
so the beauty of chrome, is it actually has SO many more features than you're led to believe, but many of them are in some way restricted as chrome has a fuckload of build targets, desktop, android, chromeos, cast, androidtv etc
for example chrome support hls, m2ts, dv, eac4, multi-track audio and video and a fuckload more
they are just behind build flags, and u cant turn them on at runtime
since they are yeeted at compile
oblique egret
hm
i think i know what it mmight be
nope i dont know
HEVC is enabled by default in electron nowdays, unless dickscord did some fucky stuff
humble mortar
tested here
```
vesktop --enable-features=PlatformHEVCDecoderSupport
```
does n...
vaapi doesnt work on amd without vulkan (and webgl has issues with vulkan enabled on x11)
I'm going to lose my mind if I keep repeating that
hot juniper
so the beauty of chrome, is it actually has SO many more features than you're le...
this is real and its horror
simple groveBOT
vernal lintel
hmm
hot juniper
sudden trout
simple groveBOT
vernal lintel
peak
simple groveBOT
hot juniper
peak
this is fire actually
WHAT IS THAT
is that an extension
i should contribute something significant to vesktop
i will add window key support to vesktop
hot juniper
i want to add a utility function that will be called from src/main/ipc.ts, shouldI just do it there or somewhere else?
guh theres already functions in there
vernal lintel
i want to add a utility function that will be called from src/main/ipc.ts, shoul...
depends how much code
might be better to create a new file if it's a lot
hot juniper
moving some code that already exists in the file to use it more generically
okay
i will explain what I am trying to do
because I don't want to commit to using something that will explode for no reason
i want to refactor this
can you explain what the point of BrowserWindow.fromWebContents(e.sender) ?? e.sender is
is it safe to just use mainWin?
i will figure it out and report back with my findings
ok my changes already dont work
@vernal lintel i have a feeling i know why you only half implemented this fix
no
i am stupid and forgot to update the ipc event definitions
my bad
vernal lintel
can you explain what the point of `BrowserWindow.fromWebContents(e.sender) ?? e....
no
hot juniper
whats wrong with using mainWin directly
hot juniper
what other window does it get called from
do not say discord popouts those dont count
i've looked through every other vesktop window
and i cant find anything that would call that
guh i have implemented that anyway
simple groveBOT
vernal lintel
remote: GitHub found 1 vulnerability on Vencord/Vesktop's default branch (1 moderate). To find out more, visit:
remote: https://github.com/Vencord/Vesktop/security/dependabot/9
remote:
hot juniper
```
remote: GitHub found 1 vulnerability on Vencord/Vesktop's default branch (1 ...
i am curious now
is it "moderate" but nobody really cares and you need some setup thats not possible anyway
vernal lintel
but this commit fixes it anyway lmao
hot juniper
ehhh i see
makes some sense but
WHO CARES
is it updated in vencord?
is it worth investigating what other window controls / settings that upstream discord uses can be added to vesktop
always on top for popouts?
vernal lintel
always on top for popouts?
essentially useless
your desktop should implement that
not the app
hot juniper
your desktop should implement that
HORROR
i mean yes
but the control
should it be added
windows users use vesktop too 😭
vernal lintel
HORROR
microsoft should stop being retarded and add this as a native feature https://learn.microsoft.com/en-us/windows/powertoys/always-on-top
most linux desktops and mac have it
but windows doesnt
average windows
hot juniper
windows doesnt even have modifier key to move window
hot juniper
average windows
real
just looking at discords wrapper over the window methods
WHAT IS THAT
oh
its their ancient game store
i genuinely thought this was their play again activities list for a moment
visual refresh jumpscare
the old one is so much more useful
does discord overlay exist on mac
nvm who cares about implementing the single use of DiscordNative.window.restore
i found more horror patching that needs to be done
hot juniper
essentially useless
trolley i just tried to do it to see if it was feasible or not and it turned out that it just doesnt work on wayland
vernal lintel
trolley i just tried to do it to see if it was feasible or not and it turned out...
yes because wayland doesn't allow windows to control stuff like that
they can't even control their own position
hot juniper
they can't even control their own position
yes its horror
vernal lintel
not allowing apps to do always on top is good tho
hot juniper
not allowing apps to do always on top is good tho
i actually agree with this
vernal lintel
the desktop environment should be responsible for it
allowing apps to do that plays into malware and such
hot juniper
i dont even think apps can know their own position
azure verge
if only apps could move themselves around on the screen 😭 could make some cool ass games
hot juniper
use xwayland for now
azure verge
lame
azure verge
oh my god i just imagined something hilarious
imagine if when you got a message
vesktop would slowly slide in from off the side of the screen, covering whatever you're doing
hot juniper
i got window controls working on visual refresh
not that it matters
ok today we will be installing discord for windows
noppppp
azure verge
windows 
hot juniper
where is my vencord
sudden trout
if only apps could move themselves around on the screen 😭 could make some cool ...
you can use wlr layer shell to make a fullscreen but not rly area to draw anything on (unless you're on gnome which is the only major comp that doesn't support it)
hot juniper
you can use wlr layer shell to make a fullscreen but not rly area to draw anythi...
i read about this
)
sudden trout
i read about this
it's what makes stuff like ags/astal or eww possible on wayland
I love
hot juniper
ok
why did i just install discord and vencord in my windows vm just to find out that i patched the visual refresh window controls properly and that it is supposed to look that cursed how they have the buttons implemented twice due to layers
explode?
i will nuke this vm
.
simple groveBOT
Discord Account
brightmang0
Operating System
Pop_OS!
Linux Only ~ Desktop Environment
Gnome
Package Type
Flatpak
What happens when the bug or crash occurs?
Every time I view GIFs, they appear as a mess of lines. This happens in DMs, servers, as well as when searching for GIFs.
![Image]...
hot juniper
i actually wanna use this vm later
hot juniper
@humble mortar i broke something and i dont know why it doesnt work
does this patch do ANYTHING other than what it says it does https://github.com/Covkie/Vesktop/blob/fc529b5b452228e18de0f4bdf0f7f4d16bdedf9e/src/renderer/patches/nativeFocus.tsx
or is deep linking just busted when using pnpm run start
all i did was remove the patch and patch the method it is calling
simple groveBOT
hot juniper
ok it just looks like the type:"CHANNEL" is Gone
ok im sorry i think i figured it out
ok sorry ignore all of that my bad (i forgot to update dependencies like a complete )
hot juniper
patching this
i was just about to submit my cursed pr for it
this will close 2 issues but not a 3rd one because wayland trolley
humble mortar
what're the issues
hot juniper
i will just submit my pr
humble mortar
ive had no issues with focus and maximize stuff
hot juniper
ignore horrible pr name
humble mortar
pr'ing out of date branch horror
hot juniper
SHUT
hot juniper
scroll up
hot juniper
Wayland 🚀 🚀 🚀 fixes this
humble mortar
can't wait for ext-zones and ext-layer-shell
hot juniper
i love my pr i hope it doesnt magically explode one day
humble mortar
discord will make visual refresh overhaul that explodes the patch
they likely will anyway cause as it stands pure web clients have huge empty bars at the top
so bad
oblique egret
holy man is still at it
hot juniper
they likely will anyway cause as it stands pure web clients have huge empty bars...
YOP
this PR could've been 2 PRs