#π₯-vesktop-development
simple groveBOT
vernal lintel
someone figure out new electron 34 flags
chromium 132
this stuff https://github.com/Vencord/Vesktop/pull/1007
but theres more flags
simple groveBOT
Tested it on several systems. With different people. And what can I say, after a few minutes the stream looks like this:
There is even more blurring in motion.
@Vendicated
Or worse:
This is the only thing that is so discouraging about using Vesktop under linux.
grand swift
It does do pipewire streaming actually
It just doesn't have the portal
The portal isn't that hard to recreate technically
I might have a go at it
since you could just return a handle to the gamescope pipewire stream
yop
I'll look into it in like a week
simple groveBOT
Discord Account
No response
Operating System
Windows 10
Linux Only ~ Desktop Environment
No response
Package Type
Setup exe
What happens when the bug or crash occurs?
90% of the time the PC restarts, the account simply logs out, and you need to log in again.
What is the expected behaviour?
Show log in every time I restart my pc
How do you recreate this bug or...
humble mortar
whats happening with https://github.com/Vencord/Vesktop/pull/1043
we had a convo but i forgor
vernal lintel
FIX LINTTT NERDDDD
vernal lintel
whats happening with https://github.com/Vencord/Vesktop/pull/1043
idk buddy
tomorrow is another day i think
i will check tmrw
vernal lintel
you will cope and have long single line
im sending zt to ur house if u dont fix
humble mortar
SCARY
hot juniper
INSANE WHY HAVENT YOU FORCE ENABLED IT YET
or at the minimum just patch out the hide token in vesktop itself
humble mortar
one day curve will take adderal and bang out venmic windows in 2 days
humble mortar
can decky plugins even interact with dbus like that
vernal lintel
im checking rn which of these electron supports
it doesnt support chrome://dino :(
these are the only things it supports
hot juniper
simple groveBOT
Seems to work on my machine.
GPU: Radeon 6900 XT
I initially attempted to use the existing Switch component, but it appeared inconsistent with the current UI due to its hardcoded colors. I'm open to using it if it's the preferred solution. In that case, I can refine the markup based on your suggestions.
I see, that's fair yeah! Switch is likely not the right Component, but Discord also has a Checkbox component that should be exactly what you want
Vencord doesn't export it for some reason, but you can manually find it via const CheckBox = findExportedComponentLazy("Checkbox", "Switch");. Search (Ctrl + Shift + F) for .Checkbox in sources in chrome devtools to find how Discord uses it & which ar...
vernal lintel
crazy how we never used that component in Vencord
heady merlin
vernal lintel
technically we alr export it
cause it's in that mega module and the Forms export is the whole module xD
Forms.Checkbox works but obv u shouldnt use that
simple groveBOT
I updated the component using the Checkbox component.
Regarding preferred settings for audio, currently, only the "Entire System" option can be saved. However, I believe it's best to exclude audio settings altogether.
vernal lintel
which
humble mortar
the vaapi flag thinf
vernal lintel
idk is it the same as that pr
humble mortar
yes π
humble mortar
i will check tmrw
bwah did you check
vernal lintel
no but i checked your other pr, thoughts?
vernal lintel
bwah did you check
guh the idea of rebooting to windows to test makes me shiver
worse than getting waterboarded for 2 hours straight
humble mortar
no but i checked your other pr, thoughts?
which one
I have two billion
if ur talking about the link event one
switching to real IPC seems like a good choice
less insane
vernal lintel
that ui lies sometimes
classic chrome moment
what gpu do u have @humble mortar @humble mortar @humble mortar
I can test on my gpu I have amd 6700xt
I also have a Vega 10 (integrated ryzen graphics) (shit gpu) π₯
humble mortar
what gpu do u have <@721853658941227088> <@721853658941227088> <@721853658941227...
amd igpu and nvidia dgpu
I'll share the flags I use for full hardware accel later
but tldr I enable vulkan and override the available vulkan interfaces to just be my igpu since chromium is SHIT and kills itself if nvidia is present
you lovee
humble mortar
but tldr I enable vulkan and override the available vulkan interfaces to just be...
this is so full encode and decode work
humble mortar
either way all of this is useless because of the Discord stroking out and not loading vaapi encoded streams on some peoples ends issue
simple groveBOT
I'll also mention that if you open the app inspector (Only with the .rpm package. Seems that arRPC with the .flatpak package doesn't detect any apps and vice-versa), you'll get some errors constantly when opening these apps:
humble mortar
discord broke rpc????
humble mortar
electron apps are notoriously bad at performance management when the CPU is under load
youre kinda cooked either way
especially if youre limited and can't hardware offload
hot juniper
electron apps are notoriously bad at performance management when the CPU is unde...
most of the problems vesktop has are just chromium or electron being horror
discord just decided that instead of making a native app they will write native code as a workaround for chromium being a mess
is there hope for chromium?
simple groveBOT
simple groveBOT
hot juniper
real
humble mortar
scrubblynuggets
woeful current
@humble mortar will be eaten alive
simple groveBOT
vernal lintel
what
humble mortar
the pkgbuilds use corepack pnpm and that postInstall script somehow escapes and tries to use system
vernal lintel
you love
humble mortar
NO
revert that commit rn
its bad and stupid and bad
@wet cove will merge arrpc/130
humble mortar
revert that commit rn
@vernal lintel pretty pleasee
woeful current
<@343383572805058560> pretty pleasee
commit pin vesktop
or replace package.json on fly
humble mortar
ok but the more sane change is in a PR coming soon β’οΈ
its horrible too youre just slightly updating the thingy with no updates after its compiled
scenic hollow
@floral ledge @humble mortar i've made a bunch of changes for preregistering keybinds on globalkeybinds do yall have any comments so far 
humble mortar
<@124411800681709570> <@721853658941227088> i've made a bunch of changes for pre...
?remindme 30h take a look
small lionBOT
Alright @humble mortar, in 1 day and 6 hours: take a look
floral ledge
https://github.com/flatpak/xdg-desktop-portal/pull/1521
https://github.com/bilelmoussaoui/ashpd/pull/257
@scenic hollow
the xdg pr got merged
finally.. app id scourge eliminated
simple groveBOT
Discord Account
No response
Operating System
Arch linux and fedora 41
Linux Only ~ Desktop Environment
gnome on wayland
Package Type
binary rpm, aur, flatpak and source.
What happens when the bug or crash occurs?
watchers get green screen or black screen.
What is the expected behaviour?
work fine for who watch my stream
How do you recreate this bug or crash?
op...
simple groveBOT
small lionBOT
@humble mortar, <t:1737996360:R>: take a look
next sundial
could Vesktop benefit from those new changes in the official app?
?remindme 72h could it?
small lionBOT
Alright @next sundial, in 3 days: could it?
humble mortar
https://www.rxddit.com/r/linux_gaming/comments/1iclq1q/i_heard_discord_fixed_scr...
this is just because some desktops feed the keys to the apps as inputs
its still same old insane x11 keybinds
next sundial
it seems chromium added support for the wayland global keybinds protocol
not in electron yet, however
humble mortar
https://www.rxddit.com/r/linux_gaming/comments/1ic4a4z/discord_for_linux_gets_na...
we might be able to make use of this and stop relying on a patch
humble mortar
we might be able to make use of this and stop relying on a patch
audio is only pulseaudio though so venmic is still needed
next sundial
we might be able to make use of this and stop relying on a patch
I believe their solution is proprietary
humble mortar
it seems chromium added support for the wayland global keybinds protocol
no up down events like usual
next sundial
like in the windows app where the audio capture mechanism is proprietary
humble mortar
I believe their solution is proprietary
the css and electron requests would still work π
next sundial
no up down events like usual
wdym by that?
next sundial
the css and electron requests would still work π
but if it's proprietary we can't request since we wouldn't have it in Vesktop? π€
humble mortar
but if it's proprietary we can't request since we wouldn't have it in Vesktop? οΏ½...
discord as a whole is proprietary but vencord still works
patch the js and css
next sundial
discord as a whole is proprietary but vencord still works
yes, but
if the code that makes wayland sharing work is proprietary
it will introduce more difficult into the vencord developers' lives to be able to bring the feature to vesktop
I guess their solution only applies to the official discord app and is not present in the web client
which makes it harder to reverse-engineer
oblique egret
https://issues.chromium.org/issues/40759171
so the web version of discord can use wayland since it just runs in chrome[ium], but desktop version cant?
peak.
ah nvm ic
next sundial
so the web version of discord can use wayland since it just runs in chrome[ium],...
IDK exactly what are those keybinds (I believe it's from the X11 era still), but if it works on Chromium it's just a matter of time until it works on the desktop app (Electron would just need to update Chromium for that)
I believe Vesktop will adopt Wayland keybindings ASAP
oblique egret
from experience, electron isnt so much 1:1 chromium as people would like it to be
next sundial
I think many of the problems from Electron are due to the Chromium sandbox, so the fault is on Chromium maybe
vernal lintel
huh why didn't it update
carmine drum
simple groveBOT
humble mortar
chatgpt code
next sundial
https://github.com/flathub/dev.vencord.Vesktop/blob/master/dev.vencord.Vesktop.yml#L24-L26 can those perms be made read-only?
vernal lintel
maybe, maybe not. does it matter?
test it and see :P I doubt those perms allow you to overwrite files of those things
probably not cause those are special perms
writing might be required to create config files and similar
next sundial
maybe, maybe not. does it matter?
flatpak users normally prefer isolation whenever possible
next sundial
test it and see :P I doubt those perms allow you to overwrite files of those thi...
I use the RPM package, so that isn't relevant for me specifically
but I remember seeing those same perms with read-only in other apps IIRC
next sundial
https://github.com/flathub/org.chromium.Chromium/issues/148 @vernal lintel
is the pipewire perm. used for screensharing?
if so, may be the same cause of that chromium issue and can also be removed
another similar issue: https://github.com/flathub/org.signal.Signal/issues/261
vernal lintel
no
simple groveBOT
humble mortar
literally ai π π
woeful current
just say this is ai slop π
fallow quail
https://github.com/flathub/dev.vencord.Vesktop/pull/43 nobody has noticed this
humble mortar
@vernal lintel are you going to revert the update arrpc detectable post install script commit
vernal lintel
no?
vernal lintel
why?
humble mortar
its a pretty bad solution to the problem & if its left i have to patch it for the pkgbuilds
vernal lintel
how is it bad solution and no you dont
humble mortar
it only updates the detectable at build time so its pushing the issue farther away unless youre rebuilding constantly & i do need to patch the pkgbuilds because they use corepack pnpm so the build will fail if they dont have system pnpm
humble mortar
using system pnpm adds an extra dep :p
vernal lintel
makedependency
building electron app takes like 500mb of shit, the few mb of pnpm won't hurt
humble mortar
still needs to be downloaded and installed then the user will have to remove it after which leaves files behind
vernal lintel
still needs to be downloaded and installed then the user will have to remove it ...
no
makedependency
humble mortar
makedeps still download and install
humble mortar
also corepack pnpm literally downloads pnpm
into the temp thingy
not to the system
either way the pkgbuilds arent the main issue
humble mortar
im not attached to corepack!!! im just saying the post install thingy is a bandaid that isnt a very good solution
vernal lintel
better than nothing
humble mortar
you coulddd do the runtime updating pr
worn harness
youre creating a problem that isnt real
nop
pnpm had issues which is why i switched to corepack
humble mortar
zootie spatootie
worn harness
@humble mortar hiii
ERR_PNPM_BAD_PM_VERSIONβ This project is configured to use v9.1.0 of
pnpm. Your current pnpm is v9.1.1
this
vernal lintel
> ERR_PNPM_BAD_PM_VERSIONβ This project is configured to use v9.1.0 of
> pnpm. Y...
just disable
pnpm install --config.package-manager-strict=false
humble mortar
im going to lose my mind
simple groveBOT
next sundial
@oblique egret some good news https://www.phoronix.com/news/Chromium-CEF-Wayland-Progress
IDK if this has any impact on Electron, but I hope it does
simple groveBOT
humble mortar
<@252390917665718273> some good news https://www.phoronix.com/news/Chromium-CEF-...
CEF is entirely its own thing
it does mean that steam and spotify might work properly under pure wayland though
hot juniper
it does mean that steam and spotify might work properly under pure wayland thoug...
i hope that one day we will get 64 bit steam client
cyan flame
@humble mortar amazing photo
small lionBOT
@next sundial, <t:1738156505:R>: could it?
sudden trout
π
simple groveBOT
vernal lintel
mean π
humble mortar
mean π
theres like 5 different stopgap shortcut implementation prs ππ despite the #326 existing
those other ones should be closed too π£οΈ
vernal lintel
i will just let them brawl it out
whoever wins has their PR win
and the others are closed
humble mortar
speaking of
@scenic hollow I think the CLI stuff should function similarly to XDP. all options are available from the get go
i actually had a local branch that made that change but I think I nuked it silly
hot juniper
i would rather see dbus support than rpc
humble mortar
id kms before Vesktop reimplemented discord RPC but worse and linux only
hot juniper
id kms before Vesktop reimplemented discord RPC but worse and linux only
discord rpc is already shit
humble mortar
dbus is a horror show
hot juniper
i never said it wasnt
humble mortar
discord rpc is already shit
ok why would vesktop do it again but worse π
insane
hot juniper
i dont think websockets are sane
yes it might be better for stock client compatibility
but at that point just make dbus plugin for vencord
vencord needs dbus itself so bad
so many good ideas could come from having a sane dbus api in vencord
humble mortar
youre delulu
comment and tell the guy to implement it as a userplugin TROLLEDCRAZY
hot juniper
userplugin
the functionality that is supported by userplugins is absolutely lacking for something like this
that uses node native bindings
implementing that as a userplugin would probably involve something insane like including it as a file import and writing it as a temp file at runtime
trust me d-bus is more sane for something like shell widgets
even though d-bus is horror
hot juniper
trol
vernal lintel
vernal lintel
this change is so weird https://github.com/Vencord/Vesktop/pull/1068
it says that "we can setup a virtual cable"
but it doesn't do that anywhere
it just queries devices with pwsh
and randomly changes lint for some reason 
simple groveBOT
vernal lintel
@humble mortar this is what I was talking about
u can change ur PR to that
main: ```js
const languages = await sendRendererCommand(IpcCommands.GET_LANGUAGES);
renderer: ```js
onIpcCommand(IpcCommands.GET_LANGUAGES, () => navigator.languages);
this is what we call AI slop
humble mortar
u can change ur PR to that
will do
humble mortar
Oh that obs streamer mode pr I have
i just realized a much less insane way to do it
vernal lintel
main: ```js
const languages = await sendRendererCommand(IpcCommands.GET_LANGUAGE...
(and if you need to send data, you can)
sour muralBOT
https://github.com/Vencord/Vesktop/blob/main/src/main/arrpc.ts#L27
https://githu...
arrpc.ts: Line 27
await sendRendererCommand(IpcCommands.RPC_INVITE, invite).then(callback);
arrpc.ts: Lines 26-40
onIpcCommand(IpcCommands.RPC_INVITE, async code => {
const { invite } = await InviteActions.resolveInvite(code, "Desktop Modal");
if (!invite) return false;
VesktopNative.win.focus();
FluxDispatcher.dispatch({
type: "INVITE_MODAL_OPEN",
invite,
code,
context: "APP"
});
return true;
});
i think that already technically works?? (at least when there is xdp... which kinda makes it useless) i think it's just missing a proper ui for it to show all the ids you can call
woeful current
and randomly changes lint for some reason <:frcoal:1276702945366376458>
just look at the commenting that's ai slop π
simple groveBOT
Discord Account
No response
Operating System
Fedora Linux Asahi Remix 41
Linux Only ~ Desktop Environment
GNOME
Package Type
Flatpak
What happens when the bug or crash occurs?
Showing "Loading chunk 70329 failed (error: https://discord.com/assets/e52c0831051121e0.js)" even when quitting and reopening the app. Not sure if there is a better way to reload the app.
What i...
humble mortar
guys rewrite your app in an different framework guyysss
can we get tauri vesktop rewrite
cyan flame
can we get tauri vesktop rewrite
hop on Dorian
humble mortar
why the hell is the lint doing this
humble mortar
π
IT KEEPS PUTTING IMPORTS ABOVEE THEN ADDING A NEW HEADER
also
vesktop is horribly laggy
like
normally you can hold a key and see each letter appear in the text box
now its in chunks and horrible
latest dev vencor
humble mortar
IT KEEPS PUTTING IMPORTS ABOVEE THEN ADDING A NEW HEADER
theres a fucked up rule doing this
what the hell
vernal lintel
vesktop is horribly laggy
disable your themes / css
and make sure you have https://github.com/Vencord/Vesktop/commit/00fb658355fd0c87d19e379bc432a78e8c698861
sudden trout
I'm on the latest git commit for vesktop and it's fine for me even with my pile of scuffed css and themes
humble mortar
??? i had quickcss toggled off but it was still importing
insane
toggle state was desynced??
sudden trout
??? i had quickcss toggled off but it was still importing
did that fix it tho
sudden trout
insane
humble mortar
theres a fucked up rule doing this
ok back to figuring out why this is happening
vernal lintel
hide nitro upselling is cooked
discord cooked up some insanity that makes it lag like crazy if your css isn't 100% optimised
had to optimise a lot of Vencord's and Vesktop's css
humble mortar
how do they even accomplish that π
anti theme tactics fr
if i have the IPCCommands import above the let server it freaks out and fucks up the prettier
??
WHAT IS HAPPENING
humble mortar
I HAVEE
vernal lintel
if i have the IPCCommands import above the let server it freaks out and fucks up...
you will save file without formatting
and push
humble mortar
WHO INSTALLED THIS MALWARE
humble mortar
oops
sorriee
can NavigationRouter.transitionTo fail
all checks passed tyuppeee
vernal lintel
so how do i test ur pr
humble mortar
so how do i test ur pr
copy any link to a message, channel or server then paste in your browser. make sure to have arrpc enabled and be signed out of discord in the browser
humble mortar
how do you list the available functions
vernal lintel
look in console
vernal lintel
copy any link to a message, channel or server then paste in your browser. make s...
i didnt even know this was a thing
fire it works
humble mortar
look in console
yea but at what
vernal lintel
NavigationRouter
well it's a proxy but
either {...NavigationRouter} or look at [[Target]].[vencord.lazy.cached]
that module has way more functions too
but Vencord only exports these
humble mortar
buh it says its undefined
vernal lintel
fwiw
[Z.Etm.DEEP_LINK]: {
scope: S.cE,
handler(e) {
let {args: {type: t, params: n}} = e;
switch (N.ZP.focus(),
t) {
case S.jE.USER_SETTINGS:
null != n && ((0,
g.dL)(Z.Z5c.SETTINGS(n.section, n.subsection)),
x(n.fingerprint, "settings"));
break;
case S.jE.CHANGELOG:
null != n && ((0,
g.dL)(v.Z.formatPathWithQuery(Z.Z5c.CHANGELOGS(n.date), n.query)),
x(n.fingerprint, "changelog"));
break;
case S.jE.LIBRARY:
(0,
g.dL)(Z.Z5c.APPLICATION_LIBRARY),
null != n && x(n.fingerprint, "library");
break;
case S.jE.STORE_HOME:
(0,
g.dL)(Z.Z5c.APPLICATION_STORE),
null != n && x(n.fingerprint, "store");
break;
case S.jE.STORE_LISTING:
null != n && ((0,
g.dL)(Z.Z5c.APPLICATION_STORE_LISTING_SKU(n.skuId, n.slug)),
x(n.fingerprint, "store"));
break;
case S.jE.PICK_GUILD_SETTINGS:
null != n && ((0,
g.dL)({
pathname: Z.Z5c.PICK_GUILD_SETTINGS(n.section, n.subsection),
search: n.search
}),
x(n.fingerprint, "guild_settings"));
break;
case S.jE.CHANNEL:
null != n && ((0,
g.dL)({
pathname: Z.Z5c.CHANNEL(n.guildId, n.channelId, n.messageId),
search: n.search
}),
x(n.fingerprint, "channel"));
break;
case S.jE.QUEST_HOME:
null != n ? ((0,
g.dL)({
pathname: Z.Z5c.QUEST_HOME,
hash: n.questId
}),
x(n.fingerprint, "quest_home")) : (0,
g.dL)(Z.Z5c.QUEST_HOME);
break;
case S.jE.DISCOVERY_GAME_RESULTS:
null != n && ((0,
g.dL)({
pathname: Z.Z5c.GLOBAL_DISCOVERY_SERVERS,
search: "?game=".concat(n.gameId)
}),
x(n.fingerprint, "discovery_game"));
break;
case S.jE.OAUTH2:
let i = new URL(Z.Z5c.OAUTH2_AUTHORIZE,window.location.origin);
i.search = n.search;
let l = (0,
p.getOAuth2AuthorizeProps)(i.toString());
if (null != l)
return (0,
p.openOAuth2ModalWithCreateGuildModal)(l),
!0;
return !1
}
}
},
you should just call this handler
const { DeepLink } = findLazy(m => m.DEEP_LINK?.handler);
DeepLink.handler({ args: data });
vernal lintel
but i'm pretty sure this is DiscordNative
so it will error on vesktop
yes it is
you either have to patch this function to remove the desktop only call(s) or rewrite it
humble mortar
or just patch that native focus thing
vernal lintel
no
you can't
you have to patch that function and replace it with VesktopNative.win.focus or remove it
humble mortar
mh
humble mortar
@vernal lintel since https://github.com/OpenAsar/arrpc/pull/106 this can be removed btw
vernal lintel
<@343383572805058560> since https://github.com/OpenAsar/arrpc/pull/106 this can ...
TURN OFF THAT RAINBOW INDENT
humble mortar
NO
vernal lintel
```js
[Z.Etm.DEEP_LINK]: {
scope: S.cE,
handler(...
any luck making this work
or do u want help
vernal lintel
humble mortar
```js
const { DeepLink } = findLazy(m => m.DEEP_LINK?.handler);
DeepLink.handle...
hoiw does this work findByProps takes a strign
humble mortar
ok so
findLazy wasnt working
but if i findAll i can destructure to the right function and call it and it works
humble mortar
nothing from Lazy
vernal lintel
the lazy is correct bestie..
vernal lintel
```js
const { DeepLink } = findLazy(m => m.DEEP_LINK?.handler);
DeepLink.handle...
this
humble mortar
that gives proxyLazy called on a primitive value
vernal lintel
show code and error
vernal lintel
```js
const { DeepLink } = findLazy(m => m.DEEP_LINK?.handler);
DeepLink.handle...
this will work
vernal lintel
humble mortar
is that a youre dumb stare or a what thje hell stare
vernal lintel
is that a youre dumb stare or a what thje hell stare
we're both stupid
me for giving you wrong code, you for not noticing the error
humble mortar
IDK HOW FINDLAZY WORKS
vernal lintel
- const { DeepLink } = findLazy(m => m.DEEP_LINK?.handler);
+ const { DEEP_LINK } = findLazy(m => m.DEEP_LINK?.handler);
- DeepLink.handler({ args: data });
+ DEEP_LINK.handler({ args: data });
ok i literally tried that and got the same result
vernal lintel
ofc it works π
humble mortar
i am so sure i tried that
vernal lintel
IDK HOW FINDLAZY WORKS
the exact same
humble mortar
i am so sure i tried that
like 20000%
vernal lintel
there is no difference between find and findLazy other than that findLazy is .... lazy
under the hood there is a big difference but you don't need to know that
normal = finds immediately, won't work because top level code runs way too early (before discord code is available)
lazy = finds on first use
humble mortar
gah
humble mortar
"you fucked up your shit"
vernal lintel
Property 'DeepLink' is undefined. You probably tried to access a property that simply doesn't exist
better error
humble mortar
youre no fun
vernal lintel
nothing from Lazy
they're the same thing
just ignore that it says proxy
the proxy looks confusing tho yeah
humble mortar
where in the proxy structure does the actual matched thingy live
humble mortar
ohhHHH
vernal lintel
humble mortar
oki doki pushed
vernal lintel
js Proxy allows you to intercept all object accesses. we have a handler ("trap") for get that gets called whenever you access a property on the proxy.
then it checks if the cache (Symbol(vencord.lazy.cached)) is populated already. If not, it calls Symbol(vencord.lazy.get) which is the function you pass to the lazy (with findLazy, this is just find()) and stores it in cache. then it redirects your property access to that object instead
it's just syntax sugar for something like this:
let DEEP_LINK;
function getDEEP_LINK() {
if (!DEEP_LINK) {
DEEP_LINK = find(m => m.DEEP_LINK?.handler).DEEP_LINK;
}
return DEEP_LINK;
}
getDEEP_LINK().handler();
oh i just realized now that the the arrpc stuff is split up it can be threaded easily now
the #1053 pr
humble mortar
studipid
hot juniper
TURN OFF THAT RAINBOW INDENT
i forgot that was a thing
i might go install that at some point 
real glade
under the hood there is a big difference but you don't need to know that
the code actually terrifies me
yall are evil webpack geniuses
simple groveBOT
next sundial
for me, the app crashes if I don't select any screen/window when clicking to screenshare (and instead close the KDE pop-up window). is it a known bug?
simple groveBOT
vernal lintel
for me, the app crashes if I don't select any screen/window when clicking to scr...
electron moment
try again in latest main branch
next sundial
based
humble mortar
genuinely what does this even mean
vernal lintel
we should add an option to enable this in vesktop
might come in handy
Also why do they need a crash dump for something that's so easy to reproduce
do they have 0 devs who use linux or smth
isn't electron github
oh no it isn't
it's openjs which is a lot of companies
fire
humble mortar
we should add an option to enable this in vesktop
crashdumps are just the logs zipped up nicely and timestamped
the actual data is generated anyway
i dont think ive ever had vesktop crash that was actually Vesktops fault
peak
humble mortar
Also why do they need a crash dump for something that's so easy to reproduce
they made me copy paste the docs example into a gist ππ
humble mortar
nop a real human tagged it as needing the gist
vernal lintel
real
tbh we should copy the tag > bot posts comment thing
I'm tired of explaining the same thing 2 billion times
simple groveBOT
hot juniper
I'm tired of explaining the same thing 2 billion times
https://github.com/settings/replies would this be useful
azure verge
π₯
humble mortar
veeeeeee ππ
humble mortar
i assume the patch for visual refresh is different
what the hell is this
why does web have the bar ππππ
thats insane
like genuinely
what does discord desktop do on linux then
as it does native title bar
dont tell me it just has the massive empty space
vernal lintel
what the hell is this
ZT JUMPSCARE
simple groveBOT
humble mortar
ZT JUMPSCARE
he haunts me
hot juniper
what the hell is this
discord loves their useless help button
hot juniper
ZT JUMPSCARE
humble mortar
@vernal lintel VEEE the obs pr arrpc hash doesnt have the link changes!!!
4ad8add175158b676b4936c1292775704595a4b5
change to that hash
humble mortar
see that comment
yop in the original pr comment u can see I mentioned probably doing that
vernal lintel
but discord seems to change the database very often lol
so it might be useless
anyway that header is still better than hardcoding 24h
we can just always send the request using that header and if it hasn't changed, it will only transfer a few hundred bytes
humble mortar
so it might be useless
yeah thats why I didnt bother in the og thingy
truee
i will do next time I'm on my laptop
humble mortar
4ad8add175158b676b4936c1292775704595a4b5
also since you merged the obs pr vesktop is off main arrpc branch
vernal lintel
oh my god what is it doing
this is the most annoying gnome bug
when you alt tab, sometimes it spams two billion tab inputs to the now focused app
it makes discord lag so hard
humble mortar
lmao???
humble mortar
are you holding tab or something
simple groveBOT
vernal lintel
are you holding tab or something
nah like normal alt tab
humble mortar
VEEE THAT HASH DOESNT HAVE THE NEEDED CHANGE FOR OBS DETECTION ON LINUX
i gave you the right one guuhhhggg
vernal lintel
bestie it's latest main branch 
humble mortar
bestie the needed change is pr 129 not merged into arrpc yet
vernal lintel
force ducko to merge rn (right now)
simple groveBOT
humble mortar
force ducko to merge rn (right now)
@wet cove honk
humble mortar
realistically Electron should be doing this shit themselves
I'd pr it to them but I'm scared of the codebase
love
vernal lintel
electron should expose a raw dbus method
oblique egret
I'd pr it to them but I'm scared of the codebase
problem with electron, is that the tiniest change takes half a year to merge
i've been merging a simple docs improvement for over 2 months now
vernal lintel
VEEE THAT HASH DOESNT HAVE THE NEEDED CHANGE FOR OBS DETECTION ON LINUX
without the change, OBS detection just doesn't work right?
humble mortar
obs spawns itself with the path as just 'obs' so arrpc falsely filters that out resulting in no detection
bwrapped processes also spawn themselves like that so theres other cases for that patch
hot juniper
electron should expose a raw dbus method
simple groveBOT
vernal lintel
my grandma always said: If the description includes "Enhance" it's probably AI
nvm we found the one person who actually says enhance
vernal lintel
horror commit message
humble mortar
kys
will github ban me for saying kys in discussions
@vernal lintel review https://github.com/Vencord/Vesktop/pull/813
oh wrong one
there
vernal lintel
reviewing https://github.com/Vencord/Vesktop/pull/820 rn
humble mortar
i can't tell if thats genuine or a joke cause I accidentally linked that πππ
hot juniper
will github ban me for saying kys in discussions
idk
vernal lintel
@humble mortar can you apply either what ducko proposed or what you proposed to ur PR
this
vernal lintel
actually i canj ust make those changes
vernal lintel
cookie is gonna kill me once she realises this release doesn't include OBS auto streamer mode support
@humble mortar can u update the PKGBUILD .desktop files to add discord scheme whenever u have time please
humble mortar
yuob
vernal lintel
instant reply scary
humble mortar
did u remember for the flatpaj
vernal lintel
vernal lintel
did u remember for the flatpaj
it extracts from AppImage
humble mortar
instant reply scary
i just stopped tombwaider
humble mortar
it extracts from AppImage
nop it overrides the exec entry
vernal lintel
ohhh
humble mortar
i told u in the github comments ππ
vernal lintel
true
humble mortar
guhb
humble mortar
i told u in the github comments ππ
i told u in the github comments ππ
i told u in the github comments ππ
vernal lintel
vban spam
silk elk
humble mortar
cookie is gonna kill me once she realises this release doesn't include OBS auto ...
people are gonna cry and open issues since the commit and with the patch is real
or did u revert
vernal lintel
nah the commit is still there just targetting arrpc main
we'll add it next release there's no rush
humble mortar
no I mean the patch that enables the toggle in the client
humble mortar
yopyop
vernal lintel
yopyop
there is that right https://github.com/flathub/dev.vencord.Vesktop/pull/46
we will have to wait 3 billion years for flathub bot to build
humble mortar
there is that right https://github.com/flathub/dev.vencord.Vesktop/pull/46
yuupp
vernal lintel
now that we have autoupdater so it doesn't show the updater view anymore we need some way to view vesktop changelogs in app
maybe we should just open an inapp changelog on first launch
humble mortar
make the about page not ass first
vernal lintel
why
humble mortar
it needs a shiggy
humble mortar
its vesktoping time
vernal lintel
either that or you only tested with splash theming disabled
humble mortar
i have no memory of that commit im so real
vernal lintel
cause splash theming was broken and stored oklab instead of rgb
humble mortar
LOVEEE
vernal lintel
which electron doesn't support as backgroundColor
so instead of your theme colour it was just a flashbang
humble mortar
ohh i bet that was a change in recent electron
it def worked b4
or your theme does oklab
or something
vernal lintel
fixed it with this atrocity https://github.com/Vencord/Vesktop/blob/main/src/renderer/themedSplash.ts#L17-L37
sour muralBOT
fixed it with this atrocity https://github.com/Vencord/Vesktop/blob/main/src/ren...
themedSplash.ts: Lines 17-37
const linearToGamma = (c: number) => (c >= 0.0031308 ? 1.055 * Math.pow(c, 1 / 2.4) - 0.055 : 12.92 * c);
function oklabToSRGB({ L, a, b }: { L: number; a: number; b: number }) {
let l = L + a * +0.3963377774 + b * +0.2158037573;
let m = L + a * -0.1055613458 + b * -0.0638541728;
let s = L + a * -0.0894841775 + b * -1.291485548;
l **= 3;
m **= 3;
s **= 3;
let R = l * +4.0767416621 + m * -3.3077115913 + s * +0.2309699292;
let G = l * -1.2684380046 + m * +2.6097574011 + s * -0.3413193965;
let B = l * -0.0041960863 + m * -0.7034186147 + s * +1.707614701;
R = 255 * linearToGamma(R);
G = 255 * linearToGamma(G);
B = 255 * linearToGamma(B);
R = Math.round(clamp(R, 0, 255));
G = Math.round(clamp(G, 0, 255));
B = Math.round(clamp(B, 0, 255));
return `rgb(${R}, ${G}, ${B})`;
}
does electron not have built in colour shit π
vernal lintel
or your theme does oklab
no discord changed from hsl (rgb colourspace) to oklab colourspace
but this is already a good while ago
vernal lintel
does electron not have built in colour shit π
chromium would have it if anything and no it doesn't
humble mortar
crazy
vernal lintel
you can't really convert between the colourspaces with 100% accuracy I think
vernal lintel
**themedSplash.ts:** Lines 17-37
```ts
const linearToGamma = (c: number) => (c >...
anyway we had to make this change anyway because the splash needs rgb
humble mortar
oh would it break if the theme set the var as oklab
vernal lintel
wtf is an /a\ \ \ \ \ \ \ \
humble mortar
@vernal lintel before i eep whats happening with #865
humble mortar
wtf is an `/a\ \ \ \ \ \ \ \ `
spacing (not needed at all i just felt like it)
vernal lintel
humble mortar
failure
vernal lintel
ohhh
idk tbh
some people might not like it and instead want the vencord icon
is it somehow possible to give the user the choice between a few icons
while also having it apply to their shortcuts and stuff
how is there no good solution to this
humble mortar
people who care about the icon will have found the issue
could also post a non pinging announcement maybe
vernal lintel
we should probably allow the user to choose between a few preset icons and also their own icon
it wouldn't apply to the shortcut and stuff but at runtime
good enoughish
anyway not rn
humble mortar
we should probably allow the user to choose between a few preset icons and also ...
this is genuinely horrifying
vernal lintel
why
vernal lintel
acting like it would let them choose between 3 million icons
humble mortar
such a feature also wont be possible on wayland
vernal lintel
just vc logo
vc logo faggy version
yours
and then they can upload a custom icon (so they can use the normal discord icon)
I would add the discord icon natively but we can't cause of copyright / trademark
humble mortar
also it not matching the launcher shortcut is even more horrifying
humble mortar
they can do that right now π
vernal lintel
I think if we want to change it for everyone it should be more neutral and not something a lot of people wouldn't like aka no anime
humble mortar
vennie isnt anime π
vernal lintel
maybe
humble mortar
ill whip something up tmrw
vernal lintel
or come up with something completely new, like armcord
vernal lintel
I think if we want to change it for everyone it should be more neutral and not s...
but yeah this is not a small amount of people
humble mortar
or come up with something completely new, like armcord
ARMCORD IS DEAD!!
vernal lintel
sorry legcord
vernal lintel
ill whip something up tmrw
sure if u feel like it
vernal lintel
being dynamic is horror
it's fine honestly lol
humble mortar
its not π π
vernal lintel
you can still have identity while allowing the user to choose between a few variations
why
humble mortar
i dont know a single desktop app that has dynamic icons
purely because its not feasable cleanly
vernal lintel
btw instead of sedding you should really just consider adding pnpm as a makedependency and disabling the exact version match error #πΎ-core-development message
bright rivet
cookie, your sed regex didn't worked, this one does:
sed -i 's/"postinstall": "pnpm updateArrpcDB"/"postinstall": "corepack pnpm updateArrpcDB"/' package.json
vernal lintel
its more robust
vernal lintel
https://wayland.app/protocols/xdg-toplevel-icon-v1
cool
bribe someone at xdg so they accept it rn
humble mortar
cookie, your sed regex didn't worked, this one does:
`sed -i 's/"postinstall": ...
it was LITERALLY working
i dont understand
its the exact same sed format as the afterPack
bright rivet
bright rivet
bash vs ... ?
humble mortar
im using bash
bright rivet
idk, but I tried the command directly and didn't worked too
Mmm
ββββΌ $ wget https://raw.githubusercontent.com/Vencord/Vesktop/refs/heads/main/package.json
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 6197 100 6197 0 0 49841 0 --:--:-- --:--:-- --:--:-- 49975
ββ[ Behemoth /tmp/tmp.Cv6CEEZLFt ]
ββββΌ $ grep -i updateArrpcDB package.json
"updateArrpcDB": "node ./node_modules/arrpc/update_db.js",
"postinstall": "pnpm updateArrpcDB"
ββ[ Behemoth /tmp/tmp.Cv6CEEZLFt ]
ββββΌ $ sed -i '/"postinstall": "pnpm updateArrpcDB",/a\ \ \ \ \ \ \ \ "postinstall": "corepack pnpm updateArrpcDB"' package.json
ββ[ Behemoth /tmp/tmp.Cv6CEEZLFt ]
ββββΌ $ grep -i updateArrpcDB package.json
"updateArrpcDB": "node ./node_modules/arrpc/update_db.js",
"postinstall": "pnpm updateArrpcDB"
sends coffee to cookie
bright rivet
It's 1am here too lol, but I sleep 1.5h between 22:00 and 23:30 :p
humble mortar
???
bright rivet
Thx
humble mortar
my glorp shitto life
bright rivet
???
I mean, not intentionally, so now I'm not sleepy at all
I still go to sleep at 3/4 am every day tho
Doing things on night is cool
vernal lintel
guh the flatpak repo doesn't update metainfo hash automatically for some reason
so annoying
need to fix but idk how flathub updater config works
it works fine for the binaries but not the metainfo file
maybe we need to put it into github releases
next sundial
not sure if I'm going crazy but I noticed a slower start-up time right after upgrading to 1.5.5
seems the application is "heavier" to start now
next sundial
scrolling also feels very snappy now
simple groveBOT
next sundial
has anyone else also noticed start-up being slower and scrolling feeling snappier after the upgrade to 1.5.5?
btw
discord is showing the button to download the app on vesktop
duh
could you guys patch it, please?
vernal lintel
why do people care so much about this button π
vesktop used to hide it with css but I removed the css cause it caused lag
humble mortar
what the hell does this even mean
humble mortar
where is this button
humble mortar
hide it yourself in quickcss π
next sundial
~~what the hell does this even mean~~
when you are going to screenshare there's an "Open Audio Settings"
I'm asking if the settings changed there are saved between screenshare sessions
humble mortar
oh I replied to the wrong one
next sundial
hide it yourself in quickcss π
yes, I know how to do that; however, I think this has started to appear for everyone else, so that's why I'm suggesting it as a global patch
humble mortar
what the hell does this even mean
next sundial
what the hell does this even mean
I think he means to create an API to update Vencord/Vesktop
but IDK how would that be useful
next sundial
package manager does not exist
only exists for Nix
everything else is auto-updater
next sundial
vesktop is not packaged in distros' repos
humble mortar
uhh
next sundial
at least not officially
next sundial
vee said he doesn't care enough to package via standard means
so he just threw the auto-updater and said it's going to be fine
and, yeah, it works
next sundial
fedora copr
all unofficial
