#👾-core-development

1 messages · Page 239 of 1

left sequoia
#

dam

limber skiff
#

was supposed to be set here

image.png
#

but I suppose it fails somewhere?

left sequoia
#

yeah

#

exactly what i said lol

#

.

#

yeah

#

enumarateDevices has cases where it doesnt return devide ids

#

I remember looking at this in chromium's source code ages ago

#

dont remember what it was tho

#

some security shit

#

yeah

#

it was if you didnt query the permissions for it beforehand

odd heath
#

How does it only sometimes error on discord Desktop tho

#

Like huh

left sequoia
# 
(await   navigator.mediaDevices
    .enumerateDevices()
).map(e=>e.deviceId) // ['','','']
await navigator.permissions.query({name: 'microphone'})
await navigator.permissions.query({name: 'camera'})
(await   navigator.mediaDevices
    .enumerateDevices()
).map(e=>e.deviceId) // [     "default",     "communications",     "7b5d0522561559205b1f5209fe36202863424ee97cedd50c5ef18eb90c2f8228",     "b242f697341faf734d170f436e2d6b8ceb9cfe35802dc449fa1d7df3f395b1dc",     "39366bf071e8587ed9a8131bfe181a1f9438b08910bfc8cabac960734e217562",     "",]
#

that said, default is an accepted value for a media sink

#

so its likely erroring when its NOT default

#

since it has a list of stale IDs

#

since its possible those media device IDs change

#

thank you for coming to my ted talk.

odd heath
#

Yea that makes more sense

limber skiff
fossil inlet
#

I remember looking into this a while ago for volume booster and it not being a vencord issue

left sequoia
#

so its either a stale ID

#

or no permissions

#

since '' == null // false

#

and they check against null

#

deviceId is NEVER null, its only an empty string

#

no permissions = ''

#

this could be a vencord issue if vencord doesnt disable the permissions api

#

XD

charred monolithBOT
limber skiff
#

@granite sky ugh, they are a bit unaligned

image.png
#

apply bottom again

#

WEBHOOK needs to go just a tiny little up

granite sky
#

Bottom with or without unsetting margin top?

limber skiff
#

actually

granite sky
#

I'm going to be home like in 20 minutes

limber skiff
#

do you mind if I do it?

granite sky
limber skiff
#

alright

granite sky
#

Less work for me

limber skiff
#

I think this is good?

image.png
granite sky
#

We should check it by drawing a 1px wide red line in paint

limber skiff
#

that was the best I could do tho

#

0.01em

#

try doing 0.005 and it just moved a lot below

#

probably some limitation of such small values

left sequoia
#

simply

# 
* {
    outline: 1px solid red;
}
#

best CSS debugging tool ever made

#

XD

granite sky
limber skiff
#

they dont work

#

discord aligns everything in that span manually

#

sometimes with margin, other times with top

left sequoia
limber skiff
#

so to avoid doing that for vencord plugins I wrapped decorators in a div

left sequoia
#

no fucking way

limber skiff
#

which aligns automatically, and then has flex with center align and justify

#

however, when we add a tag it isnt matching how the normal discord tags are aligned

#

likely because the actual div we wrap isn't aligned perfectly in the center, it looks worse when we do

left sequoia
#

it... doesnmt seem like it?

image.png
limber skiff
#

wdym?

left sequoia
#

it doesnt seem manually aligned

limber skiff
#

look into the css of the tags

#

it has margin-top

left sequoia
#

yeah

#

which is static

#

it doesnt use JS to modify the margin top

limber skiff
#

I know

#

but what I mean is that the wrapper of all of that is not a flex component

#

with align center

#

which means you have to manually add margin or top to align your items

#

it is stupid

#

so I did this

left sequoia
#

welp, i seem to be too stupid to see the issue here, since adding the tag repeatedly just works flawlessly for me

#

oh well

limber skiff
#

which already adds the top to align

#

so using the same discord classes as normal tags would just add more margin

#

and thus make it unaligned

granite sky
limber skiff
#

It's mainly just an issue with tags as they have to match discord ones

granite sky
#

it would still require some fixing on discords components like with tags, but any other thing should be aligned perfectly

left sequoia
#

aaaah

granite sky
#

or i'm thinking wrong

left sequoia
#

its the vencords decoration tags api utility thats dogshit and has this issue

#

not discord's styling

#

ic

limber skiff
#

our wrapper isn't aligned perfectly

#

because as I said it looks worse

limber skiff
#

It's saving you from having to add margin-left and top to every single decoration you add

granite sky
limber skiff
#

oh it's perfectly now lol

#

@left sequoia before you say it's dogshit, realize discord shit isn't even aligned in the center

image.png
#

everything is a bit different, thus making a single solution way harder

left sequoia
#

alignment, and visual alignment are different things sir, but i understand your point

limber skiff
#

I made the API have a vertical alignment which is perfect for most plugins, but since more user tags has to match the shit alignment discord does, you gotta move it a bit

#

yes I know

#

I pushed @granite sky

granite sky
#

@limber skiff I might just replace the discord tag with our own

No issues with centering, no patch will be required, one find less ( might add other ones to steal some classnames )

#

Or we'll just stick with the current one?

limber skiff
#

that might be smarter, yes

#

actually, no

granite sky
#

Bipolar

limber skiff
#

you can make it use our own, but you still need to add the classes discord uses

#

and thus have the same issues (but instead not require a patch)

#

without the classes themes wouldn't work very nicely

granite sky
#

It seems like only margin-top should be changed then

#

Like

#

There is one class that adds top padding, we can just ignore it

limber skiff
#

I think it's fine now

#

it's aligned perfectly

grave mangoBOT
granite sky
#

I'll check it on my system if it works the same

limber skiff
#

alright

granite sky
#

After i eat

limber skiff
#

I'm thinking of a priority option for both decorators API

#

0 = default, positive = comes before other plugins, negative = comes before Discord own components

#

more negative = comes before Discord own components and before other plugins

#

does that look good?

granite sky
#

Ah, cloud sync corrupted my settings somehow

#

it seems to be the case at least

#

one moment

#

@limber skiff also, what should we do with this options? We are not modifying old tags, so it does nothing
Should i try to recreate it or just drop support?

image.png
granite sky
#

Devtools are telling me that are both the same height

jagged reef
#

Somebody PR that out

granite sky
#

Also, small notice, there is no decoration in replies

image.png
granite sky
limber skiff
granite sky
shut vineBOT
#

Alright @granite sky, in 17 hours, 10 minutes and 23 seconds: …

granite sky
granite sky
granite sky
#

Love mobile discord highlighting wrong message

limber skiff
#

lol

charred monolithBOT
shut vineBOT
#

@fossil inlet, <t:1738685913:R>: …

odd heath
#

...

#

… > ...

limber skiff
#

what if we switch to bun instead of pnpm?

#

it's soo fast for running scripts

fossil inlet
#

i love binary lockfiles

limber skiff
#

depending on their support for monorepos it actually seems pretty good for this type of management

#

@austere talon opinions?

left sequoia
#

also by running scripts i think you mean not doing so

#

since bun simply omits scripts it cant run

limber skiff
left sequoia
#

comparing

#

fuck i need sleep

limber skiff
#

bun is all in one so yes I'm comparing one part of it

left sequoia
#

BAD

limber skiff
#

which it simply seems to be doing better than pnpm

left sequoia
#

i assume u mean install scripts?

limber skiff
#

install packages, run scripts

left sequoia
#

then yeah, for install bun simply doesnt compile the natives, and hopes the prebuilds works

#

for run it should be pretty much no different

#

since that's just node vs bun

#

and they are effectively identical in actual js code scenarios

#

so you can do the same for pnpm by omitting specific scripts

#

👍

glass jasper
#

Didnt you get ban once for saying you compiled vencord with bun? @dusk blaze

left sequoia
#

i personally heavily dislike bun too

#

mainly because of their dogshit promises and awful advertising

#

in raw js, bun is worse than anything out there

#

but it tries to get ahead by implementing native libraries for everything, then going "hurr durrr, look our native library is 10% faster than node's js lib that does the same thing"

#

like yeah? no shit? now compare it to denos rusty bindings... oh yeah you wont because it will make u look bad

#

then they go "we're sooo much better than node!" but then cant actually do a lot of the shit node does, and their promises of being a node replacement fall flat because half the libs dont work

#

woooweeeeeeeeee

#

this is why i like deno, because they went "yeah, here's deno2, we did stuff, we think full nodejs support was somewhere on the list too"

#

and it just flat out works as a nodejs drop-in replacement

glass jasper
#

This guy has some very passionate opinions about bun

left sequoia
#

yeah it annoys me because they are doing agressive missleading marketing to get as much market share as possible, while not actually being a good alternative

#

just missleading people into thinking so

austere talon
#

ThaUnknown_ more like ThaYapper_

left sequoia
#

yes

#

i have strong opinions

#

"hey our on disk cache only install is x100 faster than this network based install"

austere talon
glass jasper
limber skiff
#

pnpm is good at some things but hey try to run nested scripts with it

#

500ms for every script

left sequoia
#

yes

limber skiff
#

how do they mess up that hard?

left sequoia
#

because that's the standard

#

that's what npm specified

#

and pnpm follows that

glass jasper
#

are we really complaining about ms rn?

limber skiff
#

the standard is to take time?

left sequoia
#

its bun that's weird, because it doesnt do that

limber skiff
#

and I run it all the time

fossil inlet
#

its really bad

left sequoia
#

i dont think you ever looked into those install scripts and what they do

glass jasper
left sequoia
#

they are required, because they compile native code

glass jasper
#

Shit does not take that long for me

left sequoia
#

if you dont have the code

#

and run the code

#

it doesnt run

fossil inlet
#

lol not when npm does it in a fraction of the time

left sequoia
#

npm errors on most scripts nowdays because most are outdated and use dependencies npm no longer provides

#

so npm goes "yep all good"

#

and the reason it takes 500ms, is because that's the timeout for finding vstools, which means you dont have them set up

#

to build natives

#

probably

glass jasper
#

stare this is heck of a time for me to wake up

left sequoia
#

but i agree with the skill issue part tho

image.png
#

XD

austere talon
#

should we switch from package scripts to justfile

limber skiff
austere talon
#

it doesn't really matter xd

left sequoia
#

sir you added the dependency

#

simply... dont add dogshit dependencies?

#

:?

#

okay sry, u probs werent the one adding the deps

limber skiff
left sequoia
#

are we not talkign about install scripts?

#

i might be confused on the topic then

#

anyways, my point is, bun looks better to you because its likely omitting some crucial steps, that will come out later in the washing

#

except cold boot times

#

i think thats actually better on JSC

#

v8 vm spawning takes the piss

limber skiff
#

vencord is simple 😭

#

we don't need that

glass jasper
#

you know, technically if you want the fastest speeds we should just rewrite the entirety of Vencord in Assembly

left sequoia
#

it unironically wont fix the problem

#

i think nookies is talking about the slow dev times when installing/running

#

wasm is good for runtime, not for dev

limber skiff
#

yall are just saying shit at this point

#

dont get into the discussion if you arent gonna say anything useful

glass jasper
#

Vencord in rust confirmed 2025

limber skiff
#

I notice slow time for running scripts all the time and that matters to me

#

npm is faster than pnpm for that

left sequoia
#

lord i'm confused

#

because spawning a script is 2-3ms

glass jasper
left sequoia
#

and after that its just pure node.js

#

so npm vs pnpm shouldnt have any difference

limber skiff
#

yet it does

#

they just made it badly

left sequoia
#

yeah ngl

#

that's an issue on your end

#

try nuking pnpm and reinstalling

limber skiff
#

no

#

it is not

left sequoia
#

because i have 1:1 identical start times for npm vs pnpm

#

like we're talking withing 1-2ms of "the same"

limber skiff
austere talon
#

venpm soon

limber skiff
#

but actually what's your opinion vee

#

switching to bun would be so simple

left sequoia
#

TotalMilliseconds : 868.5955 vs TotalMilliseconds : 988.8196

#

so yeah pnpm is sliiiighly slower

#

but not 1s slower

limber skiff
#

start nesting scripts

dusk blaze
#

the last time i mentioned building vencord with bun i got banned...

left sequoia
#

nodejs's "spawn"?

limber skiff
#

building reporter also feels faster with it

austere talon
left sequoia
#

150ms difference across 4 nests?

image.png
# 
{
  "scripts": {
    "nested3": "pnpm run nested2",
    "nested2": "pnpm run nested1",
    "nested1": "pnpm run start",
    "start": "node server.js"
  }
}
#

or do i need to go deeper?

#

i dont really see it

#

i mean yeah it is slower

#

but not impactibly slower

dusk blaze
#

npm does nesting decently quickly

#

bun is even faster but i definitely wouldn't use a runtime that claims "production ready" while not even having windows support and full npm package compatibility

left sequoia
#

iirc bun script runs omits package resolution

#

idk if they fixed that yet

#

cuz there's some order of global, deps and scope

#

and workspace

#

and iirc bun only does scope

#

does/did, might be living on outdated info

limber skiff
#

building tool, nothing else

left sequoia
#

there's nothing stopping you from running scripts with bun tho

#

its your local step

dusk blaze
limber skiff
#

bun + esbuild*

dusk blaze
left sequoia
#

bun cant install esbuild on windows iirc

#

:^)

#

cuz one of the deps is a native, which it doesnt build

#

and esbuild doesnt run

dusk blaze
#

honestly just make .sh scripts to run the actual build.mjs commands

left sequoia
#

oh no

#

makefile next

#

i know, lets just use rspack

dusk blaze
dusk blaze
left sequoia
#

it supports npm pnpm and bun

#

so we wont need to "support jack shit"

glass jasper
left sequoia
#

since it just works for those envs

left sequoia
glass jasper
dusk blaze
left sequoia
#

:^)

#

-3 days of free time

#

as much as i fucking hate windows with how slow it is, and how dogshit their file system is

#

it just works

#

except for network drives

#

that shit will bluescreen you every 2 minutes

#

i unironically boot up wsl just to operate on network drives

austere talon
#

I will make it faster @limber skiff

#

dw

#

not bun

limber skiff
austere talon
limber skiff
#

ehh

#

I mean pnpm is still nodejs

#

and that takes time

austere talon
#

no

limber skiff
#

the fact bun is compiled already makes it faster

austere talon
#

no

#

we're not using bun

#

you will still be able to use bun

#

bun isn't even that much faster 😭

image.png
#

just is faster than bun (or same, small variation)

image.png
#

and make is same as just

image.png
#

(ignore preedit idk what i was saying)

#

but that delay just seems to be the base runtime of build

#

even if you run the command directly it's not faster

#

try to make the build script itself faster

scenic brook
#

gradle build script when

limber skiff
austere talon
#

justfile

#

simpler makefile alternative

fossil inlet
#

@odd heath you will merge your branch husk

odd heath
#

Did I miss something

fossil inlet
#

yop

#

out of date with dev

odd heath
#

Ah

#

Fixed

limber skiff
charred monolithBOT
opaque silo
#

put in a privacy utils plugin

#

easy peasy

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
odd heath
#

Yop

charred monolithBOT
shell shuttle
#

🤬

#

whoever force pushed caused me to get a conflict error

#

wow

#

THAT WORKED

charred monolithBOT
jolly egret
#

is missing toolbox fixed on dev already or nah?

#

don't really wanna switch branch right now considering the time

#

(if its not fixed, then btw toolbox is dead)

median rapids
fossil inlet
charred monolithBOT
fossil inlet
#

guhhhh i need more ideas for features for vencord companion

shell shuttle
#

didnt work

#

😭

median rapids
shell shuttle
#

i gtg for now i gotta compile this

#

hold on

#

i may be retarded

#

severely

#

OH i see what u did

#

nvm nvm

charred monolithBOT
shell shuttle
#

i'm in a big hurry rn i'll work on it tomorrow

#

if there's more problems

fossil inlet
shell shuttle
#

@fossil inlet

#

unless there's still more

fossil inlet
#

😭

#

thats not what i was talking about

shell shuttle
#

wait wha

charred monolithBOT
shell shuttle
#

Oh

#

that

#

agony how did i miss that wtf

charred monolithBOT
charred monolithBOT
astral bone
charred monolithBOT
jagged reef
#

/merge @a

charred monolithBOT
#
ImBonana
[Vendicated/Vencord] New review comment on pull request #3191: feat(plugin): CopyStickerLinks 
    const { favoriteableId, favoriteableType } = props ?? {};
    if (!favoriteableId) return;
    if (favoriteableType != "sticker") return;

    const sticker = props.message.stickerItems.find(s => s.id === favoriteableId);
    if (sticker?.format_type === 3) return;

    const menuItem = buildMenuItem("Sticker", () => fetchSticker(favoriteableId);
    findGroupChildrenByChildId("devmode-copy-id", children, true)?.push(menuItem);
charred monolithBOT
shell shuttle
#

oh i remembered how to fix it lol

scenic brook
#

Such an active PR lol

shut vineBOT
#

@granite sky, <t:1738702177:R>: …

granite sky
#

Already done

charred monolithBOT
granite sky
#

guuuuh

#

I hate this

image.png
#

looks fine in member list though

image.png
charred monolithBOT
limber skiff
granite sky
#

nop

#

fixed in 1 minute

#

verified icon uses 1rem as its height

#

so the whole tag is 16px instead of 15

#

I've made a check if it's a verified bot, if yes -> change height

jolly egret
#

manual alignment sucks

#

this is cursed

granite sky
#

uggh

#

i forgot to push

#

again

#

It's clearly not

limber skiff
#

that happened to me another time

granite sky
#

It's actually in my branch

#

changes are pushed

limber skiff
#

try pushing a empty commit

granite sky
#

but they are not in pr

limber skiff
#

git commit --allow-empty -m "aaa"

#

and then push

jolly egret
#

at least call it "Re-run CI" lol

limber skiff
#

🔥

granite sky
#

lmao

#

github expirience

#

thank you

granite sky
grave mangoBOT
jolly egret
#

yeah but its still not ideal that you have to align this yourself

#

at least looking here has shown that its not exactly been going great

limber skiff
#

there is actually no escape from that

granite sky
#

I love discord consistansy

#

I'm horrible at spelling and spellchecker died

#

nice

limber skiff
#

make a classNameFactory, call it cl and then className={cl("message-tag", props.message.author.isVerifiedBot() && "message-verified")}

#

const cl = classNameFactory("vc-mut-");

#

that makes it a bit more clear

charred monolithBOT
granite sky
charred monolithBOT
charred monolithBOT
fossil inlet
#

GUHHHH

#

its so weird

charred monolithBOT
shell shuttle
#

i accepted someones suggestion thing

fossil inlet
#

could someone run reporter on dev

#

@jolly egret youuuu

jolly egret
#

vreport dev

nimble pendantBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

jolly egret
#

real

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds 
findByCode("APPLICATION_RPC(", "Client ID")
Bad Starts

None

Discord Errors

None

fossil inlet
#

blobcatcozy thats it

#

but thats also ARRPC

jolly egret
#

oof

fossil inlet
#

which i love

austere talon
#

we should merge into main

#

for popout fix

fossil inlet
#

was the toast fix merged?

scenic brook
#

Nope

charred monolithBOT
fossil inlet
#

I do have a better find that only works on canary

austere talon
#

don't tell me they mangled the routes object

fossil inlet
#

nope

#

just wrapped it with an async function

austere talon
#

show

fossil inlet
#

was

        function q(e, t, n) {
            return s.tn
                .get({
                    url: P.ANM.APPLICATION_RPC(t),
                    oldFormErrors: !0,
                    retries: 3,
                    rejectWithError: !0,
                })
                .then(
                    (i) => {
                        let {
                            body: {
                                rpc_origins: r,
                                id: l,
                                name: a,
                                icon: s,
                                cover_image: o,
                                flags: c,
                            },
                        } = i;
                        if ("string" == typeof n) {
                            if (e.transport === y.He.POST_MESSAGE) {
                                let e = (0, u.Z)(t);
                                if (null == e || !U(n, [e]))
                                    throw new x.Z(
                                        { closeCode: P.$VG.INVALID_ORIGIN },
                                        "Invalid Origin",
                                    );
                            } else if (!U(n, r))
                                throw new x.Z(
                                    { closeCode: P.$VG.INVALID_ORIGIN },
                                    "Invalid Origin",
                                );
                        }
                        e.application = {
                            id: l,
                            name: a,
                            icon: s,
                            coverImage: o,
                            flags: c,
                        };
                    },
                    () => {
                        throw new x.Z(
                            { closeCode: P.$VG.INVALID_CLIENTID },
                            "Invalid Client ID",
                        );
                    },
                );
        }
#

is

    async function J(e, t, n) {
        let i = h.Z.getApplication(t);
        if ("string" == typeof n) {
            if (e.transport === O.He.POST_MESSAGE) {
                let e = (0,
                u.Z)(t);
                if (null == e || !B(n, [e]))
                    throw new y.Z({
                        closeCode: R.$VG.INVALID_ORIGIN
                    },"Invalid Origin")
            } else {
                let e = await Q(t);
                if (i = _.ZP.createFromServer(e),
                !B(n, e.rpc_origins))
                    throw new y.Z({
                        closeCode: R.$VG.INVALID_ORIGIN
                    },"Invalid Origin")
            }
        }
        null == i && (i = _.ZP.createFromServer(await Q(t)));
        let {id: l, name: r, icon: a, coverImage: s, flags: o} = i;
        e.application = {
            id: l,
            name: r,
            icon: a,
            coverImage: s,
            flags: o
        }
    }
austere talon
#

ahhh

#

can we just do like findByCode('"Invalid Origin"', ".application")

fossil inlet
#

works on canary for me rn

#

pushed

#

works on stable too

charred monolithBOT
austere talon
#

thx!

#

vtest dev

nimble pendantBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New tag created: v1.11.4
fossil inlet
austere talon
#

ah yeah

#

well that's not that important

#

toasts still work

rugged spire
#

nvm

#

forget what i was gonna say

fossil inlet
rugged spire
#

actually don't forget i will say anyway

#

i recall toasts.type or whatever being an incomplete enum in discord itself at one point

#

am i being dumb?

charred monolithBOT
scenic brook
#

I didn't even realise there were more types than success, failure and custom until it broke tbh

shut vineBOT
#

@rugged spire, <t:1730841949:R>: hey have you made a v3 of "your stable plugins" yet due to git hell

rugged spire
charred monolithBOT
rugged spire
#

@wise hare please tell me you didnt spend money on that

fossil inlet
#

😭WHY would anyone do that

rugged spire
#

(he can't talk here)

jolly egret
#

what the hell 💀

fossil inlet
#

@rugged spire they're staring at me

jolly egret
#

anybody got css to remove it lol

#

the button i 'm not bothered about the actual effect

#

nvm got it

charred monolithBOT
charred monolithBOT
charred monolithBOT
shell shuttle
#

which discord staff member do i need to [redacted] to get new features early (/JOKE!!)

#

like holy shit im always the last in the rollouts 😭

jolly egret
#

if you're on about the confetti stuff idk why you would want it

#

its just a paywalled feature lol

glass jasper
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

RoleColorEverywhere (found no module):
ID: -
Match: ```
renderPrioritySpeaker(){

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

odd heath
#

RCE bug in vencord real

glass jasper
odd heath
jolly egret
#

its kinda funny sometimes

#

as long as the context is clear

#

please don't submit issues on github for RoleColorEverywhere that are just "RCE bug"

glass jasper
odd heath
#

NOT husk

surreal fiber
#

rename rolecoloreverywhere

jolly egret
#

rename it to remote code execution

glass jasper
charred monolithBOT
austere talon
#

vtest

nimble pendantBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

RoleColorEverywhere (found no module):
ID: -
Match: ```
renderPrioritySpeaker(){

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

wary palm
#

Do we need any change for the AUR build or can I just push it?

austere talon
# 
MimeType=x-scheme-handler/discord
wary palm
#

Thanks! Pushing it then cc @opaque silo and I cant find zt64

opaque silo
#

with aurpublish

austere talon
#

oh yeah idk if he has access

opaque silo
#

I'm gonna be awake for like 30 more mins

#

so I will merge with no review

wary palm
#

Sorry

#

😦

austere talon
opaque silo
#

its ok I can resync them

austere talon
#

lmaoo

opaque silo
#

ok fine turning my laptopbhack on

wary palm
wary palm
austere talon
#

also playing Tomb Raider on laptop is so real

wary palm
#

Tomb Raider ❤️

#

Lara Croft ❤️

opaque silo
#

loveee

austere talon
#

do u have a gaming laptop 😭

#

or is Tomb Raider just that well optimised

opaque silo
austere talon
#

i finished tomb raider rise just like 2 days ago

#

i love lara

opaque silo
#

for some reason comet isnt syncing achievements with gog

#

i will go bother heroic people about it

austere talon
#

crying

opaque silo
#

HIT IT

wary palm
#

So, now we can remove the anime thing when vesktop starts

#

Nice :p

#

Love u

opaque silo
#

💀 💀 💀 💀 💀 💀 💀 💀 💀

#

THATS NOT WHAT THAT CHANGE WAS FOR

wary palm
#

XDDDDD

opaque silo
#

@austere talon REVERT IT NOW

austere talon
#

and it will never close it will stay open forever

#

bro what is wrong with this fucking bot

image.png
wary palm
#

Better bussiness

opaque silo
#

you should give flathub some of your vencord biullions so they can make their bot not shit

austere talon
#

MASTER SHUTDOWN??

image.png
#
  1. smh offensive language, needs to be fixed!!!111!!11
  2. did someone ddos flathub or smth
opaque silo
#

they ddos themeselves with their bot

austere talon
#

they should ask redhat for some millions or smth

#

just ask redhat for infra 😭

wary palm
long stream
wary palm
# 
==> Starting build()...
Lockfile is up to date, resolution step is skipped
Packages: +666
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Packages are cloned from the content-addressable store to the virtual store.
  Content-addressable store is at: /home/edu4rdshl/.local/share/pnpm/store/v3
  Virtual store is at:             node_modules/.pnpm

   ╭──────────────────────────────────────────────────────────────────╮
   │                                                                  │
   │                Update available! 9.1.0 → 10.2.0.                 │
   │   Changelog: https://github.com/pnpm/pnpm/releases/tag/v10.2.0   │
   │     Run "corepack prepare pnpm@10.2.0 --activate" to update.     │
   │                                                                  │
   │      Follow @pnpmjs for updates: https://twitter.com/pnpmjs      │
   │                                                                  │
   ╰──────────────────────────────────────────────────────────────────╯

Downloading app-builder-bin@5.0.0-alpha.10: 72.51 MB/72.51 MB, done
Progress: resolved 0, reused 372, downloaded 270, added 666, done
node_modules/electron: Running postinstall script, done in 5.5s
node_modules/esbuild: Running postinstall script, done in 107ms
node_modules/tsx/node_modules/esbuild: Running postinstall script, done in 85ms
node_modules/@vencord/venmic: Running install script, done in 51ms

> vesktop@1.5.5 postinstall /home/edu4rdshl/.cache/paru/clone/vesktop/src/Vesktop-1.5.5
> pnpm updateArrpcDB

sh: line 1: pnpm: command not found
 ELIFECYCLE  Command failed.
==> ERROR: A failure occurred in build().
    Aborting...
error: failed to build 'vesktop-1.5.5-1': 
error: packages failed to build: vesktop-1.5.5-1
#

Mmmmm

opaque silo
#

oh

#

i forgot about that

#

the -git packages have the patch

#

hold on

wary palm
#

I will wait this time

#

XD

opaque silo
#

ok pushed

wary palm
#

Ty cookie

#

That didn't worked, the sed command doesn't do anything on package.json

#

sed -i 's/"postinstall": "pnpm updateArrpcDB"/"postinstall": "corepack pnpm updateArrpcDB"/' package.json this works

austere talon
wary palm
#

ight

#

sorry

opaque silo
#

or did vee change something

wary palm
#

vee told me to stfu here

#

😦

#

/s

opaque silo
#

tell vee to stfu

#

(real)

austere talon
opaque silo
fossil inlet
dapper tiger
#

guh

wary palm
#

I will try to not ping @dapper tiger too much

#

Right @dapper tiger ?

dapper tiger
#

yop

charred monolithBOT
charred monolithBOT
charred monolithBOT
scenic brook
#

mostly because I'm stupid yk
Relatable

charred monolithBOT
median rapids
#

pretty sure they just treat dragging multiple as being dragged one by one

charred monolithBOT
limber skiff
#

yeah it seems so weird to do one request per attachment

#

vext

nimble pendantBOT
limber skiff
#

cleaned up known issues a bit

charred monolithBOT
limber skiff
#

(ignore)

scenic brook
#

No

limber skiff
#

Ok

charred monolithBOT
austere talon
#

why do people use AI to generate PR descriptions 😭

image.png
leaden furnace
#

writing is hard

charred monolithBOT
granite sky
charred monolithBOT
granite sky
austere talon
#

for example

scenic brook
#

The second _ is part of the hash isn't it?

granite sky
#

oh, yeah

charred monolithBOT
austere talon
#

one thing I hate about GitHub issue/pr tab is that when you close one thing, everything skips forward

so if you're on page 1, close 3 issues there then switch to page 2, 3 issues from page 2 skip to page 1 and you never see them

charred monolithBOT
#
flawless-run
[Vendicated/Vencord] Pull request opened: #3205 feat(translate): preserve emojis and add original text option

Hey team! 👋

This PR fixes an issue where the auto-translate plugin was trying to translate emojis and adds a new option to include the original text in the translated message.

What's New?

  1. Emojis Are Safe Now

    • The plugin no longer tries to translate emojis (which was breaking things).
    • Emojis stay exactly where they should be in the message.

  2. New Setting: Include Original Text

    • Added a toggle to optionally show the original message below the...
fossil inlet
granite sky
#

Also i've changed everything you wanted on both prs blobcatcozy

charred monolithBOT
austere talon
#

vtest

nimble pendantBOT
fossil inlet
frail skyBOT
#
Bad Patches

RoleColorEverywhere (found no module):
ID: -
Match: ```
renderPrioritySpeaker(){

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
frail skyBOT
#
Bad Patches

RoleColorEverywhere (found no module):
ID: -
Match: ```
renderPrioritySpeaker(){

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

fossil inlet
#

I think I will eat breakfast then fix it blobcatcozy

fossil inlet
# charred monolith

I thought of that, but what would you use as a placeholder? Couldn't that just get sanitized/replaced by the translator?

granite sky
#

Who ate my react dev tools

image.png
scenic brook
granite sky
#

I honestly have no idea where are they

charred monolithBOT
glass jasper
# frail sky

OK, considering this is 90% of support right now I’m gonna make a KnowIssuse

charred monolithBOT
fossil inlet
#

@austere talon you will fix blobcatcozy

image.png
austere talon
charred monolithBOT
austere talon
#

we just need to update esbuild

fossil inlet
austere talon
#

our esbuild is so fucking outdated lmao

austere talon
limber skiff
#

update and make build script faster

fossil inlet
#

nop

#

in anonmous function

#

that isnt arrow

austere talon
#

love

#

wait

#

not arrow?

#

then we can

fossil inlet
#

no

austere talon
#

??

fossil inlet
austere talon
#

ah like that

#

the diff on patchWebpack is so cancer

fossil inlet
#

guhhh i love my patch helper in vscode

limber skiff
#

I changed a lot blobwob

fossil inlet
#

its so nice

austere talon
#

is it possible to get this from cache

image.png
#

or not loaded

limber skiff
#

not loaded

#

I mean

#

not required

#

but loaded

#

that code runs once the first module is required

charred monolithBOT
fossil inlet
#

wall of text

austere talon
#

looks good mostly

limber skiff
#

is this something that can actually be reached during normal functionality or is this only if something breaks?

#

It's an object so there really shouldnt be any other prop being added

#

I will remove that, it doesn't really make sense, thinking now

#

if anything will just check if newValue is a function

charred monolithBOT
charred monolithBOT
jolly egret
#

do we have a reason behind the CSS editor on the chrome extension opening a blank window for the past couple updates yet?

austere talon
#

nah

#

funny bug

#

im gonna check it out eventually

#

mfs should just use stylus

fossil inlet
#

love stylus but husk

glass jasper
rugged spire
frail skyBOT
#
Bad Patches

RoleColorEverywhere (found no module):
ID: -
Match: ```
renderPrioritySpeaker(){

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

RoleColorEverywhere (found no module):
ID: -
Match: ```
renderPrioritySpeaker(){

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

rugged spire
fossil inlet
dapper tiger
#

@fossil inlet make plugin to auto skip this

image.png
glass jasper
dapper tiger
#

nop

#

rosie abuses mod and bans me and it shows up every time

shut vineBOT
#

@fossil inlet, <t:1738289728:R>: migrate from TS 4.9.5 to 5.7.x

dapper tiger
#

seems to be really simple

#

https://discord.com/api/v9/guilds/$guildID/new-member-action/$channelID

#

just a POST request

limber skiff
#

horrible, you gotta make post requests for that?

dapper tiger
#

yes

limber skiff
#

why is discord so dumb

#

they are giving a valentines day decoration for when you gift someone nitro

fossil inlet
limber skiff
#

if they had the minimum of a brain they would realize the other person should get it too

#

bro, people like to match things

#

give to both, dumbass

fossil inlet
limber skiff
#

like what's the point if you already have nitro, gift someone it and then only you get the decoration

#

what about the other person

#

do they gotta gift a stranger?

long stream
#

their idea is probably that they gift it back

charred monolithBOT
limber skiff
charred monolithBOT
limber skiff
#

oh oops

image.png
charred monolithBOT
long stream
#

that person was a vencord contributor for a whole minute blobcatcozy

limber skiff
#

soon they will be

glass jasper
charred monolithBOT
shell shuttle
#

this time it's ready fr fr

#

unless i missed something

fossil inlet
#

HORROR

#

@limber skiff was this intentional 😭

limber skiff
#

ya

fossil inlet
#

i love the patcher rewrite branch causing 999 merge conflicts for me blobcatcozy

#

ill worry about it later blobcatcozy

austere talon
limber skiff
austere talon
#

once you address the feedback I gave on your pr and I tested tomorrow, we can merge that branch

#

half of it is just questions for clarification anyway trolley

#

oh also one last thing I didn't post there

#

I'm not a huge fan of the eagerPatches setting

#

why make it a setting?

#

pick the one that's better and make it the only option without a setting

limber skiff
#

reporter uses it lol

austere talon
#

but why does it have to be a setting then and not just reporter check

fossil inlet
#

what does eager patches even do wires

limber skiff
austere talon
#

is there any reason for anyone besides reporter to want to change the behaviour?

#

it seems like a bad idea to have something like that as a setting cause it overcomplicates the code and makes behaviour inconsistent depending on the setting

limber skiff
#

its just worse performance to have it on

#

and you might wanna use it if ur running reporterDesktop

#

oh wait it already enables it for you

#

lol

limber skiff
#

matches current behavior

fossil inlet
limber skiff
#

ya

#

that gives us way more control

fossil inlet
#

i feel like id use that on my dev build

#

without reporter

austere talon
#

I think we should just get rid of the setting and flag it behind reporter instead

#

🤔

fossil inlet
#

maybe make it require a dev build to be toggled

limber skiff
#

nop

shell shuttle
fossil inlet
#

@granite sky

shell shuttle
granite sky
charred monolithBOT
charred monolithBOT
#
nay-cat
[Vendicated/Vencord] New comment on pull request #3096: feat: Fixed bad links

as mentioned in #3205, this issue also happens with emojis. would be nice to add emojis to the regex as well.

after some testing, i've noticed that it can mess up mentions as well.

![{13B33970-5107-4E6C-BDAF-1FCFEC8E7915}](https://private-user-images.githubusercontent.com/62349009/410892124-9c7b5dd3-57ca-438b-9a2d-0faf2fcba61c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5M...

charred monolithBOT
fossil inlet
#

will there be a tag before patcher rewrite is merged into dev?

limber skiff
#

push yes, not tag

#

@fossil inlet how are you testing patches with your new devtools

#

(like the patch helper)

fossil inlet
#

then i apply it on the extension side

#

and show it in a read-only window (you will not believe how hard it is to open a readonly window in vscode) and update it everytime the user changes the patch in the source file

limber skiff
#

asking because I'm might export some more functions from WebpackPatcher

#

to make everything easier

fossil inlet
limber skiff
#

nono

#

patcher

#

not finds

#

so like one to attempt to patch with a replacement

fossil inlet
#

ah

#

idk if its possible now, but would it be possible to get a list of what plguins patch a module

#

because i dont think vencordpatchessource has the comment with it

limber skiff
#

patched source does I think

#

however

#

I could add them along patched source

fossil inlet
limber skiff
#

ohh right

#

patched source factory.toString

#

interesting

#

if I instead make patchedSource the string used to eval the factory

#

I might be able to save some memory

fossil inlet
#

small

limber skiff
#

I meann not sure how JS handles it

#

but I know they keep the string used for the eval in memory

#

so avoiding keeping a reference to factory.toString() is probably a good idea

limber skiff
fossil inlet
#

becuase if \\i in used

#

what what would that be as valid syntax

#

that would make sense to the user

limber skiff
#

if \\d works then\\i should too

austere talon
fossil inlet
#

oh, im stupid

#

\\i would just be a literal backslash followed by a literal i

limber skiff
#

ya

#

which means don't replace anything

fossil inlet
#

i just got a stupid idea on how to parse that blobcatcozy

charred monolithBOT
austere talon
#

hmm

#

i wanna make a workflow input for reporter for webhook url but

#

you can't seem to make workflow inputs private

#

i wanna make it post the results to venbot.vencord.dev

#

so venbot can post it manually

charred monolithBOT
limber skiff
#

good reminder

#

will do it now

#

I feel like it's better to keep eagerPatches as a setting

#

allows people who want to mess up with something like sadan to manipulate it easier

#

it can even be changed at runtime depending on how early you load a module

austere talon
limber skiff
#

also it's a setting without an ui so the normal user will not touch it

austere talon
#

it will trigger reporter and make it send back results to venbot via webhook

#

then venbot posts the message & edits an existing message (so we have one channel with always up to date reporter results)

charred monolithBOT
limber skiff
#

@austere talon are you sure about this?

image.png
#

don't you mean chunk ids, not module ids?

austere talon
#

nah module ids lol

#

there's no guarantee that it's a number

limber skiff
#

we already kinda rely on that

#

because the minifier changes some numbers to exponential notation

austere talon
#

is this valid syntax

image.png
#

testing workflows is so fucking annoying

limber skiff
#

I dont know honestly

limber skiff
#

but for the chunk loader it's the way of getting the proper key because we match code and not executing js code

#

so we gotta turn the exponential notation into it's proper number

#

ig I can fix this actually

#

that's not very consistent lol

image.png image.png
fossil inlet
#

iirc GH censors all secrets in output

austere talon
#

just remove your reporter changes from ur pr

#

I will do it in my change

#

cause i'm changing it anyway

#

(i mean the part that removes discord token)

limber skiff
#

alright

#

I mean

austere talon
#

i want to make the embed tell u the git buildid / hash

limber skiff
#

I have to remove it partially