for example, refuse to install or require the user to install X package before installing Vesktop
#🖥-vesktop-development
next sundial
vernal lintel
yes but we don't need any dependencies
tidal quarry
well I'm pretty sure its the last os for some macs and its not really that commonly used anymore
people can just use opencore legacy patcher to upgrade their macs to newer versions anyway
Personally I wouldn't really care about support unless its for something like the vencord installer
simple groveBOT
simple groveBOT
Content
Hi, there's a problem with vesktop. I don't know what the issue is, but I have a screenshot below
simple groveBOT
hot juniper
only `libunity` for the notification badge
wasnt it stated a few days ago in here to NOT mark libunity as a dependency anymore
oh
i see you uhhh #🖥-vesktop-development message
next sundial
<:trolley:1024751352028602449>
humble mortar
@vernal lintel what's happening with the icon pr 😭😭
humble mortar
I love not posting logs
simple groveBOT
simple groveBOT
simple groveBOT
Funnily enough, i went to double-check the logs to make sure the issue still persists, but this time they are different, no longer throwing the "Uncaught DOMException", as outlined in the original post on this issue. Anyway here they are, hope this helps somehow
Uncaught SecurityError: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
at VencordDesk...it does what 😭😭😭😭
simple groveBOT
Discord Account
skeletonek
Operating System
Arch Linux
Linux Only ~ Desktop Environment
KDE Plasma 6.2
Package Type
AppImage
What happens when the bug or crash occurs?
Users on official discord client are seing weird color artifacts and a very low stream quality
Screenshot from my friend when I (on Vesktop) was streaming Serious Sam: Siberian Mayhem to him
Comparison...
simple groveBOT
teal stump
of course im the one to find this issue
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
teal stump
fair enough honestly
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
hot juniper
omg when will NoDevtoolsWarning just be enabled by default on vesktop
cyan flame
omg when will NoDevtoolsWarning just be enabled by default on vesktop
Not just vesktop it can happen on the regular client too
There’s also just a few plug-ins that should be enabled by default
hot juniper
Not just vesktop it can happen on the regular client too
It shouldn't happen on a native client
but it probably does
hot juniper
There’s also just a few plug-ins that should be enabled by default
also I want to know what plugins those are
cyan flame
also I want to know what plugins those are
I mean, the ones right off the top of my head is ThemeAttributes, or ForceOwnerCrown,
hot juniper
I mean, the ones right off the top of my head is `ThemeAttributes`, or `ForceOwn...
One of those makes sense, the other does not.
cyan flame
One of those makes sense, the other does not.
fair enough, on the second one, but I’ll stand by the first one
hot juniper
fair enough, on the second one, but I’ll stand by the first one
that's reasonable
even if it was decided it should not be marked as required, maybe a special "you should enable this" could be shown when trying to add custom CSS
worn harness
vesktop xdg portals when
@grizzled hemlock make it happen
i hate gtk file picker so mmuch
humble mortar
i hate gtk file picker so mmuch
electron went insane and bumped to an unreleased portal version (v4)
34 has that change reverted
but 34 is still in beta sooo
worn harness
electron went insane and bumped to an unreleased portal version (v4)
fix
humble mortar
build your vesktop on 34 beta bwaa
grizzled hemlock
i hate gtk file picker so mmuch
true
next sundial
does libunity work on normal GNOME?
humble mortar
yes gnome has badges
next sundial
🤔
if it works on normal GNOME, it should also work on Linux Mint
weird
oh
they are using the flatpak version
hmm
probably libunity needs to exist inside the freekdestop platform libraries?
humble mortar
the flatpak would need the correct dbus points enabled for it
humble mortar
libunity doesnt need to be in the flatpak
next sundial
to fix the issue the flatpak manifest would have to be changed
humble mortar
just the dbus points
"--talk-name=com.canonical.AppMenu.Registrar",
"--talk-name=com.canonical.indicator.application",
"--talk-name=com.canonical.Unity",
next sundial
hmm, are you sure about that?
humble mortar
yes
humble mortar
test it before you pr
next sundial
sure
next sundial
we can add the libunity paackage to the flatpak so we guarantee that
next sundial
yes, there isn't
but we can download the .tar.gz file and extract it
see https://github.com/flathub/org.gnome.Geary/pull/14/files for an example
humble mortar
that is an insane thing to do for system badges
humble mortar
the proper solution is to emit the dbus signal
next sundial
yep I know that
Electron team = 💤
I will only have a look at the permissions
so it satisfies for now
humble mortar
Electron team = 💤
or just have vee do #686
next sundial
change of plans, discord won't allow me to create an alt account to test it
so I'll let the flatpak explode
simple groveBOT
simple groveBOT
humble mortar
AcceleratedVideoEncoder is a flag change in chromium 131
electron 33 is chromium 130
they are insane
high sundial
they are insane
i did not check, my problem is that currently Vesktop for me is not hardware accelerated on encoding
but chromium is
humble mortar
do you have hardware accel enabled in vesktop settings
high sundial
Yes
high sundial
AcceleratedVideoEncoder is a flag change in chromium 131
btw where is this stuff documented, may i know?
for me chromium flags are a black box, its much more easy to find firefox stuff than chromium on stuff about linux
humble mortar
btw where is this stuff documented, may i know?
humble mortar
is someone actually watching your stream
high sundial
Yeah they were
I can make a recording, but sadly this is no longer development but support
we can move if u want
humble mortar
just play with the flags passed to vesktop.
humble mortar
I can make a recording, but sadly this is no longer development but support
no sorry i dont really have the time rn to deal with chromium flag shit
high sundial
i agree its a pain
the least of chromium's priorities are linux support
i have a question, is it possible to open a new webview on vesktop to chrome://gpu? I tried location.href but it didnt like it and it crashed 
its much better than debugging with streams
humble mortar
I'm like 90% sure those pages are disabled in electron
high sundial
funnily enough, they are not apparently
humble mortar
well it says hardware acceleration is working 
high sundial
yup
so i guess its a me issue or an older chromium issue
u said it was 130, right?
(well it says right there)
humble mortar
130 is relatively new
high sundial
i agree
there is still a chance that its an issue with my setup but why does it work on chromium then 
humble mortar
there is still a chance that its an issue with my setup but why does it work on ...
what flags did you pass to raw chromium
high sundial
its 131 and i only did chromium --enable-features=AcceleratedVideoEncoder
$ chromium --version Chromium 131.0.6778.85
high sundial
Fun
my only reason for cam recording was to not make the enc on nvtop show lol
i also had to use multi pc setup as decoding shows as ENC also 
simple groveBOT
vernal lintel
funnily enough, they are not apparently
yeah this works fine
i was thinking about adding some sort of developer tools to vesktop to open those windows
simple groveBOT
humble mortar
they didnt change the other two flags
high sundial
they didnt change the other two flags
can do, do i use the simple one or the zero copy one?
idk if the zero copy one fallbacks to simple on x11 environments or if it breaks stuff
high sundial
i was thinking about adding some sort of developer tools to vesktop to open thos...
sounds useful ngl
hot juniper
i was thinking about adding some sort of developer tools to vesktop to open thos...
please do
actually this seems like the kind of thing that could be done relatively easily
simple groveBOT
hot juniper
where should the entry point(s) be?
simple groveBOT
hot juniper
vesktop settings?
about window?
window menu?
tray icon menu?
simple groveBOT
I can confirm that it was really due to the system configuration. More precisely, the integrated GPU. My CPU (i7-12700k) contains a graphics unit...
This led to this error. The error message was somewhat misleading.
Specifically, I had to change the following in the UEFI at MSI:
Disable IGD Multi-Monitor!
teal stump
@vernal lintel i might be able to do this myself, (depending if "wontfix" means "i will not fix" or "will not ever be fixed")
sour muralBOT
installer.nsh:
!macro preInit
SetRegView 64
WriteRegExpandStr HKLM "${INSTALL_REGISTRY_KEY}" InstallLocation "$LocalAppData\vesktop"
WriteRegExpandStr HKCU "${INSTALL_REGISTRY_KEY}" InstallLocation "$LocalAppData\vesktop"
SetRegView 32
WriteRegExpandStr HKLM "${INSTALL_REGISTRY_KEY}" InstallLocation "$LocalAppData\vesktop"
WriteRegExpandStr HKCU "${INSTALL_REGISTRY_KEY}" InstallLocation "$LocalAppData\vesktop"
!macroend
it's irrelevant
no one should be using windows 7 anymore
it's not supported
teal stump
it's irrelevant
im not adding support for it
im making it more clear it doesn't support it
vernal lintel
probably a bad idea
some people patch their win7 to support new chromium
idk if it would make them unable to install it
probably would
it's fine in its current state
if anything we could just add a note to the readme
teal stump
some people patch their win7 to support new chromium
usually those people also use a program to spoof their version
hot juniper
just have soft warning then?
vernal lintel
or nothing at all
teal stump
just have soft warning then?
maybe
gentle hatch
what is this ai slop
humble mortar
once again someone is thinking this is implemented for existing sessions
humble mortar
@vernal lintel what do you think
humble mortar
did guy not understand what I said
azure verge
^ something else to note about screenshares, ppl have been reporting to me at least, that my screenshares often like to "corrupt" or just have all of the colors get really messed up
sometimes the colors show negatives, sometimes it's nearly all black, etc.
simple groveBOT
vernal lintel
^ something else to note about screenshares, ppl have been reporting to me at le...
^ same thing applies
azure verge
o 
jus wanted to make sure incase it was something i didnt know was a known problem or anything :3
ty :D
simple groveBOT
vernal lintel
it really sucks that the majority of issues are something in electron we can't do anything about
I love having to tell people I have no clue how to fix it ten times a day
it's so much nicer if it's actually something in your codebase so you can actually fix it / tell people how to fix it instead of being as clueless as they are
hot juniper
it really sucks that the majority of issues are something in electron we can't d...
i suspect most of these issues aren't even electron itself and are chromium issues 
vernal lintel
maybe
but reporting bugs to chromium is insane
they have such a weird bug tracker
so i tell people to report it to electron cause then it's electron's problem and not our problem
hot juniper
they have such a weird bug tracker
idk why google thinks people want to use a google account for that
sudden trout
hot juniper
https://cdn.discordapp.com/attachments/1024286218801926184/1236601516555767860/c...
i love seeing this being shared around half a year after it was made
simple groveBOT
azure verge
it's so much nicer if it's actually something in your codebase so you can actual...
y u p
I mostly even brought up the streaming issues because I was hoping it was something I could fix but NOPE. 
simple groveBOT
simple groveBOT
Update: I’m not sure how, but the original issue seems to be resolved now. However, I noticed that the screen preview inside the share menu is much smaller than the blue frame around it, as you can see in the screenshot. It would be great if the preview could be properly scaled to fit the blue border
humble mortar
simple groveBOT
vernal lintel
when my right click finger popped out of its socket
what 😭
also omg why didnt they just use voice input haha
hot juniper
instead as the audio share is made mono on discords server side anyways
does this occur on stock desktop client
upper pine
No, they use a windows only native module for sharing which also handles audio
With pipewire screen capture we could try and make a replacement module for it
I'm a little sparse on time lately but I might find the time to make such a module eventually
vernal lintel
No, they use a windows only native module for sharing which also handles audio
they added native audio to the linux app
recently
linux app now has working audio + wayland support
upper pine
Ah nice, does that audio also get mixed down to mono?
vernal lintel
idk
i didnt try
probably doesnt
considering their desktop app uses the udp protocol which doesnt have the downmixing
upper pine
I'd reckon if they don't use a native module but the chromium thingy
vernal lintel
i dont think they do? how would they support audio
upper pine
If they use a native module we could include it in vesktop
Or I can figure out how it works an make Venmic work with that
vernal lintel
If they use a native module we could include it in vesktop
naaaah we can't lol
copyright infringement
upper pine
Make the user copy it :P
vernal lintel
unless you wanna like make people install discord and load it from their files
but that's insane 😭
upper pine
Or I can figure out how it works an make Venmic work with that
Then this would be the way to go I guess?
If I find the time to look at it I can check how their module works and just pump venmic audio through it
vernal lintel
Or I can figure out how it works an make Venmic work with that
well we would have to use their udp protocol
it's quite complex
and has encryption too
people have been working on remakes
in c++ and rust
it definitely wouldn't be worth it to remake imo cause at that point you should just use the normal app
upper pine
and has encryption too
Aids
vernal lintel
but if you want a fun project sure xD
upper pine
Yeah fair point
upper pine
but if you want a fun project sure xD
Def worth a shot and would be interested but I'll have to finish some other things first xd
Will keep it on my to-dos though
simple groveBOT
You could have used that time you spent typing that unnecessary comment googling your issue instead. Seriously quit being so entitled and cocky
https://bbs.archlinux.org/viewtopic.php?id=300635
https://github.com/electron/electron/issues/44543
humble mortar
LMAO
humble mortar
the worms in my head making me type a billion words of complaint instead of 4 words into google.com and clicking the top result
hot juniper
it definitely wouldn't be worth it to remake imo cause at that point you should ...
tbf what keeps me using vesktop is that it has a less deranged dev experience
woeful current
“i can’t read!”
hot juniper
“i can’t read!”
humble mortar
look at this idiot yapping
simple groveBOT
simple groveBOT
simple groveBOT
hot juniper
this wouldn't be too hard to implement would it
humble mortar
this wouldn't be too hard to implement would it
hot juniper
https://github.com/Vencord/Vesktop/pull/370
i still don't get why vesktop wants to reimplement a lot of discord settings in its own page though
i think i tried to port some of them to stock settings locations at one point
humble mortar
less patches that might break
hot juniper
good point
simple groveBOT
Discord Account
shithad
Operating System
Windows 10
Linux Only ~ Desktop Environment
No response
Package Type
Setup exe
What happens when the bug or crash occurs?
Loading Vesktop just gives a box with a white screen. There is no tray icon either. Have tried restarting PC and reinstalling Vesktop.
What is the expected behaviour?
For Vesktop to load and open to my ho...
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
livid gulch
What a convenience lol. Was gonna ask if I could PR a good temporary fix for this. Could still do it if it is wanted but not required/needed
vernal lintel
What a convenience lol. Was gonna ask if I could PR a good temporary fix for thi...
whats the fix
isnt the problerm that wayland doesnt give u control
livid gulch
Oh didnt think about that
livid gulch
isnt the problerm that wayland doesnt give u control
Seems like that's the case. Seems like the only thing that can rly be done is request full screening on a specific screen
I mean a temporary somewhat of a fix could be just place it in full screen on the monitor it was closed at the last time
humble mortar
isnt the problerm that wayland doesnt give u control
with this merged https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/264 you can spawn a full screen invisible window the spawn relative to that :ppp
humble mortar
I mean a temporary somewhat of a fix could be just place it in full screen on th...
horrible??
livid gulch
How so?
humble mortar
forcing spawning as full screen is terrible
you want it spawned in a specific location not full screen
livid gulch
If the user had it closed as fullscreen on my second monitor I would want it to start it as that. So was thinking of it more as "if the user has specified as fullscreen"
humble mortar
that already works?
cyan flame
with this merged https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merg...
eww gitlab
humble mortar
It always starts for me in fullscreen on my primary monitor
yeah thats how wayland works
you can't request the monitor
use a window rule for that
livid gulch
you can't request the monitor
https://github.com/libsdl-org/SDL/issues/7197#issuecomment-1409707012 found this comment left on SDL though
I am guessing display and monitor is the same
Only problem is I can't find any api references for this in the Wayland API
humble mortar
oh interesting
mpv --player-operation-mode=pseudo-gui --fs --fs-screen=2
works
so ig it is a thing?
livid gulch
That could be used for a solution to have it be on a specific monitor on start up
If the API for it can be figured out lol
livid gulch
I'll do it tomorrow
livid gulch
`mpv --player-operation-mode=pseudo-gui --fs --fs-screen=2`
The second more scuffed solution is using like a xdotool for Wayland and run some stuff that does keyboard shortcuts to fullscreen it on the right screen if it can't be figured out how other does it
humble mortar
despair
livid gulch
Scuffed for a reason
humble mortar
leave it for electron to figure out 😭
livid gulch
I have 0 patience :trol:
livid gulch
the 5 first results on Google: is broken on KDE, great
livid gulch
I'll check tomorrow and see it. Never heard it before
Otherwise I'll do a PR or maintain a fork until electron has figured it out 👍
humble mortar
or just run xwayland 💀
livid gulch
No fun with that /hj
simple groveBOT
livid gulch
@vernal lintel it's a Wayland issue in the way that is "Wayland is not made this way"
Wayland was made for windows to only be able to interact with anything inside of itself and nothing outside of itself. So according to a lot of people this will never be resolved as Wayland was simply not made for it or smth along those lines
So you can probably p confidentially say it will not be fixed upstream cause it just isn't wayland (tho don't take my words for this)
humble mortar
with this merged https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merg...
.
hot juniper
vesktop maintaining its own electron fork when
woeful current
vesktop maintaining its own electron fork when
vesktopOS
simple groveBOT
Can confirm that this issue is occurring (in some form) on Arch with both Hyprland and Xfce (X11), with the aur packages vesktop-bin, vesktop-electron, and the flatpak package.
It seems to manifest as streams taking ages to load for viewers (but thumbnails load with no problem?), and when they do load they are usually just a black screen, or have very strange colours (example below).
simple groveBOT
Discord Account
ryzm
Operating System
Macos 15.2
Linux Only ~ Desktop Environment
No response
Package Type
DMG
What happens when the bug or crash occurs?
What is the expected behaviour?
It Should just open like normal.
How do you recreate this bug or crash?
I dont really know i just downloaded it and then it wont load so i checked t...
hot juniper
vesktopOS
i mean in the past week i've considered adding a plugin to vencord to show my public transport card balance as a joke
simple groveBOT
simple groveBOT
simple groveBOT
vernal lintel
why is that not a dependency of hyprland 
sudden trout
it should be?
humble mortar
why is that not a dependency of hyprland <:blbctscrd:1065724903652855938>
insanity thats why
its not even optional
lmao
simple groveBOT
gentle hatch
vestkop
sly cairn
because the PR author still hasnt tested
im not going to keep chasing them up, i asked for a test status and if they havent given a result i cant do anything with it
i will chase them up one last time because im aware this is wanted but if i get no response i cant merge it
bleak spire
I wonder if it would be possible to change it with the option that applies themes to that window
woeful current
I wonder if it would be possible to change it with the option that applies theme...
no
only thing this does is take background color and save it
the theme itself isn’t really applied
humble mortar
instead of all that bloat in that pr just have it pull from a css var a URL or file path then load that
sly cairn
for transparency i have blocked them for 1 day from the org, many people receive emails for these comments and posting them is useless. they're being hidden because they add nothing to the PR, and the promotion of a fork is not productive. this isn't about being juvenile or hiding things that we don't like, this is us trying to actually work, and we're still waiting for the PR author to confirm things. behave yourselves.
you are free to use equibop or any other forks of vencord/vesktop, but please stop bringing them up here and promoting them because we, the developers of the base software, cannot support it
vernal lintel
1 day 
sly cairn
you wanna bump it up?
vernal lintel
yes. i blocked them permanently
sly cairn
ah
vernal lintel
why are you being nice to trolls and assholes lol
vernal lintel
it's obvious they're just here to be a cunt and never gonna contribute anything productive
sly cairn
fair enough
woeful current
you are an idiot!
quoting equicord’s own rules channel:
simple groveBOT
Vanilla client supports sharing screen in 4k.
cyan flame
you are an idiot!
quoting equicord’s own rules channel:
and thats the one rule we heavily inforce and follow because of stuff like this
it makes me mad because no matter how much we say and try to drill it into their heads they still do stuff like this
simple groveBOT
simple groveBOT
Discord Account
constantitus
Operating System
Linux
Linux Only ~ Desktop Environment
Hyprland, vesktop running under xwayland
Package Type
Tried flatpak and latest release from this repo.
What happens when the bug or crash occurs?
It used to work, but it stopped working at some point.
I can confirm audio is getting from firefox to the vencord-screen-share node ...
hot juniper
this channel is hell
why it always gotta be
- people who should go to #🏥-vencord-support-🏥
- gpu issue (chromium moment)
- something broke with screenshare (probably chromium if not probably venmic issue instead)
- i dont like rainbow icon (and it's always because it's rainbow and not because of an actual complaint in which case just edit the desktop file)
humble mortar
why it always gotta be
- people who should go to <#1026515880080842772>
- gpu i...
vee should merge all prs with no review so actual bug reports are made
simple groveBOT
vernal lintel
@upper pine is this expected?
simple groveBOT
humble mortar
48000 is the default for pipewire so prob some bad assumption in a library somewhere
sudden trout
upper pine
<@349609234985517057> is this expected?
I don't make any assumptions just links, meaning that if the clock rate is different and it doesn't work it's discords / the applications fault
I can't know what sample rate other programs have so I also can't downsample it to the expected rate
Just a bad idea to change the sample rate if you don't know that the applications on your systems can handle it
vernal lintel
hmm
hybrid fjord
Can't confirm that
Used flatpak version
simple groveBOT
grizzled hemlock
hop on irc
woeful current
hop on irc
hop on nin0chat
humble mortar
nin0chat has terrible uptime I'm selling all my stock in nin0corp
simple groveBOT
simple groveBOT
vernal lintel
i hate how every new electron version not only improves 5 things but also adds 3 more bugs and linux issues 😭
quasi spear
Hi. Does the discord's game sdk's RPC work for you on Vesktop linux?
Upon starting my program on linux, which works on macos with vesktop just fine, it says that f.kio.core: "/var/home/neo/.local/share/flatpak/exports/share/applications/com.discordapp.Discord.desktop" contains supported protocols but doesn't use %u or %U in its Exec line! This is inconsistent.
it works with the official discord client opened, but does not with vesktop.
It was mentioned in another channel that vesktop does not support RPC, tbh I am not sure how does the Discord GameSDK work precisely, but why would it work on macos and not on linux, then?
quasi spear
Well the issue could be that since I am using discord's proprietary libraries it tries to indentify whether or not there is discord's official client RPC server listening. There is not, because Vesktop uses arRPC (obviously) and immidiatelly terminates with this error. It is one of the possibilities, but doesn't explain why it works on macos - it could be that the SDK for mac (aarch64) and linux (x86_64) differs in this specific case. Which would be strange, but if it would not terminate the arRPC server would capture even the proprietary discord RPC (I believe)
humble mortar
Hi. Does the discord's game sdk's RPC work for you on Vesktop linux?
Upon starti...
your program is trying to xdg-open the discord protocol and when it throws that error its exiting
the error is pretty self explanatory
idk if flatpak is shipping a broken desktop file or something modified it but yeah
quasi spear
the error is pretty self explanatory
contains supported protocols but doesn't use %u or %U in its Exec line! This is inconsistent. isn't clear to me
humble mortar
the desktop file has an x-scheme-handler defined but doesnf have %u in the exec line
%u is a placeholder that would contain the data from the scheme
https://github.com/flathub/com.discordapp.Discord/pull/391
looks like they added the scheme to the desktop file without adding %U in the exec line
open an issue there
quasi spear
The issue happens with Vesktop, though, not discord's client
humble mortar
open an issue there
it works from the browser because they only look for the scheme handler and do their own magic
vernal lintel
The issue happens with Vesktop, though, not discord's client
vesktop doesnt support discord protocol yet tho
humble mortar
The issue happens with Vesktop, though, not discord's client
yes but your error is happening because of that
quasi spear
vesktop doesnt support discord protocol yet tho
Do you see activity on my profile rn? If so, game sdk RPC works with vesktop on macos, which I find strange.
humble mortar
vesktop supports game rpc
vernal lintel
vesktop supports rpc via websocket or unix socket via arrpc
humble mortar
your program is calling xdg-open and is exiting cause of that error
vernal lintel
but thats different from launching protocol
why r u even calling protocl is that even part of discord_rpc
humble mortar
nop
quasi spear
I am just executing the sdk's functions https://github.com/ZirixCZ/cmus-rpc-c/blob/master/main.c#L115
sour muralBOT
I am just executing the sdk's functions https://github.com/ZirixCZ/cmus-rpc-c/bl...
main.c: Line 115
activity_manager->update_activity(activity_manager, &activity, NULL,
¯_(ツ)_/¯
fix the .desktop by adding the %u or remove the scheme handler entry so it silently fails
I guess it's calling that so the client automatically opens or something??
vernal lintel
vesktop is built on top of [...]
what?
quasi spear
It was just a misunderstanding from my side 😅
quasi spear
open an issue there
Why did you suggest creating an issue there. Did you interpret that the issue is with the flatpak discord and not with vesktop at that time?
humble mortar
that error log you see is with the discord Flatpak
the file path is the flatpak's desktop
either way I assume youre doing something wrong initializing the SDK as every other implementation ive seen use it doesnt have this behaviour
quasi spear
either way I assume youre doing something wrong initializing the SDK as every ot...
https://discord.com/developers/docs/developer-tools/game-sdk#activities
i followed the official docs on activity management
perhaps they used discord-rpc https://github.com/discord/discord-rpc
i know that some projects use it, but it has been deprecated
hybrid fjord
Happy new year guys!!
quasi spear
happy new year
quasi spear
that error log you see is with the discord Flatpak
About our yesterdays convo - this fixed it, you were right.: https://github.com/flathub/com.discordapp.Discord/commit/d118c0b57b5497ec6138a35a2b6125424f17e31f
simple groveBOT
humble mortar
ah what a great way to start the new year
simple groveBOT
simple groveBOT
simple groveBOT
you get logs by running vesktop from the command like
simple groveBOT
simple groveBOT
simple groveBOT
humble mortar
I'm gonna lose it
simple groveBOT
sudden trout
what the fuck
humble mortar
literally huhh
humble mortar
@vernal lintel @sly cairn buhh
sly cairn
sec
woeful current
woeful current
what the fuck
least insane github user
sly cairn
reported and bannedf
humble mortar
I was gonna report but github couldn't figure out mobile formatting 😭
you are unsane
carmine drum
sly cairn
vee needs to do that
sly cairn
yeah this is why i really dont like vencord being separate from the org because our org settings dont apply
i get why vee wants it like that but its really annoying at times
- we cant cross-transfer issues between main and subrepos
simple groveBOT
simple groveBOT
vernal lintel
@humble mortar discord has an endpoint for fetching deltas https://github.com/OpenAsar/arrpc/pull/130
you can fetch that instead
see how the desktop client does it
but I think ducko said in the past that they don't want to dynamically fetch it
we really should just make our own thing, preferably natively so we can stop with the horrid shell sub processes
humble mortar
see how the desktop client does it
how do I see that? extract from the asar?
humble mortar
but I think ducko said in the past that they don't want to dynamically fetch it
hm
maybe for now we have a fork with some of the changes we'd prefer
could do proper streamer mode stuff with that too
I wonder if theres existing native implementations
humble mortar
I wonder if theres existing native implementations
theres like 3 rust ones at varying levels of parity with arrpc
and one in python
https://github.com/SpikeHD/rsRPC/tree/main looks the most compatible but doesnt implement a few things
rust seems so overkill for something like this though
vernal lintel
how
simple groveBOT
simple groveBOT
simple groveBOT
Discord Account
naczo.
Operating System
Windows 11
Linux Only ~ Desktop Environment
No response
Package Type
Setup exe
What happens when the bug or crash occurs?
If I have 2 accounts logged in in my discord app, when I put my pc to sleep for a while I come back to this screen. When i restart the app I am logged out from one of the accounts, that i was using at that moment.
...
simple groveBOT
simple groveBOT
if you close vesktop with the close button or Alt+F4, it only hides the window but still remains running in the background. if you want to fully close it, use Ctrl+Q
Alternatively, if you don't want the background behaviour at all, disable it in the Vesktop settings.
humble mortar
what the hell is ultramarine linux
humble mortar
i can actually replicate this in my vms (win 11 and 10)
something is exploding with the intro settings select
humble mortar
yeah it works for me too (linux)
grizzled hemlock
@humble mortar have you ever encountered a vesktop bug where datastore / indexeddb just hangs
humble mortar
nup
vernal lintel
<@721853658941227088> have you ever encountered a vesktop bug where datastore / ...
do u launch multiple instances
grizzled hemlock
do u launch multiple instances
never
humble mortar
guh only errors that happen are the same
except the linux one errors but doesnt implode
maybe platform difference guhh
am i gonna have to add logging with notepad on windows
what if i smb share
humble mortar
ok
it seems to be a platform implementation difference on how electron figures out conflicting window settings
sour muralBOT
https://github.com/Vencord/Vesktop/blob/6c4ecc0d64a843ec942b4fa645c0bfe617b21257...
firstLaunch.ts: Lines 29-36
const win = new BrowserWindow({
...SplashProps,
frame: true,
autoHideMenuBar: true,
height: 470,
width: 550,
icon: ICON_PATH
});
removing frame: true or adding transparent: false fixes it
SplashProps has frame: false and transparent: true
hot juniper
holy "why isn't NoDevToolsWarning enabled by default" again
woeful current
wait until he finds out discord has been detecting client mods since ages
hot juniper
~~wait until he finds out discord has been detecting client mods since ages~~
did bro forget about the notrack change recently
sour muralBOT
noTrack.ts: Lines 64-72
find: ".BetterDiscord||null!=",
replacement: {
// Make hasClientMods return false
match: /(?=let \i=window;)/,
replace: "return false;"
}
}
],
humble mortar
I'm gonna lose it
archwiki has a very good chromium hardware accel entry
explains everything and how to trouble shoot
exploodee
vernal lintel
then comment :p
simple groveBOT
humble mortar
discord desktop doesnt use chromium's webrtc right
simple groveBOT
humble mortar
ok ive done some testing and it seems as soon as electron starts encoding with gpu the stream explodes
perfectly describes the behaviour theyre mentioning
is this a chromium regression or something
can't stream to older clients with hardware acceleration
I can stream hardware accelerated just fine to myself from vesktop to latest chromium
but older and it explodes
stark falcon
vernal lintel
AYOOOOOO
vernal lintel
🇷🇴
hot juniper
this is brilliant
simple groveBOT
floral ledge
@scenic hollow enjoy https://github.com/tuxinal/venbind/pull/2 https://github.com/tuxinal/Vesktop/pull/1
I also had some auxiliary questions:
- Why use node-bindgen instead of napi-rs, which is significantly better documented and has a lot more usage? Notably, it would also solve the Electron headache, as support is builtin
- Is anything blocking https://github.com/tuxinal/venbind/pull/1, which is pretty much the only blocker for good Windows/Linux support after my PR?
scenic hollow
I also had some auxiliary questions:
- Why use node-bindgen instead of napi-rs, ...
hi thank you for the pr!!
i don't remember exactly why i chose node-bindgen i think it was easier to make the functions on the rust side be async with node-bindgen than napi-rs (although i think i didn't even end up using async because i didn't know how to make the dispatch_proc function yield properly or smth like)
the main issue with xdg rn was that there is basically nowhere we can test things properly cause something is broken either with kde's portal implementation or ashpd's way of handling sessions. otherwise the pr is basically ready to merge
quite honestly i completely forgot about this lmao
scenic hollow
hi thank you for the pr!!
i don't remember exactly why i chose node-bindgen i th...
oh also i haven't chosen a license for venbind yet i thought it might be a better idea to do that before merging stuff
vernal lintel
we love alpha distros
humble mortar
bwaa
humble mortar
i will use github editor to make pr
vernal lintel
well actually
vernal lintel
first launch tour overrides frame to true
humble mortar
is the splash not its own window
floral ledge
hi thank you for the pr!!
i don't remember exactly why i chose node-bindgen i th...
god I had fun trying to use breakpoints in the dispatch proc before
it was such a bad idea I swapped to println
vernal lintel
is the splash not its own window
it is
anyway trans and frame should work together
only resizable doesnt work
try adding resizable: false instead
floral ledge
hi thank you for the pr!!
i don't remember exactly why i chose node-bindgen i th...
what happens with testing w/xdg that's broken also
vernal lintel
actually it should already be set
humble mortar
what happens with testing w/xdg that's broken also
only kde fully implements it and theres some awkwardness there
floral ledge
only kde fully implements it and theres some awkwardness there
specifically global shortcuts api?
vernal lintel
is this related maybe https://github.com/electron/electron/issues/41063
floral ledge
arch wiki would have me believe hyprland xdg portal has fine global shortcut support
floral ledge
https://wayland.app/protocols/hyprland-global-shortcuts-v1
global shortcuts portal "yes" on arch wiki unless they don't actually have it and you have to use separate protocol?
surely not
humble mortar
link me
humble mortar
make a comment on the pr and ill test when i have a chance
humble mortar
global shortcuts portal "yes" on arch wiki unless they don't actually have it an...
ok seems youre right https://wiki.hyprland.org/Configuring/Binds/#dbus-global-shortcuts
must be new
this is actually good
simple groveBOT
simple groveBOT
humble mortar
@scenic hollow do u know what the preferred_trigger syntax is
scenic hollow
humble mortar
Ah i was doing Ctrl+
its CTRL
its returned as a string of Ctrl
truely the best api ever
i have a working demo app in python now
scenic hollow
i think it works fine if it's all lowercase also?? pretty sure that's what i did at some point
humble mortar
its def ashpd
scenic hollow
i have a working demo app in python now
with a consistent session token?
humble mortar
yep
handle_token is what changes
but it can be consistent too
as long as you dont create new interfaces without closing the previous
/org/freedesktop/portal/desktop/request/1_295/demo_1
Session created: /org/freedesktop/portal/desktop/session/1_295/vesktop
/org/freedesktop/portal/desktop/request/1_295/demo_2
dbus.Dictionary({dbus.String('shortcuts'): dbus.Array([dbus.Struct((dbus.String('shortcut2'), dbus.Dictionary({dbus.String('description'): dbus.String('Demo Shortcut 2', variant_level=1), dbus.String('trigger_description'): dbus.String('', variant_level=1)}, signature=dbus.Signature('sv'))), signature=None), dbus.Struct((dbus.String('shortcut1'), dbus.Dictionary({dbus.String('description'): dbus.String('Demo Shortcut 1', variant_level=1), dbus.String('trigger_description'): dbus.String('Ctrl+1', variant_level=1)}, signature=dbus.Signature('sv'))), signature=None)], signature=dbus.Signature('(sa{sv})'), variant_level=1)}, signature=dbus.Signature('sv'))
Shortcuts bound successfully:
shortcut2:
Description: Demo Shortcut 2
Trigger:
shortcut1:
Description: Demo Shortcut 1
Trigger: Ctrl+1```demo_1 registers everything and creates the session which has the app name
demo_2 listens for the shortcuts and changes
scenic hollow
with a consistent session token?
i've just emailed the guy responsible for the kde impl again about whether it's supposed to be consistent or not just to make sure
humble mortar
scenic hollow
oh those are different 
humble mortar
session_handle_token is the app id
vesktop or dev.vencord.Vesktop (dev_vencord_Vesktop)
scenic hollow
wdym it's the app id? you mean it gets appended to the app id?
cause that's not what i'm seeing
we went over this at some point didn't we
humble mortar
its what kde uses for the name and app icon in the settings menu
OHH
i see yeah
thats a flawed implementation yeah
it pulls the icon from the desktop file of the same name
but since you need to replace . with _ it doesnt find a demo_app.desktop when it should be looking for demo.app.desktop
so thats a bug but other than that it works
also it returns the bound trigger as the preferred trigger irregardless if it conflicts with an existing bind
i guess calling listshortcuts intsead of relying on what it returns would fix that
scenic hollow
```$ python main.py
/org/freedesktop/portal/desktop/request/1_295/demo_1
Sess...
can i have your python script perhaps
humble mortar
yeah let me clean it up
scenic hollow
@humble mortar can i also have your .desktop file
scenic hollow
wdym it's _the_ app id? you mean it gets appended to the app id?
so what confused me here was that i thought the app id is taken from the .desktop file but apparently not???
simple groveBOT
humble mortar
@scenic hollow sorry i got pulled away by family
humble mortar
<@721853658941227088> can i also have your .desktop file
why?
theres nothing specific about it
anyway since its def a client implementation issue not KDE maybe close that issue
the icon thing tho def needs an issue
all flatpak apps won't have an icon
:p
also in an actual implementation make sure shortcut ids are prefixed and overly specific to prevent any sort of clash
simple groveBOT
floral ledge
i've just emailed the guy responsible for the kde impl again about whether it's ...
I can take over the XDG PR if that guy is inactive by the way
i am keenly interested in getting this into vesktop and have free time
scenic hollow
i don't think there is anything else to be done on the xdg pr itself
floral ledge
i don't think there is anything else to be done on the xdg pr itself
just testing?
scenic hollow
anyway since its def a client implementation issue not KDE maybe close that issu...
i still doubt that. i think you are using the session handle token wrongly. even if it is consistent it definitely isn't supposed to be the app id.
the app id is supposed to be inferred from elsewhere (i assumed it would be the .desktop file but idk about that anymore) and then used in this componentName function: https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/blob/master/src/session.h?ref_type=heads#L188 which is used for figuring out the name used in KCM. and here you'll see it's the session handle token appended to the appId. the way you have it set up there is no appId and the session handle token alone just happens to match the .desktop file and so it even fetches the correct icon.
i think we should figure out where the app id is supposed to come from and make a pr to the kde portal
sour muralBOT
i still doubt that. i think you are using the session handle token wrongly. even...
session.h: Line 188
return m_appId + m_token;
yeah kinda that's kinda blocked by the whole xdg thing
floral ledge
whats the issue though
scenic hollow
this in short https://bugs.kde.org/show_bug.cgi?id=492992
floral ledge
cant i just go test it on my hyprland on my framework laptop
lmaoo
surely xdg-desktop-portal-hyprland is fine
scenic hollow
yeah you could try that
floral ledge
this in short https://bugs.kde.org/show_bug.cgi?id=492992
also this suggests it Works its just KDE's settings panel being busted
scenic hollow
yeah that's what i'm assuming but cowokie says that it's supposed to be that the session is consistent so kde doesn't make a new item for every run
the rust library we use doesn't really support setting the session directly tho
and i've asked the ashpd people about it and they say you aren't supposed to do that https://github.com/bilelmoussaoui/ashpd/issues/231
floral ledge
how is a consistent session possible
you're not supposed to keep a consistent session across several runs no?
thats why its a "session"
scenic hollow
yeah that would make sense too idk
scenic hollow
the kde one or the ashpd one?
floral ledge
if i have 2 instances of a program open then I would think the shortcuts would conflict
kde one
scenic hollow
except sessions aren't instances. i wouldn't really want it to reset my shortcuts after i restart vesktop
floral ledge
You save the shortcuts in the discord settings
they get reregistered
If you want to edit the shortcut keys from kde control panel then the changes wont be reflected in discord settings without special work and you'll have a conflict
Unless the issue is that it stays there even after the session is closed
which looking at your bug report it seems like you close the session
scenic hollow
Unless the issue is that it stays there even after the session is closed
yeah basically that
scenic hollow
If you want to edit the shortcut keys from kde control panel then the changes wo...
they get reregistered under a different name. you can't modify the existing old ones. and the one from last session sticks around so every time you start a new session and vesktop registers shortcuts you get conflicts and you have to delete the old one and make sure the new one has all the shortcuts active.
floral ledge
You're going to have to add IPC for key changes right
so that discord settings change to match
(thats another issue)
looks like receive_shortcuts_changed exists in ashpd
scenic hollow
oh yeah maybe that's another issue tho not too concerned about that rn
floral ledge
they get reregistered _under a different name_. you can't modify the existing ol...
So do the shortcuts physically not work
or just a control panel display issue
scenic hollow
yeah they are conflicting they don't fully register
floral ledge
Does literally no one use this api how has this never popped up before
scenic hollow
YEAH I GENUINELY DON'T KNOW
maybe no one has used it through ashpd and everyone just keeps supplying a static session token
floral ledge
I guess REALLY no one does because kde devs have let the bug report sit there for 4 months
Either that or no one uses ashpd global shortcuts
scenic hollow
probably that
floral ledge
probably that
why the hell does ashpd not provide options in create_session
scenic hollow
and i've asked the ashpd people about it and they say you aren't supposed to do ...
apparently you aren't supposed to changed it yourself
floral ledge
Not even true
Part of it is yeah
the TOKEN bit
where is the SENDER unique name from
scenic hollow
dbus stuff
idk exactly where but dbus handles that
still tho i think it's more of a kde issue than an ashpd issue
floral ledge
idk exactly where but dbus handles that
Yeah i checked the bus implementation handles it
ashpd zero fault here
Spec conforming!!
Now i really don't know how this hasn't been reported before you
scenic hollow
again people probably just used a consistent session handle token to get around it
scenic hollow
**session.h:** Line 188
```h
return m_appId + m_token;
```
i've emailed the guy responsible for the kde impl about this i think just removing m_token from here should fix it. i've also asked about if the session token is supposed to be consistent or not let's see what he says
floral ledge
i still doubt that. i think you are using the session handle token wrongly. even...
What an anticlimactic fix
scenic hollow
YEAH TOOK ONLY LIKE 4 MONTHS
floral ledge
I wonder if no one follows the spec and thats why its gone unnoticed
Because its clear as day
Unique and unguessable
Literally put a random number in there
That is what the spec says
scenic hollow
ok but idk if it's supposed to be random per session maybe just a random number for one time is enough
floral ledge
That is dumb and makes no sense
scenic hollow
which is the same as having it be static i guess
floral ledge
The SENDER unique name should be the thing that is static
That's what identifies the app
The TOKEN is a session identifier per-session
Why should client apps have to save a random token number somewhere to be able to run dbus sessions properly
Or hardcode one
which the spec says not to do
scenic hollow
The SENDER unique name should be the thing that is static
i think the sender is actually just another random per session thingy
floral ledge
I wonder if that's in the spec for security reasons given the "unguessable" bit
floral ledge
i think the sender is actually just another random per session thingy
how does kde identify the app then
scenic hollow
by appId
floral ledge
does dbus give the app id over
floral ledge
i think the sender is actually just another random per session thingy
this would seem to be true
not sure why the xdg spec is so unclear
floral ledge
i think the sender is actually just another random per session thingy
I have looked into it and you are not insane
sour muralBOT
https://github.com/flatpak/libportal/blob/08c86829ad92d417ffd760f91af3ba9e2f7c52...
inputcapture.c: Line 350
g_variant_builder_add (options, "{sv}", "handle_token", g_variant_new_string (token));
ok then why has no one reported this!!!!
floral ledge
its definitely a kde issue
floral ledge
ok then why has no one reported this!!!!
sour muralBOT
https://github.com/canonical/xdg_desktop_portal.dart/blob/c4763d315e91b43df600bc...
xdg_desktop_portal_client.dart: Lines 145-153
String _generateToken() {
final random = Random();
String token;
do {
token = 'dart${random.nextInt(1 << 32)}';
} while (_usedTokens.contains(token));
_usedTokens.add(token);
return token;
}
Used for handle_token and session_handle_token
Every single xdg dbus implementation uses a random string
Just like the spec says
Either every implementation is wrong or kde is broken
I am not inclined to believe the former
sour muralBOT
https://github.com/bilelmoussaoui/ashpd/blob/master/src/desktop/handle_token.rs#...
handle_token.rs: Lines 39-49
impl Default for HandleToken {
fn default() -> Self {
let mut rng = thread_rng();
let token: String = (&mut rng)
.sample_iter(Alphanumeric)
.take(10)
.map(char::from)
.collect();
format!("ashpd_{token}").parse().unwrap()
}
}
ashpd is similarly correct
scenic hollow
omfg guess what the guy responsible for the kde implementation is doing https://github.com/aleixpol/mumble/blob/work/xdp-support/src/mumble/GlobalShortcut_xdp.cpp#L65
sour muralBOT
omfg guess what the guy responsible for the kde implementation is doing https://...
GlobalShortcut_xdp.cpp: Line 65
{ QLatin1String("session_handle_token"), "Mumble" },
Okay well not only that I am staring at the hyprland implementation and I am thinking it probably also wont work correctly
I havent tested it yet but
m_vSessions.emplace_back(std::make_unique<SSession>(appID, requestHandle, sessionHandle)).get();
I figure nothing removes it from m_vSessions whenever the session is closed
The stuff inside the SSession is freed at least
But the SSession lives forever in this vector
scenic hollow
i don't think it's supposed to be removed it should just reuse the old one and not make a new one every time
floral ledge
It doesnt reuse the old one
is the issue
it just emplaces back a new one every time
even if it has the same app id
So this would cause same issue as KDE
You can't even circumvent with the same session handle
because any new session with the same app id would do it
you'd have to change the app id every time
which you can't do
scenic hollow
guhh could you perhaps test that and make sure
floral ledge
guhh could you perhaps test that and make sure
Okay actually I think it should still work
actually it wont getShortcutById will find a dead shortcut
Very unfortunate
I can give it a shot ig
This API is such a mess and it has been a part of the xdg spec since September 2022
linux desktop development actually doomed
floral ledge
omfg guess what the guy responsible for the kde implementation is doing https://...
also of course this guy is using a const string
even better part hes using a const string where the spec explicitly says it should be random
floral ledge
guhh could you perhaps test that and make sure
I didnt boot into arch for like a week so my sddm is broken and cant login to hyprland through uwsm
and it refuses to login by fingerprint
True peak
Time to fix allat
scenic hollow
and that's why i use nixos 
(i am miserable)
floral ledge
and that's why i use nixos <:SunglassesFluent:1236500617954983956> (i am miserab...
Apparently it was a rogue monitor in my hyprland config
from when I had another monitor plugged in
Apparently that managed to fry sddm to the point of fully hanging at shutdown and forcing power off
gg
I for one am impressed
floral ledge
guhh could you perhaps test that and make sure
I have a ryzen 5 3600 on my main pc and a ryzen 9 7940hs on the framework laptop
aka double the speed
and 2 more cores
I am now very sad that I was not working on venbind on it instead of the main pc because it compiled all of the dependencies in 6 seconds
scenic hollow
you can also get this might be slightly easier to set up https://github.com/tuxinal/kde_xdp_bugreport
floral ledge
you can also get this might be slightly easier to set up https://github.com/tuxi...
totally forgot i was just gonna compile this
whoops
floral ledge
you can also get this might be slightly easier to set up https://github.com/tuxi...
compiled in 16 seconds
let me compare with main pc
floral ledge
guhh could you perhaps test that and make sure
The session doesnt even work
Which i find hilarious
Oh
The appid is fucking empty
no wonder its breaking
i need a .desktop file for this or whatever
it comes with one!
the app id is still empty
unless gtk-launch doesnt work with this
simple groveBOT
floral ledge
the app id is still empty
I hate xdg desktop portal so bad
This is one of the worst documented apis i've ever worked with
Have to just go dig through the c files to figure out whats going on
scenic hollow
The appid is fucking *empty*
yeah idk how youre supposed to specify the app id i used to think it was a .desktop file (maybe it actually was???) but that doesn't work anymore