#🖥-vesktop-development
simple groveBOT
vernal lintel
like
echo "${{ secrets.APPLE_API_KEY }} > apple.p8
pnpm electron-builder --${{ matrix.platform }} --publish always
sly cairn
dumping secrets straight into run
vernal lintel
whar?
sly cairn
echo "${{ secrets.APPLE_API_KEY }}" > apple.p8
it makes github display it into the runner log
which does get starred publicly but
still not a good idea
vernal lintel
but also it censors it
vernal lintel
like
echo "$APPLE_API_KEY" > apple.p8
pnpm electron-builder --${{ matrix.platform }} --publish always
yeye
vernal lintel
idk why i was using the secret directly
sly cairn
okay attempt 2
sly cairn
with 1.5.4 thi
vernal lintel
env var doesnt expand into the full secret
even the secret access would be censored in the log tho
simple groveBOT
sly cairn
oh hey
it did it
okay let me get it to publish a 1.5.4 release and get a maccer to try it
vernal lintel
GitHub release not created reason=existing type not compatible with publishing type tag=v1.5.3 version=1.5.3 existingType=release publishingType=draft
• skipped publishing file=Vesktop-1.5.3-universal.dmg.blockmap reason=existing type not compatible with publishing type tag=v1.5.3 version=1.5.3 existingType=release publishingType=draft
• skipped publishing file=Vesktop-1.5.3-universal.dmg reason=existing type not compatible with publishing type tag=v1.5.3 version=1.5.3 existingType=release publishingType=draft
sly cairn
ye
sly cairn
o oki
vernal lintel
yop that's good
make sure u cancel the existing workflows so we don't get 3 million releases xd
vernal lintel
if deleting the tag doesn't cancel automatically
vernal lintel
what
⨯ Unexpected token 'E', "Error: The"... is not valid JSON failedTask=build stackTrace=SyntaxError: Unexpected token 'E', "Error: The"... is not valid JSON
SyntaxError: Unexpected token 'E', "Error: The"... is not valid JSON
at JSON.parse (<anonymous>)
at
fire
I think the notarization api returned an error string
vernal lintel
and electron builder is trying to parse as json
vernal lintel
> The executable does not have the hardened runtime enabled.
why would it fail now but not before
sly cairn
they all start with the
sly cairn
nothing i can see
it would be on app store connect if anything but there doesnt seem to be a page for notary
okay well
easiest thing to try
is just do it again
vernal lintel
they fixed it some months ago
try to update that dependency to the latest version
sly cairn
do you just want me to update electron builder
vernal lintel
Also someone suggested this site https://appstoreconnect.apple.com/business
vernal lintel
do you just want me to update electron builder
idk if that'll have the update
I would just update specifically that package to the latest version
the notarize one
vernal lintel
Also someone suggested this site https://appstoreconnect.apple.com/business
apparently there are some agreements there that u have to accept
sly cairn
Also someone suggested this site https://appstoreconnect.apple.com/business
not sure why cuz that's just the agreements that i've already signed
sly cairn
I would just update specifically that package to the latest version
can i even do that because of pnpm?
vernal lintel
`pnpm add -D @electron/notarize@latest`
or there might be a better command that won't add it as an explicit dep
vernal lintel
xd
sly cairn
its still chugging along
sly cairn
took it long enough
oh wait what
it bumped electron
wtf
okay
sure
whatever
if it works it works
it didnt do it
ffs
ok fine i'll just use the electron builder alpha
i fold
vernal lintel
it bumped electron
lmao you bumped everything
sly cairn
OH WAIT WHAT
vernal lintel
I mean that's alright too
sly cairn
echo "$API_KEY" > apple.p8about:blank#blocked
what's the crap???
HOW'D THAT GET IN THERE
WTF
vernal lintel
LMAOOO
vernal lintel
HOW'D THAT HAPPEN
vernal lintel
are u editing with web editor??
vernal lintel
did u drag a tab into ur vscode??
sly cairn
i might've done by accident
whilst i was trying to do something
and i didnt realise
vernal lintel
omg ahahaha
sly cairn
sly cairn
lmfao
vernal lintel
I pasted some random junk into vencord.dev css
and we had it in prod for ages
without noticing
sly cairn
lmaooo
vernal lintel
sly cairn
lol???
vernal lintel
somehow it didn't cause any errors or issues so I just didn't notice
vernal lintel
CAUSE
sly cairn
funniest bug
vernal lintel
basically anything can be a css class
so ig that's why it just worked
I don't think there is any limit to which characters you can use in a css class
you just have to escape some chars
I noticed discord started using / in some of their css classes
so good
vernal lintel
thanks lewi 
once tauri installer release we'll also have to look into notarization for that but it shouldn't be any harder with https://tauri.app/v1/guides/distribution/sign-macos/
yeah it's exactly the same
just have to set env vars
sly cairn
can probably just use the same api key and certificate
upper pine
once tauri installer release we'll also have to look into notarization for that ...
what's gonna use tauri?
vernal lintel
installer rewrite
next sundial
installer rewrite
next vesktop version:
simple groveBOT
seems to be a flatpak issue.
Top one is flatpak, bottom one is rpm
simple groveBOT
hybrid fjord
<@242305263313485825> just got the tray stuck as muted somehow
I'll take a look
hybrid fjord
<@242305263313485825> just got the tray stuck as muted somehow
it was in call or outside call?
humble mortar
it was in call or outside call?
was in a call streaming & watching a stream, muted the entire time. was messing around with my quick css, did a ctrl+r rejoined the call still muted and eventually left the vc and noticed the icon didnt change back to normal
writing this out it prob had something to do with the reload
hybrid fjord
yeah looks like on ctrl+r disconnect event not called and vesktop still thought that you're in call
sly cairn
tbf #420 was closed without a proper resolution, even if it's because the flag wasnt being passed properly
let me see if its because of the wrapperscript
vernal lintel
tbf #420 was closed without a proper resolution, even if it's because the flag w...
that was fixed ages ago
and people were still complaining
vernal lintel
if you pass the flag and it doesn't work then it's not our problem
sly cairn
so its an issue with the flatpak
wonder if i can just pass it as part of the default flagset
vernal lintel
I wouldn't
sly cairn
it seems like it just noops if there's no ime available or it's not needed, and only issue i can find with it was because electron forgot to cherrypick a bugfix which they added in 23
but eh
vernal lintel
there's gonna be a reason why it's a flag and not enabled by default
and people should be able to do basic googling to find that flag
alao
that issue states it only doesn't work in flatpak
which means it has nothing to do with the flag
just a flatpak runtime issue if anything
sly cairn
actually
vernal lintel
which once again we can't fix (I think)
sly cairn
it's probably a hyprland issue lol
both issues filed were related to hyprland and one of them pointed out it probably is just hyprland not playing nice with IMEs
vernal lintel
anyway while I don't know any details, I do know that it's not our issue™
vernal lintel
sly cairn
😭
i wish we could also just update chromium by our own will
but we cant
also switching to a fresh new stable of chromium, even if it has been beta tested for ages, is kind of a death sentence
there are bound to be lots of bugs relating to the new features
humble mortar
how about vesktop but built on a non chromium web technology
vernal lintel
nop
upper pine
IME support on linux has always been quite crappy tbh
IME should be done by the ide (and or) widget framework
simple groveBOT
simple groveBOT
can't reproduce and you're the only one experiencing this. try again on an official release.
humble mortar
is it just me or is scrolling in vesktop a LOT more laggy/jittery vs normal web
hybrid fjord
is it just me or is scrolling in vesktop a LOT more laggy/jittery vs normal web
most stable electron release
humble mortar
most stable electron release
its been like this for forever 😭😭
sly cairn
i would be worried if your immutable operating system lets you write to the immutable store
hot juniper
i would be worried if your immutable operating system lets you write to the immu...
afaik nixos isnt immutable in that sense (and doing something like that would result in Ubuntu Core)
if it is possible then permissions issue
sly cairn
/nix/store is immutable
humble mortar
was buddy using dkms without headers
hot juniper
how do you even use dkms without headers
simple groveBOT
hybrid fjord
wha
hot juniper
100% chromium exploded
simple groveBOT
Discord Account
No response
Motivation
I hate ads and dislike popups from Discord asking me to buy things, especially sponsored things.
Solution
Add an option to block the Shop and nitro buttons, along with popups.
Alternatives
N/A
Additional context
No response
Request Agreement
- [X] I have searched the existing issues and found no similar issue
- [X] This is...
hybrid fjord
Looks like a plugin request for me
simple groveBOT
vernal lintel
still don't understand why people care
why does it matter if you show up as web or desktop
humble mortar
why does it matter if you show up as web or desktop
because showing up as desktop explicitly means youre on your pc
hot juniper
because showing up as desktop explicitly means youre on your pc
ok and
you dont even understand the consequences of showing that status
humble mortar
you dont even understand the consequences of showing that status
what are they then
hot juniper
is that just ua spoof issue only
imo this is something that should be opt in
with a huge disclaimer
hot juniper
because showing up as desktop explicitly means youre on your pc
i still dont get this. why do you expect web status to be separate
humble mortar
i still dont get this. why do you expect web status to be separate
web can mean on your phone or your vr headset 💀 desktop on the other hand means u are available to play games/other desktop activities
hot juniper
hm true
humble mortar
with a huge disclaimer
a disclaimer saying what
hot juniper
a disclaimer saying what
warning this feature overrides discord gateway packets (something Discord really does care about if you touch in a bad way)
something like that
humble mortar
im passing a valid option and not spamming it imo its safe?
hot juniper
your UA would like to have a word
hot juniper
no it will explode more
humble mortar
'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) discord/0.0.61 Chrome/124.0.6367.243 Electron/30.2.0 Safari/537.36'```
top is vesktop bottom is discord desktopi wodner if including Electron in the string would cause the vc issue u mentioned
hot juniper
you will put Electron/ in your user agent and you will find it will all explode
yes
that is exactly the issue
humble mortar
does discord serve something different to that agent
hot juniper
Yes
humble mortar
ah ok
"This does not spoof the user agent so if Discord decides they want to detect and block this they can"
ok warning?
hot juniper
make userplugin trol
vernal lintel
surely their spam detection is more sophisticated than that
well no
vesktop used to hardcode user agent to windows Chrome
when you were on non windows this would trigger captchas on various actions
the captchas immediately went away when I made it use correct user agent for your os
messing with identify props is a bad idea
humble mortar
<:blobcatcozy:1026533070955872337> make userplugin trol
userplugin just for vesktop Clueless
humble mortar
i mean atp just make any of the other platform spoofer plugins userplugins
this is just meant as a small patch for vesktop
humble mortar
messing with identify props is a bad idea
its very minimal and passes a valid option i dont see how it could go wrong
Many other vencord features are way more intrusive
humble mortar
NoTrack
compact frigate
humble mortar
any UA switcher would result in the same mismatch
humble mortar
really_shock changing the user agent is foolish????
vernal lintel
yes.
antispam has a goal: to stop spam
they don't care about anything else. they have no reason to flag people who don't send analytics because there's nothing spammy about doing so
but what could be flagged as spam is sending wrong device properties that make no sense cause no normal device will have those
amount of intrusion is irrelevant
what's relevant is making yourself look suspicious
topaz dove
identify and super props and user agent must all agree
vernal lintel
now i have no knowledge or data about whether sending discord desktop + web props is actually risky in practice but I do know that sending incorrect props in general is likely to lead to suspension
and considering that showing up on desktop instead of web is literally irrelevant, it's not worth the risk
topaz dove
and a token suddenly going from one platform to another could be suspicious
humble mortar
sending incorrect props in general is likely to lead to suspension
the prop is a valid option
humble mortar
and a token suddenly going from one platform to another could be suspicious
using any mobile browser and toggling the desktop site:
topaz dove
that stays as the web client
vernal lintel
literally nothing changes lol
it just uses different viewport
anyway there's little point discussing this further
the decision is final, it won't be added
humble mortar
that stays as the web client
it goes from mobile to desktop
humble mortar
the decision is final, it won't be added
oki doki
ill use it locally and if i explode i guess u can say i told u so lol
visual walrus
Why mess with user agent at all then? You could have a Vesktop-specific PlatformIndicators' feature to make other PlatformIndicators users see "desktop"
only'll work if that Vesktop user has PlatformIndicators enabled, but anyone who cares so much about the reported client would be doing that I think
compact frigate
not possible without an external api, which wont be done
upper pine
https://twitter.com/thexpaw/status/1818057235425014153
Nice
hybrid fjord
fast enough
vernal lintel
https://twitter.com/thexpaw/status/1817884882128761047 ????
this is probably why stream audio sounds awful on windows
I thought about this ages ago actually but I didn't end up looking into it
I don't remember why
simple groveBOT
Discord Account
No response
Operating System
Windows 10
Linux Only ~ Desktop Environment
No response
Package Type
Portable
What happens when the bug or crash occurs?
Same as https://github.com/Vencord/Vesktop/issues/501, but reporting as new issue with more details.
The window is set to a much smaller size on launch.
Before closing:
After relaunching:
cyan flame
i might be stupid but i noticed this was close due to being a duplicate but i can’t find the original one
https://github.com/Vencord/Vesktop/issues/697
vernal lintel
it already fixed
cyan flame
ik, but i can’t find the original post, the reason it was close
unless… it was deleted
arctic totem
#202
cyan flame
thx
topaz dove
> from palestine
scary
iirc israel blocks certain news sites and junk for siding with Palestinians
probably why they're using a vpn
humble mortar
iirc israel blocks certain news sites and junk for siding with Palestinians
not authoritarian at all Clueless
vernal lintel
please I don't wanna be rude but why do people spam so many duplicate issues while putting in 0 effort to read anything
literally the issue template tells you the solution to this issue
or if you spend 10 seconds searching issues you will find a dozen of existing issues
i am so tired
humble mortar
how does stock discord even detect it
hybrid fjord
how does stock discord even detect it
i almost wrote same xd
maybe something like arrpc detects processes
like loop every n seconds and checks for processes
hybrid fjord
yeah i think so
humble mortar
according to that thread on the discord flatpak it wouldnt work for vesktop flatpak which is annoying
wait does arrpc even work in the flatpak
hybrid fjord
ig yes
humble mortar
flatpak skill issue
humble mortar
iterates over /proc to find a process named "obs" ig
couldnt we just add this to the list the arrpc scans for and intercept obs process detection
easy cross platform solution wammo
humble mortar
arrpc has a detectable.json that we could just append obs entries to then intercept it
arrpc is already scanning running processes why write another implementation
hot juniper
i feel like if vesktop wants feature parity with official client then significant changes to arrpc would need to be made or even just migrated into vesktop itself
humble mortar
thats a whole other can of worms lmao
arrpc doesnt implement everything discord rpc does
hot juniper
hot take
humble mortar
its true 😭
hot juniper
this is a good thing, because at the same time i've also argued with vee that there are things vesktop implements that it actively shouldn't implement
vernal lintel
i feel like if vesktop wants feature parity with official client then significan...
that is actually planned
the current arrpc implementation is meh, shelling out is ugly and spawning shell processes every 5 seconds is bad
noah was talking about making a native module
hot juniper
i have an even hotter take
this shouldnt even be a Vesktop feature
discords own game detection is Ugly and Bad
hot juniper
no
hot juniper
I think Discord's own game activity detection algorithm sucks enough that we should not try to replicate it and we should build our own thing with more user controllable detection parameters
vernal lintel
i am not used to ducko without duck pfp
hot juniper
I think Discord's own game activity detection algorithm sucks enough that we sho...
Discord Desktop lets you add running processes by path and tbh thats kinda useless to the point where you need to keep adding stuff back
I want my own matching
humble mortar
ah the process scanning aspect of rpc
hot juniper
yes
its horror
well
it isnt entirely rpc anyway
but its still within scope
also I think certain RPC features should be able to be individually toggleable, such as invite deep links (this is what I argued with vee about a few months ago)
humble mortar
invite deep links?
hot juniper
idk if its a great description
humble mortar
the join game button?
hot juniper
you know how you open invites in the browser and they just say DISCORD APP DETECTED
i hate
humble mortar
ohhhh yeah
hot juniper
bonus if you are wayland user and as such no autofocus of discord window
humble mortar
cope simply alt tab
hot juniper
yes it is cope
hot juniper
i just want it to not open in the app until I ask it to
idk if its possible to error after the connection
this is super low priority though
hot juniper
the current arrpc implementation is meh, shelling out is ugly and spawning shell...
i never even discussed this part but yes this is 
humble mortar
vesktop overlay when though
hot juniper
vesktop overlay when though
dont fucking do it like official discord does though 🙏
vernal lintel
never
hot juniper
dont fucking do it like official discord does though 🙏
that was so buggy how it hooked into an app
hot juniper
if I want an overlay I just wanna know who's in my VC and what recent messages are sent (maybe?)
but theres also desktop notifications for that
humble mortar
if I want an overlay I just wanna know who's in my VC and what recent messages a...
cant work with vesktop cause arrpc doesnt implement the full rpc spec
hot juniper
how can i trust them that its blazingly fast if they have a website more bloated with animations thant discord
hot juniper
humble mortar
nah all issue
freedesktop doesnt have a standard overlay layer so electron is cooked and cant implement a propper always on top layer
hot juniper
ok maybe you're right
humble mortar
freedesktop doesnt have a standard overlay layer so electron is cooked and cant ...
Plasma has one tho which is nice
hot juniper
Yes but thats almost useless unless we want to patch electron or tauri ourselves
humble mortar
yepp
hot juniper
considering how global menus in chromium wayland will not come for another decade I dont think doing that is a good idea
hot juniper
considering how global menus in chromium wayland will not come for another decad...
no seriously at this point i think it is rightful corporate OSS bullying to say they are doing nothing
humble mortar
considering how global menus in chromium wayland will not come for another decad...
i think thats a gtk skill issue actually
hot juniper
i think thats a gtk skill issue actually
kde has it but its through DBus
humble mortar
its a kde only protocol
hot juniper
yes
humble mortar
theres a waytland one in the works tho
hot juniper
hot juniper
https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/52
good lord 3 years ago still open
i hate saying this but
is this GNOME devs have an issue with it
humble mortar
good lord 3 years ago still open
average wayland moment
hot juniper
average wayland moment
this is real
humble mortar
firefox has it merged and its in the works for 6.2 so i think gnome wont explode it
most on topic #🖥-vesktop-development convo
hot juniper
how often is #🖥-vesktop-development even on topic anyway
i should contribute more RPC support to vesktop but blehhhhhhhhhhhhhhhhhh i would barely use
dark quarry
@hot juniper I'm not the only one with the window position bug
hot juniper
oh?
dark quarry
vernal lintel
that's odd
dark quarry
yeah very odd
vernal lintel
can you tell me the contents of your state.json before and after normal quit (positions fine) and before and after reboot (position bug)
dark quarry
when I get home later I can
sour muralBOT
https://github.com/Vencord/Vesktop/blob/main/src/main/mainWindow.ts#L274-L279
mainWindow.ts: Lines 274-279
const storedDisplay = screen.getAllDisplays().find(display => display.id === State.store.displayid);
if (x != null && y != null && storedDisplay) {
options.x = x;
options.y = y;
}
it is entirely the storedDisplay check
vernal lintel
it might be that the id changes every reboot
dark quarry
yeah I removed && storedDisplay and everything works perfect
vernal lintel
but that'd have to be a change in either windows or chrome
vernal lintel
yeah I removed && storedDisplay and everything works perfect
oh why not say that
hot juniper
it might be that the id changes every reboot
i personally think it has something to do with the taskbar or something cursed like that
vernal lintel
hot juniper
HORROR
dark quarry
oh why not say that
I did in the discussion earlier :D
hot juniper
though your hypothesis sounds more accurate
dark quarry
I can also check monitor ids and stuff for you
hybrid fjord
from electron wiki:
idnumber - Unique identifier associated with the display. A value of of -1 means the display is invalid or the correct id is not yet known, and a value of -10 means the display is a virtual display assigned to a unified desktop.
so why it changes on reboot...
or should we add checks for -1 and -10
dark quarry
can you tell me the contents of your state.json before and after normal quit (po...
does it matter if I'm using the modified version with the && storedDisplay removed (no other changes)?
well, the displayid in state.json does change after reboot
before:
{
"firstLaunch": false,
"maximized": false,
"minimized": true,
"windowBounds": {
"x": 5,
"y": 335,
"width": 1572,
"height": 1057
},
"displayid": 1230121959,
"vencordDir": "C:\\apps\\git\\Vencord\\dist"
}```
after:
{
"firstLaunch": false,
"maximized": false,
"minimized": true,
"windowBounds": {
"x": 5,
"y": 335,
"width": 1572,
"height": 1057
},
"displayid": 4008604427,
"vencordDir": "C:\apps\git\Vencord\dist"
}
😭
hybrid fjord
electron explode moment
hybrid fjord
Can we somehow from anywhere from dbus get something really unique for display?
vernal lintel
Windows not Linux
hybrid fjord
Ooh my bad
humble mortar
that's odd
vernal lintel
not related
simple groveBOT
scenic hollow
FURRY CHILD TWERKING GIF
cyan flame
“I’m not homophobic”… proceeds to call being gay a sin (something homophobic people say)
marsh hinge
“I’m not homophobic”… proceeds to call being gay a sin *(something homophobic pe...
religion
cyan flame
religion
OK, and I’m Baptist. It’s still homophobia though. It’s just saying something homophobic then masking it out with “religion”.
marsh hinge
OK, and I’m Baptist. It’s still homophobia though. It’s just saying something ho...
religion is fucked anyways
cyan flame
religion is fucked anyways
agreed
marsh hinge
look at muslims like story or whatever
e.g. look at this reddit post
but eitherway should stop talking about it here
wary merlin
i love vee github comments
simple groveBOT
humble mortar
guh arrpc can't detect linux processes that dont have their path in the process
/usr/bin/obs would be detected but obs wouldn't
prob could patch I think
grizzled hemlock
Has anyone made any progress on global keybinds?
simple groveBOT
Discord Account
blusewill
Operating System
Arch Linux
Linux Only ~ Desktop Environment
dwm
Package Type
Flatpak
What happens when the bug or crash occurs?
When close the for a period of time and open it again. It will automatically logout.
What is the expected behaviour?
I expect it to be login all the time.
How do you recreate this bug or crash?
- Login in to...
humble mortar
Has anyone made any progress on global keybinds?
https://github.com/Vencord/Vesktop/pull/326 works but its not very user friendly
grizzled hemlock
https://github.com/Vencord/Vesktop/pull/326 works but its not very user friendly
Ty
simple groveBOT
humble mortar
chromium still uses pulse???
simple groveBOT
grizzled hemlock
is it just me or is this a stock discord issue
simple groveBOT
hybrid fjord
Issue will be closed in 3..
hybrid fjord
So that means that not a
problem with Vesktop
simple groveBOT
simple groveBOT
simple groveBOT
sly cairn
weirdest PR comment from someone who i've never seen on the repos before
simple groveBOT
hybrid fjord
i can add that easily
i already did it once but it got removed, i do not even remember what was the problem with them
humble mortar
number in the tray is too small to reasonably see
just use the badge on the task bar
scenic hollow
Has anyone made any progress on global keybinds?
i actually got the native part kinda working (only on x11 for now) a couple days ago
i have to package it properly and add it to vesktop then add support for the rest of the platforms
simple groveBOT
vernal lintel
hop off advertising ur fork
marsh hinge
hop off advertising ur fork
its literally just the users of it
they dont understand the fact that they dont need to go and advertise it everywhere
humble mortar
horror that fork literally just has that pr merged why is it 80 commits ahead
Also fwiw ive been running #517 & #686 for weeks now and havent had any issues I think theyre fine to merge
simple groveBOT
simple groveBOT
tired oak
I would like this to never happen again
vernal lintel
I would like this to never happen again
hey it's not ur fault dw
users gonna be stupid
nothing one can do
tired oak
that was my reaction when I saw nyx talking about it 
vernal lintel
i've also seen vencord users going into the BD server and starting shit
tired oak
lmao
vernal lintel
it's embarassing as hell 😭
marsh hinge
😭
marsh hinge
it's embarassing as hell 😭
thororen wants to say "hop on bettervencord"
tired oak
I would never
marsh hinge
hybrid fjord
does it really exists?
tired oak
hot juniper
thororen wants to say "hop on bettervencord"
is bettervencord even a thing
hot juniper
NO
brave tendon
Is anyone here having issues with arRPC? Can't detect any games on my machine with either the flatpak, rpm, or building from source. Probably a system issue but figured id ask in case its a broader problem
humble mortar
works for me def a system issue
simple groveBOT
I see. I've tried the AppImage version, and it works fine there. I'm okay with using the AppImage version.
The Flatpak version crashes every time, consistently between reboots.
Here are some more logs (blocked out any info I thought might be sensitive, let me know if you need them):
humble mortar
this is only an issue when launching from the terminal and its more of an annoyance
add the flag yourself
simple groveBOT
hybrid fjord
is there even a noticeable difference in latency between jack and pipewire
humble mortar
why the hell does discord web have a vc delay
hybrid fjord
as i understand it converts webrtc tracks to discord_voice and discord_voice to webrtc
simple groveBOT
vernal lintel
is that true
why is it so slow
we should reimplement it faster if that's actually why there's a delay
hybrid fjord
i may be wrong bc i may not understard all things 🙂 but seems logical to me
scenic hollow
i'm gonna leave this here while i try to figure out CI and put it on npm https://github.com/tuxinal/venkeybind
humble mortar
i'm gonna leave this here while i try to figure out CI and put it on npm https:/...
call it venbind not venkeybind please 🗣️🗣️
simple groveBOT
scenic hollow
call it venbind not venkeybind please 🗣️🗣️
nnnnooooooo
also i just found out libuiohook is dual licensed under gpl and lgpl
scenic hollow
i'm gonna leave this here while i try to figure out CI and put it on npm https:/...
am i currently commiting a crime with my ARR project or am i fine
i mean i'm gonna change it either ways but
vernal lintel
also i just found out libuiohook is dual licensed under gpl _and_ lgpl
wtf is the point
scenic hollow
i have no idea
vernal lintel
that's awesome but you really didn't need to trigger an email to 23 people with that
hybrid fjord
What's the problem with using one of the PR's branches
scenic hollow
i don't think either of them have the user friendliness that discord has
hybrid fjord
agree but least that something
if user in that need of some feature then why not use some workarounds
humble mortar
nnnnooooooo
you WILL change the name
it WILL be in line with venCORD venMIC and veskTOP
hybrid fjord
venbind actually sounds better)
humble mortar
i know!!!
small lionBOT
Alright @sly cairn, in 10 hours: upgrade winget releaser
shy veldt
mfw no image in discord embeds
humble mortar
flatpak file picker moment
scenic hollow
you WILL change the name
it WILL be in line with venCORD venMIC and veskTOP
i actually didn't think of that ok maybeee
small lionBOT
@sly cairn, <t:1723244889:R>: upgrade winget releaser
simple groveBOT
simple groveBOT
marsh solstice
you WILL change the name
it WILL be in line with venCORD venMIC and veskTOP
*ventop
next sundial
yo
discovered that Free Desktop specification has PrefersNonDefaultGPU as an option for .desktop files
may be interesting to add that for Vesktop's .desktop file
however
This key is only a hint and support might not be present depending on the implementation.
so not guaranteed to work
humble mortar
vesktop is supposed to be able to handle discord.gg invites right
I dont think its working
wait maybe firefox skill issue
yeah chromium opoens it correctly
seems firefox is only using discord:// to open stuff?
and not the arrpc websocket thigny
humble mortar
oh it was ublock gwuh
next sundial
vesktop is supposed to be able to handle discord.gg invites right
afaik vesktop doesn't handle discord:// protocol
at least for me it doesn't work on KDE (firefox does not signal to vesktop)
hot juniper
oh it was ublock gwuh
good
humble mortar
afaik vesktop doesn't handle `discord://` protocol
nono invites first attempt to connect via websocket which arrpc handles
if that fails it uses the uri scheme to open discord
hybrid fjord
Probably really
We used CLI commands just for ~not~ adding new dependency, but since dbus used in badges and i'm using it for getting accent color we can add this dep
Also it may be used in future as well
humble mortar
if the issue is gdbus not being installed everywhere we can use dbus-send
all the dbus libs are basically just wrappers
marsh solstice
oh it was ublock gwuh
maybe you have "block outsider intrusion into lan" (privacy category) list enabled?
simple groveBOT
simple groveBOT
hybrid fjord
Restart app????
azure verge
I assume their issue is a flatpak issue
hot juniper
I assume their issue is a flatpak issue
I didnt even read where it said it was flatpak and I knew it was flatpak
Flatpak and cursors = unfortunately
upper pine
works fine for me with some sandbox overrides
Suggest them :p
azure verge
grrrrr that's a good idea we don't do that around here lmfao one moment
I need to figure out what they are
simple groveBOT
azure verge
:)
vernal lintel
simple groveBOT
simple groveBOT
humble mortar
@hot juniper can u send me a link where discord:/// is used
vernal lintel
humble mortar
oh interesting theres /settings as well
settings arent an actual url though so if thats passed itd need to be sent to renderer and opened there?
humble mortar
how 🗣️
humble mortar
discord:///settings/account works but discord:///settings brings you to the default app landing page
discord hill issue ig
vernal lintel
it's really easy
go into ~/.config/discord and find the modules folder with discord_desktop_core in it
then rg --text setAsDefaultProtocolClient
it'll show you the asar file that has it
then you can extract it with the asar cli from npm
and it's just js files
humble mortar
discord:///settings/account works but discord:///settings brings you to the defa...
oh i read the gist wrong /settings isnt valid
wait guh discord doesnt even ship their .desktop as setup for discord://
humble mortar
no x-scheme-handler/discord
humble mortar
then `rg --text setAsDefaultProtocolClient`
returns nothing
humble mortar
in /opt/discord/ i get a wall of text with Discord 591921 at the start
humble mortar
the websocket handles that stuff no?
vernal lintel
right but it will still register the handler
humble mortar
ohhh you meant discord desktop and vesktop being open at the same time
i thought you meant vesktop being open then the protocol being called again
i think itll behave like any other uri conflict
ie os dependent
i dont see any special handling for discord:///
in normal use cases it shouldnt be called i dont think
humble mortar
ie os dependent
chrome and Firefox give an option for either
simple groveBOT
humble mortar
I'll look into a node lib later
dbus-send not being on immutable distros is an issue
@hybrid fjord what do you think?
hybrid fjord
probably lib would be better buuut what if we just instead of adding dep just write some lightweight module for vesktop which could do simple native dbus calls for our needs?
humble mortar
I do NOT want to deal with the dbus spec
vernal lintel
adding a heavy dbus library adds a lot of bloat and is kinda overkill if it's just gonna be used for one single call 😭
hence why cli is probably better
humble mortar
single call
theres also the accent call in the tray pr
hybrid fjord
adding a heavy dbus library adds a lot of bloat and is kinda overkill if it's ju...
yeah thats why i want just create some simple function in Vesktop which can do given dbus call and return what returned
humble mortar
and iirc theres another pr that did something with dbus
hybrid fjord
i can try to do it and then bake to vesktop if succeed
humble mortar
https://www.npmjs.com/package/node-dbus looks small as hell check if it works
humble mortar
someone should request feature
theres been an open feature request for what #686 does for forever 😭😭
vernal lintel
link
vernal lintel
look at venmic
humble mortar
venmic has prebuilt binaries that it copies node-dbus doesnt
vernal lintel
node-dbus literally uses native library
it's not possible without
actually maybe it might be idk
humble mortar
how horror is this
hybrid fjord
xd
vernal lintel
no
that's wrong
https://github.com/sidorares/dbus-native
seems like this uses pure js without native binary
humble mortar
what does native binary mean
humble mortar
https://github.com/sidorares/dbus-native
seems like this uses pure js without n...
seems its deprecated in favour of https://github.com/dbusjs/node-dbus-next
vernal lintel
says who
updated 2 weeks ago
deprecated in favour of library that hasn't been updated in years
what
humble mortar
theres dbus-ts last update a year ago
also some forks of dbus native that aren't on npm
humble mortar
simple groveBOT
humble mortar
@hybrid fjord did you look into a dbus library
hybrid fjord
yeah but decision whether add it as dep or not is up to V
humble mortar
which one did u think was the best?
hybrid fjord
which one did u think was the best?
dbus-native i think
humble mortar
dbus-native i think
theres a bazillion forks 😭😭
hybrid fjord
https://www.npmjs.com/package/@homebridge/dbus-native
this one looks good for me
humble mortar
also we cant patch this
grr really?
sly cairn
the flatpak only gets the compiled source and its a nightmare, we want to avoid writing flatpak-specific patches in the packaging step because they'll be unreliable
since flatpak is an official distribution of vesktop it's fine to tweak your code to work with it
we have flatpak specific code in there already
humble mortar
why does this happen for every comment 😭😭
sly cairn
cuz it's both a comment and an update to the review
humble mortar
it doesnt say pr review update
humble mortar
idk it feels redundant
sly cairn
probably
simple groveBOT
Discord Account
frousties
Motivation
Hi!
I have noticed that the "plus" button on Vesktop directly opens the file explorer to put an attachment instead of giving the same options as the desktop app (I am aware this is due to Vesktop using Discord's browser version)
I wonder if it would be possible to sync the "plus" button behavior with how it works on the app side? Because currently t...
simple groveBOT
humble mortar
this one looks good for me
I cant figure out how to safely exit after sending the signal 😭
humble mortar
gwuh import { dbus } from "@homebridge/dbus-native"; gives undefined when compiled into vesktop but running the file with pnpm tsx works
humble mortar
there is no .node file like with venmic
hybrid fjord
wait can't you just add dbus-native to project dependencies, then npm i and then just use import { dbus } from "dbus-native"?
humble mortar
apprently not
humble mortar
that worked guh
why does import work with pnpm tsx then
idk enough about js for this
humble mortar
what if try `var dbus = require('dbus-native')`?
and this gives undefined too if i do dbus.sessionBus.connection.message instead of const sessionBus = dbus.sessionBus(); sessionBus.connection.message
ohh it needs to be initialized
ok ok its working now with import
simple groveBOT
simple groveBOT
cyan flame
next sundial
about Vencord/Vesktop#633, I found {"browser":{"enable_spellchecking":true} [...] in ~/.config/vesktop/sessionData/Preferences
hybrid fjord
Vendicord
Ahahahahhahahahaha
simple groveBOT
humble mortar
me when I dont google the error message and find the chromium bug report