Webpack.Common.* are discord's modules...
#🖥-vesktop-development
vernal lintel
vernal lintel
also no
humble mortar
so discord skill issue then
vernal lintel
it returns the number of pending relationShips
hybrid fjord
We need from some another module then?
vernal lintel
no it doesn't...
it gets the number of pending relationships
nothing else, nothing more
hybrid fjord
Yeah but in discord terms it may be cooked
next sundial
it returns the number of pending **relationShips**
what about relationTanks
maybe also relationAirplanes
hybrid fjord
Okay so from my side I just add new switch and this
next sundial
may be worth mentioning https://github.com/elFarto/nvidia-vaapi-driver in Vesktop's README for NVIDIA users
humble mortar
may be worth mentioning https://github.com/elFarto/nvidia-vaapi-driver in Veskto...
thats just for decoding
- decoding works with VAAPI on nvidia last i checked
so yes ur right id have to fix in my pr
hybrid fjord
What I need to change then, can you write fully again?
What must be when new toggle enabled, which checks and what if toggle disabled (just not show badge in tray, right?)
humble mortar
still this i think
humble mortar
no
hybrid fjord
But maybe badge must be showed on new friend?
humble mortar
But maybe badge must be showed on new friend?
thats what the app icon badge woukd indicate
hybrid fjord
Why not make if app icon badge showing something then show it also on tray 😭
humble mortar
idk im just copyinmg stock behaviour 😭
humble mortar
wait wait wait
i just installed discord to check
what the fuck this shit is so confusing
is this the discord linux build being weird??
this toggle effects the tray too
??
it says unread message badge but it also shows the red dot for friend requests
so the tray and app icon toggle are one and the same on stock discord
thats just stupid
hybrid fjord
so the tray and app icon toggle are one and the same on stock discord
Yaaaay
I should just edit text then
And for checking use that function instead of -1
humble mortar
ino thats still an issue
vesktop has the toggle itself
it shouldve just hooked into that toggle in the first place to replicate stock discord
but stock discord is still STUPID as hell
why is that one toggle
what if the user wants mention badges but not unreads on the app icon
can't do that
hybrid fjord
I can't imagine a user who even wants unreads
humble mortar
exactly
hybrid fjord
Wait what about unmuted chats
In fully muted servers in muted chats any messages are considered as unreads
But if server unmuted and chat in server is unmuted then it counts as mention or as unread?
humble mortar
fully muted = no mentions or unreads
muted but allow pings = mentions and no unreads
unmuted = both
hybrid fjord
But on fully muted if you have mention then it shows as new message, isn't?
What's a point of mention if it didn't mention lol
humble mortar
I think we just delete the stock toggle and implement a four way toggle in Vesktops settings.
humble mortar
But on fully muted if you have mention then it shows as new message, isn't?
What...
idk what u mean by that
hybrid fjord
When you mute chat
And when someone type @ and your nick then it's mention and it will ping you even when chat is fully muted and at this situation there imo must be badge
Or just replies to your msg
humble mortar
u can make it so nothing comes through
hybrid fjord
Oh shit
humble mortar
I think we just delete the stock toggle and implement a four way toggle in Veskt...
what're your thoughts on this
hybrid fjord
4 toggles??? Sounds overwhelming
I think most users are like me who do not understands well about all this shit
So that number of toggles may be complicated for them
humble mortar
let me make a mockup
hybrid fjord
Or if you want you can do it but we should describe it very well
And to me too xd when I should show and when to hide
humble mortar
gimp is a visual design software
humble mortar
first i need to figure out how to get message request count tho
hybrid fjord
Switches would be pain
humble mortar
Switches would be pain
check box?
humble mortar
gimp is a visual design software
i swear ive seen a modal like this on discord before
hybrid fjord
But here is like multuply picker and in badge settings there are settings like on or off, so I think that switches must be used
humble mortar
i think you could cheat and use a normal switch thing + an unlabeled one on the right
hybrid fjord
xd yeah but only question whether it will be aligned horizontally
Anyway it probably needs V thoughts about UI
And do we ever need to do this switches at all
But personally I like idea of these switches and UI mockup
If you add switches then your PR must be merged first so I can add tray icon support to it
And you just add new settings which will do nothing xd
And I'll use them
humble mortar
maybe fixing the toggles should be another pr that depends on both so its not in a weird limbo state of adding incomplete things
humble mortar
that one is already so massive 💀
hybrid fjord
Xd
humble mortar
how the hell do i get the value of this
hybrid fjord
Check what functions do RelationshipStore have
humble mortar
nothing that looks like it'd return that value
hybrid fjord
how the hell do i get the value of this
MessageRequestStore??
Check it
It looks like exists
humble mortar
It looks like exists
nope
hybrid fjord
What if use findStoreByName function?
humble mortar
vernal lintel
so it exists but its not a function
what?
wdym by that
also tip, enable ConsoleShortcuts plugin and type Stores.
it has the entire list
humble mortar
wdym by that
Vencord.Webpack.Common.MessageRequestStore isnt a function
hybrid fjord
Check what functions does [[Prototype]] have
humble mortar
OHHHHH
humble mortar
Is there something?
MessageRequestStore.getMessageRequestsCount();
hybrid fjord
Very good
humble mortar
is it not at webpack common?
humble mortar
use findStoreByName
how?
simple groveBOT
hybrid fjord
What
next sundial
MFW when users send reports on unsupported operating systems
"yo I am having a problem with Vesktop on Ubuntu 13 please help me!! 😭"
hybrid fjord
but there's no this func in appBadge.ts)
humble mortar
sour muralBOT
https://github.com/Vencord/Vesktop/blob/0e49e5e8f6bf3727a7d4bc0a4dfe12cf05fcfd5a...
appBadge.ts: Line 21
const hasUnread = GuildReadStateStore.hasAnyUnread();
ohh sorry
azure verge
"yo I am having a problem with Vesktop on Ubuntu 13 please help me!! 😭"
ubuntu 7
humble mortar
my PR just adds working icon badges
a better toggle system would be its own PR if not in yours
hybrid fjord
you think i should add 4 toggles into tray icon pr?
i mean i can but pr already massive
humble mortar
I think it should be a separate pr
hybrid fjord
yeah and after yours and mine PRs merged
humble mortar
👍
hybrid fjord
wait do i need then to remove this checking for -1?
bc i need that in main, not renderer
vernal lintel
someone wanna test TTS / VCNarrator in vesktop flatpak for me? https://github.com/flathub/dev.vencord.Vesktop/pull/20#issuecomment-2197792935
would be really helpful if someoen could confirm it works nicely
simple groveBOT
vernal lintel
some mac and windows users wanna test 
simple groveBOT
hybrid fjord
some mac and windows users wanna test <a:HomuNeko:1253043938571583488>
Do I need to install windows on raspberry pi xd
vernal lintel
i mean we will see next release if it works
if users don't complain that means it works
hybrid fjord
fair
vernal lintel
i think nsis installer should include both binaries? and automatically install right one
would be useful
hybrid fjord
top 10 useful bumps on issue
simple groveBOT
next sundial
btw, is Vesktop waiting for another new release of Chromium to fix some sort of screenshare bug?
hybrid fjord
btw, is Vesktop waiting for another new release of Chromium to fix some sort of ...
I'm not sure
They fixed one thing and asked me to test in beta M127
But looks like they backported this fix to latest chromium stable version and it is already in latest Electron and Vesktop
upper pine
Sorry for my absence btw, will try to fix the open venmic issues soon but I think I've caught the cold
Just throwing this in to make sure I'm not insane: when I put down (via compose down -v) a postgres container and start it again on my system Vesktops Audio ceases to function, like I can still talk and other people hear me, but I can't hear them at all and also get no notif sounds 
This is the compose:
services:
postgres:
container_name: db
image: postgres
hostname: localhost
ports:
- "5432:5432"
environment:
POSTGRES_DB: salon
POSTGRES_USER: admin
POSTGRES_PASSWORD: 12345
volumes:
- postgres-data:/var/lib/postgresql/data
restart: unless-stopped
volumes:
postgres-data:
I don't think it's a Vesktop issue but just wondering if someone is able to reprod this (command is: docker-compose down -v && docker-compose up -d) I have absolutely no clue why this happens lmao
humble mortar
I'm not sure
They fixed one thing and asked me to test in beta M127
But looks li...
what version was it backported to
hybrid fjord
what version was it backported to
I don't know, that's why I'm not sure 😦
simple groveBOT
humble mortar
when will electron support Wayland global menu 😭😭
hot juniper
vns #🪅-progaming you will read
silk elkBOT
humble mortar
vns <#1223973149222375536> you will read
Vesktop is electron and it has a app menu so ☝️🤓(vesktop is the only electron app I really use) dead
hot juniper
Vesktop is electron and it has a app menu so ☝️🤓(vesktop is the only electron a...
your vesktop isnt running under wayland then
humble mortar
yes it is?
hot juniper
no it isnt
just because it supports pipewire screen sharing doesnt necessarily mean it is native wayland
humble mortar
well the launch args and kwin debug say it is really_shock
hot juniper
is it?
humble mortar
yeah 😭
humble mortar
vns <#1223973149222375536> you will read
wait what the hell i just checked and u were yapping about the same thing like an hour ago
humble mortar
when will electron support Wayland global menu 😭😭
this was completely unrelated 😭😭😭
simple groveBOT
Discord Account
u5kun
Operating System
macOS Sonoma
Linux Only ~ Desktop Environment
No response
What happens when the bug or crash occurs?
What is the expected behaviour?
All application windows must be shown on the list.
How do you recreate this bug or crash?
- Join a voice channel
- Click "Share Your Screen"
Debug Logs
No logs
##...
vernal lintel
why reply again
hybrid fjord
why reply again
Sorry it's bad internet
vernal lintel
lmao
hybrid fjord
I'm in mountains and have bad mobile signal xd
simple groveBOT
Discord Account
No response
Operating System
Windows 10/11
Linux Only ~ Desktop Environment
No response
What happens when the bug or crash occurs?
When opening discord settings, the settings do not open and errors are displayed in the console
What is the expected...
hybrid fjord
Update Vencord bruh😭
upper pine
oops @vernal lintel hope it was ok that I closed it
We should probably track it in Vesktop right
I'll close the venmic issue and reopen the vesktop one
simple groveBOT
humble mortar
excludes; in window assets, controllable via css and the app icon(read [FEATURE] Ability to change app Icon #505, DEs provide methods of achieving this).
me omw to read the title and nothing else
humble mortar
@upper pine is there a special flag or something that specifies if the device is virtual
@hybrid fjord if you stream with audio the tray displays the speaking/audio detected icon
even if you arent actively playing audio to the stream as well
hybrid fjord
<@242305263313485825> if you stream with audio the tray displays the speaking/au...
Are you on latest bc I made some changes to it
humble mortar
Are you on latest bc I made some changes to it
yeah I double checked
simple groveBOT
hybrid fjord
yeah I double checked
xddd i can confirm
simple groveBOT
simple groveBOT
Discord Account
interchicky
Operating System
Arch Linux
Linux Only ~ Desktop Environment
GNOME on Wayland
What happens when the bug or crash occurs?
When I open the app, the window starts offset. Click targets are accurate.
What is the expected behaviour?
I expect it to open fullscreen or in a window. This bug is a minor inconvenien...
simple groveBOT
hot juniper
real
humble mortar
@hybrid fjord I think the settings menu for the situation the indicator is active should be its own PR for reviewabilitiss sake but it should also be worked on now so when the tray PR is ready the settings menu is too
hybrid fjord
<@242305263313485825> I think the settings menu for the situation the indicator ...
for now it's following setting of badge for app icon and when that setting is on then it shows badge only on mentions and personally i like this behavior
if you all want i can just add another one switch along with existing for notification like "Show mention badge on tray icon"
humble mortar
it doesnt show only for mentions tho
it shows for unreads
and doesnt show for mentions
GUH
horror
mb for yapping
humble mortar
nono it works
humble mortar
mb for yapping
.
hybrid fjord
oh i thought that mb its "maybe" and not "my bad" xdd
humble mortar
this is at most an ok solution until finer control is added
hybrid fjord
but it will show badge for both unread and mentions😭
and i prob want more only mentions
humble mortar
but it will show badge for both unread and mentions😭
only if the option in the notifications menu is toggled
hybrid fjord
but yes it should follow that shit
hybrid fjord
only if the option in the notifications menu is toggled
and if setting is disabled then it will show on mentions too??
hybrid fjord
OH THERE IS DISCORD SETTINGS TOO
humble mortar
YES
hybrid fjord
great
humble mortar
IMO this whole system needs to be redone cause its confusing which option does what
oh also the tray settings should be there own settings entry in vesktop
theres quite a lot
and reword some things
hybrid fjord
oh also the tray settings should be there own settings entry in vesktop
yeah i though about it too
humble mortar
alr ill work on it rn
hybrid fjord
I sent invite
simple groveBOT
hybrid fjord
Thanks, Cookie ^^
humble mortar
Thanks, Cookie ^^
uh did you actually implement the auto switching for dark/lightmode themes
hybrid fjord
Yes, it's in .svgs
humble mortar
its not switching when i switch between breeze dark/light hm
hybrid fjord
It's not changing automatically, try toggle it
humble mortar
oh
hybrid fjord
I think that maybe there is some event from kde that theme changed
humble mortar
shouldnt the auto setting do that 💀
hybrid fjord
I don't know how it works
humble mortar
https://www.electronjs.org/docs/latest/api/native-theme#properties electron handles it
hybrid fjord
Yeah but I still need some event
simple groveBOT
humble mortar
horror its back??
hybrid fjord
Oh there is "updated"
I'll get back to it when I'll get power xd
humble mortar
i think after that the pr is ready to merge
hybrid fjord
And after many many reviews for this shitty code xd
hybrid fjord
Not fact that works in most optimal way
humble mortar
is https://github.com/Vencord/Vesktop/pull/326 supposed to allow you to input custom keybinds
humble mortar
is https://github.com/Vencord/Vesktop/pull/326 supposed to allow you to input cu...
@scenic hollow
scenic hollow
???
oh
currently you are kinda supposed to hook up keybinds through your wm
this is temporary tho
i'll work on it some more when i'm done with school
humble mortar
your last comment on june 1st said something about ids next to the binds in the client
i dont see said id
scenic hollow
uhh maybe discord updated wait
simple groveBOT
humble mortar
yeah thats what i was thinking
scenic hollow
oh yeah no it's completely busted
i'll try fixing it
i think that fixed it
@humble mortar try again
there should be an ugly little id thing next to each keybind
simple groveBOT
I'm not sure if I understand the new behavior correctly. After updating, it now shows the dot for non-mentions again.
Am I supposed to disable “Enable Unread Message Badge” when I want it to only for mentions?
I think this could be made clearer
scenic hollow
hmm so the toString prop thing i used has disappeared i think
i know nothing about props where can i see if i can get it from somewhere else?
simple groveBOT
vernal lintel
begging people to stop reporting gpu issues
there are exactly 0 things we can do about it
hot juniper
begging google chrome developers to do something useful like contribute better wayland on nvidia support to chromium rather than adding a generic ai model in the browser
vernal lintel
it's on nvidia
dense grove
begging google chrome developers to do something useful like contribute better w...
they did tha tjust for publicity
dense grove
it's on nvidia
oh hello vee
hybrid fjord
uh did you actually implement the auto switching for dark/lightmode themes
you can pull and test now :3
hot juniper
they did tha tjust for publicity
nah
vernal lintel
the ai feature is cool idk why you'd hate on it
hybrid fjord
At least this guy is nice
dense grove
NO-ANIME-GIRL DOES THIS GUY
hybrid fjord
Why kde is always a issue xddd
humble mortar
💀 what the
wait whats sunroof
fork of vesktop with prs merged
it takes two seconds to compile vesktop why make a fork
sudden trout
humble mortar
holy hell!
simple groveBOT
Discord Account
.j.r.h.
Operating System
Ubuntu 24.04 LTS x86_64
Linux Only ~ Desktop Environment
GNOME 46.0
What happens when the bug or crash occurs?
On startup the window is just white with nothing to interact with
What is the expected behaviour?
I just expected it to work like it always had
How do you recreate this bug or cr...
hybrid fjord
Bro running without DBus??
vernal lintel
somehow
simple groveBOT
simple groveBOT
simple groveBOT
echo spire
Trying to understand how vesktop works. Is it a discord client with vencord already patched in (with maybe some extra sauce added on) or is it a custom client altogether?
upper wagon
depends on your definition of custom client
echo spire
depends on your definition of custom client
Written from ground up. Not modified version of existing discord client
marsh solstice
Vesktop was made from scratch, it loads discord webpage and injects vencord into it
upper wagon
that
echo spire
Hmm, does that mean that vesktop is not pinned to any version of discord because it would always load whatever is current for discord web?
I would have that it was some modified electron app
sudden trout
vesktop is just an electron wrapper for discord web with vencord and some screensharing patches
echo spire
Interesting. I thought it was modified version of the discord electron app itself
Was this because it is easier to integrate vencord?
vernal lintel
Interesting. I thought it was modified version of the discord electron app itsel...
no, it's a full reimplementation of it
both load discord.com/app
echo spire
Wow
Does that mean that the discord website could ever make breaking changes to vesktop though?
That could break vencord and such
hybrid fjord
Does that mean that the discord website could ever make breaking changes to vesk...
There even was this changes
Around week ago
vernal lintel
Does that mean that the discord website could ever make breaking changes to vesk...
yes
it loads the latest discord website
echo spire
How are you guys interfacing to discord then? I see that vesktop is a react app on electron. But I'm kind of wondering how you're able to mess with discord's react components. Or do you guys just avoid that entirely some how?
tardy patio
how do i run vesktop from the command line? (required step for making a bug report)
hybrid fjord
how do i run vesktop from the command line? (required step for making a bug repo...
pnpm i
pnpm start
Read readme😭
tardy patio
don't see it in the readmehttps://github.com/Vencord/Vesktop
tardy patio
`pnpm i`
`pnpm start`
Read readme😭
do i just put the first two lines into terminal one at a time?
hybrid fjord
do i just put the first two lines into terminal one at a time?
First line
Enter
Wait
Second line
Enter
tardy patio
oh well how am i supposed to know that when thats under the 'building from source' section 😭
sorry for 2 pings i forgot to turn off reply ping
hybrid fjord
oh well how am i supposed to know that when thats under the 'building from sourc...
Wait if you have Vesktop already installed you can just type vesktop in terminal
tardy patio
yeah i have vesktop already
i just need to run it from command line for the bug report
tardy patio
btw i dont know a thing about coding
compact frigate
/Applications/Vesktop.app/Contents/MacOS/Vesktop
tardy patio
Try Vesktop
compact frigate
run that
compact frigate
Try Vesktop
macos
hybrid fjord
And this conv is offtop here
tardy patio
run that
tysm it did something this time lol
do i just copy & paste this into the vesktop github issue thingy?
hybrid fjord
do i just copy & paste this into the vesktop github issue thingy?
Yes, that's it
tardy patio
ty
tardy patio
And this conv is offtop here
oh sorry
i thought yall would know here since ur all coders lol
simple groveBOT
hybrid fjord
i thought yall would know here since ur all coders lol
Yeah that's why I'm supposed you are trying to start from source, mb
tardy patio
nws!
hybrid fjord
Are this reproducible in stock discord?
Maybe that's something on server side?
tardy patio
Are this reproducible in stock discord?
Maybe that's something on server side?
ill try stock discord rn
nope it works just fine on stock discord @hybrid fjord
hybrid fjord
nope it works just fine on stock discord <@242305263313485825>
What about web xd
Bc I do not think that Vesktop doing something that can break this button so this more probably discord upstream bug
tardy patio
web works too
tardy patio
@vernal lintel sorry I have zero coding knowledge, how do I fix the issue? It says in the pr linked in issue 293 to do a bunch of stuff I don’t understand
tardy patio
Ok
simple groveBOT
simple groveBOT
Okay so I think I may have jumped the gun here. Something does slow down the system, however I am starting to think it is a plugin issue or something
hybrid fjord
560 released???
next sundial
560 released???
oops, I meant 555.58 (which includes Wayland fixes) :p
this one is on the stable branch
I will update my reply on gh to avoid confusions
humble mortar
if discord updates break it shouldn't it be a vencord mod
vernal lintel
anyway i need to fix this security issue
vesktop has sandbox escape 😭
cause im dumb
hybrid fjord
vesktop has sandbox escape 😭
That's how and where
vernal lintel
next sundial
@vernal lintel don't you think we should use the same word for both Vencord and Vesktop, considering that we use "Restart" for Vesktop and "Relaunch" for Vencord?
next sundial
I mean this
vernal lintel
it doesnt matter much
vernal lintel
they are synonymous
simple groveBOT
vernal lintel
@sly cairn pls look into https://github.com/Vencord/Vesktop/pull/674/files 🥺
sly cairn
<@96269247411400704> pls look into https://github.com/Vencord/Vesktop/pull/674/f...
im bedridden
vernal lintel
cause needs new env vars and stuff
sly cairn
tyty :3
vernal lintel
or is it just cause youre old 😔
vernal lintel
oh rip
simple groveBOT
but you just moved it down? and it breaks the count !== 0 check
humble mortar
will auto-update from now on
vernal lintel
does flathub bot hate me or do i have to do anything specific for it to build my pr https://github.com/flathub/dev.vencord.Vesktop/pull/23/
simple groveBOT
hybrid fjord
does flathub bot hate me or do i have to do anything specific for it to build my...
You need to sacrifice 15 sheeps
vernal lintel
there's no point even waiting for bot cause i know it works 😭
but i have to wait
simple groveBOT
hybrid fjord
Xddd
hybrid fjord
seems like flathub bot is dead
As always actually
vernal lintel
seems like flathub bot is dead
@golden cypress is there anything we can do or we just have to wait
golden cypress
<@848382340937023528> is there anything we can do or we just have to wait
You'll have to wait a long time
They're currently rebuilding the KDE stack lol
vernal lintel
FEAR
why do they make that block 100% of builders?
would be way smarter to only use like 50% of builders so the other half can still build normal builds
golden cypress
why do they make that block 100% of builders?
I think it's because they do it in order
So one builder for each package
vernal lintel
scary
golden cypress
Who use all kde packages as flatpak😭
On Plasma I use most KDE apps as flatpak
hybrid fjord
On Plasma I use most KDE apps as flatpak
Even like kwin and so on?
Does that not affect performance?
golden cypress
Even like kwin and so on?
No, just apps, like graphical apps
golden cypress
Does that not affect performance?
No, why would it?
humble mortar
what about app integration stuff
golden cypress
In what way?
humble mortar
ark or kcm modules
hybrid fjord
No, why would it?
Dunno, I thought that sandboxing somehow affects performance, but I really may be wrong cuz not so much familiar with all that
For now I just think that native-builded apps may be faster in some way but again I really can be wrong
golden cypress
ark or kcm modules
Idk what those are, I use Plasma almost by default
I was thinking of switching it to GNOME though, but then again I barely use my laptop so it's not a big deal for me
vernal lintel
tbh i don't like that most flatpak can't access your files
sucks when you try dropping / pasting some file and it fails cause of permissions 😭
golden cypress
That's more of an app/framework problem :p
vernal lintel
the former is issue of the app cause it doesn't use the portal
but it's still an issue in the end
humble mortar
sucks when you try dropping / pasting some file and it fails cause of permission...
honestly thats just bad ux
next sundial
how does the auto-updater for vesktop work? does it ask the user or it just updates like vencord auto-update?
humble mortar
the former is issue of the app cause it doesn't use the portal
but it's still a...
yea
vernal lintel
how does the auto-updater for vesktop work? does it ask the user or it just upda...
it just updates
maybe in the future we can make it configurable but that's more effort
golden cypress
the former is issue of the app cause it doesn't use the portal
but it's still a...
Yeah, so we can't really blame Flatpak
next sundial
it just updates
will it notify the user after a new update such as opening the changelog?
vernal lintel
yes it shows a notification
"Vesktop 1.5.4 downloaded. it will be installed once you close the app"
vernal lintel
Yeah, so we can't really blame Flatpak
well sure but it's still a flatpak issue in the end
makes flatpaks less usable
golden cypress
How? It's outside of their control and they have the APIs
Those APIs are standards
humble mortar
honestly I dont like auto updaters but thats probably me being package manager brained
golden cypress
It's like blaming Linux because Firefox doesn't follow XDG standards
humble mortar
How? It's outside of their control and they have the APIs
flatpak is niche and you can't reasonably expect all apps to use the proper portals
golden cypress
2K apps isn't niche
vernal lintel
It's like blaming Linux because Firefox doesn't follow XDG standards
im not blaming flatpak
scenic hollow
well sure but it's still a flatpak issue in the end
also doesn't that also apply to wayland?
vernal lintel
i'm just saying it's still a flatpak issue in the end
doesn't matter whose fault it is
it makes flatpaks less usable
golden cypress
I guess we see the issue differently, because I don't consider it a Flatpak issue
next sundial
"Vesktop 1.5.4 downloaded. it will be installed once you close the app"
on the screen like a big pop-up, or something like discord green button in the top-right corner?
vernal lintel
system notification
golden cypress
By that logic it'd be like blaming Linux because your NVIDIA drivers run like trash
At least that's how I'd see it
vernal lintel
once again i am not blaming flatpak
humble mortar
By that logic it'd be like blaming Linux because your NVIDIA drivers run like tr...
nvidia cooks now wdym
golden cypress
Sorry, let me rephrase
By that logic it'd be like calling it a Linux issue because your NVIDIA drivers run like trash
vernal lintel
but yes that would be a reason to not use linux, even though it's not linux' fault
same for these flatpak issues
golden cypress
nvidia cooks now wdym
They don't
humble mortar
They don't
me running 555 with wayland:
golden cypress
Not everybody has the luxury of having the latest hardware
Older NVIDIA GPUs will continue to suffer
humble mortar
im on a 2060
golden cypress
Yeah, it came out in 2019, so it's fairly recent
humble mortar
less driver support is a thing with all old hardware
golden cypress
That's not less driver support though, it's literally no driver support (at least for Wayland)
humble mortar
wayland is a newer standard
golden cypress
And the GPUs that support it are fairly recent
humble mortar
you cant get upset at a company for not supporting old hardware
you can get upset at them for not open sourcing the drivers tho
golden cypress
I'm fine with the former, but not the latter
So I don't believe that NVIDIA GPUs "cook" as you put it, because the GPUs that don't/won't have support aren't that old
humble mortar
if you drop support for older hardware you should let the user modify the firmware/drivers
humble mortar
So I don't believe that NVIDIA GPUs "cook" as you put it, because the GPUs that ...
5 years is quite a while in tech land
next sundial
once again i am not blaming flatpak
just build for every distro out there
stonks
distro jumpscare: https://flatpak.org/setup/
humble mortar
flatpak supports chromeos???
golden cypress
5 years is quite a while in tech land
Maybe if you live in a rich or middle-class area, sure, but again not everybody has the luxury of living in those areas
next sundial
flatpak supports chromeos???
u n i v e r s a l p a c k a g e s
golden cypress
flatpak supports chromeos???
Yeah, it did since forever
next sundial
@vernal lintel could you please take a look at https://github.com/Vencord/Vesktop/issues/693 ?
I dunno how the download update button doesn't work for some people
for me it just opens the github releases page in my default browser and that's all
marsh hinge
I like tux
vernal lintel
vencord old updater checked for file name
filename changed on mac so button is broken on mac
humble mortar
opinions?
humble mortar
I'm so confused about all this shit and I can't say anything xd
basically should message requests show a number
hybrid fjord
basically should message requests show a number
We prob should really just follow discord behavior
And somewhen make it fully customizable
humble mortar
idk i feel like its quite a useless thing to have togglable just for the sake of following messy discord standards..
it feels more like an oversight than a deliberate decision
humble mortar
the badges are already inconsistent with stock discord
the setting under notifications toggles both unreads and mentions on stock discord
while it only toggles unreads on vesktop
hybrid fjord
is that something broke on my branch or this is normal?
vernal lintel
probably issue with ur branch
vernal lintel
the setting under notifications toggles both unreads and mentions on stock disco...
then it should be fixed
hybrid fjord
probably issue with ur branch
maybe you have ideas what should I check first? If no then I'll figure it out but harder xd
humble mortar
then it should be fixed
then you'd always have a badge on the app icon/tray which defeats the point of the badge
which brings me back to why follow these dumb stock discord settings
if you want the mess of the stock client just use that
vernal lintel
maybe you have ideas what should I check first? If no then I'll figure it out bu...
i mean check which line the stacktrace leads to lol
simple groveBOT
simple groveBOT
hot juniper
https://github.com/Vencord/Vesktop/commit/1f12d270ec94a6e78dd1a0ae4f0511e1ddfb0e83 Can someone explain how this "escape" worked? Was it just that the renderer could pick any path and request native to load it in the future?
If yes, would assuming this popup is because setting up a migration system that isnt itself vulnerable would be too much for a feature that a very small amount of users will see?
simple groveBOT
hybrid fjord
Wtf is going on
hybrid fjord
I can test when I wake up
Better not maybe xd
azure verge
I'll do it on my laptop
simple groveBOT
vernal lintel
If yes, would assuming this popup is because setting up a migration system that ...
migrating safely is impossible
because the value is untrusted
vernal lintel
https://github.com/Vencord/Vesktop/commit/1f12d270ec94a6e78dd1a0ae4f0511e1ddfb0e...
and yes
vernal lintel
people always so eager to leave 10 me too comments but once you ask them to test a fix they're suddenly quiet
vernal lintel
wait why does this still say 1.5.2?
where does it pull the version from
am i dumb
oh the bot didn't update the metainfo
why doesn't this get done automatically https://github.com/flathub/dev.vencord.Vesktop/pull/29
vernal lintel
does this make rpc work out of the box?
https://github.com/flathub/com.discordapp.Discord/blob/master/discord.sh#L3-L6
sour muralBOT
does this make rpc work out of the box?
https://github.com/flathub/com.discordap...
discord.sh: Lines 3-6
socat $SOCAT_ARGS \
UNIX-LISTEN:$XDG_RUNTIME_DIR/app/${FLATPAK_ID}/discord-ipc-0,forever,fork \
UNIX-CONNECT:$XDG_RUNTIME_DIR/discord-ipc-0 \
&
simple groveBOT
simple groveBOT
Discord Account
No response
Motivation
Since the new update dropped, I am having two "problems" with the new UI.
First: it's too big/large when compared to the old UI. Before, I was able to select every option before streaming, and now I have to scroll to select audio sources. My resolution is 1366x768.
Second: when selecting an item in "Audio Sources" and "Exclude Sources",...
upper pine
When submitting such issues
Please propose a viable solution, that (if possible) has also been approved by other contributors
Also, a mock up is really helpful, as well as a POC that something that has been proposed is possible
As for the, "require a key press", test if something like that works, if so, let me know
Maybe we should really hide the thing behind an option to select multiple
Idk
It would require a proper discussion before hand as to not put in unnecessary work in case the solution is not deemed viable
@vernal lintel maybe you have some ideas for #731
simple groveBOT
next sundial
Also, a mock up is really helpful, as well as a POC that something that has been...
my profession is words; HTML and CSS scare me (read: I don't know how to use it, but I have an idea of what it is)
next sundial
It would require a proper discussion before hand as to not put in unnecessary wo...
one thing I thought would be just a simple "Share system audio" toggle and then hide the multi-choice selection behind "Open Audio Settings", but I don't know if that would be good
upper pine
one thing I thought would be just a simple "Share system audio" toggle and then ...
Too much indirection for audio share
next sundial
Too much indirection for audio share
I think the simplest alternative would be to simply make the menu close by default and then add a tooltip about "you can choose more than one application", without needing a keypress.
This creates an inconvenience for users who want to choose more than one app, but as I believe these are the minority, it wouldn't be a problem as it also removes the inconvenience for users who don't want to choose more than one app.
also, I think that "Audio Sources" and "Exclude Sources" should both be visible by default, since "Exclude Sources" appearing after "Audio Sources" is set seems a bit strange
then we could rename them to "Audio: Include Sources" and "Audio: Exclude Sources", with both being set to None by default
the tooltip would be valid for both of them
hybrid fjord
then we could rename them to "Audio: Include Sources" and "Audio: Exclude Source...
But it will take more space, isn't it?
hybrid fjord
also, I think that "Audio Sources" and "Exclude Sources" should both be visible ...
And what point of showing "exclude source" if there is nothing to exclude bc "whole system" not picked
marsh solstice
i think using ctrl to select multiple would be the best option, as it is pracically a standard
hybrid fjord
i think using ctrl to select multiple would be the best option, as it is pracica...
Yeah but is it possible using Discord components?
That's actually the main problem
next sundial
But it will take more space, isn't it?
same spacing
the problem is that Exclude Sources is only visible after setting Include Sources
I think this is not good UX because Exclude Sources just magically appears
next sundial
And what point of showing "exclude source" if there is nothing to exclude bc "wh...
yeah, thought about that
I think the solution would be to not use None for Exclude Sources then
if the user picks Entire System for audio then we show None for Exclude Sources, but if the user picks an app then we show Everything Else or something like that for Exclude Sources
upper pine
also, I think that "Audio Sources" and "Exclude Sources" should both be visible ...
Exclude only makes sense when sharing whole desktop audio though?
simple groveBOT
next sundial
Exclude only makes sense when sharing whole desktop audio though?
💀
fair argument
I think exclude sources should still be shown by default, maybe grayed-out so the user understands it's only available with a certain option (entire system)
I think it's best to show it by default rather than only showing after selecting Entire System
humble mortar
there isnt a 762 
hybrid fjord
there isnt a 762 <:WHAT:1167875888151539762>
He meant 726
simple groveBOT
uhh.. are you sure this is not intended gnome behaviour? happens for me on all windows
tardy patio
He meant 726
Sorry yes I did cookie
humble mortar
try building with different electron versions ig
I assume it was working before 1.5.2?
simple groveBOT
humble mortar
oh the misery
tardy patio
I assume it was working before 1.5.2?
I didn’t use vesktop before 1.5.2 lol
Was using vencord on stable discord
Also
tardy patio
Anyone here know how to completely uninstall vesktop from Mac
simple groveBOT
can repro, but even normal chromium is affected by this. there's nothing we can do about it
vernal lintel
vns
silk elkBOT
simple groveBOT
tardy patio
I didn’t comment just now btw lol
vernal lintel
I asked like 4 times yesterday in <#1026515880080842772>
okay. please stay in the support channel or i will have to take away your access to here
tardy patio
The bot is just lagging behind
tardy patio
okay. please stay in the support channel or i will have to take away your access...
Ok sorry
I’ll try asking again
simple groveBOT
can't reproduce. works flawlessly on my system. disable transparency if you have it enabled
if that doesn't solve it, it's a system issue, nothing we can do
humble mortar
He meant 726
what the guh do i call you when referencing you on a gh comment
simple groveBOT
azure verge
Better not maybe xd
i have no issue
hybrid fjord
i have no issue
Imagine receiving notification like this xddd
azure verge
HAHAHAHA
that's incredible
also a really cool watch woah
i didnt know smart watches were advanced enough to have a res and system that good (i have literally never seen someone wear one)
hybrid fjord
also a really cool watch woah
thx ^^
There is android actually and I even wrote some apps for it xd
azure verge
woahh
simple groveBOT
humble mortar
@hybrid fjord did u ever get around to doing the tray dark/lightmode auto switching
simple groveBOT
hybrid fjord
<@242305263313485825> did u ever get around to doing the tray dark/lightmode aut...
What
It works good for me
humble mortar
i have auto selected but its light for me
oh i see
youre not updating the badge from generateTrayIcons() which is what is called by the system theme detection
simple groveBOT
humble mortar
i have auto selected but its light for me
also an issue with the accent selection
since its picked from the thing it won't change with the system without the user manually updating it
maybe that ui needs to be redesigned
3 radio buttons
Default
System
Custom
selecting custom would have the colour picker appear
Default would be the vencord pink
could maybe yoink this
@hybrid fjord thoughts?
humble mortar
could maybe yoink this
or this
humble mortar
could maybe yoink this
ooo with this one you could make that side highlight the colour
hybrid fjord
i have auto selected but its light for me
Badge icon color doesn't change on theme changing, bc on some accents it works bad 😦
hybrid fjord
also an issue with the accent selection
That probably broken by last update
I maybe need to set PR as draft and fully retest all features
humble mortar
Badge icon color doesn't change on theme changing, bc on some accents it works b...
then the user can manually set it to white no?
auto should be auto for them all
hybrid fjord
then the user can manually set it to white no?
Yeah but what if he wants one setting for call icons and another for badge
humble mortar
Yeah but what if he wants one setting for call icons and another for badge
well you could make that argument for the other 4
all should update on auto
hybrid fjord
So I just need to add changing color black/white for badge too?
humble mortar
i thnk so
humble mortar
That probably broken by last update
I maybe need to set PR as draft and fully re...
wdym
hybrid fjord
wdym
Dunno, by 1.5.3 I have new issue when one of the func can't send IPC event to renderer so maaybe somewhere icons cannot be updated
hybrid fjord
is that something broke on my branch or this is normal?
These errors
humble mortar
no i dont think thats related
humble mortar
is that something broke on my branch or this is normal?
i dont get these
the way youre setting the colour with the picker makes automatically syncing the accent with the system impossible
hybrid fjord
since its picked from the thing it won't change with the system without the user...
Wait you mean when user updating accent color in system?
humble mortar
yes
humble mortar
yea lol
hybrid fjord
Default
System
Custom
It would require something like that indeed
Yeah good idea to add this
I'll do it
humble mortar
the the the me when feature creep
azure verge
hybrid fjord
what about custom icons for dark/light mode with auto switching
naaah overcomplicated
i can probably for badge create just circle svg wihout white in center
and it will follow picked color
and prob will look nice
simple groveBOT
Discord Account
octelly
Operating System
Arch Linux
Linux Only ~ Desktop Environment
Plasma 6 Wayland
What happens when the bug or crash occurs?
Vesktop doesn't let me install VolumeBooster
What is the expected behaviour?
The ability to install VolumeBooster. (especially since I cannot hear most people at all at 100% volume)
How do you rec...
hybrid fjord
Issue will be closed in 3... 2...
simple groveBOT
hybrid fjord
what about custom icons for dark/light mode with auto switching
Most users just use one theme and does not frequently change theme color, so if user want to dark/light icons, user can just set it once and that's all
simple groveBOT
humble mortar
Most users just use one theme and does not frequently change theme color, so if ...
mhm yeah
wait doesnt your pr support svgs
do custom svgs go through the same logic
hybrid fjord
do custom svgs go through the same logic
Custom svgs is supported but color not changing for them
I thought that if user picks custom svg then color is already ok in this svg
humble mortar
well then you'd just use a PNG
the only reason to use an svg is its dynamic features
hybrid fjord
I can't use svg in electron's native image
humble mortar
put it through the same processing as the default svgs
hybrid fjord
put it through the same processing as the default svgs
It is
It's converting user-picked svg to png and uses png
But not changing colors
simple groveBOT
upper pine
Bruh
hybrid fjord
Can we use stream.is-live as +1 device to granual selection?
hybrid fjord
😦
upper pine
We need something, that most nodes have, and something that is fairly unique
That's why I chose the PID
hybrid fjord
Fair enough
humble mortar
which brings me back to why follow these dumb stock discord settings
https://github.com/Vencord/Vesktop/pull/686/files#r1665982312 any update on this?
simple groveBOT
humble mortar
That's why I chose the PID
i cant seem to select even minecraft as an audio source so something else should be used
upper pine
i cant seem to select even minecraft as an audio source so something else should...
Good thing is that it's a vesktop only change, you should be able to change it in the venmic.ts, would you mind testing how good client.id works?
