throwing the overlay in the trash
#π₯-vesktop-development
azure verge
vernal lintel
i still didnt get used to the new notification style
they changed so much in new gnome
gentle hatch
what do you think of tiling wm βββββββββββββββββββββββββ
azure verge
eh not for me
gentle hatch
fair
vernal lintel
gnome user <:angelIAvomit:813040103320453152>
gnome user 
azure verge
:c
vernal lintel
it might be that the flatpak prefers running in wayland
maybe we should revert that
there's a reason it's still opt-in
it's still unstable
many bugs
and random shit
azure verge
most of the slowness i had was because of windows 11 wtf
i just switched to win10 IoT LTSC
it is a dream
runs amazingly
azure verge
woah
vernal lintel
3 days ago
azure verge
most of the slowness i had was because of windows 11 wtf
seriously why is windows 11 so bad
junior elm
i just switched to win10 IoT LTSC
I'm hoping win 11 LTSC is good
Wait it's out?
Hell yea massgravel https://massgrave.dev/windows_ltsc_links#win11-iot-enterprise-ltsc-2024
cyan flame
Hell yea massgravel https://massgrave.dev/windows_ltsc_links#win11-iot-enterpris...
we love massgrave
azure verge
yeppers
upper pine
isn't the index fully supported on linux??
also, why not dual boot :3?
maybe this is worth a shot
seems to be supported
and apparently steamvr beta is a must, stable seems to be fucked
quick crane
you can build from source to get it early
I'll patiently wait
This is the best discord client π
vernal lintel
it's really easy to build from source
quick crane
I use the flatpak and prefer to wait, is not like I'm always streaming anyway
vernal lintel
alright
hybrid fjord
Strange thing only that Chromium team asked me to test it in chromium M-127 beta
And electron 31 uses 126 chromium and it seems to be fixed Β―_(γ)_/Β―
vernal lintel
they usually backport fixes
oh wait if we update electron in vesktop we will have ugly devtools
verbal yarrow
What's going on with pr #261? Would love to see this feature merged but it's just been sat there for two months
vernal lintel
oh wait if we update electron in vesktop we will have ugly devtools
i wonder if you can theme devtools somehow
red thorn
It seems like it. I'm too dummy to read how to, but these guys seems to have a bunch of premade themes and a way to use them atleast, they did at some point
azure verge
isn't the index fully supported on linux??
there was a fucked input lag issue and passthrough cameras don't work
upper pine
oh wait if we update electron in vesktop we will have ugly devtools
how d othey look
upper pine
never too late to choose a sane os
azure verge
no literally like
my arch setup takes like 3 days to do
I don't care that much
plus win 10 iot ltsc doesn't have most of the shit that makes me dislike windows
upper pine
my arch setup takes like 3 days to do
still worth more than w10 o.O
vernal lintel
its so distracting
red thorn
It makes everything so much harder to read. They did it a while back, too, but I thought they came to their senses
vernal lintel
how do i fix this again
It's a bug, and it's fixed in Chrome 125 canary release.
??
its still an issue even in latest electron alpha
looks great in light theme tho lol
vernal lintel
i dont have the shit theme in normal chrome
vernal lintel
oh my god
oh god it gets even worse
somehow theme is broken
when u restart it goes to light even if u have dark selected
upper pine
lmfao
vernal lintel
????
hybrid fjord
ahhahahahaha
hybrid fjord
just get welding mask lmao
simple groveBOT
hybrid fjord
yaaay!!
upper pine
just get welding mask lmao
HAHAHAHAHAHHA
does discord somehow auto collapse channels?
or am I tripping balls
jovial grove
? wdym collapse
vernal lintel
u probably missclicked
xD
FINALLY
THANK YOU GNOME
before it would only show the monitor names
upper pine
Vertical Screen
vernal lintel
yea
upper pine
How's that
vernal lintel
before it would only show the monitor names
and idk which monitor is which
upper pine
Been considering doing it as well
vernal lintel
did u think about windows
like we dont want that visible on windows xd
we should restructure this code xD
like into multiple files
upper pine
it should only be in the linux picker stuff
vernal lintel
lmao athat is awful
upper pine
lmao athat is awful
hahaha
vernal lintel
honestly some of the code is a bit messy but idc much as long as it works
it needs rewrite anyway
we can do it later
upper pine
lets go
vernal lintel
thanks for the work noah!!
upper pine
np :D
vernal lintel
cant wait for venmic v14 next week
upper pine
hahahaha
upper pine
upper pine
youve been pumping out so many versions
I was not aware there were that many already holy shit xD
upper pine
wot
upper pine
time to go native module
but I need more info before I start
should I only tweak the game-utils or do a similar replacement like openasar did? Could also do a mix of both actually
vernal lintel
the minimum work that is necessary to make it work
if we just need to replace game-utils that'd be best
upper pine
alr, will do that then
it should be really straight forward
I can start next week, still have some exams and hand-ins I need to get done first ^^
upper pine
you can't easily extract the icon on linux
vernal lintel
thats not how it works
upper pine
is it serverside?
simple groveBOT
compact frigate
?
upper pine
wtf is https://codeload.github.com
opens normal github for me
vernal lintel
I can start next week, still have some exams and hand-ins I need to get done fir...
i can also look into it
simple groveBOT
vernal lintel
interesting
but it doesnt even have anything for just listing games
are u sure this is all that's needed
hybrid fjord
omg what is this theme xd
vernal lintel
game utils seems more like the game library
t.default = {
server: r.default,
commands: T,
events: A,
stores: [a.default],
transports: [g.default],
registerTransportsForEmbeddedPlatform: function() {
s.default.ensureModule("discord_rpc").then(()=>{
for (let e of [n("178318").default, n("967351").default])
r.default.registerTransport(e)
}
)
}
}
HELLO:3
hybrid fjord
i was wondering why stock discord not work for me at all
vernal lintel
honestly i cant find where discord quries games lol
upper pine
I'll figure it out :D
vernal lintel
im fairly certain this is what game_utils is for
discord_utils seems the most promising
wine64-preloader
oh thats for observing specific games
oh its this
@upper pine
upper pine
Oh nice
upper pine
Can't we just patch those out
vernal lintel
yes but it will become a lot
upper pine
Maybe we can patch the whole module
compact frigate
patch isDesktop 
(dont)
upper pine
I'll write a replacement then and also allow to call them manually
Then we could just manually dispatch
vernal lintel
like this for example
it seems like this is used like
discordUtils.setCandidateGamesCallback(candidates => {
const games = candidates.filter(...);
discordUtils.setObservedGamesCallback(games, idk => {
...
})
})
not entirely sure
idk how to reverse engineer .node binaries
maybe need to use something like ghidra or ida
but yeah we will likely have to reimplement some or all of discord_utils, then patch
- the place it is imported (thankfully it's central and reused)
- out all the desktop checks in the relevant logic
it won't be very robust
next sundial
@upper pine does your PR make the user selection for stream quality, FPS and audio input be remembered for the next screen-sharing session?
upper pine
maybe need to use something like ghidra or ida
Yes we do, I'll take care of that part ^^
upper pine
<@349609234985517057> does your [PR](https://github.com/Vencord/Vesktop/pull/621...
No, only audio
next sundial
vee, until a proper implementation of remembering the user selection for stream quality and FPS, could we have the default as 1440p 60 FPS?
I would submit a PR for it, but I have one to improve the README currently open and I have made my changes against the master branch, so I can't create a clean branch until that PR is accepted or declined
vernal lintel
no
next sundial
hm
the idea is that by having 1440p 60 FPS as the default the cap would be Chromium's max. bitrate/server-side Discord code
I actually don't know if there's any difference from using 1080p or 1440p for non-Nitro users
vernal lintel
please think for a second
majority of users has 1080p monitor
majority of users doesn't have nitro
majority of users doesn't have super fast internet
next sundial
well, by this logic we would make the default 720p :v
vernal lintel
majority of users has a medium or low spec pc that won't perform well on 1440p
vernal lintel
well, by this logic we would make the default 720p :v
yes i thought about that
maybe we should
next sundial
ye
vernal lintel
original client defaults to 720p 30fps
next sundial
I don't think 60 FPS hurts that much, but I don't know if it actually works because it's a Nitro feature; not sure how Discord actually implements it
if it's a client-side check like the NSFW channel age check then it's bypassable
next sundial
original client defaults to 720p 30fps
does Vencord and/or Vesktop have a principle of following Discord's defaults whenever possible?
upper pine
if it's a client-side check like the NSFW channel age check then it's bypassable
I'm against "bypassing" something by default
next sundial
well I think we currently do it? π€
web screenshare fixes plugin (removes chromium bitrate cap) + being able to select anything above 720p 30 FPS even when not Nitro
asked on support but I think it's relevant to say it here too -> #π₯-vencord-support-π₯ message
btw I noticed this notice of deprecation on the "upgrade to electron 31" commit
vernal lintel
irrelevant
teal summit
I don't think 60 FPS hurts that much, but I don't know if it actually works beca...
tbh most people wonβt even see a different between 30 and 60 fps - fps is only really essential if you are playing yourself, else 30 is fine imo
and over wifi it would hurt
teal summit
a default setting just shouldnβt be smth that lags or causes issues - if their net supports it (in which case users would know) they can higher it manually
azure verge
web screenshare fixes plugin (removes chromium bitrate cap) + being able to sele...
technically no
the issue is just that discord didn't remove a Bitrate cap that made it impossible to even stream a stable 720p30
that cap is removed by the plugin
non nitro users (as far as I know) are capped by discord's servers to 4622kbps
nitro users are capped at 8000kbps
next sundial
a default setting just shouldnβt be smth that lags or causes issues - if their n...
yep, that's reasonable
teal summit
I mean I donβt think itβs possible to do but the best would be if Vesktop could somehow know which the highest setting is that your network/pc supports
next sundial
IMO we can make the default 720p 30 FPS then, since it's the default and the max. allowed for non-Nitro users
still not sure how FakeNitro and even current screen selection method on Vesktop allow users to pick 1080/1440p 60 FPS
next sundial
hmm
teal summit
wouldnβt surprise me if you could stream 8K which an awful bitrate
next sundial
720p 30 FPS is what I think most would agree as a stable experience that would satisfy the majority of users
teal summit
yup
I had friends stream with 1440p/60 but their net was awful so the bitrate just tanks so low that you canβt even see anything (besides it not even being stable 60)
next sundial
I'm not sure how much 60 FPS actually weighs on a stream with the same base quality (let's assume 720p)
teal summit
I mean doing basic math 30 * 2 = 60; meaning twice as many pictures meaning twice as many bits
teal summit
- 720p 30fps: 1500-4000 Kbps
- 720p 60fps: 2500-5000 Kbps
- 1080p 60fps: 4500-9000 Kbps
- 1440p 60fps: 6000-13000 Kbps
(do not take these as actual numbers, only use to compare between)
golden cypress
hybrid fjord
IMO we can make the default 720p 30 FPS then, since it's the default and the max...
You can pick but WebRTC will just negotiate it back to 720 for example
azure verge
https://lvra.gitlab.io/docs/fossvr/index_camera_passthrough/
nvm im going back to linux
one day of this shit
im already annoyed
i have had more than one driver crash
and the fucking index keeps trying to be a monitor
how do people use this os lmao
and
all of my issues had solutions π
this is why i backed up my home folder
compact frigate
one day of this shit
mood
azure verge
LITERALLY I HAVENT EVEN BEEN HOME ALL DAY
I HAVE HAD MULTIPLE FULL SYSTEM CRASHES
HOW
humble mortar
Merge #355 RIGHT MEOW!
vernal lintel
honestly there are a bunch of very similar prs that all add customisation for different icons
it'd be better to combine and unify them
i might do that and supersede all the split prs
azure verge
just make a thingy so people can upload their own gif
vernal lintel
also i think all those prs just store the specified path
bad idea
users will choose files then delete or move them
it needs to copy the file into vencord cache dir xd
humble mortar
it needs to copy the file into vencord cache dir xd
good point
humble mortar
i might do that and supersede all the split prs
#355 - custom startup anim
#439 - change startup anim to vennie
#517 - tray icon voice detection, can change the colours
#576 - custom tray icon
#261 - unread badge in tray, isn't needed. (see above :3)
vernal lintel
yeah lol
azure verge
it needs to copy the file into vencord cache dir xd
true
red thorn
https://github.com/electron/electron/issues/42378
There's so much detail in that ticket 
That's more effort that I've put into anything in my entire life
hybrid fjord
@humble mortar sorry for ping but i can't reproduce this:
When first run the colour picker option isn't available - only shows up after re-toggling the tray icon.
are u sure that you tested on latest commit? Bc in first launch file i added this:
Settings.store.tray = true;and this must set tray setting to true by default and color picker must be showed too
next sundial
is it intentional for Vesktop to close with CTRL+W? I know it's a web page (Chromium), but I treat Vesktop as an app and it seems a little weird for it to behave like an actual web page (even if it technically is)
CTRL+Q and ALT+F4 make sense, but CTRL+W seems a bit off, at least for me
simple groveBOT
hybrid fjord
just like itπ
next sundial
I was going to comment the following on my issue
After discussion on Vencord's Discord server, I and other members of the community have come to the conclusion that 720p 30 FPS would better accomodate the majority of users, instead of the current 1080p 60 FPS and the suggested 1440p 60 FPS.
Therefore, I have changed the title of this issue.
I cannot make a PR for it right now due to having a open PR to improve the README file and it targets the master branch, so any PR I would possibly make would not be in a "clean" state.
but suddenly I can't anymore due to the reason in the attached image, so I am repassing it here
upper pine
I was going to comment the following on my [issue](<https://github.com/Vencord/V...
Regarding your last statement, you can simply make a new branch in your repo and pr that
next sundial
Regarding your last statement, you can simply make a new branch in your repo and...
I didn't know about this. thanks!
next sundial
Regarding your last statement, you can simply make a new branch in your repo and...
bruh
can't contribute because I need to contribute to be able to contribute
vernal lintel
can't contribute because I need to contribute to be able to contribute
now u can
next sundial
gracias
next sundial
also
IIRC, official Discord app doesn't let the user choose neither 480p nor 15 FPS anymore
minimum is 720p 30 FPS
next sundial
but 480p is only available through here as far as i can tell
oh, interesting
thx for the info
humble mortar
<@721853658941227088> sorry for ping but i can't reproduce this:
> When first ru...
not first first launch but the first time I opened vesktop after building with the PR
humble mortar
#355 - custom startup anim
#439 - change startup anim to vennie
#517 - tray icon...
should prob make a unified issue that lays out the design requirements of this system
humble mortar
should prob make a unified issue that lays out the design requirements of this s...
lmk if i cooked
simple groveBOT
I personally don't think storing the splash animations in the config is a good idea, since those files have the potential to be huge. Storing a base64'd GIF that's several MB in size (and also syncing that to the cloud) will be fairly detrimental to performance. The other suggestion of copying it into the cache directory is probably better.
humble mortar
what the hell is wrong with github's md/html parser
simple groveBOT
brave tendon
thanks for all the info in this, I'll see if I have time to work on it this week :)
what would be the best location for the user-set icons? just straight in the ~/.config/vesktop/sessionData dir?
simple groveBOT
hybrid fjord
not first first launch but the first time I opened vesktop after building with t...
i understood
looks like you never before toggled tray setting and because of it settings.tray is false even if tray is enabled by default
honestly i do not think that i should write some additional code for fixing this because on first first launch it will work good
also i fixed icon after toggling setting in voice chat and added support for manually setting fill color ^^
now i'm going to add ability for user to pick custom images
where should i copy user-set icons?
and how to get config folder for windows?
simple groveBOT
brave tendon
where should i copy user-set icons?
and how to get config folder for windows?
Should just be DATA_DIR in constants
simple groveBOT
viral oyster
anyone here got a developer account i can borrow an app specific password from? 
looking into this https://github.com/electron/notarize
hybrid fjord
Should just be DATA_DIR in constants
thanks ^^
humble mortar
i understood
looks like you never before toggled tray setting and because of it ...
I'm 99% sure ive toggled the tray in the past. Anyway yeah its not really worth more code as just fiddling with it resolves that weird behaviour
hybrid fjord
ohh very strange then
bc its just as in code xd
settings.tray = true -> render color picker
settings.tray = false -> do not render
probably i need to mention somewhere for updated users just to toggle setting
hybrid fjord
Milfcord
humble mortar
what's happening with #517? will it become the main PR for #667 with all the other features added to it? will it be refactored to allow easy future additions to the tray and splash systems? or will the work on it be left as a reference for an overall unified implementation of #667 like vee wanted
hybrid fjord
what's happening with #517? will it become the main PR for #667 with all the oth...
For now I'm working on modal where user can pick custom icons
In 517 already implemented saving icons to .png from .svg with custom colors, so in backend code there is no problem to use user-picked icons
About another PRs I'm not sure what would be the best way for doing all this stuff together
simple groveBOT
hybrid fjord
For now I'm working on modal where user can pick custom icons
In 517 already imp...
And about dbus stuff we can just use some third-party library or just run dbus-send command
But if we need dbus not only for icons then probably using library will be better
upper pine
Can we help?
vernal lintel
simple groveBOT
humble mortar
how did vesktop fix this icon issue with wayland electron
hybrid fjord
which UI component can i use for displaying image and on hover display pencil icon and on click change image?
hybrid fjord
omfg i'm so bad at tsx
for now i'll just let for users to manually replace icons in config folder
i hope that later i'll figure out how i can in modal display icons from file and let user replace
brave tendon
which UI component can i use for displaying image and on hover display pencil ic...
You can reference PR #576
TrayIconPicker.tsx and settings.css
brave tendon
Yeah I spent a long time making the world's most cursed css
You need help on your PR?
brave tendon
Pocket voice message oops
hybrid fjord
You can reference PR #576
Is it possible to allow .svg and .ico files to be chosen?
i have code which can convert .svg to .png of 128x128 in renderer
brave tendon
Sweet
hybrid fjord
combining all this PRs is so fucked up
i'll maybe refactor it somehow and create IPC call like "convert to png" from .svg path
brave tendon
Seems weird that electron can't make a nativeimage out of two very common icon formats
hybrid fjord
for not only my usage
brave tendon
combining all this PRs is so fucked up
i'll maybe refactor it somehow and create...
Sounds like a good idea
hybrid fjord
Sounds like a good idea
i think we must somehow merge our prs
i can create setting like "Custom tray settings" which will open modal where user can pick custom tray icons for VC
And then i can give to you write access to my repo or you can just PR to my repo and add just customization for main tray icon
or maybe you have better ideas how we can do it?
hybrid fjord
i need time for creating modal anyway xd
i only feel bad for copypasting css classes and etc
vernal lintel
i might just write this feature
it's a bit complex due to ipc and has some security implications
hybrid fjord
i might just write this feature
what exactly?
bc i believe that in 517 i have all needed except UI
now it's working like this
from main to renderer CREATE_TRAY_ICON_REQUEST with iconPath. Renderer captures it, changes colors in .svg, creates canvas, creates dataURL of this changed .svg. Then it uses createIconResponse with fileName param ("muted", "deafened" and so on) and dataURL and sends to main via CREATE_TRAY_ICON_RESPONSE
then main just creates png file to DATA_DIR/TrayIcons/fileName.png from dataURL
brave tendon
Changing tray icon should also immediately apply instead of only on a restart which I think that flow will do
hybrid fjord
on color change there is another IPC call GENERATE_TRAY_ICONS which creates new .pngs and automatically reapplies new icons
teal summit
q question, where does vesktop store settings (if using flatpak)
teal summit
thanks
also, is it just a me problem that vesktop doesn't start anymore if I set a custom vencord directory? I assume it has smth to do with flatpak but I am not sure
because my vesktop will not start after a system reboot unless I remove the vencordDir
teal summit
because my vesktop will not start after a system reboot unless I remove the venc...
yeah it seems to be flatpak doing that but idk how to fix it
simple groveBOT
go to %LOCALAPPDATA%/Vesktop and run Vesktop.exe from a terminal
Got this, nothing else
vernal lintel
because my vesktop will not start after a system reboot unless I remove the venc...
this path is temporary mount
you need to give vesktop access to the vencord folder
use flatseal
hybrid fjord
Wtf why so many activity on last hour
vernal lintel
need to just remove transparency again
vernal lintel
what π
simple groveBOT
Discord Account
dizziee
Operating System
Windows 11 23H2
Linux Only ~ Desktop Environment
No response
What happens when the bug or crash occurs?
Every single time I try to share my capture card.
What is the expected behaviour?
I expected Vencord to be able to share ...
viral oyster
why isn't vesktop universal actually
{
"target": "default",
"arch": [
- "x64",
- "arm64"
+ "universal"
]
}
how big does the binary get
viral oyster
building rn
failedTask=build stackTrace=Error: Command failed: codesign --verify --deep --strict --verbose=2 /Users/splt/projects/Vesktop/dist/mac-universal/Vesktop.app
/Users/splt/projects/Vesktop/dist/mac-universal/Vesktop.app: nested code is modified or invalid
horror
probably a beta skill issue nvm
viral oyster
how big does the binary get
| type | universal | arm64 | x64 |
| ------------------ | --------- | -------- | -------- |
| Application (.app) | 432.5 MB | 242.4 MB | 252.5 MB |
| Disk Image (.dmg) | 178.6 MB | 96.8 MB | 104.3 MB |
| Archive (.zip) | 172.5 MB | 93.1 MB | 100.6 MB |
that is only for macos right?
viral oyster
yes
upper pine
Sounds reasonable
I mean ~400MB for a universal binary and no need for users to check what kind of system they're on sounds fair to me
vernal lintel
guh double size
brave tendon
Is there a reason we have the vesktop tray turned off on MacOS? when I was testing custom tray icons, the icon worked correctly on macOS after enabling it
The only difference is that macOS is pretty strict about requiring a 16x16 icon to look good
manic sphinx
Why does Vesktop store everything in .config? Is this intentional? I think it'd make sense if some stuff was saved in .local/share, like Vencord itself.
vernal lintel
like what
manic sphinx
Vencord itself duhhh
vernal lintel
anyway why does it even matter
manic sphinx
organization i guess
i just think it's kinda dumb to have stuff in .config that isn't config
vernal lintel
have u ever looked at ~/.config/chromium
manic sphinx
never installing chrome/ium ill explod
vernal lintel
firefox is even worse it puts it in ~/.mozilla
manic sphinx
i mean
why follow others bad practices
thought I guess it actually doesn't matter much
vernal lintel
its easier
next sundial
I think we should add something like the Clown checkbox that someone talked about here
will probably save time for many issues
I also remember seeing in another repository a checkbox with something like "I confirm that I did not read the issue template and that I am lying in my answers", and it was the only box that was not mandatory to be checked, and a lot of people checked it
collaborators would then quote the marked checkbox in a new comment and close the issue as invalid
simple groveBOT
Discord Account
rozbrajaczpoziomow
Operating System
Debian sid/unstable
Linux Only ~ Desktop Environment
i3wm/lightdm on X11
What happens when the bug or crash occurs?
The crash happens after selecting any one of these screenshare sources, up to that point everything is fine.
seems like it loads for a split second then crashes.
Here's a video, in case that helps in any...
gentle hatch
hope I didn't forget anything
gentle hatch
Update venmic
okay yeah that worked sowwy :3 βββββββββββββββββββββββββ
hybrid fjord
@upper pine is there any way to venmic add checks for newer version?)
upper pine
<@349609234985517057> is there any way to venmic add checks for newer version?)
Newer venmic versions?
Sure
hybrid fjord
yep
upper pine
I can simply query the latest tag on startup and compare the semver
hybrid fjord
I had same issue and i was trying everything except updating venmic for long time xd
gentle hatch
also whilst I'm here, is this supposed not to automatically close and weirdly change height when selecting?
hybrid fjord
so maybe some message that venmic is outdated would be useful
but i'm not sure how to do it properly for builded releases of vesktop
upper pine
Yes you can select multiple
upper pine
so maybe some message that venmic is outdated would be useful
but i'm not sure h...
I know the Venmic version, it's a compile time constant, can easily check
gentle hatch
only lets me select 1 and there's no indication for that either way
hybrid fjord
also whilst I'm here, is this supposed not to automatically close and weirdly ch...
oneko ^-^
hybrid fjord
I know the Venmic version, it's a compile time constant, can easily check
i mean that if user uses builded version then message like "update venmic" is not useful/correct
upper pine
only lets me select 1 and there's no indication for that either way
None and Entire System are "exclusive"
The checkmark should convey that it's multi-select, but it's discord components, there's sadly no way to do it better without rewriting the component
gentle hatch
oh ic
upper pine
i mean that if user uses builded version then message like "update venmic" is no...
I mean would still be useful, something like: "venmic is outdated, in case of issues try building Vesktop from source" or smth
hybrid fjord
yeah message like this makes sense
gentle hatch
oki das all my questions answered, thanks yall βββββββββ
hybrid fjord
can i somehow inspect vesktop modal and edit css in real time?π
nvm, found out
gentle hatch
okay yeah that worked sowwy :3 βββββββββββββββββββββββββ
I'm just gonna add a blind pnpm i in my vesktop script lol
brave tendon
can i somehow inspect vesktop modal and edit css in real time?π
nvm, found out
Let me know how you did it please lol
hybrid fjord
Let me know how you did it please lol
Ctrl+Shift+I to open Dev menu
And iirc Ctrl+Shift+C and hover on element for inspecting
I don't have electricity rn so can't say surely
teal summit
gnome finally merged accent colours
finally
simple groveBOT
humble mortar
gonna explod
brave tendon
gnome being behind the times as usual
upper pine
thanks was about to say this :D
humble mortar
thanks was about to say this :D
humble mortar
gnome finally merged accent colours
@hybrid fjord no reason not to implement dbus stuff now for Linux accent
vernal lintel
just use a dropdown lmao
hybrid fjord
for custom icons color not be applied
but i don't know best way to add dropdown for this
something like "Choose tray icon to edit"? and dropdown and show only one switch and icon chooser
humble mortar
for custom icons color not be applied
whar wdym
humble mortar
click the icon ?
hybrid fjord
no no i mean setting custom color like green red and so on
humble mortar
put it in a box so its obviously clivkable
ohh
just a colour picker yeah?
or did u want it like per icon
hybrid fjord
for now if using stock icons it just replaces hardcoded color from .svg to user-specified in color picker
hybrid fjord
yes
there is/would be ability for user to pick custom .png for any icon so he can edit it in some apps and just use any color user wants
hybrid fjord
V just said to use dropdown
and i did not understand how exactly in UI
hybrid fjord
can i in drop down use custom elements or it's just one text line?
it can be like multipick for stream settings
vernal lintel
hmm dont do dropdown then yeah
hybrid fjord
xdd
only my wish is to move switches to left somehow
but i'm not sure its possible
without editing discord component
hybrid fjord
hmm actually i can
marsh hinge
imo that would look better
hybrid fjord
marsh hinge
i meant the text on the left as well
hybrid fjord
need to move text only
marsh hinge
is that not possible
marsh hinge
alright
hybrid fjord
but later bc my electricity will drop out for me after 30 secs xd
marsh hinge
π
humble mortar
guh
hybrid fjord
need aligning only
humble mortar
have it auto enable when u change the icon
and when the icon is changed a reset button appears
hybrid fjord
sounds like better UX and more pain for creating T_T
but this actually can fix some problems in logic
hybrid fjord
Yeees
And they did update portal
Now while starting stream you need just to choose window once, not like pick and click "Start"
humble mortar
Now while starting stream you need just to choose window once, not like pick and...
nope still requires it twice for me
hybrid fjord
π¦
humble mortar
FINALLY
WE ARE BARRACK
how the guh do i enable fake session restore
it isnt working for electron apps π
simple groveBOT
Discord Account
.yojo.
Operating System
Steamos/archlinux + kde
Linux Only ~ Desktop Environment
KDE
What happens when the bug or crash occurs?
so there is no game activity tab, and i can't set custom shortcuts
What is the expected behaviour?
vesktop defines itself as desktop app and has its features
How do you recreate this bug or crash?
- open vesktop
- ...
brave tendon
next sundial
Yes you can select multiple
I still find it confusing tbh
like, I know how it works, but for the average user I still think it would not make much "sense"
since there's no clear indication of multiple selection and users will then presume the menu staying open is a bug
upper pine
Propose a Change :D
hybrid fjord
it is not ideal variant but i really do not see any better way how to make it without editing discord component
so i believe that Curve did the best he can
hybrid fjord
need aligning only
should i show image first or "Main icon" text first?
upper pine
> propose a change
[JOEstare](https://cdn.discordapp.com/emojis/7807734513837015...
Ctrl is also bad ux
Who's gonna tell you to hold Ctrl to select multiple
humble mortar
experience with using a computer
humble mortar
should i show image first or "Main icon" text first?
are you not going with the no toggle design?
humble mortar
guh 1984 i cant automatically merge #517 and #355 anymore
humble mortar
have it auto enable when u change the icon
no i meant this
hybrid fjord
What's 335
humble mortar
What's 335
the splash pr
hybrid fjord
no i meant this
I'm doing right it:
Firstly on left only text and icon
If you click on icon and choose another icon then button "Reset" shows up
hybrid fjord
guh 1984 i cant automatically merge #517 and #355 anymore
At least 576 is at 517 :3
hybrid fjord
But not remove branch yet
hybrid fjord
Ohh fine then)
hybrid fjord
guh 1984 i cant automatically merge #517 and #355 anymore
There anyway must be some work for unifying them, not just merging
I mean what if in two PRs there is IPC calls which do same thing but in slightly different way and with different names
Keeping them all is not good
humble mortar
There anyway must be some work for unifying them, not just merging
I mean what ...
yep yep
ive just been merging them locally so i can have a custom splash atm
hybrid fjord
xdd understood
humble mortar
thats the whole point of making #667
hybrid fjord
i did same before for tray icons + keybinds
humble mortar
i did same before for tray icons + keybinds
how scuffed is the keybinds pr
humble mortar
#326 or #609?
humble mortar
guh 1984 i cant automatically merge #517 and #355 anymore
they merge fine via github desktop but not from the cli
hwuhh
humble mortar
wait it works from the cli?????
humble mortar
pkgbuilds are cooked
hybrid fjord
you about 609?
humble mortar
nono
humble mortar
guh 1984 i cant automatically merge #517 and #355 anymore
these
brave tendon
icons on left much better imo
vernal lintel
that ui is bad either way
hybrid fjord
T_T
vernal lintel
it doesnt look like it belongs into discord at all
try to stick to discord components
and what in the world is that font
vernal lintel
try to stick to discord components
like Forms.* is usually a safe bet
hybrid fjord
its custom mine from quickcss
humble mortar
I have feeling like icon on left are better
i meant on the far right
the right of the window
but yeah
it shouldnt be a popup
i dont think anything else on discord uses a popup
hybrid fjord
but putting them all right into Vesktop settings is too much
for now it is like
and this modal
humble mortar
use a dropdown?
vernal lintel
popup is fine
just that ui does not look very good
your ui should look like it could be part of normal discord
hybrid fjord
yeah i understand but for now i do not have ideas what can i change to suit discord more
in stock discord there is no even settings like this
humble mortar
you could clone the privacy settings popup
replace the toggles with the icon buttons
vernal lintel
humble mortar
TRUE
hybrid fjord
i'll try to reprod it
but maybe firstly do some clean-ups and commit all what i have now
hybrid fjord
what about this pencil thing on hoverπ
next sundial
Propose a Change :D
close by default, require CTRL to select multiple sources, add tooltip about using CTRL
AFAIK multiple sources only work on Linux, and I believe this only works on Vesktop (and not official Discord with Vencord; please correct me if I'm wrong)
and then, considering that Smoothness/Clarity option has an explanation there I think it would not be difficult to add an explanation/tooltip for audio too
while CTRL may be bad UX without having a tooltip, not having a tooltip and not closing by default is also bad UX :v
IMO, multiple sources should be behind an advanced option (such as the "Open Audio Settings" present there), because I don't think the average user is going to bother to select multiple sources when they can simply select Entire System
upper pine
close by default, require CTRL to select multiple sources, add tooltip about usi...
Still unsure about this but if we already have the tooltip component I might as well add it
hybrid fjord
And pencil i not removed, so can change icon using clicking on icon or clicking on button
upper pine
Much better
hybrid fjord
do i need to add this background?
brave tendon
Definitely a lot better
humble mortar
not good for me
this with a description on the left explaining what the iconj is
hybrid fjord
this with a description on the left explaining what the iconj is
But there description is a little bit upper
Personally I prefer last screenshot
next sundial
not good for me
you would also have to centralize the texts (main icon etc.)
not sure, I think centralized seems more "natural", but I'm fine either way
next sundial
And changed titles from h2 to h3
I would suggest CAPS LOCK, seems to fit Discord better
maybe H3 + caps lock + bold?
humble mortar
But there description is a little bit upper
Personally I prefer last screenshot
show?
next sundial
this with a description on the left explaining what the iconj is
we can have the description on the right and the icons on the left
humble mortar
we can have the description on the right and the icons on the left
wait yeah thats better
simple groveBOT
hybrid fjord
we can have the description on the right and the icons on the left
Few mins and I'll screenshot it
Walking my dog ^^
rather she walking me
next sundial
LGTM
in this case I prefer uppercase initials "Choose Icon", "Speaking Icon" etc.
but that's just a preference of style
next sundial
π you forgot idle icon, but yeah, that's it
hybrid fjord
it is big, just font
next sundial
:p
and that follows accent color?
also, one additional issue
we can't ship discord icons on Vencord due to trademark restrictions
we would have to use the vencord logo somehow
at least for main icon
hybrid fjord
accent color may be proposed as first color in color picker presents
hybrid fjord
we can't ship discord icons on Vencord due to trademark restrictions
discord icon is custom picked by me for reference
and another svgs (muted, deafened) is taken from Google iirc. Speaking and idlying created manually
simple groveBOT
hot juniper
whats stopping you from stealing the SVGs from the discord client code itself 
hybrid fjord
they are like 3 pixels T_T
hot juniper
do you know what SVG stands for
hybrid fjord
but they are .png at discord folder
hot juniper
dont use the ones they ship there just recolor them in the discord website maybe?
hot juniper
but they are .png at discord folder
i hate those ones dont worry
shell moat
how to fix it with channeltabs?
vernal lintel
v+ needy @shell moat
hybrid fjord
V, what do you think?
hybrid fjord
And changed titles from h2 to h3
and we have this, it's currently pushed
next sundial
I would suggest an option or a clear highlight for the accent color
I remember Windows
it has an option like "Use the accent color from my wallpaper"
we can do something similar
"Use the acccent color from my system"
hybrid fjord
I would suggest an option or a clear highlight for the accent color
on macos and windows accent color would be first color in this proposed colors
next sundial
if checked, user can't use custom color, you have to first uncheck it
hot juniper
"Use the acccent color from my system"
vesktop already exposes this in a CSS variable so its entirely possible
next sundial
but it is not clear at first sight that it is the accent color
I think a greater distinction would be nicer
hybrid fjord
i understood but dunno
next sundial
maybe like a separate row above the others with
"Accent color: [color here]"
then another row with the suggested colors
wait lemme draw this on paint
hot juniper
v+ needy <@903312902231040020>
omg i just checked they're using my fork of channeltabs too π is that why they came here
if you read this do note I am rewriting that it is built on too much technical debt
its super buggy too 
hybrid fjord
but i can't edit discord component T_T
hot juniper
why dont you steal this instead
hot juniper
why dont you steal this instead
make default be the accent color
next sundial
call system
hybrid fjord
no way i will redo color picker now
vernal lintel
no
hybrid fjord
i will add accenbt for linux but ui is pain
vernal lintel
look at PinDMs
next sundial
vernal lintel
how it gets colour picker
hybrid fjord
why this bad
next sundial
that is from KDE, I believe gnome has something similar
humble mortar
that is from KDE, I believe gnome has something similar
you are NOT calling the global colour picker for that guh
also windows
and mac
next sundial
you are NOT calling the global colour picker for that guh
I mean
it serves its purpose
but I agree
may be too much
humble mortar
why this bad
I dont really see the issue with it
next sundial
why this bad
not bad, there's just no indication of the first option being the accent color
humble mortar
just change the description
next sundial
as I understand it, the first option would always be the accent color
next sundial
just change the description
yes, that's what I thought
humble mortar
the second option is so you can see it in light/dark themes
should def change the wording tho
Tray icon colour
the main colour of the tray icons - Defaults to system theme
Tray icon accent
the accent colour of the tray icons - Defaults to system accent
prob could have better wording but thats the gist of what it should be
humble mortar
> Tray icon colour
the main colour of the tray icons - Defaults to system theme
and change the auto option to "Default"
next sundial
out of context, I remeber seeing an issue or PR on Vesktop about having notification badges on the system tray icon
IIRC, default Discord doesn't do it
if you are pinged @next sundial discord only shows the number one notification badge on the taskbar, while the system tray only has a red dot
on the system tray, the red dot is only used if pinged IIRC, it isn't used for unread messages on a channel with notifications on (but I could be wrong)
on the taskbar the red dot without number is used for unread channels
next sundial
yes, default Discord has a weird behavior with the unread badge
I would even say bad UX
humble mortar
on the taskbar the red dot without number is used for unread channels
wait whar
???
next sundial
example
if you don't mute a server
the unread badge (red dot icon) will also show on the taskbar icon
on the app icon
humble mortar
I thought the red badges were just for unread pings
like it'd mirror the in app red badge on the top left
next sundial
no, it could also be for unread messages if a server is unmuted
and this is global, works for all servers
no way to customize it on a per-server basis IIRC
next sundial
no, it could also be for unread messages if a server is unmuted
but only on the taskbar
system tray red dot is only for pings if I'm not mistaken
simple groveBOT
Discord Account
No response
Operating System
Windows 10 22H2 19045.4529
Linux Only ~ Desktop Environment
No response
What happens when the bug or crash occurs?
Depending on the screen share settings I put, when I try to stream into a channel I get this error:
When I don't share audio, it works fine. When I do, that error pops up.
What is the expecte...
next sundial
good ending
hybrid fjord
xdd
humble mortar
lmao
next sundial
here @humble mortar
found a screenshot on #π₯-vencord-support-π₯
look at the discord icon on the taskbar
that unread badge is for unread channels on unmuted servers
same thing for previous versions of Windows too
hybrid fjord
also need to mention for accent color
on windows setting color of icons to accent colors makes icons be the same or almost the same color as the panel and icons not visible good xd
next sundial
the red dot from the system tray is only for pings IIRC
or it could be for both pings and unread channels
but I dunno, I've been using Vesktop for ~3 months now and I can't remember the official behavior
next sundial
also need to mention for accent color
on windows setting color of icons to accen...
hum
you could add an exception
if platform == win32 then don't suggest accent color
maybe use windows blue default
hybrid fjord
but accent color works only on win and mac xd
next sundial
huh
but freedesktop merged accent color recently if I'm not mistaken
should be available for linux too
hybrid fjord
nvm users have ability to choose any color they want so this up to them
next sundial
well
if you prever to remove accent color I'm fine with it
maybe we should leave a default, probably pink due to Vesktop icon
(like the screenshots you provided before)
next sundial
no no I'm saying a possible way to get system accent color
not the color picker
the color picker we use from Discord
oberon made it look like we can't know the accent color from the system
but I think that even if there's not a freedesktop "global" implementation then there's possibly something from GNOME and/or KDE
humble mortar
ive been yapping about this for a while
its on the PR roadmap too
he knows about it
hybrid fjord
Yeah I just don't know the best way for working with DBus
Should I connect some lib for this (and even for other features in future) or should I just use CLI commands
Anyway picking accent color is not a major feature so maybe we can even let electron to implement it
humble mortar
I dont really like the idea of waiting on electron to implement it as its been an implemented standard for months and nothings happened on the electron side
let alone unread indicators
hybrid fjord
Where else we had an need of dbus calls from Vesktop?