#π₯-vesktop-development
simple groveBOT
upper pine
@vernal lintel https://github.com/Vencord/Vesktop/commit/d3b94fc4df6eec3f93a0689309760e2bb3e96249 can't we cross reference issues like this from official discord? Surely they must use similar flags to prevent the issue? Or is that all handled somewhere in their native stuff?
vernal lintel
wdym
i dont understand
oh do you mean the app.commandLine.appendSwitch("disable-renderer-backgrounding");
they do have it
if (process.platform === 'win32') {
disabledFeatures.push('CalculateNativeWinOcclusion');
app.commandLine.appendArgument('--disable-renderer-backgrounding');
app.commandLine.appendArgument('--disable-backgrounding-occluded-windows');
app.commandLine.appendArgument('--disable-background-timer-throttling');
}
they didnt have it a while ago when i checked lol
so that means they added it recently xd
hybrid fjord
so that means they added it recently xd
By reading this chat
vernal lintel
you can check discords natvie code easily, its not even minified
DiscordDir/resources/app.asar ~ main entry point which does bootstrapping
~/.config/discord/0.0.x/**/*.asar ~ other native modules
for me (with flatpak), the locations are /var/lib/flatpak/app/com.discordapp.Discord/current/active/files/discord/resources and /home/vee/.var/app/com.discordapp.Discord/config/discord
you can extract the files via ```sh
pnpx @electron/asar extract app.asar app-extracted
and after making changes repack them with ```sh
pnpx @electron/asar pack app-extracted app.asar
upper pine
so that means they added it recently xd
interesting :D
vernal lintel
```js
if (process.platform === 'win32') {
disabledFeatures.push('CalculateNati...
im gonna add the other flags too
to vencord
idk why they only add them on windows
it happens on linux as well
upper pine
`DiscordDir/resources/app.asar` ~ main entry point which does bootstrapping
`~/....
Yeah just wanted to say because it would probably be good if we look into which flags they use and use them as well
vernal lintel
already been doing that xd
upper pine
oh nvm then xd
sour muralBOT
https://github.com/Vencord/Vesktop/blob/main/src/main/index.ts#L47-L58
index.ts: Lines 47-58
// work around chrome 66 disabling autoplay by default
app.commandLine.appendSwitch("autoplay-policy", "no-user-gesture-required");
// WinRetrieveSuggestionsOnlyOnDemand: Work around electron 13 bug w/ async spellchecking on Windows.
// HardwareMediaKeyHandling,MediaSessionService: Prevent Discord from registering as a media service.
//
// WidgetLayering (Vencord Added): Fix DevTools context menus https://github.com/electron/electron/issues/38790
disabledFeatures.push(
"WinRetrieveSuggestionsOnlyOnDemand",
"HardwareMediaKeyHandling",
"MediaSessionService",
"WidgetLayering"
);
simple groveBOT
vernal lintel
how well is the venmic pr coming along?
i wanna make a release soon
no rush, just wanna know if i should release with or without it :p
upper pine
how well is the venmic pr coming along?
Uhh will prob finish it this week :D
But if possible I'd like to include it into the release
If that's ok ^^
hybrid fjord
@azure verge chromium fix for dropping corrupted buffers is merged
upper pine
cant wait for it to finally get to us in 100 years
distribute your own electron builds
hybrid fjord
On Gecko xd
upper pine
Lmao
azure verge
that just sounds like a huge pain
upper pine
that just sounds like a huge pain
I guess if the CI runs it runs
Just need to make that work lmao
How hard can it be :P
upper pine
How hard can it be :P
he was never seen again
azure verge
real
upper pine
bro
why does updating rust packages
take a bazillion years
fuck rust
seriously
faster compile times my ass
azure verge
i fucking love rust i just want them to ACTUALLY IMPLEMENT THE FUCKING GODDAMN IDFK
just
i hate that it compiles every library statically
instead of using system libs
upper pine
yeah thats so stupid as well
That should be opt in
Instead of opt out / impossible?
vernal lintel
I guess if the CI runs it runs
yeah we did this for our hermes fork in aliucord
takes like half an hour to compile but we just used github actions so it was like whatever
upper pine
takes like half an hour to compile but we just used github actions so it was lik...
laughs in venmic arm build
upper pine
takes like half an hour to compile but we just used github actions so it was lik...
Github CI is such a blessing
vernal lintel
also same with vencord installer 
to compile for windows / mac i just use actions
hybrid fjord
V, what do you think about printing Vesktop version to console when program starts?
for seeing actual version in debug logs in issues
hybrid fjord
most informative comment
gentle hatch
the fuck is cachyos
upper pine
@vernal lintel I'll try to finish my PR tomorrow
I need a break today π
Just spent 7+ hours on group project
Fuck Javas Generics
They're so ass, why do they even exist when they are always type-erased?? They literally have almost no benefit at all
upper pine
Are they better?
azure verge
sleeby
azure verge
the fuck is cachyos
some arch based distro I've seen popping up here and there
I know nothing about it
simple groveBOT
hybrid fjord
It would be great actually
upper pine
I can read "C++ bad" between the lines here :(
upper pine
@vernal lintel Is that alright?
upper pine
depending on how granular I want to make the selection I'll probably have to update venmic as well as it currently only supports selecting a target by a single property, which I should probably expand to multiple properties, this would also solve the issue in #619 without making the exclude logic super fucked
But the whole ScreensharePicker logic is now super complex which I strongly dislike
I'll try to come up with a clean(er) solution throughout the day
simple groveBOT
hot juniper
<@343383572805058560> Is that alright?
this is confusing. does this mean apps have to explicitly be pipewire native?
aka no pulseaudio compat?
upper pine
this is confusing. does this mean apps have to explicitly be pipewire native?
No, they just have to run within pipewire-pulse
Pulse setups are not supported yet (i.e. where apps run under normal pulseaudio, not pipewire-pulse)
hot juniper
is there any reason to support them (almost certainly no)
upper pine
Well it would be nice if we had native pulse support as well, but that is a little fucked so it's not a priority
hot juniper
<@343383572805058560> Is that alright?
Does this actually check the currently running audio server too?
upper pine
Yes
upper pine
Venmic does the following:
- Query currently running pulse-server
- Is Pipewire-Pulse?
- => Everything good
- Else:
- Show warning
- Is Pipewire-Pulse?
hot juniper
also what does that guide link go to
upper pine
Shows how to install pipewire
hot juniper
link?
upper pine
^
hot juniper
idk how to say this kindly but
this is an awful resource for stupid vencord users
dont assume all of them run ubuntu
or debian
thats how you get #π₯-vencord-support-π₯ questions
upper pine
dont assume all of them run ubuntu
but I thought the same
Maybe we should make a site that shows how to switch to pipewire for multiple distros
A simple github pages site would prob do the job
Should be fairly simple to setup
When Vencord Docs
upper pine
When Vencord Docs
Add it there :)
hot juniper
You are insane (or have this hidden)
upper pine
You are insane (or have this hidden)
hidden π
First screenshot is new
Why didn't I think of that earlier what the fuck
That's infinetly more flexible
hybrid fjord
xd
upper pine
Yes because you may want multiple nodes
upper pine
What the fuck the node test script is crashing for me but GDB crashes as well when attaching to it??
upper pine
Bruh
Pipewire may've fucked everything multi-threading
I hope it's either a bug or I'm doing smth really stupid
Ok nvm looks good
Bro what the fuck is it then
Why the fuck does the node addon in my testing have some threading issues when the server does not
and the thread is the fucking same
what the fuck
tulip quiver
Why the fuck does the node addon in my testing have some threading issues when t...
environment mirrors? nodejs version, addon, option, maybe os diff too?
nodejs addon is thread safe?
tulip quiver
XD
gentle hatch
yourself -> yourself again -> yourself again -> maybe it's a library bug? -> nope, yourself again -> maybe I'll check the library again -> environment -> editor -> standard library -> compiler
- Fox#0001
upper pine
I've blamed my self for 30 minutes, then my library, then venmic, then the STL, then the env and now node
It's failing due to thread-related issues but everything is happening on the same thread??????
WHAT THE FUCK
Ok I found it
gentle hatch
soo what was it
upper pine
Lol how does that even happen
Destructur is called mid pipewire update even though that's literally impossible
gentle hatch
Β―_(γ)_/Β―
gentle hatch
upper pine
HAHAHAHHA
gentle hatch
lmaowhat
gentle hatch
okay I'm just gonna keep using nodejs :3
gentle hatch
too lazy
hybrid fjord
maybe pc issue XD
cpu registry bug
tulip quiver
sounds good
tulip quiver
lol
virtual void method
extremely hot
bruh, i think u should rest XD
idk how u can handle this amount of debugging pain
upper pine
Fixed it
tulip quiver
π₯ π€
upper pine
Lol
hot juniper
time to open a gh issue
fix the CSS yourself, go looking for the .platform-win and .platform-mac CSS selectors within discord's css
simple groveBOT
Discord Account
Lenni_builder
Operating System
macOS 14 (Sonoma)
Linux Only ~ Desktop Environment
No response
What happens when the bug or crash occurs?
There's both the macOS traffic light overlaying the "Discord" text and the and the Windows-like controls on the right.
What is the expected behaviour?
That option shoukd be removed entirely on macOS or it should ...
upper pine
Wow that was really fast for the arm build
I fucked up the TS Typings
fuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuck
Can I change that without a new release
@vernal lintel Can we force update the module typings?
hot juniper
NPM is a fuck
upper pine
Fuck
hot juniper
push 4.0.1 
upper pine
fuck
hybrid fjord
xd
upper pine
45min compile again
Fuck it I'll push manually
Not through the actions
Or I'll add a rescue action thingy that doesn't rebuild
I hope this is right now
Generics in TS are so cursed lol
simple groveBOT
upper pine
aye it works
simple groveBOT
upper pine
I can't tell you how much I hate the code that makes this work
The Vesktop code for this is so fucked
And I can't even extract some of the stuff into helper functions because typescript throws a tantrum then
(due to the fucked types lmao)
Ok nvm Type Guards save the day
hybrid fjord
xdddd
vernal lintel
π
hybrid fjord
Last one i swear
plz restπ
heady merlin
@vernal lintel do you want me to host a arm runner for venmic?
tulip quiver
I just drank massives amount of black tea
heady merlin
I can use my oracle server for it
vernal lintel
what's this access token about @upper pine
heady merlin
I have one already for a personal organization, can just make a new onefor venmic
vernal lintel
venmic-reuse
upper pine
what's this access token about <@349609234985517057>
Required to download older artifacts
vernal lintel
<@343383572805058560> do you want me to host a arm runner for venmic?
i did in the past but something didn't work so we scratched the idea
i don't remember what it was
upper pine
You can now select by:
- Name
- Name/Binary & PID
- Name/Binary & Current Media
I guess that should suffice for most
heady merlin
upper pine
And you can also select multiple ofc
heady merlin
we could try, it's super easy
vernal lintel
do u remember what it was noah?
upper pine
no idea
heady merlin
I just need access to manage the runners in venmic
upper pine
I think it was too fucked to setup?
Or I made the QEMU thingy and we just went with it
I think it was the latter lmao
vernal lintel
i mean sure u can nuckyz but let me check first why we scratched it
heady merlin
actually
give me access to the vencord repo
I will make an organization level runner
heady merlin
lmao
upper pine
haha
vernal lintel
let's hide this behind some advanced selection
or is it somehow possible to have dividers in the select menu
upper pine
You need to enable this:
vernal lintel
oh
upper pine
Will push now
upper pine
We should add a pipewire guide there I guess
btw what about this?
vernal lintel
it would be better having it in vesktop
the instructions are pretty small
you could open a separate modal with instructions
vernal lintel
what other distro
it's just ubuntu / mint
arch users will figure it out themselves
upper pine
True, does fedora use pipewire by default now?
vernal lintel
and even ubuntu already has pipewire server running cause it needs it for wayland capturer
pipewire screencapture
so it's just two commands (install wireplumber instead of pulseaudio media session and enable it)
so i would say just make a modal with these two ubuntu commands and also link to the relevant arch wiki and it should suffice?
upper pine
I'll push what I have rn, would you mind adding the modal? Not sure how you'd want it to be, just a second modal ontop of the screenshare modal?
vernal lintel
give me access to the vencord repo
ill do this too
but first i need to cook some tea
vernal lintel
TBD
upper pine
Is that sweetened?
vernal lintel
what π
upper pine
I'll bump venmic again in #621 to 4.0.2 once it's finished
vernal lintel
to be discussed / decided
tulip quiver
cocoa boba πΊ
vernal lintel
What kinds of teas do you drink?
my favourite has to be ginger lemon
but i like a lot of teas
upper pine
I'm more into the earthy/smokey ones
vernal lintel
i still live with my mum and she has a cupboard of teas
upper pine
Nice, I have two compartments in my cupboard dedicated to tea as well xd
But I think the best I drank is still Dragon Pearl Jasmine
vernal lintel
omg wasserkocher ist mega verkalkt
heady merlin
ill do this too
okay just let me know when you do
tulip quiver
But I think the best I drank is still Dragon Pearl Jasmine
wooow dragon pearl jas soo good, do u know chrysanthemum green? if so, have u tried it?
heady merlin
I can deploy this from my phone 
upper pine
wooow dragon pearl jas soo good, do u know chrysanthemum green? if so, have u tr...
Have not tried that yet, sadly no store near me seems to have it
tulip quiver
ahh i see, sadge
upper pine
omg wasserkocher ist mega verkalkt
essig
vernal lintel
yep
upper pine
wooow dragon pearl jas soo good, do u know chrysanthemum green? if so, have u tr...
do you know of any online store that might sell it? Have bought tea online yet but I wanted to try it for some time now so I might as well order it
Lol I restarted pipewire and now Electron Screenshare is fucked
time to reboot ig
tulip quiver
i havent really ordered tea online, one of my friends deals with it and gets it for me so π«΄ but if u want to buy, i recommend trying osmanthus green, lily jasmine, and jasmine silver needle if available in the stop, these are all special π€€
tulip quiver
Lol I restarted pipewire and now Electron Screenshare is fucked
tauri likes the message
upper pine
i havent really ordered tea online, one of my friends deals with it and gets it ...
wow thats amazing
upper pine
*tauri likes the message*
saucer abducts tauri
tulip quiver
upper pine
Alr PR is now ready, I hope the changes are alright, they're a tiny bit messy but I couldn't think of a nicer way
simple groveBOT
upper pine
Alr PR is now ready, I hope the changes are alright, they're a tiny bit messy bu...
I might add an option to exclude sinks as well
upper pine
I might add an option to exclude sinks as well
@vernal lintel if we add another option the UI will be too small, any idea what we should do? Maybe we could have some toggles in a drop-down Menu like the audio selection
hybrid fjord
maybe create this in Vesktop settings menu?
excluding is like one-time setting for user so probably defining it in Vekstop settings instead of stream picker would be better
upper pine
Or we could open another modal in the screen share picker
Maybe that's not too bad
We would have more space but it would also be easily accessible from the screen share modal
And stream settings should be persistent
I'll look into it
brave tendon
Are stream settings currently supposed to be persistent?
brave tendon
Agreed
upper pine
Which one looks better?
I'm also not quite sure how I can handle the settings, because currently changing the settings is fucked in the modal because it's props aren't updated due to it being a modal
Ah that will probably not matter I can just give it it's own state and then persist the settings I guess?
hybrid fjord
Which one looks better?
Second one to me
upper pine
I like it better as well π
vernal lintel
I'm also not quite sure how I can handle the settings, because currently changin...
useSettings()
upper pine
useSettings()
π
Do I even need an additional state then?
I'll just handle it all globally
Which one?
First one
vernal lintel
second one is vencord settings
vernal lintel
the first one is what you want
upper pine
If I add the audio settings in the Settings Store they will also show up in the Vesktop Settings automatically right?
upper pine
Should I even add a new audio settings modal like this then? Or should I simply open the Vesktop settings?
vernal lintel
If I add the audio settings in the Settings Store they will also show up in the ...
no
upper pine
Okay that's good
vernal lintel
you need to write component
just have it in the modal, settings are already cluttered enough
upper pine
Alright, was just judging by some code I saw for a second
upper pine
just have it in the modal, settings are already cluttered enough
Yeah I'd prefer that as well
How can I set some settings to be default true?
vernal lintel
.setting !== false
cloud graniteBOT
marsh hinge
el fembot
upper pine
I need the settings in here too, should I just pass them from the parent?
(in openScreenSharePicker)
Or can I even get the settings in the venmic.ts? Then we wouldn't have to send workaround over the IPC
I could also remove the grid now
Is no longer needed :)
Lol why is the preview so massive
upper pine
There is a button further down to open the settings
The preview is too massive
How do I make it smaller lol
Was it always that massive before #499???
upper pine
I will change the "Open Audio Settings" button to look a little nicer
vernal lintel
you can make the preview smaller but then you have to add horizontal padding
upper pine
that's why we added the grid
Ah fuck should I add it back then? Because It looks so empty when the settings are behind a modal now
vernal lintel
might look weird
upper pine
Also changed Save to Done
Or should it be Back
I guess back would be better
I guess I'll just shrink the preview?
I think that's the only sane way
Because the grid is too massive now
Something like this?
Idk
The buttons looks weird
How do I make it look better π
brave tendon
i preferred the look of the full-width audio source select with the small link to open venmic settings personally
upper pine
But that's too high
It will cause scroll
Unless I shrink the Preview even further
Maybe add the button down here?
Or is that too weird?
brave tendon
feels out of place there
upper pine
Why is design so fucking hard
I also though about making it an <a> but that feels too out of place for a settings link
Oh
Nvm
I think I got something
brave tendon
also this doesn't look bad to me except the repetition in the heading and button for audio settings sticks out a little bit
brave tendon
you cooked
upper pine
@vernal lintel design approved?
upper pine
Not sure where the extra height came from
- Settings Page
brave tendon
are those the defaults and are they persistent?
actually nvm youre using settings store so yeah they are
upper pine
Last one is default off, but yes, they are persistent
upper pine
Fuck can I even get the Settings in the venmic.ts
hybrid fjord
Fuck can I even get the Settings in the venmic.ts
Yes, there must be a way
upper pine
arrpc does it but when I do it in the venmic ts it breaks the build
vernal lintel
Fuck can I even get the Settings in the venmic.ts
yes
vernal lintel
arrpc does it but when I do it in the venmic ts it breaks the build
?
are you importing from renderer/* in main/*
simple groveBOT
Discord Account
No response
Motivation
Spellcheck, when disabled, is only disabled in the chat window. It is not disabled in other parts of the app. This is an Electron feature.
Solution
https://www.electronjs.org/docs/latest/tutorial/spellchecker/
https://github.com/electron/electron/blob/main/docs/tutorial/spellchecker.md
The solutions seems to be a preference flip. ...
hybrid fjord
xdd what about 5.0
upper pine
I've split one setting up into two, which defies from the old behavior, thus new major version
hybrid fjord
ohh nvm i skipped that there was 5.0.0 already
upper pine
hahahah
upper pine
Doing the QR code does not work.
What the fuck that does not sound related to Vesktop
upper pine
mix bussing π
PR is now done, can we get it into a soonish Vesktop update π π
upper pine
mix bussing π
I think the actual term is a "mix bus", maybe we should change the wording to "... disable this when using a mix bus"
simple groveBOT
simple groveBOT
As temp workaround, is possible to setup a custom icon using the gnome-shell-extension-appindicator extension.
vernal lintel
wait thats cool i didnt know that
upper pine
Aye new logo
simple groveBOT
simple groveBOT
Hides the native macOS window controls if the custom discord titlebar is enabled.
Resolves #631
Old behavior:
New behavior:
azure verge
wtf happened to the button color
simple groveBOT
upper pine
π πͺ π©Έ π πͺ π©Έπ πͺ π©Έπ πͺ π©Έπ πͺ π©Έπ πͺ π©Έπ πͺ π©Έπ πͺ π©Έπ πͺ π©Έπ πͺ π©Έ (Nothing to see here)
vernal lintel
WHAT
hybrid fjord
π πͺ π©Έ π πͺ π©Έπ πͺ π©Έπ πͺ π©Έπ πͺ π©Έπ πͺ π©Έπ πͺ π©Έπ πͺ π©Έπ πͺ π©Έπ πͺ οΏ½...
xddd
I even forgot about this
simple groveBOT
upper pine
π€«
hybrid fjord
we can move stream settings to settings store
upper pine
The latest changes don't add explicit blacklist support but make it possible to select apps so granularly that you might not need an explicit blacklist
Shall I add an explicit additional exclude selection too?
hybrid fjord
The latest changes don't add explicit blacklist support but make it possible to ...
That means that user can just not pick what he doesn't want
hybrid fjord
Or blacklist or button in UI "Pick all" and let user unpick what he doesn't want
Or picking all when user picked "Whole system", dunno
vernal lintel
Shall I add an explicit additional exclude selection too?
i think if we already make a separate section for venmic we're gonna have the necessary space so why not
upper pine
True
I'll add it
Which component should I use for that
Should I Just make a Dropdown that lists the current ones and persits them? Or a proper key-value table?
hybrid fjord
we can move stream settings to settings store
I will try to do it
vernal lintel
we can move stream settings to settings store
nah not settings store
vernal lintel
we should introduce some state
maybe in localStorage
anyway i also wouldn't persist everything
like there's little point persisting audio / screen selection
but stuff like venmic switches & resolution would be good
hybrid fjord
Okay, I need to take a look at this after venmic update merging
hybrid fjord
we should introduce some state
Is there any examples/analogs already in project from where I can take a look?
upper pine
Should I Just make a Dropdown that lists the current ones and persits them? Or a...
@vernal lintel any idea?
vernal lintel
just the same as whitelist should work, no?
one dropdown for include, one for exclude
azure verge
`brand-experiment` -> `brand-500`
how tf did you figure that out
upper pine
one dropdown for include, one for exclude
Sometimes you may want to exclude by specific props
upper pine
Sometimes you may want to exclude by specific props
Or should we just keep it simple for now?
hybrid fjord
Sometimes you may want to exclude by specific props
Like what?
hybrid fjord
Probably adding excluding by this props would be so complicated and not used by 99% users
upper pine
@vernal lintel should I only show exclude when entire desktop is selected?
vernal lintel
sounds reasonable
hybrid fjord
best way is on first start propose max display resolution and then just memorize what user picked
upper pine
one dropdown for include, one for exclude
done :)
hybrid fjord
20 sheeps time?)
upper pine
20 sheeps time?)
Maybe
simple groveBOT
@Vendicated does this commit fix the colors on screen-share picker?
it was blue before (when an option was highlighted), but somehow it's gray now
upper pine
20 sheeps time?)
π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ π πͺ π©Έ
hybrid fjord
xddd
upper pine
I'm not mixing them
I don't
They're meant to be goats
Both are common animals in ritual sacrifices :P
hybrid fjord
we mainly used sheeps
upper pine
we mainly used sheeps
True
But I think we already used goats earlier
What ever you have at hand
Β―_(γ)_/Β―
azure verge
sacrifice!
sacrifice!
I need more sheep blood to complete the ritual
the ritual to summon....
george
upper pine
I think there was a discussion about this further up
Which settings explicitly?
Quality & FPS?
hybrid fjord
I will try to do it after 621 merge
upper pine
I will try to do it after 621 merge
I can also do it in #621
azure verge
I've been exhausted and sleeping like all day lmao but damn I wanna get working on volume boosting grr
hybrid fjord
I've been exhausted and sleeping like all day lmao but damn I wanna get working ...
Did you take a look at VoiceStateStore?
azure verge
Did you take a look at VoiceStateStore?
function g(e) {
var t, n, i;
let {context: r, userId: s, volume: a} = e;
if (s === c.default.getId() || !(0,
T.shouldReadWriteAudioSettings)())
return;
let o = d.default.getRemoteSessionId();
null != o && C(o, s, r, {
muted: E.default.isLocalMute(s, r),
volume: a
}),
t = r,
n = s,
i = a,
(0,
f.updatePendingSettings)(t, n, {
volume: i
}),
O()
}
omfg
so this function is weird
also
im gonna take this to #π§©-plugin-development now that i think about it
humble mortar
@upper pine did you change something about the audio source detection genshin is getting ignored π’
upper pine
Nope
Changed nothing
Send pw-dump
With ignored you mean not shown in the dropdown right?
humble mortar
With ignored you mean not shown in the dropdown right?
and not hooked up when selecting the system option
upper pine
then genshin is doing some weird shit
probably fixed with #621
try that actually
Clone my fork and try with Granular Selection
rancid tartan
im surprised they even bothered
do they have more than 3 linux players for some reason
humble mortar
theres quite a lot
upper pine
I fucking hate CSS
Can someone please fucking burn down everything web
And rebuild it in a sane fucking way
Just take WPF and make it WebStandard
upper pine
css is bullshit
anchors is the only sane fucking choice
Hopefully they'll make it into all browsers soonish
humble mortar
Clone my fork and try with `Granular Selection`
crashes after i select the window (when the settings popup should appear)
upper pine
crashes after i select the window (when the settings popup should appear)
What crashes?
The Picker, Vesktop itself?
humble mortar
upper pine
Gimme a sec
humble mortar
upper pine
Do you get any console logs (not browser)
hybrid fjord
Good thing that you have this bug before sacrifice 20 sheeps and before merging
upper pine
Don't see how that's happening
Undefined is accepted by venmic
Yeah
That's the issue lol
Did you pnpm install?
hybrid fjord
xdddd
humble mortar
Did you pnpm install?
ya
humble mortar
this is so cooked
running it again updated venmic
works now π
I literally freshly cloned and pnpm i how was venmic not latest
upper pine
idk native deps are weird
Fuck my playlist is so ass
When you have granular enabled you prob want to pick wine
humble mortar
small UX thing -- after selecting the audio source the popup should close to allow changing other settings
humble mortar
When you have granular enabled you prob want to pick wine
didnt even need it
genshin exe shows up now
hybrid fjord
small UX thing -- after selecting the audio source the popup should close to all...
No prob
Because it's multiple choice
upper pine
genshin exe shows up now
humble mortar
this obviously means you changed something in other versions of venmic :3
upper pine
I'm actually just passing different params to venmic from vesktop :3
upper pine
Because it's multiple choice
yep, multiple choice so it's prob more convenient to stay open
I could actually make a switch to enable multiple apps
But that would be too much settings
hybrid fjord
Ideal way is actually to improve UX somehow π
upper pine
I mean it's pretty solid now imo
hybrid fjord
Bc if user want to pick one app he should manually close it and idk
upper pine
True but how would we satisfy both needs
without an addtional toggle?
Hold Shit for multiple?
hybrid fjord
xdd i dont really know
upper pine
but no ones gonna figure that out lmao
azure verge
Hold Shit for multiple?
i love holding shit
hybrid fjord
xdd
hybrid fjord
i didn't even noticed ahahah
upper pine
hzahahahahahahaha
upper pine
Shit is about to get real
hybrid fjord
i held shit and it didnt let me
thats what we would see in new issues after pr merge
azure verge
LMAO
simple groveBOT
upper pine
REAL
humble mortar
ctrl for multiple specific selections and shift for a point to point group selection
azure verge
^
azure verge
that's standard behavior
humble mortar
yep
azure verge
i doubt its THAT hard smhhhhhhhhhhhh (im joking)
azure verge
@upper pine next thing you know someone is going to ask for OSS support
upper pine
They already did
vernal lintel
honestly if i were you i would just close as not planned xd
or tell them to implement it themselves and pr
azure verge
real
simple groveBOT
UPDATE2 - Windows Snap Working with Tweaks Below
Happy to report all the shortcuts are working now for me!
Unfortunately small, ugly, title bar at top, but no biggie.
hybrid fjord
29.17 bug returned to meπ
next sundial
about the widgetlayering (devtools context fix): it was removed from both vesktop and vencord, and now it has returned to vencord. shouldn't it be included back in vesktop then, or does this vencord code apply to vesktop as well?
vernal lintel
it is fixed in new chromium versions
azure verge
29.17 bug returned to meπ
oh no....
azure verge
29.17 bug returned to meπ
ill test in a bit
hybrid fjord
ill test in a bit
It was in server channel with only viewer on windows native discord client
Just for info
hybrid fjord
ye ill test in a bit when a fren gets out of bed
xd
next sundial
it is fixed in new chromium versions
so I guess Vesktop already has the Chromium version with the fix applied, while the official Discord client does not have it (and that's why it's still included on Vencord, but not on Vesktop)?
vernal lintel
yes
azure verge
HJASHKGJDHKJALHJA
simple groveBOT
azure verge
I'm unlucky xd
idk
it might be a bit weird tho
this is not 60fps
i set it to 15
hybrid fjord
maybe bug with async changing
azure verge
it didnt update
yeah
most likely
you were the one who did that
so idk how it works
hybrid fjord
its changing in that one setTimeout
hybrid fjord
prob need to bigger timeout?
upper pine
What is homie smoking
upper pine
Yeah lmao
hybrid fjord
i have no idea
but we need that too
upper pine
Yes
azure verge
ja
azure verge
real
simple groveBOT
hybrid fjord
iirc arrpc has a list of detectable games
and looks like they not update them frequently
And also adding new game is very inconveniently bc list is in very very long one line
https://github.com/OpenAsar/arrpc/tree/main/src/process/detectable.json
Why not make it normal jsonπ
1.4 megabyte of fucking one line
marsh hinge
iirc arrpc has a list of detectable games
and looks like they not update them fr...
it is normal json, it's just minified, you can beautify it, add your own and then minify it again, or just add it to the one line since theres not that much to be added
hybrid fjord
it is normal json, it's just minified, you can beautify it, add your own and the...
Yeah it normal, I mean why not store it already beautified π¦
marsh hinge
Yeah it normal, I mean why not store it already beautified π¦
to save on size
beautified would be alot bigger
marsh hinge
almost double
simple groveBOT
Discord Account
No response
Operating System
Arch Linux
Linux Only ~ Desktop Environment
Plasma on Wayland
What happens when the bug or crash occurs?
In settings, no Vencord settings are shown, and when Vesktop prompts Vencord update, gray screen is shown. The issue is present on both AUR and AppImage versions.
![Screenshot_20240604_110238](https://...
hot juniper
iirc arrpc has a list of detectable games
and looks like they not update them fr...
They take this file from Discord
hybrid fjord
They take this file from Discord
sadly
probably taking this list and adding games manually would be better
vernal lintel
iirc arrpc has a list of detectable games
and looks like they not update them fr...
discord fetches it dynamically from their api
i told ducko to do the same for arrpc but they refused
maybe we should just fork
azure verge
maybe we should just fork
honestly
itd be nice to make it something you can add to
like desktop discord
yk
"select running process"
and then maybe save user overrides (any changes they made to the default list, not the entire list) to the user settings so they can be uploaded to the cloud if the user so wishes
simple groveBOT
upper pine
maybe we should just fork
maybe we could also improve detection for some games then?
not sure which ones were kinda broken but I remember people complaining
it's probably due to non matching binaries, we would have to fetch /proc/.../cmdline to get the actual windows binary for wine for example, not sure if arrpc already does that, apologies if it already does
hybrid fjord
maybe we could also improve detection for some games then?
Ghost of Tushima not detecting for me
prob discord already updated it but arrpc not fetched
upper pine
easier would be just to rewrite
...in c++ 
hybrid fjord
ofc
vernal lintel
if we fork let me write it in C++ lmao
honestly wouldnt be a bad idea
upper pine
lets fucking go
vernal lintel
the current one constantly spawns shell processes
well
on windows
on linux it reads /proc
upper pine
Oh that could def be improved
vernal lintel
it would be better to use a memory safe language like rust
upper pine
~~it would be better to use a memory safe language like rust <:blobcatcozy:10265...
C++ is memory safe if you actually use your brain
vernal lintel
noppp
hybrid fjord
we can safely control memory in C++ too
upper pine
i will convert u to rust noah
There is no way that will ever happen
sly cairn
me when EnumProcesses
BOOL EnumProcesses(
[out] DWORD *lpidProcess,
[in] DWORD cb,
[out] LPDWORD lpcbNeeded
);
my beloved
upper pine
xD
sly cairn
discord-rustpc
upper pine
well rust would be better
hybrid fjord
venpc
sly cairn
discord-r(s)pc
upper pine
yes
sly cairn
why dont you like it
hybrid fjord
let's rewrite venmic on rustπ
vernal lintel
upper pine
I hate the syntax, fuck unwrap on literally everything, I love C++ too much to switch, templates are ass in rust (they are literally ass in every language except c++), no way I'm going to wrap every single fucking C library to start using it, compiling takes ages, all tech bros love it - so I must hate it
sly cairn
I hate the syntax, fuck unwrap on literally everything, I love C++ too much to s...
there's a macro that fixes this
you think i was joking
trait MyTrait {
fn compute_value(&self, x : i32) -> i32;
}
cpp!{{
struct TraitPtr { void *a,*b; };
class MyClassImpl : public MyClass {
public:
TraitPtr m_trait;
int computeValue(int x) const override {
return rust!(MCI_computeValue [m_trait : &MyTrait as "TraitPtr", x : i32 as "int"]
-> i32 as "int" {
m_trait.compute_value(x)
});
}
}
}}
i am not.
vernal lintel
what the fuck
upper pine
https://docs.rs/cpp/latest/cpp/macro.cpp.html
If I were to ever write rust again, my code would start with cpp!( and end with )
I actually knew this existed
sly cairn
very good
upper pine
Only sane way to write rust code
sly cairn
now please appreciate what my friend made
use lua_macro::{lua, lua_eval};
#[cfg(test)]
mod tests;
fn main() {
println!("hi from rust");
lua! {
function say_hi()
print("and hi from lua!")
end
say_hi()
};
let a: i32 = lua_eval! {
2 + 2
};
println!("{a}");
}
that's actually pretty cool
sly cairn
compile time lua
is very fun
it does have a couple of uses, buildscripts i can think of can benefit
since its a full lua interpreter you can require() stuff
upper pine
I hate the syntax, fuck unwrap on literally everything, I love C++ too much to s...
Also I'm way to deep into C++, there's no way I'll stop going further down the rabbit hole now
Alice in Cpp Land
hybrid fjord
Also I'm way to deep into C++, there's no way I'll stop going further down the r...
we are in a same boat actually xd
upper pine
the NSA and FBI want you to use rust over c++
fuck what the glowies say
upper pine
we are in a same boat actually xd
π€
vernal lintel
der Bundesnachrichtendienst will dass du c++ benutzt damit du einen memory bug hast und die glΓΌhies dich backdooren kΓΆnnen
upper pine
die meisten memory bugs sind in 30 Jahre altem C code, nicht C++ code π©πͺ
vernal lintel
die meisten memory bugs sind in 30 Jahre altem C code, nicht C++ code π©πͺ
oop..
π
upper pine
The company did not disclose further technical details about the flaw
Would like to know more technical infos
vernal lintel
using rust would have prebented this
sorry im gonna stop shilling rust now
but i think making it use rust would be better cause i can more easily contribute to that
vernal lintel
this sounds like bogus
if anything the processes arnet terminating properly or smth
hybrid fjord
this sounds like bogus
if anything the processes arnet terminating properly or ...
imagine if it's a chromium issue xd
vernal lintel
nah thats outside of chromium
upper pine
But the whole C++ is bad spiel is prob also because C++ is simply used in so many places and rusts usage is miniscule compared to that, so I expect a lot of Rust related CVEs to popup once it's more widely used
vernal lintel
its just that it's spawning (& killing) wmic subprocesses constantly
vernal lintel
But the whole C++ is bad spiel is prob also because C++ is simply used in so man...
the thing is that the majority of high severity bugs are memory issues, which rust fixes
upper pine
its just that it's spawning (& killing) wmic subprocesses constantly
maybe related to arrpc? If you said it spawns a script fairly often maybe?
vernal lintel
sure you can have logic errors in rust too but they usually won't be as severe
hybrid fjord
nah thats outside of chromium
yeah i see now, i juse said it depending on title and bc you sent link about chrome issues
upper pine
the thing is that the majority of high severity bugs are memory issues, which ru...
rust does not inherntly fix those issues, it just has a really good linter
vernal lintel
if you forget to check array bounds in rust (or any memory safe language, go, js, java, etc), the program will crash
if you forget to check array bounds in c(++), it's arbitary code execution
vernal lintel
maybe related to arrpc? If you said it spawns a script fairly often maybe?
the wmic spawn is arrpc yes
sour muralBOT
https://github.com/OpenAsar/arrpc/blob/main/src/process/native/win32.js#L3
win32.js: Line 3
export const getProcesses = () => new Promise(res => exec(`wmic process get ProcessID,ExecutablePath /format:csv`, (e, out) => {
it runs this every 5 seconds
upper pine
if you forget to check array bounds in rust (or any memory safe language, go, js...
This is only an issue with C arrays or unsafe array access, use .at() to access elements and the program will crash / throw as well
upper pine
it runs this every 5 seconds
what the fuck
upper pine
This is only an issue with C arrays or unsafe array access, use `.at()` to acces...
There are certain operator overloads that are explicitly unsafe to give a miniscule runtime boost, but there's always a safe/checked variant of them as well
It's like driving a car, I could crash into a gas station and make the whole thing explode because I was in such a hurry to get gasoline, or I could be more relaxed and drive into the gas station slowly
Best analogy ever made, I know 
upper pine
This is only an issue with C arrays or unsafe array access, use `.at()` to acces...
good clang-tidy rules will tell you this if you do it wrong :)
upper pine
but i think making it use rust would be better cause i can more easily contribut...
isn't this the best opportunity to dip your toes into cpp 
vernal lintel
NOP
upper pine
why π