👾-core-development

[limber skiff]

It's not

there are two pretty much identical components

one is compact the other isnt

you can differentiate them by the text size

which is what I did

[austere talon]

text-xs is so generic

is there no better way

[limber skiff]

not really

check the code

It's horrible

I stared at it for a quite a bit

[twilit vector]

vee do you just ban them from making issues cus never have i ever seen anyone complain in comments after you close their issues

[fossil inlet]

locked?

[austere talon]

it can match

// random thing
variant: "text-xs/normal",
// bunch of random code here
variant: "not the one we want",
// matches code here

[twilit vector]

not even locks (well locked this time)

i check a bit later

[limber skiff]

yeah I know but

well

you can limit the wild card

but the text size is the only way I found to differentiate them

besides the class names on the past

[austere talon]

yeah always limit wild cards

cause this is the same problem

[austere talon]

well rn I enabled this

i usually lock dumb issues and sometimes block them

[twilit vector]

yeah that

nice to know

[austere talon]

what will we do about this

[fossil inlet]

trying to find something

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

limit length of this wildcard (50 might not be enough)

                    match: /reverse:!0,.{0,50}?barClassName:.+?\}\)\]/,

[austere talon]

this is kind of crazy

[limber skiff]

It's weird but its needed :sob

😭

the bundler did like let a,b,c,{folderNode:

[austere talon]

yeah figures

tbh that patch is kinda bad

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

sadan4

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

const ActionBarIcon = findByCodeLazy(/dangerous:\i=!1,/);

[austere talon]

even old one wasnt great

we can use the rename + default value trick we often use

[fossil inlet]

yeah, i dont like it that much

[austere talon]

like change it to

_expanded: n = !!arguments[0]?.isBetterFolders && arguments[0]._expanded

[limber skiff]

I mean yeah if that works

[fossil inlet]

maybe add Children.map to this

[limber skiff]

but like

the let is still a bit needed because there's a component that exports the same stuff

it cant match that object instead

[charred monolith]

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

this patch should be improved if possible

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

[limber skiff]

this is so bad

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

                    replace: '$&(this.props?.channel?.nsfw?"vc-nsfw-img ":"")+'

[limber skiff]

this app is so laggy oh my god

[austere talon]

i didnt test this btw

whats YJig7C

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

.YJig7C works here

[austere talon]

should I add lookup command to venbot

send latest map

[fossil inlet]

unknown

[austere talon]

got it

https://cdn.discordapp.com/attachments/1015063227299811479/1464077381391224873/key-mappings-new-hash.json?ex=6974d090&is=69737f10&hm=3114b2a06b9bfde2e364f0730904cd0a4788944813d204602b64e8b235012b93&

its not

[limber skiff]

this is likely to break

I think .MUTED there is a class

I dont wanna fix that right now tho

that one is a painful patch

let it be

[austere talon]

someone figure out what it is

[fossil inlet]

yeah, iirc they have them in an object at the top of the file

[limber skiff]

oh ur right

then it's fine

phew

[fossil inlet]

didn't test but it looks right

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

sadan4

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

maybe add Children.map

[austere talon]

$intl xb78ZZ

[frozen knot]

Nothing found :(

[austere talon]

bleh?

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

sadan4

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

                    match: /(?<=let ?(?:\i,)*?{folderNode:\i,setNodeRef:\i,.+?expanded:(\i),.+?;)(?=let\[\{dragging:)/,

this seems like a good anchor

[fossil inlet]

also seems like it might break frequently

[austere talon]

oh copilot retard

$intl xb78ZZ

[frozen knot]

A11Y_CHECKBOX_CHECKED

[austere talon]

nice

vupdate

[nimble pendant]

Updated!! Now restarting...

I'm back !!! :DDD

[limber skiff]

:DDDD

[austere talon]

[fossil inlet]

@elder plinth didnt you make a script to do this

[austere talon]

someone guess this for me

STOP BOOMING @limber skiff

nookies committing 9/11 in vencord repo

[chrome coral]

https://cdn.discordapp.com/attachments/1359770198864957503/1464374494222352544/image.png?ex=69753c86&is=6973eb06&hm=de1a7cbb2b58456c69f2f5146c9ae4c253b079423be5efb06101177f3a686866&

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

should limit length

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

should limit length

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

[austere talon]

should we drop old settings patches

scrtew u

[limber skiff]

BOOM BOOM

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

            '#{intl::YJig7C::raw}', // Nameplate preview

[austere talon]

fuck u giothub

[limber skiff]

T NEVER ENDS

[hybrid blaze]

https://tenor.com/view/this-close-gif-27349496

[charred monolith]

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

really generic

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

should limit length here, of both wildcards

[austere talon]

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

should limit length

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

should limit length

[austere talon]

i sound like a broken record

[twilit vector]

vee should plugins without tags have some relevant tags added?

i looked and like 7 plugins have tags

[austere talon]

no

tags is a misleading name

[limber skiff]

😂

[twilit vector]

poor tags sitting in limbo

rip

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

should limit length

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

should limit length

[limber skiff]

LOL

I'm gonna stay here until tomorrow limiting the length 💔

but not all of them need iirc

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

sadan4

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

                match: /\.Fragment,\{children:.{0,200}?\?null:(?:\i\(\),){3}(?<=nowPlaying:(\i)=!1,.+?overlay:\i,[^}]+?\}=(\i).+?)(?=\1&&)/,

bit less generic, not sure how much better it can get

[austere talon]

ill get it eventually

[fossil inlet]

definition of insanity

[limber skiff]

???

[austere talon]

remove :

you love insane devtools search

[fossil inlet]

371741

[austere talon]

improve this if u can @limber skiff

illegal code

[austere talon]

GUILD_FOLDER_TOOLTIP_A11Y_LABEL

[fossil inlet]

he did, did he not push?

[austere talon]

oh

is this already the improved version

[fossil inlet]

no 😭

[austere talon]

vintl SZeUdR

[nimble pendant]

Nothing found :(

[fossil inlet]

#👾-core-development message

[austere talon]

much better

[gritty iris]

vesktop has this and .STREAMER_MODE_ENABLE, is broken what is it actually supposed to do?

[fossil inlet]

is the find or patch broken

[gritty iris]

find

oh wait

it finally loaded the find after like 10 tries

[fossil inlet]

i only have the old after version

if you want

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

better i think

            find: '"span",{children:"#"+',

[limber skiff]

why was ths one removed?

[austere talon]

there is no none

also not used

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

or

            find: 'hasUniqueUsername()?null:"#"',

[fossil inlet]

whats the syntax for co-author

[austere talon]

who cares

just push

[austere talon]

this is better i think

[limber skiff]

oh god no 😭

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

should limit length

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

should limit length

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

sadan4

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

sadan4

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

that find hasn't ever broken, i think it's fine

Nuckyz

[Vencord:sadanslargehole-pr] 8 new commits

b35f380 Update src/plugins/_api/commands.ts - Vendicated
80fa9ad use safer MessageAccessories patch - Vendicated
c4ad1c4 limit length of better folders patch - sadan4
94cc42c Apply suggestion from @Vendicated - Vendicated
674a627 improve ExpandableList find - Vendicated

[limber skiff]

vtest sadanslargehole-pr

[nimble pendant]

Now testing!

[limber skiff]

I'm leaving view icons to after

I need a little break

[fossil inlet]

same

[limber skiff]

I just need to see if I didnt cause a regression

[austere talon]

vintl LgCPMt

[nimble pendant]

Nothing found :(

[nimble pendant]

Discord Stable (488579)

Bad Patches

RoleColorEverywhere (had no effect):
ID: 112753
Match: ```
/tag:"strong",variant:"text-md/medium"(?<=onContextMenu:.{0,15}((\i),(\i),\i).+?)/

**__SortFriendRequests (had no effect):__**
ID: `594968`
Match: ```
/(?<=\.\i,children:\[)\(0,.{0,100}user:\i,hovered:\i+?(?=,\(0)(?<=user:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 379768
Match: ```
/return(0,\i.jsxs?)(\i.\i,{channelId:(\i).id(?=.+?((0,\i.jsxs?)("div",{className:\i.\i,children:[.{0,100}\i.length.>0.+?]})),)/

**__FriendsSince (found no module):__**
ID: `-`
Match: ```
.connections,userId:

Bad Webpack Finds

findByCode(".actionBarIconaaaaaaaaaaa")

[nimble pendant]

Discord Canary (488958)

Bad Patches

ShowHiddenChannels (had no effect):
ID: 379768
Match: ```
/return(0,\i.jsxs?)(\i.\i,{channelId:(\i).id(?=.+?((0,\i.jsxs?)("div",{className:\i.\i,children:[.{0,100}\i.length.>0.+?]})),)/

**__SortFriendRequests (had no effect):__**
ID: `594968`
Match: ```
/(?<=\.\i,children:\[)\(0,.{0,100}user:\i,hovered:\i+?(?=,\(0)(?<=user:(\i).+?)/

FriendsSince (found no module):
ID: -
Match: ```
.connections,userId:

Slow Patches

VencordToolbox (took 5.7ms):
ID: 500831
Match: ```
/(?<=trailing:.{0,50})\i.Fragment,{(?=.+?className:(\i))/

Bad Webpack Finds

findByCode(".actionBarIconaaaaaaaaaaa")

[odd heath]

uuuuuuuuuuh

[limber skiff]

😛

[odd heath]

Iconaaaaaaaaaaaaaaaaaa

[limber skiff]

broke two patches

[odd heath]

why is more broken on stable than canary

[twilit vector]

it wasa on 1 bad patch how did it regress

[odd heath]

my bad

[austere talon]

#👾-core-development message

evil nmookies broke

[twilit vector]

👎

[fossil inlet]

@austere talon add vhash, reverse of vintl

[austere talon]

sure

pr

[limber skiff]

no one fixed this one?

[fossil inlet]

doing that rn

[austere talon]

i think its better

[fossil inlet]

going to try a few guess at the key before i just use ::raw

[limber skiff]

also huh

[austere talon]

maybe i might try hooking up gemma with hash tool and have it guess the key

idk if context window is big enough to feed the entire discord json

[limber skiff]

vtest sadanslargehole-pr canary

[nimble pendant]

Now testing!

[charred monolith]

Nuckyz

[Vencord:sadanslargehole-pr] 2 new commits

fb7dafb Apply suggestion from @sadan4 - Vendicated
31b07e0 fix the boom I broke - Nuckyz

[limber skiff]

sadanslargehole-pr

...

vtest sadanslargehole-pr canary

[nimble pendant]

Now testing!

[signal sundial]

what's the state of things right now, settings work but plugins are broken?
or do settings not work too

[fossil inlet]

got it first try

[austere talon]

this seems mispelt

lol discord

[nimble pendant]

Discord Canary (488958)

Bad Patches

SortFriendRequests (had no effect):
ID: 594968
Match: ```
/(?<=.\i,children:[)(0,.{0,150}user:\i,hovered:\i+?(?=,(0)(?<=user:(\i).+?)/

**__FriendsSince (found no module):__**
ID: `-`
Match: ```
.connections,userId:

Bad Webpack Finds

findByCode(".actionBarIconaaaaaaaaaaa")

[austere talon]

oh nvm its a boolean

why not name it shouldRenderPlaceholder

[limber skiff]

it doesnt fail on my machine?

[dapper tiger]

SADANS LARGE HOLE

[fossil inlet]

?remind 1w add GAME_FRIEND to intl list

[shut vine]

Alright @fossil inlet, in 1 week: add GAME_FRIEND to intl list

[dapper tiger]

how dead is vencord

[fossil inlet]

not that bad

[elder plinth]

forever. it's never coming back

[dapper tiger]

yay

[limber skiff]

the patch is right here!

vtest sadanslargehole-pr canary

[nimble pendant]

Now testing!

[austere talon]

getting there

[limber skiff]

cursed?

[nimble pendant]

Discord Canary (488958)

Bad Patches

SortFriendRequests (had no effect):
ID: 594968
Match: ```
/(?<=.\i,children:[)(0,.{0,150}user:\i,hovered:\i+?(?=,(0)(?<=user:(\i).+?)/

**__FriendsSince (found no module):__**
ID: `-`
Match: ```
.connections,userId:

Bad Webpack Finds

findByCode(".actionBarIconaaaaaaaaaaa")

[odd heath]

theres 2-3 broken patches thats all

yea

[signal sundial]

actionBarIconaaaaaaaaaaa

[wary dew]

SADANS LARGE HOLE

[limber skiff]

WHY DOES IT FAIL ON REPORTER

AND NOT ON MY MACHINE

[wary dew]

actionBarIconaaaaaaaaaaa

[signal sundial]

i think shc died

unless its fixed on some other branch

[odd heath]

shc is fixed

all on sadanslargehole

[wary dew]

vencord devs actually so fast wth

[signal sundial]

oh okay

ill make Vde announcement

[wary dew]

dont

[odd heath]

its not out

[wary dew]

not yet

[odd heath]

its just on other branch

[limber skiff]

someone else will figure why that only fails on reporter

[odd heath]

we still need to push main

[wary dew]

vee will take 80 years to push to main btw

vencord fixed 2028

[elder plinth]

it just tried brute forcing by using a list of terms and going through all permutations. extremely slow the longer the key and suseptible to discord adding a random fuck ass word to the key that you never in a million years would have thought to add to the word bank and so it never finds the hash. long since deleted it lol

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

const ActionBarIcon = findByCodeLazy("Children.map", "isValidElement", "dangerous:");

[austere talon]

cute emoticon

[chrome coral]

+0+

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

sadan4

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

not a great find, couldn't find a better one

[fossil inlet]

i got a find for friends since

not the best tho

[austere talon]

its fine

[fossil inlet]

not really

[austere talon]

IgnoreActivities is patching this right

[fossil inlet]

it matches against a use of the prop

[austere talon]

or the one below

[fossil inlet]

LOVE

[fossil inlet]

do you want to see the old one?

[austere talon]

oh down there

[limber skiff]

insane how useful the class names were

[elder plinth]

unfathomable I could guess the a11y one but the rest are somehow different enough to elude me

[austere talon]

why not do smth like

match: /\i&&!\i||\i\?null/,
replace: "$self.renderToggleButton(),$&

[austere talon]

whats the a11y one

[elder plinth]

I reply pinged u bro

scroll up like 7 messages

[austere talon]

how did u get it

insane

[elder plinth]

I just added collectibles cause ik thats what they call profile stuff

[austere talon]

love

[elder plinth]

nameplates were the first things in the collectibles key on profile data

[austere talon]

good job

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

sadan4

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

            find: "#{intl::REMOVE_ATTACHMENT_TOOLTIP_TEXT}",

[limber skiff]

why

the old one is fine

imo

[elder plinth]

aha this is the 2nd one

[fossil inlet]

eh

[austere talon]

try this

[charred monolith]

Nuckyz

[Vencord:sadanslargehole-pr] 8 new commits

0b50bb9 Apply suggestion from @Vendicated - Vendicated
ab903ae limit length - Vendicated
075b20c Apply suggestion from @Vendicated - Vendicated
5824419 fix find for friends since - sadan4
ee3d27f limit length - Vendicated

[fossil inlet]

in general, i think intl is better than prop order

[limber skiff]

vtest sadanslargehole-pr canary

[nimble pendant]

Now testing!

[limber skiff]

intl can easily get duplicated

they re-use strings

[nimble pendant]

Discord Canary (488993)

Bad Patches

SortFriendRequests (had no effect):
ID: 594968
Match: ```
/(?<=.\i,children:[)(0,.{0,150}user:\i,hovered:\i+?(?=,(0)(?<=user:(\i).+?)/

[limber skiff]

@austere talon ^^

that shit works fine locally

[fossil inlet]

@limber skiff guhhhhhh

[limber skiff]

oh huh

now it doesnt

[limber skiff]

that's on you

[fossil inlet]

how

[limber skiff]

I didnt touch the replacement

[fossil inlet]

it's your commit???

[limber skiff]

oh wtf

not sure how that happened

[fossil inlet]

i had the bug in my original fix

[limber skiff]

I dont remember touching it

good catch

[fossil inlet]

noticed and fixed it when i replaced it with yours

i think you copy-pasted and re-added it

guh

[limber skiff]

oh I noticed a merge conflict

but I just accepted my version

[fossil inlet]

ah

[austere talon]

how is it at the start

oh

have to escape | lmfao

way better

wait im confused

it matches smth else

[austere talon]

here it's here

this is correct

HURRY UP DUDE

what is wrong with you

oh my god shithub cant handle our pr

SHIIIITHUUUUUUBBBB HURRY

[twilit vector]

you really want to go to sleep

[austere talon]

bro so bad it applied twice

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

Vendicated

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

i'm not sure if this is right please verify this is right @Nuckyz

Nuckyz

[Vencord:sadanslargehole-pr] 5 new commits

33e3de1 fix plainfoldericon - sadan4
2402999 improve IgnoreActitivies - Vendicated
0988860 Update src/plugins/messageLogger/index.tsx - Vendicated
b76b276 Update src/plugins/messageLogger/index.tsx - Vendicated
da39862 I'm so smart - Nuckyz

sadan4

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

sadan4

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

was just looking at that, its 100% wrong

[limber skiff]

vtest sadanslargehole-pr

[nimble pendant]

Now testing!

[fossil inlet]

ill fix that one

[austere talon]

how is it wrong

it's same thing nookies showed

[odd heath]

what is nookies cooking

[limber skiff]

seems fine?

[austere talon]

^

[nimble pendant]

Discord Canary (489010)

Bad Patches

SortFriendRequests (had no effect):
ID: 4
Match: ```
/(?<=.\i,children:[)(0,.{0,100}user:\i,hovered:\i.+?(?=,(0)(?<=user:(\i).+?)/

[nimble pendant]

Discord Stable (488579)

Bad Patches

SortFriendRequests (had no effect):
ID: 4
Match: ```
/(?<=.\i,children:[)(0,.{0,100}user:\i,hovered:\i.+?(?=,(0)(?<=user:(\i).+?)/

**__RoleColorEverywhere (had no effect):__**
ID: `112753`
Match: ```
/tag:"strong",variant:"text-md\/medium"(?<=onContextMenu:.{0,15}\((\i),(\i),\i\).+?)/

[limber skiff]

it should be here

[odd heath]

what happened to rce on staple

[fossil inlet]

wait im stupid

[limber skiff]

okay the fuck u mean still broken

[fossil inlet]

i thought that was one the one below it

[austere talon]

how

[fossil inlet]

4

[odd heath]

4#

insane

????

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

sadan4

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

this is 100% wrong

[austere talon]

is it normal that that monitor thing is missing

[limber skiff]

not sure lol

might be

It's the overlay

and I have roblox open

[austere talon]

installermessage is my fav game icl

[austere talon]

oh not a thing on linux

[limber skiff]

okay makes sense

[austere talon]

is it tho

[fossil inlet]

yes lol

this is what it does rn

[austere talon]

love

only fix IgnoreActivities

then we done

[fossil inlet]

my finger getting sore from scrolling throught code for hours

[austere talon]

love

use pg up/down

[austere talon]

where should it be

[fossil inlet]

fixing it rn

[limber skiff]

why was it broken

did I break it

[austere talon]

is this a different module

[fossil inlet]

dont think so

[fossil inlet]

no

[austere talon]

i cant find appDetailsHeaderContainer

oh im retarded lol

[limber skiff]

wait

what the fuck

???

im actually so dumb

LOL

WHERE DID MY FIND GO

[charred monolith]

Nuckyz

[Vencord:sadanslargehole-pr] 2 new commits

2ffa09f limit length - Vendicated
6fccaaa stupid x2 - Nuckyz

[limber skiff]

vtest sadanslargehole-pr canary

[nimble pendant]

Now testing!

[austere talon]

{
            find: "#{intl::EMBEDDED_ACTIVITIES_DEVELOPER_ACTIVITY}",
            replacement: {
                match: /,rendersPlaceholder:.{0,200}?lineClamp:1.{0,50}?(?=!\i&&\i\?)(?<=application:(\i).+?)/,
                replace: "$&$self.renderToggleActivityButton($1),"
            }
        }

@fossil inlet

[fossil inlet]

{
    find: "#{intl::EMBEDDED_ACTIVITIES_DEVELOPER_ACTIVITY}",
    replacement: {
        match: /,(?=!(\i)&&\i\?)(?<=application:(\i).+?\1="large_banner"===.+?)/,
        replace: (_, _1, application) => `,$self.renderToggleActivityButton(${application}),`
    }
}

[nimble pendant]

Discord Canary (489010)

No issues found

Seems like everything is working fine (for now)

[limber skiff]

your patch works fine @austere talon

[limber skiff]

FINALLY

[austere talon]

{
    find: "#{intl::EMBEDDED_ACTIVITIES_DEVELOPER_ACTIVITY}",
    replacement: {
        match: /lineClamp:1.{0,50}?(?=!\i&&\i\?.+?application:(\i))/,
        replace: "$&$self.renderToggleActivityButton($1),"
    }
}

[limber skiff]

what are yall fixing

[fossil inlet]

looks good

[limber skiff]

nvm

[fossil inlet]

ignoreactivities

[limber skiff]

this is stable

I'm so stupid again

[limber skiff]

this is how it should look tho

[austere talon]

this looks so bad

[austere talon]

it should only show on hover and use a muted colour

wello whatever

[charred monolith]

nerdwave-nick

[Vendicated/Vencord] Pull request closed: #3909 feat: add plugin to munge opus codec WebRTC SDP

[limber skiff]

well that requires more work cuz the component is shared rn

[limber skiff]

the color here is wrong too

for some reason

[austere talon]

ill merge now ?

[limber skiff]

hold

I didnt review view icons

[charred monolith]

Vendicated

[Vencord:sadanslargehole-pr] 1 new commit

4cfa757 fix IgnoreActivities - Vendicated

[austere talon]

vtest sadanslargehole-pr

[nimble pendant]

Now testing!

[limber skiff]

still pending

do that for me

[austere talon]

eh?

[odd heath]

that popped up a few times

in reporter

[limber skiff]

broken only on stable

for some reason

[austere talon]

oh

[fossil inlet]

someone should try and guess

[nimble pendant]

Discord Canary (489010)

No issues found

Seems like everything is working fine (for now)

[nimble pendant]

Discord Stable (488579)

Bad Patches

RoleColorEverywhere (had no effect):
ID: 112753
Match: ```
/tag:"strong",variant:"text-md/medium"(?<=onContextMenu:.{0,15}((\i),(\i),\i).+?)/

[austere talon]

matches so much

wait what

[alpine ridge]

(fixes this borked component)

[limber skiff]

yeah that's the span

@fossil inlet

why is it not all: true anymore

[charred monolith]

Vendicated

[Vencord:sadanslargehole-pr] 1 new commit

5184af1 limit length - Vendicated

[austere talon]

wrong branch

[fossil inlet]

i didn't do that one, but there is only one module for it to match, both before and after

(that the find matches against)

[limber skiff]

oh huh

it used to match more before

okay then

[austere talon]

seems wrong

shouldnt it be className={classes(RoleBorderClasses.roleCircle, RoleBorderClasses.roleCircle)}

@alpine ridge

wait

oh

[fossil inlet]

they removed one

[austere talon]

nvm

im dumb

[alpine ridge]

one of those doesnt exist anymore

[austere talon]

was the old one jkust wrong

i confused myself

[limber skiff]

why was the match changed anyway

[austere talon]

old onme should work

[limber skiff]

it does yeah

it's bad but it works

(I think I made it)

[austere talon]

just revert to the old one

[limber skiff]

ye

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

[fossil inlet]

is that everything

[limber skiff]

beides testing ye

besides

one more thing I'm pushing now

[alpine ridge]

ive found another issue with showhiddenthings, looks like an easy fix

[fossil inlet]

@limber skiff

[austere talon]

bruh they just reverted

[fossil inlet]

joking?

[austere talon]

yeah sorry

[odd heath]

what

[fossil inlet]

going to go mental if they did

also to which one

[limber skiff]

where did it g o

😭

[austere talon]

vesktop also needs fixing

[fossil inlet]

nobody uses vesktop anyway

[austere talon]

I USE IT

[odd heath]

same

[elder plinth]

have you considered using vencord instead

[fossil inlet]

oh

thorren zapped it

[fossil inlet]

@alpine ridge can pull and try now

should be good

[charred monolith]

Nuckyz

[Vencord] Branch sadanslargehole-pr was force-pushed to `50c8937`

Compare changes

[limber skiff]

vtest sadanslargehole-pr

[nimble pendant]

Now testing!

[odd heath]

[limber skiff]

I just forced pushed into sadan large hole

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3925 fix finds/patches after css module mangling

sadan4

[Vendicated/Vencord] New review comment on pull request #3925: fix finds/patches after css module mangling

should the end of this backreference be lazy?

[nimble pendant]

Discord Canary (489033)

Slow Patches

OnePingPerDM (took 10.9ms):
ID: 845618
Match: ```
/(\i.\i.getDesktopType()===\i.\i.NEVER))/

[nimble pendant]

Discord Stable (488579)

Bad Patches

RoleColorEverywhere (had no effect):
ID: 112753
Match: ```
/tag:"strong",variant:"text-md/medium"(?<=onContextMenu:.{0,15}((\i),(\i),\i).+?)/

[odd heath]

PEAK

well except rce but

canary

[fossil inlet]

wait

[limber skiff]

yes

do it

[fossil inlet]

i think i know why

[limber skiff]

nice

feels like nothing happened already

[fossil inlet]

asd

[fossil inlet]

@limber skiff what's better, text-md\/(?:medium|normal) or text-md\/\w+?

stable compat

[limber skiff]

first

add a FIXME note to remove it soon

[fossil inlet]

yop

soon™

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request review submitted: #3925 Fix finds and patches for new CSS module mangling

[limber skiff]

@austere talon anything more?

[austere talon]

did this get fixed

[limber skiff]

yep

sadan fixed it

[austere talon]

lgtm

[fossil inlet]

https://github.com/Vendicated/Vencord/pull/3925/changes/8bd5a76a494434fa8dd6dd56bf2155785e4a7a78

[alpine ridge]

yes, but theres another issue with it

[fossil inlet]

?

what am i looking at

[odd heath]

[austere talon]

is patches not exposed on window anymore

[limber skiff]

what's wrong

[austere talon]

oh Vencord.WebpackPatcher.patches

[alpine ridge]

should look like this, but for some reason they dont render for V

[fossil inlet]

oh thats the nasty lazy loading thing iirc

i remember doing that last time

[limber skiff]

minimal issue

[alpine ridge]

oh, existing issue?

[limber skiff]

can get fixed later if it's our fault

[austere talon]

someone tell discord to remove them

please

it will fix performance instantly i think

[austere talon]

somehow vesktop only had 2 patches break

[limber skiff]

I already know something will going to broken after we push

so let the users find it

[austere talon]

yes

[limber skiff]

I didnt test every plugin

[austere talon]

push to main

[limber skiff]

u do it

[austere talon]

oki

[limber skiff]

so I can blame you if something is broken

[austere talon]

normal

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request closed: #3925 Fix finds and patches for new CSS module mangling

Vendicated

[Vencord:dev] 1 new commit

575421f fix everything (#3925) - sadan4

[limber skiff]

😂

bro made the commit FIX EVERYTHING

[austere talon]

vtest dev

[nimble pendant]

Now testing!

[limber skiff]

💀

[fossil inlet]

🎉

[limber skiff]

should I reload my stable yet

wont do it tbh

[austere talon]

now discord will revert

[fossil inlet]

i think i have a stable running on my laptop from like early december

[limber skiff]

I dont think a lot of things will break if they revert

there were only some minimal bundler changes

besides the css mangling

[nimble pendant]

Discord Canary (489033)

No issues found

Seems like everything is working fine (for now)

[nimble pendant]

Discord Stable (488579)

No issues found

Seems like everything is working fine (for now)

[odd heath]

simple just revert commit and force push

YAY

[fossil inlet]

they revert to the one with fully hashed class names

[limber skiff]

that's probably going to happen

[charred monolith]

Vendicated

[Vencord:dev] 1 new commit

cd03aee bump to v1.14.1 - Vendicated

[austere talon]

i wont release ext yet

[charred monolith]

Vendicated

[Vencord:main] 2 new commits

575421f fix everything (#3925) - sadan4
cd03aee bump to v1.14.1 - Vendicated

[limber skiff]

ye

[fossil inlet]

?remind tomorrow check if this is still an issue

[shut vine]

Alright @fossil inlet, in 1 day: check if this is still an issue

[limber skiff]

🙏

[fossil inlet]

is it just me or is the role dot clipping the text

[limber skiff]

I love seeing users happy when things get fixed

[twilit vector]

ty guys

wow even viewpermission profile button came back

[austere talon]

vencord becoming bloated

600kb

[twilit vector]

i was here o7

[austere talon]

thanks for the help everyone

[limber skiff]

https://github.com/web-infra-dev/rspack/pull/12563

THE CULPRIT

SPREAD HATE

[fossil inlet]

I KNEW IT

[austere talon]

kill

(dont complain on that pr)

[hollow musk]

genuinely so funny that everything broke because of this teeny tiny pr

[limber skiff]

It's definitely coming back

It's not even a discord dev?

[fossil inlet]

discord doesnt use the default

[limber skiff]

he just wanted to sabotage us!!

[fossil inlet]

they use an _ not a -

[limber skiff]

yes but they had made it be full hash

and reverted

lets mention that PR in our PR

[austere talon]

oh my god

[fossil inlet]

hopefully it stays that way

[limber skiff]

they need to know what they did.

[austere talon]

so discord updated, then manually changed it back

[austere talon]

wait yeah

[fossil inlet]

my guess for why is because source maps cant help with that

so it's a massive pain

even if you have them

[limber skiff]

so they might bring it back?

maybe yes maybe not

[fossil inlet]

i doubt it, but it's not out of the question

[austere talon]

i wonder if them changing it back to sane was to be nice to modders or if they care about class format

[austere talon]

also i really hate this change tbh

it will ruin sites in general

so many sites will become less themeable thanks to this default change

should i complain on the PR

[limber skiff]

😂

so the hash was already an option

just not the default

[odd heath]

yes

[twilit vector]

vev dont forget about extension

[nimble pendant]

The Vencord Chrome Extension is up to date! (v1.13.12)

[twilit vector]

how the hell

[austere talon]

#👾-core-development message

it's very likely that some things might still be broken and went unnoticed

[twilit vector]

i'm blind

[austere talon]

give users some time to report issues

[limber skiff]

specially cuz I touched 50 patches and didnt double check

I trust my regex

🙏

[fossil inlet]

always has been, think it started in webpack with css-loader

@austere talon do you know the perf impact of *=? would it be worth to go back to ^=

[limber skiff]

help

[austere talon]

very minor

shouldnt matter

[limber skiff]

2k members in a day

@austere talon we really need this to happen more often

[austere talon]

should i dm advaith

[odd heath]

yes

[limber skiff]

yes

[fossil inlet]

yes

[twilit vector]

yes

[charred monolith]

Nuckyz

[Vendicated/Vencord] branch deleted: sadanslargehole-pr

[austere talon]

destroying the evidence

[charred monolith]

Vendicated

[Vendicated/Vencord] branch deleted: useSettings-wildcard

Vendicated

[Vendicated/Vencord] branch deleted: better-toolbox

Vendicated

[Vendicated/Vencord] branch deleted: new-settings-patch

Nuckyz

[Vendicated/Vencord] branch deleted: fix-yt-adblock

[limber skiff]

oh thanks

I was trying to delete a branch and I couldnt

[austere talon]

restore that

[limber skiff]

because you had done already

[austere talon]

it still needed

[limber skiff]

not merged?

[charred monolith]

Vendicated

[Vendicated/Vencord] branch deleted: copilot/find-bugs-and-vulnerabilities

Nuckyz

[Vendicated/Vencord] New branch created: fix-yt-adblock

Nuckyz

[Vencord:fix-yt-adblock] 1 new commit

14cdbaa fix YoutubeAdblock - Vendicated

[austere talon]

no

[limber skiff]

alr

[austere talon]

i reverted that because doesnt work

[fossil inlet]

i think vencord needs more dev branches

[austere talon]

well rn works well

[fossil inlet]

dev4 and dev5 when

[austere talon]

dev4 soon

[limber skiff]

we can delete these right

[austere talon]

yeah

these dont show for me

npm notice Access token expired or revoked. Please try logging in again.

[limber skiff]

it's yapping about our regex now

smhh

[austere talon]

who

[limber skiff]

code scanning

[austere talon]

npm error 403 403 Forbidden - PUT https://registry.npmjs.org/@vencord%2Ftypes - Two-factor authentication or granular access token with bypass 2fa enabled is required to publish packages.

please shut

npm so annoying man

[limber skiff]

I still didnt set 2fa on my npm account

websites that enforce it are so dumb

[fossil inlet]

you love npm revoking all tokens

[charred monolith]

Nuckyz

[Vendicated/Vencord] branch deleted: feat/permissionfreewill-onboarding-delete

Nuckyz

[Vendicated/Vencord] branch deleted: feat/startup-timings-tti

Nuckyz

[Vendicated/Vencord] Pull request closed: #1773 feat(permissionfreewill): onboarding deletion

[austere talon]

funny

DUDE WHO CARES ABOUT NODE TAR

[fossil inlet]

uh oh

[limber skiff]

someone stream on vc

[fossil inlet]

ok

https://discord.gg/6RPWXmpg

oh
i crash when i try to stream

might be vesktop issue

[limber skiff]

try watching my stream

I dont have all plugins enabled tho

can you run reporter build and watch my stream?

I closed my vscode rn

oh huh

[limber skiff]

maybe

[fossil inlet]

my messages love taking years to send, but i have the same issue on stock

[odd heath]

nop

i alr tried

couldnt repro

[fossil inlet]

huh

intresting

[odd heath]

streaming and watching both were fine

i didnt try on stock tho

too lazy

[limber skiff]

what discord mods are still maintained nowdays

[odd heath]

i tried in dms tho not vc

[limber skiff]

for desktop

[odd heath]

if theres a difference

[limber skiff]

BetterDiscord, Vencord

[odd heath]

how is bd doing with this change anyway

[limber skiff]

Replugged a little bit

[odd heath]

did it affect them at all

[limber skiff]

moonlight?

[fossil inlet]

not sure

dont really follow other mods

[limber skiff]

yeah moonlight seems to be

[limber skiff]

yeah

lots of plugins broken

[odd heath]

goooood

[limber skiff]

the mod itself broke too

[odd heath]

[limber skiff]

but we can't talk much about that 😔

Vencord patcher also died

[austere talon]

works for me

[limber skiff]

our patcher was lasting so long without problems

[odd heath]

i mean yeah

not surprised it broke with that oen tho

[limber skiff]

I never really realized the module definition could change format

[dusk blaze]

out of curiosity did shelter have issues

[fossil inlet]

this seems like a vesktop issue
crash whenever i try to start stream

[limber skiff]

but like

literally every discord regex patcher had the same issue

https://github.com/moonlight-mod/moonlight/commit/ee01708116783a6b64ef36d1ab44a9150e032261

[dusk blaze]

also did the Card import get moved somewhere else all my plugins using it fail build

[limber skiff]

https://github.com/replugged-org/replugged/commit/a9cef6181a6c894bddba11a51ad5ac9e981e760d

[odd heath]

person with the issue in support was on stable btw @fossil inlet

i think

like

stock

[austere talon]

cant repro

[limber skiff]

https://github.com/BetterDiscord/BetterDiscord/commit/1b859560148a908f077278fba9625ea82e670222

[austere talon]

are u on windows

no right

[fossil inlet]

no

[limber skiff]

this tho...

[fossil inlet]

its a react error

[austere talon]

lol

[fossil inlet]

trying to render something thats not a component

[austere talon]

Ay

[limber skiff]

Ay ay ay ay

[austere talon]

well debug it

[fossil inlet]

oh god that's going to fuck with my memory

[limber skiff]

nope but I mean shelter is designed for that

[austere talon]

or give me repro steps

[fossil inlet]

start stream

crash

[odd heath]

if its not reproable its not a vencord issue fr

[fossil inlet]

i can repro 100%

[odd heath]

is literally fine for me

canary vesktop linux

[austere talon]

works

but i have this crash when stopping the stream 💀

[limber skiff]

decor got wacky

the previewer shows this now

(not related to this update)

even on old stable it's like that

[fossil inlet]

i love discord taking five years to start

so slow

[limber skiff]

It doesnt even work 😂

fix everything (but decor)

why is this not caught by our reporter

[odd heath]

guy in support might actually be right

anyway shrimple fix no?

[austere talon]

it's inside LazyComponentWebpack

seems to have broke

[limber skiff]

weird

[austere talon]

why does this even memo

seems useless

[fossil inlet]

findComponentByCode("#{intl::PREMIUM_UPSELL_PROFILE_AVATAR_DECO_INLINE_UPSELL_DESCRIPTION}")

[limber skiff]

I cant fucking type

[fossil inlet]

oh

its not just me

i thought i was going insane

[limber skiff]

it seems like my stable client has died

[austere talon]

vintl hmyYK8

[nimble pendant]

Nothing found :(

[limber skiff]

not duplicate right

[fossil inlet]

nope

[limber skiff]

vlookup .hmyYK8

erm

hello can my messages send

aaaaaaaaa

[fossil inlet]

leading .

[austere talon]

its fine

[limber skiff]

ye

I know

[odd heath]

yeah what is this message send issue

you cant even ctrl+r if it happens

ive had it a few times by now too

[charred monolith]

Vendicated

[Vencord:dev] 1 new commit

28b4053 WebScreenshareFixes: remove codec changes - Vendicated

[fossil inlet]

this happens to me on stock stable, discord fucked something

[fossil inlet]

this happens to me on stock stable, discord fucked something

[fossil inlet]

is that the crash?

[limber skiff]

spammer

[fossil inlet]

i think it might be

[limber skiff]

let me try to fix this too

[fossil inlet]

prob just a new default boolean prob if i had to guess

[limber skiff]

I would appreacite having my react devtools

[fossil inlet]

i cant connect to voice either

[limber skiff]

oops

setting was disabled

[charred monolith]

Vendicated

[Vencord:dev] 1 new commit

e03bb9a ExpressionCloner: fix cloning animated emojis - Vendicated

[austere talon]

no lol

[fossil inlet]

id try it out if i could connect to a channel 😭

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request opened: #3933 CrashHandler: log component stack on crash

helps when debugging the cause of crashes

[austere talon]

why is_dev check

[fossil inlet]

idk

@austere talon how can i get to vesktop renderer

cant find it in sources tab

[austere talon]

just search VesktopRenderer

idk why it doesn't give clickable link

make sure u have sourcemaps on

vesktop should have

[fossil inlet]

i think you need file:/// here

[austere talon]

nah

[austere talon]

ah yeah this is wrong

you do need a protocol but file doesn't work

need to make a custom protocol

[fossil inlet]

then why is file used for the webpack modules

[austere talon]

I meant for the source maps

[fossil inlet]

oh

[austere talon]

https://github.com/Vendicated/Vencord/blob/main/scripts/build/build.mjs#L59

[grave mango]

build.mjs: Line 59

const sourceMapFooter = s => watch ? "" : `//# sourceMappingURL=vencord://${s}.js.map`;

[fossil inlet]

istg

who keeps moving me

@toxic forge evil

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `bdf0733`

Compare changes

[limber skiff]

https://github.com/Vendicated/Vencord/commit/bdf0733a0ec08a4a919455581a2d369f9f122752

had to make a patch to fix that display

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `1e284c7`

Compare changes

[fossil inlet]

maybe i should update vesktop

on 1.6.1 rn

[odd heath]

whats latest

[charred monolith]

Nuckyz

[Vencord:dev] 1 new commit

1e284c7 Decor: Fix change decoration modal being unable... - Nuckyz

[fossil inlet]

.3 i think

[odd heath]

oh good

[toxic forge]

[limber skiff]

I name the argument wrong

well whatever

not worth a force push

[charred monolith]

Nuckyz

[Vencord:main] 3 new commits

28b4053 WebScreenshareFixes: remove codec changes - Vendicated
e03bb9a ExpressionCloner: fix cloning animated emojis - Vendicated
1e284c7 Decor: Fix change decoration modal being unable... - Nuckyz

[limber skiff]

RCE broken

[fossil inlet]

how

[limber skiff]

doesn't work in vc

doesn't work in chat

[fossil inlet]

how did i not notice that

i have rce enabled in chat

[austere talon]

why push to main already

insane

I was going to do more maybe

[limber skiff]

cuz users were complaining in support

[fossil inlet]

guhhh

i wish you could blame across prs

[limber skiff]

😂

[twilit vector]

should i just forward genuine "this doesn't work" messages here?

[fossil inlet]

yes

[twilit vector]

(which can be repro'd ofc)

ok yay

[limber skiff]

guys

this doesn't look like a user

does it

[fossil inlet]

idk

sounds like some vencord support users sometimes

[odd heath]

im wondering too

cuz i have it on too

😭

yu get used to it being gone so quick

[fossil inlet]

wait?

did someone fuck up === vs !==

veeeeeeeee

@austere talon

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request opened: #3934 RoleColorEverywhere: fix logic error when coloring chat messages

[fossil inlet]

@limber skiff 😭

how has nobody noticed

[limber skiff]

I didnt have it enabled

the chat option

[fossil inlet]

i think i just dont update often

https://github.com/Vendicated/Vencord/commit/5c7a90c05f9b51fe0cb44d5d7dc7181861cd81b2

introduced here

[austere talon]

we did but just wasn't fixed

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request review submitted: #3934 RoleColorEverywhere: fix logic error when coloring chat messages

Nuckyz

[Vendicated/Vencord] Pull request closed: #3934 RoleColorEverywhere: Fix not working on voice channel and chat

Nuckyz

[Vencord:dev] 1 new commit

fbfc38a RoleColorEverywhere: Fix not working on voice c... - sadan4

[austere talon]

why 😭

isn't it the same

[limber skiff]

there were so many other destructured variables in between that it was matching a destructuring statement a thousand kilometers away

and not erroring purely because of lucky since the variablas had other values in the scope

😂

[austere talon]

😭

wtf

unreal

[fossil inlet]

updated to 1.6.3 and no longer crash when trying to stream

[limber skiff]

okay I can eat now

[odd heath]

vee did this and i told him but he didnt care

[austere talon]

I was going to fix but I forgot

anyway you have to be mentally disturbed to use coloured chat messages anyway

so awful

I was lowkey saving you by breaking that feature

[fossil inlet]

Insane

[limber skiff]

rip I restarted my client

went to support and clicked update now for funnies

restarted my whole client

It's fine tho I think

[austere talon]

that is rape...

leave venapp alone

[austere talon]

should we pub extension now @limber skiff

I think it's good to go

[limber skiff]

wait more

we can do it within like 10 hours or something

won't change much

also need to push dev to main before it

[austere talon]

the lag seems to have gotten better btw

funny

like a few days ago discord was lagging hard for me (even stock)

now it's smooth again

[weak thistle]

I wonder what actually caused it

[hybrid blaze]

discord discording

usual stuff

[fossil inlet]

anyone ever got this before

i think it means the renderer crashed

not sure

i can consistently cause this by telling companion to download all modules

[austere talon]

oom?

[fossil inlet]

dont think so

i have 64gb

and it's never oomed before

is load lazy chunks meant to fetch the same one three times

[austere talon]

nah

tbh ive had reporter fail on me earlier too

[fossil inlet]

think you could just cache the chunk ids

in a set or smth

[austere talon]

maybe that change nookies made to the regex has some issue?

https://github.com/Vendicated/Vencord/commit/8c81e5d27edfcc0f3a551ed28c0d8b2f91b8f080

[fossil inlet]

wonder what the flamegraph looks like

[austere talon]

i mean reporter works on github

[fossil inlet]

reporter works locally too

but its pretty spotty

and a lot slower

[austere talon]

I didn't really review it because too lazy and I trust nookie 😊

[fossil inlet]

guh?

[elder plinth]

im not sure if related, or if even a new thing or not, I just assumed it was cause of the new webpack things or w/e but anytime I press test patch it takes ages to get me a result and sometimes times out. dont think it's ever done that to me before. only seems to happen on multi replacements. single patches are fine

[fossil inlet]

yeah thats discord being really show

[elder plinth]

nvm happens to single patches to. random if it works instantly or takes ages or times out

[austere talon]

yeah so this means its fetching too much

have to throttle requests a bit

add a sleep