#👾-core-development
gritty iris
you all got that error much later so I thought it was an equicord problem 😭
austere talon
does it crash or
alpine ridge
no, its just causing CI to fail
austere talon
vtest dev
alpine ridge
sry prism, didnt realise your pr had already fixed it
austere talon
tbf its a quite mixed pr and doesnt mentiopn that part
hybrid blaze
sry prism, didnt realise your pr had already fixed it
its fine
hybrid blaze
tbf its a quite mixed pr and doesnt mentiopn that part
yeah, it was my bad
charred monolithBOT
charred monolithBOT
charred monolithBOT
twilit vector
people still use those?
dusk blaze
vai when did macos big sur and monterey release
nimble pendantBOT
vai when did macos big sur and monterey release
macOS Big Sur was released on November 12, 2020. macOS Monterey was released on October 25, 2021.macOS Big Sur was released on November 12, 2020. macOS Monterey was released on October 25, 2021.
-# Response generated by gemini-2.5-flash. AI may be incorrect or misleading.
charred monolithBOT
heavy wolf
Hey hey, I've created pr with custom popout's
There are few features it appears I couldn't do without touching DOM, but I've tried to use react/stores for as much as I could. Can someone have a look?
heavy wolf
@hybrid blaze wanted to add you as contributor but couldn't find your nickname/id in Dev list 🙁
gritty iris
<@390884143749136386> wanted to add you as contributor but couldn't find your ni...
I have it added in https://github.com/Vendicated/Vencord/pull/3802 right now 
heavy wolf
I have it added in https://github.com/Vendicated/Vencord/pull/3802 right now <:t...
Thanks! Copied it. I'll fix conflict if your pr will be merged first
gritty iris
They added the find twice
The same function with tiny changes I just ended up using a function name for now
charred monolithBOT
gritty iris
I think my thought process behind not using initialLocale:\i was because they are forcing the other to english for now but might add translation later
they could also just remove the entire module and none of this mattered 
shut vineBOT
@fossil inlet, <t:1767575391:R>: make plugin bisection menu
dusk blaze
bisecting sadan
charred monolithBOT
bronze glacier
they added like a time mention iirc
yes, as an experiment
-# hopefully it goes through
austere talon
I think there's a high likelihood it does
still maple
yes, as an experiment
-# hopefully it goes through
i still prefer Vencord's plugin UI, it's way better and offer every possible one
also having a datetime picker is just so :_chef:
gritty iris
you're gonna support asar right 
austere talon
not initially
gritty iris
not initially
aw now i actually gotta add it 
chrome coral
aw now i actually gotta add it <:trolley:1024751352028602449>
you're free to help with the pr https://github.com/Vencord/Installer/pull/165
but the patcher/unpatcher is not as robust as I would like because it doesnt handle every single case of someones shitty discord install
it just expects the discord instance to be not broken
gritty iris
you're free to help with the pr https://github.com/Vencord/Installer/pull/165
asar isnt merged yet so it would probably be best to leave that out
or maybe add a flag to it for now to trigger asar I guess for test use
chrome coral
not adding any flags then
gritty iris
not adding any flags then
so I shouldnt work on it for now?
chrome coral
you're free to but like if its still a wip even on vencords side then it should wait because the installer rw still needs work on other stufff
it cant fixup installs really like the go installer
not robust enough and cant even support custom installs in the gui yet
I think those should be handled first before moving on to a new way of patching
charred monolithBOT
gritty iris
forgot comment rce isnt stable compat but promptToUpload is
I 100% went how often is this too change? prob wont and then threw it in
if you want I can make rce stable compat as well the ending is whats breaking it \}\)\]
charred monolithBOT
bronze glacier
@austere talon Would I be wasting my time if I integrated this into the existing plugin?\
austere talon
probably
brazen bone
alr I'll go work on some raycast plugins then
Raytracing plugin when
hybrid blaze
lol
charred monolithBOT
charred monolithBOT
odd heath
i think RCE makes it impossible to see when a message failed to send
cuz they dont turn red anymore
gritty iris
i think RCE makes it impossible to see when a message failed to send
it should have a little text blurb?
bottom left of the message
odd heath
ill check when i get the chance
odd heath
bottom left of the message
theres literally nothing to tell unless you hover over it and see the resend button and i think thats quite bad
unless im blind but this looks exactly as if it has been send
this might send twice idek discord is weird
gritty iris
theres literally nothing to tell unless you hover over it and see the resend but...
the message is missing too tf
odd heath
yea thats why i brought it up
if the plugin makes it indistinguishable whether a message is sent or not thats pretty annoying
gritty iris
odd heath
isnt that mobile only
gritty iris
that thing
gritty iris
maybe it is mobile then
odd heath
i mean the "hold" suggests so
gritty iris
it should probably be red if it failed instead of role color
odd heath
yeah not just probably
well maybe ill look into it later
actually ill do it now just for the fix(RCE) pr title
gritty iris
actually ill do it now just for the fix(RCE) pr title <:trolley:1024751352028602...
real
odd heath
wow
the patch finds on send failed
😭
literally nobody considered that case which is ironic to me
but simple fix
hybrid blaze
vgh
charred monolithBOT
odd heath
we dont
odd heath
hybrid blaze
chrome coral
ai slop fortunately
twilit vector
charred monolithBOT
charred monolithBOT
hybrid blaze
charred monolithBOT
desert cosmos
millions will kill webp
austere talon
but discord makes webps that look like crap
u can see the quality drop whenever it switches to webp (and even the colour changes lmao)
so insane 😭
elder plinth
u can see the quality drop whenever it switches to webp (and even the colour cha...
can you send image
austere talon
elder plinth
what does this become a webp when client loses focus or smthn
elder plinth
oh im stupid thats a video of the offending files
I wanted the offending file lol
oh weird
it does that on the media proxy
on the cdn the look identical
austere talon
because cdn does not support any of these parameters
elder plinth
ah right cdn changes the ext itself
charred monolithBOT
twilit vector
i'm not able to get a sticker to appear in upload, so might be related?
desert cosmos
50% chance of role colour everywhere, 50% chance of actual rce
austere talon
discord supports apng natively now right
dont need to convert apng to gif anymore in fakenitro
desert cosmos
apng so useless
austere talon
nope
discord is insane
but you can get apng stickers as webp i think
uh u cant
WHAT https://media.discordapp.net/stickers/1061724261666005002.webp?size=512&lossless=true&animated=true
MEDIA PROXY INSANE
vtest
odd heath
That causes a more visible change though 
I liked them being colored while sending now I'm gonna be annoyed 🥀
Whatever floats your boat
austere talon
hmm
maybe we can use the role colour but less dark instead
smth like this
but idk
they should be greyed out in some way to indicate its sending
odd heath
they should be greyed out in some way to indicate its sending
They are?
austere talon
how
austere talon
oh
median rapids
discord supports apng natively now right
yop
odd heath
Unless im completely crazy
austere talon
no it doesnt play lmfao
median rapids
without other text in it
median rapids
it works for me
austere talon
Unless im completely crazy
no youre right
median rapids
lemme show u
austere talon
i didnt realise
austere talon
bro is static
austere talon
I liked them being colored while sending now I'm gonna be annoyed 🥀
you're a masochist for using that feature btw
i hate it so much
odd heath
Did you not undo the rce change
elder plinth
-# Excuse my linux terminology, I'm new to this.
Those alternatives don't work. I've spent the last like 7 hours on trying to get middle click to stop pasting in Discord 😭. The setting in plasma works only on wayland apps. Discord runs in XWayland.
So for both your points:
- Neither xmousepasteblock nor xmousepasteblock-git work. They both allow the initial paste into the text box to send, but subsequent ones are blocked. It's a weird buggy 50% working situation, but the fact the initial one still pastes makes it worthless overall.
- Force Discord to run in Wayland. Well then multi-clienting becomes scuffed as all of the windows for stable, ptb, canary, and dev will group into one once launched even if you have different wm_classes set in your launch files. There's also apparently a lot of other side effects to forcing Discord to run in Wayland, but I can't really speak to that ||(gemini said so)||.
Ended up just rewriting the plugin in the pr to use patches and intercept Discord's paste handlers. Still slightly scuffed as it relies on a onMouseUp for middle clicks as you can't differentiate between a middle click paste and a normal paste otherwise, but seems to be working fine for me.
charred monolithBOT
chrome coral
wording unfortunately looks like ai
odd heath
why are we returning if the send doesnt fail?
vee reversed the if twice but only reversed half of it the second time
dusk blaze
ai slopping prs at a very high rate
dusk blaze
screenshots: n/a (context menu entries only)
austere talon
ai slopping prs at a very high rate
we should add agents.md file that instructs the ai to add its own name to the copyright line
dusk blaze
we should add agents.md file that instructs the ai to add its own name to the co...
yop
still maple
-# Excuse my linux terminology, I'm new to this.
Those alternatives don't work. ...
I want to post the gnu copypasta to so bad
desert cosmos
we should add agents.md file that instructs the ai to add its own name to the co...
this is such a fire idea
elder plinth
tell it to replace a random word in the copyright header with banana
still maple
this is such a fire idea
imo my idea was better #🪅-progaming message
gritty iris
imo my idea was better https://discord.com/channels/1015060230222131221/12239731...
their readme
charred monolithBOT
woven saffron
Hope its not wrong to ask (or if i am supposed to ask), could I get my PR reviewed? (3885)
charred monolithBOT
willow garden
Hope its not wrong to ask (or if i am supposed to ask), could I get my PR review...
request it on github lol
also it’s out of date lol
woven saffron
also it’s out of date lol
whatcha mean?
I made the changes from Form to not use anything Deprecated
willow garden
woven saffron
You gotta be trolling yeahh?
willow garden
woven saffron
That just means I haven’t synced my branch to the main branch, there aren’t conflicts.
willow garden
yeah that’s what i said 😭
woven saffron
My bad, I thought u said something like it was an issue.
charred monolithBOT
hybrid blaze
twilit vector
most amount of reviews in a vencord pr
desert cosmos
2
still maple
Wouldn't it be funni if one created an AI that just review all PRs with LGTM
rotund canopy
mmmaaaybe?
hollow musk
mmmaaaybe?
i like the notifications, i really hope that it can get merged
charred monolithBOT
twilit vector
not bad actually
charred monolithBOT
twilit vector
terrible terrible idea.
charred monolithBOT
gritty iris
wont that just disable it entirely 😭
austere talon
yes
gritty iris
yes
I just noticed rip your reviewdb badge https://cdn.discordapp.com/emojis/1011051634295590942.webp?size=128&quality
austere talon
what happened
charred monolithBOT
charred monolithBOT
odd heath
horror
hybrid blaze
charred monolithBOT
gritty iris
I just figured I'd report this incase vencord also has the issue https://github.com/Vendicated/Vencord/blob/5c7a90c05f9b51fe0cb44d5d7dc7181861cd81b2/src/plugins/voiceMessages/native.ts#L16 some filenames werent being set to recording.ogg instead I was getting 0recording.ogg 1recording.ogg 2recording.ogg etc only happens when recording with a mic
grave mangoBOT
I just figured I'd report this incase vencord also has the issue https://github....
native.ts: Line 16
if (filename !== "recording.ogg" || !filePath.startsWith(discordBaseDirWithTrailingSlash)) return null;
0recording.ogg C:\Users\~\AppData\Roaming\discordcanary\ C:\Users\~\AppData\Roaming\discordcanary\module_data\discord_voice\0recording.ogg
``` I got that from running discord from consolejust tested it on vencord it the issue does happen as well
austere talon
is that why some people get failed to finish recording
insane
what is wrong with discord
charred monolithBOT
charred monolithBOT
lusty vector
My bad
hybrid blaze
this is why
charred monolithBOT
charred monolithBOT
charred monolithBOT
austere talon
guhhh
gritty iris
oh i was about to do that
I did it when I got bored because they pushed stable lol
gritty iris
do they just keep every voice message
only if it fails tmk
austere talon
tmk?
gritty iris
to my knowledge
I didnt see it bloat if it doesnt fail
but could've been a one off
austere talon
ill just delete it
diff --git a/src/plugins/voiceMessages/native.ts b/src/plugins/voiceMessages/native.ts
index bbc19c89..e191b377 100644
--- a/src/plugins/voiceMessages/native.ts
+++ b/src/plugins/voiceMessages/native.ts
@@ -5,20 +5,21 @@
*/
import { app } from "electron";
-import { readFile } from "fs/promises";
+import { readFile, rm } from "fs/promises";
import { basename, normalize } from "path";
export async function readRecording(_, filePath: string) {
filePath = normalize(filePath);
const filename = basename(filePath);
const discordBaseDirWithTrailingSlash = normalize(app.getPath("userData") + "/");
- console.log(filename, discordBaseDirWithTrailingSlash, filePath);
- if (filename !== "recording.ogg" || !filePath.startsWith(discordBaseDirWithTrailingSlash)) return null;
+ if (!/^\d*recording\.ogg$/.test(filename) || !filePath.startsWith(discordBaseDirWithTrailingSlash)) return null;
try {
const buf = await readFile(filePath);
return new Uint8Array(buf.buffer);
} catch {
return null;
+ } finally {
+ rm(filePath, { force: true }).catch(() => { });
}
}
pnpm test
austere talon
I did it when I got bored because they pushed stable lol
thanks
gritty iris
wasnt sure what potionbutton looked like before so not too sure if they actually removed it but it was gone from that spot
do you want me to pr any of my finds I added to webpack/common?
or atleast add the ones used multiple times and just import to where they're used
gritty iris
this could 100% be like 25-30 but I made it 50 just incase they add smth else
charred monolithBOT
austere talon
this could 100% be like 25-30 but I made it 50 just incase they add smth else
yeah but always use lazy
no matter what
gritty iris
Noted
gritty iris
Devs const
gritty iris
I guess import would've been better
hybrid blaze
it is
gritty iris
neat
charred monolithBOT
tacit marten
Just stumbled on this, and I wanted to say you are not alone.
I had to switch from Vesktop to get better performance, and it was laggy even without themes. It just started randomly recently, and is very evident when typing.
Platform is Windows, if that matters.
still maple
ok so there's smth really weird
the perf being shit seems related to discord force enabling the new settings panel
i mean "new"
austere talon
i have the lag too but it even happens on stock discord (canary) without vencord
Discord cooked
hybrid blaze
discord always
charred monolithBOT
desert cosmos
discord introduced @time i think its fully rolled out
please kill sendtimestamps ❤️
tacit marten
i have the lag too but it even happens on stock discord (canary) without vencord
Try the competition (other Discord clients), I think they are better except one had a weird quirk on Windows.
austere talon
no
tacit marten
Understandable, have a great day.
barren zealot
~~what are the differences in getting the workspace started in linux and mac? i am doing something that requires windows, linux and mac and i need to know how to set the repo up in all OSes. I know windows is just git clone, pnpm build and pnpm inject, is it the same in other OSes? ~~
forget what was said, i found the docs
dusk blaze
please kill sendtimestamps ❤️
or make it better
idk spawn sendtimestamps modal when @time is pinged
because it fucking sucks in its current state
still maple
discord introduced @time i think its fully rolled out
Imo it's way worse than Vencord's plugin, a time picker so much more convenient
hollow musk
best of both worlds, use either whenever you want
errant nacelle
there's also the timestamp tooltip experiment, it's a bit weird they didn't merge these two into one ui
twilit vector
they dont know about when prs get reviewed.....
charred monolithBOT
charred monolithBOT
fossil inlet
fake deafen
good for privacy
austere talon
average turk pr
charred monolithBOT
austere talon
hybrid blaze
insane
austere talon
i cant reproduce the lag that people have been talking about
hybrid blaze
what lag
odd heath
what lag
errant nacelle
Uhh try disabling all userplugins, hope that helps!
austere talon
or well it does feel slightly laggy but even stock discord feels laggy
fossil inlet
i don't get any lag, but i am running https://github.com/Vendicated/Vencord/commit/7098f41c5
(this is just my laptop, my desktop has the lag)
desert cosmos
smart
still maple
there's also the timestamp tooltip experiment, it's a bit weird they didn't merg...
That UI is a crime, but the UX is a beauty
still maple
i experienced it once a few days ago but now not anymore
I think discord fixed it
Cause it's fixed for me too
I think they did an extra bad update
twilit vector
lmfao
elder plinth
lol
dusk blaze
are you stupid
twilit vector
refer to their username for your answer
hybrid blaze
interesting 🤭
charred monolithBOT
charred monolithBOT
hybrid blaze
dusk blaze
<:smughehe:955421331254554624>
@fossil otter
charred monolithBOT
desert cosmos
twilit vector
dupe send moment
unkempt oak
can't believe Vencord is ai slop now
fossil inlet
doesnt discord already kinda do that or am i wrong
woven saffron
doesnt discord already kinda do that or am i wrong
For @s yah not #s
woven saffron
(source: just tested)
fossil inlet
just reuse their code
woven saffron
I dont think his code is right
.replace(/[^\w\s-]/g, ""); doesn't \w only match [A-Za-z0-9_] so this just fucks up any non-latin script
woven saffron
what da helly
elder plinth
oh I have unicode flag off
fossil inlet
you also need to normalize it eg replace é with e
elder plinth
only difference was pcre2 with unicode flag on. it detected the jp and kr
[^\p{L}] is better anyways
full support other than base python. but the popular 3rd party regex package supports it so
nifty page for regex https://en.wikipedia.org/wiki/Unicode_character_property
woven saffron
love you wikipedia.
I will forever despise teachers who say "never use wikipedia".
charred monolithBOT
hybrid jetty
I will forever despise teachers who say "never use wikipedia".
Agreed
odd heath
EquicordDevs
charred monolithBOT
desert cosmos
When the plugin is old enough to use discord
odd heath
When the plugin is old enough to use discord
Before that happens the world won't exist anymore
brazen bone
I will forever despise teachers who say "never use wikipedia".
I have never seen a teacher who says to never use wikipedia
Never cite wikipedia is what they usually say
austere talon
teachers in 2010: never use Wikipedia
teachers in 2026: never use grokipedia
🗿
twilit vector
i was not expecting to see korean in descriptions
hybrid blaze
insane
austere talon
aislop
dusk blaze
@austere talon merge
charred monolithBOT
twilit vector
should the license comments at top of plugins stay as they are or can i normalize them to the short design wherever i see them?
-# i might aswell since i'm doing the description-pass pr
grave mangoBOT
[embed moment](https://github.com/Vendicated/Vencord/blob/main/src/plugins/accou...
index.tsx: Lines 1-5
/*
* Vencord, a Discord client mod
* Copyright (c) 2024 Vendicated and contributors
* SPDX-License-Identifier: GPL-3.0-or-later
*/
dont change
twilit vector
ok
charred monolithBOT
elder plinth
wouldnt accessing .Message instantly just make it not lazy? 🤔
chrome coral
i looked into using iced instead of slint for the installer and it does support no gpu using tiny-skia
uses software rendering
had someone else test it for one of my other apps
gritty iris
not sure if this was done or not but this should be the old key mappings just updated to the new keys
I didnt check what was removed I just used a thing to update the keys
woven saffron
Adds a global Reading List (like pinned messages, but across servers and DMs), accessible from the top toolbar with actions in the message popover and context menu.
https://github.com/Vendicated/Vencord/pull/3924
How's this diff from bookmarks?
@honest field
twilit vector
doesnt require nitro
woven saffron
ohh shit never realized
twilit vector
yeah requiring nitro is so mid
tacit moth
I have a user app that does this
https://github.com/scrazzz/bookmark-bot shameless plug
twilit vector
well well this does look cute
hybrid blaze
oh dear emojis
tacit moth
ye makes the text more clear
dusk blaze
cba actually
charred monolithBOT
charred monolithBOT
fossil inlet
companion now has full support for enums!
fossil inlet
companion now has full support for enums!
should be out on the vscode marketplace now
willow garden
when zed
fossil inlet
when i port it to LSP
willow garden
🔥
fossil inlet
but lspclient-node is a pain to work with
it should be very easy to port it tho
all the logic isn't tied to vscode
elder plinth
should be out on the vscode marketplace now
does this include higher launch timeout
fossil inlet
Nope
elder plinth
agony
fossil inlet
Forgot about that
elder plinth
git pull it is
fossil inlet
I'll do it tonight
fossil inlet
does this include higher launch timeout
should be on marketplace now
desert cosmos
companion now has full support for enums!
your extension or official
can we have sadan muter back
nimble pendantBOT
vtest canary
Now testing! 
twilit vector
i think it exploded
austere talon
vtest dev canary
nimble pendantBOT
vtest dev canary
Now testing!
austere talon
I messed up the command
desert cosmos
good
twilit vector
i do not understand what's happening here but i have a feeling that's atrocious discord code.
just small smidge of a feeling
austere talon
what's wrong here?
hybrid blaze
hybrid blaze
🫡
austere talon
if they keep this, custom themes are dead
well
technically still possible
but atrocious
limber skiff
oh my god
😂
they even mangled the keys
that's gonna destroy so many of our finds
hybrid blaze
some
austere talon
now the question is whether they did this intentionally to make themeing harder or just random bundler change some dev cooked up
limber skiff
also why is the action timing out
@austere talon
I have never seen this before LOL
oh my god they are cooking with the bundler
austere talon
isn't that straight up invalid syntax
limber skiff
0,118356(e,t,n){"use strict";n.d(t,{$o:()=>o,Vy:()=>d,gZ:()=>u,si:()=>c}),n(896048);var r=n(631159);function i(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}let a="\nfont-weight: bold;\ncolor: purple;\n",s=()=>{};function o(e){s=e}let l=()=>{};function c(e){l=e}function u(e,t,n){for(var r=arguments.length,i=Array(r>3?r-3:0),s=3;s<r;s++)i[s-3]=arguments[s];"file-only"!==t&&Vencord.Plugins.plugins["ConsoleJanitor"].shouldLog(arguments[0],arguments[1])&&console[t]("%c[".concat(e,"]"),a,n,...i)}class d{enableNativeLogger(e){this.nativeLoggerEnabled=e}constructor(e="default"){var t=this;i(this,"name",void 0),i(this,"nativeLoggerEnabled",void 0),i(this,"logDangerously",function(e){for(var n=arguments.length,r=Array(n>1?n-1:0),i=1;i<n;i++)r[i-1]=arguments[i];s(t.name,"log",e,...r),t.nativeLoggerEnabled&&(null==l||l(t.name,"log",e,...r))}),i(this,"log",function(e){for(var n=arguments.length,i=Array(n>1?n-1:0),a=1;a<n;a++)i[a-1]=arguments[a];(0,r.G)(e,...i),s(t.name,"log",e,...i),t.nativeLoggerEnabled&&(null==l||l(t.name,"log",e,...i))}),i(this,"verboseDangerously",function(e){for(var n=arguments.length,r=Array(n>1?n-1:0),i=1;i<n;i++)r[i-1]=arguments[i];s(t.name,"debug",e,...r),t.nativeLoggerEnabled&&(null==l||l(t.name,"debug",e,...r))}),i(this,"verbose",function(e){for(var n=arguments.length,i=Array(n>1?n-1:0),a=1;a<n;a++)i[a-1]=arguments[a];(0,r.G)(e,...i),s(t.name,"debug",e,...i),t.nativeLoggerEnabled&&(null==l||l(t.name,"debug",e,...i))}),i(this,"info",function(e){for(var n=arguments.length,i=Array(n>1?n-1:0),a=1;a<n;a++)i[a-1]=arguments[a];(0,r.G)(e,...i),s(t.name,"info",e,...i),t.nativeLoggerEnabled&&(null==l||l(t.name,"info",e,...i))}),i(this,"warn",function(e){for(var n=arguments.length,i=Array(n>1?n-1:0),a=1;a<n;a++)i[a-1]=arguments[a];(0,r.G)(e,...i),s(t.name,"warn",e,...i),t.nativeLoggerEnabled&&(null==l||l(t.name,"warn",e,...i))}),i(this,"error",function(e){for(var n=arguments.length,i=Array(n>1?n-1:0),a=1;a<n;a++)i[a-1]=arguments[a];(0,r.G)(e,...i),s(t.name,"error",e,...i),t.nativeLoggerEnabled&&(null==l||l(t.name,"error",e,...i))}),i(this,"trace",function(e){for(var n=arguments.length,r=Array(n>1?n-1:0),i=1;i<n;i++)r[i-1]=arguments[i];s(t.name,"trace",e,...r),t.nativeLoggerEnabled&&(null==l||l(t.name,"trace",e,...r))}),i(this,"time",(e,t)=>{let n=Date.now(),r=t();return this.log(e,Date.now()-n),r}),i(this,"fileOnly",function(e){for(var n=arguments.length,r=Array(n>1?n-1:0),i=1;i<n;i++)r[i-1]=arguments[i];s(t.name,"file-only",e,...r),t.nativeLoggerEnabled&&(null==l||l(t.name,"file-only",e,...r))}),this.name=e,this.nativeLoggerEnabled=!1}}}
this is what we are trying to eval
austere talon
yeah makes sense
limber skiff
right...
because before it was anonymous function
and now it includes the name
yikes
austere talon
so that's why everything is failing
limber skiff
yeah
austere talon
we have to come up with a new solution
we could do {code}
like add {} around it
then use object values to get it
austere talon
maybe they'll revert
limber skiff
fixed it
but everything is dead 😂
this doesn't seem right
huh..
oh
right
split happens multiples times...
unkempt oak
horrible news for canary users
limber skiff
okay actually fixed now
austere talon
push to a new branch and run reporter
hybrid blaze
limber skiff
vtest dev2 canary
nimble pendantBOT
vtest dev2 canary
Now testing!
nimble pendantBOT
vtest dev2 canary
hybrid blaze
why not just wrap it in an object and extract by name? keep the function name and dont have to slice anything
smh like this ig
limber skiff
why tho
seems more complicated than it needs to be
there are only 3 ways this can exist
1: () => ...
2: function(){...}
3(){...}
first and second case were already handed
only the third needs the name stripped and function keyword added
anyways, fixing all these finds will be a good amount of work
I think we should wait a bit and see if they are going to revert or not
hybrid blaze
right 
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now) 
nimble pendantBOT
vtest dev2
limber skiff
alright
limber skiff
this is not harmless
half of our patches depend on something like \i.guilds
where guilds was a class name
odd heath
oh
limber skiff
now it's \i.x
odd heath
ims low
limber skiff
impossible to use
limber skiff
I mean, at the end of the day it is fine probably
but it's just a good amount of work to adjust them
odd heath
yea
limber skiff
and some modules might be very hard to find
odd heath
i mean yeah
fossil inlet
ig themes are pretty much just all based on updating classnames with a script now
limber skiff
huh?
limber skiff
it seems to work but it takes ages
fossil inlet
the first one takes ages, seems the http cache helps with any after that
fossil inlet
companion plugin is fixed for those who use it
elder plinth
pog
fossil inlet
guhhhh
all module ids got re-hashed
(most likely due to new rspack version)
oh
is discord's bundler just generating wrong code?
LMAO
limber skiff
this is what is supposed to happen
fossil inlet
their minifier doesnt catch all use cases of class names
gritty iris
you should probably make this a const
limber skiff
this is what was happening
fossil inlet
you should probably make this a const
not the time
gritty iris
custom entries wont show unless they are in that mapping
fossil inlet
LMAO
wait this is just a discord bug
accessing an undefined property
it didn't exist before the mangle
class names should still be in the same order if anyone was wondering
austere talon
custom entries wont show unless they are in that mapping
yeah i realised a while ago but somehow vesktop shows anyway
vesktop is just cool like that
fossil inlet
what are we going to do about finds that search for classes themselves
eg:
where this is the used class
limber skiff
what now..
gritty iris
yeah i realised a while ago but somehow vesktop shows anyway
For whatever reason sections are fine
Only sections
I have no idea why
I just copy and pasted it as a const and made it return that so it could be pushed too
elder plinth
so is this likely to be a change that sticks and should I get started on updating any of my relevant patches or nah 🤔
elder plinth
oof
limber skiff
It's just the yearly vencord promotion
limber skiff
they break everything so that people join our discord server
fossil inlet
i dont think we've had one in a while
austere talon
looks alright btw
median rapids
surely theyll revert that <:Clueless:947671183103508530>
yeah
austere talon
wait did they undo the class name changes?
fossil inlet
no
austere talon
and reverted to the previous style from months ago
fossil inlet
that's just a weird module
fossil inlet
important is 100% unused afaik
fossil inlet
can you check if chunk 18728 exists
it does
limber skiff
yeah it should load fine then
fossil inlet
are u sure?
REVERT?
austere talon
and reverted to the previous style from months ago
yeah
austere talon
discord so funny
austere talon
names are still mangled in modules
sucks but whatever
fossil inlet
(element tree is what matters)
limber skiff
(element tree is what matters)
doesnt really matter for us lol
mangled names in the modules impacts us much more
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
austere talon
we can still find them if we really need to
can check each export see if it's string and contains substring
limber skiff
when are they actually gonna notice the same two functions copied on every module?
fossil inlet
?remind 3d add companion hover hint for mangled class names
shut vineBOT
Alright @fossil inlet, in 3 days: add companion hover hint for mangled class names
austere talon
new function findModuleByExportedStringsAndMapMangledExports will go hard
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now)
nimble pendantBOT
vtest dev2
austere talon
when are they actually gonna notice the same two functions copied on every modul...
yeah so funny
turbid hatch
limber skiff
fixed already
limber skiff
but half the patches are broken anyway
austere talon
btw keep stable compat in mind if possible
idk how fast they will push to stable
we optimally want to support both at once
fossil inlet
i think most things should be stable compatible by default, ill run reporter against my pr later
limber skiff
I will help tomorrow with porting some patches
gonna push to your branch
should we push what's on dev2 to dev and main already?
or else settings won't work at all once stables gets bumped
@austere talon
austere talon
uh
does it make it functional?
but with some plugins not working
ensure all settings ui works and the app doesn't crash with all plugins enabled (it's fine to crash when opening specific tabs / menus)
if yes, then yes
limber skiff
mostly functional
fossil inlet
i would have known if you did because i would have seen it in the pins 😭
limber skiff
plugin settings dont work
gritty iris
🥀
austere talon
plugin settings dont work
try to fix that first
limber skiff
sort alphabetically by value
fossil inlet
sort alphabetically by value
they all should be except for the first one
limber skiff
try to fix that first
I can do tomorrow but im not sure if they wont push before it
limber skiff
they all should be except for the first one
why is the first one an exception
fossil inlet
why is the first one an exception
it was a key found after they hashed them
limber skiff
move it then
limber skiff
gritty iris
I'll look into some patches in a moment
fossil inlet
I'll look into some patches in a moment <:thumbs_up:1261646788318859264>
I have a PR with a bunch of fixes already
errant nacelle
when are they actually gonna notice the same two functions copied on every modul...
discor loves shipping 10000 polyfill functions instead of updating their build config and accepting that most browsers already support baseline 2015 features
twilit vector
i cant bruh 
charred monolithBOT
austere talon
vtest
austere talon
@limber skiff I think we have to add a new findCssClasses() webpack method
limber skiff
how would that work?
austere talon
just checks if exports are string and contain all your classes
688963(e, t, n) {
"use strict";
e.exports = {
kL: "container__183c2",
Kk: "icon__183c2",
dl: "size56__183c2",
H: "avatarContainer__183c2",
aV: "avatarContainerMasked__183c2",
UC: "clickableAvatar__183c2",
F2: "emptyUser__183c2",
Hb: "size32__183c2",
q1: "size24__183c2",
nc: "size16__183c2",
F_: "emptyUserDimmed__183c2",
WK: "avatarWithBackground__183c2",
my: "avatar__183c2",
In: "moreUsers__183c2",
iq: "moreUsersDimmed__183c2"
}
},
findCssClasses("moreUsers", "clickableAvatar");
// returns
// {
// moreUsers: "moreUsers__183c2",
// clickableAvatar: "clickableAvatar__183c2"
// }
but what if they hash it again?
austere talon
then we cant find
limber skiff
in that case we just hardcode the hash?
austere talon
idk
limber skiff
we could still have something like
findCssClasses({
moreUsers: "includes this",
clickableAvatar: "some hash"
})
so that the reporter catches when the hash changes
austere talon
idk 😭