not all are mana
#👾-core-development
austere talon
charred monolithBOT
charred monolithBOT
austere talon
omg lint broke
I remade the component and signature kinda changed
have fun migrating equicord code
switch.children -> switch.title
switch.note -> switch.description
rest is same
gritty iris
I remade the component and signature kinda changed
ill probably be fine (I hope)
charred monolithBOT
gritty iris
thank you for giving me a heads up 
austere talon
ill probably be fine (I hope)
you can probably get copilot to refactor if u have access
austere talon
I remade the component and signature kinda changed
@limber skiff should we just really remake all the components we use a lot
i remade FormSwitch and FormDivider now, cause FormSwitch is gone and FormDivider is so simple
FormText remake is pr
we could also remake Button and Clickable
and anything else settings uses
limber skiff
<@235834946571337729> should we just really remake all the components we use a l...
only the non hard ones
austere talon
Select is hard
but used here
maybe we could just wrap the hard to remake discord component bits in individual ErrorBoundaries
limber skiff
maybe we could just wrap the hard to remake discord component bits in individual...
yeah
Button is also kinda hard
austere talon
not really
limber skiff
because of css classes and styling
we cant just use our styles
or else themes wont match
austere talon
the only thing we need is Discord css variables
it's not that bad if they break
just degraded ui
limber skiff
we can have fallbacks
austere talon
yeah
gritty iris
you can probably get copilot to refactor if u have access
I normally manually migrate copilot hates me
fossil inlet
you should add a middle stage for when the mouse is down but before it is released
dusk blaze
I remade the component and signature kinda changed
killing myself
austere talon
pr
gritty iris
FormText remake is pr
imo <Paragraph variant="xs/thin" /> is better also seems its used more frequently
elder plinth
did V ever reply to this ;P
elder plinth
does it need to sub to all plugins.PluginName.key or just plugins.PluginName
austere talon
the former
elder plinth
fun
austere talon
however if we adress this ^, it will be able to plugins.PluginName.*
charred monolithBOT
dusk blaze
album art is probably not related to the known-issue
Regex probably broke for the 500th time
dusk blaze
album art is probably not related to the known-issue
this is so unreliable we should either use iTunes API or last fm
pine topaz
https://discord.com/channels/1015060230222131221/1026515880080842772/14237732748...
insane method
wait are we parsing html with regex???
gritty iris
findByProps("timestampTooltip", "blockquoteContainer") timestampTooltip was removed so findByProps("timestamp", "blockquoteContainer") and removing timestampTooltip works fine
["0g8Xd3"]),allowOverflow: allowOverflow was removed so ["0g8Xd3"]),text: would work now
If you want I can pr fixes
austere talon
go for it
charred monolithBOT
gritty iris
not sure if bettersessions would look okay on stable as they removed that tooltip
showhiddenthings wont
gritty iris
showhiddenthings wont
this just works like before but I figured since I was already at it
austere talon
not sure if bettersessions would look okay on stable as they removed that toolti...
wdym
gritty iris
for sessions?
austere talon
it should be fine probably
austere talon
this isnt stable compatible right
gritty iris
nope
I can try if you would like
looks fine
left is stable right is canary
could use 93S+lJ
so #{intl::GUILD_MEMBER_MOD_VIEW_HIGHEST_ROLE}),children:
gritty iris
so `#{intl::GUILD_MEMBER_MOD_VIEW_HIGHEST_ROLE}),children:`
made it this so it works on stable
austere talon
this should be enough
erm what if i change my song a lot ykyk
austere talon
wait are we parsing html with regex???
why not
dusk blaze
erm what if i change my song a lot ykyk
true
i'm not even sure how it detects
still works!
i ran like 40 times
austere talon
is this the part that broke https://github.com/Vendicated/Vencord/blob/main/src/plugins/appleMusic.desktop/native.ts#L32-L45
grave mangoBOT
is this the part that broke https://github.com/Vendicated/Vencord/blob/main/src/...
native.ts: Lines 32-45
let cachedToken: string | undefined = undefined;
const getToken = async () => {
if (cachedToken) return cachedToken;
const html = await fetch("https://music.apple.com/").then(r => r.text());
const bundleUrl = new URL(html.match(APPLE_MUSIC_BUNDLE_REGEX)![1], "https://music.apple.com/");
const bundle = await fetch(bundleUrl).then(r => r.text());
const token = bundle.match(APPLE_MUSIC_TOKEN_REGEX)![2];
cachedToken = token;
return token;
};
yeah
i'm rewriting to use the iTunes api
since it's the same catalog
and to also fix the issue where it pulls wrong album art
dusk blaze
first issue:
- itunes api doesn't use auth
second issue: - instead of
results[0]->results.find(song => song.collectionName === album) || results[0]
dusk blaze
Also what does it do if there's no image
❓
there shouldn't be no image unless you're playing a local file that isn't on AM
austere talon
yes that's what I mean
austere talon
the lastfm api doesn't give album covers you have to scrape
dusk blaze
oh my god
austere talon
you can check like musicbrainz, lastfm, google/bing
dusk blaze
oooor musicbrainz
gritty iris
I know its weird as hell
austere talon
wait no the lastfm does give album cover
it only doesn't give artist image
iirc
okay yeah it gives cover I'm dumb
ignore what I said
limber skiff
I think they are deprecating react nodes as tooltip text?
dusk blaze
austere talon
but you have to provide an api key
dusk blaze
okay works
austere talon
I think they are deprecating react nodes as tooltip text?
wtf cringe if true
limber skiff
let me confirm it
dusk blaze
slop
limber skiff
I mean
limber skiff
wtf cringe if true
they changed everytime that a component is passed to text to use __unsupportedReactNodeAsText instead
gritty iris
Probably didn't add a thing for it yet
limber skiff
god these images look so shit
gritty iris
I know it for sure works for now because I already fixed something that uses it
dusk blaze
but you have to provide an api key
about that why aren’t we just providing an api key
they aren’t private by any means
rate limiting is IP based afaik
dusk blaze
ig :snackstare:
maybe at least for amrpc since relying on lfm fallback shouldn’t happen thaaaat much
austere talon
just don't add fallback tbh
who cares
local file listeners are used to it
same thing happens with official Spotify presence
dusk blaze
truee
charred monolithBOT
charred monolithBOT
charred monolithBOT
bleak blaze
its not the worse idea just could’ve been done better
hollow musk
i mean it would be useful if you talk in different servers and want to recall a message from a different server to send in another server
a bit niche, but it reminds me of the chat history stuff that certain tuis use for vIbEcOdInG
austere talon
scary
austere talon
nina woke
austere talon
just drop it tbh no one cares about that
dusk blaze
or add as option
either show nothing or apple music or artist pfp ykyk
if it breaks less people notice ykyk
dusk blaze
i think it has cache but until you restart client
austere talon
oh yeah im blind
dusk blaze
just drop it tbh no one cares about that
Rosie probably does @warped frost
she’s like only other documented amrpc user
austere talon
amrp removed soon
austere talon
just rewrite vencord with cursor <@343383572805058560>
kys
dusk blaze
whtever i can’t hop on Mac right now so ill do in a few hrs
either option or i remove and make a plugin to monkeypatch it back in
oh i forgot discord supported custom RPC links now
@astral birch how did you do on gramophone rpc
astral birch
@dusk blaze
fossil inlet
I mean it has a source map attached so just get the information from it?
astral birch
do it urself I'm tryna game here
fossil inlet
do it urself I'm tryna game here
Not at home rn
astral birch
also like you can just look at the code here
the presence url stuff isn't transpiled
fossil inlet
I can't wait for typescript to finally become a second class citizen in node so I can stop using es build for everything
fossil inlet
I can't wait for typescript to finally become a second class citizen in node so ...
(it will never happen even when transform types becomes default)
(decorators my beloved)
austere talon
just send the source
it has sourcemap just get source urself ykyk
fossil inlet
it has sourcemap just get source urself ykyk
Me when I can't read
austere talon
fossil inlet
https://evanw.github.io/source-map-visualization/
Oh I just use a vs code extension that does it for me
fossil inlet
wrong type alert
This is why I'm so happy about the typescript 6.0 change
austere talon
This is why I'm so happy about the typescript 6.0 change
whats it change
fossil inlet
whats it change
dusk blaze
dusk blaze
rare good PR
charred monolithBOT
austere talon
rare good PR
it's just copy paste 😭
austere talon
MinecraftBedrockArabic
dusk blaze
listioning
prime dew
Literally the snippet I'm working on 
dusk blaze
why is he still sneaking in his abandonware
bright island
gits and shiggles
brazen bone
NoBlockedMessages is so last gen, where's OnlyBlockedMessages
charred monolithBOT
charred monolithBOT
austere talon
lol found a reporter bug
austere talon
does this look right @limber skiff
i just change this from webp to png
instead of removing the block
austere talon
yes
also this is how I learn better gif alt text is bugged and adds it to all images not just gifs lmao
limber skiff
okay I think that's fine yeah
desert cosmos
hey why was this closed? this looks totally fine
austere talon
i lbocked his ass
austere talon
2nd but yeah
and his 2nd pr broke a new rule
he clearly didnt read anything so I just blocked
breaking rules is fine but if I close your pr for breaking rules and then 10 minutes you open another pr thats breaking a second rule...
natural selection
kindred viper
MinecraftBedrockArabic
dusk blaze
vee on abandonware closing streak
dusk blaze
this broke ages ago
austere talon
I will try to fix circular dependencies in vencord soon
fixing them in vesktop was super easy
i think it's just removing any top level code in plugins/index.ts (and maybe some other files) and instead putting it into a init() function then calling the function from index
brazen bone
Unless it dies of preventable diseases
odd heath
Unless it dies of preventable diseases
it is a child in the us and the parents dont believe in vaccines
odd heath
hey why was this closed? this looks totally fine
the sad part is this is all you need to actually do it 😭 😭 its so simple and yet theres some shit with dom manip
anyway should i add hiding reactions from blocked users
fossil inlet
anyway should i add hiding reactions from blocked users
I would just hide their avatar in who reacted
gritty iris
in what country
just 10 more years in the usa dont worry it will eventually happen
bright island
3492 ffs
austere talon
whar
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/467da909d60a11c9e3b896e5943a10c6e2ff4...
ContextMenu.ts: Line 175
(obj.type !== Menu.MenuControlItem || obj.type === Menu.MenuControlItem && obj.props.control != null)
ngl this is pretty bad
why does our clone children function have to explicitly check for those
I dont even remember anymore
austere talon
I dont even remember anymore
austere talon
**ContextMenu.ts:** Line 175
```ts
(obj.type !== Menu.MenuControlItem || obj.typ...
@brazen bone why this Menu.MenuControlItem check?
brazen bone
Don't remember, but maybe cloning the control caused issues with state management or something
charred monolithBOT
charred monolithBOT
desert cosmos
vencord translation releasing 2076
austere talon
vtest
gritty iris
weird it worked for me
well I mean technically it did 💀
anyways I get the point 
I prob forgot to revert some bettersettings changes so mine showed like that lol
scenic brook
aaaa
charred monolithBOT
gritty iris
it should be like this
I saw lol
charred monolithBOT
olive aurora
@austere talon rate ```diff
diff --git a/src/plugins/webContextMenus.web/index.ts b/src/plugins/webContextMenus.web/index.ts
index be85e33c..c7c913ab 100644
--- a/src/plugins/webContextMenus.web/index.ts
+++ b/src/plugins/webContextMenus.web/index.ts
@@ -128,8 +128,8 @@ export default definePlugin({
replace: "false"
},
{
-
match: /canCopyImage\(.+?(?=return"function"==typeof \i\.clipboard\.copyImage)/, -
replace: "$&return true;"
-
match: /(?<=canCopyImage\(.{0,240}?)typeof \i\.clipboard\.copyImage/, -
replace: '"function"' } ] },
wait wrong diff
on stable its "function"==typeof x, but on canary right now its "function"!=typeof x and the branches changed
so this works for both
austere talon
<@343383572805058560> rate ```diff
diff --git a/src/plugins/webContextMenus.web/...
lol I came up with the exact same thing
{
match: /(?<=canCopyImage\(.+?)typeof \i\.clipboard\.copyImage/,
replace: '"function"'
}
mine
olive aurora
goood
charred monolithBOT
austere talon
vtest
charred monolithBOT
odd heath
@fossil inlet shouldnt it be user-companion in the when 😭
otherwise conflicts with the settings you have blabla
fossil inlet
don't remove old ones, just add new ones for backwards compat
odd heath
sure
charred monolithBOT
odd heath
slop code
im not even sure but i think with channelstream filtering the other code removing the groups might just be obsolete
too lazy to figure that out rn
austere talon
yes one day
odd heath
Why is it a pumpkin 😭
odd heath
yes one day
Do i have to fix it for you
austere talon
basically just moved all the top level code in plugins/index.ts to an init() function that's called from Vencord index
austere talon
I also had to move this function to a different file so @utils/misc doesn't import webpack
austere talon
limber skiff
I also had to move this function to a different file so @utils/misc doesn't impo...
that's fine
the functions in util shouldnt use discord code
austere talon
yeah
exactly
this is the file that exports things like classes() function
which is used in ErrorBoundary indirectly
so ErrorBoundary was accidentally importing webpack commons
which it shouldn't
limber skiff
u should remove the comments about circular dependency too
limber skiff
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/078043d5cd63da42affe7ae9e897f9696c88c...
utils.ts: Line 26
// Non import access to avoid circular dependency
i moved plugins/index.ts -> api/PluginManager
not related to fixing circular imports, I just thought it was better
limber skiff
yeah that's good
we should separate vencord apis from apis that wrap discord stuff
like Settings api shouldn't be in the same place as UserSettings api
makes it confusing to know what belongs to what
charred monolithBOT
limber skiff
like Settings api shouldn't be in the same place as UserSettings api
should we potentially do this in this same PR?
gritty iris
so...
fossil inlet
@austere talon why not just enforce type imports as required
austere talon
should we potentially do this in this same PR?
probably not
gritty iris
Autodnd started a spark in some people 😭
bright island
this guy
gritty iris
lmfao
fossil inlet
Isn’t this already a native feature for forums or am I crazy
scenic brook
I think they just mean general messages, not just the initial post
austere talon
vext
desert cosmos
veee 😭
jagged cloak
lol
odd heath
im not even sure but i think with channelstream filtering the other code removin...
it was 
charred monolithBOT
fossil inlet
@austere talon been thinking of making some custom eslint rules for a bit, is this something you would be intrested in/have any ideas for?
austere talon
sure yeah
fossil inlet
sure yeah
id love to hear ideas
the only thing i have off the top of my head is forbidding imports
also thinging about something for prefering useStateFromStores and settings.use over their non-reactive counterparts
also something for warning if a setting is used in a predicate but does not need a restart
odd heath
formsection gone
surely its just a different find needed right 
odd heath
awful
gritty iris
mana
odd heath
well i cba to compare stable and canary and make it work sooooooo
not my pr relying on selects
odd heath
enjoy
fossil inlet
formsection gone
Discord is probably deprecating their form components
We should probably move off of them
gritty iris
their moving to mana
fossil inlet
their moving to mana
Yeah
odd heath
their moving to mana
what specifically does this mean
austere talon
they've been remaking their settings ui for a while, moving away from the old form components
brazen bone
their moving to mana
What's mana? Hardly @mana-ui/ui which has 1 dl/w
odd heath
yea i wanna know what exactly that is and how it changes things 😭
fossil inlet
What's mana? Hardly @mana-ui/ui which has 1 dl/w
My guess is it's their internal name for their new component system
With the previous one being void (I think)
brazen bone
Oh, new internal system, not an existing library
odd heath
ooh i see
fossil inlet
Oh, new internal system, not an existing library
Internal library/system same thing
gritty iris
most components Im finding are with RadioGroup
fossil inlet
most components Im finding are with RadioGroup
Wdym
gritty iris
mana-toggle-inputs goes back to on atleast one component RadioGroup is checked
whatever
search I did
lol
austere talon
gritty iris
619307 select
921349 searchable select
fossil inlet
i think we have to remake FormSection
limber skiff
what's the reason we are remaking form components
fossil inlet
discord removed
limber skiff
didnt we agree they sucked? 😭
fossil inlet
what's the reason we are remaking form components
i don't think we have to remake it exactly, but we have to replace it with something similar
limber skiff
discord removed
no wonder they did
fossil inlet
id love to hear ideas
the only thing i have off the top of my head is forbiddin...
@limber skiff got any ideas for lint rules
charred monolithBOT
austere talon
not the time
charred monolithBOT
austere talon
FormSection literally useless idk why it was ever used
austere talon
we should stop using all Form components
fossil inlet
yes
charred monolithBOT
austere talon
vtest
austere talon
i will merge into main like this for now
austere talon
then we should asap switch to this, at least for settings
charred monolithBOT
austere talon
vtest
odd heath
amazing
charred monolithBOT
fossil inlet
I have a PR for the experiments patch
fossil inlet
😭
austere talon
sorry i didnt mean to sound rude
i just mean it's very low priority cause it's just the error card
much more important to rush out a fix for the settings ui
and also make it future proof
austere talon
cause they're gonna remove more and more formslop the coming week probably
first it was FormSwitch now it was FormSection
the other Form components are also dead afaik
i have replacements for the other Forms in that uikit pr
we should try to make Settings ui discord componentless
or if we really must use a discord component then it has to be inside an individual ErrorBoundary
fossil inlet
we should try to make Settings ui discord componentless
i'd be willing to remake some components
desert cosmos
FormSection literally useless idk why it was ever used
hey its not
odd heath
@austere talon can we have something to disable hellish middle click paste please 😭
so annoying
austere talon
just disable it in ur system bruh
austere talon
wrong
odd heath
how
austere talon
odd heath
im not using xorg
austere talon
odd heath
austere talon
yes you are
odd heath
no im not
austere talon
you are running Discord in Xwayland
odd heath
im running vesktop natively in wayland
austere talon
then the setting would work
odd heath
it should be off in my config though
unless im getting trolled
nop @austere talon electron just blatantly ignores it
unless the config is just fucked
odd heath
its not my config thats fucked
cuz it works for apps that dont involve elctron
unless its just hyprland doing hyprland things
odd heath
i think electron apps just genuinely dont care and electron has no flag override for it to my knowledge
husk
charred monolithBOT
dusk blaze
will this change break my abandonware
odd heath
will this change break my abandonware
yes
limber skiff
holy portuguese
austere talon
i wanna merge that pr fast @limber skiff
it's ready now
it replaces FormText, FormDivider and FormTitle
limber skiff
i wanna merge that pr fast <@235834946571337729>
right now?
austere talon
yeah
limber skiff
why so fast
austere talon
it replaces FormText, FormDivider and FormTitle
I didn't migrate code using it, I just made drop in replacements
the migration should be a separate commit
austere talon
why so fast
cause they're killing form components
last week it was FormSwitch, today it was FormSection
soon the other ones will be gone too
limber skiff
yes but we can wait a day no?
limber skiff
I'm free tomorrow afternoon
austere talon
and I wanna get this in the release
i mean you dont have to review really
we can merge now and check later
limber skiff
if ur sure of the changes then go ahead
I can review tomorrow and commit anything that needs changing
It's fine
charred monolithBOT
austere talon
wtf is eyebrow variant
charred monolithBOT
limber skiff
wtf is eyebrow variant
it's a specific one with uppercase letters iirc
charred monolithBOT
austere talon
i broke webpack so no finds work and main settings page doesnt error now
only plugins page errors still
lmao
cause of this shit
very useful class
oh i didnt break all webpack finds
but now I did (except react)
I caught two plugin crashes
charred monolithBOT
nimble pendantBOT
vtest uikit
Now testing! 
limber skiff
austere talon
<@343383572805058560> make sure you dont merge with forced broken finds <:teef:9...
yeah of course 
we should remake the Button and Clickable components
shouldn't be that hard
austere talon
select is kinda hard to make
and only minor things
imo just wrap in ErrorBoundary
limber skiff
we need like a popup for select right
austere talon
that's not the hard part
you either use the html select element but it's very limited and painful to style
or you remake it, but then you have to ensure it's accessible and has keyboard listeners, etc
turbid hatch
maybe you can borrow a component from react-aria?
just so you arent going from scratch
although aria integrates with its own components heavily so that would mean you'd have to either rewrite the aria component or use all of aria for this one thing
nevermind
austere talon
gonna add shadcn to vencord
turbid hatch
😭
i specifically picked aria because it would've been easiest to style forgetting that aria is kind of all or nothing
austere talon
anyway we don't need to remake everything
turbid hatch
which bits are gone atm?
austere talon
just to a point where settings are still usable in the worst case
austere talon
which bits are gone atm?
the idea is that even if all component finds fail, settings should still work
austere talon
I deliberately made every webpack find except react fail here
the goal is to not crash even with all plugins
and for the settings ui to be usable
turbid hatch
oh that reminds me
i need ur input on translation PR, ill write a comment on github
charred monolithBOT
charred monolithBOT
gritty iris
New vencord working 100% no lie no virus 2025 not released leaks gamer discord
austere talon
making buttons now, based on mana buttons
austere talon
okay im done
charred monolithBOT
austere talon
still need some work
still maple
oh no the rebase gone wrong
wait it's not even an issue of mine, it's an upstream issue
charred monolithBOT
austere talon
charred monolithBOT
austere talon
I did it @limber skiff
austere talon
that uses Modal api
if modal api breaks they wont work
otherwise, I made every settings component individually use ErrorBoundary
so if say Select breaks, only select settigns wont be visible
limber skiff
will the authors section cause errors?
since it uses the avatars component
but that's pretty good
we can even use those components in plugins
charred monolithBOT
austere talon
we can even use those components in plugins
yes I already did lol
I replaced all Forms, Text, Button and (Form)Switch with our own
limber skiff
nicee
austere talon
I didn't replace usages of the non deprecated components yet
I wanna do that in a separate commit
to keep the noise of that out of this commit
well it's still 62 changed files xD
austere talon
is it still called FormSwitch
it still is
what else should we call it
we have Switch that's just the switch
limber skiff
oh
austere talon
and then we have FormSwitch that's the settings component with title and description
this is FormSwitch
discord already axed FormSwitch a week ago so Vencord has been using our own FormSwitch component since a week ago xD
limber skiff
can keep it called FormSwitch then
limber skiff
discord already axed FormSwitch a week ago so Vencord has been using our own For...
what do they use now
gritty iris
switch 
limber skiff
limber skiff
and they still dont center the button vertically
gritty iris
they really removed it just to readd it 😭
austere talon
and they still dont center the button vertically
look at this lmaoo
look at the height
gritty iris
what the
austere talon
the ones that don't have the glow around them still use the old deprecated components
and are 2px higher
that glow feature was so useful for me ahahah cause it made it so easy to find redesign switches
austere talon
look at this lmaoo
the Decor one is our own button component
austere talon
i just made everything look the same as discord's components
gritty iris
cant wait to have to go through hell to port it all
gritty iris
oh btw I have a fix for reviewdb's patch but it needs a better find and I couldnt find the modal
like it patches but I couldnt find the modal to test it
gritty iris
please dont merge this today 😭
austere talon
Discord components are so sane
gritty iris
we all like saturdays right
limber skiff
look at this lmaoo
there's no way...
gritty iris
Discord components are so sane
so... everybody gets a classname?
austere talon
please dont merge this today 😭
I will probably
gritty iris
welp
austere talon
should be ready now
limber skiff
please dont merge this today 😭
why not
charred monolithBOT
gritty iris
I kinda wanna go test it to see how good it looks
charred monolithBOT
austere talon
I added the webpack breaking as a build flag
limber skiff
what
they meant they added an option to force e everything to fail
so you can see what crashes and what doesnt
gritty iris
That's cool helpful for debugging
I saw the webpack was dead earlier so I was wondering what caused it lol
limber skiff
it was intentional
gritty iris
We love that
charred monolithBOT
odd heath
? await UserUtils.getUser(`${user.id}`)
why is it in the string
shouldnt user.id be a string already
odd heath
valid
gritty iris
isnt it using plugin author ids
limber skiff
this should be banned
nuke these margins classes
they just encourage bad code imo
odd heath
it's a bigint
horror
odd heath
isnt it using plugin author ids
ohh true i shoudlve thought of that
least obvious comment
limber skiff
I genuinely hate everywhere that Margin.x is used
gritty iris
ohh true i shoudlve thought of that
devs const:
odd heath
<yea ik
gritty iris
I genuinely hate everywhere that Margin.x is used
okay but that one is genuinly useless
austere talon
they just encourage bad code imo
how?
austere talon
why
gritty iris
least obvious comment
discord out here taking notes
austere talon
so much effort if you just need margins
limber skiff
well
odd heath
discord out here taking notes
dsicord unpaid intern will switch framework out of boredom
trust
limber skiff
most places that use those can instead use a flex component with gap
odd heath
and push to stable without testing
gritty iris
dsicord unpaid intern will switch framework out of boredom
like last time
limber skiff
which is way more clean than margin
odd heath
like last time <:trolley:1024751352028602449>
wait what
limber skiff
like last time <:trolley:1024751352028602449>
what last time
gritty iris
not framework but I remember someone pushed smth and it was just what the hell
either pushed early or some intern was like yup im done for today
I forgot which
possibly switch to rspack I honestly dont remember
limber skiff
😭
austere talon
you would hate tailwind
limber skiff
I wouldnt
but I would rather pick one or another
not combine both
like right now
austere talon
tbh im lazy to always add a css file and come up with classNames
a lot of times I just need margins and nothing else. so the margin classes are very handy
limber skiff
possibly switch to rspack I honestly dont remember
I'm sure they dont regret changing to rspack
iirc their build time was so long before it
gritty iris
I liked the rspack change
it made things interesting for me to find stuff because I was still learning patches and such
limber skiff
I still think they should somehow revive the aggressive tree shaking 
odd heath
I still think they should somehow revive the aggressive tree shaking <:trol:1095...
whats that
limber skiff
not sure if I called it the right way
austere talon
I still think they should somehow revive the aggressive tree shaking <:trol:1095...
scary
limber skiff
but it merged modules way ore hardly
austere talon
do you mean the shit that merged modules
limber skiff
yeah
austere talon
NO
limber skiff
it wasn't that bad
gritty iris
ven got scared
limber skiff
besides non exported things
austere talon
you love having to add patches to get functions & components 😭
limber skiff
gritty iris
nookies loves patching 
limber skiff
or they have to at leaast fix this
have they ever looked at their own bundle to see how many times that's added
so much for minifying when u add that shit to all modules
the plugin that does that is genuinely so dumb
limber skiff
you love having to add patches to get functions & components 😭
I wanna find the commit where they changed that
to see what we had to change
how to find...
do you remember any plugin that had to export a function?
austere talon
look at the pr first 😭
we really need to release browser extension
settings ui is broken
austere talon
yes
limber skiff
okay so the comment can be nuked
austere talon
the other ones were all deprecated anyway (besides eyebrow)
austere talon
okay so the comment can be nuked
the entire thing will be nuked
it's just there for now
austere talon
our own text component uses two separate props
Old:
<Text variant="text-sm/normal" />
New:
<Paragraph size="sm" weight="normal" />
so just to confirm
we are gonna remove the text find
and text component typings
right?
austere talon
yes
austere talon
we are gonna remove the text find
it's already gone
limber skiff
alr
austere talon
it's been broken forever
limber skiff
lol
charred monolithBOT
austere talon
that code was just outdated and bad anyway lmao
charred monolithBOT
charred monolithBOT
limber skiff
yep
austere talon
anyway
i forgot that we have to remove these three props
and they're still in use
i think submitting is just disabled
limber skiff
should the divider potentially just accept all props that hr accepts
instead of style explicitly
limber skiff
It's that only doing style seems a bit weird
austere talon
wait this is this right
limber skiff
yes
austere talon
thats hilarious
innerClassName isnt even used anymore
but it looks fine
so innerClassName is useless
charred monolithBOT
limber skiff
can you confirm this is even needed
seems pointless to keep if we are rewriting
Tag isnt defined in this scope
no wonder its not blue
you called it T, not Tag
austere talon
bruh was this always so misaligned
austere talon
Tag isnt defined in this scope <:trol:1095049440835928234>
this is a rename
not the generic
limber skiff
oh
austere talon
it needs to be upper case or react will think we are trying to create an element called tag
austere talon
wtf
limber skiff
😭
austere talon
that svg is bad
i literally stole it from gh lol
the svg viewbox is 16x16 but the actual path is only 16x14
so to have it line up you have to translate it up 1px
wait no
it was our own style
wtf
austere talon
globals
limber skiff
should export the others then
charred monolithBOT
austere talon
if you mean the new components, yes
austere talon
😭
bro you don't know how hard it is to find crash reason if you make everything error
charred monolithBOT
austere talon
or do you actually want it <:sus:817476250708738088>
yes i wanna keep that
austere talon
it looks fine imo
limber skiff
but ig not even discord does it anymore
limber skiff
it looks fine imo
ye that's okay
austere talon
but we do have to go through our headings and check
limber skiff
maybe a bit smaller?
austere talon
cause these are lower case now
austere talon
tbh I hate components transforming your text
but we have to make sure there are no lowercase headings now
how does this look normally
the heading here
also horror why is there :
limber skiff
does Button centers the component inside
limber skiff
alr good
limber skiff
check with those changes
to make sure i didnt break anything
lol our FormSwitch is using Text from webpack
austere talon
which is TextCompat anyway lmao
limber skiff
I'll change it to Span
