#👾-core-development
charred monolithBOT
austere talon
prd aamias snippet again award
make venapp auto detect aamias snippetr and close the pr
olive aurora
give me perms i will close everything
austere talon
ya rules are pointless the people who need them wont read
just makes it easier to justify why a pr is being closed
bright island
i feel like having a rule about going around an important discord mechanism like spoofing quests or "getting around admin perms" might be useful
fossil inlet
feel free to look into this and pr new workflow (if you want)
alr
austere talon
if a relevant person leaves feedback it automatically moves to in review
for the stale part we could either use stale bot or just do it ourselves with a cron trigger
cron could check once a day for stale prs
austere talon
if a relevant person leaves feedback it automatically moves to in review
maybe we could introduce a fourth category "Needs Re-review"
if all feedback is marked as resolved ci will move there
that way it's super easy to keep track
fossil inlet
have a working version
fossil inlet
https://discord.com/blog/bringing-dave-to-all-discord-platforms
tbh i don't really see this as any issue, afaik DAVE is open source
clients can implement it
gritty iris
I think it would be fun to watch aliucord
fossil inlet
(if they will is another question)
@dapper tiger do https://github.com/discord/libdave
gritty iris
its out?
limber skiff
see you all in 5 days
limber skiff
tell me
gritty iris
I can either get a ref from the actual const or from a component using the same ref but way closer
which is better
limber skiff
the one that's easier
gritty iris
this was d3sox's patch but I figured that was alot so I was making it shorter but I don't know if I should use the front for the ref or ref:
I just grabbed it from one using it 
figured I pr it to his thing if he likes it he can use it
yes I 100% hate the way I did that
no I dont plan on redoing it
also never played hollow knight
was it good
limber skiff
the second is better but it still seems not that good
gritty iris
hes replacing all of this with this
im grabbing ref from here while he gets it from here
module id: 201542
austere talon
https://store.steampowered.com/app/1030300/Hollow_Knight_Silksong/
i never played the first but i kinda got interested
gritty iris
steam is just fucked because of its launch
I just got to the purchase page and then it died again
gritty iris
limber skiff
why didnt they do a preorder
it's steam fault for not being better
gritty iris
real
austere talon
apparently nintendo and ps shops are also affected
weak thistle
everything is/was down
austere talon
limber skiff
i never played the first but i kinda got interested
I played the first and im def playing the second
I'm not home yet
limber skiff
alr
but rn I'm prob gonna say u can start with the second
I doubt they are gonna do so many things related from the first
and iirc it's likely a prequel to the first game
but I have yet to confirm
limber skiff
okayy
limber skiff
I just grabbed it from one using it <:Joe_Shrug:1304274203431796756>
/\(0,\i\.jsxs?\)\(.{0,50}\.playbackRateContainer.+?}\)}\)(?<=ref:(\i),className:\i\.audioElement.+?)/
gritty iris
jesus
limber skiff
capturing group 1 is now the ref
and no more capturing group for the extra you just have to insert again
the whole match is what you need to remove
limber skiff
`/\(0,\i\.jsxs?\)\(.{0,50}\.playbackRateContainer.+?}\)}\)(?<=ref:(\i),className...
untested but unless I made a mistake it should work
gritty iris
and very performant
I had to change a few of mine
they were so slow until I removed the lookback
lol
limber skiff
yes it depends how you use it
gritty iris
yup I realized after that day lmfao
leaden furnace
tweaks section good
gritty iris
I know lol
I forgot your username to ping 😭
I'm not that smart
English isn't my first language if coding was one it would be
Then english
Yw
limber skiff
@austere talon we need a project for improvements
austere talon
remove anything above 2 and add a slider for fine grained
limber skiff
austere talon
theres a menuslider
limber skiff
this is your pr btw @austere talon
austere talon
no it isnt lmao
it's someone else's
I accidentally closed it so I reopened it myself
limber skiff
are u not handling it now?
austere talon
no
limber skiff
ahh okay
austere talon
i just reopened it because I deleted his commits
gritty iris
I was so close
charred monolithBOT
charred monolithBOT
prime dew
and iirc it's likely a prequel to the first game
Afair it's the opposite, Silksong is the sequel
You can start from Silksong but the first one is such a gem that it'd be a pity to miss out on it
I'm done with the off topic
fossil inlet
thanks for categorising prs into the projects sadan
do you want the action to move them to in review when they're reviewed?
austere talon
yeahh
if someone (relevant) reviews, move to In Review
if all reviews are resolved, move from In Review to Needs ReReview (new column)
if the pr is in no project, maybe it could just leave a comment saying to add it to a project manually
fossil inlet
it's pretty basic rn
austere talon
does it even need a token
fossil inlet
yes
the token needs to be classic
and i needed to add these permissions to get it to work on my test repo
fossil inlet
i tried that lol
if you can get it to work lmk
fine grained tokens don't work for projects
tbh i'd just make an alt and use the token for that account
austere talon
i guess because the prooject is not actually part of the repo
odd heath
insane
pr i forgot about got a review
oh and the patch is broken
lovely
gonna fix in a bit and fix the blockedcontext pr after 
austere talon
is it stable compatible
make reporter work for prs @fossil inlet
actually shouldnt be that hard
but hard part is only testing the things in the pr
seems to be stable compatible
the find anyway
fossil inlet
is it stable compatible
second one isnt, experiments should be
austere talon
add a comment
// TODO: remove .button once it's gone on stable
(we will remove in half a year)
gritty iris
bing 😭
austere talon
would be nice if they actually told you what the treatments are
you will forward datamining repo comment instead
glass jasper
you will forward datamining repo comment instead
?
gritty iris
fossil inlet
would be nice if they actually told you what the treatments are
You can just look in experiments tab???
charred monolithBOT
austere talon
You can just look in experiments tab???
effort
now that vencord toolbox is more out of the way, should we make it enabled by default?
so it's more useful and we can actually put stuff there
uneven needle
github loves not sending notifications
there was the other pr that handled plugins / managed style too so should i even work on this
austere talon
there was the other pr that handled plugins / managed style too so should i even...
which
uneven needle
3153
gritty iris
canUseCustomNotificationSounds looks like it was removed and for onepingperdm soundpack:\i, was removed
dusk blaze
vtest
gritty iris
onepingperdm's sound match is fine alone because its the only one using \i ? \i : void 0 but I figured anchoring it with onclick still would be better
gritty iris
this entire chunk is gone now for fakenitro yes I know it match smth else but I was checking this for usage
canary
where c is used on stable
module id: 974180
fossil inlet
Are they removing custom notification sounds
Probably because the find mentioning soundpacks failed as well
charred monolithBOT
gritty iris
this is literally the only one using ? : 😭
austere talon
we can use pull request template + project workflows to automatically organise prs
odd heath
i hate discord 
i have to find an entirely new place to put the patch into cuz otherwise there's just gonna be fucking gaps in the chat
and this is the second pr i have to do this with 
austere talon
i love when i have to work with a pr on a branch called dev and fuck up my local clone cause now it's tracking the wrong fucking dev 😭
why did they add themselves at the very top in the dev object bruh
insane
i didnt even notice
elder plinth
why is the icon for total members a border-radius css trick and not an svg 💔
I just noticed sometimes it becomes slightly elongated 💔
odd heath
i really need to start using sadans companion
austere talon
I just noticed sometimes it becomes slightly elongated 💔
how
austere talon
why is the icon for total members a border-radius css trick and not an svg 💔
why does it matter
elder plinth
im assuming subpixel width from the number shifting
odd heath
i have to find an entirely new place to put the patch into cuz otherwise there's...
theres still a gap
fuck you discord
elder plinth
why does it matter
cause it can cause elongated icon as I said above
austere talon
I just noticed sometimes it becomes slightly elongated 💔
i never expeirneced this
austere talon
change it to a svg if you really care
austere talon
60 whole seconds
noty
odd heath
<:wires:1262562427422244874> theres still a gap
amazing way to hide a reply icl
elder plinth
i never expeirneced this
elder plinth
yeah but the green blob doesnt have text to its left shifting in width
the online icon has the green text shifting next to it
bright island
oh dear lord that's horrid
austere talon
wtf is this experiment #🏥-vencord-support-🏥 message
odd heath
i dont think its possible to cleanly hide replies to blocked messages anymore
@austere talon do u wanna take a look at it or should i just close the pr
odd heath
i may also just be heavily incompetent
austere talon
why wouldnt it be possible
odd heath
amazing way to hide a reply icl
this
no matter how i try to take the message out it ends up with a gap where it was
and idk what to try next
austere talon
it's hard to hide messages properly
odd heath
ya im noticing
thats why im asking if u wanna take a look at it
cuz i cant figure it out
but also im retarded so 
austere talon
why do we need a new patch
odd heath
why do we need a new patch
to hide replies that already exist in the chat history?
tjey dont go through the old patch
austere talon
oh the other message patches the blocked thing
odd heath
unless the old patch just was fucked all along idek anymore
austere talon
so cursed
odd heath
yeaa
but im confused now on why the messagestore patch doesnt wor-nvm yea it obv doesnt work cuz its a separate setting
austere talon
we could just patch getMessages and remove them from the array maybe
idk if that would have a negative effect on anything else
elder plinth
what are you tryna do
odd heath
what are you tryna do
hiding replies to blocked messages
elder plinth
oh is the equicord version upgraded. myb
elder plinth
still has a small gap where the message would be but works
odd heath
that one looks good
should i just steal
odd heath
still has a small gap where the message would be but works
show
elder plinth
i feel like you surely could interfere earlier in the call chain to stop it from appearing at all
odd heath
i feel like you surely could interfere earlier in the call chain to stop it from...
i tried to filter as early as chat history being rendered and failed
elder plinth
?
odd heath
the gap is identical to the gap with my attempts
elder plinth
wdym profile though
austere talon
does equicord just accept every single plugin
I never even heard of this shit in my life https://github.com/Equicord/Equicord/blob/main/src/equicordplugins/absRPC/index.tsx#L87
grave mangoBOT
I never even heard of this shit in my life https://github.com/Equicord/Equicord/...
index.tsx: Line 87
name: "AudioBookShelfRichPresence",
if it works it probably gets accepted. but thororen has been working on merging a bunch of smaller plugins recently
dusk blaze
does equicord just accept every single plugin
yea
bright island
gonna make the GiveMeYourCreditCardInformation plugin
dusk blaze
Bro just mad they won’t add his token logger
how is it mad to say a fact
glass jasper
dusk blaze
equicord accepts everything
glass jasper
equicord accepts everything
Cope lil bro
dusk blaze
glass jasper
Idc
charred monolithBOT
odd heath
LOVE
austere talon
Bro just mad they won’t add his token logger
keep annoying drama out of here no one cares
elder plinth
@odd heath think I got a working patch
odd heath
@austere talon what do you think of this? works fine (i don't notice any delay introduced by this, i think it should be fine since the messages are batched in arrays of 50 anyway)
only downside is you might have to reload after unblocking a user for obvious reasons
elder plinth
{
find: "compact:!0,messageGroups",
replacement: [
{
match: /(messageDisplayCompact:\i,)channelStream:(\i),(uploads:\i)/,
replace: "$1blockedChannelStreamOverwrite:$2=$self.filterChannelStream(arguments[0].channelStream),$3"
}
],
},
],
filterChannelStream(channelStream: any[]) {
return channelStream.filter(items => {
if (items.type === "MESSAGE_GROUP_BLOCKED") {
return false;
} else if (items.type === "MESSAGE") {
return !this.isReplyToBlocked(items.content);
} else {
return true;
}
});
},
odd heath
huh
elder plinth
channelstream is on a parent of the message list
odd heath
im fairly certain i tried to patch the same place earlier and it didnt work
elder plinth
it contains groups
odd heath
channelstream is on a parent of the message list
yea ive tried to patch that but maybe ive patched it too late
elder plinth
yeah idk. did you patch it in the destructure line? or after?
odd heath
i patched before it maps the messages
elder plinth
I originally was trying to patch arguments[0].messages._array but that doesnt work on first load
only on second+ load
but channel stream seems to work every time
even if you dont also patch arguments[0].messages._array
odd heath
hmm
let v decide what to use
oh yea i think you patch one or two functions before i patched the channel stream
thats prolly why its different
elder plinth
wdym
for what it's worth if I unblock and reblock with my method it instantly returns and hides the messages
no reload necessary
odd heath
yeaa then imma do that
elder plinth
cause discord already reloads the messages since they're sent in MESSAGE_GROUP_BLOCKED groups
so im just piggybacking off of that by filtering that array
odd heath
wdym
you patched the module that calls the module i patched when trying earlier
i have up on trying to patch that cuz it seemed to me as thatd make no difference but apparently it does 
ty
elder plinth
lol
it looks like this might also make the other patch(es) not needed?
well not my current impl but you could add another if statement to that list to check if the message itself is blocked
no need for multiple patches in that case
oh im already doing that with returning false on MESSAGE_GROUP_BLOCKED I think
odd heath
it looks like this might also make the other patch(es) not needed?
the other one is less intrusive though
i think less intrusive and two patches > one more intrusive patch
elder plinth
what does the other one do
odd heath
one patches messagestore so that completely prevents the message from being dispatched to the client and the other one just looks for the collapsed message and hides it
im not sure if this method prevents it from being dispatched
if it does then yea the other patch is essentially useless
elder plinth
well no im assuming this is after it's been dispatched
elder plinth
lol
odd heath
i just assumed at that point itd have the same result
odd heath
well no im assuming this is after it's been dispatched
same
elder plinth
dont see how that's bad though
odd heath
its not
i just dont think we need to remove a simpler mechanism if we can replace it with a more complicated one
thats all
elder plinth
hm yeah tested it. other 2 patches redundant now but if keeping them is better then 
wait whats even the point of the ignoreMessages setting
how is it any more ignored with or without that patch 🤔
odd heath
wait whats even the point of the ignoreMessages setting
one patches messagestore so that completely prevents the message from being dispatched to the client
elder plinth
but I can still use MessageStore.getMessage on the message
so...?
even after reloading. do I need to do a full restart
elder plinth
yeah the client is definitely still caching the message
so that setting isn't really doing anything
odd heath
nothign wrong with that though as long its just cached and not processed furhter ig
odd heath
so that setting isn't really doing anything
it definitely has some sort of side effect that it does
itd be weird if it wouldnt
elder plinth
looks like it blocks new message notifications
elder plinth
could be worth changing the name then to be more clear but also
odd heath
dunno thats out of scope for my pr 
elder plinth
tbh that should be default behavior
the whole point of the plugin is to hide messages
why would you want a notification for a message you cant see
odd heath
@elder plinth i found why my solution always had gaps
i never included a check for the message_group_blocked
😭
elder plinth
oh is that it lol
odd heath
ya
cuz you can make the patch waaaaaay simpler
i wonder if itll work if i go to my original patch again cuz that was even shorter
lemme check
elder plinth
that only works if you update isreplytoblocked to handle the channelstream format though
thats just more dependencies for a single function to handle
if u werent aware channelstream children arent messages. the messages are .content or .content[index].content for blocked message groups
elder plinth
wait have you tested that patch above
no way it works
it'll say cannot access g before it is initialized
thats the whole point of the blockedChannelStreamOverwrite:$2=$self.filterChannelStream(arguments[0].channelStream) syntax
odd heath
the patch works but my even simpler patch from inside B.Z works too
odd heath
it'll say cannot access g before it is initialized
nop
odd heath
mine patches the args passed to B
and inside of B i just filter before it maps the channel stream to messages
odd heath
and inside of B i just filter before it maps the channel stream to messages
since that entire module only uses .map once the patch is pretty short too
I feel like this filtering of the channelstream might be introducing lag though
elder plinth
you actually experiencing it or just vibes
odd heath
just vibes apparently
for whatever reason discord takes its sweet time to switch channels rn but its not related to the patch
elder plinth
technically possible that messages._array needs to be patched too but I dont see the consequence of not doing that atm
austere talon
for better error handling and avoiding minor bugs, avoid putting code inside patches
austere talon
I feel like this filtering of the channelstream might be introducing lag though ...
pure Javascript is incredibly fast
don't worry about it
odd heath
for better error handling and avoiding minor bugs, avoid putting code inside pat...
very fair
austere talon
the array filter is almost never gonna be your bottleneck
odd heath
don't worry about it
i was only worried cuz there was a 3-5 second lag in between switching channels 😭
austere talon
the array filter is almost never gonna be your bottleneck
what can be slow is the rendering aspects and if you misuse react
elder plinth
commit farming
odd heath
commit farming
How what
elder plinth
real
gritty iris
I never even heard of this shit in my life https://github.com/Equicord/Equicord/...
fuck I don't even know whats added anymore
I get yelled at everytime I try to remove shit 😭
so I just fix patches
also we do not add every plugin I swore against that just seems like we do because everyone wants everything lol
austere talon
:P
scenic brook
hey that's me
gritty iris
ima just make indi do the hard work 🔥 (make a list of plugins no one uses and remove them)
that project started only because I wanted mlenhanced and is only alive because I use it for a few extra plugins lol
gritty iris
If I had merged ml enhanced you never would have made it?
equicord would've never existed 
ong merge it and all Ill shut down
this is a joke I use equicord to test my plugins as well lmfao
see if people would use em or not
charred monolithBOT
brazen bone
People are sooo good at ignoring the big loud "you're not a dev" sign
fossil inlet
nookies review soon 🙏
charred monolithBOT
fossil inlet
@austere talon what category would a pr like this fall into?
https://github.com/Vendicated/Vencord/pull/3627
austere talon
I was really confused why it changed like 15 plugins
maybe skip the error boundary if it's just a string
fossil inlet
scenic brook
The "this user is wanted by the fbi" troll plugin
odd heath
should I commit a regex warcrime or should i just delete it silently and act like it never happened cuz it wouldnt ever be merged anyway
charred monolithBOT
scenic brook
Share your email address and we'll bump you manually
gritty iris
Share your email address and we'll bump you manually
nookies-the20thtimefor@email.spam
trust 
charred monolithBOT
scenic brook
nookies-the20thtimefor@email.spam
You fool 
gritty iris
You fool <:suffoPeepoMischief:1002737828989501542>
whoops wrong one
I meant nookies-foremailspam@email.spam
my fault
wonder if spamming someone without an email server on their domain kills the servers 😭
scenic brook
If they don't have the MX record set up it won't get routed to the domain will it?
brazen bone
Is there any plugin (official or user) that lets you change the volume of discord's notification blip? Because that thing is so loud
scenic brook
charred monolithBOT
gritty iris
old was s = l +a its now u = l.fractionalState === Z.a$.NONE ? a + s : 0 might make it match the .NONE to be safe not sure I did
limber skiff
you can probably just remove the = from the original patch
using the capturing groups should already make it specific enough to just have the a + b
charred monolithBOT
fossil inlet
HOW DID THAT HAPPEN LMAO
it's been like that for a while
i was just going through some of discord's comments in their css
and found that
austere talon
For the new tweaks feature i was planning:
Basically each small plugin that adds an objective improvement, and each plugin that changes some specific discord behaviour would be converted to a tweak
these tweaks would further be separated into enabled by default and disabled by default
Some examples of current plugins that would become tweaks:
- CopyEmojiMarkdown - enabled by default
- BetterRoleContext - enabled by default
CtrlEnterSend - disabled by default- NoProfileThemes - disabled by default
actually not ctrlentersend because it has settings
fossil inlet
will there be a new tab for it or will it be an addition to the plugins tab
austere talon
it would be a new tab
austere talon
For the new tweaks feature i was planning:
Basically each small plugin that add...
the motivation is to reduce the amount of plugins and also be able to add many more minor tweaks in the future
there are a lot of pretty niche small improvements that are kinda too niche to become plugins but we could just add it as a tweak
fixing discord bugs too
fossil inlet
how will they be globbed
will they be something like
definePlugin({ tweak: true})
or their own dir
austere talon
probably their own dir with one tweak per file
dusk blaze
vencord will add conflicts
fossil inlet
whar
fossil inlet
like AddExtraNitroAds and NoNitroAds
things like that would probably be better suited as a BetterNitroAds plugin
austere talon
probably their own dir with one tweak per file
defineTweak({
name: "No Onboarding Delay",
description: "Skips the very slow onboarding animation",
enabledByDefault: true,
patches: [...]
})
then it would probably just be a list of switches
elder plinth
isnt that just a plugin reskinned. how does this really fix the too many plugins issue
fossil inlet
isnt that just a plugin reskinned. how does this really fix the too many plugins...
each one has a smaller scope + seperate UI for them
austere talon
^
and also anything that most people would appreciate will be enabled by default
with a master toggle to disable all tweaks
fossil inlet
the average tweak will probably just be a patch or two
austere talon
```js
defineTweak({
name: "No Onboarding Delay",
description: "Skips the...
this plugin is a very good example of what would become a tweak
its a super minor change that really has no reason to be a plugin
elder plinth
that's still the scope of the plugins that you would be converting to tweaks. nothing changes except a new ui for them. which I guess helps a bit
I guess you could think of them as plugins without settings
dusk blaze
objectively good unconfigurable improvements
fossil inlet
scenic brook
I guess you could think of them as plugins without settings
It's probably good on the dev side since defineTweak can have less shit available to use
dusk blaze
you will d1e
fossil inlet
<@521819891141967883> i hope your dotfiles vanish someday
husk
dusk blaze
defineBalls()
fossil inlet
nin0 going insane
austere talon
I mainly think that having everything disabled by default is mediocre user experience the more features you add because it's not realistic for users to go through 200 plugins and understand what they do
it would be more user friendly if users get objective improvements for free while simultaneously reducing the amount of plugins they have to go through
having everything as plugin is kinda limiting because I always have to wager if something is worth adding a new plugin for
austere talon
having everything as plugin is kinda limiting because I always have to wager if ...
I rejected this plugin because it's too niche but I wouldn't mind adding it as a single switch (tweak) https://github.com/Vendicated/Vencord/pull/3200
(disabled by default obviously)
gritty iris
having everything as plugin is kinda limiting because I always have to wager if ...
I think tweaks should have a setting dial realisitically
some tweaks would be plugins just for settings but also wouldn't be considered enough of a branch to be a plugin but more of a tweak
austere talon
that kinda defeats the point
gritty iris
I see what you're saying now I read the explanation wrong
time to move the always* plugins to tweaks
quite a bit of plugins could become tweaks just from the looks of it
so I do believe tweaks would be a nice addition to not having such a doom and gloom scroll to the bottom of plugins
austere talon
how do users even find the right plugins in equicord 😭
gritty iris
I have no fucking clue
austere talon
having to scroll through like 400 plugins
gritty iris
I dont enable plugins anymore
I wanted to paginate it but they were all agaisnt it
austere talon
those stats on the top are kinda cool but they kinda look ugly ngl
gritty iris
they made it doom scroll but thats terrible as well
they were better I think
but I never fixed the classes and indis pc broke
I like the enabled plugins | total plugins
austere talon
I was pondering the idea of adding very basic plugin telemetry that shares with the server which plugins you have enabled, so we can have sort by popularity
will also help with finding plugins for users but I'm worried it will end up biased because users will only look at the most popular ones so new plugins won't get a chance
gritty iris
I do like the "telemetry" idea but I also think people would go bonkers
bright island
i personally just went through every single plugin, do you think it might be a good idea to make the plugin tab have a way of having a kind of "discover the plugins" kinda thing?
plugin guide or something
glass jasper
I wanted to paginate it but they were all agaisnt it
Only Moh and Creations was iirc
gritty iris
tweak: Hide nin0.dev messages
defineTweak({
name: "Hide nin0.dev's messages",
description: ":trolley:",
enabledByDefault: true,
patches: [
{
find: ".messageListItem",
replacement: {
match: /renderContentOnly:\i}=\i;/,
replace: '$&if(arguments[0].message.author.id === "886685857560539176") return null;'
}
}
]
});
one of the other things I like that we have is this
austere talon
I do like the "telemetry" idea but I also think people would go bonkers
it would collect as little as possible 
scenic brook
those stats on the top are kinda cool but they kinda look ugly ngl
I feel like the stats encourage the whole "add as many plugins as possible" mentality lol
austere talon
can just turn it off no reason to complain
nimble pendantBOT
vp activities
austere talon
guh
fossil inlet
I was pondering the idea of adding very basic plugin telemetry that shares with ...
i'm fine with the idea as long as no data is associated to users
fossil inlet
I plan to add buttons to these embeds:
isn't there a pr for it
austere talon
yes
gritty iris
I would've used our bot (venbot's code) but I didnt wanna deal with it lmfao
austere talon
it's been on hiatus because I plan to remake the command with componentsv2 etc
fossil inlet
i'm fine with the idea as long as no data is associated to users
but i think users would go insane
austere talon
I doubt most people would care
BD has the same telemetry
with bd it's not telemetry cause you have to press download on their site
gritty iris
I think having a disable option is key
austere talon
but for vencord since it's all in your client we don't have that data 
austere talon
I think having a disable option is key
I mean that is legally required anyway lmao
bright island
i would say just don't set out an announcement about it and have an easy way to opt-out in order to calm people who love setting things ablaze
fossil inlet
with bd it's not telemetry cause you have to press download on their site
that's a very different thing lol
dusk blaze
austere talon
that's a very different thing lol
it's the same thing just in a different way 😭
it's still telemetry in the exact same way
fossil inlet
not even close imo
gritty iris
if you do telemetry and we add it ill forward it to your server if you want (you prob don't)
dusk blaze
3 users are using GoodPerson
gritty iris
telemetry I would use would probably be just to see how many people use a certain plugin
and whats not used to delete it
dusk blaze
@austere talon userplugin telemetry and venbot updates a sticky in the plugin thread
fossil inlet
i'm fine with the idea as long as no data is associated to users
also it should ignore userplugins
austere talon
ofc it's not directly comparable but it ends up in exactly the same data about you being collected
austere talon
also it should ignore userplugins
ofc it will
what would we even do with that data
gritty iris
telemetry dead on dev 🔥
but if you want I can pass our telemetry of vencord's related stuff to yours if you want (if I can figure it out)
prob adds another 2-3k
fossil inlet
but if you want I can pass our telemetry of vencord's related stuff to yours if ...
does equicord have telemetry?
gritty iris
nop
I mean when this all happens if it does
ill probably set it up as well for plugin count to see whats not used
if the telemetry is open sourced
I 100% could switch back to vencord without issue rn 🔥 (ignoring asar)
austere talon
if the telemetry is open sourced <:prayingcar:1236730480351514645>
naturally
gritty iris
I was so happy when I saw venbots source
I wanted that discord reporter log 😭
I just always think you all are mad at me
austere talon
why
gritty iris
fossil inlet
I wanted that discord reporter log 😭
it's so easy to make
austere talon
I wanted that discord reporter log 😭
it's mostly just github workflow
gritty iris
just seems like the default response to me
austere talon
did you get it working in your bot
gritty iris
mhm
fossil inlet
i had a version before venbot
austere talon
I was so happy when I saw venbots source
everything I make is open source
everything vencord uses is too
gritty iris
I do when I clean up the code
if its not clean its private
all equicords stuff is pub tmk
fossil inlet
i think the only things that i have private are the things that would dox me
gritty iris
the one thing I also get scared of is I dont wanna violate the license because im dumb
I've done so much research to make sure I don't 😭
austere talon
is equicord the one where I opened an issue complaining about license violation
or was it something else
fossil inlet
is equicord the one where I opened an issue complaining about license violation
pretty sure that was something else
gritty iris
I just dont want that to be us
you did an issue comment on one of my commits with badges btw thank you for that
glass jasper
you did an issue comment on one of my commits with badges btw thank you for that
-# Me and Inbest made that new goated version
glass jasper
I remember thats what made us just revamp the whole plugin
austere talon
I meant when I was blowing up vens server
it wasn't actually that bad
dusk blaze
as insane as equicord plugin selection is it’s the sanest fork ykyk
gritty iris
I remember thats what made us just revamp the whole plugin
wrong idea
Im talking about fetching the donor badges
gritty iris
it wasn't actually that bad
still sorry
austere talon
vencord badge api literally serves terabytes of data each month
glass jasper
Im talking about fetching the donor badges
vro im giving lore
fossil inlet
gritty iris
sometimes create stuff thats all
austere talon
vencord badge api literally serves terabytes of data each month
vast majority is cached by cloudflare
glass jasper
equicords lore is just
Horror
austere talon
do you codereview prs and ask people to make changes etc or do you just merge if its alright
gritty iris
I review all the prs
I ask for changes or make them myself if its good enough as is ill merge and fuck with it then or later
I would never not review the prs at least 😭
im not insane
austere talon
how much time do you spend
vencord gets way too many prs I can't keep up
but I'm also perfectionist
austere talon
yeah
dusk blaze
vencord gets way too many prs I can't keep up
but I'm also perfectionist
make other people review
gritty iris
depends on what I'm reviewing
austere talon
make other people review
we've been through this dozens of times
gritty iris
it can be a couple of minutes to days
I normally review the prs as soon as I see them
normal takes like an hour or so without fixes
austere talon
review every vencord pr thsnks
austere talon
gritty iris
both mine are good trust
austere talon
😭
gritty iris
statuswhileplaying is weird
alwaysexpandprofiles is good tho
the patch ehhh
I realized I wasnt matching clydes type of popout
so it was ignored
fossil inlet
who cares about clyde 😭
fossil inlet
ah
gritty iris
but bot was changed an had a very bad find
so I matched all 3 with view profile
and just did that
rather than having a terrible find and 1 missing
https://github.com/Vendicated/Vencord/pull/3618/files
also vee please don't do me like this
austere talon
why
gritty iris
bouta make me go replace all of this on mine 😭
austere talon
it's will just be find and replace (or get ai to do it)
dusk blaze
vee is a vibe coder
gritty iris
most should be fine I agree then theres the random selection of 25 plugins
most prs could be closed imo
either already added already has a pr or just niche
austere talon
originally I only wanted to replace the components for the settings ui so it stops breaking
but then I realised it's way more powerful and nicer to use than the form components
gritty iris
I agree with that using our own would be way better
https://github.com/Vendicated/Vencord/pull/3630
this should definitely show mute as well
just to give a heads up on what the users (un) mute/deafen status is
fossil inlet
https://github.com/Vendicated/Vencord/pull/3630
this should definitely show mut...
yop
glass jasper
https://github.com/Vendicated/Vencord/pull/3630
this should definitely show mut...
NSFW voice channels also need an icon added like private voice channels are
gritty iris
should turn red
gritty iris
NSFW voice channels also need an icon added like private voice channels are
🔞 emoji trust
fossil inlet
NSFW voice channels also need an icon added like private voice channels are
does discord not have a function/component for the correct voice channel icon
eg: stage/private/nsfw
gritty iris
Im 100% compiling a list of plugins that are niche or dont really seem like vencords plugin style
fossil inlet
Im 100% compiling a list of plugins that are niche or dont really seem like venc...
in vencord prs or equicords
glass jasper
does discord not have a function/component for the correct voice channel icon
e...
I just know it shows when a Vc is locked/ private but not when It’s a stage or nsfw vc
fossil inlet
auto mute his videos
🙁
fossil inlet
gritty iris
@austere talon here is my list
in no specific order or anything
I also didnt look hard or at code really
just put mantis pr out of its misery 😭
hollow musk
bouta make me go replace all of this on mine 😭
repgrep is amazing for mass replacements, i had to do a couple of such mass renaming, and it handled it really nicely
scooter also works
kindred tree
<@343383572805058560> here is my list
from my experience it's the best performing translation tool out there atm, although most features are paid. It uses an LLM which lets it pick up on context or language quirks better than most translators can
https://help.kagi.com/kagi/company/
https://help.kagi.com/kagi/ai/translate.html
https://help.kagi.com/kagi/why-kagi/ai-philosophy.html
re:
charred monolithBOT
unkempt oak
<@343383572805058560> here is my list
startpage is a pretty nice search engine
gritty iris
the ones I counted as niche are the ones I dont see people use much at all whether its the same plugin or close some are excluded
north knoll
<@343383572805058560> here is my list
#1806: definitely not niche, there has been resounding support to get this merged over the past 2 years both in the PR and in this discord
gritty iris
[#1806](https://github.com/Vendicated/Vencord/pull/1806): definitely not niche, ...
prob looked at it wrong
I thought it was just os
austere talon
cant even update branch
gritty iris
WHAT
I didnt touch anything
hold on
it doesnt even exist
tf
am I loosing it?
I merged dev
I have no clue why the button is missing
austere talon
it should be somewhere in sidebar
gritty iris
the sidebar in question
elder plinth
is it cause it's from a branch in your equicord repo which has non-default security settings?
gritty iris
austere talon
and tbh I would probably pr from somewhere else than equicord
north knoll
you cant enable maintainer edits on PR if the originating branch belongs to an org
gritty iris
you cant enable maintainer edits on PR if the originating branch belongs to an o...
you're kidding
😭
north knoll
org accounts enforce their own permission policies
elder plinth
this is why vencord isnt in an org 
austere talon
elder plinth
elder plinth
good job ren
austere talon
ren feels wrong
gritty iris
I started helping out because I fixed my git again
austere talon
i need to implement reporter for prs guhh
austere talon
would be better
gritty iris
alr
austere talon
although if they have existing feedback / convo make sure to mention the old pr
austere talon
is there actually a use case for anything but DND?
gritty iris
is there actually a use case for anything but DND?
Not really
Figured if I'm doing it make it customizable
austere talon
cause "Auto DND when launching a game" could just be a tweak
gritty iris
My guess was if someone wanted DND or invis
austere talon
i just have this on vesktop
if discord is unfocused for more than 1 minute it puts me to idle
similar to the mobile app
gritty iris
That is fair I was planning on making them both tweaks which would kill settings
austere talon
(well tweaks arent set in stone yet)
gritty iris
One day
charred monolithBOT
gritty iris
Anyways you think I should keep the setting or just drop it?
english or french no more apparently
austere talon
@elder plinth are you still gonna remake MemberCount with svgs?
odd heath
i need to implement reporter for prs guhh
do
elder plinth
<@94597845868355584> are you still gonna remake MemberCount with svgs?
it was not my plan to no
austere talon
i thought u were gonna
elder plinth
I dont look at that corner of the screen often enough to be arsed
austere talon
i might do it then
elder plinth
it's currently css. which causes issues occasionally do to subpixel rendering
so replace them with svgs
🟢
got one done for you
no gray circle emoji but surely you can just change the color of that
gritty iris
function L(e) {
return (0,
r.jsx)("mask", {
id: e,
maskContentUnits: "objectBoundingBox",
viewBox: "0 0 1 1",
children: (0,
r.jsx)("circle", {
fill: "white",
cx: .5,
cy: .5,
r: .5
})
})
}
discord:
elder plinth
there you go
elder plinth
also lowkey I feel like the new voice users icon and number should be blue not gray but thats just me
elder plinth
arent those literally just circles
gritty iris
no clue
elder plinth
nothing else to then
gritty iris
didnt test em yet
austere talon
don't hardcode colours
austere talon
what's the point of the mask on the online?
elder plinth
turning it into a circle from a square?
austere talon
both masks seem useless
gritty iris
what's the point of the mask on the online?
I didnt have it like that originally
online was just a circle
but offline idk how to do with out a mask
austere talon
you want fill=none and then set stroke
elder plinth
didnt you say that code is what discord uses
gritty iris
it literally is a direct rip basically
that isnt right?
its using --status--offline
elder plinth
oh I might have the im not colorblind plugin enabled
austere talon
yes you do
elder plinth
mm yeah
scenic brook
Why does it use offline for total member count anyway, it doesn't subtract the online members from the figure
elder plinth
true
austere talon
gritty iris
oh god
austere talon
discord does it too
austere talon
stroke width exists
elder plinth
yeah keep it colorblind friendly
gritty iris
what width we thinkin?
elder plinth
whataver makes it look like the real one
tbh you should just use discord's impl idk why ven is having u make it custom
austere talon
discord does it too
just realised it isn't even aligned 💀
the circles are top aligned
elder plinth
a lot of stuff in discord isnt aligned
gritty iris
I made the icons slightly bigger
there 18px now
I take that back the only 18px is green
for whatever reason 18px and its a good size for everything the rest are 15px
charred monolithBOT
austere talon
I think it looks better if it's slightly smaller
try to keep it the same as before
gritty iris
Alr
elder plinth
center align plz
gritty iris
old first new second
elder plinth
bruh that comma ruins everything 😭
maybe hit the icons with a 1 or 2px margin-bottom or smthn idk
gritty iris
maybe hit the icons with a 1 or 2px margin-bottom or smthn idk
you mean top?
austere talon
the comma annoys me anyway cause...
elder plinth
you mean top?
top margin would just push them down further
you want to push the icons up
gritty iris
oh you want the mic margin?
austere talon
any country that uses period is wrong
fuck u
elder plinth
to account for the comma
gritty iris
im lost
elder plinth
<3
austere talon
where are you from morphy
elder plinth
ren plz
gritty iris
elder plinth
https://tenor.com/view/america-hurricane-happy4th-of-july-america-flag-independence-day-gif-21259025
austere talon
you seem like you're from eastern euripe
maybe romania
you dont seem like an american
elder plinth
??
gritty iris
hes american
elder plinth
ya know what
gritty iris
I could never forget it 😭
elder plinth
in today's climate thats a compliment
bright island
that's true
austere talon
u dont wanna be from romania
elder plinth
im lost
the comma causes the "center" to be lower than it should so the icons are lower than they should be. so to counter act that you add bottom margin
austere talon
just set line height bruh
elder plinth
well idk if being called romanian is a compliment or not but being called not an american is
austere talon
line-height: 1.2em;