#๐พ-core-development
limber skiff
I was able to generate this with custom-background-theme
but settings look so bright for some reason
feels like this wont work 
yeah no this doesnt achieves good results
limber skiff
ugh
I have no idea how to fix client theme lol
they changed completely how the colors for each thing are calculated
same main background, but everything else changed
limber skiff
it does work, it's just different now
austere talon
or maybe cassie wants to do it afterall :P
limber skiff
before it was this "primary"
now it's "neutral"
which by itself is already different than primary
austere talon
it does work, it's just different now
yeah but it sucks ass
limber skiff
before and now
you can see the main background is still the same primary color
but the rest is all cooked
limber skiff
i used to use the plugin but now i stopped using it
same
what color did you use to have?
austere talon
the preset green
austere talon
looks so bad
austere talon
gradient 
limber skiff
looks so bad
I mean you also have the midnight on
austere talon
looks so bad
it even changes text colour
limber skiff
was it this one
austere talon
I mean you also have the midnight on
yeah but this is still awful
it looks very different
limber skiff
do you have a screenshot of before lol
gritty canyon
gradient <:puke:338265885414391818>
not if you just dont supply a gradient :^)
austere talon
im looking rn
limber skiff
not if you just dont supply a gradient :^)
I just tried that
gritty canyon
you can look into that if you want to, of course doesnt change the text color though
limber skiff
but it doesnt work well with dark themes
gritty canyon
wdym
austere talon
(also combined with nitro theme)
this is new with nitro theme
it changes text colours for example
it shouldnt imo
fossil inlet
guhhh is that another version of the freeze bug i found a bit ago
limber skiff
guhhh is that another version of the freeze bug i found a bit ago
no idea why that could be happening
limber skiff
they cooked this app sohard
fossil inlet
no idea why that could be happening
i'll look into it later (today/tomorrow hopefully), i have a bit of an idea
limber skiff
hmm
I have an idea
to get old behavior we would need to have neutral the same as primary
im asking gpt ๐ฅ
austere talon
are u still working on it or did you give up
limber skiff
still working
I interporlated the neutral colors the way the old primary colors were
which goes from ~+12 to ~-30
but it looks shit
lol
limber skiff
@austere talon there's no easy way to get back the exact old behavior
we can do our best to try to get it close, but exact would require manually changing so many vars
they changed the way they use to calculate the colors and how they use them
opaque silo
Why aren't you guys just generating these and telling the client its in the custom theme mode
limber skiff
already am
opaque silo
already am
oh so whats the issue?
limber skiff
it's different
opaque silo
wdym
limber skiff
the colors are different
opaque silo
im confused ๐ญ
limber skiff
then ignore it
opaque silo
dusk blaze
cookie science
fossil inlet
guhhhh vscode css api so bad
i have to provide my own language server to add css completions
dusk blaze
jolly egret
thought so
jolly egret
scenic brook
clear jasper
didn't work for me using buildWeb 
fossil inlet
didn't work for me using buildWeb <:shrug:1037110715024150568>
both build and buildWeb import IS_DEV from common
charred monolithBOT
fossil inlet
yeah
wasn't you
discord changed something i think
(i love my n key being broken 
)
charred monolithBOT
austere talon
what this straight up seems broken
they never change t or e so how is the condition ever supposed to change?
fossil inlet
they never change t or e so how is the condition ever supposed to change?
they mutate r at the bottom
austere talon
yes but
they never change t or e
so they always assign the same value to r
it never changes
fossil inlet
wait yeah
weird
the only thing i can think of is that getNode has some side effect
but that would be really cursed
fossil inlet
yeah, but it works fine without better folders
austere talon
maybe cause t or t.parentId is null without betterfolders
idk i think it's a clear sign that the betterfolders experiment failed
let's remove it
Also I tried earlier and it worked fine for me... is it some setting?
fossil inlet
I managed to "fix" it, but it should be done in a better way
fossil inlet
taking a closer look into this
why is it even a for loop
it's just getting the parent folder ref
and you can't nest them
charred monolithBOT
fossil inlet
i'm pretty sure the loop where this patches can only run once, or forever
limber skiff
that's hacky
austere talon
okay but Discord's code is literally shitcode
limber skiff
the actual issue is still present
austere talon
look at this ๐ญ
limber skiff
okay but Discord's code is literally shitcode
yeah but the issue only happens because of what we do
austere talon
okay so the issue is
limber skiff
the other time we had something like that was because of a missing memo in the new tree calculation, which ended up building a new tree everytime and triggering an effect
austere talon
this is null with BetterFolders
which is why it enters the broken loop
for Discord that is not null
limber skiff
that was the same function that caused the issue last time ๐ญ
it was called by an effect iirc
austere talon
it calls that function when you click on a guild in a folder
limber skiff
oh nvm I remember now
austere talon
the way it happens with betterfolders is when you quickswitch to a guild in a closed folder
limber skiff
the one I'm talking was an issue where the scroll would reset
๐
kinda related but hmmm
limber skiff
this is null with BetterFolders
okay so
need to see why that is null
it could simply be I'm nuking a component that shouldn't be nuked
and that causes it to be null
austere talon
let r = this.nodeRefs[e];
for (; null == r; ) {
let t = this.guildsTree.getNode(e);
if ((null == t ? void 0 : t.parentId) == null)
break;
r = this.nodeRefs[t.parentId]
}
When the folder of the guild you're navigating to is open, this.nodeRefs[e] is not null and it doesn't enter the loop
When the folder is closed, this.nodeRefs[e] is null but then it pulls this.nodeRefs[t.parentId] which is not null so it terminates the loop after one iteration
With BetterFolders both are null when the folder is closed and because Discord's code is straight up broken it leads to an infinite loop
like why they fuck do they use a for loop here lmfao
the for loop always does the same thing
if it fails the first time, it will fail infinitely
Discord's code is broken, but because the state it is broken for will never happen for Discord, it actually isn't
but we put it in that broken state
limber skiff
the state also shouldn't be broken
it should have the server messed in a folder and have the loop work fine
it does, but for some reason it's not working
austere talon
no the loop is straight up broken lmao
i think they accidentally use e instead of r
the loop never reassigns e so it will always do the same thing
this is a constant
they always use the same node's parent id
we just have to make sure nodeRefs[guildNode.parentId] is never null
limber skiff
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/bdd22b1486bd4c4f76b2652c364df38272701...
index.tsx: Lines 319-334
getGuildTree(isBetterFolders: boolean, originalTree: any, expandedFolderIds?: Set<any>) {
return useMemo(() => {
if (!isBetterFolders || expandedFolderIds == null) return originalTree;
const newTree = new GuildsTree();
// Children is every folder and guild which is not in a folder, this filters out only the expanded folders
newTree.root.children = originalTree.root.children.filter(guildOrFolder => expandedFolderIds.has(guildOrFolder.id));
// Nodes is every folder and guild, even if it's in a folder, this filters out only the expanded folders and guilds inside them
newTree.nodes = Object.fromEntries(
Object.entries(originalTree.nodes)
.filter(([_, guildOrFolder]: any[]) => expandedFolderIds.has(guildOrFolder.id) || expandedFolderIds.has(guildOrFolder.parentId))
);
return newTree;
}, [isBetterFolders, originalTree, expandedFolderIds]);
},
that filters out not expanded folders
limber skiff
yeah
austere talon
i think that's the problem
limber skiff
is this trying to jump into a non expanded folder?
austere talon
the way it happens with betterfolders is when you quickswitch to a guild in a cl...
.
like i said
austere talon
```js
let r = this.nodeRefs[e];
for (; null == r; ) {
let t = this.guildsTre...
you filter out closed folders
so when you jump to a closer folder, it will try to get that folder from the tree but it won't be there
so that's why it's null
limber skiff
so we should just fix the loop
austere talon
just don't filter out anything maybe
limber skiff
changing the tree will break the plugin
austere talon
you can put them in a div with display none
limber skiff
that's much more work
austere talon
no it isn't
austere talon
**index.tsx:** Lines 319-334
```tsx
getGuildTree(isBetterFolders: boolean, origi...
const newTree = new GuildsTree();
const openFolders = [];
const closedFoldersAndGuilds = [];
for (const child of originalTree.root.children) {
if (expandedFolderIds.has(child.id))
openFolders.push(child);
else
closedFoldersAndGuilds.push(child);
}
newTree.root.children = <>
{openFolders}
<div style={{ display: "none" }}>{closedFoldersAndGuilds}</div>
</>
just do this
limber skiff
those arent components lol
they are data used to make the components
later down it's mapped
limber skiff
almost yeah
austere talon
i would assume nodes is the data and children is the components
limber skiff
the comment explains what is
austere talon
anyway doesn't change that the way the plugin works is problematic
only putting the expanded folders in the bar is asking for trouble
austere talon
we should try to rethink how the plugin works because it's so unstable
breaks like every update
limber skiff
nah it's fine for rn
just need to fix this
besides the hacky css grid fixes
because discord wanted to use a stupid grid
austere talon
**index.tsx:** Lines 319-334
```tsx
getGuildTree(isBetterFolders: boolean, origi...
btw i think this memo is not quite right too
originalTree and expandedFolderIds can both change what elements they contain while still being the same Set
and it won't retrigger the memo
limber skiff
they make a new tree everytime
but it doesnt really matter
it works rn
let me find where the tree is mapped
here
yk
it uses root to render
so what if we only filter root
austere talon
try
limber skiff
I cant reproduce the issue with or without my change
cool
im dumb
I kept sadan change
aw
didnt work
limber skiff
working nice
changed all of this just to have the same issue
I think I'm close tho
@austere talon display none worked
and more specifically, only like this
if you just return an element with display none or null it breaks
jolly egret
https://github.com/Vendicated/Vencord/pull/3367 hey guys guess what
we should apply to this components v2 text display components too
same goes for other plugins like viewraw ๐ฅฐ
idk if its worth the effort but at least top level text displays should be supported
limber skiff
vtest
limber skiff
doesnt fix the colors but makes the plugin more readable
limber skiff
whatd u change
just refactored
basically works the same but with refactored code
cuz I as I said yesterday I couldnt fix it looking bad
austere talon
why rename
limber skiff
consistency
limber skiff
ive seen more plugins use the way I did than camelCase
austere talon
yes but camelCase is better
limber skiff
alright
austere talon
i only recently started using it
before i mostly used acronyms
.vc-ct-thing
but .vc-clientTheme-thing is better imo
limber skiff
ill push to main
limber skiff
no idea lmao
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing! 
limber skiff
that wasn't hard at all
nimble pendantBOT
vtest dev2
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now) 
austere talon
bro dont
limber skiff
why
austere talon
you're gonna manifest the update by doing that
limber skiff
wdym
austere talon
they will realise it's a horrible horrible idea and abandon the experiment, trust me
limber skiff
๐ญ
very well aligned
that's annoying
whatever that doesn't matter for now
their css is scuffed too
limber skiff
basically so when it does have a rollout we don't have to fix a lot of plugins at once
limber skiff
it's finee
austere talon
jumpscare
limber skiff
^ for theme purposes
clear jasper
https://discord.gg/brazil
lemme record a video rq
austere talon
clear jasper
clear jasper
in the web version
austere talon
this is expected and not the intention of the plugin to fix
austere talon
in the web version
this is web.
clear jasper
this is expected and not the intention of the plugin to fix
it's called a deep link internally so yes it is the intention of the plugin to fix
austere talon
i think I know better than you what my own plugin is intending to do
austere talon
If you have the desktop app open and open an invite in a new tab, then yes the intended behaviour is to open the desktop app. Anything else would be insane
If you have Discord open in your browser and open an invite in that tab then it will open in app. This is what the plugin does
clear jasper
If you have Discord open in your browser and open an invite in that tab then it ...
it prompts do you want to open discord
if you don't have the app open
opaque silo
so deny it perms?
the plugin is to stop the incensent pushing to the desktop app which cooks vesktop
austere talon
SO GOOD
jolly egret
incredible
fossil inlet
why is that a thing ๐ญ
discord was using it as a basic test before they actually started adding features to libdiscore
odd heath
ohh
limber skiff
vext
austere talon
discord was using it as a basic test before they actually started adding feature...
pushing hello world to prod
so good
somber ginkgo
thank ye kindly for fixing up clienttheme
median rapids
best libdiscore method
have u not seen the log at startup
best findByProps function
austere talon
thank ye kindly for fixing up clienttheme
now make it look not shit
limber skiff
true
limber skiff
@median rapids alien
whos gonna report to discord their stupid websocket fast connect doesn't work
shit been broken for ages
median rapids
whos gonna report to discord their stupid websocket fast connect doesn't work
lol i've noticed this for forever
it used to send the identify on fast connect
years ago
maybe it's only used on mobile now
austere talon
what's fastconnect?
median rapids
a preload script in the discord html that's supposed to bootstrap the gw connection
but rn it just opens a connection and does nothing with it
!function() {
if (null != window.WebSocket && function(n) {
try {
var o = localStorage.getItem(n);
if (null == o)
return null;
return JSON.parse(o)
} catch (e) {
return null
}
}("token") && !window.__OVERLAY__) {
var n = null != window.DiscordNative || null != window.require ? "etf" : "json"
, o = window.GLOBAL_ENV.GATEWAY_ENDPOINT + "/?encoding=" + n + "&v=" + window.GLOBAL_ENV.API_VERSION;
null != window.DiscordNative && void 0 !== window.Uint8Array && void 0 !== window.TextDecoder ? o += "&compress=zstd-stream" : void 0 !== window.Uint8Array && (o += "&compress=zlib-stream"),
console.log("[FAST CONNECT] " + o + ", encoding: " + n + ", version: " + window.GLOBAL_ENV.API_VERSION);
var e = new WebSocket(o);
e.binaryType = "arraybuffer";
var i = Date.now()
, r = {
open: !1,
identify: !1,
gateway: o,
messages: []
};
e.onopen = function() {
console.log("[FAST CONNECT] connected in " + (Date.now() - i) + "ms"),
r.open = !0
}
,
e.onclose = e.onerror = function() {
window._ws = null
}
,
e.onmessage = function(n) {
r.messages.push(n)
}
,
window._ws = {
ws: e,
state: r
}
}
}();
long stream
purely nepotism
austere talon
a preload script in the discord html that's supposed to bootstrap the gw connect...
fire?
limber skiff
@austere talon it's this
supposed to save the ws in a global object to take it over after
but doesnt work anymore
median rapids
do yall have no way to contact a dev
no lol
starf would see my admin panel notes and prolly block me
median rapids
what the bug hunter for ๐ญ
i'm not in dt i got it from sec xd
limber skiff
guh
im gonna send an email to the guy at discord intl
๐
@median rapids we are dumb
it does work
๐งโโ๏ธ
charred monolithBOT
limber skiff
looks fine to me
limber skiff
ah
median rapids
so the READY would be received by the time the app loaded
median rapids
possibly could lead to me being legally liable for distributing it.
is that actually real xd
i love eu law
austere talon
> possibly could lead to me being legally liable for distributing it.
is that ac...
yes
i chatted it up with grok
limber skiff
who's grok
austere talon
the only way it wouldn't be illegal would be if we added ID verification or smth like that
median rapids
oh nookies
limber skiff
hi
austere talon
i chatted it up with grok
lc.gem Would distributing the following Discord Modification be legal in Germany?
NSFWGateBypass
Allows you to access NSFW channels without setting/verifying your age. You are only allowed to use this software if you are over the age of 18
rancid idolBOT
lc.gem Would distributing the following Discord Modification be legal in Germany...
Would distributing the following Discord Modificaโฆ
austere talon
oh my god why is it so dumb
median rapids
i never open that
it's in ur bio ๐ญ
limber skiff
it's in ur bio ๐ญ
to see what I listen
austere talon
anyway someone else can put it on github or whatever idc i don't want anything to do with that anymore
median rapids
so silly
austere talon
median rapids
anyway someone else can put it on github or whatever idc i don't want anything t...
a faint whisper of third party plugin support passes over your head
limber skiff
anyway someone else can put it on github or whatever idc i don't want anything t...
moved it to my userplugins already
median rapids
i wasnt dumb and put a fake age when i signed up so i just don't need it
limber skiff
not idea what year I put
granite wharf
when it gets merged to main should we tell users that NSFWGateBypass was removed?
austere talon
moved it to my userplugins already <:blobwob:708468571986067467>
why u using that
nooker looking at nsfw on discord
granite wharf
when it gets merged to main should we tell users that NSFWGateBypass was removed...
@austere talon maybe we should be more informative about what plugins were removed for what reason (like when the tag plugin was removed)
fossil inlet
vencord support will be fun 
limber skiff
vencord support will be fun <:blobhuskcozy:1026533139608252436>
promoting you to supreme support helper
must help everyone that needs
fossil inlet
๐ญ
limber skiff
Lead Support Helper
fossil inlet
someone should make a tessie rule for nsfw or smth like that
limber skiff
it's fine
still gonna take some days to reach main (I hope discord doesn't break shit in the incoming week)
everything is so nice right now
fossil inlet
everything is so nice right now
soon...
scenic brook
lc.gem Would distributing the following Discord Modification be legal in Germany...
over the age of what
fossil inlet
just noticed that lol
limber skiff
soon...
im telling you something
better folders will survive now
there's just no way it breaks again
austere talon
over the age of what
HORROR TYPO
I saw that in the ai response and was like wtf is it cooking
thought it was ai brainrot
LOL betterfolders broken again @limber skiff
fossil inlet
WHAT
austere talon
vtest canary
nimble pendantBOT
vtest canary
Now testing!
dusk blaze
all the gooners gonna cry in support...
opaque silo
koda is heartbroken
limber skiff
LOL betterfolders broken again <@235834946571337729>
lying
lying
there's just no way
austere talon
dusk blaze
LOL betterfolders broken again <@235834946571337729>
sorry
glass jasper
Now testing! <:shipit:1330992654602731530>
Is it ever gonna send?
austere talon
that's not how the command syntax goes I think it just errored
anyway i lied
nuckyz was scared for a second
then he realised it's Sunday and they wouldn't push
fossil inlet
this is vee
opaque silo
this is vee
yop
limber skiff
nuckyz was scared for a second
I realized immediately it's sunday ๐
austere talon
they push on Sundays sometimes
fossil inlet
they push on Sundays sometimes
yeah, they just pushed an update that broke better folders
limber skiff
yeah, they just pushed an update that broke better folders
im breaking you next
austere talon
Amazon so goated for forcing people to work at 3am on Mondays so I get my package quicker
limber skiff
do they deliver at night
austere talon
no ๐ญ
later today
the original delivery date was Tuesday but now they emailed it will arrive on Monday (I ordered Friday at 8pm)
dusk blaze
im breaking you next
reminds me of
fossil inlet
reminds me of
still hasn't been reviewed
austere talon
still hasn't been reviewed <:blobcatcozy:1026533070955872337>
I'll review the most viable options for exploding your house
fossil inlet
insane
fossil inlet
i love arbitrary file read from browser
i love sandbox escape
@dusk blaze did you write this?
chrome coral
wouldnt a path to the secret also be.. something not ideal?
if an attacker somehow gets access to config.json what makes them not be able to use that to their advantage to find the path to where said api key is located
it just seems like something unnecessary
fossil inlet
if an attacker somehow gets access to config.json what makes them not be able to...
feel like it's more settings sync things
fossil inlet
but if you don't trust vencloud just dont use it
i feel like it's more the level of trust
theres a difference bewteen random settings and an API key
i dont use vencloud personally , but i wouldn't trust an API key in it
chrome coral
yes thats the point
if you don't want vencloud having that information either just don't use vencloud, or just don't put an api key and use vencloud
not sure how thats husk, another user asked if they could put their personal IP in one of their settings just for fun
vencloud technically would store it but at that point why do it in the first place
it just seems nonsensical
fossil inlet
not sure how thats husk, another user asked if they could put their personal IP ...
there's no way to use the plugin and use settings sync assuming that you don't want the API key synced
you shouldn't be forced to choose bewteen using an API key and settings sync for everything else
chrome coral
are you suggesting you want the api key to be not synced with vencloud
fossil inlet
remainnn not synced
am i being stupid, i thought it was synced
chrome coral
just answer the question instead of trying to point out a useless grammar mistake
fossil inlet
just answer the question instead of trying to point out a useless grammar mistak...
yes and i wouldn't call it a useless mistake
chrome coral
sigh
that would be the only obvious solution to having both
unless you can think of something else
fossil inlet
i can think of two other things, both either complex or not that good
hollow musk
i dont personally see any difference, not sure what exactly these guys are on
yes, the background is slightly dimmer, but its mostly due to a stupid bezier curve (fun fact, it isnt) that the discord employers found that changes the values of the lightness entirely
its either you a) get used to it or b) make your own theme or c) steal a theme
trying to hand select the lightness shifts is just not worth your time
for context, this is a better side by side comparision of a screenshot i took a while back to showcase my version with exactly the same lightness as discord had set it
chrome coral
the text and icons is mainly the problem in my opinion
it feels extremely weird to color those
chrome coral
lol.
gritty canyon
ill make an nsfw gate bypass 3rd party plugin but youll have to dm me your id to get access to it if you want
limber skiff
vext
fossil inlet
vext
odd heath
vext
jolly egret
every time ๐ญ
fair wolf
Vencord doesn't have any kind of access to the nodejs electron layer when running on the official client right?
gritty canyon
Vencord doesn't have any kind of access to the nodejs electron layer when runnin...
it does
check plugins that use native
fair wolf
check plugins that use native
Okay thanks :>
austere talon
Vencord doesn't have any kind of access to the nodejs electron layer when runnin...
full access
still maple
ill make an nsfw gate bypass 3rd party plugin but youll have to dm me your id to...
here's my user ID : 369179216031383552
charred monolithBOT
hollow musk
the text and icons is mainly the problem in my opinion
i swear i cant see the difference in text colour
charred monolithBOT
austere talon
insane
austere talon
i misclicked
austere talon
so much malware here
kindred tree
:3
jolly egret
incredible
cant wait for the "I'm sorry, but I can't assist with that request." ๐ฅฐ
austere talon
what now
jolly egret
git stores permissions
no idea why that was changed though 
what funky IDE stuff is goin on
kindred tree
me neither, I saw it in git before committing but I forgot to discard it
austere talon
git stores permissions
ik 
kindred tree
it shouldn't affect anything, didn't do anything weird with the file
kindred tree
yeah 
austere talon
refined github flop
jolly egret
lol
gritty canyon
what now
me when the me the when the me the file perms
the git config core.fileMode false
jolly egret
what context am i lacking
limber skiff
that one is wild to break tho
limber skiff
what context am i lacking
breaking everything
austere talon
that one is wild to break tho
nah
react 19 upgrade
reactjs.org is old domain
new one is react.dev
limber skiff
it's in rdom client
limber skiff
fixed it already
limber skiff
isnt it just React.createRoot now
nop
it's in just dom client
but hydrateRoot doesnt even exist in discord
limber skiff
vtest
limber skiff
so I think we released extension yesterday with image zoom broken
nimble pendantBOT
vtest dev2
Now testing!
limber skiff
vtest dev2
austere talon
React has blocked a javascript: URL as a security precaution.
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now)
nimble pendantBOT
vtest dev2
jolly egret
maybe you wanna tell people you removed nsfwgatebypass
can't wait for everyone to complain otherwise
at least add a tessie autoresponse
austere talon
eh they can see it
dusk blaze
gooner invasion
limber skiff
vext
dusk blaze
tbf a #1257025907625951423 saying about nsfwgate might be nice else it'll be reviewdb 2.0
kindred tree
maybe you wanna tell people you removed nsfwgatebypass
rip bozo
limber skiff
wait dont delete the fix yt adblock one
it was already merged
I suppose you are fixing it again?
austere talon
it was already merged
and reverted
limber skiff
ah
shell shuttle
gooner invasion
WHAT
where did it go
๐ญ i've never needed that plugin EVER
but like
why's it gone
limber skiff
maybe click the commit and read
median rapids
they broke everything again
what changed
fossil inlet
https://discord.com/channels/1015060230222131221/1337479880849362994/13691323541...
i feel like i've seen that before
grizzled halo
austere talon
Vencore
limber skiff
so when libvencore
limber skiff
@jagged reef looking to review https://github.com/Vendicated/Vencord/pull/2239
so if you wanna make sure it works
jolly egret
wanna review my stuff ๐ฅบ
jagged reef
<@761777382041714690> looking to review https://github.com/Vendicated/Vencord/pu...
Last I checked it does
odd heath
can i get a review toooo
scenic brook
You have plenty smh
odd heath
You have plenty smh
i meant on this xd
https://github.com/Vendicated/Vencord/pull/3346 also on this but imma fix the patches first
limber skiff
vext
odd heath
https://github.com/Vendicated/Vencord/pull/3346 also on this but imma fix the pa...
fixed the patches 
charred monolithBOT
odd heath
charred monolithBOT
chrome coral
๐ญ
shell shuttle
kill kill kill
what's wrong with it
limber skiff
vext
elder plinth
where does MessagePopoverAPI get the message data it provides the plugin that uses it?
elder plinth
so it's getting it as-is from the client itself and not some other part of vencord?
limber skiff
yeah
elder plinth
cause some of the data returned by it is wrong based on the api
so I guess the client does some transforming on it
limber skiff
vext
limber skiff
Google taking so long
glass jasper
vext
jagged reef
<@761777382041714690> looking to review https://github.com/Vendicated/Vencord/pu...
Can confirm that it works, call ringtones, and messages alert correctly!
(On the latest discord version)
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
nimble pendantBOT
vtest dev2
nimble pendantBOT
vtest dev2
limber skiff
vtest
limber skiff
now also includes an animateText prop which is probably related to gradients, can potentially animate that in the future too
scenic brook
Is dev tools just unusably slow for anyone else
Typing a few chars into the styles tab freezes it for ages
It's not vencord as it's the same after uninjecting but it seems to affect all but stable
scenic brook
Sick
fossil inlet
?remind week update prs
shut vineBOT
Invalid time provided, try e.g. "tomorrow" or "3 days".
odd heath
Lmao
scenic brook
How will he remember now
austere talon
vtest dev
shell shuttle
shipit!
dusk blaze
brb gonna break some things
limber skiff
just these?
yeah, mostly for NoUnblockToJump
pine topaz
brb gonna break some things
nin0 will delete half of the vencord core
shell shuttle
vencore
glass jasper
Other then adding yourself to constants for a small change thatโs actually a good change
somber ginkgo
showmeyourname is being blueballed by gradient roles when in x then y modes https://shit.post.in/5GEN12J.png
imo the gradient shouldnt extend to the brackets, but i cant find an easy css fix since i cant override background-image on a text node, and smyn puts its element right next to said text node, so it gets set by the parent
fossil inlet
imo the gradient shouldnt extend to the brackets, but i cant find an easy css fi...
weird, i would have thought that the css from the plugin itself would have priority
yeah
somber ginkgo
gradients are overlaying a background-image (and moving it using an animation when hovered) https://shit.post.in/7Ahkf9U.png
so its like, hard to do anything useful by overriding it on the smyn class (at least that isnt complete aids)
gritty canyon
gradients are overlaying a background-image (and moving it using an `animation` ...
yo can just do this
somber ginkgo
webkit property moment
gritty canyon
gritty canyon
webkit property moment
yes that is how the styling works for gradient text everywhere
it is what discord uses too
gritty canyon
background to gradient
clip background to text
set text fill to transparent
gritty canyon
so yea you can add this i guess fixes that issue
austere talon
funny
span {
background: linear-gradient(to right, lightblue, pink, white, pink, lightblue);
background-clip: text;
-webkit-text-fill-color: transparent;
}
you can do the same with color tho
idk why they use the webkit one
this works the same
span {
background: linear-gradient(to right, lightblue, pink, white, pink, lightblue);
background-clip: text;
color: transparent !important;
}
this looks certifiably terrible https://shit.post.in/7T3FwzJ.png ```css
.vc-smyn-suffix {
-webkit-text-fill-color: var(--text-muted);
background-color: var(--text-muted);
background-clip: text;
}
text is aliased to hell and appears bold because of it
@gritty canyon the property you posted appears to be insufficient
gritty canyon
wdym
somber ginkgo
text is aliased to hell and appears bold because of it
.
also without setting the background colour too, the gradient colour bleeds through
gritty canyon
everything works fine for me
somber ginkgo
with no gradient applied, just to show how it makes the text appear worse
without fix https://shit.post.in/AdV4ZZx.png
with fix https://shit.post.in/8XDxLPN.png
and again, with gradient
without bg colour https://shit.post.in/ANTc9J8.png
with bg colour https://shit.post.in/94KvRpx.png
fossil inlet
is it just me, or are react devtools breaking with the discord react update
afaik we're using an old verson because electron doesn't support mv3 yet, but it will be a pain in the ass to get things done with just the component tree and nothing else.
||if things get bad enough i might patch a version myself ||
limber skiff
test if latest version works with electron
austere talon
is it just me, or are react devtools breaking with the discord react update
afa...
works for me
what function is that
oh nvm
fossil inlet
i'm going to see if latest version works, and if not patch an old version
austere talon
test if latest version works with electron
no cause it doesnt support manifest v3
limber skiff
horrible.
austere talon
unless they added
fossil inlet
new devtools work
love
charred monolithBOT
austere talon
there's electron/electron#41613 but i cant repro
oh nvm
it worked the first time but now it no work
fossil inlet
it worked the first time but now it no work
is it cached?
austere talon
there's [electron/electron#41613](https://github.com/electron/electron/issues/41...
same issue as here
LOVE
fossil inlet
was just about to say try a delay ๐ญ
charred monolithBOT
austere talon
i wanna merge all the No* plugins into one plugin
then you have to go into the settings of that plugin and enable the ones you want
if you enable the plugin without changing settings it will do nothing
this should hopefully solve idiots enabling plugins then complaining why the feature it disables doesn't work
grave harness
How does one get access to css snippets channel?
might be in the wrong place to ask lol
Looks like I am! Ignore me!
fossil inlet
who knows, maybe it'll be merged before 2026
somber ginkgo
i wanna merge all the `No*` plugins into one plugin
what would you even name it
austere talon
i wanna merge all the `No*` plugins into one plugin
why husk, do you have any better idea @dusk blaze
the problem: lot of dumb people enable plugins without reading and then end up with a feature "broken"
especially NoRpc, NoProfileThemes, and a few more
there are two solutions:
- remove all those plugins
- add more explicit action to all of those to require the user to use their brain before enabling. I think unifying them into one single "FeatureDisabler" plugin with switches for everything (and maybe explicit confirmation) would be the best way to do this
that plugin could then also have a section for disabling things like profile effects, the gift / etc chat buttons, and so on
somber ginkgo
not all things those plugins disable are features per se, perhaps functionalitydisabler would be more fitting
austere talon
bikeshedding :P name doesn't matter that much rn, just mainly the concept
somber ginkgo
setting migration would be interesting
since its moreso the plugin being enabled and its settings if it has any, as opposed to just the plugin settings themselves
another point, if youre consolidating, why stop at No* plugins, why not just combine everything that only modifies discord behaviour instead of adding new behaviour into one
could have another tab just for "tweaks", outside of the plugins page
scenic brook
Unless they've changed it, you need to change the patched webpack modules to have file:/// before the filename to allow jumping to source code with latest dev tools
I've been using them for a while
charred monolithBOT
scenic brook
I also find this is a common issue with the current version, I have to already have dev tools open when the page loads for it to load the tree
fossil inlet
I also find this is a common issue with the current version, I have to already h...
@austere talon seems like stock discord is on an older electron version that doesn't support the newer react devtools yet
scenic brook
I haven't had the issue in a while now until I removed and let it reinstall the extension and now it's a thing again
So I don't know if it's something that just resolves itself
fossil inlet
Istg I'm just patching an old version of react devtools
scenic brook
Just put an old one in the extensionCache folder
limber skiff
Istg I'm just patching an old version of react devtools
fix it then
can just host the same way we were already doing and use old version
fossil inlet
fix it then
That's what I meant ๐ญ
shell shuttle
the problem: lot of dumb people enable plugins without reading and then end up w...
i love having above average intelligence to not have issues using vencord
๐ฅ
gritty canyon
i love having above average intelligence to not have issues using vencord
bringing back this banger
(sorry not sorry)
:3
shell shuttle
bringing back this banger
๐ญ
it was like
6 months after i worked on my first plugin
i forgot about good old pnpm run build
grave harness
bringing back this banger
Ey Hi Chloe!!!
charred monolithBOT
discord couldnt be bothered to make proper ui for guild experiments, so this plugin fixes it. depending on how things turn out I might add user ones to see friends too
still maple
that seems cool
scenic brook
The notification for when you get added to an experiment rollout is the most interesting part tbh
hollow musk
lgtm
austere talon
would be fire
glass jasper
I swear if this does the same as client theme plugin
iirc wasnโt Client Theme a recreation of a super old discord experiment anyhow
limber skiff
yeah but it's changed now
glass jasper
Fair
glass jasper
||knowing Discord if this does happen, itโs going too be a nitro only thing, so FakeNitro bypass will still be required||
jagged reef
<@761777382041714690> looking to review https://github.com/Vendicated/Vencord/pu...
Whatever happened to that ๐ญ
charred monolithBOT
@votzybo Should be fixed now, latest changes also includes some general improvements.
I am still experiencing the same problem. i dont
get any notifications, and the example notification does not work. am i installing the pull request wrong?
desert cosmos
why did they request my review
austere talon
you will review
north knoll
you were already down as reviewer from last time :)
north knoll
:(
desert cosmos
im surprised that youre still willing to work on that pr
its open for like a year now
north knoll
i use & maintain the plugin mainly for myself but theres dozens of users who depend on my branch so happy to keep it up to date
though would be nice to have it in main so i dont have to teach people how to build from source ๐
brazen bone
Did discord change their react version recently? Think you mentioned something about that
limber skiff
Did discord change their react version recently? Think you mentioned something a...
yeah
It's react 19 now
brazen bone
Turns out that broke my classify plugin, gotta fix that
brazen bone
Didn't need a huge change luckily, just update the patch
somber ginkgo
give it to MEEE
dusk blaze
gonna bump u down a cliff soon
dusk blaze
hi! please do not use AI for writing pull requests. this pull request is closed!
long stream
๐
jolly egret
perish
dusk blaze
average discord gooner
jolly egret
people will see genuine reasons to do something and then still act entitled
shell shuttle
average discord gooner
๐ญ oh this is to THAT ccommit
idle fossil
y was there a gate bypass plugin anyway you can just put a fake date if you don't want to give away your birthday (as an adult)
or do they require actual ID for any age you input now
charred monolithBOT
scenic brook
or do they require actual ID for any age you input now
UK and Aus are starting to require ID in some cases
jolly egret
this fixes nothing because nothing is broken
you can't just call it "FixX" just because you don't know what else to call it
desert cosmos
isnt discord already doing this
brazen bone
you can't just call it "FixX" just because you don't know what else to call it
Yeah you gotta flip a coin
Heads for "FixX", tails for "BetterX"
charred monolithBOT
opaque silo
scenic brook
I've seen many people get malware because of copy-pasting commands mindlessly from a tutorial
So I wanted to add another way for them to do it too
jolly egret
yep