#👾-core-development

1 messages · Page 248 of 1

scenic brook
#

[Will add screenshots after initial review]
Why

charred monolithBOT
jagged reef
#

1362 lines

charred monolithBOT
#
iminlikewithyou
[Vendicated/Vencord] Issue opened: #3330 [Bug] Disable minimum window size no longer works

What happens when the bug or crash occurs?

Enabling "Disable minimum window size" in Settings > Vencord no longer disables the minimum window size. This stopped working seemingly alongside the updated Discord UI refresh.

What is the expected behaviour?

I expect Vencord to still be able to disable the minimum window size via Electron tinkering or some other patch rather than [relying on the MIN_WIDTH and MIN_HEIGHT settings from appSettings](https://github.com/Vendicated/Vencord/blo...

jagged reef
#

Goddamnit

Screenshot_2025-03-28_at_10.29.22_PM.png
scenic brook
#

Smh automod hates comedy

jagged reef
versed fern
#

reaction notifications

scenic brook
#

Calls if that's not already included

charred monolithBOT
#
Walkoud
[Vendicated/Vencord] New comment on pull request #2977: new plugin: BlurMediasToggle

thanks for your contribution! however, this seems too niche / not very useful. one can just disable/enable embeds in discord settings for a similar effect

  • BlurNSFW exists

I think BlurMediasToggle is actually quite useful, even if Discord has options to disable media previews globally.

First, Discord’s built-in settings are not flexible. If you disable media previews, it applies to everything across all servers and DMs, and if you want to see previews again, you have to manual...

charred monolithBOT
charred monolithBOT
desert cosmos
#

what

astral bone
#

Git has a mind of his own confirmed?

charred monolithBOT
jolly egret
#

merge these changes right this instant

image.png
granite wharf
#

most optimized pr

brazen bone
median rapids
#

fetch

+
jagged cloak
#

Create fetch NOW

charred monolithBOT
charred monolithBOT
median rapids
woeful sleet
#

Never in my life have I considered the racial connotations there. Is that really something people are thinking about?

fossil inlet
#

wait i misread it

median rapids
jagged cloak
#

yes

#

i believe it was someone working at twitter that started the whole "whitelist and blacklist is racist" or whatever

#

idgi its just terminology no one is using that to be racist or anything and ifthye are theyre just weird

lime stone
#

cmon lol whitespace too?
I don't know the origin of whitelist and blacklist but isn't whitespace just the white space on a page?

jagged reef
#

Peak minification:

function D(e) {
    let {channel: t} = e;
    return N(t.id)
}```
charred monolithBOT
brazen bone
#

Was obviously written function D({channel}) { return N(channel.id); }

jagged reef
charred monolithBOT
jagged reef
charred monolithBOT
jagged reef
# versed fern reaction notifications

If you really do want that, it looks like the module is 974180 and it's less straightforward than the others. The PR is #2239 if you get it working

charred monolithBOT
charred monolithBOT
#
Voxxin
[Vendicated/Vencord] Pull request opened: #3333 [Plugin] KeybindMute

This plugin adds keybinds for muting, unmuting, deafening, and undeafening yourself.
While Discord provides toggle options by default, this plugin lets you assign keybinds to set a specific state directly—for example, instantly deafening yourself with a single press.

These keybinds are integrated into the Keybinds page action list, making setup and customization simple and intuitive.

ruby totem
#

yay !

charred monolithBOT
austere talon
#

they even consider a white person doing any typical black thing racist

#

wearing dreadlocks? making rap? you're probably a massive racist

#

it's just losers who get offended by everything and get their kick from taking the moral highground, it's a waste of time to pay any mind to that group

#

personally I'm inclusive by using mayoMonkeyList and blackQueenList instead of whitelist and blacklist

woeful sleet
#

I don't think it's even that. Like I can't imagine anybody in any of these companies takes that shit seriously. It only really makes sense to me if someone's being paid a lot of money to try and come up with these "inclusivity" stunts. To throw out something like this once in a while so they can claim they're making a change.

At some point it's definietly ends up being echoed by trolls and idiots, but I can't imagine it starts there

desert cosmos
austere talon
#

nah there's definitely people who actually believe that shit lol and a lot of companies are pandering to it cause they wanna seem super welcoming and inclusive to everyone and think it will boost sales

#

But a lot of companies are starting to realise it doesn't actually resonate with the average Joe

gritty canyon
austere talon
#

who cares that much

#

shocker: discord, the same company who also unironically says latinx, likes woke language

gritty canyon
#

discord is woke...

opaque silo
#

need to change all words to latinx

charred monolithBOT
charred monolithBOT
median rapids
charred monolithBOT
jolly egret
#

What is going to happen with the toolbox and stuff in the visual refresh? is there plans to move it to where the current buttons (like the inbox) are or what?

#

Would realistically make the most sense i think

glass jasper
#

Putting it up near the inbox (and where the bug icon would if the patch for it worked) makes the sense to me

charred monolithBOT
charred monolithBOT
scenic brook
surreal fiber
charred monolithBOT
austere talon
#

lol Australia moment

jolly egret
#

yeah

opaque silo
#

no way I trust discord with id like that

austere talon
#

but recently they added the option to verify your age based on your online activity (somehow)

#

I used that and it worked

jolly egret
jolly egret
#

no idea what they qualify

opaque silo
jolly egret
#

id verification for bots and stuff is handled by stripe i think

#

idk if its the same here

opaque silo
odd heath
charred monolithBOT
jagged reef
#

Best April Fools idea; merge the adcord plugin

scenic brook
#

Best April Fools idea; merge ||the|| a||dcord|| plugin

jagged reef
limber skiff
#

so they started releasing this?

austere talon
#

NamePlates

limber skiff
#

yeah

jagged reef
limber skiff
#

looks nice

jagged reef
#

I can see into the future using Vencord™©®

Screenshot_2025-03-31_at_3.28.23_PM.png
knotty musk
knotty musk
charred monolithBOT
charred monolithBOT
woeful sleet
charred monolithBOT
#
dolfies
[Vendicated/Vencord] Pull request opened: #3338 fix(ImplicitRelationships): update logic

Discord updated their logic so you no longer need a mutual guild for a user to be considered an implicit relationship. This makes the plugin logic quite a bit simpler (it should now be a lot faster as it loads asynchronously). Unfortunately, it also means some users may not show up in the list if the user object isn't cached, but I don't think it's worth adding HTTP fetching logic for these rare edge cases.

dusk blaze
#

for april fools 100 prs will be merged such as;

  • goodperson
  • adcord
  • spotifycontrols visual refresh css
charred monolithBOT
scenic brook
#

Nice april fools

charred monolithBOT
brazen bone
#

You don't have to close the pr to push new commits

#

Also isn't this textreplace but worse

charred monolithBOT
scenic brook
#

lol the "a lot" was a bit mean

charred monolithBOT
#
smoukey
[Vendicated/Vencord] New comment on pull request #3340: ReplaceAnything plugin

I didnt know about TextReplace but i just went thru it and it’s kinda overcomplicated. It has regex support, multiple rule types, and a bunch of UI elements that most people don’t need. Mine is way simpler, just pick what you want to replace and what to replace it with, and you’re done. No unnecessary settings, no clutter, just works.

jolly egret
charred monolithBOT
jolly egret
#

it also happens to build the regex every time you send a message that contains the target

charred monolithBOT
#
jamesbt365
[Vendicated/Vencord] New comment on pull request #3340: ReplaceAnything plugin

and it’s kinda overcomplicated

It really isn't that complicated, you get your find, your replace and an option to only replace in certain situations

and a bunch of UI elements that most people don’t need

I don't get this at all? What?

Mine is way simpler

Yes, it is simpler but in a way that makes this unusable for any person who wants to replace multiple things or more advanced things, your plugin has 1 replacement option, thats it, you can only have 1, TextReplace ...

gritty canyon
#

so mad...

scenic brook
#

Mouse just hit the wall

charred monolithBOT
scenic brook
#

If this isn't a troll it's great comedy

#

ClearURLs next

charred monolithBOT
austere talon
charred monolithBOT
jolly egret
#

The guy sent me a dm request from another account other than the one hes trying to put as a contributor

#

but i closed it because i didn't care but i can't find it anymore

#

Either way they're just contributing crap and i can think of multiple reasons why this is just worse

#

Oh i checked there gh profile

#

multiple selfbots

charred monolithBOT
jagged reef
jagged cloak
#

still not timedones

charred monolithBOT
glass jasper
jolly egret
#

why am i a co-author to that

jolly egret
#

that kinda has nothing to do with the visual refresh

gritty iris
charred monolithBOT
weary cave
long stream
#

what's the difference

weary cave
#

I won't get into it as not to pull drama into dev channel

long stream
#

im pretty sure you can merge prs without attributing them to their authors

#

eitherway they're in vencord's commit history afaik so it doesn't really matter

weary cave
#

fair i suppose

odd heath
weary cave
#

it works for me

#

hang on

#

oh I see

#

I don't use any theming lmao

charred monolithBOT
glass jasper
#

Very basic thing to implement

#

Test

grave vaporBOT
glass jasper
#

^^

weary cave
#

is that what that PR does

#

because theres no context

#

sob

glass jasper
#

Also, it’s just a straight up stolen plug-in

#

It’s a really old @still wasp plugin

#

They’re not even trying to hide it

#

They did absolutely nothing but added their name

charred monolithBOT
#
lukasani94
[Vendicated/Vencord] New comment on issue #3258: Visual Referesh UI issues

Lukas Ani — 7:50 PM
with the PinDM plugin, when I click on usernames/convos that are not pinned (to open that specific convo), the username list jumps unexpectedly to the wrong place, it almost seems like it's being offset by all the pinned stuff at the top

I.e. I click on an username to open a convo with that person, the username list jumps down to the point where I can't even see the name of the person I just clicked on

NOTE: This problem does not occur when clicking on pinned usernames/...

weary cave
glass jasper
#

They changed one thing and then slapped their name on it

glass jasper
scenic brook
glass jasper
#

It’s an old sandwich plug-in

charred monolithBOT
weary cave
jolly egret
#

yep

fossil inlet
# weary cave

isnt mock already a command in the more commands plugin

(i havent read the pr so idk if it's the same thing)

jolly egret
#

it is a command, but they added a BUTTON on the message context menu that just automatically mocked the persons message

#

which just makes misclicks that sends messages possible, accidental pings possible, links would get mangled, and tbf the way they were changing the capitalization was somewhat weird

weary cave
#

woudln't a button to send a message fall under self bot

austere talon
#

... no?

fossil inlet
weary cave
#

fair enough

gritty canyon
#

i view it as automating shit, sending a message on a button press still requires that button press
automatically sending a message every x minutes? completely automated, self bot

fossil inlet
jolly egret
#

yeah but your example was just... selfbotting lol

fossil inlet
knotty musk
#

how many merges for a badge?

fossil inlet
jolly egret
#

you don't get a badge on vencord without being on the contributors section which is either reserved for big changes or plugin development

fossil inlet
weary cave
jolly egret
#

you get the role any time you count as a contributor (author or coauthor) of a merged commit in the default branch in the git history

fossil inlet
#

run vgh to get the role

knotty musk
weary cave
#

vgh

nimble pendantBOT
weary cave
#

husk

knotty musk
#

what'd it say?

jolly egret
#

run vgh and find out

knotty musk
#

Done

nimble pendantBOT
odd heath
#

vgh

nimble pendantBOT
odd heath
#

silly

odd heath
#

unless theres alr one for that

#

cuz this looks familiar

#

o yeag

knotty musk
odd heath
#

someone should merge #3308 so we dont get more ppl complaining

fossil inlet
umbral hillBOT
#

mods crush this person's skull

nimble pendantBOT
odd heath
fossil inlet
#

@knotty musk subscript (-#) is blocked by an automod rule

and you get timed out if you send a screenshot of an automodded message

knotty musk
#

I got that last part

#

Who runs @umbral hill?

#

The bot's in 100 servers, but it's not verified with the new api thingy

jolly egret
#

the app is verified

#

but its ran by lewi iirc

knotty musk
#

Yes, in the UI, but the backend isn't verified, so you can't add it to more servers.

#

I want to know if that's on purpose

fossil inlet
fossil inlet
austere talon
#

cause of intents probably lol

fossil inlet
#

should be pretty easy to make your onw

knotty musk
jolly egret
#

oh it probably added an extra intent

knotty musk
jolly egret
#

wait no it literally only has the messages one

knotty musk
#

Like what it's blocking specifically

knotty musk
austere talon
#

iirc lewi said something ages ago about discord not approving message content intent lol

fossil inlet
#

those are bot side, you cant change them on the client

jolly egret
knotty musk
#

but apparently not.

fossil inlet
knotty musk
#

That's the automod

#

I was asking about the bot lol

knotty musk
fossil inlet
knotty musk
#

gotcha

#

so not the string

jolly egret
#

the ... means it continues

#

they obviously cannot say the whole thing

knotty musk
#

well doesn't it only block it if it's in an image?

fossil inlet
#

i just didnt want to type it all out

umbral hillBOT
#

mods crush this person's skull

knotty musk
#

or does it also block in case someone goes to inspect element and copies it to clipboard skulltula

nimble pendantBOT
knotty musk
#

bruh

fossil inlet
#

yea, it blocks in text too

jolly egret
#

everything tessie does

knotty musk
#

I don't think this'll work because @nimble pendant probably only does it if it comes from @umbral hill

#

but..

knotty musk
#

yeah no

#

that would be funny though

knotty musk
jolly egret
grave mangoBOT
# jolly egret https://codeberg.org/vee/bot/src/branch/main/src/modules/moderate.ts#L286-L306

moderate.ts: Lines 286-306

export async function lobotomiseMaybe(msg: Message<AnyTextableGuildChannel>) {
    if (msg.author.id !== TESSIE_ID || !msg.referencedMessage || msg.content !== "mods crush this person's skull") return false;

    try {
        await msg.referencedMessage.member!.edit({
            communicationDisabledUntil: until(10 * Millis.MINUTE),
            reason: "showing screenshot of automodded message"
        });

        silently(msg.referencedMessage.delete());

        silently(reply(msg, {
            content: "Lobotomised! 🔨"
        }));

        return true;
    } catch (e) {
        console.error("Failed to lobotomise", e);
        return false;
    }
}
jolly egret
#

now this is extremely offtopic for vencords development so please move channel

knotty musk
#

okay

scenic brook
charred monolithBOT
shell shuttle
#

wrong channel

charred monolithBOT
charred monolithBOT
austere talon
#

horror wtf is pr

image.png
fossil inlet
charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New comment on pull request #3336: Update NSFWGateBypass to allow users in the UK/Australia to bypass nsfw age filter

Thank you for your contribution! I wanted to make some changes before merging (mainly merging both patches into one and not adding you as author because our convention is to only list people who made major changes, not just a few lines of changes), but you disabled the "Allow Maintainers to edit the code" switch so I can't (please leave that checked in the future)

Thus I edited and merged this manually via https://github.com/Vendicated/Vencord/commit/95bd8c831c9ef5067dd9a1be548c682eb7bc5177

charred monolithBOT
opaque silo
#

discord is already breaking old ui so i think its best to just drop all old ui patches

austere talon
#

no harm in keeping support for old stuff for now if it doesn't add extra effort

fossil inlet
austere talon
#

but if it does then yeah

#

depends what exactly you mean

#

if you mean using those names in your css

#

well yeah you have to

fossil inlet
#

ok, ill do that for better folders (idk what i was on with the current one 😭)

charred monolithBOT
fossil inlet
# charred monolith

i was having that issue on old UI too

for some reason, toggling quick css would fix it until the window lost focus

#

then it would start lagging again

austere talon
#

css funnies

fossil inlet
#

wonder if it's somehow related to the flickering thing

charred monolithBOT
opaque silo
#

vee so proper in github comments

austere talon
#

so proper
look inside
second to last comment literally contains fbomb

charred monolithBOT
austere talon
#

you woke up the rascal in me @opaque silo

fossil inlet
#

every other word in my next pr will be the funny toilet word

charred monolithBOT
opaque silo
#

thanks!!!

opaque silo
austere talon
opaque silo
#

im watching you

#

inject me with css energy

#

i will finish catppuccin visual refresh overhaul

#

rahHHGG

fossil inlet
opaque silo
#

so much to do but so much twitter to doomscroll..

austere talon
charred monolithBOT
austere talon
#

you could just add a displayName argument to LazyComponent and call it a day

#

doesn't take much brain to guess what LazyComponent(Tooltip) > X$ is

charred monolithBOT
charred monolithBOT
charred monolithBOT
jagged reef
charred monolithBOT
#
peyton2465
[Vendicated/Vencord] New comment on pull request #3260: vcNarrator: Add ability to use Friend Nickname

Reasons that I think having a new tag is a better option:

  1. It doesn't change the functionality of current configurations.
  2. It does not break any of the other functions of this plugin.
  3. Some users may use friend nicknames, but don't want those nicknames to be announced by the narrator.
  4. It gives users more options for configuring the plugin to their liking.

But please explain your stance. I'm not sure which variable you would prefer to alter for this new feature.

charred monolithBOT
charred monolithBOT
#
doyle31
[Vendicated/Vencord] New comment on pull request #3336: Update NSFWGateBypass to allow users in the UK/Australia to bypass nsfw age filter

Thank you for your contribution! I wanted to make some changes before merging (mainly merging both patches into one and not adding you as author because our convention is to only list people who made major changes, not just a few lines of changes), but you disabled the "Allow Maintainers to edit the code" switch so I can't. please leave that checked in the future!

Thus I edited and merged this manually via [95bd8c8](https://github.com/Vendicated/Vencord/commit/95bd8c831c9ef5067dd9a1b...

charred monolithBOT
charred monolithBOT
dusk blaze
#

@warped frost will you marry me

charred monolithBOT
charred monolithBOT
charred monolithBOT
#
sadan4
[Vendicated/Vencord] New comment on issue #3258: Visual Referesh UI issues

with the PinDM plugin, when I click on usernames/convos that are not pinned (to open that specific convo), the username list jumps unexpectedly to the wrong place, it almost seems like it's being offset by all the pinned stuff at the top

I.e. I click on an username to open a convo with that person, the username list jumps down to the point where I can't even see the name of the person I just clicked on

NOTE: This problem does not occur when clicking on pinned usernames/convos ...

charred monolithBOT
charred monolithBOT
charred monolithBOT
odd heath
#

omg

#

i was losing my mind over a patch

#

to realise

#

pnpm wasnt watchin

#

guhhhhhhhhhhh

#

is there any way to patch a function that gets loaded like this Hmm

4BbCctX6z6lic32UXVzP9UeRxN05lyjeWNJ.png
fossil inlet
odd heath
#

i think at least

#

unless i do some silly manipulation of the values of the RLStore before the module is loaded and then undo them after its been used

fossil inlet
odd heath
fossil inlet
odd heath
#

ya

fossil inlet
#

SO CURSED

fossil inlet
# fossil inlet

i think the only case this makes a difference is something like null || undefined || null where it would be undefined otherwise

#

but both y and O should always be booleans

#

🤷

odd heath
#

yop

#

had the same thought when i saw that 😭

austere talon
#

the 0?

#

oh wait it's y twice

#

wtf is going on

fossil inlet
austere talon
#

okay yeah that just makes no sense

fossil inlet
#

assuming y isnt a getter

#

which i know it is not

clever sierraBOT
#

Yes, there's a specific case where x || 0 || x is not equal to x: when x is NaN (Not a Number).

Here's why:

  • NaN || 0: The || (logical OR) operator first evaluates its left operand. If the left operand is truthy, it returns the left operand. If it's falsy, it evaluates and returns the right operand. NaN is falsy. So, NaN || 0 evaluates to 0.

  • 0 || NaN: Similarly, the || operator first evaluates its left operand. If the left operand is truthy, it returns the left operand. If it's falsy, it evaluates and returns the right operand. 0 is falsy. So, 0 || NaN evaluates to NaN.

  • x || 0 || x with x = NaN: The expression becomes NaN || 0 || NaN. First, NaN || 0 evaluates to 0. Then, 0 || NaN evaluates to NaN.

  • NaN === NaN is always false: Because of the unique nature of NaN, it's never equal to itself. Number.isNaN(NaN) is the proper way to check if a value is NaN.

Therefore:

let x = NaN;
console.log(x || 0 || x); // Output: NaN

console.log(x === (x || 0 || x));  // Output: false

Example to demonstrate:

let x = NaN;

let result = x || 0 || x;

console.log(x === result); // Output: false

console.log(Number.isNaN(x));     // Output: true
console.log(Number.isNaN(result));  // Output: true

Why does this happen?

JavaScript's || operator uses short-circuit evaluation. It stops evaluating once it finds a truthy value. However, since NaN is falsy, the entire expression needs to be evaluated, and the result can be different from the original value if there is any other value.

In summary:

The expression x || 0 || x will be different from x only when x is NaN. In all other cases (where x is not NaN), x || 0 || x will be equal to x. If x is any other falsy value like 0, null, undefined, '', the expression will evaluate to that falsy value.

fossil inlet
knotty musk
#

why gemini

fossil inlet
#

while nan would be an issue

knotty musk
#

why

fossil inlet
#

there could be other minor ones too

austere talon
#

I think it would know

knotty musk
#

all options are better than gemma

austere talon
#

Personally i can't think of anything

odd heath
#

isnt that an O and not a 0

#

or asm i stupid

austere talon
#

no it's a zero

fossil inlet
#

slashed zeros my beloved

image.png
fossil inlet
austere talon
#

react doesn't know it's y || 0 || y

#

react just gets y

fossil inlet
austere talon
#

what?

#

oh is it an O not a 0

fossil inlet
austere talon
#

your theme is goofy

#

i mean then it makes sense

fossil inlet
austere talon
fossil inlet
austere talon
#

the original one.

#

In the useState

odd heath
#

Capitalisation prolly

fossil inlet
#

(colored as a constant)

austere talon
#

insane

fossil inlet
austere talon
#

yop

fossil inlet
austere talon
#

nop

fossil inlet
odd heath
fossil inlet
odd heath
#

i searched for the text and then the intl key and that got me to the lazy module iirc

fossil inlet
#

in 347475

odd heath
#

oo

#

thx

#

ill have a look later

#

uuuuh

#

?remind 3h

shut vineBOT
#

Alright @odd heath, in 3 hours: …

odd heath
#

surely im not hgih anymore then

fossil inlet
odd heath
#

oh fair

#

yeah maybe i need to improve my methods of finding shit 😭

#

thanks tho

fossil inlet
odd heath
#

yeag fair

charred monolithBOT
charred monolithBOT
#
GHAbdenouR
[Vendicated/Vencord] Issue opened: #3345 [Bug] <title>ShowMeYourName not working

What happens when the bug or crash occurs?

ShowMeYourName not working

What is the expected behaviour?

ShowMeYourName not working

How do you recreate this bug or crash?

ShowMeYourName not working

Errors

Replace this text with your crash-log.

Request Agreement

  • [x] I am using Discord Stable or tried on Stable and this bug happens there as well
  • [x] I am a Vencord Developer
knotty musk
charred monolithBOT
odd heath
#

Lowkey I'd build a new Internet personality if I did that 😭

glass jasper
jolly egret
#

i expect it to not work, please close the PR that fixes this

shut vineBOT
#

@odd heath, <t:1743625614:R>: …

opaque silo
fossil inlet
opaque silo
#

HUSSKKK

granite wharf
#

irc colors seem to have broken

fossil inlet
granite wharf
#

goodgood

charred monolithBOT
odd heath
charred monolithBOT
odd heath
#

yeah

#

i wanrted to change that agane but forgor

fossil inlet
#

tbh you could prob just match off the triple or

#

*in the use state call

odd heath
#

yeah

#

ill do that

glass jasper
odd heath
#

would need video

#

and i cba

fossil inlet
odd heath
#

love

charred monolithBOT
vivid garden
#

i am going to shake someone at github if it keeps changing my pr base to main when i select the dev branch

granite wharf
#

both work technically

glass jasper
#

First photo looks better tho

granite wharf
#

oh its a setting it seems

#

i mean idk

charred monolithBOT
glass jasper
scenic brook
#

Not if you want it to work suffoMischief

brazen bone
#

Correctly spelled properties are usually better than wrongly spelled ones

#

Just my subjective opinion

glass jasper
#

Bruh

#

Typo

#

But still

glass jasper
charred monolithBOT
#
sander1946
[Vendicated/Vencord] Issue opened: #3348 [QoL] Proposed UI fix for betterFolders sidebar

Content

Hello,
I use Better Folders on Vesktop, however the sidebar has been moved to the left side since the new discord UI update. I however do not like how it looks. The way it's now the folder expands way above the top of the original guild bar.
I did some digging into the CSS of discord and Vesktop and have added these CSS snippets to my QuickCSS. I would like it to be added to the source code. I looked into adding it myself and creating a pull request, but I could not figure that...

charred monolithBOT
charred monolithBOT
glass jasper
#

F in chat for canary

fossil inlet
charred monolithBOT
charred monolithBOT
fossil inlet
#

from what i can tell its a bundler changeg

#

where terenaries are favored over chained &&s

gritty iris
#

@fossil inlet I fixed the rest of the patches

#

want them for your pr?

fossil inlet
gritty iris
#

alr

opaque silo
#

groupdms are pushed off the screen when theres an activity

image.png
fossil inlet
#

😭

opaque silo
#

yoppp

fossil inlet
#

ill pr that seprately

opaque silo
#

yup

#

too lazy to pr myself

fossil inlet
opaque silo
#

I'm going insane fixing catppuccin for the visual refresh

gritty iris
#

its open sadan

fossil inlet
#

alr

gritty iris
#

some reason it did consolejan as ts so had to redo it 😭

#

I just realized I used the wrong patch for consolejan

fossil inlet
#

WHY IS THIS ALL ONE LINE

image.png
gritty iris
fossil inlet
#

you love github extension shitting itself when trying to add a review

gritty iris
#

real 😭

fossil inlet
#

(iirc its two off by one errors)

gritty iris
#

dumb that down :)

charred monolithBOT
fossil inlet
#

@dusk blaze @dusk blaze

odd heath
brazen bone
fossil inlet
brazen bone
#

I've tried to make a decompiler, but it's surprisingly hard

#

All those optimizations compound in ways that are difficult to untangle

fossil inlet
#

i was working on a vscode extension for vencord

#

and got pretty far

#

but havent worked on it in a bit

brazen bone
#

Nah, properly decompiled code is so much easier to read, when the decompiler doesn't just crash

fossil inlet
#

ive considered making something that transpiles the (0,r.jsx)(...) to actual jsx syntax

#

that should be pretty easy tho

brazen bone
#

The difficult thing about that is that lowercase identifiers are treated weirdly in jsx

fossil inlet
brazen bone
#

Most, yes

fossil inlet
#

and it doesnt matter that much in the end because it would just be to read

#

not to actually run

brazen bone
#

But yeah jsx is one of the easier parts to decompile

#

Comma misuse and ?. operator are much harder, but imo more important

fossil inlet
#

that comes in handy a lot more

brazen bone
#

Renaming all variables to unique names is also helpful

fossil inlet
brazen bone
#

Yeah that's also useful, but be careful about duplicates

fossil inlet
#

tbh shouldn't be that hard

#

i can just filter by all identifiers available in that scope

austere talon
#

should we declare canary and ptb unsupported?

#

official support would only be stable

you will still be able to install to canary & ptb but it will warn you that it's not supported and you should use stable unless you really know what you're doing

fossil inlet
#

They break too often.

#

The only thing I can think of is that a lot of people use all three on desktop at the same time.

#

to manage multiple accounts at once

#

But you can just use multiple chrome profiles for that.

austere talon
#

what's causing the crashes?

#

need to fix that and push before it hits stable

fossil inlet
austere talon
#

why not make the entire pr compatible

gritty iris
#

they broke another one

fossil inlet
#

loveeee

gritty iris
#

since I last looked at least

fossil inlet
austere talon
#

then yes i guess

fossil inlet
#

because rn it just error boundaries

austere talon
#

guhh what plugins dont have error boundaries

#

we really need to do what i mentioned once

#

deliberately make all webpack searches fail

#

then see what causes crashes

#

and fix it

fossil inlet
austere talon
fossil inlet
austere talon
#

do you mean settings component?

fossil inlet
austere talon
#

so yes settings component

#

because that only gets rendered when you open the plugin popup

#

there is little point handling that error

odd heath
#

why does vesktop not suppress this lmao 😭

austere talon
#

it does

grave mangoBOT
austere talon
austere talon
#

you might crash once but then you know not to open that

#

so there is no real issue

#

no point handling that crash

odd heath
fossil inlet
#

it would allow the other ones to be edited

gritty iris
#

they removed =3]

fossil inlet
#

i booted up windows just before that happened to play a game of val 😭

#

ill fix it after i boot back into linux

gritty iris
#

okay

fossil inlet
#

dw, we're getting fucked 😭

image.png
gritty iris
#

wasnt sure if you read it 😭

charred monolithBOT
odd heath
#

actually

#

gimme a secc

glass jasper
#

Something where all you have to have is a token and then you can easily switch between accounts

#

Shit I do it with Ripcord, Got like 4 diff accounts on it

fossil inlet
glass jasper
#

Still works and if your in the right community Cancel is well trust and liked person

fossil inlet
#

thats not the point

glass jasper
#

Plus, only the main stuff is closed source the patches and the extender is open source

fossil inlet
#

again, not the point

glass jasper
#

Mb

#

Close source = Bad

#

Forgor

fossil inlet
#

nop

#

not always

#

but in this case, id say so

glass jasper
#

Idc anymore

#

Agree with the hive mind

charred monolithBOT
fossil inlet
#

guhh

#

thanks github

jagged cloak
#

guhhub

jagged cloak
#

||april fools||

fossil inlet
opaque silo
fossil inlet
opaque silo
#

why have the error

fossil inlet
#

uhhhhhhhh

charred monolithBOT
austere talon
#

that pr doesnt prevent it from crashing again in the future

#

@fossil inlet

fossil inlet
austere talon
#

okay i fixed

#

the old hacky error prevention broke cause the api was changed without changing that location

#

so the old checks didnt work

charred monolithBOT
austere talon
#

vtest dev

nimble pendantBOT
fossil inlet
austere talon
#

edit webpack.ts -> find

#

change its code to return null

#

profit

fossil inlet
#

?remind saturday

shut vineBOT
#

Alright @fossil inlet, in 1 day: …

nimble pendantBOT
# austere talon vtest dev
Discord Canary (386206)
Bad Patches

NewGuildSettings (had no effect):
ID: 447543
Match: ```
/INVITE_ACCEPT_SUCCESS.+?,(\i)=null!==.+?;/


**__CustomIdle (had no effect):__**
ID: `517100`
Match: ```
/(setInterval\(\i,\.25\*)\i\.\i/

NSFWGateBypass (had no effect):
ID: 598077
Match: ```
/(?<=.nsfwAllowed=)null!==.+?(?=[,;])/


**__NSFWGateBypass (had no effect):__**
ID: `598077`
Match: ```
/(?<=\.ageVerificationStatus=)null!==.+?(?=[,;])/

ConsoleJanitor (errored):
ID: 109117
Match: ```
/console.log("AppCrashedFatalReport: getLastCrash not supported.");/

Error: ```
Unexpected strict mode reserved word

ConsoleJanitor (errored):
ID: 405826
Match: ```
/\i.error("".concat(\i," is not a valid locale."));/

Error: ```
Unexpected strict mode reserved word

IrcColors (had no effect):
ID: 421399
Match: ```
/(?<=className:\i.username,style:.{0,50}:void 0,)/


**__ShowMeYourName (had no effect):__**
ID: `421399`
Match: ```
/(?<=children:)\(\i\?"@":""\)\+\i(?=,|\})/

MessageLogger (found no module):
ID: -
Match: ```
THREAD_STARTER_MESSAGE?null===

Slow Patches

OverrideForumDefaults (took 5.1ms):
ID: 131704
Match: ```
/getDefaultSortOrder(){/

Bad Webpack Finds 
mapMangledModule("POSITIVE=3]="POSITIVE", {
	HelpMessageTypes: (m) => props.every((p) => m[p] !== void 0)...,
	HelpMessage: (m) => {
            if (typeof m !== "function") return false;
            return stringMatches(Function.prototype.toString.call(m), parsedCode);
...
})
nimble pendantBOT
# austere talon vtest dev
Discord Stable (385936)
Bad Patches

IrcColors (had no effect):
ID: 421399
Match: ```
/(?<=className:\i.username,style:.{0,50}:void 0,)/


**__ShowMeYourName (had no effect):__**
ID: `421399`
Match: ```
/(?<=children:)\(\i\?"@":""\)\+\i(?=,|\})/
austere talon
#

i hate when i build reporter build to test plugins and now I have fucking ctrl enter send enabled

#

AND NO SERVER EMOJIS

fossil inlet
#

yop

#

thats why i almost never build reporter

austere talon
#

i will release browser rn

#

i would rather have browser have some plugins broken for a bit than have it crash

fossil inlet
austere talon
#

who cares

fossil inlet
#

alr

charred monolithBOT
austere talon
#

browser users will cope

fossil inlet
charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New tag created: v1.11.8
austere talon
#

thank u

#

NOW I NEED TO HOP OFF REPORTER BUILD

#

ATROCIOUS

fossil inlet
#

np

i keep getting burnt out from spotify dev and vencord so i keep bouncing bewteen the two toll

austere talon
#

cause loading all chunks moment

fossil inlet
#

?remind sunday make userpluign to make ctrl-enter-send defaults sane on reporter build

shut vineBOT
#

Alright @fossil inlet, in 2 days: make userpluign to make ctrl-enter-send defaults sane on reporter build

austere talon
#

just disable that plugin on reporter Trollfac

fossil inlet
austere talon
#

yeye

#

i meant like

#

make a userplugin that just disables it

fossil inlet
#

thats even more insane

#

you want the patch to run, but you dont want it to actually do anything

sterile oak
hollow musk
#

vext

nimble pendantBOT
glass jasper
#

Prolly wouldn’t be for a few days

#

vext

nimble pendantBOT
median rapids
jagged reef
#

vext

nimble pendantBOT
median rapids
#

just do it for canary

jagged reef
#

Alright team, it's time to push this into the market at full velocity 🚀. No more waiting around ⏳ or second-guessing 💭—let’s execute flawlessly 🎯, break through the barriers 💥, and get this live 🌍. We've optimized ⚙️, we've iterated 🔄, and now it's time to ship it 📦. Let’s make this happen and drive real impact 💡—full throttle ahead! 💨🔥

median rapids
#

sounding like my eng principles professors

glass jasper
median rapids
#

not abandoned, it gets native updates earlier sometimes

glass jasper
median rapids
#

ya

#

new electron vers usually

glass jasper
#

Cool

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
limber skiff
#

I can do some reviewing and merging today

#

what is left to do for the latest changes?

#

sorry for the inactivity rn, been busy with irl and other things

#

they hit with the refresh in a not so good time wires

charred monolithBOT
austere talon
#

that find is fine actually it's nowhere else (and no reason to be) xD

charred monolithBOT
limber skiff
#

seems so easy to be in another place

austere talon
#

you can make them compatible if u really want but it's not that important

limber skiff
#

ahh, I see

#

I'll try it then, once I'm home

#

question, are we fixing things for Visual Refresh with old UI in mind or ignoring it?

scenic brook
#

I think general consensus has been just ignoring it

scenic brook
limber skiff
#

yeah I saw that

fossil inlet
#

From what I can tell, that is the only that is broken on stable, and that is a change in a constant from 25 to 30 iirc

austere talon
#

if it's more effort then fuck old ui

#

discord themselves already broke old ui

#

pointless for us to bother supporting it then it's 0.1% of users

limber skiff
#

yeah

#

the member list is fucked in some channels

#

for old UI

fossil inlet
#

didnt someone make a css snippet to fix that

#

i tried looking into what caused that, but gave up after 2 hours with no progress

charred monolithBOT
fossil inlet
#

irc colors broke again

#

wonder if just reverting fix would work, dont have time rn to test that

jolly egret
#

the breakages hit stable

#

CC @fossil inlet

fossil inlet
#

But good news is that the crash fixes have already been pushed and tagged

austere talon
jolly egret
fossil inlet
#

vext

nimble pendantBOT
fossil inlet
#

cursed IIFE

#

no way that takes less chars than just inlining Q in the terenaries

and i think inlining Q gives the exact same result

#

no matter what

brazen bone
#

Yeah putting Q in the ternary would allow removing the {} and return

fossil inlet
charred monolithBOT
charred monolithBOT
austere talon
#

I mean it works cause it essentially acts as a noop in that case

#

it just makes no sense

fossil inlet
#

yea

#

when i read that i thought for a moment, then realized that if it was what i thought it was, it would be erroring

austere talon
#

else I'll fix it

#

oh u fixed

fossil inlet
#

yop blobcatcozy

austere talon
#

github loves breaking their shit

#

github had flawless dynamic updates

#

now they broke it so hard

#

even ctrl + r didnt update

fossil inlet
#

weird, it's always worked great for me

austere talon
#

do u have new ui

fossil inlet
charred monolithBOT
desert cosmos
#

horrible

charred monolithBOT
austere talon
#

you love

austere talon
#

nop dont use pure lookbehind too cursed

fossil inlet
#

oh

#

i need to fix betterfolders rq

austere talon
#

to that pr?

fossil inlet
#

no

#

that makes no sense

#

just been meaning to finish the better folders pr for a bit now

i know how, just havent had the time

austere talon
#

so merge?

charred monolithBOT
fossil inlet
austere talon
#

what did they cook anyway

#

why did their bundler change a bunch of shit from === to ==

#

so insane 😭

charred monolithBOT
austere talon
#

vtest dev

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
fossil inlet
fossil inlet
#

peace at last

austere talon
#

how do u disable experiment with code

#

i wanna force disable deep links on web

#

discord so insane

fossil inlet
austere talon
#

i'll patch instead probably

fossil inlet
austere talon
#

do you already use that

glass jasper
#

Imma delete that message now

austere talon
#

why

glass jasper
#

Because you husked

#

Idk if that’s proper too

glass jasper
charred monolithBOT
austere talon
#

cause .vesktop

dusk blaze
#

the experiment i mean

austere talon
#

when you open shop or various other tabs

fossil inlet
austere talon
#

you have to reload to get out of there

dusk blaze
#

insaneee

fossil inlet
#

unless they changed it

dusk blaze
#

i'll assume this happens on all web clients

austere talon
dusk blaze
austere talon
#

discord loves breaking their web app

versed fern
#

i had that happen and i just put window.location = "https://discord.com/app" in the console to fix it

austere talon
#

anything to make you use their desktop app

dusk blaze
#

why would they

#

it's not like you lose many features on web 😭

charred monolithBOT
fossil inlet
#

@austere talon better folder fixes are sane now

austere talon
#

love

charred monolithBOT
austere talon
#

old code was 3x repeated code and reimplement something in utils (plugin older than that util and was never updated)

#

so I refactored the code

fossil inlet
austere talon
#

before it was just the same command boilerplate 3 times

#

we need to make settings ux better

#

add some visualisation for commands to better highlight them

fossil inlet
#

GUHHHH HOW DID THIS NOT GET CAUGHT

austere talon
#

how

#

oh do u mean Decor

#

I discarded your changes to that file

#

the plugin shouldn't handle that

#

oh nvm not decor

fossil inlet
austere talon
fossil inlet
#

did you discard a fix wires

austere talon
#

where even is that

austere talon
fossil inlet
#

yea

#

im curious how that didnt show in the reporter

austere talon
#

lazy loaded?

fossil inlet
#

maybe

austere talon
#

not loaded for u but reporter loads it

#

epic lint fail on ur pr

#

you love

fossil inlet
charred monolithBOT
fossil inlet
fossil inlet
# fossil inlet

nevermind, i swapped to an out of date branch and didnt notice somehow blobcatcozy

#

cant repro now

austere talon
#

GUHHHHHHHH

image.png
fossil inlet
#

if it doesnt work, i think that's just a skill issue

jolly egret
#

gg vee is a bot

fossil inlet
charred monolithBOT
austere talon
#

idk why the last one is spazzing out

charred monolithBOT
fossil inlet
#

/ have them in some constant

austere talon
#

looking at PR
hmm this is surely outdated let me merge latest dev
nuckyz jumpscare

image.png
charred monolithBOT