👾-core-development

[golden gulch]

that said if someone is interested we'd both support it all the way and can provide the tooling and information that would be needed for it

[austere talon]

apparently i already created a chrome web store api key 5 years ago

[limber skiff]

actually

that's for the pr right?

then there is no function for it

[jolly egret]

huh?

[limber skiff]

you are asking for my review correct?

[jolly egret]

yeah you told me to rename what i added and migrate the existing setting

[austere talon]

bro

[limber skiff]

leave the rename of the existing setting for me

[fossil inlet]

all paths lead to scraping

[jolly egret]

aight

[odd heath]

nuckyz will review my small and totally not 1450 line pr

[fossil inlet]

youtube slop

https://www.youtube.com/watch?v=jIOHUfAKiNQ

350 views 😭

[long stream]

why do u need ai for scraping 😭

how can u not know how to use something like puppeteer

[jolly egret]

looks fine or should i not change the Settings.plugin to settings.store?

[fossil inlet]

this should do what you want

git rev-list --ancestry-path $(git describe --tags --abbrev=0)..HEAD

[austere talon]

$ext

[frozen knot]

1.11.2

[austere talon]

fire

[odd heath]

Re

fckign

email reply

[dusk blaze]

Fake version…

[fossil inlet]

what does it reply if it doesnt match

[dusk blaze]

new role so good…

[golden gulch]

also as a side note since the removal of usrbg as a built in plugin was mentioned (even though vee said to keep it I figure this is worth mentioning) - based on the very loose stats cloudflare gives me it has ~2.3 million monthly users and I would politely request to not deal with having to tell that many people that the plugin was removed

(also hi i'm back i just needed a quick break from discord due to stuff™️)

[limber skiff]

yes thats fine

[jolly egret]

its DOOMED

[fossil inlet]

you will use ssh

[austere talon]

we will remove the plugin and add a notice to dm or ping you if users have any questions regarding the removal

[dusk blaze]

you will ssh sign NOW

[jolly egret]

boring

[golden gulch]

[jolly egret]

i've always done it this way

[austere talon]

or better yet

[jolly egret]

let me just fix my shit

[limber skiff]

fair enough haha

[fossil inlet]

that means its working

[dusk blaze]

katlyn will die of trillions of users dming

[austere talon]

Unfortunately, we had to remove the Usrbg plugin due to legal reasons. For any questions, please email [your email here]

[fossil inlet]

[e-mail]

[golden gulch]

fear

[fossil inlet]

@swift fjord soon

[limber skiff]

we are gonna add the Vencord changelog modal just to show that message

[fossil inlet]

add it to support helper

[limber skiff]

and explicitly highlight katlyn email

[jolly egret]

it works fine if i install gcr 👍

changes pushed

[limber skiff]

someone stole my regex!!

[swift fjord]

if i start getting support emails then im ddosing vees vps

[jolly egret]

do it anyway

[austere talon]

$ext

[frozen knot]

The extension is up to date! (v1.11.2)

[austere talon]

no lol

[limber skiff]

alright I will review tomorrow again or something

[jolly egret]

cool

[limber skiff]

I'm feeling tired now

[jolly egret]

all good

[limber skiff]

you did it super similar lmaooo

https://tenor.com/view/my-reaction-to-that-information-my-honest-reaction-cat-silly-cat-gif-26999062

(also dont get it wrong I'm not complaining)

[austere talon]

i pushed

vextversion

[nimble pendant]

The Vencord Chrome Extension is up to date! (v1.11.2)

[limber skiff]

hugee command

[austere talon]

surprisingly easy

[jolly egret]

the days are gone of opening it myself and scrolling down

[limber skiff]

ngl

regex way easier than using a scraper

[austere talon]

yeah lmao but less stable

[limber skiff]

doubt it will break

[austere talon]

in this case yeah

but good luck scraping something more complex with pure regex

[limber skiff]

yeah

[austere talon]

like trying to scrape products from amazon or smth

[limber skiff]

have you tried that before

😛

[austere talon]

[austere talon]

especially with stuff that has many moving parts

like optional nodes

basically impossible to parse with regex

[limber skiff]

omg can we have that discord fixes plugin and fucking change this to a proper flex component

it's so bad to align those

and always feel un-aligned

[fossil inlet]

vext

[nimble pendant]

The Vencord Chrome Extension is up to date! (v1.11.2)

[fossil inlet]

[limber skiff]

the fact this is a span

is so dumb

[fossil inlet]

jsdom

[austere talon]

inb4 someone spams this and gets me rate limited from google webstore

[jolly egret]

vexplode

[fossil inlet]

i wonder if its possible to easily route a single connection through open vpn/wg

[austere talon]

@limber skiff what do you think about how we should store the favicon pngs for vencord code

[odd heath]

pasting into console rn

[austere talon]

cause of csp update we can't fetch them directly from all sites anymore (without whitelisting all of them (nope 😭)) but both google and ddg favicon api fail to fetch one of the sites' icons

[limber skiff]

just do static.vencord.dev if that doesnt explode vencord servers

as for third party builds of vencord, they can modify the csp for it...

[austere talon]

so you think we should make our own cdn

also no it wouldn't explode

we just need to give images unique filenames (hashes) and we can make cloudflare cache them for an entire year

so cloudflare takes 99% load

that's how I serve badges

[limber skiff]

I think so yes, we need a proper way to store stuff thats not github or remote fetch or random cdn or even Vencord repo

however hmm

im not sure how plugin dev would be like that

would have to manually request or something

[austere talon]

i was actually working on smth like that in the past

you upload file to discord and venbot optimises it and automatically pushes it to git repo

https://github.com/Vencord/plugin-assets

venbot still has code for that iirc

but it was kinda bad

[limber skiff]

I swear im having to click github links 3 times for them to open

so weird

[austere talon]

SAME

[fossil inlet]

only happens for me after the initial link

[limber skiff]

after it opens once it's normal

but before that

https://github.com/Vencord/Companion

[austere talon]

the only annoying thing about csp update is that you won't be able to fetch() random sites

[austere talon]

i had to click twice

[limber skiff]

yeah literally

I clicked it

didnt open

[austere talon]

https://github.com/torvalds/linux

[fossil inlet]

isnt there a way for plugins to whitelist urls?

[limber skiff]

that one opened instantly for me

[austere talon]

i love chrome logging this every time discord fetches any image

[fossil inlet]

prob cached

[austere talon]

guys i think chrome might be moving towards a new experience that allows users to choose to browse without third-party cookies.

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3087 EmoteCloner: Fix a hang when the sticker/original server is deleted

Vendicated

[Vendicated/Vencord] New review comment on pull request #3087: EmoteCloner: Fix a hang when the sticker/original server is deleted

extract the fake sticker into a separate function and call it inline for nicer code

                return buildMenuItem("Sticker", () => fetchSticker(favoriteableId).then(s => s ?? buildFakeSticker(sticker));

Vendicated

[Vendicated/Vencord] New review comment on pull request #3087: EmoteCloner: Fix a hang when the sticker/original server is deleted

why is this needed? we already check favoriteableId above, and that's all we need

Vendicated

[Vendicated/Vencord] New review comment on pull request #3087: EmoteCloner: Fix a hang when the sticker/original server is deleted

		return null;
    }

Vendicated

[Vendicated/Vencord] New comment on pull request #2732: Add plugin toggling to venbot embeds

maybe instead of completely replacing the original message, we could instead add the plugin card as Accessory? So the message will have both

please also resolve conflicts 🙏🏻

[rugged spire]

yes i make bad PR titles

i had the opposite thought for some reason, i wouldn't expect the dots to stop click propagation
especially when it's in dots only mode

[rugged spire]

please also resolve conflicts 🙏🏻

[austere talon]

i was in the process of doing it but

it's a lot

and i dont wanna break their code

@fossil inlet for ur showconnections pr

it's kinda meh to make an entire custom compoennt

you could just add some more props to the slider settings type

to only allow precise ints

[fossil inlet]

nop

tried that

[austere talon]

wdym tried that

[rugged spire]

just make it number of rows

[fossil inlet]

how do you calculate that

[austere talon]

like buttons or wtf

[fossil inlet]

because the size of the icons and margins can vary

and i dont think the profile size is constant

(if it was, id calculate it)

[fossil inlet]

i assume you mean pass extra props to the slider via component props

[rugged spire]

AAAAAAA I see why you say that it's not that simple

[austere talon]

i mean update the settings component to allow you to control this via behaviour

[fossil inlet]

what does that even mean

[austere talon]

edit the settings slider component

to add props

to control this behaviour

[fossil inlet]

ah

[limber skiff]

oh uhmm

I see

vcotd

[nimble pendant]

The cozy of the day is fire! (#aa4203)

[limber skiff]

that is NOT fire

[rugged spire]

UX design is hard

[fossil inlet]

[austere talon]

it is fire

[limber skiff]

yesterday cotd was so good

[austere talon]

lc.gem fire color hex code

[rancid idol]

fire color hex code

The hex code for a common fire color is #AA4203.

This represents a vibrant and intense orange.

Keep in mind that fire can have a wide range of colors, from yellow and orange to red and even blue or green in specific conditions.

Gemini • Gemini may display inaccurate info, so double-check its responses.

[limber skiff]

I might steal and put my color as that hehe

[rugged spire]

who wants to watch me add size 20 avatars

to both of those plugins

[limber skiff]

show screenshot

I'm in my phone

[rugged spire]

users will immediately notice though

[charred monolith]

nakoyasha

[Vendicated/Vencord] Pull request review submitted: #3087 EmoteCloner: Fix a hang when the sticker/original server is deleted

nakoyasha

[Vendicated/Vencord] New review comment on pull request #3087: EmoteCloner: Fix a hang when the sticker/original server is deleted

it's needed because of the incompatibility with the plugin mentioned in the comment, it results in this without the check:

it's a niche case, but i wanna be safe in case the issue exists elsewhere too

[limber skiff]

damn

so ugly

[charred monolith]

sadan4

[Vendicated/Vencord] Issue opened: #3164 [Bug] TypingIndicator: User popout unrenders, even when focused, after all users stop typing

Discord Account

No response

What happens when the bug or crash occurs?

the user popout profile vanishes even if it was in use

What is the expected behaviour?

i expect clicking the users avatar to do nothing or for the popout to stay even after all users have stopped typing

How do you recreate this bug or crash?

1. click on a users avatar in a typing indicator
2. start doing some...

[fossil inlet]

that bug has annoyed me for a while now

[rugged spire]

[fossil inlet]

i think its a side-effect of how discord renders their popouts

not sure

[limber skiff]

sadan why 😭

[rugged spire]

Yes

[fossil inlet]

it annoys me

[limber skiff]

sqaa pr is literally to avoid that

[rugged spire]

nope

[fossil inlet]

nop

[limber skiff]

to make clicking do nothing

[fossil inlet]

something else (i think)

[rugged spire]

different issue

[limber skiff]

huh

[fossil inlet]

😭

[limber skiff]

I still don't understand what your pr fixes then

[rugged spire]

clicking the avatar or pressing space/enter in the message box inside of the popout will switch to that channel

[limber skiff]

ah

I get it

[fossil inlet]

keypresses in user popouts would bubble up to their parrents, triggering them

@rugged spire is that right

[rugged spire]

Yop

also just to make you feel even more

[limber skiff]

it might not be fixable honestly

unless they have a prop to control it in Popouts

[fossil inlet]

i think it should be if theres a way to detect if a popout is open

[limber skiff]

it's just how their Popout component works

if there is no prop to control then rip

[rugged spire]

i will leave a painful comment on that issue

[limber skiff]

implementing Popouts from scratch would not be a solution

[fossil inlet]

i could be crazy but i remember a popout ref

[fossil inlet]

im not that crazy

[limber skiff]

hmm

[rugged spire]

Good News: the comment isn't going to be that bad

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] New comment on issue #3164: [Bug] TypingIndicator: User popout unrenders, even when focused, after all users stop typing

this would probably require reimplementing a small portion of UserSummaryItem
it actually doesn't seem quite hard to do tbh

maybe we could just patch the component?

[limber skiff]

bad news there is no way to avoid it

[limber skiff]

nop

[rugged spire]

what do you mean nop

[limber skiff]

when you click a user it uses the Popout component... to create the popout

and when that component is unmouted it dispatches a popout close

[rugged spire]

it looks like it just involves replacing looking up the user from the users prop

The component is never unmounted

nvm

it is

time to play around with it!

[limber skiff]

that's called on unmount of the Popout

[rugged spire]

all we need to do is just not unmount the component? or how horrible is this idea

[fossil inlet]

is there a way to do that in react besides rendering something with display none

[limber skiff]

that's just not doable

[rugged spire]

what is this then

[limber skiff]

re-implement the user component to render null but keep the popout

[rugged spire]

i mean the usersummaryitem btw

[limber skiff]

which means you are creating components which just keep stacking

[fossil inlet]

you underestimate my horrorcode

[limber skiff]

and never disappear

[rugged spire]

i figured out that idea doesnt work how you think it would

my testing is going well

i did it

[glass jasper]

push to main

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] New comment on issue #3164: [Bug] TypingIndicator: User popout unrenders, even when focused, after all users stop typing

forget all of that. I have a working prototype now.

How it works:
remove the if (typingUsersArray.length > 0) condition so the component always renders
add that condition to the Dots indicator mode condition

Sqaaakoi

[Vendicated/Vencord] New comment on issue #3164: [Bug] TypingIndicator: User popout unrenders, even when focused, after all users stop typing

MY GLORIOUS HORRORCODE

<details>

    // if (typingUsersArray.length > 0) {
    return (
        <Tooltip text={tooltipText!}>
            {props => (
                <div className="vc-typing-indicator" {...props}>
                    {((settings.store.indicatorMode & IndicatorMode.Avatars) === IndicatorMode.Avatars) && (
                        <div
                            onClick={e => {
                                e.stopPropagation();
                         ...

[rugged spire]

github destroys it

insane

[fossil inlet]

git format-patch in shambles rn

[rugged spire]

no github's markdown html renderer just explodes the codeblock formatting if its inside of html

[fossil inlet]

i cant apply a codeblock

[rugged spire]

?remindme 1d pr this mess

[shut vine]

Alright @rugged spire, in 1 day: pr this mess

[rugged spire]

unless i should put it in the existing PR

idk

[fossil inlet]

which one?

[rugged spire]

the one to fix events bubbling to clickable components

[fossil inlet]

depends how cursed this fix is

[hollow musk]

hey guys, so @fossil inlet said [here](#1331976527545368646 message) that I can consider PR-ing my theme it to fix Client Theme not working with Visual Refresh. The issue is that I have no idea where to add the CSS in the typescrcipt file (i do know that the file to change is src\plugins\clientTheme\index.tsx but now how). Do I ask for help here or in #🧩-plugin-development?

[rugged spire]

what is your fix

is it something that's generated

or is it static (put it in clientTheme.css)

[hollow musk]

static

it just takes the variables set by client theme

[fossil inlet]

import "./REPLACE_WITH_FILE_NAME.css"

[rugged spire]

there is already a file for it

just put it in there

[fossil inlet]

ehhh, might be better to keep them separate

[rugged spire]

maybe?

[fossil inlet]

doesnt matter that much tho

[hollow musk]

oh so thats it?

[fossil inlet]

ITS BACK

[rugged spire]

probably your userscript manager

going insane

[hollow musk]

NSPC911/Vencord @f6c5fd8
can yall tell me if this is good

[charred monolith]

Scyye

[Vendicated/Vencord] New comment on pull request #3163: New plugin: ViewMembersWithRole

What's the use case?

[fallen vale]

@fossil inlet am i missing something obvious or?

[fossil inlet]

yea, the plugin has a clear use

eg: use permission viewer to see what role has a certain perm

use this role to find users with that perm

[limber skiff]

the plugin shouldnt hardcode the css

[hollow musk]

how to then?

[fossil inlet]

@hollow musk did you generate that with a script or handwrite it

[hollow musk]

took from original css, used regex to find and replace

[hollow musk]

but anyways, the css changes based on the selected color automatically with the set variables, so it shouldnt cause any issues right?

[sterile oak]

I don't really remember, but I think it's to avoid creating an array than pushing elements to it, I should used map smh

[rugged spire]

oh yeah thats true

[hollow musk]

whats wrong with doing it?

[fossil inlet]

harder to mantain in the future

/make small changes

[hollow musk]

so what exactly should i do?

[fossil inlet]

Well, how did you make the CSS in the first place

I'm assuming the numbers weren't chosen at random

[hollow musk]

there was a css file within the network page that handled the variables for the colors, i downloaded it, removed the uneccessary stuff, did a find and replace with regex and yeah

the numbers werent random, they were chosen by discord

[fossil inlet]

OK, that makes sense

Its 330 am for me

[hollow musk]

i forgot to disable anonymisefilenames

[charred monolith]

programminglaboratorys

[Vendicated/Vencord] New comment on pull request #2447: new api: ExpressionPickerTabsAPI

Recently we got shortcuts in the plugins definition to use most apis, this one should add those shortcuts too

look at renderChatBarButton for an example

I was not able to find renderChatBarButton, can you explain those new changes and what am I required to do?

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] New comment on pull request #2447: new api: ExpressionPickerTabsAPI

Recently we got shortcuts in the plugins definition to use most apis, this one should add those shortcuts too
look at renderChatBarButton for an example

I was not able to find renderChatBarButton, can you explain those new changes and what am I required to do?

Instead of plugins calling the API in their start/stop methods, plugins should have a property with metadata about the tabs they will add

Take a look at #3028 where this was implemented for all the other APIs

De...

[scenic brook]

Pretty sure this is tampermonkey, it's in their i18n keys on github

[charred monolith]

Masterjoona

[Vendicated/Vencord] New comment on pull request #2732: Add plugin toggling to venbot embeds

fixeddd

[charred monolith]

developer861

[Vendicated/Vencord] Issue opened: #3165 see all media in desktop app

Content

in the mobile app there is an option to see all media sent in a discussion but there is no option in desktop app is there any way to fix it?

Request Agreement

• [x] I have read the requirements for opening an issue above

[jolly egret]

from:@me has:image has:video has:sound

[charred monolith]

nin0-dev

[Vendicated/Vencord] New comment on issue #3165: see all media in desktop app

• This is not a vencord issue
• Search for “has:image in:#whatever-channel-you-want-to-search-into”
• Also not sure how you missed the big warning telling you that the issue form is for developers only. Use the support server for further issues

developer861

[Vendicated/Vencord] New comment on issue #3165: see all media in desktop app

• This is not a vencord issue

  • Search for “has:image in:#whatever-channel-you-want-to-search-into”

  • Also not sure how you missed the big warning telling you that the issue form is for developers only. Use the support server for further issues

sorry didn't see it should i close it?

jamesbt365

[Vendicated/Vencord] New comment on issue #3165: see all media in desktop app

should i close it?

Yes.

[jolly egret]

didn't see
literally 1000 capital letters and warnings telling you to fuck off 😭

you just can't not see you're being intentionally oblivious

[charred monolith]

developer861

[Vendicated/Vencord] Issue closed: #3165 see all media in desktop app

[hollow musk]

so uhh what should i do?

[limber skiff]

attempt to generate

the plugin already does for the old stuff

[charred monolith]

moneerat

[Vencord/Vendroid] New star added

[shut vine]

@fossil inlet, <t:1737766685:R>: right-click to clear filters in members tab

[limber skiff]

this command is always so slow to run for the first time

I'm not sure why

[austere talon]

[limber skiff]

I did something

this didnt work tho LMAOOO

horribl

[dusk blaze]

because vee is insane

starting a node script takes a second or two

vencord has pnpm dev -> pnpm watch -> pnpm build —watch -> build.mjs command

[limber skiff]

why insane then

[dusk blaze]

because it would be doable to put the build.mjs command in all of the above scripts

then youd save some time

[limber skiff]

so you mean running pnpm scripts is slow

[dusk blaze]

the initial start does for some reason

[limber skiff]

shit ass package manager

[dusk blaze]

npm is probably as bad

i was wrong

and bun is soooo fast

[fossil inlet]

Saner than npm

[limber skiff]

bruhh

[somber thorn]

how about deno ​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​

[fossil inlet]

@limber skiff didnt you fix a bug like this a couple of months ago?

[limber skiff]

hm

not for message logger I guess

[odd heath]

How is that even undefined??

[fossil inlet]

something with switching accoutns

i might just check if its undefined and return false if it is

[odd heath]

Horror

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[hollow musk]

but what is there to generate, when the variables do it automatically?

[limber skiff]

generate the variable names

I dont understand why you are asking so much about it

look at the existing code for the plugin and you will realize no variable names is being hardcoded

which means for visual refresh it should do the same

[hollow musk]

im sorry, this is my first time actually modifying vencord's code and i want to do a proper job instead of a half-assed one

wait so i need to modify this part to add the style but not use the variable names and instead use the actual variables in the function right?

[jolly egret]

can i pay just the merge without any review

[austere talon]

yes

it's an all inclusive option

[jolly egret]

yeah but i want just the merge no review i want to merge malware

[glass jasper]

How much money to just be given push access to Vencord for five minutes

[austere talon]

NOP

[rugged spire]

just use AuthenticationStore.getId() instead

[shut vine]

@rugged spire, <t:1737775575:R>: pr this mess

[rugged spire]

later

[hollow musk]

how do i check whether visual refresh is enabled or not?

[fossil inlet]

wdym

you did that in your orig css

just wrap with .visual-referesh (or what ever the class name is

[hollow musk]

yeah but like wouldnt it be better if it injects if visual refresh is enabled instead of just injecting it whether or not it is enabled?

[rugged spire]

not really????

[fossil inlet]

no

[hollow musk]

damn, so no difference in terms of performance?

(like i said, i have no idea what im doing and im slowly learning)

[fossil inlet]

no

generating the css is quick and only happens once

if you generate based on if its enabled, you would have to somehwo listen for when its changed

and re-generate

and if you didnt, people could think client theme is broken when they toggle the experiment

[rugged spire]

the .visual-refresh class is already done for you

[fossil inlet]

this is what matters

@hollow musk tbh if you dont do something within a few days, do you mind if it do it (ill credit you)

[rugged spire]

you may also like :root:not(.visual-refresh)

[hollow musk]

yeah sure, just add me as co-author i guess

[fossil inlet]

id or that or just send you the code

[hollow musk]

?remindme 5d if you didnt finish the fix, tell @fossil inlet to make it

[shut vine]

Alright @hollow musk, in 5 days: if you didnt finish the fix, tell @/home/meow to make it

[shut vine]

@fossil inlet, <t:1737694115:R>: bump a random pr

[charred monolith]

sadan4

[Vendicated/Vencord] New comment on pull request #3125: EmoteCloner: Add new places to clone from

bump

[limber skiff]

why is it lazy 😭

[fossil inlet]

good question

[dusk blaze]

because sadan is lazy

[austere talon]

don't use lazy one horror

lazy is meant for when you need to await a promise (it shows a loading spinner in the context menu)

aka lazy loaded context menus or context menus that need to fetch stuff

if you don't have an await you want to use the normal one

[fossil inlet]

yop

[rugged spire]

guh??????

i've had to implement a lazy context menu and i didn't know thats how the context menu spinner worked

[shut vine]

@rugged spire, <t:1737862048:R>: pr this mess

[rugged spire]

do i make horror merge conflict later or ??

shove it into my existing PR?

[hollow musk]

the more that i look at this, the more i wonder whose ass discord pulled the percentages from

[rugged spire]

Welcome to Discord CSS

it's hu

[hollow musk]

so i made a graph of them

fucking party poopers, i cant even say they are a logarithmic expression now

[hollow musk]

like i cant even vouch for the devs, why is it like this

[fossil inlet]

Try googling the numbers maybe

[hollow musk]

how do i google numbers 😭

[charred monolith]

lolsuffocate

[Vendicated/Vencord] Pull request opened: #3166 Fix top level settings in Vencord tab notifying global listeners

Fix the settings in the Vencord tab not notifying listeners, so switches don't work and changes aren't saved

[scenic brook]

I wondered why my quickcss kept turning itself off every restart

[hollow musk]

i think ill just do some manual work to change the lightness because the colors arent as accurate as normal discord

[limber skiff]

finally we got a bug

@scenic brook thank you for using dev and testing lmao

[scenic brook]

[limber skiff]

I think you should put that in the else though

to not fire multiple times globally for plugin settings change

[scenic brook]

Yeah I thought that might be the case but I didn't know if it was important for it to be fired for both pathStr and settingPathStr

I'll change in a little bit

[limber skiff]

pathListeners should fire for both as they only fire if there are actually callbacks that exist

but globalListeners should only fire once

[scenic brook]

Okay cool

Done

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request closed: #3166 Fix top level settings notifying global listeners

Nuckyz

[Vencord:dev] 1 new commit

87cb1fd Fix top level settings notifying global listene... - lolsuffocate

[limber skiff]

thankss

[long stream]

vencord has about as much testing as discord /j

[austere talon]

nop

I literally said we should merge this into dev only and wait a few days to find bugs

[limber skiff]

should Option.CUSTOM be changed from any, rn it allows stuff like RegExp lmao

[austere talon]

it's fine like this for now

like I already mentioned before we could add serialize & deserialize props so you can store arbitrary data

[limber skiff]

hmm alright

[austere talon]

now you see why I wanted to wait nuckyz

[limber skiff]

yep

[jolly egret]

wanna get my other PR in :3

[charred monolith]

nay-cat

[Vendicated/Vencord] Pull request review submitted: #3096 feat: Fixed bad links

nay-cat

[Vendicated/Vencord] New review comment on pull request #3096: feat: Fixed bad links

Have you managed to test if everything is working properly?

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3125 EmoteCloner: Add new places to clone from

Vendicated

[Vendicated/Vencord] New review comment on pull request #3125: EmoteCloner: Add new places to clone from

this is way too long, one example should be enough and this really should be a gif instead of a video

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3125 EmoteCloner: Add new places to clone from

Vendicated

[Vendicated/Vencord] New review comment on pull request #3125: EmoteCloner: Add new places to clone from

also should probably be above those location lists!

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3125 EmoteCloner: Add new places to clone from

Vendicated

[Vendicated/Vencord] New review comment on pull request #3125: EmoteCloner: Add new places to clone from

no discrimination in my vencord 😠

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3125 EmoteCloner: Add new places to clone from

Vendicated

[Vendicated/Vencord] New review comment on pull request #3125: EmoteCloner: Add new places to clone from

what in the world does this type do? a comment would be useful

Vendicated

[Vendicated/Vencord] New review comment on pull request #3125: EmoteCloner: Add new places to clone from

this should use normal non-lazy openContextMenu

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3125 EmoteCloner: Add new places to clone from

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3096 feat: Fixed bad links

thanks for the changes, that's already better!

Vendicated

[Vendicated/Vencord] New review comment on pull request #3096: feat: Fixed bad links

            const urlRegex = /https?:\/\/\S+/g;

Vendicated

[Vendicated/Vencord] New review comment on pull request #3096: feat: Fixed bad links

            if (matches?.[0] === message.content.trim()) return;

Vendicated

[Vendicated/Vencord] New review comment on pull request #3096: feat: Fixed bad links

            matches?.forEach(url => {
                const hash = h64(url).toString(16);
                translatedContent = translatedContent.replaceAll(hash, url); 
            });

[long stream]

@austere talon don't push yourself too hard pls

[austere talon]

@fossil inlet for ur ShowConnections pr, did you understand what I suggested? (editing the Slider settings component to allow plugins to specify they want full ints)

I can make that change if you don't wanna do it

[austere talon]

24h PR review marathon

gonna do a 24h twitch charity livestream where u can use channel points to redeem PR reviews

[odd heath]

automasting this

[long stream]

😭

[odd heath]

ill just tier 3 sub to get mosdt points trol

[austere talon]

I wanted to rewrite settings from scratch anyway

shit is SO MESSY

[long stream]

xd

[austere talon]

what just adding new code on top of existing code for 2 years without ever refactoring it does to a codebase

[charred monolith]

splatterxl

[Vendicated/Vencord] Pull request review submitted: #3087 EmoteCloner: Fix a hang when the sticker/original server is deleted

nitpicks

splatterxl

[Vendicated/Vencord] New review comment on pull request #3087: EmoteCloner: Fix a hang when the sticker/original server is deleted

could this be some other type than any? like Partial<Sticker> or smth?

splatterxl

[Vendicated/Vencord] New review comment on pull request #3087: EmoteCloner: Fix a hang when the sticker/original server is deleted

is there an enum for this, for clarity?

sadan4

[Vendicated/Vencord] Pull request review submitted: #3125 EmoteCloner: Add new places to clone from

sadan4

[Vendicated/Vencord] New review comment on pull request #3125: EmoteCloner: Add new places to clone from

adds intellisense to properties in the build menu item function, but yeah I'll add a comment

[fossil inlet]

Yea, I just haven't had time yet (family issues)

[austere talon]

oh all good no rush, take as much time as needed

Just making sure we're on the same page

[dusk blaze]

you should start selling pr reviews @austere talon

and guaranteed merges

you’d have to pay monthly to keep the plugin in vencord

[odd heath]

horror

[fossil inlet]

Also, do you want me to change the name Discriminate to something else? I just used it because that's what I copied from another project of mine

[austere talon]

no i was just joking 😭

although

if the name could better describe the function sure

Discriminate doesnt really say a lot

[fossil inlet]

Its called a discriminated union

[limber skiff]

@austere talon https://github.com/Vendicated/Vencord/pull/3157

at least the rest which is not patchWebpack lmaoo

[limber skiff]

if I dont do today I will do tomorrow

[jolly egret]

cool

[limber skiff]

I forgot about it yesterday mbbb

I remembered earlier today

but then I havent got to do stuff yet

[charred monolith]

Nuckyz

[Vencord:patcher-rewrite] 8 new commits

e45b867 ServerInfo: Add Ignored Users tab (#3127) - jamesbt365
7ee70e8 MessageLogger: Make collapseDeleted require a r... - jamesbt365
79cbfe9 HideAttachments, UnsupressEmbeds: Work with for... - jamesbt365
4036fba ConsoleJanitor: Remove old patch and add getLas... - sadan4
aac5242 ImageZoom: Fix incorrectly adding context menu ... - sadan4

[jolly egret]

all good

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[fossil inlet]

@austere talon did discord push an update where you can see invisible users?

[granite wharf]

awful update

[fossil inlet]

Its either that or a bug

[median rapids]

it's a bug on vencord's side

[granite wharf]

vencord creep update...

[charred monolith]

Vendicated

[Vendicated/Vencord] New comment on pull request #2048: Add IrcColors plugin

there's actually one bug I noticed: for people who use the colour dot instead of role name (or use BetterRoleDot), the roledot has the wrong colour

also this doesn't integrate with RoleColorEverywhere which kinda sucks and should be added

In any case, I will just merge this now and we can make these fixe...

Vendicated

[Vendicated/Vencord] Pull request closed: #2048 Add IrcColors plugin

Vendicated

[Vencord:dev] 1 new commit

cf28c65 Add IrcColors plugin (#2048) - jedenastka

[austere talon]

is it tho?

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3105 feat(plugin): VCPanelSettings

Vendicated

[Vendicated/Vencord] New review comment on pull request #3105: feat(plugin): VCPanelSettings

you never unsub also this can probably just be a useStateFromStores

Vendicated

[Vendicated/Vencord] New review comment on pull request #3105: feat(plugin): VCPanelSettings

HOP OFF

Vendicated

[Vendicated/Vencord] New review comment on pull request #3105: feat(plugin): VCPanelSettings

all these components are like the same code

try making one or two generic components and passing the data via props to duplicate way less code

Vendicated

[Vendicated/Vencord] New review comment on pull request #3105: feat(plugin): VCPanelSettings

use defineSettings

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3124 Plugin: FixedForumTags

Vendicated

[Vendicated/Vencord] New review comment on pull request #3124: Plugin: FixedForumTags

alt text should either be meaningful if this image is relevant for blind people, or blank to make this image not be included in screen reader

Vendicated

[Vendicated/Vencord] New review comment on pull request #3124: Plugin: FixedForumTags

            find: '"-all-tags-dropdown-navigator"',

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3124 Plugin: FixedForumTags

[median rapids]

ya this has happened for forever

no idea what causes it tbh

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3124 Plugin: FixedForumTags

Vendicated

[Vendicated/Vencord] New review comment on pull request #3124: Plugin: FixedForumTags

this is very ugly try making this better idk what the code looks like but generally you should try getting some less generic string or token in there

[dusk blaze]

reviewmaxxing…

[median rapids]

stream of consciousness review

[austere talon]

UR CODE IS SO HORROR NINO

bro

you never unsubscribe 😭

after using ur panel a bit there will be 200 subscriptions

[dusk blaze]

guhh i quickly made this because some idiot was willing to pay

i will fix my shitcode

[austere talon]

lmaoo

[fossil inlet]

@austere talon not really a better parch for this. IIRC it's matching a call from another module amongst another call exactly like it

||I could be misremembering or discord could have changed code since then||

[charred monolith]

Vendicated

[Vendicated/Vencord] New comment on pull request #3083: feat(ViewRaw): Add raw option to role

added it here too

Vendicated

[Vendicated/Vencord] Pull request closed: #3083 feat(ViewRaw): add View Role option

Vendicated

[Vencord:dev] 1 new commit

f29662c feat(ViewRaw): add View Role option (#3083) - vishnyanetchereshnya

Vendicated

[Vendicated/Vencord] New comment on pull request #3083: feat(ViewRaw): add View Role option

thank u good idea!

[limber skiff]

this should settings.use on lightness

[median rapids]

v cooking

[charred monolith]

Vendicated

[Vencord:dev] 2 new commits

fc304f5 LastFMRichPresence: Add option to hide presence... - 54ac
91d9c78 simplify code - Vendicated

[austere talon]

omg

wrong thing lol why is git so dumb

it pushed to the wrong place

[median rapids]

not git issue

[charred monolith]

Vendicated

[Vencord] Branch dev was force-pushed to `f29662c`

Compare changes

[austere talon]

yeah its gh cli

i did gh pr checkout 1234

normally it should set up the branch correctly but it didnt

[median rapids]

real

[charred monolith]

Vendicated

[Vencord:dev] 1 new commit

3350922 LastFmRPC: Add option to hide if there is anoth... - Vendicated

Vendicated

[Vendicated/Vencord] Pull request closed: #2866 LastFMRichPresence: Add option to hide presence when any other activity is detected

Vendicated

[Vendicated/Vencord] New comment on pull request #2866: LastFMRichPresence: Add option to hide presence when any other activity is detected

thank you! merged manually

[austere talon]

idk why it's acting up on this pr

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #2889 Feat(plugin): add CopyStatusUrls

Vendicated

[Vendicated/Vencord] New review comment on pull request #2889: Feat(plugin): add CopyStatusUrls

please fix formatting

Vendicated

[Vendicated/Vencord] Pull request review submitted: #2889 Feat(plugin): add CopyStatusUrls

Vendicated

[Vendicated/Vencord] New review comment on pull request #2889: Feat(plugin): add CopyStatusUrls

you can use the copyWithToast util instead

Vendicated

[Vendicated/Vencord] New review comment on pull request #2889: Feat(plugin): add CopyStatusUrls

this is not very robust. it will match the first onClick in the file and then find the next index which can very easily be wrong. you should add some anchor or limit length to ensure you match the right onClick and index

Vendicated

[Vendicated/Vencord] New review comment on pull request #2889: Feat(plugin): add CopyStatusUrls

just get rid of this try catch it's not needed

Vendicated

[Vendicated/Vencord] New comment on pull request #2902: feat(plugin): ShowMeTheMember

okay this definitely needs a better description and or name because the current ones are really vague and I had no clue what this does based on them

This also needs a README! and I think I fixed your conflicts lol

[austere talon]

do

[limber skiff]

I'm bed rn

(me but not angry)

[austere talon]

silly

[limber skiff]

I saw the emoji and didn't realize it was angry lmaooo

[fossil inlet]

love old prs

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #3049 feat: Add donor and contributor cards in vencord settings

Vendicated

[Vendicated/Vencord] New review comment on pull request #3049: feat: Add donor and contributor cards in vencord settings

at this point for consistency you should add regular id to constants as well and remove the comments

Vendicated

[Vendicated/Vencord] New review comment on pull request #3049: feat: Add donor and contributor cards in vencord settings

try just importing the BadgeAPI on the top level it would be cleaner but it might cause an error i don't actually know

Vendicated

[Vendicated/Vencord] New review comment on pull request #3049: feat: Add donor and contributor cards in vencord settings

just inline this

[rugged spire]

will date picker setting be possible now

and not suck

[fossil inlet]

what plugin uses date picker

[austere talon]

i just wanted to merge it for now cause it's already usable and it's been waiting for so long

[rugged spire]

nothing

afaik

it's just a new possibility

[fossil inlet]

husk

[rugged spire]

also so many changes

[austere talon]

i think for PRs we could instead of trying to make it perfect right away merge it first and then add more features later

[fossil inlet]

cant you just serialize date as string

[rugged spire]

so many good features

[austere talon]

so PRs wait less

[rugged spire]

yop

[rugged spire]

I like this

[fossil inlet]

if this happens the known shortcomings should be documented somewhere for devs to fix later

so they dont get lost in the sands of time

[rugged spire]

comments in the files?

[fossil inlet]

gh issue?

[rugged spire]

irccolors is neat

[fossil inlet]

yea

esp for people who use compact mode

(they're crazy)

[rugged spire]

i might actually play around with what could be changed though

also overrides would be neat

[austere talon]

fix the things I mentioned

[rugged spire]

what things?

[austere talon]

[rugged spire]

rolecoloreverywhere?

yop i found it

[austere talon]

on the irccolors pr

my comment

[rugged spire]

its hsl

[fossil inlet]

god this is the best thing ive ever added to vencord companion

so nice

[austere talon]

you just need to intregate the plugin with RCE

maybe edit RCE

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #2889 Feat(plugin): add CopyStatusUrls

sadan4

[Vendicated/Vencord] New review comment on pull request #2889: Feat(plugin): add CopyStatusUrls

the patch should be better now (also addressed other feedback)

[rugged spire]

bleh

i will come back to this later

[glass jasper]

we gotta stop calling it that

[rugged spire]

never

[fossil inlet]

ignoring the only plugin that actually has RCE

[austere talon]

why did you edit the copy function 😭

[fossil inlet]

it uses success on error 😭

why show a checkmark when you cant copy

[austere talon]

that case should never happen because you would have to use some insane browser to even get that

[fossil inlet]

then does it even matter 😭

[rugged spire]

it has mattered enough for you to notice it

[fossil inlet]

revert if you dont like it that much

[fossil inlet]

yop

[charred monolith]

sadan4

[Vendicated/Vencord] Issue opened: #3167 [Bug] PermissionViewer: Role context menu in modal is not consistent with out of modal

Discord Account

sadan

What happens when the bug or crash occurs?

the context menu does not have the expected items

What is the expected behaviour?

the context menu to have the expected items

How do you recreate this bug or crash?

1. open modal
2. right click role
3. notice items missing

Errors

N/A

![Image](https://github.com/user-attachments/assets/c524cd3e-ad64-4d78-8e0c-5...

Vendicated

[Vendicated/Vencord] New comment on issue #3167: [Bug] PermissionViewer: Role context menu in modal is not consistent with out of modal

those options are added by other plugins that patch the dev-context menu (yes that's the id of that role context menu)

sadan4

[Vendicated/Vencord] New comment on issue #3167: [Bug] PermissionViewer: Role context menu in modal is not consistent with out of modal

those options are added by other plugins that patch the dev-context menu (yes that's the id of that role context menu)

yea, I'm aware.

wonder if there's any way to imitate the dev-context menu from the modal

[median rapids]

[charred monolith]

Vendicated

[Vendicated/Vencord] New comment on issue #3167: [Bug] PermissionViewer: Role context menu in modal is not consistent with out of modal

you can give it the dev-context id and make sure you pass the same props to it (mainly id prop) and it should automatically be patched

[hollow musk]

not sure if yall know this, but better folders sidebar doesnt really add itself to the right place in visual refresh (it should be under sidebar_a4d4d9 but it is under base_a4d4d9 instead. i looked at the code, i have no idea how it works, so im leaving this here for any of yall to fix (i was planning to fix this and add to my PR, but nevermind)

[fossil inlet]

?remind 3 days look into this

[shut vine]

Alright @fossil inlet, in 3 days: look into this

[charred monolith]

NSPC911

[Vendicated/Vencord] Pull request opened: #3168 ClientTheme: Fix for Visual Refresh

Uses some diabolical themeing to fix ClientTheme not working while Visual Refresh is enabled
I can't find a proper curve to plot points and get better Lightness percentages (linear increase made it more flatter than it originally was with discord's wonky ahh curve
), so until then this is what is available

I haven't added my name to the Plugin Authors because I remember somewhere stating that the name can ...

[inland timber]

Is there a way to open vencord's settings page, plugins page, etc, via code?

sort of working on something to combine all discord mod clients together and I want to put their settings in a single unified location instead of cluttering the settings page which can also cause incompatiblities with how each mod adds their own settings menu to the panel

[hollow musk]

i don't think that's worth the trouble

[inland timber]

(I already have it working)

[austere talon]

you're insane

anyway look how the update notification does it when u click it

[glass jasper]

+1 there is only one man I’ve known in Vencord history to get other client mods working with Vencord, and that shit is fucked to all hell

[hollow musk]

thats wild lol

[inland timber]

thanks for pointing in the right direction!
time to revive Topaz but better

[glass jasper]

The only other client mod, you will get a semi stable experience with is shelter

[hollow musk]

no way, you have to be coping
what are the clients you added, and why do you need that much

[austere talon]

if you want to combine multiple mods you will have to patch their code to make them compatible lol

Vencord and BD are incompatible

[inland timber]

betterdiscord, kernel, shelter and atm replugged sortof
replugged collides with vencord due to plaintext patches but I am trying to fix that

[inland timber]

they are the most compatible out of all

[hollow musk]

no way

[glass jasper]

actually Vencord and shelter are

[inland timber]

literally perfect out of the box working

[hollow musk]

yeah thats what i thought, because iirc shelter uses something different compared to the others

[glass jasper]

vro’s will do anything to get ‘BDcompact’

[hollow musk]

@inland timber the point still stands, why.

[fossil inlet]

Userplugger soon

[austere talon]

anyway this is off topic to this channel

[inland timber]

shelter, vencord, bd
are the most compatible ever period.

everything works perfectly out of the box
actually wait BD needs their win32 thingie removed but that's optional and more of a platform thing

[austere talon]

#🪅-progaming or whatever

and take ur meds cause no one asked for this

[inland timber]

instead of the user choosing
let everyone use one!

[hollow musk]

wha
i have no words

[glass jasper]

vro is cooked the next doomsday

[hollow musk]

chat i think this guy needs some actual medication, he is beyond saving

[inland timber]

oh my bad, my question was related to vencord itself on how to get to its settings, so I thought this was the appropriate channel

[inland timber]

I got it working!!! no cap

[hollow musk]

ahh moment

wait also is it a vencord issue or vesktop issue that the nav bar (which has the minimize, maximize and close button) to not show up while having visual refresh?

[toxic forge]

ai

[austere talon]

you guys are giving me a headache

hop into a different channel before I kill myself

[hollow musk]

8x^3 + 15x^2 - 22x - 15

I'm sorry i just had to do it

[inland timber]

🤯
amazing code (i actually enjoy math)

[hollow musk]

same

why would anyone hate it

[scenic brook]

I did this a bit back too, actually insanely useful

Immediate feedback that your regex is shit

This plus diff view are op

Also this because I always forget when working in native

[astral bone]

How do you even solve

[hollow musk]

its literally simple calculus, hows that hard

[scenic brook]

This is how people lose channel access

[hollow musk]

my bad

[charred monolith]

Masterjoona

[Vendicated/Vencord] New comment on issue #1749: Plugin README images thread

OpenMemberPopoutInstead

Masterjoona

[Vendicated/Vencord] New comment on pull request #2902: feat(plugin): ShowMeTheMember

fixedd

(thank you about the conflicts i have no idea how i did those)

Vendicated

[Vendicated/Vencord] New comment on pull request #2902: feat(plugin): ShowMeTheMember

just forcepush shenanigans

[limber skiff]

I wouldn't do replugged if I were you

[fossil inlet]

isnt replugged EOL

[limber skiff]

nop

[austere talon]

sadly no

[limber skiff]

but replugged does async stuff everywhere and they have all sort of race conditions with webpack finds, patching and even with discord own lazy chunk loader (at least used to have this one)

[austere talon]

LMAOO i forgot about that

i wonder if they found the cause yet

[limber skiff]

adding replugged is almost asking to have race conditions and a lot of crashes/plugins not working

[limber skiff]

I think tarki did yeah

https://github.com/replugged-org/replugged/pull/659

[austere talon]

not merged lol

that means it took them this long to find it

meanwhile we found it in like 10 minutes

[limber skiff]

90 files changed lol

[austere talon]

i still dont understand the async spam they do

i love await getReact

[austere talon]

lol yeah he found it

[limber skiff]

[limber skiff]

we should turn every vencord import into await import

[austere talon]

half of the diff is just him rewriting the renderer code to not use top level await everywhere lmfaoo because that's esm only

[jolly egret]

will become faster

[limber skiff]

I kinda understand a bit why it's async

cuz gotta load plugins from files and stuff and they didn't want blocking

[austere talon]

ya but u dont gotta make the entire webpack stuff async for that 😭

[limber skiff]

but basically attempting to mess up with webpack and turn it async

that would never work well

webpack even has it's own function for esm modules with top level await

cuz obviously that needs special handling

[charred monolith]

henmalib

[Vendicated/Vencord] Pull request opened: #3169 ircColors: fix ColorDot/RoleColorsEverywhere/maybe smth else

Basically instead of modifying just the username, now it's changing color inside of discord's helper func

And this function is used by RoleColorsEverywhere, so it's a win-win situation
https://github.com/Vendicated/Vencord/blob/main/src/plugins/roleColorEverywhere/index.tsx#L28

sadan4

[Vendicated/Vencord] Pull request review submitted: #3125 EmoteCloner: Add new places to clone from

sadan4

[Vendicated/Vencord] New review comment on pull request #3125: EmoteCloner: Add new places to clone from

this is way too long, one example should be enough and this really should be a gif instead of a video

how can you embed a gif, I have the readme updated with the gif but it wont embed for me

[scenic brook]

It's embedded fine for me

[fossil inlet]

Husk

[limber skiff]

@austere talon couldnt this just hash from xxhash64 instead

[austere talon]

tias

[limber skiff]

what does tias mean

😛

[austere talon]

https://tryitands.ee

[limber skiff]

oh lol

it worked

2. You might be breaking the Rules of Hooks

I broke the rules of hooks

[austere talon]

https://media.discordapp.net/attachments/717777832604074005/1009573333379067945/caption.gif?ex=6798a22f&is=679750af&hm=5041a58c1a716531959481d8184cde263b6f250c1de37f33f958b56eaa0343c7&

[limber skiff]

can I really not call a hook from here

[austere talon]

nop

[limber skiff]

it is inside the context of rendering tho?

[austere talon]

they probably call ew()

instead of using proper react call

[limber skiff]

nvm it is not

yeah

SHIT ASS

https://media.discordapp.net/attachments/968574375190212728/1014400713184514058/SPOILER_unknown.gif

[austere talon]

trolled

[limber skiff]

alright there we go

[charred monolith]

Nuckyz

[Vencord:dev2] 5 new commits

87cb1fd Fix top level settings notifying global listene... - lolsuffocate
cf28c65 Add IrcColors plugin (#2048) - jedenastka
f29662c feat(ViewRaw): add View Role option (#3083) - vishnyanetchereshnya
3350922 LastFmRPC: Add option to hide if there is anoth... - Vendicated
c4f8221 IrcColors: Make lightness apply without restart - Nuckyz

[limber skiff]

Keep in mind this overrides role colors in chat, so if you wish to know
someone's role color without checking their profile, enable the role dot: go to
User Settings, Accessibility and switch Role Colors to Show role
colors next to names.

https://github.com/Vendicated/Vencord/pull/3169

someone made this pr to make color dot reflect it

hmm

[charred monolith]

Nuckyz

[Vencord:dev] 1 new commit

c4f8221 IrcColors: Make lightness apply without restart - Nuckyz

[austere talon]

https://github.com/Vendicated/Vencord/pull/3169/files

[granite sky]

https://github.com/Vendicated/Vencord/pulls?q=sort:updated-desc is:pr is:open#issuecomment-2614745263

I just saw vee's comment complaining about it

Also i've just noticed small issue about my pr: it does changes color text, but doesn't reflect on mentions ( when using role colors everywhere)

[limber skiff]

shit is exploding im trying to work on it

[austere talon]

just update the RCE plugin

[limber skiff]

this proxy memo just doesnt work right idk why

wrapMessageAuthor(userId: string, messageAuthor: any) {
        const colorString = useMemo(() => calculateNameColorForUser(userId), [userId]);

        const proxy = useMemo(() => {
            return new Proxy(messageAuthor, {
                get(target, prop, receiver) {
                    if (prop === ORIGINAL_COLOR_SYM) {
                        return Reflect.get(target, "colorString", receiver);
                    }

                    if (prop === "colorString") {
                        return colorString;
                    }

                    return Reflect.get(target, prop, receiver);
                }
            });
        }, [userId, messageAuthor]);

        return proxy;
    },

[granite sky]

May i make it in one pr?

[limber skiff]

lies

[austere talon]

why tf r u using a proxy

[limber skiff]

to get original color for role dot

[austere talon]

why

the role dot should also have the IrcColors color

[austere talon]

yes

[granite sky]

If i make something like this ( needs conversion from hsl to hex ) how many husks of huisk it will get?

I've seen a long time ago that no one should modife stores since discord relies on it

[limber skiff]

u should pull dev

[austere talon]

yeah this is what i meant

[granite sky]

I've no idea how to change it

[limber skiff]

make a new branch

then git merge upstream dev

or better

reset to dev

git reset upstream dev

[austere talon]

go into your pr

and change base branch to dev

then press the button on github

[granite sky]

It's already dev

[austere talon]

then click update branch

and then run git pull locally

[granite sky]

oh, wait

[limber skiff]

vs dev

vtest dev

[nimble pendant]

Now testing!

[fossil inlet]

what version of react does discord use

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[austere talon]

React.version

[frail sky]

Bad Patches

PermissionFreeWill (had no effect):
ID: 156699
Match: ```
/{(\i:function(){return \i},?){2}}/

**__ConsoleJanitor (had no effect):__**
ID: `173840`
Match: ```
/(?<=&&\()console.log\(`Deprecated.+?`\),/

ChatInputButtonAPI (had no effect):
ID: 258696
Match: ```
/return(!\i.\i&&(?=(\i.isDM.+?(\i).push(.{0,50}"gift")/

**__IgnoreActivities (had no effect):__**
ID: `293273`
Match: ```
/HANG_STATUS.+?(?=!\i\(\)\(\i,\i\)&&)(?<=(\i)\.push.+?)/

ShowTimeoutDuration (had no effect):
ID: 464891
Match: ```
/(\i).Tooltip,{(text:.{0,30}(?:.AeYyLy)))/

**__ShowHiddenChannels (had no effect):__**
ID: `557135`
Match: ```
/(?=&&\i\.\i\.selectVoiceChannel\((\i)\.id\))/

iLoveSpam (had no effect):
ID: 598077
Match: ```
/if((\i)<=(?:1<<30|1073741824))return/

**__MentionAvatars (had no effect):__**
ID: `644956`
Match: ```
/children:\[\i&&.{0,50}\.RoleDot.{0,300},\i(?=\])/

OpenInApp (had no effect):
ID: 952164
Match: ```
/!(0,\i.isDesktop)()/

**__BetterSettings (had no effect):__**
ID: `493544`
Match: ```
/\(0,\i\.useTransition\)\((\i)/

Settings (had no effect):
ID: 991346
Match: ```
/({(?=.+?function (\i).{0,160}(\i)=\i.useMemo.{0,140}return \i.useMemo(()=>\i(\3).+?function(){return )\2(?=})/

**__ShowHiddenChannels (had no effect):__**
ID: `473403`
Match: ```
/(?<=\.wrapper:\i\.notInteractive,)(.+?)if\((\i)\)return (\i\.MUTED);/

ShowHiddenChannels (had no effect):
ID: 473403
Match: ```
/.LOCKED;if((?<={channel:(\i).+?)/

**__BetterFolders (had no effect):__**
ID: `179809`
Match: ```
/(?<=(?:\.xV9hVl).+?useTransition\)\()/

ShowHiddenChannels (had no effect):
ID: 424785
Match: ```
/!(\i).isRoleSubscriptionTemplatePreviewChannel()/

**__ViewIcons (had no effect):__**
ID: `217314`
Match: ```
/.Avatar,.+?src:(.+?\))(?=[,}])/

ViewIcons (had no effect):
ID: 753898
Match: ```
/.Avatar,.+?src:(.+?))(?=[,}])/

**__ImplicitRelationships (had no effect):__**
ID: `270759`
Match: ```
/(\(0,\i\.jsx\)\(\i\.TabBar\.Item,\{id:\i\.\i)\.BLOCKED,className:([^\s]+?)\.item,children:\i\.\i\.string\(\i\.\i(?:\["4bDptL"\])\)\}\)/

CtrlEnterSend (found no module):
ID: -
Match: ```
.ENTER&&(!

**__FakeNitro (found no module):__**
ID: `-`
Match: ```
.PREMIUM_LOCKED;

MessageLogger (found no module):
ID: -
Match: ```
useMessageMenu:

Bad Webpack Finds

waitFor("FormItem", "Button")

waitFor("MenuItem", "MenuSliderControl")

findByProps("ModalRoot", "ModalCloseButton")

findByProps("openModalLazy")

proxyLazyWebpack(()=>zr.openModalLazy...)

proxyLazyWebpack(()=>zr.openModal...)

proxyLazyWebpack(()=>zr.closeModal...)

proxyLazyWebpack(()=>zr.closeAllModals...)

findExportedComponent("BlobMask")

findByProps("useMessageMenu")

findComponentByCode("Button.Sizes.NONE,disabled:")

findExportedComponent("HiddenVisually")

find(e=>e.Types?.[0]==="BOT"...)

findExportedComponent("ColorPicker", "CustomColorPicker")

findByProps("useStatusFillColor", "StatusTypes")

findExportedComponent("Dots", "AnimatedDots")

findComponentByCode(".AvatarSizeSpecs[", "getAvatarURL")

Bad Starts

None

Discord Errors

None

[limber skiff]

...

[austere talon]

what did they cook

[fossil inlet]

WHAT

[limber skiff]

mangled everything again

[fossil inlet]

@limber skiff is this the big component module again

[austere talon]

Components module kill

[fossil inlet]

i have a feeling they wont revert this time

[grizzled halo]

Time to #1257025907625951423?

[limber skiff]

it's just mangled

[austere talon]

oh

[jolly egret]

doomed

[fossil inlet]

iirc support helper crashes discord with this

[sterile oak]

insane

[austere talon]

horror, need to fix that

[fossil inlet]

thats what happened last time, havent tested on this build yet

so someone should prob make known issues post ( @jolly egret )

[jolly egret]

i'm eating

sticky message is updated in #🏥-vencord-support-🏥 though

[limber skiff]

I have these fixes already

[austere talon]

theyre gonna revert bro

[limber skiff]

that's from a squash

[austere talon]

oh old

[jolly egret]

haven't they pushed this same mangling multiple times now

[limber skiff]

remember I was trying push a fix to not depend on non mangled stuff

[fossil inlet]

yea

[limber skiff]

and had the DOMTokenList issue

[austere talon]

theyre stupid

[fossil inlet]

@austere talon even if they revert, support helper should be done in a way where it doesnt crash, even when finds fail

[austere talon]

yes

[austere talon]

^

I suggested in the past that we make a mode where it deliberately breaks all webpack finds

so we can find crashes

we should do that

[fossil inlet]

yea, thats been in the back of my mind for a while

im busy rn, but if a few hours ill start fixing stuff if needed and they havent reverted

[odd heath]

HORROR

What did they do???

[austere talon]

they cooked

(probably will revert)

[odd heath]

Yeah

[austere talon]

why the fuck does this crash (cannot read properties BOT of undefined (so r.Z.Types is undefined)

why is r.Z.Types undefined

it's MoreUserTags that causes the crash btw

[limber skiff]

how to properly type this here

I'm not sure if there is a way to infer this

[austere talon]

dude

[granite sky]

Is there some analog of useMemo that doesn't utilize hooks?

[austere talon]

MoreUserTags just needs a rewrite I already said this last time and it wasn't done

that plugin is so dangerous

[odd heath]

Why?

[austere talon]

because it always causes crash

its patches are written in a way that makes Discord crash if anything changes

[odd heath]

h

OH HUSK

[austere talon]

so many patches to different modules that depend on one another and aren't stable even on their own

[jolly egret]

incredible

[austere talon]

look at this

it makes a discord module return early and export undefined

so Discord's own code causes crash because it's reading property of undefined

FIRE

[austere talon]

what is this supposed to refer to

[fossil inlet]

love

[limber skiff]

plugin def

[austere talon]

function (this: SomeType, arg1: SomeType)

i will delete MoreUserTags for now

we need to rewrite it, then we can add it back

[fossil inlet]

intersection with ThisType<MyType> or (this: MyType, ...args: any) => void

why husk?

seriously

[austere talon]

@limber skiff

[limber skiff]

I guess

[austere talon]

also whatever this thing is shouldnt use an ErrorBoundary lmaoo

it's username or smth

[limber skiff]

but is it not easy to fix for now

[austere talon]

yes but it will crash again in the future

and we dont even want to fix it for now

but we dont want stable to crash

[limber skiff]

in the future, not now 😛

[charred monolith]

Vendicated

[Vencord:dev] 1 new commit

ceba977 Delete MoreUserTags for now because it's unstable - Vendicated

[limber skiff]

I did this before

const Tag = findComponentByCodeLazy("#{intl::DISCORD_SYSTEM_MESSAGE_BOT_TAG_TOOLTIP_OFFICIAL}") as RC<{ type?: number, className?: string, useRemSizes?: boolean; }>;
const TagTypes: Record<string, number> = findByPropsLazy("ORIGINAL_POSTER", "REMIX");

[sterile oak]

uh why are you trying to use this? u should return a Element

[limber skiff]

ik

[fossil inlet]

what other plugins are crashing (nothing is for me rn)

[sterile oak]

okay. me sleep now gn

[limber skiff]

gn

[charred monolith]

Vendicated

[Vencord:dev] 1 new commit

ea1e961 MessageLatency: ErrorBoundary should be noop - Vendicated

[austere talon]

why are u even trying to make this work

that's antipattern you shouldn't use this there

[limber skiff]

hmm

[austere talon]

this seems to be the only thing crashing

[fossil inlet]

@austere talon should message accessories all be noops

they take up a lot of space in chat if they arent

[austere talon]

why doesn't this work am i stupid

[fossil inlet]

(the error boundaries)

[limber skiff]

according to cynthia stuff isn't mangled, but not exported in the common module anymore

[fossil inlet]

build --reporter

[limber skiff]

reporterDesktop

[austere talon]

i use vesktop

[limber skiff]

oh

that should still work then

[fossil inlet]

i use build --reporter --dev on vesktopp

[austere talon]

right vesktop is considered desktop

i may be stupid

holy fucking lag

oh theres crash when right clicking

chat bar

but thats fine

should we push to main?

it will make sure people wont get crash if they push to stable

[limber skiff]

ig

the other changes should already be good to go

they have been in dev for a while now

[austere talon]

let me do some tests

[limber skiff]

ugh we should really stop relying on anything that's not mangled

so stupid

always causes issues at some point

[austere talon]

it's fine

[limber skiff]

not really

[granite sky]

uggh
if you decide to push to main, can someone review my irccolors pr? So users have all benefits of it
i've made it working

[austere talon]

i will just push main for now

[austere talon]

doesnt matter much, later

[granite sky]

okay

[austere talon]

@limber skiff any objections?

[granite sky]

Than i'll take a look what i can do for MoreUserTags

[fossil inlet]

love

[austere talon]

i fixed that already

[austere talon]

^

[limber skiff]

nop, its fine

[austere talon]

bro my local clone is so fucked

[charred monolith]

Vendicated

[Vencord:main] 17 new commits

317121f Replace API add/remove funcs with methods in pl... - Vendicated
5c8ba6e Settings API: add support for custom objects / ... - Nuckyz
e000a94 Optimize slow patches - Nuckyz
72ec5e2 Merge remote-tracking branch main into dev - Nuckyz
78c2f0d Fix calling option onChange listeners for legac... - Nuckyz

[austere talon]

nvm just goofy git behaviour

the past 2 days i've had so much weird behaviour

[limber skiff]

17 commits

lmaooooo

[austere talon]

basically
i did

git checkout main
git reset --hard dev
git pull

then the pull rebased and changed it to 16 commits

i was so confused

but remember one of the commits is a merge commit

I have merge strategy set to rebase

So it automatically removed the dev merge commit and changed it to rebase

confused me so much for a bit

[limber skiff]

oh lol

[austere talon]

wtf is purp

did you just add that or am i insane

[limber skiff]

i did

[austere talon]

i saw you change colour in real time

[limber skiff]

I remembered about the cotd color of some days ago which was this one

oh yeah userplugins users will cry now

and forks too

[austere talon]

good timing

assuming discord pushes this to stable

[median rapids]

idts

[limber skiff]

it's so weird this is happening

what are they changing...?

[fossil inlet]

reporter randomly wont load for me with this being spammed in the console

[limber skiff]

rate limit?

[fossil inlet]

dont think so because i will reload and it will work

it just randomly doesnt

[fossil inlet]

if stuff isnt mangled, then why cant i find any mention of old names (FormItem, openModalLazy)

[limber skiff]

that huge module basically re-exports with non mangled names

[fossil inlet]

yea

[limber skiff]

they were always exported mangled in another place (for most)

not the case for useMessageMenu though

[fossil inlet]

@limber skiff should i just start fixing patches or are we going to see if they revert

[median rapids]

might be a new more aggressive minifier rule lol

they need every % they can get

[austere talon]

they have so many easy ways to minify their code 😭

instead they do insane bundler shit

[scenic brook]

Just put less code in there

[long stream]

deleting ancient analytics and builds:
minifying the current builds to hell to save 5.62 kb:

[median rapids]

they're not saving on their own storage costs lol

this is client-side savings

don't be silly

[long stream]

doubt

it can't be anything other than storage costs especially since they're trying to maximize profit right now

[median rapids]

?????????????

😭

[glass jasper]

Never forget what they did to my beloved past time of using them to host my files for other places

[long stream]

why do u think they're doing ads and throwing a nitro upsell everywhere they can

[median rapids]

ur logic makes zero sense lmao

[scenic brook]

They're not minifying their own codebase lol

[long stream]

when did i say it was the actual codebase 😭😭

[scenic brook]

How else would it save them storage

[long stream]

they don't pay for git storage