#๐Ÿ‘พ-core-development

1 messages ยท Page 223 of 1

junior olive
#

@fossil inlet why was the decor pr fix closed if u know?

charred monolithBOT
scenic brook
#

Asap, get to it

dusk blaze
#

alibabacord

limber skiff
charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

ShowHiddenChannels (had no effect):
ID: 557135
Match: ```
/(?<=getBlockedUsersForVoiceChannel((\i).id);return()/


**__ConsoleJanitor (found no module):__**
ID: `-`
Match: ```
[DEPRECATED] Passing a vanilla store will be unsupported in a future version. Instead use `import { useStore } from 'zustand'`.

ConsoleJanitor (found no module):
ID: -
Match: ```
[DEPRECATED] getStorage, serialize and deserialize options are deprecated. Use storage option instead.

Bad Webpack Finds
mapMangledModule("useSyncExternalStoreWithSelector:,Object.assign,/(\i)\?(\i)\(\1\):\2/", {
	zustandCreate: t=>typeof t!="function"?!1:Ia(Function.prototype.toString.call(t),e)...
})
Bad Starts

None

Discord Errors

None

#
Bad Patches

ShowHiddenChannels (had no effect):
ID: 557135
Match: ```
/(?<=getBlockedUsersForVoiceChannel((\i).id);return()/


**__ConsoleJanitor (found no module):__**
ID: `-`
Match: ```
[DEPRECATED] Passing a vanilla store will be unsupported in a future version. Instead use `import { useStore } from 'zustand'`.

ConsoleJanitor (found no module):
ID: -
Match: ```
[DEPRECATED] getStorage, serialize and deserialize options are deprecated. Use storage option instead.

Bad Webpack Finds
mapMangledModule("useSyncExternalStoreWithSelector:,Object.assign,/(\i)\?(\i)\(\1\):\2/", {
	zustandCreate: t=>typeof t!="function"?!1:Ia(Function.prototype.toString.call(t),e)...
})
Bad Starts

None

Discord Errors

None

limber skiff
#

@fossil inlet I get it now

#

they updated zustand to v5

fossil inlet
#

ah

#

does that change decors usage?

limber skiff
#

but are only importing create from zustand/traditional

#

which makes the find not work cuz the other implementation isn't bundled

limber skiff
fossil inlet
#

so is my fix good, or is something else needed

limber skiff
#

only breaking change that affected decor was getStorage -> storage

#

which I already did

fossil inlet
limber skiff
#

I'm gonna edit the find a little but push to your pr

fossil inlet
#

thats fine blobcatcozy

limber skiff
#

just making sure it wont break if they somehow revert again

fossil inlet
#

also when you have a chance, can you take a look at #3027

fossil inlet
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
#

13993f3 Decor: Fix avatar decorations not showing (agai... - sadan4
ac1b1d4 ShowHiddenChannels: Fix viewing voice channels ... - sadan4
f22d0e1 EmoteCloner: Fix recognizing animated emojis (#... - sadan4
f8dfe21 Remove no-longer desired collaborator (#3032) - CodeF53
7ca4ea3 RoleColorEverywhere: Fix message headers colors... - henmalib

fossil inlet
#

@junior olive decor blobcatcozy

junior olive
#

w glad to see it

limber skiff
#

sorry for the wait blobwob

junior olive
#

its all good

#

if i tried to fix it would take even longer im so out of the loop

limber skiff
#

better folders is good right?

fossil inlet
#

discord reverted

limber skiff
#

alright

#

it's probably going to break soon again

fossil inlet
limber skiff
#

just did blobwob

fossil inlet
jolly egret
#

betterfolders is always breaking

fossil inlet
#

iirc this is the last time its broke since discord changed up their flux events thing

#

id say fake nitro and shc break more

limber skiff
#

I'm pretty sure it broke now because they organized the file better

#

iirc

#

but I guess they made an issue and had to revert temporarily

#

their JSX looks similar to that in their non minified file

#

which is horrible lmao

#

and from what I remember from your fix sadan, they just separated it in components

fossil inlet
#

iirc it still looked a lot like that in the broken thing

#

just a massive element

limber skiff
fossil inlet
#

but a third patch was also needed (minor fix for the unread thing at bottom/top)

#

but i never got to that before they reverted

limber skiff
#

oh

#

you are right

#

I was thinking those smalls components were they separating

#

nvm then

fossil inlet
#

i think it would be funny if I kept a local diff of every canary update

#

by that i mean a diff of each module

limber skiff
#

DM me

jagged cloak
#

someone might wanna doublecheck the fakenitro isPremium patch

#

oh

#

me when i dont fucking read

long stream
#

rare case of a vencord contributor not being able to read

fossil inlet
charred monolithBOT
#

Is it possible to achieve the same result without the use of transform and scale?

I was trying to do it without using scale and transform because to me it seemed finnicky or bad practice, and I tried for a while and couldn't get the red bar to look the same, so I think it's possible but not worth the time unless someone that is knowledgeable can remake it without transformations, if it is strictly needed.

I used the scale attribute of the SVG element so that the red bar would be the s...

charred monolithBOT
fossil inlet
#

i love necroing year old posts

austere talon
#

we should add a workflow that just locks closed issues after a few months of inactivity

#

to stop people from necroing

fossil inlet
#

ehhhhhh

#

tbh that just gives off a bad vibe to me

#

doesnt happen that often

charred monolithBOT
#

Discord Account

No response

What happens when the bug or crash occurs?

image

using the plugin but the other person doesn't have any indicator of them being on what platform, bc they are using invisible mode

What is the expected behaviour?

however it works fine with online/dnd/idle users,

How do you recreate this bug or crash?

just communicating with a user who is in invisible mode...

glass jasper
rugged spire
#

oh

#

closed issues?

#

eh

jagged cloak
#

valebot

rugged spire
#

closed issues is fine

jagged cloak
#

stalebot but only for closed issues

#

This still happens for me on hyprland. Can't believe the Vendor dev team still hasnt fixed this

fossil inlet
#

guhhh

#

is it possible to make a validated input field in settings without a custom component

fossil inlet
#

teach me

rugged spire
#

let me remember how

fossil inlet
#

like im aware i can do some type of checkedinputfield in a custom component

#

but im lazy and want to avoid that

rugged spire
#

oh

#

its just isValid: (value) => boolean | string

#

i think

#

i saw it in CustomRPC trolley

#

dont mind my multiple edits

grave mangoBOT
rugged spire
#

@fossil inlet

fossil inlet
#

tyyy

#

i will use after i eep

rugged spire
#

just had motivation to look into PermissionsViewer for the first time in idk how long

rugged spire
#

shouldnt this button and the associated setting be removed lol

#

the arrow

#

its always set to forceopen

#

and there is a setting that is "toggled" when you click it

fossil inlet
#

it doesnt render formatted text in permission descriptions

rugged spire
fossil inlet
#

remenant of i18n changes

rugged spire
#

and you will vouch for my code

fossil inlet
rugged spire
#

todo:

refactor how forceOpen in ExpandableHeader component works (hide the button entirely)
remove defaultPermissionsDropdownState setting from PermissionsViewer (it is useless)
fix i18n tooltip bug
add total calculated permissions page in member permission modal

fossil inlet
#

ooh

rugged spire
#

no

fossil inlet
#

also could you open modview on yourself

rugged spire
#

thats popout

rugged spire
fossil inlet
fossil inlet
shut vineBOT
#

Alright @fossil inlet, in 13 hours, 25 minutes and 39 seconds: โ€ฆ

fossil inlet
#

i will do when i wake

rugged spire
#

3pm thumbsup

glass jasper
rugged spire
#

i mean when @fossil inlet will "wake up"

#

@fossil inlet are you nocturnal creature

fossil inlet
#

i just have a fucked up sleep

#

there are times where i go to bed at 3

#

and wake up to go to school at 7

rugged spire
rugged spire
#

and i see discord has this ast thing

#

idk how to deal with it lol

limber skiff
#

uhh

#

try this

rugged spire
#

all I can tell is msgis always a string

#

is it worth always formatting it?

fossil inlet
#

Guhhh I really need to make runtime ast generator

limber skiff
#
return getIntlMessage(`ROLE_PERMISSIONS_${permission}_DESCRIPTION`, {}) ?? "";
#

that might work

rugged spire
#

that just returns ast

limber skiff
#

hmm

#

okay wait

rugged spire
limber skiff
#

are you sure that doesn't work

#

that's exactly what we want

rugged spire
#

yes

#

but how do I use that

fossil inlet
#

Itโ€™s a react mode

#

Just render it

rugged spire
#

What

fossil inlet
#

Am I stupid

limber skiff
#
export function getPermissionDescription(permission: string): ReactNode {
    // DISCORD PLEEEEEEEEAAAAASE IM BEGGING YOU :(
    if (permission === "USE_APPLICATION_COMMANDS")
        permission = "USE_APPLICATION_COMMANDS_GUILD";
    else if (permission === "SEND_VOICE_MESSAGES")
        permission = "SEND_VOICE_MESSAGE_GUILD";
    else if (permission !== "STREAM")
        permission = PermissionKeyMap[permission] || permission;

    return getIntlMessage(`ROLE_PERMISSIONS_${permission}_DESCRIPTION`, {}) ?? permission;
}
fossil inlet
#

React can render arrays

rugged spire
limber skiff
#

that's react rendered shit for you to put in the children

#

aka ReactNode

rugged spire
#

im brainBasket

#

i totally missed the react element stuff

fossil inlet
limber skiff
#

which is exactly what getPermissionDescription returns

#

does it work?

rugged spire
#

there is no magic

#

i'm blind

#

it works

fossil inlet
#

@limber skiff thoughts on a minimum contrast for role color everywhere

limber skiff
# rugged spire it works

do this instead

return getIntlMessage(`ROLE_PERMISSIONS_${permission}_DESCRIPTION`, {}) ?? permission;
#

better than ""

rugged spire
#

i did

limber skiff
#

I changed after the ??

fossil inlet
#

I wonder how stock discord renders it

limber skiff
#

they do the same

fossil inlet
#

Because I know they have a runtime hash func in their code

limber skiff
#

oh

#

I think they have it hardcoded

#

they surely do

limber skiff
#

else this wouldn't have happened

rugged spire
#

is there a problem

limber skiff
#

nono

#

I'm just saying they hardcode the permission -> description

#

instead of doing it dynamically

rugged spire
#

are you saying that mess isn't required

limber skiff
limber skiff
#

not saying that

#

It's good as it is

#

wreq(208884).WW({ showMembershipManualApprovalPermissions: false })

#

@fossil inlet check this out

rugged spire
#

is this a refactor

limber skiff
rugged spire
rugged spire
limber skiff
#

gives permission name and description using the bit

rugged spire
#

i will run and bomb my client

limber skiff
#

can use as alternative to these two

rugged spire
limber skiff
#

lol that's fine

rugged spire
#

mod view is so overengineered

limber skiff
#

use this find

#

const PermissionsStrings = proxyLazyWebpack(() => findByCode("showMembershipManualApprovalPermissions?")({ showMembershipManualApprovalPermissions: false }))

#

or just leave it to me if you want

rugged spire
#

i'l leave it to you and I'll just open my changes as a draft PR

limber skiff
#

okie

#

I'll look at it tomorrow

#

eep now

charred monolithBOT
rugged spire
#

?remindme 12h fix

shut vineBOT
#

Alright @rugged spire, in 12 hours: fix

rugged spire
#

HORROR

#

why don't patch failures error anymore

#

they haven't worked for me since the intl changes

#

noppp

#

i had the stock code running

charred monolithBOT
#

Discord Account

remagofficial

What happens when the bug or crash occurs?

the server count at the top of the server list shows 98 but when trying to join a new server discord tells me I'm already in 100 and can't join the new server

What is the expected behaviour?

i expect it to show the correct count

How do you recreate this bug or crash?

i dont really know what triggered it but maybe it was because a server i was in got deleted without me leaving it first

Errors

...

charred monolithBOT
charred monolithBOT
#
  1. I think the button in the context menu is useless
  2. What are the lags when enabling the plugin and blocking users?

Lags? What Lags? Can you tell me what to do to reproduce that? And The button in what context menu? Like I like the insta one to "block and mute" because that also skips the extra step of "are you sure you want to block personXY?"

When I block someone using this plugin, it takes half a second before I can browse channels or do anything els...

jolly egret
charred monolithBOT
dusk blaze
charred monolithBOT
shut vineBOT
#

@rugged spire, <t:1732434387:R>: fix

#

@fossil inlet, <t:1732430061:R>: โ€ฆ

fossil inlet
charred monolithBOT
fossil inlet
#

@rugged spire you love

still maple
#

:w:

#

smth i'm gonna merge manually in my thing

#

can you make it also show on people that are not in the server anymore ?

fossil inlet
#

uhhh prob not

#

ill take a look

#

ping a user thats no longer in this server

still maple
#

cause sometimes someone gets banned by someone else and i need to verify what they have done

fossil inlet
#

and ill take a look

still maple
#

eeeeeh

#

i'm gonna invite my alt and leave

fossil inlet
#

nevermind

#

ill find an old active user

#

@verbal pumice

still maple
#

rip

#

like discord return you a nope when you do the request manually

#

:sadge:

fossil inlet
#

@limber skiff when are you planning the next tag/browser release?

fossil inlet
#

idk whats going on

#

feel free to fix it yourslef

still maple
#

i mean i've noticed it close itself
i just don't really know how i'd go about finding why

#

ig i need to set a breakpoint somewhere and analyze the logic flow

fossil inlet
#

ill show you how to find one

still maple
#

well i'm all ears

#

i can't talk in there @fossil inlet

fossil inlet
#

GUHHH

still maple
#

perms

fossil inlet
#

permissions so bad

jolly egret
still maple
spark pivot
still maple
#

it's not wednesday my dudes

charred monolithBOT
limber skiff
charred monolithBOT
limber skiff
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
rugged spire
#

this will be awesome for the 1 userplugger that uses this API

limber skiff
#

yep

rugged spire
#

i'm going to try it now

#

oh is it all just inline now

#

were these always 24px?

limber skiff
#

ye

rugged spire
#

no they weren't

limber skiff
#

oh yeah the icon itself was 20

#

but the whole button was 24

#

doesn't matter tho ngl

rugged spire
#

OH

#

let me see what it used to look like

#

because I feel they look too big compared to the "permissions" header itself

limber skiff
#

the header looked weird too big lol

rugged spire
#

i see now

#

the arrow was 20px, the buttons were 24px, you've added a gap of 8px and increased the arrow to 24px

#

i see

#

the ... button was always 24px

limber skiff
#

o maybe I added too much gap

rugged spire
#

that permissions text feels 1-2px higher than center

#

is it even vertically aligned

#

i don't think so

#

I LOVE CSS (no i don't)

rugged spire
versed fern
#

I hate css

fossil inlet
#

@rugged spire was this all really needed just to fix tooltips

rugged spire
fossil inlet
rugged spire
#

sorry

#

i mean most of it

#

the ExpandableHeader code got obliterated

#

it was only used by PermissionsViewer

#

and the "expandable" part has been irrelevant for months

#

it was only expandable because old profiles

fossil inlet
#

ah

rugged spire
#

i took the safe route and just decided to remove the button in this case

#

but @limber skiff decided to bomb it entirely

#

idk if any userplugger ever used that code (i doubt it)

fossil inlet
#

idk how it took me five years to find this out

rugged spire
#

cursed code

fossil inlet
#

its literally the workaround from the github issue

rugged spire
#

yes i know its a workaround thats why its cursed

limber skiff
fossil inlet
rugged spire
jolly egret
#

Its a bit weird to ask for help in the development channel of a client mod for help on changes that do not contribute to said client mod?

#

Just look at how the element is drawn on the plugin cards and look how other react elements are drawn

#

Though IMO you shouldnt be asking for help for something like this here

cloud fractal
#

just wanted to do smth a little silly is all

cloud fractal
limber skiff
rugged spire
charred monolithBOT
#

5fb6324 Add support for onAuxClick on ChatBarButton (#3... - EtorixDev
23c9e2c ShowHiddenThings: Allow opening mod view on you... - sadan4
e7a54b0 SilentTyping: Improve button visual look (#3026) - xNasuni
a9d44e3 PermissionsViewer: Fix permission description t... - Sqaaakoi

#

13993f3 Decor: Fix avatar decorations not showing (agai... - sadan4
ac1b1d4 ShowHiddenChannels: Fix viewing voice channels ... - sadan4
f22d0e1 EmoteCloner: Fix recognizing animated emojis (#... - sadan4
f8dfe21 Remove no-longer desired collaborator (#3032) - CodeF53
7ca4ea3 RoleColorEverywhere: Fix message headers colors... - henmalib

fossil inlet
#

@rugged spire you love a link where i cant even click it

limber skiff
#

lol

#

kinda funny

rugged spire
#

@fossil inlet You should try that activity icon userplugin

fossil inlet
#

never heard of it

rugged spire
#

It does something similar where it embeds the stock activity card from profile popouts and you can't click the ... because its a a tooltip

fossil inlet
#

cant find it

rugged spire
#

idk where i found it I'll check later

#

?remindme 1h

shut vineBOT
#

Alright @rugged spire, in 1 hour: โ€ฆ

fossil inlet
#

am i going crazy

#

nevermind, im stupid

charred monolithBOT
charred monolithBOT
fossil inlet
#

do commands even have boolean options

#

and if they do

#

how this never been an issue before

elder plinth
#

not sure how it's never come up but was affecting me when trying to use the falsy option on boolean options for my customized silent typing plugin

{
    name: "chat-icon",
    description: "Show an icon in the chat bar for toggling the plugin on the go.",
    required: false,
    type: ApplicationCommandOptionType.BOOLEAN,
},
elder plinth
# fossil inlet how this never been an issue before

looks like the only plugin currently that uses a boolean command option is noServerPfp and it falls back to false so it's an invisible issue there

execute: async (opts, cmdCtx) => {
    const frames = await getFrames();

    const noServerPfp = findOption(opts, "no-server-pfp", false);
charred monolithBOT
dusk blaze
#

love

charred monolithBOT
charred monolithBOT
jolly egret
#

i think they deployed the change that broke betterfolders again

frail skyBOT
#
Bad Patches

BetterFolders (had no effect):
ID: 416568
Match: ```
/lastTargetNode:\i[\i.length-1].+?Fragment.+?]})]/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

BetterFolders (had no effect):
ID: 416568
Match: ```
/lastTargetNode:\i[\i.length-1].+?Fragment.+?]})]/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

granite wharf
#

@limber skiff when it comes to the backgrounds of the donation/contrib cards where should I host the svgs

#

theyre both 6kb in size

charred monolithBOT
frail skyBOT
#
Bad Patches

WebContextMenus (had no effect):
ID: 343602
Match: ```
/\i.isPlatformEmbedded/


**__WebContextMenus (had no effect):__**
ID: `343602`
Match: ```
/\i\.\i\.copy/
Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
granite wharf
#

I could put them directly inside of vencord but it would increase the size a little and would require me to do some refactoring which im not really excited for xd

frail skyBOT
#
Bad Patches

WebContextMenus (had no effect):
ID: 343602
Match: ```
/\i.isPlatformEmbedded/


**__WebContextMenus (had no effect):__**
ID: `343602`
Match: ```
/\i\.\i\.copy/
Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
granite wharf
#

I could put it on githubs user attachments thing but it would take a second to load

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
#
  • Add cute cards for if you've donated or contributions, and improved on the existing card telling you to donate.

  • Changed quick actions to be more inline with the styling of the plugin cards

  • Made some discord ids globally accessible such as vencord guild id for reuse, for example used to see if you're a donator

One slight issue is that the background images are hosted on github user attachments, so loading them may be take a second but otherwise thats fine

![image](https:...

turbid hatch
# charred monolith

@granite wharf import img from "file://...?base64" gives you it as b64, so you can probably do data:image/png;base64,${img}

#

then you dont need to external host it

granite wharf
#

ooh

#

good idea

turbid hatch
#

ask vee first

granite wharf
#

but the svgs are 6kb in size

turbid hatch
#

oh are they svgs originally?

granite wharf
#

nope they are svgs xd

turbid hatch
#

ooh i see

#

hm

austere talon
#

if they are svgs u can just put them in source code

turbid hatch
#

@granite wharf u heard the girl

granite wharf
#

๐Ÿ˜ญ

#

I didn't want to do that bc of size but sure

opaque silo
#

6000 char long line incoming

austere talon
#

how is the svg 6kb

granite wharf
#

errr

#

in comparison discord hypesquad svg is like 30kb

limber skiff
#

I'm sure we can start by removing this kind off stuff xmlns="http://www.w3.org/2000/svg"

#

<!-- Created with Inkscape (http://www.inkscape.org/) -->

#

and this probably xlink:href="#heart"?

granite wharf
#

one thing I can think of that would solve this without adding the svg to the src is just making a discord emoji/sticker with a png

#

conveniently those don't expire at least I don't think and loading it would be instant probably

opaque silo
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

fossil inlet
#

nevermind, this code is too cursed to ever be merged

#

~300 lines of just color conversions and math with colors

opaque silo
#

@granite wharf all elements share a style + svgo'd

#

the two svgs actually share some of the same elements so further savings could be done by combining them and putting the two patterns on different groups

#

also using href instead of xlink:href

#

@granite wharfok final ones (that dont use shared elements between them)

charred monolithBOT
opaque silo
glass jasper
fossil inlet
rugged spire
rugged spire
#

oh

#

you are doing that

charred monolithBOT
opaque silo
#

from what I'm reading it can be done by calculating the luminosity from the rgb channels then comparing

#

no colour space conversion

fossil inlet
grave mangoBOT
fossil inlet
#

thats what i already have blobcatcozy

fossil inlet
#

?remind 11am fix whoReacted spacebar bug

shut vineBOT
#

Alright @fossil inlet, in 10 hours, 40 minutes and 12 seconds: fix whoReacted spacebar bug

limber skiff
#

what's the spacebar bug lol

fossil inlet
limber skiff
#

o

#

i wonder how you are gonna fix that

fossil inlet
#

but im not sure about that

rugged spire
#

time for rolecoloreverywhere where role colors already exist

fossil inlet
#

horror

#

tbh i prob wont work on this any more

#

its very big

#

and it relies on parsing css with regex

still maple
brazen bone
#

Regex is pain and suffering

still maple
#

+:skill_issue::trollface:

jagged reef
#

Real*

brazen bone
charred monolithBOT
fossil inlet
shut vineBOT
#

@fossil inlet, <t:1732598388:R>: fix whoReacted spacebar bug

charred monolithBOT
jolly egret
#

no

#

(read the issue)

scenic brook
#

Deleted message really changes the context of the no

still maple
#

XD, indeed it does a lot

jolly egret
#

well now i look schizo because they deleted their message

glass jasper
#

itโ€™s fitting for you

charred monolithBOT
limber skiff
#

thanks

glass jasper
brazen bone
#

Smacked it so hard it got closed twice

jolly egret
#

bruh

jagged reef
glass jasper
#

The account already got taken down

versed fern
glass jasper
#

more companies need support like githubโ€™s support

versed fern
#

Yes

jolly egret
glass jasper
granite wharf
#

which load pretty much instantly

opaque silo
#

can you not just do the same with svgs

granite wharf
opaque silo
#

bwuau whar

#

wdym

#

why would you upload the backgrounds as emojis

granite wharf
#

stickers*

#

but they dont expire if you do that

#

I think

#

so I didn't want to deal with them not working somehow in the future

opaque silo
#

github's cdn:

granite wharf
#

its slow

#

as I mentioned in my pr

#

discord is pretty much instant

#

even with my thing which simulates 4g

opaque silo
#

its so slow that 4kb is noticeable??

#

insane

#

alr do whatever works :p

granite wharf
limber skiff
granite wharf
opaque silo
granite wharf
#

svgs

#

discord one has pngs

opaque silo
#

INSANE

#

well hopefully discord doesnt explode them

granite wharf
#

if it does the donator icons wouldnt work either xd

#

the shiggy here is jsut a discord sticker

opaque silo
#

new discord change inc tmrw

#

specifically to explod that

granite wharf
#

time to optimize assets

#

there we go

#

@opaque silo co-authored u

#

since I used ur svgs technically..

opaque silo
#

INSANE ๐Ÿ˜ญ๐Ÿ˜ญ

#

oh did you generate cleaner pngs from the svgs lmao

charred monolithBOT
#

Part of the improvements to the command (number 3 below) requires #3047 to be merged as well.

Changes

  1. The tooltip for the chat bar icon now states the current status of the plugin.
    • Previously it would say "Disable Silent Typing" which could be confused with the feature itself, disabling typing from showing.
    • Now it states "Typing Hidden" which clearly states the current status without possible confusion for what clicking it would do.
  2. The chat context menu settings ...
elder plinth
#

Keep forgetting to reset my main before making a new branch so it's including previous pr commits facePalm In this case is it problematic or is it fine to leave it be? The first PR was already merged and I don't foresee the second being an issue.

sterile oak
elder plinth
#

I merged my other prs into main cause I wanted to actively use the features in my client lol

sterile oak
elder plinth
#

how does that help here? FaunaThink

sterile oak
elder plinth
#

I think I just need to keep main clean and then have another branch that combines all my changes and checkout to that whenever im done experimenting and want to use the changes before they get merged

fossil inlet
elder plinth
#

that looks powerful but also complicated lol

fossil inlet
#
  • you can always press ? to see the bindings
charred monolithBOT
#

Nuckyz said in the core-development channel that you shouldn't add yourself as a developer for minor changes. I originally started modifying the enhanced fork before switching to main and D3SOX only had Rini and not ImBanana listed so I decided to just look at everyone's commit history on the file and the only thing Rini did was a single line for the match in #1865 so I thought it didn't really qualify. I don't mind adding it bac...

fossil inlet
elder plinth
#

real

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

oh yeah ImageZoom still has the bug where it doesnt properly save zoom

fossil inlet
#

or am i crazy

rugged spire
austere talon
#

yes but i have it on

#

and it doesnt save lol

rugged spire
#

i wonder if the setting actually does anything

#

or if it was bombed by accident in an update

#

(flashbacks to a few days ago)

fossil inlet
#

but ill check

cunning canyon
fossil inlet
#

fixed

#

i have no idea why it wasnt working before

#

it makes no sense

#

does anyone know why this works as a fix

limber skiff
#

idk honestly

charred monolithBOT
fossil inlet
charred monolithBOT
charred monolithBOT
opaque silo
#

insane just disable the experiment for yourself

#

why whole plugin

teal nest
#

it'll roll out eventuallyโ„ข๏ธ (maybe) and the exp has more upsides than anything, this is basically the only bad part about it

#

i've seen people complain about that

opaque silo
#

what's the experiment

#

I will try

charred monolithBOT
teal nest
#

fair

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

jagged cloak
#

"you check this channel too much, i made it always unread for you" husk

fossil inlet
#

horror

#

sho would want that

jagged cloak
#

@verbal eagle would want that

jagged cloak
#

it used to be "should we mark this as unread for every message" now it's fuck you, we're marking unread for every message because you clearly won't do it

fossil inlet
#

it was called muting the channel

jagged cloak
#

well muting the channel completely silences it, and if i still want to see it with hide muted channels?

#

more choice is always great imo

#

except when it's not but shh

#

grey dot vs white dot

fossil inlet
jagged cloak
#

use the experiment for yourself for a while you'll probably end up changing the settings a couple times /shrug

fossil inlet
#

also
doesnt this bypass the muted aspect of the channel

fossil inlet
#

?remind 30s test

shut vineBOT
#

Alright @fossil inlet, in 30 seconds: test

jagged cloak
#

muting the channel hasn't changed at all

shut vineBOT
#

@fossil inlet, <t:1732765654:R>: test

fossil inlet
#

guhh i understand now

jagged cloak
#

example:
(the unread indicator on the server won't display if everything but discord datamine is read)

#

ig this is only for terminally online nerds, the average user probsbly won't actually use anything more than @mentions and all

limber skiff
fossil inlet
#

@limber skiff removing the dep array from the layout effect seems to work fine

#

i eep now

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
fossil inlet
elder plinth
#

insane

fossil inlet
#

BEST PLUGIN

fossil inlet
rugged spire
#

WHAT DO YOU MEAN YOU SUBMITTED THIS AS A REAL PLUGIN @jagged reef

#

it usees dom manipulation everywhere

#

horror

charred monolithBOT
rugged spire
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
#

Thank you for your contribution. However, this is too niche (and has already been rejected before)

Respectfully, this is a load of bullshit. PluralKit is in nearly 1,000,000 servers (roughly). The fact you deny it on a matter of "too niche" when it also plays part in accessibility is fucking stupid, but I guess anything not used by majorities is "too niche" for this repository isn't it, despite having plugins that do things as minor as "removes the gap between code blocks and text below ...

spice python
charred monolithBOT
#

Just locking this now in advance because I know how this is going to go.

The codeblock fix plugin was allowed because it makes a change to the source code which is more performant than using the CSS equivalent. The other plugins you have cited were added to the mod before proper quality control restrictions were put in place. They are kept purely out of the fact that they're funny and for the fact that we don't perform retroactive QC, but would not be acceptable under our rules now (and a ...

turbid hatch
#

Nyan_sigh when people do this it makes us even less likely to add the plugins, and you look like a massive ass in the process

#

especially when you're attacking other devs who aren't even related in your own attempted rebuttal

#

please, if you're going to argue for or against a plugin, behave yourself and be objective.

charred monolithBOT
#

Prefacing your message with "Respectfully" doesn't make it any less disrespectful and outright hostile.

This hostility isn't welcome here. This is your first and last warning to play it nice or we will have to restrict your access to contribute.

Not to mention that this is our project, so it is completely up to us what to accept and what to reject. You are welcome to create your own fork if you have different ideas

austere talon
#

"Not niche" yet not a single server i ever joined had it

#

and the average discord user doesn't even knows what that bot does or what a plural is

charred monolithBOT
prime dew
charred monolithBOT
charred monolithBOT
versed fern
#

Putting respectfully at the start of your message doesn't magically make it respectful

austere talon
#

respectfully kys

woeful sable
glass jasper
#

saving that for later

granite wharf
# charred monolith

why do people get so aggressive when people say something like remotely against plural kit

granite wharf
#

I personally dont have a problem with it but i see this type of agressive accessibility argument happen often, like just respect the decision that its not gonna be added xd

#

find it a bit disappointing

jolly egret
#

accessible communication should be possible so i get why people are mad when you deny it

granite wharf
#

if you respond with an overly rude response it's not gonna end well

austere talon
#

I don't think that's a very strong argument

You don't need that bot to have an accessible chat app

#

And are we supposed to just merge anything that makes discord "more accessible" now?

#

Not realistic

#

there are infinite things that could be done to make discord more accessible in some way

#

if it were a pr like someone making vencord's ui more accessible and we rejected that, sure that'd be a bad move

but rejecting one plugin is not that

jolly egret
#

in this case it relies on pk anyway, but imo having to prefix or suffix your messages is a pain in the ass lol

austere talon
#

okay? still doesn't mean a mod with millions of users should include a plugin maybe 1000 people will use and the rest won't even understand and be confused by

charred monolithBOT
#

A potential solution could be to modify the plugin to filter out deleted servers when updating the count, meaning if you leave a server what's expected is: It doesn't keep it on the count, instead it removes it off.

What's happening:

It remains, the author of the plugin has not added a filter to it, to remove servers from still showing if they're deleted, or if the user leaves the guild.

austere talon
limber skiff
#

that doesn't make sense

#

number is 98 yet user is in 100 servers

#

filtering more will only reduce the number not make it grow

austere talon
#

yeah i don't think that's true, not to mention that discord most likely removes guilds from the cache if it receives a guild leave event

#

doesn't seem right

limber skiff
#

unavailable guild perhaps?

#

but I dont see how that would be consistent

austere talon
#

I assume it has to do with unavailable servers yes

#

since unavailable guilds aren't in the main guild record

turbid hatch
#

give @shrewd hornet programming perks

#

they're competent

#

i vouch

#

they're the PR creator

#

@limber skiff

limber skiff
#

alright

turbid hatch
#

@shrewd hornet

shrewd hornet
#

๐Ÿ‘‹ hello, I do believe it's unavailable guilds.

#

I've personally had the bug before hand, where it refuses to update the count if youre removed out of a server, or if you leave manually

#

I am not too entirely sure if Discord removes guilds from the cache if it receives a guild leave event, I'll have to double check on that if anything to be 100% certain.

charred monolithBOT
charred monolithBOT
austere talon
#

Discord so stupid

#

oh PlatformIndiators has a bug too

#

the phone icon is too small

jagged reef
austere talon
limber skiff
#

what do we think about adding the platform icon here?

#

along side that icon

#

user voice show currently does it but it could be turned into an api

jolly egret
#

we don't seem to have the same amount of room, could you even fit it without choking the rest of the content?

limber skiff
#

lets see

#

๐Ÿ’€

#

good shit

limber skiff
#

im pushing chrome extension

#

weekend is hitting and discord doesnt do updates on the weekend

glass jasper
austere talon
limber skiff
#

yeah

#

I actually didnt realize there were pending commits in dev

austere talon
#

i just pushed some blobcatcozy

limber skiff
#

I was gonna do this:

charred monolithBOT
limber skiff
charred monolithBOT
#
[Vendicated/Vencord] New tag created: v1.10.8
limber skiff
#

we chill now

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

@austere talon what if we cooked some magic to make finds always be accessed using an object

#

so we can discard proxyLazy partially

limber skiff
charred monolithBOT
charred monolithBOT
#

Discord Account

currypan1229

What happens when the bug or crash occurs?

Show channels sent many messages by blocked users

What is the expected behaviour?

Show other users messages

How do you recreate this bug or crash?

  1. block all users that are recently chatted
    1. Crash

Errors

WebpackModule995340:2 Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limi...
austere talon
#

block all users that are recently chatted

jolly egret
#

incredible

#

why would you ever try this lol

jolly egret
#

should've made yours even better as a counter

jolly egret
#

i wonder if you could trigger it if you just had a lot of people you blocked talking

#

either way you can't expect discord to just endlessly fetch backwards until it finds messages to show

dusk blaze
austere talon
#

find a channel with only messages by one single person (usually a bot) and block that person

charred monolithBOT
pine topaz
#

currently sifting through them to make a few changes to ones that need a little more

pine topaz
#

LOL

#

discord crashes from your hate

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
#

most sane match

dusk blaze
#

love

elder plinth
#

one day ill understand matches

fossil inlet
limber skiff
#

I did name each element blobwob

charred monolithBOT
jagged reef
#

accurate

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
median rapids
#

e.g. clan applications

#

they count towards the limit

limber skiff
#

what's the name of the store they have that data

median rapids
#

idk probably something like GuildJoinRequestStore

#

close nuff

fossil inlet
#

why is it a v2

median rapids
#

fuck knows

austere talon
#

probably because they refactored and it's no longer compatible with the old store

#

discord serialises stores and backs them up to local storage

austere talon
#

if they made incompatible changes obviously they don't want to load data from the old one into the new one, hence V2

#

that's what they did on android kotlin app.too

fossil inlet
#

oh, yeah

junior olive
rugged spire
#

warningzoom discord please do not explode anything over the next week

elder plinth
#

why not

somber thorn
#

discord will see this message and explode everything within the next week

dusk blaze
somber thorn
#

change localisation again for no reason

rugged spire
#

yop

somber thorn
#

April 1st discord gets an actual non-electron native app

#

imagine

brazen bone
#

Rewrite web app to do rendering with canvas+wasm

shrewd hornet
#

erm

charred monolithBOT
charred monolithBOT
shut vineBOT
#

@fossil inlet, <t:1730586946:R>: hover for intl strings in companion

austere talon
#

thanks for making it use stores instead of the old cursed forceUpdate way

#

i was looking at the code the other day and thought about rewriting it this way xD

limber skiff
#

no prob lol

austere talon
#

the plugin was written within the first 2 months of the project existing so that's why the code was odd

limber skiff
#

I dont think I had ever looked at the code of this plugin

#

no patches which means it would almost never break

austere talon
#

yeah only the api breaks

limber skiff
#

noticed the api also doesn't update the component when an element is added/removed

#

ngl I think we should have a generic updateX/useX to use in components

#

to hold a global value which can update multiple components

#

kinda like a useState but the value stored is global

brazen bone
#

Isn't that kinda what useContext is meant to be?

#

Though a bit less structured

limber skiff
#

no, simpler than that

#
const renderFunctionsAbove = new Something(initialvalue);

export function addServerListElement(position: ServerListRenderPosition, renderFunction: Function) {
    renderFunctionsAbove.update(newValue);
}

function MyComponent() {
  const renderFunctionsAbove = renderFunctionsAbove.use();
}
#

horrible names but yeah

austere talon
#

that's literally just context erm

#

well not exactly

limber skiff
#

is it?

#

I've never used context

#

but it doesnt seem quite it

austere talon
limber skiff
#

for trigerring a re-render when a server list element is added for example

#

but there are more uses cases for it too

frail skyBOT
#
Bad Patches

AlwaysTrust (had no effect):
ID: 881706
Match: ```
/function \i(\i){(?=.{0,60}.parse(\i))/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

AlwaysTrust (had no effect):
ID: 881706
Match: ```
/function \i(\i){(?=.{0,60}.parse(\i))/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

@rugged spire

charred monolithBOT
dusk blaze
austere talon
#

insane

charred monolithBOT
#

0ac80ce MessagePopoverAPI: Add buttons after quick reac... - Nuckyz
d70e0f2 ServerListIndicators: Account for pending clans... - Nuckyz
3f61fe7 AlwaysTrust: Fix disabling suspicious file popup - Nuckyz
dd87f36 CommandsAPI: Fix spread overwriting omitted sub... - EtorixDev
6628624 CommandHelpers: Make findOption use nullish coa... - EtorixDev

limber skiff
#

@rugged spire thanks too

rugged spire
#

sorry for the curse it will happen again

austere talon
#

holy shit electron fixed the blue & light mode devtools

fossil inlet
#

blobcatcozy

import { IpcMainInvokeEvent, nativeTheme } from "electron";

export function initDevtoolsHook(e: IpcMainInvokeEvent) {
    e.sender.on("devtools-opened", toggleDevtoolsTheme);
}
export function stopDevtoolsHook(e: IpcMainInvokeEvent) {
    e.sender.off("devtools-opened", toggleDevtoolsTheme);
}

function toggleDevtoolsTheme() {
    nativeTheme.themeSource = "light";
    setTimeout(() => nativeTheme.themeSource = "dark", 100);
}

limber skiff
#

what about the shit font

austere talon
fossil inlet
#

what shit font wires

limber skiff
#

THE FONT TOO

austere talon
#

it looks so weird now

austere talon
#

cause i got used to the bugged devtools

#

basically it failed to apply a stylesheet lol

limber skiff
#

they somehow made devtools soooo ugly

fossil inlet
#

@austere talon you should update and bump vesktop blobcatcozy

austere talon
#

guess what i'm doing rn

fossil inlet
#

i wonder if the new devtools use the system default font

#

because its really inconsistent

limber skiff
#

discord has to bump to 32.2.5

#

someone tweet to that guy i forgot the name

fossil inlet
limber skiff
#

look how ugly it was

fossil inlet
#

it looks like normal, am i crazy

limber skiff
#

the font is so bad

fossil inlet
#

ehhhh

#

i dont mind it that much

limber skiff
#

I got used to it too

#

but it is horrible.

fossil inlet
#

because it never worked for me

#

weird

limber skiff
#

for a long time

#

vencord has it too

austere talon
#

it does work lol

fossil inlet
#

nop blobcatcozy

limber skiff
#

-/prefetch-src/ -/Forced\sreflow/ -/handler\stook/ -/Slow\snetwork\sis/ -/'interest-cohort'/ -/Third-party/ -/Custom\sstate\spseudo/

limber skiff
#

added a new one just rn lol

fossil inlet
#

still just -1 line blobcatcozy

austere talon
#

inconvenient

limber skiff
limber skiff
austere talon
#

i like using it for search

limber skiff
#

you were the one to suggest one in the past lol

austere talon
#

and searching is inconvenient when ur search bar is full

fossil inlet
#

the handy devtools filters:

limber skiff
#

you can just ctrl F

charred monolithBOT
charred monolithBOT
fossil inlet
#

is it possible to use a store in react and re-render with store updates

brazen bone
#

useStateFromStores

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None