#๐Ÿ‘พ-core-development

1 messages ยท Page 214 of 1

opaque silo
#

@wary palm ?

dapper tiger
#

@opaque silo


@zt64 Don't use replaces on AUR. They don't work / just cause problems. The usual intended behavior is done with provides/conflicts.

If you want users to be able to switch from old package, you have to change the old package into a metapackage. Then when it's rebuilt and installed, the new package will be installed.
#

i really dont like this its risky

opaque silo
#

i will do anyway

dapper tiger
#

they think i did the replaces change

#

sfjnsdhfbsd

#

@opaque silo hold on

dapper tiger
#

vesktop-git

opaque silo
opaque silo
dapper tiger
#

moving too fast

#

i dont wanna mess this up

#

check comment they updated

opaque silo
#

i mean none of them build in clean chroot rn :p

dapper tiger
#

its still using the old version

#

what

#

i reallllly dont like this

opaque silo
#

system issue?

#

it clones correctly for me

dapper tiger
#

youre running paru -S vesktop-git?

opaque silo
#

no im cloning it with git

dapper tiger
#

Bruh i figured ito ut

opaque silo
#

what was it

dapper tiger
opaque silo
#

HHAHAHAHA

#

aur helper moment

#

i think easiest route is just change the replaces to conflict and delete the old package

#

aur helpers warn about deleted packages

#

and manual clone users will check the aur and see its gone

dapper tiger
#

๐Ÿ˜ญ

opaque silo
#

metapackage too complicated

dapper tiger
#

you tell them in comments theyll think its me

opaque silo
#

why do u not agree ๐Ÿ˜ญ

dapper tiger
#

if you know itll work

#

gonna see what i can do about chaotic aur

opaque silo
#

i use a wrapper for chaotic aur

#

so when i wanna use it i type cparu

dapper tiger
#

well chaotic-aur/vesktop-git is the wrong package name

#

its using system electron

#

actually i think its just based on the aur one

#

so maybe once it rebuilds itll be ok

opaque silo
#

yeah it will

dapper tiger
#

@opaque silo fix provides/conflicts thing

#

ill have to go soon

opaque silo
#

ok

#

i did

#

u do aurpublish vesktop-git

dapper tiger
opaque silo
#

are u converting to a metapkg?

dapper tiger
#

idk

#

should i

opaque silo
#

seems overkill imo

#

ppl can manually switch

#

they wont lose settings or anything so

dapper tiger
#

i updated vencord-desktop-git provides/conflicts from vencord to vesktop

opaque silo
opaque silo
#

goodnight vencorders

#

aur reckoning has passed

#

I think everything works

glass jasper
opaque silo
#

I'm beginning to think it isnt a joke,.,.,.

fossil inlet
glass jasper
fossil inlet
wary palm
#

Works now, thanks @opaque silo

charred monolithBOT
charred monolithBOT
shy veldt
#

@austere talon grrr

#

removing isStaff patch ๐Ÿ™„

#

patch this smh

austere talon
charred monolithBOT
dusk blaze
#

just set the char to an empty unicode bro

#

not that hard

brazen bone
#

But I'm probably not gonna pr that one, it's too silly

jolly tundra
# charred monolith

So maybe I'm missing something but I based that styling off of the styling in the setting like Accessibility > Saturation or in My Account > Authenticator App. There they seemed to be using --custom-margin-margin-medium for the bottom margin which appeared to be 20px for me... the font size should also be the same since I'm using the exact same classes besides the margin for styling? Maybe settings are just formatted differently accross discord idk...

austere talon
#

you did it between the description and the control element

#

but yeah discord isn't very consistent themselves xd

frail skyBOT
#
Bad Patches

Experiments (had no effect):
ID: 984370
Match: ```
/\i.isStaff()/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

Experiments (had no effect):
ID: 984370
Match: ```
/\i.isStaff()/


**__ConsoleJanitor (found no module):__**
ID: `-`
Match: ```
"Handling ping: "

ReviewDB (found no module):
ID: -
Match: ```
.PANEL,isInteractionSource:

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

reviuwerdb explosion @crude hearth

limber skiff
#

I will fix

jolly tundra
austere talon
limber skiff
#

alright

austere talon
limber skiff
#

I feel like we should not match how discord settings are for our plugin settings

austere talon
#

but check a drop down from discord

#

they do 16 there

limber skiff
#

a compact style would be better in my opinion

jolly tundra
#

Yeah the main downside of the PR i made is that settings have more height than before obviously

austere talon
#

eh it's a double edged sword

limber skiff
#

they bumped electron on canary

austere talon
#

having a proper title description is more user friendly

limber skiff
#

and I got flash banged

austere talon
#

what electron version is that

limber skiff
#

32

#

why is the font still so wonky

#

god

jolly tundra
#

Comic sans in dev tools when

crude hearth
opaque silo
limber skiff
#

they are insanely good in fucking up the devtools

#

every version it gets worse

austere talon
#

yeah lmao

opaque silo
#

its so annoying too cause chromium is finally fixing hardware accel on Linux

austere talon
jagged cloak
#

oml yeah

glass jasper
# limber skiff

so thatโ€™s why I keep getting flash banged, and I have to keep going into the settings and change it, from system preference to dark every single time (even though system preference is dark)

limber skiff
#

@austere talon this enables that different topbar menu lol

austere talon
#

wdym

limber skiff
#

the experiment is controlling this

#

maybe they are gonna allow more people to report bugs

dapper tiger
#

ok this actually looks worse

#

the icon

austere talon
#

oh ic

austere talon
dapper tiger
#

@opaque silo

#

reverttttttttttttttttttttt

austere talon
#

wdym

#

try her logo

dapper tiger
#

idk how

austere talon
#

she made a diff one

dapper tiger
#

guh

glass jasper
opaque silo
dapper tiger
#

its so uglyyy there

opaque silo
#

THAGD WHY IM 2ORKING ON NEW ICON

glass jasper
opaque silo
#

whar?

limber skiff
fossil inlet
#

does bumping electron actually do anything good?

limber skiff
#

alright

shy veldt
shy veldt
opaque silo
fossil inlet
charred monolithBOT
austere talon
#

discord os

opaque silo
austere talon
#

not for me blobcatcozy

charred monolithBOT
opaque silo
austere talon
#

u mean for streams ?

opaque silo
#

nop ik encoding works for that

#

other aspects of hardware accel

austere talon
#

then wtf are u encoding in discord

opaque silo
#

decodinf

charred monolithBOT
limber skiff
#

now I sleep

austere talon
#

In the afternoon?? ๐Ÿ˜ญ

frail skyBOT
#
Bad Patches

ReviewDB (found no module):
ID: -
Match: ```
.PANEL,interactionType:

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

(expected, patch is not compatible with stable, doesn't matter tho)

charred monolithBOT
limber skiff
austere talon
#

lmao ๐Ÿ˜ญ

#

good night

limber skiff
#

It's on purpose tho, i've been doing stuff during the night so it's the only way to be able to go to college and not die

#

gn blobcatcozy

opaque silo
brazen bone
#

I'm up at five nested menus now

austere talon
charred monolithBOT
dusk blaze
#

too long itll get cut off

charred monolithBOT
#

thank you for the contribution! like I said on discord, I'm impressed that you so quickly figured out all apis and native capabilities

since this plugin seems to only support pdfs, perhaps a rename to PdfViewer would be good? it can still be renamed later if support for more filetypes would be added

the native file is needed due to CORS, right? if the native file is absolutely needed for the plugin to function, the plugin should be marked as desktop only by naming its folder `plugin.des...

charred monolithBOT
#

Sure I can remove it I guess. I just thought it might make sense to add some customizability... I guess the memory usage has less inherently to do with the amount of files, more the size of all the objectUrls. I was thinking of a worst-case scenario where someone might have a channel with a ton of pdf files they want to review quickly, whilst keeping them in cache, but that's probably just unnecessary and overkill.

#

That might be a somewhat hacky solution yes... I toggle the visibility of file previews via css, so I need to give each preview element a unique id which I can then use to control their display value. As a means of giving the preview an id, I grabbed the channel and message id from the the attachment url.

So for example https://cdn.discordapp.com/attachments/123456789/987654321/filename.pdf?ex=66eaae57&is=66e95cd7&hm=388f&... would simply turn into 123456789-987654321 which I then ass...

#

So the PreviewButton is the main driving force behind toggling the visibility of the preview with is a different component. The PreviewButton uses a state on it's own, but since the actual preview isn't a child of the preview button (since it's sort of in a different place) I can't really prop drill the state? I also tried adding visibility information to the message object it'self (like I do after adding the previewBlobUrl), then I would have to update the Message every time I change the vis...

austere talon
#

@brazen bone i stole code from ur pr

fallen vale
austere talon
#

reply tooltip

#

funny

teal nest
charred monolithBOT
austere talon
#

stop using random shit from Common.Forms ๐Ÿ˜ญ

#

it's only meant to be used for forms

#

it's just the entire components module for simplicity

woeful sleet
#

You wants people to grab the module again just to use a component from there?

austere talon
#

no

#

edit that file

#

add a new export and add to the destructure block

woeful sleet
#

Oh, that makes more sense. Does destructuring it like that actually change anything? Or is it just to try and keep things tidy?

brazen bone
#

I don't know if I'm gonna continue on that MessageLinkEmbed pr; as I've mentioned, the tooltips are similar enough to the embeds that it's awkward to have them separate, but different enough (at least how I envision it) that my attempts to unify them just end up as an awkward mess

#

But if you want to steal code or ideas from it, be my guest

austere talon
#

but it's kinda too large sometimes

#

idk how to deal with that

austere talon
brazen bone
#

Not really, it's just that my attempts at actually doing it are unsatisfactory

austere talon
#

i can help out maybe

#

also why didn't i do this earlier

brazen bone
#

One example of the differences is that for embeds you use a queue to load them sequentially to avoid sending requests too fast, while the tooltips are a response to user action and should be loaded as fast as possible

jolly tundra
austere talon
#

well if they're in the mega components module no reason not to use them

#

unless they don't work for some reason

#

but yes Icons.tsx are mostly discord icons

jolly tundra
#

Yeah but would you rather I hardcode the paths that discord use in the Icons.tsx or extend the components module thing and use the icon components from there?

jolly tundra
#

Just trying to be consistent with the other plugins which mostly use the Icons.tsx as far as I can tell for icons

austere talon
#

but if they're easily available in the components module then you can just use that

jolly tundra
#

k

austere talon
jolly tundra
#

I reworked pretty much all other other stuff and removed the ugly css thing

#

Ugh I guess I need to add type definitions for the icon now though...

#

I think I'm gonna stick to the Icons.tsx for now

austere talon
jolly tundra
#

I'm mostly lazy lol

austere talon
#

it's pretty easy to type

jolly tundra
#

Well I guess I should put it into an "icons" group like the forms so its cleaner

austere talon
#

these are all the props and it spreads the rest into the svg

#

so you would just do

export type EyeIcon = ComponentType<JSX.IntrinsicElements["svg"] & {
  size: string;
  // ...
}>
#

but i assume all icons take the same props, so once written it can be reused

jolly tundra
#

Wait so it's just the svg intrinsic props, size and colorClass?

austere talon
#

well anyway it's also fine to put in Icons.tsx
or type as ComponenType<any>

jolly tundra
#

Is it ok If I group it like the Forms so more Icons could be added later down the line?

austere talon
#

damn that's a lot of Icons

austere talon
#

or you could generate a full list of icon names

jolly tundra
#

I think that's a little out of the scope of a pdf viewer plugin PR though lol

austere talon
#

copy(Object.keys(findByProps("EyeIcon")).filter(k => k.endsWith("Icon")).map(JSON.stringify).join("|"))

slap it in a new file called iconNames.d.ts

austere talon
#

fairly normal to amend api when adding features that need it

jolly tundra
#

The feature in question: Icon husk

#

You're the boss

austere talon
#

it's fine

#

i mean i can do it in a separaze commti if u want

#

and u just merge into ur branch

jolly tundra
#

I mean if you don't care I can do that, I just thought you'd want the PR scope to not be too huge or whatever

brazen bone
#

What electron version does discord and vesktop use? And more importantly what chrome version does that correspond to?

austere talon
#

30+

#

very modern chrome

#

why

#

what do yu want to use

charred monolithBOT
brazen bone
#

I'm thinking to try to merge my MessageColor plugin, which uses color-mix(), into RCE

austere talon
#

yes you can

#

it's supported everywhere

#

well, vendroid users with old android will cry

rugged spire
rugged spire
brazen bone
charred monolithBOT
austere talon
#

there

jolly tundra
#

Can you pls maybe add the spinner component whilst your at it ๐Ÿฅน

austere talon
#

๐Ÿ˜ญ

jolly tundra
#

lmao

austere talon
#

u add it

jolly tundra
#

k

austere talon
#

u were too slow sorry..

jolly tundra
#

I will live

austere talon
jolly tundra
#

Wait am I supposed to put dev as my target branch in the pr instead of main?

austere talon
#

well in this case you'll have to

#

or cherry pick that commit

marsh spruce
#

how do I find the react for it?

austere talon
#

react devtools

marsh spruce
#

so found the onclick button?

jolly tundra
#

Sorry the PR has like 8 commit now

#

Can probably squash some of those

marsh spruce
austere talon
#

it gets squashed in the end anyway

#

some of my prs have dozens of commits xD

#

better not to squash in prs cause if you do, it makes it harder to review

#

pr -> get review -> fix review -> reviewer checks your changes to see if they satisfy the review

if you squash, the reviewer can't see what you changed and has to read the whole code again

marsh spruce
austere talon
#

i can't help you with that

#

reverse engineering minified js is part of making plugins

austere talon
#

look at it inside your devtools

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

marsh spruce
#

cause it looks similar to the guide you made

austere talon
#

idk

#

you have to know

marsh spruce
#

this section honestly makes the most sense to me

marsh spruce
grave mangoBOT
marsh spruce
#

now I know what to replace, how do I get to execute code for me?

charred monolithBOT
fossil inlet
#

jumping to modules coming soon

charred monolithBOT
glass jasper
#

css?

#

oh... i already said that

glass jasper
clear jasper
glass jasper
limber skiff
#

@austere talon btw nitpick but we should start enforcing React.ComponentPropsWithRef and React.ComponentPropsWithoutRef insteadof JSX.IntrinsicElements or React.HTMLAttributes

https://stackoverflow.com/questions/64867112/difference-between-react-htmlpropshtmldivelement-and-react-detailedhtmlpropsr

#

so for example

gritty iris
charred monolithBOT
wary relic
#

horror

torpid vessel
#

horror indeed

charred monolithBOT
fossil inlet
# charred monolith

Hi, I really want to fake discord screenshots but I'm too lazy to use inspect Element

torpid vessel
#

i am gonna explode

charred monolithBOT
scenic brook
charred monolithBOT
limber skiff
#

okay that's getting too much out of scope, that should be good enough utilities to use for the future

torpid vessel
#

"yes"

fossil inlet
torpid vessel
limber skiff
scenic brook
#

Which I am thankful for

fossil inlet
dusk blaze
#

squashing my beloved

torpid vessel
#

i didnt even change the commit msg

fossil inlet
#

One time I pushed like five commits with the same message to test an action

limber skiff
#

help

charred monolithBOT
still wasp
charred monolithBOT
limber skiff
#

guys I lied

torpid vessel
#

i think u need one more commit

dusk blaze
charred monolithBOT
brazen bone
limber skiff
#

tests passing which means yes I'm done now

torpid vessel
#

i was right

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

I lied again

charred monolithBOT
limber skiff
charred monolithBOT
limber skiff
#

i-

torpid vessel
#

the moment nook finishes fixing that thing is the moment they'll take a nap

charred monolithBOT
torpid vessel
jolly tundra
#

Amend commit?

charred monolithBOT
limber skiff
#

no i dont wanna force push

#

okay there

#

ugh did i really import react there??

torpid vessel
#

yop

charred monolithBOT
limber skiff
#

...

charred monolithBOT
jolly tundra
limber skiff
#

it's a branch so it doesn't matter

#

if anything it's sending messages here

torpid vessel
#

its just gonna squash once its merged right

limber skiff
#

yeah

#

dude I messed up again

torpid vessel
charred monolithBOT
limber skiff
#

perfect

jolly tundra
#

Actually that doesn't look like vscode at all

#

More like jetbrains

#

Nvm i cant read

fossil inlet
austere talon
fossil inlet
#

He saw that and copied what I did into JetBrains WebStorm.

jolly tundra
#

I see

fossil inlet
#

There's a PR for it somewhere to be merged ETA 2027

jolly tundra
#

Don't think discord will exist that long tbh

austere talon
#

fully functional

#

idk why discord shows such a limited fucking menu

torpid vessel
austere talon
#

for reference: default one

torpid vessel
#

jesus christ

#

that is limited

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
glass jasper
charred monolithBOT
austere talon
#

ALREADY BANNED

glass jasper
austere talon
#

github is faaast damn

glass jasper
#

discord need to use what ever support team github uses

woeful sleet
# charred monolith

I don't know anything, but there's some folk that seem pretty staunch against embed for various reasons. They talk about some security stuff here, I'm not sure how much of it is an actual issue, though

https://github.com/whatwg/html/issues/4592

GitHub

See #4590 Also we should probably more directly recommend to use iframe for HTML (and PDF?) and img for images, instead of embed/object. also #3752 (comment) object and embed are typically treated ...

charred monolithBOT
torpid vessel
#

sad finally

torpid vessel
#

oop wrong reply

dusk blaze
fossil inlet
torpid vessel
fossil inlet
torpid vessel
clear jasper
glass jasper
#

i just going to send this then leave this convo

charred monolithBOT
torpid vessel
#

lets gooooo rc_ryanoo

charred monolithBOT
torpid vessel
#

need opinion:
should i put the separator before the button placeholders or after the button placeholders or should i just put them before mention toggle

fossil inlet
torpid vessel
#

just like how chatinputbuttonsapi implements it

austere talon
#

what even is the use case for this

torpid vessel
#

i pressed send too early

#

some plugins could use a toggle qol feature like noreplymentions

where instead of manually changing the setting store via settings, just update it via a button near the reply toggle

#

something like @ON (set as default) | X

and that would update the settings for that user ig

#

or i could just implement it directly to NoMentionReply, but what if other plugins come in the future that wants to adds buttons to the reply bar

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

lean ingot
rugged spire
lean ingot
#

What is it?

fossil inlet
#

iirc new nitro feature

rugged spire
#

Stock experiment

#

yeah

#

it requires nitro and idk if it even works

#

guh

lean ingot
#

oh yeah i turned that on, but it didn't have arrow thing because i don't have nitro

#

oh yeah and i thought this was part of it

#

ig it's not?

#

what's that

austere talon
#

summaries

fossil inlet
#

?remind 4pm pr console logger new feature

shut vineBOT
#

Alright @fossil inlet, in 17 hours, 32 minutes and 4 seconds: pr console logger new feature

torpid vessel
#

?remind 8am finalize pr for replybuttonapi *initial

shut vineBOT
#

Alright @torpid vessel, in 4 hours, 56 minutes and 19 seconds: finalize pr for replybuttonapi

charred monolithBOT
fossil inlet
fossil inlet
#

@placid hinge

#

(sorry for ping, testing smth)

#

?remind 5pm fix hidden modal bug

shut vineBOT
#

Alright @fossil inlet, in 16 hours, 41 minutes and 52 seconds: fix hidden modal bug

charred monolithBOT
sterile oak
#

eh. can be better

prime dew
#

I wouldn't place it there, but rather just below it, as a side menu of "Set Custom Status"

sterile oak
rugged spire
sterile oak
rugged spire
#

login with qr blobcatcozy

sterile oak
#

I can't login into my account SKULL_SKELETON

#

tried removing the auth app, it wants a 2fa code fr

rugged spire
#

hope you have 2fa recovery

limber skiff
#

I don't have it too

sterile oak
rugged spire
#

5 seconds is not enough for it to matter though

#

Did you mean 5 minutes?

#

Did you mean setting the time manually with the wrong timezone set?

gritty iris
sterile oak
rugged spire
gritty iris
#

I was off by like 10s and my 2 auth apps wouldn't open

#

I love when windows fails to sync time :)

brazen bone
#

We need to abolish time entirely one of these days

gritty iris
#

Real

prime dew
sterile oak
brazen bone
#

I have the bubble on web

sterile oak
brazen bone
#

Skill issue

charred monolithBOT
shut vineBOT
#

@torpid vessel, <t:1726715021:R>: finalize pr for replybuttonapi

brazen bone
#

What's a replybuttonapi?

#

Sounds oddly specific

charred monolithBOT
torpid vessel
#

i added the same thing but for the reply bar

torpid vessel
#

yop

rugged spire
#

...but why?

#

What's your use-case?

torpid vessel
#

honestly, i was gonna bake this in NoReplyMention alone because its litr the only plugin that could use it atm

brazen bone
#

And why does it need to be an api rather than just a one-shot patch

rugged spire
#

Patching places like this multiple times gets ugly quickly

brazen bone
#

Sure, but that only applies if you do have multiple plugins that want to patch that place

torpid vessel
#

Make default ping button | @ON/@OFF | (close button)

so it updates the settingsstore via the button so the end user doesnt have to keep going back to plugin settings just to add users and remove users from ping preferences

#

i made it an api just in case other ppl wants to use the same func for reply bar in the future,

its essentially just 1 api call like how chatbar buttons implement it via .add and .remove

rugged spire
torpid vessel
#

buuuut, i'm actually doubting on doing the whole bit rn, despite having a working version and just integrating it to NoReplyMentions alone

torpid vessel
# rugged spire <:blobcatcozy:1026533070955872337>

here's an example of a plugin just calling the api to add the button (in this case - InvisibleChat),

its essentially the same thing as ChatBarButton but with differences to support reply context, and settings

rugged spire
charred monolithBOT
limber skiff
#

vencord with its giant name

#

egirl paradise too

charred monolithBOT
fossil inlet
# limber skiff

Love Mika Paradise | VC EGirlsโ€ขSocialโ€ข
Emotes Nitro Gamingโ€ข Memes Call Chill Anime

prime dew
brazen bone
#

Nothing

#

It's always been this

fair wolf
#

I should look into reworking my pr

brazen bone
#

Why? All PRs are perfect from the start, no read to rework things ever

limber skiff
#

say that to my 20 refactors in the same PR

bleak blaze
#

the pr version of that

#

cause i tried to get that version and it gave me the one without guild pfp and itโ€™s not functioning properly i mustโ€™ve got an outdated version

bleak blaze
limber skiff
#

do you have a dev install?

bleak blaze
#

yes

limber skiff
#

checkout the dev branch and re-build

bleak blaze
#

oh okay thanks thatโ€™s why it didnโ€™t work

sterile oak
bleak blaze
#

cause theyโ€™re used to changing their status a certain way and ur changing that flow by putting the dropdown there

sterile oak
bleak blaze
sterile oak
#

don't want to create something; no one would use

bleak blaze
#

well capitalize the first letter for the presence

#

rather than lowercase online do Online first letter capitalized

#

also the size looks off for
icon

sterile oak
charred monolithBOT
limber skiff
#

don't hate me

#

just getting rid of unnecessary memos

#

soooo cool

charred monolithBOT
bleak blaze
#

there's so many branches under different names dev, dev2 etc

#

could you link it by chance

limber skiff
#

do you not have it setup by git

bleak blaze
#

because i don't want to override existing custom plugins

limber skiff
bleak blaze
#

ah

#

i see what you mean

limber skiff
#

you can ignore dev2

bleak blaze
#

its not displaying the server icon for me pretty sure and i dont have the click functionality

limber skiff
#

does the server have an icon

bleak blaze
#

yes

limber skiff
#

show me

bleak blaze
#

this is when hovering over the icon

#

and this would be the server itself

#

you can see the icon above in my serverlist

limber skiff
#

it doesnt have the server name

bleak blaze
#

weird cause im going to the devbranch it just keeps giving me the wrong files

limber skiff
#

did you pnpm build again

bleak blaze
#

yes

limber skiff
#

#๐Ÿค–-bot-commands

bleak blaze
limber skiff
#

ah

bleak blaze
#

because it was under a different name so that's why it was crashing when opening settings

#

im sorry

#

restarting client now

#

fixed

#

yeah that's cool its nice

limber skiff
#

nice

bleak blaze
#

you have on click jump to channel

#

double click to join

#

if you really want to take a step up rather than just displaying icons of users, when right clicking the icon itself display a member list of the people in call with their icons, and usernames

#

basically like a slider-menu idk the correct word for it

limber skiff
#

ehh

#

too much

#

you can just jump to the channel for that

bleak blaze
#

good job though its way better than the previous uservoiceshow

#

you might want to prevent accidental clicks from the user to prevent them from opening DM @limber skiff or closing it

#

idk if it does that already

limber skiff
#

huh?

bleak blaze
#

like

#

nvm sorry

#

i think thats already implemented because nothing in the background like the other elements, have any interference with mouse clicks

limber skiff
#

oh yeah

#

already did that

charred monolithBOT
charred monolithBOT
austere talon
#

uhh

#

my new plugin

#

incompatible with message lagger

brazen bone
#

Message lagger, does that like make messages send only the first letter and then edit them back in one at a time?

#

That's a terrible plugin idea

shut vineBOT
#

@fossil inlet, <t:1726712876:R>: pr console logger new feature

bleak blaze
#

ability to copy stickers, we have that with emojis but not with stickers

#

you can copy the url, of a sticker but the output format is so horrible it makes it look degraded and the size itself is awful and when clicking it doesn't show u origin of sticker itself

#

so yeah we definitely need a copy sticker either in the context menu or highlighting it and then doing ctrl+ c and putting it into textbox

sterile oak
shut vineBOT
#

@fossil inlet, <t:1726719488:R>: fix hidden modal bug

bleak blaze
#

and not the raw data of the sticker you basically are selecting the sticker from the menu

#

multistickers

#

allows you to select up to 3 stickers from the sticker menu

austere talon
#

btw i noticed that deleted messages now have all options

#

we should clean it up i think

fair wolf
spark pivot
#

role color everywhere plugin
look inside
rce

lean ingot
#

should i make a pr to update vencord's reply icon?

brazen bone
#

Vencord's does look much better

limber skiff
#

what's with the duplicate buttons

#

why did they start to happen randomly?

fossil inlet
#

bug in quick reply

#

i think im going crazy ||that was prob wrong||

limber skiff
#

we all are

rugged spire
austere talon
#

it's vencord plugin bug

#

alr fixed

#

in dev

frail skyBOT
#
Bad Patches

ShowHiddenThings (had no effect):
ID: 762692
Match: ```
/\i.\i.get({url:\i.\i.GUILD_DISCOVERY_VALID_TERM,query:{term:\i},oldFormErrors:!0});/g

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

ShowHiddenThings (had no effect):
ID: 762692
Match: ```
/\i.\i.get({url:\i.\i.GUILD_DISCOVERY_VALID_TERM,query:{term:\i},oldFormErrors:!0});/g

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

blehhhhhhhh

#

two finds

#

oh nvm

#

its all

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

@limber skiff pub? + bump

#

any objections

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

lean ingot
charred monolithBOT
limber skiff
fossil inlet
#

@glass jasper why hysk

#

new icon so much better

limber skiff
#

I'm gonna change a user voice show patch

#

cuz it looks weird in friends list

austere talon
charred monolithBOT
#

FYI to readers considering using my fork for aesthetic reasons: I intend on maintaining this PR for as long as I use Vencord (ie. for the foreseeable future) and I intend to keep it as up-to-date as possible. It's very stable and I haven't noticed any bugs for a long time. If you'd like to use this as a fork, go ahead; if you notice any bugs, be sure to leave a comment on this PR and I'll work on them.

fossil inlet
#

@limber skiff question
for console janitor, would you mind if i pr'd a feature that just removes all the purple discord logs

rugged spire
#

the fuck is going on here

fossil inlet
#

i ate your webpack

rugged spire
#

the Hack in one of my plugins got broken by a recent change

fossil inlet
#

how did i just learn neovim supports code lens

#

guhh

#

vencord-neovim after i finish the vscode version

#

ill make generic LSP verison

rugged spire
#

its this

limber skiff
#

proxyLazy the command object

rugged spire
#

let me try

limber skiff
#

you have to proxyLazy every command that uses i18n

rugged spire
#

i didn't know how to do that at the time

#

so I used this horrible hack

fossil inlet
rugged spire
limber skiff
#

omg I just had the worse idea of my life

#

so we know how webpack searches depend on the cache (so a module being already loaded)

#

which means at the moment vencord runs no webpack module has been loaded, thus we proxy everything

#

what if

#

Vencord would only run files that depend on webpack searches once webpack has finished loading the core stuff

fossil inlet
#

isnt that just plugin.startAt

limber skiff
#

and going even further, it would searches the loaded modules instead of the cache to manually require anything that needs to be required

#

which means

#

you would be able to use i18n in top level

rugged spire
limber skiff
#

React.memo in top level

#

this idea is actually possible

limber skiff
#

but it would be an even bigger rewrite than my current pr

limber skiff
#

ideally, the only files we would load initially from Vencord is the settings one and the patchWebpack

#

all of the rest would run after webpack is ready so we can do our searches and require stuff

rugged spire
#

while you're modifying console janitor can you make NavigationRouter loggers toggleable separately?

#

the Routing/Utils one

#

i think

limber skiff
#

webpack commons wouldn't even need to be proxies or waitFor anymores

fossil inlet
#

if so, sure

limber skiff
#

they would be a webpack require just like discord would normally do

rugged spire
limber skiff
rugged spire
#

also devtools window title location doesnt update

#

well, not properly (?)

fossil inlet
#

@rugged spire nav router is Routing/utils, right

rugged spire
#

you will read chat history

#

2 semi-confident people makes a right.... right?

fossil inlet
#

guhhhh

#

im blind

charred monolithBOT
fossil inlet
#

best find ever

#

find: "ฮฃ:"

rugged spire
#

i can only imagine this would be a codeblock language thing

fossil inlet
#

its the discord logger module

rugged spire
#

what the fuck even causes that to be logged

#

is this a performance timer?

fossil inlet
#

idfk

charred monolithBOT
fossil inlet
#

i eep now

rugged spire
#

there is probably a Slightly Better Way to do this blobcatcozy

rugged spire
#

Yop

fossil inlet
#

What part is done badly

rugged spire
#

Why not just make a list of allowed loggers

#

This feels wrong

fossil inlet
rugged spire
#

And why haven't you decided to PR that to upstream instead?

fossil inlet
#

I just donโ€™t think a list is the right choice

rugged spire
#

Hm

#

True

#

bad ux?

fossil inlet
#

If Nuckyz / vee want that, Iโ€™ll add it

fossil inlet
limber skiff
#

is this weird

rugged spire
#

Something feels off about it

brazen bone
#

You playing roblox is weird

rugged spire
#

I don't know how to describe it though

limber skiff
#

the fucking div with the name and activity is flex column guh

limber skiff
prime dew
limber skiff
#

meh its not even cuz of that tbh

#

its jsut the button in a weird place

prime dew
#

Oh I didn't even notice that lol

limber skiff
#

I might just do a higher component and place it here

#

to match those buttons

prime dew
#

Is that in the friends list?

limber skiff
#

yes

prime dew
#

It would definitely look better

#

But then, wouldn't it just be a copycat of the active now tab?

limber skiff
#

meh

#

its fine

limber skiff
#

alright this is better

limber skiff
#

did I cook

rugged spire
#

Yes

#

Also this seems to be an extension to part of a new feature is the stock version an experiment or not?

limber skiff
#

idk but its good

#

neat as fuck

charred monolithBOT
limber skiff
#

I lowkey cooked

#

that genuinely looks so good

limber skiff
charred monolithBOT
#

b822542 BetterFolders: Fix pending clan applications (#... - sadan4
292f7d7 AppleMusicRichPresence: fix metadata fetching (... - ryanccn
f17b92c OpenInApp: support Spotify prerelease links (#2... - Covkie
bcfef05 delete TimeBarAllActivites ~ now a stock feature - Vendicated
640d99d delete NoDefaultHangStatus ~ Removed feature - Nuckyz

#
[Vendicated/Vencord] New tag created: v1.10.2
limber skiff
#

fly high

charred monolithBOT
rugged spire
limber skiff
#

LOL

#

that's a great sign

#

if the shit looks stock then it looks good

rugged spire
#

it is user voice show ๐Ÿ˜ญ

#

i assumed it wasnt

#

because of where it was placed and how it was styled

#

being a tooltip thing

#

and in the sidebar

grizzled halo
#

You cooked it ngl

dusk blaze
#

yop

fossil inlet
#

I thought it was an experiment

rugged spire
#

IT GOT YOU TOO?

prime dew
#

it's just so good

limber skiff
#

no fucking way ๐Ÿ˜ญ

turbid hatch
#

vencord

#

making features that should be in stockโ„ข๏ธ

prime dew
#

unironically, that's the same thing I tell my friends when they say "I already have Nitro, I don't need Vencord"

brazen bone
#

I already have vencord, I don't need nitro

fossil inlet
# limber skiff LOL

And somehow saw you working on it here and thought you were just modifying it to make it look a bit better.

limber skiff
#

LMAOOOO

#

:help me

fossil inlet
#

Anyways, that was a good job

bleak blaze
#

did you make it so the user voice show icon shows in the chat too?

limber skiff
#

that's icons for group dms and direct messages

bleak blaze
#

like letโ€™s say someone is texting

limber skiff
#

it's not a guild, it's the group/user name and its icons

bleak blaze
#

oh okay yeah thatโ€™s nice then

#

nice feature

#

if you really want to implement a toggle to add the icon within server chat too

limber skiff
#

before it wouldnt even show the user/group name

bleak blaze
#

so you know whether a person is in call or not

#

idk if you have that implemented already

limber skiff
#

here u mean?

bleak blaze
#

yes

limber skiff
#

u should update ur vencord btw

bleak blaze
limber skiff
#

no

#

everything

#

so ur up to date

#

just paste the files again

#

and overwrite everything

charred monolithBOT
bleak blaze
limber skiff
#

I can definitely make it a setting

limber skiff
#

ewww why does it expand

#

why the fuck is this a span discord

#

that's so annoying

woeful sleet
#

Saves time. Ain't nobody going to take the time to set inline on all those different elements, that'd be crazy

limber skiff
#

it should be a flex box

#

with align items center

woeful sleet
#

Didn't it used to be? Did someone get told off for all the cursed flexboxes?

limber skiff
#

why is that arrow not aligned lol

woeful sleet
#

Are you using some negative margins or something?

limber skiff
#

nop

#

after I hover in another tooltip it fixes itself

#

huh

#

weird

limber skiff
#

it doesnt happen only in messages

#

hmmm

#

the position is different

austere talon
#

the tooltip arrow?

#

try using TooltipContainer instead of Tooltip

limber skiff
#

didnt work

#

this is the faulty css

#

which is weird because in permissions viewer I do the same and no issue

#

no idea how to fix

charred monolithBOT
limber skiff
#

@bleak blaze there you go

charred monolithBOT
limber skiff
#

ughhh really

#

I undid something

charred monolithBOT
charred monolithBOT
fast pasture
#

when you build vencord can you get standalone VencordInstaller.exe?

#

so like you pack everything into .exe

fossil inlet
#

the installer is in a seprate repo

#

vencord/installer

fast pasture
#

oh thank you so much

prime dew
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

ReviewDB (found no module):
ID: -
Match: ```
.PANEL,interactionType:

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

fossil inlet
#

is there any reason to keep the pronoundb part of pronoundb instead of making it a pronouns in chat plugin

charred monolithBOT
bleak blaze
#

ur using newer modules or something

#

both P and match

bleak blaze
#

this is unrelated but you know how you're in a voice channel, and you restart your discord it prompts you this banner with the ability to join

rugged spire
#

Not to my knowledge

#

Though, i would that edit users should be finished first before touching that

fossil inlet
#

oh yea i forgot

#

i wanted to work on edit users

bleak blaze
#

Idea:
Disabling that prompt, and replacing it with a new UI Guild Icon, Guild Name, Previous Channel name, option to join VC and then an option to join later after a certain duration because sometimes people restart their discord with the intention to resolve a issue

#

pretty much similar to your current design just a little bit bigger

#

not really necessary but its just to remove that ugly banner when you restart lol

austere talon
#

not really useful

rugged spire
#

it really is a lot of work for something you can remember yourself blobcatcozy

charred monolithBOT
#

i wouldn't say that the implementation is really the same - because i gave the user between two default options: Insert the link into the chatbox, or send immediately. then, on top of that, i gave them the option to perform the opposite behavior by holding down shift.

you might think that this is equivalent to providing the user with three options (which you did): Insert the link into the chatbox, send immediately, or insert link if shift is held, but it isn't. with your implementation, yo...

bleak blaze
#

something discord should fix themselves theyve done every other ui except for that

#

reminds me of the old discord mobile app ui

limber skiff
limber skiff
#

my theme is so dark I didn't even notice those issues

charred monolithBOT
fair wolf
#

wait ๐Ÿ’€
did discord stop using react-dnd

rugged spire
#

i don't know?

fair wolf
#

Why can't I find the named functions but yes the Webpack modules

prime dew
limber skiff
#

๐Ÿ˜ญ why is this shit not aligned

rugged spire
charred monolithBOT
limber skiff
#

I fixed it I guess

#

hey so

charred monolithBOT
limber skiff
#

yeah another force push

#

this is still broken tho

charred monolithBOT
limber skiff
#

RCE

glass jasper
brazen bone
#

feat(RCE): eval every incoming message

limber skiff
#

people might not know what saturation means

dusk blaze
#

remote code execution

austere talon
#

aka never updating on role colour changes which was actually problematic because often this made messages uncoloured

#

lewi made a pr like that ages ago but it has been im limbo because that's kinda a major issue

turbid hatch
#

thats actually a much nicer version of my PR

#

i like that, id actually use that

#

but yeah, the primary issue was that when you first hop into a channel the messages werent colored properly since it didnt have the role info at the time