#๐พ-core-development
1 messages ยท Page 214 of 1
@opaque silo
@zt64 Don't use replaces on AUR. They don't work / just cause problems. The usual intended behavior is done with provides/conflicts.
If you want users to be able to switch from old package, you have to change the old package into a metapackage. Then when it's rebuilt and installed, the new package will be installed.
i really dont like this its risky
i will do anyway
what package is this
vesktop-git
idk I just followed PKGBUILD wiki
what for
i mean none of them build in clean chroot rn :p
youre running paru -S vesktop-git?
no im cloning it with git
Bruh i figured ito ut
what was it
HHAHAHAHA
aur helper moment
i think easiest route is just change the replaces to conflict and delete the old package
aur helpers warn about deleted packages
and manual clone users will check the aur and see its gone
๐ญ
metapackage too complicated
you tell them in comments theyll think its me
why do u not agree ๐ญ
okay do
if you know itll work
gonna see what i can do about chaotic aur
well chaotic-aur/vesktop-git is the wrong package name
its using system electron
actually i think its just based on the aur one
so maybe once it rebuilds itll be ok
yeah it will
does vencord-desktop-git need any changes
are u converting to a metapkg?
i updated vencord-desktop-git provides/conflicts from vencord to vesktop
next up Nix? /joke
I'm beginning to think it isnt a joke,.,.,.
ill do that after i have finished my basic LSP for webpack modules
i pled the 5th
there might be a slight bug in my code
Works now, thanks @opaque silo
what are we thinking about https://github.com/Vendicated/Vencord/pull/2884
e26986f AppleMusicRichPresence: fix formatting when lis... - lumap
c572116 BetterSettings: Add submenu for plugins (#2858) - Kyuuhachi
i definitely agree that it's confusing that the description is used as title and the name itself isn't displayed anywhere and the fact that this is inconsistent with boolean settings
but i think in its current state it also looks a bit odd
20 seems too much, discord seems to use 16! also perhaps we could match their font size
<Forms.FormText className={Margins.bottom16} type="description">{option.description}</Forms.FormText>
i don't think this is a good idea because it could be considered spam and get automodded
also you can just do this with textreplace plugin if you really want
This gave me another idea
But I'm probably not gonna pr that one, it's too silly
So maybe I'm missing something but I based that styling off of the styling in the setting like Accessibility > Saturation or in My Account > Authenticator App. There they seemed to be using --custom-margin-margin-medium for the bottom margin which appeared to be 20px for me... the font size should also be the same since I'm using the exact same classes besides the margin for styling? Maybe settings are just formatted differently accross discord idk...
that's between the title and the description
you did it between the description and the control element
but yeah discord isn't very consistent themselves xd
Experiments (had no effect):
ID: 984370
Match: ```
/\i.isStaff()/
None
None
None
Experiments (had no effect):
ID: 984370
Match: ```
/\i.isStaff()/
**__ConsoleJanitor (found no module):__**
ID: `-`
Match: ```
"Handling ping: "
ReviewDB (found no module):
ID: -
Match: ```
.PANEL,isInteractionSource:
None
None
None
reviuwerdb explosion @crude hearth
I will fix
The slider in Accessibility > Saturation has a 20px margin between description and control element
add this for pookie if you're gonna fix the experiments patch
alright
hmm tbf here it makes sense because it overlaps the marker texts
I feel like we should not match how discord settings are for our plugin settings
a compact style would be better in my opinion
Yeah the main downside of the PR i made is that settings have more height than before obviously
eh it's a double edged sword
they bumped electron on canary
having a proper title description is more user friendly
what electron version is that
Comic sans in dev tools when
Fix
https://github.com/electron/electron/issues/43367 regressions my beloved
Preflight Checklist I have read the Contributing Guidelines for this project. I agree to follow the Code of Conduct that this project adheres to. I have searched the issue tracker for a bug report ...
yeah lmao
Preflight Checklist I have read the Contributing Guidelines for this project. I agree to follow the Code of Conduct that this project adheres to. I have searched the issue tracker for a bug report ...
its so annoying too cause chromium is finally fixing hardware accel on Linux
every electron major there are 2 new improvements and 10 new regression
oml yeah
so thatโs why I keep getting flash banged, and I have to keep going into the settings and change it, from system preference to dark every single time (even though system preference is dark)
wdym
the experiment is controlling this
maybe they are gonna allow more people to report bugs
oh ic
doubt tbh xd
idk how
guh
bug reporter badge coming back?
thats the vesktop logo ๐ญofficial package should use
its so uglyyy there
THAGD WHY IM 2ORKING ON NEW ICON
just use that shiggy icon
whar?
what does this enable? just so I can write a description for the patch
does bumping electron actually do anything good?
alright
ofc, makes your devtools all white 
it wont be public
bumps chromium which is finally fixing hardware accel on linu
has hwaccel been broken?
yes 
not for me 
enc and decoding works for u???
u mean for streams ?
then wtf are u encoding in discord
decodinf
e26986f AppleMusicRichPresence: fix formatting when lis... - lumap
c572116 BetterSettings: Add submenu for plugins (#2858) - Kyuuhachi
1848b16 ReviewDB: Fix in panel profile - Nuckyz
6cce8a8 Experiments: Allow clips to be recorded without... - Nuckyz
dc7b3db Merge branch 'dev' into immediate-finds - Nuckyz
now I sleep
In the afternoon?? ๐ญ
ReviewDB (found no module):
ID: -
Match: ```
.PANEL,interactionType:
None
None
None
None
None
None
None
(expected, patch is not compatible with stable, doesn't matter tho)
I woke up at night, went to college at morning and now going to sleep

It's on purpose tho, i've been doing stuff during the night so it's the only way to be able to go to college and not die
gn 
discord will revert canary changes 
I'm up at five nested menus now
@limber skiff let me know what you think about https://github.com/Vendicated/Vencord/pull/2884 (whenever u got time)
i think it's a good idea but u said u wanna keep things compact
Replace the description with "Disables the 'HOLD UP' banner in the DevTools console. As a side effect, this also prevents Discord from hiding your token and logging you out of your account when you close Discord while DevTools is open."
This describes all of the effects the plugin has and is easy to understand.
too long itll get cut off
tbh just give the plugin a readme.md instead
thank you for the contribution! like I said on discord, I'm impressed that you so quickly figured out all apis and native capabilities
since this plugin seems to only support pdfs, perhaps a rename to PdfViewer would be good? it can still be renamed later if support for more filetypes would be added
the native file is needed due to CORS, right? if the native file is absolutely needed for the plugin to function, the plugin should be marked as desktop only by naming its folder `plugin.des...
what exactly does this do? and why? would aid maintainability to add a short doc comment
it might also be a good idea to depend on the more robust URL api instead of doing manual url manipulation
i don't think this setting is a very good idea. a plugin should never use excessive memory and should just use a sensible default that won't use too much
it's also fairly rare to even encounter a pdf so i doubt having such a high limit would be useful
wouldn't this be better solved via react state?
- this is a full cors / csp bypass, which is very bad. please make sure to validate the
urlto ensure only discord cdn urls can be fetched with this - you can just use the
fetchapi instead of using the https module, since we're finally on modern electron
Sure I can remove it I guess. I just thought it might make sense to add some customizability... I guess the memory usage has less inherently to do with the amount of files, more the size of all the objectUrls. I was thinking of a worst-case scenario where someone might have a channel with a ton of pdf files they want to review quickly, whilst keeping them in cache, but that's probably just unnecessary and overkill.
That might be a somewhat hacky solution yes... I toggle the visibility of file previews via css, so I need to give each preview element a unique id which I can then use to control their display value. As a means of giving the preview an id, I grabbed the channel and message id from the the attachment url.
So for example https://cdn.discordapp.com/attachments/123456789/987654321/filename.pdf?ex=66eaae57&is=66e95cd7&hm=388f&... would simply turn into 123456789-987654321 which I then ass...
So the PreviewButton is the main driving force behind toggling the visibility of the preview with is a different component. The PreviewButton uses a state on it's own, but since the actual preview isn't a child of the preview button (since it's sort of in a different place) I can't really prop drill the state? I also tried adding visibility information to the message object it'self (like I do after adding the previewBlobUrl), then I would have to update the Message every time I change the vis...
I don't think it's from discord, probably just some random svg I found some time ago. If you have an idea for a different/more fitting Icon that's built into discord, let me know and I can add that instead.
@brazen bone i stole code from ur pr
robbery is good
the amount of plugins that add hover functionality is crazy, this could be yet another one of them (and a good one)
Discord has their own const { EyeIcon, EyeSlashIcon } = Vencord.Webpack.Common.Forms
stop using random shit from Common.Forms ๐ญ
it's only meant to be used for forms
it's just the entire components module for simplicity
You wants people to grab the module again just to use a component from there?
Oh, that makes more sense. Does destructuring it like that actually change anything? Or is it just to try and keep things tidy?
I don't know if I'm gonna continue on that MessageLinkEmbed pr; as I've mentioned, the tooltips are similar enough to the embeds that it's awkward to have them separate, but different enough (at least how I envision it) that my attempts to unify them just end up as an awkward mess
But if you want to steal code or ideas from it, be my guest
do you have any better idea than to unify them?
Not really, it's just that my attempts at actually doing it are unsatisfactory
One example of the differences is that for embeds you use a queue to load them sequentially to avoid sending requests too fast, while the tooltips are a response to user action and should be loaded as fast as possible
Can I also put those icons into the Icons.tsx components file if I keep the same paths as discord or rather not?
well if they're in the mega components module no reason not to use them
unless they don't work for some reason
but yes Icons.tsx are mostly discord icons
Yeah but would you rather I hardcode the paths that discord use in the Icons.tsx or extend the components module thing and use the icon components from there?
Since they are discord icons then I guess?
Just trying to be consistent with the other plugins which mostly use the Icons.tsx as far as I can tell for icons
mainly because it's easier and more efficient to copy paste than webpack find them
but if they're easily available in the components module then you can just use that
k
i did it because svg finds kept breaking
I reworked pretty much all other other stuff and removed the ugly css thing
Ugh I guess I need to add type definitions for the icon now though...
I think I'm gonna stick to the Icons.tsx for now
are you not good with typescript?
I'm mostly lazy lol
it's pretty easy to type
Well I guess I should put it into an "icons" group like the forms so its cleaner
these are all the props and it spreads the rest into the svg
so you would just do
export type EyeIcon = ComponentType<JSX.IntrinsicElements["svg"] & {
size: string;
// ...
}>
but i assume all icons take the same props, so once written it can be reused
Wait so it's just the svg intrinsic props, size and colorClass?
well anyway it's also fine to put in Icons.tsx
or type as ComponenType<any>
Is it ok If I group it like the Forms so more Icons could be added later down the line?
damn that's a lot of Icons
u could do
export let Icons: Record<`${string}Icon`, t.Icon>;
or you could generate a full list of icon names
I think that's a little out of the scope of a pdf viewer plugin PR though lol
copy(Object.keys(findByProps("EyeIcon")).filter(k => k.endsWith("Icon")).map(JSON.stringify).join("|"))
slap it in a new file called iconNames.d.ts
eh it's fine
fairly normal to amend api when adding features that need it

it's fine
i mean i can do it in a separaze commti if u want
and u just merge into ur branch
I mean if you don't care I can do that, I just thought you'd want the PR scope to not be too huge or whatever
What electron version does discord and vesktop use? And more importantly what chrome version does that correspond to?
i'll add it
I'm thinking to try to merge my MessageColor plugin, which uses color-mix(), into RCE
yes you can
it's supported everywhere
well, vendroid users with old android will cry
very small change but this is neat
vendroid makes me cry
Self inflicted
there
Can you pls maybe add the spinner component whilst your at it ๐ฅน
๐ญ
lmao
u add it
k
u were too slow sorry..
I will live
take from there
just add Co-Authored-By: Kyuuhachi <caagr98@gmail.com> to the commit description and it will credit them
(assuming those are the ones you want and are correct)
Wait am I supposed to put dev as my target branch in the pr instead of main?
so i haven't found a good guide on how to find the actual react to replace the content of what i want to replace
how do I find the react for it?
so found the onclick button?
Ok well the types file has a merge conflict now which makes sense but should be an easy resolve
Sorry the PR has like 8 commit now
Can probably squash some of those
it seems to be related to this:
https://discord.com/assets/web.43c366283019593fe343.js
that's fine
it gets squashed in the end anyway
some of my prs have dozens of commits xD
better not to squash in prs cause if you do, it makes it harder to review
pr -> get review -> fix review -> reviewer checks your changes to see if they satisfy the review
if you squash, the reviewer can't see what you changed and has to read the whole code again
So I found a bunch of javascript but it's kind of hard to read
i can't help you with that
reverse engineering minified js is part of making plugins
make sure you have pretty print on in devtools and stop looking at that cause it's useless
look at it inside your devtools
None
None
None
None
None
None
None
None
className: V.friendsButtonContainer,
children: [(0,
i.jsx)(U.Qj, {
interactiveClassName: l ? V.friendsBadge : void 0,
selected: t,
route: k.Z5c.FRIENDS,
icon: E.FriendsIcon,
text: H.Z.Messages.FRIENDS
would this be what I am looking for?
cause it looks similar to the guide you made
this section honestly makes the most sense to me
I think I'll need to do a little simialr to what you did here:
index.tsx: Line 125
find: ".FRIENDS},\"friends\"",
now I know what to replace, how do I get to execute code for me?
This was requested here.
It requires a restart because of some weird caching issues
Disabled:
Enabled:
It also works in the member list and with verified bots as well
note: this isnt official, its someone using Equi name without permisson
i did gang,, i was just stating something
for now it seems like an okay change, but I still think for a future refactor settings should be more compact
@austere talon btw nitpick but we should start enforcing React.ComponentPropsWithRef and React.ComponentPropsWithoutRef insteadof JSX.IntrinsicElements or React.HTMLAttributes
so for example
Bruh
horror
horror indeed
Hi, I really want to fake discord screenshots but I'm too lazy to use inspect Element
i am gonna explode
kinda sick ngl
okay that's getting too much out of scope, that should be good enough utilities to use for the future
its dom manip too
i love ur commit messages
"yes"
Does Jetbrains provide a Built in api for that

I can't be bothered anymore
Yeah, you can add a psi reference to an element and it just works
Which I am thankful for
I have to parse the AST myself in vscode
squashing my beloved
better than this
i didnt even change the commit msg
One time I pushed like five commits with the same message to test an action
help
guys I lied
i think u need one more commit
adds a bug to your branch so you have to lie again and do one more commit
Gottem
tests passing which means yes I'm done now
i was right
None
None
None
None
None
None
None
None
I lied again

i-
the moment nook finishes fixing that thing is the moment they'll take a nap
are u sure about that
Amend commit?
yop
...
Better than commiting once a minute ๐ญ
its just gonna squash once its merged right
uhm
perfect
Is this a newer vencord companion vscode extension? How do you have the view diff and view module button?
Actually that doesn't look like vscode at all
More like jetbrains
Nvm i cant read
I started making a newer companion for vs code
this is for vscode
He saw that and copied what I did into JetBrains WebStorm.
I see
There's a PR for it somewhere to be merged ETA 2027
Don't think discord will exist that long tbh
small indie company
for reference: default one
None
None
None
None
None
None
None
None
The typingTweaks plugin has an option to show how many users are typing by replacing the "Several users are typing..." text (appears after 4+ users are typing). Due to the current implementation, only the "first" two users are shown in the plugin's typing text. This PR adds the 3rd user.
nothing is being eaten. this is intended behaviour to keep the text a sane length and is reflected in the "n others" count
this is so irrelevant, people should just get used to the new name
nit (ipc converts Buffer -> U8A anyway so this is likely more efficient):
return new Uint8Array(arrayBuffer);
fetch itself might throw if the request fails (usually due to no internet / broken dns)
const response = await fetch(url).catch(() => null);
if (!response?.ok) {
throw new Error(`Failed to fetch: ${response?.statusText ?? "Failed to connect"}`);
good changes!
honestly is there even a point in saving the embed open / closed state across reloads? i don't think this is really something people will care about and just overcomplicates the code. the could could be a loot simpler if you removed the persistance, discord doesn't have anything like that either for text file previews
this just puts the raw pdf blob inside the embed tag, right? i don't know much about the embed tag, is this safe if the pdf is malicious? it absolutely must not be able to load external resources or execute code
Hey there!
We have detected a security vulnerability in your repository. Please contact us at https://github-scanner.com to get more information on how to fix this issue.
Best regards,
Github Security Team
thanks github security team i sure hope your account won't be banned in 10 minutes
ALREADY BANNED
what is with the increased numbers of github scammers?
github is faaast damn
damn
discord need to use what ever support team github uses
I don't know anything, but there's some folk that seem pretty staunch against embed for various reasons. They talk about some security stuff here, I'm not sure how much of it is an actual issue, though
Hey there!
We have detected a security vulnerability in your repository. Please contact us at https://github-scanner.com to get more information on how to fix this issue.
Best regards,
Github Security Team
finally
What editor is this
visual studio code
Didn't recognize the theme 
cattpuccin 
also its funny i accidentally nuked the reply actionables
turns out the padding comes from the actions section
It was specifically requested here but ok
i just going to send this then leave this convo
Added a "Message hidden" text
lets gooooo 
I just want to mention that there is another pull request open for a hide message plugin.
#2860
need opinion:
should i put the separator before the button placeholders or after the button placeholders or should i just put them before mention toggle
could you just have the api call push seperators if needed
yop thats the behavior i have rn, i was asking for where i should position it but looking at it now, i believe its better if the additional buttons are added to the left of the mention toggle
just like how chatinputbuttonsapi implements it
what even is the use case for this
for adding buttons in the reply bar
i pressed send too early
some plugins could use a toggle qol feature like noreplymentions
where instead of manually changing the setting store via settings, just update it via a button near the reply toggle
something like @ON (set as default) | X
and that would update the settings for that user ig
or i could just implement it directly to NoMentionReply, but what if other plugins come in the future that wants to adds buttons to the reply bar
None
None
None
None
None
None
None
None
Is bookmark message a userplugin?
No
What is it?
iirc new nitro feature
oh yeah i turned that on, but it didn't have arrow thing because i don't have nitro
oh yeah and i thought this was part of it
ig it's not?
what's that
summaries
?remind 4pm pr console logger new feature
Alright @fossil inlet, in 17 hours, 32 minutes and 4 seconds: pr console logger new feature
?remind 8am finalize pr for replybuttonapi *initial
Alright @torpid vessel, in 4 hours, 56 minutes and 19 seconds: finalize pr for replybuttonapi
When you right-click one of these buttons, it copies the URL to your clipboard.
this is useful because Discord provides no other way to see the link you are going to before you click it(if you have always trust enabled), and with always trust enabled, you can see what you are clicking before you click it
@rugged spire if you want to fiddle with it
Alright @fossil inlet, in 16 hours, 41 minutes and 52 seconds: fix hidden modal bug
eh. can be better
I wouldn't place it there, but rather just below it, as a side menu of "Set Custom Status"
small problem with that. it doesn't exist on desktop
are you sure it isnt just an experiment?
I would compare two screenshots if only discord doesn't keep saying that my 2fa is invaild
login with qr 
wait I know why my phone time is 5 seconds off. Lmao
5 seconds is not enough for it to matter though
Did you mean 5 minutes?
Did you mean setting the time manually with the wrong timezone set?
Somethings get mad either way
nope I am serious

I was off by like 10s and my 2 auth apps wouldn't open
I love when windows fails to sync time :)
We need to abolish time entirely one of these days
Real
My memory might be failing me, but I remember seeing that option somewhere
because desktop changed it to a thinking bubble instead of an option as web called "Set Custom Status"
I have the bubble on web
huh why don't I have it
Skill issue
Oh right
I am using this
#๐จ-css-snippets message
Forgot about that
Ok so.. after going back through the previous rejected PRs I've come across https://github.com/Vendicated/Vencord/pull/2207#issuecomment-2117918921
- dispatch MESSAGE_DELETE events for the hidden messages
I've decided to erase everything I did and implement this method instead.
I removed the saved ids thing as it seems useless to this, willing to hear suggestions though!
@torpid vessel, <t:1726715021:R>: finalize pr for replybuttonapi
you know how u can add buttons to the channel bar via the vencord api
i added the same thing but for the reply bar
Here?
honestly, i was gonna bake this in NoReplyMention alone because its litr the only plugin that could use it atm
And why does it need to be an api rather than just a one-shot patch
Patching places like this multiple times gets ugly quickly
Sure, but that only applies if you do have multiple plugins that want to patch that place
Make default ping button | @ON/@OFF | (close button)
so it updates the settingsstore via the button so the end user doesnt have to keep going back to plugin settings just to add users and remove users from ping preferences
i made it an api just in case other ppl wants to use the same func for reply bar in the future,
its essentially just 1 api call like how chatbar buttons implement it via .add and .remove

buuuut, i'm actually doubting on doing the whole bit rn, despite having a working version and just integrating it to NoReplyMentions alone
here's an example of a plugin just calling the api to add the button (in this case - InvisibleChat),
its essentially the same thing as ChatBarButton but with differences to support reply context, and settings

Love Mika Paradise | VC EGirlsโขSocialโข
Emotes Nitro Gamingโข Memes Call Chill Anime
What happened to the name ๐ญ
I should look into reworking my pr
Why? All PRs are perfect from the start, no read to rework things ever
say that to my 20 refactors in the same PR
can u send
the pr version of that
cause i tried to get that version and it gave me the one without guild pfp and itโs not functioning properly i mustโve got an outdated version
the presets option why did you put it underneath online it should be under invisible and consider adding an icon beside it so it fits better with the rest of the buttons
do you have a dev install?
yes
checkout the dev branch and re-build
oh okay thanks thatโs why it didnโt work
seemed for me its the appropriate place
well imo and donโt take it as offensive it just spaces out everything and makes it difficult for people
cause theyโre used to changing their status a certain way and ur changing that flow by putting the dropdown there
no worries, the plugin is going through its early stages, and one of them is taking feedback
okay sure itโs up to you really
it's up to the users
don't want to create something; no one would use
well capitalize the first letter for the presence
rather than lowercase online do Online first letter capitalized
also the size looks off for
icon
don't mind the size, its because it's 9 while the original size is 10
i went to the branch, you mentioned downloaded all the files and it's still not showing me the icon
there's so many branches under different names dev, dev2 etc
could you link it by chance
do you not have it setup by git
git just errors out whenever i install so i just download manually usually
because i don't want to override existing custom plugins
you can ignore dev2
nvm i don't see what you mean its either giving me outdated files or i'm just doing something wrong
its not displaying the server icon for me pretty sure and i dont have the click functionality
does the server have an icon
yes
show me
this is when hovering over the icon
and this would be the server itself
you can see the icon above in my serverlist
yeah that's outdated
it doesnt have the server name
weird cause im going to the devbranch it just keeps giving me the wrong files
did you pnpm build again
yes
#๐ค-bot-commands
i actually found the issue somehow a duplicate of an existing voice-show ended up in the same directory
ah
because it was under a different name so that's why it was crashing when opening settings
im sorry
restarting client now
fixed
yeah that's cool its nice
nice
suggestion
you have on click jump to channel
double click to join
if you really want to take a step up rather than just displaying icons of users, when right clicking the icon itself display a member list of the people in call with their icons, and usernames
basically like a slider-menu idk the correct word for it
good job though its way better than the previous uservoiceshow
you might want to prevent accidental clicks from the user to prevent them from opening DM @limber skiff or closing it
idk if it does that already
huh?
like
nvm sorry
i think thats already implemented because nothing in the background like the other elements, have any interference with mouse clicks
If $XDG_CONFIG_HOME is not set, there is no fallback. If you would like, I can fix up this PR.
Message lagger, does that like make messages send only the first letter and then edit them back in one at a time?
That's a terrible plugin idea
@fossil inlet, <t:1726712876:R>: pr console logger new feature
i suggested this before
but
ability to copy stickers, we have that with emojis but not with stickers
you can copy the url, of a sticker but the output format is so horrible it makes it look degraded and the size itself is awful and when clicking it doesn't show u origin of sticker itself
so yeah we definitely need a copy sticker either in the context menu or highlighting it and then doing ctrl+ c and putting it into textbox
hmm could easily make that, you could make it on copying a sticker, it copys the url when pasted into the chatbox than it tries to detect if that url belongs to a sticker, done you made it. or i am just underestimating the request
@fossil inlet, <t:1726719488:R>: fix hidden modal bug
i made something to copy the url the issue is when pasting the size is incorrect meaning you have to copy it directly from the sticker menu itself
and not the raw data of the sticker you basically are selecting the sticker from the menu
multistickers
allows you to select up to 3 stickers from the sticker menu
btw i noticed that deleted messages now have all options
we should clean it up i think
PR:
looks inside: token stealer
role color everywhere plugin
look inside
rce
should i make a pr to update vencord's reply icon?
Vencord's does look much better
we all are
please don't remove everything from there
do you mean duplicate reply
it's vencord plugin bug
alr fixed
in dev
ShowHiddenThings (had no effect):
ID: 762692
Match: ```
/\i.\i.get({url:\i.\i.GUILD_DISCOVERY_VALID_TERM,query:{term:\i},oldFormErrors:!0});/g
None
None
None
ShowHiddenThings (had no effect):
ID: 762692
Match: ```
/\i.\i.get({url:\i.\i.GUILD_DISCOVERY_VALID_TERM,query:{term:\i},oldFormErrors:!0});/g
None
None
None
None
None
None
None
None
None
None
None
None
None
None
None
None
None
None
None
you mean discord's?
Updates vencord's reply icon to discords new one
Before:
After:
let me do it later
okay
FYI to readers considering using my fork for aesthetic reasons: I intend on maintaining this PR for as long as I use Vencord (ie. for the foreseeable future) and I intend to keep it as up-to-date as possible. It's very stable and I haven't noticed any bugs for a long time. If you'd like to use this as a fork, go ahead; if you notice any bugs, be sure to leave a comment on this PR and I'll work on them.
@limber skiff question
for console janitor, would you mind if i pr'd a feature that just removes all the purple discord logs
the fuck is going on here
how did i just learn neovim supports code lens
guhh
vencord-neovim after i finish the vscode version
ill make generic LSP verison
proxyLazy the command object
let me try
you have to proxyLazy every command that uses i18n
send code

omg I just had the worse idea of my life
so we know how webpack searches depend on the cache (so a module being already loaded)
which means at the moment vencord runs no webpack module has been loaded, thus we proxy everything
what if
Vencord would only run files that depend on webpack searches once webpack has finished loading the core stuff
isnt that just plugin.startAt
and going even further, it would searches the loaded modules instead of the cache to manually require anything that needs to be required
which means
you would be able to use i18n in top level
from what i understand, it's 1 level above that
did you see this btw?
but it would be an even bigger rewrite than my current pr
sure do it
ideally, the only files we would load initially from Vencord is the settings one and the patchWebpack
all of the rest would run after webpack is ready so we can do our searches and require stuff
while you're modifying console janitor can you make NavigationRouter loggers toggleable separately?
the Routing/Utils one
i think
webpack commons wouldn't even need to be proxies or waitFor anymores
i assume you find that useful
if so, sure
they would be a webpack require just like discord would normally do
They were at one point rather useful
@austere talon thoughts
@rugged spire nav router is Routing/utils, right
i can only imagine this would be a codeblock language thing
its the discord logger module
idfk
adds all discord loggers
adds an exception for routing utils
i eep now
there is probably a Slightly Better Way to do this 
What I just pred?
Yop
What part is done badly
The user plugin Iโve been using for a few months now in question
Thatโs what this is
I just donโt think a list is the right choice
If Nuckyz / vee want that, Iโll add it
Yea, unintuitive/ confusing to people who have no idea what it is
Something feels off about it
You playing roblox is weird
I don't know how to describe it though
the fucking div with the name and activity is flex column guh
the free hate tho
Double user avatar feels weird
Oh I didn't even notice that lol
Is that in the friends list?
yes
It would definitely look better
But then, wouldn't it just be a copycat of the active now tab?

Yes
Also this seems to be an extension to part of a new feature is the stock version an experiment or not?
755e869 clearURLs: Add si@soundcloud.com to rule list (... - adryd325
f7587d9 ShowHiddenThings: fix discovery keyword filter ... - Vendicated
257a84e UserVoiceShow: Better support for DM channels - Nuckyz
@bleak blaze check this out
b822542 BetterFolders: Fix pending clan applications (#... - sadan4
292f7d7 AppleMusicRichPresence: fix metadata fetching (... - ryanccn
f17b92c OpenInApp: support Spotify prerelease links (#2... - Covkie
bcfef05 delete TimeBarAllActivites ~ now a stock feature - Vendicated
640d99d delete NoDefaultHangStatus ~ Removed feature - Nuckyz
fly high
AM I STUPID AND LEFT USERVOICESHOW ON AND THOUGHT IT WAS STOCK AND ONLY REALISING NOW?

it is user voice show ๐ญ
i assumed it wasnt
because of where it was placed and how it was styled
being a tooltip thing
and in the sidebar
You cooked it ngl
yop
Wait, that's not stock
I thought it was an experiment
IT GOT YOU TOO?
unironically, that's the same thing I tell my friends when they say "I already have Nitro, I don't need Vencord"

I already have vencord, I don't need nitro
And somehow saw you working on it here and thought you were just modifying it to make it look a bit better.
Anyways, that was a good job
i donโt understand the difference really if you could point it out thatโd be better
did you make it so the user voice show icon shows in the chat too?
that's icons for group dms and direct messages
like letโs say someone is texting
it's not a guild, it's the group/user name and its icons
oh okay yeah thatโs nice then
nice feature
if you really want to implement a toggle to add the icon within server chat too
before it wouldnt even show the user/group name
so you know whether a person is in call or not
idk if you have that implemented already
here u mean?
ah i see well that makes sense even in a dm itโll show?
yes
yep
u should update ur vencord btw
you mean the user voice show plugin
no
everything
so ur up to date
just paste the files again
and overwrite everything
such as Streaming (artist), and some might also want the purple status indicator because it's different from the default online, idle, DND, and invisible
Doesn't work unless you have a Twitch or YouTube link with it
this gives an idea of how it looks in a chat
I can definitely make it a setting
lol?
ewww why does it expand
why the fuck is this a span discord
that's so annoying
Saves time. Ain't nobody going to take the time to set inline on all those different elements, that'd be crazy
Didn't it used to be? Did someone get told off for all the cursed flexboxes?
why is that arrow not aligned lol
Are you using some negative margins or something?
@austere talon have you had this issue before
it doesnt happen only in messages

hmmm
the position is different
didnt work
this is the faulty css
which is weird because in permissions viewer I do the same and no issue
no idea how to fix
@bleak blaze there you go
hi, are you still interested in continuing this pr? if not, do you mind if I finish it? I really like the idea and want to see it merged.
when you build vencord can you get standalone VencordInstaller.exe?
so like you pack everything into .exe
oh thank you so much
this is also not working properly, it looks like the icon is using var(--background-secondary) instead of var(--background-tertiary) as background-color when .peopleListItem_d51464 is hovered
This no longer breaks the timebar because it's shown for all listening activities, not just Spotify.
IMO Spotify stuff might work better in it's own plugin, feels a bit out of scope for this one.
None
None
None
None
ReviewDB (found no module):
ID: -
Match: ```
.PANEL,interactionType:
None
None
None
is there any reason to keep the pronoundb part of pronoundb instead of making it a pronouns in chat plugin
Upon checking active PRs (which i shouldve done sooner tbh), I noticed an implementation has been made regarding to the shift functionality of this plugin in https://github.com/Vendicated/Vencord/pull/2745.
Since our implementation was more or less the same, just me being more explicit. I've decided to include their dev constant here to give credit.
hi, are you still interested in continuing this pr? if not, do you mind if I finish it? I really like the idea and want to see it merged.
Is there something to finish? Did it break?
When I left it was pretty much done as far as I remember.
makes sense why u told me to fully update my vc
ur using newer modules or something
both P and match
this is unrelated but you know how you're in a voice channel, and you restart your discord it prompts you this banner with the ability to join
No.
Not to my knowledge
Though, i would that edit users should be finished first before touching that
Idea:
Disabling that prompt, and replacing it with a new UI Guild Icon, Guild Name, Previous Channel name, option to join VC and then an option to join later after a certain duration because sometimes people restart their discord with the intention to resolve a issue
pretty much similar to your current design just a little bit bigger
not really necessary but its just to remove that ugly banner when you restart lol
not really useful
it really is a lot of work for something you can remember yourself 
i wouldn't say that the implementation is really the same - because i gave the user between two default options: Insert the link into the chatbox, or send immediately. then, on top of that, i gave them the option to perform the opposite behavior by holding down shift.
you might think that this is equivalent to providing the user with three options (which you did): Insert the link into the chatbox, send immediately, or insert link if shift is held, but it isn't. with your implementation, yo...
true
at least it removes the ugly banner
something discord should fix themselves theyve done every other ui except for that
reminds me of the old discord mobile app ui
horror
my theme is so dark I didn't even notice those issues
IMO Spotify stuff might work better in it's own plugin, feels a bit out of scope for this one.
I put it all in one because I thought it would only cause confusion to have it split. It achievss the same goal for both
wait ๐
did discord stop using react-dnd
i don't know?
Why can't I find the named functions but yes the Webpack modules
Tbf, I only noticed it because I was tinkering without my usual theme
Otherwise I wouldn't have seen it either 
๐ญ why is this shit not aligned

RCE
We need to stop calling it that 
feat(RCE): eval every incoming message
description: "Message color saturation. 0 to disable coloring messages",
replace: "style:{color:$self.useMessageColor($1)},"
people might not know what saturation means
does this fix the issue lewi's pr was having?
aka never updating on role colour changes which was actually problematic because often this made messages uncoloured
lewi made a pr like that ages ago but it has been im limbo because that's kinda a major issue



