#👾-core-development
limber skiff
scenic brook
I was thinking of making something like that the other day lol, I hate not being able to see my profile in a big server I don't talk in
charred monolithBOT
gritty canyon
🔥
nimble plaza
turbid hatch
i wish people would stop complaining about things like this
it doesnt matter
its a badge
no one cares
contribute because you want to add something useful, not for a badge
limber skiff
haters 💔
fossil inlet
me when i cant read
austere talon
youre the one who cant read
vivid garden
limber skiff
ngl that plugin is actually neat
quaint sapphire
I am too lazy to open a PR, can someone with write access just add badge: false to me?
https://github.com/Vendicated/Vencord/blob/main/src%2Futils%2Fconstants.ts#L40-L43
It's been so long since I've contributed anything, I doubt any line of code I've written still exists in the codebase.
I feel like a badge should not be shown for me.
limber skiff
done
quaint sapphire
Arigato
limber skiff
huh
I think I broke testing patches with predicates long ago
and im just noticing now
wrong order lmaoo
that condition should be above
limber skiff
@balmy perch thanks for the original idea and sorry for ending up re-doing it all lol
frail skyBOT
limber skiff
I really appreciate your fix and the initial contribution regardless
frail skyBOT
limber skiff
definitely keeping this on hehe
I'll post it on #plugin-news wihtin the next days
glass jasper
<@929208515883569182> 🤓
you frfr
limber skiff
https://media.discordapp.net/attachments/1184105637718802536/1201324576215404584/20240129_113356.gif
I have looked at that Api so many times
and everytime it hurt me
brazen bone
Cringest commit in the history of mankind
limber skiff
do yall really not like that
glass jasper
Cringest commit in the history of mankind
glass jasper
do yall really not like that
yes Api is better not API
shell shuttle
do yall really not like that
i have OCD i think its better
limber skiff
is there a part in specific
there's so much inconsistency between Api and API in the project
shell shuttle
i also instinctively type API
limber skiff
yes Api is better not API
the only place I can maybe agree is in Vencord.Api
everywhere it looks worse
ContextMenuApi looks so shit
fossil inlet
User-plugins when breaking changes
glass jasper
the only place I can maybe agree is in Vencord.Api
no, all of them all capitalisation on it is weird. Api is better
glass jasper
User-plugins when breaking changes
frfr
limber skiff
I disagree
brazen bone
Context, menu, and api are three words
fossil inlet
Its like userId
swift fjord
why not do a poll
limber skiff
yes I know how camel case works
swift fjord
pick a style and use that everywhere
glass jasper
me waiting for the revert
limber skiff
User-plugins when breaking changes
almost no userplugins is gonna hardcode Vencord.Api or something like that
but well
I guess on ContextMenuApi
fossil inlet
yes I know how camel case works
nuh huh
shell shuttle
API for the win
glass jasper
fr
limber skiff
bad change
we have inconsistency everywhere
brazen bone
I can't vote be because ancient mobile app
austere talon
acronyms are not to be capitalised in code
glass jasper
I can't vote be because ancient mobile app
i cant on Ripcord either
limber skiff
yet ContextMenuApi
brazen bone
Will vote when I get home I guess
limber skiff
well then we should pick one and use everywhere
austere talon
it doesn't matter
limber skiff
fossil inlet
well then we should pick one and use everywhere
Fix in your finds branch or smth
fossil inlet
Oh, I'm.blind
limber skiff
either way it's gonna have breaking changes because the code is inconsistency
glass jasper
still tho Rip every userplugin ever
limber skiff
in some places we use API, in others Api
fossil inlet
still tho Rip every userplugin ever
Not hard to update them
brazen bone
I love apis 🐝
brazen bone
it's preference honestly
Great idea, add a setting for which to use
glass jasper
ok so we wait the revert of this commit
limber skiff
Great idea, add a setting for which to use
very uneeded comment
shell shuttle
It’s an acronym, anyways acronyms shouldn’t be capitalised
no it's not
swift fjord
erm actually its an initialism
opaque silo
erm actually its an initialism
I'm going to bash your head in
charred monolithBOT
limber skiff
fine
shell shuttle
this is krystal's fault
limber skiff
I still think at some point stuff needs to be changed
glass jasper
this is krystal's fault
how? i just woke up
limber skiff
it's an active project and the more code quality the better
limber skiff
I still think at some point stuff needs to be changed
even if that requires changing a lot of files
limber skiff
for example a more strict eslint rule set too
limber skiff
casing of variable names is not code quality <:wires:1262562427422244874>
the consistency is code quality
limber skiff
yes we have intellisense but even then
dapper crest
ColonThree
shell shuttle
ColonThree
:3
fossil inlet
guhhh
fossil inlet
works on my machine <:blobCatCozy:1084121193591885906>
what commit are you on?
dusk blaze
97670e12
fossil inlet
guhh
Vencord: v1.10.1 • f48bfd59 (Dev) - 6 Sept 2024
Client: stable ~ Vesktop v1.5.3
Platform: Linux x86_64
⚠️ Vencord DevBuild
⚠️ Has UserPlugins
dusk blaze
Vencord: v1.9.8 • 97670e12 (Dev) - 2 Sept 2024
Client: stable ~ Vesktop v1.5.3
Platform: Win32
⚠️ Activity Sharing disabled
⚠️ Vencord DevBuild
⚠️ Has UserPlugins
fossil inlet
works on my machine <:blobCatCozy:1084121193591885906>
guhhh im stupid
||pulled lastest commit but didnt rebuild||
Vencord: v1.10.1 • 56459bdc (Dev) - 6 Sept 2024
Client: stable ~ Vesktop v1.5.3
Platform: Linux x86_64
⚠️ Vencord DevBuild
⚠️ Has UserPlugins
fossil inlet
with the new profile plugin does anyone think it would be a good idea to move the buttons on the normal profile to the guild one
rugged spire
with the new profile plugin does anyone think it would be a good idea to move th...
do
glass jasper
w
grizzled stream
where is the vesktop local copy of vencord located? vesktop is currently set to load vencord from the default location but apparently it has "more recent commits" somehow
update: ended up nuking ~/Library/Application Support/vesktop/vencordDist and it fixed itself
dusk blaze
where is the vesktop local copy of vencord located? vesktop is currently set to ...
sorry i added the more recent commits to your vesktop
grizzled stream
limber skiff
I'm sure you can look at any plugins that use them and ur gonna understand
fossil inlet
i missed the one line i needed to see 😭
rugged spire
i didnt know plugin requests were closed now 🙏
limber skiff
they are?
crude raptor
god bless
fallen vale
at last, im free
limber skiff
yeah
grizzled halo
Thats actually pretty cool
crude raptor
definitely interesting
feel like people going online/offline would absolutely fuck with its brain tho LOL
limber skiff
wary relic
ahh
charred monolithBOT
charred monolithBOT
charred monolithBOT
jagged cloak
I FUCKING FORGOT
austere talon
austere talon
I FUCKING FORGOT
what'd u forget
jagged cloak
me when i try to painstakingly give support over github issues because i have the support channel muted and forgot it existed
shell shuttle
me when i try to painstakingly give support over github issues because i have th...
damn how'd you get into the most gatekept clan
they declined almost everyone a few months ago
jagged cloak
ive neen in it for months
shell shuttle
be a guild owner
advertise to guild-joining server
decline literally everyone
get clan removed from guild-joining server because 99% of the comments were "i was declined" or "hope i'm accepted" and get donowalled
shell shuttle
ive neen in it for months
oohhhhhhhhh
jagged cloak
its just a genshin/gacha server lol she prob declined all the guild badge goblins
iirc it wasnt even added there by the owner so 
shell shuttle
OHHHH
jagged cloak
average coredev conversation
shell shuttle
shiit that makes sense
i dont play enough genshin prob
ar 33 and i do less than 1k damage
glass jasper
>be a guild owner
>advertise to guild-joining server
>decline literally everyone...
nothing will ever be like your server though and polar
shell shuttle
nothing will ever be like your server though and polar
polar finds it funny to send the most profane gifs and then i punish him and he still does it
jagged cloak
glass jasper
ask @umbral hedge about that, she is the owner
shell shuttle
shell shuttle
alr i asked in the server
jagged cloak
polar finds it funny to send the most profane gifs and then i punish him and he ...
i thought that said polaris then i read it
glass jasper
polar finds it funny to send the most profane gifs and then i punish him and he ...
don’t let Shorty know I actually do find it a little funny
austere talon
meanwhile i got donowalled from funny datamining guild
megu in japan rn they probably have better things to do than check applications for their clan
jagged cloak
i didnt say they had to chekc it now lool
they should be eating more famichiki instead
converted
glass jasper
megu in japan rn they probably have better things to do than check applications ...
nah discord 24/7
shell shuttle
megu in japan rn they probably have better things to do than check applications ...
ooo nice
umbral hedge
there are hundreds of requests and the UI for viewing them is unintuitive
you just gotta ask me
gritty canyon
As I am Vees alt account, and thus can decide over PRs on GitHub, I shall strike this PR down due to begging for merge.
jagged cloak
there are hundreds of requests and the UI for viewing them is unintuitive
fair enough i didnt think to ask u tbh 
shut vineBOT
@fossil inlet, <t:1725320656:R>: fix
charred monolithBOT
fossil inlet
is the webpack instance always the thrid argument in webpack modules
charred monolithBOT
charred monolithBOT
charred monolithBOT
crude hearth
We need
opaque silo
someone should make a plugin to make discord not slow
gritty canyon
someone should make a plugin to make discord not slow
just rewrite it in rust
fallen vale
someone should make a plugin to make discord not slow
rejected (can be done with css)
* {
display: none;
}
discord cant be slow if theres no discord 
austere talon
way too much yapping that readme
torpid vessel
my bad
hybrid blaze
way too much yapping that readme
whats was the issue here? #👾-core-development message
i mean maybe im trippin and dumb, just wanna know 🙆♂️
like
austere talon
you completely broke the plugin
hybrid blaze
damn thats op
fallen vale
didnt ya just randomly invert the case for no reason?/genq
charred monolithBOT
This is a fork of BlurNSFW, works as BlurNSFW, but its a separate plugin because it have some extra options that are not neccesary in a simple plugin like BlurNSFW+. I will be adding more options in that days.
fallen vale
<already existing plugin>+ my beloved
gritty canyon
sanest plugin
gritty canyon
why does GitHub hide the "<Plugin>"..
charred monolithBOT
gritty canyon
the badge pr
gritty canyon
this more than 2line <:SH_cat_angry:1272928382669291631>
either way this is pretty useless because its faster to right click and pin than to bend your hand to press those buttons, also this feels very rushed (especially with the weird key combo and typos)
imo at least
- dont add to devs constant for such minor changes
charred monolithBOT
opaque silo
no update to finished feature means its dead and abandoned surely
hybrid blaze
either way this is pretty useless because its faster to right click and pin than...
then by that logic, replying is pointless too. right-click, reply, done. with pin/unpin there is a confirm widget that you want to pin it, which takes even more clicks. so, i really dont get 🤷♂️
also based on the code structure, this isnt that "minor change" since it adds 2 more functions to the previous 3, which is a decent ratio
i mean okay, i understand, but still
obv, if you have a better idea for the key combo, im all ears. for me its a quick option, but sure, it can vary
gritty canyon
then by that logic, replying is pointless too. right-click, reply, done. with pi...
"2 more functions"..?
Also the difference between pinning and replying is that replying is an action you do often and pinning is an action you do once a month
pins is also a place to put important message (at least intended to by discord) so having a shortcut to it might make you pin unnecessary messages
i doubt anyone is going to really use this, but i mean there are a couple of features that barely anyone uses so my largest problem is that this seems more like a band aid patch for the contributor badge instead of something more thought out
something more thought out wouldve not had the typo, the inconsistencies in the settings description (random capitalisation) and allow for more customisation instead of hardcoded binds
stuff like this is ofc fine on a smaller plugin, but once it gets expanded it should be addressed (reason for openinapp rewrite) but that is just my opinion on it
hybrid blaze
"2 more functions"..?
Also the difference between pinning and replying is that r...
u're partly right, but i actually did this a long time ago, before the plugins were refactored. at that time, pull requests were also paused for some reason, and it was mentioned in the pull request that it would be merged. but as i said, after that, there was a pause on pull requests, and nothing happened for a long time. a few months later, i redid it, basically, thats it.
as for the typo, thats something that can happen to anyone. i dont think its that big of a deal, i just modified the code and i accidentally left the description unfinished, but ofc i understand what are you talking about, and its fine 
Also, i understand the point about wanting a "more creative and unique idea," and its valid obv. but there are already tons of plugins, some of which would make more sense to merge because they're very similar. most useful plugins already exist so.
u might not use it, but u know how it is, different ppl, different habits. it could be useful for some, and some might use it often
fossil inlet
pine topaz
As I am Vees alt account, and thus can decide over PRs on GitHub, I shall strike...
can you do something other than being negative for once in your discord life
gritty canyon
can you do something other than being negative for once in your discord life
as vees alt, nope, you will be banned
charred monolithBOT
Bumps the go_modules group with 1 update in the / directory: google.golang.org/protobuf.
Updates google.golang.org/protobuf from 1.30.0 to 1.33.0
...
turbid hatch
jesus christ okay
prime dew
turbid hatch
what the hell?
i didnt configure dependabot to do that though
like i explicitly turned that off
prime dew
Is everything okay?
turbid hatch
glass jasper
erm... chat spam much
glass jasper
vban 96269247411400704 chat spam /joke
fallen vale
what the fuck
turbid hatch
oh wait
all of these PRs are security updates
lol
i just saw the dependabot dashboard
wary relic
nah who needs security
turbid hatch
there's like 15 security issues
turbid hatch
this is painfully annoying
charred monolithBOT
turbid hatch
so i need to update to go 1.21
okay
because there's a vulnerability in a library on go 1.20 and its kinda bust
ed
fossil inlet
Average cord dev spam
fallen vale
?purge 150
austere talon
idk why it did that
cause vulnerability
austere talon
jesus christ the spam
turbid hatch
tbf i did actually read the security advisory
and they were very relevant
and very bad
like there were a few attacks that the software was vulnerable to like a http/2 cancellation attach, http/2 rapid reset ddos, CORS configuration error, QUIC memory exhaustion attack, denial of service
actually i just listed off all the advisories lol
so its probably not great to have that in a live image
turbid hatch
the version of the quic library
versions after that required 1.21
but the current version needed 1.20
i dont know why 
weird funny stuff
hey dependabot
why are you still upset
turbid hatch
?????????????
fallen vale
lmfao
fallen vale
lewi pro
charred monolithBOT
turbid hatch
i have
no idea
how i missed that
yeah no wonder dependabot cant reopen the PR
it doesnt know where to put it
turbid hatch
there we go
turbid hatch
oh, horrifying
it's found a billion new security vulnerabilities
oh, no
these are just normal ones
its because i forgot to tell it "security only"
well this is annoying
so dependabot will only PR to the main branch unless you use a config file
but if you use a config file then it'll do version updates as well
this is literally not what i want
but there's no w
okay
whatever
its probably good to do it
austere talon
horror
turbid hatch
dependabot
austere talon
just remove the dependabot config
turbid hatch
i want it to do it for security updates i just dont want it to do it for anything else!!
charred monolithBOT
austere talon
you still get alerts
via email if you have that on
austere talon
turbid hatch
so what it wants me to do
now
is close the PR
but if i close the PR
it doesnt do anything
charred monolithBOT
turbid hatch
watch
charred monolithBOT
turbid hatch
it says that
and then thats it
it literally does nothing else
it wont recreate the PR
so now i have a bugged security advisory
good software
turbid hatch
so good https://github.com/Vendicated/Vencord/security/advisories/GHSA-8c8g-rcr9...
i cant see it
i can only see published ones, as the repo owner you have exclusive access to the ones people have reported
send a screenshot
turbid hatch
i cant see it
if it was in the org i would be able to :p
austere talon
turbid hatch
nice
pine topaz
fgdg is a very powerful exploit
charred monolithBOT
Bumps google.golang.org/protobuf from 1.30.0 to 1.33.0.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. ...
fossil inlet
i think he found the vencord rce
charred monolithBOT
pine topaz
g
pine topaz
- open vencord
- g
- ???
- severe security vulnerability
charred monolithBOT
turbid hatch
okay
austere talon
someone reported a plugin bug via security advisories
austere talon
can i enable webhook notifications
like not the content but maybe like
New security report opened
austere talon
don't make dependabot angry or it will open 200 prs
charred monolithBOT
glass jasper
don't make dependabot angry or it will open 200 prs
vban dependabot troll
turbid hatch
don't make dependabot angry or it will open 200 prs
the foul beast assumes the coat of the righteous
austere talon
why not just
git fetch
git reset --hard dev
git push --force origin main
too lazy
turbid hatch
rugged spire
why not just
```sh
git fetch
git reset --hard dev
git push --force origin main
`...
🔥
turbid hatch
tbh pushing to ghcr was actually
a lot easier than i anticipated
of course it'd be nice if the action actually
ran
oh its because i put skip ci
ffs
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
sterile oak
doesn't this Issue plugin-requests #990 exists as pr or a plugin?
limber skiff
@austere talon they did something to discord spotify token permissions
shuffle and repeat
spark pivot
grave mangoBOT
index.tsx: Line 78
const source = regex.map(r => r.reg.source).join("|");
https://github.com/henmalib/vc-messageColors/blob/main/index.tsx#L69
Works fine
index.tsx: Line 69
const amount = settings.store.enableShortHexCodes ? "{1,2}" : "{2}";
yes
limber skiff
I really hate how that works
settings in the plugin object is the only reason ur not able to use them at top level
fossil inlet
is there any need to use at top level
limber skiff
rare but yeah
either way
if we could somehow insert the plugin name without inserting something in the plugin object
things would be easier
and more possibilities
this is an use
would not need that start method
charred monolithBOT
turbid hatch
settings in the plugin object is the only reason ur not able to use them at top ...
this is probably a good thing
using it at the top level means that we'd have to initialise the settings for a plugin you might not even be running, which is kinda silly
turbid hatch
limber skiff
PlainSettings are still stored
which include all plugin settings
even those not enabled
initializing those settings are just some extra objects which really doesn't matter
limber skiff
though either way, doing what I said might be complicated
it would be some esbuild magic to somehow grab the plugin name and insert in place somewhere
turbid hatch
there is only one use case for doing it at the top level and it's easily worked around by just doing it in start anyway, where it is better suited
oh also you have to remember that if you use the settings before the plugin is initialised you will cause an error
which i guess is what your esbuild magic is for
but that makes it really complicated so i rly dont think its a good idea
limber skiff
which i guess is what your esbuild magic is for
yes exactly
because we require the settings to be inside the plugin definition
for them to grab the plugin name
austere talon
also is used to resolve defaults with how it's used rn
limber skiff
and that ends up causing a circular dependency if you use them in top level
turbid hatch
not really a circular dependency
just a
"this prop isnt initialised, whoops!"
we have a dedicated error for it
limber skiff
I dont remember what's the error exactly
but I don't like how it's so dependant on that
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/api/Settings.ts#L229-L236
Settings.ts: Lines 229-236
get store() {
if (!definedSettings.pluginName) throw new Error("Cannot access settings before plugin is initialized");
return Settings.plugins[definedSettings.pluginName] as any;
},
get plain() {
if (!definedSettings.pluginName) throw new Error("Cannot access settings before plugin is initialized");
return PlainSettings.plugins[definedSettings.pluginName] as any;
},
right it's that one
turbid hatch
pluginName is populated by the plugin loader here https://github.com/Vendicated/Vencord/blob/8890c8c6b4201121c559e671e0110b45937467c2/src/plugins/index.ts#L112
grave mangoBOT
`pluginName` is populated by the plugin loader here https://github.com/Vendicate...
index.ts: Line 112
p.settings.pluginName = p.name;
yes I know
turbid hatch
regardless of the plugin being enabled or not
so yes you could use esbuild to inject it as an extra parameter to definePluginSettings
limber skiff
that wouldn't be only useful for definePluginSettings
turbid hatch
but that may also cause other issues down the line
limber skiff
we would be able to decouple other functions from the plugin object
and perhaps have some decorator like functions
for example addContextMenuPatch(contextMenuDefinition)
all at top level
turbid hatch
decorators are nice
turbid hatch
well damn
i must've thought of something else
time to move to class based plugins 
limber skiff
xd
limber skiff
so imagine this instead
limber skiff
although i guess i kinda understand why
they rely on descriptors
turbid hatch
welcome back powercord
limber skiff
so imagine this instead
and we would inject the plugin name
automatically
for handling enabling/disabling
austere talon
I think it's better in the plugin definition
limber skiff
hmm
austere talon
less confusing
austere talon
so imagine this instead
this might make people think the first arg is some id or smth
and it's just extra effort to couple that call to the right plugin
we could have some dynamic module via esbuild plugin that returns scoped methods whenever you import it but is it really worth it
would be confusing to use
quaint sapphire
I swear to god that I remember you had a custom regex shortcut to match variables, but I can't fucking find it
and I am starting to think that it was all in my mind
it was \i!
at last
ngl \i is weird, since $self also exists and uses a different style
(talking about the syntax, not what each does)
nimble plaza
$self doesnt match anything
brazen bone
$self is in the replacement
quaint sapphire
yeah I know
nimble plaza
its not a part of regex
gritty canyon
ngl `\i` is weird, since `$self` also exists and uses a different style
(talking...
\i matches identifiers
$self replaces to the current plugin
brazen bone
Replacement has different syntax from regex
gritty canyon
notice how matches and replaces are 2 different words
quaint sapphire
I ain't new to this
brazen bone
It is quite common for different things to have different syntax
quaint sapphire
I am commenting on the \ vs $
brazen bone
It is consistent with the contexts in which the two are used
quaint sapphire
\ is regex syntax
yes, but it is confusing since it looks like actual regex syntax and no such thing exists as \i
it's just a personal opinion
gritty canyon
I am commenting on the `\` vs `$`
yes because everywhere \ is used in matches and $ in replace
i.e. \b matches word boundries, $1 replaces with the first group
quaint sapphire
yes, we can agree on that, I did not mix them up
gritty canyon
this isnt vencord things
quaint sapphire
i.e. \b matches word boundries, $1 replaces with the first group
fair enough
I am used to \1 for replacement groups
brazen bone
It would be way weirder if replace was \self even though replaces use $1 for capture groups
quaint sapphire
not all regex engines use $1 in replacements
brazen bone
Js does
gritty canyon
not all regex engines use `$1` in replacements
most of them do
vscode, jetbrains does
and there you have 90% of all regex replaces covered
brazen bone
In most regex libraries if you specify \1 you get a nice SOH
gritty canyon
whats an soh
brazen bone
As in ascii 0x01
spice python
vscode, jetbrains does
Code editors are regex engines??
quaint sapphire
shell regex has ruined me
gritty canyon
Code editors are regex engines??
did you not know about regex search and replace
brazen bone
All modern text editors have regex replace, yes
Where "modern" means "everything in the last 30 years except ms notepad"
gritty canyon
spice python
They just use their languages regex thing tho probably
quaint sapphire
Code editors are regex engines??
aren't we all regex engines in our hearts?
brazen bone
They're literally just regex replace (plus \i and $self)
spice python
Is there a more in depth guide on how patches work.
Nuckyz sent you a link in #🧩-plugin-development which covers what you need know
quaint sapphire
Is there a more in depth guide on how patches work.
there ain't much to learn ngl
if you are good (or ok) with regex, you are 90% there
you just have to get creative in ur replacements
a bad replacement can cause code to crash
gritty canyon
Is there a more in depth guide on how patches work.
they go through the source code, find uses a string as is (no regex) to find the webpack chunk, replacement match and replace then replaces a piece of source code in that chunk
marsh spruce
So I need to grab the webpack value of the ui to essentially then allow me to create a new react element?
brazen bone
The component is made of code
quaint sapphire
I am making a patch rn, wanna hop on a VC so I call tell you and answer questions?
marsh spruce
The component is made of code
It's html based
brazen bone
No, it's React
quaint sapphire
nah
marsh spruce
And switches the actual page
quaint sapphire
it is javascript that generates html
you should learn the basics of reactjs ig
to understand how the UI is rendered
spice python
what youre patching is the reactjs code this isnt betterdiscord
quaint sapphire
bd mentioned in 2024
marsh spruce
It's in a fact list
quaint sapphire
what fact list?
brazen bone
"FaCt LiSt"
marsh spruce
fossil inlet
what youre patching is the reactjs code this isnt betterdiscord
Does bd patch react
marsh spruce
It's some form of ui list
quaint sapphire
that is an unordered list, UL
marsh spruce
So the regex is the dom element version?
spice python
Does bd patch react
I think you can technically do that but it's mostly dom manip
quaint sapphire
So the regex is the dom element version?
no
brazen bone
React code builds react elements
quaint sapphire
you use regex to edit the javascript code that is responsible for generating the html
brazen bone
Which are then somewhere, deep down converted to dom elements but you don't need to worry about that part
spice python
So the regex is the dom element version?
are you like trolling or smth
marsh spruce
I am not trolling why do you think I am?
austere talon
you guys are terrible at explaining 😭
- forget about any kind of DOM or html, that's not how vencord plugins work
quaint sapphire
@marsh spruce https://www.youtube.com/watch?v=za2FZ8QCE18
spice python
<@168422909482762240> https://www.youtube.com/watch?v=za2FZ8QCE18
I really doubt hes actually lacking react , just reading bd docs
austere talon
1. forget about any kind of DOM or html, that's not how vencord plugins work
- discord has many modules. each module represents one file, except that they are bundled together into one big file
- vencord patches work by string replacing discord's javascript code
- you need to find the module that contains the code for the ui element you want to patch
- then you use a regex replace to change the code in that file to add or remove code you need for your own functionality
quaint sapphire
you guys are terrible at explaining 😭
at this point I suspect they don't know what regex is
maybe we should start there?
austere talon
discord's code will look something like this:
function a(e) {
const { channels } = e;
return (0, r.jsx)("ul", {
children: channels.map(/* ... some code here */)
})
}
So I need to find out what generates the unordered list so I can inject the button to generate a modal for lookup
austere talon
you can add an ui element by adding your own code
quaint sapphire
let's make a thread
austere talon
you can add an ui element by adding your own code
for example by rewriting the code to something like this:
function a(e) {
const { channels } = e;
return (0, r.jsx)("ul", {
children: [$self.createMyFakeChannel(e), ...channels.map(/* ... some code here */)]
})
}
patching discord's UI
spice python
cant talk in threads sad
dusk blaze
@austere talon thread perms for contribs when
austere talon
there fixed
austere talon
<@343383572805058560> thread perms for contribs when
vfjd? should i give contrib thread perms?
nimble pendantBOT
vfjd? should i give contrib thread perms?
No
frosty bronzeBOT
A tactical nuke will soon arrive on @austere talon’s location.\n-# 
Only aliens can see this
opaque silo
chat are gray blob badges a known issue
austere talon
if you don't update your vencord yes
opaque silo
i just did 😭
quaint sapphire
rate my code, how cursed is it?
(is it cursed at all?)
it reverts the shift key when starting a call
so it by default will not ring anyone, and when pressing shift it will ring the DM members
fossil inlet
is that webstorm
quaint sapphire
yes, my vscode on windows 11 stopped working out of nowhere
literally no LSP server would work on it
fossil inlet