should work
#πΎ-core-development
swift fjord
@austere talon started
austere talon
restarted
rugged spire
unironically a good idea just make sure to cache them
@austere talon i just realised something, does asar-bundle have to do anything with my so-called skill issue i had yesterday where loading @sentry/electron into cache didnt work for me what I think is that you are rewriting loads of stuff just to make getting rid of that easier? is that right or am I crazy
austere talon
whar
rugged spire
tl;dr: are you moving vencord files into asar archive so we can bomb sentry without horrible code or is it just because its a good idea to do it this way
spark pivot
gritty iris
lmao
austere talon
tl;dr: are you moving vencord files into asar archive so we can bomb sentry with...
no correlation
rugged spire
alright
just curious though
why do you want to move all the vencord files into an asar archive
rugged spire
its real π
fossil inlet
Wtf is ventord
gritty iris
Vencord for people who need femboy pics command
I can see one person I know using that plugin
istg if I get a ping telling me to add it 
rugged spire
I can see one person I know using that plugin
who π
rugged spire
gritty iris
not even a second
gritty iris
rugged spire
vencord users on their way to make plugins that may or may not add slash commands that immediately send NSFW content:
i dont even think im safe from that one fuck you @still wasp (for actually making my stupid idea) 
?remindme 1h revive GifRoulette and make it even more obnoxious
shut vineBOT
Alright @rugged spire, in 1 hour: revive GifRoulette and make it even more obnoxious
gritty iris
real
rugged spire
real
still wasp
i dont even think im safe from that one fuck you <@976176454511509554> (for actu...
You asked for it fuck you
You ask and i deliver
glass jasper
<:gone:1226692404925562991>
I will turn Equicord into the Femboy fork
I can not be stopped
sterile oak
sam cute when mad
shut vineBOT
@rugged spire, <t:1721336719:R>: revive GifRoulette and make it even more obnoxious
rugged spire
no
swift fjord
why do you want to move all the vencord files into an asar archive
for localization
so strings can be packaged
rugged spire
but
there is no localization api for vencord yet
is that being built along with this?
swift fjord
forgot it was restricted
rugged spire
it was open to viewing previously
glass jasper
<#1247190321423716352>
no access my beloved
swift fjord
Β―\_(γ)_/Β―
vee took our ability to edit channels away so cant do anything about it
rugged spire
vee took our ability to edit channels away so cant do anything about it
for security?
swift fjord
i can let you in if you plan on contributing to localization
woeful sable
i can let you in if you plan on contributing to localization
how many things is there to translate
rugged spire
i can let you in if you plan on contributing to localization
i'm not really suited for providing translations but i might be interested in how the system works, come back to me about it later
swift fjord
how many things is there to translate
all the ui
woeful sable
all the ui
does this include plugins?
rugged spire
maybe don't squish everything into one source file
swift fjord
maybe don't squish everything into one source file
i think its split per plugin
woeful sable
π
swift fjord
does this include setting names?
everything except plugin names iirc
swift fjord
we're only going to support the languages that discord does
rugged spire
separate translations folder is a bad idea imo
woeful sable
latvian is in there
swift fjord
cool
rugged spire
really bad for dev UX imo
swift fjord
then ig just wait
rugged spire
really bad for dev UX imo
jumping outside of your plugins' folder to write text seems kinda bad for dev workflows?
can you partially expand a folder in vscode (no?)
swift fjord
really bad for dev UX imo
its better for the localization software we're going to use
easier to have them all in one place
rugged spire
its better for the localization software we're going to use
what software did you decide on
woeful sable
jumping outside of your plugins' folder to write text seems kinda bad for dev wo...
you can also just open it as a second file
rugged spire
you can also just open it as a second file
ofc
swift fjord
what software did you decide on
crowdin
woeful sable
its ai powered π₯ (trust)
swift fjord
no selfhosting
rugged spire
no selfhosting
wtf
woeful sable
rugged spire
are you saying that is a selling point
woeful sable
60,000 hosted words π
swift fjord
*are you saying that is a selling point*
being forced to selfhost is a bad thing
swift fjord
ik about weblate
rugged spire
ik about weblate
yeah iirc some of the other devs had issues with it though
swift fjord
lewi had their own reason for crowdin i just can't remember
rugged spire
nah sounds like "let us use your project as AI training data for other people to use"
swift fjord
i think it was about a specific string type or something
swift fjord
j
austere talon
im going insane
swift fjord
love
spark cove
how lovely
swift fjord
shrodingers asar file
somber thorn
π₯
spark cove
I build the asar branch at the j commit and relaunched. Got an error probably becuase I'm using the git updater. Went back and built main branch and relaunched,, now my localstorage is resetting every launch lmao this behaviour is wild
austere talon
I build the asar branch at the j commit and relaunched. Got an error probably be...
what error?
it should work fine
oh nvm
austere talon
you need this
spark cove
I think it was like
austere talon
duplicate listener
austere talon
yes
spark cove
thank god
austere talon
it was cause I was accidently importing http updater even in git updater builds
which led to duplicate handlers
charred monolithBOT
austere talon
is that on windows?
spark cove
yea
austere talon
can you try with normal install
pnpm build --standalone then copy all files from dist/desktop to AppData/Vencord/dist
and launch Discord
it should migrate and relaunch and work
spark cove
so
oh with normal installer first ok
seems like that worked
it did something before it actually opened a visible window
oh probably made vencord.asar
austere talon
oh probably made vencord.asar
it downloads vencord.asar, writes this to vencordFiles/patcher.js:
// Legacy shim for new asar
require("../vencord.asar");
```then relaunchesyea worked
austere talon
can u verify that patcher.js indeed contains that
spark cove
yea it does
austere talon
fire
now just need to test updater too and also workflows
and then update installer and vesktop
limber skiff
alright
austere talon
working on this rn https://github.com/Vendicated/Vencord/pull/2707
limber skiff
yep I saw it
austere talon
is github ok
austere talon
okay it works
charred monolithBOT
swift fjord
pnpm tauri
spark cove
amaze balls
austere talon
amaze balls
wha
austere talon
okay now i only need to test on windows and also test the updater
then make release of installer, vesktop and vencord
i will do tomorrow
so if soimething goes wrong i have plenty of time
imagine if i push this rn then go sleep
stuff will explode maybe and average support user will die without their vencord
swift fjord
i will do tomorrow
pushing big update on a friday
you'll do great if you get a software engineering job
dapper crest
Please do not private message Vencord plugin developers for support!
Instead, use the Vencord support channel: β Vencord Vendor Venniecordβ π₯-vencord-support-π₯
This warning should not show up if you have a friend request from the developer
austere talon
irrelevant
fossil inlet
> Please do not private message Vencord plugin developers for support!
> Instead...
i disabled that in my build 
crude raptor
it agrees with this sentiment
its weird when someone friends or DMs you and then your client tries to tell you off
fossil inlet
also just accept the request or remove the warning
dapper crest
I should be able to meow at people and not have them be yelled at for looking
fossil inlet
the message is prob for the better tho
austere talon
horro
austere talon
OMG
limber skiff
okay this should work
limber skiff
π
limber skiff
discord
spark cove
amzing
austere talon
but i think any minifier will do this
limber skiff
I'm surprised this never happened before
spark cove
oh i see lol true
austere talon
it's fairly unlikely for ids to have 3 consecutive zeroes as ending ig
charred monolithBOT
Discord Account
CJStylesOrg
What happens when the bug or crash occurs?
the roles will not show up on the mod view at all despite the user having a role shown in their profile. i have tested this on Bread (304260051915374603) whom is a plugin developer in BetterDiscord. cases like this are rare but i managed to stumble upon this.
What is the expected behaviour?
i expect the plugin to...
rugged spire
& friendssince broken on canary
we need a Inject profile data feature for this at this point π
I maintain a similar plugin
also broken again
woeful sable
π
rugged spire
ignore that
gritty iris
I'm never getting the time I spent porting stuff because of vesktops downloader hating asar files
austere talon
I'm never getting the time I spent porting stuff because of vesktops downloader ...
the commit in vesktop is broken
i already fixed it but I didn't push that
charred monolithBOT
austere talon
π
looks like u cant really reload asar
so in dev it would have to build non asar
gritty iris
am I missing something about the rpc part?
pine topaz
this edits the profile status
gritty iris
yes
but what does rpc have to do with editing the profile status?
is either an option I missed or
charred monolithBOT
desert cosmos
not really selfbot in my opinion as it requires you to actually do something (start some registered application)
but maybe spammy no clue
charred monolithBOT
charred monolithBOT
austere talon
oh
charred monolithBOT
desert cosmos
discord try not to break FriendsSince challenge impossible
brazen bone
git diff
crude hearth
why can you forward embeds individually
gritty iris
we love that canary is fine
charred monolithBOT
gritty iris
this is the only broken thing I can find between Vencord Vesktop and the Installer
anyways im off 2 work
charred monolithBOT
charred monolithBOT
Discord Account
CJStylesOrg
What happens when the bug or crash occurs?
When I delete messages starting from the top of the thread downwards, the messages automatically collapse again after each deletion from the top. However, if I delete messages from any other position in the messages (not starting from the top), the collapsed messages remain expanded and do not collapse.
What is the expected behaviour?
I expect the message lo...
austere talon
@brazen bone what do u think?
hallow kestrel
oh wait while we're at the topic of collapse messages now, i notice that when i turn off the option and delete a message, it continues to collapse newly deleted messages until you relaunch discord.
assuming their was supposed to be a prompt telling you to relaunch discord, same issue i made about showhiddenthings which was fixed.
rugged spire
trolled
brazen bone
<@236588665420251137> what do u think?
Smells like (very minor) discord bug to me
austere talon
it is yeah
rugged spire
Smells like (very minor) discord bug to me
yet another "very minor discord bug" exposed by a vencord plugin
i can relate 
fossil inlet
yet another "very minor discord bug" exposed by a vencord plugin
if its only exposed by a plugin, is it really a bug
rugged spire
if its only exposed by a plugin, is it really a bug
neither the bug mentioned here and the bug I found yesterday are only exposed by a plugin
both can be found in stock discord, albeit slightly rarer to experience
fossil inlet
ah
brazen bone
Have blocked user post two messages, uncollapse, delete first
rugged spire
Bug I found: Open mod view from context menu, no highest role because discord stupid and goes through membersafetystore to get that
brazen bone
Probably (without looking at the code) the collapsed message group is keyed by first message id, so when the first id in the group changes, the useState is reset
No idea how you'd go about fixing that
charred monolithBOT
gritty iris
My helpful assistant @glass jasper has tested this for me and this has fixed it
gritty iris
I was apparently too tired to even notice it was still mjs until now ig
glass jasper
idk what happened he just blew my computer up telling me what to do.
gritty iris
idk what happened he just blew my computer up telling me what to do.
You are now infected hahahhaha
glass jasper
You are now infected hahahhaha
pretty sure that started when you got me on board helping with Equicord (/joke)
austere talon
I was apparently too tired to even notice it was still mjs until now ig
mjs is correct tho
that's deliberate
esm is a fuck
gritty iris
esm is a fuck
I dont even know anymore
it wont compile for me
but compiles for indi
.mjs is right
so
why
gee
its adding a third /?
austere talon
wdym esnext lol
gritty iris
idk just what I remembered from the name
of the commit
that commit
sorry esbuild
austere talon
its not that easy to fix
limber skiff
but outside of that building works fine
gritty iris
tf
gritty iris
ye just merged it
limber skiff
try on node 20
charred monolithBOT
charred monolithBOT
added support for voice messages, keep in mind that i tried my best to ensure the filter values are as identical as the status danger variable, feel free to change it before this gets merged in the future to the best liking.
limber skiff
of course they are not gonna merge canary into stable for the whole weekend
hallow kestrel
friendsince gonna last longer against other plugins in bad patches. π₯
brazen bone
Why is friendssince so fragile?
hallow kestrel
assuming discord is really actively working on profiles, since canary got a new look with the new add friend and message button.
previously it was behind an experiment.
rugged spire
Why is friendssince so fragile?
Discord LOVES redesigning the user profile in the DM sidebar
hallow kestrel
i think that is why it added duplicate @ symbols in the mod view in my snippet.
rugged spire
i think that is why it added duplicate @ symbols in the mod view in my snippet.
screenshot?
mod view internal code is disgusting tbh
hallow kestrel
rugged spire
hallow kestrel
this is what it looked like days ago, i just grabbed the old code before i made changes to it.
simple fix though
rugged spire
fun fact
you cant see this highest role in mod view on anyone here
Try it.
The role just doesn't appear, at all
hallow kestrel
oh yeah im the one that made the issue and you responded to it.
rugged spire
oh
hallow kestrel
that is honestly stupid though, im sure this new refresh their doing is them trying to sort out this mess.
rugged spire
oh <:SKULL_SKELETON:1133504974777757726>
how tf did I not even realise that
rugged spire
that is honestly stupid though, im sure this new refresh their doing is them try...
doubt
brazen bone
When was the last time discord sorted out a mess
rugged spire
idk 
mod view needs other fixes too
why doesn't it show what time today something happened
knowing "It happened... today" is entirely useless
not to mention how it doesn't show who the action was taken against, only who took the action (sometimes?)
hallow kestrel
at first i thought the @ symbol was from my snippet but realized it was there before-hand.
was this added by the plugin or discord?
rugged spire
what plugin are you talking about
hallow kestrel
what plugin are you talking about
the @ symbol in the mod view action logs.
shut vineBOT
@rugged spire, <t:1721340367:R>: revive GifRoulette and make it even more obnoxious
fallen vale
mood
limber skiff
aaa not the debug stuff
brazen bone
Such good commit messages
limber skiff
mapMangledModule such an advanced find
charred monolithBOT
gritty iris
I caused this!!!
rugged spire
what did you do
austere talon
okay so if you update the asar but don't restart the app and only soft reload, it uses state of the old asar which causes this shit
(fixed by full restarting)
so we should force a full restart
or is there some way to invalidate cache of asar
happens on BD too xd
i think vencord should force restart after an update
actually no we cant
cause of auto update
austere talon
how does discord solve this in their updater
maybe download update to vencord.asar.new and apply on before-quit?
π
austere talon
it doesnt work...
limber skiff
π
austere talon
maybe download update to `vencord.asar.new` and apply on `before-quit`?
i think this is the only option
limber skiff
which means only actually applying the update after a full restart regardless right
austere talon
yes
limber skiff
if I use the inject script will it use the old installer which doesnt support asar
okay yes it will
charred monolithBOT
austere talon
if I use the inject script will it use the old installer which doesnt support as...
yes
you need to build new installer
or
limber skiff
its probably easier for me to manually install than to clone and build windows
austere talon
u can do it really easily
go into patcher.js, search for Vendicated/Vencord and change it to Vendicated/VencordStaging
then update via in app updater
well that's for standalone xd
limber skiff
isnt it easier for me to manually inject
austere talon
kinda
limber skiff
should I look into the code for the installer or its quick to explain what to do
austere talon
well what do u want to test exactly
limber skiff
anything lmao
austere talon
first of all, check out the branch and build and ur dev install should still work without having to reinstall
other than that just build the installer from source and put it where the runInstaller.mjs script downloads installer to
if you build the cli instead of gui, you only need go installed and nothing else and it will compile fast
go build --tags cli
that'll build the cli
austere talon
yeah but this is not a proper install
austere talon
yeah but this is not a proper install
it just overwrites dist/patcher.js with that code
austere talon
because the installer puts app.asar which is hardcoded to import AppData/Vencord/dist/patcher.js
so users would have to reinstall
limber skiff
I see
austere talon
but yeah just build the cli it won't take u long
building gui neds a bunch of c++ libraries and 5+ minutes to compile so don't do that xd
anyway i would say the PR is pretty finalised now
just need to do a bit more testing and then we can release it
hopefully tomorrow
austere talon
yes
nothing changed about it
it's the same as before, just slightly different app.asar contents
limber skiff
alright it worked
austere talon
btw the new installer should also just work when run in normal mode cause i uploaded a testing build to main repo releases
limber skiff
okay so if you update the asar but don't restart the app and only soft reload, i...
okay how do you cause this explosion?
change anything and build again or something in particular
austere talon
you need to change vencord.asar to a different build and then reload
limber skiff
so you need to do a standalone build?
austere talon
but anyway this should fix it
i wouldn't bother looking more into fixing it
the apply on quit solution is perfect imo
it will also prevent issues with making change in main and then people only reload renderer and renderer expects new main but really has old main
happened a few times in the past
limber skiff
alright
austere talon
the way i was testing updater is that i just made a separate repo at https://github.com/Vendicated/VencordStaging
and pushed random commits
who tf starring that repo
austere talon
we can delete all .js, .map and .LEGAL.txt files except patcher.js
limber skiff
why is patcher needed still?
austere talon
the way i was testing updater is that i just made a separate repo at https://git...
if u wanna help me test updater:
- make a repo like this ^
- create devbuild release (empty) and enable workflows
- push my asar branch to main branch in ur repo and make sure that it creates release
- install normal vencord with the old official installer, open
patcher.js, and change allVendicated/Vencordto your repo you made - update once with in app updater
- now when you open Discord next time, it should migrate you to new asar install
- now push some commit to your repo and update with in app updater
limber skiff
I will help you test rn since after tomorrow I will be far away from my pc
for days
austere talon
scary
limber skiff
so this is the last time I can lol
austere talon
if u wanna help me test updater:
- make a repo like this ^
- create devbuild rel...
just make sure that it works
and uhhh be very careful to push to the right repo and not vencord main repo
limber skiff
@austere talon do I need to add any env vars?
limber skiff
oh rightt
limber skiff
@austere talon I updated and choose to not restart
then when I clicked to exit discord using the tray
austere talon
which one
limber skiff
vencord.asar
austere talon
okay
austere talon
yeah cause it applies old updates on boot
limber skiff
yep
austere talon
anyway it's not hard to fix
just need to
- rename
vencord.asar->vencord.asar.old - rename
vencord.asar.new->vencord.asar
on boot:
- delete
vencord.asar.old
maybe u wanna do that
if not thats okay, i'll do tomorrow
limber skiff
I dont think that will work
unless using the explorer is different than using the apis
grave mangoBOT
https://github.com/Vencord/Installer/blob/main/self_updater.go#L113-L121
self_updater.go: Lines 113-121
if err = os.Remove(ownExePath); err != nil {
if err = os.Rename(ownExePath, ownExePath+".old"); err != nil {
return fmt.Errorf("Failed to remove/rename own executable: %w", err)
}
}
if err = os.Rename(tmp.Name(), ownExePath); err != nil {
return fmt.Errorf("Failed to replace self with updated executable. Please manually redownload the installer: %w", err)
}
try it with pwsh / cmd
austere talon
I tried with renameSync
did it work
limber skiff
nop
austere talon
well i'll try tmrw
rugged spire
dumb suggestion
why don't you just perform this logic before vencord.asar is even loaded using a stub loader of some kind
limber skiff
alright
fallen vale
i think the name could be a tad more descriptive
brazen bone
That sounds like it would ignore the toggle on send, not receive
still wasp
Yeah that's what i was thinking
hidden grotto
https://docs.vencord.dev/installing/
Docs seem to be wrong on building from src, use buildWeb instead of build --web on windows, looking @ package.json and the scripts with gitblame I don't see when/how this changed recently.
#π₯-vencord-support-π₯ message is there a better channel for this?
nimble plaza
buildWeb was always a seperate script, whoever put that in the docs was wrong
hidden grotto
Looking back further, it was always wrong, heh.
gritty iris
if u wanna help me test updater:
- make a repo like this ^
- create devbuild rel...
I've been doing this for a while now and I can confirm it works
brazen bone
Anyone know how to deal with scrollers? Currently when a message is very long the ML modal has a scrollbar over the entire contents including the tab bar, but I'd rather have the tab bar stay at the top and only scroll the message content
grave mangoBOT
Also
https://github.com/Vendicated/Vencord/blob/main/src%2Fwebpack%2Fcommon%2Fty...
src/webpack/common/types/components.d.ts: Lines 457-468
export type ScrollerThin = ComponentType<PropsWithChildren<{
className?: string;
style?: CSSProperties;
dir?: "ltr";
orientation?: "horizontal" | "vertical";
paddingFix?: boolean;
fade?: boolean;
onClose?(): void;
onScroll?(): void;
}>>;
Looks like it
brazen bone
Doesn't seem to work, probably because it's already inside another scroller
fallen vale
oops :p
hidden grotto
spark pivot
btw: https://about.signpath.io/product/editions
Free OSS Code signing
It's not...
Oh I didnβt scroll down
turbid hatch
it would unfortunately still require us to leak one of our names or establish a company (which will still require that anyway)
- globalsign certificates need to belong to a legally registered org
i dont know if signpath take that responsibility when issuing for open source
ah
it comes up as signpath foundation
i guess thats not a bad solution
we'll see
we have to put it through their infra though which is kind of a blackbox
fallen vale
it is, youre right
desert cosmos
switch to alt
create new issue
disregard comments from vee
fallen vale
if its been reported twice its prob an actual issue, i can't replicate though
hallow kestrel
wrong, the commit number is 686f2d9 
fallen vale
wrong, the commit number is 686f2d9 <:blobcatcool:1202289299060428831>
oh true, the extra f
hallow kestrel
i love how that person just scrolls all the way down the commits just to comment on a random commit from december of 2023.
dawn coyote
posts useless comment
comment is wrong
hidden grotto
we have to put it through their infra though which is kind of a blackbox
If their infra is ever compromised, there are way bigger issues then some APT spoofing a vencord install.
And I don't think 99% of companies should be self hosting code signing.
It's hard, plus the dongles.
Tons of benefits for very little risk
pine topaz
wrong, extra f added
turbid hatch
And I don't think 99% of companies should be self hosting code signing.
It's ha...
literally every company that buys their own certificates either goes through a cloud blackbox or, if required for auditing purposes (so most companies), uses the dongles/provided server
you can get a signing server to install and put on the network
blackboxes and blind trust are not good security practice (see: literally crowdstrike)
i'd rather not sign if there's no way for us to actually sign our code ourselves
i dont trust random companies that offer codesigning for free if you dont get the certificate
plus most companies dont want to submit their code through the cloud blackbox because of trade secret reasons
im aware this is different because its OSS software, but we still dont know what they're doing and they don't publish the process anywhere
i give it an executable, i get a different, signed executable back out
i dont know whats going on in between
i wish we could get the old open source developer certificates back
those were fire
and you got to actually keep them yourself and run your own signing process
shut vineBOT
@rugged spire, <t:1721513189:R>: revive GifRoulette and make it even more obnoxious
rugged spire
<@259558259491340288>, <t:1721513189:R>: revive GifRoulette and make it even mor...
you know what i have been pushing this back too much no i am not fixing
hidden grotto
you can get a signing server to install and put on the network
That's the issue.
(From the stance of prodsec of a security vendor) Securing the network and having a prodsec team to analysis stuff when it gets flagged (supplychain attack style) is not easy. SLSA is going to help get companies to where they need to be but OSS does not have the infra in place for it.
I don't see most of the above from my view of things, but maybe it's different in SMB?
https://azure.microsoft.com/en-us/products/trusted-signing would be an alternative for companies, but requirements are a lot higher.
Verifying code is super easy now too. Heck, Ghidra is free and you can do so much with just hashes.
I get the FOSS communities want to DIY stuff, but somethings are better to be secured at scale where more resources can be spent
hidden grotto
literally every company that buys their own certificates either goes through a c...
And that's why most companies have horrid security, then try to selfhost and then their cert is leaked for cheatdevs. Cloud based solutions are better then what 99% of companies can DIY. ;-;
dawn coyote
i wouldnβt want to run an exe from a black box
hidden grotto
i wouldnβt want to run an exe from a black box
Unless you are building from source, GHA is a black box π¦ (SLSA + syscall tracing would help tho)
fallen vale
friendssince my beloved
glass jasper
what does discord have against friendssince?
fallen vale
they're messin around with profiles
austere talon
oh they finally pushed it to stable
hallow kestrel
they're messin around with profiles
most likely getting ready to probably change the message box in profile popouts to just a message button.
this is using the cta message and call experiment on canary but they removed an experiment recently which changed the design of the add friend button, forcing it to the stable build too, this is likely next.
austere talon
huh
@limber skiff u love
they broke again xdddd
looks like old patch works again
charred monolithBOT
charred monolithBOT
jagged cloak
lool
charred monolithBOT
RelationshipPruner allows you to easily go through and remove your friends/servers (useful, especially if you have a lot). You can view relevant information to help you make the decision
There may be some parts that could be improved, mainly the api requests in the guild prune modal- they should be fine but it's...
charred monolithBOT
spark pivot
why c# style
still wasp
why c# style
You saw nothing
spark pivot
missed a few spots lol
crude raptor
is that specifically a c# thing? thought it was just how some IDEs formatted code by default
spark pivot
most c# code i see or write looks like that
also ides tend to format it like that by default
rugged spire
looks like old patch works again
horror
spark pivot
REAL
fallen vale
C# WAS MY FIRST LANGUAGE LEAVE ME ALONE π
it's conventions are disgusting though
-a c# dev
austere talon
it is conventions are disgusting though
fossil inlet
C# WAS MY FIRST LANGUAGE LEAVE ME ALONE π
You need help
fallen vale
it is conventions are disgusting though
auto correct, vee, auto correct..
inland fable
@austere talon hello sorry for being months late never noticed you responded to my PR cause i dont check my email often
you suggested this change however when i remove the count thing and there are more users than the max (12) the count is needed for it to show "+1" or +2 wtv properly
with
without
inland fable
fuck i broke something
im gonna cry i dont understand git
is there any chance i could close my old pr and make a new one because idk how to fix git issue
limber skiff
what's the issue
inland fable
what's the issue
i didnt touch the pictureInPicture thing at all
and some stuff are red in constants when i just added myself
limber skiff
I will resolve for you
actually no I cant
what's the name of the vencord repo remote you have
upstream? origin?
inland fable
I will resolve for you
alright i fixed it i think i just uh
went to github.com/Vendicated/Vencord and copypasted the files it says i modified into my local repo
charred monolithBOT
I believe this line is needed in order to properly display the more users thing
With
Without
inland fable
Doesn't it make it worse?
13 is definitely not *many people* + 12
sorry for my wording: "+12" is wrong and thats what it says without the line I was suggested to remove, with the line it shows "+2" which is accurate
granite sky
Oh, my bad
I thought with/without this change
median rapids
fallen vale
oops
desert cosmos
insightful
fallen vale
i didnt realise they changed it already
dusk blaze
fallen vale
pointing stuff out on drafts isnt the end of the world lol
glass jasper
not enough arrows, i dont know what im suppose to be looking at
fallen vale
it just-so-happens that they already caught it
fallen vale
github webhooks how i dont love you <3
rugged spire
You will push 0 commits
fallen vale
i would heart emoji react that but im kinda in a weird state of schrodinger's programmer which prevents me from doing so
gritty iris
thanks for the heads up whoever you are!
fallen vale
thanks for the heads up whoever you are!
hm?
charred monolithBOT
jagged cloak
cant wait for ppl to complain abt it not working/spam cause a nonzero amount of servers have the spoiler thing automodded
glass jasper
cant wait for ppl to complain abt it not working/spam cause a nonzero amount of ...
100% any normal auto will block this
sleek pine
I searched for this here but what about switching to bun for faster deps install times? Bun is already for windows and it should work fine, i can also make pr but asking first. Well yeah it's maybe pointless as vendicated said earlier but still it reduces time.
austere talon
I searched for this here but what about switching to bun for faster deps install...
why
pnpm is already very fast
and it's also irrelevant
sleek pine
I've always had faster installation times with bun and also running scripts from pkgjson but yeah if it's irrelevant then there's no reason to do it
brazen bone
Building is already just about instant, especially with pnpm watch
turbid hatch
also installing a whole new runtime just for package management seems a bit pointless
charred monolithBOT
fallen vale
isn't this not allowed?
heavy bloom
isn't this not allowed?
i got explicit permission from ven #π§©-plugin-development
fallen vale
makes sense
fallen vale
lol
fallen vale
the part i commented on
weary bolt
*the part i commented on*
ik i said in le thing
fallen vale
ik i said in le thing
no, i mean what does the line i commented on mean
weary bolt
no, i mean what does the line i commented on mean
what line, u commented on four lines
fallen vale
no i didnt
weary bolt
no i didnt
well it shows that so um was it the facebook line
fallen vale
well it shows that so um was it the facebook line
mhm
crude hearth
I think directly using restapi is a bad idea
charred monolithBOT
Discord Account
@lncvrt
What happens when the bug or crash occurs?
The bug is the icon for platform indicators console is messed up
What is the expected behaviour?
Should be a proper icon
How do you recreate this bug or crash?
Find a person on a console then use platform indicators
Errors
No response
Request Agreement
- [X] I am using Discord Stable or tried on Stabl...
brazen bone
No, fridge sounds about right, speaking as a pc gamer
Since when does discord run on consoles
nimble plaza
xbox and ps5 have it now
charred monolithBOT
I believe that image is correct, it's showing a fridge.
Well it's a Xbox Series X from the angle like the picture below
I mean the icon looks like its more like rotated 35Β° to the left but whatever.
desert cosmos
I love github
fallen vale
I love github
said no one ever
spark pivot
I love github
limber skiff
someone find for me the name of the store that has the getLocalPresence function
uneven needle
selfpresencestore
nimble plaza
EditMessageStore
limber skiff
thank youu
fallen vale
EditMessageStore
just ooc, how are you finding these
limber skiff
I'm cleaning up my branch without touching discord code since I'm using a potato laptop
nimble plaza
findByProps(funcname) -> show function definition -> scroll down a bit to find the displayname
lemme make a cid
vid
brazen bone
For me it's just a quick grep
limber skiff
another one
getMessageRequestsCount
nimble plaza
UploadAttachmentStore
limber skiff
nice
brazen bone
Easy stuff
nimble plaza
scary
limber skiff
allSummaries, findSummary
nimble plaza
SummaryStore
limber skiff
getPendingReply
fallen vale
@limber skiff just ooc, whatre ya doin?
limber skiff
also is getPlayerState from a store (Spotify related)
limber skiff
<@235834946571337729> just ooc, whatre ya doin?
cleaning up a branch and also converting findByProps to findStore when possible
nimble plaza
getPendingReply
PendingReplyStore
nimble plaza
also is getPlayerState from a store (Spotify related)
yop, SpotifyStore
nimble plaza
SortedVoiceStateStore
limber skiff
does it have getCurrentClientVoiceChannelId too?
limber skiff
I see
somber thorn
π§Ή
fallen vale
no.
frail skyBOT
limber skiff
oh so it wasn't all my fault
brazen bone
It's only crazy because of all the \u{}, without that it looks pretty tame
It's just \[#([a-fA-F0-9]{0,6}),#([a-fA-F0-9]{0,6})\], but with tag characters instead of ascii
rugged spire
It's only crazy because of all the \u{}, without that it looks pretty tame
I know :(
charred monolithBOT
still wasp
Absolute madlad
gritty iris
What are those fixes tf
Did discord actually name something isCopiedStreakGodlike lol
gritty iris
Did discord actually name something isCopiedStreakGodlike lol
I just matched it to "account";
rugged spire
Did discord actually name something isCopiedStreakGodlike lol
this thing
gritty iris
this thing
What the
gritty iris
I'm confused on why the look back
woeful sable
even before simplified profiles
wasnt it originally the thing when u click on ur profile here it copies the username, but copying it multiple times gives u the easter egg
rugged spire
wasnt it originally the thing when u click on ur profile here it copies the user...
Yes
uneven needle
I'm confused on why the look back
because other wise it adds to let {foo: bar} = e;
gritty iris
because other wise it adds to let {foo: bar} = e;
If I'm not mistaken discord just added the let correct?
Or are we looking 2 different places
It seems to work fine with the match match: /dataSafeSrc:\i,children:/, if you want you can test it
uneven needle
but why should i change it again
gritty iris
but why should i change it again
I don't think the look back is necessary
rugged spire
Lookback kabooms your performance too iirc
gritty iris
That's all I'm saying
rugged spire
Lookback kabooms your performance too iirc
Don't count me on that
brazen bone
Lookback kabooms your performance too iirc
One millisecond on load doesn't really matter
uneven needle
Lookback kabooms your performance too iirc
it doesnt much here
rugged spire
One millisecond on load doesn't really matter
- Words of someone not using a laptop
gritty iris
when was your laptop made 
brazen bone
Unless your laptop is moving at relativistic speeds, a millisecond is equally long on all hardware
If your laptop is moving at relativistic speeds, I lift my hat to you
uneven needle
If I'm not mistaken discord just added the let correct?
before it was ,placeholderVersion:foo}=this.props; but they added dataSafeSrc after that so now it matches that instead
gritty iris
before it was ,placeholderVersion:foo}=this.props; but they added dataSafeSrc af...
Your matching the wrong thing then?
If it ended at : foo } then it was matching below it because of the ,
uneven needle
Your matching the wrong thing then?
no the current version matches the wrong one
gritty iris
I'm so confused
If your matching the thing below the let then why the look back it makes no sense
You can just match to what's after placeholderVersion and it's fine
gritty iris
no the current version matches the wrong one
I thought you were patching the let mb
uneven needle
If your matching the thing below the let then why the look back it makes no sens...
... because it regex doesn't know it below the let? Thats what im doing with the lookbehind
gritty iris
It does tho?
I did it?
Don't match placeholderVersion?
Match dataSafeSrc?
Wait
I'm so lost
uneven needle
Match dataSafeSrc?
what if they add more variables to destructure
we will back here again
gritty iris
.{1,50} is what I used to get around that
At this point just match children
,children: (joke)
austere talon
apparently you can now use listening RPC on canary
so the activity fixer is no longer needed
frail skyBOT
woeful sable
el patch.
austere talon
oh broken on stable too
frail skyBOT
scenic fog
for the ClientTheme thing (the bad find), I did that a bit ago https://github.com/Vendicated/Vencord/pull/2720
charred monolithBOT
uneven needle