Yop
#๐พ-core-development
crude hearth
limber skiff
how did I confuse "if" with "with"
limber skiff
this is funny
charred monolithBOT
This fixes bug where Markdown headers from deleted logged messages don't show as red text (if option is enabled)
without fix:
with fix:
charred monolithBOT
rugged spire
insane
austere talon
one cant possibly be fat finger control and R that much right
LMAO i do a lot
trying to open emote picker (ctrl + e)
jagged cloak
github ate the lines i selected
austere talon
average plugin merge time [clueless](https://cdn.discordapp.com/emojis/121116108...
tbf there was unresolved feedback for a long time 
(but its completely understandable that you'd lose interest in resolving it considering the feedback was only sent months later)
nimble plaza
i havent got any github notifications in a while wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA ill fix my notifications
austere talon
speaking of which you still have another pr with unresolved feedback (banners everywhere) if u wanna finish that
austere talon
i havent got any github notifications in a while [wAAAAAAAAAAAAAAAAAAAAAAAAAAAAA...
oh these are months ago :p
and yeah i'm trying to get old stuff merged but its a veeeeery long backlog
its pain cause every time i merge 10 prs, 10 new ones get made ๐ญ
i did like 40prs on one day fairly recently, dropping prs to 140, then later even more getting them down to like 120 but now we're at 132 again
limber skiff
and me doing refactors doesn't make it easier lol
shell shuttle
still works this time :3
wowowoooaaahhh
austere talon
this is not the first person claiming that having quickcss + theme somehow causes lag
inb4 this is some really cursed css thing
sterile oak
its pain cause every time i merge 10 prs, 10 new ones get made ๐ญ
hmmm, get nuckyz to help in merging?
jagged cloak
some ppl rlly just want a contrib badge or sm
sterile oak
bruh, the bug is still not fixed?
jagged cloak
why do i bother
(i am bored)
also zero effort went into making that its literally one glance to tell everytime 
rugged spire
java reference
austere talon
tbf dom manipulation is fine for that
turbid hatch
^ tested, works fine
and the only blocker was the js -> txt
wuh oh
why did that fail to compile
wtf
literally compiled it on my machine fine
austere talon
i think the patches could use some improvement tbh
turbid hatch
oh was it the rebase dev
turbid hatch
i think the patches could use some improvement tbh
i think for the purposes of what the PR does, its fine as is
we can rework the patches separately
austere talon
wdym
turbid hatch
the PR accomplishes the whole custom quotes thing
turbid hatch
woah hello
turbid hatch
the PR accomplishes the whole custom quotes thing
we should try and avoid lumping things like patch changes into the same PR when the patches work fine, yes it reduces the amount of PRs but it increases the scope from what the original contributor wanted to work on
turbid hatch
oh i thought you were fine with it because it wasnt pointed out in review
:p
i need to fix the filecontent stuff anytway
ah i see it was changed quite literally 24 hours ago
i see
btw are we using codium now as like
a proper thing
or just on one offs
austere talon
it sucks ass it was just as a joke lmao
turbid hatch
actually
why were the patches changed like that
im confused
they seem way more complicated than they need to be
am i silly for thinking that or
oh >enableDiscordPresetQuotes
i see
okay lets see what i can do here
austere talon
im fixing them rn :p
jagged cloak
btw are we using codium now as like
use only on mantika prs
jagged cloak
jagged cloak
fat fingered buttons count
austere talon
this is also safer cause it doesnt reassign the variable
so if they ever change it to const it wont error
austere talon
xd
jagged cloak
(no)
somber thorn
really no.
charred monolithBOT
Pasting a link while you have text selected will paste your link as a masked link at that location
austere talon
STOP OPENING PRS
rugged spire
STOP OPENING PRS
Nop
austere talon
need somebody to make a "STOP DOING PRS" meme
you know those graphics
rugged spire
I have at least 5 finished plugins that I just never ended up submitting
austere talon
rugged spire
i can't wait to submit a PR and get a reply saying "FUCK OFF"
rugged spire
https://discord.com/channels/1015060230222131221/1216096162008924291/12436817911...
Yop
Please choose your preferred method of harrassment
lol why do i still have this branch
i should bomb it
feature exists in upstream since i made it
fuck off devs list merge conflict
spark pivot
fuck off devs list merge conflict
this is why i put my addition to devs one above the last one
rugged spire
this is why i put my addition to devs one above the last one
too late to fix for all my legacy branches 
will just merge dev branch
somber thorn
You forgot adding files through upload
still wasp
jagged cloak
austere talon
idk xd
austere talon
.GUILD_PROFILE(
oh its just profile update
i would assume guild profile is always cached or smth
actually idk
await (0,
r.fetchProfile)(e, {
withMutualGuilds: T,
withMutualFriends: S,
withMutualFriendsCount: f,
friendToken: h,
guildId: N,
connectionsRoleId: c,
abortSignal: O
}, U)
it seems to be because of the dispatch under
but I guess it doesnt account for the cache when requesting
so you need to check the store, and cache if empty
oh
yall moved o #๐งฉ-plugin-development
oops
charred monolithBOT
limber skiff
this is like almost impossible to happen but why not
austere talon
how so fast
xd [] || undefined is still []
did u test that it still works
i cant exactly test it cause u know...
thanks for the swift fixes btw 
glass jasper
email jumpscare
charred monolithBOT
austere talon
did u test that it still works
@placid hinge 
austere talon
<@929208515883569182> is updating it now
why do it so strange xd
jagged reef
why do it so strange xd
I'm not on their fork lol
jagged reef
so I can't commit to the PR
austere talon
jagged reef
just pr to their fork or have them invite u xd
Too much work fr ;3
new longest username in chat lmao
sterile oak
new longest username in chat lmao
fitting for vee
austere talon
hmm yes foo.includes(foo)
jagged reef
hmm yes `foo.includes(foo)` <:blobcatcozy:1026533070955872337>
while (true) {run(git push -f)}
charred monolithBOT
glass jasper
My computer is hard-core bugging right now so I donโt know what is happening
glass jasper
new longest username in chat lmao
fr
jagged reef
all fixed
charred monolithBOT
charred monolithBOT
median rapids
charred monolithBOT
charred monolithBOT
charred monolithBOT
spark pivot
@still wasp
still wasp
<@976176454511509554>
Ay my bad
charred monolithBOT
charred monolithBOT
It adds the /uwuify command that just makes your message more "cute" based off of a long word and letter replacement list and some suffixes.
It does not have any super special characters in the suffixes or replacements so it shouldn't get automodded in some servers with those "English only" automods.
What it looks like:
Some options for it:
(sorry for it bei...
limber skiff
I'm really thinking my two prs are in a very final stage
can't see much changing now
limber skiff
are you up to date?
sterile oak
oh. nvm, I didn't update...
desert cosmos
imagine the images disappearing and the whole plugin exploding 
dusk blaze
imagine the images disappearing and the whole plugin exploding <:nyaboom:1105406...
afaik catbox images are permanent
austere talon
what if you get removed and added again
"Relationship is rocky"
austere talon
afaik catbox images are permanent
don't use external file hosts in plugins
shell shuttle
"Relationship is rocky"
somber thorn
somber thorn
also did vee again forget about #plugin-news
turbid hatch
^ you'd have to include a separate math interpreter for this to be secure and at that point it would just bloat the mod considering how niche it is
turbid hatch
id rather not have a hidden eval command
- you can sandbox break out of that in many different ways and get access to the client
turbid hatch
๐ค
charred monolithBOT
you don't need a client mod for slash commands. you can use user installabe apps, they work anywhere on discord (including mobile)
austere talon
i will start just rejecting any slash command thing that can also be done with a user app
charred monolithBOT
dusk blaze
don't use external file hosts in plugins
@still wasp (I didn't make plugin)
you will either use svg or data url
spark pivot
austere talon
austere talon
but this has one issue @limber skiff
it won't work the first time cause it's not loaded, need to load first
rugged spire
don't use external file hosts in plugins
don't use external file hosts in plugins
I am sure I can find too many instances of that. I'm sure I've raised the issue we should migrate the existing cases of this to being built in and you said it isnt an issue
austere talon
maybe we could force load all commons when you open devtools?
also let me know if the code looks good if you would do anything differently
rugged spire
i will start just rejecting any slash command thing that can also be done with a...
reasonable
i should add more consoleshortcuts
austere talon
i want to add ones for current channelId, guildId, userId, etc
tired of having to manually copy channel or guild id
rugged spire
YES
wait
You will add Vencord.Util as Util too
i hate writing out Vencord.Util.getCurrentChannel().id
yeah i know Selected{Guild,Channel}Store exists
austere talon
but this has one issue <@235834946571337729>
it won't work the first time caus...
this is what i mean btw
you need to execute it once to load it
rugged spire
husk
austere talon
because chrome devtools wont call it
limber skiff
but this has one issue <@235834946571337729>
it won't work the first time caus...
you could instead just the set the value instead of getter if when you call the getter the value is defined
austere talon
but yeah the issue is that chrome only eager evaluates stuff that has no sideeffects
limber skiff
it's okay tbh
I mainly did this change to get reference to wreq as soon as possible
tired of having to wait for connection open lmao
limber skiff
you don't
rugged spire
austere talon
your change isnt the issue
limber skiff
it's that just than when connection open is triggered you can be sure pretty much everything loaded
austere talon
i also do this here
limber skiff
your change isnt the issue
ik ik
austere talon
but basically nothing will be loaded at that point
limber skiff
yeah
austere talon
these arent loaded
limber skiff
wreq and some vencord stuff, mainly
austere talon
what we could do is eager load all modules when console is opened
rugged spire
i know this sounds stupid but is there any way of actually detecting that on web clients
rugged spire
technically yes
austere talon
but its not robust
austere talon
there are many ways to do it
this works but only if you have them docked
not if u have popout
well web users will shrimply cope
the horror
limber skiff
horror
austere talon
cursed xd
limber skiff
it's really cool how that code gets stripped out if it's web
austere talon
yeaa
austere talon
the diff is so horror cause i moved the shortcuts function to top level
hmmm
this has some issues still
limber skiff
yeah ik how that is
austere talon
if you open devtools very early
limber skiff
(me)
charred monolithBOT
austere talon
easy fix
limber skiff
lmaooo
limber skiff
wtf
charred monolithBOT
limber skiff
do writable true when you define a value too
might wanna change for whatever reason
austere talon
there we go
limber skiff
what's the reason for setTimeout 1000
austere talon
austere talon
what's the reason for setTimeout 1000
basically just to let plugins start and stuff
cause they might load some more modules
austere talon
like
the point of that func is to unproxy already cached modules
if we do it immediately at webpack start it wont be any
but after 1s some might have gotten accessed
limber skiff
yeah
and it does make sense for it to be connection open
because plugins may want to do gateway things in the start
if you want me to change let me know
it's better for me to do in my pr which already changes so much stuff
austere talon
naaah
the more changes u tuck into one pr the harder it gets to properly test & review xd
limber skiff
this wont work
charred monolithBOT
limber skiff
the more changes u tuck into one pr the harder it gets to properly test & review...
yeah but that's almost no changes honestly
just a few renaming
austere talon
this wont work
what now
limber skiff
and it's better because that pr already touched most files, so why not change a little more of them haha
limber skiff
you can have writable and get
cant*
austere talon
you can
limber skiff
I know for sure one of them you can't have at the same time as a writable
charred monolithBOT
austere talon
austere talon
I know for sure one of them you can't have at the same time as a writable
yeah its both
limber skiff
lmao the message
austere talon
limber skiff
yeah I saw that
it's so funny
okay give me a second I'm gonna make coffee and then I review/merge your pr
and fix my conflicts
charred monolithBOT
austere talon
limber skiff
did you know about Reflect.defineProperty
it's a little more sane
and doesn't throw an error
austere talon
anything else that could be useful?
limber skiff
put Vencord.Util on Util
austere talon
yop
limber skiff
I guess that's it
austere talon
bleh
limber skiff
also unrelated but should I export this
it's a set with wreq.m and sentryWreq.m
or I could change that to contain all the wreqs instead
i guess that can be useful
charred monolithBOT
austere talon
i do this so often xd
so i save 1 restart when testing plugins
what else could we add thats useful
limber skiff
that's smart
austere talon
๐ญ
odd heath
we need something for pronoundb where it hides this shit automatically
i dont feel like its worth making a pr for it tho
charred monolithBOT
limber skiff
let me just clean this up and I review
austere talon
BRO WHAT IS THIS EXAMPLE CODE
class B extends class A {
set a(v) {
console.log("Setter called");
}
} {
a = 1; // Nothing logged
}
๐ญ
i was so confused and thinking it was invalid syntax
until i ran it and realised...
austere talon
class B extends
(class A {
set a(v) {
console.log("Setter called");
}
})
{
a = 1; // Nothing logged
}
this should make it a bit more obvious
limber skiff
```js
class B extends
(class A {
set a(v) {
console.log("Setter call...
๐
wait that if is wrong
limber skiff
oh fuck
austere talon
btw im surprised we never had this
https://github.com/Vendicated/Vencord/pull/2519/files#diff-9de81098f70afeebbe6eba8df217008ac039d73e6979e5fdf8aa145720facd7dR109-R110
austere talon
๐ญ
austere talon
๐ญ it looks so scary too
limber skiff
yeah lmao
github is dying I can't dismiss it lmao
btw I finally used tagged templates again lmao
basically if any of the variables inside is == null it returns "" instead
any reason this is not camelCase
limber skiff
okay seems good
austere talon
btw i noticed that fakeRender doesnt work on discord desktop
but its not that easy to fix
limber skiff
what's the issue on desktop
austere talon
thats mainly what i use it for
austere talon
you can call hooks with it and stuff
like
fakeRender(() => console.log(useThing()))
I see
limber skiff
oh thats cool
limber skiff
okay lets hope for the best
austere talon
what's the issue on desktop
its the issue with how the code opens the popup
currently it does
window.open("about:blank", "Fake Render", ...);
but it has to be
window.open("/popout", "DISCORD_...")
oh
austere talon
with that change and a small adjustment to how we initialise the html it works in discord desktop
but then it doesnt work in vesktop anymore
so we first need to fix popouts in vesktop
limber skiff
charred monolithBOT
if you want to close a pr just click here:
this likely won't be merged since it can be done using a CSS snippet, which doesn't require any plugin. general "policy" with vencord plugins are that they shouldn't be made if you can do it with CSS
austere talon
> don't use external file hosts in plugins
I am sure I can find too many instanc...
such as?
austere talon
it's because these properties are dictated by spec so proxy enforces them to properly correspond to the proxied element, so you can't break js spec
limber skiff
okay I hope nothing else got messed up
rugged spire
hate github UI
limber skiff
wtf?
rugged spire
idk whats going on but looks like git hell
austere talon
don't be rude
rugged spire
don't be rude
it was for the start/stop being console.log also yes that was a bit rude of me
i have it
i should start writing another plugin that nobody will use
limber skiff
btw i came up with a way we can maybe update messages <@235834946571337729>
I don't quite get it
did you see what I said about the research I did another time
austere talon
that they're memoed?
austere talon
I don't quite get it
why not
austere talon
MESSAGE_UPDATE event
charred monolithBOT
limber skiff
I'll take a deeper look into it
austere talon
basically the entire reason we cant use MESSAGE_UPDATE is cause it fucks up embed
but now after looking into it, it's just sanitizeEmbed as described in those messages that does that
so if we noop that for the MESSAGE_UPDATE call, it should work fine
limber skiff
ideally we want something which doesn't depend on patching a single parsing
that's why I'm gonna take a deeper look
to see if that's doable
deep clone message obj, set prototype to the class, and then update message store with it?
just an idea idk
charred monolithBOT
shell shuttle
spark pivot
me when new plugins and no #plugin-news
charred monolithBOT
austere talon
Error: Execution context was destroyed, most likely because of a navigation.
at rewriteError
reprter explosion
somehow
its consistent broken somehow
but why
limber skiff
it broke rn?
austere talon
yes
but its not cause vncord broke
puppeteer error
its redirecting and that somehow breaks stuff
maybe issue with new chrome version
limber skiff
uhh I have news
frail skyBOT
limber skiff
my branch works
austere talon
what..
limber skiff
๐ญ
austere talon
how
limber skiff
idk
frail skyBOT
limber skiff
I ran on immediate-finds-modules-proxy
austere talon
did u make any major changes
limber skiff
it may be related to this https://github.com/Vendicated/Vencord/commit/f469060ccfbf4c585802d7ebf20e0edcc7cea963
but my branch has that too
austere talon
but the error is so confusing
austere talon
nah
limber skiff
odd
charred monolithBOT
limber skiff
idk why my other branches work though
austere talon
well its not a big deal for now
but we need to fix it sooon
why wuld it randomly break
it worked earlier
austere talon
no the thing is
it wasnt updated in a week
it worked a few days ago
so literally we didnt change any code and it broke
well we did change some webpack code
maybe its consoleshortcuts change?
maybe ur branch doesnt have it yet
limber skiff
it does
limber skiff
it has everything but the last 2 commits
austere talon
maybe its the eager loading somehow
limber skiff
unsure
I can try the reporter on dev later
i'm trying so hard to make the fucking message re-render
austere talon
yeah but
your branch has immediate finds
my guess is that it's about the eager loading
limber skiff
lol that branch has two things, a option for eager patching and immediate finds
it's a combination of my two others with conflicts resolved
is your reporter exploding during finds checking?
anyways it's crazy, I got the main channel component that subscribes to the message store to update
but the single message is still not
limber skiff
hmm so it is a find
austere talon
i dont understand whats wrong here
limber skiff
nothing technically
austere talon
we should just make the updater force restart once update applied
instead of levaing you the choice
verbal pumice
why
verbal pumice
it should be clear that discord will restart after you update
charred monolithBOT
limber skiff
@austere talon how is window even being there if we mark it as not enumerable
austere talon
if its a property
we only check module.exports = window
but if its like module.exports.window = window
actually
no we dont check exports anymore
then its defualt export maybe
limber skiff
we should not put these fixes in the finds
austere talon
austere talon
these are gone cause not enumerable
austere talon
it should be in the factory wrapper
yeah true
limber skiff
I will fix it dont worry
charred monolithBOT
woeful sable
rip
austere talon
i mean i know the issue, i know the exact line of code that causes the issue xd
but idk why it does
limber skiff
who would guess message update api is so fucking easy
right this should support updating with no changes
austere talon
pretty sure you can just MessageStore.markChanged()
limber skiff
you cant
you need to commit the new cache and update the message reference too
the first makes the useStateFromStores trigger
austere talon
store.emitChange()
limber skiff
right
this doesnt need to be an api
it can be an util
isnt it lovely
it doesnt update the message while the app is starting
why.
accessories are not getting re-rendered ๐ฅ
charred monolithBOT
A simple plugin that allows you to send cute messages and 'rizz' lines in the chat. It's easy to use and can be fun and entertaining in many situations
https://github.com/Vendicated/Vencord/assets/69634294/5e710b12-ae0e-409a-a749-7a6fe1b7a158
verbal pumice
manti alt
limber skiff
force push time
limber skiff
puppeteer is weird
frail skyBOT
limber skiff
works :)
frail skyBOT
limber skiff
oops should have not add that one
limber skiff
frail skyBOT
charred monolithBOT
charred monolithBOT
shell shuttle
timid reef
welp i guess i dont have to talk via github commits anymore
austere talon
aye good job @limber skiff
this never worked before
like the icon didnt update
speaking of which that plugin is written like shit
what was i cooking
dynamically builds css to hide ๐ญ
desert cosmos
limber skiff
aye good job <@235834946571337729>
thanks haha
that took so much reverse engineer to get working
and it's so simple lmaoo
desert cosmos
seems like the "animate" option is broken, returns a gif regardless of setting, unless im tripping
nimble plaza
OHH i forgot to reimpliment that
thanks!!!
wait
it should work
oh wait im dumb
i was returning https://cdn.discordapp.com/banners/id/anotherid, not https://cdn.discordapp.com/banners/id/anotherid.gif
@austere talon would this ternerary be too cursed
const extension = settings.store.animate ? profile.banner.startsWith("a_") ? ".gif" : ".png" : ".png";
return `https://cdn.discordapp.com/banners/${userId}/${profile.banner}${extension}`;```bestie
const extension = settings.store.animate && profile.banner.startsWith("a_")
? ".gif"
: ".png";
ohhhhhh
ty
@cunning canyon does the usrbg api have a way to specify png or gif? or is there any way to tell if a user's banner is animated?
austere talon
u can fetch the first few bytes for GIF magic
surely gifs have magic right
is usrbg limited to gifs or can it also be apng/webp/avif...
nimble plaza
oh it gives content-type
oki
how would i handle async in a react component
state?
austere talon
or yeah content type
charred monolithBOT
Displays hex/rgb/hsl colors in messages with a tiny-colored box nearby :3
I might have made some bad code especially with dynamic element creation, so I would be glad to get roasted
nimble plaza
moving to #๐งฉ-plugin-development
nimble plaza
pindms's module loader for the modal to edit a group is failing on stable btw
austere talon
real or fake
nimble plaza
nimble plaza
does reporter test for extractandloadchunks tho
nimble plaza
yeah i realised
limber skiff
because it is matching something
austere talon
let N = (0,
_.makeLazy)({
createPromise: ()=>Promise.all([n.e("49237"), n.e("99387"), n.e("96427"), n.e("40326"), n.e("23357"), n.e("28020"), n.e("15972"), n.e("6416"), n.e("38674"), n.e("43906"), n.e("33053"), n.e("49146"), n.e("17938"), n.e("76540"), n.e("65866"), n.e("93521"), n.e("80603"), n.e("18824"), n.e("5528"), n.e("73427"), n.e("79618")]).then(n.bind(n, "989804")),
webpackId: "989804",
name: "UserSettings",
_: Promise.all([n.e("49237"), n.e("99387"), n.e("96427"), n.e("40326"), n.e("23357"), n.e("28020"), n.e("15972"), n.e("6416"), n.e("38674"), n.e("43906"), n.e("33053"), n.e("49146"), n.e("17938"), n.e("76540"), n.e("65866"), n.e("93521"), n.e("80603"), n.e("18824"), n.e("5528"), n.e("73427"), n.e("79618")]).then(n.bind(n, "989804"))
})
but it's not capturing what it should be
hybrid blaze
```js
let N = (0,
_.makeLazy)({
createPromise: ()=>Promise.all([n.e(...
๐ตโ๐ซ
limber skiff
entryPointId seems to be NaN
austere talon
is entry point not n.bind(n, "989804")
austere talon
ye
limber skiff
what is it matching?
austere talon
idk
limber skiff
fuck I know
I added another case
there are 3 groups now
chunks when its promise all
limber skiff
chunks when its single promise
and entry point id
the regex for better settings only has 2 groups
so the entryPoint is getting treated as the second group instead of the 3rd
austere talon
so the entryPoint is getting treated as the second group instead of the 3rd
yea
limber skiff
extractAndLoad needs to account for when it's only 2 groups
austere talon
just check group count
austere talon
yeah
limber skiff
yeah that should work probably
are you gonna fix it or you want me to fix later
actually leave it for me
austere talon
wha xd
austere talon
oh yeah
limber skiff
today I realized why
austere talon
for funny properties
limber skiff
yeah
austere talon
๐ฆฆ
limber skiff
I had changed more user tags and said it was not possible to access those
because I was assigning to the wrong thing
instead of the wrapper i was doing the inner component
so of course it didnt work
limber skiff
instead of the wrapper i was doing the inner component
(even though 1 line above I had InnerComponent = find)
/(?:(?:Promise\.all\(\[)?(\i\.e\("[^)]+?"\)[^\]]*?)(?:\]\))?|Promise\.resolve\(\))\.then\(\i\.bind\(\i,"([^)]+?)"\)\)/
most sane vencord regex
limber skiff
in operator is kinda bad
mimimi cannot use in operator in boolean
๐คจ
is this true, it just had happened
probably just me messing up
sterile oak
what's this bad patch that the webhook keeps yapping about?
austere talon
old settings patch
not needed anymore
we removed it but then discord decided to revert to a 10 days old build which required it again
and now we're just leaving it in for now for safety
crude raptor
heh