not really? with activities you can advertise in all servers the user is in
joining them to random guilds doesn't do much, it's just an annoyance
#👾-core-development
austere talon
median rapids
eh ig
thats with guilds.join as advertised tho
there's like 3 ways you can ban ppl with it
rugged spire
wtf?
limber skiff
@median rapids :)
rugged spire
<@852892297661906993> :)
How will this affect things that aren't loaded until later
limber skiff
vee you broke context menus on devtools again
somber thorn
vee you broke context menus on devtools again
limber skiff
yeah I know
limber skiff
thanks merge command for being stupid
verbal pumice
triple horror
median rapids
<@852892297661906993> :)
so real
turbid hatch
<@852892297661906993> :)
the sentence doesnt make sense
"it affects startup"
"difference is minimal"
please dont put both, because it confuses people
i'd remove the "difference" part of that entirely
austere talon
just remove the setting
it's not useful to have and worst case scenario will cause confusing issues or inconsistencies
charred monolithBOT
limber skiff
it's fixed
not on stable
charred monolithBOT
austere talon
how horror is this
odd heath
not at all
charred monolithBOT
austere talon
how horror is this
nah this is kinda awful
cause its really easy to accidently change languages
but idk how to make it better
austere talon
i think like this is better
makes it so its way harder to accidently open
um... chrome
why is there en twice
charred monolithBOT
austere talon
TRUE
dusk blaze
@placid wave insane
charred monolithBOT
dusk blaze
but true
@austere talon will lock
else aagamerkafasi will fight
then close pr, block mantika from repo, and go to turkey to destroy his pc
glass jasper
then close pr, block mantika from repo, and go to turkey to destroy his pc
then nuke turkey
lime stone
:trollface:
median rapids
then nuke turkey
net benefit to society 
glass jasper
net benefit to society <:blobcatcozy:1026533070955872337>
ong
limber skiff
just remove the setting
okay I will keep it internally but remove the switch
reporter benefits from it
charred monolithBOT
frail skyBOT
frail skyBOT
austere talon
why did they fucking revert
limber skiff
was it only that or more
lets see
@austere talon bro
they reverted to a build 10 days ago
median rapids
lmao
limber skiff
saving for later
this is so weird
the first is the acc for all the patch times
the second is this
where are 5600 milliseconds coming from
what's taking so long
oh, the find checks probably
lets see
ngl I think it's the one regex find we have that's causing all this time
okay so 2700 are from find checks
now how much from is that is the regex find
14ms only, nvm
limber skiff
the second is this
this is taking in consideration the regex testing for chunks
which only happens in the reporter
aha
this seems more right
limber skiff
look behind is good, but also need to be careful
all of the slow patches are because of the look behind
the slowest one
limber skiff
@austere talon 
austere talon
oh god did they repush it
limber skiff
yes
limber skiff
@austere talon should I just make this one noWarn
limber skiff
it will already show with the new one failing
austere talon
thanks
kinda weird that just removing look behind makes it better sometimes lol
maybe we should add a new category to reporter that shows slow patches
limber skiff
i know the reason the look behind makes it slow lol
take this one by example
match: /(?<={channel:(\i),name:\i,.+?unread:(\i).+?;)/,
replace: (_, channel, unread) => `${unread}=$self.isHiddenChannel(${channel})?false:${unread};`
the everytime the look behind advances one step with of .+?, it's re-checking the whole lookbehind again
by removing the look behind it no longer goes back to the start of it every step of .+?
limber skiff
wdymm bro where is my merge commit
limber skiff
I dont know what discord did but their app is starting slower now (or it's a me thing for some reason)
It used to find the main WebpackRequire.onChunksLoaded before DOMContentLoaded
and it's not an issue with my branch because this is using dev
austere talon
thanks
kinda weird that just removing look behind makes it better sometimes lol...
what do you think
limber skiff
it's definitely possible
now the question is which branch do I do it lmaooo
both of the ones I'm working modify the reporter a bit
limber skiff
now this works properly
austere talon
before?
limber skiff
austere talon
i have banger idea
add venbot command to eval command in a discord + vencord context
with puppeteer
so you can test webpack finds and shit from discord chat
austere talon
from mobile i mean
austere talon
try something else
limber skiff
austere talon
that might be expected if it's a bound function or smth like that
limber skiff
wait but why is native code and not object Function
austere talon
btw i have an idea
vencord companion browser extension
that adds test patch / webpack find to github pr code view
limber skiff
wtff
that's crazy
ohhh fuck
I know why it's native code
receiver is the proxy and it has priority over innerTarget
I dont need to monkey patch I just need to remove receiver from there
maybe not
hmm this works
frail skyBOT
limber skiff
(wrong implementation but yeah)
austere talon
what if it's not a function
frail skyBOT
austere talon
btw pronoundb plugin is frequently hitting 429s
austere talon
btw pronoundb plugin is frequently hitting 429s
@odd heath maybe you might be interested in looking into that (since you did the migration as well)
median rapids
add venbot command to eval command in a discord + vencord context
counterpoint to idea: findByProps("HTTP").HTTP.post
austere talon
wdym
austere talon
fixed
limber skiff
I think I did an oopsies
austere talon
bound bound bound bound bound v
limber skiff
okay yeah this is not practical
can't bind everything
monkey patching to string more safe
shell shuttle
I think I did an oopsies
bound bound bound bound bound v
austere talon
why do we even need working toString?
is this an actual need or is it just a why not
austere talon
seems xyproblemo
limber skiff
it doesnt work sadly
austere talon
are u sure
limber skiff
yeah it depends on the source code
not the name property
as you can see f() is still anonymous
austere talon
you could try something cursed like
const obj = {
ProxyDummy() {}
}
then access it from that object
but lmao
austere talon
this is kinda cursed lmao
limber skiff
have you seen yet how it works?
austere talon
it'll just garbage collect that object once it's no longer referenced
limber skiff
okay good
austere talon
so no need for delete
austere talon
that's cool tho we can do that in more places i think
we could even have like custom lazy name
limber skiff
this
austere talon
LMAOO
limber skiff
sadly it does not work for proxies
austere talon
sadly it does not work for proxies
try to declare name property
limber skiff
nah name doesnt work either cuz it depends on source code
and proxies are not functons either
guhh really, it proxies defineProperty too
limber skiff
it already has a name
because of the name on the object
dang this doesn't work either
austere talon
dang this doesn't work either
HORROR
limber skiff
wait of course it doesn't work
proxies dont have prototypes
okay yeah impossible
I even tried
median rapids
nookies webpack wizard
austere talon
bro forgor
median rapids
wtf,,,
austere talon
tbh i didn't understand what the third property in reflect calls is for
like how tf do u have a custom receiver for a get
limber skiff
like how tf do u have a custom receiver for a get
wanna know a funnie
austere talon
maybe
limber skiff
when I do this
and I try wreq.m["45835734543"] = "hi"
target is proxiedModules
receiver is originalModules
median rapids
i wonder if js will ever not terrify me
limber skiff
that's the main reason I have to manually define the proxy set, because if I let it call Reflect.set(...args), it will set the prop in the receiver
instead of the target
and the receiver is not what I want lol
limber skiff
what happened here
why is your icon so far away
discord just made your name super large for some reason
austere talon
discord css bug lmao
the clan tag is supposed to show there
but the parent has overflow hidden
and it makes it hide and have the weird gap
limber skiff
I see lmao
limber skiff
I think I can make this less hacky
maybe..........
hmmm
okay hmmm
let me try to cook this
odd heath
<@708275751816003615> maybe you might be interested in looking into that (since ...
Eh? I never touched how often it does the requests and I never saw it 429 when I tested that's kinda weird
I could look into it maybe I fucked something with a change accidentally
limber skiff
let me try to cook this
this was easy
limber skiff
github is about to say I have a security vulnerability
spark pivot
i think you have a security vulnerability
limber skiff
okay
limber skiff
oh look an explosion
limber skiff
I'm starting to think we don't need to patch onChunksLoaded
charred monolithBOT
limber skiff
I waited and it wasn't enough 😞
shell shuttle
@codiumAI
shell shuttle
what's the command i forgot it
shell shuttle
i can't do allat
jagged cloak
u shall
shell shuttle
u shall
no like literally
as far as i know
specific error logging is impossible with this method
charred monolithBOT
fiery jungle
@crude hearth
limber skiff
timedones review??
still wasp
charred monolithBOT
rugged spire
yt tutorial
dusk blaze
> yt tutorial
<:husk:1026532993923293184>
Hello today we will watch Youtube tutorial on how to make a pipe bomb!
(will likely explode on you due to being outdated(
rugged spire
fucking insane notification
charred monolithBOT
spark pivot
oh no
charred monolithBOT
limber skiff
oh this fucking formatter
limber skiff
^^^ Reflect.defineProperty doesn't throw which is good for us
limber skiff
nice I didn't break anything
median rapids
limber skiff
will this work? idk
rugged spire
BORN TO SAY "YOUR CODE IS SHIT" FORCED TO STAY SILENT
@dusk blaze Today we will be watching YouTube tootorals on submitting a PR to Vencord!
limber skiff
not the typoo
desert cosmos
this pr made my day
jagged cloak
timedones
limber skiff
epico
grave mangoBOT
https://github.com/Sqaaakoi/Vencord/blob/sqaaakoi-stable/src/plugins/reactComman...
index.ts: Line 31
return (messageStore.getMessages(channel.id) as { last: () => Message; }).last();
BORN TO COMMIT BROKEN CODE
rugged spire
who wants to watch me PR some junk'
charred monolithBOT
somber thorn
oh no
rugged spire
i didnt even notice
somber thorn
wasn't there one of those already btw
rugged spire
yes
somber thorn
tryna find it rn
somber thorn
yeep
charred monolithBOT
somber thorn
also yes let's follow naming conventions
austere talon
also yes let's follow naming conventions
i mean it doesnt matter
limber skiff
I mean yeah it doesn't matter but it was the only plugin like that
limber skiff
so I changed
rugged spire
is proper displayname for settings
limber skiff
nop
limber skiff
any way worke
rugged spire
is proper displayname for settings
this is why we need
rugged spire
rugged spire
guhhhh dont wanna reply to this because i dont wanna feel mean
charred monolithBOT
rugged spire
how do we teach this user git
oh also i wanted to share something random I've been working on
high hound
how do we teach this user git
austere talon
why does it matter
rugged spire
it will be easier in the long run to install git locally
rugged spire
why does it matter
true
high hound
it will be easier in the long run to install git locally
its just faster for me to do it that way
rugged spire
it doesn't but it is significantly easier
rugged spire
if you're using VSCode it has git integration built-in
high hound
upload file then done
also i have files that i dont want comitted
rugged spire
oh also i wanted to share something random I've been working on
unfinished FriendInvites UI
rugged spire
also i have files that i dont want comitted
don't stage them
or use .gitignore (or even .git/info/exclude to not sync those excluded files)
high hound
alright ill look into it for future projects
rugged spire
alright ill look into it for future projects
have fun
dont be afraid to come ask in #🧩-plugin-development
and also as I've discovered with projects related to modding
look at how other people implemented generic ideas
rugged spire
yes i know you closed it
high hound
the only thing im really having issues on is patches
rugged spire
okay
high hound
i cant seem to understand it
charred monolithBOT
rugged spire
Patches are defined as regex
There is one exception to the regular syntax of regex; you can use \i to refer to variable names
The find string is any unique string within the webpack module
high hound
so for example if i wanted to find an attatchment i could set the find to ".attatchmentInner"?
rugged spire
you can easily see that as each module is a function in an object with the key for the function being some random number
crude hearth
@austere talon your code less performant 👎🏿
austere talon
<@343383572805058560> your code less performant 👎🏿
what if it has more than 50 elements
like 60
you will pop and it will become 59
crude hearth
what if it has more than 50 elements
it wontt
rugged spire
so for example if i wanted to find an attatchment i could set the find to ".atta...
yeah something like that
high hound
yeah something like that
so thats finding an element, what would i do for match? like what would i put there if im trying to get the element
rugged spire
so thats finding an element, what would i do for match? like what would i put th...
you need to select the minified source with regex and manipulate it in some way where your element (defined like (0,\i,jsx)(ReactNode,{})) is wrapped within a call to some wrapper function
or just modify what you need directly
crude hearth
done @austere talon
rugged spire
also if you have built Vencord with pnpm watch it will add dev companion plugin
charred monolithBOT
I didnt need to post this but g
high hound
also if you have built Vencord with `pnpm watch` it will add dev companion plugi...
how do i use it
rugged spire
1: patch helper tab in settings
2: Vencord companion VSCode extension
austere talon
you only fixed in one location lmao
crude hearth
Vendicated pushed one commit
austere talon
horror a slider would be way better
austere talon
insane users will put to negative number or smth
crude hearth
WHY CHANGE THE PHOTOO
rugged spire
horror a slider would be way better
speaking of sliders
when are we getting slider settings component with full integer numbers
wen
crude hearth
horror a slider would be way better
I think i tried slider but then for some reason I just put number box
tro
rugged spire
inb4 "So niche do it yourself"
austere talon
when are we getting slider settings component with full integer numbers
?wdym
crude hearth
I think it would be nice if we let people to retain it for longer time
austere talon
seems like a bad idea lmaoo
crude hearth
why :(
rugged spire
this but without having to explicitly set each visible slider tick
austere talon
they will have 2 billion summaries and wonder why it lags
austere talon
this but without having to explicitly set each visible slider tick
?
crude hearth
they will have 2 billion summaries and wonder why it lags
you can only have max 50 in a channel
rugged spire
<:aliening:1127035801423839312>
@austere talon insane
austere talon
you can only have max 50 in a channel
oh true
austere talon
<:aliening:1127035801423839312>
you can have that
rugged spire
is that pissbot enterprises
rugged spire
idk i am not in there
crude hearth
good
rugged spire
guh i have shit memory or something
austere talon
yes
rugged spire
wait
this will explode if it is non-integer and round to nearest day or something idk
austere talon
rugged spire
i love waiting 3.06324673287 days
austere talon
yop
rugged spire
vee u do know those sliders are only fixed to 2dp in the tooltip
rugged spire
🔥
crude hearth
les goo
austere talon
vee u do know those sliders are only fixed to 2dp in the tooltip
?
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/components/PluginSettings/co...
SettingSliderComponent.tsx: Lines 54-64
<Slider
disabled={option.disabled?.call(definedSettings) ?? false}
markers={option.markers}
minValue={option.markers[0]}
maxValue={option.markers[option.markers.length - 1]}
initialValue={def}
onValueChange={handleChange}
onValueRender={(v: number) => String(v.toFixed(2))}
stickToMarkers={option.stickToMarkers ?? true}
{...option.componentProps}
/>
what if I want to keep 0decimal places
rugged spire
need to stick to markers
this is what i was trying to say 5 minutes ago
want so bad
should I make it myself
austere talon
just dont use a slider
rugged spire
looks 
median rapids
the description kinda implies that the summaries aren't created without the plugin
even though they always are
median rapids
why lol
austere talon
whyn ot
users see the commit history so its a bit much if theres 3 billion commits
"fix minor bugs in various plugins" is a lot easier to understand than 5 commits
austere talon
and if anyone wants more info there's an extended description
median rapids
i never see updater so i forgot
austere talon
otherwise you get "There are 30 new updates" jumpscare
and they're all properly credited dw 
austere talon
should i just finish and merge https://github.com/Vendicated/Vencord/pull/2021
if it even still works
somber thorn
me when
austere talon
why did i do this instead of just using file urls
stark flint
if it even still works
fwiw i tried a bit ago and didn't seem to work but pls yes
granite sky
anyway...
austere talon
but the original pr is not mergeable
granite sky
yours also seems to be a duplicate i think
My hides all messages from specific users/bots instead of only 1 :3
rugged spire
why did i do this instead of just using file urls
i thought the files arent even stored
austere talon
this is kinda fire cause now u can
import monacoHtml from "file://monacoWin.html?minify&base64";
will minify the html and base64 it for u
somber thorn
otherwise you get "There are 30 new updates" jumpscare
me when #🏥-vencord-support-🏥 message
austere talon
that error message is misleading but it happens because he didnt restart fully
austere talon
this is kinda fire cause now u can
```js
import monacoHtml from "file://monacoWi...
i mainly made this for the adguard pr but also useful for vencord html files
granite sky
i mainly made this for the adguard pr but also useful for vencord html files
vencord adguard?
median rapids
venguard
charred monolithBOT
median rapids
lol they always did
granite sky
Ah
limber skiff
it's possible to see the ublock origin rules for the ad bypassing and fix
but idk if that's easy
charred monolithBOT
median rapids
maybe there was a second iframe in the first one
austere talon
oooh wait yeah
austere talon
https://i.dolfi.es/yrH9931vSf.png?key=NlLFOI6buyZqSJ
yeah
good call
i got confused because
it didnt catch any frame so i checked and it was discordsays
but the oriignal code targeted https://youtube.com
median rapids
ahh
austere talon
when its https://www.youtube.com
median rapids
funny
austere talon
thgats why it didnt catch
import adguard from "file://adguard.js?minify";
app.on("browser-window-created", (_, win) => {
win.webContents.on("frame-created", (_, { frame }) => {
frame.once("dom-ready", () => {
if (frame.url.includes("discordsays") && frame.url.includes("youtube.com")) {
if (!RendererSettings.store.plugins?.WatchTogetherAdblock?.enabled) return;
frame.executeJavaScript(adguard);
}
});
});
});
this works now
stark flint
!!!
desert cosmos
cant tell if its just me, but i'm still seeing ads on videos, someone else might need to confirm that though
limber skiff
@austere talon do you know anything about this?
it's the only thing I have like almost no idea how it works to be able to document
limber skiff
because I want this to be a general thing we can look at to see what a property does
rugged spire
why document random properties
discord-types logic
limber skiff
that's why I took the effort of documenting every prob on the wreq of discord
limber skiff
no need to check for webpack source code and not even understand what's happening
limber skiff
yeah
limber skiff
the current description of .a I got from there
but it's still bad
webpack is just so poorly documented even in the source code internals
austere talon
tbf why would u document internals xd
they're not supposed to be used by consumers
charred monolithBOT
rugged spire
tbf why would u document internals xd
something something react do not use or you will be fired
limber skiff
I mean like, when someone is developing webpack themselves
the source code is poorly documented idk how one can work in that
austere talon
the webpack codebase is so weirdly written
limber skiff
I know, that's so true
I think this may be one of the reasons webpack never changes
charred monolithBOT
austere talon
the webpack codebase is so weirdly written
it's almost as bad as corejs
limber skiff
it's so horribly documented that no one wants to touch the internals
austere talon
i tried reading corejs to better understand how some functions work under the hood but it's unironically easier to read ecmascript spec than to try to understand corejs code
limber skiff
if you look in a commit of 2016 or something, almost all the current internals already existed
and to be honest, I got a good documentation of everything in the webpack of discord
it's just this one function
which is also not called ever
grave mangoBOT
https://github.com/zloirock/core-js/blob/master/packages/core-js/modules/es.arra...
es.array.every.js: Lines 1-14
'use strict';
var $ = require('../internals/export');
var $every = require('../internals/array-iteration').every;
var arrayMethodIsStrict = require('../internals/array-method-is-strict');
var STRICT_METHOD = arrayMethodIsStrict('every');
// `Array.prototype.every` method
// https://tc39.es/ecma262/#sec-array.prototype.every
$({ target: 'Array', proto: true, forced: !STRICT_METHOD }, {
every: function every(callbackfn /* , thisArg */) {
return $every(this, callbackfn, arguments.length > 1 ? arguments[1] : undefined);
}
});
what the fuck
limber skiff
the fuck is happening
rugged spire
dont dig into core-js lore too much
limber skiff
and I also tried a lot to understand the return of onChunksLoaded
limber skiff
like bro wtf is this
rugged spire
CAN YOU STOP POSTING THINGS THAT MAKE ME NEED TO USE MY BRAIN
limber skiff
dont use your brain then
rugged spire
dont use your brain then
thanks i will simply let the code you post roll over the no wrinkles in my brain
rugged spire
dont even try to understand that stuff
yes
limber skiff
I spent more than 5 hours documenting webpack
limber skiff
okay wait I think im understanding
it's related to exports like this
pretty sure
const factory = (module, exports, wreq) => {
wreq.a(module, async (__webpack_handle_async_dependencies__, __webpack_async_result__) => {
try {
wreq.r(exports);
wreq.d(exports, {
memory: () => memory
});
async function getMemoryFromParentInWorker() {
await new Promise(r => setTimeout(r, 200));
return new WebAssembly.Memory({ initial: 1 });
}
const memory = await getMemoryFromParentInWorker();
__webpack_async_result__();
} catch(e) {
__webpack_async_result__(e);
}
}, 1);
};
okay so __webpack_async_result__ marks as done it looks like
// memory.js
const factory = (module, exports, wreq) => {
wreq.a(module, async (__webpack_handle_async_dependencies__, __webpack_async_result__) => {
try {
wreq.r(exports);
wreq.d(exports, {
memory: () => memory
});
async function getMemoryFromParentInWorker() {
await new Promise(r => setTimeout(r, 200));
return new WebAssembly.Memory({ initial: 1 });
}
const memory = await getMemoryFromParentInWorker();
__webpack_async_result__();
} catch(e) {
__webpack_async_result__(e);
}
}, true);
};
// other file that requires memory.js
const factory2 = (module, exports, wreq) => {
wreq.a(module, async (__webpack_handle_async_dependencies__, __webpack_async_result__) => {
try {
var WEBPACK_IMPORTED_MODULE_0 = __webpack_require__(/* ./memory.js */ 3);
var __webpack_async_dependencies__ = __webpack_handle_async_dependencies__([WEBPACK_IMPORTED_MODULE_0]);
var [WEBPACK_IMPORTED_MODULE_0] = __webpack_async_dependencies__.then
? (await __webpack_async_dependencies__)()
: __webpack_async_dependencies__;
await __webpack_require__.v(exports, module.id, "daa529a2a650ee3943a9", {
"./memory.js": {
"memory": WEBPACK_IMPORTED_MODULE_0.memory
}
});
__webpack_async_result__();
} catch(e) {
__webpack_async_result__(e);
}
}, true);
}
got it
limber skiff
🤨
austere talon
HORROR
spark pivot
granite sky
30K NEW LINES?
spark pivot
Is this every user plugin
sterile oak
I will find where you live 
limber skiff
now that I understand wreq.a it makes sense why it exists
prime dew
But why
shell shuttle
how do i enable custom flags to try to counteract the unload issue?
limber skiff
I made this extremely future proof, it really should not break unless webpack changes considerably
shell shuttle
the --disable-something-something
shell shuttle
uhhhh
do i need a custom build for it
hold on
like where do i go to add that n all
limber skiff
what are you using?
shell shuttle
vennie vencord
limber skiff
desktop?
charred monolithBOT
shell shuttle
limber skiff
it should be applying the setting for you automatically if you are up to date
jagged reef
Also, this is more subjective, but having stuff like “By xyz” forced down users’ throats feels icky
limber skiff
it keeps growing
limber skiff
hmm what is this
@crude hearth this is related to you
this should fix it I guess
crude hearth
<@287555395151593473> this is related to you
How did that even cause error
I think I declared default state somewhere
limber skiff
ill fix it