#👾-core-development

1 messages · Page 178 of 1

charred monolithBOT
#

Please make it support regular expressions as was mentioned in this issue: Vencord/plugin-requests#159, I need it. Also please make it so it can also replace words in other people's messages from your perspective. & it would be nice if you make it so if the description message of a forum post or thread is hidden, the forum post or thread itself is also hidden.

It does support regular expressions, it's in the settings :)

charred monolithBOT
glass jasper
lime stone
#

slowmode is e

austere talon
#

i just got a peak plugin idea to solve the problem of having to be in a lot of servers if you want a lot of emote choices

basically return the dead emoji packs feature by keeping a separate list of emotes independent of discords emoji picker

then whenever you use an emote, create it on demand on a dummy server and if you're out of space, delete the one that was used last the longest ago

#

obviously will have some limitations with rate limit melt

glass jasper
#

we have the badge.api file, now we need emoji.api file

austere talon
#

what

glass jasper
#

idk, i’m on 29 hours of no sleep

inland fable
#

i been working on fixing that

#

i think best would be to put it inside the chat box but then

#

it'd be on top of the buttons thing

#

i got this which i think doesnt look too bad but you tell me is it too small

#

should i try making the chat box larger although that'd take another patch

#

doing that

glass jasper
tepid knoll
#

i mean u could also maybe try putting it under the chat bar, there is a somewhat decent amount of space under it at least on my end

inland fable
glass jasper
charred monolithBOT
tepid knoll
#

oh right i forgot whats where the slowmode text is

inland fable
#

me too 😭

glass jasper
# inland fable me too 😭

if I remember correctly, the BD version moves it to be in front of the slow mode text when it’s there and then it’s a normal place when it’s not there

tepid knoll
#

maybe u could put it on top? make it go behind things like the gif picker and maybe give it a little back drop

inland fable
#

yeh i was thinking on top

tepid knoll
#

like i guess thatll still go over stuff but i feel like that would happen not as often

inland fable
#

bbut that mnight be a bit hard and idk if uhm

glass jasper
tepid knoll
#

i mean if u can figure it out that could work too

lime stone
shell shuttle
charred monolithBOT
prime dew
#

Maybe this has already been suggested, but what about merging Betterfolders with Plainfoldericons? It seems a bit weird to have 2 separate plugins, and one of them is literally 1 toggle switch...

charred monolithBOT
limber skiff
#

does it not have another alternative than manually building the url

#

also need to edit it in two places, one handler is for sending, one for editing

austere talon
#

it's most likely in IconUtils

limber skiff
#

yepp

shell shuttle
#

still works on mobile thank god

charred monolithBOT
odd heath
#

what

#

oh i see how this works but this is horror

long hill
frail skyBOT
#
Bad Patches

BetterFolders (had no effect):
ID: 222059
Match: /(?<=onClick:\(\)=>{)(?=.{0,200}"discodo")/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

BetterFolders (had no effect):
ID: 222059
Match: /(?<=onClick:\(\)=>{)(?=.{0,200}"discodo")/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

oop

#

I knew something else would have broke

long hill
#

shitting and crying because of dis

#

how could you let this happen Nuckyz ;-; (bc this is totally 100% your fault because u made all of discord)

charred monolithBOT
limber skiff
#

should comment that

charred monolithBOT
mortal fractal
#

interesting

#

that they changed the event name

charred monolithBOT
limber skiff
charred monolithBOT
long hill
#

are commits instantly applied to be updated

#

like you can update in vencord

limber skiff
#

no

#

they will arrive in vencord when they hit the main branch

long hill
#

oh gotcha

limber skiff
#

I will merge to main when the fake nitro fix pr is merged

long hill
#

alralr

#

good job :D

#

it seems like most things were already manually building the url instead so it's probably best you do the same thing either way

limber skiff
#

this isnt manually building lol

long hill
#

oh mb i was looking at your previous commit

#

sorry

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

long hill
limber skiff
#

yeah but no need to cuz discord has a getEmojiURL function

long hill
#

new seems much more streamlined tho, again gj :3

charred monolithBOT
jagged cloak
#

banger idea

inland fable
#

i had similar idea but it'd be for non nitro and servers where you have upload emoji perms

#

it'd upload the emoji then send your message then delete the emoji blehhhhh

limber skiff
#

@lost smelt that's not quite right

#

do you know how to apply git patches?

long hill
jagged cloak
#

that relies on image/embed perms

limber skiff
#

git apply patch.diff

jagged cloak
#

emojis are usable on most servers that arent insane given you have nitro trol

long hill
#

i guess so, maybe two different version?

limber skiff
long hill
#

bc the other one would be perma rate limited pretty fast and have a limit on the amount of emoji's, meanwhile my idea just saves all the links to cache, keeping them in a separate group listing in the emoji picker and boom, ezpz as long as you have img/embed perms

#

although it sounds more like an addition to fakenitro if anything

austere talon
#

you can only create like 30 emotes or smth per hour

charred monolithBOT
long hill
#

overall executing it that way is worse than just filehosting them

austere talon
#

rate limits end when they end

long hill
#

not really, most of the time if you get rate limited too much especially with emoji's you will have an extremely long abnormal wait time sometimes even permanently

#

it happens a lot

austere talon
#

no

long hill
#

yeah lol, and stuff like this too "{"code": 0, "message": "You are being blocked from accessing our API temporarily due to exceeding our rate limits frequently. Please read our docs at https://discord.com/developers/docs/topics/rate-limits to prevent this moving forward."} " will, yes, regularly appear for normal 1 hour times, but after that a lot of people report the rate limit staying

austere talon
#

that happens if you spam 10k error requests in a short span of time

#

if you simply abide by the rate limit that will never happen

silk cypress
long hill
#

odd, i remember reading that many people had issues with it

long hill
#

so it wouldnt work if a server is deleted

silk cypress
#

good point

#

it would solve the issue of too many servers though

long hill
austere talon
long hill
#

and you can't get rate limited, theres no limits, and it takes minimal storage

austere talon
#

please don't talk so confidently if you have no idea what you're saying

#

you've been spreading a lot of misinfo the past dozens of messages

long hill
#

whar

austere talon
#

emojis are never deleted

#

no matter what happens

long hill
#

i was just explaining what i knew

silk cypress
#

I wonder if you could email discord privacy to remove an emoji if it was a privacy concern, although idk why it ever would be, just a silly thought

#

the last time I emailed discord privacy i got ghosted though so

#

it just depends on if you get the good RNG and can get a response from discord support

austere talon
#

probably yeah but other than that it will never go away

silk cypress
#

imo having the character counter there is the best looking option

silk cypress
glass jasper
austere talon
#

no

glass jasper
#

oh then idk what your are doing but sounds like a fine idea

silk cypress
#

it's kind of like an automated version of emote cloner in a way

#

huge oversimplification though

long hill
#

on aliu you can download all at once to upload them yourself, couldnt you just make a plugin to run the clone every few seconds to avoid rate limiting and show a toast to know how many are done/left and an eta?

#

(no idea if that's possible but still something i wanted to mention)

#

i'm actually unsure if the delay you need to upload emoji's with to avoid rate limiting is one set number of one that raises every time you upload another

silk cypress
#

discord explains this in their api docs

#

tl;dr you have to check response headers

#

although the same docs mention that emoji rate limit headers may be inaccurate

long hill
#

plus ping could also affect that i think, it depends if the delay is client or server i think? not sure

#

like if i have a really high ping and the delay is client side then the timer could be wildly inaccurate

silk cypress
#

I think just using links is simpler tbh

long hill
#

yeah it's better than what i said, i was so sure they deleted but ig not

#

WAIT

#

I'M DUMB

#

I WAS THINKING OF AVATAR URLS

#

mb

austere talon
#

the idea is not to automatically mass clone

long hill
#

gotcha gotcha

rugged spire
#

will emotecloner ever get the option to remember last server blobhuskcozy

long hill
#

it should just sort by recently cloned to imo

rugged spire
#

i can imagine the UX would get confusing very quick though

long hill
#

or there should be a sort button for diff sorts

rugged spire
lost smelt
long hill
mortal fractal
#

electron 30 testing on dev on windows

silk cypress
#

hello

charred monolithBOT
lost smelt
#

@limber skiff changes were pushed

limber skiff
lost smelt
limber skiff
#

were the routes for guild packs totally disabled?

mortal fractal
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
#

peak git management

charred monolithBOT
limber skiff
#

😭

lost smelt
#

but it did fix it

limber skiff
#

I'm sad cuz just merged

lost smelt
limber skiff
charred monolithBOT
rugged spire
lost smelt
jagged cloak
amber robinBOT
charred monolithBOT
rugged spire
#

so uh, uh yeah uhhhhh

crude hearth
#

I love reading event reviews

rugged spire
#

dont worry

#

this isnt YOUR code

#

this is MY (horrible) CODE

crude hearth
#

good add to vencord when

rugged spire
crude hearth
#

nice

rugged spire
#

it turns out that the event context menu ID is user-context

#

this will be fixed

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
shell shuttle
#

rce patched again grrrrrr

rugged spire
#

yop can confirm on canary

#

inb4 i dont even HAVE the patch that fixed it last time

#

discord LOVES breaking RCE

rugged spire
tepid knoll
#

man yall need to stop calling rolecoloreverywhere rce i thought u were complaining about discord fixing remote code execution for a second 😭

fringe basalt
#

same

charred monolithBOT
shell shuttle
#

Next we need All Colors Everywhere

#

I need ACE plugin in Vencord now

fringe basalt
#

what about Direct Message Colors Anywhere

#

need that vencord DMCA

charred monolithBOT
charred monolithBOT
median rapids
austere talon
lost smelt
#

how are you even doing that

#

the api returns a 403 for me

jagged cloak
#

dolfer moment

shell shuttle
jagged cloak
#

wild vrchatter jumpscare

shell shuttle
charred monolithBOT
charred monolithBOT
odd heath
#

vee will review my pr

lime stone
#

😔

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

why is electron 30 so ugly

charred monolithBOT
limber skiff
#

omg sorry guys!! wrong commit name!!!!!

charred monolithBOT
austere talon
#

thats funny but people will see this and be scared

charred monolithBOT
limber skiff
#

if this same patch breaks again I'm gonna go insane

charred monolithBOT
jagged cloak
#

nuckyz real trol

jagged cloak
#

wait no i see why you did this now

#

lmfaoo

limber skiff
#

more shit broke with no broken patches

#

WE LOVE

#

where is my button to view home :((

jagged cloak
#

just now? cause i still have it

limber skiff
#

what are you using? stable?

#

actually it's broken in stable too

jagged cloak
#

stable yeah

limber skiff
#

restart it :)

jagged cloak
#

is it related to electron 30 upgrade

#

cause im using x64 stable still have 28

#

and nothing's broken that wasnt already

limber skiff
#

nop

charred monolithBOT
limber skiff
#

oh my fucking god

#

yall are gonna laugh of this

jagged cloak
#

whats it this time

charred monolithBOT
limber skiff
#

I can't believe this

#

💀 💀

charred monolithBOT
limber skiff
#

gonna wait before merging again...

jagged cloak
#

lool not the colorblindness patch

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

lime stone
#

feat: add RCE

odd heath
shell shuttle
#

ive never seen this before

#

waaaait

#

nvm

#

idk why thats happening

#

pls help

#

im doing a smart

#

lets go i fixed it

lime stone
#

pnpm i

charred monolithBOT
shell shuttle
#

oh shit i missed lint

#

one minite

#

ok fixed

shell shuttle
median rapids
#

lmao

mortal fractal
charred monolithBOT
shell shuttle
#

i hope

#

maybe

median rapids
#

vencor url rce wen

median rapids
shell shuttle
#

IM GOING MENTALLY INSANE

charred monolithBOT
golden gulch
#

while it's not really urgent or anything, a review/merge of #2388 would be neat as it also addresses some caching things with the new file store - some users are running into issues with discord caching images longer than it should and changes in the PR would resolve it

GitHub

USRBG has moved storage to a new dedicated platform, allowing better integration and more control over the data that can be made available for plugins to use. This has allowed creation of a new API...

austere talon
#

sure ill have a look tomorrow

golden gulch
#

neat, thanks vennieflower

austere talon
#

(if i dont forget, maybe remind me if i do)

#

i really need to get like a task organiser or smth

glass jasper
glass jasper
real flower
#

dumb question
where are core vencord patches (not plugin, just always loaded)

real flower
#

oh that's a good question

austere talon
#

do you mean the apis and settings and such?

real flower
#

are there any
uhh

real flower
#

just any find replace patches

#

that apply every load no matter what

#

o

austere talon
#

theyre just regular plugins

#

but API plugins are hidden from the user

real flower
#

ahh

#

i was thinking

austere talon
#

unless you search for "API"

real flower
#

what if we moved this from ScreenSharePicker.tsx

#
{
            find: "x-google-max-bitrate",
            replacement: [
                {
                    // eslint-disable-next-line no-useless-escape
                    match: /"x-google-max-bitrate=".concat\(\i\)/,
                    replace: '"x-google-max-bitrate=".concat("80_000")'
                },
                {
                    match: /;level-asymmetry-allowed=1/,
                    replace: ";b=AS:800000;level-asymmetry-allowed=1"
                }
            ]
        }
#

to a core vencord plugin

#

so the 2500kbps bitrate limit wouldn't kill chromium users

#

i was thinking about other fixes but honestly fixing a ton of streaming issues i feel is out of the scope for vencord

#

but a small patch to improve them

#

seems useful

shell shuttle
#

damn

#

OH HOLY SHIT

#

ITS LIKE AN EASTER EGG

#

it only shows up when i type api

#

u should make it so when u type Vennie in the plugin search

real flower
#

it vennies all over the place

shell shuttle
#

🙏 it would be amazing

#

i will litearlly find a way to imploment it if it was an accepted idea

glass jasper
real flower
#

idk what happens when a core patch fails

austere talon
#

it would warn on firefox

real flower
#

how AAE_Stare

#

also uhhh I'd just say wait to merge the pr until next vesktop update cuz you'd have to merge the pr that removes that patch from vesktop too

real flower
austere talon
#

.web.ts

real flower
#

ahhh

#

nice

#

thx

real flower
rugged spire
#

yes

austere talon
#

yes

real flower
#

oki

rugged spire
#

do not try to make vesktop register as a desktop client with the gateway

#

it will explode voice channels i heard

real flower
#

i will not

#

i have tested that in the past

#

who knows maybe one day ill make that a thing

#

not today though

#

not today

real flower
#

yeah true

#

eh

rugged spire
real flower
#

its discord's problem

rugged spire
#

discord will never fix

#

i fix discord bugs

real flower
#

they fixed the 30kbit issue

rugged spire
real flower
#

not my fault they haven't fixed their screenshare resolution not applying

#

id have to do what we did in vesktop

#

and rewrite like half of their webrtc code

#

i am nOT doing that again

charred monolithBOT
limber skiff
#

not a core, and look at the required

real flower
#

huh

#

okay

limber skiff
#

but actually you can keep it as required: true

real flower
#

why

#

why not core I mean

limber skiff
#

because it's only going to be bundled in web so no need to check for IS_WEB

real flower
#

cuz I'm like half asleep rn

limber skiff
#

oh yeah also call it like WebScreenshareTweaks or something

real flower
#

it's literally fixing a discord bug that makes screenshares unbearable

#

I don't see how it could be anything other than core

#

unless I understand incorrectly

limber skiff
#

there are plugins that fix stuff too

#

and they are not a core

#

WebContextMenus is required too and it's not a core

real flower
#

yeah but what's the difference

#

considering this isn't even a plugin

limber skiff
#

It's just not an extremely core I dont know how to explain

real flower
#

it's a 1 line patch

limber skiff
#

ask for vee what's his opinion

real flower
#

lol fair idk

#

@austere talon I'm confused help

limber skiff
real flower
#

there's nothing else to do

limber skiff
#

these are the core plugins, I dont see that one fitting there

real flower
#

it's a single fix that changes a lot

real flower
#

yeah but I also said that would require rewriting like their entire webrtc code

#

I'm not doing that

austere talon
#

i would not make it required

#

but enabled by default

real flower
#

may I ask why

limber skiff
#

_core plugins are required for the functionality of Vencord

#

that one is not for Vencord, but a discord thing

real flower
real flower
#

still I don't see why not required

#

sorry btw I'm not trying to argue, just curious

limber skiff
#

I dont mind it not being required, just dont like it being a core, but lets see what vee says

austere talon
# real flower may I ask why

because it is not required for vencord to function

we try to keep the default vencord experience as vanilla as possible so unless something is absolutely required it should be toggleable

real flower
#

ahhhhh

austere talon
#

enabledByDefault is basically the same as required

#

cause no sane person is gonna disable it

real flower
#

okay I didn't realize that

#

alr

austere talon
#

but leaves the user the option to turn it off if they still want to

real flower
#

I'll fix that tmrw

austere talon
#

some users may want to cause they think it's risky or whatever

limber skiff
#

that's true almost no one prob has crash handler disabled

austere talon
#

some people even want notrack to be disableable

real flower
#

wtf

austere talon
#

which i think i might make parts of it possible to turn off

limber skiff
#

this one is the only I can see a reason for turning off

austere talon
#

the reason it's required is to disable crash reporting so discord doesn't get vencord error logs in their error tracking

#

but the analytics stuff can be on

#

some insane people might want it

limber skiff
#

do you want me to just make an option to keep the science stuff

#

should I change anything?

#

prob better if I screenshot haha

rugged spire
#

are they insane

limber skiff
#

I wouldnt be against doing it myself

austere talon
#

Disable Analytics

limber skiff
#

aight

charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

jagged cloak
#

some insane people

#

who in the right mind gonna turn back on analytics

lost smelt
#

but the option is there ig

charred monolithBOT
charred monolithBOT
charred monolithBOT
rugged spire
#

hey everyone, you should go to the app directory, open the page for any app, and right click any link

#

must have ImageZoom plugin enabled

rugged spire
#

discord devs don't reuse unrelated context menus for random shit (failed)

charred monolithBOT
charred monolithBOT
shell shuttle
rugged spire
#

FINALLY

#

Thank you @austere talon for this

#

I will admit I wanted this feature forever ago

austere talon
shell shuttle
austere talon
rugged spire
#

the one you just implemented

#

idc if its ugly

shell shuttle
#

i don't get it

rugged spire
#

click contributor badge to see what plugins they made

crude raptor
#

oh that does sound nice

rugged spire
#

I have never seen this modal before

#

and

#

it's popping up

#

because local is ahead of remote

#

oh

#

and also i didnt build it

#

i am stupid

austere talon
rugged spire
#

@austere talon is there any reason that clicking on the profile name in that menu doesn't open the actual profile on discord?

#

is that by design?

austere talon
#

yes

#

do you really want whitenames to dm you for support

rugged spire
#

to stop people DMing for support

#

yeah......

austere talon
#

we had the pfps open profiles before

#

but people kept dming for support

#

thats why i made these pages that show ur github and website and plugins

#

so you still get attribution without people annoying u

shell shuttle
rugged spire
#

maybe it could be reimplemented with a check to see if you are also a dev

austere talon
#

i think this is good now

#

wait

rugged spire
#

vee

austere talon
#

hmm

rugged spire
#

you forgot the original purpose of the badge

#

which was to link to the github

austere talon
#

its literally top right

rugged spire
#

no

austere talon
#

oh do u mean the vencord github

rugged spire
#

yes

austere talon
#

should i just make "contributed" a hyperlink

rugged spire
#

hmm

#

if it were a hyperlink i would link to the page of that users' commits

austere talon
#

not possible

shell shuttle
#

PRs to their commits?

rugged spire
austere talon
#

not possible

#

we dont know the github people used to contribute

#

github and website are pulled from your profile connections

#

if you dont have them linked they wont show in the modal

rugged spire
#

is that too unreliable?

austere talon
#

theres no guarantee that you have it linked or that you have the right one linked

shell shuttle
#

ohhhh

rugged spire
#

Oh?

#

@austere talon have you considered using github API to check if the linked github account has commits in the repo

#

is that even a possibility?

austere talon
#

bad

#

now its a link

shell shuttle
#

ooooh

charred monolithBOT
austere talon
#

jumpscare

shell shuttle
#

Aaaaaaaaah

#

they likely {ContributorHyperlink}

rugged spire
#

How was this never a feature until now?

#

Should 0/1 snippet[s] be pluralised or not

#

That is 0 out of 1 btw

austere talon
#

what

rugged spire
charred monolithBOT
austere talon
#

how tf did this code ever work before

#

it used proxied components

shell shuttle
#

woaw

glass jasper
# charred monolith

this shouldn’t break my pr showbadgesinchat, i mean pull contributor info from @utils/misc, we really only touch the donor badges stuff, and even then that’s pulled from the plugins/_api/badges.tsx unless i’m being an idiot and some how those work together.

#

idk what i’m thinking i need a little while i just woke up

charred monolithBOT
odd heath
#

It confused me so much because it behaved differently from the other finds

shell shuttle
#

woah

odd heath
#

Jumpscare

austere talon
#

actually

#

remmeber we have different stages of plugin start

#

like Init, WebpackReady, etc

#

does using Init break flux stuff?

limber skiff
#

how would it?

#

hmm you mean because it calls startPlugin in init

#

I think so

#

have to test but probably yeah

glass jasper
#

close jumpscare

austere talon
#

fear

#

they deleted their fork :o

glass jasper
#

based

charred monolithBOT
limber skiff
#

see if that works

austere talon
limber skiff
#

lol vee

austere talon
#

huh

topaz thistle
#

When you still get prompted to enable 1 Million Analytics when installing Windows Pro N

#

Fuck you Microsoft

limber skiff
topaz thistle
limber skiff
#

not even lint, what am I saying

#

the type checking

charred monolithBOT
limber skiff
#

the only reason that existed was to not subscribe if we already did when flux was ready

#

but now we dont try to subscribe if flux was not ready

real flower
#

does my pr look better now?
i tried to toss it in its own plugin

#

:3

austere talon
#

OH MY GOD @limber skiff

#

wanna know why lint exploded

#

i didnt fucking save a file

#

so it didnt give me errors locally cause vscode was using the unsaved file

real flower
#

vscode autosave:

odd heath
austere talon
charred monolithBOT
glass jasper
odd heath
glass jasper
woeful sable
#

Real

charred monolithBOT
golden gulch
#

idk when vee sleeps but I guess it is kinda technically tomorrow?? so just a small reminder about the usrbg pr blobcatcozystars

lime stone
#

oops

charred monolithBOT
verbal pumice
charred monolithBOT
#

PR Review

<table>
<tr>
<tr><td> ⏱️ <strong>Estimated effort to review [1-5]</strong></td><td>

4, due to the complexity and size of the PR, which includes a new plugin with multiple components, lazy loading, and dynamic routing. The PR involves advanced TypeScript features and React components, requiring a thorough understanding of asynchronous operations, state management, and event handling.

</td></tr>
<tr><td> 🧪 <strong>Relevant tests</strong></td><td>

No

...

austere talon
#

what does that link to

#

link beamed me into some random server 😭

verbal pumice
#

discord previews

#

snippets channel

charred monolithBOT
austere talon
#

nice

charred monolithBOT
#

this is a horrible way of doing this, way worse than the "bloated" plugin made before this PR.

what do you mean this is a horrible way of doing this? horrible to the undescribed standards that you guys set?

it works and it does it without having 156 lines of code + a css file and modifying a discord feature which would cause the plugin to break if discord ever wants to update that feature bruh. 💀 at least mine is foolproof (kinda).

topaz thistle
#

VSCode taking 19GB Ram Challange

spark pivot
charred monolithBOT
#

this is a horrible way of doing this, way worse than the "bloated" plugin made before this PR.

what do you mean this is a horrible way of doing this? horrible to the undescribed standards that you guys set?

it works and it does it without having 156 lines of code + a css file and modifying a discord feature which would cause the plugin to break if discord ever wants to update that feature bruh. 💀 at least mine is foolproof (kinda).

you could do the same with a single rege...

verbal pumice
#

can someone just lock that thread please

#

preferably close the pr too

verbal pumice
#

ty

woeful sable
charred monolithBOT
limber skiff
#

it's fixed already 😞

spark pivot
topaz thistle
#

nvm the extension host has a massive memory leak

real flower
topaz thistle
#

narrowed it down to some plugin

#

Not sure which one tho

#

doesn't show up in the extension host funnily

real flower
#

vencord companion:

#

that would be really funny

#

@turbid hatch i dont mean to bother, just curious cuz i dont know much about how flathub works
what does it take for flathub to update to 1.5.2, as i see the repo is already updated

turbid hatch
#

they have a grace period before its deployed for everyone

#

2 or so hours

#

so you can fix any bugs that show up

#

and then it takes time for it to be reviewed and approved

real flower
#

ahhhhhhhhh

turbid hatch
#

the build was delayed so

real flower
#

yeah

#

i saw that but i assumed it was finished by now

#

that makes sense tho

#

thanks :3

turbid hatch
#

yeah it should be, i think its just in that review period thing

real flower
#

mhm

topaz thistle
#

It's the fucking gradle extension

#

It leaks big when a yaml file is opened

charred monolithBOT
rugged spire
charred monolithBOT
#

I think there really should be a feature where you can publish filter lists, & there should also be a feature where anyone can make a fork of a list, & the fork can be merged into the original. & anyone should be able to use any version of a filter list & choose whether or not to automatically update it. If they use the newest version, automatic updates would be enabled by default, but if they use any other version, automatic updates would be disabled by default.

topaz thistle
rugged spire
topaz thistle
#

Yeah idk either

#

Just patch properly

#

Like everyone does

#

Def not dumb to hook into every regex call

#

and then also have prototype pollution

austere talon
#

sorry for the multiple reviews xd

#

this change is quite complex so

limber skiff
#

lmao it's fine

charred monolithBOT
limber skiff
#

in case it does explode our console will stay way more clean

austere talon
#

hmm

#

so its to handle the worst case scenario where webpack patching fails?

limber skiff
#

yeah kinda

#

it's more of a change to make things look better in case it finds

#

it's not useful to get spammed a billion errors because grabbing the wreq failed and our patches are trying to do finds

austere talon
#

but this will make settings not patch

#

when settings could potentially still work

#

i dont think its good to have

limber skiff
#

right

austere talon
#

maybe in IS_DEV

limber skiff
#

alright I will change it

austere talon
#

well settings ui would still depend on webpack but if the ui fails it gets caught by ErrorBoundary

#

which is deliberately vanilla no webpack modules

#

and that has the update prompt

limber skiff
#

yop

austere talon
#

welll

#

actually

#

that still needs React which would also fail

#

well anyway just do it dev only imo

#

seems better

limber skiff
austere talon
#

actually no cause we get React via waitFor

#

which doesnt rely on wreq existing

limber skiff
#

also true

austere talon
#

if patches work, waitFor also works

#

but looks good other than that!

limber skiff
#

what this do you want it to be in this case

#

here's the full code

austere talon
#

the this from callback

limber skiff
#

I see

austere talon
#

if ts is crying, just do

callback = function (this: unknown) {
limber skiff
#

in case webpack does set the this

austere talon
#

it probably wouldnt but

limber skiff
#

nah it's not crying I just wanted to know

austere talon
#

when monkey patching its always best to relay this and arguments

#

just in case

limber skiff
#

I should also anyway

austere talon
#

at that point just

#

originalOnChunksLoaded.apply(this, arguments)

#

make sure callback syncs to arguments tho

#

behaviour is a bit weird sometimes

limber skiff
#

but are you sure this will be the obj

#

hmm it will be I need to bind our patched function too then

austere talon
#

wdym

#

u dont have to bind

#

if u monkey patch something with a function then the this will be correct

limber skiff
#

are you sure those will be the same

#

this is how we set the monkey patched function

austere talon
#

try it and see

#

it should

limber skiff
#

we love this

austere talon
#

well why wouldnt it

charred monolithBOT
austere talon
#

anyway you could also

#

.apply(wreq, arguments)

#

or just keep it

#

its fine the way it is

limber skiff
austere talon
#

i mean it makes sense

#

this is always the object the method is called on

#

CURSED

#

AAAAAH JS WHY

limber skiff
#

ok yeah it works

charred monolithBOT
limber skiff
#

now this should not break anything for sure

austere talon
#

u didnt have to do all these changes

limber skiff
#

you mean these?

austere talon
#

i meant the this stuff xd

limber skiff
#

it's okay

#

I like to keep it clean

austere talon
#

are u done

limber skiff
#

yeah let me just make sure the toString works

charred monolithBOT
limber skiff
#

huh

#

that doesnt work

#

💥

#

it's why I didn't do it haha

austere talon
#

oh

#

okay im dumb

#

okay revert

#

xd

#

im sorry

limber skiff
#

easier like this :)

charred monolithBOT
austere talon
#

we good?

#

did u test what u wanted to test

limber skiff
#

we good

#

yeah

charred monolithBOT
austere talon
#

thanks a lot nuckyz

#

finally working reporter again

limber skiff
#

it's the time I finally brick vencord

#

did you see my super cursed stuff on the reporter code

#

the way I see if we finished loading everything

charred monolithBOT
limber skiff
#

@austere talon should we delete these branches with closed prs?

#

maybe not telemetry

austere talon
#

nah keep them

real flower
#

@austere talon seriously what's up with wikisearch

#

why isnt that camelCase lmao

austere talon
#

cause the author iddnt make it

#

and it slipped through

limber skiff
#

so many conflicts with my other working thing :(

shell shuttle
austere talon
real flower
#

fix it

limber skiff
#

waitFor finds

#

(I need a better name for that)

#

I was waiting for webpack refactor to get merged to work more on it

#

and now it has a billion conflicts

real flower
#

so some of them are way behind

#

lmao

austere talon
#

delete branch when pr merged :P

#

if u use refined github it auto does it

shell shuttle
#

same

#

i need branches for every individual feature when working on vencord stuff

real flower
#

branch per commit

#

3000 prs

#

to add one plugin

rugged spire
rugged spire
shell shuttle
rugged spire
shell shuttle
#

DAMN

real flower
#

what the hell are you working on

rugged spire
#

custom fork of channeltabs

charred monolithBOT
limber skiff
#

I fucked up so bad the git on this

#

jesus christ

charred monolithBOT
limber skiff
#

help idk how to fix this

charred monolithBOT
golden gulch
# charred monolith

those are good questions and the answer is that I went through a few different response formats while working out how I wanted the shape of the API to be and was testing it alongside the vencord plugin blobcatcozystars will add a commit to clean up that stuff now

#

alright all resolved

#

gonna clean up one or two more things now too that I've just noticed

charred monolithBOT
limber skiff
#

finally

austere talon
#

bro discord staff praised me for merging vencord prs best moment of my life

limber skiff
#

wait for real?

lime stone
#

inadventently i assume blobcatcozy

rugged spire
#

100 commits

austere talon
# limber skiff wait for real?

lmao it was an event in the discord admins server where we did intervals of 15min "work sessions" where we all set goals and then after talked about our succcess

i mentioned it without mentioning what the prs are for xd

charred monolithBOT
lime stone
#

does discord not have some kind of Vencord / BetterDiscord staff badge for people

rugged spire
austere talon
#

tbh that staff was really sweet

lime stone
#

was joke

limber skiff
#

yooo drop the app

shell shuttle
#

oh wait im in that server

#

on another account ughhh

austere talon
rugged spire
limber skiff
lime stone
golden gulch
#

oki v I'm done with the very minor changes venniecozycat thankies for review

shell shuttle
#

wait how do i join discord admins again]\

#

i thought it was 500 member server

lime stone
#

have server with >= 1k members & >= 60% retention

charred monolithBOT
shell shuttle
#

ofc they made it 1k members

#

well im fucked now

median rapids
#

ew

golden gulch
#

v will give the janitors manage server and we will all join the admins server

shell shuttle
#

im watching a cyberpunk iceberg

lime stone
#

🙏

#

venchord raid

median rapids
#

v will give me manage server (i will steal your vanity)

lime stone
#

doesn't it check for the actual admin perm

#

can lewi join for e.g.

median rapids
#

no idts

#

i think it's just manage guild

#

check docs tho smh

long heart
lime stone
#

discord.sex >

limber skiff
#

this is why I made this function accept the flux as argument vee

#

:)

#

preparing for my own shit

#

also I think this is pretty cool

austere talon
#

this server doesnt have enough retention

golden gulch
#

sad day

rugged spire
lime stone
#

who trusts vee

golden gulch
#

going through my hundreds of servers to see if there's some random one I have manage server in and meets the requirements

lime stone
#

i will become admin in roblox community

lime stone
#

i will choose a cuter avatar

golden gulch
#

there was a time when that was the case yes xP

lime stone
#

that happens to me but only in smol

#

not like 100k member

#

what kinda management

golden gulch
#

I used to help out with a fairly big event organization group that helped set up smaller groups a lot