#👾-core-development
charred monolithBOT
charred monolithBOT
Add Character Count plugin
Always displays the character count on the bottom right of the chat input, followed by the user's max character count
glass jasper
@inland fable i think i found a issue with this plugin
lime stone
slowmode is e
austere talon
i just got a peak plugin idea to solve the problem of having to be in a lot of servers if you want a lot of emote choices
basically return the dead emoji packs feature by keeping a separate list of emotes independent of discords emoji picker
then whenever you use an emote, create it on demand on a dummy server and if you're out of space, delete the one that was used last the longest ago
obviously will have some limitations with rate limit 
glass jasper
obviously will have some limitations with rate limit <:melt:1175354410617020416>
host every emoji on vencord.dev, so when someone wants to use an emoji it just pulls from you
we have the badge.api file, now we need emoji.api file
austere talon
what
glass jasper
idk, i’m on 29 hours of no sleep
odd heath
i just got a peak plugin idea to solve the problem of having to be in a lot of s...
FIRE
inland fable
<@843448897737064448> i think i found a issue with this plugin
yeah
i been working on fixing that
i think best would be to put it inside the chat box but then
it'd be on top of the buttons thing
i got this which i think doesnt look too bad but you tell me is it too small
should i try making the chat box larger although that'd take another patch
doing that
glass jasper
i got this which i think doesnt look too bad but you tell me is it too small
what would it look like on the other side of the bottom of the chat bar?
tepid knoll
i mean u could also maybe try putting it under the chat bar, there is a somewhat decent amount of space under it at least on my end
inland fable
i mean u could also maybe try putting it under the chat bar, there is a somewhat...
yeah the issue is it then collides with the slowmode text 😓
glass jasper
i mean u could also maybe try putting it under the chat bar, there is a somewhat...
if you that you run into this problem
tepid knoll
oh right i forgot whats where the slowmode text is
inland fable
me too 😭
glass jasper
me too 😭
if I remember correctly, the BD version moves it to be in front of the slow mode text when it’s there and then it’s a normal place when it’s not there
tepid knoll
maybe u could put it on top? make it go behind things like the gif picker and maybe give it a little back drop
inland fable
yeh i was thinking on top
tepid knoll
like i guess thatll still go over stuff but i feel like that would happen not as often
inland fable
if I remember correctly, the BD version moves it to be in front of the slow mode...
i uhm was thinking i could make it like this if theres slowmode
bbut that mnight be a bit hard and idk if uhm
glass jasper
i uhm was thinking i could make it like this if theres slowmode
if I remember correctly, that’s exactly what the BD version does, and that would work
tepid knoll
i mean if u can figure it out that could work too
lime stone
obviously will have some limitations with rate limit <:melt:1175354410617020416>
the rate limit is there specifically to stop stuff like this i think
shell shuttle
idk, i’m on 29 hours of no sleep
get sleeeep
shell shuttle
i just got a peak plugin idea to solve the problem of having to be in a lot of s...
holy shit i love this idea
glass jasper
get sleeeep
crude hearth
i just got a peak plugin idea to solve the problem of having to be in a lot of s...
sefbot
charred monolithBOT
prime dew
Maybe this has already been suggested, but what about merging Betterfolders with Plainfoldericons? It seems a bit weird to have 2 separate plugins, and one of them is literally 1 toggle switch...
charred monolithBOT
limber skiff
does it not have another alternative than manually building the url
also need to edit it in two places, one handler is for sending, one for editing
austere talon
it's most likely in IconUtils
limber skiff
yepp
long hill
praying
frail sky
long hill
shitting and crying because of dis
how could you let this happen Nuckyz ;-; (bc this is totally 100% your fault because u made all of discord)
limber skiff
should comment that
limber skiff
that they changed the event name
yep
long hill
oh gotcha
limber skiff
I will merge to main when the fake nitro fix pr is merged
long hill
alralr
good job :D
it seems like most things were already manually building the url instead so it's probably best you do the same thing either way
limber skiff
this isnt manually building lol
long hill
oh mb i was looking at your previous commit
this
const url = new URL(`https://cdn.discordapp.com/emojis/${emoji.id}.${emoji.animated ? "gif" : "webp"}?quality=lossless`);
yeah but no need to cuz discord has a getEmojiURL function
jagged cloak
i just got a peak plugin idea to solve the problem of having to be in a lot of s...
i thoiyght about this like a year ago but never wanted to dedicate the time to make it
banger idea
inland fable
i had similar idea but it'd be for non nitro and servers where you have upload emoji perms
it'd upload the emoji then send your message then delete the emoji 
long hill
i just got a peak plugin idea to solve the problem of having to be in a lot of s...
couldnt you just have it take the emoji urls from servers rip the image to a separate free file host and then just reuse that as a fakemoji, seems easier and you dont need a server or multiple for it
jagged cloak
that relies on image/embed perms
jagged cloak
emojis are usable on most servers that arent insane given you have nitro 
long hill
i guess so, maybe two different version?
limber skiff
@lost smelt
long hill
bc the other one would be perma rate limited pretty fast and have a limit on the amount of emoji's, meanwhile my idea just saves all the links to cache, keeping them in a separate group listing in the emoji picker and boom, ezpz as long as you have img/embed perms
although it sounds more like an addition to fakenitro if anything
austere talon
it'd upload the emoji then send your message then delete the emoji <:blehhhhh:12...
emoji rate limit is very strict
you can only create like 30 emotes or smth per hour
long hill
you can only create like 30 emotes or smth per hour
any more than it permanently limits you, as i said, and can even get you banned for selfbot etc
overall executing it that way is worse than just filehosting them
austere talon
any more than it permanently limits you, as i said, and can even get you banned ...
no?
rate limits end when they end
long hill
not really, most of the time if you get rate limited too much especially with emoji's you will have an extremely long abnormal wait time sometimes even permanently
it happens a lot
austere talon
no
long hill
yeah lol, and stuff like this too "{"code": 0, "message": "You are being blocked from accessing our API temporarily due to exceeding our rate limits frequently. Please read our docs at https://discord.com/developers/docs/topics/rate-limits to prevent this moving forward."} " will, yes, regularly appear for normal 1 hour times, but after that a lot of people report the rate limit staying
austere talon
that happens if you spam 10k error requests in a short span of time
if you simply abide by the rate limit that will never happen
silk cypress
i just got a peak plugin idea to solve the problem of having to be in a lot of s...
why not just save the emoji links and then post fake nitro emojis?
long hill
odd, i remember reading that many people had issues with it
austere talon
why not just save the emoji links and then post fake nitro emojis?
cause its meh
long hill
why not just save the emoji links and then post fake nitro emojis?
when the emoji are deleted so is the cdn link
so it wouldnt work if a server is deleted
long hill
couldnt you just have it take the emoji urls from servers rip the image to a sep...
so would offloading them like i explained here
austere talon
when the emoji are deleted so is the cdn link
wrong
long hill
and you can't get rate limited, theres no limits, and it takes minimal storage
austere talon
please don't talk so confidently if you have no idea what you're saying
you've been spreading a lot of misinfo the past dozens of messages
long hill
whar
long hill
i was just explaining what i knew
silk cypress
I wonder if you could email discord privacy to remove an emoji if it was a privacy concern, although idk why it ever would be, just a silly thought
the last time I emailed discord privacy i got ghosted though so
it just depends on if you get the good RNG and can get a response from discord support
austere talon
probably yeah but other than that it will never go away
silk cypress
if I remember correctly, that’s exactly what the BD version does, and that would...
the BD version had the character counter on the far right, then moved everything else to the left, including combo gauge and slowmode and I think that's it
imo having the character counter there is the best looking option
silk cypress
i uhm was thinking i could make it like this if theres slowmode
this also looks great, using a little separator dot
glass jasper
probably yeah but other than that it will never go away
this is starting to sound like Vendetta’s stealmoji where you can can copy a server’s emoj (and i think stickers) to a different server
https://vd-plugins.github.io/proxy/fierdetta.github.io/stealmoji/
glass jasper
oh then idk what your are doing but sounds like a fine idea
silk cypress
it's kind of like an automated version of emote cloner in a way
huge oversimplification though
long hill
on aliu you can download all at once to upload them yourself, couldnt you just make a plugin to run the clone every few seconds to avoid rate limiting and show a toast to know how many are done/left and an eta?
(no idea if that's possible but still something i wanted to mention)
i'm actually unsure if the delay you need to upload emoji's with to avoid rate limiting is one set number of one that raises every time you upload another
silk cypress
discord explains this in their api docs
tl;dr you have to check response headers
although the same docs mention that emoji rate limit headers may be inaccurate
long hill
plus ping could also affect that i think, it depends if the delay is client or server i think? not sure
like if i have a really high ping and the delay is client side then the timer could be wildly inaccurate
silk cypress
I think just using links is simpler tbh
long hill
yeah it's better than what i said, i was so sure they deleted but ig not
WAIT
I'M DUMB
I WAS THINKING OF AVATAR URLS
mb
austere talon
the idea is not to automatically mass clone
long hill
gotcha gotcha
rugged spire
will emotecloner ever get the option to remember last server 
long hill
it should just sort by recently cloned to imo
rugged spire
i can imagine the UX would get confusing very quick though
long hill
or there should be a sort button for diff sorts
rugged spire
it should just sort by recently cloned to imo
nop
lost smelt
do you know how to apply git patches?
yea
mortal fractal
electron 30 testing on dev on windows
silk cypress
hello
charred monolithBOT
i have made some changes because otherwise it collides with the slowmode text
^ currently like that however i do plan to improve it and make it pretty i just cant do it for a day or so i don't know if i can put the PR on hold or whatever for a while
lost smelt
@limber skiff changes were pushed
limber skiff
<@235834946571337729> changes were pushed
you didnt import IconUtils
lost smelt
you didnt import IconUtils
fixed
limber skiff
were the routes for guild packs totally disabled?
mortal fractal
limber skiff
https://fxtwitter.com/lolpython/status/1785444412644057158
really cool
limber skiff
peak git management
limber skiff
😭
limber skiff
I'm sad cuz just merged
lost smelt
I'm sad cuz just merged
why not merge again
limber skiff
this is an extension release
shell shuttle
https://fxtwitter.com/lolpython/status/1785444412644057158
ooooh
rugged spire
https://fxtwitter.com/lolpython/status/1785444412644057158
@median rapids you will cry
lost smelt
<@852892297661906993> you will cry
rip
jagged cloak
<@852892297661906993> you will cry
trol
amber robinBOT
charred monolithBOT
Sure, userVoiceShow2.zip
I tried to use it, but I can't see voice icons in the member list even though it's enabled in the settings.
rugged spire
so uh, uh yeah uhhhhh
crude hearth
good add to vencord when
rugged spire
crude hearth
nice
charred monolithBOT
charred monolithBOT
charred monolithBOT
shell shuttle
rce patched again grrrrrr
rugged spire
yop can confirm on canary
inb4 i dont even HAVE the patch that fixed it last time
discord LOVES breaking RCE
rugged spire
inb4 i dont even HAVE the patch that fixed it last time
wasn't the case btw
tepid knoll
man yall need to stop calling rolecoloreverywhere rce i thought u were complaining about discord fixing remote code execution for a second 😭
fringe basalt
same
charred monolithBOT
shell shuttle
man yall need to stop calling rolecoloreverywhere rce i thought u were complaini...
Next we need All Colors Everywhere
I need ACE plugin in Vencord now
median rapids
<@852892297661906993> you will cry
spoiler: they didn't fix it
austere talon
<@852892297661906993> you will cry
bros did not fix
jagged cloak
dolfer moment
shell shuttle
bros did not fix
byon jumscare
jagged cloak
wild vrchatter jumpscare
shell shuttle
wild vrchatter jumpscare
‼️
odd heath
vee will review my pr
odd heath
https://tenor.com/view/nuh-uh-beocord-no-lol-gif-24435520
yxuh uh
shell shuttle
https://tenor.com/view/nuh-uh-beocord-no-lol-gif-24435520
lime stone
vee will review my pr
unfortunately this is not something which happens outside of dreams
😔
limber skiff
why is electron 30 so ugly
limber skiff
omg sorry guys!! wrong commit name!!!!!
limber skiff
thats funny but people will see this and be scared
DFHDFD only those who see this channel will see it 🤫
if this same patch breaks again I'm gonna go insane
jagged cloak
nuckyz real trol
jagged cloak
is there not already a catch-all to ignore all bots/webhooks
wait no i see why you did this now
lmfaoo
limber skiff
more shit broke with no broken patches
WE LOVE
where is my button to view home :((
jagged cloak
just now? cause i still have it
jagged cloak
stable yeah
limber skiff
restart it :)
jagged cloak
is it related to electron 30 upgrade
cause im using x64 stable still have 28
and nothing's broken that wasnt already
limber skiff
nop
jagged cloak
whats it this time
limber skiff
gonna wait before merging again...
jagged cloak
lool not the colorblindness patch
lime stone
feat: add RCE
odd heath
feat: add RCE
whenever vee runs ve itll pick a random vencord user to run the code instead of running it through venbot
shell shuttle
uhh
ive never seen this before
waaaait
nvm
idk why thats happening
pls help
im doing a smart
lets go i fixed it
lime stone
pnpm i
median rapids
lmao
mortal fractal
why is ur username T... i thought i was in streamer mode
are you sure
charred monolithBOT
median rapids
vencor url rce wen
median rapids
why is ur username T... i thought i was in streamer mode
idk maybe double check
shell shuttle
IM GOING MENTALLY INSANE
golden gulch
while it's not really urgent or anything, a review/merge of #2388 would be neat as it also addresses some caching things with the new file store - some users are running into issues with discord caching images longer than it should and changes in the PR would resolve it
austere talon
sure ill have a look tomorrow
golden gulch
neat, thanks 
austere talon
(if i dont forget, maybe remind me if i do)
i really need to get like a task organiser or smth
glass jasper
while it's not really urgent or anything, a review/merge of [#2388](https://gith...
@odd heath you need to do this for PronounDB since the new API need too be merged with the it uses now being old
glass jasper
i really need to get like a task organiser or smth
hire me to your personal assistant and it’ll be my duty to remained you
real flower
dumb question
where are core vencord patches (not plugin, just always loaded)
austere talon
dumb question
where are core vencord patches (not plugin, just always loaded)
such as?
real flower
oh that's a good question
austere talon
do you mean the apis and settings and such?
real flower
are there any
uhh
austere talon
real flower
what if we moved this from ScreenSharePicker.tsx
{
find: "x-google-max-bitrate",
replacement: [
{
// eslint-disable-next-line no-useless-escape
match: /"x-google-max-bitrate=".concat\(\i\)/,
replace: '"x-google-max-bitrate=".concat("80_000")'
},
{
match: /;level-asymmetry-allowed=1/,
replace: ";b=AS:800000;level-asymmetry-allowed=1"
}
]
}
to a core vencord plugin
so the 2500kbps bitrate limit wouldn't kill chromium users
i was thinking about other fixes but honestly fixing a ton of streaming issues i feel is out of the scope for vencord
but a small patch to improve them
seems useful
shell shuttle
thats a lot of apis
damn
OH HOLY SHIT
ITS LIKE AN EASTER EGG
it only shows up when i type api
u should make it so when u type Vennie in the plugin search
real flower
it vennies all over the place
shell shuttle
#🎨-css-snippets message this happens
🙏 it would be amazing
i will litearlly find a way to imploment it if it was an accepted idea
glass jasper
we got a lot of API(s)
real flower
```
{
find: "x-google-max-bitrate",
replacement:...
could this cause issues because it wouldn't exist on desktop/firefox?
idk what happens when a core patch fails
austere talon
could this cause issues because it wouldn't exist on desktop/firefox?
you simply mark it as web only
it would warn on firefox
real flower
how 
also uhhh I'd just say wait to merge the pr until next vesktop update cuz you'd have to merge the pr that removes that patch from vesktop too
real flower
you simply mark it as web only
with the folders its just .web but how do it with .ts files (core plugins)
austere talon
.web.ts
rugged spire
yes
austere talon
yes
real flower
oki
rugged spire
do not try to make vesktop register as a desktop client with the gateway
it will explode voice channels i heard
real flower
i will not
i have tested that in the past
who knows maybe one day ill make that a thing
not today though
not today
limber skiff
i was thinking about other fixes but honestly fixing a ton of streaming issues i...
you could make it a plugin
rugged spire
real flower
its discord's problem
real flower
they fixed the 30kbit issue
rugged spire
i fix discord bugs
you should too
real flower
not my fault they haven't fixed their screenshare resolution not applying
id have to do what we did in vesktop
and rewrite like half of their webrtc code
i am nOT doing that again
charred monolithBOT
limber skiff
@real flower do it how web context menus does https://github.com/Vendicated/Vencord/blob/main/src/plugins/webContextMenus.web/index.ts
not a core, and look at the required
limber skiff
but actually you can keep it as required: true
limber skiff
because it's only going to be bundled in web so no need to check for IS_WEB
limber skiff
oh yeah also call it like WebScreenshareTweaks or something
real flower
it's literally fixing a discord bug that makes screenshares unbearable
I don't see how it could be anything other than core
unless I understand incorrectly
limber skiff
there are plugins that fix stuff too
and they are not a core
WebContextMenus is required too and it's not a core
limber skiff
It's just not an extremely core I dont know how to explain
real flower
it's a 1 line patch
limber skiff
ask for vee what's his opinion
limber skiff
it's a 1 line patch
that's why I said call it tweaks and do more stuff too
real flower
there's nothing else to do
limber skiff
these are the core plugins, I dont see that one fitting there
real flower
it's a single fix that changes a lot
limber skiff
i was thinking about other fixes but honestly fixing a ton of streaming issues i...
you said...
real flower
yeah but I also said that would require rewriting like their entire webrtc code
I'm not doing that
real flower
may I ask why
limber skiff
_core plugins are required for the functionality of Vencord
that one is not for Vencord, but a discord thing
real flower
may I ask why
there is no downside, it's just something discord didn't change on web clients out of pure forgetfulness
real flower
_core plugins are required for the functionality of **Vencord**
ahh that I understand
still I don't see why not required
sorry btw I'm not trying to argue, just curious
limber skiff
I dont mind it not being required, just dont like it being a core, but lets see what vee says
austere talon
may I ask why
because it is not required for vencord to function
we try to keep the default vencord experience as vanilla as possible so unless something is absolutely required it should be toggleable
real flower
ahhhhh
austere talon
enabledByDefault is basically the same as required
cause no sane person is gonna disable it
austere talon
but leaves the user the option to turn it off if they still want to
real flower
I'll fix that tmrw
austere talon
some users may want to cause they think it's risky or whatever
limber skiff
that's true almost no one prob has crash handler disabled
austere talon
some people even want notrack to be disableable
real flower
wtf
austere talon
which i think i might make parts of it possible to turn off
limber skiff
this one is the only I can see a reason for turning off
austere talon
the reason it's required is to disable crash reporting so discord doesn't get vencord error logs in their error tracking
but the analytics stuff can be on
some insane people might want it
limber skiff
do you want me to just make an option to keep the science stuff
should I change anything?
prob better if I screenshot haha
limber skiff
I wouldnt be against doing it myself
limber skiff
aight
rugged spire
lost smelt
who in the right mind gonna *turn back on* analytics
nobody
but the option is there ig
rugged spire
hey everyone, you should go to the app directory, open the page for any app, and right click any link
must have ImageZoom plugin enabled
rugged spire
so uh, uh yeah uhhhhh
it uh does this shit in there
discord devs don't reuse unrelated context menus for random shit (failed)
charred monolithBOT
charred monolithBOT
austere talon
shell shuttle
rugged spire
FINALLY
Thank you @austere talon for this
I will admit I wanted this feature forever ago
austere talon
lmao
shell shuttle
I will admit I wanted this feature forever ago
what feature
austere talon
I will admit I wanted this feature forever ago
what exactly
shell shuttle
i don't get it
rugged spire
click contributor badge to see what plugins they made
crude raptor
oh that does sound nice
rugged spire
I have never seen this modal before
and
it's popping up
because local is ahead of remote
oh
and also i didnt build it
i am stupid
austere talon
rugged spire
@austere talon is there any reason that clicking on the profile name in that menu doesn't open the actual profile on discord?
is that by design?
austere talon
we had the pfps open profiles before
but people kept dming for support
thats why i made these pages that show ur github and website and plugins
so you still get attribution without people annoying u
shell shuttle
I have never seen this modal before
cool as FUCK modal
rugged spire
we had the pfps open profiles before
honestly I am not even surprised to learn that the feature existed far before I become a contributor and got removed because stupid people
maybe it could be reimplemented with a check to see if you are also a dev
rugged spire
vee
austere talon
hmm
austere talon
its literally top right
rugged spire
no
austere talon
oh do u mean the vencord github
rugged spire
yes
austere talon
should i just make "contributed" a hyperlink
austere talon
not possible
shell shuttle
PRs to their commits?
rugged spire
not possible
what are you talking about
austere talon
not possible
we dont know the github people used to contribute
github and website are pulled from your profile connections
if you dont have them linked they wont show in the modal
rugged spire
is that too unreliable?
austere talon
theres no guarantee that you have it linked or that you have the right one linked
shell shuttle
ohhhh
rugged spire
Oh?
@austere talon have you considered using github API to check if the linked github account has commits in the repo
is that even a possibility?
shell shuttle
ooooh
charred monolithBOT
austere talon
jumpscare
rugged spire
How was this never a feature until now?
Should 0/1 snippet[s] be pluralised or not
That is 0 out of 1 btw
austere talon
what
charred monolithBOT
austere talon
how tf did this code ever work before
it used proxied components
first commit vencord https://github.com/Vendicated/Vencord/tree/af498e78291b67377aaf876c84143cdfe7c8b308
shell shuttle
woaw
glass jasper
this shouldn’t break my pr showbadgesinchat, i mean pull contributor info from @utils/misc, we really only touch the donor badges stuff, and even then that’s pulled from the plugins/_api/badges.tsx unless i’m being an idiot and some how those work together.
idk what i’m thinking i need a little while i just woke up
odd heath
how tf did this code ever work before
I have no idea but it did lmfao
It confused me so much because it behaved differently from the other finds
shell shuttle
woah
odd heath
Jumpscare
austere talon
actually
remmeber we have different stages of plugin start
like Init, WebpackReady, etc
does using Init break flux stuff?
limber skiff
how would it?
hmm you mean because it calls startPlugin in init
I think so
have to test but probably yeah
glass jasper
close jumpscare
glass jasper
based
limber skiff
see if that works
austere talon
they deleted their fork :o
@cunning canyon what happened 😭
limber skiff
lol vee
austere talon
huh
topaz thistle
When you still get prompted to enable 1 Million Analytics when installing Windows Pro N
Fuck you Microsoft
limber skiff
el lint is failing
topaz thistle
el lint is failing
el lint 🌮
limber skiff
the only reason that existed was to not subscribe if we already did when flux was ready
but now we dont try to subscribe if flux was not ready
austere talon
OH MY GOD @limber skiff
wanna know why lint exploded
i didnt fucking save a file
so it didnt give me errors locally cause vscode was using the unsaved file
real flower
vscode autosave:
odd heath
i didnt fucking save a file
auotsave 
austere talon
i didnt fucking save a file
@limber skiff can u make this fix in ur pr
glass jasper
auotsave <:venniepopcorn:1217924409885724682>
vscode doesn’t autosave, don’t listen to the eastern propaganda these two spread
odd heath
vscode doesn’t autosave, don’t listen to the eastern propaganda these two spread
mf theres literally a setting for it
glass jasper
mf theres literally a setting for it
Nuh uh
(i like spreading false information on the Internet)
woeful sable
Real
odd heath
Nuh uh
*(i like spreading false information on the Internet)*
im exploding you
real flower
does my pr look better now?
i tried to toss it in its own plugin
@austere talon 
golden gulch
idk when vee sleeps but I guess it is kinda technically tomorrow?? so just a small reminder about the usrbg pr 
lime stone
oops
verbal pumice
jumpscare
limber skiff
<@235834946571337729> can u make this fix in ur pr
done
austere talon
nice
topaz thistle
VSCode taking 19GB Ram Challange
spark pivot
Least obvious devilbro alt
verbal pumice
ty
woeful sable
Epic
limber skiff
it's fixed already 😞
spark pivot
fix(RCE)
topaz thistle
VSCode taking 19GB Ram Challange
Who would've guessed it was an official ms extension
nvm the extension host has a massive memory leak
real flower
nvm the extension host has a massive memory leak
oh god what
topaz thistle
narrowed it down to some plugin
Not sure which one tho
doesn't show up in the extension host funnily
real flower
vencord companion:
that would be really funny
@turbid hatch i dont mean to bother, just curious cuz i dont know much about how flathub works
what does it take for flathub to update to 1.5.2, as i see the repo is already updated
turbid hatch
they have a grace period before its deployed for everyone
2 or so hours
so you can fix any bugs that show up
and then it takes time for it to be reviewed and approved
real flower
ahhhhhhhhh
turbid hatch
the build was delayed so
real flower
yeah
i saw that but i assumed it was finished by now
that makes sense tho
thanks :3
turbid hatch
yeah it should be, i think its just in that review period thing
real flower
mhm
rugged spire
It's the fucking gradle extension
it even has the audacity to ASK FOR MORE RAM
topaz thistle
Lmao this PR was a shitshow
rugged spire
Lmao this PR was a shitshow
Idk how anyone can read that and think "this isn't a hack at all"
topaz thistle
Yeah idk either
Just patch properly
Like everyone does
Def not dumb to hook into every regex call
and then also have prototype pollution
limber skiff
lmao it's fine
limber skiff
in case it does explode our console will stay way more clean
limber skiff
yeah kinda
it's more of a change to make things look better in case it finds
it's not useful to get spammed a billion errors because grabbing the wreq failed and our patches are trying to do finds
austere talon
but this will make settings not patch
when settings could potentially still work
i dont think its good to have
limber skiff
right
austere talon
maybe in IS_DEV
limber skiff
alright I will change it
austere talon
well settings ui would still depend on webpack but if the ui fails it gets caught by ErrorBoundary
which is deliberately vanilla no webpack modules
and that has the update prompt
limber skiff
yop
austere talon
welll
actually
that still needs React which would also fail
well anyway just do it dev only imo
seems better
limber skiff
that still needs React which would also fail
haha lmao
limber skiff
also true
limber skiff
I see
austere talon
if ts is crying, just do
callback = function (this: unknown) {
in case webpack does set the this
austere talon
it probably wouldnt but
limber skiff
nah it's not crying I just wanted to know
austere talon
at that point just
originalOnChunksLoaded.apply(this, arguments)
make sure callback syncs to arguments tho
behaviour is a bit weird sometimes
limber skiff
but are you sure this will be the obj
hmm it will be I need to bind our patched function too then
austere talon
wdym
u dont have to bind
if u monkey patch something with a function then the this will be correct
limber skiff
are you sure those will be the same
this is how we set the monkey patched function
limber skiff
we love this
charred monolithBOT
austere talon
anyway you could also
.apply(wreq, arguments)
or just keep it
its fine the way it is
limber skiff
interesting
austere talon
i mean it makes sense
this is always the object the method is called on
CURSED
AAAAAH JS WHY
limber skiff
ok yeah it works
limber skiff
now this should not break anything for sure
limber skiff
you mean these?
austere talon
i meant the this stuff xd
austere talon
are u done
limber skiff
yeah let me just make sure the toString works
charred monolithBOT
limber skiff
easier like this :)
limber skiff
it's the time I finally brick vencord
did you see my super cursed stuff on the reporter code
the way I see if we finished loading everything
charred monolithBOT
please fix the filename casing. it should be camelCase!
tell that to wikisearch
limber skiff
@austere talon should we delete these branches with closed prs?
maybe not telemetry
austere talon
nah keep them
shell shuttle
nah keep them
genuien question why do some repositories have 200 branches but 90% of them are like "behind 9,394 commits"
austere talon
wait whats this
limber skiff
waitFor finds
(I need a better name for that)
I was waiting for webpack refactor to get merged to work more on it
and now it has a billion conflicts
real flower
genuien question why do some repositories have 200 branches but 90% of them are ...
at least for me, i just make a new branch for every new major pr(for my vencord/vesktop forks)
so some of them are way behind
lmao
shell shuttle
at least for me, i just make a new branch for every new major pr(for my vencord/...
same
i need branches for every individual feature when working on vencord stuff
rugged spire
i need branches for every individual feature when working on vencord stuff
some people should learn to do this tbh
rugged spire
genuien question why do some repositories have 200 branches but 90% of them are ...
me and my 400 commit ahead of upstream would like to talk
shell shuttle
rugged spire
shell shuttle
DAMN
real flower
what the hell are you working on
rugged spire
custom fork of channeltabs
limber skiff
help idk how to fix this
golden gulch
those are good questions and the answer is that I went through a few different response formats while working out how I wanted the shape of the API to be and was testing it alongside the vencord plugin will add a commit to clean up that stuff now
alright all resolved
gonna clean up one or two more things now too that I've just noticed
limber skiff
finally
charred monolithBOT
limber skiff
wait for real?
shell shuttle
bro discord staff praised me for merging vencord prs best moment of my life
acutally??!?!!?
lime stone
inadventently i assume
austere talon
wait for real?
lmao it was an event in the discord admins server where we did intervals of 15min "work sessions" where we all set goals and then after talked about our succcess
i mentioned it without mentioning what the prs are for xd
limber skiff
lmao it was an event in the discord admins server where we did intervals of 15mi...
haha lmaoooo
rugged spire
does discord not have some kind of Vencord / BetterDiscord staff badge for peopl...
The people who know will know
austere talon
tbh that staff was really sweet
shell shuttle
does discord not have some kind of Vencord / BetterDiscord staff badge for peopl...
huh
austere talon
does discord not have some kind of Vencord / BetterDiscord staff badge for peopl...
look at the member list in that stage 😭 https://media.discordapp.net/attachments/1015060231060983891/1235725894103072779/image.png?ex=66356aeb&is=6634196b&hm=46acd06fe61f37dc5cbd32741b122d57345b164f4728a286536fd0baa4996c9b&=&format=webp&quality=lossless&width=1168&height=657
lime stone
was joke
limber skiff
yooo drop the app
austere talon
look at the member list in that stage 😭 https://media.discordapp.net/attachmen...
50% are clientmodders / dataminers
rugged spire
50% are clientmodders / dataminers
real
lime stone
50% are clientmodders / dataminers
and dziurwa and bignutty are actually discord staff in secret
golden gulch
oki v I'm done with the very minor changes thankies for review
lime stone
have server with >= 1k members & >= 60% retention
median rapids
ew
golden gulch
v will give the janitors manage server and we will all join the admins server
shell shuttle
im watching a cyberpunk iceberg
median rapids
v will give me manage server (i will steal your vanity)
long heart
v will give me manage server (i will steal your vanity)
realest Dolfies message
lime stone
discord.sex >
limber skiff
this is why I made this function accept the flux as argument vee
:)
preparing for my own shit
also I think this is pretty cool
austere talon
v will give the janitors manage server and we will all join the admins server
(its not even via this server)
this server doesnt have enough retention
golden gulch
sad day
rugged spire
(its not even via this server)
Wait what
lime stone
who trusts vee
golden gulch
going through my hundreds of servers to see if there's some random one I have manage server in and meets the requirements
lime stone
i will become admin in roblox community
lime stone
going through my hundreds of servers to see if there's some random one I have ma...
do you just get given manage server randomly lol
i will choose a cuter avatar
golden gulch
there was a time when that was the case yes xP
golden gulch
I used to help out with a fairly big event organization group that helped set up smaller groups a lot