#👾-core-development

1 messages · Page 176 of 1

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
sterile oak
#

what else someone would do? make a useful plugin? good thing you are not serious /j

crude hearth
#

Guys I am Vencord Contributor and developer!!!!!

subtle leaf
charred monolithBOT
charred monolithBOT
still wasp
#

There should be a prompt like the outdated prompt for if you're on a dev build when you enter support

charred monolithBOT
crude hearth
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
#
TomH5634142b7
[Vendicated/Vencord] New comment on pull request #1548: New Plugin: Platform Emulator

I'm worried about the safety of people's accounts when using this. There's also not much reason to want to spoof your platform

I don't think this is a good plugin to have

Thanks anyway!

Please reconsider this, I've been using the more recent PlatformSpoofer pull request for a week and my account is still good.
Some people may wanna appear online but on mobile instead of desktop to avoid the "I see you online, play [so and so]" messages, or when using custom clients that us...

charred monolithBOT
austere talon
#

faking ur platform instead of just saying "sorry i dont feel like playing rn"

odd heath
#

They should be glad that they even get asked that ngl

tepid knoll
#

true

magic agate
#

boundaries are hard when your friends are in cluster B

#

learning boundaries is a better solution tho, it's true

charred monolithBOT
jagged cloak
#

true

#

though i've done that no prob i don't need to fake being on phone

IMG_0762.png IMG_0761.png
charred monolithBOT
charred monolithBOT
crude hearth
#

merge my pr

charred monolithBOT
glass jasper
charred monolithBOT
glass jasper
subtle leaf
#

fr

opaque silo
odd heath
charred monolithBOT
charred monolithBOT
odd heath
#

discord broke friendssince on canary partially

#

very rude

#

nvm they broke it fully

austere talon
#

could you limit that to some length instead of .*

odd heath
#

sure

#

is done

median rapids
#

‼️ very important announcement ‼️

#

everyone wish my pr a happy birthday blobcatcozy

shy veldt
#

happy birthday

charred monolithBOT
odd heath
odd heath
austere talon
charred monolithBOT
charred monolithBOT
median rapids
charred monolithBOT
long stream
#

cant wait to wish it happy birthday next year

median rapids
#

so real

charred monolithBOT
#
kvbaxi
[Vendicated/Vencord] Pull request opened: #2371 feat(GifPaste): Option to apply plugin behavior to commands (/tenor and /gif).

Small feature suggested in https://github.com/Vendicated/Vencord/issues/2190 that gives you an option to apply the same behavior to the commands /tenor and /gif
Vesktop_Kd1rK0N3lY

For people liking the old behavior of instantly sending GIF with command there's a new option in plugin settings which allows you to toggle on/off said change.
![image](https://github.com/Vendicated/Vencord/as...

#
gonsodany
[Vendicated/Vencord] New comment on pull request #2369: fix ValidUser

so was this merged or not? and does this fix it? because im almost pretty sure discord added some kind of privacy block (the same say you can see channels you dont have access to) now you cant see users you've never interacted with, whenever you used to see numbers, now you'll be blocked from seeing the user profile all together, which is raally stupid, essentially made the userid useless for everyone who actually used it. I might be wrong tho (hopefully)

charred monolithBOT
frail skyBOT
#
Bad Patches

ValidUser (had no effect):
ID: 878611
Match: /react(?=\(\i,\i,\i\).{0,50}return null==\i\?\(0,\i\.jsx\)\((\i\.\i),.+?jsx\)\((\i\.\i),\{className:"mention")/

RoleColorEverywhere (found no module):
ID: -
Match: CLYDE_AI_MENTION_COLOR:null,

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

ValidUser (had no effect):
ID: 878611
Match: /react(?=\(\i,\i,\i\).{0,50}return null==\i\?\(0,\i\.jsx\)\((\i\.\i),.+?jsx\)\((\i\.\i),\{className:"mention")/

RoleColorEverywhere (found no module):
ID: -
Match: CLYDE_AI_MENTION_COLOR:null,

Bad Webpack Finds

findByProps("memberSinceContainer")

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
shell shuttle
#

sorry chat i got a lil too silly

#

do not mind that

#

also for the record i'm kidding

sterile oak
glass jasper
charred monolithBOT
#
gonsodany
[Vendicated/Vencord] New comment on pull request #2369: fix ValidUser

what a useless fucking "security" feature, anyone that used the userid to be able to check people by their ids cant do that anymore, its so fucking anoying, i tested with an account, i mentioned them with the <@id> thing, for my friend they could click the profile, but for me it said "unknown user" and i was locked out of their profile, even tho we had 9 servers in common mind you.

I had to go to one of the servers we have in common, search for them and then click on their profile, after d...

jagged cloak
#

oh L

woeful sable
glass jasper
gritty iris
#

Agreed

woeful sable
crude hearth
charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New comment on pull request #2369: fix ValidUser

what even is this rant. discord changed absolutely nothing, other than changing the display of mentions of uncached users from @river scroll -> @unknown-user

For the average Discord user who doesn't know what a user id is or how to use them, this is objectively more user friendly. Not to mention that this makes it more consistent with role or channel mentions, which have always rendered as @deleted-role and #unknown-channel

This plugin still works exactly the same way, it just n...

thick kestrel
#

can I refer people to a theme in the README of a plugin? talking about IrcColors, it was specifically made to complement Compact++, though it can be used separately

#

I am planning to refer to Vencord and the plugin in the README of the theme, just not sure if I can do the reverse

austere talon
#

wait is irc colors merged yet or no

#

I don't remember

thick kestrel
#

it's not

austere talon
#

hard to keep track

#

oki ill merge soon

#

it's pretty cool

thick kestrel
#

I need to add the README first lol

austere talon
#

oh right

thick kestrel
#

you marked it as draft because of that

austere talon
#

did i tell you to add one?

thick kestrel
#

yes

austere talon
#

oooooohhhh

#

okay i see

thick kestrel
#

as I am writing the README now

austere talon
#

well it doesn't need the theme to be usable does it?

you can add it as a suggestion sure

thick kestrel
#

yeah that's what I meant

#

it sure can be used on it's own

austere talon
thick kestrel
#

yeah I get why you'd do it lol

austere talon
#

this is like a full time job at this point

#

maybe i should rework the contributing file and add a disclaimer that prs might be slow just so people don't get upset if i don't attend to their pr timely

#

i do feel bad if prs are in limbo for a long time but it's hard to keep track of everything because there are just so many things going on, and i often struggle with motivation to review things because it's honestly not very exciting

thick kestrel
#

have you thought about getting a comaintainer?

#

most bigger OSS projects have multiple maintainers exactly because of maintainer strain

austere talon
#

there are! multiple

but i think they're more busy than me, it's mostly me doing review

thick kestrel
#

oh, lol

#

I should've checked the org tbh

#

I was sure it's just you

austere talon
#

it's hard adding new collaborators because not many people are too familiar with the project

thick kestrel
#

makes sense

austere talon
#

also this job is unpaid so there's not that much incentive to doing it

#

code review is not a very fun activity, it's much more fun to write code yourself xd

austere talon
#

but it's not a lot cause i myself don't have a lot

thick kestrel
#

I mean, if it's hard for someone working on fucking xz to get paid for their work, I imagine working on a Discord client would be worse lol

#

though it seems like there's a decent amount of donors, I assume most of them are one time

#

maybe you could encourage smaller, but recurring donations more...?

#

idk

#

I haven't worked on a "proper" FOSS project myself so all I know is second-hand knowledge

austere talon
#

oh yeah i do have a lot of sponsors and i appreciate it a lot. but most of them are 1-5$ so it doesn't add up to that much. it's way below minimum wage / minimum money required for living in my country

i distribute 10% of it to other contributors (would love to do more but can't rn sadly)
more than half of it goes away for my rent

doesn't mean that i don't appreciate every single sponsor, no i really do, it's already amazing that so many people love what i'm doing that they choose to donate and im really happy about that

but yeah it's sadly not liveable

#

but so is the fate of free/libre software tomatopray

#

unless you get lucky and make something that many companies use and somehow get these greedy bastards to sponsor you

#

but vencord has never been about money, i do it out of passion. even if i got 0 donations I would still do it

#

im currently looking for a job, and we might look into trying to get ads on vencord.dev again (we already tried in the past but google rejected us)

thick kestrel
thick kestrel
austere talon
#

nah, you get the role even for 1 time sponsor

thick kestrel
#

I think this is outdated then :P

image.png
austere talon
thick kestrel
#

yeah FOSS is extremely underfunded

austere talon
#

companies are abusing libre software for their gain without giving anything back

thick kestrel
#

which is such a shame

austere talon
#

we need to amend our licenses to add a statement that if your company earns more than a million a year you need to give back >1% of your income to the floss projects you depend on

#

🦔

odd heath
#

Because that still says <@id>

austere talon
#

oh yeah ofc

thick kestrel
#

I mean that does violate the "right to use for any purpose"
though the idea of a "FOSS tax" (hey, EU, you already recognize the value of free software, what if...? :)))) is definitely an interesting one

#

tbh the xz incident sounds like something that might change the perception of FOSS in the eyes of the corps

austere talon
#

i think such a statement would not make it non-free

#

because you don't add any restrictions on who can use it

#

it would be non-free if you said "any company above 1 million$ income may not use this software"

#

but requiring payment is okay

thick kestrel
austere talon
#

it just doesn't make a lot of sense because anyone who purchases it can distribute it without payment

thick kestrel
#

I mean, you can do proprietary builds if you have a CLA or a permissive license

#

Ardour is a good example

austere talon
#

ive seen some projects do this dual licensing scheme where open source projects may use it under a free software license, while proprietary ones must purchase a proprietary license

thick kestrel
#

Qt

austere talon
#

gpl / commercial dual license

#

it's a decent scheme but the only way to properly achieve that is using copyleft like gpl

#

if you want permissive you can't really do it

thick kestrel
#

yeah permissive is... permissive

austere talon
thick kestrel
#

unique, or "simply" of very high quality

#

Qt is certainly not unique in terms of being a UI toolkit

#

but a lot of companies buy their commercial licenses anyways, you can find Qt in the most random places

#

though you can say it being high quality is the unique thing about it

austere talon
#

there's not really competition to QT

#

there are not many good cross platform ui frameworks

#

QT, GTK (kinda looks out of place on non windows), WebUI, Java Swing, really what else is there

woeful sable
#

apologies I didn't realize this was core development

austere talon
#

tbf we're also off topic rn snailcat

woeful sable
thick kestrel
#

unrelated, but how is this "assets" thing done on GitHub

obraz.png
#

because I see it's not in the Git repo itself

#

or at least doesn't appear to be

crude hearth
#

Unless you are sindirhous and publish 9000 garbage npm packages you end up poor sadJoe

austere talon
#

it makes a github cdn link

#

we don't upload the files to the repo so it doesn't explode in size

topaz spoke
#

because from my knowing the files don't expire in 1 day

#

like files uploaded to discord do

crude hearth
topaz spoke
#

or am I being an idiot

crude hearth
#

I mean they are using it

#

so it can be done

#

I think you can also upload in readmes

#

probably api is pretty easy to reverse blobcatcozy

#

I put random numbers to bucket id blobcatcozy

#

why do they keep source maps trolldayruined

image.png
topaz spoke
charred monolithBOT
#
gonsodany
[Vendicated/Vencord] New comment on pull request #2369: fix ValidUser

what even is this rant. discord changed absolutely nothing, other than changing the display of mentions of uncached users from @river scroll -> @unknown-user

For the average Discord user who doesn't know what a user id is or how to use them, this is objectively more user friendly. Not to mention that this makes it more consistent with role or channel mentions, which have always rendered as @deleted-role and #unknown-channel

This plugin still works exactly the same way,...

austere talon
#

they have source maps for the floss libraries

#

I think

charred monolithBOT
austere talon
#

btw @odd heath i recommend changing github username

#

cause it shows like this so i almost called u ed again by accident AyamePeek

image.png
#

it will redirect all repos so its not a big deal

#

just make an organisation called EdVraz so people cant steal ur old name and hijack old repo links

#

did someone fix RCE

#

no right?

topaz spoke
austere talon
#

RoleColorEverywhere

topaz spoke
#

remote code execution?

austere talon
#

nuh uh

topaz spoke
#

what do you mean by RCE then?

#

nvm

#

I'm dumb

charred monolithBOT
austere talon
#

btw your ValidUser fix doesnt work for the new unknown-user mentions

#

well makes sense

image.png
charred monolithBOT
odd heath
charred monolithBOT
austere talon
#

trollage

image.png
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

findByProps("memberSinceContainer")

Bad Starts

None

Discord Errors

None

austere talon
#

rip to a real one

#

oh its friends since

#

unreal

image.png
#

memberSinceContainer -> memberSinceWrapper

crude hearth
#

I THOUGHT VENCORD HAD A REMOTE CODE EXECUTION

topaz spoke
odd heath
austere talon
#

guh they changed it so much

image.png image.png
#

discord be like yeah lets change this entire layout for no reason

topaz spoke
austere talon
#

lmao i love discord devs

odd heath
austere talon
#

whats ur fix

#

is it compatible with both stable and canary

odd heath
odd heath
#

Works fine

austere talon
#

well

#

we can make it compatible

odd heath
#

How

charred monolithBOT
austere talon
#

meow

#

we need makeLazyWebpack

charred monolithBOT
austere talon
#

maybe we could add this as a dedicated webpack function

charred monolithBOT
odd heath
#

Does that even work

austere talon
#

why wouldn't it

odd heath
#

Bcs the findbypropslazy returned multiple things :3

#

Idrk how those things work

charred monolithBOT
charred monolithBOT
topaz spoke
#

I'm trying to make changes to the updater, so you can look at the commits with an in app modal, but it's not doing anything if I click on the commit hash, not even throwing an error.

Corresponding files are attached

📎 UpdaterTab.tsx 📎 CommitModal.tsx
austere talon
#

what

#

what would it look like

#

do u mean show like diff

topaz spoke
#

you have an update availiable, click on the commit hash

then a modal should open with the commiter name, file changes and stuff

image.png
topaz spoke
#
  • other info
#

but nothing happens at all, not even errors

austere talon
#

eh whats the point

#

u can just open in browser

topaz spoke
#

I want to integrate it into vencord

#

faster 💨

prime dew
#

VencordOS soon™️

charred monolithBOT
charred monolithBOT
charred monolithBOT
odd heath
#

Next pr to have a birthday soon

austere talon
#

at this point just make AlienHacks plugin

#

AlienCord

rugged spire
median rapids
austere talon
#

me too

charred monolithBOT
subtle leaf
charred monolithBOT
odd heath
#

I wonder if my pronoundb pr will get merged before they cut off the api trolley

charred monolithBOT
shell shuttle
median rapids
rugged spire
median rapids
#

not another pr fear

lime stone
#

consoles hortcuts

median rapids
#

torture

rugged spire
#

friend invite plugin is a victim of this

median rapids
#

yeah

austere talon
topaz spoke
median rapids
#

i'm too used to them

austere talon
#

:nerdlien:

median rapids
#

:(

#

GREEN HEART

#

you're so real for that

#

💚

austere talon
median rapids
#

in the swc times i had the last pre-swc build locally so i could match enums

#

at least those are back now

austere talon
#

i didnt bother

median rapids
#

scary

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
odd heath
#

spam

shell shuttle
median rapids
#

huh

charred monolithBOT
#
Tr0llie
[Vendicated/Vencord] New comment on pull request #2370: Add HideServers

how do i still view hidden servers?

as mentioned maybe there could be a button in which lets you view all the server that you have hidden but there could be Ui issue if you try to view it from devices that does not have vencord installed.
there could be errors such as the servers being messy etc
this could be fixed by putting the servers in a separated folders when a user hides a channel
and the button will also let you view all the server that u've hidden but just in a better ui and...

charred monolithBOT
charred monolithBOT
sterile oak
#

this is the second time I ask about the addPreSendListener is there a reason it's not working in vesktop?

#

when I test it in web its all good

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
rugged spire
#

how would this work

#

you're not the first person to suggest this

#

but

#

95% of vencord users are users who use a stupid operating system "Microsoft Windows" that doesn't come with basic system utilities like git and node and npm and pnpm

#

do not assume those are installed

charred monolithBOT
crude hearth
#

thats actually amazing

rugged spire
#

true

#

nodejs is not essential system package

crude hearth
#

git isnt really either

rugged spire
#

doubt

#

well

#

it isnt

crude hearth
#

unless you are setting up full installion git doesnt come preinstalled with linux distros

#

I think even vanilla arch doesnt come with it

rugged spire
#

but it is so useful that i would consider it required in any sane system

crude hearth
#

meh not everyone are developers

#

or people that build packages

rugged spire
tepid knoll
rugged spire
tepid knoll
#

i see

#

still it should be possible client mods have done it before

#

shouldnt require node or git to be able to install third party stuff if there was a built in installer if done right

charred monolithBOT
charred monolithBOT
austere talon
#

no

#

already had a working prototype ages ago but I scratched the idea

#

it's just not what I envisioned for vencord

#

there are already multiple other options that offer dynamic plugin installs

#

it would tremendously worsen support and user experience

rugged spire
#

if people use a regular dev build (which the count of those people will go down due to this) then just offer a warning instead

#

or maybe just

#

dont

#

because i do also understand

#

that you cant fight stupid idiots

austere talon
#

the idea has already been outruled

rugged spire
#

real

#

@austere talon how do you feel about better documentation instead

austere talon
#

instead of what

rugged spire
#

if you want to respond with "please stop being too kind to #🏥-vencord-support-🏥 users it is not worth your time making docs better for them" then do just say so

rugged spire
#

aka "how to use src/userplugins"
what a \i is for in regexes

#

OH

#

idea

#

so

#

i was looking at the git autoupdater

#

should I rewrite it to attempt to merge upstream changes into a branch?

charred monolithBOT
rugged spire
#

well

#

they uh deleted their account

subtle leaf
charred monolithBOT
long stream
#

i thought they completely removed it

charred monolithBOT
rancid dragon
#

target audience

charred monolithBOT
median rapids
#

it's never getting completely removed

#

but I also doubt they ever roll it out to non-community servers now

charred monolithBOT
rugged spire
median rapids
#

tbf there's not many downsides to turning on community

charred monolithBOT
austere talon
median rapids
#

true

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
#
Sqaaakoi
[Vendicated/Vencord] New comment on pull request #2375: feat(ShowTimeouts): Also show invites disabled tooltip

Is "ShowHiddenThings" descriptive enough? There's a lot of plugins that "show hidden things" in Vencord, and this could quickly get confusing

Also, I had previously worked on a concept extending this plugin (show a detailed timer on hovering over the timeout icon) that would be more appropriate to keep the name as ShowTimeouts. Unfortunately I gave up on it (due to react not wanting to remove stuff after the channel was unloaded). Would such an idea be best reborn as its own plugin?

#
Sqaaakoi
[Vendicated/Vencord] New comment on pull request #2370: Add HideServers

I don't really know where the UI for removing individual servers should be. I could cram it all into a settings component, but no other plugin seems to do that.

I would have a button at the bottom of the server list that opens a modal to all the servers you've hidden

I implemented a horrible hack to do something similar in pure CSS and using folder names starting with . (before they did some class rerolls and it broke and I never updated it)
I just showed those folders when the...

charred monolithBOT
#
dolfies
[Vendicated/Vencord] New comment on pull request #2375: feat(ShowTimeouts): Also show invites disabled tooltip

Is "ShowHiddenThings" descriptive enough? There's a lot of plugins that "show hidden things" in Vencord, and this could quickly get confusing

Pretty sure only other similar one is ShowHiddenChannels. I guess they could maybe be merged but this seems a little different. Something like ShowModActions could work, though maybe this extends beyond just mod stuff at some point?

Also, I had previously worked on a concept extending this plugin (show a detailed timer on hovering over the ...

median rapids
#

oh right ig the plugin would be disabled for everyone

#

@austere talon is there a built in magic way for fixing that

rugged spire
#

migratePluginSettings

austere talon
#

horror

IMG_20240422_013836.jpg
#

@dapper tiger help

median rapids
austere talon
#

I had the genius idea to review prs on my laptop in bed

#

but i forgot I haven't updated this fucker in half a year

median rapids
#

go to sleep bestie

rugged spire
austere talon
dapper tiger
median rapids
dapper tiger
#

@median rapids hii

median rapids
#

hii

rugged spire
median rapids
#

real

rugged spire
#

commit right from the browser

#

suffer while doing so

austere talon
#

terrifying

median rapids
#

horror

austere talon
#

uh

#

reasons

#

mad?

median rapids
#

yeah

austere talon
median rapids
#

:(

rugged spire
#

lmao

#

(across many many many many apps)

median rapids
#

nop

#

those are not electron installs

#

smh

charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New review comment on pull request #1324: New Plugin: BetterSessions

this is not really how you're supposed to use react. Instead of plain functions, you should prefer Components. Instead of pushing to an array in if statements, you should just conditionally render jsx. For example, this function would be better written as

return (
	<>
		<span>{name}</span>
		<RenameButton session={session} state={state} />

		{(savedSession == null || savedSession.isNew) && (
			<div ...>NEW</div>
		)}
	</>
);
austere talon
#

jumpscare

charred monolithBOT
austere talon
#

@median rapids inb4 github randomly nukes that issue thread cause we use it as cdn meowlien

median rapids
austere talon
#

cdn or nuking?

median rapids
#

an issue thread for images

austere talon
#

yea true

#

anyway yeah for the rename

# 
migratePluginSettings("NewName", "OldName1", "OldName2");
export default definePlugin({
#

thats it

#

and we remove it after some months

median rapids
#

oh oke

austere talon
#

when r they gonna fix goofy ahh embeds

#

triple octocat combo

median rapids
#

should i rename it to ShowModElements or something

#

that's even more ambiguous imo

#

cuz wtf is a mod element

#

at least a hidden thing is obv a hidden thing

#

wonder if there's any other hidden things i could show

austere talon
#

😭

#

naming shit is haaard bro

median rapids
#

yeahhhh

#

i'm tempted to do ShowThingsDiscordStaffDoesNotWantNonModeratorsToSeeButReallyTheresNothingPreventingYouFromSeeingItSoHereYouGoLmao

austere talon
#

broo

median rapids
#

but that would probably break a few ui elements

austere talon
#

shared braincell i swear

#

YEAH HAHA

#

i did it once for the funny

median rapids
austere talon
#

it fucks up the settings menu

austere talon
median rapids
#

mineeee

#

humancell blobcatcozy

austere talon
#

bro got only aliencells

#

no wonder he aliening all the time

median rapids
#

she alien on my cell till i alieningwebp

mortal fractal
austere talon
#

doesnt bother me blobcatcozy

#

true vencord users have at least 10 chatbar icons

mortal fractal
#

horrible

median rapids
mortal fractal
#

horror

median rapids
#

also i got plenty of horizontal space lol

#

the only one i'd want to hide is the gift one anyway

charred monolithBOT
rugged spire
limber skiff
#

lets see how plugins are going

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
#
JohnyTheCarrot
[Vendicated/Vencord] New comment on pull request #2290: new plugin: AutomodContext

An addition that could be neat for this plugin is injecting the automodded message into the message cache similar to how messagelogger does with deleted messages - that way it's possible to see the message actually in context rather than just seeing messages around the same time.

I'm gonna be honest I struggled to implement this and I feel like I may be too unskilled/new with client modding to do so at this time.

odd heath
charred monolithBOT
charred monolithBOT
charred monolithBOT
median rapids
odd heath
#

yeah by @rugged spire iirc?

#

but i think it fits well into it

charred monolithBOT
charred monolithBOT
shell shuttle
#

maybe i said that before

#

idk

#

i have shit memory

charred monolithBOT
jagged cloak
#

lmao every time RCE is mentioned like that i have to think (i do not usually)

crude raptor
#

oh LMFAO that took it a second

#

it likes that plugin

rugged spire
charred monolithBOT
charred monolithBOT
odd heath
#

Gays we should all go and write bump on all our open prs that'd be fun

#

/j

charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New review comment on pull request #1324: New Plugin: BetterSessions

if any of your renderX() functions error, it will likely crash discord

to prevent that from happening, you should wrap any components that have the potential to error (anything that relies on some discord module that might change / break. e.g. if your component just renders a plain div, thats safe) in an ErrorBoundary:

renderName: ErorrBoundary.wrap(({ session }: SessionInfo) => {
}),

this will catch any erorrs in your component and by default instead render a red error car...

median rapids
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
charred monolithBOT
subtle leaf
sterile oak
#

dam, I been trolled by an "about me"

charred monolithBOT
charred monolithBOT
#
FairwellNoob
[Vendicated/Vencord] Issue opened: #2379 [Bug] MemberCount online member incorrectly calcuated

Discord Account

fairwellnoob

What happens when the bug or crash occurs?

The members online in the channel is 0

What is the expected behaviour?

The members online in the channel should be listed correctly (in this case, it should be 5 online)

How do you recreate this bug or crash?

I have honestly no idea. Some servers have this, some don't. I've tried creating a forum channel in my own server while it was community, disabling community, going back into the forum channel,...

charred monolithBOT
subtle leaf
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
subtle leaf
#

HUH i just changed default branch on my fork 😭 whar

#

next time i'm not touching anything

charred monolithBOT
subtle leaf
#

omg

charred monolithBOT
subtle leaf
charred monolithBOT
odd heath
#

NO WAY WE GOT A NEW PLUGIN

glass jasper
charred monolithBOT
spark pivot
austere talon
#

cause its not i nmain yet fool

spark pivot
#

I am a fool

rugged spire
spark pivot
#

have venbot listen for commits that have "new plugin" or something and make it automatically generate a #plugin-news post for it

#

lol

austere talon
charred monolithBOT
median rapids
austere talon
#

forgor..

#

i need someone to scream at me whenever theres new plugin

median rapids
#

nah u just hate me

#

:(

austere talon
#

nooo...

#

i love you youre my favourite alien blobcatcozy

rugged spire
charred monolithBOT
#
My-Name-Is-Jeff
[Vendicated/Vencord] Pull request opened: #2381 fix(ValidUser): increase code boundary

Change patch from 50 to 100 chars to match

function(e,t,n){"use strict";n.r(t);var i=n("735250");n("470079");var r=n("239091"),s=n("644956"),a=n("819366"),o=n("592125");t.default={handleUserContextMenu(e,t,s,a){let l=o.default.getChannel(t);null!=l&&(0,r.openContextMenuLazy)(a,async()=>{let{default:t}=await Promise.all([n.e("99387"),n.e("79695"),n.e("1502"),n.e("70866"),n.e("12435"),n.e("6696")]).then(n.bind(n,"757387"));return n=>(0,i.jsx)(t,{...n,user:e,channel:l,guildId:s})})},re...
spark pivot
charred monolithBOT
rugged spire
#

they aren't even editing contributors list

#

my first PR was something tiny like this

#

and i didn't try doing it for contributor

#

i did it because it was something so tiny that bothered me too much

austere talon
#

its a fix i think

frail skyBOT
#
Bad Patches

BadgeAPI (had no effect):
ID: 80132
Match: /&&(\i)\.push\(\{id:"premium".+?\}\);/

BadgeAPI (had no effect):
ID: 80132
Match: /alt:" ","aria-hidden":!0,src:(?=(\i)\.src)/

BadgeAPI (had no effect):
ID: 80132
Match: /(?<=text:(\i)\.description,spacing:12,)children:/

ValidUser (had no effect):
ID: 878611
Match: /react(?=\(\i,\i,\i\).{0,50}return null==.{0,70}\?\(0,\i\.jsx\)\((\i\.\i),.+?jsx\)\((\i\.\i),\{className:"mention")/

FakeProfileThemes (had no effect):
ID: 688298
Match: /RESET_PROFILE_THEME}\)(?<=color:(\i),.{0,500}?color:(\i),.{0,500}?)/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

BadgeAPI (had no effect):
ID: 80132
Match: /&&(\i)\.push\(\{id:"premium".+?\}\);/

BadgeAPI (had no effect):
ID: 80132
Match: /alt:" ","aria-hidden":!0,src:(?=(\i)\.src)/

BadgeAPI (had no effect):
ID: 80132
Match: /(?<=text:(\i)\.description,spacing:12,)children:/

ValidUser (had no effect):
ID: 878611
Match: /react(?=\(\i,\i,\i\).{0,50}return null==.{0,70}\?\(0,\i\.jsx\)\((\i\.\i),.+?jsx\)\((\i\.\i),\{className:"mention")/

FakeProfileThemes (had no effect):
ID: 688298
Match: /RESET_PROFILE_THEME}\)(?<=color:(\i),.{0,500}?color:(\i),.{0,500}?)/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

its time to do a little fixing

charred monolithBOT
spark pivot
spark pivot
austere talon
rugged spire
austere talon
#

chat is it time to open vscode

rugged spire
#

yes

still wasp
charred monolithBOT
rugged spire
#

ooooooo

#

whoever made this does not know

Sqaaakoi-24-04-2024-15-43-28.png
austere talon
#

know what

rugged spire
#

discord love making new sessions

#

for no reason

#

also @fringe basalt why does the linux icon look like piss

austere talon
#

piss icon blobcatcozy

#

its not piss its banana

rugged spire
#

istg if this was taken from discord's own branding

#

WHAT it isnt

#

could this please be rewritten to use CSS classes instead of hardcoded color variables

#

before it gets to main

charred monolithBOT
rugged spire
#

there are absolutely no CSS files in this plugin

austere talon
rugged spire
#

theming

#

i literally just described the #1 usecase

#

banana color looks like piss

austere talon
#

can do it later

rugged spire
austere talon
#

u can pr bleh

#

or maybe amia wants to do that idk

charred monolithBOT
rugged spire
#

i will submit my ReviewDB plugin PR

charred monolithBOT
rugged spire
#

vee is actually closing PRs

#

i will open a new one

charred monolithBOT
rugged spire
glass jasper
rugged spire
gritty iris
#

😔

rugged spire
#

i just discovered an extremely niche bug

gritty iris
#

Which is?

rugged spire
#

migratePluginSettings does not migrate Vencord_existingPlugins timestamps

gritty iris
#

Can you dumb it down

rugged spire
#

Renamed plugin shows as new

Sqaaakoi-24-04-2024-16-01-22.png
gritty iris
#

Okay thanks

#

I noticed that in December and ignored it lmao

rugged spire
glass jasper
gritty iris
charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New review comment on pull request #2372: feat(plugin): PauseInvitesForever

since this is not stateful, it won't update on change

i assume this means if you press the button it wont actually update the ui until you reopen the modal

you could make it stateful & subscribe to the experiment and guild updates (i assume changing features dispatches a guild update?)

useShowDisabledInvites(guildId: string) {
	const { enableInvitesDisabled } = InvitesDisabledExperiment.useSetting({ guildId });
	const guild = useStateFromStores([GuildStore], () => GuildStore.g...
gritty iris
#

Pause invites forever looks dope ngl

charred monolithBOT
austere talon
#

usually if we rename plugins its cause they got new features

#

so its not misleading to mark it as new again

charred monolithBOT
glass jasper
#

|| damn just when i thought my pr had a chance ||

austere talon
#

another time!

#

gonna sleep now sorry

glass jasper
#

damn but night

gritty iris
#

Night

gritty iris
glass jasper
gritty iris
#

I would never do such a thing

glass jasper
median rapids
gritty iris
median rapids
#

OH you mean on community feature add

austere talon
#

does it rerender ui and hide the permanent disable as it should?

median rapids
#

it does

austere talon
#

well ig cause discord already subs in the parent

#

xd

#

then u can ignore ig

median rapids
#

bleh

austere talon
#

well yeah discord subs then blobcatcozy

#

which also updates u

median rapids
#

oke

#

i'll take ur word for it :p

austere talon
#

i mean it has to otherwise you wouldn't rerender caturtle

austere talon
charred monolithBOT
median rapids
austere talon
#

i never used this feature in my life blobcatcozy

median rapids
#

turn off switch

#

press save

#

profit

gritty iris
#

The green slider!

austere talon
#

oh i fucking blind

#

i didnt realise the switch state changed

median rapids
#

it's weird that my button doesn't require pressing save

#

but doing that sounds insanely hard

#

so i wont

gritty iris
#

Fair

median rapids
#

doesnt rlly matter tbh

austere talon
#

tbh it would be nicer if u added a drop down option and did the save button

#

but yeah it's way more effort lmao

median rapids
#

aaa

austere talon
#

that's why i didn't suggest that

#

it's fine the way it is

median rapids
#

i couldnt even do the link button properly

austere talon
median rapids
#

u shouldve seen my first patch

#

it... worked

gritty iris
#

Horror

median rapids
#

aaaamia saved you

austere talon
#

i love aaaaaaaaaaaaaaaamia blobcatcozy

#

my heroine

median rapids
#

i love aaaaaaaaaaaaaaaaaaaaamia too blobcatcozy

gritty iris
#

I love when discord canary on mobile just freezes for a few seconds and then revives

austere talon
gritty iris
#

Wha-

median rapids
#

so real

austere talon
#

choose wisely

median rapids
#

i'll split it across multiple messages blobcatcozy

subtle leaf
median rapids
subtle leaf
austere talon
#

what the

median rapids
#

humans are so mean

austere talon
gritty iris
#

My fault they won't let you go they said they need more chips

median rapids
#

hm i wonder what other unimplemented stuff i could add to the client

austere talon
#

ui for role locking emotes caturtle

gritty iris
#

A button that will throw a flash bang

median rapids
#

OH

#

yeah

#

i could

#

?remind 17h

#

dang

#

what i really wanted to do was add a built-in http UI

#

for sending reqs

#

but that would be private 👽

austere talon
#

insomnia in discord hollow

median rapids
#

yeah

#

devtools get annoying sometimes

#

esp if you have gw logs on

#

also i don't like js

austere talon
median rapids
median rapids
#

rn i just open ipython

#

and use my own http handler

#

lmao

gritty iris
#

I just tell windows do this and it brings back a void

#

So

rugged spire
median rapids
#

y

rugged spire
#

do not add anti-features to vencord

median rapids
#

i wonder if there's a way to add a reason parameter to like every mod action

rugged spire
median rapids
#

with good ux

rugged spire
median rapids
#

without becoming suicidal

median rapids
#

exactly

#

cuz like

#

i can think of a way

#

but making it would be so husk

austere talon
#

for what other actions would a reason be useful?

#

maybe adding roles

median rapids
#

the api supports it on nearly everything

#

client only exposes on kick/ban

austere talon
#

but imo just use bot commands if you want a reason xd

austere talon
median rapids
#

stuff like editing/deleting channel etc

#

would be nice to have a reason for

austere talon
#

true

rugged spire
#

discord should require password to delete channel

median rapids
#

i could just intercept the request and obnoxiously popup a modal

austere talon
#

reason: raid alieningwebp

median rapids
#

kinda like mfa

rugged spire
#

like it does for massban

median rapids
#

that could very easily get annoying tho

#

especially for simpler stuff

rugged spire
austere talon
#

well for delete anyway

#

for edit idk

median rapids
#

not everything has one

#

like what you said

#

adding roles

#

whgere tf would it go

austere talon
median rapids
#

maybe like

#

hold alt while doing something

rugged spire
median rapids
#

to popup modal

rugged spire
#

also

median rapids
#

actually thats not even terrible

#

hold alt for reason modal

austere talon
#

yeah maybe

rugged spire
#

the role member-ids endpoint has a limit of 100 users returned 😭

median rapids
#

yea

#

oo i wanted to make my modcache thing too

rugged spire
#

oh fuck

#

i just remembered

median rapids
#

enabling member joins/updates/removes for guilds you're mod in

#

so the cache is always up to date

rugged spire
austere talon
median rapids
#

alien

rugged spire
#

discord caches audit log to one specific variable afaik

#

regardless of guild

median rapids
#

and a place to show response

#

and syntax highlighting and stuff

austere talon
#

so basically dollar store insomnia

median rapids
#

basically import insomnia

#

into discor

austere talon
#

you can even use monaco for the body if you're crazy

median rapids
#

idk what that is

austere talon
#

vscode Editor

rugged spire
median rapids
#

real

austere talon
#

the quick css editor is monaco

median rapids
#

sounds valid

rugged spire
#

why don't you just put monaco in a component

#

instead of a popup

#

for qcss

median rapids
#

unfortunately my most useful dev plugin i can't share

austere talon
#

why would you ever want it in the discord window lmao

rugged spire
median rapids
#

cuz

rugged spire
median rapids
#

no setting up headers

#

no separate app

#

etc

austere talon
#

no i meant sqaaa

median rapids
#

i hate multitasking

#

oh

rugged spire
#

i do say true because it would be such a pain to go between

austere talon
#

i meant why do they want the quick css editor to be in the settings page instead of a separate window

rugged spire
#

but

median rapids
austere talon
#

i have two monitors but I hardly ever use my second monitor lmao 😭

rugged spire
rugged spire
median rapids
# rugged spire but

window is better cuz u can watch the updates instead of being stuck in settings

median rapids
rugged spire
#

i get it now

austere talon
#

i basically only use my second monitor to have discord on it when im playing a game

median rapids
#

real

austere talon
#

and to live preview for frontend dev

median rapids
#

userdoccers dev wouldgo hard

rugged spire
median rapids