#๐พ-core-development
1 messages ยท Page 172 of 1
it is
I mean some don't but most do
so when it explodes your console is spammed with errors about things not found
in that branch the wreq is initialized before the first require
oh okay
what's happening
@CodiumAI-Agent /review
lets see 
PR Review
<table>
<tr>
<tr><td> โฑ๏ธย <strong>Estimatedย effortย toย review [1-5]</strong></td><td>
4, due to the complexity and the amount of changes involved in the PR, especially with the refactoring and introduction of new APIs. The changes impact critical functionality related to webpack patching and module loading, requiring careful review to ensure no unintended side effects or regressions are introduced.
</td></tr>
<tr><td> ๐งชย <strong>Relevant tests</strong></...
๐
username
890228870559698955
oh
@junior olive check this out
i was trying to ping fiery but his name is swiftui and jack lmao
so it didn't find
pushed the tag
thanks 
My neighborhood has been having internet issues since tuesday apparently and it inevitably struck decor more permanently this time
okay extension released
wait are u hosting it on ur home network
yuh
crazy
nop
hope ur internet improves soon
Same but if it needs anything from me wrt decor it'll have to wait til I'm at a hotel or something
Abroad rn
visiting the Brit's
internet outage is like the worst thing ever ๐
yop
whenever my internet is down i notice how much i depend on it
well if you're abroad it doesn't affect u lol so funny timing

lucky timing
๐จ
For me yes but my dad works from home and isn't abroad yet

no rush
but the kids are gonna ask about decor a lot, so that's gonna be fun

he's probably already got his phone hotspot going lmaoxd
I just locked decors support 
call in Tessie for help
yeah but fixed
I'm aware of more error boundary crashes that @shy veldt can detail
if the user opens profile effects before decor decor patches wrong module
meooow
We need more specific find there
oh wtf
yeah it's funky
nookies on the case
easy fix
yes it does
it was matching this
60f6678 Decor: Fix find targetting wrong module in some... - Nuckyz
60f6678 Decor: Fix find targetting wrong module in some... - Nuckyz
8445933 Merge branch 'dev' of https://github.com/Vendic... - Nuckyz
I will churn you
๐ฟ
@austere talon #1222936386626129920 message I doubt DAYS
it's America ๐บ๐ธ ๐บ๐ธ๐บ๐ธ
The whole neighborhood is out
weeks even
Discord Account
zverolovz
What happens when the bug or crash occurs?
Always Animate is on but it isn't animate. It's on
What is the expected behaviour?
I'm expecting that it'll animate
How do you recreate this bug or crash?
Turn on plugi...
works fine for me. update vencord or use support channel if it doesnt work
@austere talon decor back apparently
650f405 fix(PinDMs): display properly when there are 0 ... - Syncxv
why is this done with CSS rather than a patch?
it is much easier to hide and show messages using CSS rather than JavaScript. I would have to delete the element from the DOM but putting it back would be hard and if I have to stick with JavaScript, I have to append a style to the message div that will hide the message but I will eventually use CSS if I do that.
Discord Account
deepinyahmum
What happens when the bug or crash occurs?
Every time I open someone's stream. Full crashes discord. If I stream and open someone else's stream, it will work. But if I click anywhere outside of discord, it will crash again.
What is the expected behaviour?
To be able to not crash
How do you recreate this bug or crash?
Have a friend stream their game
Open said friends stream.
Errors
[Spotify] WS Connecting
player:1
...
try if this also happens on stock discord without vencord. it is very unlikely to be related to vencord
also your error log contained your spotify token so you should change your spotify password and remove and readd spotify to your discord
Weird. I fully re-installed discord, and it does appear to be doing the same thing unrelated to vencord. Could anyone confirm if they are also experiencing this?
fwiw someone else in support a few hours ago was reporting the exact same behaviour so
smells like discord issue
ohh we should have merged before releasing browser
it's too late
i forgot to merge that i was gonna merge days ago but then discord explosion happened
Weird. I fully re-installed discord, and it does appear to be doing the same thing unrelated to vencord. Could anyone confirm if they are also experiencing this?
got the same problem, unistalled vencord, problem solved
bro changed one line in commented code
I found a silly bug
i am using the last build and seems fine to me
You put the EPOCH and it showed it correctly?
bcs its timezone dependant
I can confirm the issue
what's supposed to be the bug
if you put the Epoch date in the date selector it defaults to Now
because the timestamp is 0
why put 0 anyway doesn't make that much sense just type <t:0>
Exactly why I said that it was a silly bug
Silly bugs are still bugs though
650f405 fix(PinDMs): display properly when there are 0 ... - Syncxv
e255027 Merge branch 'dev' of https://github.com/Vendic... - Nuckyz
Thank you for the update, but I'm having trouble activating the feature on the desktop Windows app. Are there any additional steps required besides the fake nitro activation?
let me run reporter manually cuz the automatic doesnt work anymore lmao
You probably don't understand what it does, so just ignore it. It does not give you free access to the soundboard.
None
None
None
None
None
None
None
None
there's a typo in the script
it's trying to query select from temp1
NoMouseNavigation allows users to disable the default handling of mouse side buttons (3 and 4).
Many people use side buttons for PTT. By default, Discord will handle those by navigating forward/backward through visited pages while the app is in focus, causing severe butthurt for PTT users. This plugin simply prevents the default behavior, PTT continues working normally.
P.S. I'm not sure if adding myself into the dev list in constants.ts is appropriate, but looking through other plugi...
BANGER
i dont know why i didnt think of that
i just resorted to physically muting the mic instead of ptt lol
Using those for navigation is standard just about everywhere, but yeah being able to use them for ptt sounds useful too
I never use them for navigation in discord
that's W
I sometimes use alt-left and alt-right, but my mouse doesn't even have those buttons
instead of adding your own listener, it would be better to simply noop discords listeners, to avoid having unnecessary listeners
I doubt it even has a listener for it, I assumed it just listens to the browser's forward/back nav
I believe it must be handled by the Electron itself, the same way it's hardcoded into Chrome. I'll double check tho
theres native side added listeners which is what cause buggy navigation with them on linux
Yeah, based on my experience with Chromium and the fact that I couldn't find anything explicitly handling this from Discord's side, I'm assuming this is pretty much the only way to implement this - but I'll be happy to be proven wrong here. It must be a native thing inherited from Chromium
If Discord had its own listeners for mouseup, e.preventDefault() wouldn't affect those, and we'd need to call e.stopPropagation()/e.stopImmediatePropagation(), which is not the case, @Vendicated
that's a good point
idk why i assumed they handle it manually
hmm maybe we could use the navigate event instead of key event
seems cleaner?
I support this, but I would like to add a recommendation. Instead of a new plugin, possibly add a toggle below the activity on the users profile?
@limber skiff lol what were you smoking here https://github.com/Vendicated/Vencord/blob/main/src/main/updater/http.ts#L56
**http.ts: **Line 56
message: c.commit.message.substring(c.commit.message.indexOf("\n") + 1)
I mean I tested and it works even when it's not found
wtf
it removes the first line
or
message: c.commit.message.substring(0, c.commit.message.indexOf("\n") + 1)
prob works too
no
if it doesnt contain newline it will make empty string
and why even use .substring()
.slice better
:p
always use slice
why don't you push it to main
the silence before the storm
Not again 
None
None
None
None
its so voer
god damn
a lot of context menu stuff but so many others
what did they cook this time? @shy veldt
i have no idea
well they didnt update react
so that checks out

Surely they will revert
did they push to stable
lets check
it's so over
ayo wtf
vencord patched for real
for rea
they cooked
who let them cook
well have fun with that im going to sleep lol
@austere talon disable messages on #๐ฅ-vencord-support-๐ฅ please
you do it
let only us talk
i can't im on phone

things exploded rip lmao
broken
nothing crashing
or at least i didnt get to that point yet

its mostly just failing to patch
Discord Account
tsaitou7361
What happens when the bug or crash occurs?
Many plugins in version 650f405 are BROKEN
What is the expected behaviour?
Any plugins won't work
How do you recreate this bug or crash?
- Update to 650f405
- And boom!
Errors
No response
Request Agreement
- [X] I am using Discord Stable or tried on Stable and this bug happens there as well
- [X] I have read the requirements for opening an issue above
YOU WONT SAY
Bruh
so if it wont patch theres nothing to crash
good
Content
Known. Just wait
Request Agreement
- [X] I have read the requirements for opening an issue above
Do I get out of bed and do fixing or do I eep
web design is my passion
true
discord moment lol
tbh i would wait a bit with fixing maybe they will revert
well you do you im going to sleep
have fun
Sleep well
i wish discord had a feature to limit communication to previous chatters
like github
WTF IS THIS?
Scary
is that like assign lmao
the old patch for that
funny
Break into discord hq and make them revert
What
wtf is this shit lol
it's the new way they set store methods
fire
discord carefully configuring their bundler to produce the shittiest code imaginable
it's copy and pasted on thousands of stuff
I'm triggered by there not being a space after value"
Lmao
I just hope they revert this
I guess lmao
yeah they dont have async anymore
that's not what i asked
they still have classes
are classes gone and .prototype again
sorry I was already typing it
???
no
discord really doesn't like you guys lately
not again ๐ญ
does it use class syntax
๐ญ
never reloading ever again
or does it use prototype
oh let me see
HORROR
why'd they make the code sucky again
i was just getting used to it
:(
gotta GET THE 2s LESS BUILD TIME???????
๐ฅ ๐ฅ
class syntax is gone p sure
just search \bclass\b
wdym bro ๐ญ
yeah no classes
DISCORD MOMENT
about the prototype thing
why downgrade pre es6 again
how nice of them
why do they push these updates at such late times anyway??
who tf working at 9pm
or are they west coast
remote
who tf cooking with the bundler at this time
Pushing to stable on Easter weekend 
wait
the pr before this one was Disable Tests
Last commit before holidays let's hope nothing explodes
wait for real??
if you notice that the @discord mobile app feels a bit faster in the near future, maybe a little snappier, that's because it is ๐
brandon overcooking
cannot call cannot call cannot call
yeah he accidentally pushed mobile update to desktop (real)
LOL?
๐ญ what is he cooking
nah they still have arrow functions
chat do we ping him
Yes
it's just the flux listeners are back to using function()
as seen here
this bundler config is so scuffed jeez
transpiles classes
transpiles async await to generator
still uses es6 array functions
they are transpiling to pre es6 but still use es6 features so it's completely useless and just dumb, cause it heavily bloats the bundle and makes performance worse
also this absolutely deranged assignment everywhere https://cdn.discordapp.com/attachments/1015063227299811479/1223464894616178778/image.png?ex=6619f379&is=66077e79&hm=32f5437488ae3498f327e856100ff55c8a60654d30f192682a48fe6723fea0d4&
@tribal tundra hey what did yall cook
have you considered reverting already
whoops missclick chat
i really don't understand like they upgraded their output to es6 before and now just went a step back?
no
I gave him programming haha
I mean there could be an override
nah brandon is gonna ban all of us from discord it's over
nobody takes client mods into account >:(
Finally I get rid of my crippling discord addiction
no it's not about client mods, it's just that they heavily downgraded their bundler config again
it was so good before now it's back to shit
i was joking silly goose
WIAT LOOK
they are fighting vencord obv
frankenstein config

it's the same file that also has arrow functions
Die Bundlerkonfiguration ist fรผr uns alle Neuland
i mean
its sentry
its not affected 
the files that don't have arrow functions don't have classes
yeah lmao
at the very least he will be 2nd staff to block me
if they wanna make it faster why don't they also go back to the config that mangled stuff and merged modules hardly
GO AWAY
this makes it slower not faster
can we go back to 2018 ?
๐ฅบ
how so?
why don't they just disable minification

true
becsuse native classes and async await are much more performant than cursed legacy polyfills
oh yeah
and they dont have to worry about build times
and these assignments looping over arrays everywhere must be awful lol

wonder why
every bug fixed in 2 weeks
clueless
true
then they'll have nothing to do :(
real
rem -> px -> rem -> px
Guys what if this bundler config change is just a big April fools for all client mods 
goodluck to us

dolfies pretending like he doesn't have access to discord/discord
true
thats where error codes are located

can confirm
give me the entire source
actual april fools will be pushing src maps
new cookie dropped
:(
๐
now you can't eat it
true
How many ndas have you signed
i think discord devs change random things just to look busy when their boss is nearby
yeah
I think this array thing is part of the polyfill of classes
banning random users looks like work


yeah this can't be performant at all lol
should i be scared
final nail in coffin for all vendetta forks
someone should update #1222936386626129920 prob
"everything's an issue, deal with it, we know"
woo more config changes
i blame you
lambdas seem to be gone in some places
i wish
look who's talking
i knew someone that was hidden staff that helped with a11y stuff and thats as closest ill get to being dev
ive gotten 3 1/2 features merged

yeah it does
i expect revert soon
back to pre es5 lol
Prayimg
i'm sure they'd accept you 

nop
discord devs have weekend tomorrow
official vencord discord rep
false
yeah but doubt he checks pings lol
doesnt mean anything
theres devs that will push builds on weekends
isn't today supposed to be a us holiday too
no
oh it's not a federal holiday in the us
religious holiday
but normally faulty pushes are canary only
did this get pushed to stable?
new discord intern said fuck it we ship 
bruh
@odd heath you see this discrimination to us Canary users
that one time someone pushed an update
no sane vencor user would use stable
(it got released on stable)
smh smh
(no one could use discord)
lmao
discord employee pushing broken config right before leaving for the weekend
s/for the weekend//
they are like
hey guys any more updates?
no
okay im gonna push my config update
okay
okay
discor epad leaked
discord employee pushing to master with left hand on his phone (brushing teeth with right hand) then going to sleep

u sure about brushing teeth

So what did he use to push 
i really feel like this was "fuck it its 7:30 we ball"
๐ญ
its just jason citron that doesn't
who's kirby
Iโm pretty sure heโs Amish, so he probably doesnโt know about brushing teeth
๐ญ๐ญ
pink ball
you dont want to nkow
so much hatin today
im gonna get fucked
lmao
YAY
im allowed to hate jason citron
fuck me
be there in 5,,
Run reporter
someone verify
yep reverted
shiva me timba
yes do this mods
nuh uh
yeah still on canary
horror
yeah only stable was reverted
stinky
do they have like a ci that automatically reverts update if they get too many sentry logs
fix what
ummmm
have you considered
None
None
None
None
usesClientMods:
boop
doesn't detect venchord
blacklisted native side
too smol
reporter will be blazing fast
mere blip in the radar
that's only native vencord
not vencord renderer
lol
"body": "a test relied on an endpoint that had an expiration of ~4pm dec 13 (or UTC dec 14 00:00). this disables that test.\r\n\r\n
PREMIUM_TIER_2_SNOWSGIVING_ONE_WEEK_PROMOTION_EXPIRATION = datetime(year=2022, month=12, day=14)",
"title": "[tests] disable failing test", "updatedAt": "2022-12-14T04:16:42Z", "url": "https://github.com/discord/discord/pull/97209"
they don't block us in renderer cause we do it ourselves
vencord rootkit
okay yeah only reverted on stable
doesn't vender kill sentry anyway
brownie points if you find where this is from
leaked emails from jason citron
norp
yorp
vendor treasure hunting
its me
**node.ts: **Lines 10-26
try {
const sentryPath = require.resolve(
resolve(preloadPath, "..", "node_modules", "@sentry", "electron")
);
require.cache[sentryPath] = new Module(
sentryPath,
require.cache[require.resolve(preloadPath)]
);
require.cache[sentryPath]!.exports = {
init: () => {},
setTag: () => {},
setUser: () => {}
};
logger.debug("Stubbed Sentry node side!");
} catch (err) {
logger.error("Failed to stub Sentry:", err);
}
vev doesn't know
moonlighting
i can see all discord employee emails
me too
it did
It ran, the message was too long
reporter shit, make it upload as a file
They always run together
true...
can you pls leak this in a sec
where is reporter ill fix it
i upload cynthia as a file
i download cynthia
yeah i was about to suggest that
yeah hold on
just upload as file
527064
that's not a jwt smh
how did this leak
its new method
in early testing
dzi you should join the server for the custom client im working on
leak all the secrets

dolfies leaked insider knowledge in my dms
ong?
actual discord staff 
@median rapids what did bro dump
proof?
full of slurs
so true
didn't expect that
yeah ๐
its true
nicest dziurwa to ven dm
dzi called me slurs no one has even heard of
thats just cause polish isnt real
hey hey hey
consider
what that most of them are that emote?
dzi has a fake account in the discord employee slack
๐
but then theres ven
well

did you
things
thy punishment is obv dumping me everything in dm
i should know about your internet activities
nah no way i got this houngry at 4am
yall pls go to sleep ๐ญ
ofc pookie
did you eat your monitor
you first
as you can see in ":3"
actually im not really esleeping
thats just from when i was fixing extension from crashing without fixing its functionality
me waiting for canary revert (wont happen until sunday night)
[FAST CONNECT] Attempting to set fast connect zstd when unsupported
vee gets 5 seconds of sleep a night
2015
4 months after discord launched
alien technology
yop true
vev will eep
how do they even do this, like detect it
they'd have to like check stacktrace or smth
which would be insane
return n = function(e, t) {
return function(n, r, o) {
var c = t.levels[r]
, d = new RegExp("^(" + c + ")$");
if ("log" !== n && o.unshift(n.toUpperCase() + ":"),
o.unshift(e + ":"),
Z) {
Z.push([].concat(o));
var h = Z.length - 1e3;
Z.splice(0, h > 0 ? h : 0)
}
if (l.a.console) {
var f = l.a.console[n];
f || "debug" !== n || (f = l.a.console.info || l.a.console.log),
f && c && d.test(n) && f[Array.isArray(o) ? "apply" : "call"](l.a.console, o)
}
}
}(t, o),
idk what this does
explain in fortnite terms
yeah
there will be a new native modukle
discord-zstd
yorp
not a victory royale
:(
i can relate
:(
building in lego fortnite without keyboard or controller
fear

me
the regular version of this gif is absurdly large
guys i think my one-time verification key is
logger level
regex for the logger level for some reason
if the function is not log, add uppercase function name, add first arg of wrapper
check if Z is not null
push an array of arguments
reduce it to 1000 arguments
check if log level exists, if not debug set it to info or log if it doesnt exist
check if levels null, test the regex
if arguments is an array use apply otherwise use call on the logger function
not on dev yet ๐
3
overengineered ass logger
very
all enterprise loggers have to be overengineered silly
bros should take notes from https://github.com/Vendicated/Vencord/blob/main/src/utils/Logger.ts
add first arg of wrapper
sorry this is logger name
understood ๐ซก
vecnord lggoer
aamia logger
token logger
โLogger.tsโ, vencord is a Token and Ip logger confirmed
/joke
true
280231
ye
wait im confused now
are you saying the breaking update is fully reverted on all branches
so what's this
a virus
canary and ptb fix
oh alright
as they reverted stable to 280008 first
None
None
None
None
None
None
None
None
watch it come back tomorrow
scary
was it brandon who reverted
ask him obv

nah probably not
hes dead
i love chomikuj.pl
what are you expecting
you mean amia.dev 
now i look like a goofball with this dm
horror

i used chomikuj as a kid, before their search was free
good times
true!
@devout river 
github issue lookin ass message
real
i've put bazillion random javascripts on my chomik's page
when the smart is fridge
Do wykorzystania bezpลatny voucher w nowotwartych hotelach w Karpaczu i Lฤ dku Zdroju XD
wait why are u awake at 5am
go to sleep ๐ฅบ
who
dzwiurwa
aays you
fix when
did you know that theres paczkuล now
never
goofy ahh https://amia.cx
yop
why no embed
the video..
amia where u from
i only whitelisted /i/* for discord
THEN WHY ARE YOU TELLING US TO GO SLEEP
hey guys im back
i might've gotten timed out
dziurwa is younger, he need sleep more
๐ต
true
sorry but old woman emoji doesn't hit the same
old woman emoji looks 60, old man emoji looks 90
man_with_chinese_cap
how old r u amia
20

dzwiurwa is like 15 or something iirc
god i turn 24 in days
๐จ
i would rather run 5km away
you haven't seen the wild stuff he says
no trust me i have
hi
guess you haven't after all 
i mean that's reasonable you're a cutie afterall
gonna rename this channel to nerd-off-topic
no u

#vencord-dev-except-when-discord-changes-their-build-system-again-then-its-nerd-off-topic
no this is always off topic lmao
it's like off topic but with only devs and contributors
topics are merely a suggestion
true
the only sane people in this place
i mean it doesn't matter if channels are off topic as long as it doesn't disrupt a different on topic discussion
bet
posting miku in every inactive channel /j
so true
when is vencord dev ever vencord dev
except when the webhook exists for a total of two minutes
stable is now on 280231 and canary is on 280234
and annoying people like me who want to contribute but aren't technically contributors yet
gonna write a massive essay about how topics are a patriarchal construct that indiscriminately oppress our ability to speak
leaving you in pr hell for eternity
that's how it works
the commit history
Maybe I'll start posting images of furniture on the PR to make PR hell a more comfortable place
id say learn to rebase but ive had bad experiences rebasing prs
i'm too lazy for that and this works fine
my experience with rebasing just ends up in a force push lol
to be fair i could just revert the fork and then copy paste my changes, making it all one single commit
I'm going to venture to say remaking the PR would be a bad idea, but I think the title could use some work
nah don't squash / rebase prs
it doesn't matter ill squash it anyway when i merge it
yeah
tbh i hate when people rebase their prs
when i review something and then they make changes but instead of pushing normal commit they rebase it so now i have to read the entire code again instead of being able to only look at what they changed


I'll rename the PR so that its title is more concise and continue updating it whenever vencord gets pushes
whatever this is off the topic of the off topic channel topic topic
oh fun i can't comment on my own PR anymore
that's pretty wacky
I also can't edit the original message ๐ค
Wack
right i locked it because you know why
my pr specifically or the whole repo
whole repo ofc lol
i completely understand either way kek
i unlocked
ah awesome
In a discord message or from github?
i got it
๐
speaking of prโs cough, cough
https://github.com/Vendicated/Vencord/pull/2302
IM JUST JOKING
THIS IS JUST A JOKE
BUT ACTUALLY :3
ah yes, fellow PR hell user, how are you
iโm great hru
ยฏ_(ใ)_/ยฏ
fair enough
what's the regular role
itโs kinda of in the name
it means you're a regular person with no oddities or quirks?
iโm a regular in this server so i got the regular role
nah iโm trans and bisexual
LOL
activity + being sane
based
I totally knew that from having totally thoroughly read your bio
Fair
it doesn't have any real meaning it's just to give image perms to people who aren't insane
anywaysโฆ did you see my message pookie :3 (pookie as a thing friends call each other)
yes
we will probably add reaction roles soon
just haven't gotten around to it yet
understandable





