#👾-core-development

1 messages · Page 171 of 1

umbral hedge
#

idk if they made it default

#

because i was already on 64bit

austere talon
#

check taskmgr

sterile oak
#

functions naming style should be camelCase right?

austere talon
#

yes

umbral hedge
#

im already using 64bit stable

#

and have been for months

#

so i know its 64bit

#

?

charred monolithBOT
austere talon
#

huhhh

#

where tf do u get 64 bit stable

#

i thought it was only canary for now

jagged cloak
#

ive been using 64bit ptb canary and dev

#

never seen or heard of 64bit stable unless megu straight up gaslighting lmao

cunning canyon
jagged cloak
#

that used to give an error

#

now it doesnt lol

#

live reaction to that information

jagged cloak
#

i figured that out on my screenshot

#

ty tho

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

MemberListDecoratorsAPI (had no effect):
ID: 888503
Match: /decorators:.{0,100}?children:\[/

ChatInputButtonAPI (found no module):
ID: -
Match: location:"ChannelTextAreaButtons"

WebContextMenus (found no module):
ID: -
Match: .default("MediaEngineWebRTC");

Bad Webpack Finds

None

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 Attempting to set fast connect zstd when unsupported ```
charred monolithBOT
limber skiff
#

oop

charred monolithBOT
limber skiff
#

these fixes are not compatible with stable

charred monolithBOT
limber skiff
#

we could try using this to help with errors

#

forgot to include the description 💀

austere talon
#

wdym

#

how would that help

limber skiff
#

so they dont need to press ctrl + shift + i

#

only click a button

austere talon
#

mm

#

maybe

charred monolithBOT
charred monolithBOT
charred monolithBOT
crude hearth
#

wibdows10

fringe basalt
#

the silence before the storm

charred monolithBOT
shy veldt
#

do they know?

glass jasper
fringe basalt
#

nop

#

the storm of discord's monthly webpack change

charred monolithBOT
frail skyBOT
#
Bad Patches

MemberListDecoratorsAPI (had no effect):
ID: 888503
Match: /\.Messages\.GUILD_OWNER(?=.+?decorators:(\i)\(\)).+?\1=?\(\)=>.+?children:\[/

ChatInputButtonAPI (found no module):
ID: -
Match: "gift")),(null

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

oh uh

#

reporter exploded?

#

they are actually right about it?

#

it is true.

#

let me try my other branch

#

haha .el is GONE

brazen bone
#

That sounds fun

frail skyBOT
#
Bad Patches

ViewIcons (had no effect):
ID: 289918
Match: /style:\{(?=backgroundImage:(\i&&\i)\?"url\("\.concat\((\i),)/

BetterNotesBox (had no effect):
ID: 301998
Match: /(?<=return \i\?)null(?=:\(0,\i\.jsxs)/

Decor (had no effect):
ID: 907148
Match: /(?<={user:\i},"decoration"\),)/

Bad Webpack Finds

findByProps("getAPIBaseURL", "get")

Bad Starts

None

Discord Errors

None

limber skiff
austere talon
#

what hapepned lol

limber skiff
#

@austere talon WE ARE BACK TO IT

#

working in my branch rn to not use .el

austere talon
#

"it"?

limber skiff
#

very easy to fix prob

#

it used to be like that

austere talon
#

oh okay

limber skiff
#

the chunk ids were hardcoded in the code

#

instead of having a mapping

limber skiff
brazen bone
#

Is it that .el() looks up a mapping and then .e()s each chunk?

#

And now they cut out the middleman?

limber skiff
#

yes

#

it used to be like that before

#

well at least exports are not mangled

charred monolithBOT
#

PR Review

<table>
<tr>
<tr><td> ⏱️ <strong>Estimated effort to review [1-5]</strong></td><td>

2, because the changes are straightforward and localized to a specific feature. The addition of a new CSS file and modification of existing TypeScript files are clear and do not seem to introduce complex logic. However, reviewing the CSS for compatibility with various themes and ensuring the TypeScript changes do not affect other functionalities would require some effort.

<...

austere talon
#

why did u close it again

glass jasper
austere talon
#

because posting it as snippet makes no sense

#

just have a little patience and get it added properly to the plugin

charred monolithBOT
limber skiff
#

I hate forgetting that

glass jasper
charred monolithBOT
austere talon
#

then say that and let someone else do it? noone is forcing you to do anything

long stream
#

oh there it is

limber skiff
#

hmm wait ignore that

#

wait for th canary

#

cool

long stream
limber skiff
#

I'd guess that seems more like it

#

the canary one

spark pivot
#

Oh no

lofty helm
#

mfw

#

my discord just HAD to segfault due to me accidentally dragging something

charred monolithBOT
lofty helm
#

at such a wonderful time as well

#

now my theme is broken again

charred monolithBOT
dapper tiger
crude hearth
#

love

#

vencord falling apart after AI reviewed a PR

long stream
dapper tiger
#

ai will be the downfall of vencord

long stream
crude hearth
#

laziness brings disasters

lofty helm
#

brb going to git checkout to webpack-changes

limber skiff
#

okay here it is

#

only the canary one is valid

long stream
#

Maximum call stack size exceeded my beloved

glass jasper
limber skiff
#

what the actual fuck is this?

#

what is this bundler cooking?

lofty helm
#

when will discord stop fucking with the webpack config

brazen bone
limber skiff
#

I guess it is 😭

brazen bone
#

Wait is that inside a for loop or something

limber skiff
#

no

austere talon
limber skiff
brazen bone
#

Wait in is an operator?

austere talon
#

yes

long stream
#

a loop operator yea

limber skiff
#

it's what the new displayName="MessageStore" is

long stream
charred monolithBOT
#

Discord Account

rabbydevs

What happens when the bug or crash occurs?

When "Automatically Hide Taskbar" is enabled on windows, and the transparent window setting is enabled, unexpected behavior occurs.

What is the expected behaviour?

Taskbar unhides properly when mouse moves to the bottom of the screen.

How do you recreate this bug or crash?

  1. Enable "Automatically hide taskbar"
  2. Enable transparent window.
  3. Move mouse up from the bottom of the screen to hide it.
    ...
odd heath
#

Discord segfault?

lofty helm
#

mfw

#

looks like discord's chat summaries are fucking STUPID

#

and doesn't understand jack shit

odd heath
#

As expected yea

charred monolithBOT
lofty helm
#

it only picked that up because of me experiencing almost every single plugin and theme breaking because of discord crashing of what i assume is a segfault due to me accidentally dragging something

#

more themes should switch to selectors tbh

brazen bone
charred monolithBOT
brazen bone
#

Maybe except if they only use @font-face

lofty helm
brazen bone
#

It's not like you can do any styling whatsoever without selectors...

austere talon
#

i think by selectors they mean attribute selectors

brazen bone
#

If you're referring to specifically attribute selectors, maybe use that term

charred monolithBOT
crude hearth
#

NO

charred monolithBOT
#

PR Review

<table>
<tr>
<tr><td> ⏱️ <strong>Estimated effort to review [1-5]</strong></td><td>

4, due to the complexity and size of the PR, which includes multiple new features and modifications across different files. The PR introduces a new plugin with various functionalities, including timezone fetching, UI components for displaying and editing timezones, and integration with external APIs. Reviewing this PR requires a thorough understanding of the existing codebase...

austere talon
#

the ai will say wow this is the worst pr ive ever seen close this immediately

brazen bone
#

Yeah I'm done with time too

crude hearth
#

its very good

brazen bone
#

Time was such a bad idea, let's drop it already

crude hearth
#

can I use that too

austere talon
#

inb4 the ai said like blow up vencord hq

charred monolithBOT
crude hearth
#

I CANT USE IT

#

WHY

#

oh nvm

charred monolithBOT
#

PR Review

<table>
<tr>
<tr><td> ⏱️ <strong>Estimated effort to review [1-5]</strong></td><td>

4, due to the complexity and the number of files involved in implementing the reply feature, including UI components, state management, and integration with the backend API. The changes span across multiple components and involve both the frontend and backend logic, requiring a thorough review to ensure functionality, consistency, and maintainability.

</td></tr>
<tr><td> 🧪&...

crude hearth
#

die yourself

limber skiff
#

L

crude hearth
#

okay it seems good

#

time to merge

crude hearth
limber skiff
#

no reddit replies for you

brazen bone
#

As long as you set key= correctly, I don't think rerenders would be any concern since react will notice that the component is the same as before

charred monolithBOT
#

okay so this is very confusing. i was testing this again today and i noticed some weird interactions: when spotify's rpc shows up, the lastfm rpc goes away, even with the "Hide with Spotify" option disabled, and it shows up as soon as i pause the song. the lastfm rpc also shows up fine if i disable spotify's rpc in discord's connections settings page. this was all tested on stock stable (desktop & web), as the rpc shows up regardless on the client with the plugin enabled. could be a discord b...

crude hearth
#

also it doesnt load replies infinitely

#

reviews and replies can be max 50 together

stark flint
austere talon
#

why is this happening

austere talon
#

seems to be NotificationComponent

odd heath
#

we love discord

#

time to wait for them to revert

austere talon
#

how tf does that happen

#

its somehow infinite proxying

#

it really shouldnt be

charred monolithBOT
austere talon
#

do u have any idea why this is happening @limber skiff

#

somehow it proxies recursively but idk why or how

#

it only happens on first launch then when u restart it works normally

limber skiff
#

wtf?

#

that never happened before

#

isChild should be true and prevent the recursive proxy that's odd

#

put a breakpoint and watch what happens?

austere talon
#

it might be because of this

#

yep holy fuck

limber skiff
#

how so?

austere talon
#

i made webpack find ignore window and its fixed

brazen bone
#

Why is useStateFromStores on window

shy veldt
austere talon
#

puts all webpack commons on window

brazen bone
#

Oh right

austere talon
#

so it was finding the webpack export proxy

#

and that proxy was referring to itself

#

idk its really brainfuck cause recursion + lazy moment but

#

it just found itself basically

limber skiff
#

I dont get it but whatever

#

if you fixed the issue it's okay haha

austere talon
#

its hard to explain

basically... proxyLazy takes a factory of () => find(). and every time you access a member on the proxy, it calls the factory and then accesses the member on the factory return

so... access member on proxy => proxy calls factory => factory returns itself (the proxy) => access member on the return value => go to step 1

because ConsoleShortcuts puts the useStateFromStores webpack common (the proxy) on the window, the find found its own proxy

odd heath
limber skiff
#

btw do you know if with regex I can have a non definitive amount of groups?

austere talon
#

but only if you had ConsoleShortcuts enabled

limber skiff
austere talon
#

btw i made chatbuttons patch better

limber skiff
#

dont think it's possible though

austere talon
#

now works on both stable and canary

limber skiff
#

nice

charred monolithBOT
austere talon
#

basically exactly same approach you used for canary, but also supporting the old if () statement

#

btw why is the MemberListDecorator patch so complex

#

with backref

limber skiff
#

it's needed

#

look at it

#

I mean not needed but less likely to break

austere talon
#

did they push to stable

limber skiff
#

let me check

austere talon
#

nop

#

they didnt

limber skiff
#

aight

#

that one just needs to wait honestly

austere talon
#

why does pindms always break

austere talon
limber skiff
#

memberlistdecorator

odd heath
#

pindms breakage is the worst

#

other plugins just dont do anything but pindms fucks up the entire dm list

limber skiff
#

uhh

#

let me fix extractAndLoad stuff

mortal fractal
#

yall work around webpackRequire.el being removed yet? tr

austere talon
#

we dont really use it

#

only in reporter i think

mortal fractal
#

no places where lazy modules are force loaded?

#

interesting

austere talon
#

but we hardly do it

mortal fractal
#

yeah

#

i cant get it to work properly even copying discord's code idk why

#

just fails to load fsr

limber skiff
mortal fractal
#

i do

limber skiff
#

works in the reporter for me

mortal fractal
#

i get this bullshit for no reason

junior olive
#

lork

limber skiff
#

yeah I cant help much without having the code

mortal fractal
limber skiff
#

unsure honestly

mortal fractal
#

it just doenst exist in wreq.m after the Promise.all

brazen bone
#

Do indirect calls to wreq.e really work? Try i=>wreq.e(i)

limber skiff
#

yeah

#

I was going to suggest that

charred monolithBOT
spark pivot
#

This better work

mortal fractal
#

wait yeah cause fucking

#

map will return a promise

mortal fractal
#

no change nvm

charred monolithBOT
#

PR Review

<table>
<tr>
<tr><td> ⏱️ <strong>Estimated effort to review [1-5]</strong></td><td>

4, due to the extensive amount of new code across multiple files, including complex logic for drawing tools, event handling, and integration with external APIs. The PR introduces a significant feature with various components that require a detailed review to ensure correctness, performance, and adherence to best practices.

</td></tr>
<tr><td> 🧪 <strong>Relevant tests</...

mortal fractal
#

even if i check for the module to exist it just errors down the line because other modules arent loaded

#

weird as fuck

odd heath
charred monolithBOT
limber skiff
#

wait no I'm dumb

junior olive
spark pivot
#

Gonna run it on all my PRs lol

charred monolithBOT
spark pivot
#

Actually prob just that one

charred monolithBOT
#

PR Review

<table>
<tr>
<tr><td> ⏱️ <strong>Estimated effort to review [1-5]</strong></td><td>

4, due to the complexity of the changes involving both TypeScript and CSS, the introduction of a new plugin, and modifications to existing plugins and utilities. The PR involves a significant amount of new logic, including handling different media types, patching existing functionality, and introducing new settings. Understanding the full impact of these changes requires a de...

austere talon
#

i want to write a lint rule that automatically flags (new) plugins that have no README

#

i wonder how hard that would be

#

maybe can use github reporting api

brazen bone
#

Just add a step in pnpm test for it

charred monolithBOT
austere talon
#

btw some people said FakeNitro is broken somehow

#

on canary

#

what the

#

not real

limber skiff
#

nono

#

fake

#

the reporter doesnt work in stable

spark pivot
limber skiff
#

can you review my pr ven 🥺

austere talon
#

which

limber skiff
#

webpack refac

charred monolithBOT
austere talon
#

what the

odd heath
brazen bone
#

What even is that

odd heath
#

a regex match

shy veldt
brazen bone
#

I think it's an obfuscated cryptominer

odd heath
#

LOL

sterile oak
#

wish you can tell when a variable is made and where

brazen bone
#

Uh, what

#

They're declared by the let/const declaration

sterile oak
#

in devtools debugging

austere talon
#

?

shy veldt
#

shit is invalid

sterile oak
shy veldt
#

oh wait

#

did they push that build

#

without testing

#

i know what build this is

topaz spoke
sterile oak
topaz spoke
odd heath
#

holy professional devtools usage

sterile oak
#

bless you guys, gonna go and use my new skills

charred monolithBOT
austere talon
#

i was mainly asking why there even needs to be a limit in the first place (like as a setting), why u cant set the limit to like Infinity

#

but if its unstable, thats fair :p

charred monolithBOT
#

YES I KNOW THERE IS ALREADY A PR FOR THIS BUT THAT IS OLD AND OBSOLETE, ITS WAS JUST EASIER TO OPEN ANEW ONE. SINCE THAT ONE ABANDONED BY THE PERSON WHOM MADE IT

Shows profile badges in chat. That includes built in Discord Badges. Also shows Vencord Contributor Badges and all Donor badges (more sources of badges to most likely come soon)

shell shuttle
#

its very important

glass jasper
charred monolithBOT
charred monolithBOT
shell shuttle
#

offical

#

anywayyyys

#

i like the plugin and i'd use it

austere talon
glass jasper
austere talon
#

(im the one who edited the description)

glass jasper
#

ohh, idk then that wasn’t showing up for me

glass jasper
# charred monolith

@austere talon i didn’t make that was from the old devs. So Idk what to do there but i’ll see what i can do

charred monolithBOT
#

Fixes #1512

Works on Chrome extension + Chrome userscript

I ending up having to import the web worker file from unpkg because I was having trouble with bundling it into the userscript (Worker constructor needs a URL so I tried storing a blob of the entire file in the userscript, but that increased size by 70%)

Let me know if you prefer not fetching from unpkg (I tried bundling the encoderworker.min.js into the third-party folder and it worked for the extension but idk how to do ...

mortal fractal
#

well the good news is i can replicate it not loading properly on vencord

#

fun!

limber skiff
#

oh wtf

#

I have to be honest I didn't try it

#

but the reporter is working and it uses the same code?

mortal fractal
#

i dont think either of us are at fault

#

thats the annoying part here

#

which is why its confusing cause it works fine in the normal context its in

limber skiff
#

if you want to mess with the reporter look at the ci workfile and try in your machine

mortal fractal
#

if it requires docker then no

limber skiff
#

because there it's working 🤷

limber skiff
#

just you to build the script, build web with some arguments and put some environment vars needed

#

then run the script

mortal fractal
#

cba just going to keep throwing shit at the wall until i figure out why its not working

limber skiff
#

you can change headless to false to mess with devtools

limber skiff
# mortal fractal

can you try changing the entry point id group to the id used in the wreq call

#

instead of the webpackId

mortal fractal
#

they're the same id but i guess

limber skiff
#

ah

mortal fractal
#

i guess my regex was just too shit for it to pull properly

limber skiff
#

it worked?

mortal fractal
#

i was prob matching the first set of chunks

#

/createPromise:\(\)=>Promise\.all\((\[.+?\])\)\.then\(.\.bind\(.,"(\d+)"\)\),(?=webpackId:".+?",name:"GuildSettings")/ works

#

i think

#

its pulling a module but its still not grabbing what i need hm

limber skiff
#

yeah that's similar to the default regex I put for it

mortal fractal
#

okay this new regex is pulling every id now guh

#

/(?<="CollectiblesShop".+?)createPromise:\(\)=>Promise\.all\((\[.+?\])\)\.then\(.\.bind\(.,"(\d+)"\)\),(?=webpackId:"\d+",name:"GuildSettings")/

austere talon
#

pretty cool

grave mangoBOT
limber skiff
#

this is what I did

#

but that's for every

charred monolithBOT
#

Discord Account

No response

What happens when the bug or crash occurs?

When someone is typing in a channel you haven't opened before, it won't show the typing indicator on that channel

it might be that you have to subscribe to typing events via the gateway to get these events for not previously opened channels

What is the expected behaviour?

it should correctly display the typing indicator for all channels

How do you recreate this bug or crash?

  1. Restart discord
    ...
limber skiff
#

I never noticed that

austere talon
#

@median rapids tell

median rapids
#

oh

#

you subscribe per-guild

austere talon
#

that's odd, shouldn't it already be subbed to the current guild

median rapids
#

it def is

#

so this issue is something else lol

#

i'm sure the client is getting the events

charred monolithBOT
median rapids
swift fjord
#

auth/10

median rapids
#

eel

limber skiff
#

trying to hack me???????

#

banned from vendo

glass jasper
austere talon
#

gotdamn

austere talon
#

they think it's phishing

median rapids
#

skull

austere talon
#

imagine using chrome guh

median rapids
#

why did they flag the random git branch temp deploy

austere talon
#

hop on kiwi browser

limber skiff
#

what even is kiwi browser

austere talon
#

maybe like discord + vercel = spam?

glass jasper
median rapids
austere talon
limber skiff
#

is it chromium based

swift fjord
#

yes

#

its chrome android fork

limber skiff
#

I hate fireroz....

austere talon
limber skiff
#

that seems pretty hot

swift fjord
#

its chrome with a different font

median rapids
swift fjord
#

and icon set

austere talon
#

devtools on phone is cursed

median rapids
# austere talon

i feel like android will malfunction in mysterious ways if i change the default browser

swift fjord
#

well

median rapids
#

like the in-app browser stuff and the google app will just die

austere talon
swift fjord
#

custom tabs may not work depending on the browser settings

limber skiff
#

I don't even know how to change

austere talon
#

kiwi supports custom tabs + has adblock for them

limber skiff
#

I never did

median rapids
median rapids
swift fjord
#

for the most part its fine though

median rapids
#

someone will make magisk patch that fixes

austere talon
median rapids
#

then maybe i will root again

#

:blobcatcozy:

#

GUH

swift fjord
#

github doesn't show the browser i use when i open a gh link not supported by the app

limber skiff
#

I'm scared of rooting my phone and my bank app crying about it

median rapids
#

it will

#

but you can fix

austere talon
swift fjord
#

my bank app is literally just a webview wrapper

austere talon
#

i remember when i helped someone make an xposed module to bypass root detection in a brazilian banking app

median rapids
#

horror

austere talon
#

i think it was rini

median rapids
#

my banking app is oddly good

austere talon
#

but not sure

median rapids
#

ui is a little dated sometimes but mostly functional

#

canada banks are funny

swift fjord
#

id be more concerned with tap to pay

limber skiff
#

my bank is different from them I think though

#

it's called Nubank it's a virtual bank only

swift fjord
#

i only even use my bank app to check balance

#

nothing else

limber skiff
#

so maybe they will cry about root

median rapids
#

td canada trust on top >>

swift fjord
#

i don't think this is on topic anymore

limber skiff
#

also I think I'm gonna have to ask github to pay me again this month lmaoo

#

automatic payout fail

median rapids
austere talon
#

anyway like root detection is really hard now so it's usually not a big deal

#

worst case scenario you have to put smth on zygisk hidelist

median rapids
#

oh yeah

#

discord gave me green spoon today

limber skiff
#

what do you mean

#

oh

#

the badge?

median rapids
#

yop

limber skiff
#

is it even hard to get

austere talon
#

🐛 🍽

median rapids
#

idk lol

limber skiff
#

like how many actual bugs you gotta report

median rapids
#

i never bothered asking till now

median rapids
limber skiff
#

they just gave to you?

austere talon
#

how do u even report bugs

i remember trying to but it was closed

median rapids
#

cuz of sec

austere talon
median rapids
#

client bugs are too annoying

limber skiff
#

sec?

median rapids
median rapids
austere talon
#

urity

limber skiff
#

ah

lime stone
#

for some reason ages ago i submitted a report saying that you could call deleted user WHAT

swift fjord
#

anyone can report security bugs

median rapids
#

yop

swift fjord
#

the form is open

median rapids
limber skiff
#

did you report the soundboard thing dolfies

median rapids
#

nah

lime stone
#

abuse it

limber skiff
#

I might make a patch for fake nitro for it lmao

median rapids
#

go for it lol

swift fjord
#

its hard to report a bug in dtesters bc like 500 people would have beaten you to it

median rapids
#

also they dont care lol

#

i reported mfa bypass meowlien

swift fjord
#

the android rn client is so broken its insane

median rapids
#

honestly this version is working okish for me on tabs v1 override

lime stone
median rapids
#

blobcatcozy emoji

swift fjord
median rapids
#

ya that never has

#

with tabs v1

#

it was added after they stopped working on it

swift fjord
#

guh

austere talon
#

how do you even find shit like mfa bypass

#

do you just try all sorts of weird things

swift fjord
#

i forced dolfer to work on auth docs

austere talon
#

normally when i find a bug it's cause i randomly stumbled across it xd

median rapids
#

i found it while documenting mfa

#

lmao

austere talon
#

funny

#

is it fixed yet

median rapids
#

yop

#

that's why i can share

swift fjord
#

if i didn't make dolfer do docs then it wouldn't have gotten fixed as soon

median rapids
#

this was almost def getting abused

#

for ato

swift fjord
#

my custom client making an impact before it has any ui

median rapids
#

wing will finish the entire chat ui in one day

swift fjord
#

guh

median rapids
#

one day per api route section

swift fjord
#

i don't even have gateway implemented

median rapids
#

day 1: /users

#

seems doable

swift fjord
#

i think its funny that the mfa enabled setting is on the user object

#

not with any of the other settings

median rapids
#

cuz it's not a setting

#

it's a property

swift fjord
#

it feels more like a setting to me

austere talon
#

damn https://www.ato.gov.au abusing discord vulns?

#

naughty

swift fjord
#

Antifa
Transgender
Offensive

median rapids
#

account take-over silly

swift fjord
#

don't call them silly

#

be nice >:(

austere talon
lime stone
long stream
median rapids
#

lmao

median rapids
austere talon
#

(i will)

long stream
#

only sensible reason i can think of is microsoft told google to block it cuz it lets u enable europe mode without being in the eu

#

thus letting u uninstall edge

median rapids
#

i really doubt it

swift fjord
#

i will submit vencord.dev to various spam lists

swift fjord
austere talon
#

money

long stream
austere talon
swift fjord
#

"yeah i want fewer people to use my data harvester"

long stream
#

either that or they let their llm decide

shell shuttle
#

who wants to forward me bug bounties so i can make money 🗣️ 💯 🔥

lime stone
#

don't remind me...

median rapids
swift fjord
#

discord makes 5 million api changes a day

#

just get lucky

frail skyBOT
#
Bad Patches

MemberListDecoratorsAPI (had no effect):
ID: 888503
Match: /\.Messages\.GUILD_OWNER(?=.+?decorators:(\i)\(\)).+?\1=?\(\)=>.+?children:\[/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

did u fix reporter btw @limber skiff

limber skiff
#

yeah

austere talon
#

oh okay

limber skiff
#

but the message is giving 400 bad request because its too large

austere talon
#

why didn't u run it then

austere talon
limber skiff
#

yeah

austere talon
#

are u sure it's not false positives

limber skiff
#

look at the summary

#

hmm I'm not sure

#

but I dont think it is

austere talon
#

seems like false positive

#

so many failed finds

#

when i tried earlier, no finds were broken

limber skiff
#

if you look at the devtools requests it's loading a lot of stuff

odd heath
#

Discord will merge into stable this night and everything will be broken venniecozycat

mortal fractal
#

good

charred monolithBOT
charred monolithBOT
austere talon
#

stable exploder @limber skiff

austere talon
#

yeah its def false positives nookies

#

trying some of those finds, all work fine

#

funny BetterSettings immediately broke

austere talon
#

wtf is this bro

odd heath
#

Surely they will revert

limber skiff
umbral hedge
#

Surely I will meow

austere talon
#

not that much broke

#

smth broke on my server

umbral hedge
#

i gotta fix my script finder regex

#

grrr

austere talon
#

oh god is this cause my vps is ratelimited from discord

#

😭

#

ve

umbral hedge
#

lmfao

austere talon
#

btw ghwp is broken as well due to it

#

so no webhook notifs for repos

umbral hedge
austere talon
#

painful

#

they use this fucking shit everywhere

#

to assign properties

#

wtf is that bro

umbral hedge
#

guh

umbral hedge
austere talon
#

heres whats still broken (on first glance)

#

wait i forgot to fix FakeNitro

#

ShowHiddenChannels seems to work kinda so not important

#

wait it seems to work?

#

hmm no

#

i hate u discord

#

how am i gonna test this

sly veldt
#

@austere talon just confirmed that my role color patch still works if you're interested https://github.com/Vendicated/Vencord/pull/2161
Even though it uses a lot of patches to transport the user's color to the bot tag in each specific place, it's still working on the latest discord version

GitHub

This feature is inspired by https://github.com/Puyodead1/replugged-stafftags
It took me 3 hours to figure out how to do this in Vencord and I'm so glad I did because it looks just so much bette...

#

(just fyi)

#

Thanks for all your awesome work fixing vencord

rugged spire
#

i wonder how many of my plugins are broken

#

none

#

OH COME ON

#

MY CUSTOM CSS

spark pivot
#

i am never reloading discord

#

i am at peace being before the update

austere talon
#

many things alr fixed

rugged spire
#

WhoReacted seems to be broke Thinkies

#

Doesnt show any patches as broken though

rugged spire
#

@austere talon I love your commit name lmfao

rugged spire
brazen bone
gritty iris
austere talon
#

stable

brazen bone
#

That's weird, because on stable everything seems to be working for me

austere talon
#

restart

gritty iris
#

everything went boom

brazen bone
#

Reloading changes nothing, both in browser and discord-desktop

#

On canary everything's fucked and even things like vencord toolbox and plugins tab error

#

On dev branch

rugged spire
#

Whats wrong with vc toolbox on canary?

#

I'm running dev branch and its fine

#

On canary

brazen bone
#

Huh, now it works

austere talon
brazen bone
#

Maybe there was some caching going on

austere talon
rugged spire
brazen bone
#

But I don't seem to be getting the apocalypse update

austere talon
#

it's not that bad

#

just like 10 broken plugins

brazen bone
#

Yeah but I mean, I can't reproduce the failure

#

Oh wait here it is

austere talon
#

how

austere talon
#

yeppers

brazen bone
#

Why were warnings toggled off in devtools

#

Who did that, it certainly wasn't me

still wasp
#

Gah damn i just deleted the fork bruhsk

#

Rate the fork name

austere talon
#

lmao

#

why did u delete form

#

wait github webhook is back

still wasp
#

Oh it is

austere talon
#

does that mean my server got unbanned

still wasp
#

Perchance

austere talon
#

negative

still wasp
#

Rip

austere talon
#

idk how those went through

still wasp
rugged spire
#

vee

#

you do know github servers are not your vps

austere talon
rugged spire
#

HUH

#

hm

charred monolithBOT
shell shuttle
charred monolithBOT
#

Discord Account

swewzeex

What happens when the bug or crash occurs?

themes don't work

What is the expected behaviour?

themes don't work

How do you recreate this bug or crash?

themes don't work

Errors

Replace this text with your crash-log.

Request Agreement

  • [X] I am using Discord Stable or tried on Stable and this bug happens there as well
  • [X] I have read the requirements for opening an issue above
mint thistle
#

bruh

rugged spire
cunning canyon
#

they expect theme dont work

charred monolithBOT
rugged spire
charred monolithBOT
charred monolithBOT
charred monolithBOT
lime stone
#

have we got a list of broken stuff

lime stone
#

o.o i just fixed a patch but upon reloading the page the code went back to what it was before? wtf

#

why did I sometimes see the old code (this.setTimeout =) and sometimes the new code (which uses Object.defineProperty)

#

some weird caching thing? goodness knows

#

perhaps actually running watch helps

lime stone
charred monolithBOT
brazen bone
#

From what I can tell, the differences between this bullshit and normal assignments are

  • does not invoke setters
  • returns object rather than value
limber skiff
#

now the question is why

topaz spoke
#

links don't even display anymore

brazen bone
#

Links where?

topaz spoke
brazen bone
#

Huh

#

No funny themes?

topaz spoke
#

oh nvm

#

custom css was the issue

charred monolithBOT
limber skiff
#

@austere talon are you sure it's false positives? these are matches that didnt have effect, not finds

#

these are the finds

austere talon
#

at least the webpack finds have to be false positives

limber skiff
#

the stores seems to be right

#

isStaff is right too

austere talon
#

no

#

check some of the webpack finds

#

run them in console

#

they work

limber skiff
#

look at the amount of modules

limber skiff
austere talon
#

yes

limber skiff
#

there is none

austere talon
#

🤔

#

was i looking at old report

#

i checked the newest one i saw

#

it contained dozens of webpack finds

limber skiff
#

maybe you were looking at the stable one?

#

the reporter wasnt working in stable

austere talon
#

oh

#

maybe

limber skiff
#

let me fix these stores finds and run again

austere talon
#

well anyway fixing the rest of plugins shouldn't be hard

#

most fixes are easy

#

just assignment changes

limber skiff
#

yeah

#

omg why

#

why here it's different

charred monolithBOT
austere talon
#

that function defines property just like that

limber skiff
#

yeah ik

austere talon
#

ig if module only has one single assignment it inlines it

charred monolithBOT
austere talon
#

otherwise it uses func

charred monolithBOT
limber skiff
#

ohh fuck

austere talon
#

lmao

#

love how it says me

#

tbh we need to fix that somehow, it's annoying

#

just push dev again after waiting a bit

#

let's fix the rest of the plugins then merge into main and release extension

charred monolithBOT
limber skiff
#

I'm running the reporter

frail skyBOT
#
Bad Patches

DisableCallIdle (had no effect):
ID: 288444
Match: /,?(?=this\.idleTimeout=new \i\.Timeout)/

IgnoreActivities (had no effect):
ID: 293273
Match: /HANG_STATUS.+?(?=!\i\(\i,\i\)&&)(?<=(\i)\.push.+?)/

BetterGifPicker (had no effect):
ID: 455708
Match: this.state={resultType:null}

Decor (had no effect):
ID: 818611
Match: /(?<=\.Section\.PREMIUM_PURCHASE&&\i;if\()(?<=avatarDecoration:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /(?<=renderHeaderToolbar=\(\)=>{.+?case \i\.\i\.GUILD_TEXT:)(?=.+?(\i\.push.{0,50}channel:(\i)},"notifications"\)\)))(?<=isLurking:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /(?<=renderHeaderToolbar=\(\)=>{.+?case \i\.\i\.GUILD_MEDIA:)(?=.+?(\i\.push.{0,40}channel:(\i)},"notifications"\)\)))(?<=isLurking:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /renderMobileToolbar=\(\)=>{.+?case \i\.\i\.GUILD_DIRECTORY:(?<=let{channel:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /(?<=renderHeaderBar=\(\)=>{.+?hideSearch:(\i)\.isDirectory\(\))/

ShowHiddenChannels (had no effect):
ID: 424785
Match: /(?<=renderOpenChatButton=\(\)=>{)/

ShowHiddenChannels (had no effect):
ID: 831700
Match: /(?<=renderOpenChatButton=\(\)=>{)/

ShowHiddenChannels (had no effect):
ID: 968847
Match: /(?<=if\(null==(\i))(?=.{0,160}?getHasImportantUnread\)\(\i\))/g

BetterSettings (had no effect):
ID: 718813
Match: /(?<=(\i)\.contextType=\i\.AccessibilityPreferencesContext;)/

BetterSettings (had no effect):
ID: 720734
Match: /(?<=handleOpenSettingsContextMenu.{0,250}?\i\.el\(("[^"]+")\)\.then\([^;]*?("\d+").*?Messages\.USER_SETTINGS,)(?=onClick:)/

ResurrectHome (had no effect):
ID: 199140
Match: /return{showFeedback:\i,setOnDismissedFeedback:(\i)}/

BetterGifAltText (found no module):
ID: -
Match: onCloseImage=

Experiments (found no module):
ID: -
Match: .isStaff=()

GifPaste (found no module):
ID: -
Match: .handleSelectGIF=

NoBlockedMessages (found no module):
ID: -
Match: ="ReadStateStore",

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

DisableCallIdle (had no effect):
ID: 288444
Match: /,?(?=this\.idleTimeout=new \i\.Timeout)/

IgnoreActivities (had no effect):
ID: 293273
Match: /HANG_STATUS.+?(?=!\i\(\i,\i\)&&)(?<=(\i)\.push.+?)/

BetterGifPicker (had no effect):
ID: 455708
Match: this.state={resultType:null}

Decor (had no effect):
ID: 818611
Match: /(?<=\.Section\.PREMIUM_PURCHASE&&\i;if\()(?<=avatarDecoration:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 424785
Match: /(?<=renderOpenChatButton=\(\)=>{)/

ShowHiddenChannels (had no effect):
ID: 831700
Match: /(?<=renderOpenChatButton=\(\)=>{)/

ShowHiddenChannels (had no effect):
ID: 968847
Match: /(?<=if\(null==(\i))(?=.{0,160}?getHasImportantUnread\)\(\i\))/g

ShowHiddenChannels (had no effect):
ID: 823748
Match: /(?<=renderHeaderToolbar=\(\)=>{.+?case \i\.\i\.GUILD_TEXT:)(?=.+?(\i\.push.{0,50}channel:(\i)},"notifications"\)\)))(?<=isLurking:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /(?<=renderHeaderToolbar=\(\)=>{.+?case \i\.\i\.GUILD_MEDIA:)(?=.+?(\i\.push.{0,40}channel:(\i)},"notifications"\)\)))(?<=isLurking:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /renderMobileToolbar=\(\)=>{.+?case \i\.\i\.GUILD_DIRECTORY:(?<=let{channel:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /(?<=renderHeaderBar=\(\)=>{.+?hideSearch:(\i)\.isDirectory\(\))/

BetterSettings (had no effect):
ID: 718813
Match: /(?<=(\i)\.contextType=\i\.AccessibilityPreferencesContext;)/

BetterSettings (had no effect):
ID: 720734
Match: /(?<=handleOpenSettingsContextMenu.{0,250}?\i\.el\(("[^"]+")\)\.then\([^;]*?("\d+").*?Messages\.USER_SETTINGS,)(?=onClick:)/

ResurrectHome (had no effect):
ID: 199140
Match: /return{showFeedback:\i,setOnDismissedFeedback:(\i)}/

BetterGifAltText (found no module):
ID: -
Match: onCloseImage=

Experiments (found no module):
ID: -
Match: .isStaff=()

GifPaste (found no module):
ID: -
Match: .handleSelectGIF=

NoBlockedMessages (found no module):
ID: -
Match: ="ReadStateStore",

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

this is so fast

#

oop that store didnt fix

austere talon
#

literally all of these are assignments

#

where it's likely few character change to fix

#

should be easy to fix

#

btw there is BetterSettings pr

limber skiff
limber skiff
austere talon
#

yeah it's basically just ```diff

  • .foo=
  • "foo",
limber skiff
#

omg dont do that @lime stone DSXFJDFDSS

#

keep it to dev

lime stone
#

ohh

#

now i have to rerebase

#

dev is outdated

charred monolithBOT
limber skiff
#

I got you @lime stone

lime stone
#

oh i already rerebased to dev

austere talon
#

what happened

limber skiff
#

they changed their pr base to webpack-changes when I was going to merge it

#

??

long stream
#

i think they really wanna know how to fix supports

austere talon
#

blocked & reported just ignore

#

why not the first, did u alr fix?

limber skiff
#

ohh so better settings does this

austere talon
#

eager load yeah

limber skiff
#

I dont really like the creation of that new key

austere talon
#

why

#

it doesn't matter

#

although i'd maybe use something unique instead of _

limber skiff
#

could do some magic with comma operator instead

austere talon
#

like vcBsExplode

limber skiff
#

(Promise.all..., () => the normal stuff)

brazen bone
limber skiff
#

it's whatever

charred monolithBOT
austere talon
#

BetterMenu?

brazen bone
#

Oh

limber skiff
#

oh lmao

brazen bone
#

I'm forgetting my own plugin names

limber skiff
#

Bad Patches

  • IgnoreActivities (had no effect)
    • ID: 293273
    • Match: /HANG_STATUS.+?(?=!\i\(\i,\i\)&&)(?<=(\i)\.push.+?)/
  • Decor (had no effect)
    • ID: 818611
    • Match: /(?<=\.Section\.PREMIUM_PURCHASE&&\i;if\()(?<=avatarDecoration:(\i).+?)/
  • ShowHiddenChannels (had no effect)
    • ID: 823748
    • Match: /(?<=renderHeaderToolbar=\(\)=>{.+?case \i\.\i\.GUILD_TEXT:)(?=.+?(\i\.push.{0,50}channel:(\i)},"notifications"\)\)))(?<=isLurking:(\i).+?)/
  • ShowHiddenChannels (had no effect)
    • ID: 823748
    • Match: /(?<=renderHeaderToolbar=\(\)=>{.+?case \i\.\i\.GUILD_MEDIA:)(?=.+?(\i\.push.{0,40}channel:(\i)},"notifications"\)\)))(?<=isLurking:(\i).+?)/
  • ShowHiddenChannels (had no effect)
    • ID: 823748
    • Match: /renderMobileToolbar=\(\)=>{.+?case \i\.\i\.GUILD_DIRECTORY:(?<=let{channel:(\i).+?)/
  • ShowHiddenChannels (had no effect)
    • ID: 823748
    • Match: /(?<=renderHeaderBar=\(\)=>{.+?hideSearch:(\i)\.isDirectory\(\))/
  • ShowHiddenChannels (had no effect)
    • ID: 424785
    • Match: /(?<=renderOpenChatButton=\(\)=>{)/
  • ShowHiddenChannels (had no effect)
    • ID: 831700
    • Match: /(?<=renderOpenChatButton=\(\)=>{)/
  • ShowHiddenChannels (had no effect)
    • ID: 968847
    • Match: /(?<=if\(null==(\i))(?=.{0,160}?getHasImportantUnread\)\(\i\))/g
  • ResurrectHome (had no effect)
    • ID: 199140
    • Match: /return{showFeedback:\i,setOnDismissedFeedback:(\i)}/
  • BetterGifAltText (found no module)
    • ID: -
    • Match: onCloseImage=
  • GifPaste (found no module)
    • ID: -
    • Match: .handleSelectGIF=
charred monolithBOT
limber skiff
#

👍

#

I wish they heavily merged modules again

#

it was nice tbh

charred monolithBOT
limber skiff
#

FUCK OFF

charred monolithBOT
limber skiff
#

it should just be hidden channels stuff now

#

what

#

where are my commits

#

I'm so dumb

charred monolithBOT
frail skyBOT
#
Bad Patches

ShowHiddenChannels (had no effect):
ID: 823748
Match: /(?<=renderHeaderToolbar=\(\)=>{.+?case \i\.\i\.GUILD_TEXT:)(?=.+?(\i\.push.{0,50}channel:(\i)},"notifications"\)\)))(?<=isLurking:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /(?<=renderHeaderToolbar=\(\)=>{.+?case \i\.\i\.GUILD_MEDIA:)(?=.+?(\i\.push.{0,40}channel:(\i)},"notifications"\)\)))(?<=isLurking:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /renderMobileToolbar=\(\)=>{.+?case \i\.\i\.GUILD_DIRECTORY:(?<=let{channel:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /(?<=renderHeaderBar=\(\)=>{.+?hideSearch:(\i)\.isDirectory\(\))/

ShowHiddenChannels (had no effect):
ID: 424785
Match: /(?<=renderOpenChatButton=\(\)=>{)/

ShowHiddenChannels (had no effect):
ID: 831700
Match: /(?<=renderOpenChatButton=\(\)=>{)/

ShowHiddenChannels (had no effect):
ID: 968847
Match: /(?<=if\(null==(\i))(?=.{0,160}?getHasImportantUnread\)\(\i\))/g

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

yippie

frail skyBOT
#
Bad Patches

ShowHiddenChannels (had no effect):
ID: 424785
Match: /(?<=renderOpenChatButton=\(\)=>{)/

ShowHiddenChannels (had no effect):
ID: 831700
Match: /(?<=renderOpenChatButton=\(\)=>{)/

ShowHiddenChannels (had no effect):
ID: 968847
Match: /(?<=if\(null==(\i))(?=.{0,160}?getHasImportantUnread\)\(\i\))/g

ShowHiddenChannels (had no effect):
ID: 823748
Match: /(?<=renderHeaderToolbar=\(\)=>{.+?case \i\.\i\.GUILD_TEXT:)(?=.+?(\i\.push.{0,50}channel:(\i)},"notifications"\)\)))(?<=isLurking:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /(?<=renderHeaderToolbar=\(\)=>{.+?case \i\.\i\.GUILD_MEDIA:)(?=.+?(\i\.push.{0,40}channel:(\i)},"notifications"\)\)))(?<=isLurking:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /renderMobileToolbar=\(\)=>{.+?case \i\.\i\.GUILD_DIRECTORY:(?<=let{channel:(\i).+?)/

ShowHiddenChannels (had no effect):
ID: 823748
Match: /(?<=renderHeaderBar=\(\)=>{.+?hideSearch:(\i)\.isDirectory\(\))/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
#

well lets see

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

@austere talon we are so back

odd heath
austere talon
#

nice

odd heath
#

That was less bad than I expected

charred monolithBOT
austere talon
#

im currently figuring out how to fetch 100k users a day

odd heath
#

Why

austere talon
limber skiff
#

why

austere talon
#

reviewdb

limber skiff
#

💀

austere talon
#

we need to update usernames and avatars

limber skiff
#

honestly I think the only way is for you to abuse the websocket

austere talon
#

anyway we have a plan thanks to idk if i should name them

#

ill dm

limber skiff
#

for the users that are in the server maybe

#

oop gonna add a new patch to fake nitro

charred monolithBOT
austere talon
#

you can technically do it with electron @brazen bone

#

electron can screenshot browser windows

#

so you can create new browser window, write html, get bounds of the katex container then screenshot that section

brazen bone
#

Hm

austere talon
#

by create new browser window i mean like a popup, you can use discords popup api for it

#

it's gonna be a bit cursed and require ipc

brazen bone
#

Possibility aside, I'm not sure what would be a good ui/ux for it

austere talon
#

i mean you're desktop anyway no?

brazen bone
#

I meant how to invoke the rendering in the first place

#

Though I guess a slash command wouldn't be too bad

charred monolithBOT
limber skiff
#

@austere talon should we merge and release browser?

charred monolithBOT
frail skyBOT
#
Bad Patches

ReverseImageSearch (had no effect):
ID: 240678
Match: /favoriteableType:\i,(?<=(\i)\.getAttribute\("data-type"\).+?)/

MessageEventsAPI (had no effect):
ID: 430036
Match: /(type:this\.props\.chatInputType.+?\.then\()(\i=>\{.+?let (\i)=\i\.\i\.parse\((\i),.+?let (\i)=\i\.\i\.getSendMessageOptionsForReply\(\i\);)(?<=\)\(({.+?})\)\.then.+?)/

Bad Webpack Finds

findComponentByCode("renderSimpleAccessories)")

Bad Starts

None

Discord Errors

Cannot read properties of undefined (reading 'call')

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

oh

#

okay

#

huhh

austere talon
#

how's it still broke

#

also goofy discord error

limber skiff
#

I'm running again

#

because it's working

#

and I just ran on my machine and it's working fine

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

🤷

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

okay anyways everything works

charred monolithBOT
limber skiff
#

should I push the tag and trigger browser extension?

charred monolithBOT
austere talon
#

uhh let me see first and maybe we can merge some prs too

limber skiff
#

everything is nice so I pushed to main already

austere talon
#

ya looks good

charred monolithBOT
limber skiff
#

better be safe than having things explode

austere talon
#

wait what