just its waaayy cleaner and it will allow us to also use it in main process
#š¾-core-development
austere talon
and we will be able to listen to settings changes from renderer in the main process
// in main
VencordSettings.addChangeListener("idkSomeThing", () => console.log("changed"));
// in renderer
Settings.idkSomeThing = true;
idk how you did that
its actually super simple
austere talon
no its via ipc
austere talon
grave mangoBOT
https://github.com/Vencord/Vesktop/blob/main/src/renderer/settings.ts#L11
https:...
**settings.ts: **Line 11
Settings.addGlobalChangeListener((o, p) => VesktopNative.settings.set(o, p));
**ipc.ts: **Lines 48-50
handle(IpcEvents.SET_SETTINGS, (_, settings: typeof Settings.store, path?: string) => {
Settings.setData(settings, path);
});
you just made the proxy wrap the ipc
grave mangoBOT
https://github.com/Vencord/Vesktop/blob/main/src/shared/utils/SettingsStore.ts#L...
**SettingsStore.ts: **Lines 78-92
if (pathToNotify) {
let v = value;
const path = pathToNotify.split(".");
for (const p of path) {
if (!v) {
console.warn(
`Settings#setData: Path ${pathToNotify} does not exist in new data. Not dispatching update`
);
return;
}
v = v[p];
}
this.pathListeners.get(pathToNotify)?.forEach(cb => cb(v));
rugged spire
austere talon
it just sends the path that was changed via ipc and then it dispatches an update for that path in main too
well i havent implemented that in vencord yet
only vesktop
rugged spire
i fucking hate how discord implements popout windows
it is all controlled by the parent window
leading to that
charred monolithBOT
limber skiff
that's crazy good
austere talon
now you can subscribe to settings changes of your plugin in your native.ts file as well
charred monolithBOT
limber skiff
can you somehow make settings not explode at first run
limber skiff
like you cant access at the time the renderer script runs
austere talon
this should be && not ||
oooooh
well actually yeah we can fix that now but
the reason that happens is that it requires plugins to be initialised so it can auto fill default values
rugged spire
i fucking hate how discord implements popout windows
explode
charred monolithBOT
austere talon
need to test that this works fully
limber skiff
the reason that happens is that it requires plugins to be initialised so it can ...
and how can you fix now
austere talon
and then can merge
austere talon
and how can you fix now
we can fix it but with one limitation: it wont be able to handle default values on the top level
limber skiff
i guess that's okay
austere talon
and how can you fix now
by moving the thing that handles default values to a different file
// api/index.ts
import Settings from "./Settings";
import "./addSettingsDefaultValueGetterSettingsStoreCallback";
then you can import from Settings freely without causing a circular import
seems to work flawlessly
can u guys also test that pr
oh wait
hmm
charred monolithBOT
austere talon
hmmm
actually this will still cause issues if
this will still error
Cannot access settings before plugin is initialized
so you cannot use store but you can use Settings global manually
well ready for review and testing
charred monolithBOT
rugged spire
will vencord ever go a day without someone suggesting/saying some stupid shit that makes no sense or is impossible
is that possible?
charred monolithBOT
austere talon
i wanna do more refactoring next
i wanna restructure the project a little
its bad that everything is in @utils and all processes import from it
i want to move everything that is shared across processes into the shared folder so its clearer
to make sure not to introduce dom usage in those files cause that happened in the past and bricked updater
optimally i'd want to move everything into a renderer folder for stronger isolation but that would ruin history
limber skiff
lmao no way they used a attachment for that
rugged spire
real
rugged spire
just look for super-reactions-launch
its real
what the fuck
this code is actual dogshit
like the rest of discord code
idle meteor
austere talon
this code is actual dogshit
?
you're using the function wrong
not even passing a channel id
your skill issue = discord code bad?
rugged spire
nop
verbal pumice
what the fuck
wheres the channel id?? lmao
rugged spire
nvm
doesnt matter
I found what I was looking for
wasted 20 minutes stepping over shit in debugger
rugged spire
It never got typed 
charred monolithBOT
limber skiff
@austere talon I'm not sure if I see how updating a setting on the renderer updates it on the electron side too
when you change a setting it saves to the file
but you only read the file once, how does the electron side reflect the change
brazen bone
I wonder why the lottie/bodymovin module is not name-mangled ```js
function(module,exports,webpack_require){module=webpack_require.nmd(module),webpack_require("854508"),...
lmao funny
brazen bone
It does still have all other minification stuff, just not name mangling
austere talon
<@343383572805058560> I'm not sure if I see how updating a setting on the render...
https://github.com/Vendicated/Vencord/blob/settingsStore/src/api/Settings.ts#L162-L167
https://github.com/Vendicated/Vencord/blob/settingsStore/src/main/rendererSettings.ts#L35-L37
https://github.com/Vendicated/Vencord/blob/settingsStore/src/shared/SettingsStore.ts#L97-L121
https://github.com/Vendicated/Vencord/blob/settingsStore/src/main/rendererSettings.ts#L28-L30
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/settingsStore/src/api/Settings.ts#L16...
**Settings.ts: **Lines 162-167
SettingsStore.addGlobalChangeListener((_, path) => {
SettingsStore.plain.cloud.settingsSyncVersion = Date.now();
localStorage.Vencord_settingsDirty = true;
saveSettingsOnFrequentAction();
VencordNative.settings.set(SettingsStore.plain, path);
});
**rendererSettings.ts: **Lines 35-37
ipcMain.handle(IpcEvents.SET_SETTINGS, (_, data: Settings, pathToNotify?: string) => {
RendererSettings.setData(data, pathToNotify);
});
**SettingsStore.ts: **Lines 97-121
public setData(value: T, pathToNotify?: string) {
if (this.readOnly) throw new Error("SettingsStore is read-only");
this.plain = value;
this.store = this.makeProxy(value);
if (pathToNotify) {
let v = value;
const path = pathToNotify.split(".");
for (const p of path) {
if (!v) {
console.warn(
`Settings#setData: Path ${pathToNotify} does not exist in new data. Not dispatching update`
);
return;
}
v = v[p];
}
this.pathListeners.get(pathToNotify)?.forEach(cb => cb(v));
}
this.markAsChanged();
}
**rendererSettings.ts: **Lines 28-30
RendererSettings.addGlobalChangeListener(() => {
writeFileSync(SETTINGS_FILE, JSON.stringify(RendererSettings.plain, null, 4));
});
austere talon
no
changing it on main doesn't update renderer
there isn't much demand for changing settings on main side imo
limber skiff
yeah that's what I noticed
austere talon
what's a use case
i plan to add a second settings file: main settings
that are only accessible in main
this can be used for more security sensitive stuff like whitelisting url for csp, or whitelisting a folder that the renderer can read files from via ipc
austere talon
the way it currently works it's not really possible to update both ways
the settings store in renderer is read only because i export its .store member
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/settingsStore/src/api/Settings.ts#L18...
**Settings.ts: **Line 183
export const Settings = SettingsStore.store;
setData changes the store so that will break
limber skiff
yeah
makes sense
I mean
store is a proxy
the inner object can change no?
somehow
austere talon
**Settings.ts: **Line 183
```ts
export const Settings = SettingsStore.store;
```
we could also refactor all vencord code to use .store, but that would also break snippets and such
austere talon
the inner object can change no?
not really no
limber skiff
cant we make the inner obj a dummy
and return values from another
so technically the proxy is empty but it has values
austere talon
that's very meh
austere talon
well actually
instead of changing the root object we could recursively merge the object
via Object.assign
limber skiff
that is true
limber skiff
do you have any idea why pindms break
like I don't even know how to even start debugging that
austere talon
cause it causes issues with the lazyscroller
limber skiff
well that's a start
but that seems like super hard to debug
and I would need to make it happen to me which idk how to
austere talon
close all dms that aren't pinned
limber skiff
might as well pin all lmao
limber skiff
true
austere talon
tbh idc about PinDms
so i never bothered fixing it
i only made it because people wanted it and i was bored
btw there is a category pr
limber skiff
I would fix but it's a so weird bug
austere talon
take a look at it and work on that instead
austere talon
take a look at it and work on that instead
but it doesn't fix the issues either
limber skiff
yeah
austere talon
I would fix but it's a so weird bug
well i know why it happens but
working with discords lazy scrollers is a nightmare
i already had so many bugs when i wrote the plugin
that i took long to fix xd
limber skiff
horror
austere talon
maybe from native scripts
i think for now ill change stores so that you can't change settings in main at all to prevent confusion
and introduce a native settings api
if there's ever demand to change renderer settings from main we can add it
limber skiff
sure
austere talon
id rather not overengineer it rn if there's no use case
limber skiff
yeye you are right
sterile oak
looks doable
but its so small, its not worth adding
so maybe add more features like channel/user/whatever is there
brazen bone
Having something like copy emoji id just like copy channel id and all that would make sense
topaz spoke
||server ban 
||
grizzled halo
sooner or later you'd get banned from discord too
brazen bone
It's even easier to not do things that get you banned in the first place
grizzled halo
the reason animated status is against the rules is because discord hates selfbots/api abuse
they do ban for api and selfbots
no
they still do
its not a matter of if, but when
it is actually
uses the (discord) api that it was not intended to be used for
they will see it (eventually) and will ban you for it
topaz spoke
tbh animated status is pretty useless
grizzled halo
weird flex
austere talon
follow the rules or you will be banned
vban 7 @woeful sable continuous discussion of banned plugins
nimble pendantBOT
vban 7 <@456226577798135808> continuous discussion of banned plugins
Done! 
manic root
i just loaded 20 alts in here, not hard
š
you might wanna slow mode channels there is about to be a wave of spam
odd heath
i just loaded 20 alts in here, not hard
Discord shows when people joined and alts are pretty obvious so you gained nothing
manic root
Discord shows when people joined and alts are pretty obvious so you gained nothi...
the whole point isnt to hide
you're kinda slow
verbal pumice
you might wanna slow mode channels there is about to be a wave of spam
great argument however The Fog Is Coming
grizzled halo
oh no! anyways
odd heath
the whole point isnt to hide
We can just select them all and ban with 1 click stop yapping
glass jasper
great argument however The Fog Is Coming
slim marsh
you might wanna slow mode channels there is about to be a wave of spam
lol
bros so tough
since when is this channel not locked to regulars/contribs
topaz spoke
i just loaded 20 alts in here, not hard
odd heath
since when is this channel not locked to regulars/contribs
Since channels got mvoed
glass jasper
Since channels got mvoed
Letās bring back that requirement. as a matter of fact, letās close all dev channels from white names talking in them
odd heath
twilit fiber
Letās bring back that requirement. as a matter of fact, letās close all dev chan...
true
mint thistle
nooooo iām a white name
mint thistle
i just loaded 20 alts in here, not hard
patent flint
sterile oak
i just loaded 20 alts in here, not hard
what? why does this guy want to spam the server?
glass jasper
nooooo iām a white name
OK, letās bring back the programming role. so if a white name wants to talk and one of the channels, they can ask for permission, but if needed, it could be taken very easily.
gloomy atlas
maybe by adding linked role
charred monolithBOT
limber skiff
don't mind about it
they can just disable if they dont want
I never receive any emails like that
mint thistle
I remember that one story where someone emailed every single epic games employee because of a Github Organization Teams mis-mention
limber skiff
funny
mint thistle
i feel bad that this channel gets flooded with my PR comments
brazen bone
Better than those new star notices
still wasp
Better than those new star notices
Why do they even exist š
mint thistle
clearly you haven't seen me flood it with 50 comments, commits and such
i havenāt seen that yet 
lime stone
sorry if i'm being annoying but wouldn't it be nice if the webhook thing auto-completed for channels where you have perm
mint thistle
sorry if i'm being annoying but wouldn't it be nice if the webhook thing auto-co...
like if thereās a webhook in the channel itāll auto copy into the url parameter?
lime stone
you know how there's a box which appears while you're typing the command, showing the possible values?
idk how easy it is though
mint thistle
or if it notices that youāre in a server that the webhook has the same serverid/channelid for itāll automatically show something like āSending message to ā#testā in Balls Serverā
mint thistle
you know how there's a box which appears while you're typing the command, showin...
hmmm
havenāt seen that
lime stone
like this thing
mint thistle
it might be really difficult
but iāll keep it in the back of my mind if i can think of a way to do it
lime stone
well, discord already implements a way for the bot to respond with a list of strings
mint thistle
that makes it a little easier
but gathering the URLs is gonna be the difficult part
for one of the suggestions
is it just as easy as making the command name [webhook send]
or do i need to like
do other complicated stuff to achieve that
lime stone
but gathering the URLs is gonna be the difficult part
isn't there an endpoint to get all of them idk
i hope this is legal
glass jasper
like this thing
ayo i got a shoutout in that photo
lime stone
i didn't show any usernames in case anyone minds 
mint thistle
is it just as easy as making the command name [webhook send]
iām almost there to fixing every suggestion this is the only thing i need to know
glass jasper
Iām a start taking a shot for every single time you submit a new comment
mint thistle
LMAO
i mean i donāt wanna be rude and just close comments without reasoning 
inb4 i could just respond here
yea i could idk why iām not doing that
glass jasper
itās fine iām just messing with messing with you
mint thistle
austere talon
i mean i donāt wanna be rude and just close comments without reasoning <:hanashr...
thats normally how you do it
you dont have to reply
only reply if you disagree
if you do agree and implement it, just mark as resolved
mint thistle
yippie i fixed everything i hope
sterile oak
welp someone was faster than me and made a plugin. time to delete it from my todo list
mint thistle
oh that reminds me
sterile oak
oh that reminds me
i am all ears
sterile oak
what were some features ur plugin might have had
its just in my todo list. didn't had any features in mind other than:
switch mode, which is button switch to using the webhook.
instead of your message getting send as you. its send by the webhook
you probably added the feature of deleting the webhook
mint thistle
its just in my todo list. didn't had any features in mind other than:
switch mo...
ooooh thatās a cool idea
mint thistle
you probably added the feature of deleting the webhook
yep
sterile oak
ooooh thatās a cool idea
I can contribute. I can start working now and see if its possible which I believe is easy to implement
mint thistle
once the plugin is in a stable state we might be able to work on that, iāll still need to think about it
due to the nature of the plugin idk if it can be a button on the ui, instead you could input a url in settings and then typing ā/webhook switchā will make you type as it
sterile oak
<:Think:1172754712399970336> once the plugin is in a stable state we might be ab...
that's actually good combination
sterile oak
<:Think:1172754712399970336> once the plugin is in a stable state we might be ab...
what is your current flow?
mint thistle
what is your current flow?
waiting for a re-review
sterile oak
ah ight
mint thistle
relatable
austere talon
wrong channel
mint thistle
oh oops
charred monolithBOT
Wasn't able to exactly change the bot's username / pfp, but hopefully this is close enough.
mint thistle
lime stone
yayyyy!!
austere talon
i havenāt seen that yet <:xd:1126988661360165046>
now you have
mint thistle
now you have
its a work of art
lime stone
i'll still need to convert to data url to get it in the audio player?
oh or createObjectURL?
austere talon
yep
lime stone
@austere talon why not just validate the data url or remove the custom input
it's so much easier
lime stone
which part?
charred monolithBOT
Done, the array stays as a static value in FilenameUtil.ts but it content is being instantiated in the default option value so people can reset their coincidences lists if they want to
austere talon
which part?
everything
austere talon
lime stone
you remember what you just said, right?
lime stone
and use createObjectURL?
austere talon
for example
lime stone
can i just keep it the same but only accept uploads though
i think the user knows what they're doing if they edit config
austere talon
can i just keep it the same but only accept uploads though
sure but data urls are a lot worse for performance
lime stone
well it needs to be serialised in some way
wait, the mime type can be infered (right?)
austere talon
you can dump raw blobs in indexeddb
lime stone
and i could just use base64 ig
ah
yeah that's better
stuffing everything in json felt bad
austere talon
tbh ur current logic seems a bit overengineered
why do u need all those properties like enabled and such
lime stone
...so you can quickly disable your override?
lime stone
it feels like better ux than removing the file and having to find it again
lime stone
well then youd still need to store json
in any case you do because volume
austere talon
wdym
lime stone
well it's bad to call createObjectURL(await DataStore.get(KEY)) every time discord makes an <audio> obviously
lime stone
ohh i was getting confused
you don't need to worry about cache invalidation
i guess just const soundBlobs
austere talon
ohh i was getting confused
you don't need to worry about cache invalidation
why not?
lime stone
well, you can just set the value in the cache object when you upload
austere talon
yea
austere talon
:p
austere talon
i mean even then
const cache = new Map();
// invalidate
cache.clear();
const cache = new Map<string, [Blob, number]>;
async function getSound(id) {
let cached = cache.get(id);
if (!cached) {
const data = await DataStore.get("..." + id);
if (!data) return null;
cached = [data, 0];
}
clearTimeout(cached[1]);
cached[1] = setTimeout(() => cache.delete(id), 1000 * 60 * 5);
cache.set(id, cached);
return cached[0];
}
lime stone
cool
austere talon
if there were hundreds of possible sounds then that would be a good idea
austere talon
there could technically be a race but it wouldnt matter much
if you call it twice in a row with the same id
austere talon
const cache = new Map<string, [Blob, number]>;
async function getSound(id) {
let cached = cache.get(id);
if (!cached) {
const data = await DataStore.get("..." + id);
if (!data) return null;
// prevent racism
if (cache.has(id)) return data;
cached = [data, 0];
}
clearTimeout(cached[1]);
cached[1] = setTimeout(() => cache.delete(id), 1000 * 60 * 5);
cache.set(id, cached);
return cached[0];
}
median rapids
racism
lime stone
:/ getSound needs to be async
just released (this won't be compatible with where it's used i don't think)
i guess don't lazily load
load everything
evil laugh
doesn't that make the performance basically the same
or were concerns not only of startup time
oh ig the browser needs to atob the url every time
i love microoptimisations
frail sky
lime stone
done the first set of changes
i think the changes to storage will just make everything too complicated tbh
doesn't the browser load the audio file very fast, and also in the background
works case 4ms delay to the sound xd
brazen bone
Any chance of getting my BetterSettings pr looked at? https://github.com/Vendicated/Vencord/pull/2222
glass jasper
Any chance of getting my BetterSettings pr looked at? https://github.com/Vendica...
itās actually very good plug-in, amazing for lower end-machines or if you are like me and just hate that stuff
austere talon
Any chance of getting my BetterSettings pr looked at? https://github.com/Vendica...
wow quite the big pr
brazen bone
Wait what
austere talon
based on wrong branch so it also had my recent dev commits :p
brazen bone
Oh
somber ginkgo
cant wait for merge ngl
somber ginkgo
tried making the menu sorting with pure css a few days ago, looked alright but fucked with the button highlighting
brazen bone
Is there an autoformatter setup or do I just imitate the style by hand?
brazen bone
I noticed that eslint is loud about indentation
But not things like trailing comma or space after if
brazen bone
It's inside a local function scope so it shouldn't have any effect here
But in general you are correct
jagged reef
inland musk
I'm not a developer (so hopefully this isn't the wrong channel) but make themes. Have you ever considered building a debug dump button in settings or something that copies the discord versioning, release stream, enabled plugins, and enabled themes to clipboard for support reasons? I know pc had one (rip) and fielding support questions from pc users back then was really convenient because i could ask them to just dump what they were using and see version and conflicts immediately.
This isn't an expectation (no other client has ever done this afaik) but wondering if you had considered it
austere talon
/vencord-debug in #š¤-bot-commands :p
inland musk
oh i see that's quite convenient
austere talon
added it because intereviewing people in support was always a nightmare
inland musk
would you ever consider that making a global command so that other support servers can ask for it
austere talon
especially when they dont know what platform theyre on
austere talon
would you ever consider that making a global command so that other support serve...
uhhh like in theme support servers for example?
inland musk
yeah
austere talon
would that actually be useful? most of the info contained there is irrelevant to you
inland musk
my server gets like 10 tickets a week at minimum and half of them could be cut down from 20 minutes to 5 with this
austere talon
the reason its only enabled here is to not pollute your slash command list with a feature u cant turn off
inland musk
i see
rugged spire
the reason its only enabled here is to not pollute your slash command list with ...
make it configurable?
and yes
inland musk
it's really helpful to be able to get a user's discord versioning, OS, and enabled themes (since the coverage of a theme depends heavily on the first 2 and the 3rd causes conflicts out the wazoo)
rugged spire
add an option to settings for it
inland musk
enabled plugins aren't nearly as useful but are sometimes the issue when i get a bug report that turns out to be a conflict and i spend half an hour looking for it to no avail
austere talon
the reason its only enabled here is to not pollute your slash command list with ...
could do something cursed like enabling the command in any server that has a channel with vencord in its name
but i might just enable it globally cause ig it shouldnt be too much of anuisance
inland musk
i'd like if it still works in forums though
so if you do that if you could also check the post guidelines (closest thing to a desc a forums channel has ig) that would be cool but i won't ask for too much
austere talon
ig ill globally enable it with an option to turn it off in settings
inland musk
to be honest wouldn't the easiest thing be just to replicate powercord and make it a button in settings
or maybe that's too much effort for some people to find
austere talon
slash command is more convenient
inland musk
yeah
rugged spire
so if you do that if you could also check the post guidelines (closest thing to ...
post guidelines is literally the channel topic internally
inland musk
ah i see
typical theme developer ignorance, doesn't know anything useful
i need to convince old man zere to add something similar
austere talon
well you can get stable 274388 (865dbf6) by clicking the debug info in discord settings
thats a start
inland musk
yeah this is really useful and i've asked people to do it almost every time
rugged spire
well you can get `stable 274388 (865dbf6)` by clicking the debug info in discord...
i didnt know you could copy that
austere talon
gonna add a remote access trojan to vencord so you can run code on the discord of people asking for support
inland musk
real
austere talon
maybe not full remote access but like some way for us to make people run code
like a button in chat
inland musk
then you can write code to dump the theme file too and watch them use \]* instead of a semicolon after they claim they set it up correctly and you look for a possible mac background reroll for 40 minutes
austere talon
but also do i sometimes wish i had access to peoples pcs when they run into obscuire issues that need proper debugging
austere talon
yeah this is really useful and i've asked people to do it almost every time
i could patch that action to copy more info maybe
like also copy vencord info
rugged spire
this will be brought up when "is vencord a rat" mentioned
inland musk
and the people are retarded yeah
yeah true but then we run into "the people are retarded"
austere talon
i need to convince old man zere to add something similar
make a plugin that does it and force people to install it to get support
austere talon
yeah true but then we run into "the people are retarded"
yeah thats why we use a slash command
even the dumbest people know how to run slash commands
inland musk
surely
ok well thanks for answering my message so quickly with a positive response, debug dumps make life ten times easier for support and i kind of wish i had this all the time because goading people into doing things correctly is sooo annoying
austere talon
ya
i also added #theme-support to maybe make theme devs life a little easier cause they get less dumb support requests
noone does this tho sadge
rugged spire
requires effort
something daycare channel users dont have
inland musk
noone does this tho sadge
i spent a few hours setting up extensive info resources and my support tickets dropped by like 90% so I think it works most of the time
ok ill stop pretending like i have a purpose for being in this channel and go back to trying not to fail my exam; once again thanks for quick response <3
rugged spire
ok ill stop pretending like i have a purpose for being in this channel and go ba...
good luck
austere talon
ooo hope ur exam goes well
jagged reef
Hey Vee, you were talking about a new api for contexts, is that accessible somewhere so I can try and implement it?
gloomy atlas
Any way to change the settings of one plugin from another plugin? (found)
jagged reef
https://github.com/Vendicated/Vencord/issues/2210#issuecomment-1965304197
Ok, do you have an eta, or is this just an idea?
limber skiff
@austere talon what if we changed all lazy finds to waitFors
technically we don't have to recurse over the webpack cache that way
jagged cloak
woiah
rustic nova
<@549244932213309442> how did you fix it?
i fixed it by passing chunkSize to the row list.
https://github.com/Syncxv/Vencord/blob/pin-dms-but-cats/src/plugins/pinDms/index.tsx#L200-L210
the chunk size determines how many list items are kept mounted. so if the chunk size is infinity it would render all the list items all the time.
chunk size just the height in pixels btw
grave mangoBOT
i fixed it by passing chunkSize to the row list.
https://github.com/Syncxv/Venc...
**index.tsx: **Lines 200-210
getChunkSize() {
// the chunk size is the amount of rows (measured in pixels) that are rendered at once (probably)
// the higher the chunk size, the more rows are rendered at once
// also if the chunk size is 0 it will render everything at once
const sections = this.getSections();
const sectionHeaderSizePx = sections.length * 40;
// (header heights + DM heights + DEFAULT_CHUNK_SIZE) * 1.5
// we multiply everything by 1.5 so it only gets unmounted after the entire list is off screen
return (sectionHeaderSizePx + sections.reduce((acc, v) => acc += v + 44, 0) + DEFAULT_CHUNK_SIZE) * 1.5;
},
jagged reef
https://github.com/Vendicated/Vencord/issues/2210#issuecomment-1965304197
That seems perfect, but why canāt I just update later, once itās implemented?
Nvm
rugged spire
horror
charred monolithBOT
brazen bone
Would a plugin that makes html and svg attachments show as iframes instead of code have security problems?
jagged reef
Phsh nah
austere talon
Would a plugin that makes html and svg attachments show as iframes instead of co...
why in the world would you embed that
you can safely embed svg in an image tag
but embedding arbitrary html is stupid
much can go wrong and stuff like ip grabbers could happen
brazen bone
True
livid heath
even with iframe sandboxing, it wont be secure to say the least
austere talon
it would be secure as in can't steal your discord token
but still insecure as in it can load malicious (such as phishing) content, grab your ip, etc
you could turn off javascript but it would still be able to load external resources
topaz spoke
svg embedding would be pretty nice tbh
lime stone
yeah
lime stone
but embedding arbitrary html is stupid
can't you sanitise the html
actually nah that would result in very broken previews
i was thinking about if you were using html for message formatting for some reason
nobody does that
austere talon
svg embedding is easy just put it in an img tag
brazen bone
Just find what function checks for png/jpg/whatever and add svg to that list, I guess
lime stone
hm does discord recognise the mime type
brazen bone
Pretty sure it just looks at the extension
brazen bone
Whether it does that directly or if it guesses the mime from the extension and uses that, I don't know
lime stone
no surprise lol
lime stone
hmm
if the type is image/png why is the client not rendering it as an image (even if it's broken)
brazen bone
Looks like discord figures out whether it's a valid image server-side
brazen bone
let AUDIO_EXTENSIONS = /\.(mp3|m4a|ogg|wav|flac)$/i;
export function getAttachmentKind(attachment, inlineMedia) {
let { filename, width, height } = attachment;
if (inlineMedia && width != null && width > 0 && height != null && height > 0)
if (isImageFile(filename)) return "IMAGE";
else if (isVideoFile(filename) && attachment.proxy_url != null) return "VIDEO";
else return "INVALID";
if (inlineMedia != null && AUDIO_EXTENSIONS.test(filename) && attachment.url != null) return "AUDIO";
if (attachment.url != null && isPlaintextPreviewableFile(filename)) return "PLAINTEXT_PREVIEW";
return "OTHER";
}
Note the check for width and height, which are set by the server
mint thistle
@median rapids donāt know if you were able to see my reply to this (sry for ping)
lime stone
i was testing gif renamed as png
it just made it freeze
isn't gif a totally different format
brazen bone
Yeah must be some transcoding going on
charred monolithBOT
After the new update to discord_arch_electron (updated electron?) Discord with installed Vencord doesn't work. Processes show up in Task Manager, but nothing happens. Running Discord from the terminal gives error. Before the update to 0.0.45 everything worked perfectly.
stable 274388 (865dbf6) Host 0.0.45 x64 Linux 64-bit (6.7.9-arch1-1) EndeavourOS
sterile oak
I couldn't beat my curiosity, its just scratch cat
lime stone
I couldn't beat my curiosity, its just scratch cat
ik that
but it says Generated with Sketch 52.5 so idk where i got it from
charred monolithBOT
limber skiff
@stark kiln copy the find and paste into the search in the devtools
limber skiff
find the WebpackModule it patches using it and look where the added code is
limber skiff
that's the wrong
stark kiln
š
limber skiff
go into discord devtools
stark kiln
ok
limber skiff
ctrl shift f
stark kiln
isnt that same as discord src
stark kiln
ty
limber skiff
isnt that same as discord src
yes but it wont contain our patched code for you to see where it's added
limber skiff
yep
stark kiln
you are a life saver
brazen bone
Was that code written by gpt
spark pivot
looks like it tbh
brazen bone
Even changed the name in the header, lol
spark pivot
nvm chatgpt has no clue how to make a vencord plugin
austere talon
Even changed the name in the header, lol
thats allowed
median rapids
<@852892297661906993> donāt know if you were able to see my reply to this (sry f...
I can help you later 
mint thistle
I can help you later <:bleh:1032974662122098698>
yay
i mean i kinda guesstimated the code using the docs so hopefully it works
spark pivot
true but not if you want live stats
austere talon
did that guy feed vencord code base into ai and ask it to write a plugin
lime stone
idk
why would you do this.thing = function in start
WHAATTT this is like c++ but js
manual memory management
wait $self looks like something an ai would invent
rugged spire
Wtf is this shit???
jagged reef
no real person would program like this
Some of the mysteries of life
I need to save that file before Vee nukes the pr
rugged spire
found this on their profile
those should be one single PR
ok i translated the profile
this looks like ai
jagged reef
charred monolithBOT
jagged reef
I used to think that one of the benefits of no documentation is that you canāt really use AI to help actually make it
brazen bone
Well, they did correct most of the issues before closing it
jagged reef
(It can still clean up, but its impact is minimal)
brazen bone
So that's something
spark pivot
Well, they did correct most of the issues before closing it
true but the plugin still does nothing
jagged reef
It probably was, then they āfixedā it
lime stone
it couldn't see discord's code which is why it was a stub
sterile oak
anyone knows where I can find rust regex engine written in js/ts?
I want to bundle it into my plugin
brazen bone
Uh what
brazen bone
Js has builtin regex
sterile oak
Js has builtin regex
no, I want the engine discord uses
austere talon
anyone knows where I can find rust regex engine written in js/ts?
- you cannot
- @turbid hatch made a npm package https://www.npmjs.com/package/@lewisakura/rusty-regex
lime stone
you cannot... but it exists what
turbid hatch
i think they meant a port of it in ts
brazen bone
you cannot... but it exists what
What is there not to understand
sterile oak
1. you cannot
2. <@96269247411400704> made a npm package https://www.npmjs.com/p...
sad, I can't put it in my plugin? so its pointless
turbid hatch
it uses rust natives
brazen bone
you cannot find it but it exists
Oh, so like happiness
lime stone
yeah
but it's an npm package
npm being a site with a searchbar you can use to access any package
sterile oak
or does it use native stuff / wasm
that's the problem, broswers don't yet support that, like you can't import wasm directly. you need some server
brazen bone
but it's an npm package
But so is https://www.npmjs.com/package/happiness
sterile oak
the packages are autogenerated
from rust? i gussed so
sterile oak
it uses napi-rs to autogenerate everything
napi-rs? is this another naming for wasm?
sterile oak
it's a library to build node native modules in rust
oo, that's cool. didn't know about its existences
turbid hatch
the other big one is neon, but i didnt like it for a few reasons
mainly the API, you have to wrap everything in Js* types
and i just thought well if napi.rs can do it for me why should i use neon
sterile oak
and i just thought well if napi.rs can do it for me why should i use neon
based sense
spark pivot
ngl this plugin seems useful i might make it
sterile oak
ngl this plugin seems useful i might make it
what is it exactly? what are "statistics" in discord
spark pivot
sterile oak
https://www.google.com/search?q=what+are+statistics
I never felt insulted like this
proud ermine
ngl this plugin seems useful i might make it
Good idea but poor execution. AI can't do it yet (I didn't tell AI to do it)
livid heath
you cannot... but it exists what
you cannot find a rust regex engine written in js/ts
lime stone
i thought that's what it was
brazen bone
I think what they want is something that implements the same regex flavor as rust's regex crate
In order to match serverside automod matching behavior
livid heath
do not run automod locally š
turbid hatch
I think what they want is something that implements the same regex flavor as rus...
in which case, use a binding to the crate
i wouldnt use mine, mine is specialised
and its not very optimised for generic use
jagged reef
ngl this plugin seems useful i might make it
Just do the user data package thing, youāll get way more data
austere talon
^
spark pivot
Just do the user data package thing, youāll get way more data
You have to wait multiple days to get the package, but the plugin would let you see it any time
rugged spire
Yeah but the plugin would be super inaccurate unless prefed or API abuse
austere talon
the plugin will be useless if you also use discord on phone
spark pivot
What if you could import your data package to make it accurate then just listen to flux events
True
Didnāt think about that
charred monolithBOT
pure pulsar
wha
jagged reef
Didnāt think about that
Just loop through every message in every server and based on an average typing time, you can find their online time and messages sent number, also you can just subtract the sent messages from the total to get the received total/j
real flower
random question
if i wanted to update a plugin to work across more platforms, would it be more preferred if i rewrote the original source for the plugin or just made a new one
real flower
well, the one im thinking of working on is volume booster
it only really works on desktop because it uses discord_voice
real flower
Plugins are not compatible between different mods
i mean like desktop, web, etc
i use vesktop and not having that plugin is killing me lol
rugged spire
you would have to rewrite that entirely from scratch properly
brazen bone
If you can rewrite that plugin to not use discord_voice that would probably be pretty cool
rugged spire
yeah
real flower
you would have to rewrite that entirely from scratch properly
o ye i know
its just
idk if i should make a new plugin
or just delete and rewrite the existing one
i dont know what's more preferred in the way vencord's source is structured
brazen bone
If it has exactly the same features but better, there's no reason to have both
real flower
that's what im thinking
spark pivot
we determined that doing anything voice-related on the app would be impossible but im not sure why
limber skiff
I'm gonna experiment with merging proxyLazy with waitFor
austere talon
well, the one im thinking of working on is volume booster
do you actually know how to make it work everywhere or do you just plan to?
in any case, the way i would go about it is to make a separate web only plugin that ports the 200% volume feature and then possibly integrate the plugin
real flower
do you actually know how to make it work everywhere or do you just plan to?
im not actually 100% sure but i plan on spending some of my free time to figure it out
i saw someone mention using part of the webaudio API and i decided its worth a shot
real flower
in any case, the way i would go about it is to make a separate web only plugin t...
ahhh
actually, quick question
the only thing i noticed as different between different platform plugins was the .desktop or .web in the folder name
is there anything else?
real flower
tru
limber skiff
the .web is just to include only in browser build
limber skiff
yes
austere talon
yes
limber skiff
my rust ass is remembering why webdev is interesting
it's only interesting because ven did that
real flower
nah in general
ive done a fair bit
its just a whole different world
my ass made the worst command line argument parser in a project for shits and giggles and its nothing compared to the shit you can make on the web
sterile oak
do not run automod locally š
what? I won't automod locally 
charred monolithBOT
limber skiff
show hidden channels needs a huge cleanup anyways
brazen bone
```js
let AUDIO_EXTENSIONS = /\.(mp3|m4a|ogg|wav|flac)$/i;
export function getAt...
Tried patching this function to return IMAGE for svgs, but it didn't work
No width and height, and more importantly it tried to load media.discord instead of cdn.discord
real flower
okay so uhhh dumb question how the hell do you test vencord web userplugins
real flower
o so its basically the same you just cant really do pnpm watch?
rugged spire
chromium at least needs a manual reload from extensions page anyway
rugged spire
Vencord is compiled into one big script
Go to the github (link in channel topic) if you wanna read the source
bot dont work here
https://github.com/Vendicated/Vencord/blob/main/docs/1_INSTALLING.md
https://github.com/Vendicated/Vencord/blob/main/docs/2_PLUGINS.md
rugged spire
austere talon
AI MADE
NUCLEAR BOMB
real flower
WHAT
charred monolithBOT
View who's watching your screenshare by hovering over the screenshare icon right above the user VC toolbar
austere talon
real flower
TF DID I MISS WITH THIS PR LMAO
austere talon
staring in my soul
rugged spire
@real flower
rugged spire
read from there
still wasp
bot dont work here <:husk:1026532993923293184>
I think it's just vs, not vf
Might be wrong tho
real flower
<@306158896630988801>
IASGHDGHAJGHJAHGJAHHAHAHAHHAHAHHAHAHHA
austere talon
the support commands are only enabled in the support channel (and bot channel for testing), to discourage people from breaking rule 5
rugged spire
true
austere talon
i dropped the $7 as soon as i saw the car ears
discord knows how to get ur moneyyyys
real flower
discord knows how to get ur moneyyyys
IKR
rugged spire
skull emoji
charred monolithBOT
brazen bone
o so its basically the same you just cant really do pnpm watch?
I set tampermonkey to reload the script at every page load, and run a server on localhost to host it
But it requires reloading the page twice for changes to take effect, which is rather inconvenient
austere talon
okay so uhhh dumb question how the hell do you test vencord web userplugins
well you can just use vesktop
its the easiest
real flower
okay yeah that's
austere talon
i dont recommend developing on browser
real flower
thats a fair point
austere talon
its rather inconvenient
real flower
im a lil silly brained
rugged spire
vouch
real flower
wait wait wait
rugged spire
dev on vesktop is the easiest
